commit 0cedc054a23e4c43c96af7f72a7861e091385f82
author Rasmus Brandt <brandtr@webrtc.org> Thu May 31 12:53:00 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Thu May 31 11:48:17 2018 +0000
tree 72b32614f66556fdd1ac5dbb57d962f30e6952ce
parent 29921cf0976c7eb289c1c26bde1481c7395cc963

Refactor SimulcastTestUtility into SimulcastTestFixture{,Impl}

This will allow exposing the interface to downstream users that
want to test VP8 simulcast. No functional changes to the tests
themselves are expected.

Bug: webrtc:9281
Change-Id: I4128b8f35a4412c5b330cf55c8dc0e173d4570da
Reviewed-on: https://webrtc-review.googlesource.com/77361
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23469}

modules/video_coding/BUILD.gn

diff --git a/modules/video_coding/BUILD.gn b/modules/video_coding/BUILD.gn
index 5e5e8c3..875c46f 100644
--- a/modules/video_coding/BUILD.gn
+++ b/modules/video_coding/BUILD.gn
@@ -549,10 +549,11 @@
     }
   }
 
-  rtc_source_set("simulcast_test_utility") {
+  rtc_source_set("simulcast_test_fixture_impl") {
     testonly = true
     sources = [
-      "codecs/vp8/simulcast_test_utility.h",
+      "codecs/vp8/simulcast_test_fixture_impl.cc",
+      "codecs/vp8/simulcast_test_fixture_impl.h",
     ]
 
     if (!build_with_chromium && is_clang) {
@@ -565,8 +566,11 @@
       ":video_codec_interface",
       ":video_coding",
       ":webrtc_vp8_helpers",
+      "../../:webrtc_common",
+      "../../api:simulcast_test_fixture_api",
       "../../api/video:video_frame",
       "../../api/video:video_frame_i420",
+      "../../api/video_codecs:video_codecs_api",
       "../../common_video:common_video",
       "../../rtc_base:checks",
       "../../rtc_base:rtc_base_approved",
@@ -767,8 +771,8 @@
       "codecs/test/videocodec_test_stats_impl_unittest.cc",
       "codecs/test/videoprocessor_unittest.cc",
       "codecs/vp8/default_temporal_layers_unittest.cc",
+      "codecs/vp8/libvpx_vp8_simulcast_test.cc",
       "codecs/vp8/screenshare_layers_unittest.cc",
-      "codecs/vp8/simulcast_unittest.cc",
       "codecs/vp9/svc_config_unittest.cc",
       "codecs/vp9/svc_rate_allocator_unittest.cc",
       "decoding_state_unittest.cc",
@@ -809,7 +813,6 @@
       ":codec_globals_headers",
       ":encoded_frame",
       ":mock_headers",
-      ":simulcast_test_utility",
       ":video_codec_interface",
       ":video_codecs_test_framework",
       ":video_coding",
@@ -823,6 +826,8 @@
       "..:module_api",
       "../..:webrtc_common",
       "../../:typedefs",
+      "../../api:create_simulcast_test_fixture_api",
+      "../../api:simulcast_test_fixture_api",
       "../../api:videocodec_test_fixture_api",
       "../../api/video:video_frame",
       "../../api/video:video_frame_i420",
@@ -842,6 +847,7 @@
       "../../system_wrappers:metrics_default",
       "../../test:field_trial",
       "../../test:fileutils",
+      "../../test:test_common",
       "../../test:test_support",
       "../../test:video_test_common",
       "../../test:video_test_support",