commit 0aefbf0ec47c018bf2a4cd520c93f72908af2b56
author Per Åhgren <peah@webrtc.org> Fri Aug 23 21:29:17 2019 +0200
committer Commit Bot <commit-bot@chromium.org> Fri Aug 23 20:04:10 2019 +0000
tree 2258f6f885a2a80b573fea585d4abab7d5a1c263
parent c8626b6072598829e98bf65bc508359b3f8bb9ca

Use the AEC3 high-pass filter for the whole APM

This CL removes and replaces the legacy fixed-point high-pass filter in
APM with the floating point high-pass filter in AEC3.

Bug: webrtc:10907
Change-Id: I88cf8f622ab139e4ffa97f89a72425aa3becfc58
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150103
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28950}

modules/audio_processing/audio_processing_impl_unittest.cc

diff --git a/modules/audio_processing/audio_processing_impl_unittest.cc b/modules/audio_processing/audio_processing_impl_unittest.cc
index f6953ab..72bd673 100644
--- a/modules/audio_processing/audio_processing_impl_unittest.cc
+++ b/modules/audio_processing/audio_processing_impl_unittest.cc
@@ -239,13 +239,13 @@
 
   MockEchoControl* echo_control_mock = echo_control_factory_ptr->GetNext();
 
-  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(NotNull())).Times(1);
+  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(testing::_)).Times(1);
   EXPECT_CALL(*echo_control_mock,
               ProcessCapture(NotNull(), /*echo_path_change=*/false))
       .Times(1);
   apm->ProcessStream(&frame);
 
-  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(NotNull())).Times(1);
+  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(testing::_)).Times(1);
   EXPECT_CALL(*echo_control_mock,
               ProcessCapture(NotNull(), /*echo_path_change=*/true))
       .Times(1);
@@ -282,7 +282,7 @@
   MockEchoControl* echo_control_mock = echo_control_factory_ptr->GetNext();
 
   const int initial_analog_gain = apm->gain_control()->stream_analog_level();
-  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(NotNull())).Times(1);
+  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(testing::_)).Times(1);
   EXPECT_CALL(*echo_control_mock, ProcessCapture(NotNull(), false)).Times(1);
   apm->ProcessStream(&frame);
 
@@ -291,7 +291,7 @@
     apm->gain_control()->set_stream_analog_level(initial_analog_gain + 1);
   }
 
-  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(NotNull())).Times(1);
+  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(testing::_)).Times(1);
   EXPECT_CALL(*echo_control_mock, ProcessCapture(NotNull(), true)).Times(1);
   apm->ProcessStream(&frame);
 }
@@ -318,13 +318,13 @@
 
   MockEchoControl* echo_control_mock = echo_control_factory_ptr->GetNext();
 
-  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(NotNull())).Times(1);
+  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(testing::_)).Times(1);
   EXPECT_CALL(*echo_control_mock,
               ProcessCapture(NotNull(), /*echo_path_change=*/false))
       .Times(1);
   apm->ProcessStream(&frame);
 
-  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(NotNull())).Times(1);
+  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(testing::_)).Times(1);
   EXPECT_CALL(*echo_control_mock,
               ProcessCapture(NotNull(), /*echo_path_change=*/false))
       .Times(1);
@@ -332,7 +332,7 @@
       AudioProcessing::RuntimeSetting::CreatePlayoutVolumeChange(50));
   apm->ProcessStream(&frame);
 
-  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(NotNull())).Times(1);
+  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(testing::_)).Times(1);
   EXPECT_CALL(*echo_control_mock,
               ProcessCapture(NotNull(), /*echo_path_change=*/false))
       .Times(1);
@@ -340,7 +340,7 @@
       AudioProcessing::RuntimeSetting::CreatePlayoutVolumeChange(50));
   apm->ProcessStream(&frame);
 
-  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(NotNull())).Times(1);
+  EXPECT_CALL(*echo_control_mock, AnalyzeCapture(testing::_)).Times(1);
   EXPECT_CALL(*echo_control_mock,
               ProcessCapture(NotNull(), /*echo_path_change=*/true))
       .Times(1);