commit 039743e06680e82bbd7af7f8c35cc91e39453582
author Niels Möller <nisse@webrtc.org> Tue Oct 23 10:07:25 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Thu Oct 25 14:13:44 2018 +0000
tree 726ee175fdef305ca8d0f12bf1a18ab132ffa229
parent e2754c95c5097c5249fe4bb37d63b96ca770fb72

Reland "Delete CodecNamesEq, replaced with absl::EqualsIgnoreCase"

This is a reland of 80cd25bcfb2264fa0f1192de942a6f063879dd42

Original change's description:
> Delete CodecNamesEq, replaced with absl::EqualsIgnoreCase
>
> Bug: None
> Change-Id: I225fe1e16a3c96e5a03e3ae8fe975f368be7e6ad
> Reviewed-on: https://webrtc-review.googlesource.com/c/107303
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#25312}

Tbr: kwiberg@webrtc.org
Bug: None
Change-Id: Id43a93bada9d6d66a4d0f0286f583066156aa2fc
Reviewed-on: https://webrtc-review.googlesource.com/c/107716
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25368}

api/video_codecs/BUILD.gn

diff --git a/api/video_codecs/BUILD.gn b/api/video_codecs/BUILD.gn
index 129336b..916e7da 100644
--- a/api/video_codecs/BUILD.gn
+++ b/api/video_codecs/BUILD.gn
@@ -82,6 +82,7 @@
     "../../rtc_base:ptr_util",
     "../../rtc_base/system:rtc_export",
     "//third_party/abseil-cpp/absl/memory",
+    "//third_party/abseil-cpp/absl/strings",
   ]
 }
 

api/video_codecs/builtin_video_encoder_factory.cc

diff --git a/api/video_codecs/builtin_video_encoder_factory.cc b/api/video_codecs/builtin_video_encoder_factory.cc
index ca389b9..1d0827c 100644
--- a/api/video_codecs/builtin_video_encoder_factory.cc
+++ b/api/video_codecs/builtin_video_encoder_factory.cc
@@ -13,6 +13,7 @@
 #include <vector>
 
 #include "absl/memory/memory.h"
+#include "absl/strings/match.h"
 #include "api/video_codecs/sdp_video_format.h"
 #include "media/base/codec.h"
 #include "media/base/mediaconstants.h"
@@ -59,7 +60,7 @@
     if (IsFormatSupported(internal_encoder_factory_->GetSupportedFormats(),
                           format)) {
       internal_encoder =
-          cricket::CodecNamesEq(format.name.c_str(), cricket::kVp8CodecName)
+          absl::EqualsIgnoreCase(format.name, cricket::kVp8CodecName)
               ? absl::make_unique<VP8EncoderSimulcastProxy>(
                     internal_encoder_factory_.get(), format)
               : internal_encoder_factory_->CreateVideoEncoder(format);

api/video_codecs/video_codec.cc

diff --git a/api/video_codecs/video_codec.cc b/api/video_codecs/video_codec.cc
index ea8dfa7..0819c82 100644
--- a/api/video_codecs/video_codec.cc
+++ b/api/video_codecs/video_codec.cc
@@ -115,11 +115,6 @@
 static const char* kPayloadNameGeneric = "Generic";
 static const char* kPayloadNameMultiplex = "Multiplex";
 
-// TODO(nisse): Delete this wrapper.
-static bool CodecNamesEq(const char* name1, const char* name2) {
-  return absl::EqualsIgnoreCase(name1, name2);
-}
-
 const char* CodecTypeToPayloadString(VideoCodecType type) {
   switch (type) {
     case kVideoCodecVP8:
@@ -137,15 +132,15 @@
 }
 
 VideoCodecType PayloadStringToCodecType(const std::string& name) {
-  if (CodecNamesEq(name.c_str(), kPayloadNameVp8))
+  if (absl::EqualsIgnoreCase(name, kPayloadNameVp8))
     return kVideoCodecVP8;
-  if (CodecNamesEq(name.c_str(), kPayloadNameVp9))
+  if (absl::EqualsIgnoreCase(name, kPayloadNameVp9))
     return kVideoCodecVP9;
-  if (CodecNamesEq(name.c_str(), kPayloadNameH264))
+  if (absl::EqualsIgnoreCase(name, kPayloadNameH264))
     return kVideoCodecH264;
-  if (CodecNamesEq(name.c_str(), kPayloadNameI420))
+  if (absl::EqualsIgnoreCase(name, kPayloadNameI420))
     return kVideoCodecI420;
-  if (CodecNamesEq(name.c_str(), kPayloadNameMultiplex))
+  if (absl::EqualsIgnoreCase(name, kPayloadNameMultiplex))
     return kVideoCodecMultiplex;
   return kVideoCodecGeneric;
 }