| commit | e506d56f8c1e8ebfd69dbb783fbe131724b866e3 | [log] [tgz] |
|---|---|---|
| author | Tom Sepez <tsepez@chromium.org> | Mon Jan 24 20:52:53 2022 +0000 |
| committer | Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jan 24 20:52:53 2022 +0000 |
| tree | 099fb6a2d838eeb13191467d3d7abfe9638461ae | |
| parent | 7c899da9d900cfa4d7b085925313589590920db6 [diff] [blame] |
Call v8::V8::Dispose() as part of termination. This step has always been missing from the pdfium test infrastructure but was only recently flagged by an update to V8. This will be needed to roll past V8 version 518d217a0e. Bug: chromium:1290159 Change-Id: I3a93c998614bd8c8381a101ac53ae77eff7f0867 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/89770 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
diff --git a/testing/v8_initializer.cpp b/testing/v8_initializer.cpp index e2fdfc5..9b295d0 100644 --- a/testing/v8_initializer.cpp +++ b/testing/v8_initializer.cpp
@@ -112,5 +112,6 @@ #ifdef PDF_ENABLE_XFA cppgc::ShutdownProcess(); #endif + v8::V8::Dispose(); v8::V8::DisposePlatform(); }