commit f46c0a6bda52678b6712e1e8cf99c94e9852041c
author Jordan Bayles <jophba@chromium.org> Fri Sep 20 11:37:42 2019 -0700
committer Commit Bot <commit-bot@chromium.org> Wed Sep 25 16:38:25 2019 +0000
tree 2517101dba14b928153e63b5a5221ad8faa78811
parent c05ada2d30d52623ba90d2450405e992f9b1140c

Add simple reading to TlsConnection

This patch implements a ReceiveMessage method for TlsConnectionPosix,
that simply checks if bytes are pending and then reads them if so,
reporting any errors that occur.

Change-Id: If9c453cd466c235c502ed16deedac3b7538a6a46
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1816287
Reviewed-by: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Jordan Bayles <jophba@chromium.org>

platform/api/tls_connection.cc

diff --git a/platform/api/tls_connection.cc b/platform/api/tls_connection.cc
index 0696e4f..ee0258c 100644
--- a/platform/api/tls_connection.cc
+++ b/platform/api/tls_connection.cc
@@ -42,14 +42,14 @@
   });
 }
 
-void TlsConnection::OnRead(std::vector<uint8_t> message) {
+void TlsConnection::OnRead(std::vector<uint8_t> block) {
   if (!client_) {
     return;
   }
 
-  task_runner_->PostTask([m = std::move(message), this]() mutable {
+  task_runner_->PostTask([b = std::move(block), this]() mutable {
     // TODO(issues/71): |this| may be invalid at this point.
-    this->client_->OnRead(this, std::move(m));
+    this->client_->OnRead(this, std::move(b));
   });
 }
 

platform/api/tls_connection.h

diff --git a/platform/api/tls_connection.h b/platform/api/tls_connection.h
index 1126265..de7faff 100644
--- a/platform/api/tls_connection.h
+++ b/platform/api/tls_connection.h
@@ -33,11 +33,11 @@
     virtual void OnWriteUnblocked(TlsConnection* connection) = 0;
 
     // Called when |connection| experiences an error, such as a read error.
-    virtual void OnError(TlsConnection* socket, Error error) = 0;
+    virtual void OnError(TlsConnection* connection, Error error) = 0;
 
-    // Called when a |packet| arrives on |socket|.
-    virtual void OnRead(TlsConnection* socket,
-                        std::vector<uint8_t> message) = 0;
+    // Called when a |block| arrives on |connection|.
+    virtual void OnRead(TlsConnection* connection,
+                        std::vector<uint8_t> block) = 0;
 
    protected:
     virtual ~Client() = default;