commit b0b5891ddfacb9033d24b18e7495f5f0b664c863
author mark a. foltz <mfoltz@chromium.org> Thu Jul 09 11:48:23 2020 -0700
committer Commit Bot <commit-bot@chromium.org> Fri Jul 10 17:11:13 2020 +0000
tree 2271e0532225360f7d3bbcb7775422027cc926b0
parent 09cdba8cd4a66eb6bf8f9b7123f2b4be8b327cd8

[Open Screen] Fix/remove some TODOs in util/

- Replace OSP_LOG with OSP_LOG_INFO
- Remove TODO in scoped_trace_operations_unittest.cc
- Update TODO in yet_another_bit_vector.cc

Bug: openscreen:52
Change-Id: I6584413aeb0d20dc09a91f7744092d3963d62224
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2063423
Reviewed-by: Ryan Keane <rwkeane@google.com>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>

platform/impl/logging_posix.cc

diff --git a/platform/impl/logging_posix.cc b/platform/impl/logging_posix.cc
index 412876c..2041077 100644
--- a/platform/impl/logging_posix.cc
+++ b/platform/impl/logging_posix.cc
@@ -52,7 +52,7 @@
     g_log_fd = STDERR_FILENO;
   }
 
-  // Note: The use of OSP_CHECK/OSP_LOG here will log to stderr.
+  // Note: The use of OSP_CHECK/OSP_LOG_* here will log to stderr.
   struct stat st = {};
   int open_result = -1;
   if (stat(filename, &st) == -1 && errno == ENOENT) {

platform/impl/text_trace_logging_platform.cc

diff --git a/platform/impl/text_trace_logging_platform.cc b/platform/impl/text_trace_logging_platform.cc
index e650fa1..3e0b529 100644
--- a/platform/impl/text_trace_logging_platform.cc
+++ b/platform/impl/text_trace_logging_platform.cc
@@ -41,7 +41,7 @@
      << ids.current << "] (" << std::dec << total_runtime << microseconds_symbol
      << ") " << name << "<" << file << ":" << line << "> " << error;
 
-  OSP_LOG << ss.str();
+  OSP_LOG_INFO << ss.str();
 }
 
 void TextTraceLoggingPlatform::LogAsyncStart(const char* name,
@@ -54,7 +54,7 @@
      << ":" << ids.current << std::dec << "] (" << timestamp << ") " << name
      << "<" << file << ":" << line << ">";
 
-  OSP_LOG << ss.str();
+  OSP_LOG_INFO << ss.str();
 }
 
 void TextTraceLoggingPlatform::LogAsyncEnd(const uint32_t line,
@@ -62,8 +62,8 @@
                                            Clock::time_point timestamp,
                                            TraceId trace_id,
                                            Error::Code error) {
-  OSP_LOG << "ASYNC TRACE END [" << std::hex << trace_id << std::dec << "] ("
-          << timestamp << ") " << error;
+  OSP_LOG_INFO << "ASYNC TRACE END [" << std::hex << trace_id << std::dec
+               << "] (" << timestamp << ") " << error;
 }
 
 }  // namespace openscreen