arm, ppc, mips32: fix fallocate and add tests
Previously, offset and length were truncated to 32-bits.
Change-Id: I5456a33921ee05f761945da225db0dabd7c12222
Reviewed-on: https://chromium-review.googlesource.com/c/linux-syscall-support/+/1953468
Reviewed-by: Mike Frysinger <vapier@chromium.org>
diff --git a/linux_syscall_support.h b/linux_syscall_support.h
index 8e0cc38..a71bea8 100644
--- a/linux_syscall_support.h
+++ b/linux_syscall_support.h
@@ -3630,7 +3630,10 @@
LSS_BODY(4, int, fallocate, LSS_SYSCALL_ARG(f), LSS_SYSCALL_ARG(mode),
(uint64_t)(offset), (uint64_t)(len));
}
- #elif defined(__i386__) || (defined(__s390__) && !defined(__s390x__))
+ #elif (defined(__i386__) || (defined(__s390__) && !defined(__s390x__)) \
+ || defined(__ARM_ARCH_3__) || defined(__ARM_EABI__) \
+ || (defined(__mips__) && _MIPS_SIM == _MIPS_SIM_ABI32) \
+ || defined(__PPC__))
#define __NR__fallocate __NR_fallocate
LSS_INLINE _syscall6(int, _fallocate, int, fd,
int, mode,
diff --git a/tests/Makefile b/tests/Makefile
index 2ea4b0d..5e37345 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -40,6 +40,7 @@
LDFLAGS += -static
TESTS = \
+ fallocate \
sigtimedwait \
unlink \
diff --git a/tests/fallocate.c b/tests/fallocate.c
new file mode 100644
index 0000000..c156e58
--- /dev/null
+++ b/tests/fallocate.c
@@ -0,0 +1,67 @@
+/* Copyright 2019, Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "test_skel.h"
+
+int main(int argc, char *argv[]) {
+ int fd = 0, mode = 0;
+ loff_t offset = 0, len = 0;
+
+ // Bad file descriptor.
+ fd = -1;
+ assert(sys_fallocate(fd, mode, offset, len) == -1);
+ assert(errno == EBADF);
+
+ char filename[] = "tempfile.XXXXXX";
+ fd = mkstemp(filename);
+ assert(fd >= 0);
+
+ // Invalid len.
+ assert(sys_fallocate(fd, mode, offset, len) == -1);
+ assert(errno == EINVAL);
+
+ // Small offset and length succeeds.
+ len = 4096;
+ assert(sys_fallocate(fd, mode, offset, len) == 0);
+
+ // Large offset succeeds and isn't truncated.
+ offset = 1llu + UINT32_MAX;
+ assert(sys_fallocate(fd, mode , offset, len) == 0);
+
+#if defined(__NR_fstat64)
+ struct kernel_stat64 st;
+ assert(sys_fstat64(fd, &st) == 0);
+#else
+ struct kernel_stat st;
+ assert(sys_fstat(fd, &st) == 0);
+#endif
+ assert(st.st_size == offset + len);
+
+ return 0;
+}