commit a404c6e2fc9d33f72919a780d6487ebe8fe57444
author Jonah Hooper <jonahhooper@google.com> Fri Dec 09 20:57:37 2022 +0000
committer Copybara-Service <copybara-worker@google.com> Fri Dec 09 12:58:21 2022 -0800
tree 69f75cdbd25a24116cab4217926b052cfc2c53a0
parent 9d811fce090e161a904e13212caa5ec8dde851aa

[swarming] Always set --cipd-cache to <botdir>/cipd_cache

`--cipd-cache` specifies where to install and cache `cipd`, `cas` and other `cipd` packages required for task. Before this change there were two possible ways `--cipd-cache` would be set in `run_isolated.py`.
1. set to `<root_dir>/cipd_cache` where `root_dir` is bot working directory iff there exists `cipd_input` in task_slice properties - in other words more packages to install.
2. set to a random directory temporary directory otherwise.

In (1.) the cache would not be deleted between runs. In (2.) it would be.

This CL does two things:
1. Never sets the `--cipd-cache` argument of `run_isolated.py` to a temp directory. This was causing issues with anti virus sometimes.
2. Do not delete `--cipd-cache` directory after each run of `run_isolated.py`. This was the behaviour before if no `cipd_input` was specified in the `task_slice` properties. It seems quite wasteful and different from the other case.

Bug: 1395532
Change-Id: I6abaea93457f7b1fb7aa0e7961f70727a8c11270
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/4087207
Auto-Submit: Jonah Hooper <jonahhooper@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Jonah Hooper <jonahhooper@google.com>
NOKEYCHECK=True
GitOrigin-RevId: db56c585d17a553147cebd68f59a1cd88889779b