| commit | 087aab7ca4d7037c2368f58ffc790d2c2eb4b84a | [log] [tgz] |
|---|---|---|
| author | Vadim Shtayura <vadimsh@chromium.org> | Fri Jan 13 00:38:11 2023 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jan 12 16:39:07 2023 -0800 |
| tree | 4e738c1d85bab33ccc1eed77cb4416c7b2a0537f | |
| parent | a404c6e2fc9d33f72919a780d6487ebe8fe57444 [diff] |
Revert "[swarming] Always set --cipd-cache to <botdir>/cipd_cache" This reverts commit db56c585d17a553147cebd68f59a1cd88889779b. Reason for revert: sets wrong CIPD_CACHE_DIR env var. Original change's description: > [swarming] Always set --cipd-cache to <botdir>/cipd_cache > > `--cipd-cache` specifies where to install and cache `cipd`, `cas` and other `cipd` packages required for task. Before this change there were two possible ways `--cipd-cache` would be set in `run_isolated.py`. > 1. set to `<root_dir>/cipd_cache` where `root_dir` is bot working directory iff there exists `cipd_input` in task_slice properties - in other words more packages to install. > 2. set to a random directory temporary directory otherwise. > > In (1.) the cache would not be deleted between runs. In (2.) it would be. > > This CL does two things: > 1. Never sets the `--cipd-cache` argument of `run_isolated.py` to a temp directory. This was causing issues with anti virus sometimes. > 2. Do not delete `--cipd-cache` directory after each run of `run_isolated.py`. This was the behaviour before if no `cipd_input` was specified in the `task_slice` properties. It seems quite wasteful and different from the other case. > > Bug: 1395532 > Change-Id: I6abaea93457f7b1fb7aa0e7961f70727a8c11270 > Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/4087207 > Auto-Submit: Jonah Hooper <jonahhooper@google.com> > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Commit-Queue: Jonah Hooper <jonahhooper@google.com> Bug: 1395532 Change-Id: I8b17b366b7c2568c874d96c5912ce2d81534dd05 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/4162393 Reviewed-by: Justin Luong <justinluong@google.com> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 49df67a36b6787d2c6a27e13e211628e9d9cfa34
This is the Python Client code for LUCI. It's part of the main python repo, and is also mirrored into a standalone client-py repo.
To contribute changes you need to clone the main python repo and then use git cl upload. The client-py repo mirror (which appears in Chromium's third_party directory) cannot be contributed to directly.
This project is licensed under Apache v2.0 license. See LICENSE for details.