Mike Frysinger | f601376 | 2019-06-13 02:30:51 -0400 | [diff] [blame] | 1 | # -*- coding:utf-8 -*- |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 2 | # |
| 3 | # Copyright (C) 2008 The Android Open Source Project |
| 4 | # |
| 5 | # Licensed under the Apache License, Version 2.0 (the "License"); |
| 6 | # you may not use this file except in compliance with the License. |
| 7 | # You may obtain a copy of the License at |
| 8 | # |
| 9 | # http://www.apache.org/licenses/LICENSE-2.0 |
| 10 | # |
| 11 | # Unless required by applicable law or agreed to in writing, software |
| 12 | # distributed under the License is distributed on an "AS IS" BASIS, |
| 13 | # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 14 | # See the License for the specific language governing permissions and |
| 15 | # limitations under the License. |
| 16 | |
Sarah Owens | cecd1d8 | 2012-11-01 22:59:27 -0700 | [diff] [blame] | 17 | from __future__ import print_function |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 18 | import itertools |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 19 | import os |
Conley Owens | db728cd | 2011-09-26 16:34:01 -0700 | [diff] [blame] | 20 | import re |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 21 | import sys |
David Pursehouse | 59bbb58 | 2013-05-17 10:49:33 +0900 | [diff] [blame] | 22 | import xml.dom.minidom |
| 23 | |
| 24 | from pyversion import is_python3 |
| 25 | if is_python3(): |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 26 | import urllib.parse |
David Pursehouse | 59bbb58 | 2013-05-17 10:49:33 +0900 | [diff] [blame] | 27 | else: |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 28 | import imp |
| 29 | import urlparse |
| 30 | urllib = imp.new_module('urllib') |
Chirayu Desai | db2ad9d | 2013-06-11 13:42:25 +0530 | [diff] [blame] | 31 | urllib.parse = urlparse |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 32 | |
Simran Basi | b9a1b73 | 2015-08-20 12:19:28 -0700 | [diff] [blame] | 33 | import gitc_utils |
David Pursehouse | e15c65a | 2012-08-22 10:46:11 +0900 | [diff] [blame] | 34 | from git_config import GitConfig |
David Pursehouse | e00aa6b | 2012-09-11 14:33:51 +0900 | [diff] [blame] | 35 | from git_refs import R_HEADS, HEAD |
Renaud Paquay | d5cec5e | 2016-11-01 11:24:03 -0700 | [diff] [blame] | 36 | import platform_utils |
David Pursehouse | e00aa6b | 2012-09-11 14:33:51 +0900 | [diff] [blame] | 37 | from project import RemoteSpec, Project, MetaProject |
Mike Frysinger | 04122b7 | 2019-07-31 23:32:58 -0400 | [diff] [blame] | 38 | from error import (ManifestParseError, ManifestInvalidPathError, |
| 39 | ManifestInvalidRevisionError) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 40 | |
| 41 | MANIFEST_FILE_NAME = 'manifest.xml' |
Shawn O. Pearce | 5cc6679 | 2008-10-23 16:19:27 -0700 | [diff] [blame] | 42 | LOCAL_MANIFEST_NAME = 'local_manifest.xml' |
David Pursehouse | 2d5a0df | 2012-11-13 02:50:36 +0900 | [diff] [blame] | 43 | LOCAL_MANIFESTS_DIR_NAME = 'local_manifests' |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 44 | |
Anthony King | cb07ba7 | 2015-03-28 23:26:04 +0000 | [diff] [blame] | 45 | # urljoin gets confused if the scheme is not known. |
Joe Kilner | 6e31079 | 2016-10-27 15:53:53 -0700 | [diff] [blame] | 46 | urllib.parse.uses_relative.extend([ |
| 47 | 'ssh', |
| 48 | 'git', |
| 49 | 'persistent-https', |
| 50 | 'sso', |
| 51 | 'rpc']) |
| 52 | urllib.parse.uses_netloc.extend([ |
| 53 | 'ssh', |
| 54 | 'git', |
| 55 | 'persistent-https', |
| 56 | 'sso', |
| 57 | 'rpc']) |
Conley Owens | db728cd | 2011-09-26 16:34:01 -0700 | [diff] [blame] | 58 | |
David Pursehouse | 819827a | 2020-02-12 15:20:19 +0900 | [diff] [blame] | 59 | |
Mike Frysinger | bb8ee7f | 2020-02-22 05:30:12 -0500 | [diff] [blame] | 60 | def XmlBool(node, attr, default=None): |
| 61 | """Determine boolean value of |node|'s |attr|. |
| 62 | |
| 63 | Invalid values will issue a non-fatal warning. |
| 64 | |
| 65 | Args: |
| 66 | node: XML node whose attributes we access. |
| 67 | attr: The attribute to access. |
| 68 | default: If the attribute is not set (value is empty), then use this. |
| 69 | |
| 70 | Returns: |
| 71 | True if the attribute is a valid string representing true. |
| 72 | False if the attribute is a valid string representing false. |
| 73 | |default| otherwise. |
| 74 | """ |
| 75 | value = node.getAttribute(attr) |
| 76 | s = value.lower() |
| 77 | if s == '': |
| 78 | return default |
| 79 | elif s in {'yes', 'true', '1'}: |
| 80 | return True |
| 81 | elif s in {'no', 'false', '0'}: |
| 82 | return False |
| 83 | else: |
| 84 | print('warning: manifest: %s="%s": ignoring invalid XML boolean' % |
| 85 | (attr, value), file=sys.stderr) |
| 86 | return default |
| 87 | |
| 88 | |
| 89 | def XmlInt(node, attr, default=None): |
| 90 | """Determine integer value of |node|'s |attr|. |
| 91 | |
| 92 | Args: |
| 93 | node: XML node whose attributes we access. |
| 94 | attr: The attribute to access. |
| 95 | default: If the attribute is not set (value is empty), then use this. |
| 96 | |
| 97 | Returns: |
| 98 | The number if the attribute is a valid number. |
| 99 | |
| 100 | Raises: |
| 101 | ManifestParseError: The number is invalid. |
| 102 | """ |
| 103 | value = node.getAttribute(attr) |
| 104 | if not value: |
| 105 | return default |
| 106 | |
| 107 | try: |
| 108 | return int(value) |
| 109 | except ValueError: |
| 110 | raise ManifestParseError('manifest: invalid %s="%s" integer' % |
| 111 | (attr, value)) |
| 112 | |
| 113 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 114 | class _Default(object): |
| 115 | """Project defaults within the manifest.""" |
| 116 | |
Shawn O. Pearce | 3c8dea1 | 2009-05-29 18:38:17 -0700 | [diff] [blame] | 117 | revisionExpr = None |
Conley Owens | b6a16e6 | 2013-09-25 15:06:09 -0700 | [diff] [blame] | 118 | destBranchExpr = None |
Nasser Grainawi | da40341 | 2018-05-04 12:53:29 -0600 | [diff] [blame] | 119 | upstreamExpr = None |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 120 | remote = None |
Shawn O. Pearce | 6392c87 | 2011-09-22 17:44:31 -0700 | [diff] [blame] | 121 | sync_j = 1 |
Anatol Pomazau | 79770d2 | 2012-04-20 14:41:59 -0700 | [diff] [blame] | 122 | sync_c = False |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 123 | sync_s = False |
YOUNG HO CHA | a32c92c | 2018-02-14 16:57:31 +0900 | [diff] [blame] | 124 | sync_tags = True |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 125 | |
Julien Campergue | 7487992 | 2013-10-09 14:38:46 +0200 | [diff] [blame] | 126 | def __eq__(self, other): |
| 127 | return self.__dict__ == other.__dict__ |
| 128 | |
| 129 | def __ne__(self, other): |
| 130 | return self.__dict__ != other.__dict__ |
| 131 | |
David Pursehouse | 819827a | 2020-02-12 15:20:19 +0900 | [diff] [blame] | 132 | |
Shawn O. Pearce | d1f70d9 | 2009-05-19 14:58:02 -0700 | [diff] [blame] | 133 | class _XmlRemote(object): |
| 134 | def __init__(self, |
| 135 | name, |
Yestin Sun | b292b98 | 2012-07-02 07:32:50 -0700 | [diff] [blame] | 136 | alias=None, |
Shawn O. Pearce | d1f70d9 | 2009-05-19 14:58:02 -0700 | [diff] [blame] | 137 | fetch=None, |
Steve Rae | d648045 | 2016-08-10 15:00:00 -0700 | [diff] [blame] | 138 | pushUrl=None, |
Conley Owens | db728cd | 2011-09-26 16:34:01 -0700 | [diff] [blame] | 139 | manifestUrl=None, |
Anthony King | 36ea2fb | 2014-05-06 11:54:01 +0100 | [diff] [blame] | 140 | review=None, |
Jonathan Nieder | 9371979 | 2015-03-17 11:29:58 -0700 | [diff] [blame] | 141 | revision=None): |
Shawn O. Pearce | d1f70d9 | 2009-05-19 14:58:02 -0700 | [diff] [blame] | 142 | self.name = name |
| 143 | self.fetchUrl = fetch |
Steve Rae | d648045 | 2016-08-10 15:00:00 -0700 | [diff] [blame] | 144 | self.pushUrl = pushUrl |
Conley Owens | db728cd | 2011-09-26 16:34:01 -0700 | [diff] [blame] | 145 | self.manifestUrl = manifestUrl |
Yestin Sun | b292b98 | 2012-07-02 07:32:50 -0700 | [diff] [blame] | 146 | self.remoteAlias = alias |
Shawn O. Pearce | d1f70d9 | 2009-05-19 14:58:02 -0700 | [diff] [blame] | 147 | self.reviewUrl = review |
Anthony King | 36ea2fb | 2014-05-06 11:54:01 +0100 | [diff] [blame] | 148 | self.revision = revision |
Conley Owens | ceea368 | 2011-10-20 10:45:47 -0700 | [diff] [blame] | 149 | self.resolvedFetchUrl = self._resolveFetchUrl() |
Shawn O. Pearce | d1f70d9 | 2009-05-19 14:58:02 -0700 | [diff] [blame] | 150 | |
David Pursehouse | 717ece9 | 2012-11-13 08:49:16 +0900 | [diff] [blame] | 151 | def __eq__(self, other): |
| 152 | return self.__dict__ == other.__dict__ |
| 153 | |
| 154 | def __ne__(self, other): |
| 155 | return self.__dict__ != other.__dict__ |
| 156 | |
Conley Owens | ceea368 | 2011-10-20 10:45:47 -0700 | [diff] [blame] | 157 | def _resolveFetchUrl(self): |
| 158 | url = self.fetchUrl.rstrip('/') |
Conley Owens | db728cd | 2011-09-26 16:34:01 -0700 | [diff] [blame] | 159 | manifestUrl = self.manifestUrl.rstrip('/') |
Conley Owens | 2d0f508 | 2014-01-31 15:03:51 -0800 | [diff] [blame] | 160 | # urljoin will gets confused over quite a few things. The ones we care |
| 161 | # about here are: |
| 162 | # * no scheme in the base url, like <hostname:port> |
Anthony King | cb07ba7 | 2015-03-28 23:26:04 +0000 | [diff] [blame] | 163 | # We handle no scheme by replacing it with an obscure protocol, gopher |
| 164 | # and then replacing it with the original when we are done. |
| 165 | |
Conley Owens | db728cd | 2011-09-26 16:34:01 -0700 | [diff] [blame] | 166 | if manifestUrl.find(':') != manifestUrl.find('/') - 1: |
Conley Owens | 4ccad75 | 2015-04-29 10:45:37 -0700 | [diff] [blame] | 167 | url = urllib.parse.urljoin('gopher://' + manifestUrl, url) |
| 168 | url = re.sub(r'^gopher://', '', url) |
Anthony King | cb07ba7 | 2015-03-28 23:26:04 +0000 | [diff] [blame] | 169 | else: |
| 170 | url = urllib.parse.urljoin(manifestUrl, url) |
Shawn Pearce | a9f11b3 | 2013-01-02 15:40:48 -0800 | [diff] [blame] | 171 | return url |
Conley Owens | ceea368 | 2011-10-20 10:45:47 -0700 | [diff] [blame] | 172 | |
| 173 | def ToRemoteSpec(self, projectName): |
David Riley | e0684ad | 2017-04-05 00:02:59 -0700 | [diff] [blame] | 174 | fetchUrl = self.resolvedFetchUrl.rstrip('/') |
| 175 | url = fetchUrl + '/' + projectName |
Yestin Sun | b292b98 | 2012-07-02 07:32:50 -0700 | [diff] [blame] | 176 | remoteName = self.name |
Conley Owens | 1e7ab2a | 2013-10-08 17:26:57 -0700 | [diff] [blame] | 177 | if self.remoteAlias: |
David Pursehouse | 37128b6 | 2013-10-15 10:48:40 +0900 | [diff] [blame] | 178 | remoteName = self.remoteAlias |
Dan Willemsen | 96c2d65 | 2016-04-06 16:03:54 -0700 | [diff] [blame] | 179 | return RemoteSpec(remoteName, |
| 180 | url=url, |
Steve Rae | d648045 | 2016-08-10 15:00:00 -0700 | [diff] [blame] | 181 | pushUrl=self.pushUrl, |
Dan Willemsen | 96c2d65 | 2016-04-06 16:03:54 -0700 | [diff] [blame] | 182 | review=self.reviewUrl, |
David Riley | e0684ad | 2017-04-05 00:02:59 -0700 | [diff] [blame] | 183 | orig_name=self.name, |
| 184 | fetchUrl=self.fetchUrl) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 185 | |
David Pursehouse | 819827a | 2020-02-12 15:20:19 +0900 | [diff] [blame] | 186 | |
Shawn O. Pearce | c8a300f | 2009-05-18 13:19:57 -0700 | [diff] [blame] | 187 | class XmlManifest(object): |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 188 | """manages the repo configuration file""" |
| 189 | |
| 190 | def __init__(self, repodir): |
| 191 | self.repodir = os.path.abspath(repodir) |
| 192 | self.topdir = os.path.dirname(self.repodir) |
| 193 | self.manifestFile = os.path.join(self.repodir, MANIFEST_FILE_NAME) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 194 | self.globalConfig = GitConfig.ForUser() |
David Pursehouse | 4eb285c | 2013-02-14 16:28:44 +0900 | [diff] [blame] | 195 | self.localManifestWarning = False |
Simran Basi | b9a1b73 | 2015-08-20 12:19:28 -0700 | [diff] [blame] | 196 | self.isGitcClient = False |
Basil Gello | c745350 | 2018-05-25 20:23:52 +0300 | [diff] [blame] | 197 | self._load_local_manifests = True |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 198 | |
| 199 | self.repoProject = MetaProject(self, 'repo', |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 200 | gitdir=os.path.join(repodir, 'repo/.git'), |
| 201 | worktree=os.path.join(repodir, 'repo')) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 202 | |
Mike Frysinger | 979d5bd | 2020-02-09 02:28:34 -0500 | [diff] [blame] | 203 | mp = MetaProject(self, 'manifests', |
| 204 | gitdir=os.path.join(repodir, 'manifests.git'), |
| 205 | worktree=os.path.join(repodir, 'manifests')) |
| 206 | self.manifestProject = mp |
| 207 | |
| 208 | # This is a bit hacky, but we're in a chicken & egg situation: all the |
| 209 | # normal repo settings live in the manifestProject which we just setup |
| 210 | # above, so we couldn't easily query before that. We assume Project() |
| 211 | # init doesn't care if this changes afterwards. |
Mike Frysinger | d957ec6 | 2020-02-24 14:40:25 -0500 | [diff] [blame] | 212 | if os.path.exists(mp.gitdir) and mp.config.GetBoolean('repo.worktree'): |
Mike Frysinger | 979d5bd | 2020-02-09 02:28:34 -0500 | [diff] [blame] | 213 | mp.use_git_worktrees = True |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 214 | |
| 215 | self._Unload() |
| 216 | |
Basil Gello | c745350 | 2018-05-25 20:23:52 +0300 | [diff] [blame] | 217 | def Override(self, name, load_local_manifests=True): |
Nico Sallembien | a1bfd2c | 2010-04-06 10:40:01 -0700 | [diff] [blame] | 218 | """Use a different manifest, just for the current instantiation. |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 219 | """ |
Basil Gello | c745350 | 2018-05-25 20:23:52 +0300 | [diff] [blame] | 220 | path = None |
| 221 | |
| 222 | # Look for a manifest by path in the filesystem (including the cwd). |
| 223 | if not load_local_manifests: |
| 224 | local_path = os.path.abspath(name) |
| 225 | if os.path.isfile(local_path): |
| 226 | path = local_path |
| 227 | |
| 228 | # Look for manifests by name from the manifests repo. |
| 229 | if path is None: |
| 230 | path = os.path.join(self.manifestProject.worktree, name) |
| 231 | if not os.path.isfile(path): |
| 232 | raise ManifestParseError('manifest %s not found' % name) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 233 | |
| 234 | old = self.manifestFile |
| 235 | try: |
Basil Gello | c745350 | 2018-05-25 20:23:52 +0300 | [diff] [blame] | 236 | self._load_local_manifests = load_local_manifests |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 237 | self.manifestFile = path |
| 238 | self._Unload() |
| 239 | self._Load() |
| 240 | finally: |
| 241 | self.manifestFile = old |
| 242 | |
Nico Sallembien | a1bfd2c | 2010-04-06 10:40:01 -0700 | [diff] [blame] | 243 | def Link(self, name): |
| 244 | """Update the repo metadata to use a different manifest. |
| 245 | """ |
| 246 | self.Override(name) |
| 247 | |
Mike Frysinger | a269b1c | 2020-02-21 00:49:41 -0500 | [diff] [blame] | 248 | # Old versions of repo would generate symlinks we need to clean up. |
| 249 | if os.path.lexists(self.manifestFile): |
| 250 | platform_utils.remove(self.manifestFile) |
| 251 | # This file is interpreted as if it existed inside the manifest repo. |
| 252 | # That allows us to use <include> with the relative file name. |
| 253 | with open(self.manifestFile, 'w') as fp: |
| 254 | fp.write("""<?xml version="1.0" encoding="UTF-8"?> |
| 255 | <!-- |
| 256 | DO NOT EDIT THIS FILE! It is generated by repo and changes will be discarded. |
| 257 | If you want to use a different manifest, use `repo init -m <file>` instead. |
| 258 | |
| 259 | If you want to customize your checkout by overriding manifest settings, use |
| 260 | the local_manifests/ directory instead. |
| 261 | |
| 262 | For more information on repo manifests, check out: |
| 263 | https://gerrit.googlesource.com/git-repo/+/HEAD/docs/manifest-format.md |
| 264 | --> |
| 265 | <manifest> |
| 266 | <include name="%s" /> |
| 267 | </manifest> |
| 268 | """ % (name,)) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 269 | |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 270 | def _RemoteToXml(self, r, doc, root): |
| 271 | e = doc.createElement('remote') |
| 272 | root.appendChild(e) |
| 273 | e.setAttribute('name', r.name) |
| 274 | e.setAttribute('fetch', r.fetchUrl) |
Steve Rae | d648045 | 2016-08-10 15:00:00 -0700 | [diff] [blame] | 275 | if r.pushUrl is not None: |
| 276 | e.setAttribute('pushurl', r.pushUrl) |
Conley Owens | 1e7ab2a | 2013-10-08 17:26:57 -0700 | [diff] [blame] | 277 | if r.remoteAlias is not None: |
| 278 | e.setAttribute('alias', r.remoteAlias) |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 279 | if r.reviewUrl is not None: |
| 280 | e.setAttribute('review', r.reviewUrl) |
Anthony King | 36ea2fb | 2014-05-06 11:54:01 +0100 | [diff] [blame] | 281 | if r.revision is not None: |
| 282 | e.setAttribute('revision', r.revision) |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 283 | |
Josh Triplett | 884a387 | 2014-06-12 14:57:29 -0700 | [diff] [blame] | 284 | def _ParseGroups(self, groups): |
| 285 | return [x for x in re.split(r'[,\s]+', groups) if x] |
| 286 | |
Sean McAllister | af908cb | 2020-04-20 08:41:58 -0600 | [diff] [blame] | 287 | def Save(self, fd, peg_rev=False, peg_rev_upstream=True, peg_rev_dest_branch=True, groups=None): |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 288 | """Write the current manifest out to the given file descriptor. |
| 289 | """ |
Colin Cross | 5acde75 | 2012-03-28 20:15:45 -0700 | [diff] [blame] | 290 | mp = self.manifestProject |
| 291 | |
Dan Willemsen | 5ea32d1 | 2015-09-08 13:27:20 -0700 | [diff] [blame] | 292 | if groups is None: |
| 293 | groups = mp.config.GetString('manifest.groups') |
Matt Gumbel | 0c635bb | 2012-12-21 10:14:53 -0800 | [diff] [blame] | 294 | if groups: |
Josh Triplett | 884a387 | 2014-06-12 14:57:29 -0700 | [diff] [blame] | 295 | groups = self._ParseGroups(groups) |
Colin Cross | 5acde75 | 2012-03-28 20:15:45 -0700 | [diff] [blame] | 296 | |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 297 | doc = xml.dom.minidom.Document() |
| 298 | root = doc.createElement('manifest') |
| 299 | doc.appendChild(root) |
| 300 | |
Doug Anderson | 2b8db3c | 2010-11-01 15:08:06 -0700 | [diff] [blame] | 301 | # Save out the notice. There's a little bit of work here to give it the |
| 302 | # right whitespace, which assumes that the notice is automatically indented |
| 303 | # by 4 by minidom. |
| 304 | if self.notice: |
| 305 | notice_element = root.appendChild(doc.createElement('notice')) |
| 306 | notice_lines = self.notice.splitlines() |
David Pursehouse | 54a4e60 | 2020-02-12 14:31:05 +0900 | [diff] [blame] | 307 | indented_notice = ('\n'.join(" " * 4 + line for line in notice_lines))[4:] |
Doug Anderson | 2b8db3c | 2010-11-01 15:08:06 -0700 | [diff] [blame] | 308 | notice_element.appendChild(doc.createTextNode(indented_notice)) |
| 309 | |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 310 | d = self.default |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 311 | |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 312 | for r in sorted(self.remotes): |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 313 | self._RemoteToXml(self.remotes[r], doc, root) |
| 314 | if self.remotes: |
| 315 | root.appendChild(doc.createTextNode('')) |
| 316 | |
| 317 | have_default = False |
| 318 | e = doc.createElement('default') |
| 319 | if d.remote: |
| 320 | have_default = True |
| 321 | e.setAttribute('remote', d.remote.name) |
Shawn O. Pearce | 3c8dea1 | 2009-05-29 18:38:17 -0700 | [diff] [blame] | 322 | if d.revisionExpr: |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 323 | have_default = True |
Shawn O. Pearce | 3c8dea1 | 2009-05-29 18:38:17 -0700 | [diff] [blame] | 324 | e.setAttribute('revision', d.revisionExpr) |
Simon Ruggier | 7e59de2 | 2015-07-24 12:50:06 +0200 | [diff] [blame] | 325 | if d.destBranchExpr: |
| 326 | have_default = True |
| 327 | e.setAttribute('dest-branch', d.destBranchExpr) |
Nasser Grainawi | da40341 | 2018-05-04 12:53:29 -0600 | [diff] [blame] | 328 | if d.upstreamExpr: |
| 329 | have_default = True |
| 330 | e.setAttribute('upstream', d.upstreamExpr) |
Shawn O. Pearce | 6392c87 | 2011-09-22 17:44:31 -0700 | [diff] [blame] | 331 | if d.sync_j > 1: |
| 332 | have_default = True |
| 333 | e.setAttribute('sync-j', '%d' % d.sync_j) |
Anatol Pomazau | 79770d2 | 2012-04-20 14:41:59 -0700 | [diff] [blame] | 334 | if d.sync_c: |
| 335 | have_default = True |
| 336 | e.setAttribute('sync-c', 'true') |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 337 | if d.sync_s: |
| 338 | have_default = True |
| 339 | e.setAttribute('sync-s', 'true') |
YOUNG HO CHA | a32c92c | 2018-02-14 16:57:31 +0900 | [diff] [blame] | 340 | if not d.sync_tags: |
| 341 | have_default = True |
| 342 | e.setAttribute('sync-tags', 'false') |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 343 | if have_default: |
| 344 | root.appendChild(e) |
| 345 | root.appendChild(doc.createTextNode('')) |
| 346 | |
Nico Sallembien | a1bfd2c | 2010-04-06 10:40:01 -0700 | [diff] [blame] | 347 | if self._manifest_server: |
| 348 | e = doc.createElement('manifest-server') |
| 349 | e.setAttribute('url', self._manifest_server) |
| 350 | root.appendChild(e) |
| 351 | root.appendChild(doc.createTextNode('')) |
| 352 | |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 353 | def output_projects(parent, parent_node, projects): |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 354 | for project_name in projects: |
| 355 | for project in self._projects[project_name]: |
| 356 | output_project(parent, parent_node, project) |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 357 | |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 358 | def output_project(parent, parent_node, p): |
Colin Cross | 5acde75 | 2012-03-28 20:15:45 -0700 | [diff] [blame] | 359 | if not p.MatchesGroups(groups): |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 360 | return |
| 361 | |
| 362 | name = p.name |
| 363 | relpath = p.relpath |
| 364 | if parent: |
| 365 | name = self._UnjoinName(parent.name, name) |
| 366 | relpath = self._UnjoinRelpath(parent.relpath, relpath) |
Colin Cross | 5acde75 | 2012-03-28 20:15:45 -0700 | [diff] [blame] | 367 | |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 368 | e = doc.createElement('project') |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 369 | parent_node.appendChild(e) |
| 370 | e.setAttribute('name', name) |
| 371 | if relpath != name: |
| 372 | e.setAttribute('path', relpath) |
Conley Owens | a17d7af | 2013-10-16 14:38:09 -0700 | [diff] [blame] | 373 | remoteName = None |
| 374 | if d.remote: |
Dan Willemsen | 96c2d65 | 2016-04-06 16:03:54 -0700 | [diff] [blame] | 375 | remoteName = d.remote.name |
| 376 | if not d.remote or p.remote.orig_name != remoteName: |
| 377 | remoteName = p.remote.orig_name |
Anthony King | 36ea2fb | 2014-05-06 11:54:01 +0100 | [diff] [blame] | 378 | e.setAttribute('remote', remoteName) |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 379 | if peg_rev: |
| 380 | if self.IsMirror: |
Brian Harring | 14a6674 | 2012-09-28 20:21:57 -0700 | [diff] [blame] | 381 | value = p.bare_git.rev_parse(p.revisionExpr + '^0') |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 382 | else: |
Brian Harring | 14a6674 | 2012-09-28 20:21:57 -0700 | [diff] [blame] | 383 | value = p.work_git.rev_parse(HEAD + '^0') |
| 384 | e.setAttribute('revision', value) |
Conley Owens | 551dfec | 2015-07-10 14:54:54 -0700 | [diff] [blame] | 385 | if peg_rev_upstream: |
| 386 | if p.upstream: |
| 387 | e.setAttribute('upstream', p.upstream) |
| 388 | elif value != p.revisionExpr: |
| 389 | # Only save the origin if the origin is not a sha1, and the default |
| 390 | # isn't our value |
| 391 | e.setAttribute('upstream', p.revisionExpr) |
Sean McAllister | af908cb | 2020-04-20 08:41:58 -0600 | [diff] [blame] | 392 | |
| 393 | if peg_rev_dest_branch: |
| 394 | if p.dest_branch: |
| 395 | e.setAttribute('dest-branch', p.dest_branch) |
| 396 | elif value != p.revisionExpr: |
| 397 | e.setAttribute('dest-branch', p.revisionExpr) |
| 398 | |
Anthony King | 36ea2fb | 2014-05-06 11:54:01 +0100 | [diff] [blame] | 399 | else: |
Dan Willemsen | 96c2d65 | 2016-04-06 16:03:54 -0700 | [diff] [blame] | 400 | revision = self.remotes[p.remote.orig_name].revision or d.revisionExpr |
Anthony King | 36ea2fb | 2014-05-06 11:54:01 +0100 | [diff] [blame] | 401 | if not revision or revision != p.revisionExpr: |
| 402 | e.setAttribute('revision', p.revisionExpr) |
Nasser Grainawi | da40341 | 2018-05-04 12:53:29 -0600 | [diff] [blame] | 403 | if (p.upstream and (p.upstream != p.revisionExpr or |
| 404 | p.upstream != d.upstreamExpr)): |
Mani Chandel | 7a91d51 | 2014-07-24 16:27:08 +0530 | [diff] [blame] | 405 | e.setAttribute('upstream', p.upstream) |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 406 | |
Simon Ruggier | 7e59de2 | 2015-07-24 12:50:06 +0200 | [diff] [blame] | 407 | if p.dest_branch and p.dest_branch != d.destBranchExpr: |
| 408 | e.setAttribute('dest-branch', p.dest_branch) |
| 409 | |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 410 | for c in p.copyfiles: |
| 411 | ce = doc.createElement('copyfile') |
| 412 | ce.setAttribute('src', c.src) |
| 413 | ce.setAttribute('dest', c.dest) |
| 414 | e.appendChild(ce) |
| 415 | |
Jeff Hamilton | e0df232 | 2014-04-21 17:10:59 -0500 | [diff] [blame] | 416 | for l in p.linkfiles: |
| 417 | le = doc.createElement('linkfile') |
| 418 | le.setAttribute('src', l.src) |
| 419 | le.setAttribute('dest', l.dest) |
| 420 | e.appendChild(le) |
| 421 | |
Conley Owens | bb1b5f5 | 2012-08-13 13:11:18 -0700 | [diff] [blame] | 422 | default_groups = ['all', 'name:%s' % p.name, 'path:%s' % p.relpath] |
Dmitry Fink | 17f85ea | 2012-08-06 14:52:29 -0700 | [diff] [blame] | 423 | egroups = [g for g in p.groups if g not in default_groups] |
Conley Owens | 971de8e | 2012-04-16 10:36:08 -0700 | [diff] [blame] | 424 | if egroups: |
| 425 | e.setAttribute('groups', ','.join(egroups)) |
Colin Cross | 5acde75 | 2012-03-28 20:15:45 -0700 | [diff] [blame] | 426 | |
James W. Mills | 24c1308 | 2012-04-12 15:04:13 -0500 | [diff] [blame] | 427 | for a in p.annotations: |
| 428 | if a.keep == "true": |
| 429 | ae = doc.createElement('annotation') |
| 430 | ae.setAttribute('name', a.name) |
| 431 | ae.setAttribute('value', a.value) |
| 432 | e.appendChild(ae) |
| 433 | |
Anatol Pomazau | 79770d2 | 2012-04-20 14:41:59 -0700 | [diff] [blame] | 434 | if p.sync_c: |
| 435 | e.setAttribute('sync-c', 'true') |
| 436 | |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 437 | if p.sync_s: |
| 438 | e.setAttribute('sync-s', 'true') |
| 439 | |
YOUNG HO CHA | a32c92c | 2018-02-14 16:57:31 +0900 | [diff] [blame] | 440 | if not p.sync_tags: |
| 441 | e.setAttribute('sync-tags', 'false') |
| 442 | |
Dan Willemsen | 8840922 | 2015-08-17 15:29:10 -0700 | [diff] [blame] | 443 | if p.clone_depth: |
| 444 | e.setAttribute('clone-depth', str(p.clone_depth)) |
| 445 | |
Simran Basi | b9a1b73 | 2015-08-20 12:19:28 -0700 | [diff] [blame] | 446 | self._output_manifest_project_extras(p, e) |
| 447 | |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 448 | if p.subprojects: |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 449 | subprojects = set(subp.name for subp in p.subprojects) |
| 450 | output_projects(p, e, list(sorted(subprojects))) |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 451 | |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 452 | projects = set(p.name for p in self._paths.values() if not p.parent) |
| 453 | output_projects(None, root, list(sorted(projects))) |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 454 | |
Doug Anderson | 37282b4 | 2011-03-04 11:54:18 -0800 | [diff] [blame] | 455 | if self._repo_hooks_project: |
| 456 | root.appendChild(doc.createTextNode('')) |
| 457 | e = doc.createElement('repo-hooks') |
| 458 | e.setAttribute('in-project', self._repo_hooks_project.name) |
| 459 | e.setAttribute('enabled-list', |
| 460 | ' '.join(self._repo_hooks_project.enabled_repo_hooks)) |
| 461 | root.appendChild(e) |
| 462 | |
Shawn O. Pearce | c7a4eef | 2009-03-05 10:32:38 -0800 | [diff] [blame] | 463 | doc.writexml(fd, '', ' ', '\n', 'UTF-8') |
| 464 | |
Simran Basi | b9a1b73 | 2015-08-20 12:19:28 -0700 | [diff] [blame] | 465 | def _output_manifest_project_extras(self, p, e): |
| 466 | """Manifests can modify e if they support extra project attributes.""" |
| 467 | pass |
| 468 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 469 | @property |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 470 | def paths(self): |
| 471 | self._Load() |
| 472 | return self._paths |
| 473 | |
| 474 | @property |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 475 | def projects(self): |
| 476 | self._Load() |
Anthony King | d58bfe5 | 2014-05-05 23:30:49 +0100 | [diff] [blame] | 477 | return list(self._paths.values()) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 478 | |
| 479 | @property |
| 480 | def remotes(self): |
| 481 | self._Load() |
| 482 | return self._remotes |
| 483 | |
| 484 | @property |
| 485 | def default(self): |
| 486 | self._Load() |
| 487 | return self._default |
| 488 | |
Shawn O. Pearce | e284ad1 | 2008-11-04 07:37:10 -0800 | [diff] [blame] | 489 | @property |
Doug Anderson | 37282b4 | 2011-03-04 11:54:18 -0800 | [diff] [blame] | 490 | def repo_hooks_project(self): |
| 491 | self._Load() |
| 492 | return self._repo_hooks_project |
| 493 | |
| 494 | @property |
Doug Anderson | 2b8db3c | 2010-11-01 15:08:06 -0700 | [diff] [blame] | 495 | def notice(self): |
| 496 | self._Load() |
| 497 | return self._notice |
| 498 | |
| 499 | @property |
Nico Sallembien | a1bfd2c | 2010-04-06 10:40:01 -0700 | [diff] [blame] | 500 | def manifest_server(self): |
| 501 | self._Load() |
Shawn O. Pearce | 34fb20f | 2011-11-30 13:41:02 -0800 | [diff] [blame] | 502 | return self._manifest_server |
Nico Sallembien | a1bfd2c | 2010-04-06 10:40:01 -0700 | [diff] [blame] | 503 | |
| 504 | @property |
Xin Li | 745be2e | 2019-06-03 11:24:30 -0700 | [diff] [blame] | 505 | def CloneFilter(self): |
| 506 | if self.manifestProject.config.GetBoolean('repo.partialclone'): |
| 507 | return self.manifestProject.config.GetString('repo.clonefilter') |
| 508 | return None |
| 509 | |
| 510 | @property |
Shawn O. Pearce | e284ad1 | 2008-11-04 07:37:10 -0800 | [diff] [blame] | 511 | def IsMirror(self): |
| 512 | return self.manifestProject.config.GetBoolean('repo.mirror') |
| 513 | |
Julien Campergue | 335f5ef | 2013-10-16 11:02:35 +0200 | [diff] [blame] | 514 | @property |
Mike Frysinger | 979d5bd | 2020-02-09 02:28:34 -0500 | [diff] [blame] | 515 | def UseGitWorktrees(self): |
| 516 | return self.manifestProject.config.GetBoolean('repo.worktree') |
| 517 | |
| 518 | @property |
Julien Campergue | 335f5ef | 2013-10-16 11:02:35 +0200 | [diff] [blame] | 519 | def IsArchive(self): |
| 520 | return self.manifestProject.config.GetBoolean('repo.archive') |
| 521 | |
Martin Kelly | e4e94d2 | 2017-03-21 16:05:12 -0700 | [diff] [blame] | 522 | @property |
| 523 | def HasSubmodules(self): |
| 524 | return self.manifestProject.config.GetBoolean('repo.submodules') |
| 525 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 526 | def _Unload(self): |
| 527 | self._loaded = False |
| 528 | self._projects = {} |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 529 | self._paths = {} |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 530 | self._remotes = {} |
| 531 | self._default = None |
Doug Anderson | 37282b4 | 2011-03-04 11:54:18 -0800 | [diff] [blame] | 532 | self._repo_hooks_project = None |
Doug Anderson | 2b8db3c | 2010-11-01 15:08:06 -0700 | [diff] [blame] | 533 | self._notice = None |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 534 | self.branch = None |
Nico Sallembien | a1bfd2c | 2010-04-06 10:40:01 -0700 | [diff] [blame] | 535 | self._manifest_server = None |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 536 | |
| 537 | def _Load(self): |
| 538 | if not self._loaded: |
Shawn O. Pearce | 2450a29 | 2008-11-04 08:22:07 -0800 | [diff] [blame] | 539 | m = self.manifestProject |
| 540 | b = m.GetBranch(m.CurrentBranch).merge |
Shawn O. Pearce | 21c5c34 | 2009-06-25 16:47:30 -0700 | [diff] [blame] | 541 | if b is not None and b.startswith(R_HEADS): |
Shawn O. Pearce | 2450a29 | 2008-11-04 08:22:07 -0800 | [diff] [blame] | 542 | b = b[len(R_HEADS):] |
| 543 | self.branch = b |
| 544 | |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 545 | nodes = [] |
Brian Harring | 475a47d | 2012-06-07 20:05:35 -0700 | [diff] [blame] | 546 | nodes.append(self._ParseManifestXml(self.manifestFile, |
| 547 | self.manifestProject.worktree)) |
Shawn O. Pearce | 5cc6679 | 2008-10-23 16:19:27 -0700 | [diff] [blame] | 548 | |
Basil Gello | c745350 | 2018-05-25 20:23:52 +0300 | [diff] [blame] | 549 | if self._load_local_manifests: |
| 550 | local = os.path.join(self.repodir, LOCAL_MANIFEST_NAME) |
| 551 | if os.path.exists(local): |
| 552 | if not self.localManifestWarning: |
| 553 | self.localManifestWarning = True |
| 554 | print('warning: %s is deprecated; put local manifests ' |
| 555 | 'in `%s` instead' % (LOCAL_MANIFEST_NAME, |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 556 | os.path.join(self.repodir, LOCAL_MANIFESTS_DIR_NAME)), |
Basil Gello | c745350 | 2018-05-25 20:23:52 +0300 | [diff] [blame] | 557 | file=sys.stderr) |
| 558 | nodes.append(self._ParseManifestXml(local, self.repodir)) |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 559 | |
Basil Gello | c745350 | 2018-05-25 20:23:52 +0300 | [diff] [blame] | 560 | local_dir = os.path.abspath(os.path.join(self.repodir, |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 561 | LOCAL_MANIFESTS_DIR_NAME)) |
Basil Gello | c745350 | 2018-05-25 20:23:52 +0300 | [diff] [blame] | 562 | try: |
| 563 | for local_file in sorted(platform_utils.listdir(local_dir)): |
| 564 | if local_file.endswith('.xml'): |
| 565 | local = os.path.join(local_dir, local_file) |
| 566 | nodes.append(self._ParseManifestXml(local, self.repodir)) |
| 567 | except OSError: |
| 568 | pass |
David Pursehouse | 2d5a0df | 2012-11-13 02:50:36 +0900 | [diff] [blame] | 569 | |
Joe Onorato | 26e2475 | 2013-01-11 12:35:53 -0800 | [diff] [blame] | 570 | try: |
| 571 | self._ParseManifest(nodes) |
| 572 | except ManifestParseError as e: |
| 573 | # There was a problem parsing, unload ourselves in case they catch |
| 574 | # this error and try again later, we will show the correct error |
| 575 | self._Unload() |
| 576 | raise e |
Shawn O. Pearce | 5cc6679 | 2008-10-23 16:19:27 -0700 | [diff] [blame] | 577 | |
Shawn O. Pearce | e284ad1 | 2008-11-04 07:37:10 -0800 | [diff] [blame] | 578 | if self.IsMirror: |
| 579 | self._AddMetaProjectMirror(self.repoProject) |
| 580 | self._AddMetaProjectMirror(self.manifestProject) |
| 581 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 582 | self._loaded = True |
| 583 | |
Brian Harring | 475a47d | 2012-06-07 20:05:35 -0700 | [diff] [blame] | 584 | def _ParseManifestXml(self, path, include_root): |
David Pursehouse | f7fc8a9 | 2012-11-13 04:00:28 +0900 | [diff] [blame] | 585 | try: |
| 586 | root = xml.dom.minidom.parse(path) |
David Pursehouse | 2d5a0df | 2012-11-13 02:50:36 +0900 | [diff] [blame] | 587 | except (OSError, xml.parsers.expat.ExpatError) as e: |
David Pursehouse | f7fc8a9 | 2012-11-13 04:00:28 +0900 | [diff] [blame] | 588 | raise ManifestParseError("error parsing manifest %s: %s" % (path, e)) |
| 589 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 590 | if not root or not root.childNodes: |
Brian Harring | 2644874 | 2011-04-28 05:04:41 -0700 | [diff] [blame] | 591 | raise ManifestParseError("no root node in %s" % (path,)) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 592 | |
Jooncheol Park | 34acdd2 | 2012-08-27 02:25:59 +0900 | [diff] [blame] | 593 | for manifest in root.childNodes: |
| 594 | if manifest.nodeName == 'manifest': |
| 595 | break |
| 596 | else: |
Brian Harring | 2644874 | 2011-04-28 05:04:41 -0700 | [diff] [blame] | 597 | raise ManifestParseError("no <manifest> in %s" % (path,)) |
| 598 | |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 599 | nodes = [] |
David Pursehouse | 65b0ba5 | 2018-06-24 16:21:51 +0900 | [diff] [blame] | 600 | for node in manifest.childNodes: |
David Pursehouse | c1b86a2 | 2012-11-14 11:36:51 +0900 | [diff] [blame] | 601 | if node.nodeName == 'include': |
| 602 | name = self._reqatt(node, 'name') |
| 603 | fp = os.path.join(include_root, name) |
| 604 | if not os.path.isfile(fp): |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 605 | raise ManifestParseError("include %s doesn't exist or isn't a file" |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 606 | % (name,)) |
David Pursehouse | c1b86a2 | 2012-11-14 11:36:51 +0900 | [diff] [blame] | 607 | try: |
| 608 | nodes.extend(self._ParseManifestXml(fp, include_root)) |
| 609 | # should isolate this to the exact exception, but that's |
| 610 | # tricky. actual parsing implementation may vary. |
| 611 | except (KeyboardInterrupt, RuntimeError, SystemExit): |
| 612 | raise |
| 613 | except Exception as e: |
| 614 | raise ManifestParseError( |
Mike Frysinger | ec558df | 2019-07-05 01:38:05 -0400 | [diff] [blame] | 615 | "failed parsing included manifest %s: %s" % (name, e)) |
David Pursehouse | c1b86a2 | 2012-11-14 11:36:51 +0900 | [diff] [blame] | 616 | else: |
| 617 | nodes.append(node) |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 618 | return nodes |
Brian Harring | 2644874 | 2011-04-28 05:04:41 -0700 | [diff] [blame] | 619 | |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 620 | def _ParseManifest(self, node_list): |
| 621 | for node in itertools.chain(*node_list): |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 622 | if node.nodeName == 'remote': |
| 623 | remote = self._ParseRemote(node) |
David Pursehouse | 717ece9 | 2012-11-13 08:49:16 +0900 | [diff] [blame] | 624 | if remote: |
| 625 | if remote.name in self._remotes: |
| 626 | if remote != self._remotes[remote.name]: |
| 627 | raise ManifestParseError( |
| 628 | 'remote %s already exists with different attributes' % |
| 629 | (remote.name)) |
| 630 | else: |
| 631 | self._remotes[remote.name] = remote |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 632 | |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 633 | for node in itertools.chain(*node_list): |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 634 | if node.nodeName == 'default': |
Julien Campergue | 7487992 | 2013-10-09 14:38:46 +0200 | [diff] [blame] | 635 | new_default = self._ParseDefault(node) |
| 636 | if self._default is None: |
| 637 | self._default = new_default |
| 638 | elif new_default != self._default: |
David Pursehouse | 37128b6 | 2013-10-15 10:48:40 +0900 | [diff] [blame] | 639 | raise ManifestParseError('duplicate default in %s' % |
| 640 | (self.manifestFile)) |
Julien Campergue | 7487992 | 2013-10-09 14:38:46 +0200 | [diff] [blame] | 641 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 642 | if self._default is None: |
| 643 | self._default = _Default() |
| 644 | |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 645 | for node in itertools.chain(*node_list): |
Doug Anderson | 2b8db3c | 2010-11-01 15:08:06 -0700 | [diff] [blame] | 646 | if node.nodeName == 'notice': |
| 647 | if self._notice is not None: |
Doug Anderson | 37282b4 | 2011-03-04 11:54:18 -0800 | [diff] [blame] | 648 | raise ManifestParseError( |
| 649 | 'duplicate notice in %s' % |
| 650 | (self.manifestFile)) |
Doug Anderson | 2b8db3c | 2010-11-01 15:08:06 -0700 | [diff] [blame] | 651 | self._notice = self._ParseNotice(node) |
| 652 | |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 653 | for node in itertools.chain(*node_list): |
Nico Sallembien | a1bfd2c | 2010-04-06 10:40:01 -0700 | [diff] [blame] | 654 | if node.nodeName == 'manifest-server': |
| 655 | url = self._reqatt(node, 'url') |
| 656 | if self._manifest_server is not None: |
David Pursehouse | c1b86a2 | 2012-11-14 11:36:51 +0900 | [diff] [blame] | 657 | raise ManifestParseError( |
| 658 | 'duplicate manifest-server in %s' % |
| 659 | (self.manifestFile)) |
Nico Sallembien | a1bfd2c | 2010-04-06 10:40:01 -0700 | [diff] [blame] | 660 | self._manifest_server = url |
| 661 | |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 662 | def recursively_add_projects(project): |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 663 | projects = self._projects.setdefault(project.name, []) |
| 664 | if project.relpath is None: |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 665 | raise ManifestParseError( |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 666 | 'missing path for %s in %s' % |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 667 | (project.name, self.manifestFile)) |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 668 | if project.relpath in self._paths: |
| 669 | raise ManifestParseError( |
| 670 | 'duplicate path %s in %s' % |
| 671 | (project.relpath, self.manifestFile)) |
| 672 | self._paths[project.relpath] = project |
| 673 | projects.append(project) |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 674 | for subproject in project.subprojects: |
| 675 | recursively_add_projects(subproject) |
| 676 | |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 677 | for node in itertools.chain(*node_list): |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 678 | if node.nodeName == 'project': |
| 679 | project = self._ParseProject(node) |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 680 | recursively_add_projects(project) |
Josh Triplett | 884a387 | 2014-06-12 14:57:29 -0700 | [diff] [blame] | 681 | if node.nodeName == 'extend-project': |
| 682 | name = self._reqatt(node, 'name') |
| 683 | |
| 684 | if name not in self._projects: |
| 685 | raise ManifestParseError('extend-project element specifies non-existent ' |
| 686 | 'project: %s' % name) |
| 687 | |
| 688 | path = node.getAttribute('path') |
| 689 | groups = node.getAttribute('groups') |
| 690 | if groups: |
| 691 | groups = self._ParseGroups(groups) |
Luis Hector Chavez | 7d52585 | 2018-03-15 09:54:08 -0700 | [diff] [blame] | 692 | revision = node.getAttribute('revision') |
Kyunam Jo | bd0aae9 | 2020-02-04 11:38:53 +0900 | [diff] [blame] | 693 | remote = node.getAttribute('remote') |
| 694 | if remote: |
| 695 | remote = self._get_remote(node) |
Josh Triplett | 884a387 | 2014-06-12 14:57:29 -0700 | [diff] [blame] | 696 | |
| 697 | for p in self._projects[name]: |
| 698 | if path and p.relpath != path: |
| 699 | continue |
| 700 | if groups: |
| 701 | p.groups.extend(groups) |
Luis Hector Chavez | 7d52585 | 2018-03-15 09:54:08 -0700 | [diff] [blame] | 702 | if revision: |
| 703 | p.revisionExpr = revision |
Kyunam Jo | bd0aae9 | 2020-02-04 11:38:53 +0900 | [diff] [blame] | 704 | if remote: |
| 705 | p.remote = remote.ToRemoteSpec(name) |
Doug Anderson | 37282b4 | 2011-03-04 11:54:18 -0800 | [diff] [blame] | 706 | if node.nodeName == 'repo-hooks': |
| 707 | # Get the name of the project and the (space-separated) list of enabled. |
| 708 | repo_hooks_project = self._reqatt(node, 'in-project') |
| 709 | enabled_repo_hooks = self._reqatt(node, 'enabled-list').split() |
| 710 | |
| 711 | # Only one project can be the hooks project |
| 712 | if self._repo_hooks_project is not None: |
| 713 | raise ManifestParseError( |
| 714 | 'duplicate repo-hooks in %s' % |
| 715 | (self.manifestFile)) |
| 716 | |
| 717 | # Store a reference to the Project. |
| 718 | try: |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 719 | repo_hooks_projects = self._projects[repo_hooks_project] |
Doug Anderson | 37282b4 | 2011-03-04 11:54:18 -0800 | [diff] [blame] | 720 | except KeyError: |
| 721 | raise ManifestParseError( |
| 722 | 'project %s not found for repo-hooks' % |
| 723 | (repo_hooks_project)) |
| 724 | |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 725 | if len(repo_hooks_projects) != 1: |
| 726 | raise ManifestParseError( |
| 727 | 'internal error parsing repo-hooks in %s' % |
| 728 | (self.manifestFile)) |
| 729 | self._repo_hooks_project = repo_hooks_projects[0] |
| 730 | |
Doug Anderson | 37282b4 | 2011-03-04 11:54:18 -0800 | [diff] [blame] | 731 | # Store the enabled hooks in the Project object. |
| 732 | self._repo_hooks_project.enabled_repo_hooks = enabled_repo_hooks |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 733 | if node.nodeName == 'remove-project': |
| 734 | name = self._reqatt(node, 'name') |
David James | b8433df | 2014-01-30 10:11:17 -0800 | [diff] [blame] | 735 | |
| 736 | if name not in self._projects: |
David Pursehouse | f910748 | 2012-11-16 19:12:32 +0900 | [diff] [blame] | 737 | raise ManifestParseError('remove-project element specifies non-existent ' |
| 738 | 'project: %s' % name) |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 739 | |
David James | b8433df | 2014-01-30 10:11:17 -0800 | [diff] [blame] | 740 | for p in self._projects[name]: |
| 741 | del self._paths[p.relpath] |
| 742 | del self._projects[name] |
| 743 | |
Colin Cross | 23acdd3 | 2012-04-21 00:33:54 -0700 | [diff] [blame] | 744 | # If the manifest removes the hooks project, treat it as if it deleted |
| 745 | # the repo-hooks element too. |
| 746 | if self._repo_hooks_project and (self._repo_hooks_project.name == name): |
| 747 | self._repo_hooks_project = None |
| 748 | |
Shawn O. Pearce | e284ad1 | 2008-11-04 07:37:10 -0800 | [diff] [blame] | 749 | def _AddMetaProjectMirror(self, m): |
| 750 | name = None |
| 751 | m_url = m.GetRemote(m.remote.name).url |
| 752 | if m_url.endswith('/.git'): |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 753 | raise ManifestParseError('refusing to mirror %s' % m_url) |
Shawn O. Pearce | e284ad1 | 2008-11-04 07:37:10 -0800 | [diff] [blame] | 754 | |
| 755 | if self._default and self._default.remote: |
Conley Owens | ceea368 | 2011-10-20 10:45:47 -0700 | [diff] [blame] | 756 | url = self._default.remote.resolvedFetchUrl |
Shawn O. Pearce | e284ad1 | 2008-11-04 07:37:10 -0800 | [diff] [blame] | 757 | if not url.endswith('/'): |
| 758 | url += '/' |
| 759 | if m_url.startswith(url): |
| 760 | remote = self._default.remote |
| 761 | name = m_url[len(url):] |
| 762 | |
| 763 | if name is None: |
| 764 | s = m_url.rindex('/') + 1 |
Conley Owens | db728cd | 2011-09-26 16:34:01 -0700 | [diff] [blame] | 765 | manifestUrl = self.manifestProject.config.GetString('remote.origin.url') |
Shawn O. Pearce | f35b2d9 | 2012-08-02 11:46:22 -0700 | [diff] [blame] | 766 | remote = _XmlRemote('origin', fetch=m_url[:s], manifestUrl=manifestUrl) |
Shawn O. Pearce | e284ad1 | 2008-11-04 07:37:10 -0800 | [diff] [blame] | 767 | name = m_url[s:] |
| 768 | |
| 769 | if name.endswith('.git'): |
| 770 | name = name[:-4] |
| 771 | |
| 772 | if name not in self._projects: |
| 773 | m.PreSync() |
| 774 | gitdir = os.path.join(self.topdir, '%s.git' % name) |
David Pursehouse | e5913ae | 2020-02-12 13:56:59 +0900 | [diff] [blame] | 775 | project = Project(manifest=self, |
| 776 | name=name, |
| 777 | remote=remote.ToRemoteSpec(name), |
| 778 | gitdir=gitdir, |
| 779 | objdir=gitdir, |
| 780 | worktree=None, |
| 781 | relpath=name or None, |
| 782 | revisionExpr=m.revisionExpr, |
| 783 | revisionId=None) |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 784 | self._projects[project.name] = [project] |
Kwanhong Lee | ccd218c | 2014-02-17 13:07:32 +0900 | [diff] [blame] | 785 | self._paths[project.relpath] = project |
Shawn O. Pearce | e284ad1 | 2008-11-04 07:37:10 -0800 | [diff] [blame] | 786 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 787 | def _ParseRemote(self, node): |
| 788 | """ |
| 789 | reads a <remote> element from the manifest file |
| 790 | """ |
| 791 | name = self._reqatt(node, 'name') |
Yestin Sun | b292b98 | 2012-07-02 07:32:50 -0700 | [diff] [blame] | 792 | alias = node.getAttribute('alias') |
| 793 | if alias == '': |
| 794 | alias = None |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 795 | fetch = self._reqatt(node, 'fetch') |
Steve Rae | d648045 | 2016-08-10 15:00:00 -0700 | [diff] [blame] | 796 | pushUrl = node.getAttribute('pushurl') |
| 797 | if pushUrl == '': |
| 798 | pushUrl = None |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 799 | review = node.getAttribute('review') |
Shawn O. Pearce | ae6e094 | 2008-11-06 10:25:35 -0800 | [diff] [blame] | 800 | if review == '': |
| 801 | review = None |
Anthony King | 36ea2fb | 2014-05-06 11:54:01 +0100 | [diff] [blame] | 802 | revision = node.getAttribute('revision') |
| 803 | if revision == '': |
| 804 | revision = None |
Conley Owens | db728cd | 2011-09-26 16:34:01 -0700 | [diff] [blame] | 805 | manifestUrl = self.manifestProject.config.GetString('remote.origin.url') |
Steve Rae | d648045 | 2016-08-10 15:00:00 -0700 | [diff] [blame] | 806 | return _XmlRemote(name, alias, fetch, pushUrl, manifestUrl, review, revision) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 807 | |
| 808 | def _ParseDefault(self, node): |
| 809 | """ |
| 810 | reads a <default> element from the manifest file |
| 811 | """ |
| 812 | d = _Default() |
| 813 | d.remote = self._get_remote(node) |
Shawn O. Pearce | 3c8dea1 | 2009-05-29 18:38:17 -0700 | [diff] [blame] | 814 | d.revisionExpr = node.getAttribute('revision') |
| 815 | if d.revisionExpr == '': |
| 816 | d.revisionExpr = None |
Anatol Pomazau | 79770d2 | 2012-04-20 14:41:59 -0700 | [diff] [blame] | 817 | |
Bryan Jacobs | f609f91 | 2013-05-06 13:36:24 -0400 | [diff] [blame] | 818 | d.destBranchExpr = node.getAttribute('dest-branch') or None |
Nasser Grainawi | da40341 | 2018-05-04 12:53:29 -0600 | [diff] [blame] | 819 | d.upstreamExpr = node.getAttribute('upstream') or None |
Bryan Jacobs | f609f91 | 2013-05-06 13:36:24 -0400 | [diff] [blame] | 820 | |
Mike Frysinger | bb8ee7f | 2020-02-22 05:30:12 -0500 | [diff] [blame] | 821 | d.sync_j = XmlInt(node, 'sync-j', 1) |
| 822 | if d.sync_j <= 0: |
| 823 | raise ManifestParseError('%s: sync-j must be greater than 0, not "%s"' % |
| 824 | (self.manifestFile, d.sync_j)) |
Anatol Pomazau | 79770d2 | 2012-04-20 14:41:59 -0700 | [diff] [blame] | 825 | |
Mike Frysinger | bb8ee7f | 2020-02-22 05:30:12 -0500 | [diff] [blame] | 826 | d.sync_c = XmlBool(node, 'sync-c', False) |
| 827 | d.sync_s = XmlBool(node, 'sync-s', False) |
| 828 | d.sync_tags = XmlBool(node, 'sync-tags', True) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 829 | return d |
| 830 | |
Doug Anderson | 2b8db3c | 2010-11-01 15:08:06 -0700 | [diff] [blame] | 831 | def _ParseNotice(self, node): |
| 832 | """ |
| 833 | reads a <notice> element from the manifest file |
| 834 | |
| 835 | The <notice> element is distinct from other tags in the XML in that the |
| 836 | data is conveyed between the start and end tag (it's not an empty-element |
| 837 | tag). |
| 838 | |
| 839 | The white space (carriage returns, indentation) for the notice element is |
| 840 | relevant and is parsed in a way that is based on how python docstrings work. |
| 841 | In fact, the code is remarkably similar to here: |
| 842 | http://www.python.org/dev/peps/pep-0257/ |
| 843 | """ |
| 844 | # Get the data out of the node... |
| 845 | notice = node.childNodes[0].data |
| 846 | |
| 847 | # Figure out minimum indentation, skipping the first line (the same line |
| 848 | # as the <notice> tag)... |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 849 | minIndent = sys.maxsize |
Doug Anderson | 2b8db3c | 2010-11-01 15:08:06 -0700 | [diff] [blame] | 850 | lines = notice.splitlines() |
| 851 | for line in lines[1:]: |
| 852 | lstrippedLine = line.lstrip() |
| 853 | if lstrippedLine: |
| 854 | indent = len(line) - len(lstrippedLine) |
| 855 | minIndent = min(indent, minIndent) |
| 856 | |
| 857 | # Strip leading / trailing blank lines and also indentation. |
| 858 | cleanLines = [lines[0].strip()] |
| 859 | for line in lines[1:]: |
| 860 | cleanLines.append(line[minIndent:].rstrip()) |
| 861 | |
| 862 | # Clear completely blank lines from front and back... |
| 863 | while cleanLines and not cleanLines[0]: |
| 864 | del cleanLines[0] |
| 865 | while cleanLines and not cleanLines[-1]: |
| 866 | del cleanLines[-1] |
| 867 | |
| 868 | return '\n'.join(cleanLines) |
| 869 | |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 870 | def _JoinName(self, parent_name, name): |
| 871 | return os.path.join(parent_name, name) |
| 872 | |
| 873 | def _UnjoinName(self, parent_name, name): |
| 874 | return os.path.relpath(name, parent_name) |
| 875 | |
David Pursehouse | e5913ae | 2020-02-12 13:56:59 +0900 | [diff] [blame] | 876 | def _ParseProject(self, node, parent=None, **extra_proj_attrs): |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 877 | """ |
| 878 | reads a <project> element from the manifest file |
Nico Sallembien | a1bfd2c | 2010-04-06 10:40:01 -0700 | [diff] [blame] | 879 | """ |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 880 | name = self._reqatt(node, 'name') |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 881 | if parent: |
| 882 | name = self._JoinName(parent.name, name) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 883 | |
| 884 | remote = self._get_remote(node) |
| 885 | if remote is None: |
| 886 | remote = self._default.remote |
| 887 | if remote is None: |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 888 | raise ManifestParseError("no remote for project %s within %s" % |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 889 | (name, self.manifestFile)) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 890 | |
Anthony King | 36ea2fb | 2014-05-06 11:54:01 +0100 | [diff] [blame] | 891 | revisionExpr = node.getAttribute('revision') or remote.revision |
Shawn O. Pearce | 3c8dea1 | 2009-05-29 18:38:17 -0700 | [diff] [blame] | 892 | if not revisionExpr: |
| 893 | revisionExpr = self._default.revisionExpr |
| 894 | if not revisionExpr: |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 895 | raise ManifestParseError("no revision for project %s within %s" % |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 896 | (name, self.manifestFile)) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 897 | |
| 898 | path = node.getAttribute('path') |
| 899 | if not path: |
| 900 | path = name |
| 901 | if path.startswith('/'): |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 902 | raise ManifestParseError("project %s path cannot be absolute in %s" % |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 903 | (name, self.manifestFile)) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 904 | |
Mike Frysinger | bb8ee7f | 2020-02-22 05:30:12 -0500 | [diff] [blame] | 905 | rebase = XmlBool(node, 'rebase', True) |
| 906 | sync_c = XmlBool(node, 'sync-c', False) |
| 907 | sync_s = XmlBool(node, 'sync-s', self._default.sync_s) |
| 908 | sync_tags = XmlBool(node, 'sync-tags', self._default.sync_tags) |
Mike Pontillo | d315382 | 2012-02-28 11:53:24 -0800 | [diff] [blame] | 909 | |
Mike Frysinger | bb8ee7f | 2020-02-22 05:30:12 -0500 | [diff] [blame] | 910 | clone_depth = XmlInt(node, 'clone-depth') |
| 911 | if clone_depth is not None and clone_depth <= 0: |
| 912 | raise ManifestParseError('%s: clone-depth must be greater than 0, not "%s"' % |
| 913 | (self.manifestFile, clone_depth)) |
David Pursehouse | ede7f12 | 2012-11-27 22:25:30 +0900 | [diff] [blame] | 914 | |
Bryan Jacobs | f609f91 | 2013-05-06 13:36:24 -0400 | [diff] [blame] | 915 | dest_branch = node.getAttribute('dest-branch') or self._default.destBranchExpr |
| 916 | |
Nasser Grainawi | da40341 | 2018-05-04 12:53:29 -0600 | [diff] [blame] | 917 | upstream = node.getAttribute('upstream') or self._default.upstreamExpr |
Brian Harring | 14a6674 | 2012-09-28 20:21:57 -0700 | [diff] [blame] | 918 | |
Conley Owens | 971de8e | 2012-04-16 10:36:08 -0700 | [diff] [blame] | 919 | groups = '' |
| 920 | if node.hasAttribute('groups'): |
| 921 | groups = node.getAttribute('groups') |
Josh Triplett | 884a387 | 2014-06-12 14:57:29 -0700 | [diff] [blame] | 922 | groups = self._ParseGroups(groups) |
Brian Harring | 7da1314 | 2012-06-15 02:24:20 -0700 | [diff] [blame] | 923 | |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 924 | if parent is None: |
Mike Frysinger | 979d5bd | 2020-02-09 02:28:34 -0500 | [diff] [blame] | 925 | relpath, worktree, gitdir, objdir, use_git_worktrees = \ |
| 926 | self.GetProjectPaths(name, path) |
Shawn O. Pearce | cd81dd6 | 2012-10-26 12:18:00 -0700 | [diff] [blame] | 927 | else: |
Mike Frysinger | 979d5bd | 2020-02-09 02:28:34 -0500 | [diff] [blame] | 928 | use_git_worktrees = False |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 929 | relpath, worktree, gitdir, objdir = \ |
| 930 | self.GetSubprojectPaths(parent, name, path) |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 931 | |
| 932 | default_groups = ['all', 'name:%s' % name, 'path:%s' % relpath] |
| 933 | groups.extend(set(default_groups).difference(groups)) |
Shawn O. Pearce | cd81dd6 | 2012-10-26 12:18:00 -0700 | [diff] [blame] | 934 | |
Scott Fan | db83b1b | 2013-02-28 09:34:14 +0800 | [diff] [blame] | 935 | if self.IsMirror and node.hasAttribute('force-path'): |
Mike Frysinger | bb8ee7f | 2020-02-22 05:30:12 -0500 | [diff] [blame] | 936 | if XmlBool(node, 'force-path', False): |
Scott Fan | db83b1b | 2013-02-28 09:34:14 +0800 | [diff] [blame] | 937 | gitdir = os.path.join(self.topdir, '%s.git' % path) |
| 938 | |
David Pursehouse | e5913ae | 2020-02-12 13:56:59 +0900 | [diff] [blame] | 939 | project = Project(manifest=self, |
| 940 | name=name, |
| 941 | remote=remote.ToRemoteSpec(name), |
| 942 | gitdir=gitdir, |
| 943 | objdir=objdir, |
| 944 | worktree=worktree, |
| 945 | relpath=relpath, |
| 946 | revisionExpr=revisionExpr, |
| 947 | revisionId=None, |
| 948 | rebase=rebase, |
| 949 | groups=groups, |
| 950 | sync_c=sync_c, |
| 951 | sync_s=sync_s, |
| 952 | sync_tags=sync_tags, |
| 953 | clone_depth=clone_depth, |
| 954 | upstream=upstream, |
| 955 | parent=parent, |
| 956 | dest_branch=dest_branch, |
Mike Frysinger | 979d5bd | 2020-02-09 02:28:34 -0500 | [diff] [blame] | 957 | use_git_worktrees=use_git_worktrees, |
Simran Basi | b9a1b73 | 2015-08-20 12:19:28 -0700 | [diff] [blame] | 958 | **extra_proj_attrs) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 959 | |
| 960 | for n in node.childNodes: |
Shawn O. Pearce | 242b526 | 2009-05-19 13:00:29 -0700 | [diff] [blame] | 961 | if n.nodeName == 'copyfile': |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 962 | self._ParseCopyFile(project, n) |
Jeff Hamilton | e0df232 | 2014-04-21 17:10:59 -0500 | [diff] [blame] | 963 | if n.nodeName == 'linkfile': |
| 964 | self._ParseLinkFile(project, n) |
James W. Mills | 24c1308 | 2012-04-12 15:04:13 -0500 | [diff] [blame] | 965 | if n.nodeName == 'annotation': |
| 966 | self._ParseAnnotation(project, n) |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 967 | if n.nodeName == 'project': |
David Pursehouse | e5913ae | 2020-02-12 13:56:59 +0900 | [diff] [blame] | 968 | project.subprojects.append(self._ParseProject(n, parent=project)) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 969 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 970 | return project |
| 971 | |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 972 | def GetProjectPaths(self, name, path): |
Mike Frysinger | 979d5bd | 2020-02-09 02:28:34 -0500 | [diff] [blame] | 973 | use_git_worktrees = False |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 974 | relpath = path |
| 975 | if self.IsMirror: |
| 976 | worktree = None |
| 977 | gitdir = os.path.join(self.topdir, '%s.git' % name) |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 978 | objdir = gitdir |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 979 | else: |
| 980 | worktree = os.path.join(self.topdir, path).replace('\\', '/') |
| 981 | gitdir = os.path.join(self.repodir, 'projects', '%s.git' % path) |
Mike Frysinger | 979d5bd | 2020-02-09 02:28:34 -0500 | [diff] [blame] | 982 | # We allow people to mix git worktrees & non-git worktrees for now. |
| 983 | # This allows for in situ migration of repo clients. |
| 984 | if os.path.exists(gitdir) or not self.UseGitWorktrees: |
| 985 | objdir = os.path.join(self.repodir, 'project-objects', '%s.git' % name) |
| 986 | else: |
| 987 | use_git_worktrees = True |
| 988 | gitdir = os.path.join(self.repodir, 'worktrees', '%s.git' % name) |
| 989 | objdir = gitdir |
| 990 | return relpath, worktree, gitdir, objdir, use_git_worktrees |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 991 | |
| 992 | def GetProjectsWithName(self, name): |
| 993 | return self._projects.get(name, []) |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 994 | |
| 995 | def GetSubprojectName(self, parent, submodule_path): |
| 996 | return os.path.join(parent.name, submodule_path) |
| 997 | |
| 998 | def _JoinRelpath(self, parent_relpath, relpath): |
| 999 | return os.path.join(parent_relpath, relpath) |
| 1000 | |
| 1001 | def _UnjoinRelpath(self, parent_relpath, relpath): |
| 1002 | return os.path.relpath(relpath, parent_relpath) |
| 1003 | |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 1004 | def GetSubprojectPaths(self, parent, name, path): |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 1005 | relpath = self._JoinRelpath(parent.relpath, path) |
| 1006 | gitdir = os.path.join(parent.gitdir, 'subprojects', '%s.git' % path) |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 1007 | objdir = os.path.join(parent.gitdir, 'subproject-objects', '%s.git' % name) |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 1008 | if self.IsMirror: |
| 1009 | worktree = None |
| 1010 | else: |
| 1011 | worktree = os.path.join(parent.worktree, path).replace('\\', '/') |
David James | 8d20116 | 2013-10-11 17:03:19 -0700 | [diff] [blame] | 1012 | return relpath, worktree, gitdir, objdir |
Che-Liang Chiou | b2bd91c | 2012-01-11 11:28:42 +0800 | [diff] [blame] | 1013 | |
Mike Frysinger | 04122b7 | 2019-07-31 23:32:58 -0400 | [diff] [blame] | 1014 | @staticmethod |
| 1015 | def _CheckLocalPath(path, symlink=False): |
| 1016 | """Verify |path| is reasonable for use in <copyfile> & <linkfile>.""" |
| 1017 | if '~' in path: |
| 1018 | return '~ not allowed (due to 8.3 filenames on Windows filesystems)' |
| 1019 | |
| 1020 | # Some filesystems (like Apple's HFS+) try to normalize Unicode codepoints |
| 1021 | # which means there are alternative names for ".git". Reject paths with |
| 1022 | # these in it as there shouldn't be any reasonable need for them here. |
| 1023 | # The set of codepoints here was cribbed from jgit's implementation: |
| 1024 | # https://eclipse.googlesource.com/jgit/jgit/+/9110037e3e9461ff4dac22fee84ef3694ed57648/org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectChecker.java#884 |
| 1025 | BAD_CODEPOINTS = { |
| 1026 | u'\u200C', # ZERO WIDTH NON-JOINER |
| 1027 | u'\u200D', # ZERO WIDTH JOINER |
| 1028 | u'\u200E', # LEFT-TO-RIGHT MARK |
| 1029 | u'\u200F', # RIGHT-TO-LEFT MARK |
| 1030 | u'\u202A', # LEFT-TO-RIGHT EMBEDDING |
| 1031 | u'\u202B', # RIGHT-TO-LEFT EMBEDDING |
| 1032 | u'\u202C', # POP DIRECTIONAL FORMATTING |
| 1033 | u'\u202D', # LEFT-TO-RIGHT OVERRIDE |
| 1034 | u'\u202E', # RIGHT-TO-LEFT OVERRIDE |
| 1035 | u'\u206A', # INHIBIT SYMMETRIC SWAPPING |
| 1036 | u'\u206B', # ACTIVATE SYMMETRIC SWAPPING |
| 1037 | u'\u206C', # INHIBIT ARABIC FORM SHAPING |
| 1038 | u'\u206D', # ACTIVATE ARABIC FORM SHAPING |
| 1039 | u'\u206E', # NATIONAL DIGIT SHAPES |
| 1040 | u'\u206F', # NOMINAL DIGIT SHAPES |
| 1041 | u'\uFEFF', # ZERO WIDTH NO-BREAK SPACE |
| 1042 | } |
| 1043 | if BAD_CODEPOINTS & set(path): |
| 1044 | # This message is more expansive than reality, but should be fine. |
| 1045 | return 'Unicode combining characters not allowed' |
| 1046 | |
| 1047 | # Assume paths might be used on case-insensitive filesystems. |
| 1048 | path = path.lower() |
| 1049 | |
Mike Frysinger | d925459 | 2020-02-19 22:36:26 -0500 | [diff] [blame] | 1050 | # Split up the path by its components. We can't use os.path.sep exclusively |
| 1051 | # as some platforms (like Windows) will convert / to \ and that bypasses all |
| 1052 | # our constructed logic here. Especially since manifest authors only use |
| 1053 | # / in their paths. |
| 1054 | resep = re.compile(r'[/%s]' % re.escape(os.path.sep)) |
| 1055 | parts = resep.split(path) |
| 1056 | |
Mike Frysinger | ae62541 | 2020-02-10 17:10:03 -0500 | [diff] [blame] | 1057 | # Some people use src="." to create stable links to projects. Lets allow |
| 1058 | # that but reject all other uses of "." to keep things simple. |
Mike Frysinger | ae62541 | 2020-02-10 17:10:03 -0500 | [diff] [blame] | 1059 | if parts != ['.']: |
| 1060 | for part in set(parts): |
| 1061 | if part in {'.', '..', '.git'} or part.startswith('.repo'): |
| 1062 | return 'bad component: %s' % (part,) |
Mike Frysinger | 04122b7 | 2019-07-31 23:32:58 -0400 | [diff] [blame] | 1063 | |
Mike Frysinger | d925459 | 2020-02-19 22:36:26 -0500 | [diff] [blame] | 1064 | if not symlink and resep.match(path[-1]): |
Mike Frysinger | 04122b7 | 2019-07-31 23:32:58 -0400 | [diff] [blame] | 1065 | return 'dirs not allowed' |
| 1066 | |
Mike Frysinger | d925459 | 2020-02-19 22:36:26 -0500 | [diff] [blame] | 1067 | # NB: The two abspath checks here are to handle platforms with multiple |
| 1068 | # filesystem path styles (e.g. Windows). |
Mike Frysinger | 04122b7 | 2019-07-31 23:32:58 -0400 | [diff] [blame] | 1069 | norm = os.path.normpath(path) |
Mike Frysinger | d925459 | 2020-02-19 22:36:26 -0500 | [diff] [blame] | 1070 | if (norm == '..' or |
| 1071 | (len(norm) >= 3 and norm.startswith('..') and resep.match(norm[0])) or |
| 1072 | os.path.isabs(norm) or |
| 1073 | norm.startswith('/')): |
Mike Frysinger | 04122b7 | 2019-07-31 23:32:58 -0400 | [diff] [blame] | 1074 | return 'path cannot be outside' |
| 1075 | |
| 1076 | @classmethod |
| 1077 | def _ValidateFilePaths(cls, element, src, dest): |
| 1078 | """Verify |src| & |dest| are reasonable for <copyfile> & <linkfile>. |
| 1079 | |
| 1080 | We verify the path independent of any filesystem state as we won't have a |
| 1081 | checkout available to compare to. i.e. This is for parsing validation |
| 1082 | purposes only. |
| 1083 | |
| 1084 | We'll do full/live sanity checking before we do the actual filesystem |
| 1085 | modifications in _CopyFile/_LinkFile/etc... |
| 1086 | """ |
| 1087 | # |dest| is the file we write to or symlink we create. |
| 1088 | # It is relative to the top of the repo client checkout. |
| 1089 | msg = cls._CheckLocalPath(dest) |
| 1090 | if msg: |
| 1091 | raise ManifestInvalidPathError( |
| 1092 | '<%s> invalid "dest": %s: %s' % (element, dest, msg)) |
| 1093 | |
| 1094 | # |src| is the file we read from or path we point to for symlinks. |
| 1095 | # It is relative to the top of the git project checkout. |
| 1096 | msg = cls._CheckLocalPath(src, symlink=element == 'linkfile') |
| 1097 | if msg: |
| 1098 | raise ManifestInvalidPathError( |
| 1099 | '<%s> invalid "src": %s: %s' % (element, src, msg)) |
| 1100 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 1101 | def _ParseCopyFile(self, project, node): |
| 1102 | src = self._reqatt(node, 'src') |
| 1103 | dest = self._reqatt(node, 'dest') |
Shawn O. Pearce | e284ad1 | 2008-11-04 07:37:10 -0800 | [diff] [blame] | 1104 | if not self.IsMirror: |
| 1105 | # src is project relative; |
Mike Frysinger | 04122b7 | 2019-07-31 23:32:58 -0400 | [diff] [blame] | 1106 | # dest is relative to the top of the tree. |
| 1107 | # We only validate paths if we actually plan to process them. |
| 1108 | self._ValidateFilePaths('copyfile', src, dest) |
Mike Frysinger | e6a202f | 2019-08-02 15:57:57 -0400 | [diff] [blame] | 1109 | project.AddCopyFile(src, dest, self.topdir) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 1110 | |
Jeff Hamilton | e0df232 | 2014-04-21 17:10:59 -0500 | [diff] [blame] | 1111 | def _ParseLinkFile(self, project, node): |
| 1112 | src = self._reqatt(node, 'src') |
| 1113 | dest = self._reqatt(node, 'dest') |
| 1114 | if not self.IsMirror: |
| 1115 | # src is project relative; |
Mike Frysinger | 04122b7 | 2019-07-31 23:32:58 -0400 | [diff] [blame] | 1116 | # dest is relative to the top of the tree. |
| 1117 | # We only validate paths if we actually plan to process them. |
| 1118 | self._ValidateFilePaths('linkfile', src, dest) |
Mike Frysinger | e6a202f | 2019-08-02 15:57:57 -0400 | [diff] [blame] | 1119 | project.AddLinkFile(src, dest, self.topdir) |
Jeff Hamilton | e0df232 | 2014-04-21 17:10:59 -0500 | [diff] [blame] | 1120 | |
James W. Mills | 24c1308 | 2012-04-12 15:04:13 -0500 | [diff] [blame] | 1121 | def _ParseAnnotation(self, project, node): |
| 1122 | name = self._reqatt(node, 'name') |
| 1123 | value = self._reqatt(node, 'value') |
| 1124 | try: |
| 1125 | keep = self._reqatt(node, 'keep').lower() |
| 1126 | except ManifestParseError: |
| 1127 | keep = "true" |
| 1128 | if keep != "true" and keep != "false": |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 1129 | raise ManifestParseError('optional "keep" attribute must be ' |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 1130 | '"true" or "false"') |
James W. Mills | 24c1308 | 2012-04-12 15:04:13 -0500 | [diff] [blame] | 1131 | project.AddAnnotation(name, value, keep) |
| 1132 | |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 1133 | def _get_remote(self, node): |
| 1134 | name = node.getAttribute('remote') |
| 1135 | if not name: |
| 1136 | return None |
| 1137 | |
| 1138 | v = self._remotes.get(name) |
| 1139 | if not v: |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 1140 | raise ManifestParseError("remote %s not defined in %s" % |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 1141 | (name, self.manifestFile)) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 1142 | return v |
| 1143 | |
| 1144 | def _reqatt(self, node, attname): |
| 1145 | """ |
| 1146 | reads a required attribute from the node. |
| 1147 | """ |
| 1148 | v = node.getAttribute(attname) |
| 1149 | if not v: |
Chirayu Desai | 217ea7d | 2013-03-01 19:14:38 +0530 | [diff] [blame] | 1150 | raise ManifestParseError("no %s in <%s> within %s" % |
David Pursehouse | abdf750 | 2020-02-12 14:58:39 +0900 | [diff] [blame] | 1151 | (attname, node.nodeName, self.manifestFile)) |
The Android Open Source Project | cf31fe9 | 2008-10-21 07:00:00 -0700 | [diff] [blame] | 1152 | return v |
Julien Campergue | dd65422 | 2014-01-09 16:21:37 +0100 | [diff] [blame] | 1153 | |
| 1154 | def projectsDiff(self, manifest): |
| 1155 | """return the projects differences between two manifests. |
| 1156 | |
| 1157 | The diff will be from self to given manifest. |
| 1158 | |
| 1159 | """ |
| 1160 | fromProjects = self.paths |
| 1161 | toProjects = manifest.paths |
| 1162 | |
Anthony King | 7446c59 | 2014-05-06 09:19:39 +0100 | [diff] [blame] | 1163 | fromKeys = sorted(fromProjects.keys()) |
| 1164 | toKeys = sorted(toProjects.keys()) |
Julien Campergue | dd65422 | 2014-01-09 16:21:37 +0100 | [diff] [blame] | 1165 | |
| 1166 | diff = {'added': [], 'removed': [], 'changed': [], 'unreachable': []} |
| 1167 | |
| 1168 | for proj in fromKeys: |
David Pursehouse | eeff353 | 2020-02-12 11:24:10 +0900 | [diff] [blame] | 1169 | if proj not in toKeys: |
Julien Campergue | dd65422 | 2014-01-09 16:21:37 +0100 | [diff] [blame] | 1170 | diff['removed'].append(fromProjects[proj]) |
| 1171 | else: |
| 1172 | fromProj = fromProjects[proj] |
| 1173 | toProj = toProjects[proj] |
| 1174 | try: |
| 1175 | fromRevId = fromProj.GetCommitRevisionId() |
| 1176 | toRevId = toProj.GetCommitRevisionId() |
| 1177 | except ManifestInvalidRevisionError: |
| 1178 | diff['unreachable'].append((fromProj, toProj)) |
| 1179 | else: |
| 1180 | if fromRevId != toRevId: |
| 1181 | diff['changed'].append((fromProj, toProj)) |
| 1182 | toKeys.remove(proj) |
| 1183 | |
| 1184 | for proj in toKeys: |
| 1185 | diff['added'].append(toProjects[proj]) |
| 1186 | |
| 1187 | return diff |
Simran Basi | b9a1b73 | 2015-08-20 12:19:28 -0700 | [diff] [blame] | 1188 | |
| 1189 | |
| 1190 | class GitcManifest(XmlManifest): |
| 1191 | |
| 1192 | def __init__(self, repodir, gitc_client_name): |
| 1193 | """Initialize the GitcManifest object.""" |
| 1194 | super(GitcManifest, self).__init__(repodir) |
| 1195 | self.isGitcClient = True |
| 1196 | self.gitc_client_name = gitc_client_name |
Simran Basi | 8ce5041 | 2015-08-28 14:25:44 -0700 | [diff] [blame] | 1197 | self.gitc_client_dir = os.path.join(gitc_utils.get_gitc_manifest_dir(), |
Simran Basi | b9a1b73 | 2015-08-20 12:19:28 -0700 | [diff] [blame] | 1198 | gitc_client_name) |
| 1199 | self.manifestFile = os.path.join(self.gitc_client_dir, '.manifest') |
| 1200 | |
David Pursehouse | e5913ae | 2020-02-12 13:56:59 +0900 | [diff] [blame] | 1201 | def _ParseProject(self, node, parent=None): |
Simran Basi | b9a1b73 | 2015-08-20 12:19:28 -0700 | [diff] [blame] | 1202 | """Override _ParseProject and add support for GITC specific attributes.""" |
| 1203 | return super(GitcManifest, self)._ParseProject( |
| 1204 | node, parent=parent, old_revision=node.getAttribute('old-revision')) |
| 1205 | |
| 1206 | def _output_manifest_project_extras(self, p, e): |
| 1207 | """Output GITC Specific Project attributes""" |
| 1208 | if p.old_revision: |
Stefan Beller | 6685106 | 2016-06-17 16:40:08 -0700 | [diff] [blame] | 1209 | e.setAttribute('old-revision', str(p.old_revision)) |