Coding style cleanup
Fix the following issues reported by pylint:
C0321: More than one statement on a single line
W0622: Redefining built-in 'name'
W0612: Unused variable 'name'
W0613: Unused argument 'name'
W0102: Dangerous default value 'value' as argument
W0105: String statement has no effect
Also fixed a few cases of inconsistent indentation.
Change-Id: Ie0db839e7c57d576cff12d8c055fe87030d00744
diff --git a/subcmds/overview.py b/subcmds/overview.py
index 96fa93d..a509bd9 100644
--- a/subcmds/overview.py
+++ b/subcmds/overview.py
@@ -38,16 +38,16 @@
help="Consider only checked out branches")
def Execute(self, opt, args):
- all = []
+ all_branches = []
for project in self.GetProjects(args):
br = [project.GetUploadableBranch(x)
for x in project.GetBranches().keys()]
br = [x for x in br if x]
if opt.current_branch:
br = [x for x in br if x.name == project.CurrentBranch]
- all.extend(br)
+ all_branches.extend(br)
- if not all:
+ if not all_branches:
return
class Report(Coloring):
@@ -55,13 +55,13 @@
Coloring.__init__(self, config, 'status')
self.project = self.printer('header', attr='bold')
- out = Report(all[0].project.config)
+ out = Report(all_branches[0].project.config)
out.project('Projects Overview')
out.nl()
project = None
- for branch in all:
+ for branch in all_branches:
if project != branch.project:
project = branch.project
out.nl()