commit 87058c6ca5ec2c66d0850f1015de01ec6c0dd758
author Jason Chang <jasonnc@google.com> Wed Sep 27 11:34:43 2023 -0700
committer LUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 27 19:05:16 2023 +0000
tree fdd8233c570dadb44dac658137f5a441a87b670e
parent b5644160b74e70e223caa62ad0ca2ce8310cfb87

Track expected git errors in logs

Sometimes it is expected that a GitCommand executed in repo fails. In
such cases indicate in trace logs that the error was expected.

Bug: b/293344017
Change-Id: If137fae9ef9769258246f5b4494e070345db4a71
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/387714
Commit-Queue: Jason Chang <jasonnc@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Tested-by: Jason Chang <jasonnc@google.com>

git_command.py

diff --git a/git_command.py b/git_command.py
index 71b464c..fe1e48d 100644
--- a/git_command.py
+++ b/git_command.py
@@ -286,6 +286,7 @@
         objdir=None,
         verify_command=False,
         add_event_log=True,
+        log_as_error=True,
     ):
         if project:
             if not cwd:
@@ -362,6 +363,7 @@
                         "ReturnCode": str(e.git_rc)
                         if e.git_rc is not None
                         else None,
+                        "IsError": log_as_error,
                     }
                 )
                 event_log.ErrorEvent(