commit 6964ae8d52d42d2821572fc8359e56c821289e00
author Rasmus Munk Larsen <rmlarsen@google.com> Tue Jul 07 01:54:04 2020 +0000
committer Rasmus Munk Larsen <rmlarsen@google.com> Tue Jul 07 01:54:04 2020 +0000
tree 18eee0bf5a4d10d026420a540879d908e9bb9fc6
parent cb6315318316653479b184db447bc29040be8e6e

Change the sign operator in Eigen to return NaN for NaN arguments, not zero.

test/array_cwise.cpp

diff --git a/test/array_cwise.cpp b/test/array_cwise.cpp
index b3fb59b..48c0935 100644
--- a/test/array_cwise.cpp
+++ b/test/array_cwise.cpp
@@ -309,7 +309,7 @@
   VERIFY_IS_APPROX(m1.cube(), cube(m1));
   VERIFY_IS_APPROX(cos(m1+RealScalar(3)*m2), cos((m1+RealScalar(3)*m2).eval()));
   VERIFY_IS_APPROX(m1.sign(), sign(m1));
-
+  VERIFY((m1.sqrt().sign().isNaN() == (Eigen::isnan)(sign(sqrt(m1)))).all());
 
   // avoid NaNs with abs() so verification doesn't fail
   m3 = m1.abs();