commit e7d8cce28f6886ee4fe4db25ef3faeb5f05ef9d7
author Marshall Clow <mclow.lists@gmail.com> Thu Jul 31 01:18:05 2014 +0000
committer Marshall Clow <mclow.lists@gmail.com> Thu Jul 31 01:18:05 2014 +0000
tree 933d20f48607868751e358447d668101ebfc1fe5
parent 7ed4234aa8b40fc62aa8f9f7013b9d3b730ee791

Fix numeric_limits<XXX>::is_modulo for signed arithmetic types. We were reporting true, for all arithmetic types, which is incorrect. Fix the tests which were wrong, too. This fixes PR#20158.

llvm-svn: 214371
Cr-Mirrored-From: sso://chromium.googlesource.com/_direct/external/github.com/llvm/llvm-project
Cr-Mirrored-Commit: 6a577a819f5b942e3a7f6212c2f0059e9fef8ad3

include/limits

diff --git a/include/limits b/include/limits
index 2216966..1acf03e 100644
--- a/include/limits
+++ b/include/limits
@@ -235,7 +235,7 @@
 
     static _LIBCPP_CONSTEXPR const bool is_iec559 = false;
     static _LIBCPP_CONSTEXPR const bool is_bounded = true;
-    static _LIBCPP_CONSTEXPR const bool is_modulo = true;
+    static _LIBCPP_CONSTEXPR const bool is_modulo = !_VSTD::is_signed<_Tp>::value;
 
 #if __i386__ || __x86_64__
     static _LIBCPP_CONSTEXPR const bool traps = true;

test/language.support/support.limits/limits/numeric.limits.members/is_modulo.pass.cpp

diff --git a/test/language.support/support.limits/limits/numeric.limits.members/is_modulo.pass.cpp b/test/language.support/support.limits/limits/numeric.limits.members/is_modulo.pass.cpp
index fadc015..6a60996 100644
--- a/test/language.support/support.limits/limits/numeric.limits.members/is_modulo.pass.cpp
+++ b/test/language.support/support.limits/limits/numeric.limits.members/is_modulo.pass.cpp
@@ -26,24 +26,24 @@
 int main()
 {
     test<bool, false>();
-    test<char, true>();
-    test<signed char, true>();
+//    test<char, false>(); // don't know
+    test<signed char, false>();
     test<unsigned char, true>();
-    test<wchar_t, true>();
+//    test<wchar_t, false>(); // don't know
 #ifndef _LIBCPP_HAS_NO_UNICODE_CHARS
     test<char16_t, true>();
     test<char32_t, true>();
 #endif  // _LIBCPP_HAS_NO_UNICODE_CHARS
-    test<short, true>();
+    test<short, false>();
     test<unsigned short, true>();
-    test<int, true>();
+    test<int, false>();
     test<unsigned int, true>();
-    test<long, true>();
+    test<long, false>();
     test<unsigned long, true>();
-    test<long long, true>();
+    test<long long, false>();
     test<unsigned long long, true>();
 #ifndef _LIBCPP_HAS_NO_INT128
-    test<__int128_t, true>();
+    test<__int128_t, false>();
     test<__uint128_t, true>();
 #endif
     test<float, false>();