Implement LWG#2579: Inconsistency wrt Allocators in basic_string assignment vs. basic_string::assign

llvm-svn: 263042
Cr-Mirrored-From: sso://chromium.googlesource.com/_direct/external/github.com/llvm/llvm-project
Cr-Mirrored-Commit: ffc888bc09120f904c66d764ac6943b1ef739395
diff --git a/include/string b/include/string
index 6f5089c..b937d29 100644
--- a/include/string
+++ b/include/string
@@ -1551,7 +1551,7 @@
     _LIBCPP_INLINE_VISIBILITY const_reference back() const;
 
     _LIBCPP_INLINE_VISIBILITY
-    basic_string& assign(const basic_string& __str);
+    basic_string& assign(const basic_string& __str) { return *this = __str; }
 #ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES
     _LIBCPP_INLINE_VISIBILITY
     basic_string& assign(basic_string&& str)
@@ -2489,7 +2489,7 @@
     if (this != &__str)
     {
         __copy_assign_alloc(__str);
-        assign(__str);
+        assign(__str.data(), __str.size());
     }
     return *this;
 }
@@ -2581,14 +2581,6 @@
 }
 
 template <class _CharT, class _Traits, class _Allocator>
-inline _LIBCPP_INLINE_VISIBILITY
-basic_string<_CharT, _Traits, _Allocator>&
-basic_string<_CharT, _Traits, _Allocator>::assign(const basic_string& __str)
-{
-    return assign(__str.data(), __str.size());
-}
-
-template <class _CharT, class _Traits, class _Allocator>
 basic_string<_CharT, _Traits, _Allocator>&
 basic_string<_CharT, _Traits, _Allocator>::assign(const basic_string& __str, size_type __pos, size_type __n)
 {