commit 66fd4310b29b5c9a8f610f60cc707af7b347d3af
author Eric Fiselier <eric@efcs.ca> Mon Oct 01 01:00:11 2018 +0000
committer Eric Fiselier <eric@efcs.ca> Mon Oct 01 01:00:11 2018 +0000
tree 23e824cf6762a90e2ca81e5208f594501f4072f5
parent 93b21c9b9c024a135579c8b9dc9ad3caa12f7751

Attempt to unbreak Windows configuration.

Although libc++ doesn't yet support Windows we still have Windows
builders to track our progress.

Currently the clang-cl configuration seems broken because it doesn't
support -std=c++11 and instead requires /std:c++11. This patch attempts
to fix this.

llvm-svn: 343431
Cr-Mirrored-From: sso://chromium.googlesource.com/_direct/external/github.com/llvm/llvm-project
Cr-Mirrored-Commit: 11edd935c8516f92841ca372aca86f20a002ce7f

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index c87e356..fb866e1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -53,6 +53,7 @@
 
 if (MSVC)
   set(LIBCXX_TARGETING_MSVC ON)
+  message(STATUS "Configuring for MSVC")
 else()
   set(LIBCXX_TARGETING_MSVC OFF)
 endif()
@@ -504,8 +505,10 @@
   set(LIBCXX_STANDARD_VER c++14 CACHE INTERNAL "internal option to change build dialect")
 endif()
 add_compile_flags_if_supported(-std=${LIBCXX_STANDARD_VER})
+add_compile_flags_if_supported("/std:${LIBCXX_STANDARD_VER}")
 mangle_name("LIBCXX_SUPPORTS_STD_EQ_${LIBCXX_STANDARD_VER}_FLAG" SUPPORTS_DIALECT_NAME)
-if(NOT ${SUPPORTS_DIALECT_NAME})
+mangle_name("LIBCXX_SUPPORTS_STD_COLON_${LIBCXX_STANDARD_VER}_FLAG" SUPPORTS_DIALECT_NAME_MSVC)
+if(NOT ${SUPPORTS_DIALECT_NAME} AND NOT ${SUPPORTS_DIALECT_NAME_MSVC})
   if(NOT "${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" AND NOT "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
     message(FATAL_ERROR "C++11 or greater is required but the compiler does not support ${LIBCXX_STANDARD_VER}")
   endif()

cmake/Modules/HandleLibcxxFlags.cmake

diff --git a/cmake/Modules/HandleLibcxxFlags.cmake b/cmake/Modules/HandleLibcxxFlags.cmake
index 65f7d18..24fe0c5 100644
--- a/cmake/Modules/HandleLibcxxFlags.cmake
+++ b/cmake/Modules/HandleLibcxxFlags.cmake
@@ -16,6 +16,7 @@
   string(REGEX REPLACE "^-+" "" strippedStr "${strippedStr}")
   string(REGEX REPLACE "-+$" "" strippedStr "${strippedStr}")
   string(REPLACE "-" "_" strippedStr "${strippedStr}")
+  string(REPLACE ":" "_COLON_" strippedStr "${strippedStr}")
   string(REPLACE "=" "_EQ_" strippedStr "${strippedStr}")
   string(REPLACE "+" "X" strippedStr "${strippedStr}")
   string(TOUPPER "${strippedStr}" ${output})