commit 5d2d7392a02ad0cea512d099a79cf1e486f36988
author Nikolas Klauser <nikolasklauser@berlin.de> Thu Nov 10 23:57:43 2022 +0100
committer Copybara-Service <copybara-worker@google.com> Wed Nov 23 15:46:15 2022 -0800
tree ed7eb6b9dd046d9499ea50b68236c693baf68341
parent 44ad48b67d3cbac16c509e41084f2f2e9b9faccf

[libc++][clang-tidy] Enable readability-simplify-boolean-expr

Reviewed By: ldionne, #libc

Spies: Eugene.Zelenko, aheejin, libcxx-commits, xazax.hun

Differential Revision: https://reviews.llvm.org/D137804

NOKEYCHECK=True
GitOrigin-RevId: 3574b800cf72c3209e6200eee9fb93fd0228ad5f

include/fstream

diff --git a/include/fstream b/include/fstream
index b8417f3..65b22a4 100644
--- a/include/fstream
+++ b/include/fstream
@@ -753,9 +753,10 @@
         }
         else
         {
-            _LIBCPP_ASSERT ( !(__extbufnext_ == NULL && (__extbufend_ != __extbufnext_)), "underflow moving from NULL" );
-            if (__extbufend_ != __extbufnext_)
+            if (__extbufend_ != __extbufnext_) {
+                _LIBCPP_ASSERT(__extbufnext_ != nullptr, "underflow moving from NULL" );
                 _VSTD::memmove(__extbuf_, __extbufnext_, __extbufend_ - __extbufnext_);
+            }
             __extbufnext_ = __extbuf_ + (__extbufend_ - __extbufnext_);
             __extbufend_ = __extbuf_ + (__extbuf_ == __extbuf_min_ ? sizeof(__extbuf_min_) : __ebs_);
             size_t __nmemb = _VSTD::min(static_cast<size_t>(__ibs_ - __unget_sz),