Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 1 | /* |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 2 | * Copyright (c) 2015-2022 The Khronos Group Inc. |
| 3 | * Copyright (c) 2015-2022 Valve Corporation |
| 4 | * Copyright (c) 2015-2022 LunarG, Inc. |
| 5 | * Copyright (c) 2015-2022 Google, Inc. |
| 6 | * Modifications Copyright (C) 2020-2022 Advanced Micro Devices, Inc. All rights reserved. |
Tony-LunarG | 4c25337 | 2022-01-18 13:51:07 -0700 | [diff] [blame] | 7 | * Modifications Copyright (C) 2021-2022 ARM, Inc. All rights reserved. |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 8 | * |
| 9 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 10 | * you may not use this file except in compliance with the License. |
| 11 | * You may obtain a copy of the License at |
| 12 | * |
| 13 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 14 | * |
| 15 | */ |
| 16 | |
| 17 | #include "cast_utils.h" |
| 18 | #include "layer_validation_tests.h" |
| 19 | |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 20 | TEST_F(VkLayerTest, DynamicRenderingCommandBufferInheritanceRenderingInfo) { |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 21 | TEST_DESCRIPTION("VkCommandBufferInheritanceRenderingInfoKHR Dynamic Rendering Tests."); |
| 22 | |
| 23 | uint32_t version = SetTargetApiVersion(VK_API_VERSION_1_2); |
| 24 | if (version < VK_API_VERSION_1_2) { |
| 25 | printf("%s At least Vulkan version 1.2 is required, skipping test.\n", kSkipPrefix); |
| 26 | return; |
| 27 | } |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 28 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 29 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
Nathaniel Cesario | a06135e | 2022-03-02 21:22:30 -0700 | [diff] [blame] | 30 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 31 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 32 | if (!AreRequiredExtensionsEnabled()) { |
| 33 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 34 | } |
| 35 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 36 | if (DeviceValidationVersion() < VK_API_VERSION_1_2) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 37 | GTEST_SKIP() << "At least Vulkan version 1.2 is required"; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 38 | } |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 39 | |
Nathaniel Cesario | a06135e | 2022-03-02 21:22:30 -0700 | [diff] [blame] | 40 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 41 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 42 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 43 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 44 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 45 | } |
| 46 | |
ziga-lunarg | f54cb2a | 2022-03-11 02:54:27 +0100 | [diff] [blame] | 47 | features2.features.variableMultisampleRate = VK_FALSE; |
| 48 | |
Nathaniel Cesario | a06135e | 2022-03-02 21:22:30 -0700 | [diff] [blame] | 49 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT)); |
| 50 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 51 | VkPhysicalDeviceMultiviewProperties multiview_props = LvlInitStruct<VkPhysicalDeviceMultiviewProperties>(); |
| 52 | VkPhysicalDeviceProperties2 pd_props2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&multiview_props); |
| 53 | vk::GetPhysicalDeviceProperties2(gpu(), &pd_props2); |
| 54 | |
| 55 | if (multiview_props.maxMultiviewViewCount == 32) { |
| 56 | printf("%s VUID is not testable as maxMultiviewViewCount is 32, skipping test\n", kSkipPrefix); |
| 57 | return; |
| 58 | } |
| 59 | |
| 60 | VkFormat color_format = VK_FORMAT_D32_SFLOAT; |
| 61 | |
| 62 | auto cmd_buffer_inheritance_rendering_info = LvlInitStruct<VkCommandBufferInheritanceRenderingInfoKHR>(); |
| 63 | cmd_buffer_inheritance_rendering_info.colorAttachmentCount = 1; |
| 64 | cmd_buffer_inheritance_rendering_info.pColorAttachmentFormats = &color_format; |
| 65 | cmd_buffer_inheritance_rendering_info.depthAttachmentFormat = VK_FORMAT_R8G8B8_UNORM; |
| 66 | cmd_buffer_inheritance_rendering_info.stencilAttachmentFormat = VK_FORMAT_R8G8B8_SNORM; |
| 67 | cmd_buffer_inheritance_rendering_info.viewMask = 1 << multiview_props.maxMultiviewViewCount; |
| 68 | |
| 69 | auto sample_count_info_amd = LvlInitStruct<VkAttachmentSampleCountInfoAMD>(); |
| 70 | sample_count_info_amd.pNext = &cmd_buffer_inheritance_rendering_info; |
| 71 | sample_count_info_amd.colorAttachmentCount = 2; |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 72 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 73 | auto cmd_buffer_inheritance_info = LvlInitStruct<VkCommandBufferInheritanceInfo>(); |
| 74 | cmd_buffer_inheritance_info.pNext = &sample_count_info_amd; |
| 75 | |
| 76 | auto cmd_buffer_allocate_info = LvlInitStruct<VkCommandBufferAllocateInfo>(); |
| 77 | cmd_buffer_allocate_info.commandPool = m_commandPool->handle(); |
| 78 | cmd_buffer_allocate_info.level = VK_COMMAND_BUFFER_LEVEL_SECONDARY; |
| 79 | cmd_buffer_allocate_info.commandBufferCount = 0x1; |
| 80 | |
| 81 | VkCommandBuffer secondary_cmd_buffer; |
| 82 | VkResult err = vk::AllocateCommandBuffers(m_device->device(), &cmd_buffer_allocate_info, &secondary_cmd_buffer); |
| 83 | ASSERT_VK_SUCCESS(err); |
| 84 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferBeginInfo-flags-06003"); |
Tony-LunarG | bbd2ab9 | 2021-12-02 08:31:24 -0700 | [diff] [blame] | 85 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-colorAttachmentCount-06004"); |
| 86 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-variableMultisampleRate-06005"); |
| 87 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-depthAttachmentFormat-06007"); |
| 88 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-multiview-06008"); |
| 89 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-viewMask-06009"); |
ziga-lunarg | 813fa01 | 2022-04-09 14:09:57 +0200 | [diff] [blame] | 90 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-stencilAttachmentFormat-06199"); |
| 91 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-depthAttachmentFormat-06200"); |
| 92 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-pColorAttachmentFormats-06006"); |
| 93 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-depthAttachmentFormat-06540"); |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 94 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-stencilAttachmentFormat-06541"); |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 95 | |
| 96 | VkCommandBufferBeginInfo cmd_buffer_begin_info = LvlInitStruct<VkCommandBufferBeginInfo>(); |
| 97 | cmd_buffer_begin_info.flags = VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT; |
| 98 | cmd_buffer_begin_info.pInheritanceInfo = &cmd_buffer_inheritance_info; |
| 99 | vk::BeginCommandBuffer(secondary_cmd_buffer, &cmd_buffer_begin_info); |
| 100 | m_errorMonitor->VerifyFound(); |
| 101 | } |
| 102 | |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 103 | TEST_F(VkLayerTest, DynamicRenderingCommandDraw) { |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 104 | TEST_DESCRIPTION("vkCmdDraw* Dynamic Rendering Tests."); |
| 105 | |
| 106 | uint32_t version = SetTargetApiVersion(VK_API_VERSION_1_2); |
| 107 | if (version < VK_API_VERSION_1_2) { |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 108 | GTEST_SKIP() << "At least Vulkan version 1.2 is required, skipping test."; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 109 | } |
| 110 | |
| 111 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 112 | |
| 113 | ASSERT_NO_FATAL_FAILURE(InitFramework(m_errorMonitor)); |
| 114 | |
| 115 | if (DeviceValidationVersion() < VK_API_VERSION_1_2) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 116 | GTEST_SKIP() << "At least Vulkan version 1.2 is required"; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 117 | } |
| 118 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 119 | if (!AreRequiredExtensionsEnabled()) { |
| 120 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 121 | } |
| 122 | |
| 123 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 124 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 125 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 126 | if (!dynamic_rendering_features.dynamicRendering) { |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 127 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering , skipping."; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 128 | } |
| 129 | |
| 130 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 131 | |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 132 | VkShaderObj vs(this, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX_BIT); |
| 133 | VkShaderObj fs(this, bindStateFragShaderText, VK_SHADER_STAGE_FRAGMENT_BIT); |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 134 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 135 | auto ds_state = LvlInitStruct<VkPipelineDepthStencilStateCreateInfo>(); |
| 136 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 137 | VkPipelineObj pipe(m_device); |
| 138 | pipe.AddShader(&vs); |
| 139 | pipe.AddShader(&fs); |
| 140 | pipe.AddDefaultColorAttachment(); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 141 | pipe.SetDepthStencil(&ds_state); |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 142 | |
| 143 | VkDescriptorSetLayoutBinding dslb = {0, VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, 1, VK_SHADER_STAGE_FRAGMENT_BIT, nullptr}; |
| 144 | const VkDescriptorSetLayoutObj dsl(m_device, {dslb}); |
| 145 | const VkPipelineLayoutObj pl(m_device, {&dsl}); |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 146 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 147 | VkFormat depth_format = VK_FORMAT_D32_SFLOAT_S8_UINT; |
| 148 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 149 | pipeline_rendering_info.depthAttachmentFormat = depth_format; |
| 150 | pipeline_rendering_info.stencilAttachmentFormat = depth_format; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 151 | |
| 152 | auto multisample_state_create_info = LvlInitStruct<VkPipelineMultisampleStateCreateInfo>(); |
| 153 | multisample_state_create_info.rasterizationSamples = VK_SAMPLE_COUNT_2_BIT; |
| 154 | |
| 155 | auto create_info = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 156 | pipe.InitGraphicsPipelineCreateInfo(&create_info); |
| 157 | create_info.pMultisampleState = &multisample_state_create_info; |
| 158 | create_info.renderPass = VkRenderPass(0x1); |
| 159 | create_info.pNext = &pipeline_rendering_info; |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 160 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 161 | VkResult err = pipe.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info); |
| 162 | ASSERT_VK_SUCCESS(err); |
| 163 | |
| 164 | VkViewport viewport = {0, 0, 16, 16, 0, 1}; |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 165 | VkRect2D scissor = {{0, 0}, {16, 16}}; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 166 | |
| 167 | VkImageObj image(m_device); |
| 168 | image.Init(32, 32, 1, depth_format, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, VK_IMAGE_TILING_LINEAR, 0); |
| 169 | ASSERT_TRUE(image.initialized()); |
| 170 | |
| 171 | VkImageViewCreateInfo ivci = {VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO, |
| 172 | nullptr, |
| 173 | 0, |
| 174 | image.handle(), |
| 175 | VK_IMAGE_VIEW_TYPE_2D, |
| 176 | depth_format, |
| 177 | {VK_COMPONENT_SWIZZLE_IDENTITY, VK_COMPONENT_SWIZZLE_IDENTITY, VK_COMPONENT_SWIZZLE_IDENTITY, |
| 178 | VK_COMPONENT_SWIZZLE_IDENTITY}, |
| 179 | {VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT, 0, 1, 0, 1}}; |
| 180 | |
paul-lunarg | 18e1634 | 2022-07-12 14:02:23 -0600 | [diff] [blame] | 181 | vk_testing::ImageView depth_image_view(*m_device, ivci); |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 182 | |
| 183 | VkRenderingAttachmentInfoKHR depth_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 184 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_OPTIMAL; |
paul-lunarg | 18e1634 | 2022-07-12 14:02:23 -0600 | [diff] [blame] | 185 | depth_attachment.imageView = depth_image_view.handle(); |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 186 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 187 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 188 | begin_rendering_info.pDepthAttachment = &depth_attachment; |
| 189 | begin_rendering_info.pStencilAttachment = &depth_attachment; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 190 | begin_rendering_info.layerCount = 1; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 191 | |
| 192 | m_commandBuffer->begin(); |
| 193 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 194 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.handle()); |
| 195 | vk::CmdSetViewport(m_commandBuffer->handle(), 0, 1, &viewport); |
| 196 | vk::CmdSetScissor(m_commandBuffer->handle(), 0, 1, &scissor); |
| 197 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-pDepthAttachment-06189"); |
| 198 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-pStencilAttachment-06190"); |
| 199 | vk::CmdDraw(m_commandBuffer->handle(), 3, 1, 0, 0); |
| 200 | m_errorMonitor->VerifyFound(); |
| 201 | m_commandBuffer->EndRendering(); |
| 202 | m_commandBuffer->end(); |
| 203 | } |
| 204 | |
| 205 | TEST_F(VkLayerTest, DynamicRenderingGraphicsPipelineCreateInfo) { |
| 206 | TEST_DESCRIPTION("Test graphics pipeline creation with dynamic rendering."); |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 207 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 208 | uint32_t version = SetTargetApiVersion(VK_API_VERSION_1_2); |
| 209 | if (version < VK_API_VERSION_1_2) { |
| 210 | printf("%s At least Vulkan version 1.2 is required, skipping test.\n", kSkipPrefix); |
| 211 | return; |
| 212 | } |
| 213 | |
| 214 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 215 | |
| 216 | ASSERT_NO_FATAL_FAILURE(InitFramework(m_errorMonitor)); |
| 217 | |
| 218 | if (DeviceValidationVersion() < VK_API_VERSION_1_2) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 219 | GTEST_SKIP() << "At least Vulkan version 1.2 is required"; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 220 | } |
| 221 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 222 | if (!AreRequiredExtensionsEnabled()) { |
| 223 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 224 | } |
| 225 | |
| 226 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 227 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 228 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 229 | if (!dynamic_rendering_features.dynamicRendering) { |
| 230 | printf("%s Test requires (unsupported) dynamicRendering , skipping\n", kSkipPrefix); |
| 231 | return; |
| 232 | } |
| 233 | |
| 234 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 235 | |
| 236 | const VkPipelineLayoutObj pl(m_device); |
| 237 | VkPipelineObj pipe(m_device); |
| 238 | |
| 239 | VkPipelineColorBlendAttachmentState color_blend_attachment_state = {}; |
| 240 | |
| 241 | auto color_blend_state_create_info = LvlInitStruct<VkPipelineColorBlendStateCreateInfo>(); |
| 242 | color_blend_state_create_info.attachmentCount = 1; |
| 243 | color_blend_state_create_info.pAttachments = &color_blend_attachment_state; |
| 244 | |
| 245 | VkFormat color_format[2] = {VK_FORMAT_R8G8B8A8_UNORM, VK_FORMAT_D32_SFLOAT_S8_UINT}; |
| 246 | |
| 247 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 248 | pipeline_rendering_info.colorAttachmentCount = 2; |
| 249 | pipeline_rendering_info.pColorAttachmentFormats = &color_format[0]; |
| 250 | pipeline_rendering_info.viewMask = 0x2; |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 251 | pipeline_rendering_info.depthAttachmentFormat = VK_FORMAT_D32_SFLOAT_S8_UINT; |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 252 | |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 253 | auto pipeline_tessellation_state_info = LvlInitStruct<VkPipelineTessellationStateCreateInfo>(); |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 254 | pipeline_tessellation_state_info.patchControlPoints = 1; |
| 255 | |
| 256 | auto pipeline_input_assembly_state_info = LvlInitStruct<VkPipelineInputAssemblyStateCreateInfo>(); |
| 257 | pipeline_input_assembly_state_info.topology = VK_PRIMITIVE_TOPOLOGY_PATCH_LIST; |
| 258 | |
| 259 | auto create_info = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 260 | |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 261 | VkShaderObj vs(this, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX_BIT); |
| 262 | VkShaderObj gs(this, bindStateGeomShaderText, VK_SHADER_STAGE_GEOMETRY_BIT); |
| 263 | VkShaderObj te(this, bindStateTeshaderText, VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT); |
| 264 | VkShaderObj tc(this, bindStateTscShaderText, VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 265 | VkShaderObj fs(this, bindStateFragShaderText, VK_SHADER_STAGE_FRAGMENT_BIT); |
| 266 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 267 | pipe.AddShader(&vs); |
| 268 | pipe.AddShader(&gs); |
| 269 | pipe.AddShader(&te); |
| 270 | pipe.AddShader(&tc); |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 271 | pipe.AddShader(&fs); |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 272 | pipe.InitGraphicsPipelineCreateInfo(&create_info); |
Nathaniel Cesario | 72f2955 | 2022-03-24 05:11:11 -0600 | [diff] [blame] | 273 | |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 274 | create_info.pColorBlendState = &color_blend_state_create_info; |
| 275 | create_info.pNext = &pipeline_rendering_info; |
| 276 | create_info.pTessellationState = &pipeline_tessellation_state_info; |
| 277 | create_info.pInputAssemblyState = &pipeline_input_assembly_state_info; |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 278 | |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 279 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06053"); |
Nathaniel Cesario | 72f2955 | 2022-03-24 05:11:11 -0600 | [diff] [blame] | 280 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06581"); |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 281 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06055"); |
| 282 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06057"); |
| 283 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06058"); |
Nathaniel Cesario | a611857 | 2022-03-24 04:48:33 -0600 | [diff] [blame] | 284 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-multiview-06577"); |
Aaron Hagan | aca5044 | 2021-12-07 22:26:29 -0500 | [diff] [blame] | 285 | pipe.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info); |
| 286 | m_errorMonitor->VerifyFound(); |
| 287 | |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 288 | create_info.pColorBlendState = nullptr; |
| 289 | pipeline_rendering_info.depthAttachmentFormat = VK_FORMAT_UNDEFINED; |
| 290 | pipeline_rendering_info.viewMask = 0x0; |
| 291 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 292 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06054"); |
| 293 | pipe.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info); |
| 294 | m_errorMonitor->VerifyFound(); |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 295 | |
ziga-lunarg | 5e67160 | 2022-03-17 19:06:55 +0100 | [diff] [blame] | 296 | color_format[0] = VK_FORMAT_D32_SFLOAT_S8_UINT; |
| 297 | color_blend_attachment_state.blendEnable = VK_TRUE; |
| 298 | create_info.pColorBlendState = &color_blend_state_create_info; |
Nathaniel Cesario | 72f2955 | 2022-03-24 05:11:11 -0600 | [diff] [blame] | 299 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06581"); |
ziga-lunarg | 5e67160 | 2022-03-17 19:06:55 +0100 | [diff] [blame] | 300 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06062"); |
ziga-lunarg | 5e67160 | 2022-03-17 19:06:55 +0100 | [diff] [blame] | 301 | pipe.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info); |
| 302 | m_errorMonitor->VerifyFound(); |
| 303 | color_format[0] = VK_FORMAT_R8G8B8A8_UNORM; |
| 304 | |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 305 | auto ds_ci = LvlInitStruct<VkPipelineDepthStencilStateCreateInfo>(); |
| 306 | ds_ci.flags = VK_PIPELINE_DEPTH_STENCIL_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_DEPTH_ACCESS_BIT_ARM; |
| 307 | color_blend_state_create_info.flags = VK_PIPELINE_COLOR_BLEND_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_ACCESS_BIT_ARM; |
| 308 | create_info.pColorBlendState = &color_blend_state_create_info; |
| 309 | create_info.pDepthStencilState = &ds_ci; |
| 310 | create_info.renderPass = VK_NULL_HANDLE; |
| 311 | pipeline_rendering_info.depthAttachmentFormat = VK_FORMAT_D32_SFLOAT_S8_UINT; |
| 312 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-flags-06482"); |
| 313 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-flags-06483"); |
| 314 | pipe.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info); |
| 315 | m_errorMonitor->VerifyFound(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 316 | } |
| 317 | |
| 318 | TEST_F(VkLayerTest, DynamicRenderingWithMismatchingViewMask) { |
| 319 | TEST_DESCRIPTION("Draw with Dynamic Rendering and a mismatching viewMask"); |
| 320 | |
| 321 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 322 | |
| 323 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 324 | |
| 325 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 326 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 327 | if (!AreRequiredExtensionsEnabled()) { |
| 328 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 329 | } |
| 330 | |
| 331 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 332 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 333 | } |
| 334 | |
| 335 | auto multiview_features = LvlInitStruct<VkPhysicalDeviceMultiviewFeatures>(); |
| 336 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(&multiview_features); |
| 337 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 338 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 339 | if (!dynamic_rendering_features.dynamicRendering) { |
| 340 | printf("%s Test requires (unsupported) dynamicRendering , skipping\n", kSkipPrefix); |
| 341 | return; |
| 342 | } |
| 343 | if (!multiview_features.multiview) { |
| 344 | printf("%s Test requires (unsupported) multiview , skipping\n", kSkipPrefix); |
| 345 | return; |
| 346 | } |
| 347 | |
| 348 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 349 | |
| 350 | char const *fsSource = R"glsl( |
| 351 | #version 450 |
| 352 | layout(location=0) out vec4 color; |
| 353 | void main() { |
| 354 | color = vec4(1.0f); |
| 355 | } |
| 356 | )glsl"; |
| 357 | |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 358 | VkShaderObj vs(this, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX_BIT); |
| 359 | VkShaderObj fs(this, fsSource, VK_SHADER_STAGE_FRAGMENT_BIT); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 360 | |
| 361 | VkPipelineObj pipe(m_device); |
| 362 | pipe.AddShader(&vs); |
| 363 | pipe.AddShader(&fs); |
| 364 | pipe.AddDefaultColorAttachment(); |
| 365 | |
| 366 | VkDescriptorSetLayoutBinding dslb = {0, VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, 1, VK_SHADER_STAGE_FRAGMENT_BIT, nullptr}; |
| 367 | const VkDescriptorSetLayoutObj dsl(m_device, {dslb}); |
| 368 | const VkPipelineLayoutObj pl(m_device, {&dsl}); |
| 369 | |
| 370 | VkFormat color_formats = {VK_FORMAT_R8G8B8A8_UNORM}; |
| 371 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 372 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 373 | pipeline_rendering_info.pColorAttachmentFormats = &color_formats; |
| 374 | pipeline_rendering_info.viewMask = 1; |
| 375 | |
| 376 | VkViewport viewport = {0, 0, 16, 16, 0, 1}; |
| 377 | VkRect2D scissor = {{0, 0}, {16, 16}}; |
| 378 | m_viewports.push_back(viewport); |
| 379 | m_scissors.push_back(scissor); |
| 380 | pipe.SetViewport(m_viewports); |
| 381 | pipe.SetScissor(m_scissors); |
| 382 | |
| 383 | auto create_info = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 384 | pipe.InitGraphicsPipelineCreateInfo(&create_info); |
| 385 | create_info.pNext = &pipeline_rendering_info; |
| 386 | |
| 387 | pipe.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info); |
| 388 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 389 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 390 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 391 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 392 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 393 | begin_rendering_info.colorAttachmentCount = 1; |
| 394 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 395 | begin_rendering_info.viewMask = 2; |
| 396 | begin_rendering_info.layerCount = 1; |
| 397 | |
| 398 | m_commandBuffer->begin(); |
| 399 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 400 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.handle()); |
| 401 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-viewMask-06178"); |
| 402 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 403 | m_errorMonitor->VerifyFound(); |
| 404 | m_commandBuffer->EndRendering(); |
| 405 | m_commandBuffer->end(); |
| 406 | } |
| 407 | |
| 408 | TEST_F(VkLayerTest, DynamicRenderingWithMistmatchingAttachments) { |
| 409 | TEST_DESCRIPTION("Draw with Dynamic Rendering with mismatching color attachment counts and depth/stencil formats"); |
| 410 | |
| 411 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 412 | |
| 413 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 414 | |
| 415 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 416 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 417 | if (!AreRequiredExtensionsEnabled()) { |
| 418 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 419 | } |
| 420 | |
| 421 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 422 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 423 | } |
| 424 | |
| 425 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 426 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 427 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 428 | if (!dynamic_rendering_features.dynamicRendering) { |
| 429 | printf("%s Test requires (unsupported) dynamicRendering , skipping\n", kSkipPrefix); |
| 430 | return; |
| 431 | } |
| 432 | |
| 433 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 434 | |
| 435 | char const *fsSource = R"glsl( |
| 436 | #version 450 |
| 437 | layout(location=0) out vec4 color; |
| 438 | void main() { |
| 439 | color = vec4(1.0f); |
| 440 | } |
| 441 | )glsl"; |
| 442 | |
| 443 | VkViewport viewport = {0, 0, 16, 16, 0, 1}; |
| 444 | VkRect2D scissor = {{0, 0}, {16, 16}}; |
| 445 | m_viewports.push_back(viewport); |
| 446 | m_scissors.push_back(scissor); |
| 447 | |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 448 | VkShaderObj vs(this, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX_BIT); |
| 449 | VkShaderObj fs(this, fsSource, VK_SHADER_STAGE_FRAGMENT_BIT); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 450 | |
| 451 | VkDescriptorSetLayoutBinding dslb = {0, VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, 1, VK_SHADER_STAGE_FRAGMENT_BIT, nullptr}; |
| 452 | const VkDescriptorSetLayoutObj dsl(m_device, {dslb}); |
| 453 | const VkPipelineLayoutObj pl(m_device, {&dsl}); |
| 454 | |
| 455 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 456 | |
| 457 | VkPipelineObj pipe1(m_device); |
| 458 | pipe1.AddShader(&vs); |
| 459 | pipe1.AddShader(&fs); |
| 460 | pipe1.AddDefaultColorAttachment(); |
| 461 | pipe1.SetViewport(m_viewports); |
| 462 | pipe1.SetScissor(m_scissors); |
| 463 | |
| 464 | VkFormat color_formats[] = {VK_FORMAT_R8G8B8A8_UNORM}; |
| 465 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 466 | pipeline_rendering_info.pColorAttachmentFormats = color_formats; |
| 467 | |
| 468 | auto create_info1 = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 469 | pipe1.InitGraphicsPipelineCreateInfo(&create_info1); |
| 470 | create_info1.pNext = &pipeline_rendering_info; |
| 471 | |
| 472 | pipe1.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info1); |
| 473 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 474 | auto ds_state = LvlInitStruct<VkPipelineDepthStencilStateCreateInfo>(); |
| 475 | |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 476 | VkPipelineObj pipe2(m_device); |
| 477 | pipe2.AddShader(&vs); |
| 478 | pipe2.AddShader(&fs); |
| 479 | pipe2.AddDefaultColorAttachment(); |
| 480 | pipe2.SetViewport(m_viewports); |
| 481 | pipe2.SetScissor(m_scissors); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 482 | pipe2.SetDepthStencil(&ds_state); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 483 | |
| 484 | pipeline_rendering_info.colorAttachmentCount = 0; |
| 485 | pipeline_rendering_info.pColorAttachmentFormats = nullptr; |
| 486 | pipeline_rendering_info.depthAttachmentFormat = VK_FORMAT_D16_UNORM; |
| 487 | |
| 488 | auto create_info2 = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 489 | pipe2.InitGraphicsPipelineCreateInfo(&create_info2); |
| 490 | create_info2.pNext = &pipeline_rendering_info; |
| 491 | |
| 492 | pipe2.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info2); |
| 493 | |
| 494 | VkFormat depthStencilFormat = FindSupportedDepthStencilFormat(gpu()); |
| 495 | ASSERT_TRUE(depthStencilFormat != 0); |
| 496 | |
| 497 | bool testStencil = false; |
| 498 | VkFormat stencilFormat = VK_FORMAT_UNDEFINED; |
| 499 | |
| 500 | if (ImageFormatIsSupported(gpu(), VK_FORMAT_S8_UINT, VK_IMAGE_TILING_OPTIMAL)) { |
| 501 | stencilFormat = VK_FORMAT_S8_UINT; |
| 502 | testStencil = true; |
| 503 | } else if ((depthStencilFormat != VK_FORMAT_D16_UNORM_S8_UINT) && |
| 504 | ImageFormatIsSupported(gpu(), VK_FORMAT_D16_UNORM_S8_UINT, VK_IMAGE_TILING_OPTIMAL)) { |
| 505 | stencilFormat = VK_FORMAT_D16_UNORM_S8_UINT; |
| 506 | testStencil = true; |
| 507 | } else if ((depthStencilFormat != VK_FORMAT_D24_UNORM_S8_UINT) && |
| 508 | ImageFormatIsSupported(gpu(), VK_FORMAT_D24_UNORM_S8_UINT, VK_IMAGE_TILING_OPTIMAL)) { |
| 509 | stencilFormat = VK_FORMAT_D24_UNORM_S8_UINT; |
| 510 | testStencil = true; |
| 511 | } else if ((depthStencilFormat != VK_FORMAT_D32_SFLOAT_S8_UINT) && |
| 512 | ImageFormatIsSupported(gpu(), VK_FORMAT_D32_SFLOAT_S8_UINT, VK_IMAGE_TILING_OPTIMAL)) { |
| 513 | stencilFormat = VK_FORMAT_D32_SFLOAT_S8_UINT; |
| 514 | testStencil = true; |
| 515 | } |
| 516 | |
| 517 | VkPipelineObj pipe3(m_device); |
| 518 | |
| 519 | if (testStencil) { |
| 520 | pipe3.AddShader(&vs); |
| 521 | pipe3.AddShader(&fs); |
| 522 | pipe3.AddDefaultColorAttachment(); |
| 523 | pipe3.SetViewport(m_viewports); |
| 524 | pipe3.SetScissor(m_scissors); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 525 | pipe3.SetDepthStencil(&ds_state); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 526 | |
| 527 | pipeline_rendering_info.colorAttachmentCount = 0; |
| 528 | pipeline_rendering_info.depthAttachmentFormat = VK_FORMAT_UNDEFINED; |
| 529 | pipeline_rendering_info.stencilAttachmentFormat = stencilFormat; |
| 530 | |
| 531 | auto create_info3 = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 532 | pipe3.InitGraphicsPipelineCreateInfo(&create_info3); |
| 533 | create_info3.pNext = &pipeline_rendering_info; |
| 534 | |
| 535 | pipe3.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info3); |
| 536 | } |
| 537 | |
| 538 | VkImageObj colorImage(m_device); |
| 539 | colorImage.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UINT, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 540 | VkImageView colorImageView = colorImage.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 541 | |
| 542 | VkImageObj depthStencilImage(m_device); |
| 543 | depthStencilImage.Init(32, 32, 1, depthStencilFormat, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); |
| 544 | VkImageView depthStencilImageView = |
| 545 | depthStencilImage.targetView(depthStencilFormat, VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 546 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 547 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 548 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 549 | color_attachment.imageView = colorImageView; |
| 550 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 551 | VkRenderingAttachmentInfoKHR depth_stencil_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 552 | depth_stencil_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 553 | depth_stencil_attachment.imageView = depthStencilImageView; |
| 554 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 555 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 556 | begin_rendering_info.layerCount = 1; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 557 | m_commandBuffer->begin(); |
| 558 | |
| 559 | // Mismatching color attachment count |
| 560 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 561 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe1.handle()); |
| 562 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-colorAttachmentCount-06179"); |
| 563 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 564 | m_errorMonitor->VerifyFound(); |
| 565 | m_commandBuffer->EndRendering(); |
| 566 | |
| 567 | // Mismatching color formats |
| 568 | begin_rendering_info.colorAttachmentCount = 1; |
| 569 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 570 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 571 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe1.handle()); |
| 572 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-colorAttachmentCount-06180"); |
| 573 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 574 | m_errorMonitor->VerifyFound(); |
| 575 | m_commandBuffer->EndRendering(); |
| 576 | |
| 577 | // Mismatching depth format |
| 578 | begin_rendering_info.colorAttachmentCount = 0; |
| 579 | begin_rendering_info.pColorAttachments = nullptr; |
| 580 | begin_rendering_info.pDepthAttachment = &depth_stencil_attachment; |
| 581 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 582 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe2.handle()); |
| 583 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-pDepthAttachment-06181"); |
| 584 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 585 | m_errorMonitor->VerifyFound(); |
| 586 | m_commandBuffer->EndRendering(); |
| 587 | |
| 588 | // Mismatching stencil format |
| 589 | if (testStencil) { |
| 590 | begin_rendering_info.pDepthAttachment = nullptr; |
| 591 | begin_rendering_info.pStencilAttachment = &depth_stencil_attachment; |
| 592 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 593 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe3.handle()); |
| 594 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-pStencilAttachment-06182"); |
| 595 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 596 | m_errorMonitor->VerifyFound(); |
| 597 | m_commandBuffer->EndRendering(); |
| 598 | } |
| 599 | |
| 600 | m_commandBuffer->end(); |
| 601 | } |
| 602 | |
| 603 | TEST_F(VkLayerTest, DynamicRenderingWithMistmatchingAttachmentSamples) { |
| 604 | TEST_DESCRIPTION("Draw with Dynamic Rendering with mismatching color/depth/stencil sample counts"); |
| 605 | |
| 606 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 607 | |
| 608 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 609 | |
| 610 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 611 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 612 | if (!AreRequiredExtensionsEnabled()) { |
| 613 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 614 | } |
| 615 | |
| 616 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 617 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 618 | } |
| 619 | |
| 620 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 621 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 622 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 623 | if (!dynamic_rendering_features.dynamicRendering) { |
| 624 | printf("%s Test requires (unsupported) dynamicRendering , skipping\n", kSkipPrefix); |
| 625 | return; |
| 626 | } |
| 627 | |
| 628 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 629 | |
| 630 | char const *fsSource = R"glsl( |
| 631 | #version 450 |
| 632 | layout(location=0) out vec4 color; |
| 633 | void main() { |
| 634 | color = vec4(1.0f); |
| 635 | } |
| 636 | )glsl"; |
| 637 | |
| 638 | VkViewport viewport = {0, 0, 16, 16, 0, 1}; |
| 639 | VkRect2D scissor = {{0, 0}, {16, 16}}; |
| 640 | m_viewports.push_back(viewport); |
| 641 | m_scissors.push_back(scissor); |
| 642 | |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 643 | VkShaderObj vs(this, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX_BIT); |
| 644 | VkShaderObj fs(this, fsSource, VK_SHADER_STAGE_FRAGMENT_BIT); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 645 | |
| 646 | VkDescriptorSetLayoutBinding dslb = {0, VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, 1, VK_SHADER_STAGE_FRAGMENT_BIT, nullptr}; |
| 647 | const VkDescriptorSetLayoutObj dsl(m_device, {dslb}); |
| 648 | const VkPipelineLayoutObj pl(m_device, {&dsl}); |
| 649 | |
| 650 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 651 | |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 652 | VkPipelineObj pipe1(m_device); |
| 653 | pipe1.AddShader(&vs); |
| 654 | pipe1.AddShader(&fs); |
| 655 | pipe1.AddDefaultColorAttachment(); |
| 656 | pipe1.SetViewport(m_viewports); |
| 657 | pipe1.SetScissor(m_scissors); |
| 658 | |
| 659 | VkFormat color_formats[] = {VK_FORMAT_R8G8B8A8_UNORM}; |
| 660 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 661 | pipeline_rendering_info.pColorAttachmentFormats = color_formats; |
| 662 | |
| 663 | auto create_info1 = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 664 | pipe1.InitGraphicsPipelineCreateInfo(&create_info1); |
| 665 | create_info1.pNext = &pipeline_rendering_info; |
| 666 | |
| 667 | auto multisample_state_create_info = LvlInitStruct<VkPipelineMultisampleStateCreateInfo>(); |
| 668 | multisample_state_create_info.rasterizationSamples = VK_SAMPLE_COUNT_2_BIT; |
| 669 | create_info1.pMultisampleState = &multisample_state_create_info; |
| 670 | |
| 671 | pipe1.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info1); |
| 672 | |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 673 | VkFormat depthStencilFormat = FindSupportedDepthStencilFormat(gpu()); |
| 674 | ASSERT_TRUE(depthStencilFormat != 0); |
| 675 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 676 | auto ds_state = LvlInitStruct<VkPipelineDepthStencilStateCreateInfo>(); |
| 677 | |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 678 | VkPipelineObj pipe2(m_device); |
| 679 | pipe2.AddShader(&vs); |
| 680 | pipe2.AddShader(&fs); |
| 681 | pipe2.AddDefaultColorAttachment(); |
| 682 | pipe2.SetViewport(m_viewports); |
| 683 | pipe2.SetScissor(m_scissors); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 684 | pipe2.SetDepthStencil(&ds_state); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 685 | |
| 686 | pipeline_rendering_info.colorAttachmentCount = 0; |
| 687 | pipeline_rendering_info.pColorAttachmentFormats = nullptr; |
| 688 | pipeline_rendering_info.depthAttachmentFormat = depthStencilFormat; |
| 689 | |
| 690 | auto create_info2 = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 691 | pipe2.InitGraphicsPipelineCreateInfo(&create_info2); |
| 692 | create_info2.pNext = &pipeline_rendering_info; |
| 693 | |
| 694 | create_info2.pMultisampleState = &multisample_state_create_info; |
| 695 | |
| 696 | pipe2.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info2); |
| 697 | |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 698 | VkPipelineObj pipe3(m_device); |
| 699 | |
| 700 | pipe3.AddShader(&vs); |
| 701 | pipe3.AddShader(&fs); |
| 702 | pipe3.AddDefaultColorAttachment(); |
| 703 | pipe3.SetViewport(m_viewports); |
| 704 | pipe3.SetScissor(m_scissors); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 705 | pipe3.SetDepthStencil(&ds_state); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 706 | |
| 707 | pipeline_rendering_info.colorAttachmentCount = 0; |
| 708 | pipeline_rendering_info.depthAttachmentFormat = VK_FORMAT_UNDEFINED; |
| 709 | pipeline_rendering_info.stencilAttachmentFormat = depthStencilFormat; |
| 710 | |
| 711 | auto create_info3 = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 712 | pipe3.InitGraphicsPipelineCreateInfo(&create_info3); |
| 713 | create_info3.pNext = &pipeline_rendering_info; |
| 714 | |
| 715 | create_info3.pMultisampleState = &multisample_state_create_info; |
| 716 | |
| 717 | pipe3.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info3); |
| 718 | |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 719 | VkImageObj colorImage(m_device); |
| 720 | colorImage.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 721 | VkImageView colorImageView = colorImage.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 722 | |
| 723 | VkImageObj depthStencilImage(m_device); |
| 724 | depthStencilImage.Init(32, 32, 1, depthStencilFormat, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); |
| 725 | VkImageView depthStencilImageView = |
| 726 | depthStencilImage.targetView(depthStencilFormat, VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 727 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 728 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 729 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 730 | color_attachment.imageView = colorImageView; |
| 731 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 732 | VkRenderingAttachmentInfoKHR depth_stencil_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 733 | depth_stencil_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 734 | depth_stencil_attachment.imageView = depthStencilImageView; |
| 735 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 736 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 737 | begin_rendering_info.layerCount = 1; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 738 | m_commandBuffer->begin(); |
| 739 | |
| 740 | // Mismatching color samples |
| 741 | begin_rendering_info.colorAttachmentCount = 1; |
| 742 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 743 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 744 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe1.handle()); |
| 745 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-colorAttachmentCount-06188"); |
| 746 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 747 | m_errorMonitor->VerifyFound(); |
| 748 | m_commandBuffer->EndRendering(); |
| 749 | |
| 750 | // Mismatching depth samples |
| 751 | begin_rendering_info.colorAttachmentCount = 0; |
| 752 | begin_rendering_info.pColorAttachments = nullptr; |
| 753 | begin_rendering_info.pDepthAttachment = &depth_stencil_attachment; |
| 754 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 755 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe2.handle()); |
| 756 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-pDepthAttachment-06189"); |
| 757 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 758 | m_errorMonitor->VerifyFound(); |
| 759 | m_commandBuffer->EndRendering(); |
| 760 | |
| 761 | // Mismatching stencil samples |
| 762 | begin_rendering_info.pDepthAttachment = nullptr; |
| 763 | begin_rendering_info.pStencilAttachment = &depth_stencil_attachment; |
| 764 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 765 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe3.handle()); |
| 766 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-pStencilAttachment-06190"); |
| 767 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 768 | m_errorMonitor->VerifyFound(); |
| 769 | m_commandBuffer->EndRendering(); |
| 770 | |
| 771 | m_commandBuffer->end(); |
| 772 | } |
| 773 | |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 774 | TEST_F(VkLayerTest, DynamicRenderingWithMismatchingMixedAttachmentSamples) { |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 775 | TEST_DESCRIPTION("Draw with Dynamic Rendering with mismatching mixed color/depth/stencil sample counts"); |
| 776 | |
| 777 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 778 | |
| 779 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 780 | |
| 781 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 782 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 783 | if (!AreRequiredExtensionsEnabled()) { |
| 784 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 785 | } |
| 786 | |
| 787 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 788 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 789 | } |
| 790 | |
| 791 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 792 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 793 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 794 | if (!dynamic_rendering_features.dynamicRendering) { |
| 795 | printf("%s Test requires (unsupported) dynamicRendering , skipping\n", kSkipPrefix); |
| 796 | return; |
| 797 | } |
| 798 | |
| 799 | bool amd_samples = false; |
| 800 | if (DeviceExtensionSupported(gpu(), nullptr, VK_AMD_MIXED_ATTACHMENT_SAMPLES_EXTENSION_NAME)) { |
| 801 | m_device_extension_names.push_back(VK_AMD_MIXED_ATTACHMENT_SAMPLES_EXTENSION_NAME); |
| 802 | amd_samples = true; |
| 803 | } |
| 804 | |
| 805 | bool nv_samples = false; |
| 806 | if (DeviceExtensionSupported(gpu(), nullptr, VK_NV_FRAMEBUFFER_MIXED_SAMPLES_EXTENSION_NAME)) { |
| 807 | m_device_extension_names.push_back(VK_NV_FRAMEBUFFER_MIXED_SAMPLES_EXTENSION_NAME); |
| 808 | nv_samples = true; |
| 809 | } |
| 810 | |
| 811 | if (!amd_samples && !nv_samples) { |
| 812 | printf("%s Test requires either VK_AMD_mixed_attachment_samples or VK_NV_framebuffer_mixed_samples, skipping\n", |
| 813 | kSkipPrefix); |
| 814 | return; |
| 815 | } |
| 816 | |
| 817 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 818 | |
| 819 | char const *fsSource = R"glsl( |
| 820 | #version 450 |
| 821 | layout(location=0) out vec4 color; |
| 822 | void main() { |
| 823 | color = vec4(1.0f); |
| 824 | } |
| 825 | )glsl"; |
| 826 | |
| 827 | VkViewport viewport = {0, 0, 16, 16, 0, 1}; |
| 828 | VkRect2D scissor = {{0, 0}, {16, 16}}; |
| 829 | m_viewports.push_back(viewport); |
| 830 | m_scissors.push_back(scissor); |
| 831 | |
sfricke-samsung | ae54c1e | 2022-01-21 05:35:21 -0800 | [diff] [blame] | 832 | VkShaderObj vs(this, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX_BIT); |
| 833 | VkShaderObj fs(this, fsSource, VK_SHADER_STAGE_FRAGMENT_BIT); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 834 | |
| 835 | VkDescriptorSetLayoutBinding dslb = {0, VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, 1, VK_SHADER_STAGE_FRAGMENT_BIT, nullptr}; |
| 836 | const VkDescriptorSetLayoutObj dsl(m_device, {dslb}); |
| 837 | const VkPipelineLayoutObj pl(m_device, {&dsl}); |
| 838 | |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 839 | VkSampleCountFlagBits counts[2] = {VK_SAMPLE_COUNT_2_BIT, VK_SAMPLE_COUNT_2_BIT}; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 840 | auto samples_info = LvlInitStruct<VkAttachmentSampleCountInfoAMD>(); |
| 841 | |
| 842 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(&samples_info); |
| 843 | |
| 844 | VkPipelineObj pipe1(m_device); |
| 845 | pipe1.AddShader(&vs); |
| 846 | pipe1.AddShader(&fs); |
| 847 | pipe1.AddDefaultColorAttachment(); |
| 848 | pipe1.SetViewport(m_viewports); |
| 849 | pipe1.SetScissor(m_scissors); |
| 850 | |
| 851 | VkFormat color_formats[] = {VK_FORMAT_R8G8B8A8_UNORM}; |
| 852 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 853 | pipeline_rendering_info.pColorAttachmentFormats = color_formats; |
| 854 | |
| 855 | samples_info.colorAttachmentCount = 1; |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 856 | samples_info.pColorAttachmentSamples = counts; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 857 | |
| 858 | auto create_info1 = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 859 | pipe1.InitGraphicsPipelineCreateInfo(&create_info1); |
| 860 | create_info1.pNext = &pipeline_rendering_info; |
| 861 | |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 862 | samples_info.colorAttachmentCount = 2; |
| 863 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06063"); |
| 864 | pipe1.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info1); |
| 865 | m_errorMonitor->VerifyFound(); |
| 866 | |
| 867 | samples_info.colorAttachmentCount = 1; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 868 | pipe1.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info1); |
| 869 | |
| 870 | VkFormat depthStencilFormat = FindSupportedDepthStencilFormat(gpu()); |
| 871 | ASSERT_TRUE(depthStencilFormat != 0); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 872 | auto ds_state = LvlInitStruct<VkPipelineDepthStencilStateCreateInfo>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 873 | |
| 874 | VkPipelineObj pipe2(m_device); |
| 875 | pipe2.AddShader(&vs); |
| 876 | pipe2.AddShader(&fs); |
| 877 | pipe2.AddDefaultColorAttachment(); |
| 878 | pipe2.SetViewport(m_viewports); |
| 879 | pipe2.SetScissor(m_scissors); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 880 | pipe2.SetDepthStencil(&ds_state); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 881 | |
| 882 | pipeline_rendering_info.colorAttachmentCount = 0; |
| 883 | pipeline_rendering_info.pColorAttachmentFormats = nullptr; |
| 884 | pipeline_rendering_info.depthAttachmentFormat = depthStencilFormat; |
| 885 | |
| 886 | samples_info.colorAttachmentCount = 0; |
| 887 | samples_info.pColorAttachmentSamples = nullptr; |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 888 | samples_info.depthStencilAttachmentSamples = counts[0]; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 889 | |
| 890 | auto create_info2 = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 891 | pipe2.InitGraphicsPipelineCreateInfo(&create_info2); |
| 892 | create_info2.pNext = &pipeline_rendering_info; |
| 893 | |
| 894 | pipe2.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info2); |
| 895 | |
| 896 | VkPipelineObj pipe3(m_device); |
| 897 | |
| 898 | pipe3.AddShader(&vs); |
| 899 | pipe3.AddShader(&fs); |
| 900 | pipe3.AddDefaultColorAttachment(); |
| 901 | pipe3.SetViewport(m_viewports); |
| 902 | pipe3.SetScissor(m_scissors); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 903 | pipe3.SetDepthStencil(&ds_state); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 904 | |
| 905 | pipeline_rendering_info.colorAttachmentCount = 0; |
| 906 | pipeline_rendering_info.depthAttachmentFormat = VK_FORMAT_UNDEFINED; |
| 907 | pipeline_rendering_info.stencilAttachmentFormat = depthStencilFormat; |
| 908 | |
| 909 | auto create_info3 = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 910 | pipe3.InitGraphicsPipelineCreateInfo(&create_info3); |
| 911 | create_info3.pNext = &pipeline_rendering_info; |
| 912 | |
| 913 | pipe3.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &create_info3); |
| 914 | |
| 915 | VkImageObj colorImage(m_device); |
| 916 | colorImage.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 917 | VkImageView colorImageView = colorImage.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 918 | |
| 919 | VkImageObj depthStencilImage(m_device); |
| 920 | depthStencilImage.Init(32, 32, 1, depthStencilFormat, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); |
| 921 | VkImageView depthStencilImageView = |
| 922 | depthStencilImage.targetView(depthStencilFormat, VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 923 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 924 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 925 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 926 | color_attachment.imageView = colorImageView; |
| 927 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 928 | VkRenderingAttachmentInfoKHR depth_stencil_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 929 | depth_stencil_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 930 | depth_stencil_attachment.imageView = depthStencilImageView; |
| 931 | |
sfricke-samsung | 6fc3e32 | 2022-02-15 22:41:29 -0800 | [diff] [blame] | 932 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 933 | m_commandBuffer->begin(); |
| 934 | |
| 935 | // Mismatching color samples |
| 936 | begin_rendering_info.colorAttachmentCount = 1; |
| 937 | begin_rendering_info.pColorAttachments = &color_attachment; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 938 | begin_rendering_info.layerCount = 1; |
stusmith | 15f24a8 | 2021-12-24 15:21:19 +0000 | [diff] [blame] | 939 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 940 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe1.handle()); |
| 941 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-colorAttachmentCount-06185"); |
| 942 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 943 | m_errorMonitor->VerifyFound(); |
| 944 | m_commandBuffer->EndRendering(); |
| 945 | |
| 946 | // Mismatching depth samples |
| 947 | begin_rendering_info.colorAttachmentCount = 0; |
| 948 | begin_rendering_info.pColorAttachments = nullptr; |
| 949 | begin_rendering_info.pDepthAttachment = &depth_stencil_attachment; |
| 950 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 951 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe2.handle()); |
| 952 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-pDepthAttachment-06186"); |
| 953 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 954 | m_errorMonitor->VerifyFound(); |
| 955 | m_commandBuffer->EndRendering(); |
| 956 | |
| 957 | // Mismatching stencil samples |
| 958 | begin_rendering_info.pDepthAttachment = nullptr; |
| 959 | begin_rendering_info.pStencilAttachment = &depth_stencil_attachment; |
| 960 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 961 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe3.handle()); |
| 962 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-pStencilAttachment-06187"); |
| 963 | m_commandBuffer->Draw(1, 1, 0, 0); |
| 964 | m_errorMonitor->VerifyFound(); |
| 965 | m_commandBuffer->EndRendering(); |
| 966 | |
| 967 | m_commandBuffer->end(); |
| 968 | } |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 969 | |
| 970 | TEST_F(VkLayerTest, DynamicRenderingAttachmentInfo) { |
| 971 | TEST_DESCRIPTION("AttachmentInfo Dynamic Rendering Tests."); |
| 972 | |
| 973 | uint32_t version = SetTargetApiVersion(VK_API_VERSION_1_2); |
| 974 | if (version < VK_API_VERSION_1_2) { |
| 975 | printf("%s At least Vulkan version 1.2 is required, skipping test.\n", kSkipPrefix); |
| 976 | return; |
| 977 | } |
| 978 | |
| 979 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 980 | |
| 981 | ASSERT_NO_FATAL_FAILURE(InitFramework(m_errorMonitor)); |
| 982 | |
| 983 | if (DeviceValidationVersion() < VK_API_VERSION_1_2) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 984 | GTEST_SKIP() << "At least Vulkan version 1.2 is required"; |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 985 | } |
| 986 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 987 | if (!AreRequiredExtensionsEnabled()) { |
| 988 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 989 | } |
| 990 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 991 | auto fdm_features = LvlInitStruct<VkPhysicalDeviceFragmentDensityMapFeaturesEXT>(); |
| 992 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(&fdm_features); |
| 993 | auto features2 = GetPhysicalDeviceFeatures2(dynamic_rendering_features); |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 994 | if (!dynamic_rendering_features.dynamicRendering) { |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 995 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering , skipping"; |
| 996 | } |
| 997 | if (!fdm_features.fragmentDensityMapNonSubsampledImages) { |
| 998 | GTEST_SKIP() << "fragmentDensityMapNonSubsampledImages not supported."; |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 999 | } |
| 1000 | |
| 1001 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 1002 | |
| 1003 | VkShaderObj vs(this, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX_BIT); |
| 1004 | VkShaderObj fs(this, bindStateFragShaderText, VK_SHADER_STAGE_FRAGMENT_BIT); |
| 1005 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1006 | auto ds_state = LvlInitStruct<VkPipelineDepthStencilStateCreateInfo>(); |
| 1007 | |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 1008 | VkPipelineObj pipe(m_device); |
| 1009 | pipe.AddShader(&vs); |
| 1010 | pipe.AddShader(&fs); |
| 1011 | pipe.AddDefaultColorAttachment(); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1012 | pipe.SetDepthStencil(&ds_state); |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 1013 | |
| 1014 | VkDescriptorSetLayoutBinding dslb = {0, VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, 1, VK_SHADER_STAGE_FRAGMENT_BIT, nullptr}; |
| 1015 | const VkDescriptorSetLayoutObj dsl(m_device, {dslb}); |
| 1016 | const VkPipelineLayoutObj pl(m_device, {&dsl}); |
| 1017 | |
| 1018 | VkFormat depth_format = VK_FORMAT_D32_SFLOAT_S8_UINT; |
| 1019 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 1020 | pipeline_rendering_info.depthAttachmentFormat = depth_format; |
| 1021 | |
| 1022 | auto pipeline_create_info = LvlInitStruct<VkGraphicsPipelineCreateInfo>(); |
| 1023 | pipe.InitGraphicsPipelineCreateInfo(&pipeline_create_info); |
| 1024 | pipeline_create_info.pNext = &pipeline_rendering_info; |
| 1025 | |
| 1026 | VkResult err = pipe.CreateVKPipeline(pl.handle(), VK_NULL_HANDLE, &pipeline_create_info); |
| 1027 | ASSERT_VK_SUCCESS(err); |
| 1028 | |
| 1029 | VkImageObj image(m_device); |
| 1030 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 1031 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 1032 | image_create_info.format = depth_format; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1033 | image_create_info.extent = {64, 64, 1}; |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 1034 | image_create_info.mipLevels = 1; |
| 1035 | image_create_info.arrayLayers = 1; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1036 | image_create_info.samples = VK_SAMPLE_COUNT_1_BIT; |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 1037 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 1038 | image_create_info.usage = VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT; |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 1039 | image_create_info.sharingMode = VK_SHARING_MODE_EXCLUSIVE; |
| 1040 | |
| 1041 | image.Init(image_create_info); |
| 1042 | ASSERT_TRUE(image.initialized()); |
| 1043 | |
| 1044 | VkImageViewCreateInfo ivci = {VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO, |
| 1045 | nullptr, |
| 1046 | 0, |
| 1047 | image.handle(), |
| 1048 | VK_IMAGE_VIEW_TYPE_2D, |
| 1049 | depth_format, |
| 1050 | {VK_COMPONENT_SWIZZLE_IDENTITY, VK_COMPONENT_SWIZZLE_IDENTITY, VK_COMPONENT_SWIZZLE_IDENTITY, |
| 1051 | VK_COMPONENT_SWIZZLE_IDENTITY}, |
| 1052 | {VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT, 0, 1, 0, 1}}; |
| 1053 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1054 | VkImageView depth_image_view = image.targetView(ivci); |
| 1055 | ASSERT_NE(depth_image_view, VK_NULL_HANDLE); |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 1056 | |
| 1057 | VkRenderingAttachmentInfoKHR depth_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 1058 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_PRESENT_SRC_KHR; |
| 1059 | depth_attachment.imageView = depth_image_view; |
| 1060 | depth_attachment.resolveMode = VK_RESOLVE_MODE_SAMPLE_ZERO_BIT; |
| 1061 | depth_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_PRESENT_SRC_KHR; |
| 1062 | |
| 1063 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 1064 | begin_rendering_info.pDepthAttachment = &depth_attachment; |
| 1065 | begin_rendering_info.viewMask = 0x4; |
| 1066 | |
| 1067 | VkRenderingFragmentDensityMapAttachmentInfoEXT fragment_density_map = |
| 1068 | LvlInitStruct<VkRenderingFragmentDensityMapAttachmentInfoEXT>(); |
| 1069 | fragment_density_map.imageView = depth_image_view; |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 1070 | fragment_density_map.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 1071 | begin_rendering_info.pNext = &fragment_density_map; |
| 1072 | |
| 1073 | m_commandBuffer->begin(); |
| 1074 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-multiview-06127"); |
Jeremy Gebben | 09c1a07 | 2022-02-08 09:42:47 -0700 | [diff] [blame] | 1075 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06107"); |
| 1076 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06108"); |
| 1077 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06116"); |
Jeremy Gebben | 09c1a07 | 2022-02-08 09:42:47 -0700 | [diff] [blame] | 1078 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06145"); |
| 1079 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06146"); |
Aaron Hagan | 80034ea | 2021-12-23 11:24:09 -0500 | [diff] [blame] | 1080 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1081 | m_errorMonitor->VerifyFound(); |
| 1082 | } |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 1083 | |
| 1084 | TEST_F(VkLayerTest, DynamicRenderingBufferBeginInfoLegacy) { |
| 1085 | TEST_DESCRIPTION("VkCommandBufferBeginInfo Dynamic Rendering Tests."); |
| 1086 | |
| 1087 | uint32_t version = SetTargetApiVersion(VK_API_VERSION_1_2); |
| 1088 | if (version < VK_API_VERSION_1_2) { |
| 1089 | printf("%s At least Vulkan version 1.2 is required, skipping test.\n", kSkipPrefix); |
| 1090 | return; |
| 1091 | } |
| 1092 | |
| 1093 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1094 | |
| 1095 | ASSERT_NO_FATAL_FAILURE(Init(nullptr, nullptr, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT)); |
| 1096 | |
| 1097 | if (DeviceValidationVersion() < VK_API_VERSION_1_2) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1098 | GTEST_SKIP() << "At least Vulkan version 1.2 is required"; |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 1099 | } |
| 1100 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1101 | if (!AreRequiredExtensionsEnabled()) { |
| 1102 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 1103 | } |
| 1104 | |
| 1105 | auto cmd_buffer_inheritance_rendering_info = LvlInitStruct<VkCommandBufferInheritanceRenderingInfoKHR>(); |
| 1106 | cmd_buffer_inheritance_rendering_info.rasterizationSamples = VK_SAMPLE_COUNT_1_BIT; |
| 1107 | |
| 1108 | auto cmd_buffer_inheritance_info = LvlInitStruct<VkCommandBufferInheritanceInfo>(); |
| 1109 | cmd_buffer_inheritance_info.pNext = &cmd_buffer_inheritance_rendering_info; |
| 1110 | cmd_buffer_inheritance_info.renderPass = VK_NULL_HANDLE; |
| 1111 | |
| 1112 | auto cmd_buffer_allocate_info = LvlInitStruct<VkCommandBufferAllocateInfo>(); |
| 1113 | cmd_buffer_allocate_info.commandPool = m_commandPool->handle(); |
| 1114 | cmd_buffer_allocate_info.level = VK_COMMAND_BUFFER_LEVEL_SECONDARY; |
| 1115 | cmd_buffer_allocate_info.commandBufferCount = 0x1; |
| 1116 | |
| 1117 | VkCommandBuffer secondary_cmd_buffer; |
| 1118 | VkResult err = vk::AllocateCommandBuffers(m_device->device(), &cmd_buffer_allocate_info, &secondary_cmd_buffer); |
| 1119 | ASSERT_VK_SUCCESS(err); |
| 1120 | |
| 1121 | // Invalid RenderPass |
| 1122 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferBeginInfo-flags-00053"); |
| 1123 | VkCommandBufferBeginInfo cmd_buffer_begin_info = LvlInitStruct<VkCommandBufferBeginInfo>(); |
| 1124 | cmd_buffer_begin_info.flags = VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT; |
| 1125 | cmd_buffer_begin_info.pInheritanceInfo = &cmd_buffer_inheritance_info; |
| 1126 | vk::BeginCommandBuffer(secondary_cmd_buffer, &cmd_buffer_begin_info); |
| 1127 | m_errorMonitor->VerifyFound(); |
| 1128 | |
| 1129 | // Valid RenderPass |
| 1130 | VkAttachmentDescription attach[] = { |
| 1131 | {0, VK_FORMAT_B8G8R8A8_UNORM, VK_SAMPLE_COUNT_1_BIT, VK_ATTACHMENT_LOAD_OP_DONT_CARE, VK_ATTACHMENT_STORE_OP_DONT_CARE, |
| 1132 | VK_ATTACHMENT_LOAD_OP_DONT_CARE, VK_ATTACHMENT_STORE_OP_DONT_CARE, VK_IMAGE_LAYOUT_UNDEFINED, |
| 1133 | VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL}, |
| 1134 | }; |
| 1135 | VkAttachmentReference att_ref = {0, VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL}; |
| 1136 | |
| 1137 | VkSubpassDescription subpass = {0, VK_PIPELINE_BIND_POINT_GRAPHICS, 0, nullptr, 1, &att_ref, nullptr, nullptr, 0, nullptr}; |
| 1138 | VkRenderPassCreateInfo rpci = {VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO, nullptr, 0, 1, attach, 1, &subpass, 0, nullptr}; |
| 1139 | |
| 1140 | vk_testing::RenderPass rp1; |
| 1141 | rp1.init(*m_device, rpci); |
| 1142 | |
| 1143 | cmd_buffer_inheritance_info.renderPass = rp1.handle(); |
| 1144 | cmd_buffer_inheritance_info.subpass = 0x5; |
| 1145 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferBeginInfo-flags-00054"); |
| 1146 | vk::BeginCommandBuffer(secondary_cmd_buffer, &cmd_buffer_begin_info); |
| 1147 | m_errorMonitor->VerifyFound(); |
| 1148 | } |
| 1149 | |
| 1150 | TEST_F(VkLayerTest, DynamicRenderingSecondaryCommandBuffer) { |
| 1151 | TEST_DESCRIPTION("VkCommandBufferBeginInfo Dynamic Rendering Tests."); |
| 1152 | |
| 1153 | uint32_t version = SetTargetApiVersion(VK_API_VERSION_1_3); |
| 1154 | if (version < VK_API_VERSION_1_3) { |
| 1155 | printf("%s At least Vulkan version 1.3 is required, skipping test.\n", kSkipPrefix); |
| 1156 | return; |
| 1157 | } |
| 1158 | |
| 1159 | ASSERT_NO_FATAL_FAILURE(Init()); |
| 1160 | |
| 1161 | if (DeviceValidationVersion() < VK_API_VERSION_1_3) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1162 | GTEST_SKIP() << "At least Vulkan version 1.3 is required"; |
Aaron Hagan | b54466d | 2022-02-18 15:02:54 -0500 | [diff] [blame] | 1163 | } |
| 1164 | |
| 1165 | VkCommandBufferObj cb(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY); |
| 1166 | |
| 1167 | // Force the failure by not setting the Renderpass and Framebuffer fields |
| 1168 | VkCommandBufferInheritanceInfo cmd_buf_hinfo = LvlInitStruct<VkCommandBufferInheritanceInfo>(); |
| 1169 | cmd_buf_hinfo.renderPass = VkRenderPass(0x1); |
| 1170 | VkCommandBufferBeginInfo cmd_buf_info = LvlInitStruct<VkCommandBufferBeginInfo>(); |
| 1171 | cmd_buf_info.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT | VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT; |
| 1172 | cmd_buf_info.pInheritanceInfo = &cmd_buf_hinfo; |
| 1173 | |
| 1174 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferBeginInfo-flags-06000"); |
| 1175 | vk::BeginCommandBuffer(cb.handle(), &cmd_buf_info); |
| 1176 | m_errorMonitor->VerifyFound(); |
| 1177 | |
| 1178 | // Valid RenderPass |
| 1179 | VkAttachmentDescription attach[] = { |
| 1180 | {0, VK_FORMAT_B8G8R8A8_UNORM, VK_SAMPLE_COUNT_1_BIT, VK_ATTACHMENT_LOAD_OP_DONT_CARE, VK_ATTACHMENT_STORE_OP_DONT_CARE, |
| 1181 | VK_ATTACHMENT_LOAD_OP_DONT_CARE, VK_ATTACHMENT_STORE_OP_DONT_CARE, VK_IMAGE_LAYOUT_UNDEFINED, |
| 1182 | VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL}, |
| 1183 | }; |
| 1184 | VkAttachmentReference att_ref = {0, VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL}; |
| 1185 | |
| 1186 | VkSubpassDescription subpass = {0, VK_PIPELINE_BIND_POINT_GRAPHICS, 0, nullptr, 1, &att_ref, nullptr, nullptr, 0, nullptr}; |
| 1187 | VkRenderPassCreateInfo rpci = {VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO, nullptr, 0, 1, attach, 1, &subpass, 0, nullptr}; |
| 1188 | |
| 1189 | vk_testing::RenderPass rp1; |
| 1190 | rp1.init(*m_device, rpci); |
| 1191 | |
| 1192 | cmd_buf_hinfo.renderPass = rp1.handle(); |
| 1193 | cmd_buf_hinfo.subpass = 0x5; |
| 1194 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferBeginInfo-flags-06001"); |
| 1195 | vk::BeginCommandBuffer(cb.handle(), &cmd_buf_info); |
| 1196 | m_errorMonitor->VerifyFound(); |
| 1197 | |
| 1198 | cmd_buf_hinfo.renderPass = VK_NULL_HANDLE; |
| 1199 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferBeginInfo-flags-06002"); |
| 1200 | vk::BeginCommandBuffer(cb.handle(), &cmd_buf_info); |
| 1201 | m_errorMonitor->VerifyFound(); |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1202 | } |
| 1203 | |
| 1204 | TEST_F(VkLayerTest, TestDynamicRenderingPipelineMissingFlags) { |
| 1205 | TEST_DESCRIPTION("Test dynamic rendering with pipeline missing flags."); |
| 1206 | |
| 1207 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 1208 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1209 | AddOptionalExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 1210 | AddOptionalExtensions(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1211 | |
| 1212 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1213 | |
| 1214 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1215 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1216 | } |
| 1217 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1218 | if (!IsExtensionsEnabled(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME)) { |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1219 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1220 | } |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1221 | bool fragment_density = IsExtensionsEnabled(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 1222 | bool shading_rate = IsExtensionsEnabled(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1223 | |
| 1224 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 1225 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 1226 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 1227 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1228 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1229 | } |
| 1230 | |
| 1231 | auto fsr_properties = LvlInitStruct<VkPhysicalDeviceFragmentShadingRatePropertiesKHR>(); |
| 1232 | |
| 1233 | auto phys_dev_props_2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&fsr_properties); |
| 1234 | vk::GetPhysicalDeviceProperties2(gpu(), &phys_dev_props_2); |
| 1235 | |
| 1236 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT)); |
| 1237 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 1238 | |
| 1239 | VkFormat depthStencilFormat = FindSupportedDepthStencilFormat(gpu()); |
| 1240 | ASSERT_TRUE(depthStencilFormat != 0); |
| 1241 | |
| 1242 | VkImageObj image(m_device); |
| 1243 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 1244 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 1245 | image_create_info.format = depthStencilFormat; |
| 1246 | image_create_info.extent = {64, 64, 1}; |
| 1247 | image_create_info.mipLevels = 1; |
| 1248 | image_create_info.arrayLayers = 1; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1249 | image_create_info.samples = VK_SAMPLE_COUNT_1_BIT; |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1250 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
ziga-lunarg | d3de6ce | 2022-03-18 21:14:57 +0100 | [diff] [blame] | 1251 | image_create_info.usage = VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR; |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1252 | image_create_info.sharingMode = VK_SHARING_MODE_EXCLUSIVE; |
| 1253 | |
| 1254 | image.Init(image_create_info); |
| 1255 | ASSERT_TRUE(image.initialized()); |
| 1256 | |
| 1257 | VkImageViewCreateInfo ivci = {VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO, |
| 1258 | nullptr, |
| 1259 | 0, |
| 1260 | image.handle(), |
| 1261 | VK_IMAGE_VIEW_TYPE_2D, |
| 1262 | depthStencilFormat, |
| 1263 | {VK_COMPONENT_SWIZZLE_IDENTITY, VK_COMPONENT_SWIZZLE_IDENTITY, VK_COMPONENT_SWIZZLE_IDENTITY, |
| 1264 | VK_COMPONENT_SWIZZLE_IDENTITY}, |
| 1265 | {VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT, 0, 1, 0, 1}}; |
| 1266 | |
| 1267 | vk_testing::ImageView depth_image_view; |
| 1268 | depth_image_view.init(*m_device, ivci); |
| 1269 | |
| 1270 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 1271 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 1272 | |
| 1273 | if (shading_rate) { |
| 1274 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-imageView-06183"); |
| 1275 | VkRenderingFragmentShadingRateAttachmentInfoKHR fragment_shading_rate = |
| 1276 | LvlInitStruct<VkRenderingFragmentShadingRateAttachmentInfoKHR>(); |
| 1277 | fragment_shading_rate.imageView = depth_image_view.handle(); |
| 1278 | fragment_shading_rate.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 1279 | fragment_shading_rate.shadingRateAttachmentTexelSize = fsr_properties.minFragmentShadingRateAttachmentTexelSize; |
| 1280 | |
| 1281 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&fragment_shading_rate); |
ziga-lunarg | aa97cbb | 2022-03-18 19:06:35 +0100 | [diff] [blame] | 1282 | begin_rendering_info.layerCount = 1; |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1283 | begin_rendering_info.colorAttachmentCount = 1; |
| 1284 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 1285 | |
| 1286 | VkFormat color_format = VK_FORMAT_R8G8B8A8_UNORM; |
| 1287 | |
| 1288 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 1289 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 1290 | pipeline_rendering_info.pColorAttachmentFormats = &color_format; |
| 1291 | |
| 1292 | CreatePipelineHelper pipe(*this); |
| 1293 | pipe.InitInfo(); |
| 1294 | pipe.gp_ci_.pNext = &pipeline_rendering_info; |
| 1295 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 1296 | pipe.InitState(); |
| 1297 | pipe.CreateGraphicsPipeline(); |
| 1298 | |
| 1299 | m_commandBuffer->begin(); |
| 1300 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1301 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.pipeline_); |
| 1302 | vk::CmdDraw(m_commandBuffer->handle(), 3, 1, 0, 0); |
| 1303 | m_commandBuffer->EndRendering(); |
| 1304 | m_commandBuffer->end(); |
| 1305 | |
| 1306 | m_errorMonitor->VerifyFound(); |
| 1307 | } |
| 1308 | |
| 1309 | if (fragment_density) { |
| 1310 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-imageView-06184"); |
| 1311 | VkRenderingFragmentDensityMapAttachmentInfoEXT fragment_density_map = |
| 1312 | LvlInitStruct<VkRenderingFragmentDensityMapAttachmentInfoEXT>(); |
| 1313 | fragment_density_map.imageView = depth_image_view.handle(); |
| 1314 | |
| 1315 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&fragment_density_map); |
ziga-lunarg | aa97cbb | 2022-03-18 19:06:35 +0100 | [diff] [blame] | 1316 | begin_rendering_info.layerCount = 1; |
ziga-lunarg | 6c8f162 | 2022-03-14 20:14:04 +0100 | [diff] [blame] | 1317 | begin_rendering_info.colorAttachmentCount = 1; |
| 1318 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 1319 | |
| 1320 | VkFormat color_format = VK_FORMAT_R8G8B8A8_UNORM; |
| 1321 | |
| 1322 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 1323 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 1324 | pipeline_rendering_info.pColorAttachmentFormats = &color_format; |
| 1325 | |
| 1326 | CreatePipelineHelper pipe(*this); |
| 1327 | pipe.InitInfo(); |
| 1328 | pipe.gp_ci_.pNext = &pipeline_rendering_info; |
| 1329 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 1330 | pipe.InitState(); |
| 1331 | pipe.CreateGraphicsPipeline(); |
| 1332 | |
| 1333 | m_commandBuffer->begin(); |
| 1334 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1335 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.pipeline_); |
| 1336 | vk::CmdDraw(m_commandBuffer->handle(), 3, 1, 0, 0); |
| 1337 | m_commandBuffer->EndRendering(); |
| 1338 | m_commandBuffer->end(); |
| 1339 | |
| 1340 | m_errorMonitor->VerifyFound(); |
| 1341 | } |
| 1342 | } |
ziga-lunarg | bc6d8ad | 2022-03-18 13:04:20 +0100 | [diff] [blame] | 1343 | |
ziga-lunarg | 2c9067e | 2022-03-18 18:33:52 +0100 | [diff] [blame] | 1344 | TEST_F(VkLayerTest, DynamicRenderingLayerCount) { |
| 1345 | TEST_DESCRIPTION("Test dynamic rendering with viewMask 0 and invalid layer count."); |
| 1346 | |
| 1347 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 1348 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1349 | |
| 1350 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1351 | |
| 1352 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1353 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 2c9067e | 2022-03-18 18:33:52 +0100 | [diff] [blame] | 1354 | } |
| 1355 | |
| 1356 | if (!DeviceExtensionSupported(gpu(), nullptr, VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME)) { |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1357 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 2c9067e | 2022-03-18 18:33:52 +0100 | [diff] [blame] | 1358 | } |
| 1359 | |
| 1360 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 1361 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 1362 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 1363 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1364 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 2c9067e | 2022-03-18 18:33:52 +0100 | [diff] [blame] | 1365 | } |
| 1366 | |
| 1367 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 1368 | |
| 1369 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 1370 | |
| 1371 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-viewMask-06069"); |
| 1372 | m_commandBuffer->begin(); |
| 1373 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1374 | m_commandBuffer->end(); |
| 1375 | m_errorMonitor->VerifyFound(); |
| 1376 | } |
| 1377 | |
ziga-lunarg | bc6d8ad | 2022-03-18 13:04:20 +0100 | [diff] [blame] | 1378 | TEST_F(VkLayerTest, TestRenderingInfoMismatchedSamples) { |
| 1379 | TEST_DESCRIPTION("Test beginning rendering with mismatched sample counts."); |
| 1380 | |
| 1381 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 1382 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1383 | |
| 1384 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1385 | |
| 1386 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1387 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | bc6d8ad | 2022-03-18 13:04:20 +0100 | [diff] [blame] | 1388 | } |
| 1389 | |
| 1390 | if (!DeviceExtensionSupported(gpu(), nullptr, VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME)) { |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1391 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | bc6d8ad | 2022-03-18 13:04:20 +0100 | [diff] [blame] | 1392 | } |
| 1393 | |
| 1394 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 1395 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 1396 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 1397 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1398 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | bc6d8ad | 2022-03-18 13:04:20 +0100 | [diff] [blame] | 1399 | } |
| 1400 | |
| 1401 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 1402 | |
| 1403 | VkImageCreateInfo image_ci = LvlInitStruct<VkImageCreateInfo>(); |
| 1404 | image_ci.imageType = VK_IMAGE_TYPE_2D; |
| 1405 | image_ci.format = VK_FORMAT_R8G8B8A8_UNORM; |
| 1406 | image_ci.extent.width = 64; |
| 1407 | image_ci.extent.height = 64; |
| 1408 | image_ci.extent.depth = 1; |
| 1409 | image_ci.mipLevels = 1; |
| 1410 | image_ci.arrayLayers = 1; |
| 1411 | image_ci.samples = VK_SAMPLE_COUNT_2_BIT; |
| 1412 | image_ci.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 1413 | image_ci.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 1414 | |
| 1415 | VkImageObj color_image(m_device); |
| 1416 | color_image.init(&image_ci); |
| 1417 | |
| 1418 | VkImageViewCreateInfo civ_ci = LvlInitStruct<VkImageViewCreateInfo>(); |
| 1419 | civ_ci.image = color_image.handle(); |
| 1420 | civ_ci.viewType = VK_IMAGE_VIEW_TYPE_2D; |
| 1421 | civ_ci.format = VK_FORMAT_R8G8B8A8_UNORM; |
| 1422 | civ_ci.subresourceRange.layerCount = 1; |
| 1423 | civ_ci.subresourceRange.baseMipLevel = 0; |
| 1424 | civ_ci.subresourceRange.levelCount = 1; |
| 1425 | civ_ci.subresourceRange.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT; |
| 1426 | |
| 1427 | vk_testing::ImageView color_image_view; |
| 1428 | color_image_view.init(*m_device, civ_ci); |
| 1429 | |
| 1430 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 1431 | color_attachment.imageView = color_image_view.handle(); |
| 1432 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 1433 | color_attachment.resolveMode = VK_RESOLVE_MODE_NONE; |
| 1434 | |
| 1435 | const VkFormat depth_format = FindSupportedDepthOnlyFormat(gpu()); |
| 1436 | if (depth_format == VK_FORMAT_UNDEFINED) { |
| 1437 | printf("%s requires a depth only format, skipping.\n", kSkipPrefix); |
| 1438 | return; |
| 1439 | } |
| 1440 | |
| 1441 | VkImageObj depth_image(m_device); |
| 1442 | depth_image.Init(64, 64, 1, depth_format, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, VK_IMAGE_TILING_OPTIMAL); |
| 1443 | |
| 1444 | VkImageViewCreateInfo div_ci = LvlInitStruct<VkImageViewCreateInfo>(); |
| 1445 | div_ci.image = depth_image.handle(); |
| 1446 | div_ci.viewType = VK_IMAGE_VIEW_TYPE_2D; |
| 1447 | div_ci.format = depth_format; |
| 1448 | div_ci.subresourceRange.layerCount = 1; |
| 1449 | div_ci.subresourceRange.baseMipLevel = 0; |
| 1450 | div_ci.subresourceRange.levelCount = 1; |
| 1451 | div_ci.subresourceRange.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT; |
| 1452 | |
| 1453 | vk_testing::ImageView depth_image_view; |
| 1454 | depth_image_view.init(*m_device, div_ci); |
| 1455 | |
| 1456 | VkRenderingAttachmentInfoKHR depth_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 1457 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 1458 | depth_attachment.imageView = depth_image_view.handle(); |
| 1459 | depth_attachment.resolveMode = VK_RESOLVE_MODE_NONE; |
| 1460 | |
| 1461 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
ziga-lunarg | aa97cbb | 2022-03-18 19:06:35 +0100 | [diff] [blame] | 1462 | begin_rendering_info.layerCount = 1; |
ziga-lunarg | bc6d8ad | 2022-03-18 13:04:20 +0100 | [diff] [blame] | 1463 | begin_rendering_info.colorAttachmentCount = 1; |
| 1464 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 1465 | begin_rendering_info.pDepthAttachment = &depth_attachment; |
| 1466 | |
Tony-LunarG | 7384f7e | 2022-07-05 14:20:42 -0600 | [diff] [blame] | 1467 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-multisampledRenderToSingleSampled-06857"); |
ziga-lunarg | bc6d8ad | 2022-03-18 13:04:20 +0100 | [diff] [blame] | 1468 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1469 | m_errorMonitor->VerifyFound(); |
| 1470 | } |
ziga-lunarg | ec0ac1c | 2022-03-18 19:25:17 +0100 | [diff] [blame] | 1471 | |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1472 | TEST_F(VkLayerTest, TestBeginRenderingFragmentShadingRate) { |
| 1473 | TEST_DESCRIPTION("Test BeginRenderingInfo with FragmentShadingRateAttachment."); |
| 1474 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1475 | SetTargetApiVersion(VK_API_VERSION_1_2); |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1476 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1477 | AddRequiredExtensions(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
| 1478 | |
| 1479 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1480 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1481 | if (DeviceValidationVersion() < VK_API_VERSION_1_2) { |
| 1482 | GTEST_SKIP() << "At least Vulkan version 1.2 is required"; |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1483 | } |
| 1484 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1485 | if (!AreRequiredExtensionsEnabled()) { |
| 1486 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1487 | } |
| 1488 | |
| 1489 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 1490 | auto features11 = LvlInitStruct<VkPhysicalDeviceVulkan11Features>(&dynamic_rendering_features); |
| 1491 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&features11); |
| 1492 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 1493 | |
| 1494 | if (features11.multiview == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1495 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1496 | } |
| 1497 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1498 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1499 | } |
| 1500 | |
| 1501 | auto fsr_properties = LvlInitStruct<VkPhysicalDeviceFragmentShadingRatePropertiesKHR>(); |
| 1502 | |
| 1503 | auto phys_dev_props_2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&fsr_properties); |
| 1504 | vk::GetPhysicalDeviceProperties2(gpu(), &phys_dev_props_2); |
| 1505 | |
| 1506 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT)); |
| 1507 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 1508 | |
| 1509 | auto image_ci = LvlInitStruct<VkImageCreateInfo>(nullptr); |
| 1510 | image_ci.imageType = VK_IMAGE_TYPE_2D; |
| 1511 | image_ci.format = VK_FORMAT_R8G8B8A8_UNORM; |
| 1512 | image_ci.extent.width = 32; |
| 1513 | image_ci.extent.height = 32; |
| 1514 | image_ci.extent.depth = 1; |
| 1515 | image_ci.mipLevels = 1; |
| 1516 | image_ci.arrayLayers = 2; |
| 1517 | image_ci.samples = VK_SAMPLE_COUNT_1_BIT; |
| 1518 | image_ci.tiling = VK_IMAGE_TILING_OPTIMAL; |
ziga-lunarg | ade1d9e | 2022-04-25 10:59:15 +0200 | [diff] [blame] | 1519 | image_ci.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR; |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1520 | |
| 1521 | VkImageObj image(m_device); |
| 1522 | image.init(&image_ci); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1523 | VkImageView image_view = |
| 1524 | image.targetView(VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_ASPECT_COLOR_BIT, 0, 1, 0, 2, VK_IMAGE_VIEW_TYPE_2D_ARRAY); |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1525 | |
ziga-lunarg | ade1d9e | 2022-04-25 10:59:15 +0200 | [diff] [blame] | 1526 | auto fragment_shading_rate = LvlInitStruct<VkRenderingFragmentShadingRateAttachmentInfoKHR>(); |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1527 | fragment_shading_rate.imageView = image_view; |
| 1528 | fragment_shading_rate.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 1529 | fragment_shading_rate.shadingRateAttachmentTexelSize = fsr_properties.minFragmentShadingRateAttachmentTexelSize; |
| 1530 | |
| 1531 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&fragment_shading_rate); |
| 1532 | begin_rendering_info.layerCount = 4; |
| 1533 | |
| 1534 | m_commandBuffer->begin(); |
| 1535 | |
| 1536 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06123"); |
| 1537 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1538 | m_errorMonitor->VerifyFound(); |
| 1539 | |
| 1540 | begin_rendering_info.viewMask = 0xF; |
| 1541 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06124"); |
| 1542 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1543 | m_errorMonitor->VerifyFound(); |
| 1544 | |
ziga-lunarg | ade1d9e | 2022-04-25 10:59:15 +0200 | [diff] [blame] | 1545 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 1546 | color_attachment.imageView = image_view; |
| 1547 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 1548 | |
| 1549 | begin_rendering_info.layerCount = 2; |
| 1550 | begin_rendering_info.colorAttachmentCount = 1; |
| 1551 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 1552 | begin_rendering_info.viewMask = 0; |
| 1553 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06125"); |
| 1554 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1555 | m_errorMonitor->VerifyFound(); |
| 1556 | |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1557 | m_commandBuffer->end(); |
ziga-lunarg | b7fec14 | 2022-03-18 22:08:17 +0100 | [diff] [blame] | 1558 | } |
| 1559 | |
ziga-lunarg | 7e7138c | 2022-03-18 19:02:31 +0100 | [diff] [blame] | 1560 | TEST_F(VkLayerTest, TestDeviceGroupRenderPassBeginInfo) { |
| 1561 | TEST_DESCRIPTION("Test render area of DeviceGroupRenderPassBeginInfo."); |
| 1562 | |
| 1563 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 1564 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1565 | |
| 1566 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1567 | |
| 1568 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1569 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 7e7138c | 2022-03-18 19:02:31 +0100 | [diff] [blame] | 1570 | } |
| 1571 | |
| 1572 | if (!DeviceExtensionSupported(gpu(), nullptr, VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME)) { |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1573 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 7e7138c | 2022-03-18 19:02:31 +0100 | [diff] [blame] | 1574 | } |
| 1575 | |
| 1576 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 1577 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 1578 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 1579 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1580 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 7e7138c | 2022-03-18 19:02:31 +0100 | [diff] [blame] | 1581 | } |
| 1582 | |
| 1583 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT)); |
| 1584 | |
| 1585 | VkRect2D render_area = {}; |
| 1586 | render_area.offset.x = 0; |
| 1587 | render_area.offset.y = 0; |
| 1588 | render_area.extent.width = 32; |
| 1589 | render_area.extent.height = 32; |
| 1590 | |
| 1591 | auto device_group_render_pass_begin_info = LvlInitStruct<VkDeviceGroupRenderPassBeginInfo>(); |
| 1592 | device_group_render_pass_begin_info.deviceRenderAreaCount = 1; |
| 1593 | device_group_render_pass_begin_info.pDeviceRenderAreas = &render_area; |
| 1594 | |
| 1595 | VkImageObj colorImage(m_device); |
| 1596 | colorImage.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UINT, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 1597 | VkImageView colorImageView = colorImage.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 1598 | |
| 1599 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 1600 | color_attachment.imageView = colorImageView; |
| 1601 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 1602 | |
| 1603 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&device_group_render_pass_begin_info); |
ziga-lunarg | 1fec633 | 2022-03-20 14:39:54 +0100 | [diff] [blame] | 1604 | begin_rendering_info.layerCount = 1; |
ziga-lunarg | 7e7138c | 2022-03-18 19:02:31 +0100 | [diff] [blame] | 1605 | begin_rendering_info.colorAttachmentCount = 1; |
| 1606 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 1607 | |
| 1608 | m_commandBuffer->begin(); |
| 1609 | |
ziga-lunarg | 7e7138c | 2022-03-18 19:02:31 +0100 | [diff] [blame] | 1610 | m_commandBuffer->BeginRendering(begin_rendering_info); |
ziga-lunarg | 7e7138c | 2022-03-18 19:02:31 +0100 | [diff] [blame] | 1611 | |
| 1612 | render_area.offset.x = 1; |
| 1613 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06083"); |
| 1614 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1615 | m_errorMonitor->VerifyFound(); |
| 1616 | |
| 1617 | render_area.offset.x = 0; |
| 1618 | render_area.offset.y = 16; |
| 1619 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06084"); |
| 1620 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1621 | m_errorMonitor->VerifyFound(); |
ziga-lunarg | 7e7138c | 2022-03-18 19:02:31 +0100 | [diff] [blame] | 1622 | } |
| 1623 | |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1624 | TEST_F(VkLayerTest, TestBeginRenderingInvalidFragmentShadingRateImage) { |
| 1625 | TEST_DESCRIPTION("Test BeginRendering with FragmentShadingRateAttachmentInfo with missing image usage bit."); |
| 1626 | |
| 1627 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 1628 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1629 | AddRequiredExtensions(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
| 1630 | |
| 1631 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1632 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 1633 | if (IsDriver(VK_DRIVER_ID_AMD_PROPRIETARY)) { |
| 1634 | GTEST_SKIP() << "Skipping on AMD proprietary driver pending further investigation."; |
| 1635 | } |
| 1636 | |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1637 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1638 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1639 | } |
| 1640 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1641 | if (!AreRequiredExtensionsEnabled()) { |
| 1642 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1643 | } |
| 1644 | |
| 1645 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 1646 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 1647 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 1648 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1649 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1650 | } |
| 1651 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 1652 | |
| 1653 | auto fsr_properties = LvlInitStruct<VkPhysicalDeviceFragmentShadingRatePropertiesKHR>(); |
| 1654 | auto properties2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&fsr_properties); |
| 1655 | vk::GetPhysicalDeviceProperties2(gpu(), &properties2); |
| 1656 | |
| 1657 | VkImageObj image(m_device); |
ziga-lunarg | d3de6ce | 2022-03-18 21:14:57 +0100 | [diff] [blame] | 1658 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UINT, |
| 1659 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR); |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1660 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 1661 | |
ziga-lunarg | d3de6ce | 2022-03-18 21:14:57 +0100 | [diff] [blame] | 1662 | VkImageObj invalid_image(m_device); |
| 1663 | invalid_image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UINT, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 1664 | VkImageView invalid_image_view = invalid_image.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 1665 | |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1666 | auto fragment_shading_rate = LvlInitStruct<VkRenderingFragmentShadingRateAttachmentInfoKHR>(); |
ziga-lunarg | d3de6ce | 2022-03-18 21:14:57 +0100 | [diff] [blame] | 1667 | fragment_shading_rate.imageView = invalid_image_view; |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1668 | fragment_shading_rate.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 1669 | fragment_shading_rate.shadingRateAttachmentTexelSize = fsr_properties.minFragmentShadingRateAttachmentTexelSize; |
| 1670 | |
| 1671 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&fragment_shading_rate); |
ziga-lunarg | d3de6ce | 2022-03-18 21:14:57 +0100 | [diff] [blame] | 1672 | begin_rendering_info.layerCount = 1; |
| 1673 | |
| 1674 | m_commandBuffer->begin(); |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1675 | |
| 1676 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06148"); |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1677 | m_commandBuffer->BeginRendering(begin_rendering_info); |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1678 | m_errorMonitor->VerifyFound(); |
ziga-lunarg | d3de6ce | 2022-03-18 21:14:57 +0100 | [diff] [blame] | 1679 | fragment_shading_rate.imageView = image_view; |
| 1680 | |
| 1681 | fragment_shading_rate.shadingRateAttachmentTexelSize.width = fsr_properties.minFragmentShadingRateAttachmentTexelSize.width + 1; |
| 1682 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06149"); |
| 1683 | if (fragment_shading_rate.shadingRateAttachmentTexelSize.width > |
| 1684 | fsr_properties.minFragmentShadingRateAttachmentTexelSize.width) { |
| 1685 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06150"); |
| 1686 | } |
| 1687 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1688 | m_errorMonitor->VerifyFound(); |
| 1689 | |
| 1690 | if (fsr_properties.minFragmentShadingRateAttachmentTexelSize.width > 1) { |
| 1691 | fragment_shading_rate.shadingRateAttachmentTexelSize.width = |
| 1692 | fsr_properties.minFragmentShadingRateAttachmentTexelSize.width / 2; |
| 1693 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06151"); |
| 1694 | if (fragment_shading_rate.shadingRateAttachmentTexelSize.height / |
| 1695 | fragment_shading_rate.shadingRateAttachmentTexelSize.width >= |
| 1696 | fsr_properties.maxFragmentShadingRateAttachmentTexelSizeAspectRatio) { |
| 1697 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06156"); |
| 1698 | } |
| 1699 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1700 | m_errorMonitor->VerifyFound(); |
| 1701 | } |
| 1702 | |
| 1703 | fragment_shading_rate.shadingRateAttachmentTexelSize.width = fsr_properties.minFragmentShadingRateAttachmentTexelSize.width; |
| 1704 | |
| 1705 | fragment_shading_rate.shadingRateAttachmentTexelSize.height = |
| 1706 | fsr_properties.minFragmentShadingRateAttachmentTexelSize.height + 1; |
| 1707 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06152"); |
| 1708 | if (fragment_shading_rate.shadingRateAttachmentTexelSize.height > |
| 1709 | fsr_properties.minFragmentShadingRateAttachmentTexelSize.height) { |
| 1710 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06153"); |
| 1711 | } |
| 1712 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1713 | m_errorMonitor->VerifyFound(); |
| 1714 | |
| 1715 | if (fsr_properties.minFragmentShadingRateAttachmentTexelSize.height > 1) { |
| 1716 | fragment_shading_rate.shadingRateAttachmentTexelSize.height = |
| 1717 | fsr_properties.minFragmentShadingRateAttachmentTexelSize.height / 2; |
| 1718 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06154"); |
| 1719 | if (fragment_shading_rate.shadingRateAttachmentTexelSize.width / |
| 1720 | fragment_shading_rate.shadingRateAttachmentTexelSize.height > |
| 1721 | fsr_properties.maxFragmentShadingRateAttachmentTexelSizeAspectRatio) { |
| 1722 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06155"); |
| 1723 | } |
| 1724 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1725 | m_errorMonitor->VerifyFound(); |
| 1726 | } |
| 1727 | |
| 1728 | m_commandBuffer->end(); |
ziga-lunarg | 184a20b | 2022-03-18 20:54:48 +0100 | [diff] [blame] | 1729 | } |
| 1730 | |
ziga-lunarg | ec0ac1c | 2022-03-18 19:25:17 +0100 | [diff] [blame] | 1731 | TEST_F(VkLayerTest, BeginRenderingInvalidDepthAttachmentFormat) { |
| 1732 | TEST_DESCRIPTION("Test begin rendering with a depth attachment that has an invalid format"); |
| 1733 | |
| 1734 | SetTargetApiVersion(VK_API_VERSION_1_3); |
| 1735 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1736 | |
| 1737 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1738 | |
| 1739 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1740 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | ec0ac1c | 2022-03-18 19:25:17 +0100 | [diff] [blame] | 1741 | } |
| 1742 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1743 | if (!AreRequiredExtensionsEnabled()) { |
| 1744 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | ec0ac1c | 2022-03-18 19:25:17 +0100 | [diff] [blame] | 1745 | } |
| 1746 | |
| 1747 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 1748 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 1749 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 1750 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1751 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | ec0ac1c | 2022-03-18 19:25:17 +0100 | [diff] [blame] | 1752 | } |
| 1753 | |
| 1754 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 1755 | |
| 1756 | VkFormat stencil_format = FindSupportedStencilOnlyFormat(gpu()); |
| 1757 | if (stencil_format == VK_FORMAT_UNDEFINED) { |
| 1758 | printf("%s requires a stencil only format format.\n", kSkipPrefix); |
| 1759 | return; |
| 1760 | } |
| 1761 | |
| 1762 | VkImageObj image(m_device); |
| 1763 | image.Init(32, 32, 1, stencil_format, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); |
| 1764 | VkImageView image_view = image.targetView(stencil_format, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 1765 | |
| 1766 | VkRenderingAttachmentInfoKHR depth_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 1767 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_OPTIMAL; |
| 1768 | depth_attachment.imageView = image_view; |
| 1769 | |
| 1770 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
ziga-lunarg | 1fec633 | 2022-03-20 14:39:54 +0100 | [diff] [blame] | 1771 | begin_rendering_info.layerCount = 1; |
ziga-lunarg | ec0ac1c | 2022-03-18 19:25:17 +0100 | [diff] [blame] | 1772 | begin_rendering_info.pDepthAttachment = &depth_attachment; |
| 1773 | |
| 1774 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06547"); |
| 1775 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1776 | m_errorMonitor->VerifyFound(); |
| 1777 | } |
ziga-lunarg | 4b5bb5b | 2022-03-20 00:49:04 +0100 | [diff] [blame] | 1778 | |
ziga-lunarg | 14a6978 | 2022-03-20 00:39:31 +0100 | [diff] [blame] | 1779 | TEST_F(VkLayerTest, TestFragmentDensityMapRenderArea) { |
| 1780 | TEST_DESCRIPTION("Validate VkRenderingFragmentDensityMapAttachmentInfo attachment image view extent."); |
| 1781 | |
| 1782 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 1783 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1784 | AddRequiredExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 1785 | |
| 1786 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1787 | |
| 1788 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1789 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 14a6978 | 2022-03-20 00:39:31 +0100 | [diff] [blame] | 1790 | } |
| 1791 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1792 | if (!AreRequiredExtensionsEnabled()) { |
| 1793 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 14a6978 | 2022-03-20 00:39:31 +0100 | [diff] [blame] | 1794 | } |
| 1795 | |
| 1796 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 1797 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 1798 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 1799 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1800 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 14a6978 | 2022-03-20 00:39:31 +0100 | [diff] [blame] | 1801 | } |
| 1802 | |
| 1803 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 1804 | |
| 1805 | auto fdm_props = LvlInitStruct<VkPhysicalDeviceFragmentDensityMapPropertiesEXT>(); |
| 1806 | auto props2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&fdm_props); |
| 1807 | vk::GetPhysicalDeviceProperties2(gpu(), &props2); |
| 1808 | |
| 1809 | VkImageObj image(m_device); |
ziga-lunarg | 2aa8d59 | 2022-04-25 14:29:13 +0200 | [diff] [blame] | 1810 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UINT, |
| 1811 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT); |
ziga-lunarg | 14a6978 | 2022-03-20 00:39:31 +0100 | [diff] [blame] | 1812 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UINT, VK_IMAGE_ASPECT_COLOR_BIT, 0, 1, 0, 1); |
| 1813 | |
| 1814 | auto fragment_density_map = LvlInitStruct<VkRenderingFragmentDensityMapAttachmentInfoEXT>(); |
| 1815 | fragment_density_map.imageView = image_view; |
ziga-lunarg | 2aa8d59 | 2022-04-25 14:29:13 +0200 | [diff] [blame] | 1816 | fragment_density_map.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 1817 | |
ziga-lunarg | 14a6978 | 2022-03-20 00:39:31 +0100 | [diff] [blame] | 1818 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&fragment_density_map); |
| 1819 | begin_rendering_info.layerCount = 1; |
| 1820 | begin_rendering_info.renderArea.extent.width = 64 * fdm_props.maxFragmentDensityTexelSize.width; |
| 1821 | begin_rendering_info.renderArea.extent.height = 32 * fdm_props.maxFragmentDensityTexelSize.height; |
| 1822 | |
| 1823 | m_commandBuffer->begin(); |
| 1824 | |
| 1825 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06112"); |
| 1826 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1827 | m_errorMonitor->VerifyFound(); |
| 1828 | |
| 1829 | begin_rendering_info.renderArea.extent.width = 32 * fdm_props.maxFragmentDensityTexelSize.width; |
| 1830 | begin_rendering_info.renderArea.extent.height = 64 * fdm_props.maxFragmentDensityTexelSize.height; |
| 1831 | |
| 1832 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06114"); |
| 1833 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1834 | m_errorMonitor->VerifyFound(); |
| 1835 | |
| 1836 | VkRect2D device_render_area = {}; |
| 1837 | device_render_area.extent.width = 64 * fdm_props.maxFragmentDensityTexelSize.width; |
| 1838 | device_render_area.extent.height = 32 * fdm_props.maxFragmentDensityTexelSize.height; |
| 1839 | auto device_group_render_pass_begin_info = LvlInitStruct<VkDeviceGroupRenderPassBeginInfo>(); |
| 1840 | device_group_render_pass_begin_info.deviceRenderAreaCount = 1; |
| 1841 | device_group_render_pass_begin_info.pDeviceRenderAreas = &device_render_area; |
| 1842 | fragment_density_map.pNext = &device_group_render_pass_begin_info; |
| 1843 | |
| 1844 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06113"); |
| 1845 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1846 | m_errorMonitor->VerifyFound(); |
| 1847 | |
| 1848 | device_render_area.extent.width = 32 * fdm_props.maxFragmentDensityTexelSize.width; |
| 1849 | device_render_area.extent.height = 64 * fdm_props.maxFragmentDensityTexelSize.height; |
| 1850 | |
| 1851 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06115"); |
| 1852 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1853 | m_errorMonitor->VerifyFound(); |
| 1854 | |
| 1855 | m_commandBuffer->end(); |
| 1856 | } |
| 1857 | |
ziga-lunarg | 50253b9 | 2022-04-25 14:36:13 +0200 | [diff] [blame] | 1858 | TEST_F(VkLayerTest, TestFragmentDensityMapRenderAreaWithoutDeviceGroupExt) { |
| 1859 | TEST_DESCRIPTION("Validate VkRenderingFragmentDensityMapAttachmentInfo attachment image view extent."); |
| 1860 | |
| 1861 | SetTargetApiVersion(VK_API_VERSION_1_0); |
| 1862 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1863 | AddRequiredExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 1864 | |
| 1865 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1866 | |
| 1867 | if (DeviceValidationVersion() != VK_API_VERSION_1_0) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1868 | GTEST_SKIP() << "Tests for 1.0 only"; |
ziga-lunarg | 50253b9 | 2022-04-25 14:36:13 +0200 | [diff] [blame] | 1869 | } |
| 1870 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 1871 | if (!AreRequiredExtensionsEnabled()) { |
| 1872 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 50253b9 | 2022-04-25 14:36:13 +0200 | [diff] [blame] | 1873 | } |
| 1874 | |
| 1875 | auto vkGetPhysicalDeviceFeatures2KHR = reinterpret_cast<PFN_vkGetPhysicalDeviceFeatures2KHR>( |
| 1876 | vk::GetInstanceProcAddr(instance(), "vkGetPhysicalDeviceFeatures2KHR")); |
| 1877 | ASSERT_TRUE(vkGetPhysicalDeviceFeatures2KHR != nullptr); |
| 1878 | |
| 1879 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 1880 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2KHR>(&dynamic_rendering_features); |
| 1881 | vkGetPhysicalDeviceFeatures2KHR(gpu(), &features2); |
| 1882 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 1883 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 50253b9 | 2022-04-25 14:36:13 +0200 | [diff] [blame] | 1884 | } |
| 1885 | |
| 1886 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 1887 | |
| 1888 | auto fdm_props = LvlInitStruct<VkPhysicalDeviceFragmentDensityMapPropertiesEXT>(); |
| 1889 | auto props2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&fdm_props); |
| 1890 | vk::GetPhysicalDeviceProperties2(gpu(), &props2); |
| 1891 | |
| 1892 | VkImageObj image(m_device); |
| 1893 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UINT, |
| 1894 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT); |
| 1895 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UINT, VK_IMAGE_ASPECT_COLOR_BIT, 0, 1, 0, 1); |
| 1896 | |
| 1897 | auto fragment_density_map = LvlInitStruct<VkRenderingFragmentDensityMapAttachmentInfoEXT>(); |
| 1898 | fragment_density_map.imageView = image_view; |
| 1899 | fragment_density_map.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 1900 | |
| 1901 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&fragment_density_map); |
| 1902 | begin_rendering_info.layerCount = 1; |
| 1903 | begin_rendering_info.renderArea.extent.width = 64 * fdm_props.maxFragmentDensityTexelSize.width; |
| 1904 | begin_rendering_info.renderArea.extent.height = 32 * fdm_props.maxFragmentDensityTexelSize.height; |
| 1905 | |
| 1906 | m_commandBuffer->begin(); |
| 1907 | |
| 1908 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06110"); |
| 1909 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1910 | m_errorMonitor->VerifyFound(); |
| 1911 | |
| 1912 | begin_rendering_info.renderArea.extent.width = 32 * fdm_props.maxFragmentDensityTexelSize.width; |
| 1913 | begin_rendering_info.renderArea.extent.height = 64 * fdm_props.maxFragmentDensityTexelSize.height; |
| 1914 | |
| 1915 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06111"); |
| 1916 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 1917 | m_errorMonitor->VerifyFound(); |
| 1918 | |
| 1919 | m_commandBuffer->end(); |
| 1920 | } |
| 1921 | |
ziga-lunarg | e7279ba | 2022-03-31 20:55:27 +0200 | [diff] [blame] | 1922 | TEST_F(VkLayerTest, TestBarrierWithDynamicRendering) { |
| 1923 | TEST_DESCRIPTION("Test setting buffer memory barrier when dynamic rendering is active."); |
| 1924 | |
| 1925 | SetTargetApiVersion(VK_API_VERSION_1_3); |
| 1926 | |
| 1927 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1928 | |
| 1929 | if (DeviceValidationVersion() < VK_API_VERSION_1_3) { |
sjfricke | bdd58dd | 2022-05-20 14:22:50 +0900 | [diff] [blame] | 1930 | GTEST_SKIP() << "At least Vulkan version 1.3 is required"; |
ziga-lunarg | e7279ba | 2022-03-31 20:55:27 +0200 | [diff] [blame] | 1931 | } |
| 1932 | |
| 1933 | auto vk13features = LvlInitStruct<VkPhysicalDeviceVulkan13Features>(); |
| 1934 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&vk13features); |
| 1935 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 1936 | if (!vk13features.dynamicRendering) { |
| 1937 | printf("%s Test requires (unsupported) dynamicRendering, skipping\n", kSkipPrefix); |
| 1938 | return; |
| 1939 | } |
| 1940 | if (!vk13features.synchronization2) { |
| 1941 | printf("%s Test requires (unsupported) synchronization2, skipping\n", kSkipPrefix); |
| 1942 | return; |
| 1943 | } |
| 1944 | |
| 1945 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 1946 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 1947 | |
| 1948 | PFN_vkCmdBeginRendering vkCmdBeginRendering = |
| 1949 | reinterpret_cast<PFN_vkCmdBeginRendering>(vk::GetDeviceProcAddr(m_device->device(), "vkCmdBeginRendering")); |
| 1950 | assert(vkCmdBeginRendering != nullptr); |
| 1951 | PFN_vkCmdEndRendering vkCmdEndRendering = |
| 1952 | reinterpret_cast<PFN_vkCmdEndRendering>(vk::GetDeviceProcAddr(m_device->device(), "vkCmdEndRendering")); |
| 1953 | assert(vkCmdEndRendering != nullptr); |
| 1954 | |
| 1955 | m_commandBuffer->begin(); |
| 1956 | |
| 1957 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 1958 | VkClearRect clear_rect = {{{0, 0}, {(uint32_t)m_width, (uint32_t)m_height}}, 0, 1}; |
| 1959 | begin_rendering_info.renderArea = clear_rect.rect; |
| 1960 | begin_rendering_info.layerCount = 1; |
| 1961 | |
| 1962 | vkCmdBeginRendering(m_commandBuffer->handle(), &begin_rendering_info); |
| 1963 | |
| 1964 | VkBufferObj buffer; |
| 1965 | VkMemoryPropertyFlags mem_reqs = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT; |
| 1966 | buffer.init_as_src_and_dst(*m_device, 256, mem_reqs); |
| 1967 | |
| 1968 | auto buf_barrier = lvl_init_struct<VkBufferMemoryBarrier2KHR>(); |
| 1969 | buf_barrier.buffer = buffer.handle(); |
| 1970 | buf_barrier.offset = 0; |
| 1971 | buf_barrier.size = VK_WHOLE_SIZE; |
| 1972 | buf_barrier.srcStageMask = VK_PIPELINE_STAGE_ALL_COMMANDS_BIT; |
| 1973 | buf_barrier.dstStageMask = VK_PIPELINE_STAGE_ALL_COMMANDS_BIT; |
| 1974 | |
| 1975 | auto dependency_info = lvl_init_struct<VkDependencyInfoKHR>(); |
| 1976 | dependency_info.bufferMemoryBarrierCount = 1; |
| 1977 | dependency_info.pBufferMemoryBarriers = &buf_barrier; |
| 1978 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdPipelineBarrier2-None-06191"); |
| 1979 | vk::CmdPipelineBarrier2(m_commandBuffer->handle(), &dependency_info); |
| 1980 | m_errorMonitor->VerifyFound(); |
| 1981 | |
| 1982 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdPipelineBarrier-None-06191"); |
| 1983 | vk::CmdPipelineBarrier(m_commandBuffer->handle(), VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, 0, 0, |
| 1984 | nullptr, 0, nullptr, 0, nullptr); |
| 1985 | m_errorMonitor->VerifyFound(); |
| 1986 | |
| 1987 | vkCmdEndRendering(m_commandBuffer->handle()); |
| 1988 | m_commandBuffer->end(); |
| 1989 | } |
| 1990 | |
ziga-lunarg | 5e0a245 | 2022-04-20 19:29:37 +0200 | [diff] [blame] | 1991 | TEST_F(VkLayerTest, BeginRenderingInvalidStencilAttachmentFormat) { |
| 1992 | TEST_DESCRIPTION("Test begin rendering with a stencil attachment that has an invalid format"); |
| 1993 | |
| 1994 | SetTargetApiVersion(VK_API_VERSION_1_3); |
| 1995 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 1996 | |
| 1997 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 1998 | |
| 1999 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
| 2000 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
| 2001 | } |
| 2002 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2003 | if (!AreRequiredExtensionsEnabled()) { |
| 2004 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 5e0a245 | 2022-04-20 19:29:37 +0200 | [diff] [blame] | 2005 | } |
| 2006 | |
| 2007 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2008 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2009 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2010 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2011 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 5e0a245 | 2022-04-20 19:29:37 +0200 | [diff] [blame] | 2012 | } |
| 2013 | |
| 2014 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2015 | |
| 2016 | VkFormat depth_format = FindSupportedDepthOnlyFormat(gpu()); |
| 2017 | if (depth_format == VK_FORMAT_UNDEFINED) { |
| 2018 | printf("%s requires a stencil only format format.\n", kSkipPrefix); |
| 2019 | return; |
| 2020 | } |
| 2021 | |
| 2022 | VkImageObj image(m_device); |
| 2023 | image.Init(32, 32, 1, depth_format, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); |
| 2024 | VkImageView image_view = image.targetView(depth_format, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 2025 | |
| 2026 | VkRenderingAttachmentInfoKHR stencil_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 2027 | stencil_attachment.imageLayout = VK_IMAGE_LAYOUT_STENCIL_ATTACHMENT_OPTIMAL; |
| 2028 | stencil_attachment.imageView = image_view; |
| 2029 | |
| 2030 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 2031 | begin_rendering_info.layerCount = 1; |
| 2032 | begin_rendering_info.pStencilAttachment = &stencil_attachment; |
| 2033 | |
| 2034 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pStencilAttachment-06548"); |
| 2035 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2036 | m_errorMonitor->VerifyFound(); |
| 2037 | } |
| 2038 | |
| 2039 | TEST_F(VkLayerTest, TestInheritanceRenderingInfoStencilAttachmentFormat) { |
| 2040 | TEST_DESCRIPTION("Test begin rendering with a stencil attachment that has an invalid format"); |
| 2041 | |
| 2042 | SetTargetApiVersion(VK_API_VERSION_1_3); |
| 2043 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2044 | |
| 2045 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2046 | |
| 2047 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
| 2048 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
| 2049 | } |
| 2050 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2051 | if (!AreRequiredExtensionsEnabled()) { |
| 2052 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 5e0a245 | 2022-04-20 19:29:37 +0200 | [diff] [blame] | 2053 | } |
| 2054 | |
| 2055 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2056 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2057 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2058 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2059 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 5e0a245 | 2022-04-20 19:29:37 +0200 | [diff] [blame] | 2060 | } |
| 2061 | |
| 2062 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2063 | |
| 2064 | VkFormat depth_format = FindSupportedDepthOnlyFormat(gpu()); |
| 2065 | if (depth_format == VK_FORMAT_UNDEFINED) { |
| 2066 | printf("%s requires a stencil only format format.\n", kSkipPrefix); |
| 2067 | return; |
| 2068 | } |
| 2069 | |
| 2070 | VkFormat color_format = VK_FORMAT_R8G8B8A8_UNORM; |
| 2071 | |
| 2072 | auto cmd_buffer_inheritance_rendering_info = LvlInitStruct<VkCommandBufferInheritanceRenderingInfoKHR>(); |
| 2073 | cmd_buffer_inheritance_rendering_info.colorAttachmentCount = 1; |
| 2074 | cmd_buffer_inheritance_rendering_info.pColorAttachmentFormats = &color_format; |
| 2075 | cmd_buffer_inheritance_rendering_info.depthAttachmentFormat = depth_format; |
| 2076 | cmd_buffer_inheritance_rendering_info.stencilAttachmentFormat = depth_format; |
| 2077 | cmd_buffer_inheritance_rendering_info.rasterizationSamples = VK_SAMPLE_COUNT_1_BIT; |
| 2078 | |
| 2079 | auto cmd_buffer_inheritance_info = LvlInitStruct<VkCommandBufferInheritanceInfo>(); |
| 2080 | cmd_buffer_inheritance_info.pNext = &cmd_buffer_inheritance_rendering_info; |
| 2081 | cmd_buffer_inheritance_info.renderPass = VK_NULL_HANDLE; |
| 2082 | |
| 2083 | VkCommandBufferBeginInfo cmd_buffer_begin_info = LvlInitStruct<VkCommandBufferBeginInfo>(); |
| 2084 | cmd_buffer_begin_info.flags = VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT; |
| 2085 | cmd_buffer_begin_info.pInheritanceInfo = &cmd_buffer_inheritance_info; |
| 2086 | |
| 2087 | auto cmd_buffer_allocate_info = LvlInitStruct<VkCommandBufferAllocateInfo>(); |
| 2088 | cmd_buffer_allocate_info.commandPool = m_commandPool->handle(); |
| 2089 | cmd_buffer_allocate_info.level = VK_COMMAND_BUFFER_LEVEL_SECONDARY; |
| 2090 | cmd_buffer_allocate_info.commandBufferCount = 1; |
| 2091 | |
| 2092 | VkCommandBuffer secondary_cmd_buffer; |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 2093 | vk::AllocateCommandBuffers(m_device->device(), &cmd_buffer_allocate_info, &secondary_cmd_buffer); |
ziga-lunarg | 5e0a245 | 2022-04-20 19:29:37 +0200 | [diff] [blame] | 2094 | |
| 2095 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkCommandBufferInheritanceRenderingInfo-stencilAttachmentFormat-06541"); |
| 2096 | vk::BeginCommandBuffer(secondary_cmd_buffer, &cmd_buffer_begin_info); |
| 2097 | m_errorMonitor->VerifyFound(); |
| 2098 | } |
ziga-lunarg | eb4a69c | 2022-04-20 21:52:00 +0200 | [diff] [blame] | 2099 | |
| 2100 | TEST_F(VkLayerTest, CreateGraphicsPipelineWithInvalidAttachmentSampleCount) { |
| 2101 | TEST_DESCRIPTION("Create pipeline with fragment shader that uses samples, but multisample state not begin set"); |
| 2102 | |
ziga-lunarg | 7f25dff | 2022-05-06 17:49:34 +0200 | [diff] [blame] | 2103 | SetTargetApiVersion(VK_API_VERSION_1_1); |
ziga-lunarg | eb4a69c | 2022-04-20 21:52:00 +0200 | [diff] [blame] | 2104 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2105 | AddRequiredExtensions(VK_NV_FRAMEBUFFER_MIXED_SAMPLES_EXTENSION_NAME); |
| 2106 | |
| 2107 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2108 | |
| 2109 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2110 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | eb4a69c | 2022-04-20 21:52:00 +0200 | [diff] [blame] | 2111 | } |
| 2112 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2113 | if (!AreRequiredExtensionsEnabled()) { |
| 2114 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | eb4a69c | 2022-04-20 21:52:00 +0200 | [diff] [blame] | 2115 | } |
| 2116 | |
| 2117 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2118 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2119 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2120 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2121 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | eb4a69c | 2022-04-20 21:52:00 +0200 | [diff] [blame] | 2122 | } |
| 2123 | |
| 2124 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2125 | VkFormat color_format = VK_FORMAT_R8G8B8A8_UNORM; |
| 2126 | |
| 2127 | auto sample_count_info_amd = LvlInitStruct<VkAttachmentSampleCountInfoNV>(); |
| 2128 | sample_count_info_amd.colorAttachmentCount = 1; |
ziga-lunarg | 7f25dff | 2022-05-06 17:49:34 +0200 | [diff] [blame] | 2129 | sample_count_info_amd.depthStencilAttachmentSamples = static_cast<VkSampleCountFlagBits>(0x3); |
ziga-lunarg | eb4a69c | 2022-04-20 21:52:00 +0200 | [diff] [blame] | 2130 | |
| 2131 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(&sample_count_info_amd); |
| 2132 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 2133 | pipeline_rendering_info.pColorAttachmentFormats = &color_format; |
| 2134 | |
| 2135 | CreatePipelineHelper pipe(*this); |
| 2136 | pipe.InitInfo(); |
| 2137 | pipe.gp_ci_.pNext = &pipeline_rendering_info; |
| 2138 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2139 | pipe.InitState(); |
| 2140 | |
| 2141 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-depthStencilAttachmentSamples-06593"); |
| 2142 | pipe.CreateGraphicsPipeline(); |
| 2143 | m_errorMonitor->VerifyFound(); |
| 2144 | } |
ziga-lunarg | d680bf2 | 2022-04-20 22:01:00 +0200 | [diff] [blame] | 2145 | |
| 2146 | TEST_F(VkLayerTest, CreatePipelineUsingDynamicRenderingWithoutFeature) { |
| 2147 | TEST_DESCRIPTION("Create graphcis pipeline that uses dynamic rendering, but feature is not enabled"); |
| 2148 | |
| 2149 | SetTargetApiVersion(VK_API_VERSION_1_3); |
| 2150 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2151 | AddRequiredExtensions(VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME); |
| 2152 | |
| 2153 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2154 | |
| 2155 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2156 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | d680bf2 | 2022-04-20 22:01:00 +0200 | [diff] [blame] | 2157 | } |
| 2158 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2159 | if (!AreRequiredExtensionsEnabled()) { |
| 2160 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | d680bf2 | 2022-04-20 22:01:00 +0200 | [diff] [blame] | 2161 | } |
| 2162 | |
| 2163 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 2164 | |
| 2165 | CreatePipelineHelper pipe(*this); |
| 2166 | pipe.InitInfo(); |
| 2167 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2168 | pipe.InitState(); |
| 2169 | |
| 2170 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-dynamicRendering-06576"); |
| 2171 | pipe.CreateGraphicsPipeline(); |
| 2172 | m_errorMonitor->VerifyFound(); |
| 2173 | } |
ziga-lunarg | f20d795 | 2022-04-20 22:11:40 +0200 | [diff] [blame] | 2174 | |
ziga-lunarg | 6ed1dad | 2022-04-20 23:14:53 +0200 | [diff] [blame] | 2175 | TEST_F(VkLayerTest, DynamicRenderingAreaGreaterThanAttachmentExtent) { |
| 2176 | TEST_DESCRIPTION("Begin dynamic rendering with render area greater than extent of attachments"); |
| 2177 | |
| 2178 | SetTargetApiVersion(VK_API_VERSION_1_0); |
| 2179 | AddRequiredExtensions(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME); |
| 2180 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2181 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2182 | |
| 2183 | if (DeviceValidationVersion() != VK_API_VERSION_1_0) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2184 | GTEST_SKIP() << "Tests for 1.0 only"; |
ziga-lunarg | 6ed1dad | 2022-04-20 23:14:53 +0200 | [diff] [blame] | 2185 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2186 | if (!AreRequiredExtensionsEnabled()) { |
| 2187 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 6ed1dad | 2022-04-20 23:14:53 +0200 | [diff] [blame] | 2188 | } |
| 2189 | |
ziga-lunarg | a51287c | 2022-04-20 23:24:37 +0200 | [diff] [blame] | 2190 | auto vkGetPhysicalDeviceFeatures2KHR = reinterpret_cast<PFN_vkGetPhysicalDeviceFeatures2KHR>( |
| 2191 | vk::GetInstanceProcAddr(instance(), "vkGetPhysicalDeviceFeatures2KHR")); |
ziga-lunarg | 6ed1dad | 2022-04-20 23:14:53 +0200 | [diff] [blame] | 2192 | ASSERT_TRUE(vkGetPhysicalDeviceFeatures2KHR != nullptr); |
| 2193 | |
| 2194 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2195 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2KHR>(&dynamic_rendering_features); |
| 2196 | vkGetPhysicalDeviceFeatures2KHR(gpu(), &features2); |
| 2197 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2198 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 6ed1dad | 2022-04-20 23:14:53 +0200 | [diff] [blame] | 2199 | } |
| 2200 | |
| 2201 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2202 | |
| 2203 | VkImageObj colorImage(m_device); |
| 2204 | colorImage.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UINT, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 2205 | VkImageView colorImageView = colorImage.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 2206 | |
ziga-lunarg | a51287c | 2022-04-20 23:24:37 +0200 | [diff] [blame] | 2207 | auto color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
ziga-lunarg | 6ed1dad | 2022-04-20 23:14:53 +0200 | [diff] [blame] | 2208 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 2209 | color_attachment.imageView = colorImageView; |
| 2210 | |
ziga-lunarg | a51287c | 2022-04-20 23:24:37 +0200 | [diff] [blame] | 2211 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
ziga-lunarg | 6ed1dad | 2022-04-20 23:14:53 +0200 | [diff] [blame] | 2212 | begin_rendering_info.layerCount = 1; |
| 2213 | begin_rendering_info.colorAttachmentCount = 1; |
| 2214 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 2215 | begin_rendering_info.renderArea.extent.width = 64; |
| 2216 | begin_rendering_info.renderArea.extent.height = 32; |
| 2217 | |
| 2218 | m_commandBuffer->begin(); |
| 2219 | |
| 2220 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06075"); |
| 2221 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2222 | m_errorMonitor->VerifyFound(); |
| 2223 | |
| 2224 | begin_rendering_info.renderArea.extent.width = 32; |
| 2225 | begin_rendering_info.renderArea.extent.height = 64; |
| 2226 | |
| 2227 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06076"); |
| 2228 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2229 | m_errorMonitor->VerifyFound(); |
| 2230 | |
| 2231 | const VkFormat ds_format = FindSupportedDepthStencilFormat(gpu()); |
| 2232 | if (ds_format != VK_FORMAT_UNDEFINED) { |
| 2233 | VkImageObj depthImage(m_device); |
| 2234 | depthImage.Init(32, 32, 1, ds_format, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); |
| 2235 | VkImageView depthImageView = depthImage.targetView(ds_format, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 2236 | |
| 2237 | VkRenderingAttachmentInfoKHR depth_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 2238 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_OPTIMAL; |
| 2239 | depth_attachment.imageView = depthImageView; |
| 2240 | |
| 2241 | begin_rendering_info.colorAttachmentCount = 0; |
| 2242 | begin_rendering_info.pDepthAttachment = &depth_attachment; |
| 2243 | |
| 2244 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06076"); |
| 2245 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2246 | m_errorMonitor->VerifyFound(); |
| 2247 | } |
| 2248 | |
| 2249 | m_commandBuffer->end(); |
| 2250 | } |
ziga-lunarg | a51287c | 2022-04-20 23:24:37 +0200 | [diff] [blame] | 2251 | |
| 2252 | TEST_F(VkLayerTest, DynamicRenderingDeviceGroupAreaGreaterThanAttachmentExtent) { |
| 2253 | TEST_DESCRIPTION("Begin dynamic rendering with device group with render area greater than extent of attachments"); |
| 2254 | |
| 2255 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2256 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2257 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2258 | |
| 2259 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2260 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | a51287c | 2022-04-20 23:24:37 +0200 | [diff] [blame] | 2261 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2262 | if (!AreRequiredExtensionsEnabled()) { |
| 2263 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | a51287c | 2022-04-20 23:24:37 +0200 | [diff] [blame] | 2264 | } |
| 2265 | |
| 2266 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2267 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2268 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2269 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2270 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | a51287c | 2022-04-20 23:24:37 +0200 | [diff] [blame] | 2271 | } |
| 2272 | |
| 2273 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2274 | |
| 2275 | VkImageObj colorImage(m_device); |
| 2276 | colorImage.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UINT, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 2277 | VkImageView colorImageView = colorImage.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 2278 | |
| 2279 | auto color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 2280 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 2281 | color_attachment.imageView = colorImageView; |
| 2282 | |
| 2283 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 2284 | begin_rendering_info.layerCount = 1; |
| 2285 | begin_rendering_info.colorAttachmentCount = 1; |
| 2286 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 2287 | begin_rendering_info.renderArea.extent.width = 64; |
| 2288 | begin_rendering_info.renderArea.extent.height = 32; |
| 2289 | |
| 2290 | m_commandBuffer->begin(); |
| 2291 | |
| 2292 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06079"); |
| 2293 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2294 | m_errorMonitor->VerifyFound(); |
| 2295 | |
| 2296 | begin_rendering_info.renderArea.extent.width = 32; |
| 2297 | begin_rendering_info.renderArea.extent.height = 64; |
| 2298 | |
| 2299 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06080"); |
| 2300 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2301 | m_errorMonitor->VerifyFound(); |
| 2302 | |
| 2303 | const VkFormat ds_format = FindSupportedDepthStencilFormat(gpu()); |
| 2304 | if (ds_format != VK_FORMAT_UNDEFINED) { |
| 2305 | VkImageObj depthImage(m_device); |
| 2306 | depthImage.Init(32, 32, 1, ds_format, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); |
| 2307 | VkImageView depthImageView = depthImage.targetView(ds_format, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 2308 | |
| 2309 | VkRenderingAttachmentInfoKHR depth_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 2310 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_OPTIMAL; |
| 2311 | depth_attachment.imageView = depthImageView; |
| 2312 | |
| 2313 | begin_rendering_info.colorAttachmentCount = 0; |
| 2314 | begin_rendering_info.pDepthAttachment = &depth_attachment; |
| 2315 | |
| 2316 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06080"); |
| 2317 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2318 | m_errorMonitor->VerifyFound(); |
| 2319 | } |
| 2320 | |
| 2321 | m_commandBuffer->end(); |
| 2322 | } |
ziga-lunarg | d4105c1 | 2022-04-21 13:54:20 +0200 | [diff] [blame] | 2323 | |
| 2324 | TEST_F(VkLayerTest, SecondaryCommandBufferIncompatibleRenderPass) { |
| 2325 | TEST_DESCRIPTION("Execute secondary command buffers within render pass instance with incompatible render pass"); |
| 2326 | |
| 2327 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2328 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2329 | |
| 2330 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2331 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | d4105c1 | 2022-04-21 13:54:20 +0200 | [diff] [blame] | 2332 | } |
| 2333 | |
| 2334 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 2335 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2336 | |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 2337 | VkSubpassDescription subpass = {}; |
ziga-lunarg | d4105c1 | 2022-04-21 13:54:20 +0200 | [diff] [blame] | 2338 | auto render_pass_ci = LvlInitStruct<VkRenderPassCreateInfo>(); |
ziga-lunarg | a3cc848 | 2022-04-29 14:58:29 +0200 | [diff] [blame] | 2339 | render_pass_ci.subpassCount = 1; |
| 2340 | render_pass_ci.pSubpasses = &subpass; |
ziga-lunarg | d4105c1 | 2022-04-21 13:54:20 +0200 | [diff] [blame] | 2341 | |
| 2342 | vk_testing::RenderPass render_pass; |
| 2343 | render_pass.init(*m_device, render_pass_ci); |
| 2344 | |
| 2345 | VkCommandBufferObj cb(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY); |
| 2346 | VkCommandBuffer secondary_handle = cb.handle(); |
| 2347 | |
| 2348 | auto cmd_buffer_inheritance_info = LvlInitStruct<VkCommandBufferInheritanceInfo>(); |
| 2349 | cmd_buffer_inheritance_info.renderPass = render_pass.handle(); |
| 2350 | VkCommandBufferBeginInfo cmd_buffer_begin_info = LvlInitStruct<VkCommandBufferBeginInfo>(); |
| 2351 | cmd_buffer_begin_info.flags = VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT; |
| 2352 | cmd_buffer_begin_info.pInheritanceInfo = &cmd_buffer_inheritance_info; |
| 2353 | |
| 2354 | cb.begin(&cmd_buffer_begin_info); |
| 2355 | cb.end(); |
| 2356 | |
| 2357 | m_commandBuffer->begin(); |
| 2358 | m_commandBuffer->BeginRenderPass(m_renderPassBeginInfo, VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS); |
| 2359 | |
| 2360 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdExecuteCommands-pBeginInfo-06020"); |
| 2361 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdExecuteCommands-pInheritanceInfo-00098"); |
| 2362 | vk::CmdExecuteCommands(m_commandBuffer->handle(), 1, &secondary_handle); |
| 2363 | m_errorMonitor->VerifyFound(); |
| 2364 | |
| 2365 | m_commandBuffer->EndRenderPass(); |
| 2366 | m_commandBuffer->end(); |
| 2367 | } |
ziga-lunarg | 590e029 | 2022-04-21 14:07:22 +0200 | [diff] [blame] | 2368 | |
| 2369 | TEST_F(VkLayerTest, SecondaryCommandBufferIncompatibleSubpass) { |
| 2370 | TEST_DESCRIPTION("Execute secondary command buffers with different subpass"); |
| 2371 | |
| 2372 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2373 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2374 | |
| 2375 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2376 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 590e029 | 2022-04-21 14:07:22 +0200 | [diff] [blame] | 2377 | } |
| 2378 | |
| 2379 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 2380 | |
| 2381 | VkSubpassDescription subpasses[2] = {}; |
| 2382 | |
| 2383 | auto render_pass_ci = LvlInitStruct<VkRenderPassCreateInfo>(); |
| 2384 | render_pass_ci.subpassCount = 2; |
| 2385 | render_pass_ci.pSubpasses = subpasses; |
| 2386 | |
| 2387 | vk_testing::RenderPass render_pass; |
| 2388 | render_pass.init(*m_device, render_pass_ci); |
| 2389 | |
| 2390 | auto framebuffer_ci = LvlInitStruct<VkFramebufferCreateInfo>(); |
| 2391 | framebuffer_ci.renderPass = render_pass.handle(); |
| 2392 | framebuffer_ci.width = 32; |
| 2393 | framebuffer_ci.height = 32; |
ziga-lunarg | 143bdbf | 2022-05-04 19:04:58 +0200 | [diff] [blame] | 2394 | framebuffer_ci.layers = 1; |
ziga-lunarg | 590e029 | 2022-04-21 14:07:22 +0200 | [diff] [blame] | 2395 | |
| 2396 | vk_testing::Framebuffer framebuffer; |
| 2397 | framebuffer.init(*m_device, framebuffer_ci); |
| 2398 | |
| 2399 | VkCommandBufferObj cb(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY); |
| 2400 | VkCommandBuffer secondary_handle = cb.handle(); |
| 2401 | |
| 2402 | auto cmd_buffer_inheritance_info = LvlInitStruct<VkCommandBufferInheritanceInfo>(); |
| 2403 | cmd_buffer_inheritance_info.renderPass = render_pass.handle(); |
| 2404 | VkCommandBufferBeginInfo cmd_buffer_begin_info = LvlInitStruct<VkCommandBufferBeginInfo>(); |
| 2405 | cmd_buffer_begin_info.flags = VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT; |
| 2406 | cmd_buffer_begin_info.pInheritanceInfo = &cmd_buffer_inheritance_info; |
| 2407 | |
| 2408 | cb.begin(&cmd_buffer_begin_info); |
| 2409 | cb.end(); |
| 2410 | |
| 2411 | auto render_pass_begin_info = LvlInitStruct<VkRenderPassBeginInfo>(); |
| 2412 | render_pass_begin_info.renderPass = render_pass.handle(); |
| 2413 | render_pass_begin_info.renderArea.extent = {32, 32}; |
| 2414 | render_pass_begin_info.framebuffer = framebuffer.handle(); |
| 2415 | |
| 2416 | m_commandBuffer->begin(); |
| 2417 | m_commandBuffer->BeginRenderPass(render_pass_begin_info, VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS); |
| 2418 | vk::CmdNextSubpass(m_commandBuffer->handle(), VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS); |
| 2419 | |
| 2420 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdExecuteCommands-pCommandBuffers-00097"); |
| 2421 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdExecuteCommands-pCommandBuffers-06019"); |
| 2422 | vk::CmdExecuteCommands(m_commandBuffer->handle(), 1, &secondary_handle); |
| 2423 | m_errorMonitor->VerifyFound(); |
| 2424 | |
| 2425 | m_commandBuffer->EndRenderPass(); |
| 2426 | m_commandBuffer->end(); |
| 2427 | } |
ziga-lunarg | 343193b | 2022-04-21 14:15:17 +0200 | [diff] [blame] | 2428 | |
| 2429 | TEST_F(VkLayerTest, SecondaryCommandBufferInvalidContents) { |
| 2430 | TEST_DESCRIPTION("Execute secondary command buffers within active render pass that was not begun with VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS"); |
| 2431 | |
| 2432 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2433 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2434 | |
| 2435 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2436 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 343193b | 2022-04-21 14:15:17 +0200 | [diff] [blame] | 2437 | } |
| 2438 | |
| 2439 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 2440 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2441 | |
ziga-lunarg | 343193b | 2022-04-21 14:15:17 +0200 | [diff] [blame] | 2442 | VkCommandBufferObj cb(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY); |
| 2443 | VkCommandBuffer secondary_handle = cb.handle(); |
| 2444 | |
| 2445 | auto cmd_buffer_inheritance_info = LvlInitStruct<VkCommandBufferInheritanceInfo>(); |
| 2446 | cmd_buffer_inheritance_info.renderPass = m_renderPass; |
| 2447 | VkCommandBufferBeginInfo cmd_buffer_begin_info = LvlInitStruct<VkCommandBufferBeginInfo>(); |
| 2448 | cmd_buffer_begin_info.flags = VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT; |
| 2449 | cmd_buffer_begin_info.pInheritanceInfo = &cmd_buffer_inheritance_info; |
| 2450 | |
| 2451 | cb.begin(&cmd_buffer_begin_info); |
| 2452 | cb.end(); |
| 2453 | |
| 2454 | m_commandBuffer->begin(); |
| 2455 | m_commandBuffer->BeginRenderPass(m_renderPassBeginInfo); |
| 2456 | |
| 2457 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdExecuteCommands-contents-00095"); |
| 2458 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdExecuteCommands-contents-06018"); |
| 2459 | vk::CmdExecuteCommands(m_commandBuffer->handle(), 1, &secondary_handle); |
| 2460 | m_errorMonitor->VerifyFound(); |
| 2461 | |
| 2462 | m_commandBuffer->EndRenderPass(); |
| 2463 | m_commandBuffer->end(); |
| 2464 | } |
ziga-lunarg | 9104e0a | 2022-04-21 16:45:09 +0200 | [diff] [blame] | 2465 | |
| 2466 | TEST_F(VkLayerTest, BindPipelineWithIncompatibleRenderingInfoDepthFormat) { |
| 2467 | TEST_DESCRIPTION("Bind pipeline that has RenderingInfo DepthFormat incompatible with previously used pipeline"); |
| 2468 | |
| 2469 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2470 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2471 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2472 | |
| 2473 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2474 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 9104e0a | 2022-04-21 16:45:09 +0200 | [diff] [blame] | 2475 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2476 | if (!AreRequiredExtensionsEnabled()) { |
| 2477 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 9104e0a | 2022-04-21 16:45:09 +0200 | [diff] [blame] | 2478 | } |
| 2479 | |
| 2480 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2481 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2482 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2483 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2484 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 9104e0a | 2022-04-21 16:45:09 +0200 | [diff] [blame] | 2485 | } |
| 2486 | |
| 2487 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2488 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2489 | |
ziga-lunarg | 9104e0a | 2022-04-21 16:45:09 +0200 | [diff] [blame] | 2490 | std::vector<VkFormat> depth_formats; |
| 2491 | const VkFormat ds_formats[] = {VK_FORMAT_D16_UNORM_S8_UINT, VK_FORMAT_D24_UNORM_S8_UINT, VK_FORMAT_D32_SFLOAT_S8_UINT}; |
| 2492 | for (uint32_t i = 0; i < size(ds_formats); ++i) { |
| 2493 | VkFormatProperties format_props; |
| 2494 | vk::GetPhysicalDeviceFormatProperties(gpu(), ds_formats[i], &format_props); |
| 2495 | |
| 2496 | if (format_props.optimalTilingFeatures & VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT) { |
| 2497 | depth_formats.push_back(ds_formats[i]); |
| 2498 | } |
| 2499 | } |
| 2500 | |
| 2501 | if (depth_formats.size() < 2) { |
| 2502 | printf("%s Test requires 2 depth formats, skipping test.\n", kSkipPrefix); |
| 2503 | return; |
| 2504 | } |
| 2505 | |
| 2506 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 2507 | pipeline_rendering_info.depthAttachmentFormat = depth_formats[0]; |
| 2508 | |
| 2509 | auto ds_ci = LvlInitStruct<VkPipelineDepthStencilStateCreateInfo>(); |
| 2510 | |
| 2511 | CreatePipelineHelper pipe1(*this); |
| 2512 | pipe1.InitInfo(); |
| 2513 | pipe1.gp_ci_.pNext = &pipeline_rendering_info; |
| 2514 | pipe1.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2515 | pipe1.InitState(); |
| 2516 | pipe1.ds_ci_ = ds_ci; |
| 2517 | pipe1.CreateGraphicsPipeline(); |
| 2518 | |
| 2519 | pipeline_rendering_info.depthAttachmentFormat = depth_formats[1]; |
| 2520 | |
| 2521 | CreatePipelineHelper pipe2(*this); |
| 2522 | pipe2.InitInfo(); |
| 2523 | pipe2.gp_ci_.pNext = &pipeline_rendering_info; |
| 2524 | pipe2.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2525 | pipe2.InitState(); |
| 2526 | pipe2.ds_ci_ = ds_ci; |
| 2527 | pipe2.CreateGraphicsPipeline(); |
| 2528 | |
| 2529 | VkImageObj image(m_device); |
| 2530 | image.Init(32, 32, 1, depth_formats[0], VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, VK_IMAGE_TILING_LINEAR, 0); |
| 2531 | VkImageView depth_image_view = image.targetView(depth_formats[0], VK_IMAGE_ASPECT_DEPTH_BIT); |
| 2532 | |
| 2533 | VkRenderingAttachmentInfoKHR depth_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 2534 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_OPTIMAL; |
| 2535 | depth_attachment.imageView = depth_image_view; |
| 2536 | |
| 2537 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 2538 | begin_rendering_info.layerCount = 1; |
| 2539 | begin_rendering_info.pDepthAttachment = &depth_attachment; |
| 2540 | |
| 2541 | m_commandBuffer->begin(); |
| 2542 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2543 | |
| 2544 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe1.pipeline_); |
| 2545 | vk::CmdDraw(m_commandBuffer->handle(), 3, 1, 0, 0); |
| 2546 | |
ziga-lunarg | 9104e0a | 2022-04-21 16:45:09 +0200 | [diff] [blame] | 2547 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdBindPipeline-pipeline-06197"); |
| 2548 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe2.pipeline_); |
| 2549 | m_errorMonitor->VerifyFound(); |
| 2550 | |
| 2551 | m_commandBuffer->EndRendering(); |
| 2552 | m_commandBuffer->end(); |
| 2553 | } |
ziga-lunarg | 1ac9b67 | 2022-04-21 17:55:28 +0200 | [diff] [blame] | 2554 | |
| 2555 | TEST_F(VkLayerTest, BindPipelineWithIncompatibleRenderingInfoColorAttachments) { |
| 2556 | TEST_DESCRIPTION("Bind pipeline that has RenderingInfo color attachment incompatible with previously used pipeline"); |
| 2557 | |
| 2558 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2559 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2560 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2561 | |
| 2562 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2563 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 1ac9b67 | 2022-04-21 17:55:28 +0200 | [diff] [blame] | 2564 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2565 | if (!AreRequiredExtensionsEnabled()) { |
| 2566 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 1ac9b67 | 2022-04-21 17:55:28 +0200 | [diff] [blame] | 2567 | } |
| 2568 | |
| 2569 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2570 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2571 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2572 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2573 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 1ac9b67 | 2022-04-21 17:55:28 +0200 | [diff] [blame] | 2574 | } |
| 2575 | |
| 2576 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2577 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2578 | |
ziga-lunarg | 1ac9b67 | 2022-04-21 17:55:28 +0200 | [diff] [blame] | 2579 | VkFormat format = VK_FORMAT_R8G8B8A8_UNORM; |
| 2580 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 2581 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 2582 | pipeline_rendering_info.pColorAttachmentFormats = &format; |
| 2583 | |
| 2584 | CreatePipelineHelper pipe1(*this); |
| 2585 | pipe1.InitInfo(); |
| 2586 | pipe1.gp_ci_.pNext = &pipeline_rendering_info; |
| 2587 | pipe1.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2588 | pipe1.InitState(); |
| 2589 | pipe1.CreateGraphicsPipeline(); |
| 2590 | |
| 2591 | format = VK_FORMAT_B8G8R8A8_UNORM; |
| 2592 | |
| 2593 | CreatePipelineHelper pipe2(*this); |
| 2594 | pipe2.InitInfo(); |
| 2595 | pipe2.gp_ci_.pNext = &pipeline_rendering_info; |
| 2596 | pipe2.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2597 | pipe2.InitState(); |
| 2598 | pipe2.CreateGraphicsPipeline(); |
| 2599 | |
| 2600 | VkImageObj image(m_device); |
| 2601 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, VK_IMAGE_TILING_LINEAR, 0); |
| 2602 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 2603 | |
| 2604 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 2605 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 2606 | color_attachment.imageView = image_view; |
| 2607 | |
| 2608 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 2609 | begin_rendering_info.layerCount = 1; |
| 2610 | begin_rendering_info.colorAttachmentCount = 1; |
| 2611 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 2612 | |
| 2613 | m_commandBuffer->begin(); |
| 2614 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2615 | |
| 2616 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe1.pipeline_); |
| 2617 | vk::CmdDraw(m_commandBuffer->handle(), 3, 1, 0, 0); |
| 2618 | |
ziga-lunarg | 1ac9b67 | 2022-04-21 17:55:28 +0200 | [diff] [blame] | 2619 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdBindPipeline-pipeline-06196"); |
| 2620 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe2.pipeline_); |
| 2621 | m_errorMonitor->VerifyFound(); |
| 2622 | |
| 2623 | m_commandBuffer->EndRendering(); |
| 2624 | m_commandBuffer->end(); |
| 2625 | } |
ziga-lunarg | acd7932 | 2022-04-21 18:36:34 +0200 | [diff] [blame] | 2626 | |
| 2627 | TEST_F(VkLayerTest, BindPipelineWithIncompatibleRenderingInfoColorAttachmentCount) { |
| 2628 | TEST_DESCRIPTION("Bind pipeline that has RenderingInfo color attachment count incompatible with previously used pipeline"); |
| 2629 | |
| 2630 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2631 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2632 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2633 | |
| 2634 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2635 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | acd7932 | 2022-04-21 18:36:34 +0200 | [diff] [blame] | 2636 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2637 | if (!AreRequiredExtensionsEnabled()) { |
| 2638 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | acd7932 | 2022-04-21 18:36:34 +0200 | [diff] [blame] | 2639 | } |
| 2640 | |
| 2641 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2642 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2643 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2644 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2645 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | acd7932 | 2022-04-21 18:36:34 +0200 | [diff] [blame] | 2646 | } |
| 2647 | |
| 2648 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2649 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2650 | |
ziga-lunarg | acd7932 | 2022-04-21 18:36:34 +0200 | [diff] [blame] | 2651 | VkFormat format = VK_FORMAT_R8G8B8A8_UNORM; |
| 2652 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 2653 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 2654 | pipeline_rendering_info.pColorAttachmentFormats = &format; |
| 2655 | |
| 2656 | CreatePipelineHelper pipe1(*this); |
| 2657 | pipe1.InitInfo(); |
| 2658 | pipe1.gp_ci_.pNext = &pipeline_rendering_info; |
| 2659 | pipe1.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2660 | pipe1.InitState(); |
| 2661 | pipe1.CreateGraphicsPipeline(); |
| 2662 | |
| 2663 | pipeline_rendering_info.colorAttachmentCount = 0; |
| 2664 | |
| 2665 | CreatePipelineHelper pipe2(*this); |
| 2666 | pipe2.InitInfo(); |
| 2667 | pipe2.gp_ci_.pNext = &pipeline_rendering_info; |
| 2668 | pipe2.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2669 | pipe2.InitState(); |
| 2670 | pipe2.CreateGraphicsPipeline(); |
| 2671 | |
| 2672 | VkImageObj image(m_device); |
| 2673 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, VK_IMAGE_TILING_LINEAR, 0); |
| 2674 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 2675 | |
| 2676 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 2677 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 2678 | color_attachment.imageView = image_view; |
| 2679 | |
| 2680 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 2681 | begin_rendering_info.layerCount = 1; |
| 2682 | begin_rendering_info.colorAttachmentCount = 1; |
| 2683 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 2684 | |
| 2685 | m_commandBuffer->begin(); |
| 2686 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2687 | |
| 2688 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe1.pipeline_); |
| 2689 | vk::CmdDraw(m_commandBuffer->handle(), 3, 1, 0, 0); |
| 2690 | |
ziga-lunarg | acd7932 | 2022-04-21 18:36:34 +0200 | [diff] [blame] | 2691 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdBindPipeline-pipeline-06195"); |
| 2692 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe2.pipeline_); |
| 2693 | m_errorMonitor->VerifyFound(); |
| 2694 | |
| 2695 | m_commandBuffer->EndRendering(); |
| 2696 | m_commandBuffer->end(); |
ziga-lunarg | e3f1128 | 2022-04-21 18:39:55 +0200 | [diff] [blame] | 2697 | } |
| 2698 | |
| 2699 | TEST_F(VkLayerTest, BindPipelineWithIncompatibleRenderingInfoStencilFormat) { |
| 2700 | TEST_DESCRIPTION("Bind pipeline that has RenderingInfo StencilFormat incompatible with previously used pipeline"); |
| 2701 | |
| 2702 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2703 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2704 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2705 | |
| 2706 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2707 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | e3f1128 | 2022-04-21 18:39:55 +0200 | [diff] [blame] | 2708 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2709 | if (!AreRequiredExtensionsEnabled()) { |
| 2710 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | e3f1128 | 2022-04-21 18:39:55 +0200 | [diff] [blame] | 2711 | } |
| 2712 | |
| 2713 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2714 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2715 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2716 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2717 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | e3f1128 | 2022-04-21 18:39:55 +0200 | [diff] [blame] | 2718 | } |
| 2719 | |
| 2720 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2721 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2722 | |
ziga-lunarg | e3f1128 | 2022-04-21 18:39:55 +0200 | [diff] [blame] | 2723 | std::vector<VkFormat> stencil_formats; |
| 2724 | const VkFormat ds_formats[] = {VK_FORMAT_D16_UNORM_S8_UINT, VK_FORMAT_D24_UNORM_S8_UINT, VK_FORMAT_D32_SFLOAT_S8_UINT}; |
| 2725 | for (uint32_t i = 0; i < size(ds_formats); ++i) { |
| 2726 | VkFormatProperties format_props; |
| 2727 | vk::GetPhysicalDeviceFormatProperties(gpu(), ds_formats[i], &format_props); |
| 2728 | |
| 2729 | if (format_props.optimalTilingFeatures & VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT) { |
| 2730 | stencil_formats.push_back(ds_formats[i]); |
| 2731 | } |
| 2732 | } |
| 2733 | |
| 2734 | if (stencil_formats.size() < 2) { |
| 2735 | printf("%s Test requires 2 stencil formats, skipping test.\n", kSkipPrefix); |
| 2736 | return; |
| 2737 | } |
| 2738 | |
| 2739 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 2740 | pipeline_rendering_info.stencilAttachmentFormat = stencil_formats[0]; |
| 2741 | |
| 2742 | auto ds_ci = LvlInitStruct<VkPipelineDepthStencilStateCreateInfo>(); |
| 2743 | |
| 2744 | CreatePipelineHelper pipe1(*this); |
| 2745 | pipe1.InitInfo(); |
| 2746 | pipe1.gp_ci_.pNext = &pipeline_rendering_info; |
| 2747 | pipe1.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2748 | pipe1.InitState(); |
| 2749 | pipe1.ds_ci_ = ds_ci; |
| 2750 | pipe1.CreateGraphicsPipeline(); |
| 2751 | |
| 2752 | pipeline_rendering_info.stencilAttachmentFormat = stencil_formats[1]; |
| 2753 | |
| 2754 | CreatePipelineHelper pipe2(*this); |
| 2755 | pipe2.InitInfo(); |
| 2756 | pipe2.gp_ci_.pNext = &pipeline_rendering_info; |
| 2757 | pipe2.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2758 | pipe2.InitState(); |
| 2759 | pipe2.ds_ci_ = ds_ci; |
| 2760 | pipe2.CreateGraphicsPipeline(); |
| 2761 | |
| 2762 | VkImageObj image(m_device); |
| 2763 | image.Init(32, 32, 1, stencil_formats[0], VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, VK_IMAGE_TILING_LINEAR, 0); |
| 2764 | VkImageView stencil_image_view = image.targetView(stencil_formats[0], VK_IMAGE_ASPECT_DEPTH_BIT); |
| 2765 | |
| 2766 | VkRenderingAttachmentInfoKHR stencil_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 2767 | stencil_attachment.imageLayout = VK_IMAGE_LAYOUT_STENCIL_ATTACHMENT_OPTIMAL; |
| 2768 | stencil_attachment.imageView = stencil_image_view; |
| 2769 | |
| 2770 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 2771 | begin_rendering_info.layerCount = 1; |
| 2772 | begin_rendering_info.pStencilAttachment = &stencil_attachment; |
| 2773 | |
| 2774 | m_commandBuffer->begin(); |
| 2775 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 2776 | |
| 2777 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe1.pipeline_); |
| 2778 | vk::CmdDraw(m_commandBuffer->handle(), 3, 1, 0, 0); |
| 2779 | |
ziga-lunarg | e3f1128 | 2022-04-21 18:39:55 +0200 | [diff] [blame] | 2780 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdBindPipeline-pipeline-06194"); |
| 2781 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe2.pipeline_); |
| 2782 | m_errorMonitor->VerifyFound(); |
| 2783 | |
| 2784 | m_commandBuffer->EndRendering(); |
| 2785 | m_commandBuffer->end(); |
| 2786 | } |
ziga-lunarg | 155ed45 | 2022-04-21 23:54:06 +0200 | [diff] [blame] | 2787 | |
| 2788 | TEST_F(VkLayerTest, DynamicRenderingWithInvalidShaderLayerBuiltIn) { |
| 2789 | TEST_DESCRIPTION("Create invalid pipeline that writes to Layer built-in"); |
| 2790 | |
| 2791 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2792 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2793 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2794 | |
| 2795 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2796 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 155ed45 | 2022-04-21 23:54:06 +0200 | [diff] [blame] | 2797 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2798 | if (!AreRequiredExtensionsEnabled()) { |
| 2799 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 155ed45 | 2022-04-21 23:54:06 +0200 | [diff] [blame] | 2800 | } |
| 2801 | |
| 2802 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2803 | auto multiview_features = LvlInitStruct<VkPhysicalDeviceMultiviewFeatures>(&dynamic_rendering_features); |
| 2804 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&multiview_features); |
| 2805 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2806 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2807 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 155ed45 | 2022-04-21 23:54:06 +0200 | [diff] [blame] | 2808 | } |
| 2809 | if (multiview_features.multiview == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2810 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | 155ed45 | 2022-04-21 23:54:06 +0200 | [diff] [blame] | 2811 | } |
| 2812 | if (multiview_features.multiviewGeometryShader == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2813 | GTEST_SKIP() << "Test requires (unsupported) multiviewGeometryShader"; |
ziga-lunarg | 155ed45 | 2022-04-21 23:54:06 +0200 | [diff] [blame] | 2814 | } |
| 2815 | |
| 2816 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2817 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2818 | |
| 2819 | static char const *gsSource = R"glsl( |
| 2820 | #version 450 |
| 2821 | layout (triangles) in; |
| 2822 | layout (triangle_strip) out; |
| 2823 | layout (max_vertices = 1) out; |
| 2824 | void main() { |
| 2825 | gl_Position = vec4(1.0, 0.5, 0.5, 0.0); |
| 2826 | EmitVertex(); |
| 2827 | gl_Layer = 4; |
| 2828 | } |
| 2829 | )glsl"; |
| 2830 | |
| 2831 | VkShaderObj vs(this, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX_BIT); |
| 2832 | VkShaderObj gs(this, gsSource, VK_SHADER_STAGE_GEOMETRY_BIT); |
| 2833 | |
| 2834 | VkFormat color_format = VK_FORMAT_R8G8B8A8_UNORM; |
| 2835 | |
| 2836 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 2837 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 2838 | pipeline_rendering_info.pColorAttachmentFormats = &color_format; |
| 2839 | pipeline_rendering_info.viewMask = 0x1; |
| 2840 | |
| 2841 | CreatePipelineHelper pipe(*this); |
| 2842 | pipe.InitInfo(); |
| 2843 | pipe.shader_stages_ = {vs.GetStageCreateInfo(), gs.GetStageCreateInfo(), pipe.fs_->GetStageCreateInfo()}; |
| 2844 | pipe.gp_ci_.pNext = &pipeline_rendering_info; |
| 2845 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2846 | pipe.InitState(); |
| 2847 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06059"); |
| 2848 | pipe.CreateGraphicsPipeline(); |
| 2849 | m_errorMonitor->VerifyFound(); |
| 2850 | } |
ziga-lunarg | 6feb463 | 2022-04-22 00:20:21 +0200 | [diff] [blame] | 2851 | |
| 2852 | TEST_F(VkLayerTest, DynamicRenderingWithInputAttachmentCapability) { |
| 2853 | TEST_DESCRIPTION("Create invalid pipeline that uses InputAttachment capability"); |
| 2854 | |
| 2855 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2856 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2857 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2858 | |
| 2859 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2860 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 6feb463 | 2022-04-22 00:20:21 +0200 | [diff] [blame] | 2861 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2862 | if (!AreRequiredExtensionsEnabled()) { |
| 2863 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 6feb463 | 2022-04-22 00:20:21 +0200 | [diff] [blame] | 2864 | } |
| 2865 | |
| 2866 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2867 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2868 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2869 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2870 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 6feb463 | 2022-04-22 00:20:21 +0200 | [diff] [blame] | 2871 | } |
| 2872 | |
| 2873 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2874 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2875 | |
sjfricke | 394227a | 2022-06-20 16:47:38 +0900 | [diff] [blame] | 2876 | const char *fsSource = R"( |
ziga-lunarg | 6feb463 | 2022-04-22 00:20:21 +0200 | [diff] [blame] | 2877 | OpCapability Shader |
| 2878 | OpCapability InputAttachment |
| 2879 | %1 = OpExtInstImport "GLSL.std.450" |
| 2880 | OpMemoryModel Logical GLSL450 |
| 2881 | OpEntryPoint Fragment %main "main" |
| 2882 | OpExecutionMode %main OriginUpperLeft |
| 2883 | |
| 2884 | ; Debug Information |
| 2885 | OpSource GLSL 450 |
| 2886 | OpName %main "main" ; id %4 |
| 2887 | |
| 2888 | ; Types, variables and constants |
| 2889 | %void = OpTypeVoid |
| 2890 | %3 = OpTypeFunction %void |
| 2891 | |
| 2892 | ; Function main |
| 2893 | %main = OpFunction %void None %3 |
| 2894 | %5 = OpLabel |
| 2895 | OpReturn |
| 2896 | OpFunctionEnd |
| 2897 | )"; |
| 2898 | |
| 2899 | VkShaderObj fs(this, fsSource, VK_SHADER_STAGE_FRAGMENT_BIT, SPV_ENV_VULKAN_1_0, SPV_SOURCE_ASM); |
| 2900 | |
| 2901 | VkFormat color_format = VK_FORMAT_R8G8B8A8_UNORM; |
| 2902 | |
| 2903 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 2904 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 2905 | pipeline_rendering_info.pColorAttachmentFormats = &color_format; |
| 2906 | |
| 2907 | CreatePipelineHelper pipe(*this); |
| 2908 | pipe.InitInfo(); |
| 2909 | pipe.shader_stages_ = {pipe.vs_->GetStageCreateInfo(), fs.GetStageCreateInfo()}; |
| 2910 | pipe.gp_ci_.pNext = &pipeline_rendering_info; |
| 2911 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2912 | pipe.InitState(); |
| 2913 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06061"); |
| 2914 | pipe.CreateGraphicsPipeline(); |
| 2915 | m_errorMonitor->VerifyFound(); |
| 2916 | } |
ziga-lunarg | a62b6ce | 2022-04-22 14:33:47 +0200 | [diff] [blame] | 2917 | |
| 2918 | TEST_F(VkLayerTest, InvalidRenderingInfoColorAttachmentFormat) { |
| 2919 | TEST_DESCRIPTION("Create pipeline with invalid color attachment format"); |
| 2920 | |
| 2921 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2922 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2923 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2924 | |
| 2925 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2926 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | a62b6ce | 2022-04-22 14:33:47 +0200 | [diff] [blame] | 2927 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2928 | if (!AreRequiredExtensionsEnabled()) { |
| 2929 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | a62b6ce | 2022-04-22 14:33:47 +0200 | [diff] [blame] | 2930 | } |
| 2931 | |
| 2932 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 2933 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 2934 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 2935 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2936 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | a62b6ce | 2022-04-22 14:33:47 +0200 | [diff] [blame] | 2937 | } |
| 2938 | |
| 2939 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 2940 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2941 | |
| 2942 | VkFormat color_format = VK_FORMAT_MAX_ENUM; |
| 2943 | |
| 2944 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 2945 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 2946 | pipeline_rendering_info.pColorAttachmentFormats = &color_format; |
| 2947 | |
| 2948 | CreatePipelineHelper pipe(*this); |
| 2949 | pipe.InitInfo(); |
| 2950 | pipe.gp_ci_.pNext = &pipeline_rendering_info; |
| 2951 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 2952 | pipe.InitState(); |
| 2953 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06579"); |
| 2954 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06580"); |
| 2955 | pipe.CreateGraphicsPipeline(); |
| 2956 | m_errorMonitor->VerifyFound(); |
| 2957 | } |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 2958 | |
| 2959 | TEST_F(VkLayerTest, InvalidDynamicRenderingLibraryViewMask) { |
| 2960 | TEST_DESCRIPTION("Create pipeline with invalid view mask"); |
| 2961 | |
| 2962 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 2963 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 2964 | AddRequiredExtensions(VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME); |
| 2965 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 2966 | |
| 2967 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2968 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 2969 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 2970 | if (!AreRequiredExtensionsEnabled()) { |
| 2971 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 2972 | } |
| 2973 | |
| 2974 | auto multiview_features = LvlInitStruct<VkPhysicalDeviceMultiviewFeatures>(); |
| 2975 | auto library_features = LvlInitStruct<VkPhysicalDeviceGraphicsPipelineLibraryFeaturesEXT>(&multiview_features); |
| 2976 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(&library_features); |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 2977 | GetPhysicalDeviceFeatures2(dynamic_rendering_features); |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 2978 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2979 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 2980 | } |
| 2981 | if (library_features.graphicsPipelineLibrary == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2982 | GTEST_SKIP() << "Test requires (unsupported) graphicsPipelineLibrary"; |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 2983 | } |
| 2984 | if (multiview_features.multiview == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 2985 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 2986 | } |
| 2987 | |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 2988 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &dynamic_rendering_features)); |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 2989 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2990 | |
| 2991 | VkFormat color_format = VK_FORMAT_R8G8B8A8_UNORM; |
| 2992 | |
| 2993 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 2994 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 2995 | pipeline_rendering_info.pColorAttachmentFormats = &color_format; |
| 2996 | |
| 2997 | auto graphics_library_create_info = LvlInitStruct<VkGraphicsPipelineLibraryCreateInfoEXT>(&pipeline_rendering_info); |
| 2998 | graphics_library_create_info.flags = VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT; |
| 2999 | auto library_create_info = LvlInitStruct<VkPipelineLibraryCreateInfoKHR>(&graphics_library_create_info); |
| 3000 | |
| 3001 | VkPipelineColorBlendAttachmentState color_blend_attachment_state = {}; |
| 3002 | auto color_blend_state_create_info = LvlInitStruct<VkPipelineColorBlendStateCreateInfo>(); |
| 3003 | color_blend_state_create_info.attachmentCount = 1; |
| 3004 | color_blend_state_create_info.pAttachments = &color_blend_attachment_state; |
| 3005 | |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 3006 | CreatePipelineHelper lib(*this); |
| 3007 | lib.cb_ci_ = color_blend_state_create_info; |
| 3008 | lib.InitInfo(); |
| 3009 | lib.gp_ci_.pNext = &library_create_info; |
| 3010 | lib.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 3011 | lib.InitState(); |
| 3012 | lib.CreateGraphicsPipeline(); |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 3013 | |
| 3014 | graphics_library_create_info.flags = VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT; |
| 3015 | library_create_info.libraryCount = 1; |
| 3016 | library_create_info.pLibraries = &lib.pipeline_; |
| 3017 | pipeline_rendering_info.viewMask = 0x1; |
| 3018 | |
| 3019 | CreatePipelineHelper pipe(*this); |
| 3020 | pipe.InitInfo(); |
| 3021 | pipe.gp_ci_.pNext = &library_create_info; |
| 3022 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3023 | pipe.shader_stages_ = {pipe.fs_->GetStageCreateInfo()}; |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 3024 | pipe.InitState(); |
| 3025 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-flags-06626"); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 3026 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-flags-06626"); |
ziga-lunarg | f7fb920 | 2022-04-22 17:19:10 +0200 | [diff] [blame] | 3027 | pipe.CreateGraphicsPipeline(); |
| 3028 | m_errorMonitor->VerifyFound(); |
| 3029 | } |
ziga-lunarg | e151ca6 | 2022-04-22 17:40:51 +0200 | [diff] [blame] | 3030 | |
| 3031 | TEST_F(VkLayerTest, InvalidAttachmentSampleCount) { |
| 3032 | TEST_DESCRIPTION("Create pipeline with invalid color attachment samples"); |
| 3033 | |
| 3034 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3035 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3036 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3037 | |
| 3038 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3039 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | e151ca6 | 2022-04-22 17:40:51 +0200 | [diff] [blame] | 3040 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3041 | if (!AreRequiredExtensionsEnabled()) { |
| 3042 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | e151ca6 | 2022-04-22 17:40:51 +0200 | [diff] [blame] | 3043 | } |
| 3044 | |
| 3045 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 3046 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3047 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3048 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3049 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | e151ca6 | 2022-04-22 17:40:51 +0200 | [diff] [blame] | 3050 | } |
| 3051 | |
| 3052 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3053 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3054 | |
| 3055 | VkSampleCountFlagBits color_attachment_samples = VK_SAMPLE_COUNT_FLAG_BITS_MAX_ENUM; |
| 3056 | |
| 3057 | auto samples_info = LvlInitStruct<VkAttachmentSampleCountInfoAMD>(); |
| 3058 | samples_info.colorAttachmentCount = 1; |
| 3059 | samples_info.pColorAttachmentSamples = &color_attachment_samples; |
| 3060 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(&samples_info); |
| 3061 | |
| 3062 | CreatePipelineHelper pipe(*this); |
| 3063 | pipe.InitInfo(); |
| 3064 | pipe.gp_ci_.pNext = &pipeline_rendering_info; |
| 3065 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 3066 | pipe.InitState(); |
| 3067 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-pColorAttachmentSamples-06592"); |
| 3068 | pipe.CreateGraphicsPipeline(); |
| 3069 | m_errorMonitor->VerifyFound(); |
| 3070 | } |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3071 | |
| 3072 | TEST_F(VkLayerTest, InvalidDynamicRenderingLibrariesViewMask) { |
| 3073 | TEST_DESCRIPTION("Create pipeline with libaries that have incompatible view mask"); |
| 3074 | |
| 3075 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3076 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3077 | AddRequiredExtensions(VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME); |
| 3078 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3079 | |
| 3080 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3081 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3082 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3083 | if (!AreRequiredExtensionsEnabled()) { |
| 3084 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3085 | } |
| 3086 | |
| 3087 | auto multiview_features = LvlInitStruct<VkPhysicalDeviceMultiviewFeatures>(); |
| 3088 | auto library_features = LvlInitStruct<VkPhysicalDeviceGraphicsPipelineLibraryFeaturesEXT>(&multiview_features); |
| 3089 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(&library_features); |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3090 | GetPhysicalDeviceFeatures2(dynamic_rendering_features); |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3091 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3092 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3093 | } |
| 3094 | if (library_features.graphicsPipelineLibrary == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3095 | GTEST_SKIP() << "Test requires (unsupported) graphicsPipelineLibrary"; |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3096 | } |
| 3097 | if (multiview_features.multiview == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3098 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3099 | } |
| 3100 | |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3101 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &dynamic_rendering_features)); |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3102 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3103 | |
| 3104 | VkFormat color_format = VK_FORMAT_R8G8B8A8_UNORM; |
| 3105 | |
| 3106 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 3107 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 3108 | pipeline_rendering_info.pColorAttachmentFormats = &color_format; |
| 3109 | |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3110 | VkPipelineColorBlendAttachmentState color_blend_attachment_state = {}; |
| 3111 | auto color_blend_state_create_info = LvlInitStruct<VkPipelineColorBlendStateCreateInfo>(); |
| 3112 | color_blend_state_create_info.attachmentCount = 1; |
| 3113 | color_blend_state_create_info.pAttachments = &color_blend_attachment_state; |
| 3114 | |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3115 | CreatePipelineHelper lib1(*this); |
| 3116 | lib1.cb_ci_ = color_blend_state_create_info; |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3117 | lib1.InitFragmentOutputLibInfo(&pipeline_rendering_info); |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3118 | lib1.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 3119 | lib1.InitState(); |
| 3120 | lib1.CreateGraphicsPipeline(); |
| 3121 | |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3122 | pipeline_rendering_info.viewMask = 0x1; |
| 3123 | |
| 3124 | auto ds_ci = LvlInitStruct<VkPipelineDepthStencilStateCreateInfo>(); |
| 3125 | |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3126 | const auto fs_spv = GLSLToSPV(VK_SHADER_STAGE_FRAGMENT_BIT, bindStateFragShaderText); |
| 3127 | auto fs_ci = LvlInitStruct<VkShaderModuleCreateInfo>(); |
| 3128 | fs_ci.codeSize = fs_spv.size() * sizeof(decltype(fs_spv)::value_type); |
| 3129 | fs_ci.pCode = fs_spv.data(); |
| 3130 | |
| 3131 | auto fs_stage_ci = LvlInitStruct<VkPipelineShaderStageCreateInfo>(&fs_ci); |
| 3132 | fs_stage_ci.stage = VK_SHADER_STAGE_FRAGMENT_BIT; |
| 3133 | fs_stage_ci.module = VK_NULL_HANDLE; |
| 3134 | fs_stage_ci.pName = "main"; |
| 3135 | |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3136 | CreatePipelineHelper lib2(*this); |
| 3137 | lib2.cb_ci_ = color_blend_state_create_info; |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3138 | lib2.InitFragmentLibInfo(1, &fs_stage_ci, &pipeline_rendering_info); |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3139 | lib2.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 3140 | lib2.ds_ci_ = ds_ci; |
| 3141 | lib2.InitState(); |
| 3142 | lib2.CreateGraphicsPipeline(); |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3143 | |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3144 | pipeline_rendering_info.viewMask = 0; |
| 3145 | auto library_create_info = LvlInitStruct<VkPipelineLibraryCreateInfoKHR>(); |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3146 | library_create_info.libraryCount = 2; |
| 3147 | VkPipeline libraries[2] = {lib1.pipeline_, lib2.pipeline_}; |
| 3148 | library_create_info.pLibraries = libraries; |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3149 | |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3150 | auto pipe_ci = LvlInitStruct<VkGraphicsPipelineCreateInfo>(&library_create_info); |
ziga-lunarg | 7f25dff | 2022-05-06 17:49:34 +0200 | [diff] [blame] | 3151 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-pLibraries-06627"); |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3152 | vk_testing::Pipeline pipe(*m_device, pipe_ci); |
ziga-lunarg | b81597d | 2022-04-22 19:11:51 +0200 | [diff] [blame] | 3153 | m_errorMonitor->VerifyFound(); |
| 3154 | } |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3155 | |
| 3156 | TEST_F(VkLayerTest, InvalidDynamicRenderingLibraryRenderPass) { |
| 3157 | TEST_DESCRIPTION("Create pipeline with invalid library render pass"); |
| 3158 | |
| 3159 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3160 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3161 | AddRequiredExtensions(VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME); |
| 3162 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3163 | |
| 3164 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3165 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3166 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3167 | if (!AreRequiredExtensionsEnabled()) { |
| 3168 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3169 | } |
| 3170 | |
| 3171 | auto library_features = LvlInitStruct<VkPhysicalDeviceGraphicsPipelineLibraryFeaturesEXT>(); |
| 3172 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(&library_features); |
| 3173 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3174 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3175 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3176 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3177 | } |
| 3178 | if (library_features.graphicsPipelineLibrary == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3179 | GTEST_SKIP() << "Test requires (unsupported) graphicsPipelineLibrary"; |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3180 | } |
| 3181 | |
| 3182 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3183 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3184 | |
| 3185 | VkFormat color_format = VK_FORMAT_R8G8B8A8_UNORM; |
| 3186 | |
| 3187 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 3188 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 3189 | pipeline_rendering_info.pColorAttachmentFormats = &color_format; |
| 3190 | |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3191 | VkPipelineColorBlendAttachmentState color_blend_attachment_state = {}; |
| 3192 | auto color_blend_state_create_info = LvlInitStruct<VkPipelineColorBlendStateCreateInfo>(); |
| 3193 | color_blend_state_create_info.attachmentCount = 1; |
| 3194 | color_blend_state_create_info.pAttachments = &color_blend_attachment_state; |
| 3195 | |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3196 | CreatePipelineHelper lib(*this); |
| 3197 | lib.cb_ci_ = color_blend_state_create_info; |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3198 | lib.InitFragmentOutputLibInfo(&pipeline_rendering_info); |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3199 | lib.InitState(); |
| 3200 | lib.CreateGraphicsPipeline(); |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3201 | |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3202 | auto library_create_info = LvlInitStruct<VkPipelineLibraryCreateInfoKHR>(&pipeline_rendering_info); |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3203 | library_create_info.libraryCount = 1; |
| 3204 | library_create_info.pLibraries = &lib.pipeline_; |
| 3205 | |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3206 | const auto fs_spv = GLSLToSPV(VK_SHADER_STAGE_FRAGMENT_BIT, bindStateFragShaderText); |
| 3207 | auto fs_ci = LvlInitStruct<VkShaderModuleCreateInfo>(); |
| 3208 | fs_ci.codeSize = fs_spv.size() * sizeof(decltype(fs_spv)::value_type); |
| 3209 | fs_ci.pCode = fs_spv.data(); |
| 3210 | |
| 3211 | auto fs_stage_ci = LvlInitStruct<VkPipelineShaderStageCreateInfo>(&fs_ci); |
| 3212 | fs_stage_ci.stage = VK_SHADER_STAGE_FRAGMENT_BIT; |
| 3213 | fs_stage_ci.module = VK_NULL_HANDLE; |
| 3214 | fs_stage_ci.pName = "main"; |
| 3215 | |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3216 | CreatePipelineHelper pipe(*this); |
Nathaniel Cesario | 13da77b | 2022-07-15 14:51:12 -0600 | [diff] [blame] | 3217 | pipe.InitFragmentLibInfo(1, &fs_stage_ci, &library_create_info); |
ziga-lunarg | 2e30231 | 2022-04-22 19:47:32 +0200 | [diff] [blame] | 3218 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 3219 | pipe.InitState(); |
| 3220 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderpass-06625"); |
| 3221 | pipe.CreateGraphicsPipeline(); |
| 3222 | m_errorMonitor->VerifyFound(); |
| 3223 | } |
ziga-lunarg | 7ba5a1c | 2022-04-22 19:56:49 +0200 | [diff] [blame] | 3224 | |
| 3225 | TEST_F(VkLayerTest, PipelineMissingMultisampleState) { |
| 3226 | TEST_DESCRIPTION("Create pipeline with missing multisample state"); |
| 3227 | |
| 3228 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3229 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3230 | AddRequiredExtensions(VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME); |
| 3231 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3232 | |
| 3233 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3234 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 7ba5a1c | 2022-04-22 19:56:49 +0200 | [diff] [blame] | 3235 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3236 | if (!AreRequiredExtensionsEnabled()) { |
| 3237 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 7ba5a1c | 2022-04-22 19:56:49 +0200 | [diff] [blame] | 3238 | } |
| 3239 | |
| 3240 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 3241 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3242 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3243 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3244 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 7ba5a1c | 2022-04-22 19:56:49 +0200 | [diff] [blame] | 3245 | } |
| 3246 | |
| 3247 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3248 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3249 | |
| 3250 | CreatePipelineHelper pipe(*this); |
| 3251 | pipe.InitInfo(); |
| 3252 | pipe.gp_ci_.pMultisampleState = nullptr; |
| 3253 | pipe.InitState(); |
| 3254 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderpass-06631"); |
| 3255 | pipe.CreateGraphicsPipeline(); |
| 3256 | m_errorMonitor->VerifyFound(); |
ziga-lunarg | 1422253 | 2022-04-22 23:27:17 +0200 | [diff] [blame] | 3257 | } |
| 3258 | |
ziga-lunarg | d773748 | 2022-04-25 11:16:37 +0200 | [diff] [blame] | 3259 | TEST_F(VkLayerTest, InvalidRenderingFragmentDensityMapAttachment) { |
| 3260 | TEST_DESCRIPTION("Use invalid VkRenderingFragmentDensityMapAttachmentInfoEXT"); |
ziga-lunarg | 1422253 | 2022-04-22 23:27:17 +0200 | [diff] [blame] | 3261 | |
| 3262 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3263 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3264 | AddRequiredExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 3265 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3266 | |
| 3267 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3268 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 1422253 | 2022-04-22 23:27:17 +0200 | [diff] [blame] | 3269 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3270 | if (!AreRequiredExtensionsEnabled()) { |
| 3271 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 1422253 | 2022-04-22 23:27:17 +0200 | [diff] [blame] | 3272 | } |
| 3273 | |
ziga-lunarg | d773748 | 2022-04-25 11:16:37 +0200 | [diff] [blame] | 3274 | auto multiview_featuers = LvlInitStruct<VkPhysicalDeviceMultiviewFeatures>(); |
| 3275 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(&multiview_featuers); |
ziga-lunarg | 1422253 | 2022-04-22 23:27:17 +0200 | [diff] [blame] | 3276 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3277 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3278 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3279 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 1422253 | 2022-04-22 23:27:17 +0200 | [diff] [blame] | 3280 | } |
ziga-lunarg | d773748 | 2022-04-25 11:16:37 +0200 | [diff] [blame] | 3281 | if (multiview_featuers.multiview == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3282 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | d773748 | 2022-04-25 11:16:37 +0200 | [diff] [blame] | 3283 | } |
ziga-lunarg | 1422253 | 2022-04-22 23:27:17 +0200 | [diff] [blame] | 3284 | |
| 3285 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3286 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3287 | |
| 3288 | VkImageObj image(m_device); |
| 3289 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, |
| 3290 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, VK_IMAGE_TILING_LINEAR, 0); |
| 3291 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3292 | |
| 3293 | auto rendering_fragment_density = LvlInitStruct<VkRenderingFragmentDensityMapAttachmentInfoEXT>(); |
| 3294 | rendering_fragment_density.imageView = image_view; |
| 3295 | rendering_fragment_density.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 3296 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&rendering_fragment_density); |
| 3297 | begin_rendering_info.layerCount = 1; |
| 3298 | |
| 3299 | m_commandBuffer->begin(); |
ziga-lunarg | d773748 | 2022-04-25 11:16:37 +0200 | [diff] [blame] | 3300 | |
ziga-lunarg | 1422253 | 2022-04-22 23:27:17 +0200 | [diff] [blame] | 3301 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentDensityMapAttachmentInfoEXT-imageView-06157"); |
| 3302 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3303 | m_errorMonitor->VerifyFound(); |
ziga-lunarg | d773748 | 2022-04-25 11:16:37 +0200 | [diff] [blame] | 3304 | |
| 3305 | rendering_fragment_density.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 3306 | |
| 3307 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 3308 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 3309 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; |
| 3310 | image_create_info.extent = {32, 32, 1}; |
| 3311 | image_create_info.mipLevels = 1; |
| 3312 | image_create_info.arrayLayers = 2; |
| 3313 | image_create_info.samples = VK_SAMPLE_COUNT_1_BIT; |
| 3314 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 3315 | image_create_info.usage = VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV | VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT; |
| 3316 | VkImageObj image2(m_device); |
| 3317 | image2.Init(image_create_info); |
| 3318 | VkImageView image_view2 = image2.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 3319 | rendering_fragment_density.imageView = image_view2; |
| 3320 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentDensityMapAttachmentInfoEXT-imageView-06160"); |
| 3321 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06109"); |
| 3322 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3323 | m_errorMonitor->VerifyFound(); |
| 3324 | |
ziga-lunarg | 1422253 | 2022-04-22 23:27:17 +0200 | [diff] [blame] | 3325 | m_commandBuffer->end(); |
| 3326 | } |
ziga-lunarg | a81df9d | 2022-04-22 23:33:13 +0200 | [diff] [blame] | 3327 | |
| 3328 | TEST_F(VkLayerTest, InvalidRenderingFragmentDensityMapAttachmentUsage) { |
| 3329 | TEST_DESCRIPTION("Use VkRenderingFragmentDensityMapAttachmentInfoEXT with invalid imageLayout"); |
| 3330 | |
| 3331 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3332 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3333 | AddRequiredExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 3334 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3335 | |
| 3336 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3337 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | a81df9d | 2022-04-22 23:33:13 +0200 | [diff] [blame] | 3338 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3339 | if (!AreRequiredExtensionsEnabled()) { |
| 3340 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | a81df9d | 2022-04-22 23:33:13 +0200 | [diff] [blame] | 3341 | } |
| 3342 | |
| 3343 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 3344 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3345 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3346 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3347 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | a81df9d | 2022-04-22 23:33:13 +0200 | [diff] [blame] | 3348 | } |
| 3349 | |
| 3350 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3351 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3352 | |
| 3353 | VkImageObj image(m_device); |
| 3354 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, VK_IMAGE_TILING_LINEAR, 0); |
| 3355 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3356 | |
| 3357 | auto rendering_fragment_density = LvlInitStruct<VkRenderingFragmentDensityMapAttachmentInfoEXT>(); |
| 3358 | rendering_fragment_density.imageView = image_view; |
| 3359 | rendering_fragment_density.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 3360 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&rendering_fragment_density); |
| 3361 | begin_rendering_info.layerCount = 1; |
| 3362 | |
| 3363 | m_commandBuffer->begin(); |
| 3364 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentDensityMapAttachmentInfoEXT-imageView-06158"); |
| 3365 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3366 | m_errorMonitor->VerifyFound(); |
| 3367 | m_commandBuffer->end(); |
| 3368 | } |
ziga-lunarg | 7c411b3 | 2022-04-22 23:37:48 +0200 | [diff] [blame] | 3369 | |
| 3370 | TEST_F(VkLayerTest, InvalidRenderingFragmentDensityMapAttachmentCreateFlags) { |
| 3371 | TEST_DESCRIPTION("Use VkRenderingFragmentDensityMapAttachmentInfoEXT with invalid image create flags"); |
| 3372 | |
| 3373 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3374 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3375 | AddRequiredExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 3376 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3377 | |
| 3378 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3379 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 7c411b3 | 2022-04-22 23:37:48 +0200 | [diff] [blame] | 3380 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3381 | if (!AreRequiredExtensionsEnabled()) { |
| 3382 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 7c411b3 | 2022-04-22 23:37:48 +0200 | [diff] [blame] | 3383 | } |
| 3384 | |
| 3385 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 3386 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3387 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3388 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3389 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 7c411b3 | 2022-04-22 23:37:48 +0200 | [diff] [blame] | 3390 | } |
| 3391 | |
| 3392 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3393 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3394 | |
| 3395 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 3396 | image_create_info.flags = VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT; |
| 3397 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 3398 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; |
| 3399 | image_create_info.extent = {32, 32, 4}; |
| 3400 | image_create_info.mipLevels = 1; |
| 3401 | image_create_info.arrayLayers = 1; |
| 3402 | image_create_info.samples = VK_SAMPLE_COUNT_1_BIT; |
| 3403 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 3404 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT; |
| 3405 | |
| 3406 | VkImageObj image(m_device); |
| 3407 | image.Init(image_create_info); |
| 3408 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3409 | |
| 3410 | auto rendering_fragment_density = LvlInitStruct<VkRenderingFragmentDensityMapAttachmentInfoEXT>(); |
| 3411 | rendering_fragment_density.imageView = image_view; |
| 3412 | rendering_fragment_density.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 3413 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&rendering_fragment_density); |
| 3414 | begin_rendering_info.layerCount = 1; |
| 3415 | |
| 3416 | m_commandBuffer->begin(); |
| 3417 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentDensityMapAttachmentInfoEXT-imageView-06159"); |
| 3418 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3419 | m_errorMonitor->VerifyFound(); |
| 3420 | m_commandBuffer->end(); |
| 3421 | } |
ziga-lunarg | 66569a7 | 2022-04-22 23:43:26 +0200 | [diff] [blame] | 3422 | |
| 3423 | TEST_F(VkLayerTest, InvalidRenderingFragmentDensityMapAttachmentLayerCount) { |
| 3424 | TEST_DESCRIPTION("Use VkRenderingFragmentDensityMapAttachmentInfoEXT with invalid layer count"); |
| 3425 | |
| 3426 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3427 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3428 | AddRequiredExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 3429 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3430 | |
| 3431 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3432 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 66569a7 | 2022-04-22 23:43:26 +0200 | [diff] [blame] | 3433 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3434 | if (!AreRequiredExtensionsEnabled()) { |
| 3435 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 66569a7 | 2022-04-22 23:43:26 +0200 | [diff] [blame] | 3436 | } |
| 3437 | |
| 3438 | auto multiview_features = LvlInitStruct<VkPhysicalDeviceMultiviewFeatures>(); |
| 3439 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(&multiview_features); |
| 3440 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3441 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3442 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3443 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 66569a7 | 2022-04-22 23:43:26 +0200 | [diff] [blame] | 3444 | } |
| 3445 | if (!multiview_features.multiview) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3446 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | 66569a7 | 2022-04-22 23:43:26 +0200 | [diff] [blame] | 3447 | } |
| 3448 | |
| 3449 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3450 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3451 | |
| 3452 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 3453 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 3454 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; |
| 3455 | image_create_info.extent = {32, 32, 4}; |
| 3456 | image_create_info.mipLevels = 1; |
| 3457 | image_create_info.arrayLayers = 2; |
| 3458 | image_create_info.samples = VK_SAMPLE_COUNT_1_BIT; |
| 3459 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 3460 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT; |
| 3461 | |
| 3462 | VkImageObj image(m_device); |
| 3463 | image.Init(image_create_info); |
| 3464 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3465 | |
| 3466 | auto rendering_fragment_density = LvlInitStruct<VkRenderingFragmentDensityMapAttachmentInfoEXT>(); |
| 3467 | rendering_fragment_density.imageView = image_view; |
| 3468 | rendering_fragment_density.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 3469 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&rendering_fragment_density); |
| 3470 | begin_rendering_info.layerCount = 1; |
| 3471 | begin_rendering_info.viewMask = 0x1; |
| 3472 | |
| 3473 | m_commandBuffer->begin(); |
| 3474 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentDensityMapAttachmentInfoEXT-imageView-06160"); |
| 3475 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3476 | m_errorMonitor->VerifyFound(); |
| 3477 | m_commandBuffer->end(); |
| 3478 | } |
ziga-lunarg | 323c11d | 2022-04-22 23:56:32 +0200 | [diff] [blame] | 3479 | |
| 3480 | TEST_F(VkLayerTest, InvalidRenderingPNextImageView) { |
| 3481 | TEST_DESCRIPTION( |
| 3482 | "Use different image views in VkRenderingFragmentShadingRateAttachmentInfoKHR and " |
| 3483 | "VkRenderingFragmentDensityMapAttachmentInfoEXT"); |
| 3484 | |
| 3485 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3486 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3487 | AddRequiredExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 3488 | AddRequiredExtensions(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
| 3489 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3490 | |
| 3491 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3492 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 323c11d | 2022-04-22 23:56:32 +0200 | [diff] [blame] | 3493 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3494 | if (!AreRequiredExtensionsEnabled()) { |
| 3495 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 323c11d | 2022-04-22 23:56:32 +0200 | [diff] [blame] | 3496 | } |
| 3497 | |
| 3498 | auto multiview_features = LvlInitStruct<VkPhysicalDeviceMultiviewFeatures>(); |
| 3499 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(&multiview_features); |
| 3500 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3501 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3502 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3503 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 323c11d | 2022-04-22 23:56:32 +0200 | [diff] [blame] | 3504 | } |
| 3505 | if (!multiview_features.multiview) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3506 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | 323c11d | 2022-04-22 23:56:32 +0200 | [diff] [blame] | 3507 | } |
| 3508 | |
| 3509 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3510 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3511 | |
| 3512 | auto fsr_properties = LvlInitStruct<VkPhysicalDeviceFragmentShadingRatePropertiesKHR>(); |
| 3513 | |
| 3514 | auto phys_dev_props_2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&fsr_properties); |
| 3515 | vk::GetPhysicalDeviceProperties2(gpu(), &phys_dev_props_2); |
| 3516 | |
| 3517 | VkImageObj image1(m_device); |
| 3518 | image1.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, |
| 3519 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR, |
| 3520 | VK_IMAGE_TILING_LINEAR, 0); |
| 3521 | VkImageView image_view1 = image1.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3522 | VkImageObj image2(m_device); |
| 3523 | image2.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, |
| 3524 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, VK_IMAGE_TILING_LINEAR, 0); |
| 3525 | VkImageView image_view2 = image2.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3526 | |
| 3527 | auto rendering_fragment_shading_rate = LvlInitStruct<VkRenderingFragmentShadingRateAttachmentInfoKHR>(); |
| 3528 | rendering_fragment_shading_rate.imageView = image_view1; |
| 3529 | rendering_fragment_shading_rate.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 3530 | rendering_fragment_shading_rate.shadingRateAttachmentTexelSize = fsr_properties.minFragmentShadingRateAttachmentTexelSize; |
| 3531 | auto rendering_fragment_density = |
| 3532 | LvlInitStruct<VkRenderingFragmentDensityMapAttachmentInfoEXT>(&rendering_fragment_shading_rate); |
| 3533 | rendering_fragment_density.imageView = image_view2; |
| 3534 | rendering_fragment_density.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 3535 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&rendering_fragment_density); |
| 3536 | begin_rendering_info.layerCount = 1; |
| 3537 | begin_rendering_info.viewMask = 0x1; |
| 3538 | |
| 3539 | m_commandBuffer->begin(); |
| 3540 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06126"); |
| 3541 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3542 | m_errorMonitor->VerifyFound(); |
| 3543 | m_commandBuffer->end(); |
| 3544 | } |
ziga-lunarg | 95f20d4 | 2022-04-23 00:06:42 +0200 | [diff] [blame] | 3545 | |
| 3546 | TEST_F(VkLayerTest, InvalidRenderingRenderArea) { |
| 3547 | TEST_DESCRIPTION("Use negative offset in RenderingInfo render area"); |
| 3548 | |
| 3549 | SetTargetApiVersion(VK_API_VERSION_1_0); |
| 3550 | AddRequiredExtensions(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME); |
| 3551 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3552 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3553 | |
| 3554 | if (DeviceValidationVersion() != VK_API_VERSION_1_0) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3555 | GTEST_SKIP() << "Tests for 1.0 only"; |
ziga-lunarg | 95f20d4 | 2022-04-23 00:06:42 +0200 | [diff] [blame] | 3556 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3557 | if (!AreRequiredExtensionsEnabled()) { |
| 3558 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 95f20d4 | 2022-04-23 00:06:42 +0200 | [diff] [blame] | 3559 | } |
| 3560 | |
| 3561 | auto vkGetPhysicalDeviceFeatures2KHR = reinterpret_cast<PFN_vkGetPhysicalDeviceFeatures2KHR>( |
| 3562 | vk::GetInstanceProcAddr(instance(), "vkGetPhysicalDeviceFeatures2KHR")); |
| 3563 | ASSERT_TRUE(vkGetPhysicalDeviceFeatures2KHR != nullptr); |
| 3564 | |
| 3565 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 3566 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2KHR>(&dynamic_rendering_features); |
| 3567 | vkGetPhysicalDeviceFeatures2KHR(gpu(), &features2); |
| 3568 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3569 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 95f20d4 | 2022-04-23 00:06:42 +0200 | [diff] [blame] | 3570 | } |
| 3571 | |
| 3572 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3573 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3574 | |
| 3575 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 3576 | begin_rendering_info.layerCount = 1; |
| 3577 | begin_rendering_info.renderArea.offset.x = -1; |
ziga-lunarg | 9b6a95f | 2022-04-23 00:13:38 +0200 | [diff] [blame] | 3578 | begin_rendering_info.renderArea.extent.width = 32; |
| 3579 | begin_rendering_info.renderArea.extent.height = 32; |
ziga-lunarg | 95f20d4 | 2022-04-23 00:06:42 +0200 | [diff] [blame] | 3580 | |
| 3581 | m_commandBuffer->begin(); |
| 3582 | |
| 3583 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-renderArea-06071"); |
| 3584 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3585 | m_errorMonitor->VerifyFound(); |
| 3586 | |
| 3587 | begin_rendering_info.renderArea.offset.x = 0; |
| 3588 | begin_rendering_info.renderArea.offset.y = -1; |
| 3589 | |
| 3590 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-renderArea-06072"); |
| 3591 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3592 | m_errorMonitor->VerifyFound(); |
| 3593 | |
ziga-lunarg | 9b6a95f | 2022-04-23 00:13:38 +0200 | [diff] [blame] | 3594 | begin_rendering_info.renderArea.offset.y = 0; |
| 3595 | begin_rendering_info.renderArea.offset.x = m_device->phy().properties().limits.maxFramebufferWidth - 16; |
| 3596 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-renderArea-06073"); |
| 3597 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3598 | m_errorMonitor->VerifyFound(); |
| 3599 | |
| 3600 | begin_rendering_info.renderArea.offset.x = 0; |
| 3601 | begin_rendering_info.renderArea.offset.y = m_device->phy().properties().limits.maxFramebufferHeight - 16; |
| 3602 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-renderArea-06074"); |
| 3603 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3604 | m_errorMonitor->VerifyFound(); |
| 3605 | |
ziga-lunarg | 95f20d4 | 2022-04-23 00:06:42 +0200 | [diff] [blame] | 3606 | m_commandBuffer->end(); |
| 3607 | } |
ziga-lunarg | 6662a88 | 2022-04-23 00:21:27 +0200 | [diff] [blame] | 3608 | |
| 3609 | TEST_F(VkLayerTest, InvalidRenderingInfoViewMask) { |
| 3610 | TEST_DESCRIPTION("Use negative offset in RenderingInfo render area"); |
| 3611 | |
| 3612 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3613 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3614 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3615 | |
| 3616 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3617 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 6662a88 | 2022-04-23 00:21:27 +0200 | [diff] [blame] | 3618 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3619 | if (!AreRequiredExtensionsEnabled()) { |
| 3620 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 6662a88 | 2022-04-23 00:21:27 +0200 | [diff] [blame] | 3621 | } |
| 3622 | |
| 3623 | auto multiview_features = LvlInitStruct<VkPhysicalDeviceMultiviewFeatures>(); |
| 3624 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(&multiview_features); |
| 3625 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3626 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3627 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3628 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 6662a88 | 2022-04-23 00:21:27 +0200 | [diff] [blame] | 3629 | } |
| 3630 | if (multiview_features.multiview == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3631 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | 6662a88 | 2022-04-23 00:21:27 +0200 | [diff] [blame] | 3632 | } |
| 3633 | |
| 3634 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3635 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3636 | |
| 3637 | VkPhysicalDeviceMultiviewProperties multiview_props = LvlInitStruct<VkPhysicalDeviceMultiviewProperties>(); |
| 3638 | VkPhysicalDeviceProperties2 pd_props2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&multiview_props); |
| 3639 | vk::GetPhysicalDeviceProperties2(gpu(), &pd_props2); |
| 3640 | |
| 3641 | if (multiview_props.maxMultiviewViewCount == 32) { |
| 3642 | printf("%s VUID is not testable as maxMultiviewViewCount is 32, skipping test\n", kSkipPrefix); |
| 3643 | return; |
| 3644 | } |
| 3645 | |
| 3646 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 3647 | begin_rendering_info.layerCount = 1; |
| 3648 | begin_rendering_info.renderArea.extent.width = 32; |
| 3649 | begin_rendering_info.renderArea.extent.height = 32; |
| 3650 | begin_rendering_info.viewMask = 1u << multiview_props.maxMultiviewViewCount; |
| 3651 | |
| 3652 | m_commandBuffer->begin(); |
| 3653 | |
| 3654 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-viewMask-06128"); |
| 3655 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3656 | m_errorMonitor->VerifyFound(); |
| 3657 | |
| 3658 | m_commandBuffer->end(); |
| 3659 | } |
ziga-lunarg | ae75b8a | 2022-04-23 10:54:37 +0200 | [diff] [blame] | 3660 | |
| 3661 | TEST_F(VkLayerTest, InvalidRenderingColorAttachmentFormat) { |
| 3662 | TEST_DESCRIPTION("Use format with missing potential format features in rendering color attachment"); |
| 3663 | |
| 3664 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3665 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3666 | AddRequiredExtensions(VK_NV_LINEAR_COLOR_ATTACHMENT_EXTENSION_NAME); |
| 3667 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3668 | |
| 3669 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3670 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | ae75b8a | 2022-04-23 10:54:37 +0200 | [diff] [blame] | 3671 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3672 | if (!AreRequiredExtensionsEnabled()) { |
| 3673 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | ae75b8a | 2022-04-23 10:54:37 +0200 | [diff] [blame] | 3674 | } |
| 3675 | |
| 3676 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 3677 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3678 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3679 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3680 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | ae75b8a | 2022-04-23 10:54:37 +0200 | [diff] [blame] | 3681 | } |
| 3682 | |
| 3683 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3684 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3685 | |
| 3686 | VkFormat format = FindSupportedDepthStencilFormat(gpu()); |
| 3687 | if (format == VK_FORMAT_UNDEFINED) { |
| 3688 | printf("%s No Depth + Stencil format found. Skipped.\n", kSkipPrefix); |
| 3689 | return; |
| 3690 | } |
| 3691 | |
| 3692 | auto pipeline_rendering_info = LvlInitStruct<VkPipelineRenderingCreateInfoKHR>(); |
| 3693 | pipeline_rendering_info.colorAttachmentCount = 1; |
| 3694 | pipeline_rendering_info.pColorAttachmentFormats = &format; |
| 3695 | |
| 3696 | CreatePipelineHelper pipe(*this); |
| 3697 | pipe.InitInfo(); |
| 3698 | pipe.gp_ci_.pNext = &pipeline_rendering_info; |
| 3699 | pipe.gp_ci_.renderPass = VK_NULL_HANDLE; |
| 3700 | pipe.InitState(); |
| 3701 | |
| 3702 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06582"); |
| 3703 | pipe.CreateGraphicsPipeline(); |
| 3704 | m_errorMonitor->VerifyFound(); |
| 3705 | } |
ziga-lunarg | eac390f | 2022-04-23 11:05:28 +0200 | [diff] [blame] | 3706 | |
sjfricke | 483c108 | 2022-06-05 10:21:44 +0900 | [diff] [blame] | 3707 | TEST_F(VkLayerTest, InvalidResolveModeWithNonIntegerColorFormat) { |
| 3708 | TEST_DESCRIPTION("Use invalid resolve mode with non integer color format"); |
| 3709 | |
| 3710 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3711 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3712 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3713 | |
| 3714 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
| 3715 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
| 3716 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3717 | if (!AreRequiredExtensionsEnabled()) { |
| 3718 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
sjfricke | 483c108 | 2022-06-05 10:21:44 +0900 | [diff] [blame] | 3719 | } |
| 3720 | |
| 3721 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 3722 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3723 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3724 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
| 3725 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
| 3726 | } |
| 3727 | |
| 3728 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3729 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3730 | |
| 3731 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 3732 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 3733 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; // not int color |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 3734 | image_create_info.extent = {32, 32, 1}; |
sjfricke | 483c108 | 2022-06-05 10:21:44 +0900 | [diff] [blame] | 3735 | image_create_info.mipLevels = 1; |
| 3736 | image_create_info.arrayLayers = 1; |
| 3737 | image_create_info.samples = VK_SAMPLE_COUNT_4_BIT; |
| 3738 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 3739 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 3740 | VkImageObj image(m_device); |
| 3741 | image.Init(image_create_info); |
| 3742 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3743 | |
Tony-LunarG | f088c6b | 2022-07-08 11:29:53 -0600 | [diff] [blame] | 3744 | image_create_info.samples = VK_SAMPLE_COUNT_1_BIT; |
| 3745 | VkImageObj resolve_image(m_device); |
| 3746 | resolve_image.Init(image_create_info); |
| 3747 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3748 | |
sjfricke | 483c108 | 2022-06-05 10:21:44 +0900 | [diff] [blame] | 3749 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 3750 | color_attachment.imageView = image_view; |
| 3751 | color_attachment.resolveMode = VK_RESOLVE_MODE_SAMPLE_ZERO_BIT; // not allowed for format |
| 3752 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 3753 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_GENERAL; |
Tony-LunarG | f088c6b | 2022-07-08 11:29:53 -0600 | [diff] [blame] | 3754 | color_attachment.resolveImageView = resolve_image_view; |
sjfricke | 483c108 | 2022-06-05 10:21:44 +0900 | [diff] [blame] | 3755 | |
| 3756 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 3757 | begin_rendering_info.colorAttachmentCount = 1; |
| 3758 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 3759 | begin_rendering_info.layerCount = 1; |
| 3760 | |
| 3761 | m_commandBuffer->begin(); |
| 3762 | |
| 3763 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06129"); |
| 3764 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3765 | m_errorMonitor->VerifyFound(); |
| 3766 | |
| 3767 | m_commandBuffer->end(); |
| 3768 | } |
| 3769 | |
ziga-lunarg | eac390f | 2022-04-23 11:05:28 +0200 | [diff] [blame] | 3770 | TEST_F(VkLayerTest, InvalidResolveModeWithIntegerColorFormat) { |
| 3771 | TEST_DESCRIPTION("Use invalid resolve mode with integer color format"); |
| 3772 | |
| 3773 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3774 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3775 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3776 | |
| 3777 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3778 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | eac390f | 2022-04-23 11:05:28 +0200 | [diff] [blame] | 3779 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3780 | if (!AreRequiredExtensionsEnabled()) { |
| 3781 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | eac390f | 2022-04-23 11:05:28 +0200 | [diff] [blame] | 3782 | } |
| 3783 | |
| 3784 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 3785 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3786 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3787 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3788 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | eac390f | 2022-04-23 11:05:28 +0200 | [diff] [blame] | 3789 | } |
| 3790 | |
| 3791 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3792 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3793 | |
| 3794 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 3795 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 3796 | image_create_info.format = VK_FORMAT_R8G8B8A8_UINT; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 3797 | image_create_info.extent = {32, 32, 1}; |
ziga-lunarg | eac390f | 2022-04-23 11:05:28 +0200 | [diff] [blame] | 3798 | image_create_info.mipLevels = 1; |
| 3799 | image_create_info.arrayLayers = 1; |
| 3800 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 3801 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 3802 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 3803 | VkImageObj image(m_device); |
| 3804 | image.Init(image_create_info); |
| 3805 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 3806 | |
Tony-LunarG | f088c6b | 2022-07-08 11:29:53 -0600 | [diff] [blame] | 3807 | image_create_info.samples = VK_SAMPLE_COUNT_1_BIT; |
| 3808 | VkImageObj resolve_image(m_device); |
| 3809 | resolve_image.Init(image_create_info); |
| 3810 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 3811 | |
ziga-lunarg | eac390f | 2022-04-23 11:05:28 +0200 | [diff] [blame] | 3812 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 3813 | color_attachment.imageView = image_view; |
| 3814 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 3815 | color_attachment.resolveMode = VK_RESOLVE_MODE_MAX_BIT; |
| 3816 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_GENERAL; |
Tony-LunarG | f088c6b | 2022-07-08 11:29:53 -0600 | [diff] [blame] | 3817 | color_attachment.resolveImageView = resolve_image_view; |
ziga-lunarg | eac390f | 2022-04-23 11:05:28 +0200 | [diff] [blame] | 3818 | |
| 3819 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 3820 | begin_rendering_info.colorAttachmentCount = 1; |
| 3821 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 3822 | begin_rendering_info.layerCount = 1; |
| 3823 | |
| 3824 | m_commandBuffer->begin(); |
| 3825 | |
| 3826 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06130"); |
| 3827 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3828 | m_errorMonitor->VerifyFound(); |
| 3829 | |
| 3830 | m_commandBuffer->end(); |
| 3831 | } |
ziga-lunarg | df2a320 | 2022-04-23 11:07:46 +0200 | [diff] [blame] | 3832 | |
| 3833 | TEST_F(VkLayerTest, InvalidResolveModeSamples) { |
| 3834 | TEST_DESCRIPTION("Use invalid sample count with resolve mode that is not none"); |
| 3835 | |
| 3836 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3837 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3838 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3839 | |
| 3840 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3841 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | df2a320 | 2022-04-23 11:07:46 +0200 | [diff] [blame] | 3842 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3843 | if (!AreRequiredExtensionsEnabled()) { |
| 3844 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | df2a320 | 2022-04-23 11:07:46 +0200 | [diff] [blame] | 3845 | } |
| 3846 | |
| 3847 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 3848 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3849 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3850 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3851 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | df2a320 | 2022-04-23 11:07:46 +0200 | [diff] [blame] | 3852 | } |
| 3853 | |
| 3854 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3855 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3856 | |
| 3857 | VkImageObj image(m_device); |
| 3858 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 3859 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3860 | |
| 3861 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 3862 | color_attachment.imageView = image_view; |
| 3863 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 3864 | color_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 3865 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_GENERAL; |
Tony-LunarG | f088c6b | 2022-07-08 11:29:53 -0600 | [diff] [blame] | 3866 | color_attachment.resolveImageView = image_view; |
ziga-lunarg | df2a320 | 2022-04-23 11:07:46 +0200 | [diff] [blame] | 3867 | |
| 3868 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 3869 | begin_rendering_info.colorAttachmentCount = 1; |
| 3870 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 3871 | begin_rendering_info.layerCount = 1; |
| 3872 | |
| 3873 | m_commandBuffer->begin(); |
| 3874 | |
| 3875 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06132"); |
| 3876 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3877 | m_errorMonitor->VerifyFound(); |
| 3878 | |
| 3879 | m_commandBuffer->end(); |
| 3880 | } |
ziga-lunarg | b7693aa | 2022-04-23 11:21:57 +0200 | [diff] [blame] | 3881 | |
| 3882 | TEST_F(VkLayerTest, InvalidResolveImageViewSamples) { |
| 3883 | TEST_DESCRIPTION("Use resolve image view with invalid sample count"); |
| 3884 | |
| 3885 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3886 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3887 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3888 | |
| 3889 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3890 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | b7693aa | 2022-04-23 11:21:57 +0200 | [diff] [blame] | 3891 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3892 | if (!AreRequiredExtensionsEnabled()) { |
| 3893 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | b7693aa | 2022-04-23 11:21:57 +0200 | [diff] [blame] | 3894 | } |
| 3895 | |
| 3896 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 3897 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3898 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3899 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3900 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | b7693aa | 2022-04-23 11:21:57 +0200 | [diff] [blame] | 3901 | } |
| 3902 | |
| 3903 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3904 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3905 | |
| 3906 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 3907 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 3908 | image_create_info.format = VK_FORMAT_R8G8B8A8_UINT; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 3909 | image_create_info.extent = {32, 32, 1}; |
ziga-lunarg | b7693aa | 2022-04-23 11:21:57 +0200 | [diff] [blame] | 3910 | image_create_info.mipLevels = 1; |
| 3911 | image_create_info.arrayLayers = 1; |
| 3912 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 3913 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 3914 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 3915 | |
| 3916 | VkImageObj image(m_device); |
| 3917 | image.Init(image_create_info); |
| 3918 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 3919 | |
| 3920 | VkImageObj resolve_image(m_device); |
| 3921 | resolve_image.Init(image_create_info); |
| 3922 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 3923 | |
| 3924 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 3925 | color_attachment.imageView = image_view; |
| 3926 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 3927 | color_attachment.resolveMode = VK_RESOLVE_MODE_SAMPLE_ZERO_BIT; |
| 3928 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 3929 | color_attachment.resolveImageView = resolve_image_view; |
| 3930 | |
| 3931 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 3932 | begin_rendering_info.colorAttachmentCount = 1; |
| 3933 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 3934 | begin_rendering_info.layerCount = 1; |
| 3935 | |
| 3936 | m_commandBuffer->begin(); |
| 3937 | |
Tony-LunarG | 7384f7e | 2022-07-05 14:20:42 -0600 | [diff] [blame] | 3938 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06864"); |
ziga-lunarg | b7693aa | 2022-04-23 11:21:57 +0200 | [diff] [blame] | 3939 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 3940 | m_errorMonitor->VerifyFound(); |
| 3941 | |
| 3942 | m_commandBuffer->end(); |
ziga-lunarg | d12cbce | 2022-04-23 11:35:20 +0200 | [diff] [blame] | 3943 | } |
| 3944 | |
| 3945 | TEST_F(VkLayerTest, InvalidResolveImageViewFormatMatch) { |
| 3946 | TEST_DESCRIPTION("Use resolve image view with different format from image view"); |
| 3947 | |
| 3948 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 3949 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 3950 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 3951 | |
| 3952 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3953 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | d12cbce | 2022-04-23 11:35:20 +0200 | [diff] [blame] | 3954 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 3955 | if (!AreRequiredExtensionsEnabled()) { |
| 3956 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | d12cbce | 2022-04-23 11:35:20 +0200 | [diff] [blame] | 3957 | } |
| 3958 | |
| 3959 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 3960 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 3961 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 3962 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 3963 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | d12cbce | 2022-04-23 11:35:20 +0200 | [diff] [blame] | 3964 | } |
| 3965 | |
| 3966 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 3967 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 3968 | |
| 3969 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 3970 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 3971 | image_create_info.format = VK_FORMAT_R8G8B8A8_UINT; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 3972 | image_create_info.extent = {32, 32, 1}; |
ziga-lunarg | d12cbce | 2022-04-23 11:35:20 +0200 | [diff] [blame] | 3973 | image_create_info.mipLevels = 1; |
| 3974 | image_create_info.arrayLayers = 1; |
| 3975 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 3976 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 3977 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 3978 | |
| 3979 | VkImageObj image(m_device); |
| 3980 | image.Init(image_create_info); |
| 3981 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UINT); |
| 3982 | |
| 3983 | VkImageObj resolve_image(m_device); |
| 3984 | resolve_image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 3985 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 3986 | |
| 3987 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 3988 | color_attachment.imageView = image_view; |
| 3989 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 3990 | color_attachment.resolveMode = VK_RESOLVE_MODE_SAMPLE_ZERO_BIT; |
| 3991 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 3992 | color_attachment.resolveImageView = resolve_image_view; |
| 3993 | |
| 3994 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 3995 | begin_rendering_info.colorAttachmentCount = 1; |
| 3996 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 3997 | begin_rendering_info.layerCount = 1; |
| 3998 | |
| 3999 | m_commandBuffer->begin(); |
| 4000 | |
Tony-LunarG | 7384f7e | 2022-07-05 14:20:42 -0600 | [diff] [blame] | 4001 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06865"); |
ziga-lunarg | d12cbce | 2022-04-23 11:35:20 +0200 | [diff] [blame] | 4002 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4003 | m_errorMonitor->VerifyFound(); |
| 4004 | |
| 4005 | m_commandBuffer->end(); |
| 4006 | } |
ziga-lunarg | e579a3b | 2022-04-23 11:38:02 +0200 | [diff] [blame] | 4007 | |
| 4008 | TEST_F(VkLayerTest, InvalidRenderingAttachmentImageViewLayout) { |
| 4009 | TEST_DESCRIPTION("Use rendering attachment image view with invalid layout"); |
| 4010 | |
| 4011 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4012 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4013 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4014 | |
| 4015 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4016 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | e579a3b | 2022-04-23 11:38:02 +0200 | [diff] [blame] | 4017 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4018 | if (!AreRequiredExtensionsEnabled()) { |
| 4019 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | e579a3b | 2022-04-23 11:38:02 +0200 | [diff] [blame] | 4020 | } |
| 4021 | |
| 4022 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 4023 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4024 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4025 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4026 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | e579a3b | 2022-04-23 11:38:02 +0200 | [diff] [blame] | 4027 | } |
| 4028 | |
| 4029 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4030 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4031 | |
| 4032 | VkImageObj image(m_device); |
| 4033 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 4034 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4035 | |
| 4036 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4037 | color_attachment.imageView = image_view; |
| 4038 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_PREINITIALIZED; |
| 4039 | |
| 4040 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4041 | begin_rendering_info.colorAttachmentCount = 1; |
| 4042 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 4043 | begin_rendering_info.layerCount = 1; |
| 4044 | |
| 4045 | m_commandBuffer->begin(); |
| 4046 | |
| 4047 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06135"); |
| 4048 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4049 | m_errorMonitor->VerifyFound(); |
| 4050 | |
| 4051 | m_commandBuffer->end(); |
| 4052 | } |
ziga-lunarg | 409f821 | 2022-04-23 11:40:53 +0200 | [diff] [blame] | 4053 | |
| 4054 | TEST_F(VkLayerTest, InvalidResolveImageViewLayout) { |
| 4055 | TEST_DESCRIPTION("Use resolve image view with invalid layout"); |
| 4056 | |
| 4057 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4058 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4059 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4060 | |
| 4061 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4062 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 409f821 | 2022-04-23 11:40:53 +0200 | [diff] [blame] | 4063 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4064 | if (!AreRequiredExtensionsEnabled()) { |
| 4065 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 409f821 | 2022-04-23 11:40:53 +0200 | [diff] [blame] | 4066 | } |
| 4067 | |
| 4068 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 4069 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4070 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4071 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4072 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 409f821 | 2022-04-23 11:40:53 +0200 | [diff] [blame] | 4073 | } |
| 4074 | |
| 4075 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4076 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4077 | |
| 4078 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 4079 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 4080 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4081 | image_create_info.extent = {32, 32, 1}; |
ziga-lunarg | 409f821 | 2022-04-23 11:40:53 +0200 | [diff] [blame] | 4082 | image_create_info.mipLevels = 1; |
| 4083 | image_create_info.arrayLayers = 1; |
| 4084 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 4085 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 4086 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 4087 | |
| 4088 | VkImageObj image(m_device); |
| 4089 | image.Init(image_create_info); |
| 4090 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4091 | |
| 4092 | VkImageObj resolve_image(m_device); |
| 4093 | resolve_image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 4094 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4095 | |
| 4096 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4097 | color_attachment.imageView = image_view; |
| 4098 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4099 | color_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4100 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_PREINITIALIZED; |
| 4101 | color_attachment.resolveImageView = resolve_image_view; |
| 4102 | |
| 4103 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4104 | begin_rendering_info.colorAttachmentCount = 1; |
| 4105 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 4106 | begin_rendering_info.layerCount = 1; |
| 4107 | |
| 4108 | m_commandBuffer->begin(); |
| 4109 | |
| 4110 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06136"); |
| 4111 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4112 | m_errorMonitor->VerifyFound(); |
| 4113 | |
| 4114 | m_commandBuffer->end(); |
| 4115 | } |
ziga-lunarg | bbbef24 | 2022-04-23 12:12:10 +0200 | [diff] [blame] | 4116 | |
| 4117 | TEST_F(VkLayerTest, InvalidResolveImageViewLayoutSeparateDepthStencil) { |
| 4118 | TEST_DESCRIPTION("Use resolve image view with invalid layout"); |
| 4119 | |
| 4120 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4121 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4122 | AddRequiredExtensions(VK_KHR_SEPARATE_DEPTH_STENCIL_LAYOUTS_EXTENSION_NAME); |
| 4123 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4124 | |
| 4125 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4126 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | bbbef24 | 2022-04-23 12:12:10 +0200 | [diff] [blame] | 4127 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4128 | if (!AreRequiredExtensionsEnabled()) { |
| 4129 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | bbbef24 | 2022-04-23 12:12:10 +0200 | [diff] [blame] | 4130 | } |
| 4131 | |
| 4132 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 4133 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4134 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4135 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4136 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | bbbef24 | 2022-04-23 12:12:10 +0200 | [diff] [blame] | 4137 | } |
| 4138 | |
| 4139 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4140 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4141 | |
| 4142 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 4143 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 4144 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4145 | image_create_info.extent = {32, 32, 1}; |
ziga-lunarg | bbbef24 | 2022-04-23 12:12:10 +0200 | [diff] [blame] | 4146 | image_create_info.mipLevels = 1; |
| 4147 | image_create_info.arrayLayers = 1; |
| 4148 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 4149 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 4150 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 4151 | |
| 4152 | VkImageObj image(m_device); |
| 4153 | image.Init(image_create_info); |
| 4154 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4155 | |
| 4156 | VkImageObj resolve_image(m_device); |
| 4157 | resolve_image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 4158 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4159 | |
| 4160 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4161 | color_attachment.imageView = image_view; |
| 4162 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4163 | color_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4164 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL; |
| 4165 | color_attachment.resolveImageView = resolve_image_view; |
| 4166 | |
| 4167 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4168 | begin_rendering_info.colorAttachmentCount = 1; |
| 4169 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 4170 | begin_rendering_info.layerCount = 1; |
| 4171 | |
| 4172 | m_commandBuffer->begin(); |
| 4173 | |
| 4174 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06137"); |
| 4175 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4176 | m_errorMonitor->VerifyFound(); |
| 4177 | |
| 4178 | m_commandBuffer->end(); |
| 4179 | } |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4180 | |
| 4181 | TEST_F(VkLayerTest, InvalidRenderingAttachmentImageViewShadingRateLayout) { |
| 4182 | TEST_DESCRIPTION("Use image view with invalid layout"); |
| 4183 | |
| 4184 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4185 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
sjfricke | 6e8fb40 | 2022-06-05 09:47:58 +0900 | [diff] [blame] | 4186 | AddOptionalExtensions(VK_NV_SHADING_RATE_IMAGE_EXTENSION_NAME); |
| 4187 | AddOptionalExtensions(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4188 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4189 | |
| 4190 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4191 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4192 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4193 | if (!AreRequiredExtensionsEnabled()) { |
| 4194 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4195 | } |
| 4196 | |
sjfricke | 6e8fb40 | 2022-06-05 09:47:58 +0900 | [diff] [blame] | 4197 | const bool nv_shading_rate = IsExtensionsEnabled(VK_NV_SHADING_RATE_IMAGE_EXTENSION_NAME); |
| 4198 | const bool khr_fragment_shading = IsExtensionsEnabled(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
| 4199 | if (!khr_fragment_shading && !nv_shading_rate) { |
| 4200 | GTEST_SKIP() << "shading rate / fragment shading not supported"; |
| 4201 | } |
| 4202 | |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4203 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 4204 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4205 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4206 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4207 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4208 | } |
| 4209 | |
| 4210 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4211 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4212 | |
| 4213 | VkImageObj image(m_device); |
| 4214 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 4215 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4216 | |
| 4217 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4218 | color_attachment.imageView = image_view; |
| 4219 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_SHADING_RATE_OPTIMAL_NV; |
| 4220 | |
| 4221 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4222 | begin_rendering_info.colorAttachmentCount = 1; |
| 4223 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 4224 | begin_rendering_info.layerCount = 1; |
| 4225 | |
| 4226 | m_commandBuffer->begin(); |
| 4227 | |
sjfricke | 6e8fb40 | 2022-06-05 09:47:58 +0900 | [diff] [blame] | 4228 | // SHADING_RATE_OPTIMAL_NV is aliased FRAGMENT_SHADING_RATE_ATTACHMENT_OPTIMAL_KHR so VU depends on which extensions |
| 4229 | const char *vuid = |
| 4230 | khr_fragment_shading ? "VUID-VkRenderingAttachmentInfo-imageView-06143" : "VUID-VkRenderingAttachmentInfo-imageView-06138"; |
| 4231 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, vuid); |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4232 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4233 | m_errorMonitor->VerifyFound(); |
| 4234 | |
| 4235 | m_commandBuffer->end(); |
| 4236 | } |
| 4237 | |
| 4238 | TEST_F(VkLayerTest, InvalidResolveImageViewShadingRateLayout) { |
| 4239 | TEST_DESCRIPTION("Use resolve image view with invalid shading ratelayout"); |
| 4240 | |
| 4241 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4242 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
sjfricke | 6e8fb40 | 2022-06-05 09:47:58 +0900 | [diff] [blame] | 4243 | AddOptionalExtensions(VK_NV_SHADING_RATE_IMAGE_EXTENSION_NAME); |
| 4244 | AddOptionalExtensions(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4245 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4246 | |
| 4247 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4248 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4249 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4250 | if (!AreRequiredExtensionsEnabled()) { |
| 4251 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4252 | } |
| 4253 | |
sjfricke | 6e8fb40 | 2022-06-05 09:47:58 +0900 | [diff] [blame] | 4254 | const bool nv_shading_rate = IsExtensionsEnabled(VK_NV_SHADING_RATE_IMAGE_EXTENSION_NAME); |
| 4255 | const bool khr_fragment_shading = IsExtensionsEnabled(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
| 4256 | if (!khr_fragment_shading && !nv_shading_rate) { |
| 4257 | GTEST_SKIP() << "shading rate / fragment shading not supported"; |
| 4258 | } |
| 4259 | |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4260 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 4261 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4262 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4263 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4264 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4265 | } |
| 4266 | |
| 4267 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4268 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4269 | |
| 4270 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 4271 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 4272 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4273 | image_create_info.extent = {32, 32, 1}; |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4274 | image_create_info.mipLevels = 1; |
| 4275 | image_create_info.arrayLayers = 1; |
| 4276 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 4277 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 4278 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 4279 | |
| 4280 | VkImageObj image(m_device); |
| 4281 | image.Init(image_create_info); |
| 4282 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4283 | |
| 4284 | VkImageObj resolve_image(m_device); |
| 4285 | resolve_image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 4286 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4287 | |
| 4288 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4289 | color_attachment.imageView = image_view; |
| 4290 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4291 | color_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4292 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_SHADING_RATE_OPTIMAL_NV; |
| 4293 | color_attachment.resolveImageView = resolve_image_view; |
| 4294 | |
| 4295 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4296 | begin_rendering_info.colorAttachmentCount = 1; |
| 4297 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 4298 | begin_rendering_info.layerCount = 1; |
| 4299 | |
| 4300 | m_commandBuffer->begin(); |
| 4301 | |
sjfricke | 6e8fb40 | 2022-06-05 09:47:58 +0900 | [diff] [blame] | 4302 | // SHADING_RATE_OPTIMAL_NV is aliased FRAGMENT_SHADING_RATE_ATTACHMENT_OPTIMAL_KHR so VU depends on which extensions |
| 4303 | const char *vuid = |
| 4304 | khr_fragment_shading ? "VUID-VkRenderingAttachmentInfo-imageView-06144" : "VUID-VkRenderingAttachmentInfo-imageView-06139"; |
| 4305 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, vuid); |
ziga-lunarg | 7d2c111 | 2022-04-23 12:17:33 +0200 | [diff] [blame] | 4306 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4307 | m_errorMonitor->VerifyFound(); |
| 4308 | |
| 4309 | m_commandBuffer->end(); |
| 4310 | } |
ziga-lunarg | e750395 | 2022-04-23 12:19:14 +0200 | [diff] [blame] | 4311 | |
| 4312 | TEST_F(VkLayerTest, InvalidRenderingAttachmentImageViewFragmentDensityLayout) { |
| 4313 | TEST_DESCRIPTION("Use image view with invalid layout"); |
| 4314 | |
| 4315 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4316 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4317 | AddRequiredExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 4318 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4319 | |
| 4320 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4321 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | e750395 | 2022-04-23 12:19:14 +0200 | [diff] [blame] | 4322 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4323 | if (!AreRequiredExtensionsEnabled()) { |
| 4324 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | e750395 | 2022-04-23 12:19:14 +0200 | [diff] [blame] | 4325 | } |
| 4326 | |
| 4327 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 4328 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4329 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4330 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4331 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | e750395 | 2022-04-23 12:19:14 +0200 | [diff] [blame] | 4332 | } |
| 4333 | |
| 4334 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4335 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4336 | |
| 4337 | VkImageObj image(m_device); |
| 4338 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 4339 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4340 | |
| 4341 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4342 | color_attachment.imageView = image_view; |
| 4343 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_FRAGMENT_DENSITY_MAP_OPTIMAL_EXT; |
| 4344 | |
| 4345 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4346 | begin_rendering_info.colorAttachmentCount = 1; |
| 4347 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 4348 | begin_rendering_info.layerCount = 1; |
| 4349 | |
| 4350 | m_commandBuffer->begin(); |
| 4351 | |
| 4352 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06140"); |
| 4353 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4354 | m_errorMonitor->VerifyFound(); |
| 4355 | |
| 4356 | m_commandBuffer->end(); |
ziga-lunarg | 10cd0fb | 2022-04-23 12:20:46 +0200 | [diff] [blame] | 4357 | } |
| 4358 | |
| 4359 | TEST_F(VkLayerTest, InvalidResolveImageViewFragmentDensityLayout) { |
| 4360 | TEST_DESCRIPTION("Use resolve image view with invalid fragment density layout"); |
| 4361 | |
| 4362 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4363 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4364 | AddRequiredExtensions(VK_EXT_FRAGMENT_DENSITY_MAP_EXTENSION_NAME); |
| 4365 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4366 | |
| 4367 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4368 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 10cd0fb | 2022-04-23 12:20:46 +0200 | [diff] [blame] | 4369 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4370 | if (!AreRequiredExtensionsEnabled()) { |
| 4371 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 10cd0fb | 2022-04-23 12:20:46 +0200 | [diff] [blame] | 4372 | } |
| 4373 | |
| 4374 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 4375 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4376 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4377 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4378 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 10cd0fb | 2022-04-23 12:20:46 +0200 | [diff] [blame] | 4379 | } |
| 4380 | |
| 4381 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4382 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4383 | |
| 4384 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 4385 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 4386 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; |
| 4387 | image_create_info.extent = {32, 32, 4}; |
| 4388 | image_create_info.mipLevels = 1; |
| 4389 | image_create_info.arrayLayers = 1; |
| 4390 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 4391 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 4392 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 4393 | |
| 4394 | VkImageObj image(m_device); |
| 4395 | image.Init(image_create_info); |
| 4396 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4397 | |
| 4398 | VkImageObj resolve_image(m_device); |
| 4399 | resolve_image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 4400 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4401 | |
| 4402 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4403 | color_attachment.imageView = image_view; |
| 4404 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4405 | color_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4406 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_FRAGMENT_DENSITY_MAP_OPTIMAL_EXT; |
| 4407 | color_attachment.resolveImageView = resolve_image_view; |
| 4408 | |
| 4409 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4410 | begin_rendering_info.colorAttachmentCount = 1; |
| 4411 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 4412 | begin_rendering_info.layerCount = 1; |
| 4413 | |
| 4414 | m_commandBuffer->begin(); |
| 4415 | |
| 4416 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06141"); |
| 4417 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4418 | m_errorMonitor->VerifyFound(); |
| 4419 | |
| 4420 | m_commandBuffer->end(); |
| 4421 | } |
ziga-lunarg | dfa31d1 | 2022-04-23 12:22:18 +0200 | [diff] [blame] | 4422 | |
| 4423 | TEST_F(VkLayerTest, InvalidResolveImageViewReadOnlyOptimalLayout) { |
| 4424 | TEST_DESCRIPTION("Use resolve image view with invalid read only optimal layout"); |
| 4425 | |
| 4426 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4427 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4428 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4429 | |
| 4430 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4431 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | dfa31d1 | 2022-04-23 12:22:18 +0200 | [diff] [blame] | 4432 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4433 | if (!AreRequiredExtensionsEnabled()) { |
| 4434 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | dfa31d1 | 2022-04-23 12:22:18 +0200 | [diff] [blame] | 4435 | } |
| 4436 | |
| 4437 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeaturesKHR>(); |
| 4438 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4439 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4440 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4441 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | dfa31d1 | 2022-04-23 12:22:18 +0200 | [diff] [blame] | 4442 | } |
| 4443 | |
| 4444 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4445 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4446 | |
| 4447 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 4448 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 4449 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4450 | image_create_info.extent = {32, 32, 1}; |
ziga-lunarg | dfa31d1 | 2022-04-23 12:22:18 +0200 | [diff] [blame] | 4451 | image_create_info.mipLevels = 1; |
| 4452 | image_create_info.arrayLayers = 1; |
| 4453 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 4454 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 4455 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 4456 | |
| 4457 | VkImageObj image(m_device); |
| 4458 | image.Init(image_create_info); |
| 4459 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4460 | |
| 4461 | VkImageObj resolve_image(m_device); |
| 4462 | resolve_image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); |
| 4463 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4464 | |
| 4465 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4466 | color_attachment.imageView = image_view; |
| 4467 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4468 | color_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4469 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_READ_ONLY_OPTIMAL; |
| 4470 | color_attachment.resolveImageView = resolve_image_view; |
| 4471 | |
| 4472 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4473 | begin_rendering_info.colorAttachmentCount = 1; |
| 4474 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 4475 | begin_rendering_info.layerCount = 1; |
| 4476 | |
| 4477 | m_commandBuffer->begin(); |
| 4478 | |
| 4479 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingAttachmentInfo-imageView-06142"); |
| 4480 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4481 | m_errorMonitor->VerifyFound(); |
| 4482 | |
| 4483 | m_commandBuffer->end(); |
| 4484 | } |
ziga-lunarg | 735aa32 | 2022-04-24 14:17:47 +0200 | [diff] [blame] | 4485 | |
| 4486 | TEST_F(VkLayerTest, TestBeginRenderingFragmentShadingRateImageView) { |
| 4487 | TEST_DESCRIPTION("Test BeginRenderingInfo image view with FragmentShadingRateAttachment."); |
| 4488 | |
| 4489 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4490 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4491 | AddRequiredExtensions(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
| 4492 | |
| 4493 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4494 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4495 | if (IsDriver(VK_DRIVER_ID_AMD_PROPRIETARY)) { |
| 4496 | GTEST_SKIP() << "Skipping on AMD proprietary driver pending further investigation."; |
| 4497 | } |
| 4498 | |
ziga-lunarg | 735aa32 | 2022-04-24 14:17:47 +0200 | [diff] [blame] | 4499 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4500 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 735aa32 | 2022-04-24 14:17:47 +0200 | [diff] [blame] | 4501 | } |
| 4502 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4503 | if (!AreRequiredExtensionsEnabled()) { |
| 4504 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 735aa32 | 2022-04-24 14:17:47 +0200 | [diff] [blame] | 4505 | } |
| 4506 | |
| 4507 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 4508 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4509 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4510 | |
| 4511 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4512 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 735aa32 | 2022-04-24 14:17:47 +0200 | [diff] [blame] | 4513 | } |
| 4514 | |
| 4515 | auto fsr_properties = LvlInitStruct<VkPhysicalDeviceFragmentShadingRatePropertiesKHR>(); |
| 4516 | |
| 4517 | auto phys_dev_props_2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&fsr_properties); |
| 4518 | vk::GetPhysicalDeviceProperties2(gpu(), &phys_dev_props_2); |
| 4519 | |
| 4520 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4521 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4522 | |
| 4523 | VkImageObj image(m_device); |
| 4524 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, |
| 4525 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR, |
| 4526 | VK_IMAGE_TILING_LINEAR, 0); |
| 4527 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4528 | |
| 4529 | auto fragment_shading_rate = LvlInitStruct<VkRenderingFragmentShadingRateAttachmentInfoKHR>(); |
| 4530 | fragment_shading_rate.imageView = image_view; |
| 4531 | fragment_shading_rate.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4532 | fragment_shading_rate.shadingRateAttachmentTexelSize = fsr_properties.minFragmentShadingRateAttachmentTexelSize; |
| 4533 | |
| 4534 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&fragment_shading_rate); |
| 4535 | begin_rendering_info.layerCount = 1; |
| 4536 | |
| 4537 | m_commandBuffer->begin(); |
| 4538 | |
| 4539 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06147"); |
| 4540 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4541 | m_errorMonitor->VerifyFound(); |
| 4542 | |
| 4543 | m_commandBuffer->end(); |
| 4544 | } |
ziga-lunarg | 644c055 | 2022-04-24 17:50:58 +0200 | [diff] [blame] | 4545 | |
| 4546 | TEST_F(VkLayerTest, TestRenderingInfoColorAttachment) { |
| 4547 | TEST_DESCRIPTION("Test RenderingInfo color attachment."); |
| 4548 | |
| 4549 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4550 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4551 | |
| 4552 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4553 | |
| 4554 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4555 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 644c055 | 2022-04-24 17:50:58 +0200 | [diff] [blame] | 4556 | } |
| 4557 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4558 | if (!AreRequiredExtensionsEnabled()) { |
| 4559 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 644c055 | 2022-04-24 17:50:58 +0200 | [diff] [blame] | 4560 | } |
| 4561 | |
| 4562 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 4563 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4564 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4565 | |
| 4566 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4567 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 644c055 | 2022-04-24 17:50:58 +0200 | [diff] [blame] | 4568 | } |
| 4569 | |
| 4570 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4571 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4572 | |
| 4573 | VkImageObj invalid_image(m_device); |
| 4574 | invalid_image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_USAGE_SAMPLED_BIT, VK_IMAGE_TILING_LINEAR, 0); |
| 4575 | VkImageView invalid_image_view = invalid_image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4576 | |
| 4577 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 4578 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 4579 | image_create_info.format = VK_FORMAT_R8G8B8A8_UNORM; |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4580 | image_create_info.extent = {32, 32, 1}; |
ziga-lunarg | 644c055 | 2022-04-24 17:50:58 +0200 | [diff] [blame] | 4581 | image_create_info.mipLevels = 1; |
| 4582 | image_create_info.arrayLayers = 1; |
| 4583 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 4584 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 4585 | image_create_info.usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 4586 | image_create_info.sharingMode = VK_SHARING_MODE_EXCLUSIVE; |
| 4587 | VkImageObj image(m_device); |
| 4588 | image.Init(image_create_info); |
| 4589 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4590 | |
Tony-LunarG | f088c6b | 2022-07-08 11:29:53 -0600 | [diff] [blame] | 4591 | image_create_info.samples = VK_SAMPLE_COUNT_1_BIT; |
| 4592 | VkImageObj resolve_image(m_device); |
| 4593 | resolve_image.Init(image_create_info); |
| 4594 | VkImageView resolve_image_view = resolve_image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
| 4595 | |
ziga-lunarg | 644c055 | 2022-04-24 17:50:58 +0200 | [diff] [blame] | 4596 | VkRenderingAttachmentInfoKHR color_attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4597 | color_attachment.imageView = invalid_image_view; |
| 4598 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
Tony-LunarG | f088c6b | 2022-07-08 11:29:53 -0600 | [diff] [blame] | 4599 | color_attachment.resolveImageView = resolve_image_view; |
ziga-lunarg | 644c055 | 2022-04-24 17:50:58 +0200 | [diff] [blame] | 4600 | |
| 4601 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4602 | begin_rendering_info.layerCount = 1; |
| 4603 | begin_rendering_info.colorAttachmentCount = 1; |
| 4604 | begin_rendering_info.pColorAttachments = &color_attachment; |
| 4605 | |
| 4606 | m_commandBuffer->begin(); |
| 4607 | |
| 4608 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-colorAttachmentCount-06087"); |
| 4609 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4610 | m_errorMonitor->VerifyFound(); |
| 4611 | |
| 4612 | color_attachment.imageView = image_view; |
| 4613 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4614 | |
| 4615 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-colorAttachmentCount-06090"); |
| 4616 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4617 | m_errorMonitor->VerifyFound(); |
| 4618 | |
| 4619 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL; |
| 4620 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-colorAttachmentCount-06096"); |
| 4621 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4622 | m_errorMonitor->VerifyFound(); |
| 4623 | |
| 4624 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_STENCIL_ATTACHMENT_OPTIMAL; |
| 4625 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-colorAttachmentCount-06100"); |
| 4626 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4627 | m_errorMonitor->VerifyFound(); |
| 4628 | |
| 4629 | color_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4630 | color_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4631 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4632 | |
| 4633 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-colorAttachmentCount-06091"); |
| 4634 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4635 | m_errorMonitor->VerifyFound(); |
| 4636 | |
| 4637 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL; |
| 4638 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-colorAttachmentCount-06097"); |
| 4639 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4640 | m_errorMonitor->VerifyFound(); |
| 4641 | |
| 4642 | color_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_OPTIMAL; |
| 4643 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-colorAttachmentCount-06101"); |
| 4644 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4645 | m_errorMonitor->VerifyFound(); |
| 4646 | |
| 4647 | color_attachment.resolveMode = VK_RESOLVE_MODE_NONE; |
sjfricke | 483c108 | 2022-06-05 10:21:44 +0900 | [diff] [blame] | 4648 | |
ziga-lunarg | 644c055 | 2022-04-24 17:50:58 +0200 | [diff] [blame] | 4649 | const uint32_t max_color_attachments = m_device->phy().properties().limits.maxColorAttachments + 1; |
| 4650 | std::vector<VkRenderingAttachmentInfoKHR> color_attachments(max_color_attachments); |
| 4651 | for (auto &attachment : color_attachments) { |
| 4652 | attachment = LvlInitStruct<VkRenderingAttachmentInfoKHR>(); |
| 4653 | attachment.imageView = image_view; |
| 4654 | attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4655 | } |
| 4656 | begin_rendering_info.colorAttachmentCount = max_color_attachments; |
| 4657 | begin_rendering_info.pColorAttachments = color_attachments.data(); |
| 4658 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-colorAttachmentCount-06106"); |
| 4659 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4660 | m_errorMonitor->VerifyFound(); |
| 4661 | |
| 4662 | m_commandBuffer->end(); |
| 4663 | } |
ziga-lunarg | 7a69bd9 | 2022-04-25 00:33:18 +0200 | [diff] [blame] | 4664 | |
| 4665 | TEST_F(VkLayerTest, TestRenderingInfoDepthAttachment) { |
| 4666 | TEST_DESCRIPTION("Test RenderingInfo depth attachment."); |
| 4667 | |
| 4668 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4669 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4670 | AddRequiredExtensions(VK_KHR_DEPTH_STENCIL_RESOLVE_EXTENSION_NAME); |
| 4671 | |
| 4672 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4673 | |
| 4674 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4675 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 7a69bd9 | 2022-04-25 00:33:18 +0200 | [diff] [blame] | 4676 | } |
| 4677 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4678 | if (!AreRequiredExtensionsEnabled()) { |
| 4679 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 7a69bd9 | 2022-04-25 00:33:18 +0200 | [diff] [blame] | 4680 | } |
| 4681 | |
| 4682 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 4683 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4684 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4685 | |
| 4686 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4687 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 7a69bd9 | 2022-04-25 00:33:18 +0200 | [diff] [blame] | 4688 | } |
| 4689 | |
| 4690 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4691 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4692 | |
| 4693 | VkFormat ds_format = FindSupportedDepthStencilFormat(gpu()); |
| 4694 | if (ds_format == VK_FORMAT_UNDEFINED) { |
| 4695 | printf("%s No Depth + Stencil format found, skipping test..\n", kSkipPrefix); |
| 4696 | return; |
| 4697 | } |
| 4698 | |
| 4699 | auto depth_stencil_resolve_properties = LvlInitStruct<VkPhysicalDeviceDepthStencilResolveProperties>(); |
| 4700 | auto properties2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&depth_stencil_resolve_properties); |
| 4701 | vk::GetPhysicalDeviceProperties2(gpu(), &properties2); |
| 4702 | bool has_depth_resolve_mode_average = |
| 4703 | (depth_stencil_resolve_properties.supportedDepthResolveModes & VK_RESOLVE_MODE_AVERAGE_BIT) != 0; |
| 4704 | bool has_stencil_resolve_mode_average = |
| 4705 | (depth_stencil_resolve_properties.supportedStencilResolveModes & VK_RESOLVE_MODE_AVERAGE_BIT) != 0; |
| 4706 | |
| 4707 | VkImageCreateInfo image_create_info = LvlInitStruct<VkImageCreateInfo>(); |
| 4708 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 4709 | image_create_info.format = ds_format; |
| 4710 | image_create_info.extent = {32, 32, 1}; |
| 4711 | image_create_info.mipLevels = 1; |
| 4712 | image_create_info.arrayLayers = 1; |
| 4713 | image_create_info.samples = VK_SAMPLE_COUNT_2_BIT; |
| 4714 | image_create_info.tiling = VK_IMAGE_TILING_OPTIMAL; |
| 4715 | image_create_info.usage = VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT; |
| 4716 | VkImageObj image(m_device); |
| 4717 | image.Init(image_create_info); |
| 4718 | |
| 4719 | VkImageObj depth_image(m_device); |
| 4720 | depth_image.Init(image_create_info); |
| 4721 | VkImageView depth_image_view = depth_image.targetView(ds_format, VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 4722 | VkImageObj stencil_image(m_device); |
| 4723 | stencil_image.Init(image_create_info); |
| 4724 | VkImageView stencil_image_view = stencil_image.targetView(ds_format, VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 4725 | |
| 4726 | VkImageObj depth_resolvel_image(m_device); |
| 4727 | depth_resolvel_image.Init(32, 32, 1, ds_format, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, VK_IMAGE_TILING_OPTIMAL, 0); |
| 4728 | VkImageView depth_resolve_image_view = |
| 4729 | depth_resolvel_image.targetView(ds_format, VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 4730 | |
| 4731 | VkImageObj stencil_resolvel_image(m_device); |
| 4732 | stencil_resolvel_image.Init(32, 32, 1, ds_format, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, VK_IMAGE_TILING_OPTIMAL, 0); |
| 4733 | VkImageView stencil_resolve_image_view = |
| 4734 | stencil_resolvel_image.targetView(ds_format, VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 4735 | |
| 4736 | VkImageObj invalid_image(m_device); |
| 4737 | image_create_info.usage = VK_IMAGE_USAGE_SAMPLED_BIT; |
| 4738 | invalid_image.Init(image_create_info); |
| 4739 | VkImageView invalid_image_view = invalid_image.targetView(ds_format, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 4740 | |
| 4741 | auto depth_attachment = LvlInitStruct<VkRenderingAttachmentInfo>(); |
| 4742 | depth_attachment.imageView = depth_image_view; |
| 4743 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4744 | |
| 4745 | auto stencil_attachment = LvlInitStruct<VkRenderingAttachmentInfo>(); |
| 4746 | stencil_attachment.imageView = stencil_image_view; |
| 4747 | stencil_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4748 | |
| 4749 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4750 | begin_rendering_info.layerCount = 1; |
| 4751 | begin_rendering_info.pDepthAttachment = &depth_attachment; |
| 4752 | begin_rendering_info.pStencilAttachment = &stencil_attachment; |
| 4753 | |
| 4754 | m_commandBuffer->begin(); |
| 4755 | |
| 4756 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06085"); |
| 4757 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4758 | m_errorMonitor->VerifyFound(); |
| 4759 | |
| 4760 | depth_attachment.imageView = VK_NULL_HANDLE; |
| 4761 | stencil_attachment.imageView = VK_NULL_HANDLE; |
| 4762 | depth_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4763 | depth_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4764 | depth_attachment.resolveImageView = depth_resolve_image_view; |
| 4765 | stencil_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4766 | stencil_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4767 | stencil_attachment.resolveImageView = stencil_resolve_image_view; |
| 4768 | |
| 4769 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06086"); |
| 4770 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4771 | m_errorMonitor->VerifyFound(); |
| 4772 | |
| 4773 | depth_attachment.imageView = depth_image_view; |
| 4774 | stencil_attachment.imageView = depth_image_view; |
| 4775 | depth_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4776 | stencil_attachment.resolveImageView = depth_resolve_image_view; |
| 4777 | |
| 4778 | if (!has_depth_resolve_mode_average) { |
| 4779 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06102"); |
| 4780 | } |
| 4781 | if (!has_stencil_resolve_mode_average) { |
| 4782 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pStencilAttachment-06103"); |
| 4783 | } |
| 4784 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06093"); |
| 4785 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4786 | m_errorMonitor->VerifyFound(); |
| 4787 | |
| 4788 | depth_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL; |
| 4789 | if (has_depth_resolve_mode_average && has_stencil_resolve_mode_average) { |
| 4790 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06098"); |
| 4791 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4792 | m_errorMonitor->VerifyFound(); |
| 4793 | } |
| 4794 | |
| 4795 | depth_attachment.imageView = invalid_image_view; |
| 4796 | stencil_attachment.imageView = invalid_image_view; |
| 4797 | depth_attachment.resolveMode = VK_RESOLVE_MODE_NONE; |
| 4798 | stencil_attachment.resolveMode = VK_RESOLVE_MODE_NONE; |
| 4799 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06088"); |
| 4800 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pStencilAttachment-06089"); |
| 4801 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4802 | m_errorMonitor->VerifyFound(); |
| 4803 | |
| 4804 | depth_attachment.imageView = depth_image_view; |
| 4805 | stencil_attachment.imageView = depth_image_view; |
| 4806 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4807 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06092"); |
| 4808 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4809 | m_errorMonitor->VerifyFound(); |
| 4810 | |
| 4811 | depth_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4812 | stencil_attachment.imageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4813 | depth_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4814 | stencil_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL; |
| 4815 | depth_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4816 | if (depth_stencil_resolve_properties.independentResolveNone == VK_FALSE && has_depth_resolve_mode_average) { |
| 4817 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06104"); |
| 4818 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4819 | m_errorMonitor->VerifyFound(); |
| 4820 | } |
| 4821 | if (depth_stencil_resolve_properties.independentResolve == VK_FALSE && has_depth_resolve_mode_average) { |
| 4822 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pDepthAttachment-06105"); |
| 4823 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4824 | m_errorMonitor->VerifyFound(); |
| 4825 | } |
| 4826 | |
ziga-lunarg | f35a7d7 | 2022-04-25 01:00:41 +0200 | [diff] [blame] | 4827 | stencil_attachment.resolveMode = VK_RESOLVE_MODE_AVERAGE_BIT; |
| 4828 | stencil_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4829 | if (has_stencil_resolve_mode_average) { |
| 4830 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pStencilAttachment-06095"); |
| 4831 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4832 | m_errorMonitor->VerifyFound(); |
| 4833 | } |
| 4834 | stencil_attachment.resolveImageLayout = VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL; |
| 4835 | if (has_stencil_resolve_mode_average) { |
| 4836 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pStencilAttachment-06099"); |
| 4837 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4838 | m_errorMonitor->VerifyFound(); |
| 4839 | } |
| 4840 | |
| 4841 | depth_attachment.resolveMode = VK_RESOLVE_MODE_NONE; |
| 4842 | stencil_attachment.resolveMode = VK_RESOLVE_MODE_NONE; |
| 4843 | stencil_attachment.imageLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; |
| 4844 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pStencilAttachment-06094"); |
| 4845 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4846 | m_errorMonitor->VerifyFound(); |
| 4847 | |
ziga-lunarg | 7a69bd9 | 2022-04-25 00:33:18 +0200 | [diff] [blame] | 4848 | m_commandBuffer->end(); |
| 4849 | } |
ziga-lunarg | 002e656 | 2022-04-25 00:54:16 +0200 | [diff] [blame] | 4850 | |
| 4851 | TEST_F(VkLayerTest, InvalidRenderingRenderAreaWithDeviceGroupExt) { |
| 4852 | TEST_DESCRIPTION("Use negative offset in RenderingInfo render area"); |
| 4853 | |
| 4854 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4855 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4856 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4857 | |
| 4858 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4859 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 002e656 | 2022-04-25 00:54:16 +0200 | [diff] [blame] | 4860 | } |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4861 | if (!AreRequiredExtensionsEnabled()) { |
| 4862 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 002e656 | 2022-04-25 00:54:16 +0200 | [diff] [blame] | 4863 | } |
| 4864 | |
| 4865 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 4866 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4867 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4868 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4869 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 002e656 | 2022-04-25 00:54:16 +0200 | [diff] [blame] | 4870 | } |
| 4871 | |
| 4872 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4873 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4874 | |
| 4875 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4876 | begin_rendering_info.layerCount = 1; |
| 4877 | begin_rendering_info.renderArea.offset.x = -1; |
| 4878 | begin_rendering_info.renderArea.extent.width = 32; |
| 4879 | begin_rendering_info.renderArea.extent.height = 32; |
| 4880 | |
| 4881 | m_commandBuffer->begin(); |
| 4882 | |
| 4883 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06077"); |
| 4884 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4885 | m_errorMonitor->VerifyFound(); |
| 4886 | |
| 4887 | begin_rendering_info.renderArea.offset.x = 0; |
| 4888 | begin_rendering_info.renderArea.offset.y = -1; |
| 4889 | |
| 4890 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06078"); |
| 4891 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4892 | m_errorMonitor->VerifyFound(); |
| 4893 | |
| 4894 | m_commandBuffer->end(); |
| 4895 | } |
ziga-lunarg | 6e4f9da | 2022-04-25 01:05:22 +0200 | [diff] [blame] | 4896 | |
| 4897 | TEST_F(VkLayerTest, TestDynamicRenderingPipeline) { |
| 4898 | TEST_DESCRIPTION("Use pipeline created with render pass in dynamic render pass."); |
| 4899 | |
| 4900 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 4901 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4902 | |
| 4903 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4904 | |
| 4905 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4906 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 6e4f9da | 2022-04-25 01:05:22 +0200 | [diff] [blame] | 4907 | } |
| 4908 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4909 | if (!AreRequiredExtensionsEnabled()) { |
| 4910 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 6e4f9da | 2022-04-25 01:05:22 +0200 | [diff] [blame] | 4911 | } |
| 4912 | |
| 4913 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 4914 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 4915 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 4916 | |
| 4917 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4918 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 6e4f9da | 2022-04-25 01:05:22 +0200 | [diff] [blame] | 4919 | } |
| 4920 | |
| 4921 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 4922 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 4923 | |
| 4924 | CreatePipelineHelper pipe(*this); |
| 4925 | pipe.InitInfo(); |
| 4926 | pipe.InitState(); |
| 4927 | pipe.CreateGraphicsPipeline(); |
| 4928 | |
| 4929 | auto begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(); |
| 4930 | begin_rendering_info.layerCount = 1; |
| 4931 | |
| 4932 | m_commandBuffer->begin(); |
| 4933 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 4934 | |
| 4935 | vk::CmdBindPipeline(m_commandBuffer->handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.pipeline_); |
| 4936 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-vkCmdDraw-renderPass-06198"); |
| 4937 | vk::CmdDraw(m_commandBuffer->handle(), 3, 1, 0, 0); |
| 4938 | m_errorMonitor->VerifyFound(); |
| 4939 | |
| 4940 | m_commandBuffer->EndRendering(); |
| 4941 | m_commandBuffer->end(); |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 4942 | } |
| 4943 | |
| 4944 | TEST_F(VkLayerTest, TestBeginRenderingFragmentShadingRateAttachmentSize) { |
| 4945 | TEST_DESCRIPTION("Test FragmentShadingRateAttachment size."); |
| 4946 | |
| 4947 | SetTargetApiVersion(VK_API_VERSION_1_0); |
| 4948 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 4949 | AddRequiredExtensions(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4950 | AddRequiredExtensions(VK_KHR_MULTIVIEW_EXTENSION_NAME); |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 4951 | |
| 4952 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 4953 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4954 | if (IsDriver(VK_DRIVER_ID_AMD_PROPRIETARY)) { |
| 4955 | GTEST_SKIP() << "Skipping on AMD proprietary driver pending further investigation."; |
| 4956 | } |
| 4957 | |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 4958 | if (DeviceValidationVersion() != VK_API_VERSION_1_0) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4959 | GTEST_SKIP() << "Tests for 1.0 only"; |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 4960 | } |
| 4961 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 4962 | if (!AreRequiredExtensionsEnabled()) { |
| 4963 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 4964 | } |
| 4965 | |
| 4966 | auto vkGetPhysicalDeviceFeatures2KHR = reinterpret_cast<PFN_vkGetPhysicalDeviceFeatures2KHR>( |
| 4967 | vk::GetInstanceProcAddr(instance(), "vkGetPhysicalDeviceFeatures2KHR")); |
| 4968 | ASSERT_TRUE(vkGetPhysicalDeviceFeatures2KHR != nullptr); |
| 4969 | |
| 4970 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4971 | auto multiview_features = LvlInitStruct<VkPhysicalDeviceMultiviewFeaturesKHR>(&dynamic_rendering_features); |
| 4972 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2KHR>(&multiview_features); |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 4973 | vkGetPhysicalDeviceFeatures2KHR(gpu(), &features2); |
| 4974 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4975 | if (multiview_features.multiview == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4976 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 4977 | } |
| 4978 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 4979 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 4980 | } |
| 4981 | |
| 4982 | auto fsr_properties = LvlInitStruct<VkPhysicalDeviceFragmentShadingRatePropertiesKHR>(); |
| 4983 | |
| 4984 | auto phys_dev_props_2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&fsr_properties); |
| 4985 | vk::GetPhysicalDeviceProperties2(gpu(), &phys_dev_props_2); |
| 4986 | |
| 4987 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT)); |
| 4988 | |
| 4989 | VkImageObj image(m_device); |
| 4990 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, |
| 4991 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR, |
| 4992 | VK_IMAGE_TILING_LINEAR, 0); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 4993 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 4994 | |
| 4995 | auto fragment_shading_rate = LvlInitStruct<VkRenderingFragmentShadingRateAttachmentInfoKHR>(); |
| 4996 | fragment_shading_rate.imageView = image_view; |
| 4997 | fragment_shading_rate.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 4998 | fragment_shading_rate.shadingRateAttachmentTexelSize = fsr_properties.minFragmentShadingRateAttachmentTexelSize; |
| 4999 | |
| 5000 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&fragment_shading_rate); |
| 5001 | begin_rendering_info.layerCount = 1; |
| 5002 | begin_rendering_info.renderArea.offset.x = fragment_shading_rate.shadingRateAttachmentTexelSize.width * 64; |
| 5003 | |
| 5004 | m_commandBuffer->begin(); |
| 5005 | |
| 5006 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06117"); |
| 5007 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 5008 | m_errorMonitor->VerifyFound(); |
| 5009 | |
| 5010 | begin_rendering_info.renderArea.offset.x = 0; |
| 5011 | begin_rendering_info.renderArea.offset.y = fragment_shading_rate.shadingRateAttachmentTexelSize.height * 64; |
| 5012 | |
| 5013 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06118"); |
| 5014 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 5015 | m_errorMonitor->VerifyFound(); |
| 5016 | } |
| 5017 | |
| 5018 | TEST_F(VkLayerTest, TestBeginRenderingFragmentShadingRateAttachmentSizeWithDeviceGroupExt) { |
| 5019 | TEST_DESCRIPTION("Test FragmentShadingRateAttachment size with device group extension."); |
| 5020 | |
| 5021 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 5022 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 5023 | AddRequiredExtensions(VK_KHR_FRAGMENT_SHADING_RATE_EXTENSION_NAME); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 5024 | AddRequiredExtensions(VK_KHR_MULTIVIEW_EXTENSION_NAME); |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 5025 | |
| 5026 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 5027 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 5028 | if (IsDriver(VK_DRIVER_ID_AMD_PROPRIETARY)) { |
| 5029 | GTEST_SKIP() << "Skipping on AMD proprietary driver pending further investigation."; |
| 5030 | } |
| 5031 | |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 5032 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 5033 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 5034 | } |
| 5035 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 5036 | if (!AreRequiredExtensionsEnabled()) { |
| 5037 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 5038 | } |
| 5039 | |
| 5040 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 5041 | auto multiview_features = LvlInitStruct<VkPhysicalDeviceMultiviewFeaturesKHR>(&dynamic_rendering_features); |
| 5042 | VkPhysicalDeviceFeatures2 features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&multiview_features); |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 5043 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 5044 | |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 5045 | if (multiview_features.multiview == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 5046 | GTEST_SKIP() << "Test requires (unsupported) multiview"; |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 5047 | } |
| 5048 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 5049 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 5050 | } |
| 5051 | |
| 5052 | auto fsr_properties = LvlInitStruct<VkPhysicalDeviceFragmentShadingRatePropertiesKHR>(); |
| 5053 | |
| 5054 | auto phys_dev_props_2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&fsr_properties); |
| 5055 | vk::GetPhysicalDeviceProperties2(gpu(), &phys_dev_props_2); |
| 5056 | |
| 5057 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT)); |
| 5058 | |
| 5059 | VkImageObj image(m_device); |
| 5060 | image.Init(32, 32, 1, VK_FORMAT_R8G8B8A8_UNORM, |
| 5061 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR, |
| 5062 | VK_IMAGE_TILING_LINEAR, 0); |
Nathaniel Cesario | 0d50bcf | 2022-06-21 10:30:04 -0600 | [diff] [blame] | 5063 | VkImageView image_view = image.targetView(VK_FORMAT_R8G8B8A8_UNORM); |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 5064 | |
| 5065 | auto fragment_shading_rate = LvlInitStruct<VkRenderingFragmentShadingRateAttachmentInfoKHR>(); |
| 5066 | fragment_shading_rate.imageView = image_view; |
| 5067 | fragment_shading_rate.imageLayout = VK_IMAGE_LAYOUT_GENERAL; |
| 5068 | fragment_shading_rate.shadingRateAttachmentTexelSize = fsr_properties.minFragmentShadingRateAttachmentTexelSize; |
| 5069 | |
| 5070 | VkRenderingInfoKHR begin_rendering_info = LvlInitStruct<VkRenderingInfoKHR>(&fragment_shading_rate); |
| 5071 | begin_rendering_info.layerCount = 1; |
| 5072 | begin_rendering_info.renderArea.offset.x = fragment_shading_rate.shadingRateAttachmentTexelSize.width * 64; |
| 5073 | |
| 5074 | m_commandBuffer->begin(); |
| 5075 | |
| 5076 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06119"); |
| 5077 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 5078 | m_errorMonitor->VerifyFound(); |
| 5079 | |
| 5080 | begin_rendering_info.renderArea.offset.x = 0; |
| 5081 | begin_rendering_info.renderArea.offset.y = fragment_shading_rate.shadingRateAttachmentTexelSize.height * 64; |
| 5082 | |
ziga-lunarg | 8f9de2a | 2022-04-25 15:59:19 +0200 | [diff] [blame] | 5083 | VkRect2D render_area = {}; |
| 5084 | render_area.offset.x = 0; |
| 5085 | render_area.offset.y = 0; |
| 5086 | render_area.extent.width = 64 * fragment_shading_rate.shadingRateAttachmentTexelSize.width; |
| 5087 | render_area.extent.height = 32; |
| 5088 | |
| 5089 | auto device_group_render_pass_begin_info = LvlInitStruct<VkDeviceGroupRenderPassBeginInfo>(); |
| 5090 | device_group_render_pass_begin_info.deviceRenderAreaCount = 1; |
| 5091 | device_group_render_pass_begin_info.pDeviceRenderAreas = &render_area; |
| 5092 | fragment_shading_rate.pNext = &device_group_render_pass_begin_info; |
| 5093 | |
ziga-lunarg | 7f25dff | 2022-05-06 17:49:34 +0200 | [diff] [blame] | 5094 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06120"); |
ziga-lunarg | 8f9de2a | 2022-04-25 15:59:19 +0200 | [diff] [blame] | 5095 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 5096 | m_errorMonitor->VerifyFound(); |
| 5097 | |
| 5098 | render_area.extent.width = 32; |
| 5099 | render_area.extent.height = 64 * fragment_shading_rate.shadingRateAttachmentTexelSize.height; |
| 5100 | |
| 5101 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-pNext-06122"); |
ziga-lunarg | 6755163 | 2022-04-25 15:20:20 +0200 | [diff] [blame] | 5102 | m_commandBuffer->BeginRendering(begin_rendering_info); |
| 5103 | m_errorMonitor->VerifyFound(); |
| 5104 | } |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5105 | |
| 5106 | TEST_F(VkLayerTest, TestSuspendingRenderPassInstance) { |
| 5107 | TEST_DESCRIPTION("Test suspending render pass instance."); |
| 5108 | |
| 5109 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 5110 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 5111 | |
| 5112 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 5113 | |
| 5114 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 5115 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5116 | } |
| 5117 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 5118 | if (!AreRequiredExtensionsEnabled()) { |
| 5119 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5120 | } |
| 5121 | |
| 5122 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(); |
| 5123 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 5124 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 5125 | |
| 5126 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 5127 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5128 | } |
| 5129 | |
| 5130 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 5131 | |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5132 | VkCommandPoolObj command_pool(m_device, m_device->graphics_queue_node_index_); |
| 5133 | VkCommandBufferObj cmd_buffer1(m_device, &command_pool); |
| 5134 | VkCommandBufferObj cmd_buffer2(m_device, &command_pool); |
| 5135 | VkCommandBufferObj cmd_buffer3(m_device, &command_pool); |
| 5136 | |
| 5137 | VkRenderingInfo suspend_rendering_info = LvlInitStruct<VkRenderingInfo>(); |
| 5138 | suspend_rendering_info.flags = VK_RENDERING_SUSPENDING_BIT; |
| 5139 | suspend_rendering_info.layerCount = 1; |
| 5140 | |
| 5141 | VkRenderingInfo resume_rendering_info = LvlInitStruct<VkRenderingInfo>(); |
| 5142 | resume_rendering_info.flags = VK_RENDERING_RESUMING_BIT; |
| 5143 | resume_rendering_info.layerCount = 1; |
| 5144 | |
| 5145 | VkRenderingInfo rendering_info = LvlInitStruct<VkRenderingInfo>(); |
| 5146 | rendering_info.layerCount = 1; |
| 5147 | |
| 5148 | auto cmd_begin = LvlInitStruct<VkCommandBufferBeginInfo>(); |
| 5149 | |
| 5150 | cmd_buffer1.begin(&cmd_begin); |
| 5151 | cmd_buffer1.BeginRendering(suspend_rendering_info); |
| 5152 | cmd_buffer1.EndRendering(); |
| 5153 | cmd_buffer1.end(); |
| 5154 | |
| 5155 | cmd_buffer2.begin(&cmd_begin); |
| 5156 | cmd_buffer2.BeginRendering(resume_rendering_info); |
| 5157 | cmd_buffer2.EndRendering(); |
| 5158 | cmd_buffer2.end(); |
| 5159 | |
| 5160 | cmd_buffer3.begin(&cmd_begin); |
| 5161 | cmd_buffer3.BeginRendering(rendering_info); |
| 5162 | cmd_buffer3.EndRendering(); |
| 5163 | cmd_buffer3.end(); |
| 5164 | |
| 5165 | VkCommandBuffer command_buffers[3] = {cmd_buffer1.handle(), cmd_buffer2.handle()}; |
| 5166 | |
| 5167 | VkSubmitInfo submit_info = LvlInitStruct<VkSubmitInfo>(); |
| 5168 | submit_info.commandBufferCount = 2; |
| 5169 | submit_info.pCommandBuffers = command_buffers; |
| 5170 | vk::QueueSubmit(m_device->m_queue, 1, &submit_info, VK_NULL_HANDLE); |
| 5171 | vk::QueueWaitIdle(m_device->m_queue); |
| 5172 | |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5173 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkSubmitInfo-pCommandBuffers-06014"); |
| 5174 | |
| 5175 | submit_info.commandBufferCount = 1; |
| 5176 | vk::QueueSubmit(m_device->m_queue, 1, &submit_info, VK_NULL_HANDLE); |
| 5177 | vk::QueueWaitIdle(m_device->m_queue); |
| 5178 | |
| 5179 | m_errorMonitor->VerifyFound(); |
| 5180 | |
| 5181 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkSubmitInfo-pCommandBuffers-06016"); |
| 5182 | |
| 5183 | command_buffers[1] = cmd_buffer3.handle(); |
| 5184 | command_buffers[2] = cmd_buffer2.handle(); |
| 5185 | submit_info.commandBufferCount = 3; |
| 5186 | vk::QueueSubmit(m_device->m_queue, 1, &submit_info, VK_NULL_HANDLE); |
| 5187 | vk::QueueWaitIdle(m_device->m_queue); |
| 5188 | |
| 5189 | m_errorMonitor->VerifyFound(); |
| 5190 | |
| 5191 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkSubmitInfo-pCommandBuffers-06193"); |
| 5192 | |
| 5193 | command_buffers[0] = cmd_buffer2.handle(); |
| 5194 | submit_info.commandBufferCount = 1; |
| 5195 | vk::QueueSubmit(m_device->m_queue, 1, &submit_info, VK_NULL_HANDLE); |
| 5196 | vk::QueueWaitIdle(m_device->m_queue); |
| 5197 | |
| 5198 | m_errorMonitor->VerifyFound(); |
| 5199 | } |
| 5200 | |
| 5201 | TEST_F(VkLayerTest, TestSuspendingRenderPassInstanceQueueSubmit2) { |
| 5202 | TEST_DESCRIPTION("Test suspending render pass instance with QueueSubmit2."); |
| 5203 | |
| 5204 | SetTargetApiVersion(VK_API_VERSION_1_1); |
| 5205 | AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME); |
| 5206 | AddRequiredExtensions(VK_KHR_SYNCHRONIZATION_2_EXTENSION_NAME); |
| 5207 | |
| 5208 | ASSERT_NO_FATAL_FAILURE(InitFramework()); |
| 5209 | |
| 5210 | if (DeviceValidationVersion() < VK_API_VERSION_1_1) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 5211 | GTEST_SKIP() << "At least Vulkan version 1.1 is required"; |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5212 | } |
| 5213 | |
sjfricke | d700bc0 | 2022-05-30 16:35:06 +0900 | [diff] [blame] | 5214 | if (!AreRequiredExtensionsEnabled()) { |
| 5215 | GTEST_SKIP() << RequiredExtensionsNotSupported() << " not supported"; |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5216 | } |
| 5217 | |
| 5218 | auto synchronization2 = LvlInitStruct<VkPhysicalDeviceSynchronization2Features>(); |
| 5219 | auto dynamic_rendering_features = LvlInitStruct<VkPhysicalDeviceDynamicRenderingFeatures>(&synchronization2); |
| 5220 | auto features2 = LvlInitStruct<VkPhysicalDeviceFeatures2>(&dynamic_rendering_features); |
| 5221 | vk::GetPhysicalDeviceFeatures2(gpu(), &features2); |
| 5222 | |
| 5223 | if (dynamic_rendering_features.dynamicRendering == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 5224 | GTEST_SKIP() << "Test requires (unsupported) dynamicRendering"; |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5225 | } |
| 5226 | if (synchronization2.synchronization2 == VK_FALSE) { |
sjfricke | 50955f3 | 2022-06-05 10:12:52 +0900 | [diff] [blame] | 5227 | GTEST_SKIP() << "Test requires (unsupported) synchronization2"; |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5228 | } |
| 5229 | |
| 5230 | ASSERT_NO_FATAL_FAILURE(InitState(nullptr, &features2)); |
| 5231 | |
| 5232 | auto vkQueueSubmit2KHR = |
| 5233 | reinterpret_cast<PFN_vkQueueSubmit2KHR>(vk::GetDeviceProcAddr(m_device->device(), "vkQueueSubmit2KHR")); |
| 5234 | ASSERT_TRUE(vkQueueSubmit2KHR != nullptr); |
| 5235 | |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5236 | VkCommandPoolObj command_pool(m_device, m_device->graphics_queue_node_index_); |
| 5237 | VkCommandBufferObj cmd_buffer1(m_device, &command_pool); |
| 5238 | VkCommandBufferObj cmd_buffer2(m_device, &command_pool); |
| 5239 | VkCommandBufferObj cmd_buffer3(m_device, &command_pool); |
| 5240 | |
| 5241 | VkRenderingInfo suspend_rendering_info = LvlInitStruct<VkRenderingInfo>(); |
| 5242 | suspend_rendering_info.flags = VK_RENDERING_SUSPENDING_BIT; |
| 5243 | suspend_rendering_info.layerCount = 1; |
| 5244 | |
| 5245 | VkRenderingInfo resume_rendering_info = LvlInitStruct<VkRenderingInfo>(); |
| 5246 | resume_rendering_info.flags = VK_RENDERING_RESUMING_BIT; |
| 5247 | resume_rendering_info.layerCount = 1; |
| 5248 | |
| 5249 | VkRenderingInfo rendering_info = LvlInitStruct<VkRenderingInfo>(); |
| 5250 | rendering_info.layerCount = 1; |
| 5251 | |
| 5252 | auto cmd_begin = LvlInitStruct<VkCommandBufferBeginInfo>(); |
| 5253 | |
| 5254 | cmd_buffer1.begin(&cmd_begin); |
| 5255 | cmd_buffer1.BeginRendering(suspend_rendering_info); |
| 5256 | cmd_buffer1.EndRendering(); |
| 5257 | cmd_buffer1.end(); |
| 5258 | |
| 5259 | cmd_buffer2.begin(&cmd_begin); |
| 5260 | cmd_buffer2.BeginRendering(resume_rendering_info); |
| 5261 | cmd_buffer2.EndRendering(); |
| 5262 | cmd_buffer2.end(); |
| 5263 | |
| 5264 | cmd_buffer3.begin(&cmd_begin); |
| 5265 | cmd_buffer3.BeginRendering(rendering_info); |
| 5266 | cmd_buffer3.EndRendering(); |
| 5267 | cmd_buffer3.end(); |
| 5268 | |
| 5269 | VkCommandBufferSubmitInfo command_buffer_submit_info[3]; |
| 5270 | command_buffer_submit_info[0] = LvlInitStruct<VkCommandBufferSubmitInfo>(); |
| 5271 | command_buffer_submit_info[1] = LvlInitStruct<VkCommandBufferSubmitInfo>(); |
| 5272 | command_buffer_submit_info[2] = LvlInitStruct<VkCommandBufferSubmitInfo>(); |
| 5273 | |
| 5274 | command_buffer_submit_info[0].commandBuffer = cmd_buffer1.handle(); |
| 5275 | command_buffer_submit_info[1].commandBuffer = cmd_buffer2.handle(); |
| 5276 | |
| 5277 | VkSubmitInfo2KHR submit_info = LvlInitStruct<VkSubmitInfo2KHR>(); |
| 5278 | submit_info.commandBufferInfoCount = 2; |
| 5279 | submit_info.pCommandBufferInfos = command_buffer_submit_info; |
| 5280 | vkQueueSubmit2KHR(m_device->m_queue, 1, &submit_info, VK_NULL_HANDLE); |
| 5281 | vk::QueueWaitIdle(m_device->m_queue); |
| 5282 | |
ziga-lunarg | e966a9a | 2022-04-25 22:42:08 +0200 | [diff] [blame] | 5283 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkSubmitInfo2KHR-commandBuffer-06010"); |
| 5284 | |
| 5285 | submit_info.commandBufferInfoCount = 1; |
| 5286 | vkQueueSubmit2KHR(m_device->m_queue, 1, &submit_info, VK_NULL_HANDLE); |
| 5287 | vk::QueueWaitIdle(m_device->m_queue); |
| 5288 | |
| 5289 | m_errorMonitor->VerifyFound(); |
| 5290 | |
| 5291 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkSubmitInfo2KHR-commandBuffer-06012"); |
| 5292 | |
| 5293 | command_buffer_submit_info[1].commandBuffer = cmd_buffer3.handle(); |
| 5294 | command_buffer_submit_info[2].commandBuffer = cmd_buffer2.handle(); |
| 5295 | submit_info.commandBufferInfoCount = 3; |
| 5296 | vkQueueSubmit2KHR(m_device->m_queue, 1, &submit_info, VK_NULL_HANDLE); |
| 5297 | vk::QueueWaitIdle(m_device->m_queue); |
| 5298 | |
| 5299 | m_errorMonitor->VerifyFound(); |
| 5300 | |
| 5301 | m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkSubmitInfo2KHR-commandBuffer-06192"); |
| 5302 | |
| 5303 | command_buffer_submit_info[0].commandBuffer = cmd_buffer2.handle(); |
| 5304 | submit_info.commandBufferInfoCount = 1; |
| 5305 | vkQueueSubmit2KHR(m_device->m_queue, 1, &submit_info, VK_NULL_HANDLE); |
| 5306 | vk::QueueWaitIdle(m_device->m_queue); |
| 5307 | |
| 5308 | m_errorMonitor->VerifyFound(); |
| 5309 | } |