blob: 9875ec05be7a8196735e1cfe1902ad577d27495e [file] [log] [blame]
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07001/* Copyright (c) 2015-2019 The Khronos Group Inc.
2 * Copyright (c) 2015-2019 Valve Corporation
3 * Copyright (c) 2015-2019 LunarG, Inc.
4 * Copyright (C) 2015-2019 Google Inc.
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@lunarg.com>
19 * Author: Jon Ashburn <jon@lunarg.com>
20 * Author: Tobin Ehlis <tobin@lunarg.com>
21 */
22
Mark Lobodzinski0c668462018-09-27 10:13:19 -060023#include "chassis.h"
Mark Lobodzinskiadd93232018-10-09 11:49:42 -060024
Mark Lobodzinski63902f02018-09-21 10:36:44 -060025#include "object_lifetime_validation.h"
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060026
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060027uint64_t object_track_index = 0;
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060028
John Zulauf1c3844a2019-04-01 17:39:48 -060029VulkanTypedHandle ObjTrackStateTypedHandle(const ObjTrackState &track_state) {
30 // TODO: Unify Typed Handle representation (i.e. VulkanTypedHandle everywhere there are handle/type pairs)
31 VulkanTypedHandle typed_handle;
32 typed_handle.handle = track_state.handle;
33 typed_handle.type = track_state.object_type;
34 return typed_handle;
35}
36
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060037// Destroy memRef lists and free all memory
Mark Lobodzinski702c6a42019-09-11 11:52:23 -060038void ObjectLifetimes::DestroyQueueDataStructures() {
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060039 // Destroy the items in the queue map
Jeff Bolzfd3bb242019-08-22 06:10:49 -050040 auto snapshot = object_map[kVulkanObjectTypeQueue].snapshot();
41 for (const auto &queue : snapshot) {
42 uint32_t obj_index = queue.second->object_type;
Mark Lobodzinskiadd93232018-10-09 11:49:42 -060043 assert(num_total_objects > 0);
44 num_total_objects--;
45 assert(num_objects[obj_index] > 0);
46 num_objects[obj_index]--;
Jeff Bolzfd3bb242019-08-22 06:10:49 -050047 object_map[kVulkanObjectTypeQueue].erase(queue.first);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060048 }
49}
50
Mark Lobodzinskic763f582019-09-11 11:35:43 -060051void ObjectLifetimes::DestroyUndestroyedObjects(VulkanObjectType object_type) {
52 auto snapshot = object_map[object_type].snapshot();
53 for (const auto &item : snapshot) {
54 auto object_info = item.second;
55 DestroyObjectSilently(object_info->handle, object_type);
56 }
57}
58
Mark Lobodzinski9bd81192017-11-13 09:38:23 -070059// Look for this device object in any of the instance child devices lists.
60// NOTE: This is of dubious value. In most circumstances Vulkan will die a flaming death if a dispatchable object is invalid.
61// However, if this layer is loaded first and GetProcAddress is used to make API calls, it will detect bad DOs.
John Zulauf1c3844a2019-04-01 17:39:48 -060062bool ObjectLifetimes::ValidateDeviceObject(const VulkanTypedHandle &device_typed, const char *invalid_handle_code,
63 const char *wrong_device_code) {
Mark Lobodzinskiadd93232018-10-09 11:49:42 -060064 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), layer_data_map);
65 auto instance_object_lifetime_data = GetObjectLifetimeData(instance_data->object_dispatch);
Jeff Bolzfd3bb242019-08-22 06:10:49 -050066 if (instance_object_lifetime_data->object_map[kVulkanObjectTypeDevice].contains(device_typed.handle)) {
67 return false;
Mark Lobodzinski9bd81192017-11-13 09:38:23 -070068 }
John Zulauf1c3844a2019-04-01 17:39:48 -060069 return log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, device_typed.handle,
locke-lunarg9edc2812019-06-17 23:18:52 -060070 invalid_handle_code, "Invalid %s.", report_data->FormatHandle(device_typed).c_str());
Mark Lobodzinski9bd81192017-11-13 09:38:23 -070071}
72
Mark Lobodzinski702c6a42019-09-11 11:52:23 -060073void ObjectLifetimes::AllocateCommandBuffer(const VkCommandPool command_pool, const VkCommandBuffer command_buffer,
Mark Lobodzinski0c668462018-09-27 10:13:19 -060074 VkCommandBufferLevel level) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -050075 auto pNewObjNode = std::make_shared<ObjTrackState>();
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060076 pNewObjNode->object_type = kVulkanObjectTypeCommandBuffer;
77 pNewObjNode->handle = HandleToUint64(command_buffer);
78 pNewObjNode->parent_object = HandleToUint64(command_pool);
79 if (level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) {
80 pNewObjNode->status = OBJSTATUS_COMMAND_BUFFER_SECONDARY;
81 } else {
82 pNewObjNode->status = OBJSTATUS_NONE;
83 }
Jeff Bolzfd3bb242019-08-22 06:10:49 -050084 InsertObject(object_map[kVulkanObjectTypeCommandBuffer], HandleToUint64(command_buffer), kVulkanObjectTypeCommandBuffer,
85 pNewObjNode);
Mark Lobodzinskiadd93232018-10-09 11:49:42 -060086 num_objects[kVulkanObjectTypeCommandBuffer]++;
87 num_total_objects++;
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060088}
89
Mark Lobodzinski702c6a42019-09-11 11:52:23 -060090bool ObjectLifetimes::ValidateCommandBuffer(VkCommandPool command_pool, VkCommandBuffer command_buffer) {
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060091 bool skip = false;
92 uint64_t object_handle = HandleToUint64(command_buffer);
Jeff Bolzfd3bb242019-08-22 06:10:49 -050093 auto iter = object_map[kVulkanObjectTypeCommandBuffer].find(object_handle);
94 if (iter != object_map[kVulkanObjectTypeCommandBuffer].end()) {
95 auto pNode = iter->second;
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -060096
97 if (pNode->parent_object != HandleToUint64(command_pool)) {
John Zulauf1c3844a2019-04-01 17:39:48 -060098 // We know that the parent *must* be a command pool
99 const auto parent_pool = CastFromUint64<VkCommandPool>(pNode->parent_object);
locke-lunarg9edc2812019-06-17 23:18:52 -0600100 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
101 object_handle, "VUID-vkFreeCommandBuffers-pCommandBuffers-parent",
102 "FreeCommandBuffers is attempting to free %s belonging to %s from %s).",
103 report_data->FormatHandle(command_buffer).c_str(), report_data->FormatHandle(parent_pool).c_str(),
104 report_data->FormatHandle(command_pool).c_str());
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600105 }
106 } else {
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600107 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, object_handle,
locke-lunarg9edc2812019-06-17 23:18:52 -0600108 "VUID-vkFreeCommandBuffers-pCommandBuffers-00048", "Invalid %s.",
109 report_data->FormatHandle(command_buffer).c_str());
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600110 }
111 return skip;
112}
113
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600114void ObjectLifetimes::AllocateDescriptorSet(VkDescriptorPool descriptor_pool, VkDescriptorSet descriptor_set) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500115 auto pNewObjNode = std::make_shared<ObjTrackState>();
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600116 pNewObjNode->object_type = kVulkanObjectTypeDescriptorSet;
117 pNewObjNode->status = OBJSTATUS_NONE;
118 pNewObjNode->handle = HandleToUint64(descriptor_set);
119 pNewObjNode->parent_object = HandleToUint64(descriptor_pool);
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500120 InsertObject(object_map[kVulkanObjectTypeDescriptorSet], HandleToUint64(descriptor_set), kVulkanObjectTypeDescriptorSet,
121 pNewObjNode);
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600122 num_objects[kVulkanObjectTypeDescriptorSet]++;
123 num_total_objects++;
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600124
125 auto itr = object_map[kVulkanObjectTypeDescriptorPool].find(HandleToUint64(descriptor_pool));
126 if (itr != object_map[kVulkanObjectTypeDescriptorPool].end()) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500127 itr->second->child_objects->insert(HandleToUint64(descriptor_set));
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600128 }
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600129}
130
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600131bool ObjectLifetimes::ValidateDescriptorSet(VkDescriptorPool descriptor_pool, VkDescriptorSet descriptor_set) {
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600132 bool skip = false;
133 uint64_t object_handle = HandleToUint64(descriptor_set);
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600134 auto dsItem = object_map[kVulkanObjectTypeDescriptorSet].find(object_handle);
135 if (dsItem != object_map[kVulkanObjectTypeDescriptorSet].end()) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500136 if (dsItem->second->parent_object != HandleToUint64(descriptor_pool)) {
John Zulauf1c3844a2019-04-01 17:39:48 -0600137 // We know that the parent *must* be a descriptor pool
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500138 const auto parent_pool = CastFromUint64<VkDescriptorPool>(dsItem->second->parent_object);
John Zulauf1c3844a2019-04-01 17:39:48 -0600139 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT,
140 object_handle, "VUID-vkFreeDescriptorSets-pDescriptorSets-parent",
locke-lunarg9edc2812019-06-17 23:18:52 -0600141 "FreeDescriptorSets is attempting to free %s"
142 " belonging to %s from %s).",
John Zulauf1c3844a2019-04-01 17:39:48 -0600143 report_data->FormatHandle(descriptor_set).c_str(), report_data->FormatHandle(parent_pool).c_str(),
144 report_data->FormatHandle(descriptor_pool).c_str());
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600145 }
146 } else {
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600147 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, object_handle,
locke-lunarg9edc2812019-06-17 23:18:52 -0600148 "VUID-vkFreeDescriptorSets-pDescriptorSets-00310", "Invalid %s.",
149 report_data->FormatHandle(descriptor_set).c_str());
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600150 }
151 return skip;
152}
153
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600154bool ObjectLifetimes::ValidateDescriptorWrite(VkWriteDescriptorSet const *desc, bool isPush) {
Chris Forbes2c600e92017-10-20 11:13:20 -0700155 bool skip = false;
156
157 if (!isPush && desc->dstSet) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600158 skip |= ValidateObject(desc->dstSet, kVulkanObjectTypeDescriptorSet, false, "VUID-VkWriteDescriptorSet-dstSet-00320",
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600159 "VUID-VkWriteDescriptorSet-commonparent");
Chris Forbes2c600e92017-10-20 11:13:20 -0700160 }
161
162 if ((desc->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
163 (desc->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
164 for (uint32_t idx2 = 0; idx2 < desc->descriptorCount; ++idx2) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600165 skip |= ValidateObject(desc->pTexelBufferView[idx2], kVulkanObjectTypeBufferView, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600166 "VUID-VkWriteDescriptorSet-descriptorType-00323", "VUID-VkWriteDescriptorSet-commonparent");
Chris Forbes2c600e92017-10-20 11:13:20 -0700167 }
168 }
169
170 if ((desc->descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
Dave Houltona9df0ce2018-02-07 10:51:23 -0700171 (desc->descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) || (desc->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
Chris Forbes2c600e92017-10-20 11:13:20 -0700172 (desc->descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
173 for (uint32_t idx3 = 0; idx3 < desc->descriptorCount; ++idx3) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600174 skip |= ValidateObject(desc->pImageInfo[idx3].imageView, kVulkanObjectTypeImageView, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600175 "VUID-VkWriteDescriptorSet-descriptorType-00326", "VUID-VkDescriptorImageInfo-commonparent");
Chris Forbes2c600e92017-10-20 11:13:20 -0700176 }
177 }
178
179 if ((desc->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
180 (desc->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
181 (desc->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
182 (desc->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
183 for (uint32_t idx4 = 0; idx4 < desc->descriptorCount; ++idx4) {
184 if (desc->pBufferInfo[idx4].buffer) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600185 skip |= ValidateObject(desc->pBufferInfo[idx4].buffer, kVulkanObjectTypeBuffer, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600186 "VUID-VkDescriptorBufferInfo-buffer-parameter", kVUIDUndefined);
Chris Forbes2c600e92017-10-20 11:13:20 -0700187 }
188 }
189 }
190
191 return skip;
192}
193
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600194bool ObjectLifetimes::PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint,
195 VkPipelineLayout layout, uint32_t set, uint32_t descriptorWriteCount,
196 const VkWriteDescriptorSet *pDescriptorWrites) {
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600197 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600198 skip |= ValidateObject(commandBuffer, kVulkanObjectTypeCommandBuffer, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600199 "VUID-vkCmdPushDescriptorSetKHR-commandBuffer-parameter", "VUID-vkCmdPushDescriptorSetKHR-commonparent");
Mark Lobodzinski39965742019-09-11 11:03:51 -0600200 skip |= ValidateObject(layout, kVulkanObjectTypePipelineLayout, false, "VUID-vkCmdPushDescriptorSetKHR-layout-parameter",
201 "VUID-vkCmdPushDescriptorSetKHR-commonparent");
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600202 if (pDescriptorWrites) {
203 for (uint32_t index0 = 0; index0 < descriptorWriteCount; ++index0) {
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600204 skip |= ValidateDescriptorWrite(&pDescriptorWrites[index0], true);
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600205 }
206 }
207 return skip;
208}
209
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600210void ObjectLifetimes::CreateQueue(VkQueue vkObj) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500211 std::shared_ptr<ObjTrackState> p_obj_node = NULL;
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600212 auto queue_item = object_map[kVulkanObjectTypeQueue].find(HandleToUint64(vkObj));
213 if (queue_item == object_map[kVulkanObjectTypeQueue].end()) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500214 p_obj_node = std::make_shared<ObjTrackState>();
215 InsertObject(object_map[kVulkanObjectTypeQueue], HandleToUint64(vkObj), kVulkanObjectTypeQueue, p_obj_node);
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600216 num_objects[kVulkanObjectTypeQueue]++;
217 num_total_objects++;
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600218 } else {
219 p_obj_node = queue_item->second;
220 }
221 p_obj_node->object_type = kVulkanObjectTypeQueue;
222 p_obj_node->status = OBJSTATUS_NONE;
223 p_obj_node->handle = HandleToUint64(vkObj);
224}
225
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600226void ObjectLifetimes::CreateSwapchainImageObject(VkImage swapchain_image, VkSwapchainKHR swapchain) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500227 if (!swapchainImageMap.contains(HandleToUint64(swapchain_image))) {
228 auto pNewObjNode = std::make_shared<ObjTrackState>();
229 pNewObjNode->object_type = kVulkanObjectTypeImage;
230 pNewObjNode->status = OBJSTATUS_NONE;
231 pNewObjNode->handle = HandleToUint64(swapchain_image);
232 pNewObjNode->parent_object = HandleToUint64(swapchain);
233 InsertObject(swapchainImageMap, HandleToUint64(swapchain_image), kVulkanObjectTypeImage, pNewObjNode);
234 }
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600235}
236
Mark Lobodzinskibe102ad2019-09-04 12:03:07 -0600237bool ObjectLifetimes::ReportLeakedInstanceObjects(VkInstance instance, VulkanObjectType object_type,
238 const std::string &error_code) {
Mark Lobodzinski7cef2632019-08-28 15:50:13 -0600239 bool skip = false;
240
241 auto snapshot = object_map[object_type].snapshot();
242 for (const auto &item : snapshot) {
243 const auto object_info = item.second;
244 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, get_debug_report_enum[object_type], object_info->handle,
245 error_code, "OBJ ERROR : For %s, %s has not been destroyed.", report_data->FormatHandle(instance).c_str(),
246 report_data->FormatHandle(ObjTrackStateTypedHandle(*object_info)).c_str());
247 }
248 return skip;
249}
250
Mark Lobodzinskibe102ad2019-09-04 12:03:07 -0600251bool ObjectLifetimes::ReportLeakedDeviceObjects(VkDevice device, VulkanObjectType object_type, const std::string &error_code) {
Mark Lobodzinski5183a032018-09-13 14:44:28 -0600252 bool skip = false;
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500253
254 auto snapshot = object_map[object_type].snapshot();
255 for (const auto &item : snapshot) {
256 const auto object_info = item.second;
locke-lunarg9edc2812019-06-17 23:18:52 -0600257 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, get_debug_report_enum[object_type], object_info->handle,
258 error_code, "OBJ ERROR : For %s, %s has not been destroyed.", report_data->FormatHandle(device).c_str(),
259 report_data->FormatHandle(ObjTrackStateTypedHandle(*object_info)).c_str());
Gabríel Arthúr Péturssonfdcb5402018-03-20 21:52:06 +0000260 }
Mark Lobodzinski5183a032018-09-13 14:44:28 -0600261 return skip;
Gabríel Arthúr Péturssonfdcb5402018-03-20 21:52:06 +0000262}
263
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600264bool ObjectLifetimes::PreCallValidateDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600265 bool skip = false;
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600266
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600267 // We validate here for coverage, though we'd not have made it this for with a bad instance.
Mark Lobodzinski39965742019-09-11 11:03:51 -0600268 skip |= ValidateObject(instance, kVulkanObjectTypeInstance, true, "VUID-vkDestroyInstance-instance-parameter", kVUIDUndefined);
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600269
270 // Validate that child devices have been destroyed
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500271 auto snapshot = object_map[kVulkanObjectTypeDevice].snapshot();
272 for (const auto &iit : snapshot) {
273 auto pNode = iit.second;
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600274
275 VkDevice device = reinterpret_cast<VkDevice>(pNode->handle);
276 VkDebugReportObjectTypeEXT debug_object_type = get_debug_report_enum[pNode->object_type];
277
John Zulauf1c3844a2019-04-01 17:39:48 -0600278 skip |=
279 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, debug_object_type, pNode->handle, kVUID_ObjectTracker_ObjectLeak,
280 "OBJ ERROR : %s object %s has not been destroyed.", string_VkDebugReportObjectTypeEXT(debug_object_type),
281 report_data->FormatHandle(ObjTrackStateTypedHandle(*pNode)).c_str());
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600282
Mark Lobodzinski7cef2632019-08-28 15:50:13 -0600283 // Throw errors if any device objects belonging to this instance have not been destroyed
284 skip |= ReportUndestroyedDeviceObjects(device, "VUID-vkDestroyDevice-device-00378");
Mark Lobodzinskie65acca2019-09-11 12:06:17 -0600285 DestroyLeakedDeviceObjects();
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600286
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600287 skip |= ValidateDestroyObject(device, kVulkanObjectTypeDevice, pAllocator, "VUID-vkDestroyInstance-instance-00630",
288 "VUID-vkDestroyInstance-instance-00631");
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600289 }
290
Mark Lobodzinski7cef2632019-08-28 15:50:13 -0600291 // Throw errors if any instance objects created on this instance have not been destroyed
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600292 ValidateDestroyObject(instance, kVulkanObjectTypeInstance, pAllocator, "VUID-vkDestroyInstance-instance-00630",
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600293 "VUID-vkDestroyInstance-instance-00631");
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600294
Mark Lobodzinski7cef2632019-08-28 15:50:13 -0600295 // Report any remaining instance objects
296 skip |= ReportUndestroyedInstanceObjects(instance, "VUID-vkDestroyInstance-instance-00629");
Mark Lobodzinskie65acca2019-09-11 12:06:17 -0600297 DestroyLeakedInstanceObjects();
Mark Lobodzinski7cef2632019-08-28 15:50:13 -0600298
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600299 return skip;
300}
301
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600302bool ObjectLifetimes::PreCallValidateEnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount,
303 VkPhysicalDevice *pPhysicalDevices) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600304 bool skip = ValidateObject(instance, kVulkanObjectTypeInstance, false, "VUID-vkEnumeratePhysicalDevices-instance-parameter",
305 kVUIDUndefined);
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600306 return skip;
307}
308
309void ObjectLifetimes::PostCallRecordEnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700310 VkPhysicalDevice *pPhysicalDevices, VkResult result) {
311 if ((result != VK_SUCCESS) && (result != VK_INCOMPLETE)) return;
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600312 if (pPhysicalDevices) {
313 for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) {
Mark Lobodzinski1e76a7d2019-09-11 11:11:46 -0600314 CreateObject(pPhysicalDevices[i], kVulkanObjectTypePhysicalDevice, nullptr);
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600315 }
316 }
317}
318
319void ObjectLifetimes::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600320 // Destroy physical devices
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500321 auto snapshot = object_map[kVulkanObjectTypePhysicalDevice].snapshot();
322 for (const auto &iit : snapshot) {
323 auto pNode = iit.second;
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600324 VkPhysicalDevice physical_device = reinterpret_cast<VkPhysicalDevice>(pNode->handle);
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600325 RecordDestroyObject(physical_device, kVulkanObjectTypePhysicalDevice);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600326 }
327
Mark Lobodzinski9bd81192017-11-13 09:38:23 -0700328 // Destroy child devices
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500329 auto snapshot2 = object_map[kVulkanObjectTypeDevice].snapshot();
330 for (const auto &iit : snapshot2) {
331 auto pNode = iit.second;
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600332 VkDevice device = reinterpret_cast<VkDevice>(pNode->handle);
Mark Lobodzinskie65acca2019-09-11 12:06:17 -0600333 DestroyLeakedInstanceObjects();
Mark Lobodzinski9bd81192017-11-13 09:38:23 -0700334
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600335 RecordDestroyObject(device, kVulkanObjectTypeDevice);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600336 }
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600337}
338
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600339void ObjectLifetimes::PostCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600340 RecordDestroyObject(instance, kVulkanObjectTypeInstance);
Mark Lobodzinski34f5ea62018-09-14 09:51:43 -0600341}
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600342
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600343bool ObjectLifetimes::PreCallValidateDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600344 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600345 skip |= ValidateObject(device, kVulkanObjectTypeDevice, true, "VUID-vkDestroyDevice-device-parameter", kVUIDUndefined);
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600346 skip |= ValidateDestroyObject(device, kVulkanObjectTypeDevice, pAllocator, "VUID-vkDestroyDevice-device-00379",
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600347 "VUID-vkDestroyDevice-device-00380");
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600348 // Report any remaining objects associated with this VkDevice object in LL
Mark Lobodzinski7cef2632019-08-28 15:50:13 -0600349 skip |= ReportUndestroyedDeviceObjects(device, "VUID-vkDestroyDevice-device-00378");
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600350
351 return skip;
352}
353
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600354void ObjectLifetimes::PreCallRecordDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinski52db2352018-12-28 09:41:15 -0700355 auto instance_data = GetLayerDataPtr(get_dispatch_key(physical_device), layer_data_map);
356 ValidationObject *validation_data = GetValidationObject(instance_data->object_dispatch, LayerObjectTypeObjectTracker);
357 ObjectLifetimes *object_lifetimes = static_cast<ObjectLifetimes *>(validation_data);
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600358 object_lifetimes->RecordDestroyObject(device, kVulkanObjectTypeDevice);
Mark Lobodzinskie65acca2019-09-11 12:06:17 -0600359 DestroyLeakedDeviceObjects();
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600360
361 // Clean up Queue's MemRef Linked Lists
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600362 DestroyQueueDataStructures();
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600363}
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600364
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600365bool ObjectLifetimes::PreCallValidateGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex,
366 VkQueue *pQueue) {
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600367 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600368 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkGetDeviceQueue-device-parameter", kVUIDUndefined);
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600369 return skip;
370}
Mark Lobodzinski439645a2017-07-19 15:18:15 -0600371
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600372void ObjectLifetimes::PostCallRecordGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex,
373 VkQueue *pQueue) {
Jeff Bolzc31aae42019-08-12 20:29:43 -0500374 auto lock = write_shared_lock();
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600375 CreateQueue(*pQueue);
Mark Lobodzinski439645a2017-07-19 15:18:15 -0600376}
377
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600378bool ObjectLifetimes::PreCallValidateGetDeviceQueue2(VkDevice device, const VkDeviceQueueInfo2 *pQueueInfo, VkQueue *pQueue) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600379 return ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkGetDeviceQueue2-device-parameter", kVUIDUndefined);
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600380}
381
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600382void ObjectLifetimes::PostCallRecordGetDeviceQueue2(VkDevice device, const VkDeviceQueueInfo2 *pQueueInfo, VkQueue *pQueue) {
Jeff Bolzc31aae42019-08-12 20:29:43 -0500383 auto lock = write_shared_lock();
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600384 CreateQueue(*pQueue);
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600385}
386
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600387bool ObjectLifetimes::PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
388 const VkWriteDescriptorSet *pDescriptorWrites,
389 uint32_t descriptorCopyCount,
390 const VkCopyDescriptorSet *pDescriptorCopies) {
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600391 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600392 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkUpdateDescriptorSets-device-parameter", kVUIDUndefined);
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600393 if (pDescriptorCopies) {
394 for (uint32_t idx0 = 0; idx0 < descriptorCopyCount; ++idx0) {
395 if (pDescriptorCopies[idx0].dstSet) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600396 skip |= ValidateObject(pDescriptorCopies[idx0].dstSet, kVulkanObjectTypeDescriptorSet, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600397 "VUID-VkCopyDescriptorSet-dstSet-parameter", "VUID-VkCopyDescriptorSet-commonparent");
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600398 }
399 if (pDescriptorCopies[idx0].srcSet) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600400 skip |= ValidateObject(pDescriptorCopies[idx0].srcSet, kVulkanObjectTypeDescriptorSet, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600401 "VUID-VkCopyDescriptorSet-srcSet-parameter", "VUID-VkCopyDescriptorSet-commonparent");
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600402 }
403 }
404 }
405 if (pDescriptorWrites) {
406 for (uint32_t idx1 = 0; idx1 < descriptorWriteCount; ++idx1) {
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600407 skip |= ValidateDescriptorWrite(&pDescriptorWrites[idx1], false);
Mark Lobodzinskib58fe782018-09-14 11:50:27 -0600408 }
409 }
410 return skip;
411}
412
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600413bool ObjectLifetimes::PreCallValidateResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool,
414 VkDescriptorPoolResetFlags flags) {
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600415 bool skip = false;
Jeff Bolzc31aae42019-08-12 20:29:43 -0500416 auto lock = read_shared_lock();
Mark Lobodzinski0de500d2018-09-14 15:14:01 -0600417
Mark Lobodzinski39965742019-09-11 11:03:51 -0600418 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkResetDescriptorPool-device-parameter", kVUIDUndefined);
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600419 skip |=
Mark Lobodzinski39965742019-09-11 11:03:51 -0600420 ValidateObject(descriptorPool, kVulkanObjectTypeDescriptorPool, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600421 "VUID-vkResetDescriptorPool-descriptorPool-parameter", "VUID-vkResetDescriptorPool-descriptorPool-parent");
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600422
423 auto itr = object_map[kVulkanObjectTypeDescriptorPool].find(HandleToUint64(descriptorPool));
424 if (itr != object_map[kVulkanObjectTypeDescriptorPool].end()) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500425 auto pPoolNode = itr->second;
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600426 for (auto set : *pPoolNode->child_objects) {
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600427 skip |= ValidateDestroyObject((VkDescriptorSet)set, kVulkanObjectTypeDescriptorSet, nullptr, kVUIDUndefined,
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600428 kVUIDUndefined);
Mark Lobodzinski0de500d2018-09-14 15:14:01 -0600429 }
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600430 }
Mark Lobodzinski0de500d2018-09-14 15:14:01 -0600431 return skip;
432}
433
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600434void ObjectLifetimes::PreCallRecordResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool,
435 VkDescriptorPoolResetFlags flags) {
Jeff Bolzc31aae42019-08-12 20:29:43 -0500436 auto lock = write_shared_lock();
Mark Lobodzinski0de500d2018-09-14 15:14:01 -0600437 // A DescriptorPool's descriptor sets are implicitly deleted when the pool is reset. Remove this pool's descriptor sets from
438 // our descriptorSet map.
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600439 auto itr = object_map[kVulkanObjectTypeDescriptorPool].find(HandleToUint64(descriptorPool));
440 if (itr != object_map[kVulkanObjectTypeDescriptorPool].end()) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500441 auto pPoolNode = itr->second;
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600442 for (auto set : *pPoolNode->child_objects) {
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600443 RecordDestroyObject((VkDescriptorSet)set, kVulkanObjectTypeDescriptorSet);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600444 }
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600445 pPoolNode->child_objects->clear();
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600446 }
Mark Lobodzinski0de500d2018-09-14 15:14:01 -0600447}
448
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600449bool ObjectLifetimes::PreCallValidateBeginCommandBuffer(VkCommandBuffer command_buffer,
450 const VkCommandBufferBeginInfo *begin_info) {
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600451 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600452 skip |= ValidateObject(command_buffer, kVulkanObjectTypeCommandBuffer, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600453 "VUID-vkBeginCommandBuffer-commandBuffer-parameter", kVUIDUndefined);
Mark Lobodzinski0de500d2018-09-14 15:14:01 -0600454 if (begin_info) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500455 auto iter = object_map[kVulkanObjectTypeCommandBuffer].find(HandleToUint64(command_buffer));
456 if (iter != object_map[kVulkanObjectTypeCommandBuffer].end()) {
457 auto pNode = iter->second;
458 if ((begin_info->pInheritanceInfo) && (pNode->status & OBJSTATUS_COMMAND_BUFFER_SECONDARY) &&
459 (begin_info->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) {
460 skip |=
Mark Lobodzinski39965742019-09-11 11:03:51 -0600461 ValidateObject(begin_info->pInheritanceInfo->framebuffer, kVulkanObjectTypeFramebuffer, true,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600462 "VUID-VkCommandBufferBeginInfo-flags-00055", "VUID-VkCommandBufferInheritanceInfo-commonparent");
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500463 skip |=
Mark Lobodzinski39965742019-09-11 11:03:51 -0600464 ValidateObject(begin_info->pInheritanceInfo->renderPass, kVulkanObjectTypeRenderPass, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600465 "VUID-VkCommandBufferBeginInfo-flags-00053", "VUID-VkCommandBufferInheritanceInfo-commonparent");
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500466 }
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600467 }
468 }
Mark Lobodzinski0de500d2018-09-14 15:14:01 -0600469 return skip;
470}
471
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600472bool ObjectLifetimes::PreCallValidateGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain,
473 uint32_t *pSwapchainImageCount, VkImage *pSwapchainImages) {
Mark Lobodzinskibe4b3452018-09-14 16:14:33 -0600474 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600475 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkGetSwapchainImagesKHR-device-parameter",
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600476 "VUID-vkGetSwapchainImagesKHR-commonparent");
Mark Lobodzinski39965742019-09-11 11:03:51 -0600477 skip |= ValidateObject(swapchain, kVulkanObjectTypeSwapchainKHR, false, "VUID-vkGetSwapchainImagesKHR-swapchain-parameter",
478 "VUID-vkGetSwapchainImagesKHR-commonparent");
Mark Lobodzinskibe4b3452018-09-14 16:14:33 -0600479 return skip;
480}
481
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600482void ObjectLifetimes::PostCallRecordGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pSwapchainImageCount,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700483 VkImage *pSwapchainImages, VkResult result) {
484 if ((result != VK_SUCCESS) && (result != VK_INCOMPLETE)) return;
Jeff Bolzc31aae42019-08-12 20:29:43 -0500485 auto lock = write_shared_lock();
Mark Lobodzinskibe4b3452018-09-14 16:14:33 -0600486 if (pSwapchainImages != NULL) {
487 for (uint32_t i = 0; i < *pSwapchainImageCount; i++) {
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600488 CreateSwapchainImageObject(pSwapchainImages[i], swapchain);
Mark Lobodzinskibe4b3452018-09-14 16:14:33 -0600489 }
490 }
491}
492
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600493bool ObjectLifetimes::PreCallValidateCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
494 const VkAllocationCallbacks *pAllocator,
495 VkDescriptorSetLayout *pSetLayout) {
Petr Kraus42f6f8d2017-12-17 17:37:33 +0100496 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600497 skip |=
498 ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkCreateDescriptorSetLayout-device-parameter", kVUIDUndefined);
Mark Lobodzinskibe4b3452018-09-14 16:14:33 -0600499 if (pCreateInfo) {
500 if (pCreateInfo->pBindings) {
501 for (uint32_t binding_index = 0; binding_index < pCreateInfo->bindingCount; ++binding_index) {
502 const VkDescriptorSetLayoutBinding &binding = pCreateInfo->pBindings[binding_index];
503 const bool is_sampler_type = binding.descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER ||
504 binding.descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER;
505 if (binding.pImmutableSamplers && is_sampler_type) {
506 for (uint32_t index2 = 0; index2 < binding.descriptorCount; ++index2) {
507 const VkSampler sampler = binding.pImmutableSamplers[index2];
Mark Lobodzinski39965742019-09-11 11:03:51 -0600508 skip |= ValidateObject(sampler, kVulkanObjectTypeSampler, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600509 "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282", kVUIDUndefined);
Petr Kraus42f6f8d2017-12-17 17:37:33 +0100510 }
511 }
512 }
513 }
514 }
Mark Lobodzinskibe4b3452018-09-14 16:14:33 -0600515 return skip;
516}
517
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600518void ObjectLifetimes::PostCallRecordCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
519 const VkAllocationCallbacks *pAllocator,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700520 VkDescriptorSetLayout *pSetLayout, VkResult result) {
521 if (result != VK_SUCCESS) return;
Mark Lobodzinski1e76a7d2019-09-11 11:11:46 -0600522 CreateObject(*pSetLayout, kVulkanObjectTypeDescriptorSetLayout, pAllocator);
Mark Lobodzinskibe4b3452018-09-14 16:14:33 -0600523}
524
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600525bool ObjectLifetimes::ValidateSamplerObjects(const VkDescriptorSetLayoutCreateInfo *pCreateInfo) {
Mark Lobodzinski88a1a662018-07-02 14:09:39 -0600526 bool skip = false;
527 if (pCreateInfo->pBindings) {
528 for (uint32_t index1 = 0; index1 < pCreateInfo->bindingCount; ++index1) {
529 for (uint32_t index2 = 0; index2 < pCreateInfo->pBindings[index1].descriptorCount; ++index2) {
530 if (pCreateInfo->pBindings[index1].pImmutableSamplers) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600531 skip |= ValidateObject(pCreateInfo->pBindings[index1].pImmutableSamplers[index2], kVulkanObjectTypeSampler,
532 true, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282", kVUIDUndefined);
Mark Lobodzinski88a1a662018-07-02 14:09:39 -0600533 }
534 }
535 }
536 }
537 return skip;
538}
539
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600540bool ObjectLifetimes::PreCallValidateGetDescriptorSetLayoutSupport(VkDevice device,
541 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
542 VkDescriptorSetLayoutSupport *pSupport) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600543 bool skip = ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkGetDescriptorSetLayoutSupport-device-parameter",
544 kVUIDUndefined);
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600545 if (pCreateInfo) {
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600546 skip |= ValidateSamplerObjects(pCreateInfo);
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600547 }
548 return skip;
549}
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600550bool ObjectLifetimes::PreCallValidateGetDescriptorSetLayoutSupportKHR(VkDevice device,
551 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
552 VkDescriptorSetLayoutSupport *pSupport) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600553 bool skip = ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkGetDescriptorSetLayoutSupportKHR-device-parameter",
554 kVUIDUndefined);
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600555 if (pCreateInfo) {
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600556 skip |= ValidateSamplerObjects(pCreateInfo);
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600557 }
558 return skip;
559}
560
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600561bool ObjectLifetimes::PreCallValidateGetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice,
562 uint32_t *pQueueFamilyPropertyCount,
563 VkQueueFamilyProperties *pQueueFamilyProperties) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600564 return ValidateObject(physicalDevice, kVulkanObjectTypePhysicalDevice, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600565 "VUID-vkGetPhysicalDeviceQueueFamilyProperties-physicalDevice-parameter", kVUIDUndefined);
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600566}
Mark Lobodzinski63902f02018-09-21 10:36:44 -0600567
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600568void ObjectLifetimes::PostCallRecordGetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice,
569 uint32_t *pQueueFamilyPropertyCount,
Jeff Bolz6d243112019-08-21 13:24:11 -0500570 VkQueueFamilyProperties *pQueueFamilyProperties) {}
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600571
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600572void ObjectLifetimes::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700573 VkInstance *pInstance, VkResult result) {
574 if (result != VK_SUCCESS) return;
Mark Lobodzinski1e76a7d2019-09-11 11:11:46 -0600575 CreateObject(*pInstance, kVulkanObjectTypeInstance, pAllocator);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600576}
577
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600578bool ObjectLifetimes::PreCallValidateAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pAllocateInfo,
579 VkCommandBuffer *pCommandBuffers) {
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600580 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600581 skip |=
582 ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkAllocateCommandBuffers-device-parameter", kVUIDUndefined);
583 skip |= ValidateObject(pAllocateInfo->commandPool, kVulkanObjectTypeCommandPool, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600584 "VUID-VkCommandBufferAllocateInfo-commandPool-parameter", kVUIDUndefined);
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600585 return skip;
586}
587
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600588void ObjectLifetimes::PostCallRecordAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pAllocateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700589 VkCommandBuffer *pCommandBuffers, VkResult result) {
590 if (result != VK_SUCCESS) return;
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600591 for (uint32_t i = 0; i < pAllocateInfo->commandBufferCount; i++) {
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600592 AllocateCommandBuffer(pAllocateInfo->commandPool, pCommandBuffers[i], pAllocateInfo->level);
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600593 }
594}
595
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600596bool ObjectLifetimes::PreCallValidateAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo,
597 VkDescriptorSet *pDescriptorSets) {
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600598 bool skip = false;
Jeff Bolzc31aae42019-08-12 20:29:43 -0500599 auto lock = read_shared_lock();
Mark Lobodzinski39965742019-09-11 11:03:51 -0600600 skip |=
601 ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkAllocateDescriptorSets-device-parameter", kVUIDUndefined);
602 skip |= ValidateObject(pAllocateInfo->descriptorPool, kVulkanObjectTypeDescriptorPool, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600603 "VUID-VkDescriptorSetAllocateInfo-descriptorPool-parameter",
604 "VUID-VkDescriptorSetAllocateInfo-commonparent");
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600605 for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600606 skip |= ValidateObject(pAllocateInfo->pSetLayouts[i], kVulkanObjectTypeDescriptorSetLayout, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600607 "VUID-VkDescriptorSetAllocateInfo-pSetLayouts-parameter",
608 "VUID-VkDescriptorSetAllocateInfo-commonparent");
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600609 }
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600610 return skip;
611}
612
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600613void ObjectLifetimes::PostCallRecordAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700614 VkDescriptorSet *pDescriptorSets, VkResult result) {
615 if (result != VK_SUCCESS) return;
Jeff Bolzc31aae42019-08-12 20:29:43 -0500616 auto lock = write_shared_lock();
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600617 for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) {
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600618 AllocateDescriptorSet(pAllocateInfo->descriptorPool, pDescriptorSets[i]);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600619 }
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600620}
621
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600622bool ObjectLifetimes::PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
623 const VkCommandBuffer *pCommandBuffers) {
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600624 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600625 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkFreeCommandBuffers-device-parameter", kVUIDUndefined);
626 skip |= ValidateObject(commandPool, kVulkanObjectTypeCommandPool, false, "VUID-vkFreeCommandBuffers-commandPool-parameter",
627 "VUID-vkFreeCommandBuffers-commandPool-parent");
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600628 for (uint32_t i = 0; i < commandBufferCount; i++) {
629 if (pCommandBuffers[i] != VK_NULL_HANDLE) {
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600630 skip |= ValidateCommandBuffer(commandPool, pCommandBuffers[i]);
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600631 skip |=
632 ValidateDestroyObject(pCommandBuffers[i], kVulkanObjectTypeCommandBuffer, nullptr, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600633 }
634 }
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600635 return skip;
636}
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600637
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600638void ObjectLifetimes::PreCallRecordFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
639 const VkCommandBuffer *pCommandBuffers) {
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600640 for (uint32_t i = 0; i < commandBufferCount; i++) {
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600641 RecordDestroyObject(pCommandBuffers[i], kVulkanObjectTypeCommandBuffer);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600642 }
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600643}
644
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600645bool ObjectLifetimes::PreCallValidateDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain,
646 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600647 return ValidateDestroyObject(swapchain, kVulkanObjectTypeSwapchainKHR, pAllocator, "VUID-vkDestroySwapchainKHR-swapchain-01283",
648 "VUID-vkDestroySwapchainKHR-swapchain-01284");
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600649}
650
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600651void ObjectLifetimes::PreCallRecordDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain,
652 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600653 RecordDestroyObject(swapchain, kVulkanObjectTypeSwapchainKHR);
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500654
655 auto snapshot = swapchainImageMap.snapshot(
656 [swapchain](std::shared_ptr<ObjTrackState> pNode) { return pNode->parent_object == HandleToUint64(swapchain); });
657 for (const auto &itr : snapshot) {
658 swapchainImageMap.erase(itr.first);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600659 }
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600660}
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600661
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600662bool ObjectLifetimes::PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
663 uint32_t descriptorSetCount, const VkDescriptorSet *pDescriptorSets) {
Jeff Bolzc31aae42019-08-12 20:29:43 -0500664 auto lock = read_shared_lock();
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600665 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600666 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkFreeDescriptorSets-device-parameter", kVUIDUndefined);
667 skip |= ValidateObject(descriptorPool, kVulkanObjectTypeDescriptorPool, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600668 "VUID-vkFreeDescriptorSets-descriptorPool-parameter", "VUID-vkFreeDescriptorSets-descriptorPool-parent");
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600669 for (uint32_t i = 0; i < descriptorSetCount; i++) {
670 if (pDescriptorSets[i] != VK_NULL_HANDLE) {
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600671 skip |= ValidateDescriptorSet(descriptorPool, pDescriptorSets[i]);
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600672 skip |=
673 ValidateDestroyObject(pDescriptorSets[i], kVulkanObjectTypeDescriptorSet, nullptr, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600674 }
675 }
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600676 return skip;
677}
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600678void ObjectLifetimes::PreCallRecordFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
679 const VkDescriptorSet *pDescriptorSets) {
Jeff Bolzc31aae42019-08-12 20:29:43 -0500680 auto lock = write_shared_lock();
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500681 std::shared_ptr<ObjTrackState> pPoolNode = nullptr;
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600682 auto itr = object_map[kVulkanObjectTypeDescriptorPool].find(HandleToUint64(descriptorPool));
683 if (itr != object_map[kVulkanObjectTypeDescriptorPool].end()) {
684 pPoolNode = itr->second;
685 }
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600686 for (uint32_t i = 0; i < descriptorSetCount; i++) {
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600687 RecordDestroyObject(pDescriptorSets[i], kVulkanObjectTypeDescriptorSet);
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600688 if (pPoolNode) {
689 pPoolNode->child_objects->erase(HandleToUint64(pDescriptorSets[i]));
690 }
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600691 }
Mark Lobodzinski1c7fa372018-09-17 11:35:00 -0600692}
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600693
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600694bool ObjectLifetimes::PreCallValidateDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool,
695 const VkAllocationCallbacks *pAllocator) {
Jeff Bolzc31aae42019-08-12 20:29:43 -0500696 auto lock = read_shared_lock();
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600697 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600698 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkDestroyDescriptorPool-device-parameter", kVUIDUndefined);
699 skip |= ValidateObject(descriptorPool, kVulkanObjectTypeDescriptorPool, true,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600700 "VUID-vkDestroyDescriptorPool-descriptorPool-parameter",
701 "VUID-vkDestroyDescriptorPool-descriptorPool-parent");
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600702
703 auto itr = object_map[kVulkanObjectTypeDescriptorPool].find(HandleToUint64(descriptorPool));
704 if (itr != object_map[kVulkanObjectTypeDescriptorPool].end()) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500705 auto pPoolNode = itr->second;
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600706 for (auto set : *pPoolNode->child_objects) {
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600707 skip |= ValidateDestroyObject((VkDescriptorSet)set, kVulkanObjectTypeDescriptorSet, nullptr, kVUIDUndefined,
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600708 kVUIDUndefined);
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600709 }
710 }
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600711 skip |= ValidateDestroyObject(descriptorPool, kVulkanObjectTypeDescriptorPool, pAllocator,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600712 "VUID-vkDestroyDescriptorPool-descriptorPool-00304",
713 "VUID-vkDestroyDescriptorPool-descriptorPool-00305");
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600714 return skip;
715}
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600716void ObjectLifetimes::PreCallRecordDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool,
717 const VkAllocationCallbacks *pAllocator) {
Jeff Bolzc31aae42019-08-12 20:29:43 -0500718 auto lock = write_shared_lock();
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600719 auto itr = object_map[kVulkanObjectTypeDescriptorPool].find(HandleToUint64(descriptorPool));
720 if (itr != object_map[kVulkanObjectTypeDescriptorPool].end()) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500721 auto pPoolNode = itr->second;
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600722 for (auto set : *pPoolNode->child_objects) {
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600723 RecordDestroyObject((VkDescriptorSet)set, kVulkanObjectTypeDescriptorSet);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600724 }
Jeff Bolzcf802bc2019-02-10 00:18:00 -0600725 pPoolNode->child_objects->clear();
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600726 }
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600727 RecordDestroyObject(descriptorPool, kVulkanObjectTypeDescriptorPool);
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600728}
729
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600730bool ObjectLifetimes::PreCallValidateDestroyCommandPool(VkDevice device, VkCommandPool commandPool,
731 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600732 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600733 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkDestroyCommandPool-device-parameter", kVUIDUndefined);
734 skip |= ValidateObject(commandPool, kVulkanObjectTypeCommandPool, true, "VUID-vkDestroyCommandPool-commandPool-parameter",
735 "VUID-vkDestroyCommandPool-commandPool-parent");
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500736
737 auto snapshot = object_map[kVulkanObjectTypeCommandBuffer].snapshot(
738 [commandPool](std::shared_ptr<ObjTrackState> pNode) { return pNode->parent_object == HandleToUint64(commandPool); });
739 for (const auto &itr : snapshot) {
740 auto pNode = itr.second;
Mark Lobodzinski702c6a42019-09-11 11:52:23 -0600741 skip |= ValidateCommandBuffer(commandPool, reinterpret_cast<VkCommandBuffer>(itr.first));
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600742 skip |= ValidateDestroyObject(reinterpret_cast<VkCommandBuffer>(itr.first), kVulkanObjectTypeCommandBuffer, nullptr,
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500743 kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600744 }
Mark Lobodzinski3d89a2c2019-09-11 11:41:11 -0600745 skip |= ValidateDestroyObject(commandPool, kVulkanObjectTypeCommandPool, pAllocator,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600746 "VUID-vkDestroyCommandPool-commandPool-00042", "VUID-vkDestroyCommandPool-commandPool-00043");
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600747 return skip;
748}
749
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600750void ObjectLifetimes::PreCallRecordDestroyCommandPool(VkDevice device, VkCommandPool commandPool,
751 const VkAllocationCallbacks *pAllocator) {
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500752 auto snapshot = object_map[kVulkanObjectTypeCommandBuffer].snapshot(
753 [commandPool](std::shared_ptr<ObjTrackState> pNode) { return pNode->parent_object == HandleToUint64(commandPool); });
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600754 // A CommandPool's cmd buffers are implicitly deleted when pool is deleted. Remove this pool's cmdBuffers from cmd buffer map.
Jeff Bolzfd3bb242019-08-22 06:10:49 -0500755 for (const auto &itr : snapshot) {
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600756 RecordDestroyObject(reinterpret_cast<VkCommandBuffer>(itr.first), kVulkanObjectTypeCommandBuffer);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600757 }
Mark Lobodzinski82742f62019-09-11 11:20:26 -0600758 RecordDestroyObject(commandPool, kVulkanObjectTypeCommandPool);
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600759}
760
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600761bool ObjectLifetimes::PreCallValidateGetPhysicalDeviceQueueFamilyProperties2(VkPhysicalDevice physicalDevice,
762 uint32_t *pQueueFamilyPropertyCount,
763 VkQueueFamilyProperties2KHR *pQueueFamilyProperties) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600764 return ValidateObject(physicalDevice, kVulkanObjectTypePhysicalDevice, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600765 "VUID-vkGetPhysicalDeviceQueueFamilyProperties2-physicalDevice-parameter", kVUIDUndefined);
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600766}
767
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600768bool ObjectLifetimes::PreCallValidateGetPhysicalDeviceQueueFamilyProperties2KHR(VkPhysicalDevice physicalDevice,
769 uint32_t *pQueueFamilyPropertyCount,
770 VkQueueFamilyProperties2 *pQueueFamilyProperties) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600771 return ValidateObject(physicalDevice, kVulkanObjectTypePhysicalDevice, false,
Shannon McPherson3ea65132018-12-05 10:37:39 -0700772 "VUID-vkGetPhysicalDeviceQueueFamilyProperties2-physicalDevice-parameter", kVUIDUndefined);
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600773}
774
775void ObjectLifetimes::PostCallRecordGetPhysicalDeviceQueueFamilyProperties2(VkPhysicalDevice physicalDevice,
776 uint32_t *pQueueFamilyPropertyCount,
Jeff Bolz6d243112019-08-21 13:24:11 -0500777 VkQueueFamilyProperties2KHR *pQueueFamilyProperties) {}
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600778
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600779void ObjectLifetimes::PostCallRecordGetPhysicalDeviceQueueFamilyProperties2KHR(
Jeff Bolz6d243112019-08-21 13:24:11 -0500780 VkPhysicalDevice physicalDevice, uint32_t *pQueueFamilyPropertyCount, VkQueueFamilyProperties2KHR *pQueueFamilyProperties) {}
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600781
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600782bool ObjectLifetimes::PreCallValidateGetPhysicalDeviceDisplayPropertiesKHR(VkPhysicalDevice physicalDevice,
783 uint32_t *pPropertyCount,
784 VkDisplayPropertiesKHR *pProperties) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600785 return ValidateObject(physicalDevice, kVulkanObjectTypePhysicalDevice, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600786 "VUID-vkGetPhysicalDeviceDisplayPropertiesKHR-physicalDevice-parameter", kVUIDUndefined);
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600787}
788
789void ObjectLifetimes::PostCallRecordGetPhysicalDeviceDisplayPropertiesKHR(VkPhysicalDevice physicalDevice, uint32_t *pPropertyCount,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700790 VkDisplayPropertiesKHR *pProperties, VkResult result) {
791 if ((result != VK_SUCCESS) && (result != VK_INCOMPLETE)) return;
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600792 if (pProperties) {
793 for (uint32_t i = 0; i < *pPropertyCount; ++i) {
Mark Lobodzinski1e76a7d2019-09-11 11:11:46 -0600794 CreateObject(pProperties[i].display, kVulkanObjectTypeDisplayKHR, nullptr);
Mark Lobodzinskib2de97f2017-07-06 15:28:11 -0600795 }
796 }
797}
798
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600799bool ObjectLifetimes::PreCallValidateGetDisplayModePropertiesKHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
800 uint32_t *pPropertyCount,
801 VkDisplayModePropertiesKHR *pProperties) {
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600802 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600803 skip |= ValidateObject(physicalDevice, kVulkanObjectTypePhysicalDevice, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600804 "VUID-vkGetDisplayModePropertiesKHR-physicalDevice-parameter", kVUIDUndefined);
Mark Lobodzinski39965742019-09-11 11:03:51 -0600805 skip |= ValidateObject(display, kVulkanObjectTypeDisplayKHR, false, "VUID-vkGetDisplayModePropertiesKHR-display-parameter",
806 kVUIDUndefined);
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600807
808 return skip;
809}
810
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600811void ObjectLifetimes::PostCallRecordGetDisplayModePropertiesKHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700812 uint32_t *pPropertyCount, VkDisplayModePropertiesKHR *pProperties,
813 VkResult result) {
814 if ((result != VK_SUCCESS) && (result != VK_INCOMPLETE)) return;
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600815 if (pProperties) {
Tony-LunarGcd0c6b02018-10-26 14:56:44 -0600816 for (uint32_t i = 0; i < *pPropertyCount; ++i) {
Mark Lobodzinski1e76a7d2019-09-11 11:11:46 -0600817 CreateObject(pProperties[i].displayMode, kVulkanObjectTypeDisplayModeKHR, nullptr);
Shannon McPherson9d5167f2018-05-02 15:24:37 -0600818 }
819 }
Shannon McPherson9d5167f2018-05-02 15:24:37 -0600820}
821
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600822bool ObjectLifetimes::PreCallValidateGetPhysicalDeviceDisplayProperties2KHR(VkPhysicalDevice physicalDevice,
823 uint32_t *pPropertyCount,
824 VkDisplayProperties2KHR *pProperties) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600825 return ValidateObject(physicalDevice, kVulkanObjectTypePhysicalDevice, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600826 "VUID-vkGetPhysicalDeviceDisplayProperties2KHR-physicalDevice-parameter", kVUIDUndefined);
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600827}
828
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600829void ObjectLifetimes::PostCallRecordGetPhysicalDeviceDisplayProperties2KHR(VkPhysicalDevice physicalDevice,
830 uint32_t *pPropertyCount,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700831 VkDisplayProperties2KHR *pProperties, VkResult result) {
832 if ((result != VK_SUCCESS) && (result != VK_INCOMPLETE)) return;
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600833 for (uint32_t index = 0; index < *pPropertyCount; ++index) {
Mark Lobodzinski1e76a7d2019-09-11 11:11:46 -0600834 CreateObject(pProperties[index].displayProperties.display, kVulkanObjectTypeDisplayKHR, nullptr);
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600835 }
836}
837
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600838bool ObjectLifetimes::PreCallValidateGetDisplayModeProperties2KHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
839 uint32_t *pPropertyCount,
840 VkDisplayModeProperties2KHR *pProperties) {
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600841 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600842 skip |= ValidateObject(physicalDevice, kVulkanObjectTypePhysicalDevice, false,
Mark Lobodzinskiadd93232018-10-09 11:49:42 -0600843 "VUID-vkGetDisplayModeProperties2KHR-physicalDevice-parameter", kVUIDUndefined);
Mark Lobodzinski39965742019-09-11 11:03:51 -0600844 skip |= ValidateObject(display, kVulkanObjectTypeDisplayKHR, false, "VUID-vkGetDisplayModeProperties2KHR-display-parameter",
845 kVUIDUndefined);
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600846
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600847 return skip;
848}
849
Mark Lobodzinski0c668462018-09-27 10:13:19 -0600850void ObjectLifetimes::PostCallRecordGetDisplayModeProperties2KHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700851 uint32_t *pPropertyCount, VkDisplayModeProperties2KHR *pProperties,
852 VkResult result) {
853 if ((result != VK_SUCCESS) && (result != VK_INCOMPLETE)) return;
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600854 for (uint32_t index = 0; index < *pPropertyCount; ++index) {
Mark Lobodzinski1e76a7d2019-09-11 11:11:46 -0600855 CreateObject(pProperties[index].displayModeProperties.displayMode, kVulkanObjectTypeDisplayModeKHR, nullptr);
Mark Lobodzinskia2e97362018-09-17 13:58:32 -0600856 }
857}
Shannon McPhersonf7d9cf62019-06-26 09:23:57 -0600858
859bool ObjectLifetimes::PreCallValidateAcquirePerformanceConfigurationINTEL(
860 VkDevice device, const VkPerformanceConfigurationAcquireInfoINTEL *pAcquireInfo,
861 VkPerformanceConfigurationINTEL *pConfiguration) {
862 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600863 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkAcquirePerformanceConfigurationINTEL-device-parameter",
864 kVUIDUndefined);
Shannon McPhersonf7d9cf62019-06-26 09:23:57 -0600865
866 return skip;
867}
868
869bool ObjectLifetimes::PreCallValidateReleasePerformanceConfigurationINTEL(VkDevice device,
870 VkPerformanceConfigurationINTEL configuration) {
871 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600872 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkReleasePerformanceConfigurationINTEL-device-parameter",
873 kVUIDUndefined);
Shannon McPhersonf7d9cf62019-06-26 09:23:57 -0600874
875 return skip;
876}
877
878bool ObjectLifetimes::PreCallValidateQueueSetPerformanceConfigurationINTEL(VkQueue queue,
879 VkPerformanceConfigurationINTEL configuration) {
880 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600881 skip |= ValidateObject(queue, kVulkanObjectTypeQueue, false, "VUID-vkQueueSetPerformanceConfigurationINTEL-queue-parameter",
882 "VUID-vkQueueSetPerformanceConfigurationINTEL-commonparent");
Shannon McPhersonf7d9cf62019-06-26 09:23:57 -0600883
884 return skip;
885}
Tobias Hectorc9057422019-07-23 12:15:52 +0100886
887bool ObjectLifetimes::PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
888 const VkAllocationCallbacks *pAllocator, VkFramebuffer *pFramebuffer) {
889 bool skip = false;
Mark Lobodzinski39965742019-09-11 11:03:51 -0600890 skip |= ValidateObject(device, kVulkanObjectTypeDevice, false, "VUID-vkCreateFramebuffer-device-parameter", kVUIDUndefined);
Tobias Hectorc9057422019-07-23 12:15:52 +0100891 if (pCreateInfo) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600892 skip |= ValidateObject(pCreateInfo->renderPass, kVulkanObjectTypeRenderPass, false,
Tobias Hectorc9057422019-07-23 12:15:52 +0100893 "VUID-VkFramebufferCreateInfo-renderPass-parameter", "VUID-VkFramebufferCreateInfo-commonparent");
894 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT_KHR) == 0) {
895 for (uint32_t index1 = 0; index1 < pCreateInfo->attachmentCount; ++index1) {
Mark Lobodzinski39965742019-09-11 11:03:51 -0600896 skip |= ValidateObject(pCreateInfo->pAttachments[index1], kVulkanObjectTypeImageView, true, kVUIDUndefined,
Tobias Hectorc9057422019-07-23 12:15:52 +0100897 "VUID-VkFramebufferCreateInfo-commonparent");
898 }
899 }
900 }
901
902 return skip;
903}
904
905void ObjectLifetimes::PostCallRecordCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
906 const VkAllocationCallbacks *pAllocator, VkFramebuffer *pFramebuffer,
907 VkResult result) {
908 if (result != VK_SUCCESS) return;
Mark Lobodzinski1e76a7d2019-09-11 11:11:46 -0600909 CreateObject(*pFramebuffer, kVulkanObjectTypeFramebuffer, pAllocator);
Tobias Hectorc9057422019-07-23 12:15:52 +0100910}