blob: 29cc315739d1f819533b7bc0985cca0002490d11 [file] [log] [blame]
Dave Houlton4d9b2f82018-10-24 18:21:06 -06001/* Copyright (c) 2015-2018 The Khronos Group Inc.
2 * Copyright (c) 2015-2018 Valve Corporation
3 * Copyright (c) 2015-2018 LunarG, Inc.
4 * Copyright (C) 2015-2018 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
22
23#include <limits.h>
24#include <math.h>
25#include <stdio.h>
26#include <stdlib.h>
27#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028
29#include <iostream>
30#include <string>
31#include <sstream>
32#include <unordered_map>
33#include <unordered_set>
34#include <vector>
35#include <mutex>
36
37#include "vk_loader_platform.h"
38#include "vulkan/vk_layer.h"
39#include "vk_layer_config.h"
40#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060041#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060042
Mark Lobodzinskid4950072017-08-01 13:02:20 -060043#include "vk_layer_data.h"
44#include "vk_layer_logging.h"
45#include "vk_layer_extension_utils.h"
46#include "vk_layer_utils.h"
Lenny Komow4c0da772018-07-03 10:17:21 -060047#include "vk_layer_dispatch_table.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060048
49#include "parameter_name.h"
50#include "parameter_validation.h"
51
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060052#if defined __ANDROID__
53#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060054#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060055#else
56#define LOGCONSOLE(...) \
57 { \
58 printf(__VA_ARGS__); \
59 printf("\n"); \
60 }
61#endif
62
Mark Lobodzinskid4950072017-08-01 13:02:20 -060063namespace parameter_validation {
64
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060065extern std::unordered_map<std::string, void *> custom_functions;
66
Mark Lobodzinskid4950072017-08-01 13:02:20 -060067extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
68 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
69extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
70extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
71 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
72extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
73extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
74 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
75extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
76 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
77 const VkAllocationCallbacks *pAllocator,
78 VkDebugReportCallbackEXT *pMsgCallback);
79extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
80 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070081extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
82 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
83 const VkAllocationCallbacks *pAllocator,
84 VkDebugUtilsMessengerEXT *pMessenger);
85extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
86 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060087extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
88 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010089extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
90 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
91extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
92 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060093
94// TODO : This can be much smarter, using separate locks for separate global data
95std::mutex global_lock;
96
97static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
98std::unordered_map<void *, layer_data *> layer_data_map;
99std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
100
101void InitializeManualParameterValidationFunctionPointers(void);
102
103static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700104 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
105 "lunarg_parameter_validation");
106 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
107 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600108}
109
Mark Young6ba8abe2017-11-09 10:37:04 -0700110static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
111 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600112
113static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700114 "VK_LAYER_LUNARG_parameter_validation",
115 VK_LAYER_API_VERSION,
116 1,
117 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600118};
119
120static const int MaxParamCheckerStringLength = 256;
121
John Zulauf71968502017-10-26 13:51:15 -0600122template <typename T>
123static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
124 // Using only < for generality and || for early abort
125 return !((value < min) || (max < value));
126}
127
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600128static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600129 const std::string &vuid, const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600130 bool skip = false;
131
132 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
133
134 if (result == VK_STRING_ERROR_NONE) {
135 return skip;
136 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600137 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
138 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600139 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600140 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
141 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600142 }
143 return skip;
144}
145
146static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Dave Houlton13b65502018-05-23 13:35:24 -0600147 const char *parameter_name, const std::string &error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600148 bool skip = false;
149
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600150 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
151 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600152 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600153 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
154 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600155 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600156 skip |=
157 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600158 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600159 "%s: %s (= %" PRIu32
160 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
161 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600162 }
163
164 return skip;
165}
166
167static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
Dave Houlton13b65502018-05-23 13:35:24 -0600168 const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
169 const std::string &valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600170 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600171 if (queue_families) {
172 std::unordered_set<uint32_t> set;
173 for (uint32_t i = 0; i < queue_family_count; ++i) {
174 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
175
176 if (set.count(queue_families[i])) {
177 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600178 HandleToUint64(device_data->device), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600179 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
180 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600181 } else {
182 set.insert(queue_families[i]);
183 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600184 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600185 }
186 }
187 }
188 return skip;
189}
190
John Zulauf620755c2018-04-16 11:00:43 -0600191static bool validate_api_version(const instance_layer_data *instance_data, uint32_t api_version, uint32_t effective_api_version) {
192 bool skip = false;
193 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
194 if (api_version_nopatch != effective_api_version) {
195 if (api_version_nopatch < VK_API_VERSION_1_0) {
196 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600197 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600198 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
199 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
200 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
201 } else {
202 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600203 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600204 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
205 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
206 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
207 }
208 }
209 return skip;
210}
211
212template <typename ExtensionState>
Dave Houlton13b65502018-05-23 13:35:24 -0600213static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
214 const std::string &vuid, const char *extension_type, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -0600215 bool skip = false;
216 if (!extension_name) {
217 return skip; // Robust to invalid char *
218 }
219 auto info = ExtensionState::get_info(extension_name);
220
221 if (!info.state) {
222 return skip; // Unknown extensions cannot be checked so report OK
223 }
224
Pat Brown3eddb062018-09-05 14:07:37 -0400225 // Check against the required list in the info
John Zulauf620755c2018-04-16 11:00:43 -0600226 std::vector<const char *> missing;
227 for (const auto &req : info.requires) {
228 if (!(extensions.*(req.enabled))) {
229 missing.push_back(req.name);
230 }
231 }
232
233 // Report any missing requirements
234 if (missing.size()) {
235 std::string missing_joined_list = string_join(", ", missing);
236 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Pat Brown3eddb062018-09-05 14:07:37 -0400237 HandleToUint64(instance_data->instance), vuid, "Missing extension%s required by the %s extension %s: %s.",
238 ((missing.size() > 1) ? "s" : ""), extension_type, extension_name, missing_joined_list.c_str());
John Zulauf620755c2018-04-16 11:00:43 -0600239 }
240 return skip;
241}
242
243bool validate_instance_extensions(const instance_layer_data *instance_data, const VkInstanceCreateInfo *pCreateInfo) {
244 bool skip = false;
245 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Dave Houlton413a6782018-05-22 13:01:54 -0600246 skip |=
247 validate_extension_reqs(instance_data, instance_data->extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
248 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -0600249 }
250
251 return skip;
252}
253
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600254VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600255 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600256 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
257
258 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
259 assert(chain_info != nullptr);
260 assert(chain_info->u.pLayerInfo != nullptr);
261
262 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
263 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
264 if (fpCreateInstance == NULL) {
265 return VK_ERROR_INITIALIZATION_FAILED;
266 }
267
268 // Advance the link info for the next element on the chain
269 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
270
271 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
272
273 if (result == VK_SUCCESS) {
274 InitializeManualParameterValidationFunctionPointers();
275 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
276 assert(my_instance_data != nullptr);
277
278 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
279 my_instance_data->instance = *pInstance;
280 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700281 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
282 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600283
284 // Look for one or more debug report create info structures
285 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700286 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
287 &my_instance_data->tmp_messenger_create_infos,
288 &my_instance_data->tmp_debug_messengers)) {
289 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600290 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700291 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
292 my_instance_data->tmp_messenger_create_infos,
293 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600294 // Failure of setting up one or more of the callback.
295 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700296 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
297 my_instance_data->tmp_debug_messengers);
298 my_instance_data->num_tmp_debug_messengers = 0;
299 }
300 }
301 }
302 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
303 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
304 if (my_instance_data->num_tmp_report_callbacks > 0) {
305 // Setup the temporary callback(s) here to catch early issues:
306 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
307 my_instance_data->tmp_report_create_infos,
308 my_instance_data->tmp_report_callbacks)) {
309 // Failure of setting up one or more of the callback.
310 // Therefore, clean up and don't use those callbacks:
311 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
312 my_instance_data->tmp_report_callbacks);
313 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600314 }
315 }
316 }
317
318 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600319 // Note: From the spec--
320 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
321 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
322 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
323 ? pCreateInfo->pApplicationInfo->apiVersion
324 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600325
John Zulauf1909e6a2018-09-05 11:43:11 -0600326 my_instance_data->api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600327
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600328 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
329 // survive we can report the issue now.
John Zulauf1909e6a2018-09-05 11:43:11 -0600330 validate_api_version(my_instance_data, api_version, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600331 validate_instance_extensions(my_instance_data, pCreateInfo);
332
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600333 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
334
335 if (pCreateInfo->pApplicationInfo) {
336 if (pCreateInfo->pApplicationInfo->pApplicationName) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600337 validate_string(
338 my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pApplicationName",
339 "VUID-VkApplicationInfo-pApplicationName-parameter", pCreateInfo->pApplicationInfo->pApplicationName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600340 }
341
342 if (pCreateInfo->pApplicationInfo->pEngineName) {
343 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600344 "VUID-VkApplicationInfo-pEngineName-parameter", pCreateInfo->pApplicationInfo->pEngineName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600345 }
346 }
347
348 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700349 if (my_instance_data->num_tmp_debug_messengers > 0) {
350 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
351 my_instance_data->tmp_debug_messengers);
352 }
353 if (my_instance_data->num_tmp_report_callbacks > 0) {
354 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
355 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600356 }
357 }
358
359 return result;
360}
361
362VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
363 // Grab the key before the instance is destroyed.
364 dispatch_key key = get_dispatch_key(instance);
365 bool skip = false;
366 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
367
368 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
369 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700370 if (instance_data->num_tmp_debug_messengers > 0) {
371 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
372 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
373 callback_setup = true;
374 }
375 }
376 if (instance_data->num_tmp_report_callbacks > 0) {
377 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
378 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600379 callback_setup = true;
380 }
381 }
382
383 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
384
385 // Disable and cleanup the temporary callback(s):
386 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700387 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
388 instance_data->tmp_debug_messengers);
389 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
390 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600391 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700392 if (instance_data->num_tmp_debug_messengers > 0) {
393 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
394 instance_data->num_tmp_debug_messengers = 0;
395 }
396 if (instance_data->num_tmp_report_callbacks > 0) {
397 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
398 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600399 }
400
401 if (!skip) {
402 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
403
404 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700405 while (instance_data->logging_messenger.size() > 0) {
406 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
407 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
408 instance_data->logging_messenger.pop_back();
409 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600410 while (instance_data->logging_callback.size() > 0) {
411 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700412 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600413 instance_data->logging_callback.pop_back();
414 }
415
Mark Young6ba8abe2017-11-09 10:37:04 -0700416 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600417 }
418
419 FreeLayerDataPtr(key, instance_layer_data_map);
420}
421
422VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
423 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
424 const VkAllocationCallbacks *pAllocator,
425 VkDebugReportCallbackEXT *pMsgCallback) {
426 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
427 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
428
429 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
430 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
431 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700432 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
433 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
434 if (VK_SUCCESS != result) {
435 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
436 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600437 }
438 return result;
439}
440
441VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
442 const VkAllocationCallbacks *pAllocator) {
443 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
444 if (!skip) {
445 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
446 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700447 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
448 }
449}
450
451VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
452 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
453 const VkAllocationCallbacks *pAllocator,
454 VkDebugUtilsMessengerEXT *pMessenger) {
455 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
456 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
457
458 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
459 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
460 if (VK_SUCCESS == result) {
461 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
462 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
463 if (VK_SUCCESS != result) {
464 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
465 }
466 }
467 return result;
468}
469
470VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
471 const VkAllocationCallbacks *pAllocator) {
472 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
473 if (!skip) {
474 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
475 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
476 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600477 }
478}
479
John Zulauf620755c2018-04-16 11:00:43 -0600480template <typename ExtensionState>
481static bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
482 if (!extension_name) return false; // null strings specify nothing
483 auto info = ExtensionState::get_info(extension_name);
484 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
485 return state;
486}
487
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600488static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
John Zulauf620755c2018-04-16 11:00:43 -0600489 const VkDeviceCreateInfo *pCreateInfo, const DeviceExtensions &extensions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600490 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600491 bool maint1 = false;
492 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600493
494 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
495 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
496 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600497 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600498 }
499 }
500
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600501 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
John Zulauf620755c2018-04-16 11:00:43 -0600502 maint1 = extension_state_by_name(extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
503 negative_viewport = extension_state_by_name(extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
504
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600505 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
506 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600507 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600508 pCreateInfo->ppEnabledExtensionNames[i]);
Dave Houlton413a6782018-05-22 13:01:54 -0600509 skip |= validate_extension_reqs(instance_data, extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387",
510 "device", pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600511 }
512 }
513
514 if (maint1 && negative_viewport) {
515 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600516 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600517 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600518 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600519 }
520
521 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
522 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600523 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
524 if (features2) {
525 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
526 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600527 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600528 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
529 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600530 }
531 }
532
533 // Validate pCreateInfo->pQueueCreateInfos
534 if (pCreateInfo->pQueueCreateInfos) {
535 std::unordered_set<uint32_t> set;
536
537 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
538 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
539 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
540 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600541 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600542 "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600543 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700544 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600545 "index value.",
546 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600547 } else if (set.count(requested_queue_family)) {
548 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600549 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600550 "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600551 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600552 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
553 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600554 } else {
555 set.insert(requested_queue_family);
556 }
557
558 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
559 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
560 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
561 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
562 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600563 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600564 "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600565 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600566 "] (=%f) is not between 0 and 1 (inclusive).",
567 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600568 }
569 }
570 }
571 }
572 }
573
574 return skip;
575}
576
577VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
578 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
579 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
580
581 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
582 bool skip = false;
583 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
584 assert(my_instance_data != nullptr);
John Zulauf620755c2018-04-16 11:00:43 -0600585
586 // Query and save physical device limits for this device, needed for validation
587 VkPhysicalDeviceProperties device_properties = {};
588 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
589
John Zulauf1909e6a2018-09-05 11:43:11 -0600590 // Setup the validation tables based on the application API version from the instance and the capabilities of the device driver.
591 uint32_t effective_api_version = std::min(device_properties.apiVersion, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600592 DeviceExtensions extensions;
John Zulauf1909e6a2018-09-05 11:43:11 -0600593 uint32_t api_version = extensions.InitFromDeviceCreateInfo(&my_instance_data->extensions, effective_api_version, pCreateInfo);
John Zulauf620755c2018-04-16 11:00:43 -0600594
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600595 std::unique_lock<std::mutex> lock(global_lock);
596
597 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
598
John Zulauf620755c2018-04-16 11:00:43 -0600599 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo, extensions);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600600
601 if (!skip) {
602 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
603 assert(chain_info != nullptr);
604 assert(chain_info->u.pLayerInfo != nullptr);
605
606 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
607 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
608 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
609 if (fpCreateDevice == NULL) {
610 return VK_ERROR_INITIALIZATION_FAILED;
611 }
612
613 // Advance the link info for the next element on the chain
614 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
615
616 lock.unlock();
617
618 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
619
620 lock.lock();
621
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600622 if (result == VK_SUCCESS) {
623 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
624 assert(my_device_data != nullptr);
625
Mark Young6ba8abe2017-11-09 10:37:04 -0700626 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
John Zulauf9b777302018-10-08 11:15:51 -0600627 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600628
John Zulauf620755c2018-04-16 11:00:43 -0600629 my_device_data->api_version = api_version;
630 my_device_data->extensions = extensions;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600631
632 // Store createdevice data
633 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
634 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
635 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
636 pCreateInfo->pQueueCreateInfos[i].queueCount));
637 }
638 }
639
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600640 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
641 my_device_data->physical_device = physicalDevice;
642 my_device_data->device = *pDevice;
643
Jeff Bolz5d2b7432018-09-06 10:32:36 -0500644 if (my_device_data->extensions.vk_nv_shading_rate_image) {
645 // Get the needed shading rate image limits
646 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
647 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
648 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
649 my_device_data->phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
650 }
651
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500652 if (my_device_data->extensions.vk_nv_mesh_shader) {
653 // Get the needed mesh shader limits
654 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
655 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
656 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
657 my_device_data->phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
658 }
659
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600660 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600661 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
662 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
663 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600664 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
665 if (features2) {
666 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600667 }
668 }
669 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700670 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600671 } else {
672 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
673 }
674 }
675 }
676
677 return result;
678}
679
680VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
681 dispatch_key key = get_dispatch_key(device);
682 bool skip = false;
683 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
684 {
685 std::unique_lock<std::mutex> lock(global_lock);
686 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
687 }
688
689 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700690 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600691 device_data->dispatch_table.DestroyDevice(device, pAllocator);
692 }
693 FreeLayerDataPtr(key, layer_data_map);
694}
695
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600696bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
697 bool skip = false;
698 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
699
Dave Houlton413a6782018-05-22 13:01:54 -0600700 skip |= ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex",
701 "VUID-vkGetDeviceQueue-queueFamilyIndex-00384");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600702 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
703 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
704 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600705 HandleToUint64(device), "VUID-vkGetDeviceQueue-queueIndex-00385",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600706 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700707 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600708 ") when the device was created (i.e. is not less than %" PRIu32 ").",
709 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600710 }
711 return skip;
712}
713
714VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
715 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
716 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
717 bool skip = false;
718 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
719 std::unique_lock<std::mutex> lock(global_lock);
720
721 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
Dave Houlton341c0052018-06-21 15:00:45 -0600722 "pCreateInfo->queueFamilyIndex", "VUID-vkCreateCommandPool-queueFamilyIndex-01937");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600723
724 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
725
726 lock.unlock();
727 if (!skip) {
728 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
729 }
730 return result;
731}
732
733VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
734 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
735 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
736 bool skip = false;
737 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
738
739 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
740
741 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
742 if (pCreateInfo != nullptr) {
743 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
744 // VkQueryPipelineStatisticFlagBits values
745 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
746 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
747 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600748 "VUID-VkQueryPoolCreateInfo-queryType-00792",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700749 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
750 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600751 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600752 }
753 }
754 if (!skip) {
755 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
756 }
757 return result;
758}
759
Petr Krause91f7a12017-12-14 20:57:36 +0100760VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
761 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
762 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
763 bool skip = false;
764 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
765
766 {
767 std::unique_lock<std::mutex> lock(global_lock);
768 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
769
Dave Houltonb3bbec72018-01-17 10:13:33 -0700770 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
771 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100772 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
773 if (custom_func != nullptr) {
774 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
775 }
776 }
777
778 if (!skip) {
779 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
780
781 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
782 if (result == VK_SUCCESS) {
783 std::unique_lock<std::mutex> lock(global_lock);
784 const auto renderPass = *pRenderPass;
785 auto &renderpass_state = device_data->renderpasses_states[renderPass];
786
787 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
788 bool uses_color = false;
789 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
790 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
791
792 bool uses_depthstencil = false;
793 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
794 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
795 uses_depthstencil = true;
796
797 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
798 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
799 }
800 }
801 }
802 return result;
803}
804
805VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
806 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
807 bool skip = false;
808
809 {
810 std::unique_lock<std::mutex> lock(global_lock);
811 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
812
Dave Houltonb3bbec72018-01-17 10:13:33 -0700813 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
814 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100815 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
816 if (custom_func != nullptr) {
817 skip |= custom_func(device, renderPass, pAllocator);
818 }
819 }
820
821 if (!skip) {
822 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
823
824 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
825 {
826 std::unique_lock<std::mutex> lock(global_lock);
827 device_data->renderpasses_states.erase(renderPass);
828 }
829 }
830}
831
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600832bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
833 VkBuffer *pBuffer) {
834 bool skip = false;
835 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
836 debug_report_data *report_data = device_data->report_data;
837
Mark Lobodzinski88529492018-04-01 10:38:15 -0600838 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100839
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600840 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600841 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600842
843 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
844 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
845 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
846 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600847 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600848 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600849 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600850 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600851 }
852
853 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
854 // queueFamilyIndexCount uint32_t values
855 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600856 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600857 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600858 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
859 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600860 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600861 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600862 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -0600863 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
864 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600865 }
866 }
867
868 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
869 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
870 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
871 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600872 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600873 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600874 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600875 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600876 }
877 }
878
879 return skip;
880}
881
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600882bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
883 VkImage *pImage) {
884 bool skip = false;
885 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
886 debug_report_data *report_data = device_data->report_data;
887
Mark Lobodzinski88529492018-04-01 10:38:15 -0600888 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100889
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600890 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600891 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
892 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
893 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
894 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600895 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600896 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600897 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600898 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600899 }
900
901 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
902 // queueFamilyIndexCount uint32_t values
903 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600904 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600905 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600906 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
907 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600908 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600909 } else {
Dave Houlton413a6782018-05-22 13:01:54 -0600910 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
911 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
912 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600913 }
914 }
915
Dave Houlton413a6782018-05-22 13:01:54 -0600916 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
917 "VUID-VkImageCreateInfo-extent-00944", log_misc);
918 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
919 "VUID-VkImageCreateInfo-extent-00945", log_misc);
920 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
921 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600922
Dave Houlton413a6782018-05-22 13:01:54 -0600923 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
924 log_misc);
925 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
926 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600927
Dave Houlton130c0212018-01-29 13:39:56 -0700928 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700929 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
930 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
931 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600932 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
933 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600934 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
935 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700936 }
937
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600938 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100939 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
940 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600941 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600942 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700943 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600944 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600945 }
946
947 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100948 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
949 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600950 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600951 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600952 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
953 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
954 ") are not equal.",
955 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100956 }
957
958 if (pCreateInfo->arrayLayers < 6) {
959 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600960 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +0100961 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600962 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
963 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100964 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600965 }
966
967 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600968 skip |=
969 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600970 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600971 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600972 }
973 }
974
Dave Houlton130c0212018-01-29 13:39:56 -0700975 // 3D image may have only 1 layer
976 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600977 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600978 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600979 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700980 }
981
982 // If multi-sample, validate type, usage, tiling and mip levels.
983 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
984 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600985 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600986 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600987 "VUID-VkImageCreateInfo-samples-02257",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600988 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700989 }
990
991 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
992 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
993 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
994 // At least one of the legal attachment bits must be set
995 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600996 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600997 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600998 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700999 }
1000 // No flags other than the legal attachment bits may be set
1001 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1002 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001003 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001004 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001005 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001006 }
1007 }
1008
Jeff Bolzef40fec2018-09-01 22:04:34 -05001009 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001010 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001011 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -06001012 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
1013 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001014 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -06001015 skip |=
1016 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1017 "VUID-VkImageCreateInfo-mipLevels-00958",
1018 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
1019 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001020 }
1021
Mark Lobodzinski69259c52018-09-18 15:14:58 -06001022 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
1023 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
1024 "VUID-VkImageCreateInfo-flags-00950",
1025 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
1026 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
1027 }
1028
Petr Krausb6f97802018-03-13 12:31:39 +01001029 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
1030 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001031 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +01001032 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001033 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +01001034 }
1035
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001036 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
1037 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
1038 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
1039 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001040 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001041 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001042 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001043 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001044 }
1045
1046 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
1047 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
1048 // Linear tiling is unsupported
1049 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -06001050 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1051 kVUID_PVError_InvalidUsage,
1052 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
1053 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001054 }
1055
1056 // Sparse 1D image isn't valid
1057 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001058 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001059 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001060 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001061 }
1062
1063 // Sparse 2D image when device doesn't support it
1064 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1065 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001066 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001067 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001068 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001069 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001070 }
1071
1072 // Sparse 3D image when device doesn't support it
1073 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1074 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001075 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001076 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001077 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001078 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001079 }
1080
1081 // Multi-sample 2D image when device doesn't support it
1082 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1083 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1084 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001085 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001086 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001087 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001088 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001089 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1090 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001091 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001092 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001093 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001094 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001095 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1096 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001097 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001098 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001099 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001100 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001101 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1102 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001103 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001104 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001105 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001106 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001107 }
1108 }
1109 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001110
Jeff Bolz9af91c52018-09-01 21:53:57 -05001111 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
1112 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1113 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1114 "VUID-VkImageCreateInfo-imageType-02082",
1115 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1116 "imageType must be VK_IMAGE_TYPE_2D.");
1117 }
1118 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1119 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1120 "VUID-VkImageCreateInfo-samples-02083",
1121 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1122 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1123 }
1124 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1125 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1126 "VUID-VkImageCreateInfo-tiling-02084",
1127 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1128 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1129 }
1130 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001131
1132 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001133 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001134 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1135 "VUID-VkImageCreateInfo-flags-02050",
1136 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1137 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
1138 }
1139
Dave Houlton142c4cb2018-10-17 15:04:41 -06001140 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001141 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1142 "VUID-VkImageCreateInfo-flags-02051",
1143 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1144 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
1145 "not be a depth/stencil format.");
1146 }
1147
Dave Houlton142c4cb2018-10-17 15:04:41 -06001148 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001149 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1150 "VUID-VkImageCreateInfo-flags-02052",
1151 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1152 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
1153 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001154 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001155 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001156 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1157 "VUID-VkImageCreateInfo-flags-02053",
1158 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1159 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
1160 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -05001161 }
1162 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001163 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001164
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001165 return skip;
1166}
1167
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001168bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1169 VkImageView *pView) {
1170 bool skip = false;
1171 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1172 debug_report_data *report_data = device_data->report_data;
1173
1174 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -06001175 // Validate chained VkImageViewUsageCreateInfo struct, if present
1176 if (nullptr != pCreateInfo->pNext) {
1177 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1178 if (chained_ivuci_struct) {
1179 if (0 == chained_ivuci_struct->usage) {
1180 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001181 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -06001182 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001183 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1184 std::stringstream ss;
1185 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1186 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1187 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001188 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -06001189 }
1190 }
1191 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001192 }
1193 return skip;
1194}
1195
Petr Krausb3fcdb42018-01-09 22:09:09 +01001196bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1197 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1198 bool skip = false;
1199 debug_report_data *report_data = device_data->report_data;
1200
1201 // Note: for numerical correctness
1202 // - float comparisons should expect NaN (comparison always false).
1203 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1204
1205 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001206 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001207 if (v1_f <= 0.0f) return true;
1208
1209 float intpart;
1210 const float fract = modff(v1_f, &intpart);
1211
1212 assert(std::numeric_limits<float>::radix == 2);
1213 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1214 if (intpart >= u32_max_plus1) return false;
1215
1216 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1217 if (v1_u32 < v2_u32)
1218 return true;
1219 else if (v1_u32 == v2_u32 && fract == 0.0f)
1220 return true;
1221 else
1222 return false;
1223 };
1224
1225 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1226 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1227 return (v1_f <= v2_f);
1228 };
1229
1230 // width
1231 bool width_healthy = true;
1232 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1233
1234 if (!(viewport.width > 0.0f)) {
1235 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001236 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001237 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001238 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1239 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001240 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001241 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1242 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001243 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001244 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001245 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001246 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1247 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001248 }
1249
1250 // height
1251 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001252 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1253 device_data->extensions.vk_khr_maintenance1 ||
1254 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001255 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1256
1257 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1258 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001259 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001260 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001261 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1262 height_healthy = false;
1263
Dave Houlton413a6782018-05-22 13:01:54 -06001264 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001265 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1266 ").",
1267 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001268 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1269 height_healthy = false;
1270
1271 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001272 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001273 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001274 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1275 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001276 }
1277
1278 // x
1279 bool x_healthy = true;
1280 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1281 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001282 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001283 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1284 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001285 }
1286
1287 // x + width
1288 if (x_healthy && width_healthy) {
1289 const float right_bound = viewport.x + viewport.width;
1290 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001291 skip |=
Dave Houlton413a6782018-05-22 13:01:54 -06001292 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001293 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1294 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1295 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001296 }
1297 }
1298
1299 // y
1300 bool y_healthy = true;
1301 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1302 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001303 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001304 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1305 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001306 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1307 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001308 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001309 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1310 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001311 }
1312
1313 // y + height
1314 if (y_healthy && height_healthy) {
1315 const float boundary = viewport.y + viewport.height;
1316
1317 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -06001318 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001319 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1320 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1321 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001322 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1323 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001324 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001325 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1326 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001327 }
1328 }
1329
1330 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1331 // minDepth
1332 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001333 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001334
Petr Krausb3fcdb42018-01-09 22:09:09 +01001335 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001336 "[0.0, 1.0] range.",
1337 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001338 }
1339
1340 // maxDepth
1341 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001342 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001343
Petr Krausb3fcdb42018-01-09 22:09:09 +01001344 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001345 "[0.0, 1.0] range.",
1346 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001347 }
1348 }
1349
1350 return skip;
1351}
1352
Dave Houlton142c4cb2018-10-17 15:04:41 -06001353struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001354 VkShadingRatePaletteEntryNV shadingRate;
1355 uint32_t width;
1356 uint32_t height;
1357};
1358
1359// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -06001360static SampleOrderInfo sampleOrderInfos[] = {
1361 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1362 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1363 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1364 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1365 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1366 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001367};
1368
Dave Houlton142c4cb2018-10-17 15:04:41 -06001369bool ValidateCoarseSampleOrderCustomNV(layer_data *device_data, const VkCoarseSampleOrderCustomNV *order) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001370 bool skip = false;
1371 debug_report_data *report_data = device_data->report_data;
1372
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001373 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001374 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001375 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001376 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001377 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001378 break;
1379 }
1380 }
1381
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001382 if (sampleOrderInfo == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001383 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1384 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1385 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1386 "that generates fragments with more than one pixel.");
1387 return skip;
1388 }
1389
Dave Houlton142c4cb2018-10-17 15:04:41 -06001390 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Jeff Bolz9af91c52018-09-01 21:53:57 -05001391 !(order->sampleCount & device_data->device_limits.framebufferNoAttachmentsSampleCounts)) {
1392 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1393 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001394 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1395 ") must "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001396 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1397 "is set in framebufferNoAttachmentsSampleCounts.",
1398 order->sampleCount);
1399 }
1400
Jeff Bolz9af91c52018-09-01 21:53:57 -05001401 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
1402 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1403 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001404 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1405 ") must "
1406 "be equal to the product of sampleCount (=%" PRIu32
1407 "), the fragment width for shadingRate "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001408 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1409 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
1410 }
1411
Jeff Bolz5d2b7432018-09-06 10:32:36 -05001412 if (order->sampleLocationCount > device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001413 skip |= log_msg(
1414 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1415 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
1416 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1417 ") must "
1418 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
1419 order->sampleLocationCount, device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001420 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001421
1422 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001423 // the first width*height*sampleCount bits to all be set. Note: There is no
1424 // guarantee that 64 bits is enough, but practically it's unlikely for an
1425 // implementation to support more than 32 bits for samplemask.
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001426 assert(device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001427 uint64_t sampleLocationsMask = 0;
1428 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1429 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1430 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
1431 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1432 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1433 "pixelX must be less than the width (in pixels) of the fragment.");
1434 }
1435 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
1436 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1437 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1438 "pixelY must be less than the height (in pixels) of the fragment.");
1439 }
1440 if (sampleLoc->sample >= order->sampleCount) {
1441 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1442 "VUID-VkCoarseSampleLocationNV-sample-02080",
1443 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
1444 }
1445 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1446 sampleLocationsMask |= 1ULL << idx;
1447 }
1448
1449 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1450 if (sampleLocationsMask != expectedMask) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001451 skip |= log_msg(
1452 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1453 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
1454 "The array pSampleLocations must contain exactly one entry for "
1455 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001456 }
1457
1458 return skip;
1459}
1460
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001461bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1462 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1463 VkPipeline *pPipelines) {
1464 bool skip = false;
1465 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1466 debug_report_data *report_data = device_data->report_data;
1467
1468 if (pCreateInfos != nullptr) {
1469 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001470 bool has_dynamic_viewport = false;
1471 bool has_dynamic_scissor = false;
1472 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001473 bool has_dynamic_viewport_w_scaling_nv = false;
1474 bool has_dynamic_discard_rectangle_ext = false;
1475 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001476 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001477 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001478 if (pCreateInfos[i].pDynamicState != nullptr) {
1479 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1480 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1481 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1482 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1483 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1484 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001485 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1486 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1487 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001488 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Dave Houlton142c4cb2018-10-17 15:04:41 -06001489 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV)
1490 has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001491 }
1492 }
1493
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001494 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1495 if (pCreateInfos[i].pVertexInputState != nullptr) {
1496 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001497
1498 if (vertex_input_state->vertexBindingDescriptionCount > device_data->device_limits.maxVertexInputBindings) {
1499 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1500 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1501 "vkCreateGraphicsPipelines: pararameter "
1502 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1503 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1504 i, vertex_input_state->vertexBindingDescriptionCount,
1505 device_data->device_limits.maxVertexInputBindings);
1506 }
1507
1508 if (vertex_input_state->vertexAttributeDescriptionCount > device_data->device_limits.maxVertexInputAttributes) {
1509 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1510 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1511 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +02001512 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +02001513 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1514 i, vertex_input_state->vertexBindingDescriptionCount,
1515 device_data->device_limits.maxVertexInputAttributes);
1516 }
1517
1518 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001519 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1520 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001521 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1522 if (binding_it != vertex_bindings.cend()) {
1523 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1524 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1525 "vkCreateGraphicsPipelines: parameter "
1526 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1527 "(%" PRIu32 ") is not distinct.",
1528 i, d, vertex_bind_desc.binding);
1529 }
1530 vertex_bindings.insert(vertex_bind_desc.binding);
1531
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001532 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1533 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001534 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001535 "vkCreateGraphicsPipelines: parameter "
1536 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001537 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1538 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001539 }
1540
1541 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1542 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001543 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001544 "vkCreateGraphicsPipelines: parameter "
1545 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001546 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1547 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001548 }
1549 }
1550
Peter Kohautc7d9d392018-07-15 00:34:07 +02001551 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001552 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1553 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001554 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1555 if (location_it != attribute_locations.cend()) {
1556 skip |= log_msg(
1557 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1558 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
1559 "vkCreateGraphicsPipelines: parameter "
1560 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1561 i, d, vertex_attrib_desc.location);
1562 }
1563 attribute_locations.insert(vertex_attrib_desc.location);
1564
1565 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1566 if (binding_it == vertex_bindings.cend()) {
1567 skip |= log_msg(
1568 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1569 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
1570 "vkCreateGraphicsPipelines: parameter "
1571 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1572 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1573 i, d, vertex_attrib_desc.binding, i);
1574 }
1575
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001576 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1577 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001578 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001579 "vkCreateGraphicsPipelines: parameter "
1580 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001581 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1582 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001583 }
1584
1585 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1586 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001587 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001588 "vkCreateGraphicsPipelines: parameter "
1589 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001590 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1591 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001592 }
1593
1594 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001595 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001596 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001597 "vkCreateGraphicsPipelines: parameter "
1598 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1599 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1600 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001601 }
1602 }
1603 }
1604
1605 if (pCreateInfos[i].pStages != nullptr) {
1606 bool has_control = false;
1607 bool has_eval = false;
1608
1609 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1610 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1611 has_control = true;
1612 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1613 has_eval = true;
1614 }
1615 }
1616
1617 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1618 if (has_control && has_eval) {
1619 if (pCreateInfos[i].pTessellationState == nullptr) {
1620 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001621 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001622 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1623 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001624 "pCreateInfos[%d].pTessellationState must not be NULL.",
1625 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001626 } else {
1627 skip |= validate_struct_pnext(
1628 report_data, "vkCreateGraphicsPipelines",
1629 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001630 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion,
1631 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001632
1633 skip |= validate_reserved_flags(
1634 report_data, "vkCreateGraphicsPipelines",
1635 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001636 pCreateInfos[i].pTessellationState->flags,
1637 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001638
1639 if (pCreateInfos[i].pTessellationState->sType !=
1640 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1641 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001642 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001643 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001644 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1645 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001646 }
1647
1648 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1649 pCreateInfos[i].pTessellationState->patchControlPoints >
1650 device_data->device_limits.maxTessellationPatchSize) {
1651 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001652 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001653 "vkCreateGraphicsPipelines: invalid parameter "
1654 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001655 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001656 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001657 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001658 }
1659 }
1660 }
1661 }
1662
1663 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1664 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1665 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1666 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001667 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001668 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001669 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1670 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001671 "].pViewportState (=NULL) is not a valid pointer.",
1672 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001673 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001674 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1675
1676 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1677 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001678 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001679 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001680 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1681 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001682 }
1683
Petr Krausa6103552017-11-16 21:21:58 +01001684 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1685 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001686 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1687 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001688 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1689 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001690 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001691 skip |= validate_struct_pnext(
1692 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001693 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001694 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001695 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1696 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001697 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001698 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1699 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001700
1701 skip |= validate_reserved_flags(
1702 report_data, "vkCreateGraphicsPipelines",
1703 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001704 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001705
Dave Houlton142c4cb2018-10-17 15:04:41 -06001706 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1707 pCreateInfos[i].pViewportState->pNext);
1708 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1709 pCreateInfos[i].pViewportState->pNext);
1710 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1711 pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001712
Petr Krausa6103552017-11-16 21:21:58 +01001713 if (!device_data->physical_device_features.multiViewport) {
1714 if (viewport_state.viewportCount != 1) {
1715 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001716 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001717 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1718 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001719 ") is not 1.",
1720 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001721 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001722
Petr Krausa6103552017-11-16 21:21:58 +01001723 if (viewport_state.scissorCount != 1) {
1724 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001725 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001726 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1727 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001728 ") is not 1.",
1729 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001730 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001731
Dave Houlton142c4cb2018-10-17 15:04:41 -06001732 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1733 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1734 skip |=
1735 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1736 VK_NULL_HANDLE,
1737 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1738 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1739 "disabled, but pCreateInfos[%" PRIu32
1740 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1741 ") is not 1.",
1742 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001743 }
1744
Jeff Bolz9af91c52018-09-01 21:53:57 -05001745 if (shading_rate_image_struct &&
1746 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1747 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton142c4cb2018-10-17 15:04:41 -06001748 VK_NULL_HANDLE,
1749 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001750 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Dave Houlton142c4cb2018-10-17 15:04:41 -06001751 "disabled, but pCreateInfos[%" PRIu32
1752 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001753 ") is neither 0 nor 1.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001754 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001755 }
1756
Petr Krausa6103552017-11-16 21:21:58 +01001757 } else { // multiViewport enabled
1758 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001759 skip |= log_msg(
1760 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001761 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001762 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001763 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1764 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001765 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001766 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1767 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001768 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1769 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001770 }
Petr Krausa6103552017-11-16 21:21:58 +01001771
1772 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001773 skip |= log_msg(
1774 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001775 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001776 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001777 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1778 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001779 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001780 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1781 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001782 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1783 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001784 }
1785 }
1786
Jeff Bolz3e71f782018-08-29 23:15:45 -05001787 if (exclusive_scissor_struct &&
1788 exclusive_scissor_struct->exclusiveScissorCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001789 skip |= log_msg(
1790 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1791 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1792 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1793 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1794 i, exclusive_scissor_struct->exclusiveScissorCount, device_data->device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001795 }
1796
Jeff Bolz9af91c52018-09-01 21:53:57 -05001797 if (shading_rate_image_struct &&
1798 shading_rate_image_struct->viewportCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001799 skip |=
1800 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1801 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1802 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1803 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1804 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1805 i, shading_rate_image_struct->viewportCount, device_data->device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001806 }
1807
Petr Krausa6103552017-11-16 21:21:58 +01001808 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001809 skip |=
1810 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001811 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001812 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1813 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1814 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001815 }
1816
Dave Houlton142c4cb2018-10-17 15:04:41 -06001817 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001818 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001819 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1820 VK_NULL_HANDLE,
1821 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1822 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1823 ") must be zero or identical to pCreateInfos[%" PRIu32
1824 "].pViewportState->viewportCount (=%" PRIu32 ").",
1825 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001826 }
1827
Dave Houlton142c4cb2018-10-17 15:04:41 -06001828 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001829 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001830 skip |= log_msg(
1831 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1832 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1833 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1834 "] "
1835 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1836 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1837 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001838 }
1839
Petr Krausa6103552017-11-16 21:21:58 +01001840 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1841 skip |= log_msg(
1842 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001843 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001844 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1845 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001846 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1847 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001848 }
1849
1850 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1851 skip |= log_msg(
1852 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001853 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001854 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1855 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001856 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1857 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001858 }
1859
Jeff Bolz3e71f782018-08-29 23:15:45 -05001860 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001861 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1862 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1863 skip |=
1864 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1865 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1866 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1867 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1868 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1869 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001870 }
1871
Jeff Bolz9af91c52018-09-01 21:53:57 -05001872 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001873 shading_rate_image_struct->viewportCount > 0 &&
1874 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001875 skip |= log_msg(
1876 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1877 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1878 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001879 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1880 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001881 i, i);
1882 }
1883
Petr Krausb3fcdb42018-01-09 22:09:09 +01001884 // validate the VkViewports
1885 if (!has_dynamic_viewport && viewport_state.pViewports) {
1886 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1887 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1888 const char fn_name[] = "vkCreateGraphicsPipelines";
1889 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1890 std::to_string(viewport_i) + "]";
1891 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1892 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1893 }
1894 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001895
1896 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1897 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001898 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001899 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001900 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001901 "VK_NV_clip_space_w_scaling extension is not enabled.",
1902 i);
1903 }
1904
1905 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1906 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001907 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001908 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001909 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001910 "VK_EXT_discard_rectangles extension is not enabled.",
1911 i);
1912 }
1913
1914 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1915 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001916 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001917 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001918 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001919 "VK_EXT_sample_locations extension is not enabled.",
1920 i);
1921 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001922
1923 if (has_dynamic_exclusive_scissor_nv && !device_data->extensions.vk_nv_scissor_exclusive) {
1924 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1925 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1926 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1927 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1928 "VK_NV_scissor_exclusive extension is not enabled.",
1929 i);
1930 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001931
1932 if (coarse_sample_order_struct &&
1933 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1934 coarse_sample_order_struct->customSampleOrderCount != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001935 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1936 VK_NULL_HANDLE,
1937 "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1938 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1939 "] "
1940 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1941 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1942 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001943 }
1944
1945 if (coarse_sample_order_struct) {
1946 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001947 skip |= ValidateCoarseSampleOrderCustomNV(device_data,
1948 &coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001949 }
1950 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001951 }
1952
1953 if (pCreateInfos[i].pMultisampleState == nullptr) {
1954 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001955 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001956 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001957 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1958 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001959 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001960 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1961 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1962 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001963 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001964 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001965 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001966 skip |= validate_struct_pnext(
1967 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001968 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1969 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001970 "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001971
1972 skip |= validate_reserved_flags(
1973 report_data, "vkCreateGraphicsPipelines",
1974 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001975 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001976
1977 skip |= validate_bool32(
1978 report_data, "vkCreateGraphicsPipelines",
1979 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1980 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1981
1982 skip |= validate_array(
1983 report_data, "vkCreateGraphicsPipelines",
1984 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1985 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001986 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001987 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001988
1989 skip |= validate_bool32(
1990 report_data, "vkCreateGraphicsPipelines",
1991 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1992 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1993
1994 skip |= validate_bool32(
1995 report_data, "vkCreateGraphicsPipelines",
1996 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1997 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1998
1999 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
2000 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002001 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002002 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2003 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2004 i);
2005 }
John Zulauf7acac592017-11-06 11:15:53 -07002006 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
2007 if (!device_data->physical_device_features.sampleRateShading) {
2008 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002009 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07002010 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002011 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2012 i);
John Zulauf7acac592017-11-06 11:15:53 -07002013 }
2014 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2015 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2016 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
2017 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002018 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002019 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002020 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002021 }
2022 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002023 }
2024
Petr Krause91f7a12017-12-14 20:57:36 +01002025 bool uses_color_attachment = false;
2026 bool uses_depthstencil_attachment = false;
2027 {
2028 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
2029 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
2030 const auto &subpasses_uses = subpasses_uses_it->second;
2031 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2032 uses_color_attachment = true;
2033 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2034 uses_depthstencil_attachment = true;
2035 }
2036 }
2037
2038 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002039 skip |= validate_struct_pnext(
2040 report_data, "vkCreateGraphicsPipelines",
2041 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002042 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion,
2043 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002044
2045 skip |= validate_reserved_flags(
2046 report_data, "vkCreateGraphicsPipelines",
2047 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002048 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002049
2050 skip |= validate_bool32(
2051 report_data, "vkCreateGraphicsPipelines",
2052 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2053 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2054
2055 skip |= validate_bool32(
2056 report_data, "vkCreateGraphicsPipelines",
2057 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2058 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2059
2060 skip |= validate_ranged_enum(
2061 report_data, "vkCreateGraphicsPipelines",
2062 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2063 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002064 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002065
2066 skip |= validate_bool32(
2067 report_data, "vkCreateGraphicsPipelines",
2068 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2069 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2070
2071 skip |= validate_bool32(
2072 report_data, "vkCreateGraphicsPipelines",
2073 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2074 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2075
2076 skip |= validate_ranged_enum(
2077 report_data, "vkCreateGraphicsPipelines",
2078 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2079 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002080 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002081
2082 skip |= validate_ranged_enum(
2083 report_data, "vkCreateGraphicsPipelines",
2084 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2085 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002086 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002087
2088 skip |= validate_ranged_enum(
2089 report_data, "vkCreateGraphicsPipelines",
2090 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2091 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002092 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002093
2094 skip |= validate_ranged_enum(
2095 report_data, "vkCreateGraphicsPipelines",
2096 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2097 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002098 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002099
2100 skip |= validate_ranged_enum(
2101 report_data, "vkCreateGraphicsPipelines",
2102 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2103 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002104 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002105
2106 skip |= validate_ranged_enum(
2107 report_data, "vkCreateGraphicsPipelines",
2108 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2109 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002110 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002111
2112 skip |= validate_ranged_enum(
2113 report_data, "vkCreateGraphicsPipelines",
2114 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2115 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002116 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002117
2118 skip |= validate_ranged_enum(
2119 report_data, "vkCreateGraphicsPipelines",
2120 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2121 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002122 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002123
2124 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
2125 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002126 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002127 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2128 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2129 i);
2130 }
2131 }
2132
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002133 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2134 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2135
Petr Krause91f7a12017-12-14 20:57:36 +01002136 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002137 skip |= validate_struct_pnext(
2138 report_data, "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002139 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2140 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2141 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
2142 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06002143 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002144
2145 skip |= validate_reserved_flags(
2146 report_data, "vkCreateGraphicsPipelines",
2147 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002148 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002149
2150 skip |= validate_bool32(
2151 report_data, "vkCreateGraphicsPipelines",
2152 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2153 pCreateInfos[i].pColorBlendState->logicOpEnable);
2154
2155 skip |= validate_array(
2156 report_data, "vkCreateGraphicsPipelines",
2157 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2158 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002159 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002160 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002161
2162 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2163 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2164 ++attachmentIndex) {
2165 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
2166 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2167 ParameterName::IndexVector{i, attachmentIndex}),
2168 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2169
2170 skip |= validate_ranged_enum(
2171 report_data, "vkCreateGraphicsPipelines",
2172 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2173 ParameterName::IndexVector{i, attachmentIndex}),
2174 "VkBlendFactor", AllVkBlendFactorEnums,
2175 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002176 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002177
2178 skip |= validate_ranged_enum(
2179 report_data, "vkCreateGraphicsPipelines",
2180 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2181 ParameterName::IndexVector{i, attachmentIndex}),
2182 "VkBlendFactor", AllVkBlendFactorEnums,
2183 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002184 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002185
2186 skip |= validate_ranged_enum(
2187 report_data, "vkCreateGraphicsPipelines",
2188 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2189 ParameterName::IndexVector{i, attachmentIndex}),
2190 "VkBlendOp", AllVkBlendOpEnums,
2191 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002192 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002193
2194 skip |= validate_ranged_enum(
2195 report_data, "vkCreateGraphicsPipelines",
2196 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2197 ParameterName::IndexVector{i, attachmentIndex}),
2198 "VkBlendFactor", AllVkBlendFactorEnums,
2199 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002200 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002201
2202 skip |= validate_ranged_enum(
2203 report_data, "vkCreateGraphicsPipelines",
2204 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2205 ParameterName::IndexVector{i, attachmentIndex}),
2206 "VkBlendFactor", AllVkBlendFactorEnums,
2207 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002208 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002209
2210 skip |= validate_ranged_enum(
2211 report_data, "vkCreateGraphicsPipelines",
2212 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2213 ParameterName::IndexVector{i, attachmentIndex}),
2214 "VkBlendOp", AllVkBlendOpEnums,
2215 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002216 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002217
2218 skip |=
2219 validate_flags(report_data, "vkCreateGraphicsPipelines",
2220 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2221 ParameterName::IndexVector{i, attachmentIndex}),
2222 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2223 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002224 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002225 }
2226 }
2227
2228 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
2229 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002230 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002231 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2232 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2233 i);
2234 }
2235
2236 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2237 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2238 skip |= validate_ranged_enum(
2239 report_data, "vkCreateGraphicsPipelines",
2240 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002241 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2242 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002243 }
2244 }
2245 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002246
Petr Kraus9752aae2017-11-24 03:05:50 +01002247 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2248 if (pCreateInfos[i].basePipelineIndex != -1) {
2249 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002250 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002251 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002252 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2253 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002254 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002255 }
2256 }
2257
Petr Kraus9752aae2017-11-24 03:05:50 +01002258 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2259 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002260 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002261 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002262 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2263 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002264 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002265 }
2266 }
2267 }
2268
Petr Kraus9752aae2017-11-24 03:05:50 +01002269 if (pCreateInfos[i].pRasterizationState) {
2270 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002271 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002272 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002273 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002274 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2275 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2276 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002277 }
Petr Kraus299ba622017-11-24 03:09:03 +01002278
2279 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
2280 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Dave Houlton413a6782018-05-22 13:01:54 -06002281 skip |=
2282 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
2283 0, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2284 "The line width state is static (pCreateInfos[%" PRIu32
2285 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2286 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2287 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2288 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002289 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002290 }
2291
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002292 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
2293 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
2294 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002295 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002296 }
2297 }
2298 }
2299
2300 return skip;
2301}
2302
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002303bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
2304 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
2305 VkPipeline *pPipelines) {
2306 bool skip = false;
2307 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2308
2309 for (uint32_t i = 0; i < createInfoCount; i++) {
2310 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
2311 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002312 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002313 }
2314
2315 return skip;
2316}
2317
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002318bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2319 VkSampler *pSampler) {
2320 bool skip = false;
2321 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2322 debug_report_data *report_data = device_data->report_data;
2323
2324 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06002325 const auto &features = device_data->physical_device_features;
2326 const auto &limits = device_data->device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002327
John Zulauf71968502017-10-26 13:51:15 -06002328 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2329 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002330 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002331 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002332 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06002333 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002334 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002335 }
2336
2337 // Anistropy cannot be enabled in sampler unless enabled as a feature
2338 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002339 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002340 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002341 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2342 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002343 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002344 }
John Zulauf71968502017-10-26 13:51:15 -06002345
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002346 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2347 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2348 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2349 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2350 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2351 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2352 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2353 }
2354 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2355 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2356 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2357 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2358 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2359 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2360 }
2361 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
2362 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2363 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2364 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2365 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2366 pCreateInfo->minLod, pCreateInfo->maxLod);
2367 }
2368 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2369 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2370 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2371 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2372 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2373 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2374 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2375 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2376 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2377 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2378 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2379 }
2380 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002381 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002382 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002383 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002384 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002385 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002386 if (pCreateInfo->compareEnable == VK_TRUE) {
2387 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2388 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2389 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2390 "not both be VK_TRUE.");
2391 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002392 }
2393
2394 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2395 if (pCreateInfo->compareEnable == VK_TRUE) {
Dave Houlton413a6782018-05-22 13:01:54 -06002396 skip |=
2397 validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2398 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002399 }
2400
2401 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2402 // valid VkBorderColor value
2403 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2404 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2405 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2406 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
Dave Houlton413a6782018-05-22 13:01:54 -06002407 AllVkBorderColorEnums, pCreateInfo->borderColor,
2408 "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002409 }
2410
2411 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2412 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
2413 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
2414 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2415 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2416 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002417 skip |=
2418 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2419 "VUID-VkSamplerCreateInfo-addressModeU-01079",
2420 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2421 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002422 }
John Zulauf275805c2017-10-26 15:34:49 -06002423
2424 // Checks for the IMG cubic filtering extension
2425 if (device_data->extensions.vk_img_filter_cubic) {
2426 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2427 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002428 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002429 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002430 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002431 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002432 }
2433 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002434 }
2435
2436 return skip;
2437}
2438
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002439bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2440 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2441 bool skip = false;
2442 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2443 debug_report_data *report_data = device_data->report_data;
2444
2445 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2446 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2447 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2448 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2449 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2450 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2451 // valid VkSampler handles
2452 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2453 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2454 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2455 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2456 ++descriptor_index) {
2457 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2458 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002459 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002460 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002461 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002462 i, descriptor_index);
2463 }
2464 }
2465 }
2466
2467 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2468 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2469 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002470 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002471 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002472 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2473 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002474 "values.",
2475 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002476 }
2477 }
2478 }
2479 }
2480
2481 return skip;
2482}
2483
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002484bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2485 const VkDescriptorSet *pDescriptorSets) {
2486 bool skip = false;
2487 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2488 debug_report_data *report_data = device_data->report_data;
2489
2490 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2491 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2492 // validate_array()
2493 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002494 &pDescriptorSets, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002495 return skip;
2496}
2497
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002498bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2499 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2500 bool skip = false;
2501 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2502 debug_report_data *report_data = device_data->report_data;
2503
2504 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2505 if (pDescriptorWrites != NULL) {
2506 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2507 // descriptorCount must be greater than 0
2508 if (pDescriptorWrites[i].descriptorCount == 0) {
2509 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002510 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002511 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002512 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002513 }
2514
2515 // dstSet must be a valid VkDescriptorSet handle
2516 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2517 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2518 pDescriptorWrites[i].dstSet);
2519
2520 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2521 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2522 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2523 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2524 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2525 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2526 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2527 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2528 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2529 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002530 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002531 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2532 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2533 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002534 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2535 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002536 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2537 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2538 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2539 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2540 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2541 ++descriptor_index) {
2542 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2543 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2544 ParameterName::IndexVector{i, descriptor_index}),
2545 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2546 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2547 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2548 ParameterName::IndexVector{i, descriptor_index}),
2549 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002550 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002551 }
2552 }
2553 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2554 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2555 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2556 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2557 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2558 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2559 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2560 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2561 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002562 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002563 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2564 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2565 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002566 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2567 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002568 } else {
2569 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2570 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2571 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2572 ParameterName::IndexVector{i, descriptorIndex}),
2573 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2574 }
2575 }
2576 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2577 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2578 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2579 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2580 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2581 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002582 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002583 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2584 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002585 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2586 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002587 } else {
2588 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2589 ++descriptor_index) {
2590 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2591 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2592 ParameterName::IndexVector{i, descriptor_index}),
2593 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2594 }
2595 }
2596 }
2597
2598 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2599 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2600 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2601 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2602 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2603 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002604 skip |=
2605 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002606 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2607 "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002608 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2609 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2610 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002611 }
2612 }
2613 }
2614 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2615 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2616 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2617 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2618 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2619 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002620 skip |=
2621 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002622 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2623 "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002624 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2625 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2626 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002627 }
2628 }
2629 }
2630 }
2631 }
2632 }
2633 return skip;
2634}
2635
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002636bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2637 VkRenderPass *pRenderPass) {
2638 bool skip = false;
2639 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2640 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
2641
2642 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2643 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2644 std::stringstream ss;
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002645 ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED. ";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002646 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002647 "VUID-VkAttachmentDescription-format-parameter", "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002648 }
2649 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2650 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
2651 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002652 "VUID-VkAttachmentDescription-finalLayout-00843",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002653 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002654 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2655 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002656 }
2657 }
2658
2659 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2660 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
2661 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002662 "VUID-VkSubpassDescription-colorAttachmentCount-00845",
2663 "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002664 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002665 }
2666 }
2667 return skip;
2668}
2669
2670bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2671 const VkCommandBuffer *pCommandBuffers) {
2672 bool skip = false;
2673 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2674 debug_report_data *report_data = device_data->report_data;
2675
2676 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2677 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2678 // validate_array()
2679 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002680 &pCommandBuffers, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002681 return skip;
2682}
2683
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002684bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2685 bool skip = false;
2686 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2687 debug_report_data *report_data = device_data->report_data;
2688 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2689
2690 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2691 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2692 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2693 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002694 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2695 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002696
2697 if (pBeginInfo->pInheritanceInfo != NULL) {
Dave Houlton413a6782018-05-22 13:01:54 -06002698 skip |= validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2699 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion,
2700 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002701
2702 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2703 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2704
2705 // TODO: This only needs to be validated when the inherited queries feature is enabled
2706 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2707 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2708
2709 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2710 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2711 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002712 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002713 }
2714
2715 if (pInfo != NULL) {
2716 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2717 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002718 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002719 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002720 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002721 }
2722 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2723 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2724 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002725 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002726 }
2727 }
2728
2729 return skip;
2730}
2731
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002732bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2733 const VkViewport *pViewports) {
2734 bool skip = false;
2735 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2736
Petr Krausd55e77c2018-01-09 22:09:25 +01002737 if (!device_data->physical_device_features.multiViewport) {
2738 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002739 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002740 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002741 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2742 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002743 }
2744 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002745 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002746 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002747 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2748 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002749 }
2750 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002751 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002752 if (sum > device_data->device_limits.maxViewports) {
2753 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002754 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002755 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002756 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2757 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002758 }
2759 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002760
2761 if (pViewports) {
2762 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2763 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2764 const char fn_name[] = "vkCmdSetViewport";
2765 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2766 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2767 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2768 }
2769 }
2770
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002771 return skip;
2772}
2773
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002774bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2775 bool skip = false;
2776 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2777 debug_report_data *report_data = device_data->report_data;
2778
Petr Kraus6260f0a2018-02-27 21:15:55 +01002779 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002780 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002781 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002782 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002783 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2784 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002785 }
2786 if (scissorCount > 1) {
2787 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002788 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002789 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2790 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002791 }
2792 } else { // multiViewport enabled
2793 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2794 if (sum > device_data->device_limits.maxViewports) {
2795 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002796 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002797 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002798 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2799 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002800 }
2801 }
2802
Petr Kraus6260f0a2018-02-27 21:15:55 +01002803 if (pScissors) {
2804 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2805 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002806
Petr Kraus6260f0a2018-02-27 21:15:55 +01002807 if (scissor.offset.x < 0) {
2808 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002809 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002810 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2811 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002812 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002813
Petr Kraus6260f0a2018-02-27 21:15:55 +01002814 if (scissor.offset.y < 0) {
2815 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002816 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002817 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2818 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002819 }
2820
2821 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2822 if (x_sum > INT32_MAX) {
2823 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002824 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002825 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002826 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2827 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002828 }
2829
2830 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2831 if (y_sum > INT32_MAX) {
2832 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002833 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002834 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002835 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2836 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002837 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002838 }
2839 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002840
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002841 return skip;
2842}
2843
Petr Kraus299ba622017-11-24 03:09:03 +01002844bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2845 bool skip = false;
2846 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2847 debug_report_data *report_data = device_data->report_data;
2848
2849 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2850 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002851 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002852 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002853 }
2854
2855 return skip;
2856}
2857
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002858bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2859 uint32_t firstInstance) {
2860 bool skip = false;
2861 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2862 if (vertexCount == 0) {
2863 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2864 // this an error or leave as is.
2865 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002866 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002867 }
2868
2869 if (instanceCount == 0) {
2870 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2871 // this an error or leave as is.
2872 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002873 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002874 }
2875 return skip;
2876}
2877
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002878bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2879 bool skip = false;
2880 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2881
2882 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2883 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002884 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002885 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2886 }
2887 return skip;
2888}
2889
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002890bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2891 uint32_t stride) {
2892 bool skip = false;
2893 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2894 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002895 skip |=
2896 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2897 kVUID_PVError_DeviceFeature,
2898 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002899 }
2900 return skip;
2901}
2902
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002903bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2904 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2905 bool skip = false;
2906 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2907
Dave Houltonf5217612018-02-02 16:18:52 -07002908 VkImageAspectFlags legal_aspect_flags =
2909 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2910 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2911 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2912 }
2913
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002914 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002915 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002916 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002917 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002918 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002919 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002920 }
Dave Houltonf5217612018-02-02 16:18:52 -07002921 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002922 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002923 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002924 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002925 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002926 }
2927 }
2928 return skip;
2929}
2930
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002931bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2932 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2933 bool skip = false;
2934 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2935
Dave Houltonf5217612018-02-02 16:18:52 -07002936 VkImageAspectFlags legal_aspect_flags =
2937 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2938 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2939 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2940 }
2941
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002942 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002943 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002944 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002945 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002946 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002947 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2948 }
Dave Houltonf5217612018-02-02 16:18:52 -07002949 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002950 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002951 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002952 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002953 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2954 }
2955 }
2956 return skip;
2957}
2958
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002959bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
2960 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2961 bool skip = false;
2962 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2963
Dave Houltonf5217612018-02-02 16:18:52 -07002964 VkImageAspectFlags legal_aspect_flags =
2965 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2966 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2967 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2968 }
2969
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002970 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002971 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002972 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002973 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002974 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2975 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002976 }
2977 }
2978 return skip;
2979}
2980
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002981bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2982 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2983 bool skip = false;
2984 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2985
Dave Houltonf5217612018-02-02 16:18:52 -07002986 VkImageAspectFlags legal_aspect_flags =
2987 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2988 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2989 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2990 }
2991
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002992 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002993 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002994 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002995 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002996 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2997 "enumerator");
2998 }
2999 }
3000 return skip;
3001}
3002
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003003bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
3004 const void *pData) {
3005 bool skip = false;
3006 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3007
3008 if (dstOffset & 3) {
3009 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003010 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003011 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3012 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003013 }
3014
3015 if ((dataSize <= 0) || (dataSize > 65536)) {
3016 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003017 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003018 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003019 "), must be greater than zero and less than or equal to 65536.",
3020 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003021 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003022 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003023 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003024 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003025 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003026 }
3027 return skip;
3028}
3029
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003030bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
3031 uint32_t data) {
3032 bool skip = false;
3033 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3034
3035 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003036 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003037 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003038 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003039 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003040 }
3041
3042 if (size != VK_WHOLE_SIZE) {
3043 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003044 skip |=
3045 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003046 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003047 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003048 } else if (size & 3) {
3049 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003050 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003051 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003052 }
3053 }
3054 return skip;
3055}
3056
3057VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
3058 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3059}
3060
3061VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3062 VkLayerProperties *pProperties) {
3063 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3064}
3065
3066VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3067 VkExtensionProperties *pProperties) {
3068 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3069 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
3070
3071 return VK_ERROR_LAYER_NOT_PRESENT;
3072}
3073
3074VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
3075 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
3076 // Parameter_validation does not have any physical device extensions
3077 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3078 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
3079
3080 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
Dave Houlton413a6782018-05-22 13:01:54 -06003081 bool skip = validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
3082 pPropertyCount, &pProperties, true, false, false, kVUIDUndefined,
3083 "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003084 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
3085
3086 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
3087}
3088
3089static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
3090 if (!flag) {
3091 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003092 kVUID_PVError_ExtensionNotEnabled,
3093 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
3094 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003095 }
3096
3097 return false;
3098}
3099
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003100bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3101 VkSwapchainKHR *pSwapchain) {
3102 bool skip = false;
3103 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3104 debug_report_data *report_data = device_data->report_data;
3105
Mark Lobodzinski88529492018-04-01 10:38:15 -06003106 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01003107 "vkCreateSwapchainKHR"};
3108
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003109 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003110 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3111 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3112 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3113 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003114 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003115 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003116 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003117 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003118 }
3119
3120 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3121 // queueFamilyIndexCount uint32_t values
3122 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003123 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003124 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003125 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3126 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003127 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003128 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003129 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -06003130 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices",
3131 kVUID_PVError_InvalidUsage, kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003132 }
3133 }
3134
Dave Houlton413a6782018-05-22 13:01:54 -06003135 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
3136 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003137 }
3138
3139 return skip;
3140}
3141
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003142bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
3143 bool skip = false;
3144 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
3145
3146 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003147 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3148 if (present_regions) {
3149 // TODO: This and all other pNext extension dependencies should be added to code-generation
3150 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
3151 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3152 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
3153 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003154 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003155 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3156 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06003157 pPresentInfo->swapchainCount, present_regions->swapchainCount);
3158 }
Dave Houlton413a6782018-05-22 13:01:54 -06003159 skip |=
3160 validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
3161 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
John Zulaufde972ac2017-10-26 12:07:05 -06003162 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003163 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
Dave Houlton413a6782018-05-22 13:01:54 -06003164 true, false, kVUIDUndefined, kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003165 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
3166 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003167 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003168 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003169 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003170 }
3171 }
3172
3173 return skip;
3174}
3175
3176#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003177bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3178 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
3179 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3180 bool skip = false;
3181
3182 if (pCreateInfo->hwnd == nullptr) {
3183 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003184 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3185 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003186 }
3187
3188 return skip;
3189}
3190#endif // VK_USE_PLATFORM_WIN32_KHR
3191
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003192bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
3193 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3194 if (pNameInfo->pObjectName) {
3195 device_data->report_data->debugObjectNameMap->insert(
3196 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
3197 } else {
3198 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
3199 }
3200 return false;
3201}
3202
Petr Krausc8655be2017-09-27 18:56:51 +02003203bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
3204 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
3205 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3206 bool skip = false;
3207
3208 if (pCreateInfo) {
3209 if (pCreateInfo->maxSets <= 0) {
Dave Houlton413a6782018-05-22 13:01:54 -06003210 skip |=
3211 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3212 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3213 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003214 }
3215
3216 if (pCreateInfo->pPoolSizes) {
3217 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3218 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
3219 skip |= log_msg(
3220 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003221 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003222 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003223 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003224 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3225 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003226 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
3227 VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, VK_NULL_HANDLE,
3228 "VUID-VkDescriptorPoolSize-type-02218",
3229 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3230 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3231 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3232 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003233 }
Petr Krausc8655be2017-09-27 18:56:51 +02003234 }
3235 }
3236 }
3237
3238 return skip;
3239}
3240
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003241bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3242 bool skip = false;
3243 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3244
3245 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003246 skip |=
3247 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003248 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003249 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3250 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003251 }
3252
3253 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003254 skip |=
3255 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003256 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003257 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3258 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003259 }
3260
3261 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003262 skip |=
3263 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003264 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003265 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3266 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003267 }
3268
3269 return skip;
3270}
3271
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003272bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003273 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3274 bool skip = false;
3275 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3276
3277 // Paired if {} else if {} tests used to avoid any possible uint underflow
3278 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
3279 if (baseGroupX >= limit) {
3280 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003281 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003282 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003283 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3284 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003285 } else if (groupCountX > (limit - baseGroupX)) {
3286 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003287 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003288 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003289 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3290 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003291 }
3292
3293 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
3294 if (baseGroupY >= limit) {
3295 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003296 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003297 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003298 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3299 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003300 } else if (groupCountY > (limit - baseGroupY)) {
3301 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003302 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003303 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003304 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3305 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003306 }
3307
3308 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
3309 if (baseGroupZ >= limit) {
3310 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003311 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003312 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003313 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3314 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003315 } else if (groupCountZ > (limit - baseGroupZ)) {
3316 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003317 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003318 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003319 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3320 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003321 }
3322
3323 return skip;
3324}
3325
Dave Houlton142c4cb2018-10-17 15:04:41 -06003326bool pv_vkCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer, uint32_t firstExclusiveScissor, uint32_t exclusiveScissorCount,
3327 const VkRect2D *pExclusiveScissors) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003328 bool skip = false;
3329
3330 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3331 debug_report_data *report_data = device_data->report_data;
3332
3333 if (!device_data->physical_device_features.multiViewport) {
3334 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003335 skip |=
3336 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3337 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3338 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3339 ") is not 0.",
3340 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003341 }
3342 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003343 skip |=
3344 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3345 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3346 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3347 ") is not 1.",
3348 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003349 }
3350 } else { // multiViewport enabled
3351 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
3352 if (sum > device_data->device_limits.maxViewports) {
3353 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3354 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003355 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3356 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003357 firstExclusiveScissor, exclusiveScissorCount, sum, device_data->device_limits.maxViewports);
3358 }
3359 }
3360
3361 if (firstExclusiveScissor >= device_data->device_limits.maxViewports) {
3362 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3363 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003364 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32
3365 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003366 firstExclusiveScissor, device_data->device_limits.maxViewports);
3367 }
3368
3369 if (pExclusiveScissors) {
3370 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3371 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3372
3373 if (scissor.offset.x < 0) {
3374 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3375 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003376 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3377 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003378 }
3379
3380 if (scissor.offset.y < 0) {
3381 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3382 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003383 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3384 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003385 }
3386
3387 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3388 if (x_sum > INT32_MAX) {
3389 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3390 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3391 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3392 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3393 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
3394 }
3395
3396 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3397 if (y_sum > INT32_MAX) {
3398 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3399 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3400 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3401 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3402 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
3403 }
3404 }
3405 }
3406
3407 return skip;
3408}
3409
Dave Houlton142c4cb2018-10-17 15:04:41 -06003410bool pv_vkCmdSetViewportShadingRatePaletteNV(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
3411 const VkShadingRatePaletteNV *pShadingRatePalettes) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003412 bool skip = false;
3413
3414 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3415 debug_report_data *report_data = device_data->report_data;
3416
3417 if (!device_data->physical_device_features.multiViewport) {
3418 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003419 skip |=
3420 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3421 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3422 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3423 ") is not 0.",
3424 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003425 }
3426 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003427 skip |=
3428 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3429 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3430 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3431 ") is not 1.",
3432 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003433 }
3434 }
3435
3436 if (firstViewport >= device_data->device_limits.maxViewports) {
3437 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3438 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003439 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3440 ") must be less than maxViewports (=%" PRIu32 ").",
Jeff Bolz9af91c52018-09-01 21:53:57 -05003441 firstViewport, device_data->device_limits.maxViewports);
3442 }
3443
3444 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3445 if (sum > device_data->device_limits.maxViewports) {
3446 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3447 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3448 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3449 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3450 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
3451 }
3452
3453 return skip;
3454}
3455
Dave Houlton142c4cb2018-10-17 15:04:41 -06003456bool pv_vkCmdSetCoarseSampleOrderNV(VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType,
3457 uint32_t customSampleOrderCount, const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003458 bool skip = false;
3459
3460 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3461 debug_report_data *report_data = device_data->report_data;
3462
Dave Houlton142c4cb2018-10-17 15:04:41 -06003463 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003464 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3465 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3466 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3467 "customSampleOrderCount must be 0.");
3468 }
3469
3470 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
3471 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &pCustomSampleOrders[order_i]);
3472 }
3473
3474 return skip;
3475}
3476
Dave Houlton142c4cb2018-10-17 15:04:41 -06003477bool pv_vkCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount, uint32_t firstTask) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003478 bool skip = false;
3479
3480 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3481
3482 if (taskCount > dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003483 skip |= log_msg(
3484 dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3485 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
3486 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3487 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
3488 taskCount, dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003489 }
3490
3491 return skip;
3492}
3493
Dave Houlton142c4cb2018-10-17 15:04:41 -06003494bool pv_vkCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t drawCount,
3495 uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003496 bool skip = false;
3497
3498 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3499 debug_report_data *report_data = dev_data->report_data;
3500
3501 if (offset & 3) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003502 skip |= log_msg(
3503 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3504 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02145",
3505 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003506 }
3507
3508 if (drawCount > 1 && ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
3509 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3510 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3511 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3512 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3513 stride);
3514 }
3515
3516 return skip;
3517}
3518
Dave Houlton142c4cb2018-10-17 15:04:41 -06003519bool pv_vkCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkBuffer countBuffer,
3520 VkDeviceSize countBufferOffset, uint32_t maxDrawCount, uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003521 bool skip = false;
3522
3523 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3524
3525 if (offset & 3) {
3526 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3527 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02180",
3528 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3529 "), is not a multiple of 4.",
3530 offset);
3531 }
3532
3533 if (countBufferOffset & 3) {
3534 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3535 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02181",
3536 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3537 "), is not a multiple of 4.",
3538 countBufferOffset);
3539 }
3540
3541 if ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV)) {
3542 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3543 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-stride-02182",
3544 "vkCmdDrawMeshTasksIndirectCountNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3545 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3546 stride);
3547 }
3548
3549 return skip;
3550}
3551
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003552VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003553 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3554 if (!ApiParentExtensionEnabled(funcName, device_data->extensions.device_extension_set)) {
3555 return nullptr;
3556 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003557 const auto item = name_to_funcptr_map.find(funcName);
3558 if (item != name_to_funcptr_map.end()) {
3559 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3560 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003561 const auto &table = device_data->dispatch_table;
3562 if (!table.GetDeviceProcAddr) return nullptr;
3563 return table.GetDeviceProcAddr(device, funcName);
3564}
3565
3566VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3567 const auto item = name_to_funcptr_map.find(funcName);
3568 if (item != name_to_funcptr_map.end()) {
3569 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3570 }
3571
3572 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3573 auto &table = instance_data->dispatch_table;
3574 if (!table.GetInstanceProcAddr) return nullptr;
3575 return table.GetInstanceProcAddr(instance, funcName);
3576}
3577
3578VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
3579 assert(instance);
3580 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3581
3582 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
3583 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
3584}
3585
3586// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
3587// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02003588void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07003589 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
3590 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
3591 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
3592 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
3593 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
3594 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
3595 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
3596 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
3597 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
3598 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
3599 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
3600 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
3601 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
3602 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01003603 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003604 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
3605 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
3606 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
3607 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
3608 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
3609 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
3610 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
3611 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
3612 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
3613 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
3614 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
3615 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
3616 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003617 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Jeff Bolz3e71f782018-08-29 23:15:45 -05003618 custom_functions["vkCmdSetExclusiveScissorNV"] = (void *)pv_vkCmdSetExclusiveScissorNV;
Jeff Bolz9af91c52018-09-01 21:53:57 -05003619 custom_functions["vkCmdSetViewportShadingRatePaletteNV"] = (void *)pv_vkCmdSetViewportShadingRatePaletteNV;
3620 custom_functions["vkCmdSetCoarseSampleOrderNV"] = (void *)pv_vkCmdSetCoarseSampleOrderNV;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003621 custom_functions["vkCmdDrawMeshTasksNV"] = (void *)pv_vkCmdDrawMeshTasksNV;
3622 custom_functions["vkCmdDrawMeshTasksIndirectNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectNV;
3623 custom_functions["vkCmdDrawMeshTasksIndirectCountNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectCountNV;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003624}
3625
3626} // namespace parameter_validation
3627
3628VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3629 VkExtensionProperties *pProperties) {
3630 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
3631}
3632
3633VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
3634 VkLayerProperties *pProperties) {
3635 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
3636}
3637
3638VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3639 VkLayerProperties *pProperties) {
3640 // the layer command handles VK_NULL_HANDLE just fine internally
3641 assert(physicalDevice == VK_NULL_HANDLE);
3642 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
3643}
3644
3645VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3646 const char *pLayerName, uint32_t *pCount,
3647 VkExtensionProperties *pProperties) {
3648 // the layer command handles VK_NULL_HANDLE just fine internally
3649 assert(physicalDevice == VK_NULL_HANDLE);
3650 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3651}
3652
3653VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3654 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3655}
3656
3657VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3658 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3659}
3660
3661VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3662 const char *funcName) {
3663 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3664}
3665
Lenny Komow2d0cbbe2018-05-24 13:38:05 -06003666VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL VKAPI_CALL
3667vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003668 assert(pVersionStruct != NULL);
3669 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3670
3671 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3672 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3673 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3674 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3675 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3676 }
3677
3678 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3679 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3680 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3681 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3682 }
3683
3684 return VK_SUCCESS;
3685}