blob: 0bd36f6cf32626dbe89730009dbaf88f6d038600 [file] [log] [blame]
sfricke-samsung691299b2021-01-01 20:48:48 -08001/* Copyright (c) 2015-2021 The Khronos Group Inc.
2 * Copyright (c) 2015-2021 Valve Corporation
3 * Copyright (c) 2015-2021 LunarG, Inc.
4 * Copyright (C) 2015-2021 Google Inc.
Tobias Hector6663c9b2020-11-05 10:18:02 +00005 * Modifications Copyright (C) 2020 Advanced Micro Devices, Inc. All rights reserved.
Chris Forbes47567b72017-06-09 12:09:45 -07006 *
7 * Licensed under the Apache License, Version 2.0 (the "License");
8 * you may not use this file except in compliance with the License.
9 * You may obtain a copy of the License at
10 *
11 * http://www.apache.org/licenses/LICENSE-2.0
12 *
13 * Unless required by applicable law or agreed to in writing, software
14 * distributed under the License is distributed on an "AS IS" BASIS,
15 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16 * See the License for the specific language governing permissions and
17 * limitations under the License.
18 *
19 * Author: Chris Forbes <chrisf@ijw.co.nz>
Dave Houlton51653902018-06-22 17:32:13 -060020 * Author: Dave Houlton <daveh@lunarg.com>
Tobias Hector6663c9b2020-11-05 10:18:02 +000021 * Author: Tobias Hector <tobias.hector@amd.com>
Chris Forbes47567b72017-06-09 12:09:45 -070022 */
23
Petr Kraus25810d02019-08-27 17:41:15 +020024#include "shader_validation.h"
25
Chris Forbes47567b72017-06-09 12:09:45 -070026#include <cassert>
Petr Kraus25810d02019-08-27 17:41:15 +020027#include <cinttypes>
Jeff Bolzf234bf82019-11-04 14:07:15 -060028#include <cmath>
Chris Forbes47567b72017-06-09 12:09:45 -070029#include <sstream>
Petr Kraus25810d02019-08-27 17:41:15 +020030#include <string>
Petr Kraus25810d02019-08-27 17:41:15 +020031#include <vector>
32
Mark Lobodzinski102687e2020-04-28 11:03:28 -060033#include <spirv/unified1/spirv.hpp>
Chris Forbes47567b72017-06-09 12:09:45 -070034#include "vk_enum_string_helper.h"
Chris Forbes47567b72017-06-09 12:09:45 -070035#include "vk_layer_data.h"
Chris Forbes47567b72017-06-09 12:09:45 -070036#include "vk_layer_utils.h"
Mark Lobodzinskib56bbb92019-02-18 11:49:59 -070037#include "chassis.h"
Chris Forbes47567b72017-06-09 12:09:45 -070038#include "core_validation.h"
Petr Kraus25810d02019-08-27 17:41:15 +020039
Chris Forbes9a61e082017-07-24 15:35:29 -070040#include "xxhash.h"
Chris Forbes47567b72017-06-09 12:09:45 -070041
Chris Forbes47567b72017-06-09 12:09:45 -070042static shader_stage_attributes shader_stage_attribs[] = {
Ari Suonpaa696b3432019-03-11 14:02:57 +020043 {"vertex shader", false, false, VK_SHADER_STAGE_VERTEX_BIT},
44 {"tessellation control shader", true, true, VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT},
45 {"tessellation evaluation shader", true, false, VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT},
46 {"geometry shader", true, false, VK_SHADER_STAGE_GEOMETRY_BIT},
47 {"fragment shader", false, false, VK_SHADER_STAGE_FRAGMENT_BIT},
Chris Forbes47567b72017-06-09 12:09:45 -070048};
49
Shannon McPhersonc06c33d2018-06-28 17:21:12 -060050static bool IsNarrowNumericType(spirv_inst_iter type) {
Chris Forbes47567b72017-06-09 12:09:45 -070051 if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) return false;
52 return type.word(2) < 64;
53}
54
Mark Lobodzinski3c59d972019-04-25 11:28:14 -060055static bool TypesMatch(SHADER_MODULE_STATE const *a, SHADER_MODULE_STATE const *b, unsigned a_type, unsigned b_type, bool a_arrayed,
Shannon McPhersonc06c33d2018-06-28 17:21:12 -060056 bool b_arrayed, bool relaxed) {
Chris Forbes47567b72017-06-09 12:09:45 -070057 // Walk two type trees together, and complain about differences
58 auto a_insn = a->get_def(a_type);
59 auto b_insn = b->get_def(b_type);
60 assert(a_insn != a->end());
61 assert(b_insn != b->end());
62
Chris Forbes062f1222018-08-21 15:34:15 -070063 // Ignore runtime-sized arrays-- they cannot appear in these interfaces.
64
Chris Forbes47567b72017-06-09 12:09:45 -070065 if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) {
Shannon McPhersonc06c33d2018-06-28 17:21:12 -060066 return TypesMatch(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed);
Chris Forbes47567b72017-06-09 12:09:45 -070067 }
68
69 if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) {
70 // We probably just found the extra level of arrayness in b_type: compare the type inside it to a_type
Shannon McPhersonc06c33d2018-06-28 17:21:12 -060071 return TypesMatch(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed);
Chris Forbes47567b72017-06-09 12:09:45 -070072 }
73
Shannon McPhersonc06c33d2018-06-28 17:21:12 -060074 if (a_insn.opcode() == spv::OpTypeVector && relaxed && IsNarrowNumericType(b_insn)) {
75 return TypesMatch(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false);
Chris Forbes47567b72017-06-09 12:09:45 -070076 }
77
78 if (a_insn.opcode() != b_insn.opcode()) {
79 return false;
80 }
81
82 if (a_insn.opcode() == spv::OpTypePointer) {
83 // Match on pointee type. storage class is expected to differ
Shannon McPhersonc06c33d2018-06-28 17:21:12 -060084 return TypesMatch(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed);
Chris Forbes47567b72017-06-09 12:09:45 -070085 }
86
87 if (a_arrayed || b_arrayed) {
88 // If we havent resolved array-of-verts by here, we're not going to.
89 return false;
90 }
91
92 switch (a_insn.opcode()) {
93 case spv::OpTypeBool:
94 return true;
95 case spv::OpTypeInt:
96 // Match on width, signedness
97 return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3);
98 case spv::OpTypeFloat:
99 // Match on width
100 return a_insn.word(2) == b_insn.word(2);
101 case spv::OpTypeVector:
102 // Match on element type, count.
Shannon McPhersonc06c33d2018-06-28 17:21:12 -0600103 if (!TypesMatch(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) return false;
104 if (relaxed && IsNarrowNumericType(a->get_def(a_insn.word(2)))) {
Chris Forbes47567b72017-06-09 12:09:45 -0700105 return a_insn.word(3) >= b_insn.word(3);
106 } else {
107 return a_insn.word(3) == b_insn.word(3);
108 }
109 case spv::OpTypeMatrix:
110 // Match on element type, count.
Shannon McPhersonc06c33d2018-06-28 17:21:12 -0600111 return TypesMatch(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) &&
Dave Houltona9df0ce2018-02-07 10:51:23 -0700112 a_insn.word(3) == b_insn.word(3);
Chris Forbes47567b72017-06-09 12:09:45 -0700113 case spv::OpTypeArray:
114 // Match on element type, count. these all have the same layout. we don't get here if b_arrayed. This differs from
115 // vector & matrix types in that the array size is the id of a constant instruction, * not a literal within OpTypeArray
Shannon McPhersonc06c33d2018-06-28 17:21:12 -0600116 return TypesMatch(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) &&
sfricke-samsung962cad92021-04-13 00:46:29 -0700117 a->GetConstantValueById(a_insn.word(3)) == b->GetConstantValueById(b_insn.word(3));
Chris Forbes47567b72017-06-09 12:09:45 -0700118 case spv::OpTypeStruct:
119 // Match on all element types
Dave Houltona9df0ce2018-02-07 10:51:23 -0700120 {
121 if (a_insn.len() != b_insn.len()) {
122 return false; // Structs cannot match if member counts differ
Chris Forbes47567b72017-06-09 12:09:45 -0700123 }
Chris Forbes47567b72017-06-09 12:09:45 -0700124
Dave Houltona9df0ce2018-02-07 10:51:23 -0700125 for (unsigned i = 2; i < a_insn.len(); i++) {
Shannon McPhersonc06c33d2018-06-28 17:21:12 -0600126 if (!TypesMatch(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -0700127 return false;
128 }
129 }
130
131 return true;
132 }
Chris Forbes47567b72017-06-09 12:09:45 -0700133 default:
134 // Remaining types are CLisms, or may not appear in the interfaces we are interested in. Just claim no match.
135 return false;
136 }
137}
138
Shannon McPhersonc06c33d2018-06-28 17:21:12 -0600139static unsigned GetLocationsConsumedByFormat(VkFormat format) {
Chris Forbes47567b72017-06-09 12:09:45 -0700140 switch (format) {
141 case VK_FORMAT_R64G64B64A64_SFLOAT:
142 case VK_FORMAT_R64G64B64A64_SINT:
143 case VK_FORMAT_R64G64B64A64_UINT:
144 case VK_FORMAT_R64G64B64_SFLOAT:
145 case VK_FORMAT_R64G64B64_SINT:
146 case VK_FORMAT_R64G64B64_UINT:
147 return 2;
148 default:
149 return 1;
150 }
151}
152
Shannon McPhersonc06c33d2018-06-28 17:21:12 -0600153static unsigned GetFormatType(VkFormat fmt) {
Dave Houltona9df0ce2018-02-07 10:51:23 -0700154 if (FormatIsSInt(fmt)) return FORMAT_TYPE_SINT;
155 if (FormatIsUInt(fmt)) return FORMAT_TYPE_UINT;
156 if (FormatIsDepthAndStencil(fmt)) return FORMAT_TYPE_FLOAT | FORMAT_TYPE_UINT;
157 if (fmt == VK_FORMAT_UNDEFINED) return 0;
Chris Forbes47567b72017-06-09 12:09:45 -0700158 // everything else -- UNORM/SNORM/FLOAT/USCALED/SSCALED is all float in the shader.
159 return FORMAT_TYPE_FLOAT;
160}
161
Shannon McPhersonc06c33d2018-06-28 17:21:12 -0600162static uint32_t GetShaderStageId(VkShaderStageFlagBits stage) {
Chris Forbes47567b72017-06-09 12:09:45 -0700163 uint32_t bit_pos = uint32_t(u_ffs(stage));
164 return bit_pos - 1;
165}
166
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -0700167bool CoreChecks::ValidateViConsistency(VkPipelineVertexInputStateCreateInfo const *vi) const {
Chris Forbes47567b72017-06-09 12:09:45 -0700168 // Walk the binding descriptions, which describe the step rate and stride of each vertex buffer. Each binding should
169 // be specified only once.
Jeremy Gebbencbf22862021-03-03 12:01:22 -0700170 layer_data::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings;
Chris Forbes47567b72017-06-09 12:09:45 -0700171 bool skip = false;
172
173 for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) {
174 auto desc = &vi->pVertexBindingDescriptions[i];
175 auto &binding = bindings[desc->binding];
176 if (binding) {
Dave Houlton78d09922018-05-17 15:48:45 -0600177 // TODO: "VUID-VkGraphicsPipelineCreateInfo-pStages-00742" perhaps?
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700178 skip |= LogError(device, kVUID_Core_Shader_InconsistentVi, "Duplicate vertex input binding descriptions for binding %d",
179 desc->binding);
Chris Forbes47567b72017-06-09 12:09:45 -0700180 } else {
181 binding = desc;
182 }
183 }
184
185 return skip;
186}
187
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -0700188bool CoreChecks::ValidateViAgainstVsInputs(VkPipelineVertexInputStateCreateInfo const *vi, SHADER_MODULE_STATE const *vs,
189 spirv_inst_iter entrypoint) const {
Chris Forbes47567b72017-06-09 12:09:45 -0700190 bool skip = false;
191
sfricke-samsung962cad92021-04-13 00:46:29 -0700192 const auto inputs = vs->CollectInterfaceByLocation(entrypoint, spv::StorageClassInput, false);
Chris Forbes47567b72017-06-09 12:09:45 -0700193
194 // Build index by location
Petr Kraus25810d02019-08-27 17:41:15 +0200195 std::map<uint32_t, const VkVertexInputAttributeDescription *> attribs;
Chris Forbes47567b72017-06-09 12:09:45 -0700196 if (vi) {
Petr Kraus25810d02019-08-27 17:41:15 +0200197 for (uint32_t i = 0; i < vi->vertexAttributeDescriptionCount; ++i) {
198 const auto num_locations = GetLocationsConsumedByFormat(vi->pVertexAttributeDescriptions[i].format);
199 for (uint32_t j = 0; j < num_locations; ++j) {
Chris Forbes47567b72017-06-09 12:09:45 -0700200 attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i];
201 }
202 }
203 }
204
Petr Kraus25810d02019-08-27 17:41:15 +0200205 struct AttribInputPair {
206 const VkVertexInputAttributeDescription *attrib = nullptr;
207 const interface_var *input = nullptr;
208 };
209 std::map<uint32_t, AttribInputPair> location_map;
210 for (const auto &attrib_it : attribs) location_map[attrib_it.first].attrib = attrib_it.second;
211 for (const auto &input_it : inputs) location_map[input_it.first.first].input = &input_it.second;
Chris Forbes47567b72017-06-09 12:09:45 -0700212
Jamie Madillc1f7ca82020-03-16 17:08:26 -0400213 for (const auto &location_it : location_map) {
Petr Kraus25810d02019-08-27 17:41:15 +0200214 const auto location = location_it.first;
215 const auto attrib = location_it.second.attrib;
216 const auto input = location_it.second.input;
Mark Lobodzinski7caa39c2018-07-25 15:48:34 -0600217
Petr Kraus25810d02019-08-27 17:41:15 +0200218 if (attrib && !input) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600219 skip |= LogPerformanceWarning(vs->vk_shader_module(), kVUID_Core_Shader_OutputNotConsumed,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700220 "Vertex attribute at location %" PRIu32 " not consumed by vertex shader", location);
Petr Kraus25810d02019-08-27 17:41:15 +0200221 } else if (!attrib && input) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600222 skip |= LogError(vs->vk_shader_module(), kVUID_Core_Shader_InputNotProduced,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700223 "Vertex shader consumes input at location %" PRIu32 " but not provided", location);
Petr Kraus25810d02019-08-27 17:41:15 +0200224 } else if (attrib && input) {
225 const auto attrib_type = GetFormatType(attrib->format);
sfricke-samsung962cad92021-04-13 00:46:29 -0700226 const auto input_type = vs->GetFundamentalType(input->type_id);
Chris Forbes47567b72017-06-09 12:09:45 -0700227
228 // Type checking
229 if (!(attrib_type & input_type)) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600230 skip |= LogError(vs->vk_shader_module(), kVUID_Core_Shader_InterfaceTypeMismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700231 "Attribute type of `%s` at location %" PRIu32 " does not match vertex shader input type of `%s`",
sfricke-samsung962cad92021-04-13 00:46:29 -0700232 string_VkFormat(attrib->format), location, vs->DescribeType(input->type_id).c_str());
Chris Forbes47567b72017-06-09 12:09:45 -0700233 }
Petr Kraus25810d02019-08-27 17:41:15 +0200234 } else { // !attrib && !input
235 assert(false); // at least one exists in the map
Chris Forbes47567b72017-06-09 12:09:45 -0700236 }
237 }
238
239 return skip;
240}
241
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -0700242bool CoreChecks::ValidateFsOutputsAgainstRenderPass(SHADER_MODULE_STATE const *fs, spirv_inst_iter entrypoint,
243 PIPELINE_STATE const *pipeline, uint32_t subpass_index) const {
Petr Kraus25810d02019-08-27 17:41:15 +0200244 bool skip = false;
Chris Forbes8bca1652017-07-20 11:10:09 -0700245
Petr Kraus25810d02019-08-27 17:41:15 +0200246 const auto rpci = pipeline->rp_state->createInfo.ptr();
247
Jeremy Hayes3699c7c2019-10-09 12:24:55 -0600248 struct Attachment {
Mike Schuchardt2df08912020-12-15 16:28:09 -0800249 const VkAttachmentReference2 *reference = nullptr;
250 const VkAttachmentDescription2 *attachment = nullptr;
Jeremy Hayes3699c7c2019-10-09 12:24:55 -0600251 const interface_var *output = nullptr;
252 };
253 std::map<uint32_t, Attachment> location_map;
254
Petr Kraus25810d02019-08-27 17:41:15 +0200255 const auto subpass = rpci->pSubpasses[subpass_index];
256 for (uint32_t i = 0; i < subpass.colorAttachmentCount; ++i) {
Jeremy Hayes3699c7c2019-10-09 12:24:55 -0600257 auto const &reference = subpass.pColorAttachments[i];
258 location_map[i].reference = &reference;
259 if (reference.attachment != VK_ATTACHMENT_UNUSED &&
260 rpci->pAttachments[reference.attachment].format != VK_FORMAT_UNDEFINED) {
261 location_map[i].attachment = &rpci->pAttachments[reference.attachment];
Chris Forbes47567b72017-06-09 12:09:45 -0700262 }
263 }
264
Chris Forbes47567b72017-06-09 12:09:45 -0700265 // TODO: dual source blend index (spv::DecIndex, zero if not provided)
266
sfricke-samsung962cad92021-04-13 00:46:29 -0700267 const auto outputs = fs->CollectInterfaceByLocation(entrypoint, spv::StorageClassOutput, false);
Jeremy Hayes3699c7c2019-10-09 12:24:55 -0600268 for (const auto &output_it : outputs) {
269 auto const location = output_it.first.first;
270 location_map[location].output = &output_it.second;
271 }
Chris Forbes47567b72017-06-09 12:09:45 -0700272
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700273 const bool alpha_to_coverage_enabled = pipeline->graphicsPipelineCI.pMultisampleState != NULL &&
274 pipeline->graphicsPipelineCI.pMultisampleState->alphaToCoverageEnable == VK_TRUE;
Chris Forbes47567b72017-06-09 12:09:45 -0700275
Jamie Madillc1f7ca82020-03-16 17:08:26 -0400276 for (const auto &location_it : location_map) {
Jeremy Hayes3699c7c2019-10-09 12:24:55 -0600277 const auto reference = location_it.second.reference;
278 if (reference != nullptr && reference->attachment == VK_ATTACHMENT_UNUSED) {
279 continue;
280 }
281
Petr Kraus25810d02019-08-27 17:41:15 +0200282 const auto location = location_it.first;
283 const auto attachment = location_it.second.attachment;
284 const auto output = location_it.second.output;
Petr Kraus25810d02019-08-27 17:41:15 +0200285 if (attachment && !output) {
286 if (pipeline->attachments[location].colorWriteMask != 0) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600287 skip |= LogWarning(fs->vk_shader_module(), kVUID_Core_Shader_InputNotProduced,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700288 "Attachment %" PRIu32
289 " not written by fragment shader; undefined values will be written to attachment",
290 location);
Petr Kraus25810d02019-08-27 17:41:15 +0200291 }
292 } else if (!attachment && output) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700293 if (!(alpha_to_coverage_enabled && location == 0)) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600294 skip |= LogWarning(fs->vk_shader_module(), kVUID_Core_Shader_OutputNotConsumed,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700295 "fragment shader writes to output location %" PRIu32 " with no matching attachment", location);
Ari Suonpaa412b23b2019-02-26 07:56:58 +0200296 }
Petr Kraus25810d02019-08-27 17:41:15 +0200297 } else if (attachment && output) {
298 const auto attachment_type = GetFormatType(attachment->format);
sfricke-samsung962cad92021-04-13 00:46:29 -0700299 const auto output_type = fs->GetFundamentalType(output->type_id);
Chris Forbes47567b72017-06-09 12:09:45 -0700300
301 // Type checking
Petr Kraus25810d02019-08-27 17:41:15 +0200302 if (!(output_type & attachment_type)) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700303 skip |=
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600304 LogWarning(fs->vk_shader_module(), kVUID_Core_Shader_InterfaceTypeMismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700305 "Attachment %" PRIu32
306 " of type `%s` does not match fragment shader output type of `%s`; resulting values are undefined",
sfricke-samsung962cad92021-04-13 00:46:29 -0700307 location, string_VkFormat(attachment->format), fs->DescribeType(output->type_id).c_str());
Chris Forbes47567b72017-06-09 12:09:45 -0700308 }
Petr Kraus25810d02019-08-27 17:41:15 +0200309 } else { // !attachment && !output
310 assert(false); // at least one exists in the map
Chris Forbes47567b72017-06-09 12:09:45 -0700311 }
312 }
313
Petr Kraus25810d02019-08-27 17:41:15 +0200314 const auto output_zero = location_map.count(0) ? location_map[0].output : nullptr;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700315 bool location_zero_has_alpha = output_zero && fs->get_def(output_zero->type_id) != fs->end() &&
sfricke-samsung962cad92021-04-13 00:46:29 -0700316 fs->GetComponentsConsumedByType(output_zero->type_id, false) == 4;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700317 if (alpha_to_coverage_enabled && !location_zero_has_alpha) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600318 skip |= LogError(fs->vk_shader_module(), kVUID_Core_Shader_NoAlphaAtLocation0WithAlphaToCoverage,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700319 "fragment shader doesn't declare alpha output at location 0 even though alpha to coverage is enabled.");
Ari Suonpaa412b23b2019-02-26 07:56:58 +0200320 }
321
Chris Forbes47567b72017-06-09 12:09:45 -0700322 return skip;
323}
324
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600325PushConstantByteState CoreChecks::ValidatePushConstantSetUpdate(const std::vector<uint8_t> &push_constant_data_update,
326 const shader_struct_member &push_constant_used_in_shader,
327 uint32_t &out_issue_index) const {
locke-lunargde3f0fa2020-09-10 11:55:31 -0600328 const auto *used_bytes = push_constant_used_in_shader.GetUsedbytes();
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600329 const auto used_bytes_size = used_bytes->size();
330 if (used_bytes_size == 0) return PC_Byte_Updated;
331
332 const auto push_constant_data_update_size = push_constant_data_update.size();
333 const auto *data = push_constant_data_update.data();
334 if ((*data == PC_Byte_Updated) && std::memcmp(data, data + 1, push_constant_data_update_size - 1) == 0) {
335 if (used_bytes_size <= push_constant_data_update_size) {
336 return PC_Byte_Updated;
337 }
338 const auto used_bytes_size1 = used_bytes_size - push_constant_data_update_size;
339
340 const auto *used_bytes_data1 = used_bytes->data() + push_constant_data_update_size;
341 if ((*used_bytes_data1 == 0) && std::memcmp(used_bytes_data1, used_bytes_data1 + 1, used_bytes_size1 - 1) == 0) {
342 return PC_Byte_Updated;
343 }
locke-lunargde3f0fa2020-09-10 11:55:31 -0600344 }
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600345
locke-lunargde3f0fa2020-09-10 11:55:31 -0600346 uint32_t i = 0;
347 for (const auto used : *used_bytes) {
348 if (used) {
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600349 if (i >= push_constant_data_update.size() || push_constant_data_update[i] == PC_Byte_Not_Set) {
locke-lunargde3f0fa2020-09-10 11:55:31 -0600350 out_issue_index = i;
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600351 return PC_Byte_Not_Set;
352 } else if (push_constant_data_update[i] == PC_Byte_Not_Updated) {
locke-lunargde3f0fa2020-09-10 11:55:31 -0600353 out_issue_index = i;
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600354 return PC_Byte_Not_Updated;
locke-lunargde3f0fa2020-09-10 11:55:31 -0600355 }
356 }
357 ++i;
358 }
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600359 return PC_Byte_Updated;
locke-lunargde3f0fa2020-09-10 11:55:31 -0600360}
361
362bool CoreChecks::ValidatePushConstantUsage(const PIPELINE_STATE &pipeline, SHADER_MODULE_STATE const *src,
sfricke-samsung7699b912021-04-12 23:01:51 -0700363 VkPipelineShaderStageCreateInfo const *pStage, const std::string &vuid) const {
Chris Forbes47567b72017-06-09 12:09:45 -0700364 bool skip = false;
sfricke-samsung5c65b372021-03-25 05:39:57 -0700365 // Temp workaround to prevent false positive errors
366 // https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2450
367 if (src->multiple_entry_points) {
368 return skip;
369 }
370
Chris Forbes47567b72017-06-09 12:09:45 -0700371 // Validate directly off the offsets. this isn't quite correct for arrays and matrices, but is a good first step.
sfricke-samsung962cad92021-04-13 00:46:29 -0700372 const auto *entrypoint = src->FindEntrypointStruct(pStage->pName, pStage->stage);
locke-lunargde3f0fa2020-09-10 11:55:31 -0600373 if (!entrypoint || !entrypoint->push_constant_used_in_shader.IsUsed()) {
374 return skip;
375 }
376 std::vector<VkPushConstantRange> const *push_constant_ranges = pipeline.pipeline_layout->push_constant_ranges.get();
Chris Forbes47567b72017-06-09 12:09:45 -0700377
locke-lunargde3f0fa2020-09-10 11:55:31 -0600378 bool found_stage = false;
379 for (auto const &range : *push_constant_ranges) {
380 if (range.stageFlags & pStage->stage) {
381 found_stage = true;
382 std::string location_desc;
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600383 std::vector<uint8_t> push_constant_bytes_set;
locke-lunargde3f0fa2020-09-10 11:55:31 -0600384 if (range.offset > 0) {
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600385 push_constant_bytes_set.resize(range.offset, PC_Byte_Not_Set);
locke-lunargde3f0fa2020-09-10 11:55:31 -0600386 }
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600387 push_constant_bytes_set.resize(range.offset + range.size, PC_Byte_Updated);
locke-lunargde3f0fa2020-09-10 11:55:31 -0600388 uint32_t issue_index = 0;
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600389 const auto ret =
390 ValidatePushConstantSetUpdate(push_constant_bytes_set, entrypoint->push_constant_used_in_shader, issue_index);
Chris Forbes47567b72017-06-09 12:09:45 -0700391
locke-lunarg3d8b8f32020-10-26 17:04:16 -0600392 if (ret == PC_Byte_Not_Set) {
locke-lunargde3f0fa2020-09-10 11:55:31 -0600393 const auto loc_descr = entrypoint->push_constant_used_in_shader.GetLocationDesc(issue_index);
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600394 LogObjectList objlist(src->vk_shader_module());
395 objlist.add(pipeline.pipeline_layout->layout());
sfricke-samsung7699b912021-04-12 23:01:51 -0700396 skip |= LogError(objlist, vuid, "Push constant buffer:%s in %s is out of range in %s.", loc_descr.c_str(),
locke-lunargde3f0fa2020-09-10 11:55:31 -0600397 string_VkShaderStageFlags(pStage->stage).c_str(),
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600398 report_data->FormatHandle(pipeline.pipeline_layout->layout()).c_str());
locke-lunargde3f0fa2020-09-10 11:55:31 -0600399 break;
Chris Forbes47567b72017-06-09 12:09:45 -0700400 }
401 }
402 }
403
locke-lunargde3f0fa2020-09-10 11:55:31 -0600404 if (!found_stage) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600405 LogObjectList objlist(src->vk_shader_module());
406 objlist.add(pipeline.pipeline_layout->layout());
sfricke-samsung7699b912021-04-12 23:01:51 -0700407 skip |= LogError(objlist, vuid, "Push constant is used in %s of %s. But %s doesn't set %s.",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600408 string_VkShaderStageFlags(pStage->stage).c_str(), report_data->FormatHandle(src->vk_shader_module()).c_str(),
409 report_data->FormatHandle(pipeline.pipeline_layout->layout()).c_str(),
sfricke-samsung7699b912021-04-12 23:01:51 -0700410 string_VkShaderStageFlags(pStage->stage).c_str());
Chris Forbes47567b72017-06-09 12:09:45 -0700411 }
Chris Forbes47567b72017-06-09 12:09:45 -0700412 return skip;
413}
414
Jeremy Gebbencbf22862021-03-03 12:01:22 -0700415bool CoreChecks::ValidateBuiltinLimits(SHADER_MODULE_STATE const *src, const layer_data::unordered_set<uint32_t> &accessible_ids,
sfricke-samsungef2a68c2020-10-26 04:22:46 -0700416 VkShaderStageFlagBits stage) const {
417 bool skip = false;
418
419 // Currently all builtin tested are only found in fragment shaders
420 if (stage != VK_SHADER_STAGE_FRAGMENT_BIT) {
421 return skip;
422 }
423
424 for (const auto id : accessible_ids) {
425 auto insn = src->get_def(id);
426 const decoration_set decorations = src->get_decorations(insn.word(2));
427
428 // Built-ins are obtained from OpVariable
429 if (((decorations.flags & decoration_set::builtin_bit) != 0) && (insn.opcode() == spv::OpVariable)) {
430 auto type_pointer = src->get_def(insn.word(1));
431 assert(type_pointer.opcode() == spv::OpTypePointer);
432
433 auto type = src->get_def(type_pointer.word(3));
434 if (type.opcode() == spv::OpTypeArray) {
sfricke-samsung962cad92021-04-13 00:46:29 -0700435 uint32_t length = static_cast<uint32_t>(src->GetConstantValueById(type.word(3)));
sfricke-samsungef2a68c2020-10-26 04:22:46 -0700436
437 switch (decorations.builtin) {
438 case spv::BuiltInSampleMask:
439 // Handles both the input and output sampleMask
440 if (length > phys_dev_props.limits.maxSampleMaskWords) {
441 skip |= LogError(device, "VUID-VkPipelineShaderStageCreateInfo-maxSampleMaskWords-00711",
442 "vkCreateGraphicsPipelines(): The BuiltIns SampleMask array sizes is %u which exceeds "
443 "maxSampleMaskWords of %u in %s.",
444 length, phys_dev_props.limits.maxSampleMaskWords,
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600445 report_data->FormatHandle(src->vk_shader_module()).c_str());
sfricke-samsungef2a68c2020-10-26 04:22:46 -0700446 }
447 break;
448 }
449 }
450 }
451 }
452
453 return skip;
454}
455
Chris Forbes47567b72017-06-09 12:09:45 -0700456// Validate that data for each specialization entry is fully contained within the buffer.
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -0700457bool CoreChecks::ValidateSpecializationOffsets(VkPipelineShaderStageCreateInfo const *info) const {
Chris Forbes47567b72017-06-09 12:09:45 -0700458 bool skip = false;
459
460 VkSpecializationInfo const *spec = info->pSpecializationInfo;
461
462 if (spec) {
463 for (auto i = 0u; i < spec->mapEntryCount; i++) {
Jeremy Hayes6c555c32019-09-09 17:14:09 -0600464 if (spec->pMapEntries[i].offset >= spec->dataSize) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700465 skip |= LogError(device, "VUID-VkSpecializationInfo-offset-00773",
466 "Specialization entry %u (for constant id %u) references memory outside provided specialization "
Petr Krausb0d5e592021-05-21 23:37:11 +0200467 "data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER " bytes provided).",
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700468 i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset,
469 spec->pMapEntries[i].offset + spec->dataSize - 1, spec->dataSize);
Jeremy Hayes6c555c32019-09-09 17:14:09 -0600470
471 continue;
472 }
Chris Forbes47567b72017-06-09 12:09:45 -0700473 if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700474 skip |= LogError(device, "VUID-VkSpecializationInfo-pMapEntries-00774",
475 "Specialization entry %u (for constant id %u) references memory outside provided specialization "
Petr Krausb0d5e592021-05-21 23:37:11 +0200476 "data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER " bytes provided).",
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700477 i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset,
478 spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize);
Chris Forbes47567b72017-06-09 12:09:45 -0700479 }
480 }
481 }
482
483 return skip;
484}
485
Jeff Bolz38b3ce72018-09-19 12:53:38 -0500486// TODO (jbolz): Can this return a const reference?
sourav parmarcd5fb182020-07-17 12:58:44 -0700487static std::set<uint32_t> TypeToDescriptorTypeSet(SHADER_MODULE_STATE const *module, uint32_t type_id, unsigned &descriptor_count,
488 bool is_khr) {
Chris Forbes47567b72017-06-09 12:09:45 -0700489 auto type = module->get_def(type_id);
Chris Forbes9f89d752018-03-07 12:57:48 -0800490 bool is_storage_buffer = false;
Chris Forbes47567b72017-06-09 12:09:45 -0700491 descriptor_count = 1;
Jeff Bolze54ae892018-09-08 12:16:29 -0500492 std::set<uint32_t> ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700493
494 // Strip off any array or ptrs. Where we remove array levels, adjust the descriptor count for each dimension.
Jeff Bolzfdf96072018-04-10 14:32:18 -0500495 while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer || type.opcode() == spv::OpTypeRuntimeArray) {
496 if (type.opcode() == spv::OpTypeRuntimeArray) {
497 descriptor_count = 0;
498 type = module->get_def(type.word(2));
499 } else if (type.opcode() == spv::OpTypeArray) {
sfricke-samsung962cad92021-04-13 00:46:29 -0700500 descriptor_count *= module->GetConstantValueById(type.word(3));
Chris Forbes47567b72017-06-09 12:09:45 -0700501 type = module->get_def(type.word(2));
502 } else {
Chris Forbes9f89d752018-03-07 12:57:48 -0800503 if (type.word(2) == spv::StorageClassStorageBuffer) {
504 is_storage_buffer = true;
505 }
Chris Forbes47567b72017-06-09 12:09:45 -0700506 type = module->get_def(type.word(3));
507 }
508 }
509
510 switch (type.opcode()) {
511 case spv::OpTypeStruct: {
sfricke-samsung94d71a52021-02-26 05:25:43 -0800512 for (auto insn : module->decoration_inst) {
513 if (insn.word(1) == type.word(1)) {
Chris Forbes47567b72017-06-09 12:09:45 -0700514 if (insn.word(2) == spv::DecorationBlock) {
Chris Forbes9f89d752018-03-07 12:57:48 -0800515 if (is_storage_buffer) {
Jeff Bolze54ae892018-09-08 12:16:29 -0500516 ret.insert(VK_DESCRIPTOR_TYPE_STORAGE_BUFFER);
517 ret.insert(VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC);
518 return ret;
Chris Forbes9f89d752018-03-07 12:57:48 -0800519 } else {
Jeff Bolze54ae892018-09-08 12:16:29 -0500520 ret.insert(VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER);
521 ret.insert(VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC);
522 ret.insert(VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT);
523 return ret;
Chris Forbes9f89d752018-03-07 12:57:48 -0800524 }
Chris Forbes47567b72017-06-09 12:09:45 -0700525 } else if (insn.word(2) == spv::DecorationBufferBlock) {
Jeff Bolze54ae892018-09-08 12:16:29 -0500526 ret.insert(VK_DESCRIPTOR_TYPE_STORAGE_BUFFER);
527 ret.insert(VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC);
528 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700529 }
530 }
531 }
532
533 // Invalid
Jeff Bolze54ae892018-09-08 12:16:29 -0500534 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700535 }
536
537 case spv::OpTypeSampler:
Jeff Bolze54ae892018-09-08 12:16:29 -0500538 ret.insert(VK_DESCRIPTOR_TYPE_SAMPLER);
539 ret.insert(VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER);
540 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700541
Chris Forbes73c00bf2018-06-22 16:28:06 -0700542 case spv::OpTypeSampledImage: {
543 // Slight relaxation for some GLSL historical madness: samplerBuffer doesn't really have a sampler, and a texel
544 // buffer descriptor doesn't really provide one. Allow this slight mismatch.
545 auto image_type = module->get_def(type.word(2));
546 auto dim = image_type.word(3);
547 auto sampled = image_type.word(7);
548 if (dim == spv::DimBuffer && sampled == 1) {
Jeff Bolze54ae892018-09-08 12:16:29 -0500549 ret.insert(VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER);
550 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700551 }
Chris Forbes73c00bf2018-06-22 16:28:06 -0700552 }
Jeff Bolze54ae892018-09-08 12:16:29 -0500553 ret.insert(VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER);
554 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700555
556 case spv::OpTypeImage: {
557 // Many descriptor types backing image types-- depends on dimension and whether the image will be used with a sampler.
558 // SPIRV for Vulkan requires that sampled be 1 or 2 -- leaving the decision to runtime is unacceptable.
559 auto dim = type.word(3);
560 auto sampled = type.word(7);
561
562 if (dim == spv::DimSubpassData) {
Jeff Bolze54ae892018-09-08 12:16:29 -0500563 ret.insert(VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT);
564 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700565 } else if (dim == spv::DimBuffer) {
566 if (sampled == 1) {
Jeff Bolze54ae892018-09-08 12:16:29 -0500567 ret.insert(VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER);
568 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700569 } else {
Jeff Bolze54ae892018-09-08 12:16:29 -0500570 ret.insert(VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER);
571 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700572 }
573 } else if (sampled == 1) {
Jeff Bolze54ae892018-09-08 12:16:29 -0500574 ret.insert(VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE);
575 ret.insert(VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER);
576 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700577 } else {
Jeff Bolze54ae892018-09-08 12:16:29 -0500578 ret.insert(VK_DESCRIPTOR_TYPE_STORAGE_IMAGE);
579 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700580 }
581 }
Shannon McPherson0fa28232018-11-01 11:59:02 -0600582 case spv::OpTypeAccelerationStructureNV:
sourav parmarcd5fb182020-07-17 12:58:44 -0700583 is_khr ? ret.insert(VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR)
584 : ret.insert(VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV);
Jeff Bolz105d6492018-09-29 15:46:44 -0500585 return ret;
Chris Forbes47567b72017-06-09 12:09:45 -0700586
587 // We shouldn't really see any other junk types -- but if we do, they're a mismatch.
588 default:
Jeff Bolze54ae892018-09-08 12:16:29 -0500589 return ret; // Matches nothing
Chris Forbes47567b72017-06-09 12:09:45 -0700590 }
591}
592
Jeff Bolze54ae892018-09-08 12:16:29 -0500593static std::string string_descriptorTypes(const std::set<uint32_t> &descriptor_types) {
Chris Forbes73c00bf2018-06-22 16:28:06 -0700594 std::stringstream ss;
Jeff Bolze54ae892018-09-08 12:16:29 -0500595 for (auto it = descriptor_types.begin(); it != descriptor_types.end(); ++it) {
596 if (ss.tellp()) ss << ", ";
597 ss << string_VkDescriptorType(VkDescriptorType(*it));
Chris Forbes73c00bf2018-06-22 16:28:06 -0700598 }
599 return ss.str();
600}
601
sfricke-samsung0065ce02020-12-03 22:46:37 -0800602bool CoreChecks::RequirePropertyFlag(VkBool32 check, char const *flag, char const *structure, const char *vuid) const {
Jeff Bolzee743412019-06-20 22:24:32 -0500603 if (!check) {
sfricke-samsung0065ce02020-12-03 22:46:37 -0800604 if (LogError(device, vuid, "Shader requires flag %s set in %s but it is not set on the device", flag, structure)) {
Jeff Bolzee743412019-06-20 22:24:32 -0500605 return true;
606 }
607 }
608
609 return false;
610}
611
sfricke-samsung0065ce02020-12-03 22:46:37 -0800612bool CoreChecks::RequireFeature(VkBool32 feature, char const *feature_name, const char *vuid) const {
Chris Forbes47567b72017-06-09 12:09:45 -0700613 if (!feature) {
sfricke-samsung0065ce02020-12-03 22:46:37 -0800614 if (LogError(device, vuid, "Shader requires %s but is not enabled on the device", feature_name)) {
Chris Forbes47567b72017-06-09 12:09:45 -0700615 return true;
616 }
617 }
618
619 return false;
620}
621
locke-lunarg63e4daf2020-08-17 17:53:25 -0600622bool CoreChecks::ValidateShaderStageWritableOrAtomicDescriptor(VkShaderStageFlagBits stage, bool has_writable_descriptor,
623 bool has_atomic_descriptor) const {
Jeff Bolzee743412019-06-20 22:24:32 -0500624 bool skip = false;
625
locke-lunarg63e4daf2020-08-17 17:53:25 -0600626 if (has_writable_descriptor || has_atomic_descriptor) {
Chris Forbes349b3132018-03-07 11:38:08 -0800627 switch (stage) {
628 case VK_SHADER_STAGE_COMPUTE_BIT:
Jeff Bolz148d94e2018-12-13 21:25:56 -0600629 case VK_SHADER_STAGE_RAYGEN_BIT_NV:
630 case VK_SHADER_STAGE_ANY_HIT_BIT_NV:
631 case VK_SHADER_STAGE_CLOSEST_HIT_BIT_NV:
632 case VK_SHADER_STAGE_MISS_BIT_NV:
633 case VK_SHADER_STAGE_INTERSECTION_BIT_NV:
634 case VK_SHADER_STAGE_CALLABLE_BIT_NV:
635 case VK_SHADER_STAGE_TASK_BIT_NV:
636 case VK_SHADER_STAGE_MESH_BIT_NV:
Chris Forbes349b3132018-03-07 11:38:08 -0800637 /* No feature requirements for writes and atomics from compute
Jeff Bolz148d94e2018-12-13 21:25:56 -0600638 * raytracing, or mesh stages */
Chris Forbes349b3132018-03-07 11:38:08 -0800639 break;
640 case VK_SHADER_STAGE_FRAGMENT_BIT:
sfricke-samsung0065ce02020-12-03 22:46:37 -0800641 skip |= RequireFeature(enabled_features.core.fragmentStoresAndAtomics, "fragmentStoresAndAtomics",
642 kVUID_Core_Shader_FeatureNotEnabled);
Chris Forbes349b3132018-03-07 11:38:08 -0800643 break;
644 default:
sfricke-samsung0065ce02020-12-03 22:46:37 -0800645 skip |= RequireFeature(enabled_features.core.vertexPipelineStoresAndAtomics, "vertexPipelineStoresAndAtomics",
646 kVUID_Core_Shader_FeatureNotEnabled);
Chris Forbes349b3132018-03-07 11:38:08 -0800647 break;
648 }
649 }
650
Chris Forbes47567b72017-06-09 12:09:45 -0700651 return skip;
652}
653
sfricke-samsung94167ca2021-02-26 04:14:59 -0800654bool CoreChecks::ValidateShaderStageGroupNonUniform(SHADER_MODULE_STATE const *module, VkShaderStageFlagBits stage,
655 spirv_inst_iter &insn) const {
Jeff Bolzee743412019-06-20 22:24:32 -0500656 bool skip = false;
657
sfricke-samsung94167ca2021-02-26 04:14:59 -0800658 // Check anything using a group operation (which currently is only OpGroupNonUnifrom* operations)
659 if (GroupOperation(insn.opcode()) == true) {
660 // Check the quad operations.
661 if ((insn.opcode() == spv::OpGroupNonUniformQuadBroadcast) || (insn.opcode() == spv::OpGroupNonUniformQuadSwap)) {
662 if ((stage != VK_SHADER_STAGE_FRAGMENT_BIT) && (stage != VK_SHADER_STAGE_COMPUTE_BIT)) {
663 skip |= RequireFeature(phys_dev_props_core11.subgroupQuadOperationsInAllStages,
664 "VkPhysicalDeviceSubgroupProperties::quadOperationsInAllStages",
665 kVUID_Core_Shader_FeatureNotEnabled);
sfricke-samsung0065ce02020-12-03 22:46:37 -0800666 }
sfricke-samsung94167ca2021-02-26 04:14:59 -0800667 }
Jeff Bolz526f2d52019-09-18 13:18:08 -0500668
sfricke-samsung94167ca2021-02-26 04:14:59 -0800669 uint32_t scope_type = spv::ScopeMax;
670 if (insn.opcode() == spv::OpGroupNonUniformPartitionNV) {
671 // OpGroupNonUniformPartitionNV always assumed subgroup as missing operand
672 scope_type = spv::ScopeSubgroup;
673 } else {
674 // "All <id> used for Scope <id> must be of an OpConstant"
675 auto scope_id = module->get_def(insn.word(3));
676 scope_type = scope_id.word(3);
677 }
sfricke-samsung0065ce02020-12-03 22:46:37 -0800678
sfricke-samsung94167ca2021-02-26 04:14:59 -0800679 if (scope_type == spv::ScopeSubgroup) {
680 // "Group operations with subgroup scope" must have stage support
681 const VkSubgroupFeatureFlags supported_stages = phys_dev_props_core11.subgroupSupportedStages;
682 skip |= RequirePropertyFlag(supported_stages & stage, string_VkShaderStageFlagBits(stage),
sfricke-samsung0065ce02020-12-03 22:46:37 -0800683 "VkPhysicalDeviceSubgroupProperties::supportedStages", kVUID_Core_Shader_ExceedDeviceLimit);
sfricke-samsung94167ca2021-02-26 04:14:59 -0800684 }
685
686 if (!enabled_features.core12.shaderSubgroupExtendedTypes) {
687 auto type = module->get_def(insn.word(1));
688
689 if (type.opcode() == spv::OpTypeVector) {
690 // Get the element type
691 type = module->get_def(type.word(2));
sfricke-samsung0065ce02020-12-03 22:46:37 -0800692 }
693
sfricke-samsung94167ca2021-02-26 04:14:59 -0800694 if (type.opcode() != spv::OpTypeBool) {
sfricke-samsung0065ce02020-12-03 22:46:37 -0800695 // Both OpTypeInt and OpTypeFloat the width is in the 2nd word.
696 const uint32_t width = type.word(2);
Jeff Bolz526f2d52019-09-18 13:18:08 -0500697
sfricke-samsung0065ce02020-12-03 22:46:37 -0800698 if ((type.opcode() == spv::OpTypeFloat && width == 16) ||
699 (type.opcode() == spv::OpTypeInt && (width == 8 || width == 16 || width == 64))) {
700 skip |= RequireFeature(enabled_features.core12.shaderSubgroupExtendedTypes,
701 "VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures::shaderSubgroupExtendedTypes",
702 kVUID_Core_Shader_FeatureNotEnabled);
Jeff Bolz526f2d52019-09-18 13:18:08 -0500703 }
704 }
705 }
Jeff Bolzee743412019-06-20 22:24:32 -0500706 }
707
708 return skip;
709}
710
Mark Lobodzinski3c59d972019-04-25 11:28:14 -0600711bool CoreChecks::ValidateShaderStageInputOutputLimits(SHADER_MODULE_STATE const *src, VkPipelineShaderStageCreateInfo const *pStage,
John Zulaufac4c6e12019-07-01 16:05:58 -0600712 const PIPELINE_STATE *pipeline, spirv_inst_iter entrypoint) const {
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200713 if (pStage->stage == VK_SHADER_STAGE_COMPUTE_BIT || pStage->stage == VK_SHADER_STAGE_ALL_GRAPHICS ||
714 pStage->stage == VK_SHADER_STAGE_ALL) {
715 return false;
716 }
717
718 bool skip = false;
Mark Lobodzinski518eadc2019-03-09 12:07:30 -0700719 auto const &limits = phys_dev_props.limits;
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200720
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700721 std::set<uint32_t> patch_i_ds;
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200722 struct Variable {
723 uint32_t baseTypePtrID;
724 uint32_t ID;
725 uint32_t storageClass;
726 };
727 std::vector<Variable> variables;
728
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700729 uint32_t num_vertices = 0;
Nathaniel Cesario75fb7222020-12-07 10:54:53 -0700730 bool is_iso_lines = false;
731 bool is_point_mode = false;
Jeff Bolze9ee3d82019-05-29 13:45:13 -0500732
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700733 auto entrypoint_variables = FindEntrypointInterfaces(entrypoint);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600734
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200735 for (auto insn : *src) {
736 switch (insn.opcode()) {
Jeff Bolze9ee3d82019-05-29 13:45:13 -0500737 // Find all Patch decorations
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200738 case spv::OpDecorate:
739 switch (insn.word(2)) {
Jeff Bolze9ee3d82019-05-29 13:45:13 -0500740 case spv::DecorationPatch: {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700741 patch_i_ds.insert(insn.word(1));
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200742 break;
743 }
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200744 default:
745 break;
746 }
747 break;
748 // Find all input and output variables
749 case spv::OpVariable: {
750 Variable var = {};
751 var.storageClass = insn.word(3);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600752 if ((var.storageClass == spv::StorageClassInput || var.storageClass == spv::StorageClassOutput) &&
753 // Only include variables in the entrypoint's interface
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700754 find(entrypoint_variables.begin(), entrypoint_variables.end(), insn.word(2)) != entrypoint_variables.end()) {
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200755 var.baseTypePtrID = insn.word(1);
756 var.ID = insn.word(2);
757 variables.push_back(var);
758 }
759 break;
760 }
Jeff Bolze9ee3d82019-05-29 13:45:13 -0500761 case spv::OpExecutionMode:
762 if (insn.word(1) == entrypoint.word(2)) {
763 switch (insn.word(2)) {
764 default:
765 break;
766 case spv::ExecutionModeOutputVertices:
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700767 num_vertices = insn.word(3);
Jeff Bolze9ee3d82019-05-29 13:45:13 -0500768 break;
Nathaniel Cesario75fb7222020-12-07 10:54:53 -0700769 case spv::ExecutionModeIsolines:
770 is_iso_lines = true;
771 break;
772 case spv::ExecutionModePointMode:
773 is_point_mode = true;
774 break;
Jeff Bolze9ee3d82019-05-29 13:45:13 -0500775 }
776 }
777 break;
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200778 default:
779 break;
780 }
781 }
782
Jeff Bolze9ee3d82019-05-29 13:45:13 -0500783 bool strip_output_array_level =
784 (pStage->stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT || pStage->stage == VK_SHADER_STAGE_MESH_BIT_NV);
785 bool strip_input_array_level =
786 (pStage->stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT ||
787 pStage->stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT || pStage->stage == VK_SHADER_STAGE_GEOMETRY_BIT);
788
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700789 uint32_t num_comp_in = 0, num_comp_out = 0;
790 int max_comp_in = 0, max_comp_out = 0;
Jeff Bolzf234bf82019-11-04 14:07:15 -0600791
sfricke-samsung962cad92021-04-13 00:46:29 -0700792 auto inputs = src->CollectInterfaceByLocation(entrypoint, spv::StorageClassInput, strip_input_array_level);
793 auto outputs = src->CollectInterfaceByLocation(entrypoint, spv::StorageClassOutput, strip_output_array_level);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600794
795 // Find max component location used for input variables.
796 for (auto &var : inputs) {
797 int location = var.first.first;
798 int component = var.first.second;
799 interface_var &iv = var.second;
800
801 // Only need to look at the first location, since we use the type's whole size
802 if (iv.offset != 0) {
803 continue;
804 }
805
806 if (iv.is_patch) {
807 continue;
808 }
809
sfricke-samsung962cad92021-04-13 00:46:29 -0700810 int num_components = src->GetComponentsConsumedByType(iv.type_id, strip_input_array_level);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700811 max_comp_in = std::max(max_comp_in, location * 4 + component + num_components);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600812 }
813
814 // Find max component location used for output variables.
815 for (auto &var : outputs) {
816 int location = var.first.first;
817 int component = var.first.second;
818 interface_var &iv = var.second;
819
820 // Only need to look at the first location, since we use the type's whole size
821 if (iv.offset != 0) {
822 continue;
823 }
824
825 if (iv.is_patch) {
826 continue;
827 }
828
sfricke-samsung962cad92021-04-13 00:46:29 -0700829 int num_components = src->GetComponentsConsumedByType(iv.type_id, strip_output_array_level);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700830 max_comp_out = std::max(max_comp_out, location * 4 + component + num_components);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600831 }
832
833 // XXX TODO: Would be nice to rewrite this to use CollectInterfaceByLocation (or something similar),
834 // but that doesn't include builtins.
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200835 for (auto &var : variables) {
Jeff Bolze9ee3d82019-05-29 13:45:13 -0500836 // Check if the variable is a patch. Patches can also be members of blocks,
837 // but if they are then the top-level arrayness has already been stripped
838 // by the time GetComponentsConsumedByType gets to it.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700839 bool is_patch = patch_i_ds.find(var.ID) != patch_i_ds.end();
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200840
841 if (var.storageClass == spv::StorageClassInput) {
sfricke-samsung962cad92021-04-13 00:46:29 -0700842 num_comp_in += src->GetComponentsConsumedByType(var.baseTypePtrID, strip_input_array_level && !is_patch);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200843 } else { // var.storageClass == spv::StorageClassOutput
sfricke-samsung962cad92021-04-13 00:46:29 -0700844 num_comp_out += src->GetComponentsConsumedByType(var.baseTypePtrID, strip_output_array_level && !is_patch);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200845 }
846 }
847
848 switch (pStage->stage) {
849 case VK_SHADER_STAGE_VERTEX_BIT:
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700850 if (num_comp_out > limits.maxVertexOutputComponents) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600851 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700852 "Invalid Pipeline CreateInfo State: Vertex shader exceeds "
853 "VkPhysicalDeviceLimits::maxVertexOutputComponents of %u "
854 "components by %u components",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700855 limits.maxVertexOutputComponents, num_comp_out - limits.maxVertexOutputComponents);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200856 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700857 if (max_comp_out > static_cast<int>(limits.maxVertexOutputComponents)) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600858 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700859 "Invalid Pipeline CreateInfo State: Vertex shader output variable uses location that "
860 "exceeds component limit VkPhysicalDeviceLimits::maxVertexOutputComponents (%u)",
861 limits.maxVertexOutputComponents);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600862 }
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200863 break;
864
865 case VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT:
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700866 if (num_comp_in > limits.maxTessellationControlPerVertexInputComponents) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600867 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700868 "Invalid Pipeline CreateInfo State: Tessellation control shader exceeds "
869 "VkPhysicalDeviceLimits::maxTessellationControlPerVertexInputComponents of %u "
870 "components by %u components",
871 limits.maxTessellationControlPerVertexInputComponents,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700872 num_comp_in - limits.maxTessellationControlPerVertexInputComponents);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200873 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700874 if (max_comp_in > static_cast<int>(limits.maxTessellationControlPerVertexInputComponents)) {
Jeff Bolzf234bf82019-11-04 14:07:15 -0600875 skip |=
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600876 LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700877 "Invalid Pipeline CreateInfo State: Tessellation control shader input variable uses location that "
878 "exceeds component limit VkPhysicalDeviceLimits::maxTessellationControlPerVertexInputComponents (%u)",
879 limits.maxTessellationControlPerVertexInputComponents);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600880 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700881 if (num_comp_out > limits.maxTessellationControlPerVertexOutputComponents) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600882 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700883 "Invalid Pipeline CreateInfo State: Tessellation control shader exceeds "
884 "VkPhysicalDeviceLimits::maxTessellationControlPerVertexOutputComponents of %u "
885 "components by %u components",
886 limits.maxTessellationControlPerVertexOutputComponents,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700887 num_comp_out - limits.maxTessellationControlPerVertexOutputComponents);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200888 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700889 if (max_comp_out > static_cast<int>(limits.maxTessellationControlPerVertexOutputComponents)) {
Jeff Bolzf234bf82019-11-04 14:07:15 -0600890 skip |=
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600891 LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700892 "Invalid Pipeline CreateInfo State: Tessellation control shader output variable uses location that "
893 "exceeds component limit VkPhysicalDeviceLimits::maxTessellationControlPerVertexOutputComponents (%u)",
894 limits.maxTessellationControlPerVertexOutputComponents);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600895 }
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200896 break;
897
898 case VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT:
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700899 if (num_comp_in > limits.maxTessellationEvaluationInputComponents) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600900 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700901 "Invalid Pipeline CreateInfo State: Tessellation evaluation shader exceeds "
902 "VkPhysicalDeviceLimits::maxTessellationEvaluationInputComponents of %u "
903 "components by %u components",
904 limits.maxTessellationEvaluationInputComponents,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700905 num_comp_in - limits.maxTessellationEvaluationInputComponents);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200906 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700907 if (max_comp_in > static_cast<int>(limits.maxTessellationEvaluationInputComponents)) {
Jeff Bolzf234bf82019-11-04 14:07:15 -0600908 skip |=
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600909 LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700910 "Invalid Pipeline CreateInfo State: Tessellation evaluation shader input variable uses location that "
911 "exceeds component limit VkPhysicalDeviceLimits::maxTessellationEvaluationInputComponents (%u)",
912 limits.maxTessellationEvaluationInputComponents);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600913 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700914 if (num_comp_out > limits.maxTessellationEvaluationOutputComponents) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600915 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700916 "Invalid Pipeline CreateInfo State: Tessellation evaluation shader exceeds "
917 "VkPhysicalDeviceLimits::maxTessellationEvaluationOutputComponents of %u "
918 "components by %u components",
919 limits.maxTessellationEvaluationOutputComponents,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700920 num_comp_out - limits.maxTessellationEvaluationOutputComponents);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200921 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700922 if (max_comp_out > static_cast<int>(limits.maxTessellationEvaluationOutputComponents)) {
Jeff Bolzf234bf82019-11-04 14:07:15 -0600923 skip |=
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600924 LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700925 "Invalid Pipeline CreateInfo State: Tessellation evaluation shader output variable uses location that "
926 "exceeds component limit VkPhysicalDeviceLimits::maxTessellationEvaluationOutputComponents (%u)",
927 limits.maxTessellationEvaluationOutputComponents);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600928 }
Nathaniel Cesario75fb7222020-12-07 10:54:53 -0700929 // Portability validation
930 if (IsExtEnabled(device_extensions.vk_khr_portability_subset)) {
931 if (is_iso_lines && (VK_FALSE == enabled_features.portability_subset_features.tessellationIsolines)) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600932 skip |= LogError(pipeline->pipeline(), kVUID_Portability_Tessellation_Isolines,
Nathaniel Cesario75fb7222020-12-07 10:54:53 -0700933 "Invalid Pipeline CreateInfo state (portability error): Tessellation evaluation shader"
934 " is using abstract patch type IsoLines, but this is not supported on this platform");
935 }
936 if (is_point_mode && (VK_FALSE == enabled_features.portability_subset_features.tessellationPointMode)) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600937 skip |= LogError(pipeline->pipeline(), kVUID_Portability_Tessellation_PointMode,
Nathaniel Cesario75fb7222020-12-07 10:54:53 -0700938 "Invalid Pipeline CreateInfo state (portability error): Tessellation evaluation shader"
939 " is using abstract patch type PointMode, but this is not supported on this platform");
940 }
941 }
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200942 break;
943
944 case VK_SHADER_STAGE_GEOMETRY_BIT:
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700945 if (num_comp_in > limits.maxGeometryInputComponents) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600946 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700947 "Invalid Pipeline CreateInfo State: Geometry shader exceeds "
948 "VkPhysicalDeviceLimits::maxGeometryInputComponents of %u "
949 "components by %u components",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700950 limits.maxGeometryInputComponents, num_comp_in - limits.maxGeometryInputComponents);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200951 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700952 if (max_comp_in > static_cast<int>(limits.maxGeometryInputComponents)) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600953 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700954 "Invalid Pipeline CreateInfo State: Geometry shader input variable uses location that "
955 "exceeds component limit VkPhysicalDeviceLimits::maxGeometryInputComponents (%u)",
956 limits.maxGeometryInputComponents);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600957 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700958 if (num_comp_out > limits.maxGeometryOutputComponents) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600959 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700960 "Invalid Pipeline CreateInfo State: Geometry shader exceeds "
961 "VkPhysicalDeviceLimits::maxGeometryOutputComponents of %u "
962 "components by %u components",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700963 limits.maxGeometryOutputComponents, num_comp_out - limits.maxGeometryOutputComponents);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200964 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700965 if (max_comp_out > static_cast<int>(limits.maxGeometryOutputComponents)) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600966 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700967 "Invalid Pipeline CreateInfo State: Geometry shader output variable uses location that "
968 "exceeds component limit VkPhysicalDeviceLimits::maxGeometryOutputComponents (%u)",
969 limits.maxGeometryOutputComponents);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600970 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700971 if (num_comp_out * num_vertices > limits.maxGeometryTotalOutputComponents) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600972 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700973 "Invalid Pipeline CreateInfo State: Geometry shader exceeds "
974 "VkPhysicalDeviceLimits::maxGeometryTotalOutputComponents of %u "
975 "components by %u components",
976 limits.maxGeometryTotalOutputComponents,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700977 num_comp_out * num_vertices - limits.maxGeometryTotalOutputComponents);
Jeff Bolze9ee3d82019-05-29 13:45:13 -0500978 }
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200979 break;
980
981 case VK_SHADER_STAGE_FRAGMENT_BIT:
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700982 if (num_comp_in > limits.maxFragmentInputComponents) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600983 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700984 "Invalid Pipeline CreateInfo State: Fragment shader exceeds "
985 "VkPhysicalDeviceLimits::maxFragmentInputComponents of %u "
986 "components by %u components",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700987 limits.maxFragmentInputComponents, num_comp_in - limits.maxFragmentInputComponents);
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200988 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700989 if (max_comp_in > static_cast<int>(limits.maxFragmentInputComponents)) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -0600990 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_ExceedDeviceLimit,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -0700991 "Invalid Pipeline CreateInfo State: Fragment shader input variable uses location that "
992 "exceeds component limit VkPhysicalDeviceLimits::maxFragmentInputComponents (%u)",
993 limits.maxFragmentInputComponents);
Jeff Bolzf234bf82019-11-04 14:07:15 -0600994 }
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +0200995 break;
996
Jeff Bolz148d94e2018-12-13 21:25:56 -0600997 case VK_SHADER_STAGE_RAYGEN_BIT_NV:
998 case VK_SHADER_STAGE_ANY_HIT_BIT_NV:
999 case VK_SHADER_STAGE_CLOSEST_HIT_BIT_NV:
1000 case VK_SHADER_STAGE_MISS_BIT_NV:
1001 case VK_SHADER_STAGE_INTERSECTION_BIT_NV:
1002 case VK_SHADER_STAGE_CALLABLE_BIT_NV:
1003 case VK_SHADER_STAGE_TASK_BIT_NV:
1004 case VK_SHADER_STAGE_MESH_BIT_NV:
1005 break;
1006
Daniel Fedai Larsenc939abc2018-08-07 10:01:58 +02001007 default:
1008 assert(false); // This should never happen
1009 }
1010 return skip;
1011}
1012
sfricke-samsungdc96f302020-03-18 20:42:10 -07001013bool CoreChecks::ValidateShaderStageMaxResources(VkShaderStageFlagBits stage, const PIPELINE_STATE *pipeline) const {
1014 bool skip = false;
1015 uint32_t total_resources = 0;
1016
1017 // Only currently testing for graphics and compute pipelines
1018 // TODO: Add check and support for Ray Tracing pipeline VUID 03428
1019 if ((stage & (VK_SHADER_STAGE_ALL_GRAPHICS | VK_SHADER_STAGE_COMPUTE_BIT)) == 0) {
1020 return false;
1021 }
1022
1023 if (stage == VK_SHADER_STAGE_FRAGMENT_BIT) {
1024 // "For the fragment shader stage the framebuffer color attachments also count against this limit"
1025 total_resources += pipeline->rp_state->createInfo.pSubpasses[pipeline->graphicsPipelineCI.subpass].colorAttachmentCount;
1026 }
1027
1028 // TODO: This reuses a lot of GetDescriptorCountMaxPerStage but currently would need to make it agnostic in a way to handle
1029 // input from CreatePipeline and CreatePipelineLayout level
1030 for (auto set_layout : pipeline->pipeline_layout->set_layouts) {
1031 if ((set_layout->GetCreateFlags() & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT) != 0) {
1032 continue;
1033 }
1034
1035 for (uint32_t binding_idx = 0; binding_idx < set_layout->GetBindingCount(); binding_idx++) {
1036 const VkDescriptorSetLayoutBinding *binding = set_layout->GetDescriptorSetLayoutBindingPtrFromIndex(binding_idx);
1037 // Bindings with a descriptorCount of 0 are "reserved" and should be skipped
1038 if (((stage & binding->stageFlags) != 0) && (binding->descriptorCount > 0)) {
1039 // Check only descriptor types listed in maxPerStageResources description in spec
1040 switch (binding->descriptorType) {
1041 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
1042 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
1043 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
1044 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
1045 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
1046 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
1047 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
1048 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
1049 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
1050 case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT:
1051 total_resources += binding->descriptorCount;
1052 break;
1053 default:
1054 break;
1055 }
1056 }
1057 }
1058 }
1059
1060 if (total_resources > phys_dev_props.limits.maxPerStageResources) {
1061 const char *vuid = (stage == VK_SHADER_STAGE_COMPUTE_BIT) ? "VUID-VkComputePipelineCreateInfo-layout-01687"
1062 : "VUID-VkGraphicsPipelineCreateInfo-layout-01688";
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001063 skip |= LogError(pipeline->pipeline(), vuid,
sfricke-samsungdc96f302020-03-18 20:42:10 -07001064 "Invalid Pipeline CreateInfo State: Shader Stage %s exceeds component limit "
1065 "VkPhysicalDeviceLimits::maxPerStageResources (%u)",
1066 string_VkShaderStageFlagBits(stage), phys_dev_props.limits.maxPerStageResources);
1067 }
1068
1069 return skip;
1070}
1071
Jeff Bolze4356752019-03-07 11:23:46 -06001072// copy the specialization constant value into buf, if it is present
1073void GetSpecConstantValue(VkPipelineShaderStageCreateInfo const *pStage, uint32_t spec_id, void *buf) {
1074 VkSpecializationInfo const *spec = pStage->pSpecializationInfo;
1075
1076 if (spec && spec_id < spec->mapEntryCount) {
1077 memcpy(buf, (uint8_t *)spec->pData + spec->pMapEntries[spec_id].offset, spec->pMapEntries[spec_id].size);
1078 }
1079}
1080
1081// Fill in value with the constant or specialization constant value, if available.
1082// Returns true if the value has been accurately filled out.
Mark Lobodzinski3c59d972019-04-25 11:28:14 -06001083static bool GetIntConstantValue(spirv_inst_iter insn, SHADER_MODULE_STATE const *src, VkPipelineShaderStageCreateInfo const *pStage,
Jeremy Gebbencbf22862021-03-03 12:01:22 -07001084 const layer_data::unordered_map<uint32_t, uint32_t> &id_to_spec_id, uint32_t *value) {
Jeff Bolze4356752019-03-07 11:23:46 -06001085 auto type_id = src->get_def(insn.word(1));
1086 if (type_id.opcode() != spv::OpTypeInt || type_id.word(2) != 32) {
1087 return false;
1088 }
1089 switch (insn.opcode()) {
1090 case spv::OpSpecConstant:
1091 *value = insn.word(3);
1092 GetSpecConstantValue(pStage, id_to_spec_id.at(insn.word(2)), value);
1093 return true;
1094 case spv::OpConstant:
1095 *value = insn.word(3);
1096 return true;
1097 default:
1098 return false;
1099 }
1100}
1101
1102// Map SPIR-V type to VK_COMPONENT_TYPE enum
Mark Lobodzinski3c59d972019-04-25 11:28:14 -06001103VkComponentTypeNV GetComponentType(spirv_inst_iter insn, SHADER_MODULE_STATE const *src) {
Jeff Bolze4356752019-03-07 11:23:46 -06001104 switch (insn.opcode()) {
1105 case spv::OpTypeInt:
1106 switch (insn.word(2)) {
1107 case 8:
1108 return insn.word(3) != 0 ? VK_COMPONENT_TYPE_SINT8_NV : VK_COMPONENT_TYPE_UINT8_NV;
1109 case 16:
1110 return insn.word(3) != 0 ? VK_COMPONENT_TYPE_SINT16_NV : VK_COMPONENT_TYPE_UINT16_NV;
1111 case 32:
1112 return insn.word(3) != 0 ? VK_COMPONENT_TYPE_SINT32_NV : VK_COMPONENT_TYPE_UINT32_NV;
1113 case 64:
1114 return insn.word(3) != 0 ? VK_COMPONENT_TYPE_SINT64_NV : VK_COMPONENT_TYPE_UINT64_NV;
1115 default:
1116 return VK_COMPONENT_TYPE_MAX_ENUM_NV;
1117 }
1118 case spv::OpTypeFloat:
1119 switch (insn.word(2)) {
1120 case 16:
1121 return VK_COMPONENT_TYPE_FLOAT16_NV;
1122 case 32:
1123 return VK_COMPONENT_TYPE_FLOAT32_NV;
1124 case 64:
1125 return VK_COMPONENT_TYPE_FLOAT64_NV;
1126 default:
1127 return VK_COMPONENT_TYPE_MAX_ENUM_NV;
1128 }
1129 default:
1130 return VK_COMPONENT_TYPE_MAX_ENUM_NV;
1131 }
1132}
1133
1134// Validate SPV_NV_cooperative_matrix behavior that can't be statically validated
1135// in SPIRV-Tools (e.g. due to specialization constant usage).
Mark Lobodzinski3c59d972019-04-25 11:28:14 -06001136bool CoreChecks::ValidateCooperativeMatrix(SHADER_MODULE_STATE const *src, VkPipelineShaderStageCreateInfo const *pStage,
John Zulaufac4c6e12019-07-01 16:05:58 -06001137 const PIPELINE_STATE *pipeline) const {
Jeff Bolze4356752019-03-07 11:23:46 -06001138 bool skip = false;
1139
1140 // Map SPIR-V result ID to specialization constant id (SpecId decoration value)
Jeremy Gebbencbf22862021-03-03 12:01:22 -07001141 layer_data::unordered_map<uint32_t, uint32_t> id_to_spec_id;
Jeff Bolze4356752019-03-07 11:23:46 -06001142 // Map SPIR-V result ID to the ID of its type.
Jeremy Gebbencbf22862021-03-03 12:01:22 -07001143 layer_data::unordered_map<uint32_t, uint32_t> id_to_type_id;
Jeff Bolze4356752019-03-07 11:23:46 -06001144
1145 struct CoopMatType {
1146 uint32_t scope, rows, cols;
1147 VkComponentTypeNV component_type;
1148 bool all_constant;
1149
1150 CoopMatType() : scope(0), rows(0), cols(0), component_type(VK_COMPONENT_TYPE_MAX_ENUM_NV), all_constant(false) {}
1151
Mark Lobodzinski3c59d972019-04-25 11:28:14 -06001152 void Init(uint32_t id, SHADER_MODULE_STATE const *src, VkPipelineShaderStageCreateInfo const *pStage,
Jeremy Gebbencbf22862021-03-03 12:01:22 -07001153 const layer_data::unordered_map<uint32_t, uint32_t> &id_to_spec_id) {
Jeff Bolze4356752019-03-07 11:23:46 -06001154 spirv_inst_iter insn = src->get_def(id);
1155 uint32_t component_type_id = insn.word(2);
1156 uint32_t scope_id = insn.word(3);
1157 uint32_t rows_id = insn.word(4);
1158 uint32_t cols_id = insn.word(5);
1159 auto component_type_iter = src->get_def(component_type_id);
1160 auto scope_iter = src->get_def(scope_id);
1161 auto rows_iter = src->get_def(rows_id);
1162 auto cols_iter = src->get_def(cols_id);
1163
1164 all_constant = true;
1165 if (!GetIntConstantValue(scope_iter, src, pStage, id_to_spec_id, &scope)) {
1166 all_constant = false;
1167 }
1168 if (!GetIntConstantValue(rows_iter, src, pStage, id_to_spec_id, &rows)) {
1169 all_constant = false;
1170 }
1171 if (!GetIntConstantValue(cols_iter, src, pStage, id_to_spec_id, &cols)) {
1172 all_constant = false;
1173 }
1174 component_type = GetComponentType(component_type_iter, src);
1175 }
1176 };
1177
1178 bool seen_coopmat_capability = false;
1179
1180 for (auto insn : *src) {
1181 // Whitelist instructions whose result can be a cooperative matrix type, and
1182 // keep track of their types. It would be nice if SPIRV-Headers generated code
1183 // to identify which instructions have a result type and result id. Lacking that,
1184 // this whitelist is based on the set of instructions that
1185 // SPV_NV_cooperative_matrix says can be used with cooperative matrix types.
1186 switch (insn.opcode()) {
1187 case spv::OpLoad:
1188 case spv::OpCooperativeMatrixLoadNV:
1189 case spv::OpCooperativeMatrixMulAddNV:
1190 case spv::OpSNegate:
1191 case spv::OpFNegate:
1192 case spv::OpIAdd:
1193 case spv::OpFAdd:
1194 case spv::OpISub:
1195 case spv::OpFSub:
1196 case spv::OpFDiv:
1197 case spv::OpSDiv:
1198 case spv::OpUDiv:
1199 case spv::OpMatrixTimesScalar:
1200 case spv::OpConstantComposite:
1201 case spv::OpCompositeConstruct:
1202 case spv::OpConvertFToU:
1203 case spv::OpConvertFToS:
1204 case spv::OpConvertSToF:
1205 case spv::OpConvertUToF:
1206 case spv::OpUConvert:
1207 case spv::OpSConvert:
1208 case spv::OpFConvert:
1209 id_to_type_id[insn.word(2)] = insn.word(1);
1210 break;
1211 default:
1212 break;
1213 }
1214
1215 switch (insn.opcode()) {
1216 case spv::OpDecorate:
1217 if (insn.word(2) == spv::DecorationSpecId) {
1218 id_to_spec_id[insn.word(1)] = insn.word(3);
1219 }
1220 break;
1221 case spv::OpCapability:
1222 if (insn.word(1) == spv::CapabilityCooperativeMatrixNV) {
1223 seen_coopmat_capability = true;
1224
1225 if (!(pStage->stage & phys_dev_ext_props.cooperative_matrix_props.cooperativeMatrixSupportedStages)) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001226 skip |= LogError(
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001227 pipeline->pipeline(), kVUID_Core_Shader_CooperativeMatrixSupportedStages,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001228 "OpTypeCooperativeMatrixNV used in shader stage not in cooperativeMatrixSupportedStages (= %u)",
1229 phys_dev_ext_props.cooperative_matrix_props.cooperativeMatrixSupportedStages);
Jeff Bolze4356752019-03-07 11:23:46 -06001230 }
1231 }
1232 break;
1233 case spv::OpMemoryModel:
1234 // If the capability isn't enabled, don't bother with the rest of this function.
1235 // OpMemoryModel is the first required instruction after all OpCapability instructions.
1236 if (!seen_coopmat_capability) {
1237 return skip;
1238 }
1239 break;
1240 case spv::OpTypeCooperativeMatrixNV: {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001241 CoopMatType m;
1242 m.Init(insn.word(1), src, pStage, id_to_spec_id);
Jeff Bolze4356752019-03-07 11:23:46 -06001243
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001244 if (m.all_constant) {
Jeff Bolze4356752019-03-07 11:23:46 -06001245 // Validate that the type parameters are all supported for one of the
1246 // operands of a cooperative matrix property.
1247 bool valid = false;
1248 for (unsigned i = 0; i < cooperative_matrix_properties.size(); ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001249 if (cooperative_matrix_properties[i].AType == m.component_type &&
1250 cooperative_matrix_properties[i].MSize == m.rows && cooperative_matrix_properties[i].KSize == m.cols &&
1251 cooperative_matrix_properties[i].scope == m.scope) {
Jeff Bolze4356752019-03-07 11:23:46 -06001252 valid = true;
1253 break;
1254 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001255 if (cooperative_matrix_properties[i].BType == m.component_type &&
1256 cooperative_matrix_properties[i].KSize == m.rows && cooperative_matrix_properties[i].NSize == m.cols &&
1257 cooperative_matrix_properties[i].scope == m.scope) {
Jeff Bolze4356752019-03-07 11:23:46 -06001258 valid = true;
1259 break;
1260 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001261 if (cooperative_matrix_properties[i].CType == m.component_type &&
1262 cooperative_matrix_properties[i].MSize == m.rows && cooperative_matrix_properties[i].NSize == m.cols &&
1263 cooperative_matrix_properties[i].scope == m.scope) {
Jeff Bolze4356752019-03-07 11:23:46 -06001264 valid = true;
1265 break;
1266 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001267 if (cooperative_matrix_properties[i].DType == m.component_type &&
1268 cooperative_matrix_properties[i].MSize == m.rows && cooperative_matrix_properties[i].NSize == m.cols &&
1269 cooperative_matrix_properties[i].scope == m.scope) {
Jeff Bolze4356752019-03-07 11:23:46 -06001270 valid = true;
1271 break;
1272 }
1273 }
1274 if (!valid) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001275 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_CooperativeMatrixType,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001276 "OpTypeCooperativeMatrixNV (result id = %u) operands don't match a supported matrix type",
1277 insn.word(1));
Jeff Bolze4356752019-03-07 11:23:46 -06001278 }
1279 }
1280 break;
1281 }
1282 case spv::OpCooperativeMatrixMulAddNV: {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001283 CoopMatType a, b, c, d;
Jeff Bolze4356752019-03-07 11:23:46 -06001284 if (id_to_type_id.find(insn.word(2)) == id_to_type_id.end() ||
1285 id_to_type_id.find(insn.word(3)) == id_to_type_id.end() ||
1286 id_to_type_id.find(insn.word(4)) == id_to_type_id.end() ||
1287 id_to_type_id.find(insn.word(5)) == id_to_type_id.end()) {
Mike Schuchardte48dc142019-04-18 09:12:03 -07001288 // Couldn't find type of matrix
1289 assert(false);
Jeff Bolze4356752019-03-07 11:23:46 -06001290 break;
1291 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001292 d.Init(id_to_type_id[insn.word(2)], src, pStage, id_to_spec_id);
1293 a.Init(id_to_type_id[insn.word(3)], src, pStage, id_to_spec_id);
1294 b.Init(id_to_type_id[insn.word(4)], src, pStage, id_to_spec_id);
1295 c.Init(id_to_type_id[insn.word(5)], src, pStage, id_to_spec_id);
Jeff Bolze4356752019-03-07 11:23:46 -06001296
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001297 if (a.all_constant && b.all_constant && c.all_constant && d.all_constant) {
Jeff Bolze4356752019-03-07 11:23:46 -06001298 // Validate that the type parameters are all supported for the same
1299 // cooperative matrix property.
1300 bool valid = false;
1301 for (unsigned i = 0; i < cooperative_matrix_properties.size(); ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001302 if (cooperative_matrix_properties[i].AType == a.component_type &&
1303 cooperative_matrix_properties[i].MSize == a.rows && cooperative_matrix_properties[i].KSize == a.cols &&
1304 cooperative_matrix_properties[i].scope == a.scope &&
Jeff Bolze4356752019-03-07 11:23:46 -06001305
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001306 cooperative_matrix_properties[i].BType == b.component_type &&
1307 cooperative_matrix_properties[i].KSize == b.rows && cooperative_matrix_properties[i].NSize == b.cols &&
1308 cooperative_matrix_properties[i].scope == b.scope &&
Jeff Bolze4356752019-03-07 11:23:46 -06001309
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001310 cooperative_matrix_properties[i].CType == c.component_type &&
1311 cooperative_matrix_properties[i].MSize == c.rows && cooperative_matrix_properties[i].NSize == c.cols &&
1312 cooperative_matrix_properties[i].scope == c.scope &&
Jeff Bolze4356752019-03-07 11:23:46 -06001313
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001314 cooperative_matrix_properties[i].DType == d.component_type &&
1315 cooperative_matrix_properties[i].MSize == d.rows && cooperative_matrix_properties[i].NSize == d.cols &&
1316 cooperative_matrix_properties[i].scope == d.scope) {
Jeff Bolze4356752019-03-07 11:23:46 -06001317 valid = true;
1318 break;
1319 }
1320 }
1321 if (!valid) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001322 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_CooperativeMatrixMulAdd,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001323 "OpCooperativeMatrixMulAddNV (result id = %u) operands don't match a supported matrix "
1324 "VkCooperativeMatrixPropertiesNV",
1325 insn.word(2));
Jeff Bolze4356752019-03-07 11:23:46 -06001326 }
1327 }
1328 break;
1329 }
1330 default:
1331 break;
1332 }
1333 }
1334
1335 return skip;
1336}
1337
Jeff Leger9b3dcff2021-05-27 15:40:20 -04001338bool CoreChecks::ValidateShaderResolveQCOM(SHADER_MODULE_STATE const *src, VkPipelineShaderStageCreateInfo const *pStage,
1339 const PIPELINE_STATE *pipeline) const {
1340 bool skip = false;
1341
1342 // If the pipeline's subpass description contains flag VK_SUBPASS_DESCRIPTION_FRAGMENT_REGION_BIT_QCOM,
1343 // then the fragment shader must not enable the SPIRV SampleRateShading capability.
1344 if (pStage->stage == VK_SHADER_STAGE_FRAGMENT_BIT) {
1345 for (auto insn : *src) {
1346 switch (insn.opcode()) {
1347 case spv::OpCapability:
1348 if (insn.word(1) == spv::CapabilitySampleRateShading) {
1349 auto subpass_flags =
1350 (pipeline->rp_state == nullptr)
1351 ? 0
1352 : pipeline->rp_state->createInfo.pSubpasses[pipeline->graphicsPipelineCI.subpass].flags;
1353 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_FRAGMENT_REGION_BIT_QCOM) != 0) {
1354 skip |=
1355 LogError(pipeline->pipeline(), kVUID_Core_Shader_ResolveQCOM_InvalidCapability,
1356 "Invalid Pipeline CreateInfo State: fragment shader enables SampleRateShading capability "
1357 "and the subpass flags includes VK_SUBPASS_DESCRIPTION_FRAGMENT_REGION_BIT_QCOM.");
1358 }
1359 }
1360 break;
1361 default:
1362 break;
1363 }
1364 }
1365 }
1366
1367 return skip;
1368}
1369
John Zulaufac4c6e12019-07-01 16:05:58 -06001370bool CoreChecks::ValidateExecutionModes(SHADER_MODULE_STATE const *src, spirv_inst_iter entrypoint) const {
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001371 auto entrypoint_id = entrypoint.word(2);
1372
Attilio Provenzanof6c0e852019-04-09 11:01:18 +01001373 // The first denorm execution mode encountered, along with its bit width.
1374 // Used to check if SeparateDenormSettings is respected.
1375 std::pair<spv::ExecutionMode, uint32_t> first_denorm_execution_mode = std::make_pair(spv::ExecutionModeMax, 0);
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001376
Attilio Provenzanof6c0e852019-04-09 11:01:18 +01001377 // The first rounding mode encountered, along with its bit width.
1378 // Used to check if SeparateRoundingModeSettings is respected.
1379 std::pair<spv::ExecutionMode, uint32_t> first_rounding_mode = std::make_pair(spv::ExecutionModeMax, 0);
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001380
1381 bool skip = false;
1382
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001383 uint32_t vertices_out = 0;
Jeff Bolze9ee3d82019-05-29 13:45:13 -05001384 uint32_t invocations = 0;
1385
sfricke-samsung8a7341a2021-02-28 07:30:21 -08001386 auto it = src->execution_mode_inst.find(entrypoint_id);
1387 if (it != src->execution_mode_inst.end()) {
1388 for (auto insn : it->second) {
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001389 auto mode = insn.word(2);
1390 switch (mode) {
1391 case spv::ExecutionModeSignedZeroInfNanPreserve: {
1392 auto bit_width = insn.word(3);
Piers Daniell41b8c5d2020-01-10 15:42:00 -07001393 if ((bit_width == 16 && !phys_dev_props_core12.shaderSignedZeroInfNanPreserveFloat16) ||
1394 (bit_width == 32 && !phys_dev_props_core12.shaderSignedZeroInfNanPreserveFloat32) ||
1395 (bit_width == 64 && !phys_dev_props_core12.shaderSignedZeroInfNanPreserveFloat64)) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001396 skip |= LogError(
1397 device, kVUID_Core_Shader_FeatureNotEnabled,
1398 "Shader requires SignedZeroInfNanPreserve for bit width %d but it is not enabled on the device",
1399 bit_width);
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001400 }
1401 break;
1402 }
1403
1404 case spv::ExecutionModeDenormPreserve: {
1405 auto bit_width = insn.word(3);
Piers Daniell41b8c5d2020-01-10 15:42:00 -07001406 if ((bit_width == 16 && !phys_dev_props_core12.shaderDenormPreserveFloat16) ||
1407 (bit_width == 32 && !phys_dev_props_core12.shaderDenormPreserveFloat32) ||
1408 (bit_width == 64 && !phys_dev_props_core12.shaderDenormPreserveFloat64)) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001409 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1410 "Shader requires DenormPreserve for bit width %d but it is not enabled on the device",
1411 bit_width);
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001412 }
1413
Attilio Provenzanof6c0e852019-04-09 11:01:18 +01001414 if (first_denorm_execution_mode.first == spv::ExecutionModeMax) {
1415 // Register the first denorm execution mode found
1416 first_denorm_execution_mode = std::make_pair(static_cast<spv::ExecutionMode>(mode), bit_width);
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001417 } else if (first_denorm_execution_mode.first != mode && first_denorm_execution_mode.second != bit_width) {
Piers Daniell41b8c5d2020-01-10 15:42:00 -07001418 switch (phys_dev_props_core12.denormBehaviorIndependence) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08001419 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_32_BIT_ONLY:
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001420 if (first_rounding_mode.second != 32 && bit_width != 32) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001421 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1422 "Shader uses different denorm execution modes for 16 and 64-bit but "
1423 "denormBehaviorIndependence is "
Mike Schuchardt2df08912020-12-15 16:28:09 -08001424 "VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_32_BIT_ONLY on the device");
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001425 }
1426 break;
1427
Mike Schuchardt2df08912020-12-15 16:28:09 -08001428 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_ALL:
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001429 break;
1430
Mike Schuchardt2df08912020-12-15 16:28:09 -08001431 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_NONE:
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001432 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1433 "Shader uses different denorm execution modes for different bit widths but "
1434 "denormBehaviorIndependence is "
Mike Schuchardt2df08912020-12-15 16:28:09 -08001435 "VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_NONE on the device");
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001436 break;
1437
1438 default:
1439 break;
1440 }
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001441 }
1442 break;
1443 }
1444
1445 case spv::ExecutionModeDenormFlushToZero: {
1446 auto bit_width = insn.word(3);
Piers Daniell41b8c5d2020-01-10 15:42:00 -07001447 if ((bit_width == 16 && !phys_dev_props_core12.shaderDenormFlushToZeroFloat16) ||
1448 (bit_width == 32 && !phys_dev_props_core12.shaderDenormFlushToZeroFloat32) ||
1449 (bit_width == 64 && !phys_dev_props_core12.shaderDenormFlushToZeroFloat64)) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001450 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1451 "Shader requires DenormFlushToZero for bit width %d but it is not enabled on the device",
1452 bit_width);
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001453 }
1454
Attilio Provenzanof6c0e852019-04-09 11:01:18 +01001455 if (first_denorm_execution_mode.first == spv::ExecutionModeMax) {
1456 // Register the first denorm execution mode found
1457 first_denorm_execution_mode = std::make_pair(static_cast<spv::ExecutionMode>(mode), bit_width);
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001458 } else if (first_denorm_execution_mode.first != mode && first_denorm_execution_mode.second != bit_width) {
Piers Daniell41b8c5d2020-01-10 15:42:00 -07001459 switch (phys_dev_props_core12.denormBehaviorIndependence) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08001460 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_32_BIT_ONLY:
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001461 if (first_rounding_mode.second != 32 && bit_width != 32) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001462 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1463 "Shader uses different denorm execution modes for 16 and 64-bit but "
1464 "denormBehaviorIndependence is "
Mike Schuchardt2df08912020-12-15 16:28:09 -08001465 "VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_32_BIT_ONLY on the device");
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001466 }
1467 break;
1468
Mike Schuchardt2df08912020-12-15 16:28:09 -08001469 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_ALL:
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001470 break;
1471
Mike Schuchardt2df08912020-12-15 16:28:09 -08001472 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_NONE:
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001473 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1474 "Shader uses different denorm execution modes for different bit widths but "
1475 "denormBehaviorIndependence is "
Mike Schuchardt2df08912020-12-15 16:28:09 -08001476 "VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_NONE on the device");
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001477 break;
1478
1479 default:
1480 break;
1481 }
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001482 }
1483 break;
1484 }
1485
1486 case spv::ExecutionModeRoundingModeRTE: {
1487 auto bit_width = insn.word(3);
Piers Daniell41b8c5d2020-01-10 15:42:00 -07001488 if ((bit_width == 16 && !phys_dev_props_core12.shaderRoundingModeRTEFloat16) ||
1489 (bit_width == 32 && !phys_dev_props_core12.shaderRoundingModeRTEFloat32) ||
1490 (bit_width == 64 && !phys_dev_props_core12.shaderRoundingModeRTEFloat64)) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001491 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1492 "Shader requires RoundingModeRTE for bit width %d but it is not enabled on the device",
1493 bit_width);
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001494 }
1495
Attilio Provenzanof6c0e852019-04-09 11:01:18 +01001496 if (first_rounding_mode.first == spv::ExecutionModeMax) {
1497 // Register the first rounding mode found
1498 first_rounding_mode = std::make_pair(static_cast<spv::ExecutionMode>(mode), bit_width);
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001499 } else if (first_rounding_mode.first != mode && first_rounding_mode.second != bit_width) {
Piers Daniell41b8c5d2020-01-10 15:42:00 -07001500 switch (phys_dev_props_core12.roundingModeIndependence) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08001501 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_32_BIT_ONLY:
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001502 if (first_rounding_mode.second != 32 && bit_width != 32) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001503 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1504 "Shader uses different rounding modes for 16 and 64-bit but "
1505 "roundingModeIndependence is "
Mike Schuchardt2df08912020-12-15 16:28:09 -08001506 "VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_32_BIT_ONLY on the device");
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001507 }
1508 break;
1509
Mike Schuchardt2df08912020-12-15 16:28:09 -08001510 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_ALL:
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001511 break;
1512
Mike Schuchardt2df08912020-12-15 16:28:09 -08001513 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_NONE:
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001514 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1515 "Shader uses different rounding modes for different bit widths but "
1516 "roundingModeIndependence is "
Mike Schuchardt2df08912020-12-15 16:28:09 -08001517 "VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_NONE on the device");
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001518 break;
1519
1520 default:
1521 break;
1522 }
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001523 }
1524 break;
1525 }
1526
1527 case spv::ExecutionModeRoundingModeRTZ: {
1528 auto bit_width = insn.word(3);
Piers Daniell41b8c5d2020-01-10 15:42:00 -07001529 if ((bit_width == 16 && !phys_dev_props_core12.shaderRoundingModeRTZFloat16) ||
1530 (bit_width == 32 && !phys_dev_props_core12.shaderRoundingModeRTZFloat32) ||
1531 (bit_width == 64 && !phys_dev_props_core12.shaderRoundingModeRTZFloat64)) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001532 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1533 "Shader requires RoundingModeRTZ for bit width %d but it is not enabled on the device",
1534 bit_width);
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001535 }
1536
Attilio Provenzanof6c0e852019-04-09 11:01:18 +01001537 if (first_rounding_mode.first == spv::ExecutionModeMax) {
1538 // Register the first rounding mode found
1539 first_rounding_mode = std::make_pair(static_cast<spv::ExecutionMode>(mode), bit_width);
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001540 } else if (first_rounding_mode.first != mode && first_rounding_mode.second != bit_width) {
Piers Daniell41b8c5d2020-01-10 15:42:00 -07001541 switch (phys_dev_props_core12.roundingModeIndependence) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08001542 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_32_BIT_ONLY:
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001543 if (first_rounding_mode.second != 32 && bit_width != 32) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001544 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1545 "Shader uses different rounding modes for 16 and 64-bit but "
1546 "roundingModeIndependence is "
Mike Schuchardt2df08912020-12-15 16:28:09 -08001547 "VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_32_BIT_ONLY on the device");
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001548 }
1549 break;
1550
Mike Schuchardt2df08912020-12-15 16:28:09 -08001551 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_ALL:
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001552 break;
1553
Mike Schuchardt2df08912020-12-15 16:28:09 -08001554 case VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_NONE:
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001555 skip |= LogError(device, kVUID_Core_Shader_FeatureNotEnabled,
1556 "Shader uses different rounding modes for different bit widths but "
1557 "roundingModeIndependence is "
Mike Schuchardt2df08912020-12-15 16:28:09 -08001558 "VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_NONE on the device");
Jason Ekstrande1e06de2019-08-05 11:43:43 -05001559 break;
1560
1561 default:
1562 break;
1563 }
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001564 }
1565 break;
1566 }
Jeff Bolze9ee3d82019-05-29 13:45:13 -05001567
1568 case spv::ExecutionModeOutputVertices: {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001569 vertices_out = insn.word(3);
Jeff Bolze9ee3d82019-05-29 13:45:13 -05001570 break;
1571 }
1572
1573 case spv::ExecutionModeInvocations: {
1574 invocations = insn.word(3);
1575 break;
1576 }
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001577 }
1578 }
1579 }
1580
Jeff Bolze9ee3d82019-05-29 13:45:13 -05001581 if (entrypoint.word(1) == spv::ExecutionModelGeometry) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001582 if (vertices_out == 0 || vertices_out > phys_dev_props.limits.maxGeometryOutputVertices) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001583 skip |= LogError(device, "VUID-VkPipelineShaderStageCreateInfo-stage-00714",
1584 "Geometry shader entry point must have an OpExecutionMode instruction that "
1585 "specifies a maximum output vertex count that is greater than 0 and less "
1586 "than or equal to maxGeometryOutputVertices. "
1587 "OutputVertices=%d, maxGeometryOutputVertices=%d",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001588 vertices_out, phys_dev_props.limits.maxGeometryOutputVertices);
Jeff Bolze9ee3d82019-05-29 13:45:13 -05001589 }
1590
1591 if (invocations == 0 || invocations > phys_dev_props.limits.maxGeometryShaderInvocations) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001592 skip |= LogError(device, "VUID-VkPipelineShaderStageCreateInfo-stage-00715",
1593 "Geometry shader entry point must have an OpExecutionMode instruction that "
1594 "specifies an invocation count that is greater than 0 and less "
1595 "than or equal to maxGeometryShaderInvocations. "
1596 "Invocations=%d, maxGeometryShaderInvocations=%d",
1597 invocations, phys_dev_props.limits.maxGeometryShaderInvocations);
Jeff Bolze9ee3d82019-05-29 13:45:13 -05001598 }
1599 }
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001600 return skip;
1601}
1602
Chris Forbes47567b72017-06-09 12:09:45 -07001603// For given pipelineLayout verify that the set_layout_node at slot.first
1604// has the requested binding at slot.second and return ptr to that binding
Mark Lobodzinskica6ebe32019-04-25 11:43:37 -06001605static VkDescriptorSetLayoutBinding const *GetDescriptorBinding(PIPELINE_LAYOUT_STATE const *pipelineLayout,
Shannon McPhersonc06c33d2018-06-28 17:21:12 -06001606 descriptor_slot_t slot) {
Chris Forbes47567b72017-06-09 12:09:45 -07001607 if (!pipelineLayout) return nullptr;
1608
1609 if (slot.first >= pipelineLayout->set_layouts.size()) return nullptr;
1610
1611 return pipelineLayout->set_layouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second);
1612}
1613
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06001614// If PointList topology is specified in the pipeline, verify that a shader geometry stage writes PointSize
1615// o If there is only a vertex shader : gl_PointSize must be written when using points
1616// o If there is a geometry or tessellation shader:
1617// - If shaderTessellationAndGeometryPointSize feature is enabled:
1618// * gl_PointSize must be written in the final geometry stage
1619// - If shaderTessellationAndGeometryPointSize feature is disabled:
1620// * gl_PointSize must NOT be written and a default of 1.0 is assumed
Mark Lobodzinski3c59d972019-04-25 11:28:14 -06001621bool CoreChecks::ValidatePointListShaderState(const PIPELINE_STATE *pipeline, SHADER_MODULE_STATE const *src,
John Zulaufac4c6e12019-07-01 16:05:58 -06001622 spirv_inst_iter entrypoint, VkShaderStageFlagBits stage) const {
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06001623 if (pipeline->topology_at_rasterizer != VK_PRIMITIVE_TOPOLOGY_POINT_LIST) {
1624 return false;
1625 }
1626
1627 bool pointsize_written = false;
1628 bool skip = false;
1629
1630 // Search for PointSize built-in decorations
sfricke-samsungc0eb5282021-02-28 23:05:55 -08001631 for (auto set : src->builtin_decoration_list) {
1632 auto insn = src->at(set.offset);
1633 if (set.builtin == spv::BuiltInPointSize) {
sfricke-samsung962cad92021-04-13 00:46:29 -07001634 pointsize_written = src->IsBuiltInWritten(insn, entrypoint);
sfricke-samsungc0eb5282021-02-28 23:05:55 -08001635 if (pointsize_written) {
1636 break;
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06001637 }
1638 }
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06001639 }
1640
1641 if ((stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT || stage == VK_SHADER_STAGE_GEOMETRY_BIT) &&
Mark Lobodzinskid7b03cc2019-04-19 14:23:10 -06001642 !enabled_features.core.shaderTessellationAndGeometryPointSize) {
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06001643 if (pointsize_written) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001644 skip |= LogError(pipeline->pipeline(), kVUID_Core_Shader_PointSizeBuiltInOverSpecified,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001645 "Pipeline topology is set to POINT_LIST and geometry or tessellation shaders write PointSize which "
1646 "is prohibited when the shaderTessellationAndGeometryPointSize feature is not enabled.");
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06001647 }
1648 } else if (!pointsize_written) {
1649 skip |=
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001650 LogError(pipeline->pipeline(), kVUID_Core_Shader_MissingPointSizeBuiltIn,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001651 "Pipeline topology is set to POINT_LIST, but PointSize is not written to in the shader corresponding to %s.",
1652 string_VkShaderStageFlagBits(stage));
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06001653 }
1654 return skip;
1655}
John Zulauf14c355b2019-06-27 16:09:37 -06001656
Tobias Hector6663c9b2020-11-05 10:18:02 +00001657bool CoreChecks::ValidatePrimitiveRateShaderState(const PIPELINE_STATE *pipeline, SHADER_MODULE_STATE const *src,
1658 spirv_inst_iter entrypoint, VkShaderStageFlagBits stage) const {
1659 bool primitiverate_written = false;
1660 bool viewportindex_written = false;
1661 bool viewportmask_written = false;
1662 bool skip = false;
1663
1664 // Check if the primitive shading rate is written
sfricke-samsungc0eb5282021-02-28 23:05:55 -08001665 for (auto set : src->builtin_decoration_list) {
1666 auto insn = src->at(set.offset);
1667 if (set.builtin == spv::BuiltInPrimitiveShadingRateKHR) {
sfricke-samsung962cad92021-04-13 00:46:29 -07001668 primitiverate_written = src->IsBuiltInWritten(insn, entrypoint);
sfricke-samsungc0eb5282021-02-28 23:05:55 -08001669 } else if (set.builtin == spv::BuiltInViewportIndex) {
sfricke-samsung962cad92021-04-13 00:46:29 -07001670 viewportindex_written = src->IsBuiltInWritten(insn, entrypoint);
sfricke-samsungc0eb5282021-02-28 23:05:55 -08001671 } else if (set.builtin == spv::BuiltInViewportMaskNV) {
sfricke-samsung962cad92021-04-13 00:46:29 -07001672 viewportmask_written = src->IsBuiltInWritten(insn, entrypoint);
Tobias Hector6663c9b2020-11-05 10:18:02 +00001673 }
sfricke-samsungc0eb5282021-02-28 23:05:55 -08001674 if (primitiverate_written && viewportindex_written && viewportmask_written) {
1675 break;
1676 }
Tobias Hector6663c9b2020-11-05 10:18:02 +00001677 }
1678
Tony-LunarGd44844c2021-01-22 13:24:37 -07001679 if (!phys_dev_ext_props.fragment_shading_rate_props.primitiveFragmentShadingRateWithMultipleViewports &&
1680 pipeline->graphicsPipelineCI.pViewportState) {
Tobias Hector6663c9b2020-11-05 10:18:02 +00001681 if (!IsDynamic(pipeline, VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) &&
1682 pipeline->graphicsPipelineCI.pViewportState->viewportCount > 1 && primitiverate_written) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001683 skip |= LogError(pipeline->pipeline(),
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001684 "VUID-VkGraphicsPipelineCreateInfo-primitiveFragmentShadingRateWithMultipleViewports-04503",
1685 "vkCreateGraphicsPipelines: %s shader statically writes to PrimitiveShadingRateKHR built-in, but "
1686 "multiple viewports "
1687 "are used and the primitiveFragmentShadingRateWithMultipleViewports limit is not supported.",
1688 string_VkShaderStageFlagBits(stage));
Tobias Hector6663c9b2020-11-05 10:18:02 +00001689 }
1690
1691 if (primitiverate_written && viewportindex_written) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001692 skip |= LogError(pipeline->pipeline(),
Tobias Hector6663c9b2020-11-05 10:18:02 +00001693 "VUID-VkGraphicsPipelineCreateInfo-primitiveFragmentShadingRateWithMultipleViewports-04504",
1694 "vkCreateGraphicsPipelines: %s shader statically writes to both PrimitiveShadingRateKHR and "
1695 "ViewportIndex built-ins,"
1696 "but the primitiveFragmentShadingRateWithMultipleViewports limit is not supported.",
1697 string_VkShaderStageFlagBits(stage));
1698 }
1699
1700 if (primitiverate_written && viewportmask_written) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001701 skip |= LogError(pipeline->pipeline(),
Tobias Hector6663c9b2020-11-05 10:18:02 +00001702 "VUID-VkGraphicsPipelineCreateInfo-primitiveFragmentShadingRateWithMultipleViewports-04505",
1703 "vkCreateGraphicsPipelines: %s shader statically writes to both PrimitiveShadingRateKHR and "
1704 "ViewportMaskNV built-ins,"
1705 "but the primitiveFragmentShadingRateWithMultipleViewports limit is not supported.",
1706 string_VkShaderStageFlagBits(stage));
1707 }
1708 }
1709 return skip;
1710}
1711
sfricke-samsung486a51e2021-01-02 00:10:15 -08001712// Validate runtime usage of various opcodes that depends on what Vulkan properties or features are exposed
sfricke-samsung94167ca2021-02-26 04:14:59 -08001713bool CoreChecks::ValidatePropertiesAndFeatures(SHADER_MODULE_STATE const *module, spirv_inst_iter &insn) const {
sfricke-samsung486a51e2021-01-02 00:10:15 -08001714 bool skip = false;
1715
sfricke-samsung94167ca2021-02-26 04:14:59 -08001716 switch (insn.opcode()) {
1717 case spv::OpReadClockKHR: {
1718 auto scope_id = module->get_def(insn.word(3));
1719 auto scope_type = scope_id.word(3);
1720 // if scope isn't Subgroup or Device, spirv-val will catch
1721 if ((scope_type == spv::ScopeSubgroup) && (enabled_features.shader_clock_feature.shaderSubgroupClock == VK_FALSE)) {
1722 skip |= LogError(device, "UNASSIGNED-spirv-shaderClock-shaderSubgroupClock",
1723 "%s: OpReadClockKHR is used with a Subgroup scope but shaderSubgroupClock was not enabled.",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001724 report_data->FormatHandle(module->vk_shader_module()).c_str());
sfricke-samsung94167ca2021-02-26 04:14:59 -08001725 } else if ((scope_type == spv::ScopeDevice) && (enabled_features.shader_clock_feature.shaderDeviceClock == VK_FALSE)) {
1726 skip |= LogError(device, "UNASSIGNED-spirv-shaderClock-shaderDeviceClock",
1727 "%s: OpReadClockKHR is used with a Device scope but shaderDeviceClock was not enabled.",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001728 report_data->FormatHandle(module->vk_shader_module()).c_str());
sfricke-samsung486a51e2021-01-02 00:10:15 -08001729 }
sfricke-samsung94167ca2021-02-26 04:14:59 -08001730 break;
sfricke-samsung486a51e2021-01-02 00:10:15 -08001731 }
1732 }
1733 return skip;
1734}
1735
John Zulauf14c355b2019-06-27 16:09:37 -06001736bool CoreChecks::ValidatePipelineShaderStage(VkPipelineShaderStageCreateInfo const *pStage, const PIPELINE_STATE *pipeline,
Jeremy Gebben159b3cc2021-06-03 09:09:03 -06001737 const PipelineStageState &stage_state, const SHADER_MODULE_STATE *module,
John Zulaufac4c6e12019-07-01 16:05:58 -06001738 const spirv_inst_iter &entrypoint, bool check_point_size) const {
John Zulauf14c355b2019-06-27 16:09:37 -06001739 bool skip = false;
1740
1741 // Check the module
1742 if (!module->has_valid_spirv) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001743 skip |= LogError(device, "VUID-VkPipelineShaderStageCreateInfo-module-parameter",
1744 "%s does not contain valid spirv for stage %s.",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001745 report_data->FormatHandle(module->vk_shader_module()).c_str(), string_VkShaderStageFlagBits(pStage->stage));
John Zulauf14c355b2019-06-27 16:09:37 -06001746 }
1747
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06001748 // If specialization-constant values are given and specialization-constant instructions are present in the shader, the
1749 // specializations should be applied and validated.
1750 if (pStage->pSpecializationInfo != nullptr && pStage->pSpecializationInfo->mapEntryCount > 0 &&
1751 pStage->pSpecializationInfo->pMapEntries != nullptr && module->has_specialization_constants) {
1752 // Gather the specialization-constant values.
1753 auto const &specialization_info = pStage->pSpecializationInfo;
Jeremy Hayes521221d2020-01-15 16:48:49 -07001754 auto const &specialization_data = reinterpret_cast<uint8_t const *>(specialization_info->pData);
Jeremy Gebbencbf22862021-03-03 12:01:22 -07001755 std::unordered_map<uint32_t, std::vector<uint32_t>> id_value_map; // note: this must be std:: to work with spvtools
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06001756 id_value_map.reserve(specialization_info->mapEntryCount);
1757 for (auto i = 0u; i < specialization_info->mapEntryCount; ++i) {
1758 auto const &map_entry = specialization_info->pMapEntries[i];
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06001759
Jeremy Hayes521221d2020-01-15 16:48:49 -07001760 // Expect only scalar types.
1761 assert(map_entry.size == 1 || map_entry.size == 2 || map_entry.size == 4 || map_entry.size == 8);
Jeremy Gebben12933ef2021-05-12 17:16:27 -06001762 if ((map_entry.offset + map_entry.size) <= specialization_info->dataSize) {
1763 auto entry = id_value_map.emplace(map_entry.constantID, std::vector<uint32_t>(map_entry.size > 4 ? 2 : 1));
1764 memcpy(entry.first->second.data(), specialization_data + map_entry.offset, map_entry.size);
1765 }
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06001766 }
1767
1768 // Apply the specialization-constant values and revalidate the shader module.
Tony-LunarG8a51b7d2020-07-01 15:57:23 -06001769 spv_target_env spirv_environment = PickSpirvEnv(api_version, (device_extensions.vk_khr_spirv_1_4 != kNotEnabled));
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06001770 spvtools::Optimizer optimizer(spirv_environment);
1771 spvtools::MessageConsumer consumer = [&skip, &module, &pStage, this](spv_message_level_t level, const char *source,
1772 const spv_position_t &position, const char *message) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001773 skip |= LogError(
1774 device, "VUID-VkPipelineShaderStageCreateInfo-module-parameter", "%s does not contain valid spirv for stage %s. %s",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001775 report_data->FormatHandle(module->vk_shader_module()).c_str(), string_VkShaderStageFlagBits(pStage->stage), message);
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06001776 };
1777 optimizer.SetMessageConsumer(consumer);
1778 optimizer.RegisterPass(spvtools::CreateSetSpecConstantDefaultValuePass(id_value_map));
1779 optimizer.RegisterPass(spvtools::CreateFreezeSpecConstantValuePass());
1780 std::vector<uint32_t> specialized_spirv;
1781 auto const optimized =
1782 optimizer.Run(module->words.data(), module->words.size(), &specialized_spirv, spvtools::ValidatorOptions(), true);
1783 assert(optimized == true);
1784
1785 if (optimized) {
1786 spv_context ctx = spvContextCreate(spirv_environment);
1787 spv_const_binary_t binary{specialized_spirv.data(), specialized_spirv.size()};
1788 spv_diagnostic diag = nullptr;
Tony-LunarG9fe69a42020-07-23 15:09:37 -06001789 spvtools::ValidatorOptions options;
1790 AdjustValidatorOptions(device_extensions, enabled_features, options);
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06001791 auto const spv_valid = spvValidateWithOptions(ctx, options, &binary, &diag);
1792 if (spv_valid != SPV_SUCCESS) {
sfricke-samsungd3793802020-08-18 22:55:03 -07001793 skip |= LogError(device, "VUID-VkPipelineShaderStageCreateInfo-module-04145",
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001794 "After specialization was applied, %s does not contain valid spirv for stage %s.",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001795 report_data->FormatHandle(module->vk_shader_module()).c_str(),
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001796 string_VkShaderStageFlagBits(pStage->stage));
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06001797 }
1798
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06001799 spvDiagnosticDestroy(diag);
1800 spvContextDestroy(ctx);
1801 }
1802 }
1803
John Zulauf14c355b2019-06-27 16:09:37 -06001804 // Check the entrypoint
1805 if (entrypoint == module->end()) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001806 skip |=
Petr Krausb0d5e592021-05-21 23:37:11 +02001807 LogError(device, "VUID-VkPipelineShaderStageCreateInfo-pName-00707", "No entrypoint found named `%s` for stage %s.",
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001808 pStage->pName, string_VkShaderStageFlagBits(pStage->stage));
John Zulauf14c355b2019-06-27 16:09:37 -06001809 }
1810 if (skip) return true; // no point continuing beyond here, any analysis is just going to be garbage.
1811
1812 // Mark accessible ids
1813 auto &accessible_ids = stage_state.accessible_ids;
1814
Chris Forbes47567b72017-06-09 12:09:45 -07001815 // Validate descriptor set layout against what the entrypoint actually uses
John Zulauf14c355b2019-06-27 16:09:37 -06001816 bool has_writable_descriptor = stage_state.has_writable_descriptor;
1817 auto &descriptor_uses = stage_state.descriptor_uses;
Chris Forbes47567b72017-06-09 12:09:45 -07001818
sfricke-samsung94167ca2021-02-26 04:14:59 -08001819 // The following tries to limit the number of passes through the shader module. The validation passes in here are "stateless"
1820 // and mainly only checking the instruction in detail for a single operation
1821 for (auto insn : *module) {
1822 skip |= ValidateShaderCapabilitiesAndExtensions(module, insn);
1823 skip |= ValidatePropertiesAndFeatures(module, insn);
1824 skip |= ValidateShaderStageGroupNonUniform(module, pStage->stage, insn);
1825 }
1826
locke-lunarg63e4daf2020-08-17 17:53:25 -06001827 skip |=
1828 ValidateShaderStageWritableOrAtomicDescriptor(pStage->stage, has_writable_descriptor, stage_state.has_atomic_descriptor);
Jeff Bolze9ee3d82019-05-29 13:45:13 -05001829 skip |= ValidateShaderStageInputOutputLimits(module, pStage, pipeline, entrypoint);
sfricke-samsungdc96f302020-03-18 20:42:10 -07001830 skip |= ValidateShaderStageMaxResources(pStage->stage, pipeline);
Attilio Provenzanoc5d50102019-03-25 17:40:37 +00001831 skip |= ValidateExecutionModes(module, entrypoint);
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -07001832 skip |= ValidateSpecializationOffsets(pStage);
Jeff Bolze54ae892018-09-08 12:16:29 -05001833 if (check_point_size && !pipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable) {
Mark Lobodzinski518eadc2019-03-09 12:07:30 -07001834 skip |= ValidatePointListShaderState(pipeline, module, entrypoint, pStage->stage);
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06001835 }
sfricke-samsungef2a68c2020-10-26 04:22:46 -07001836 skip |= ValidateBuiltinLimits(module, accessible_ids, pStage->stage);
sfricke-samsungd093e522021-02-26 04:17:45 -08001837 if (enabled_features.cooperative_matrix_features.cooperativeMatrix) {
1838 skip |= ValidateCooperativeMatrix(module, pStage, pipeline);
1839 }
Tobias Hector6663c9b2020-11-05 10:18:02 +00001840 if (enabled_features.fragment_shading_rate_features.primitiveFragmentShadingRate) {
1841 skip |= ValidatePrimitiveRateShaderState(pipeline, module, entrypoint, pStage->stage);
1842 }
Jeff Leger9b3dcff2021-05-27 15:40:20 -04001843 if (device_extensions.vk_qcom_render_pass_shader_resolve != kNotEnabled) {
1844 skip |= ValidateShaderResolveQCOM(module, pStage, pipeline);
1845 }
Chris Forbes47567b72017-06-09 12:09:45 -07001846
sfricke-samsung7699b912021-04-12 23:01:51 -07001847 // "layout must be consistent with the layout of the * shader"
1848 // 'consistent' -> #descriptorsets-pipelinelayout-consistency
locke-lunarg9a16ebb2020-07-30 16:56:33 -06001849 std::string vuid_layout_mismatch;
1850 if (pipeline->graphicsPipelineCI.sType == VK_STRUCTURE_TYPE_GRAPHICS_PIPELINE_CREATE_INFO) {
1851 vuid_layout_mismatch = "VUID-VkGraphicsPipelineCreateInfo-layout-00756";
1852 } else if (pipeline->computePipelineCI.sType == VK_STRUCTURE_TYPE_COMPUTE_PIPELINE_CREATE_INFO) {
1853 vuid_layout_mismatch = "VUID-VkComputePipelineCreateInfo-layout-00703";
1854 } else if (pipeline->raytracingPipelineCI.sType == VK_STRUCTURE_TYPE_RAY_TRACING_PIPELINE_CREATE_INFO_KHR) {
1855 vuid_layout_mismatch = "VUID-VkRayTracingPipelineCreateInfoKHR-layout-03427";
1856 } else if (pipeline->raytracingPipelineCI.sType == VK_STRUCTURE_TYPE_RAY_TRACING_PIPELINE_CREATE_INFO_NV) {
1857 vuid_layout_mismatch = "VUID-VkRayTracingPipelineCreateInfoNV-layout-03427";
1858 }
1859
sfricke-samsung7699b912021-04-12 23:01:51 -07001860 // Validate Push Constants use
1861 skip |= ValidatePushConstantUsage(*pipeline, module, pStage, vuid_layout_mismatch);
1862
Chris Forbes47567b72017-06-09 12:09:45 -07001863 // Validate descriptor use
1864 for (auto use : descriptor_uses) {
Chris Forbes47567b72017-06-09 12:09:45 -07001865 // Verify given pipelineLayout has requested setLayout with requested binding
Jeff Bolze7fc67b2019-10-04 12:29:31 -05001866 const auto &binding = GetDescriptorBinding(pipeline->pipeline_layout.get(), use.first);
Chris Forbes47567b72017-06-09 12:09:45 -07001867 unsigned required_descriptor_count;
sourav parmarcd5fb182020-07-17 12:58:44 -07001868 bool is_khr = binding && binding->descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR;
1869 std::set<uint32_t> descriptor_types =
1870 TypeToDescriptorTypeSet(module, use.second.type_id, required_descriptor_count, is_khr);
Chris Forbes47567b72017-06-09 12:09:45 -07001871
1872 if (!binding) {
locke-lunarg9a16ebb2020-07-30 16:56:33 -06001873 skip |= LogError(device, vuid_layout_mismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001874 "Shader uses descriptor slot %u.%u (expected `%s`) but not declared in pipeline layout",
1875 use.first.first, use.first.second, string_descriptorTypes(descriptor_types).c_str());
Chris Forbes47567b72017-06-09 12:09:45 -07001876 } else if (~binding->stageFlags & pStage->stage) {
locke-lunarg9a16ebb2020-07-30 16:56:33 -06001877 skip |= LogError(device, vuid_layout_mismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001878 "Shader uses descriptor slot %u.%u but descriptor not accessible from stage %s", use.first.first,
1879 use.first.second, string_VkShaderStageFlagBits(pStage->stage));
Tony-LunarGf563b362021-03-18 16:13:18 -06001880 } else if ((binding->descriptorType != VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) &&
1881 (descriptor_types.find(binding->descriptorType) == descriptor_types.end())) {
locke-lunarg9a16ebb2020-07-30 16:56:33 -06001882 skip |= LogError(device, vuid_layout_mismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001883 "Type mismatch on descriptor slot %u.%u (expected `%s`) but descriptor of type %s", use.first.first,
1884 use.first.second, string_descriptorTypes(descriptor_types).c_str(),
1885 string_VkDescriptorType(binding->descriptorType));
Chris Forbes47567b72017-06-09 12:09:45 -07001886 } else if (binding->descriptorCount < required_descriptor_count) {
locke-lunarg9a16ebb2020-07-30 16:56:33 -06001887 skip |= LogError(device, vuid_layout_mismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001888 "Shader expects at least %u descriptors for binding %u.%u but only %u provided",
1889 required_descriptor_count, use.first.first, use.first.second, binding->descriptorCount);
Chris Forbes47567b72017-06-09 12:09:45 -07001890 }
1891 }
1892
1893 // Validate use of input attachments against subpass structure
1894 if (pStage->stage == VK_SHADER_STAGE_FRAGMENT_BIT) {
sfricke-samsung962cad92021-04-13 00:46:29 -07001895 auto input_attachment_uses = module->CollectInterfaceByInputAttachmentIndex(accessible_ids);
Chris Forbes47567b72017-06-09 12:09:45 -07001896
Petr Krause91f7a12017-12-14 20:57:36 +01001897 auto rpci = pipeline->rp_state->createInfo.ptr();
Chris Forbes47567b72017-06-09 12:09:45 -07001898 auto subpass = pipeline->graphicsPipelineCI.subpass;
1899
1900 for (auto use : input_attachment_uses) {
1901 auto input_attachments = rpci->pSubpasses[subpass].pInputAttachments;
1902 auto index = (input_attachments && use.first < rpci->pSubpasses[subpass].inputAttachmentCount)
Dave Houltona9df0ce2018-02-07 10:51:23 -07001903 ? input_attachments[use.first].attachment
1904 : VK_ATTACHMENT_UNUSED;
Chris Forbes47567b72017-06-09 12:09:45 -07001905
1906 if (index == VK_ATTACHMENT_UNUSED) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001907 skip |= LogError(device, kVUID_Core_Shader_MissingInputAttachment,
1908 "Shader consumes input attachment index %d but not provided in subpass", use.first);
sfricke-samsung962cad92021-04-13 00:46:29 -07001909 } else if (!(GetFormatType(rpci->pAttachments[index].format) & module->GetFundamentalType(use.second.type_id))) {
Chris Forbes47567b72017-06-09 12:09:45 -07001910 skip |=
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001911 LogError(device, kVUID_Core_Shader_InputAttachmentTypeMismatch,
1912 "Subpass input attachment %u format of %s does not match type used in shader `%s`", use.first,
sfricke-samsung962cad92021-04-13 00:46:29 -07001913 string_VkFormat(rpci->pAttachments[index].format), module->DescribeType(use.second.type_id).c_str());
Chris Forbes47567b72017-06-09 12:09:45 -07001914 }
1915 }
1916 }
Lockeaa8fdc02019-04-02 11:59:20 -06001917 if (pStage->stage == VK_SHADER_STAGE_COMPUTE_BIT) {
sfricke-samsung8a7341a2021-02-28 07:30:21 -08001918 skip |= ValidateComputeWorkGroupSizes(module, entrypoint);
Lockeaa8fdc02019-04-02 11:59:20 -06001919 }
Chris Forbes47567b72017-06-09 12:09:45 -07001920 return skip;
1921}
1922
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -07001923bool CoreChecks::ValidateInterfaceBetweenStages(SHADER_MODULE_STATE const *producer, spirv_inst_iter producer_entrypoint,
1924 shader_stage_attributes const *producer_stage, SHADER_MODULE_STATE const *consumer,
1925 spirv_inst_iter consumer_entrypoint,
1926 shader_stage_attributes const *consumer_stage) const {
Chris Forbes47567b72017-06-09 12:09:45 -07001927 bool skip = false;
1928
1929 auto outputs =
sfricke-samsung962cad92021-04-13 00:46:29 -07001930 producer->CollectInterfaceByLocation(producer_entrypoint, spv::StorageClassOutput, producer_stage->arrayed_output);
1931 auto inputs = consumer->CollectInterfaceByLocation(consumer_entrypoint, spv::StorageClassInput, consumer_stage->arrayed_input);
Chris Forbes47567b72017-06-09 12:09:45 -07001932
1933 auto a_it = outputs.begin();
1934 auto b_it = inputs.begin();
1935
1936 // Maps sorted by key (location); walk them together to find mismatches
1937 while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) {
1938 bool a_at_end = outputs.size() == 0 || a_it == outputs.end();
1939 bool b_at_end = inputs.size() == 0 || b_it == inputs.end();
1940 auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first;
1941 auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first;
1942
1943 if (b_at_end || ((!a_at_end) && (a_first < b_first))) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001944 skip |= LogPerformanceWarning(producer->vk_shader_module(), kVUID_Core_Shader_OutputNotConsumed,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001945 "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name,
1946 a_first.first, a_first.second, consumer_stage->name);
Chris Forbes47567b72017-06-09 12:09:45 -07001947 a_it++;
1948 } else if (a_at_end || a_first > b_first) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001949 skip |= LogError(consumer->vk_shader_module(), kVUID_Core_Shader_InputNotProduced,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001950 "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first,
1951 b_first.second, producer_stage->name);
Chris Forbes47567b72017-06-09 12:09:45 -07001952 b_it++;
1953 } else {
1954 // subtleties of arrayed interfaces:
1955 // - if is_patch, then the member is not arrayed, even though the interface may be.
1956 // - if is_block_member, then the extra array level of an arrayed interface is not
1957 // expressed in the member type -- it's expressed in the block type.
Shannon McPhersonc06c33d2018-06-28 17:21:12 -06001958 if (!TypesMatch(producer, consumer, a_it->second.type_id, b_it->second.type_id,
1959 producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member,
1960 consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, true)) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001961 skip |= LogError(producer->vk_shader_module(), kVUID_Core_Shader_InterfaceTypeMismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001962 "Type mismatch on location %u.%u: '%s' vs '%s'", a_first.first, a_first.second,
sfricke-samsung962cad92021-04-13 00:46:29 -07001963 producer->DescribeType(a_it->second.type_id).c_str(),
1964 consumer->DescribeType(b_it->second.type_id).c_str());
Chris Forbes47567b72017-06-09 12:09:45 -07001965 }
1966 if (a_it->second.is_patch != b_it->second.is_patch) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001967 skip |= LogError(producer->vk_shader_module(), kVUID_Core_Shader_InterfaceTypeMismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001968 "Decoration mismatch on location %u.%u: is per-%s in %s stage but per-%s in %s stage",
1969 a_first.first, a_first.second, a_it->second.is_patch ? "patch" : "vertex", producer_stage->name,
1970 b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name);
Chris Forbes47567b72017-06-09 12:09:45 -07001971 }
1972 if (a_it->second.is_relaxed_precision != b_it->second.is_relaxed_precision) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001973 skip |= LogError(producer->vk_shader_module(), kVUID_Core_Shader_InterfaceTypeMismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001974 "Decoration mismatch on location %u.%u: %s and %s stages differ in precision", a_first.first,
1975 a_first.second, producer_stage->name, consumer_stage->name);
Chris Forbes47567b72017-06-09 12:09:45 -07001976 }
1977 a_it++;
1978 b_it++;
1979 }
1980 }
1981
Ari Suonpaa696b3432019-03-11 14:02:57 +02001982 if (consumer_stage->stage != VK_SHADER_STAGE_FRAGMENT_BIT) {
sfricke-samsung962cad92021-04-13 00:46:29 -07001983 auto builtins_producer = producer->CollectBuiltinBlockMembers(producer_entrypoint, spv::StorageClassOutput);
1984 auto builtins_consumer = consumer->CollectBuiltinBlockMembers(consumer_entrypoint, spv::StorageClassInput);
Ari Suonpaa696b3432019-03-11 14:02:57 +02001985
1986 if (!builtins_producer.empty() && !builtins_consumer.empty()) {
1987 if (builtins_producer.size() != builtins_consumer.size()) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001988 skip |= LogError(producer->vk_shader_module(), kVUID_Core_Shader_InterfaceTypeMismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001989 "Number of elements inside builtin block differ between stages (%s %d vs %s %d).",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001990 producer_stage->name, static_cast<int>(builtins_producer.size()), consumer_stage->name,
1991 static_cast<int>(builtins_consumer.size()));
Ari Suonpaa696b3432019-03-11 14:02:57 +02001992 } else {
1993 auto it_producer = builtins_producer.begin();
1994 auto it_consumer = builtins_consumer.begin();
1995 while (it_producer != builtins_producer.end() && it_consumer != builtins_consumer.end()) {
1996 if (*it_producer != *it_consumer) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06001997 skip |= LogError(producer->vk_shader_module(), kVUID_Core_Shader_InterfaceTypeMismatch,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07001998 "Builtin variable inside block doesn't match between %s and %s.", producer_stage->name,
1999 consumer_stage->name);
Ari Suonpaa696b3432019-03-11 14:02:57 +02002000 break;
2001 }
2002 it_producer++;
2003 it_consumer++;
2004 }
2005 }
2006 }
2007 }
2008
Chris Forbes47567b72017-06-09 12:09:45 -07002009 return skip;
2010}
2011
John Zulauf14c355b2019-06-27 16:09:37 -06002012static inline uint32_t DetermineFinalGeomStage(const PIPELINE_STATE *pipeline, const VkGraphicsPipelineCreateInfo *pCreateInfo) {
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06002013 uint32_t stage_mask = 0;
2014 if (pipeline->topology_at_rasterizer == VK_PRIMITIVE_TOPOLOGY_POINT_LIST) {
2015 for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) {
2016 stage_mask |= pCreateInfo->pStages[i].stage;
2017 }
2018 // Determine which shader in which PointSize should be written (the final geometry stage)
Jeff Bolz105d6492018-09-29 15:46:44 -05002019 if (stage_mask & VK_SHADER_STAGE_MESH_BIT_NV) {
2020 stage_mask = VK_SHADER_STAGE_MESH_BIT_NV;
2021 } else if (stage_mask & VK_SHADER_STAGE_GEOMETRY_BIT) {
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06002022 stage_mask = VK_SHADER_STAGE_GEOMETRY_BIT;
2023 } else if (stage_mask & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
2024 stage_mask = VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT;
2025 } else if (stage_mask & VK_SHADER_STAGE_VERTEX_BIT) {
2026 stage_mask = VK_SHADER_STAGE_VERTEX_BIT;
Mark Lobodzinski2c984cc2018-07-31 09:57:46 -06002027 }
2028 }
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06002029 return stage_mask;
Mark Lobodzinski2c984cc2018-07-31 09:57:46 -06002030}
2031
Chris Forbes47567b72017-06-09 12:09:45 -07002032// Validate that the shaders used by the given pipeline and store the active_slots
2033// that are actually used by the pipeline into pPipeline->active_slots
John Zulaufac4c6e12019-07-01 16:05:58 -06002034bool CoreChecks::ValidateGraphicsPipelineShaderState(const PIPELINE_STATE *pipeline) const {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002035 auto create_info = pipeline->graphicsPipelineCI.ptr();
Shannon McPhersonc06c33d2018-06-28 17:21:12 -06002036 int vertex_stage = GetShaderStageId(VK_SHADER_STAGE_VERTEX_BIT);
2037 int fragment_stage = GetShaderStageId(VK_SHADER_STAGE_FRAGMENT_BIT);
Chris Forbes47567b72017-06-09 12:09:45 -07002038
John Zulauf14c355b2019-06-27 16:09:37 -06002039 const SHADER_MODULE_STATE *shaders[32];
Chris Forbes47567b72017-06-09 12:09:45 -07002040 memset(shaders, 0, sizeof(shaders));
Jeff Bolz7e35c392018-09-04 15:30:41 -05002041 spirv_inst_iter entrypoints[32];
Chris Forbes47567b72017-06-09 12:09:45 -07002042 bool skip = false;
2043
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002044 uint32_t pointlist_stage_mask = DetermineFinalGeomStage(pipeline, create_info);
Mark Lobodzinski1b4a8ed2018-08-07 08:47:05 -06002045
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002046 for (uint32_t i = 0; i < create_info->stageCount; i++) {
2047 auto stage = &create_info->pStages[i];
2048 auto stage_id = GetShaderStageId(stage->stage);
2049 shaders[stage_id] = GetShaderModuleState(stage->module);
sfricke-samsung962cad92021-04-13 00:46:29 -07002050 entrypoints[stage_id] = shaders[stage_id]->FindEntrypoint(stage->pName, stage->stage);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002051 skip |= ValidatePipelineShaderStage(stage, pipeline, pipeline->stage_state[i], shaders[stage_id], entrypoints[stage_id],
2052 (pointlist_stage_mask == stage->stage));
Chris Forbes47567b72017-06-09 12:09:45 -07002053 }
2054
2055 // if the shader stages are no good individually, cross-stage validation is pointless.
2056 if (skip) return true;
2057
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002058 auto vi = create_info->pVertexInputState;
Chris Forbes47567b72017-06-09 12:09:45 -07002059
2060 if (vi) {
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -07002061 skip |= ValidateViConsistency(vi);
Chris Forbes47567b72017-06-09 12:09:45 -07002062 }
2063
Piers Daniell924cd832021-05-18 13:48:47 -06002064 if (shaders[vertex_stage] && shaders[vertex_stage]->has_valid_spirv &&
2065 !IsDynamic(pipeline, VK_DYNAMIC_STATE_VERTEX_INPUT_EXT)) {
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -07002066 skip |= ValidateViAgainstVsInputs(vi, shaders[vertex_stage], entrypoints[vertex_stage]);
Chris Forbes47567b72017-06-09 12:09:45 -07002067 }
2068
Shannon McPhersonc06c33d2018-06-28 17:21:12 -06002069 int producer = GetShaderStageId(VK_SHADER_STAGE_VERTEX_BIT);
2070 int consumer = GetShaderStageId(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT);
Chris Forbes47567b72017-06-09 12:09:45 -07002071
2072 while (!shaders[producer] && producer != fragment_stage) {
2073 producer++;
2074 consumer++;
2075 }
2076
2077 for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) {
2078 assert(shaders[producer]);
Chris Forbesdbb43fc2018-02-16 16:59:23 -08002079 if (shaders[consumer]) {
2080 if (shaders[consumer]->has_valid_spirv && shaders[producer]->has_valid_spirv) {
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -07002081 skip |= ValidateInterfaceBetweenStages(shaders[producer], entrypoints[producer], &shader_stage_attribs[producer],
2082 shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]);
Chris Forbesdbb43fc2018-02-16 16:59:23 -08002083 }
Chris Forbes47567b72017-06-09 12:09:45 -07002084
2085 producer = consumer;
2086 }
2087 }
2088
2089 if (shaders[fragment_stage] && shaders[fragment_stage]->has_valid_spirv) {
Mark Lobodzinskid8d658e2020-01-30 15:05:51 -07002090 skip |= ValidateFsOutputsAgainstRenderPass(shaders[fragment_stage], entrypoints[fragment_stage], pipeline,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002091 create_info->subpass);
Chris Forbes47567b72017-06-09 12:09:45 -07002092 }
2093
2094 return skip;
2095}
2096
Tony-LunarGb2ded512021-02-02 16:03:30 -07002097void CoreChecks::RecordGraphicsPipelineShaderDynamicState(PIPELINE_STATE *pipeline_state) {
2098 auto create_info = pipeline_state->graphicsPipelineCI.ptr();
2099
2100 if (phys_dev_ext_props.fragment_shading_rate_props.primitiveFragmentShadingRateWithMultipleViewports ||
2101 !IsDynamic(pipeline_state, VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT)) {
2102 return;
2103 }
Tobias Hector6663c9b2020-11-05 10:18:02 +00002104
Nathaniel Cesario1c3d3652021-01-25 18:35:12 -07002105 std::array<const SHADER_MODULE_STATE *, 32> shaders;
2106 std::fill(shaders.begin(), shaders.end(), nullptr);
Tobias Hector6663c9b2020-11-05 10:18:02 +00002107 spirv_inst_iter entrypoints[32];
Tobias Hector6663c9b2020-11-05 10:18:02 +00002108
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002109 for (uint32_t i = 0; i < create_info->stageCount; i++) {
2110 auto stage = &create_info->pStages[i];
2111 auto stage_id = GetShaderStageId(stage->stage);
2112 shaders[stage_id] = GetShaderModuleState(stage->module);
sfricke-samsung962cad92021-04-13 00:46:29 -07002113 entrypoints[stage_id] = shaders[stage_id]->FindEntrypoint(stage->pName, stage->stage);
Tobias Hector6663c9b2020-11-05 10:18:02 +00002114
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002115 if (stage->stage == VK_SHADER_STAGE_VERTEX_BIT || stage->stage == VK_SHADER_STAGE_GEOMETRY_BIT ||
2116 stage->stage == VK_SHADER_STAGE_MESH_BIT_NV) {
Tony-LunarGb2ded512021-02-02 16:03:30 -07002117 bool primitiverate_written = false;
Tobias Hector6663c9b2020-11-05 10:18:02 +00002118
sfricke-samsungc0eb5282021-02-28 23:05:55 -08002119 for (auto set : shaders[stage_id]->builtin_decoration_list) {
2120 auto insn = shaders[stage_id]->at(set.offset);
2121 if (set.builtin == spv::BuiltInPrimitiveShadingRateKHR) {
sfricke-samsung962cad92021-04-13 00:46:29 -07002122 primitiverate_written = shaders[stage_id]->IsBuiltInWritten(insn, entrypoints[stage_id]);
Tobias Hector6663c9b2020-11-05 10:18:02 +00002123 }
sfricke-samsungc0eb5282021-02-28 23:05:55 -08002124 if (primitiverate_written) {
2125 break;
2126 }
Tony-LunarGb2ded512021-02-02 16:03:30 -07002127 }
sfricke-samsungc0eb5282021-02-28 23:05:55 -08002128
Tony-LunarGb2ded512021-02-02 16:03:30 -07002129 if (primitiverate_written) {
2130 pipeline_state->wrote_primitive_shading_rate.insert(stage->stage);
2131 }
2132 }
2133 }
2134}
2135
2136bool CoreChecks::ValidateGraphicsPipelineShaderDynamicState(const PIPELINE_STATE *pipeline, const CMD_BUFFER_STATE *pCB,
2137 const char *caller, const DrawDispatchVuid &vuid) const {
2138 auto create_info = pipeline->graphicsPipelineCI.ptr();
2139 bool skip = false;
2140
2141 for (uint32_t i = 0; i < create_info->stageCount; i++) {
2142 auto stage = &create_info->pStages[i];
2143 if (stage->stage == VK_SHADER_STAGE_VERTEX_BIT || stage->stage == VK_SHADER_STAGE_GEOMETRY_BIT ||
2144 stage->stage == VK_SHADER_STAGE_MESH_BIT_NV) {
2145 if (!phys_dev_ext_props.fragment_shading_rate_props.primitiveFragmentShadingRateWithMultipleViewports &&
2146 IsDynamic(pipeline, VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) && pCB->viewportWithCountCount != 1) {
2147 if (pipeline->wrote_primitive_shading_rate.find(stage->stage) != pipeline->wrote_primitive_shading_rate.end()) {
Tobias Hector6663c9b2020-11-05 10:18:02 +00002148 skip |=
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06002149 LogError(pipeline->pipeline(), vuid.viewport_count_primitive_shading_rate,
Tobias Hector6663c9b2020-11-05 10:18:02 +00002150 "%s: %s shader of currently bound pipeline statically writes to PrimitiveShadingRateKHR built-in"
2151 "but multiple viewports are set by the last call to vkCmdSetViewportWithCountEXT,"
2152 "and the primitiveFragmentShadingRateWithMultipleViewports limit is not supported.",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002153 caller, string_VkShaderStageFlagBits(stage->stage));
Tobias Hector6663c9b2020-11-05 10:18:02 +00002154 }
2155 }
2156 }
2157 }
2158
2159 return skip;
2160}
2161
sfricke-samsunge72a85e2020-02-29 21:48:37 -08002162bool CoreChecks::ValidateComputePipelineShaderState(PIPELINE_STATE *pipeline) const {
John Zulauf14c355b2019-06-27 16:09:37 -06002163 const auto &stage = *pipeline->computePipelineCI.stage.ptr();
Chris Forbes47567b72017-06-09 12:09:45 -07002164
John Zulauf14c355b2019-06-27 16:09:37 -06002165 const SHADER_MODULE_STATE *module = GetShaderModuleState(stage.module);
sfricke-samsung962cad92021-04-13 00:46:29 -07002166 const spirv_inst_iter entrypoint = module->FindEntrypoint(stage.pName, stage.stage);
Chris Forbes47567b72017-06-09 12:09:45 -07002167
John Zulauf14c355b2019-06-27 16:09:37 -06002168 return ValidatePipelineShaderStage(&stage, pipeline, pipeline->stage_state[0], module, entrypoint, false);
Chris Forbes47567b72017-06-09 12:09:45 -07002169}
Chris Forbes4ae55b32017-06-09 14:42:56 -07002170
Ricardo Garcia6f3477e2020-10-21 10:58:53 +02002171uint32_t CoreChecks::CalcShaderStageCount(const PIPELINE_STATE *pipeline, VkShaderStageFlagBits stageBit) const {
2172 uint32_t total = 0;
2173
2174 const auto *stages = pipeline->raytracingPipelineCI.ptr()->pStages;
2175 for (uint32_t stage_index = 0; stage_index < pipeline->raytracingPipelineCI.stageCount; stage_index++) {
2176 if (stages[stage_index].stage == stageBit) {
2177 total++;
2178 }
2179 }
2180
2181 if (pipeline->raytracingPipelineCI.pLibraryInfo) {
2182 for (uint32_t i = 0; i < pipeline->raytracingPipelineCI.pLibraryInfo->libraryCount; ++i) {
2183 const PIPELINE_STATE *library_pipeline = GetPipelineState(pipeline->raytracingPipelineCI.pLibraryInfo->pLibraries[i]);
2184 total += CalcShaderStageCount(library_pipeline, stageBit);
2185 }
2186 }
2187
2188 return total;
2189}
2190
sourav parmarcd5fb182020-07-17 12:58:44 -07002191bool CoreChecks::ValidateRayTracingPipeline(PIPELINE_STATE *pipeline, VkPipelineCreateFlags flags, bool isKHR) const {
John Zulaufe4474e72019-07-01 17:28:27 -06002192 bool skip = false;
Jason Macnak15f95e82019-08-21 21:52:02 -04002193
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002194 if (isKHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07002195 if (pipeline->raytracingPipelineCI.maxPipelineRayRecursionDepth >
2196 phys_dev_ext_props.ray_tracing_propsKHR.maxRayRecursionDepth) {
2197 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-maxPipelineRayRecursionDepth-03589",
2198 "vkCreateRayTracingPipelinesKHR: maxPipelineRayRecursionDepth (%d ) must be less than or equal to "
2199 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayRecursionDepth %d",
2200 pipeline->raytracingPipelineCI.maxPipelineRayRecursionDepth,
2201 phys_dev_ext_props.ray_tracing_propsKHR.maxRayRecursionDepth);
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002202 }
sourav parmarcd5fb182020-07-17 12:58:44 -07002203 if (pipeline->raytracingPipelineCI.pLibraryInfo) {
2204 for (uint32_t i = 0; i < pipeline->raytracingPipelineCI.pLibraryInfo->libraryCount; ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002205 const PIPELINE_STATE *library_pipelinestate =
sourav parmarcd5fb182020-07-17 12:58:44 -07002206 GetPipelineState(pipeline->raytracingPipelineCI.pLibraryInfo->pLibraries[i]);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002207 if (library_pipelinestate->raytracingPipelineCI.maxPipelineRayRecursionDepth !=
sourav parmarcd5fb182020-07-17 12:58:44 -07002208 pipeline->raytracingPipelineCI.maxPipelineRayRecursionDepth) {
2209 skip |= LogError(
2210 device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraries-03591",
2211 "vkCreateRayTracingPipelinesKHR: Each element (%d) of the pLibraries member of libraries must have been"
2212 "created with the value of maxPipelineRayRecursionDepth (%d) equal to that in this pipeline (%d) .",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002213 i, library_pipelinestate->raytracingPipelineCI.maxPipelineRayRecursionDepth,
sourav parmarcd5fb182020-07-17 12:58:44 -07002214 pipeline->raytracingPipelineCI.maxPipelineRayRecursionDepth);
2215 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002216 if (library_pipelinestate->raytracingPipelineCI.pLibraryInfo &&
2217 (library_pipelinestate->raytracingPipelineCI.pLibraryInterface->maxPipelineRayHitAttributeSize !=
sourav parmarcd5fb182020-07-17 12:58:44 -07002218 pipeline->raytracingPipelineCI.pLibraryInterface->maxPipelineRayHitAttributeSize ||
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002219 library_pipelinestate->raytracingPipelineCI.pLibraryInterface->maxPipelineRayPayloadSize !=
sourav parmarcd5fb182020-07-17 12:58:44 -07002220 pipeline->raytracingPipelineCI.pLibraryInterface->maxPipelineRayPayloadSize)) {
2221 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03593",
2222 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL, each element of its pLibraries "
2223 "member must have been created with values of the maxPipelineRayPayloadSize and "
2224 "maxPipelineRayHitAttributeSize members of pLibraryInterface equal to those in this pipeline");
2225 }
2226 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) &&
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002227 !(library_pipelinestate->raytracingPipelineCI.flags &
sourav parmarcd5fb182020-07-17 12:58:44 -07002228 VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR)) {
2229 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03594",
2230 "vkCreateRayTracingPipelinesKHR: If flags includes "
2231 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR, each element of "
2232 "the pLibraries member of libraries must have been created with the "
2233 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR bit set");
2234 }
sourav parmar83c31b12020-05-06 12:30:54 -07002235 }
2236 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002237 } else {
2238 if (pipeline->raytracingPipelineCI.maxRecursionDepth > phys_dev_ext_props.ray_tracing_propsNV.maxRecursionDepth) {
sourav parmarcd5fb182020-07-17 12:58:44 -07002239 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-maxRecursionDepth-03457",
2240 "vkCreateRayTracingPipelinesNV: maxRecursionDepth (%d) must be less than or equal to "
2241 "VkPhysicalDeviceRayTracingPropertiesNV::maxRecursionDepth (%d)",
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002242 pipeline->raytracingPipelineCI.maxRecursionDepth,
2243 phys_dev_ext_props.ray_tracing_propsNV.maxRecursionDepth);
2244 }
Jason Macnak15f95e82019-08-21 21:52:02 -04002245 }
Jason Macnak15f95e82019-08-21 21:52:02 -04002246 const auto *stages = pipeline->raytracingPipelineCI.ptr()->pStages;
2247 const auto *groups = pipeline->raytracingPipelineCI.ptr()->pGroups;
2248
John Zulaufe4474e72019-07-01 17:28:27 -06002249 for (uint32_t stage_index = 0; stage_index < pipeline->raytracingPipelineCI.stageCount; stage_index++) {
Jason Macnak15f95e82019-08-21 21:52:02 -04002250 const auto &stage = stages[stage_index];
Jeff Bolzfbe51582018-09-13 10:01:35 -05002251
John Zulaufe4474e72019-07-01 17:28:27 -06002252 const SHADER_MODULE_STATE *module = GetShaderModuleState(stage.module);
sfricke-samsung962cad92021-04-13 00:46:29 -07002253 const spirv_inst_iter entrypoint = module->FindEntrypoint(stage.pName, stage.stage);
Jeff Bolzfbe51582018-09-13 10:01:35 -05002254
John Zulaufe4474e72019-07-01 17:28:27 -06002255 skip |= ValidatePipelineShaderStage(&stage, pipeline, pipeline->stage_state[stage_index], module, entrypoint, false);
Jason Macnak15f95e82019-08-21 21:52:02 -04002256 }
Ricardo Garcia6f3477e2020-10-21 10:58:53 +02002257
2258 if ((pipeline->raytracingPipelineCI.flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) == 0) {
2259 const uint32_t raygen_stages_count = CalcShaderStageCount(pipeline, VK_SHADER_STAGE_RAYGEN_BIT_KHR);
2260 if (raygen_stages_count == 0) {
2261 skip |= LogError(
2262 device,
2263 isKHR ? "VUID-VkRayTracingPipelineCreateInfoKHR-stage-03425" : "VUID-VkRayTracingPipelineCreateInfoNV-stage-03425",
2264 " : The stage member of at least one element of pStages must be VK_SHADER_STAGE_RAYGEN_BIT_KHR.");
2265 }
Jason Macnak15f95e82019-08-21 21:52:02 -04002266 }
2267
2268 for (uint32_t group_index = 0; group_index < pipeline->raytracingPipelineCI.groupCount; group_index++) {
2269 const auto &group = groups[group_index];
2270
2271 if (group.type == VK_RAY_TRACING_SHADER_GROUP_TYPE_GENERAL_NV) {
2272 if (group.generalShader >= pipeline->raytracingPipelineCI.stageCount ||
2273 (stages[group.generalShader].stage != VK_SHADER_STAGE_RAYGEN_BIT_NV &&
2274 stages[group.generalShader].stage != VK_SHADER_STAGE_MISS_BIT_NV &&
2275 stages[group.generalShader].stage != VK_SHADER_STAGE_CALLABLE_BIT_NV)) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002276 skip |= LogError(device,
2277 isKHR ? "VUID-VkRayTracingShaderGroupCreateInfoKHR-type-03474"
2278 : "VUID-VkRayTracingShaderGroupCreateInfoNV-type-02413",
2279 ": pGroups[%d]", group_index);
Jason Macnak15f95e82019-08-21 21:52:02 -04002280 }
2281 if (group.anyHitShader != VK_SHADER_UNUSED_NV || group.closestHitShader != VK_SHADER_UNUSED_NV ||
2282 group.intersectionShader != VK_SHADER_UNUSED_NV) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002283 skip |= LogError(device,
2284 isKHR ? "VUID-VkRayTracingShaderGroupCreateInfoKHR-type-03475"
2285 : "VUID-VkRayTracingShaderGroupCreateInfoNV-type-02414",
2286 ": pGroups[%d]", group_index);
Jason Macnak15f95e82019-08-21 21:52:02 -04002287 }
2288 } else if (group.type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_NV) {
2289 if (group.intersectionShader >= pipeline->raytracingPipelineCI.stageCount ||
2290 stages[group.intersectionShader].stage != VK_SHADER_STAGE_INTERSECTION_BIT_NV) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002291 skip |= LogError(device,
2292 isKHR ? "VUID-VkRayTracingShaderGroupCreateInfoKHR-type-03476"
2293 : "VUID-VkRayTracingShaderGroupCreateInfoNV-type-02415",
2294 ": pGroups[%d]", group_index);
Jason Macnak15f95e82019-08-21 21:52:02 -04002295 }
2296 } else if (group.type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_NV) {
2297 if (group.intersectionShader != VK_SHADER_UNUSED_NV) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002298 skip |= LogError(device,
2299 isKHR ? "VUID-VkRayTracingShaderGroupCreateInfoKHR-type-03477"
2300 : "VUID-VkRayTracingShaderGroupCreateInfoNV-type-02416",
2301 ": pGroups[%d]", group_index);
Jason Macnak15f95e82019-08-21 21:52:02 -04002302 }
2303 }
2304
2305 if (group.type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_NV ||
2306 group.type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_NV) {
2307 if (group.anyHitShader != VK_SHADER_UNUSED_NV && (group.anyHitShader >= pipeline->raytracingPipelineCI.stageCount ||
2308 stages[group.anyHitShader].stage != VK_SHADER_STAGE_ANY_HIT_BIT_NV)) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002309 skip |= LogError(device,
2310 isKHR ? "VUID-VkRayTracingShaderGroupCreateInfoKHR-anyHitShader-03479"
2311 : "VUID-VkRayTracingShaderGroupCreateInfoNV-anyHitShader-02418",
2312 ": pGroups[%d]", group_index);
Jason Macnak15f95e82019-08-21 21:52:02 -04002313 }
2314 if (group.closestHitShader != VK_SHADER_UNUSED_NV &&
2315 (group.closestHitShader >= pipeline->raytracingPipelineCI.stageCount ||
2316 stages[group.closestHitShader].stage != VK_SHADER_STAGE_CLOSEST_HIT_BIT_NV)) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05002317 skip |= LogError(device,
2318 isKHR ? "VUID-VkRayTracingShaderGroupCreateInfoKHR-closestHitShader-03478"
2319 : "VUID-VkRayTracingShaderGroupCreateInfoNV-closestHitShader-02417",
2320 ": pGroups[%d]", group_index);
Jason Macnak15f95e82019-08-21 21:52:02 -04002321 }
2322 }
John Zulaufe4474e72019-07-01 17:28:27 -06002323 }
2324 return skip;
Jeff Bolzfbe51582018-09-13 10:01:35 -05002325}
2326
Dave Houltona9df0ce2018-02-07 10:51:23 -07002327uint32_t ValidationCache::MakeShaderHash(VkShaderModuleCreateInfo const *smci) { return XXH32(smci->pCode, smci->codeSize, 0); }
Chris Forbes9a61e082017-07-24 15:35:29 -07002328
Dave Houltona9df0ce2018-02-07 10:51:23 -07002329static ValidationCache *GetValidationCacheInfo(VkShaderModuleCreateInfo const *pCreateInfo) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002330 const auto validation_cache_ci = LvlFindInChain<VkShaderModuleValidationCacheCreateInfoEXT>(pCreateInfo->pNext);
John Zulauf25ea2432019-04-05 10:07:38 -06002331 if (validation_cache_ci) {
John Zulauf146ee802019-04-05 15:31:06 -06002332 return CastFromHandle<ValidationCache *>(validation_cache_ci->validationCache);
Chris Forbes9a61e082017-07-24 15:35:29 -07002333 }
Chris Forbes9a61e082017-07-24 15:35:29 -07002334 return nullptr;
2335}
2336
Mark Lobodzinskib56bbb92019-02-18 11:49:59 -07002337bool CoreChecks::PreCallValidateCreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002338 const VkAllocationCallbacks *pAllocator, VkShaderModule *pShaderModule) const {
Chris Forbes4ae55b32017-06-09 14:42:56 -07002339 bool skip = false;
2340 spv_result_t spv_valid = SPV_SUCCESS;
Chris Forbes4ae55b32017-06-09 14:42:56 -07002341
Mark Lobodzinski90eea5b2020-05-15 12:54:00 -06002342 if (disabled[shader_validation]) {
Chris Forbes4ae55b32017-06-09 14:42:56 -07002343 return false;
2344 }
2345
Mark Lobodzinskif45e45f2019-04-19 14:15:39 -06002346 auto have_glsl_shader = device_extensions.vk_nv_glsl_shader;
Chris Forbes4ae55b32017-06-09 14:42:56 -07002347
2348 if (!have_glsl_shader && (pCreateInfo->codeSize % 4)) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002349 skip |= LogError(device, "VUID-VkShaderModuleCreateInfo-pCode-01376",
2350 "SPIR-V module not valid: Codesize must be a multiple of 4 but is " PRINTF_SIZE_T_SPECIFIER ".",
2351 pCreateInfo->codeSize);
Chris Forbes4ae55b32017-06-09 14:42:56 -07002352 } else {
Chris Forbes9a61e082017-07-24 15:35:29 -07002353 auto cache = GetValidationCacheInfo(pCreateInfo);
2354 uint32_t hash = 0;
Tony-LunarG55fdf1e2021-01-13 14:32:56 -07002355 // If app isn't using a shader validation cache, use the default one from CoreChecks
2356 if (!cache) cache = CastFromHandle<ValidationCache *>(core_validation_cache);
Chris Forbes9a61e082017-07-24 15:35:29 -07002357 if (cache) {
2358 hash = ValidationCache::MakeShaderHash(pCreateInfo);
Dave Houltona9df0ce2018-02-07 10:51:23 -07002359 if (cache->Contains(hash)) return false;
Chris Forbes9a61e082017-07-24 15:35:29 -07002360 }
2361
Jeremy Hayesb3e4d532019-08-16 10:08:49 -06002362 // Use SPIRV-Tools validator to try and catch any issues with the module itself. If specialization constants are present,
2363 // the default values will be used during validation.
Tony-LunarG8a51b7d2020-07-01 15:57:23 -06002364 spv_target_env spirv_environment = PickSpirvEnv(api_version, (device_extensions.vk_khr_spirv_1_4 != kNotEnabled));
Dave Houlton0ea2d012018-06-21 14:00:26 -06002365 spv_context ctx = spvContextCreate(spirv_environment);
Dave Houltona9df0ce2018-02-07 10:51:23 -07002366 spv_const_binary_t binary{pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t)};
Chris Forbes4ae55b32017-06-09 14:42:56 -07002367 spv_diagnostic diag = nullptr;
Tony-LunarG9fe69a42020-07-23 15:09:37 -06002368 spvtools::ValidatorOptions options;
2369 AdjustValidatorOptions(device_extensions, enabled_features, options);
Karl Schultzfda1b382018-08-08 18:56:11 -06002370 spv_valid = spvValidateWithOptions(ctx, options, &binary, &diag);
Chris Forbes4ae55b32017-06-09 14:42:56 -07002371 if (spv_valid != SPV_SUCCESS) {
2372 if (!have_glsl_shader || (pCreateInfo->pCode[0] == spv::MagicNumber)) {
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002373 if (spv_valid == SPV_WARNING) {
2374 skip |= LogWarning(device, kVUID_Core_Shader_InconsistentSpirv, "SPIR-V module not valid: %s",
2375 diag && diag->error ? diag->error : "(no error text)");
2376 } else {
2377 skip |= LogError(device, kVUID_Core_Shader_InconsistentSpirv, "SPIR-V module not valid: %s",
2378 diag && diag->error ? diag->error : "(no error text)");
2379 }
Chris Forbes4ae55b32017-06-09 14:42:56 -07002380 }
Chris Forbes9a61e082017-07-24 15:35:29 -07002381 } else {
2382 if (cache) {
2383 cache->Insert(hash);
2384 }
Chris Forbes4ae55b32017-06-09 14:42:56 -07002385 }
2386
2387 spvDiagnosticDestroy(diag);
2388 spvContextDestroy(ctx);
2389 }
2390
Chris Forbes4ae55b32017-06-09 14:42:56 -07002391 return skip;
Mark Lobodzinski01734072019-02-13 17:39:15 -07002392}
2393
sfricke-samsung8a7341a2021-02-28 07:30:21 -08002394bool CoreChecks::ValidateComputeWorkGroupSizes(const SHADER_MODULE_STATE *shader, const spirv_inst_iter &entrypoint) const {
Lockeaa8fdc02019-04-02 11:59:20 -06002395 bool skip = false;
2396 uint32_t local_size_x = 0;
2397 uint32_t local_size_y = 0;
2398 uint32_t local_size_z = 0;
sfricke-samsung962cad92021-04-13 00:46:29 -07002399 if (shader->FindLocalSize(entrypoint, local_size_x, local_size_y, local_size_z)) {
Lockeaa8fdc02019-04-02 11:59:20 -06002400 if (local_size_x > phys_dev_props.limits.maxComputeWorkGroupSize[0]) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06002401 skip |= LogError(shader->vk_shader_module(), "UNASSIGNED-features-limits-maxComputeWorkGroupSize",
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002402 "%s local_size_x (%" PRIu32 ") exceeds device limit maxComputeWorkGroupSize[0] (%" PRIu32 ").",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06002403 report_data->FormatHandle(shader->vk_shader_module()).c_str(), local_size_x,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002404 phys_dev_props.limits.maxComputeWorkGroupSize[0]);
Lockeaa8fdc02019-04-02 11:59:20 -06002405 }
2406 if (local_size_y > phys_dev_props.limits.maxComputeWorkGroupSize[1]) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06002407 skip |= LogError(shader->vk_shader_module(), "UNASSIGNED-features-limits-maxComputeWorkGroupSize",
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002408 "%s local_size_y (%" PRIu32 ") exceeds device limit maxComputeWorkGroupSize[1] (%" PRIu32 ").",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06002409 report_data->FormatHandle(shader->vk_shader_module()).c_str(), local_size_x,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002410 phys_dev_props.limits.maxComputeWorkGroupSize[1]);
Lockeaa8fdc02019-04-02 11:59:20 -06002411 }
2412 if (local_size_z > phys_dev_props.limits.maxComputeWorkGroupSize[2]) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06002413 skip |= LogError(shader->vk_shader_module(), "UNASSIGNED-features-limits-maxComputeWorkGroupSize",
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002414 "%s local_size_z (%" PRIu32 ") exceeds device limit maxComputeWorkGroupSize[2] (%" PRIu32 ").",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06002415 report_data->FormatHandle(shader->vk_shader_module()).c_str(), local_size_x,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002416 phys_dev_props.limits.maxComputeWorkGroupSize[2]);
Lockeaa8fdc02019-04-02 11:59:20 -06002417 }
2418
2419 uint32_t limit = phys_dev_props.limits.maxComputeWorkGroupInvocations;
2420 uint64_t invocations = local_size_x * local_size_y;
2421 // Prevent overflow.
2422 bool fail = false;
2423 if (invocations > UINT32_MAX || invocations > limit) {
2424 fail = true;
2425 }
2426 if (!fail) {
2427 invocations *= local_size_z;
2428 if (invocations > UINT32_MAX || invocations > limit) {
2429 fail = true;
2430 }
2431 }
2432 if (fail) {
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06002433 skip |= LogError(shader->vk_shader_module(), "UNASSIGNED-features-limits-maxComputeWorkGroupInvocations",
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002434 "%s local_size (%" PRIu32 ", %" PRIu32 ", %" PRIu32
2435 ") exceeds device limit maxComputeWorkGroupInvocations (%" PRIu32 ").",
Jeremy Gebben14b0d1a2021-05-15 20:15:41 -06002436 report_data->FormatHandle(shader->vk_shader_module()).c_str(), local_size_x, local_size_y, local_size_z,
Mark Lobodzinski12b9be92020-01-30 15:25:55 -07002437 limit);
Lockeaa8fdc02019-04-02 11:59:20 -06002438 }
2439 }
2440 return skip;
2441}
Tony-LunarG8a51b7d2020-07-01 15:57:23 -06002442
2443spv_target_env PickSpirvEnv(uint32_t api_version, bool spirv_1_4) {
2444 if (api_version >= VK_API_VERSION_1_2) {
2445 return SPV_ENV_VULKAN_1_2;
2446 } else if (api_version >= VK_API_VERSION_1_1) {
2447 if (spirv_1_4) {
2448 return SPV_ENV_VULKAN_1_1_SPIRV_1_4;
2449 } else {
2450 return SPV_ENV_VULKAN_1_1;
2451 }
2452 }
2453 return SPV_ENV_VULKAN_1_0;
2454}
Tony-LunarG9fe69a42020-07-23 15:09:37 -06002455
Jeremy Gebben5d970742021-05-31 16:04:14 -06002456void AdjustValidatorOptions(const DeviceExtensions &device_extensions, const DeviceFeatures &enabled_features,
Tony-LunarG9fe69a42020-07-23 15:09:37 -06002457 spvtools::ValidatorOptions &options) {
2458 if (device_extensions.vk_khr_relaxed_block_layout) {
2459 options.SetRelaxBlockLayout(true);
2460 }
2461 if (device_extensions.vk_khr_uniform_buffer_standard_layout && enabled_features.core12.uniformBufferStandardLayout == VK_TRUE) {
2462 options.SetUniformBufferStandardLayout(true);
2463 }
2464 if (device_extensions.vk_ext_scalar_block_layout && enabled_features.core12.scalarBlockLayout == VK_TRUE) {
2465 options.SetScalarBlockLayout(true);
2466 }
Caio Marcelo de Oliveira Filhod1bfbcd2021-01-27 01:44:04 -08002467 if (device_extensions.vk_khr_workgroup_memory_explicit_layout &&
2468 enabled_features.workgroup_memory_explicit_layout_features.workgroupMemoryExplicitLayoutScalarBlockLayout) {
2469 options.SetWorkgroupScalarBlockLayout(true);
2470 }
Tony-LunarG9fe69a42020-07-23 15:09:37 -06002471}