blob: 435070e5cedff19e01b2fcf762629367f3ab0f3f [file] [log] [blame]
aitor-lunargd5301592022-01-05 22:38:16 +01001/* Copyright (c) 2015-2022 The Khronos Group Inc.
2 * Copyright (c) 2015-2022 Valve Corporation
3 * Copyright (c) 2015-2022 LunarG, Inc.
4 * Copyright (C) 2015-2022 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
sfricke-samsung2e827212021-09-28 07:52:08 -070027#include "core_validation_error_enums.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010028
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070029static const int kMaxParamCheckerStringLength = 256;
Mark Lobodzinskid4950072017-08-01 13:02:20 -060030
John Zulauf71968502017-10-26 13:51:15 -060031template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070032inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060033 // Using only < for generality and || for early abort
34 return !((value < min) || (max < value));
35}
36
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -060037ReadLockGuard StatelessValidation::ReadLock() { return ReadLockGuard(validation_object_mutex, std::defer_lock); }
38WriteLockGuard StatelessValidation::WriteLock() { return WriteLockGuard(validation_object_mutex, std::defer_lock); }
Mark Lobodzinski21b91fe2020-12-03 15:44:24 -070039
Jeremy Gebbencbf22862021-03-03 12:01:22 -070040static layer_data::unordered_map<VkCommandBuffer, VkCommandPool> secondary_cb_map{};
Tony-LunarG3c287f62020-12-17 12:39:49 -070041static ReadWriteLock secondary_cb_map_mutex;
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -060042static ReadLockGuard CBReadLock() { return ReadLockGuard(secondary_cb_map_mutex); }
43static WriteLockGuard CBWriteLock() { return WriteLockGuard(secondary_cb_map_mutex); }
Tony-LunarG3c287f62020-12-17 12:39:49 -070044
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070045bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050046 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 bool skip = false;
48
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070049 VkStringErrorFlags result = vk_string_validate(kMaxParamCheckerStringLength, validateString);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050
51 if (result == VK_STRING_ERROR_NONE) {
52 return skip;
53 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070054 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070055 kMaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060056 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070057 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
58 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060059 }
60 return skip;
61}
62
Jeff Bolz46c0ea02019-10-09 13:06:29 -050063bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060064 bool skip = false;
65 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
66 if (api_version_nopatch != effective_api_version) {
sfricke-samsung6aec21b2020-11-01 07:49:43 -080067 if ((api_version_nopatch < VK_API_VERSION_1_0) && (api_version != 0)) {
68 skip |= LogError(instance, "VUID-VkApplicationInfo-apiVersion-04010",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070069 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
70 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
71 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060072 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070073 skip |= LogWarning(instance, kVUIDUndefined,
74 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
75 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
76 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060077 }
78 }
79 return skip;
80}
81
Jeff Bolz46c0ea02019-10-09 13:06:29 -050082bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060083 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060084 // Create and use a local instance extension object, as an actual instance has not been created yet
85 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
86 InstanceExtensions local_instance_extensions;
87 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
88
John Zulauf620755c2018-04-16 11:00:43 -060089 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060090 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
91 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060092 }
93
94 return skip;
95}
96
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060097bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
Mike Schuchardtc57de4a2021-07-20 17:26:32 -070098 if (instance_extensions.vk_khr_get_physical_device_properties2) {
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060099 // Struct is legal IF it's supported
100 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
101 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
102 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
103 if (enum_iter != dev_exts_enumerated->second.cend()) {
104 return true;
105 }
106 }
107 return false;
108}
109
Tony-LunarG866843d2020-05-13 11:22:42 -0600110bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
111 const VkValidationFeaturesEXT *validation_features) const {
112 bool skip = false;
113 bool debug_printf = false;
114 bool gpu_assisted = false;
115 bool reserve_slot = false;
116 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
117 switch (validation_features->pEnabledValidationFeatures[i]) {
118 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
119 gpu_assisted = true;
120 break;
121
122 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
123 debug_printf = true;
124 break;
125
126 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
127 reserve_slot = true;
128 break;
129
130 default:
131 break;
132 }
133 }
134 if (reserve_slot && !gpu_assisted) {
135 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
136 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
137 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
138 }
139 if (gpu_assisted && debug_printf) {
140 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
141 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
142 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
143 }
144
145 return skip;
146}
147
John Zulauf620755c2018-04-16 11:00:43 -0600148template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700149ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
150 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600151 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700152 ExtEnabled state =
153 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600154 return state;
155}
156
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700157bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500158 const VkAllocationCallbacks *pAllocator,
159 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700160 bool skip = false;
161 // Note: From the spec--
162 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
163 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
164 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700165 ? pCreateInfo->pApplicationInfo->apiVersion
166 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700167 skip |= validate_api_version(local_api_version, api_version);
168 skip |= validate_instance_extensions(pCreateInfo);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700169 const auto *validation_features = LvlFindInChain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
Tony-LunarG866843d2020-05-13 11:22:42 -0600170 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
171
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700172 return skip;
173}
174
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700175void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700176 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
177 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700178 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
179 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700180 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700181 this->instance_extensions = instance_data->instance_extensions;
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700182}
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600183
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700184void StatelessValidation::CommonPostCallRecordEnumeratePhysicalDevice(const VkPhysicalDevice *phys_devices, const int count) {
185 // Assume phys_devices is valid
186 assert(phys_devices);
187 for (int i = 0; i < count; ++i) {
188 const auto &phys_device = phys_devices[i];
189 if (0 == physical_device_properties_map.count(phys_device)) {
190 auto phys_dev_props = new VkPhysicalDeviceProperties;
191 DispatchGetPhysicalDeviceProperties(phys_device, phys_dev_props);
192 physical_device_properties_map[phys_device] = phys_dev_props;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600193
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700194 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
195 uint32_t ext_count = 0;
Jeremy Gebbencbf22862021-03-03 12:01:22 -0700196 layer_data::unordered_set<std::string> dev_exts_enumerated{};
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700197 std::vector<VkExtensionProperties> ext_props{};
198 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, nullptr);
199 ext_props.resize(ext_count);
200 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, ext_props.data());
201 for (uint32_t j = 0; j < ext_count; j++) {
202 dev_exts_enumerated.insert(ext_props[j].extensionName);
203 }
204 device_extensions_enumerated[phys_device] = std::move(dev_exts_enumerated);
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600205 }
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700206 }
207}
208
209void StatelessValidation::PostCallRecordEnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount,
210 VkPhysicalDevice *pPhysicalDevices, VkResult result) {
211 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
212 return;
213 }
214
215 if (pPhysicalDeviceCount && pPhysicalDevices) {
216 CommonPostCallRecordEnumeratePhysicalDevice(pPhysicalDevices, *pPhysicalDeviceCount);
217 }
218}
219
220void StatelessValidation::PostCallRecordEnumeratePhysicalDeviceGroups(
221 VkInstance instance, uint32_t *pPhysicalDeviceGroupCount, VkPhysicalDeviceGroupProperties *pPhysicalDeviceGroupProperties,
222 VkResult result) {
223 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
224 return;
225 }
226
227 if (pPhysicalDeviceGroupCount && pPhysicalDeviceGroupProperties) {
228 for (uint32_t i = 0; i < *pPhysicalDeviceGroupCount; i++) {
229 const auto &group = pPhysicalDeviceGroupProperties[i];
230 CommonPostCallRecordEnumeratePhysicalDevice(group.physicalDevices, group.physicalDeviceCount);
231 }
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600232 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700233}
234
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600235void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
236 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
237 delete (it->second);
238 it = physical_device_properties_map.erase(it);
239 }
240};
241
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700242void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700243 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700244 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700245 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700246 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
247 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700248
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700249 // Parmeter validation also uses extension data
250 stateless_validation->device_extensions = this->device_extensions;
251
252 VkPhysicalDeviceProperties device_properties = {};
253 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600254 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700255 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
256
sfricke-samsung45996a42021-09-16 13:45:27 -0700257 if (IsExtEnabled(device_extensions.vk_nv_shading_rate_image)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700258 // Get the needed shading rate image limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700259 auto shading_rate_image_props = LvlInitStruct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
260 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600261 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700262 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
263 }
264
sfricke-samsung45996a42021-09-16 13:45:27 -0700265 if (IsExtEnabled(device_extensions.vk_nv_mesh_shader)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700266 // Get the needed mesh shader limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700267 auto mesh_shader_props = LvlInitStruct<VkPhysicalDeviceMeshShaderPropertiesNV>();
268 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600269 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700270 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
271 }
272
sfricke-samsung45996a42021-09-16 13:45:27 -0700273 if (IsExtEnabled(device_extensions.vk_nv_ray_tracing)) {
Jason Macnak5c954952019-07-09 15:46:12 -0700274 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700275 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPropertiesNV>();
276 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jason Macnak5c954952019-07-09 15:46:12 -0700277 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500278 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
279 }
280
sfricke-samsung45996a42021-09-16 13:45:27 -0700281 if (IsExtEnabled(device_extensions.vk_khr_ray_tracing_pipeline)) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500282 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700283 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPipelinePropertiesKHR>();
284 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500285 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
286 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700287 }
288
sfricke-samsung45996a42021-09-16 13:45:27 -0700289 if (IsExtEnabled(device_extensions.vk_khr_acceleration_structure)) {
sourav parmarcd5fb182020-07-17 12:58:44 -0700290 // Get the needed ray tracing acc structure limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700291 auto acc_structure_props = LvlInitStruct<VkPhysicalDeviceAccelerationStructurePropertiesKHR>();
292 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&acc_structure_props);
sourav parmarcd5fb182020-07-17 12:58:44 -0700293 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
294 phys_dev_ext_props.acc_structure_props = acc_structure_props;
295 }
296
sfricke-samsung45996a42021-09-16 13:45:27 -0700297 if (IsExtEnabled(device_extensions.vk_ext_transform_feedback)) {
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700298 // Get the needed transform feedback limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700299 auto transform_feedback_props = LvlInitStruct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
300 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&transform_feedback_props);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700301 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
302 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
303 }
304
sfricke-samsung45996a42021-09-16 13:45:27 -0700305 if (IsExtEnabled(device_extensions.vk_ext_vertex_attribute_divisor)) {
Piers Daniellcb6d8032021-04-19 18:51:26 -0600306 // Get the needed vertex attribute divisor limits
307 auto vertex_attribute_divisor_props = LvlInitStruct<VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT>();
308 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&vertex_attribute_divisor_props);
309 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
310 phys_dev_ext_props.vertex_attribute_divisor_props = vertex_attribute_divisor_props;
311 }
312
sfricke-samsung45996a42021-09-16 13:45:27 -0700313 if (IsExtEnabled(device_extensions.vk_ext_blend_operation_advanced)) {
Piers Daniella7f93b62021-11-20 12:32:04 -0700314 // Get the needed blend operation advanced properties
ziga-lunarga283d022021-08-04 18:35:23 +0200315 auto blend_operation_advanced_props = LvlInitStruct<VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT>();
316 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&blend_operation_advanced_props);
317 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
318 phys_dev_ext_props.blend_operation_advanced_props = blend_operation_advanced_props;
319 }
320
Piers Daniella7f93b62021-11-20 12:32:04 -0700321 if (IsExtEnabled(device_extensions.vk_khr_maintenance4)) {
322 // Get the needed maintenance4 properties
323 auto maintance4_props = LvlInitStruct<VkPhysicalDeviceMaintenance4PropertiesKHR>();
324 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&maintance4_props);
325 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
326 phys_dev_ext_props.maintenance4_props = maintance4_props;
327 }
328
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800329 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
330
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700331 // Save app-enabled features in this device's validation object
332 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700333 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200334 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
335 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
336 if (features2) {
337 tmp_features2_state.features = features2->features;
338 } else if (pCreateInfo->pEnabledFeatures) {
339 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700340 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200341 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700342 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200343 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700344 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200345 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700346}
347
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700348bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500349 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600350 bool skip = false;
351
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200352 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
353 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
354 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600355 }
356
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700357 // If this device supports VK_KHR_portability_subset, it must be enabled
358 const std::string portability_extension_name("VK_KHR_portability_subset");
359 const auto &dev_extensions = device_extensions_enumerated.at(physicalDevice);
360 const bool portability_supported = dev_extensions.count(portability_extension_name) != 0;
361 bool portability_requested = false;
362
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200363 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
364 skip |=
365 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
366 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
367 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
368 pCreateInfo->ppEnabledExtensionNames[i]);
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700369 if (portability_extension_name == pCreateInfo->ppEnabledExtensionNames[i]) {
370 portability_requested = true;
371 }
372 }
373
374 if (portability_supported && !portability_requested) {
375 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-pProperties-04451",
376 "vkCreateDevice: VK_KHR_portability_subset must be enabled because physical device %s supports it",
377 report_data->FormatHandle(physicalDevice).c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600378 }
379
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200380 {
aitor-lunargd5301592022-01-05 22:38:16 +0100381 bool maint1 = IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE_1_EXTENSION_NAME));
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700382 bool negative_viewport =
aitor-lunargd5301592022-01-05 22:38:16 +0100383 IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
384 if (negative_viewport) {
385 // Only need to check for VK_KHR_MAINTENANCE_1_EXTENSION_NAME if api version is 1.0, otherwise it's deprecated due to
386 // integration into api version 1.1
387 if (api_version >= VK_API_VERSION_1_1) {
388 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-01840",
389 "vkCreateDevice(): VkDeviceCreateInfo->ppEnabledExtensionNames must not include "
390 "VK_AMD_negative_viewport_height if api version is greater than or equal to 1.1.");
391 } else if (maint1) {
392 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
393 "vkCreateDevice(): VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include "
394 "VK_KHR_maintenance1 and VK_AMD_negative_viewport_height.");
395 }
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200396 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600397 }
398
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600399 {
ziga-lunarg9271a7c2021-07-19 16:37:06 +0200400 bool khr_bda =
401 IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
402 bool ext_bda =
403 IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600404 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700405 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
406 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
407 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600408 }
409 }
410
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600411 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
412 // Check for get_physical_device_properties2 struct
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700413 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -0600414 if (features2) {
Mike Schuchardt2df08912020-12-15 16:28:09 -0800415 // Cannot include VkPhysicalDeviceFeatures2 and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700416 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mike Schuchardt2df08912020-12-15 16:28:09 -0800417 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct when "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700418 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600419 }
420 }
421
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700422 auto features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500423 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700424 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500425 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
426 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
427 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
428 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700429 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(pCreateInfo->pNext);
sourav parmarcd5fb182020-07-17 12:58:44 -0700430 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplayMixed &&
431 !raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay) {
432 skip |= LogError(
433 device,
434 "VUID-VkPhysicalDeviceRayTracingPipelineFeaturesKHR-rayTracingPipelineShaderGroupHandleCaptureReplayMixed-03575",
435 "If rayTracingPipelineShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingPipelineShaderGroupHandleCaptureReplay "
436 "must also be VK_TRUE.");
sourav parmara24fb7b2020-05-26 10:50:04 -0700437 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700438 auto vertex_attribute_divisor_features = LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
sfricke-samsung45996a42021-09-16 13:45:27 -0700439 if (vertex_attribute_divisor_features && (!IsExtEnabled(device_extensions.vk_ext_vertex_attribute_divisor))) {
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600440 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
441 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
442 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600443 }
444
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700445 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700446 if (vulkan_11_features) {
447 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
448 while (current) {
449 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
450 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
451 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
452 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
453 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
454 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700455 skip |= LogError(
456 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700457 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
458 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
459 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
460 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
461 break;
462 }
463 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
464 }
sfricke-samsungebda6792021-01-16 08:57:52 -0800465
466 // Check features are enabled if matching extension is passed in as well
467 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
468 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
469 if ((0 == strncmp(extension, VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
470 (vulkan_11_features->shaderDrawParameters == VK_FALSE)) {
471 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800472 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-04476",
sfricke-samsungebda6792021-01-16 08:57:52 -0800473 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan11Features::shaderDrawParameters is not VK_TRUE.",
474 VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME);
475 }
476 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700477 }
478
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700479 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700480 if (vulkan_12_features) {
481 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
482 while (current) {
483 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
484 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
485 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
486 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
487 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
488 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
489 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
490 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
491 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
492 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
493 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
494 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
495 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700496 skip |= LogError(
497 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700498 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
499 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
500 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
501 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
502 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
503 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
504 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
505 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
506 break;
507 }
508 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
509 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700510 // Check features are enabled if matching extension is passed in as well
511 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
512 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
513 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
514 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
515 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800516 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02831",
sfricke-samsungabab4632020-05-04 06:51:46 -0700517 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
518 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
519 }
520 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
521 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
Mike Schuchardt9969d022021-12-20 15:51:55 -0800522 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02832",
sfricke-samsungabab4632020-05-04 06:51:46 -0700523 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
524 "is not VK_TRUE.",
525 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
526 }
527 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
528 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
529 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800530 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02833",
sfricke-samsungabab4632020-05-04 06:51:46 -0700531 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
532 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
533 }
534 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
535 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
536 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800537 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02834",
sfricke-samsungabab4632020-05-04 06:51:46 -0700538 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
539 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
540 }
541 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
542 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
543 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
544 skip |=
Mike Schuchardt9969d022021-12-20 15:51:55 -0800545 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02835",
sfricke-samsungabab4632020-05-04 06:51:46 -0700546 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
547 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
548 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
549 }
550 }
ziga-lunarg27f88fd2021-08-01 15:47:30 +0200551 if (vulkan_12_features->bufferDeviceAddress == VK_TRUE) {
552 if (IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME))) {
553 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-pNext-04748",
554 "vkCreateDevice(): pNext chain includes VkPhysicalDeviceVulkan12Features with bufferDeviceAddress "
555 "set to VK_TRUE and ppEnabledExtensionNames contains VK_EXT_buffer_device_address");
556 }
557 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700558 }
559
Tony-LunarG273f32f2021-09-28 08:56:30 -0600560 const auto *vulkan_13_features = LvlFindInChain<VkPhysicalDeviceVulkan13Features>(pCreateInfo->pNext);
561 if (vulkan_13_features) {
562 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
563 while (current) {
564 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DYNAMIC_RENDERING_FEATURES ||
565 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGE_ROBUSTNESS_FEATURES ||
566 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_INLINE_UNIFORM_BLOCK_FEATURES ||
567 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MAINTENANCE_4_FEATURES ||
568 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PIPELINE_CREATION_CACHE_CONTROL_FEATURES ||
569 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PRIVATE_DATA_FEATURES ||
570 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DEMOTE_TO_HELPER_INVOCATION_FEATURES ||
571 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_INTEGER_DOT_PRODUCT_FEATURES ||
572 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_TERMINATE_INVOCATION_FEATURES ||
573 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SUBGROUP_SIZE_CONTROL_FEATURES ||
574 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SYNCHRONIZATION_2_FEATURES ||
575 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TEXTURE_COMPRESSION_ASTC_HDR_FEATURES ||
576 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_ZERO_INITIALIZE_WORKGROUP_MEMORY_FEATURES) {
577 skip |= LogError(
578 instance, "VUID-VkDeviceCreateInfo-pNext-06532",
579 "If the pNext chain includes a VkPhysicalDeviceVulkan13Features structure, then it must not include a "
580 "VkPhysicalDeviceDynamicRenderingFeatures, VkPhysicalDeviceImageRobustnessFeatures, "
581 "VkPhysicalDeviceInlineUniformBlockFeatures, VkPhysicalDeviceMaintenance4Features, "
582 "VkPhysicalDevicePipelineCreationCacheControlFeatures, VkPhysicalDevicePrivateDataFeatures, "
583 "VkPhysicalDeviceShaderDemoteToHelperInvocationFeatures, VkPhysicalDeviceShaderIntegerDotProductFeatures, "
584 "VkPhysicalDeviceShaderTerminateInvocationFeatures, VkPhysicalDeviceSubgroupSizeControlFeatures, "
585 "VkPhysicalDeviceSynchronization2Features, VkPhysicalDeviceTextureCompressionASTCHDRFeatures, or "
586 "VkPhysicalDeviceZeroInitializeWorkgroupMemoryFeatures structure");
587 break;
588 }
589 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
590 }
591 }
592
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600593 // Validate pCreateInfo->pQueueCreateInfos
594 if (pCreateInfo->pQueueCreateInfos) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600595
596 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700597 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
598 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600599 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700600 skip |=
601 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
602 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
603 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
604 "index value.",
605 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600606 }
607
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700608 if (queue_create_info.pQueuePriorities != nullptr) {
609 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
610 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600611 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700612 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
613 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
614 "] (=%f) is not between 0 and 1 (inclusive).",
615 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600616 }
617 }
618 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700619
620 // Need to know if protectedMemory feature is passed in preCall to creating the device
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700621 VkBool32 protected_memory = VK_FALSE;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700622 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700623 LvlFindInChain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700624 if (protected_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700625 protected_memory = protected_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700626 } else if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700627 protected_memory = vulkan_11_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700628 }
Mike Schuchardta9101d32021-11-12 12:24:08 -0800629 if (((queue_create_info.flags & VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) != 0) && (protected_memory == VK_FALSE)) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700630 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
Mike Schuchardta9101d32021-11-12 12:24:08 -0800631 "vkCreateDevice: pCreateInfo->flags contains VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
632 "protectedMemory feature being enabled as well.");
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700633 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600634 }
635 }
636
sfricke-samsung30a57412020-05-15 21:14:54 -0700637 // feature dependencies for VK_KHR_variable_pointers
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700638 const auto *variable_pointers_features = LvlFindInChain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700639 VkBool32 variable_pointers = VK_FALSE;
640 VkBool32 variable_pointers_storage_buffer = VK_FALSE;
sfricke-samsung30a57412020-05-15 21:14:54 -0700641 if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700642 variable_pointers = vulkan_11_features->variablePointers;
643 variable_pointers_storage_buffer = vulkan_11_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700644 } else if (variable_pointers_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700645 variable_pointers = variable_pointers_features->variablePointers;
646 variable_pointers_storage_buffer = variable_pointers_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700647 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700648 if ((variable_pointers == VK_TRUE) && (variable_pointers_storage_buffer == VK_FALSE)) {
sfricke-samsung30a57412020-05-15 21:14:54 -0700649 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
650 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
651 }
652
sfricke-samsungfd76c342020-05-29 23:13:43 -0700653 // feature dependencies for VK_KHR_multiview
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700654 const auto *multiview_features = LvlFindInChain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
sfricke-samsungfd76c342020-05-29 23:13:43 -0700655 VkBool32 multiview = VK_FALSE;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700656 VkBool32 multiview_geometry_shader = VK_FALSE;
657 VkBool32 multiview_tessellation_shader = VK_FALSE;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700658 if (vulkan_11_features) {
659 multiview = vulkan_11_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700660 multiview_geometry_shader = vulkan_11_features->multiviewGeometryShader;
661 multiview_tessellation_shader = vulkan_11_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700662 } else if (multiview_features) {
663 multiview = multiview_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700664 multiview_geometry_shader = multiview_features->multiviewGeometryShader;
665 multiview_tessellation_shader = multiview_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700666 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700667 if ((multiview == VK_FALSE) && (multiview_geometry_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700668 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
669 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
670 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700671 if ((multiview == VK_FALSE) && (multiview_tessellation_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700672 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
673 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
674 }
675
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600676 return skip;
677}
678
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500679bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700680 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700681 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
682 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
683 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600684 }
685
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700686 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600687}
688
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700689bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500690 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100691 bool skip = false;
692
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600693 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700694 skip |=
695 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600696
697 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
698 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
699 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
700 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700701 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
702 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
703 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600704 }
705
706 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
707 // queueFamilyIndexCount uint32_t values
708 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700709 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
710 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
711 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
712 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600713 }
714 }
715
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700716 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
717 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
718 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
719 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
720 }
721
722 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
723 skip |=
724 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
725 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
726 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
727 }
728
729 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
730 skip |=
731 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
732 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
733 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
734 }
735
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600736 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
737 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
738 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
739 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700740 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
741 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
742 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600743 }
Piers Daniella7f93b62021-11-20 12:32:04 -0700744
745 const auto *maintenance4_features = LvlFindInChain<VkPhysicalDeviceMaintenance4FeaturesKHR>(device_createinfo_pnext);
746 if (maintenance4_features && maintenance4_features->maintenance4) {
747 if (pCreateInfo->size > phys_dev_ext_props.maintenance4_props.maxBufferSize) {
748 skip |= LogError(device, "VUID-VkBufferCreateInfo-size-06409",
749 "vkCreateBuffer: pCreateInfo->size is larger than the maximum allowed buffer size "
750 "VkPhysicalDeviceMaintenance4Properties.maxBufferSize");
751 }
752 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600753 }
754
755 return skip;
756}
757
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700758bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500759 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600760 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600761
762 if (pCreateInfo != nullptr) {
sfricke-samsung61a57c02021-01-10 21:35:12 -0800763 const VkFormat image_format = pCreateInfo->format;
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700764 const VkImageCreateFlags image_flags = pCreateInfo->flags;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600765 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
766 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
767 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
768 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700769 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
770 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
771 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600772 }
773
774 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
775 // queueFamilyIndexCount uint32_t values
776 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700777 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
778 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
779 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
780 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600781 }
782 }
783
Dave Houlton413a6782018-05-22 13:01:54 -0600784 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700785 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600786 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700787 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600788 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700789 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600790
Dave Houlton413a6782018-05-22 13:01:54 -0600791 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700792 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600793 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700794 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600795
Dave Houlton130c0212018-01-29 13:39:56 -0700796 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700797 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
798 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700799 skip |= LogError(
800 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600801 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
802 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700803 }
804
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600805 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100806 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
807 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700808 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
809 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
810 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600811 }
812
813 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700814 if (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
Petr Kraus3f433212018-03-13 12:31:27 +0100815 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700816 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
817 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
818 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
819 ") are not equal.",
820 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100821 }
822
823 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700824 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
825 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
826 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
827 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100828 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600829 }
830
831 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700832 skip |= LogError(
833 device, "VUID-VkImageCreateInfo-imageType-00957",
834 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600835 }
836 }
837
Dave Houlton130c0212018-01-29 13:39:56 -0700838 // 3D image may have only 1 layer
839 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700840 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
841 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700842 }
843
Dave Houlton130c0212018-01-29 13:39:56 -0700844 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
845 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
846 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
847 // At least one of the legal attachment bits must be set
848 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700849 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
850 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700851 }
852 // No flags other than the legal attachment bits may be set
853 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
854 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700855 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
856 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700857 }
858 }
859
Jeff Bolzef40fec2018-09-01 22:04:34 -0500860 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700861 uint32_t max_dim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500862 // Max mip levels is different for corner-sampled images vs normal images.
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700863 uint32_t max_mip_levels = (image_flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700864 ? static_cast<uint32_t>(ceil(log2(max_dim)))
865 : static_cast<uint32_t>(floor(log2(max_dim)) + 1);
866 if (max_dim > 0 && pCreateInfo->mipLevels > max_mip_levels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600867 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700868 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
869 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
870 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600871 }
872
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700873 if ((image_flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700874 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
875 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
876 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600877 }
878
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700879 if ((image_flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700880 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
881 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
882 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100883 }
884
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700885 if ((image_flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700886 skip |= LogError(
887 device, "VUID-VkImageCreateInfo-flags-01924",
888 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
889 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
890 }
891
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600892 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
893 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700894 if (((image_flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
895 ((image_flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700896 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
897 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
898 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600899 }
900
901 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700902 if ((image_flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600903 // Linear tiling is unsupported
904 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700905 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700906 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
907 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600908 }
909
910 // Sparse 1D image isn't valid
911 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700912 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
913 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600914 }
915
916 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700917 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700918 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
919 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
920 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600921 }
922
923 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700924 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700925 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
926 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
927 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600928 }
929
930 // Multi-sample 2D image when device doesn't support it
931 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700932 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600933 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700934 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
935 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
936 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700937 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600938 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700939 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
940 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
941 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700942 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600943 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700944 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
945 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
946 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700947 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600948 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700949 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
950 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
951 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600952 }
953 }
954 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500955
Jeff Bolz9af91c52018-09-01 21:53:57 -0500956 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
957 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700958 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
959 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
960 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500961 }
962 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700963 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
964 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
965 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500966 }
967 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700968 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
969 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
970 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500971 }
972 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500973
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700974 if (image_flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600975 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700976 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
977 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
978 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500979 }
980
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700981 if ((image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(image_format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700982 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
983 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800984 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format (%s) must not be a "
985 "depth/stencil format.",
986 string_VkFormat(image_format));
Jeff Bolzef40fec2018-09-01 22:04:34 -0500987 }
988
Dave Houlton142c4cb2018-10-17 15:04:41 -0600989 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700990 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
991 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
992 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
993 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500994 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600995 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700996 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
997 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
998 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
999 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -05001000 }
1001 }
Andrew Fobel3abeb992020-01-20 16:33:22 -05001002
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001003 if (((image_flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
sfricke-samsung61a57c02021-01-10 21:35:12 -08001004 (FormatHasDepth(image_format) == false)) {
sfricke-samsung8f658d42020-05-03 20:12:24 -07001005 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
1006 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
sfricke-samsung61a57c02021-01-10 21:35:12 -08001007 "format (%s) must be a depth or depth/stencil format.",
1008 string_VkFormat(image_format));
sfricke-samsung8f658d42020-05-03 20:12:24 -07001009 }
1010
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001011 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pCreateInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05001012 if (image_stencil_struct != nullptr) {
1013 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
1014 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1015 // No flags other than the legal attachment bits may be set
1016 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1017 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001018 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
1019 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
1020 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
1021 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -05001022 }
1023 }
1024
sfricke-samsung61a57c02021-01-10 21:35:12 -08001025 if (FormatIsDepthOrStencil(image_format)) {
Andrew Fobel3abeb992020-01-20 16:33:22 -05001026 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
1027 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001028 skip |=
1029 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
1030 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
1031 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width (%" PRIu32
1032 ") exceeds device "
1033 "maxFramebufferWidth (%" PRIu32 ")",
1034 pCreateInfo->extent.width, device_limits.maxFramebufferWidth);
Andrew Fobel3abeb992020-01-20 16:33:22 -05001035 }
1036
1037 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001038 skip |=
1039 LogError(device, "VUID-VkImageCreateInfo-format-02537",
1040 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
1041 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height (%" PRIu32
1042 ") exceeds device "
1043 "maxFramebufferHeight (%" PRIu32 ")",
1044 pCreateInfo->extent.height, device_limits.maxFramebufferHeight);
Andrew Fobel3abeb992020-01-20 16:33:22 -05001045 }
1046 }
1047
1048 if (!physical_device_features.shaderStorageImageMultisample &&
1049 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1050 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1051 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001052 LogError(device, "VUID-VkImageCreateInfo-format-02538",
1053 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
1054 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
1055 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -05001056 }
1057
1058 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
1059 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001060 skip |= LogError(
1061 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001062 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
1063 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1064 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
1065 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
1066 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001067 skip |= LogError(
1068 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001069 "vkCreateImage(): Depth-stencil image in which usage does not include "
1070 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
1071 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1072 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
1073 }
1074
1075 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
1076 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001077 skip |= LogError(
1078 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001079 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1080 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1081 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1082 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
1083 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001084 skip |= LogError(
1085 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001086 "vkCreateImage(): Depth-stencil image in which usage does not include "
1087 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1088 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1089 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1090 }
1091 }
1092 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -07001093
1094 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1095 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1096 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
1097 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
1098 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
1099 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001100
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001101 std::vector<uint64_t> image_create_drm_format_modifiers;
sfricke-samsung45996a42021-09-16 13:45:27 -07001102 if (IsExtEnabled(device_extensions.vk_ext_image_drm_format_modifier)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001103 const auto drm_format_mod_list = LvlFindInChain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
1104 const auto drm_format_mod_explict = LvlFindInChain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001105 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1106 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
1107 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
1108 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
1109 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
1110 "either VkImageDrmFormatModifierListCreateInfoEXT or "
1111 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
Martin Freebody0ec2c7a2021-03-03 16:48:00 +00001112 } else if (drm_format_mod_explict != nullptr) {
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001113 image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
1114 } else if (drm_format_mod_list != nullptr) {
1115 for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {
1116 image_create_drm_format_modifiers.push_back(*drm_format_mod_list->pDrmFormatModifiers);
1117 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001118 }
1119 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
1120 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
1121 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
1122 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
1123 "in the pNext chain");
1124 }
1125 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001126
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001127 static const uint64_t drm_format_mod_linear = 0;
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001128 bool image_create_maybe_linear = false;
1129 if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) {
1130 image_create_maybe_linear = true;
1131 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) {
1132 image_create_maybe_linear = false;
1133 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1134 image_create_maybe_linear =
1135 (std::find(image_create_drm_format_modifiers.begin(), image_create_drm_format_modifiers.end(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001136 drm_format_mod_linear) != image_create_drm_format_modifiers.end());
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001137 }
1138
1139 // If multi-sample, validate type, usage, tiling and mip levels.
1140 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001141 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001142 (pCreateInfo->mipLevels != 1) || image_create_maybe_linear)) {
1143 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
1144 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
1145 }
1146
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001147 if ((image_flags & VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT) &&
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001148 ((pCreateInfo->mipLevels != 1) || (pCreateInfo->arrayLayers != 1) || (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) ||
1149 image_create_maybe_linear)) {
1150 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02259",
1151 "vkCreateImage(): Multi-device image with incompatible type, usage, tiling, or mips.");
1152 }
1153
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001154 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
1155 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1156 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
1157 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1158 "imageType must be VK_IMAGE_TYPE_2D.");
1159 }
1160 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1161 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
1162 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1163 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1164 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001165 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001166 if (image_flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001167 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1168 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
1169 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1170 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1171 }
1172 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1173 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
1174 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1175 "imageType must be VK_IMAGE_TYPE_2D.");
1176 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001177 if (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001178 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1179 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1180 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1181 }
1182 if (pCreateInfo->mipLevels != 1) {
1183 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001184 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%" PRIu32
1185 ") must be 1.",
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001186 pCreateInfo->mipLevels);
1187 }
1188 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001189
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001190 const auto swapchain_create_info = LvlFindInChain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001191 if (swapchain_create_info != nullptr) {
1192 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1193 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1194 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1195 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1196 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1197 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1198
1199 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1200 // also implicitly forces the check above that extent.depth is 1
1201 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1202 string_VkImageType(pCreateInfo->imageType));
1203 }
1204 if (pCreateInfo->mipLevels != 1) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001205 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %" PRIu32 ".", base_message,
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001206 pCreateInfo->mipLevels);
1207 }
1208 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1209 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1210 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1211 }
1212 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1213 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1214 base_message, string_VkImageTiling(pCreateInfo->tiling));
1215 }
1216 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1217 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1218 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1219 }
1220 const VkImageCreateFlags valid_flags =
1221 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
Mike Schuchardt2df08912020-12-15 16:28:09 -08001222 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT);
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001223 if ((image_flags & ~valid_flags) != 0) {
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001224 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001225 image_flags);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001226 }
1227 }
1228 }
sfricke-samsung61a57c02021-01-10 21:35:12 -08001229
1230 // If Chroma subsampled format ( _420_ or _422_ )
1231 if (FormatIsXChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.width, 2) != 0)) {
1232 skip |=
1233 LogError(device, "VUID-VkImageCreateInfo-format-04712",
1234 "vkCreateImage(): The format (%s) is X Chroma Subsampled (has _422 or _420 suffix) so the width (=%" PRIu32
1235 ") must be a multiple of 2.",
1236 string_VkFormat(image_format), pCreateInfo->extent.width);
1237 }
1238 if (FormatIsYChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.height, 2) != 0)) {
1239 skip |= LogError(device, "VUID-VkImageCreateInfo-format-04713",
1240 "vkCreateImage(): The format (%s) is Y Chroma Subsampled (has _420 suffix) so the height (=%" PRIu32
1241 ") must be a multiple of 2.",
1242 string_VkFormat(image_format), pCreateInfo->extent.height);
1243 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001244
1245 const auto format_list_info = LvlFindInChain<VkImageFormatListCreateInfo>(pCreateInfo->pNext);
1246 if (format_list_info) {
1247 const uint32_t viewFormatCount = format_list_info->viewFormatCount;
1248 if (((image_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) == 0) && (viewFormatCount > 1)) {
1249 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-04738",
1250 "vkCreateImage(): If the VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT is not set, then "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001251 "VkImageFormatListCreateInfo::viewFormatCount (%" PRIu32 ") must be 0 or 1.",
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001252 viewFormatCount);
1253 }
1254 // Check if viewFormatCount is not zero that it is all compatible
1255 for (uint32_t i = 0; i < viewFormatCount; i++) {
1256 if (FormatCompatibilityClass(format_list_info->pViewFormats[i]) != FormatCompatibilityClass(image_format)) {
1257 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-04737",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001258 "vkCreateImage(): VkImageFormatListCreateInfo::pViewFormats[%" PRIu32
1259 "] (%s) and "
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001260 "VkImageCreateInfo::format (%s) are not compatible.",
Esther O'Keefed37c24b2021-09-27 12:45:40 +10001261 i, string_VkFormat(format_list_info->pViewFormats[i]), string_VkFormat(image_format));
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001262 }
1263 }
1264 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001265 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001266
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001267 return skip;
1268}
1269
Jeff Bolz99e3f632020-03-24 22:59:22 -05001270bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1271 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1272 bool skip = false;
1273
1274 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001275 // Validate feature set if using CUBE_ARRAY
1276 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1277 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1278 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1279 "enabling the imageCubeArray feature.");
1280 }
1281
Jeff Bolz99e3f632020-03-24 22:59:22 -05001282 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1283 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1284 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001285 "vkCreateImageView(): subresourceRange.layerCount (%" PRIu32
1286 ") must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001287 pCreateInfo->subresourceRange.layerCount);
1288 }
1289 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001290 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02961",
1291 "vkCreateImageView(): subresourceRange.layerCount (%" PRIu32
1292 ") must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1293 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001294 }
1295 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001296
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001297 auto astc_decode_mode = LvlFindInChain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
sfricke-samsung45996a42021-09-16 13:45:27 -07001298 if (IsExtEnabled(device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001299 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1300 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1301 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1302 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1303 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1304 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1305 }
sfricke-samsunge3086292021-11-18 23:02:35 -08001306 if ((FormatIsCompressed_ASTC_LDR(pCreateInfo->format) == false) &&
1307 (FormatIsCompressed_ASTC_HDR(pCreateInfo->format) == false)) {
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001308 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1309 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1310 "not an ASTC format.",
1311 string_VkFormat(pCreateInfo->format));
1312 }
1313 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001314
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001315 auto ycbcr_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
sfricke-samsung83d98122020-07-04 06:21:15 -07001316 if (ycbcr_conversion != nullptr) {
1317 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1318 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1319 skip |= LogError(
1320 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1321 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1322 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1323 "r swizzle = %s\n"
1324 "g swizzle = %s\n"
1325 "b swizzle = %s\n"
1326 "a swizzle = %s\n",
1327 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1328 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1329 }
1330 }
1331 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001332 }
1333 return skip;
1334}
1335
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001336bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001337 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001338 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001339
1340 // Note: for numerical correctness
1341 // - float comparisons should expect NaN (comparison always false).
1342 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1343
1344 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001345 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001346 if (v1_f <= 0.0f) return true;
1347
1348 float intpart;
1349 const float fract = modff(v1_f, &intpart);
1350
1351 assert(std::numeric_limits<float>::radix == 2);
1352 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1353 if (intpart >= u32_max_plus1) return false;
1354
1355 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001356 if (v1_u32 < v2_u32) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001357 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001358 } else if (v1_u32 == v2_u32 && fract == 0.0f) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001359 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001360 } else {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001361 return false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001362 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01001363 };
1364
1365 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1366 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1367 return (v1_f <= v2_f);
1368 };
1369
1370 // width
1371 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001372 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001373
1374 if (!(viewport.width > 0.0f)) {
1375 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001376 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1377 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001378 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1379 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001380 skip |= LogError(object, "VUID-VkViewport-width-01771",
1381 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1382 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001383 }
1384
1385 // height
1386 bool height_healthy = true;
sfricke-samsung45996a42021-09-16 13:45:27 -07001387 const bool negative_height_enabled =
1388 IsExtEnabled(device_extensions.vk_khr_maintenance1) || IsExtEnabled(device_extensions.vk_amd_negative_viewport_height);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001389 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001390
1391 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1392 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001393 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1394 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001395 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1396 height_healthy = false;
1397
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001398 skip |= LogError(object, "VUID-VkViewport-height-01773",
1399 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1400 ").",
1401 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001402 }
1403
1404 // x
1405 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001406 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001407 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001408 skip |= LogError(object, "VUID-VkViewport-x-01774",
1409 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1410 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001411 }
1412
1413 // x + width
1414 if (x_healthy && width_healthy) {
1415 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001416 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001417 skip |= LogError(
1418 object, "VUID-VkViewport-x-01232",
1419 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1420 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1421 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001422 }
1423 }
1424
1425 // y
1426 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001427 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001428 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001429 skip |= LogError(object, "VUID-VkViewport-y-01775",
1430 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1431 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001432 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001433 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001434 skip |= LogError(object, "VUID-VkViewport-y-01776",
1435 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1436 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001437 }
1438
1439 // y + height
1440 if (y_healthy && height_healthy) {
1441 const float boundary = viewport.y + viewport.height;
1442
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001443 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001444 skip |= LogError(object, "VUID-VkViewport-y-01233",
1445 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1446 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1447 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001448 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001449 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001450 LogError(object, "VUID-VkViewport-y-01777",
1451 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1452 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1453 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001454 }
1455 }
1456
sfricke-samsungfd06d422021-01-22 02:17:21 -08001457 // The extension was not created with a feature bit whichs prevents displaying the 2 variations of the VUIDs
sfricke-samsung45996a42021-09-16 13:45:27 -07001458 if (!IsExtEnabled(device_extensions.vk_ext_depth_range_unrestricted)) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001459 // minDepth
1460 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001461 // Also VUID-VkViewport-minDepth-02540
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001462 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001463 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1464 "[0.0, 1.0] range.",
1465 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001466 }
1467
1468 // maxDepth
1469 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001470 // Also VUID-VkViewport-maxDepth-02541
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001471 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001472 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1473 "[0.0, 1.0] range.",
1474 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001475 }
1476 }
1477
1478 return skip;
1479}
1480
Dave Houlton142c4cb2018-10-17 15:04:41 -06001481struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001482 VkShadingRatePaletteEntryNV shadingRate;
1483 uint32_t width;
1484 uint32_t height;
1485};
1486
1487// All palette entries with more than one pixel per fragment
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001488static SampleOrderInfo sample_order_infos[] = {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001489 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1490 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1491 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1492 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1493 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1494 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001495};
1496
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001497bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001498 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001499
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001500 SampleOrderInfo *sample_order_info;
1501 uint32_t info_idx = 0;
1502 for (sample_order_info = nullptr; info_idx < ARRAY_SIZE(sample_order_infos); ++info_idx) {
1503 if (sample_order_infos[info_idx].shadingRate == order->shadingRate) {
1504 sample_order_info = &sample_order_infos[info_idx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001505 break;
1506 }
1507 }
1508
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001509 if (sample_order_info == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001510 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1511 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1512 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001513 return skip;
1514 }
1515
Dave Houlton142c4cb2018-10-17 15:04:41 -06001516 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001517 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001518 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1519 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1520 ") must "
1521 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1522 "is set in framebufferNoAttachmentsSampleCounts.",
1523 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001524 }
1525
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001526 if (order->sampleLocationCount != order->sampleCount * sample_order_info->width * sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001527 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1528 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1529 ") must "
1530 "be equal to the product of sampleCount (=%" PRIu32
1531 "), the fragment width for shadingRate "
1532 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001533 order->sampleLocationCount, order->sampleCount, sample_order_info->width, sample_order_info->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001534 }
1535
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001536 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001537 skip |= LogError(
1538 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001539 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1540 ") must "
1541 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001542 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001543 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001544
1545 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001546 // the first width*height*sampleCount bits to all be set. Note: There is no
1547 // guarantee that 64 bits is enough, but practically it's unlikely for an
1548 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001549 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001550 uint64_t sample_locations_mask = 0;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001551 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001552 const VkCoarseSampleLocationNV *sample_loc = &order->pSampleLocations[i];
1553 if (sample_loc->pixelX >= sample_order_info->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001554 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1555 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001556 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001557 if (sample_loc->pixelY >= sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001558 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1559 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001560 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001561 if (sample_loc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001562 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1563 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001564 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001565 uint32_t idx =
1566 sample_loc->sample + order->sampleCount * (sample_loc->pixelX + sample_order_info->width * sample_loc->pixelY);
1567 sample_locations_mask |= 1ULL << idx;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001568 }
1569
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001570 uint64_t expected_mask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1571 if (sample_locations_mask != expected_mask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001572 skip |= LogError(
1573 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001574 "The array pSampleLocations must contain exactly one entry for "
1575 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001576 }
1577
1578 return skip;
1579}
1580
sfricke-samsung51303fb2021-05-09 19:09:13 -07001581bool StatelessValidation::manual_PreCallValidateCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo,
1582 const VkAllocationCallbacks *pAllocator,
1583 VkPipelineLayout *pPipelineLayout) const {
1584 bool skip = false;
1585 // Validate layout count against device physical limit
1586 if (pCreateInfo->setLayoutCount > device_limits.maxBoundDescriptorSets) {
1587 skip |= LogError(device, "VUID-VkPipelineLayoutCreateInfo-setLayoutCount-00286",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001588 "vkCreatePipelineLayout(): setLayoutCount (%" PRIu32
1589 ") exceeds physical device maxBoundDescriptorSets limit (%" PRIu32 ").",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001590 pCreateInfo->setLayoutCount, device_limits.maxBoundDescriptorSets);
1591 }
1592
1593 // Validate Push Constant ranges
1594 for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
1595 const uint32_t offset = pCreateInfo->pPushConstantRanges[i].offset;
1596 const uint32_t size = pCreateInfo->pPushConstantRanges[i].size;
1597 const uint32_t max_push_constants_size = device_limits.maxPushConstantsSize;
1598 // Check that offset + size don't exceed the max.
1599 // Prevent arithetic overflow here by avoiding addition and testing in this order.
1600 if (offset >= max_push_constants_size) {
1601 skip |= LogError(device, "VUID-VkPushConstantRange-offset-00294",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001602 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].offset (%" PRIu32
1603 ") that exceeds this "
1604 "device's maxPushConstantSize of %" PRIu32 ".",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001605 i, offset, max_push_constants_size);
1606 }
1607 if (size > max_push_constants_size - offset) {
1608 skip |= LogError(device, "VUID-VkPushConstantRange-size-00298",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001609 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "] offset (%" PRIu32
1610 ") and size (%" PRIu32
1611 ") "
1612 "together exceeds this device's maxPushConstantSize of %" PRIu32 ".",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001613 i, offset, size, max_push_constants_size);
1614 }
1615
1616 // size needs to be non-zero and a multiple of 4.
1617 if (size == 0) {
1618 skip |= LogError(device, "VUID-VkPushConstantRange-size-00296",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001619 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].size (%" PRIu32
1620 ") is not greater than zero.",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001621 i, size);
1622 }
1623 if (size & 0x3) {
1624 skip |= LogError(device, "VUID-VkPushConstantRange-size-00297",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001625 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].size (%" PRIu32
1626 ") is not a multiple of 4.",
1627 i, size);
sfricke-samsung51303fb2021-05-09 19:09:13 -07001628 }
1629
1630 // offset needs to be a multiple of 4.
1631 if ((offset & 0x3) != 0) {
1632 skip |= LogError(device, "VUID-VkPushConstantRange-offset-00295",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001633 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].offset (%" PRIu32
1634 ") is not a multiple of 4.",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001635 i, offset);
1636 }
1637 }
1638
1639 // As of 1.0.28, there is a VU that states that a stage flag cannot appear more than once in the list of push constant ranges.
1640 for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
1641 for (uint32_t j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) {
1642 if (0 != (pCreateInfo->pPushConstantRanges[i].stageFlags & pCreateInfo->pPushConstantRanges[j].stageFlags)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001643 skip |=
1644 LogError(device, "VUID-VkPipelineLayoutCreateInfo-pPushConstantRanges-00292",
1645 "vkCreatePipelineLayout() Duplicate stage flags found in ranges %" PRIu32 " and %" PRIu32 ".", i, j);
sfricke-samsung51303fb2021-05-09 19:09:13 -07001646 }
1647 }
1648 }
1649 return skip;
1650}
1651
ziga-lunargc6341372021-07-28 12:57:42 +02001652bool StatelessValidation::ValidatePipelineShaderStageCreateInfo(const char *func_name, const char *msg,
1653 const VkPipelineShaderStageCreateInfo *pCreateInfo) const {
1654 bool skip = false;
1655
1656 const auto *required_subgroup_size_features =
1657 LvlFindInChain<VkPipelineShaderStageRequiredSubgroupSizeCreateInfoEXT>(pCreateInfo->pNext);
1658
1659 if (required_subgroup_size_features) {
1660 if ((pCreateInfo->flags & VK_PIPELINE_SHADER_STAGE_CREATE_ALLOW_VARYING_SUBGROUP_SIZE_BIT_EXT) != 0) {
1661 skip |= LogError(
1662 device, "VUID-VkPipelineShaderStageCreateInfo-pNext-02754",
1663 "%s(): %s->flags (0x%x) includes VK_PIPELINE_SHADER_STAGE_CREATE_ALLOW_VARYING_SUBGROUP_SIZE_BIT_EXT while "
1664 "VkPipelineShaderStageRequiredSubgroupSizeCreateInfoEXT is included in the pNext chain.",
1665 func_name, msg, pCreateInfo->flags);
1666 }
1667 }
1668
1669 return skip;
1670}
1671
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001672bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1673 uint32_t createInfoCount,
1674 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1675 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001676 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001677 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001678
1679 if (pCreateInfos != nullptr) {
1680 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001681 bool has_dynamic_viewport = false;
1682 bool has_dynamic_scissor = false;
1683 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001684 bool has_dynamic_depth_bias = false;
1685 bool has_dynamic_blend_constant = false;
1686 bool has_dynamic_depth_bounds = false;
1687 bool has_dynamic_stencil_compare = false;
1688 bool has_dynamic_stencil_write = false;
1689 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001690 bool has_dynamic_viewport_w_scaling_nv = false;
1691 bool has_dynamic_discard_rectangle_ext = false;
1692 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001693 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001694 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001695 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001696 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001697 bool has_dynamic_cull_mode = false;
1698 bool has_dynamic_front_face = false;
1699 bool has_dynamic_primitive_topology = false;
1700 bool has_dynamic_viewport_with_count = false;
1701 bool has_dynamic_scissor_with_count = false;
1702 bool has_dynamic_vertex_input_binding_stride = false;
1703 bool has_dynamic_depth_test_enable = false;
1704 bool has_dynamic_depth_write_enable = false;
1705 bool has_dynamic_depth_compare_op = false;
1706 bool has_dynamic_depth_bounds_test_enable = false;
1707 bool has_dynamic_stencil_test_enable = false;
1708 bool has_dynamic_stencil_op = false;
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07001709 bool has_patch_control_points = false;
1710 bool has_rasterizer_discard_enable = false;
1711 bool has_depth_bias_enable = false;
1712 bool has_logic_op = false;
1713 bool has_primitive_restart_enable = false;
Piers Daniellcb6d8032021-04-19 18:51:26 -06001714 bool has_dynamic_vertex_input = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001715 if (pCreateInfos[i].pDynamicState != nullptr) {
1716 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1717 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1718 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001719 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1720 if (has_dynamic_viewport == true) {
1721 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1722 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001723 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001724 i);
1725 }
1726 has_dynamic_viewport = true;
1727 }
1728 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1729 if (has_dynamic_scissor == true) {
1730 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1731 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001732 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001733 i);
1734 }
1735 has_dynamic_scissor = true;
1736 }
1737 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1738 if (has_dynamic_line_width == true) {
1739 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1740 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001741 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001742 i);
1743 }
1744 has_dynamic_line_width = true;
1745 }
1746 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1747 if (has_dynamic_depth_bias == true) {
1748 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1749 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001750 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001751 i);
1752 }
1753 has_dynamic_depth_bias = true;
1754 }
1755 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1756 if (has_dynamic_blend_constant == true) {
1757 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1758 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001759 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001760 i);
1761 }
1762 has_dynamic_blend_constant = true;
1763 }
1764 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1765 if (has_dynamic_depth_bounds == true) {
1766 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1767 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001768 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001769 i);
1770 }
1771 has_dynamic_depth_bounds = true;
1772 }
1773 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1774 if (has_dynamic_stencil_compare == true) {
1775 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1776 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001777 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001778 i);
1779 }
1780 has_dynamic_stencil_compare = true;
1781 }
1782 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1783 if (has_dynamic_stencil_write == true) {
1784 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1785 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001786 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001787 i);
1788 }
1789 has_dynamic_stencil_write = true;
1790 }
1791 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1792 if (has_dynamic_stencil_reference == true) {
1793 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1794 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001795 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001796 i);
1797 }
1798 has_dynamic_stencil_reference = true;
1799 }
1800 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1801 if (has_dynamic_viewport_w_scaling_nv == true) {
1802 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1803 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001804 "in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001805 i);
1806 }
1807 has_dynamic_viewport_w_scaling_nv = true;
1808 }
1809 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1810 if (has_dynamic_discard_rectangle_ext == true) {
1811 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1812 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001813 "in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001814 i);
1815 }
1816 has_dynamic_discard_rectangle_ext = true;
1817 }
1818 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1819 if (has_dynamic_sample_locations_ext == true) {
1820 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1821 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001822 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001823 i);
1824 }
1825 has_dynamic_sample_locations_ext = true;
1826 }
1827 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1828 if (has_dynamic_exclusive_scissor_nv == true) {
1829 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1830 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001831 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001832 i);
1833 }
1834 has_dynamic_exclusive_scissor_nv = true;
1835 }
1836 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1837 if (has_dynamic_shading_rate_palette_nv == true) {
1838 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1839 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001840 "listed twice in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001841 i);
1842 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001843 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001844 }
1845 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1846 if (has_dynamic_viewport_course_sample_order_nv == true) {
1847 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1848 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001849 "listed twice in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001850 i);
1851 }
1852 has_dynamic_viewport_course_sample_order_nv = true;
1853 }
1854 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1855 if (has_dynamic_line_stipple == true) {
1856 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1857 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001858 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001859 i);
1860 }
1861 has_dynamic_line_stipple = true;
1862 }
Piers Daniell39842ee2020-07-10 16:42:33 -06001863 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
1864 if (has_dynamic_cull_mode) {
1865 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1866 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001867 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001868 i);
1869 }
1870 has_dynamic_cull_mode = true;
1871 }
1872 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
1873 if (has_dynamic_front_face) {
1874 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1875 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001876 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001877 i);
1878 }
1879 has_dynamic_front_face = true;
1880 }
1881 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
1882 if (has_dynamic_primitive_topology) {
1883 skip |= LogError(
1884 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1885 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001886 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001887 i);
1888 }
1889 has_dynamic_primitive_topology = true;
1890 }
1891 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
1892 if (has_dynamic_viewport_with_count) {
1893 skip |= LogError(
1894 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1895 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001896 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001897 i);
1898 }
1899 has_dynamic_viewport_with_count = true;
1900 }
1901 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
1902 if (has_dynamic_scissor_with_count) {
1903 skip |= LogError(
1904 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1905 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001906 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001907 i);
1908 }
1909 has_dynamic_scissor_with_count = true;
1910 }
1911 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
1912 if (has_dynamic_vertex_input_binding_stride) {
1913 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1914 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
1915 "listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001916 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001917 i);
1918 }
1919 has_dynamic_vertex_input_binding_stride = true;
1920 }
1921 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
1922 if (has_dynamic_depth_test_enable) {
1923 skip |= LogError(
1924 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1925 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001926 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001927 i);
1928 }
1929 has_dynamic_depth_test_enable = true;
1930 }
1931 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
1932 if (has_dynamic_depth_write_enable) {
1933 skip |= LogError(
1934 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1935 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001936 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001937 i);
1938 }
1939 has_dynamic_depth_write_enable = true;
1940 }
1941 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
1942 if (has_dynamic_depth_compare_op) {
1943 skip |=
1944 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1945 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001946 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001947 i);
1948 }
1949 has_dynamic_depth_compare_op = true;
1950 }
1951 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
1952 if (has_dynamic_depth_bounds_test_enable) {
1953 skip |= LogError(
1954 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1955 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001956 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001957 i);
1958 }
1959 has_dynamic_depth_bounds_test_enable = true;
1960 }
1961 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
1962 if (has_dynamic_stencil_test_enable) {
1963 skip |= LogError(
1964 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1965 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001966 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001967 i);
1968 }
1969 has_dynamic_stencil_test_enable = true;
1970 }
1971 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
1972 if (has_dynamic_stencil_op) {
1973 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1974 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001975 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001976 i);
1977 }
1978 has_dynamic_stencil_op = true;
1979 }
sfricke-samsung5f8f9702021-01-29 23:30:30 -08001980 if (dynamic_state == VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR) {
1981 // Not allowed for graphics pipelines
1982 skip |= LogError(
1983 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03578",
1984 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR was listed the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001985 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates[%" PRIu32
1986 "] but not allowed in graphic pipelines.",
sfricke-samsung5f8f9702021-01-29 23:30:30 -08001987 i, state_index);
1988 }
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07001989 if (dynamic_state == VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT) {
1990 if (has_patch_control_points) {
1991 skip |= LogError(
1992 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1993 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001994 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07001995 i);
1996 }
1997 has_patch_control_points = true;
1998 }
1999 if (dynamic_state == VK_DYNAMIC_STATE_RASTERIZER_DISCARD_ENABLE_EXT) {
2000 if (has_rasterizer_discard_enable) {
2001 skip |= LogError(
2002 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2003 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_RASTERIZER_DISCARD_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002004 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002005 i);
2006 }
2007 has_rasterizer_discard_enable = true;
2008 }
2009 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS_ENABLE_EXT) {
2010 if (has_depth_bias_enable) {
2011 skip |= LogError(
2012 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2013 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002014 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002015 i);
2016 }
2017 has_depth_bias_enable = true;
2018 }
2019 if (dynamic_state == VK_DYNAMIC_STATE_LOGIC_OP_EXT) {
2020 if (has_logic_op) {
2021 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2022 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LOGIC_OP_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002023 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002024 i);
2025 }
2026 has_logic_op = true;
2027 }
2028 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_RESTART_ENABLE_EXT) {
2029 if (has_primitive_restart_enable) {
2030 skip |= LogError(
2031 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2032 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_RESTART_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002033 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002034 i);
2035 }
2036 has_primitive_restart_enable = true;
2037 }
Piers Daniellcb6d8032021-04-19 18:51:26 -06002038 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_EXT) {
2039 if (has_dynamic_vertex_input) {
2040 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002041 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_EXT was listed twice in the "
2042 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
2043 i);
Piers Daniellcb6d8032021-04-19 18:51:26 -06002044 }
2045 has_dynamic_vertex_input = true;
2046 }
Petr Kraus299ba622017-11-24 03:09:03 +01002047 }
2048 }
2049
sfricke-samsung3b944422021-01-23 02:15:19 -08002050 if (has_dynamic_viewport_with_count && has_dynamic_viewport) {
2051 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04132",
2052 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT and "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002053 "VK_DYNAMIC_STATE_VIEWPORT both listed in pCreateInfos[%" PRIu32
2054 "].pDynamicState->pDynamicStates array",
sfricke-samsung3b944422021-01-23 02:15:19 -08002055 i);
2056 }
2057
2058 if (has_dynamic_scissor_with_count && has_dynamic_scissor) {
2059 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04133",
2060 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT and VK_DYNAMIC_STATE_SCISSOR "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002061 "both listed in pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
sfricke-samsung3b944422021-01-23 02:15:19 -08002062 i);
2063 }
2064
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002065 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04002066 if ((feedback_struct != nullptr) &&
2067 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Tony-LunarGce3244a2021-11-19 12:33:40 -07002068 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfo-pipelineStageCreationFeedbackCount-02668",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002069 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
2070 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
2071 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
2072 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04002073 }
2074
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002075 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002076
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002077 // Collect active stages and other information
2078 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002079 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002080 bool has_eval = false;
2081 bool has_control = false;
2082 if (pCreateInfos[i].pStages != nullptr) {
2083 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
2084 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
2085
2086 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
2087 has_control = true;
2088 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
2089 has_eval = true;
2090 }
2091
2092 skip |= validate_string(
2093 "vkCreateGraphicsPipelines",
2094 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
2095 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
ziga-lunargc6341372021-07-28 12:57:42 +02002096
2097 std::stringstream msg;
2098 msg << "pCreateInfos[%" << i << "].pStages[%" << stage_index << "]";
2099 ValidatePipelineShaderStageCreateInfo("vkCreateGraphicsPipelines", msg.str().c_str(),
2100 &pCreateInfos[i].pStages[stage_index]);
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002101 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002102 }
2103
2104 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
2105 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
2106 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
2107 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
2108 pCreateInfos[i].pTessellationState,
2109 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
2110 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
2111
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002112 const VkStructureType allowed_structs_vk_pipeline_tessellation_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002113 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
2114
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002115 skip |= validate_struct_pnext(
2116 "vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
2117 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext,
2118 ARRAY_SIZE(allowed_structs_vk_pipeline_tessellation_state_create_info),
2119 allowed_structs_vk_pipeline_tessellation_state_create_info, GeneratedVulkanHeaderVersion,
2120 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
2121 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002122
2123 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
2124 pCreateInfos[i].pTessellationState->flags,
2125 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
2126 }
2127
2128 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
2129 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
2130 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
2131 pCreateInfos[i].pInputAssemblyState,
2132 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
2133 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
2134
2135 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
2136 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002137 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002138
2139 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
2140 pCreateInfos[i].pInputAssemblyState->flags,
2141 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
2142
2143 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
2144 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
2145 pCreateInfos[i].pInputAssemblyState->topology,
2146 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
2147
2148 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
2149 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
2150 }
2151
2152 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002153 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02002154
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002155 if (pCreateInfos[i].pVertexInputState->flags != 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002156 skip |=
2157 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
2158 "vkCreateGraphicsPipelines: pararameter "
2159 "pCreateInfos[%" PRIu32 "].pVertexInputState->flags (%" PRIu32 ") is reserved and must be zero.",
2160 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002161 }
2162
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002163 const VkStructureType allowed_structs_vk_pipeline_vertex_input_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002164 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
2165 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
2166 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
2167 pCreateInfos[i].pVertexInputState->pNext, 1,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002168 allowed_structs_vk_pipeline_vertex_input_state_create_info,
2169 GeneratedVulkanHeaderVersion, "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08002170 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002171 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
2172 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06002173 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002174 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
2175 skip |=
2176 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
2177 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
2178 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
2179 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
2180 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
2181
2182 skip |= validate_array(
2183 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
2184 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
2185 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
2186 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
2187
2188 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002189 for (uint32_t vertex_binding_description_index = 0;
2190 vertex_binding_description_index < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
2191 ++vertex_binding_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002192 skip |= validate_ranged_enum(
2193 "vkCreateGraphicsPipelines",
2194 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
2195 AllVkVertexInputRateEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002196 pCreateInfos[i]
2197 .pVertexInputState->pVertexBindingDescriptions[vertex_binding_description_index]
2198 .inputRate,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002199 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
2200 }
2201 }
2202
2203 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002204 for (uint32_t vertex_attribute_description_index = 0;
2205 vertex_attribute_description_index < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
2206 ++vertex_attribute_description_index) {
sfricke-samsung2e827212021-09-28 07:52:08 -07002207 const VkFormat format =
2208 pCreateInfos[i]
2209 .pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index]
2210 .format;
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002211 skip |= validate_ranged_enum(
2212 "vkCreateGraphicsPipelines",
2213 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
2214 AllVkFormatEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002215 pCreateInfos[i]
2216 .pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index]
2217 .format,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002218 "VUID-VkVertexInputAttributeDescription-format-parameter");
sfricke-samsung2e827212021-09-28 07:52:08 -07002219 if (FormatIsDepthOrStencil(format)) {
2220 // Should never hopefully get here, but there are known driver advertising the wrong feature flags
2221 // see https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/4849
2222 skip |= LogError(device, kVUID_Core_invalidDepthStencilFormat,
2223 "vkCreateGraphicsPipelines: "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002224 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2225 "].format is a "
sfricke-samsung2e827212021-09-28 07:52:08 -07002226 "depth/stencil format (%s) but depth/stencil formats do not have a defined sizes for "
2227 "alignment, replace with a color format.",
2228 i, vertex_attribute_description_index, string_VkFormat(format));
2229 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002230 }
2231 }
2232
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002233 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002234 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
2235 "vkCreateGraphicsPipelines: pararameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002236 "pCreateInfo[%" PRIu32 "].pVertexInputState->vertexBindingDescriptionCount (%" PRIu32
2237 ") is "
2238 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002239 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002240 }
2241
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002242 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002243 skip |=
2244 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
2245 "vkCreateGraphicsPipelines: pararameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002246 "pCreateInfo[%" PRIu32 "].pVertexInputState->vertexAttributeDescriptionCount (%" PRIu32
2247 ") is "
2248 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002249 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002250 }
2251
Jeremy Gebbencbf22862021-03-03 12:01:22 -07002252 layer_data::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002253 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
2254 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02002255 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
2256 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002257 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
2258 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002259 "pCreateInfo[%" PRIu32 "].pVertexInputState->pVertexBindingDescription[%" PRIu32
2260 "].binding "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002261 "(%" PRIu32 ") is not distinct.",
2262 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002263 }
2264 vertex_bindings.insert(vertex_bind_desc.binding);
2265
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002266 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002267 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
2268 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002269 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexBindingDescriptions[%" PRIu32
2270 "].binding (%" PRIu32
2271 ") is "
2272 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002273 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002274 }
2275
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002276 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002277 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
2278 "vkCreateGraphicsPipelines: parameter "
2279 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexBindingDescriptions[%" PRIu32
2280 "].stride (%" PRIu32
2281 ") is greater "
2282 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%" PRIu32 ").",
2283 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002284 }
2285 }
2286
Jeremy Gebbencbf22862021-03-03 12:01:22 -07002287 layer_data::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002288 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
2289 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02002290 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
2291 if (location_it != attribute_locations.cend()) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002292 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
2293 "vkCreateGraphicsPipelines: parameter "
2294 "pCreateInfo[%" PRIu32 "].pVertexInputState->vertexAttributeDescriptions[%" PRIu32
2295 "].location (%" PRIu32 ") is not distinct.",
2296 i, d, vertex_attrib_desc.location);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002297 }
2298 attribute_locations.insert(vertex_attrib_desc.location);
2299
2300 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
2301 if (binding_it == vertex_bindings.cend()) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002302 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
2303 "vkCreateGraphicsPipelines: parameter "
2304 " pCreateInfo[%" PRIu32 "].pVertexInputState->vertexAttributeDescriptions[%" PRIu32
2305 "].binding (%" PRIu32
2306 ") does not exist "
2307 "in any pCreateInfo[%" PRIu32 "].pVertexInputState->pVertexBindingDescription.",
2308 i, d, vertex_attrib_desc.binding, i);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002309 }
2310
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002311 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002312 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
2313 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002314 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2315 "].location (%" PRIu32
2316 ") is "
2317 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002318 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002319 }
2320
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002321 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002322 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
2323 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002324 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2325 "].binding (%" PRIu32
2326 ") is "
2327 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002328 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002329 }
2330
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002331 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002332 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
2333 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002334 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2335 "].offset (%" PRIu32
2336 ") is "
2337 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002338 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002339 }
2340 }
2341 }
2342
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002343 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
2344 if (has_control && has_eval) {
2345 if (pCreateInfos[i].pTessellationState == nullptr) {
2346 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002347 "vkCreateGraphicsPipelines: if pCreateInfos[%" PRIu32
2348 "].pStages includes a tessellation control "
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002349 "shader stage and a tessellation evaluation shader stage, "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002350 "pCreateInfos[%" PRIu32 "].pTessellationState must not be NULL.",
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002351 i, i);
2352 } else {
2353 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
2354 skip |= validate_struct_pnext(
2355 "vkCreateGraphicsPipelines",
2356 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
2357 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
2358 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
2359 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002360
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002361 skip |= validate_reserved_flags(
2362 "vkCreateGraphicsPipelines",
2363 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
2364 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002365
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002366 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
2367 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
2368 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
2369 "vkCreateGraphicsPipelines: invalid parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002370 "pCreateInfos[%" PRIu32 "].pTessellationState->patchControlPoints value %" PRIu32
2371 ". patchControlPoints "
2372 "should be >0 and <=%" PRIu32 ".",
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002373 i, pCreateInfos[i].pTessellationState->patchControlPoints,
2374 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002375 }
2376 }
2377 }
2378
2379 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
2380 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
2381 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
2382 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002383 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
2384 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
2385 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
2386 "].pViewportState (=NULL) is not a valid pointer.",
2387 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002388 } else {
Petr Krausa6103552017-11-16 21:21:58 +01002389 const auto &viewport_state = *pCreateInfos[i].pViewportState;
2390
2391 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002392 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
2393 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2394 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
2395 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002396 }
2397
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002398 const VkStructureType allowed_structs_vk_pipeline_viewport_state_create_info[] = {
Petr Krausa6103552017-11-16 21:21:58 +01002399 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002400 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
2401 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05002402 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
2403 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002404 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_DEPTH_CLIP_CONTROL_CREATE_INFO_EXT,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002405 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002406 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002407 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01002408 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05002409 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05002410 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002411 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV, VkPipelineViewportDepthClipControlCreateInfoEXT",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002412 viewport_state.pNext, ARRAY_SIZE(allowed_structs_vk_pipeline_viewport_state_create_info),
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002413 allowed_structs_vk_pipeline_viewport_state_create_info, 200,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002414 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08002415 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002416
2417 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002418 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002419 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002420 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002421
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002422 auto exclusive_scissor_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002423 LvlFindInChain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(viewport_state.pNext);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002424 auto shading_rate_image_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002425 LvlFindInChain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(viewport_state.pNext);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002426 auto coarse_sample_order_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002427 LvlFindInChain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(viewport_state.pNext);
2428 const auto vp_swizzle_struct = LvlFindInChain<VkPipelineViewportSwizzleStateCreateInfoNV>(viewport_state.pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002429 const auto vp_w_scaling_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002430 LvlFindInChain<VkPipelineViewportWScalingStateCreateInfoNV>(viewport_state.pNext);
2431 const auto depth_clip_control_struct =
2432 LvlFindInChain<VkPipelineViewportDepthClipControlCreateInfoEXT>(viewport_state.pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002433
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002434 if (!physical_device_features.multiViewport) {
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002435 if (!has_dynamic_viewport_with_count && (viewport_state.viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002436 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2437 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2438 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2439 ") is not 1.",
2440 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002441 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002442
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002443 if (!has_dynamic_scissor_with_count && (viewport_state.scissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002444 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2445 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2446 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2447 ") is not 1.",
2448 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002449 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002450
Dave Houlton142c4cb2018-10-17 15:04:41 -06002451 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2452 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002453 skip |= LogError(
2454 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2455 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2456 "disabled, but pCreateInfos[%" PRIu32
2457 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2458 ") is not 1.",
2459 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002460 }
2461
Jeff Bolz9af91c52018-09-01 21:53:57 -05002462 if (shading_rate_image_struct &&
2463 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002464 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2465 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2466 "disabled, but pCreateInfos[%" PRIu32
2467 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2468 ") is neither 0 nor 1.",
2469 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002470 }
2471
Petr Krausa6103552017-11-16 21:21:58 +01002472 } else { // multiViewport enabled
2473 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002474 if (!has_dynamic_viewport_with_count) {
2475 skip |= LogError(
2476 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2477 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2478 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002479 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002480 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2481 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2482 "].pViewportState->viewportCount (=%" PRIu32
2483 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2484 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002485 } else if (has_dynamic_viewport_with_count) {
2486 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2487 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2488 "].pViewportState->viewportCount (=%" PRIu32
2489 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2490 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002491 }
Petr Krausa6103552017-11-16 21:21:58 +01002492
2493 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002494 if (!has_dynamic_scissor_with_count) {
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002495 const char *vuid = IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state)
2496 ? "VUID-VkPipelineViewportStateCreateInfo-scissorCount-04136"
2497 : "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength";
Piers Daniell39842ee2020-07-10 16:42:33 -06002498 skip |= LogError(
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002499 device, vuid,
Piers Daniell39842ee2020-07-10 16:42:33 -06002500 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2501 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002502 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002503 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2504 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2505 "].pViewportState->scissorCount (=%" PRIu32
2506 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2507 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002508 } else if (has_dynamic_scissor_with_count) {
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002509 const char *vuid = IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state)
2510 ? "VUID-VkPipelineViewportStateCreateInfo-scissorCount-04136"
2511 : "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380";
2512 skip |= LogError(device, vuid,
Piers Daniell39842ee2020-07-10 16:42:33 -06002513 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2514 "].pViewportState->scissorCount (=%" PRIu32
2515 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2516 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002517 }
2518 }
2519
ziga-lunarg845883b2021-07-14 15:05:00 +02002520 if (!has_dynamic_scissor && viewport_state.pScissors) {
2521 for (uint32_t scissor_i = 0; scissor_i < viewport_state.scissorCount; ++scissor_i) {
2522 const auto &scissor = viewport_state.pScissors[scissor_i];
ziga-lunarga77dc802021-07-15 13:19:06 +02002523
2524 if (scissor.offset.x < 0) {
2525 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-x-02821",
2526 "vkCreateGraphicsPipelines: offset.x (=%" PRIi32 ") of pCreateInfos[%" PRIu32
2527 "].pViewportState->pScissors[%" PRIu32 "] is negative.",
2528 scissor.offset.x, i, scissor_i);
2529 }
2530
2531 if (scissor.offset.y < 0) {
2532 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-x-02821",
2533 "vkCreateGraphicsPipelines: offset.y (=%" PRIi32 ") of pCreateInfos[%" PRIu32
2534 "].pViewportState->pScissors[%" PRIu32 "] is negative.",
2535 scissor.offset.y, i, scissor_i);
2536 }
2537
ziga-lunarg845883b2021-07-14 15:05:00 +02002538 const int64_t x_sum =
2539 static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2540 if (x_sum > std::numeric_limits<int32_t>::max()) {
2541 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-offset-02822",
2542 "vkCreateGraphicsPipelines: offset.x + extent.width (=%" PRIi32 " + %" PRIu32
2543 " = %" PRIi64 ") of pCreateInfos[%" PRIu32 "].pViewportState->pScissors[%" PRIu32
2544 "] will overflow int32_t.",
2545 scissor.offset.x, scissor.extent.width, x_sum, i, scissor_i);
2546 }
ziga-lunarga77dc802021-07-15 13:19:06 +02002547
ziga-lunarg845883b2021-07-14 15:05:00 +02002548 const int64_t y_sum =
2549 static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2550 if (y_sum > std::numeric_limits<int32_t>::max()) {
2551 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-offset-02823",
2552 "vkCreateGraphicsPipelines: offset.y + extent.height (=%" PRIi32 " + %" PRIu32
2553 " = %" PRIi64 ") of pCreateInfos[%" PRIu32 "].pViewportState->pScissors[%" PRIu32
2554 "] will overflow int32_t.",
2555 scissor.offset.y, scissor.extent.height, y_sum, i, scissor_i);
2556 }
2557 }
2558 }
2559
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002560 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002561 skip |=
2562 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2563 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2564 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2565 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002566 }
2567
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002568 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002569 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2570 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2571 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2572 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2573 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002574 }
2575
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002576 if (viewport_state.scissorCount != viewport_state.viewportCount) {
2577 if (!IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state) ||
2578 (!has_dynamic_viewport_with_count && !has_dynamic_scissor_with_count)) {
2579 const char *vuid = IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state)
2580 ? "VUID-VkPipelineViewportStateCreateInfo-scissorCount-04134"
2581 : "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220";
2582 skip |= LogError(
2583 device, vuid,
2584 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2585 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2586 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
2587 }
Petr Krausa6103552017-11-16 21:21:58 +01002588 }
2589
Dave Houlton142c4cb2018-10-17 15:04:41 -06002590 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002591 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002592 skip |=
2593 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2594 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2595 ") must be zero or identical to pCreateInfos[%" PRIu32
2596 "].pViewportState->viewportCount (=%" PRIu32 ").",
2597 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002598 }
2599
Dave Houlton142c4cb2018-10-17 15:04:41 -06002600 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002601 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002602 skip |= LogError(
2603 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002604 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2605 "] "
2606 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2607 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2608 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002609 }
2610
Petr Krausa6103552017-11-16 21:21:58 +01002611 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002612 skip |= LogError(
2613 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002614 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2615 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002616 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2617 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002618 }
2619
2620 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002621 skip |= LogError(
2622 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002623 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2624 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002625 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2626 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002627 }
2628
Jeff Bolz3e71f782018-08-29 23:15:45 -05002629 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002630 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2631 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2632 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002633 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002634 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2635 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2636 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2637 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002638 }
2639
Jeff Bolz9af91c52018-09-01 21:53:57 -05002640 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002641 shading_rate_image_struct->viewportCount > 0 &&
2642 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002643 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002644 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002645 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002646 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2647 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002648 i, i);
2649 }
2650
Chris Mayer328d8212018-12-11 14:16:18 +01002651 if (vp_swizzle_struct) {
2652 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002653 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2654 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2655 " does "
2656 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2657 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002658 }
2659 }
2660
Petr Krausb3fcdb42018-01-09 22:09:09 +01002661 // validate the VkViewports
2662 if (!has_dynamic_viewport && viewport_state.pViewports) {
2663 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2664 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002665 const char *fn_name = "vkCreateGraphicsPipelines";
2666 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2667 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2668 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002669 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002670 }
2671 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002672
sfricke-samsung45996a42021-09-16 13:45:27 -07002673 if (has_dynamic_viewport_w_scaling_nv && !IsExtEnabled(device_extensions.vk_nv_clip_space_w_scaling)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002674 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2675 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2676 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2677 "VK_NV_clip_space_w_scaling extension is not enabled.",
2678 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002679 }
2680
sfricke-samsung45996a42021-09-16 13:45:27 -07002681 if (has_dynamic_discard_rectangle_ext && !IsExtEnabled(device_extensions.vk_ext_discard_rectangles)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002682 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2683 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2684 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2685 "VK_EXT_discard_rectangles extension is not enabled.",
2686 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002687 }
2688
sfricke-samsung45996a42021-09-16 13:45:27 -07002689 if (has_dynamic_sample_locations_ext && !IsExtEnabled(device_extensions.vk_ext_sample_locations)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002690 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2691 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2692 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2693 "VK_EXT_sample_locations extension is not enabled.",
2694 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002695 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002696
sfricke-samsung45996a42021-09-16 13:45:27 -07002697 if (has_dynamic_exclusive_scissor_nv && !IsExtEnabled(device_extensions.vk_nv_scissor_exclusive)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002698 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2699 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2700 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2701 "VK_NV_scissor_exclusive extension is not enabled.",
2702 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002703 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002704
2705 if (coarse_sample_order_struct &&
2706 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2707 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002708 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2709 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2710 "] "
2711 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2712 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2713 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002714 }
2715
2716 if (coarse_sample_order_struct) {
2717 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002718 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002719 }
2720 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002721
2722 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2723 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002724 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2725 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2726 "] "
2727 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2728 ") "
2729 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2730 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002731 }
2732 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002733 skip |= LogError(
2734 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002735 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2736 "] "
2737 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2738 i);
2739 }
2740 }
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002741
2742 if (depth_clip_control_struct) {
2743 const auto *depth_clip_control_features =
2744 LvlFindInChain<VkPhysicalDeviceDepthClipControlFeaturesEXT>(device_createinfo_pnext);
2745 const bool enabled_depth_clip_control =
2746 depth_clip_control_features && depth_clip_control_features->depthClipControl;
2747 if (depth_clip_control_struct->negativeOneToOne && !enabled_depth_clip_control) {
2748 skip |= LogError(device, "VUID-VkPipelineViewportDepthClipControlCreateInfoEXT-negativeOneToOne-06470",
2749 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2750 "].pViewportState has negativeOneToOne set to VK_TRUE in the pNext chain, but the "
2751 "depthClipControl feature is not enabled. ",
2752 i);
2753 }
2754 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002755 }
2756
2757 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002758 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002759 "vkCreateGraphicsPipelines: if pCreateInfos[%" PRIu32
2760 "].pRasterizationState->rasterizerDiscardEnable "
2761 "is VK_FALSE, pCreateInfos[%" PRIu32 "].pMultisampleState must not be NULL.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002762 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002763 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002764 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002765 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002766 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2767 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002768 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002769 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002770 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002771 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002772 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002773 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002774 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 4, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08002775 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2776 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002777
2778 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002779 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002780 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002781 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002782
2783 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002784 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002785 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2786 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2787
2788 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002789 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002790 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2791 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002792 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002793 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002794
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002795 skip |= validate_flags(
2796 "vkCreateGraphicsPipelines",
2797 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2798 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02002799 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002800
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002801 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002802 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002803 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2804 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2805
2806 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002807 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002808 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2809 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2810
2811 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002812 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002813 "vkCreateGraphicsPipelines: parameter pCreateInfos[%" PRIu32
2814 "].pMultisampleState->sType must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002815 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2816 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002817 }
John Zulauf7acac592017-11-06 11:15:53 -07002818 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002819 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002820 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2821 "vkCreateGraphicsPipelines(): parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002822 "pCreateInfos[%" PRIu32 "].pMultisampleState->sampleShadingEnable.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002823 i);
John Zulauf7acac592017-11-06 11:15:53 -07002824 }
2825 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2826 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2827 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002828 skip |= LogError(device,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002829
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002830 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
2831 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%" PRIu32
2832 "].pMultisampleState->minSampleShading.",
2833 i);
John Zulauf7acac592017-11-06 11:15:53 -07002834 }
2835 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002836
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002837 const auto *line_state =
2838 LvlFindInChain<VkPipelineRasterizationLineStateCreateInfoEXT>(pCreateInfos[i].pRasterizationState->pNext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002839
2840 if (line_state) {
2841 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2842 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
2843 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
2844 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002845 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2846 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002847 "pCreateInfos[%" PRIu32 "].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002848 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002849 }
2850 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
2851 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002852 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2853 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002854 "pCreateInfos[%" PRIu32 "].pMultisampleState->alphaToOneEnable == VK_TRUE.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002855 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002856 }
2857 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
2858 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002859 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2860 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002861 "pCreateInfos[%" PRIu32 "].pMultisampleState->sampleShadingEnable == VK_TRUE.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002862 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002863 }
2864 }
2865 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2866 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2867 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002868 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002869 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32 "] lineStippleFactor = %" PRIu32
2870 " must be in the "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002871 "range [1,256].",
2872 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002873 }
2874 }
2875 const auto *line_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002876 LvlFindInChain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002877 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2878 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002879 skip |=
2880 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002881 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2882 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002883 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2884 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002885 }
2886 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2887 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002888 skip |=
2889 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002890 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2891 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002892 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2893 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002894 }
2895 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2896 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002897 skip |=
2898 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002899 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2900 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002901 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
2902 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002903 }
2904 if (line_state->stippledLineEnable) {
2905 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2906 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002907 skip |=
2908 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002909 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2910 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002911 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
2912 "stippledRectangularLines feature.",
2913 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002914 }
2915 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2916 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002917 skip |=
2918 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002919 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2920 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002921 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
2922 "stippledBresenhamLines feature.",
2923 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002924 }
2925 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2926 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002927 skip |=
2928 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002929 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2930 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002931 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
2932 "stippledSmoothLines feature.",
2933 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002934 }
2935 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
Malcolm Bechardfc509002021-11-17 21:57:28 -05002936 (!line_features || !line_features->stippledRectangularLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002937 skip |=
2938 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002939 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2940 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002941 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
2942 "stippledRectangularLines and strictLines features.",
2943 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002944 }
2945 }
2946 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002947 }
2948
Petr Krause91f7a12017-12-14 20:57:36 +01002949 bool uses_color_attachment = false;
2950 bool uses_depthstencil_attachment = false;
Younggwan Kim26b9abd2021-12-07 21:22:03 +00002951 VkSubpassDescriptionFlags subpass_flags = 0;
Petr Krause91f7a12017-12-14 20:57:36 +01002952 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002953 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002954 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
2955 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01002956 const auto &subpasses_uses = subpasses_uses_it->second;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002957 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002958 uses_color_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002959 }
2960 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002961 uses_depthstencil_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002962 }
Younggwan Kim26b9abd2021-12-07 21:22:03 +00002963 subpass_flags = subpasses_uses.subpasses_flags[pCreateInfos[i].subpass];
Petr Krause91f7a12017-12-14 20:57:36 +01002964 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002965 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01002966 }
2967
2968 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002969 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002970 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002971 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002972 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002973 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002974
Mike Schuchardt00e81452021-11-29 11:11:20 -08002975 skip |=
2976 validate_flags("vkCreateGraphicsPipelines",
2977 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
2978 "VkPipelineDepthStencilStateCreateFlagBits", AllVkPipelineDepthStencilStateCreateFlagBits,
2979 pCreateInfos[i].pDepthStencilState->flags, kOptionalFlags,
2980 "VUID-VkPipelineDepthStencilStateCreateInfo-flags-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002981
2982 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002983 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002984 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2985 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2986
2987 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002988 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002989 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2990 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2991
2992 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002993 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002994 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2995 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002996 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002997
2998 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002999 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003000 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
3001 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
3002
3003 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003004 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003005 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
3006 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
3007
3008 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003009 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003010 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
3011 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003012 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003013
3014 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003015 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003016 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
3017 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003018 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003019
3020 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003021 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003022 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
3023 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003024 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003025
3026 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003027 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003028 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
3029 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003030 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003031
3032 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003033 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003034 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
3035 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003036 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003037
3038 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003039 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003040 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
3041 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003042 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003043
3044 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003045 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003046 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
3047 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003048 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003049
3050 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003051 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003052 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
3053 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003054 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003055
3056 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07003057 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003058 "vkCreateGraphicsPipelines: parameter pCreateInfos[%" PRIu32
3059 "].pDepthStencilState->sType must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003060 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
3061 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003062 }
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003063
3064 if ((pCreateInfos[i].pDepthStencilState->flags &
3065 VK_PIPELINE_DEPTH_STENCIL_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_DEPTH_ACCESS_BIT_ARM) != 0) {
3066 const auto *rasterization_order_attachment_access_feature =
3067 LvlFindInChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
3068 const bool rasterization_order_depth_attachment_access_feature_enabled =
3069 rasterization_order_attachment_access_feature &&
3070 rasterization_order_attachment_access_feature->rasterizationOrderDepthAttachmentAccess == VK_TRUE;
3071 if (!rasterization_order_depth_attachment_access_feature_enabled) {
3072 skip |= LogError(
3073 device, "VUID-VkPipelineDepthStencilStateCreateInfo-rasterizationOrderDepthAttachmentAccess-06463",
3074 "VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
3075 "rasterizationOrderDepthAttachmentAccess == VK_FALSE, but "
3076 "VkPipelineDepthStencilStateCreateInfo::flags == %s",
3077 string_VkPipelineDepthStencilStateCreateFlags(pCreateInfos[i].pDepthStencilState->flags).c_str());
3078 }
3079
3080 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_DEPTH_ACCESS_BIT_ARM) == 0) {
3081 skip |= LogError(
Mike Schuchardt979898a2022-01-11 10:46:59 -08003082 device, "VUID-VkGraphicsPipelineCreateInfo-flags-06485",
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003083 "VkPipelineDepthStencilStateCreateInfo::flags == %s but "
3084 "VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
3085 string_VkPipelineDepthStencilStateCreateFlags(pCreateInfos[i].pDepthStencilState->flags).c_str(),
3086 string_VkSubpassDescriptionFlags(subpass_flags).c_str());
3087 }
3088 }
3089
3090 if ((pCreateInfos[i].pDepthStencilState->flags &
3091 VK_PIPELINE_DEPTH_STENCIL_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_STENCIL_ACCESS_BIT_ARM) != 0) {
3092 const auto *rasterization_order_attachment_access_feature =
3093 LvlFindInChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
3094 const bool rasterization_order_stencil_attachment_access_feature_enabled =
3095 rasterization_order_attachment_access_feature &&
3096 rasterization_order_attachment_access_feature->rasterizationOrderStencilAttachmentAccess == VK_TRUE;
3097 if (!rasterization_order_stencil_attachment_access_feature_enabled) {
3098 skip |= LogError(
3099 device,
3100 "VUID-VkPipelineDepthStencilStateCreateInfo-rasterizationOrderStencilAttachmentAccess-06464",
3101 "VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
3102 "rasterizationOrderStencilAttachmentAccess == VK_FALSE, but "
3103 "VkPipelineDepthStencilStateCreateInfo::flags == %s",
3104 string_VkPipelineDepthStencilStateCreateFlags(pCreateInfos[i].pDepthStencilState->flags).c_str());
3105 }
3106
3107 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_STENCIL_ACCESS_BIT_ARM) == 0) {
3108 skip |= LogError(
Mike Schuchardt979898a2022-01-11 10:46:59 -08003109 device, "VUID-VkGraphicsPipelineCreateInfo-flags-06486",
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003110 "VkPipelineDepthStencilStateCreateInfo::flags == %s but "
3111 "VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
3112 string_VkPipelineDepthStencilStateCreateFlags(pCreateInfos[i].pDepthStencilState->flags).c_str(),
3113 string_VkSubpassDescriptionFlags(subpass_flags).c_str());
3114 }
3115 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003116 }
3117
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003118 const VkStructureType allowed_structs_vk_pipeline_color_blend_state_create_info[] = {
ziga-lunarg8de09162021-08-05 15:21:33 +02003119 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT,
3120 VK_STRUCTURE_TYPE_PIPELINE_COLOR_WRITE_CREATE_INFO_EXT};
Shannon McPherson9b9532b2018-10-24 12:00:09 -06003121
Petr Krause91f7a12017-12-14 20:57:36 +01003122 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06003123 skip |= validate_struct_type("vkCreateGraphicsPipelines",
3124 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
3125 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
3126 pCreateInfos[i].pColorBlendState,
3127 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
3128 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
3129
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003130 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003131 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06003132 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
ziga-lunarg8de09162021-08-05 15:21:33 +02003133 "VkPipelineColorBlendAdvancedStateCreateInfoEXT, VkPipelineColorWriteCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003134 ARRAY_SIZE(allowed_structs_vk_pipeline_color_blend_state_create_info),
3135 allowed_structs_vk_pipeline_color_blend_state_create_info, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08003136 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
3137 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003138
Mike Schuchardt00e81452021-11-29 11:11:20 -08003139 skip |= validate_flags("vkCreateGraphicsPipelines",
3140 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
3141 "VkPipelineColorBlendStateCreateFlagBits", AllVkPipelineColorBlendStateCreateFlagBits,
3142 pCreateInfos[i].pColorBlendState->flags, kOptionalFlags,
3143 "VUID-VkPipelineColorBlendStateCreateInfo-flags-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003144
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003145 if ((pCreateInfos[i].pColorBlendState->flags &
3146 VK_PIPELINE_COLOR_BLEND_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_ACCESS_BIT_ARM) != 0) {
3147 const auto *rasterization_order_attachment_access_feature =
3148 LvlFindInChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
3149 const bool rasterization_order_color_attachment_access_feature_enabled =
3150 rasterization_order_attachment_access_feature &&
3151 rasterization_order_attachment_access_feature->rasterizationOrderColorAttachmentAccess == VK_TRUE;
3152
3153 if (!rasterization_order_color_attachment_access_feature_enabled) {
3154 skip |= LogError(
3155 device, "VUID-VkPipelineColorBlendStateCreateInfo-rasterizationOrderColorAttachmentAccess-06465",
3156 "VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
3157 "rasterizationColorAttachmentAccess == VK_FALSE, but "
3158 "VkPipelineColorBlendStateCreateInfo::flags == %s",
3159 string_VkPipelineColorBlendStateCreateFlags(pCreateInfos[i].pColorBlendState->flags).c_str());
3160 }
3161
3162 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_COLOR_ACCESS_BIT_ARM) == 0) {
3163 skip |= LogError(
Mike Schuchardt979898a2022-01-11 10:46:59 -08003164 device, "VUID-VkGraphicsPipelineCreateInfo-flags-06484",
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003165 "VkPipelineColorBlendStateCreateInfo::flags == %s but "
3166 "VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
3167 string_VkPipelineColorBlendStateCreateFlags(pCreateInfos[i].pColorBlendState->flags).c_str(),
3168 string_VkSubpassDescriptionFlags(subpass_flags).c_str());
3169 }
3170 }
3171
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003172 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003173 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003174 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
3175 pCreateInfos[i].pColorBlendState->logicOpEnable);
3176
3177 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003178 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003179 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
3180 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003181 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06003182 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003183
3184 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003185 for (uint32_t attachment_index = 0; attachment_index < pCreateInfos[i].pColorBlendState->attachmentCount;
3186 ++attachment_index) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003187 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003188 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003189 ParameterName::IndexVector{i, attachment_index}),
3190 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].blendEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003191
3192 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003193 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003194 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003195 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003196 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003197 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003198 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003199
3200 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003201 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003202 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003203 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003204 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003205 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003206 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003207
3208 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003209 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003210 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003211 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003212 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003213 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003214 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003215
3216 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003217 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003218 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003219 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003220 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003221 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003222 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003223
3224 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003225 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003226 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003227 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003228 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003229 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003230 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003231
3232 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003233 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003234 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003235 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003236 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003237 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003238 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003239
3240 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003241 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003242 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003243 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003244 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003245 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02003246 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
ziga-lunarga283d022021-08-04 18:35:23 +02003247
3248 if (phys_dev_ext_props.blend_operation_advanced_props.advancedBlendAllOperations == VK_FALSE) {
3249 bool invalid = false;
3250 switch (pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorBlendOp) {
3251 case VK_BLEND_OP_ZERO_EXT:
3252 case VK_BLEND_OP_SRC_EXT:
3253 case VK_BLEND_OP_DST_EXT:
3254 case VK_BLEND_OP_SRC_OVER_EXT:
3255 case VK_BLEND_OP_DST_OVER_EXT:
3256 case VK_BLEND_OP_SRC_IN_EXT:
3257 case VK_BLEND_OP_DST_IN_EXT:
3258 case VK_BLEND_OP_SRC_OUT_EXT:
3259 case VK_BLEND_OP_DST_OUT_EXT:
3260 case VK_BLEND_OP_SRC_ATOP_EXT:
3261 case VK_BLEND_OP_DST_ATOP_EXT:
3262 case VK_BLEND_OP_XOR_EXT:
3263 case VK_BLEND_OP_INVERT_EXT:
3264 case VK_BLEND_OP_INVERT_RGB_EXT:
3265 case VK_BLEND_OP_LINEARDODGE_EXT:
3266 case VK_BLEND_OP_LINEARBURN_EXT:
3267 case VK_BLEND_OP_VIVIDLIGHT_EXT:
3268 case VK_BLEND_OP_LINEARLIGHT_EXT:
3269 case VK_BLEND_OP_PINLIGHT_EXT:
3270 case VK_BLEND_OP_HARDMIX_EXT:
3271 case VK_BLEND_OP_PLUS_EXT:
3272 case VK_BLEND_OP_PLUS_CLAMPED_EXT:
3273 case VK_BLEND_OP_PLUS_CLAMPED_ALPHA_EXT:
3274 case VK_BLEND_OP_PLUS_DARKER_EXT:
3275 case VK_BLEND_OP_MINUS_EXT:
3276 case VK_BLEND_OP_MINUS_CLAMPED_EXT:
3277 case VK_BLEND_OP_CONTRAST_EXT:
3278 case VK_BLEND_OP_INVERT_OVG_EXT:
3279 case VK_BLEND_OP_RED_EXT:
3280 case VK_BLEND_OP_GREEN_EXT:
3281 case VK_BLEND_OP_BLUE_EXT:
3282 invalid = true;
3283 break;
3284 default:
3285 break;
3286 }
3287 if (invalid) {
3288 skip |= LogError(
3289 device, "VUID-VkPipelineColorBlendAttachmentState-advancedBlendAllOperations-01409",
3290 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
3291 "].pColorBlendState->pAttachments[%" PRIu32
3292 "].colorBlendOp (%s) is not valid when "
3293 "VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT::advancedBlendAllOperations is "
3294 "VK_FALSE",
3295 i, attachment_index,
3296 string_VkBlendOp(
3297 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorBlendOp));
3298 }
3299 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003300 }
3301 }
3302
3303 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07003304 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003305 "vkCreateGraphicsPipelines: parameter pCreateInfos[%" PRIu32
3306 "].pColorBlendState->sType must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003307 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
3308 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003309 }
3310
3311 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
3312 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
3313 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003314 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003315 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06003316 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
3317 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003318 }
3319 }
3320 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003321
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003322 const VkPipelineCreateFlags flags = pCreateInfos[i].flags;
3323 if (flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
Petr Kraus9752aae2017-11-24 03:05:50 +01003324 if (pCreateInfos[i].basePipelineIndex != -1) {
3325 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003326 skip |=
3327 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003328 "vkCreateGraphicsPipelines parameter, pCreateInfos[%" PRIu32
3329 "]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003330 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003331 "and pCreateInfos->basePipelineIndex is not -1.",
3332 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003333 }
3334 }
3335
Petr Kraus9752aae2017-11-24 03:05:50 +01003336 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
3337 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003338 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003339 "vkCreateGraphicsPipelines parameter, pCreateInfos[%" PRIu32
3340 "]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003341 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003342 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
3343 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003344 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06003345 } else {
Mike Schuchardte5c15cf2020-04-06 22:57:13 -07003346 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003347 skip |=
3348 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003349 "vkCreateGraphicsPipelines parameter pCreateInfos[%" PRIu32 "]->basePipelineIndex (%" PRId32
3350 ") must be a valid"
3351 "index into the pCreateInfos array, of size %" PRIu32 ".",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003352 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06003353 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003354 }
3355 }
3356
Petr Kraus9752aae2017-11-24 03:05:50 +01003357 if (pCreateInfos[i].pRasterizationState) {
sfricke-samsung45996a42021-09-16 13:45:27 -07003358 if (!IsExtEnabled(device_extensions.vk_nv_fill_rectangle)) {
Chris Mayer840b2c42019-08-22 18:12:22 +02003359 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
3360 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003361 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
3362 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
3363 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
3364 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02003365 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
3366 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07003367 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003368 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003369 "pCreateInfos[%" PRIu32
3370 "]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003371 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
3372 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02003373 }
3374 } else {
3375 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
3376 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
3377 (physical_device_features.fillModeNonSolid == false)) {
3378 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003379 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
3380 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003381 "pCreateInfos[%" PRIu32
3382 "]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003383 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
3384 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02003385 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003386 }
Petr Kraus299ba622017-11-24 03:09:03 +01003387
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003388 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01003389 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003390 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
3391 "The line width state is static (pCreateInfos[%" PRIu32
3392 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
3393 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
3394 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
3395 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003396 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003397 }
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003398
3399 // Validate no flags not allowed are used
3400 if ((flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
sfricke-samsungad008902021-04-16 01:25:34 -07003401 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003402 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3403 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003404 "VK_PIPELINE_CREATE_DISPATCH_BASE.",
3405 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003406 }
3407 if ((flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
sfricke-samsungad008902021-04-16 01:25:34 -07003408 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03371",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003409 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3410 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003411 "VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.",
3412 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003413 }
3414 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
3415 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03372",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003416 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3417 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003418 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
3419 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003420 }
3421 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
3422 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03373",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003423 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3424 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003425 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
3426 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003427 }
3428 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
3429 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03374",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003430 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3431 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003432 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
3433 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003434 }
3435 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
3436 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03375",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003437 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3438 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003439 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
3440 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003441 }
3442 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
3443 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03376",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003444 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3445 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003446 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
3447 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003448 }
3449 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
3450 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03377",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003451 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3452 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003453 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
3454 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003455 }
3456 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
3457 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03577",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003458 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3459 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003460 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
3461 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003462 }
ziga-lunarg4bd42e42021-10-04 13:19:29 +02003463 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) != 0) {
3464 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-04947",
3465 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3466 "]->flags (0x%x) must not include "
3467 "VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV.",
3468 i, flags);
3469 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003470 }
3471 }
3472
3473 return skip;
3474}
3475
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003476bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
3477 uint32_t createInfoCount,
3478 const VkComputePipelineCreateInfo *pCreateInfos,
3479 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003480 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003481 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003482 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003483 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003484 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06003485 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003486 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04003487 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003488 skip |=
Tony-LunarGce3244a2021-11-19 12:33:40 -07003489 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfo-pipelineStageCreationFeedbackCount-02669",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003490 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
3491 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
3492 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04003493 }
sfricke-samsungc5227152020-02-09 17:36:31 -08003494
3495 // Make sure compute stage is selected
3496 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003497 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003498 "vkCreateComputePipelines(): the pCreateInfo[%" PRIu32
3499 "].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003500 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08003501 }
sourav parmarcd5fb182020-07-17 12:58:44 -07003502
sfricke-samsungeb549012021-04-16 01:25:51 -07003503 const VkPipelineCreateFlags flags = pCreateInfos[i].flags;
3504 // Validate no flags not allowed are used
3505 if ((flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003506 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03364",
3507 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3508 "]->flags (0x%x) must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.",
3509 i, flags);
sfricke-samsungeb549012021-04-16 01:25:51 -07003510 }
3511 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
3512 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03365",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003513 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3514 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003515 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
3516 i, flags);
3517 }
3518 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
3519 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03366",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003520 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3521 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003522 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
3523 i, flags);
3524 }
3525 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
3526 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03367",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003527 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3528 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003529 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
3530 i, flags);
3531 }
3532 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
3533 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03368",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003534 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3535 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003536 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
3537 i, flags);
3538 }
3539 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
3540 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03369",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003541 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3542 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003543 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
3544 i, flags);
3545 }
3546 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
3547 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03370",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003548 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3549 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003550 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
3551 i, flags);
3552 }
3553 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
3554 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03576",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003555 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3556 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003557 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
3558 i, flags);
3559 }
ziga-lunargf51e65f2021-07-18 23:51:57 +02003560 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) != 0) {
3561 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-04945",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003562 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3563 "]->flags (0x%x) must not include "
ziga-lunargf51e65f2021-07-18 23:51:57 +02003564 "VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV.",
3565 i, flags);
3566 }
sfricke-samsungeb549012021-04-16 01:25:51 -07003567 if ((flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) != 0) {
3568 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-02874",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003569 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3570 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003571 "VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.",
3572 i, flags);
sourav parmarcd5fb182020-07-17 12:58:44 -07003573 }
ziga-lunarg065f2402021-07-22 11:56:05 +02003574 if (flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
3575 if (pCreateInfos[i].basePipelineIndex != -1) {
3576 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
3577 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-00699",
3578 "vkCreateComputePipelines parameter, pCreateInfos[%" PRIu32
3579 "]->basePipelineHandle, must be VK_NULL_HANDLE if pCreateInfos->flags contains the "
3580 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and pCreateInfos->basePipelineIndex is not -1.",
3581 i);
3582 }
3583 }
3584
3585 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
3586 if (pCreateInfos[i].basePipelineIndex != -1) {
3587 skip |= LogError(
3588 device, "VUID-VkComputePipelineCreateInfo-flags-00700",
3589 "vkCreateComputePipelines parameter, pCreateInfos[%" PRIu32
3590 "]->basePipelineIndex, must be -1 if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT "
3591 "flag and pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
3592 i);
3593 }
3594 } else {
3595 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
3596 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-00698",
3597 "vkCreateComputePipelines parameter pCreateInfos[%" PRIu32 "]->basePipelineIndex (%" PRIi32
3598 ") must be a valid index into the pCreateInfos array, of size %" PRIu32 ".",
3599 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
3600 }
3601 }
3602 }
ziga-lunargc6341372021-07-28 12:57:42 +02003603
3604 std::stringstream msg;
3605 msg << "pCreateInfos[%" << i << "].stage";
3606 ValidatePipelineShaderStageCreateInfo("vkCreateComputePipelines", msg.str().c_str(), &pCreateInfos[i].stage);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003607 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003608 return skip;
3609}
3610
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003611bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003612 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003613 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003614
3615 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003616 const auto &features = physical_device_features;
3617 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003618
John Zulauf71968502017-10-26 13:51:15 -06003619 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
3620 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003621 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
3622 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
3623 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
3624 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06003625 }
3626
3627 // Anistropy cannot be enabled in sampler unless enabled as a feature
3628 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003629 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
3630 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
3631 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06003632 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003633 }
John Zulauf71968502017-10-26 13:51:15 -06003634
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003635 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
3636 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003637 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
3638 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3639 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3640 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003641 }
3642 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003643 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
3644 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3645 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3646 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003647 }
3648 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003649 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
3650 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3651 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
3652 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003653 }
3654 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
3655 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3656 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
3657 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003658 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
3659 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3660 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
3661 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
3662 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3663 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003664 }
3665 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003666 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
3667 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
3668 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06003669 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003670 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003671 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
3672 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
3673 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003674 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003675 }
3676
3677 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
3678 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003679 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
3680 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003681 const auto *sampler_reduction = LvlFindInChain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
sfricke-samsung85252fb2020-05-08 20:44:06 -07003682 if (sampler_reduction != nullptr) {
3683 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
3684 skip |= LogError(
3685 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
3686 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
3687 }
3688 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003689 }
3690
3691 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
3692 // valid VkBorderColor value
3693 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3694 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3695 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003696 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
3697 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003698 }
3699
John Zulauf275805c2017-10-26 15:34:49 -06003700 // Checks for the IMG cubic filtering extension
sfricke-samsung45996a42021-09-16 13:45:27 -07003701 if (IsExtEnabled(device_extensions.vk_img_filter_cubic)) {
John Zulauf275805c2017-10-26 15:34:49 -06003702 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
3703 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003704 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
3705 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
3706 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06003707 }
3708 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003709
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003710 // Check for valid Lod range
3711 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003712 skip |=
3713 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
3714 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003715 }
3716
3717 // Check mipLodBias to device limit
3718 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003719 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
3720 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
3721 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003722 }
3723
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003724 const auto *sampler_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003725 if (sampler_conversion != nullptr) {
3726 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3727 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3728 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3729 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003730 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003731 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003732 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
3733 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
3734 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
3735 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
3736 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
3737 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
3738 }
3739 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02003740
3741 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
3742 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
3743 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
3744 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3745 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3746 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
3747 }
3748 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
3749 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
3750 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3751 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3752 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
3753 }
3754 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
3755 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
3756 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3757 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
3758 pCreateInfo->minLod, pCreateInfo->maxLod);
3759 }
3760 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3761 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
3762 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3763 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
3764 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
3765 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3766 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
3767 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
3768 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3769 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
3770 }
3771 if (pCreateInfo->anisotropyEnable) {
3772 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
3773 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3774 "pCreateInfo->anisotropyEnable must be VK_FALSE");
3775 }
3776 if (pCreateInfo->compareEnable) {
3777 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
3778 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3779 "pCreateInfo->compareEnable must be VK_FALSE");
3780 }
3781 if (pCreateInfo->unnormalizedCoordinates) {
3782 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
3783 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3784 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
3785 }
3786 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003787
Piers Daniell833b9492021-11-20 11:47:10 -07003788 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
3789 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
3790 if (!IsExtEnabled(device_extensions.vk_ext_custom_border_color)) {
3791 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
3792 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
3793 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
3794 }
3795 auto custom_create_info = LvlFindInChain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
3796 if (!custom_create_info) {
3797 skip |= LogError(
3798 device, "VUID-VkSamplerCreateInfo-borderColor-04011",
3799 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
3800 "struct in pNext chain.\n",
3801 string_VkBorderColor(pCreateInfo->borderColor));
3802 } else {
3803 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
3804 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT &&
3805 !FormatIsSampledInt(custom_create_info->format)) ||
3806 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
3807 !FormatIsSampledFloat(custom_create_info->format)))) {
3808 skip |=
3809 LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
Tony-LunarG7337b312020-04-15 16:40:25 -06003810 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
3811 "whose type does not match\n",
3812 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
Piers Daniell833b9492021-11-20 11:47:10 -07003813 ;
3814 }
3815 }
3816 }
3817
3818 const auto *border_color_component_mapping =
3819 LvlFindInChain<VkSamplerBorderColorComponentMappingCreateInfoEXT>(pCreateInfo->pNext);
3820 if (border_color_component_mapping) {
3821 const auto *border_color_swizzle_features =
3822 LvlFindInChain<VkPhysicalDeviceBorderColorSwizzleFeaturesEXT>(device_createinfo_pnext);
3823 bool border_color_swizzle_features_enabled =
3824 border_color_swizzle_features && border_color_swizzle_features->borderColorSwizzle;
3825 if (!border_color_swizzle_features_enabled) {
3826 skip |= LogError(device, "VUID-VkSamplerBorderColorComponentMappingCreateInfoEXT-borderColorSwizzle-06437",
3827 "vkCreateSampler(): The borderColorSwizzle feature must be enabled to use "
3828 "VkPhysicalDeviceBorderColorSwizzleFeaturesEXT");
Tony-LunarG7337b312020-04-15 16:40:25 -06003829 }
3830 }
3831 }
3832
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003833 return skip;
3834}
3835
ziga-lunarg8a4d3192021-10-13 19:54:19 +02003836bool StatelessValidation::ValidateMutableDescriptorTypeCreateInfo(const VkDescriptorSetLayoutCreateInfo &create_info,
3837 const VkMutableDescriptorTypeCreateInfoVALVE &mutable_create_info,
3838 const char *func_name) const {
3839 bool skip = false;
3840
3841 for (uint32_t i = 0; i < create_info.bindingCount; ++i) {
3842 uint32_t mutable_type_count = 0;
3843 if (mutable_create_info.mutableDescriptorTypeListCount > i) {
3844 mutable_type_count = mutable_create_info.pMutableDescriptorTypeLists[i].descriptorTypeCount;
3845 }
3846 if (create_info.pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
3847 if (mutable_type_count == 0) {
3848 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-descriptorTypeCount-04597",
3849 "%s: VkDescriptorSetLayoutCreateInfo::pBindings[%" PRIu32
3850 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE, but "
3851 "VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3852 "].descriptorTypeCount is 0.",
3853 func_name, i, i);
3854 }
3855 } else {
3856 if (mutable_type_count > 0) {
3857 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-descriptorTypeCount-04599",
3858 "%s: VkDescriptorSetLayoutCreateInfo::pBindings[%" PRIu32
3859 "].descriptorType is %s, but "
3860 "VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3861 "].descriptorTypeCount is not 0.",
3862 func_name, i, string_VkDescriptorType(create_info.pBindings[i].descriptorType), i);
3863 }
3864 }
3865 }
3866
3867 for (uint32_t j = 0; j < mutable_create_info.mutableDescriptorTypeListCount; ++j) {
3868 for (uint32_t k = 0; k < mutable_create_info.pMutableDescriptorTypeLists[j].descriptorTypeCount; ++k) {
3869 switch (mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[k]) {
3870 case VK_DESCRIPTOR_TYPE_MUTABLE_VALVE:
3871 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04600",
3872 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3873 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE.",
3874 func_name, j, k);
3875 break;
3876 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
3877 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04601",
3878 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3879 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC.",
3880 func_name, j, k);
3881 break;
3882 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
3883 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04602",
3884 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3885 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC.",
3886 func_name, j, k);
3887 break;
3888 case VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT:
3889 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04603",
3890 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3891 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT.",
3892 func_name, j, k);
3893 break;
3894 default:
3895 break;
3896 }
3897 for (uint32_t l = k + 1; l < mutable_create_info.pMutableDescriptorTypeLists[j].descriptorTypeCount; ++l) {
3898 if (mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[k] ==
3899 mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[l]) {
3900 skip |=
3901 LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04598",
3902 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3903 "].pDescriptorTypes[%" PRIu32
3904 "] and VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3905 "].pDescriptorTypes[%" PRIu32 "] are both %s.",
3906 func_name, j, k, j, l,
3907 string_VkDescriptorType(mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[k]));
3908 }
3909 }
3910 }
3911 }
3912
3913 return skip;
3914}
3915
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003916bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
3917 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
3918 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003919 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003920 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003921
ziga-lunargfc6896f2021-10-15 18:46:12 +02003922 const auto *mutable_descriptor_type = LvlFindInChain<VkMutableDescriptorTypeCreateInfoVALVE>(pCreateInfo->pNext);
3923 const auto *mutable_descriptor_type_features = LvlFindInChain<VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE>(device_createinfo_pnext);
3924 bool mutable_descriptor_type_features_enabled =
3925 mutable_descriptor_type_features && mutable_descriptor_type_features->mutableDescriptorType == VK_TRUE;
3926
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003927 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3928 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
3929 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
3930 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003931 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3932 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
3933 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
3934 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
3935 ++descriptor_index) {
3936 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07003937 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003938 "vkCreateDescriptorSetLayout: required parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003939 "pCreateInfo->pBindings[%" PRIu32 "].pImmutableSamplers[%" PRIu32
3940 "] specified as VK_NULL_HANDLE",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003941 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003942 }
3943 }
3944 }
3945
3946 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
3947 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
3948 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003949 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003950 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%" PRIu32
3951 "].descriptorCount is not 0, "
3952 "pCreateInfo->pBindings[%" PRIu32
3953 "].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003954 "values.",
3955 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003956 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07003957
3958 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
3959 (pCreateInfo->pBindings[i].stageFlags != 0) &&
3960 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003961 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
3962 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%" PRIu32
3963 "].descriptorCount is not 0 and "
3964 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%" PRIu32
3965 "].stageFlags "
3966 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
3967 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
Spencer Fricke84d0cc02020-03-16 17:21:59 -07003968 }
ziga-lunargfc6896f2021-10-15 18:46:12 +02003969
3970 if (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
3971 if (!mutable_descriptor_type) {
3972 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-descriptorType-04593",
3973 "vkCreateDescriptorSetLayout(): pCreateInfo->pBindings[%" PRIu32
3974 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE but "
3975 "VkMutableDescriptorTypeCreateInfoVALVE is not included in the pNext chain.",
3976 i);
3977 }
3978 if (pCreateInfo->pBindings[i].pImmutableSamplers) {
3979 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-descriptorType-04594",
3980 "vkCreateDescriptorSetLayout(): pCreateInfo->pBindings[%" PRIu32
3981 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE but "
3982 "pImmutableSamplers is not NULL.",
3983 i);
3984 }
3985 if (!mutable_descriptor_type_features_enabled) {
3986 skip |= LogError(
3987 device, "VUID-VkDescriptorSetLayoutCreateInfo-mutableDescriptorType-04595",
3988 "vkCreateDescriptorSetLayout(): pCreateInfo->pBindings[%" PRIu32
3989 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE but "
3990 "VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType feature is not enabled.",
3991 i);
3992 }
3993 }
3994
3995 if (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR &&
3996 pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
3997 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04591",
3998 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains "
3999 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR, but pCreateInfo->pBindings[%" PRIu32
4000 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE.", i);
4001 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004002 }
4003 }
ziga-lunarg8a4d3192021-10-13 19:54:19 +02004004
4005 if (mutable_descriptor_type) {
4006 ValidateMutableDescriptorTypeCreateInfo(*pCreateInfo, *mutable_descriptor_type,
4007 "vkDescriptorSetLayoutCreateInfo");
4008 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004009 }
ziga-lunargfc6896f2021-10-15 18:46:12 +02004010 if (pCreateInfo) {
4011 if ((pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR) &&
4012 (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE)) {
4013 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04590",
4014 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains both "
4015 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR and "
4016 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE.");
4017 }
4018 if ((pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT) &&
4019 (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE)) {
4020 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04592",
4021 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains both "
4022 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT and "
4023 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE.");
4024 }
4025 if (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE &&
4026 !mutable_descriptor_type_features_enabled) {
4027 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04596",
4028 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains "
4029 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE, but "
4030 "VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType feature is not enabled.");
4031 }
4032 }
4033
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004034 return skip;
4035}
4036
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004037bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
4038 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004039 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004040 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4041 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
4042 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004043 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
4044 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004045}
4046
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004047bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
4048 const VkWriteDescriptorSet *pDescriptorWrites,
Mike Schuchardt979898a2022-01-11 10:46:59 -08004049 const bool isPushDescriptor) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004050 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004051
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004052 if (pDescriptorWrites != NULL) {
4053 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
4054 // descriptorCount must be greater than 0
4055 if (pDescriptorWrites[i].descriptorCount == 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004056 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
4057 "%s(): parameter pDescriptorWrites[%" PRIu32 "].descriptorCount must be greater than 0.",
4058 vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004059 }
4060
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004061 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
Mike Schuchardt979898a2022-01-11 10:46:59 -08004062 if (!isPushDescriptor) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004063 // dstSet must be a valid VkDescriptorSet handle
4064 skip |= validate_required_handle(vkCallingFunction,
4065 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
4066 pDescriptorWrites[i].dstSet);
4067 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004068
4069 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
4070 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
4071 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
4072 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
4073 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004074 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mike Schuchardt979898a2022-01-11 10:46:59 -08004075 if (!isPushDescriptor) {
4076 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
4077 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or
4078 // VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pImageInfo must be a pointer to an array of descriptorCount valid
4079 // VkDescriptorImageInfo structures. Valid imageView handles are checked in
4080 // ObjectLifetimes::ValidateDescriptorWrite.
4081 skip |= LogError(
4082 device, "VUID-vkUpdateDescriptorSets-pDescriptorWrites-06493",
4083 "%s(): if pDescriptorWrites[%" PRIu32
4084 "].descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
4085 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
4086 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%" PRIu32 "].pImageInfo must not be NULL.",
4087 vkCallingFunction, i, i);
4088 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
4089 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
4090 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
4091 // If called from vkCmdPushDescriptorSetKHR, pImageInfo is only requred for descriptor types
4092 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, and
4093 // VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT
4094 skip |= LogError(device, "VUID-vkCmdPushDescriptorSetKHR-pDescriptorWrites-06494",
4095 "%s(): if pDescriptorWrites[%" PRIu32
4096 "].descriptorType is VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE "
4097 "or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%" PRIu32
4098 "].pImageInfo must not be NULL.",
4099 vkCallingFunction, i, i);
4100 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004101 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
4102 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05004103 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
4104 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004105 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
4106 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004107 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004108 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
4109 ParameterName::IndexVector{i, descriptor_index}),
4110 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06004111 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004112 }
4113 }
4114 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
4115 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
4116 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
4117 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
4118 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
4119 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
4120 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05004121 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004122 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004123 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004124 "%s(): if pDescriptorWrites[%" PRIu32
4125 "].descriptorType is "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004126 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
4127 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004128 "pDescriptorWrites[%" PRIu32 "].pBufferInfo must not be NULL.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004129 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004130 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05004131 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004132 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05004133 if (robustness2_features && robustness2_features->nullDescriptor) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004134 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
4135 ++descriptor_index) {
4136 if (pDescriptorWrites[i].pBufferInfo[descriptor_index].buffer == VK_NULL_HANDLE &&
4137 (pDescriptorWrites[i].pBufferInfo[descriptor_index].offset != 0 ||
4138 pDescriptorWrites[i].pBufferInfo[descriptor_index].range != VK_WHOLE_SIZE)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05004139 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004140 "%s(): if pDescriptorWrites[%" PRIu32
4141 "].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01004142 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004143 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptor_index].offset,
4144 pDescriptorWrites[i].pBufferInfo[descriptor_index].range);
Jeff Bolz165818a2020-05-08 11:19:03 -05004145 }
4146 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004147 }
4148 }
4149 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
4150 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05004151 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004152 }
4153
4154 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
4155 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004156 VkDeviceSize uniform_alignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004157 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
4158 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004159 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06004160 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004161 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004162 "%s(): pDescriptorWrites[%" PRIu32 "].pBufferInfo[%" PRIu32 "].offset (0x%" PRIxLEAST64
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004163 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004164 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004165 }
4166 }
4167 }
4168 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
4169 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004170 VkDeviceSize storage_alignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004171 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
4172 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004173 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06004174 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004175 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004176 "%s(): pDescriptorWrites[%" PRIu32 "].pBufferInfo[%" PRIu32 "].offset (0x%" PRIxLEAST64
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004177 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004178 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004179 }
4180 }
4181 }
4182 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004183 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
4184 // or VkWriteDescriptorSetInlineUniformBlockEX
sourav parmarbcee7512020-12-28 14:34:49 -08004185 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004186 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08004187 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
4188 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
4189 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
4190 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004191 "accelerationStructureCount %" PRIu32 " member equals descriptorCount %" PRIu32 ".",
sourav parmarbcee7512020-12-28 14:34:49 -08004192 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
4193 pDescriptorWrites[i].descriptorCount);
4194 }
4195 // further checks only if we have right structtype
4196 if (pnext_struct) {
4197 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
4198 skip |= LogError(
4199 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004200 "%s(): accelerationStructureCount %" PRIu32 " must be equal to descriptorCount %" PRIu32
4201 " in the extended structure "
sourav parmarbcee7512020-12-28 14:34:49 -08004202 ".",
4203 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07004204 }
sourav parmarbcee7512020-12-28 14:34:49 -08004205 if (pnext_struct->accelerationStructureCount == 0) {
4206 skip |= LogError(device,
4207 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004208 "%s(): accelerationStructureCount must be greater than 0 .", vkCallingFunction);
sourav parmarbcee7512020-12-28 14:34:49 -08004209 }
4210 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004211 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08004212 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
4213 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
4214 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
4215 skip |= LogError(device,
4216 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-pAccelerationStructures-03580",
4217 "%s(): If the nullDescriptor feature is not enabled, each member of "
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004218 "pAccelerationStructures must not be VK_NULL_HANDLE.", vkCallingFunction);
sourav parmarcd5fb182020-07-17 12:58:44 -07004219 }
4220 }
4221 }
sourav parmarbcee7512020-12-28 14:34:49 -08004222 }
4223 } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004224 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureNV>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08004225 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
4226 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-03817",
4227 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV, the pNext"
4228 "chain must include a VkWriteDescriptorSetAccelerationStructureNV structure whose "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004229 "accelerationStructureCount %" PRIu32 " member equals descriptorCount %" PRIu32 ".",
sourav parmarbcee7512020-12-28 14:34:49 -08004230 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
4231 pDescriptorWrites[i].descriptorCount);
4232 }
4233 // further checks only if we have right structtype
4234 if (pnext_struct) {
4235 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
4236 skip |= LogError(
4237 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-03747",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004238 "%s(): accelerationStructureCount %" PRIu32 " must be equal to descriptorCount %" PRIu32
4239 " in the extended structure "
sourav parmarbcee7512020-12-28 14:34:49 -08004240 ".",
4241 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmarcd5fb182020-07-17 12:58:44 -07004242 }
sourav parmarbcee7512020-12-28 14:34:49 -08004243 if (pnext_struct->accelerationStructureCount == 0) {
4244 skip |= LogError(device,
4245 "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-arraylength",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004246 "%s(): accelerationStructureCount must be greater than 0 .", vkCallingFunction);
sourav parmarbcee7512020-12-28 14:34:49 -08004247 }
4248 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004249 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08004250 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
4251 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
4252 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
4253 skip |= LogError(device,
4254 "VUID-VkWriteDescriptorSetAccelerationStructureNV-pAccelerationStructures-03749",
4255 "%s(): If the nullDescriptor feature is not enabled, each member of "
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004256 "pAccelerationStructures must not be VK_NULL_HANDLE.", vkCallingFunction);
sourav parmarcd5fb182020-07-17 12:58:44 -07004257 }
4258 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004259 }
4260 }
4261 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004262 }
4263 }
4264 return skip;
4265}
4266
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004267bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
4268 const VkWriteDescriptorSet *pDescriptorWrites,
4269 uint32_t descriptorCopyCount,
4270 const VkCopyDescriptorSet *pDescriptorCopies) const {
Mike Schuchardt979898a2022-01-11 10:46:59 -08004271 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites, false);
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004272}
4273
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004274bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004275 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004276 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004277 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
4278}
4279
sfricke-samsung681ab7b2020-10-29 01:53:35 -07004280bool StatelessValidation::manual_PreCallValidateCreateRenderPass2(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
4281 const VkAllocationCallbacks *pAllocator,
4282 VkRenderPass *pRenderPass) const {
4283 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
4284}
4285
Mike Schuchardt2df08912020-12-15 16:28:09 -08004286bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004287 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004288 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004289 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
4290}
4291
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004292bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
4293 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004294 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004295 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004296
4297 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4298 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
4299 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004300 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
4301 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004302 return skip;
4303}
4304
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004305bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004306 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004307 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02004308
4309 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
4310 const char *cmd_name = "vkBeginCommandBuffer";
Tony-LunarG3c287f62020-12-17 12:39:49 -07004311 bool cb_is_secondary;
4312 {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06004313 auto lock = CBReadLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07004314 cb_is_secondary = (secondary_cb_map.find(commandBuffer) != secondary_cb_map.end());
4315 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004316
Tony-LunarG3c287f62020-12-17 12:39:49 -07004317 if (cb_is_secondary) {
4318 // Implicit VUs
4319 // validate only sType here; pointer has to be validated in core_validation
4320 const bool k_not_required = false;
4321 const char *k_no_vuid = nullptr;
4322 const VkCommandBufferInheritanceInfo *info = pBeginInfo->pInheritanceInfo;
4323 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004324 info, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, k_not_required, k_no_vuid,
4325 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004326
Tony-LunarG3c287f62020-12-17 12:39:49 -07004327 if (info) {
4328 const VkStructureType allowed_structs_vk_command_buffer_inheritance_info[] = {
David Zhao Akeley44139b12021-04-26 16:16:13 -07004329 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT,
amhagana448ea52021-11-02 14:09:14 -04004330 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_RENDERING_INFO_KHR,
4331 VK_STRUCTURE_TYPE_ATTACHMENT_SAMPLE_COUNT_INFO_AMD,
David Zhao Akeley44139b12021-04-26 16:16:13 -07004332 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_VIEWPORT_SCISSOR_INFO_NV};
Tony-LunarG3c287f62020-12-17 12:39:49 -07004333 skip |= validate_struct_pnext(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004334 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT",
4335 info->pNext, ARRAY_SIZE(allowed_structs_vk_command_buffer_inheritance_info),
4336 allowed_structs_vk_command_buffer_inheritance_info, GeneratedVulkanHeaderVersion,
4337 "VUID-VkCommandBufferInheritanceInfo-pNext-pNext", "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004338
Tony-LunarG3c287f62020-12-17 12:39:49 -07004339 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", info->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004340
Tony-LunarG3c287f62020-12-17 12:39:49 -07004341 // Explicit VUs
4342 if (!physical_device_features.inheritedQueries && info->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004343 skip |= LogError(
Tony-LunarG3c287f62020-12-17 12:39:49 -07004344 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
4345 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
4346 cmd_name);
4347 }
4348
4349 if (physical_device_features.inheritedQueries) {
4350 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004351 AllVkQueryControlFlagBits, info->queryFlags, kOptionalFlags,
4352 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
4353 } else { // !inheritedQueries
Tony-LunarG3c287f62020-12-17 12:39:49 -07004354 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", info->queryFlags,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004355 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Tony-LunarG3c287f62020-12-17 12:39:49 -07004356 }
4357
4358 if (physical_device_features.pipelineStatisticsQuery) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004359 skip |=
4360 validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
4361 AllVkQueryPipelineStatisticFlagBits, info->pipelineStatistics, kOptionalFlags,
4362 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
4363 } else { // !pipelineStatisticsQuery
4364 skip |=
4365 validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", info->pipelineStatistics,
4366 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Tony-LunarG3c287f62020-12-17 12:39:49 -07004367 }
4368
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004369 const auto *conditional_rendering = LvlFindInChain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(info->pNext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07004370 if (conditional_rendering) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004371 const auto *cr_features = LvlFindInChain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07004372 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
4373 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
4374 skip |= LogError(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004375 commandBuffer,
4376 "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Tony-LunarG3c287f62020-12-17 12:39:49 -07004377 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
4378 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
4379 }
Petr Kraus139757b2019-08-15 17:19:33 +02004380 }
ziga-lunarg9d019132021-07-19 01:05:31 +02004381
4382 auto p_inherited_viewport_scissor_info = LvlFindInChain<VkCommandBufferInheritanceViewportScissorInfoNV>(info->pNext);
4383 if (p_inherited_viewport_scissor_info != nullptr && !physical_device_features.multiViewport &&
4384 p_inherited_viewport_scissor_info->viewportScissor2D == VK_TRUE &&
4385 p_inherited_viewport_scissor_info->viewportDepthCount != 1) {
4386 skip |= LogError(commandBuffer, "VUID-VkCommandBufferInheritanceViewportScissorInfoNV-viewportScissor2D-04783",
4387 "vkBeginCommandBuffer: multiViewport feature is disabled, but "
4388 "VkCommandBufferInheritanceViewportScissorInfoNV::viewportScissor2D in "
4389 "pBeginInfo->pInheritanceInfo->pNext is VK_TRUE and viewportDepthCount is not 1.");
4390 }
Petr Kraus139757b2019-08-15 17:19:33 +02004391 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004392 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004393 return skip;
4394}
4395
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004396bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004397 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004398 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004399
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004400 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01004401 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004402 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
4403 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
4404 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01004405 }
4406 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004407 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
4408 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
4409 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01004410 }
4411 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01004412 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004413 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004414 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
4415 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4416 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4417 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004418 }
4419 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01004420
4421 if (pViewports) {
4422 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
4423 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06004424 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004425 skip |= manual_PreCallValidateViewport(
4426 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01004427 }
4428 }
4429
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004430 return skip;
4431}
4432
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004433bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004434 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004435 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004436
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004437 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004438 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004439 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
4440 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
4441 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004442 }
4443 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004444 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
4445 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
4446 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004447 }
4448 } else { // multiViewport enabled
4449 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004450 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004451 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
4452 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4453 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4454 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004455 }
4456 }
4457
Petr Kraus6260f0a2018-02-27 21:15:55 +01004458 if (pScissors) {
4459 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
4460 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004461
Petr Kraus6260f0a2018-02-27 21:15:55 +01004462 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004463 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
4464 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
4465 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004466 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004467
Petr Kraus6260f0a2018-02-27 21:15:55 +01004468 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004469 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
4470 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
4471 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004472 }
4473
4474 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
4475 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004476 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
4477 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4478 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4479 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004480 }
4481
4482 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
4483 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004484 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
4485 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4486 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4487 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004488 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004489 }
4490 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01004491
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004492 return skip;
4493}
4494
Jeff Bolz5c801d12019-10-09 10:38:45 -05004495bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01004496 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01004497
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004498 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004499 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
4500 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01004501 }
4502
4503 return skip;
4504}
4505
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004506bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004507 uint32_t drawCount, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004508 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004509
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004510 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski41ce65b2020-10-30 12:17:06 -06004511 skip |= LogError(device, "VUID-vkCmdDrawIndirect-drawCount-02718",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004512 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %" PRIu32 "",
4513 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004514 }
4515 if (drawCount > device_limits.maxDrawIndirectCount) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004516 skip |=
4517 LogError(commandBuffer, "VUID-vkCmdDrawIndirect-drawCount-02719",
4518 "CmdDrawIndirect(): drawCount (%" PRIu32 ") is not less than or equal to the maximum allowed (%" PRIu32 ").",
4519 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004520 }
4521 return skip;
4522}
4523
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004524bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004525 VkDeviceSize offset, uint32_t drawCount,
4526 uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004527 bool skip = false;
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004528 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004529 skip |=
4530 LogError(device, "VUID-vkCmdDrawIndexedIndirect-drawCount-02718",
4531 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %" PRIu32 "",
4532 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004533 }
4534 if (drawCount > device_limits.maxDrawIndirectCount) {
4535 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirect-drawCount-02719",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004536 "CmdDrawIndexedIndirect(): drawCount (%" PRIu32
4537 ") is not less than or equal to the maximum allowed (%" PRIu32 ").",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004538 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004539 }
4540 return skip;
4541}
4542
sfricke-samsungf692b972020-05-02 08:00:45 -07004543bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
4544 VkDeviceSize countBufferOffset, bool khr) const {
4545 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004546 const char *api_name = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07004547 if (offset & 3) {
4548 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004549 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07004550 }
4551
4552 if (countBufferOffset & 3) {
4553 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004554 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07004555 countBufferOffset);
4556 }
4557 return skip;
4558}
4559
4560bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
4561 VkDeviceSize offset, VkBuffer countBuffer,
4562 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
4563 uint32_t stride) const {
4564 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
4565}
4566
4567bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
4568 VkDeviceSize offset, VkBuffer countBuffer,
4569 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
4570 uint32_t stride) const {
4571 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
4572}
4573
4574bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
4575 VkDeviceSize countBufferOffset, bool khr) const {
4576 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004577 const char *api_name = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07004578 if (offset & 3) {
4579 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004580 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07004581 }
4582
4583 if (countBufferOffset & 3) {
4584 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004585 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07004586 countBufferOffset);
4587 }
4588 return skip;
4589}
4590
4591bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
4592 VkDeviceSize offset, VkBuffer countBuffer,
4593 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
4594 uint32_t stride) const {
4595 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
4596}
4597
4598bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
4599 VkDeviceSize offset, VkBuffer countBuffer,
4600 VkDeviceSize countBufferOffset,
4601 uint32_t maxDrawCount, uint32_t stride) const {
4602 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
4603}
4604
Tony-LunarG4490de42021-06-21 15:49:19 -06004605bool StatelessValidation::manual_PreCallValidateCmdDrawMultiEXT(VkCommandBuffer commandBuffer, uint32_t drawCount,
4606 const VkMultiDrawInfoEXT *pVertexInfo, uint32_t instanceCount,
4607 uint32_t firstInstance, uint32_t stride) const {
4608 bool skip = false;
4609 if (stride & 3) {
4610 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiEXT-stride-04936",
4611 "CmdDrawMultiEXT: parameter, uint32_t stride (%" PRIu32 ") is not a multiple of 4.", stride);
4612 }
4613 if (drawCount && nullptr == pVertexInfo) {
4614 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiEXT-drawCount-04935",
4615 "CmdDrawMultiEXT: parameter, VkMultiDrawInfoEXT *pVertexInfo must be a valid pointer to memory containing "
4616 "one or more valid instances of VkMultiDrawInfoEXT structures");
4617 }
4618 return skip;
4619}
4620
4621bool StatelessValidation::manual_PreCallValidateCmdDrawMultiIndexedEXT(VkCommandBuffer commandBuffer, uint32_t drawCount,
4622 const VkMultiDrawIndexedInfoEXT *pIndexInfo,
4623 uint32_t instanceCount, uint32_t firstInstance,
4624 uint32_t stride, const int32_t *pVertexOffset) const {
4625 bool skip = false;
4626 if (stride & 3) {
4627 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiIndexedEXT-stride-04941",
4628 "CmdDrawMultiIndexedEXT: parameter, uint32_t stride (%" PRIu32 ") is not a multiple of 4.", stride);
4629 }
4630 if (drawCount && nullptr == pIndexInfo) {
4631 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiIndexedEXT-drawCount-04940",
4632 "CmdDrawMultiIndexedEXT: parameter, VkMultiDrawIndexedInfoEXT *pIndexInfo must be a valid pointer to "
4633 "memory containing one or more valid instances of VkMultiDrawIndexedInfoEXT structures");
4634 }
4635 return skip;
4636}
4637
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004638bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
4639 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004640 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004641 bool skip = false;
4642 for (uint32_t rect = 0; rect < rectCount; rect++) {
4643 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004644 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004645 "CmdClearAttachments(): pRects[%" PRIu32 "].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004646 }
sfricke-samsung10867682020-04-25 02:20:39 -07004647 if (pRects[rect].rect.extent.width == 0) {
4648 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004649 "CmdClearAttachments(): pRects[%" PRIu32 "].rect.extent.width is zero.", rect);
sfricke-samsung10867682020-04-25 02:20:39 -07004650 }
4651 if (pRects[rect].rect.extent.height == 0) {
4652 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004653 "CmdClearAttachments(): pRects[%" PRIu32 "].rect.extent.height is zero.", rect);
sfricke-samsung10867682020-04-25 02:20:39 -07004654 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004655 }
4656 return skip;
4657}
4658
Andrew Fobel3abeb992020-01-20 16:33:22 -05004659bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
4660 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4661 VkImageFormatProperties2 *pImageFormatProperties,
4662 const char *apiName) const {
4663 bool skip = false;
4664
4665 if (pImageFormatInfo != nullptr) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004666 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pImageFormatInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05004667 if (image_stencil_struct != nullptr) {
4668 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
4669 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
4670 // No flags other than the legal attachment bits may be set
4671 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
4672 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004673 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
4674 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
4675 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
4676 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
4677 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05004678 }
4679 }
4680 }
ziga-lunargd3da2532021-08-11 11:50:12 +02004681 const auto image_drm_format = LvlFindInChain<VkPhysicalDeviceImageDrmFormatModifierInfoEXT>(pImageFormatInfo->pNext);
4682 if (image_drm_format) {
4683 if (pImageFormatInfo->tiling != VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4684 skip |= LogError(
4685 physicalDevice, "VUID-VkPhysicalDeviceImageFormatInfo2-tiling-02249",
4686 "%s(): pNext chain of VkPhysicalDeviceImageFormatInfo2 includes VkPhysicalDeviceImageDrmFormatModifierInfoEXT, "
4687 "but tiling (%s) is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.",
4688 apiName, string_VkImageTiling(pImageFormatInfo->tiling));
4689 }
ziga-lunarg27e256d2021-10-07 23:38:12 +02004690 if (image_drm_format->sharingMode == VK_SHARING_MODE_CONCURRENT && image_drm_format->queueFamilyIndexCount <= 1) {
4691 skip |= LogError(
4692 physicalDevice, "VUID-VkPhysicalDeviceImageDrmFormatModifierInfoEXT-sharingMode-02315",
4693 "%s: pNext chain of VkPhysicalDeviceImageFormatInfo2 includes VkPhysicalDeviceImageDrmFormatModifierInfoEXT, "
4694 "with sharing mode VK_SHARING_MODE_CONCURRENT, but queueFamilyIndexCount is %" PRIu32 ".",
4695 apiName, image_drm_format->queueFamilyIndexCount);
4696 }
ziga-lunargd3da2532021-08-11 11:50:12 +02004697 } else {
4698 if (pImageFormatInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4699 skip |= LogError(
4700 physicalDevice, "VUID-VkPhysicalDeviceImageFormatInfo2-tiling-02249",
4701 "%s(): pNext chain of VkPhysicalDeviceImageFormatInfo2 does not include "
4702 "VkPhysicalDeviceImageDrmFormatModifierInfoEXT, but tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.",
4703 apiName);
4704 }
4705 }
4706 if (pImageFormatInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT &&
4707 (pImageFormatInfo->flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT)) {
4708 const auto format_list = LvlFindInChain<VkImageFormatListCreateInfo>(pImageFormatInfo->pNext);
4709 if (!format_list || format_list->viewFormatCount == 0) {
4710 skip |= LogError(
4711 physicalDevice, "VUID-VkPhysicalDeviceImageFormatInfo2-tiling-02313",
4712 "%s(): tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT and flags contain VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT "
4713 "bit, but the pNext chain does not include VkImageFormatListCreateInfo with non-zero viewFormatCount.",
4714 apiName);
4715 }
4716 }
Andrew Fobel3abeb992020-01-20 16:33:22 -05004717 }
4718
4719 return skip;
4720}
4721
4722bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
4723 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4724 VkImageFormatProperties2 *pImageFormatProperties) const {
4725 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
4726 "vkGetPhysicalDeviceImageFormatProperties2");
4727}
4728
4729bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
4730 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4731 VkImageFormatProperties2 *pImageFormatProperties) const {
4732 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
4733 "vkGetPhysicalDeviceImageFormatProperties2KHR");
4734}
4735
Lionel Landwerlin5fe52752020-07-22 08:18:14 +03004736bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties(
4737 VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage,
4738 VkImageCreateFlags flags, VkImageFormatProperties *pImageFormatProperties) const {
4739 bool skip = false;
4740
4741 if (tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4742 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceImageFormatProperties-tiling-02248",
4743 "vkGetPhysicalDeviceImageFormatProperties(): tiling must not be VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.");
4744 }
4745
4746 return skip;
4747}
4748
ziga-lunarg73b5ef22021-07-29 20:25:06 +02004749bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceVideoFormatPropertiesKHR(
4750 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceVideoFormatInfoKHR *pVideoFormatInfo,
4751 uint32_t *pVideoFormatPropertyCount, VkVideoFormatPropertiesKHR *pVideoFormatProperties) const {
4752 bool skip = false;
4753
4754 if ((pVideoFormatInfo->imageUsage & (VK_IMAGE_USAGE_VIDEO_DECODE_DST_BIT_KHR | VK_IMAGE_USAGE_VIDEO_DECODE_DPB_BIT_KHR |
4755 VK_IMAGE_USAGE_VIDEO_ENCODE_SRC_BIT_KHR | VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR)) == 0) {
4756 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceVideoFormatPropertiesKHR-imageUsage-04844",
4757 "vkGetPhysicalDeviceVideoFormatPropertiesKHR(): pVideoFormatInfo->imageUsage does not contain any of "
4758 "VK_IMAGE_USAGE_VIDEO_DECODE_DST_BIT_KHR, VK_IMAGE_USAGE_VIDEO_DECODE_DPB_BIT_KHR, "
4759 "VK_IMAGE_USAGE_VIDEO_ENCODE_SRC_BIT_KHR, or VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR.");
4760 }
4761
ziga-lunarg42f884b2021-08-25 16:13:20 +02004762 return skip;
ziga-lunarg73b5ef22021-07-29 20:25:06 +02004763}
4764
sfricke-samsung3999ef62020-02-09 17:05:59 -08004765bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
4766 uint32_t regionCount, const VkBufferCopy *pRegions) const {
4767 bool skip = false;
4768
4769 if (pRegions != nullptr) {
4770 for (uint32_t i = 0; i < regionCount; i++) {
4771 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004772 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004773 "vkCmdCopyBuffer() pRegions[%" PRIu32 "].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08004774 }
4775 }
4776 }
4777 return skip;
4778}
4779
Jeff Leger178b1e52020-10-05 12:22:23 -04004780bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2KHR(VkCommandBuffer commandBuffer,
4781 const VkCopyBufferInfo2KHR *pCopyBufferInfo) const {
4782 bool skip = false;
4783
4784 if (pCopyBufferInfo->pRegions != nullptr) {
4785 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
4786 if (pCopyBufferInfo->pRegions[i].size == 0) {
Tony-LunarGef035472021-11-02 10:23:33 -06004787 skip |= LogError(device, "VUID-VkBufferCopy2-size-01988",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004788 "vkCmdCopyBuffer2KHR() pCopyBufferInfo->pRegions[%" PRIu32 "].size must be greater than zero", i);
Jeff Leger178b1e52020-10-05 12:22:23 -04004789 }
4790 }
4791 }
4792 return skip;
4793}
4794
Tony-LunarGef035472021-11-02 10:23:33 -06004795bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2(VkCommandBuffer commandBuffer,
4796 const VkCopyBufferInfo2 *pCopyBufferInfo) const {
4797 bool skip = false;
4798
4799 if (pCopyBufferInfo->pRegions != nullptr) {
4800 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
4801 if (pCopyBufferInfo->pRegions[i].size == 0) {
4802 skip |= LogError(device, "VUID-VkBufferCopy2-size-01988",
4803 "vkCmdCopyBuffer2() pCopyBufferInfo->pRegions[%" PRIu32 "].size must be greater than zero", i);
4804 }
4805 }
4806 }
4807 return skip;
4808}
4809
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004810bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004811 VkDeviceSize dstOffset, VkDeviceSize dataSize,
4812 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004813 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004814
4815 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004816 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
4817 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4818 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004819 }
4820
4821 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004822 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
4823 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
4824 "), must be greater than zero and less than or equal to 65536.",
4825 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004826 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004827 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
4828 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4829 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004830 }
4831 return skip;
4832}
4833
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004834bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004835 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004836 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004837
4838 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004839 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
4840 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4841 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004842 }
4843
4844 if (size != VK_WHOLE_SIZE) {
4845 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004846 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004847 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
4848 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004849 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004850 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
4851 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004852 }
4853 }
4854 return skip;
4855}
4856
sfricke-samsunga1d00272021-03-10 21:37:41 -08004857bool StatelessValidation::ValidateSwapchainCreateInfo(const char *func_name, VkSwapchainCreateInfoKHR const *pCreateInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004858 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004859
4860 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004861 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4862 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
4863 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
4864 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004865 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004866 "%s: if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
4867 "pCreateInfo->queueFamilyIndexCount must be greater than 1.",
4868 func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004869 }
4870
4871 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
4872 // queueFamilyIndexCount uint32_t values
4873 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004874 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004875 "%s: if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004876 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
sfricke-samsunga1d00272021-03-10 21:37:41 -08004877 "pCreateInfo->queueFamilyIndexCount uint32_t values.",
4878 func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004879 }
4880 }
4881
Dave Houlton413a6782018-05-22 13:01:54 -06004882 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004883 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004884
sfricke-samsunga1d00272021-03-10 21:37:41 -08004885 // Validate VK_KHR_image_format_list VkImageFormatListCreateInfo
4886 const auto format_list_info = LvlFindInChain<VkImageFormatListCreateInfo>(pCreateInfo->pNext);
4887 if (format_list_info) {
4888 const uint32_t viewFormatCount = format_list_info->viewFormatCount;
4889 if (((pCreateInfo->flags & VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR) == 0) && (viewFormatCount > 1)) {
4890 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-flags-04100",
4891 "%s: If the VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR is not set, then "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004892 "VkImageFormatListCreateInfo::viewFormatCount (%" PRIu32
4893 ") must be 0 or 1 if it is in the pNext chain.",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004894 func_name, viewFormatCount);
4895 }
4896
4897 // Using the first format, compare the rest of the formats against it that they are compatible
4898 for (uint32_t i = 1; i < viewFormatCount; i++) {
4899 if (FormatCompatibilityClass(format_list_info->pViewFormats[0]) !=
4900 FormatCompatibilityClass(format_list_info->pViewFormats[i])) {
4901 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-pNext-04099",
4902 "%s: VkImageFormatListCreateInfo::pViewFormats[0] (%s) and "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004903 "VkImageFormatListCreateInfo::pViewFormats[%" PRIu32
4904 "] (%s) are not compatible in the pNext chain.",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004905 func_name, string_VkFormat(format_list_info->pViewFormats[0]), i,
4906 string_VkFormat(format_list_info->pViewFormats[i]));
4907 }
4908 }
4909 }
4910
4911 // Validate VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR
4912 if ((pCreateInfo->flags & VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR) != 0) {
4913 if (!IsExtEnabled(device_extensions.vk_khr_swapchain_mutable_format)) {
4914 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
4915 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR which requires the "
4916 "VK_KHR_swapchain_mutable_format extension, which has not been enabled.",
4917 func_name);
4918 } else {
4919 if (format_list_info == nullptr) {
4920 skip |= LogError(
4921 device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
4922 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but the pNext chain of "
4923 "pCreateInfo does not contain an instance of VkImageFormatListCreateInfo.",
4924 func_name);
4925 } else if (format_list_info->viewFormatCount == 0) {
4926 skip |= LogError(
4927 device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
4928 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but the viewFormatCount "
4929 "member of VkImageFormatListCreateInfo in the pNext chain is zero.",
4930 func_name);
4931 } else {
4932 bool found_base_format = false;
4933 for (uint32_t i = 0; i < format_list_info->viewFormatCount; ++i) {
4934 if (format_list_info->pViewFormats[i] == pCreateInfo->imageFormat) {
4935 found_base_format = true;
4936 break;
4937 }
4938 }
4939 if (!found_base_format) {
4940 skip |=
4941 LogError(device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
4942 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but none of the "
4943 "elements of the pViewFormats member of VkImageFormatListCreateInfo match "
4944 "pCreateInfo->imageFormat.",
4945 func_name);
4946 }
4947 }
4948 }
4949 }
4950 }
4951 return skip;
4952}
4953
4954bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
4955 const VkAllocationCallbacks *pAllocator,
4956 VkSwapchainKHR *pSwapchain) const {
4957 bool skip = false;
4958 skip |= ValidateSwapchainCreateInfo("vkCreateSwapchainKHR()", pCreateInfo);
4959 return skip;
4960}
4961
4962bool StatelessValidation::manual_PreCallValidateCreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount,
4963 const VkSwapchainCreateInfoKHR *pCreateInfos,
4964 const VkAllocationCallbacks *pAllocator,
4965 VkSwapchainKHR *pSwapchains) const {
4966 bool skip = false;
4967 if (pCreateInfos) {
4968 for (uint32_t i = 0; i < swapchainCount; i++) {
4969 std::stringstream func_name;
4970 func_name << "vkCreateSharedSwapchainsKHR[" << swapchainCount << "]()";
4971 skip |= ValidateSwapchainCreateInfo(func_name.str().c_str(), &pCreateInfos[i]);
4972 }
4973 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004974 return skip;
4975}
4976
Jeff Bolz5c801d12019-10-09 10:38:45 -05004977bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004978 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004979
4980 if (pPresentInfo && pPresentInfo->pNext) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004981 const auto *present_regions = LvlFindInChain<VkPresentRegionsKHR>(pPresentInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -06004982 if (present_regions) {
4983 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07004984 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06004985 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
4986 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07004987 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004988 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
4989 "extension swapchainCount is %i. These values must be equal.",
4990 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06004991 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004992 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08004993 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
4994 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004995 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
4996 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
4997 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06004998 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004999 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005000 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06005001 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005002 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005003 }
5004 }
5005
5006 return skip;
5007}
5008
sfricke-samsung5c1b7392020-12-13 22:17:15 -08005009bool StatelessValidation::manual_PreCallValidateCreateDisplayModeKHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
5010 const VkDisplayModeCreateInfoKHR *pCreateInfo,
5011 const VkAllocationCallbacks *pAllocator,
5012 VkDisplayModeKHR *pMode) const {
5013 bool skip = false;
5014
5015 const VkDisplayModeParametersKHR display_mode_parameters = pCreateInfo->parameters;
5016 if (display_mode_parameters.visibleRegion.width == 0) {
5017 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-width-01990",
5018 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.width must be greater than 0.");
5019 }
5020 if (display_mode_parameters.visibleRegion.height == 0) {
5021 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-height-01991",
5022 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.height must be greater than 0.");
5023 }
5024 if (display_mode_parameters.refreshRate == 0) {
5025 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-refreshRate-01992",
5026 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.refreshRate must be greater than 0.");
5027 }
5028
5029 return skip;
5030}
5031
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005032#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005033bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
5034 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
5035 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005036 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005037 bool skip = false;
5038
5039 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005040 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
5041 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005042 }
5043
5044 return skip;
5045}
5046#endif // VK_USE_PLATFORM_WIN32_KHR
5047
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005048static bool MutableDescriptorTypePartialOverlap(const VkDescriptorPoolCreateInfo *pCreateInfo, uint32_t i, uint32_t j) {
5049 bool partial_overlap = false;
5050
5051 static const std::vector<VkDescriptorType> all_descriptor_types = {
5052 VK_DESCRIPTOR_TYPE_SAMPLER,
5053 VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
5054 VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
5055 VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
5056 VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER,
5057 VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
5058 VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
5059 VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
5060 VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC,
5061 VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC,
5062 VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
5063 VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT,
5064 VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR,
5065 VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV,
5066 };
5067
5068 const auto *mutable_descriptor_type = LvlFindInChain<VkMutableDescriptorTypeCreateInfoVALVE>(pCreateInfo->pNext);
5069 if (mutable_descriptor_type) {
5070 std::vector<VkDescriptorType> first_types, second_types;
5071 if (mutable_descriptor_type->mutableDescriptorTypeListCount > i) {
5072 for (uint32_t k = 0; k < mutable_descriptor_type->pMutableDescriptorTypeLists[i].descriptorTypeCount; ++k) {
5073 first_types.push_back(mutable_descriptor_type->pMutableDescriptorTypeLists[i].pDescriptorTypes[k]);
5074 }
5075 } else {
5076 first_types = all_descriptor_types;
5077 }
5078 if (mutable_descriptor_type->mutableDescriptorTypeListCount > j) {
5079 for (uint32_t k = 0; k < mutable_descriptor_type->pMutableDescriptorTypeLists[j].descriptorTypeCount; ++k) {
5080 second_types.push_back(mutable_descriptor_type->pMutableDescriptorTypeLists[j].pDescriptorTypes[k]);
5081 }
5082 } else {
5083 second_types = all_descriptor_types;
5084 }
5085
5086 bool complete_overlap = first_types.size() == second_types.size();
5087 bool disjoint = true;
5088 for (const auto first_type : first_types) {
5089 bool found = false;
5090 for (const auto second_type : second_types) {
5091 if (first_type == second_type) {
5092 found = true;
5093 break;
5094 }
5095 }
5096 if (found) {
5097 disjoint = false;
5098 } else {
5099 complete_overlap = false;
5100 }
5101 if (!disjoint && !complete_overlap) {
5102 partial_overlap = true;
5103 break;
5104 }
5105 }
5106 }
5107
5108 return partial_overlap;
5109}
5110
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005111bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005112 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005113 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02005114 bool skip = false;
5115
5116 if (pCreateInfo) {
5117 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005118 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
5119 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02005120 }
5121
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005122 const auto *mutable_descriptor_type_features =
5123 LvlFindInChain<VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE>(device_createinfo_pnext);
5124 bool mutable_descriptor_type_enabled =
5125 mutable_descriptor_type_features && mutable_descriptor_type_features->mutableDescriptorType == VK_TRUE;
5126
Petr Krausc8655be2017-09-27 18:56:51 +02005127 if (pCreateInfo->pPoolSizes) {
5128 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
5129 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005130 skip |= LogError(
5131 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005132 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02005133 }
Jeff Bolze54ae892018-09-08 12:16:29 -05005134 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
5135 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005136 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
5137 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
5138 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
5139 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
5140 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05005141 }
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005142 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE && !mutable_descriptor_type_enabled) {
5143 skip |=
5144 LogError(device, "VUID-VkDescriptorPoolCreateInfo-mutableDescriptorType-04608",
5145 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
5146 "].type is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE "
5147 ", but VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType is not enabled.",
5148 i);
5149 }
5150 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
5151 for (uint32_t j = i + 1; j < pCreateInfo->poolSizeCount; ++j) {
5152 if (pCreateInfo->pPoolSizes[j].type == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
5153 if (MutableDescriptorTypePartialOverlap(pCreateInfo, i, j)) {
5154 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-pPoolSizes-04787",
5155 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
5156 "].type and pCreateInfo->pPoolSizes[%" PRIu32
5157 "].type are both VK_DESCRIPTOR_TYPE_MUTABLE_VALVE "
5158 " and have sets which partially overlap.",
5159 i, j);
5160 }
5161 }
5162 }
5163 }
Petr Krausc8655be2017-09-27 18:56:51 +02005164 }
5165 }
ziga-lunarg0cf85212021-07-19 01:26:17 +02005166
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005167 if (pCreateInfo->flags & VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE && (!mutable_descriptor_type_enabled)) {
5168 skip |=
5169 LogError(device, "VUID-VkDescriptorPoolCreateInfo-flags-04609",
5170 "vkCreateDescriptorPool(): pCreateInfo->flags contains VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE, "
5171 "but VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType is not enabled.");
5172 }
ziga-lunarg0cf85212021-07-19 01:26:17 +02005173 if ((pCreateInfo->flags & VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE) &&
5174 (pCreateInfo->flags & VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT)) {
5175 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-flags-04607",
5176 "vkCreateDescriptorPool(): pCreateInfo->flags must not contain both "
5177 "VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE and VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT");
5178 }
Petr Krausc8655be2017-09-27 18:56:51 +02005179 }
5180
5181 return skip;
5182}
5183
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005184bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005185 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005186 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005187
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005188 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005189 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005190 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
5191 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
5192 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005193 }
5194
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005195 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005196 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005197 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
5198 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
5199 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005200 }
5201
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005202 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005203 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005204 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
5205 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
5206 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005207 }
5208
5209 return skip;
5210}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005211
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005212bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005213 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07005214 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07005215
5216 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005217 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
5218 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07005219 }
5220 return skip;
5221}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005222
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005223bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
5224 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005225 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005226 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005227
5228 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005229 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005230 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005231 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
5232 "vkCmdDispatch(): baseGroupX (%" PRIu32
5233 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
5234 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005235 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005236 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
5237 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
5238 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
5239 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005240 }
5241
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005242 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005243 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005244 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
5245 "vkCmdDispatch(): baseGroupY (%" PRIu32
5246 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
5247 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005248 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005249 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
5250 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
5251 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
5252 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005253 }
5254
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005255 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005256 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005257 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
5258 "vkCmdDispatch(): baseGroupZ (%" PRIu32
5259 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
5260 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005261 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005262 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
5263 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
5264 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
5265 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005266 }
5267
5268 return skip;
5269}
5270
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07005271bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
5272 VkPipelineBindPoint pipelineBindPoint,
5273 VkPipelineLayout layout, uint32_t set,
5274 uint32_t descriptorWriteCount,
5275 const VkWriteDescriptorSet *pDescriptorWrites) const {
Mike Schuchardt979898a2022-01-11 10:46:59 -08005276 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, true);
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07005277}
5278
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005279bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
5280 uint32_t firstExclusiveScissor,
5281 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005282 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05005283 bool skip = false;
5284
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005285 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05005286 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005287 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005288 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
5289 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
5290 ") is not 0.",
5291 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005292 }
5293 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005294 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005295 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
5296 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
5297 ") is not 1.",
5298 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005299 }
5300 } else { // multiViewport enabled
5301 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005302 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005303 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
5304 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
5305 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5306 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005307 }
5308 }
5309
Jeff Bolz3e71f782018-08-29 23:15:45 -05005310 if (pExclusiveScissors) {
5311 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
5312 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
5313
5314 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005315 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
5316 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
5317 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005318 }
5319
5320 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005321 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
5322 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
5323 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005324 }
5325
5326 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
5327 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005328 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
5329 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5330 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5331 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005332 }
5333
5334 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
5335 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005336 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
5337 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5338 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5339 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005340 }
5341 }
5342 }
5343
5344 return skip;
5345}
5346
Chris Mayer9ded5eb2019-09-19 16:33:26 +02005347bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
5348 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005349 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02005350 bool skip = false;
Shannon McPherson169d0c72020-11-13 18:48:19 -07005351 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
5352 if ((sum < 1) || (sum > device_limits.maxViewports)) {
5353 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
5354 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
5355 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
5356 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02005357 }
5358
5359 return skip;
5360}
5361
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005362bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
5363 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005364 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05005365 bool skip = false;
5366
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005367 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05005368 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005369 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005370 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
5371 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
5372 ") is not 0.",
5373 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005374 }
5375 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005376 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005377 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
5378 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
5379 ") is not 1.",
5380 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005381 }
5382 }
5383
Jeff Bolz9af91c52018-09-01 21:53:57 -05005384 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005385 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005386 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
5387 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
5388 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5389 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005390 }
5391
5392 return skip;
5393}
5394
Jeff Bolz5c801d12019-10-09 10:38:45 -05005395bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
5396 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
5397 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05005398 bool skip = false;
5399
Dave Houlton142c4cb2018-10-17 15:04:41 -06005400 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005401 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
5402 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
5403 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05005404 }
5405
5406 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005407 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005408 }
5409
5410 return skip;
5411}
5412
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005413bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005414 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005415 bool skip = false;
5416
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005417 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005418 skip |= LogError(
5419 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06005420 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
5421 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005422 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005423 }
5424
5425 return skip;
5426}
5427
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005428bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
5429 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005430 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005431 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06005432 static const int condition_multiples = 0b0011;
5433 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005434 skip |= LogError(
5435 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06005436 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005437 }
Lockee1c22882019-06-10 16:02:54 -06005438 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005439 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
5440 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
5441 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
5442 stride);
Lockee1c22882019-06-10 16:02:54 -06005443 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005444 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005445 skip |= LogError(
5446 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005447 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %" PRIu32 "",
5448 drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06005449 }
Tony-LunarGc0c3df52020-11-20 13:47:10 -07005450 if (drawCount > device_limits.maxDrawIndirectCount) {
5451 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02719",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005452 "vkCmdDrawMeshTasksIndirectNV: drawCount (%" PRIu32
5453 ") is not less than or equal to the maximum allowed (%" PRIu32 ").",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005454 drawCount, device_limits.maxDrawIndirectCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07005455 }
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005456 return skip;
5457}
5458
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005459bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
5460 VkDeviceSize offset, VkBuffer countBuffer,
5461 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005462 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005463 bool skip = false;
5464
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005465 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005466 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
5467 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
5468 "), is not a multiple of 4.",
5469 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005470 }
5471
5472 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005473 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
5474 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
5475 "), is not a multiple of 4.",
5476 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005477 }
5478
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005479 return skip;
5480}
5481
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005482bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005483 const VkAllocationCallbacks *pAllocator,
5484 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005485 bool skip = false;
5486
5487 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
5488 if (pCreateInfo != nullptr) {
5489 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
5490 // VkQueryPipelineStatisticFlagBits values
5491 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
5492 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005493 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
5494 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
5495 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
5496 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005497 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07005498 if (pCreateInfo->queryCount == 0) {
5499 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
5500 "vkCreateQueryPool(): queryCount must be greater than zero.");
5501 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06005502 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005503 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005504}
5505
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005506bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
5507 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005508 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005509 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
5510 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005511}
5512
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005513void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07005514 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
5515 VkResult result) {
5516 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005517 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005518}
5519
Mike Schuchardt2df08912020-12-15 16:28:09 -08005520void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07005521 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
5522 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005523 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07005524 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005525 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005526}
5527
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005528void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
5529 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005530 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07005531 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005532 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005533}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005534
Tony-LunarG3c287f62020-12-17 12:39:49 -07005535void StatelessValidation::PostCallRecordAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pAllocateInfo,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005536 VkCommandBuffer *pCommandBuffers, VkResult result) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07005537 if ((result == VK_SUCCESS) && pAllocateInfo && (pAllocateInfo->level == VK_COMMAND_BUFFER_LEVEL_SECONDARY)) {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06005538 auto lock = CBWriteLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07005539 for (uint32_t cb_index = 0; cb_index < pAllocateInfo->commandBufferCount; cb_index++) {
Jeremy Gebbenfc6f8152021-03-18 16:58:55 -06005540 secondary_cb_map.emplace(pCommandBuffers[cb_index], pAllocateInfo->commandPool);
Tony-LunarG3c287f62020-12-17 12:39:49 -07005541 }
5542 }
5543}
5544
5545void StatelessValidation::PostCallRecordFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005546 const VkCommandBuffer *pCommandBuffers) {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06005547 auto lock = CBWriteLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07005548 for (uint32_t cb_index = 0; cb_index < commandBufferCount; cb_index++) {
5549 secondary_cb_map.erase(pCommandBuffers[cb_index]);
5550 }
5551}
5552
5553void StatelessValidation::PostCallRecordDestroyCommandPool(VkDevice device, VkCommandPool commandPool,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005554 const VkAllocationCallbacks *pAllocator) {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06005555 auto lock = CBWriteLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07005556 for (auto item = secondary_cb_map.begin(); item != secondary_cb_map.end();) {
5557 if (item->second == commandPool) {
5558 item = secondary_cb_map.erase(item);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005559 } else {
Tony-LunarG3c287f62020-12-17 12:39:49 -07005560 ++item;
5561 }
5562 }
5563}
5564
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005565bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005566 const VkAllocationCallbacks *pAllocator,
5567 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005568 bool skip = false;
5569
5570 if (pAllocateInfo) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005571 auto chained_prio_struct = LvlFindInChain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005572 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005573 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
5574 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005575 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005576
5577 VkMemoryAllocateFlags flags = 0;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005578 auto flags_info = LvlFindInChain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005579 if (flags_info) {
5580 flags = flags_info->flags;
5581 }
5582
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005583 auto opaque_alloc_info = LvlFindInChain<VkMemoryOpaqueCaptureAddressAllocateInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005584 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08005585 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005586 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
5587 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
Mike Schuchardt2df08912020-12-15 16:28:09 -08005588 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005589 }
5590
5591#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005592 auto import_memory_win32_handle = LvlFindInChain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005593#endif
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005594 auto import_memory_fd = LvlFindInChain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
5595 auto import_memory_host_pointer = LvlFindInChain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005596#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005597 auto import_memory_ahb = LvlFindInChain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005598#endif
5599
5600 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005601 skip |= LogError(
5602 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005603 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
5604 }
5605 if (
5606#ifdef VK_USE_PLATFORM_WIN32_KHR
5607 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
5608#endif
5609 (import_memory_fd && import_memory_fd->handleType) ||
5610#ifdef VK_USE_PLATFORM_ANDROID_KHR
5611 (import_memory_ahb && import_memory_ahb->buffer) ||
5612#endif
5613 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005614 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
5615 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005616 }
5617 }
5618
ziga-lunarg1d5e11d2021-07-18 13:13:40 +02005619 auto export_memory = LvlFindInChain<VkExportMemoryAllocateInfo>(pAllocateInfo->pNext);
5620 if (export_memory) {
5621 auto export_memory_nv = LvlFindInChain<VkExportMemoryAllocateInfoNV>(pAllocateInfo->pNext);
5622 if (export_memory_nv) {
5623 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-pNext-00640",
5624 "pNext chain of VkMemoryAllocateInfo includes both VkExportMemoryAllocateInfo and "
5625 "VkExportMemoryAllocateInfoNV");
5626 }
5627#ifdef VK_USE_PLATFORM_WIN32_KHR
5628 auto export_memory_win32_nv = LvlFindInChain<VkExportMemoryWin32HandleInfoNV>(pAllocateInfo->pNext);
5629 if (export_memory_win32_nv) {
5630 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-pNext-00640",
5631 "pNext chain of VkMemoryAllocateInfo includes both VkExportMemoryAllocateInfo and "
5632 "VkExportMemoryWin32HandleInfoNV");
5633 }
5634#endif
5635 }
5636
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005637 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07005638 VkBool32 capture_replay = false;
5639 VkBool32 buffer_device_address = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005640 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07005641 if (vulkan_12_features) {
5642 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
5643 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
5644 } else {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005645 const auto *bda_features = LvlFindInChain<VkPhysicalDeviceBufferDeviceAddressFeatures>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07005646 if (bda_features) {
5647 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
5648 buffer_device_address = bda_features->bufferDeviceAddress;
5649 }
5650 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08005651 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005652 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
Mike Schuchardt2df08912020-12-15 16:28:09 -08005653 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT is set, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005654 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005655 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08005656 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005657 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
Mike Schuchardt2df08912020-12-15 16:28:09 -08005658 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005659 }
5660 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005661 }
5662 return skip;
5663}
Ricardo Garciaa4935972019-02-21 17:43:18 +01005664
Jason Macnak192fa0e2019-07-26 15:07:16 -07005665bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005666 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07005667 bool skip = false;
5668
5669 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
5670 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
5671 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005672 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005673 } else {
5674 uint32_t vertex_component_size = 0;
5675 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
5676 vertex_component_size = 4;
5677 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
5678 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
5679 vertex_component_size = 2;
5680 }
5681 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005682 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005683 }
5684 }
5685
5686 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
5687 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005688 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005689 } else {
5690 uint32_t index_element_size = 0;
5691 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
5692 index_element_size = 4;
5693 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
5694 index_element_size = 2;
5695 }
5696 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005697 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005698 }
5699 }
5700 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
5701 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005702 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005703 }
5704 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005705 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005706 }
5707 }
5708
5709 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005710 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005711 }
5712
5713 return skip;
5714}
5715
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005716bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
5717 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07005718 bool skip = false;
5719
5720 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005721 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005722 }
5723 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005724 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005725 }
5726
5727 return skip;
5728}
5729
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005730bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
5731 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07005732 bool skip = false;
5733 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005734 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005735 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005736 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005737 }
5738 return skip;
5739}
5740
5741bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07005742 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005743 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07005744 bool skip = false;
5745 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005746 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
5747 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
5748 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07005749 }
5750 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005751 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
5752 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
5753 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07005754 }
ziga-lunarg10309ee2021-08-02 13:11:21 +02005755 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
5756 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-04623",
5757 "VkAccelerationStructureInfoNV: type is invalid VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.");
5758 }
Jason Macnak5c954952019-07-09 15:46:12 -07005759 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
5760 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005761 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
5762 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
5763 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07005764 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005765 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005766 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005767 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
5768 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005769 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
5770 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07005771 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005772 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005773 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
5774 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
5775 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07005776 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07005777 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07005778 uint64_t total_triangle_count = 0;
5779 for (uint32_t i = 0; i < info.geometryCount; i++) {
5780 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07005781
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005782 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005783
Jason Macnak5c954952019-07-09 15:46:12 -07005784 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
5785 continue;
5786 }
5787 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
5788 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005789 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005790 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
5791 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
5792 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07005793 }
5794 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07005795 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
5796 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
5797 for (uint32_t i = 1; i < info.geometryCount; i++) {
5798 const VkGeometryNV &geometry = info.pGeometries[i];
5799 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005800 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005801 "VkAccelerationStructureInfoNV: info.pGeometries[%" PRIu32
5802 "].geometryType does not match "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005803 "info.pGeometries[0].geometryType.",
5804 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07005805 }
5806 }
5807 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005808 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
5809 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
5810 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
5811 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
5812 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
5813 "or VK_GEOMETRY_TYPE_AABBS_NV.");
5814 }
5815 }
5816 skip |=
5817 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06005818 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07005819 return skip;
5820}
5821
Ricardo Garciaa4935972019-02-21 17:43:18 +01005822bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
5823 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005824 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01005825 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01005826 if (pCreateInfo) {
5827 if ((pCreateInfo->compactedSize != 0) &&
5828 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005829 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
5830 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
5831 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
5832 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01005833 }
Jason Macnak5c954952019-07-09 15:46:12 -07005834
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005835 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07005836 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01005837 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01005838 return skip;
5839}
Mike Schuchardt21638df2019-03-16 10:52:02 -07005840
Jeff Bolz5c801d12019-10-09 10:38:45 -05005841bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
5842 const VkAccelerationStructureInfoNV *pInfo,
5843 VkBuffer instanceData, VkDeviceSize instanceOffset,
5844 VkBool32 update, VkAccelerationStructureNV dst,
5845 VkAccelerationStructureNV src, VkBuffer scratch,
5846 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07005847 bool skip = false;
5848
5849 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005850 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07005851 }
5852
5853 return skip;
5854}
5855
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005856bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
5857 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5858 VkAccelerationStructureKHR *pAccelerationStructure) const {
5859 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005860 const auto *acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005861 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005862 if (!acceleration_structure_features ||
5863 (acceleration_structure_features && acceleration_structure_features->accelerationStructure == VK_FALSE)) {
5864 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-accelerationStructure-03611",
5865 "vkCreateAccelerationStructureKHR(): The accelerationStructure feature must be enabled");
5866 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005867 if (pCreateInfo) {
sourav parmarcd5fb182020-07-17 12:58:44 -07005868 if (pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR &&
5869 (!acceleration_structure_features ||
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005870 (acceleration_structure_features &&
5871 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
sourav parmara96ab1a2020-04-25 16:28:23 -07005872 skip |=
sourav parmarcd5fb182020-07-17 12:58:44 -07005873 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-createFlags-03613",
5874 "vkCreateAccelerationStructureKHR(): If createFlags includes "
5875 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR, "
5876 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay must be VK_TRUE");
sourav parmara96ab1a2020-04-25 16:28:23 -07005877 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005878 if (pCreateInfo->deviceAddress &&
5879 !(pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
5880 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03612",
5881 "vkCreateAccelerationStructureKHR(): If deviceAddress is not zero, createFlags must include "
5882 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR");
5883 }
ziga-lunarg8ddbe462021-09-06 16:14:17 +02005884 if (pCreateInfo->deviceAddress && (!acceleration_structure_features ||
5885 (acceleration_structure_features &&
5886 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
5887 skip |= LogError(
5888 device, "VUID-vkCreateAccelerationStructureKHR-deviceAddress-03488",
5889 "VkAccelerationStructureCreateInfoKHR(): VkAccelerationStructureCreateInfoKHR::deviceAddress is not zero, but "
5890 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay is not enabled.");
5891 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005892 if (SafeModulo(pCreateInfo->offset, 256) != 0) {
5893 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-offset-03734",
ziga-lunarg8ddbe462021-09-06 16:14:17 +02005894 "vkCreateAccelerationStructureKHR(): offset %" PRIu64 " must be a multiple of 256 bytes",
5895 pCreateInfo->offset);
sourav parmarcd5fb182020-07-17 12:58:44 -07005896 }
sourav parmar83c31b12020-05-06 12:30:54 -07005897 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005898 return skip;
5899}
5900
Jason Macnak5c954952019-07-09 15:46:12 -07005901bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
5902 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005903 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07005904 bool skip = false;
5905 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005906 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
5907 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07005908 }
5909 return skip;
5910}
5911
sourav parmarcd5fb182020-07-17 12:58:44 -07005912bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesNV(
5913 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureNV *pAccelerationStructures,
5914 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5915 bool skip = false;
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07005916 if (queryType != VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV) {
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07005917 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesNV-queryType-06216",
sourav parmarcd5fb182020-07-17 12:58:44 -07005918 "vkCmdWriteAccelerationStructuresPropertiesNV: queryType must be "
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07005919 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV.");
sourav parmarcd5fb182020-07-17 12:58:44 -07005920 }
5921 return skip;
5922}
5923
Peter Chen85366392019-05-14 15:20:11 -04005924bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
5925 uint32_t createInfoCount,
5926 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
5927 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005928 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04005929 bool skip = false;
5930
5931 for (uint32_t i = 0; i < createInfoCount; i++) {
ziga-lunargc6341372021-07-28 12:57:42 +02005932 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
5933 std::stringstream msg;
5934 msg << "pCreateInfos[%" << i << "].pStages[%" << stage_index << "]";
5935 ValidatePipelineShaderStageCreateInfo("vkCreateRayTracingPipelinesNV", msg.str().c_str(), &pCreateInfos[i].pStages[i]);
5936 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005937 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04005938 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Tony-LunarGce3244a2021-11-19 12:33:40 -07005939 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfo-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005940 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
5941 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
5942 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
5943 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04005944 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005945
5946 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005947 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07005948 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
5949 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
5950 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
5951 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
5952 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
5953 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
5954 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
5955 }
5956 }
5957
sourav parmarf4a78252020-04-10 13:04:21 -07005958 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
5959 skip |=
5960 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
5961 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
5962 }
5963 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
5964 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
5965 skip |=
5966 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
5967 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
5968 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
5969 }
5970 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
5971 if (pCreateInfos[i].basePipelineIndex != -1) {
5972 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
5973 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
5974 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
5975 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
5976 "and pCreateInfos->basePipelineIndex is not -1.");
5977 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005978 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005979 skip |=
5980 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
5981 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
5982 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
5983 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
5984 "that element.");
5985 }
sourav parmarf4a78252020-04-10 13:04:21 -07005986 }
5987 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04005988 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07005989 skip |=
5990 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
5991 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
5992 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
5993 "commands pCreateInfos parameter.");
5994 }
5995 } else {
5996 if (pCreateInfos[i].basePipelineIndex != -1) {
5997 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
5998 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
5999 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
6000 }
6001 }
6002 }
6003 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
6004 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
6005 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
6006 }
6007 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
6008 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
6009 "vkCreateRayTracingPipelinesNV: flags must not include "
6010 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
6011 }
6012 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
6013 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
6014 "vkCreateRayTracingPipelinesNV: flags must not include "
6015 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
6016 }
6017 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
6018 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
6019 "vkCreateRayTracingPipelinesNV: flags must not include "
6020 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
6021 }
6022 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
6023 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
6024 "vkCreateRayTracingPipelinesNV: flags must not include "
6025 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
6026 }
6027 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
6028 skip |= LogError(
6029 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
6030 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
6031 }
6032 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
6033 skip |= LogError(
6034 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
6035 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
6036 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006037 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) {
6038 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03588",
6039 "vkCreateRayTracingPipelinesNV: flags must not include "
6040 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
6041 }
6042 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
6043 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03816",
6044 "vkCreateRayTracingPipelinesNV: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
6045 }
ziga-lunargdfffee42021-10-10 11:49:59 +02006046 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) {
6047 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-04948",
6048 "vkCreateRayTracingPipelinesNV: flags must not contain the "
6049 "VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV flag.");
6050 }
Peter Chen85366392019-05-14 15:20:11 -04006051 }
6052
6053 return skip;
6054}
6055
sourav parmarcd5fb182020-07-17 12:58:44 -07006056bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(
6057 VkDevice device, VkDeferredOperationKHR deferredOperation, VkPipelineCache pipelineCache, uint32_t createInfoCount,
6058 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos, const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) const {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006059 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006060 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006061 if (!raytracing_features || raytracing_features->rayTracingPipeline == VK_FALSE) {
6062 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracingPipeline-03586",
6063 "vkCreateRayTracingPipelinesKHR: The rayTracingPipeline feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006064 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006065 for (uint32_t i = 0; i < createInfoCount; i++) {
ziga-lunargc6341372021-07-28 12:57:42 +02006066 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
6067 std::stringstream msg;
6068 msg << "pCreateInfos[%" << i << "].pStages[%" << stage_index << "]";
6069 ValidatePipelineShaderStageCreateInfo("vkCreateRayTracingPipelinesKHR", msg.str().c_str(),
aitor-lunargdbd9e652022-02-23 19:12:53 +01006070 &pCreateInfos[i].pStages[stage_index]);
ziga-lunargc6341372021-07-28 12:57:42 +02006071 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006072 if (!raytracing_features || (raytracing_features && raytracing_features->rayTraversalPrimitiveCulling == VK_FALSE)) {
6073 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
6074 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03596",
6075 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
6076 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
6077 }
6078 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
6079 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03597",
6080 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
6081 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.");
6082 }
6083 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006084 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006085 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Tony-LunarGce3244a2021-11-19 12:33:40 -07006086 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfo-pipelineStageCreationFeedbackCount-02670",
sourav parmarcd5fb182020-07-17 12:58:44 -07006087 "vkCreateRayTracingPipelinesKHR: in pCreateInfo[%" PRIu32
6088 "], When chained to VkRayTracingPipelineCreateInfoKHR, "
6089 "VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006090 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
6091 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
6092 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006093 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006094 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07006095 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
6096 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
6097 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
6098 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
sourav parmarcd5fb182020-07-17 12:58:44 -07006099 "vkCreateRayTracingPipelinesKHR: If the pipelineCreationCacheControl feature is not enabled,"
sourav parmara96ab1a2020-04-25 16:28:23 -07006100 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
6101 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
6102 }
6103 }
sourav parmarf4a78252020-04-10 13:04:21 -07006104 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006105 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
6106 "vkCreateRayTracingPipelinesKHR: flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
sourav parmarf4a78252020-04-10 13:04:21 -07006107 }
6108 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006109 if (pCreateInfos[i].pLibraryInterface == NULL) {
sourav parmarf4a78252020-04-10 13:04:21 -07006110 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
sourav parmarcd5fb182020-07-17 12:58:44 -07006111 "vkCreateRayTracingPipelinesKHR: If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, "
6112 "pLibraryInterface must not be NULL.");
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006113 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006114 }
6115 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
6116 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03816",
6117 "vkCreateRayTracingPipelinesKHR: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
sourav parmarf4a78252020-04-10 13:04:21 -07006118 }
6119 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
6120 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
6121 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
6122 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
6123 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
6124 skip |= LogError(
6125 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
sourav parmarcd5fb182020-07-17 12:58:44 -07006126 "vkCreateRayTracingPipelinesKHR: If flags includes "
6127 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07006128 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
6129 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
6130 "must not be VK_SHADER_UNUSED_KHR");
6131 }
6132 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
6133 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
6134 skip |= LogError(
6135 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
sourav parmarcd5fb182020-07-17 12:58:44 -07006136 "vkCreateRayTracingPipelinesKHR: If flags includes "
6137 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07006138 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
6139 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
6140 "element must not be VK_SHADER_UNUSED_KHR");
6141 }
6142 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006143 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_TRUE &&
6144 pCreateInfos[i].pGroups[group_index].pShaderGroupCaptureReplayHandle) {
6145 if (!(pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR)) {
6146 skip |= LogError(
6147 device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03599",
6148 "vkCreateRayTracingPipelinesKHR: If "
6149 "VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineShaderGroupHandleCaptureReplay is "
6150 "VK_TRUE and the pShaderGroupCaptureReplayHandle member of any element of pGroups is not NULL, flags must "
6151 "include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
6152 }
6153 }
sourav parmarf4a78252020-04-10 13:04:21 -07006154 }
6155 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
6156 if (pCreateInfos[i].basePipelineIndex != -1) {
6157 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
6158 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
sourav parmarcd5fb182020-07-17 12:58:44 -07006159 "vkCreateRayTracingPipelinesKHR: parameter, pCreateInfos->basePipelineHandle, must be "
sourav parmarf4a78252020-04-10 13:04:21 -07006160 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
6161 "and pCreateInfos->basePipelineIndex is not -1.");
6162 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006163 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07006164 skip |=
6165 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
6166 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
6167 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
6168 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
6169 "element.");
6170 }
sourav parmarf4a78252020-04-10 13:04:21 -07006171 }
6172 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04006173 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07006174 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
sourav parmarcd5fb182020-07-17 12:58:44 -07006175 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006176 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%" PRId32
6177 ") must be a valid into the calling"
6178 "commands pCreateInfos parameter %" PRIu32 ".",
sourav parmarf4a78252020-04-10 13:04:21 -07006179 pCreateInfos[i].basePipelineIndex, createInfoCount);
6180 }
6181 } else {
6182 if (pCreateInfos[i].basePipelineIndex != -1) {
6183 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
sourav parmarcd5fb182020-07-17 12:58:44 -07006184 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07006185 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
6186 }
6187 }
6188 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006189 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR &&
6190 (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE)) {
6191 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03598",
6192 "vkCreateRayTracingPipelinesKHR: If flags includes "
6193 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR, "
6194 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled.");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006195 }
6196 bool library_enabled = IsExtEnabled(device_extensions.vk_khr_pipeline_library);
6197 if (!library_enabled && (pCreateInfos[i].pLibraryInfo || pCreateInfos[i].pLibraryInterface)) {
6198 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03595",
6199 "vkCreateRayTracingPipelinesKHR: If the VK_KHR_pipeline_library extension is not enabled, "
6200 "pLibraryInfo and pLibraryInterface must be NULL.");
6201 }
6202 if (pCreateInfos[i].pLibraryInfo) {
6203 if (pCreateInfos[i].pLibraryInfo->libraryCount == 0) {
6204 if (pCreateInfos[i].stageCount == 0) {
6205 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03600",
6206 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
6207 "stageCount must not be 0.");
6208 }
6209 if (pCreateInfos[i].groupCount == 0) {
6210 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03601",
6211 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
6212 "groupCount must not be 0.");
6213 }
6214 } else {
6215 if (pCreateInfos[i].pLibraryInterface == NULL) {
6216 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03590",
6217 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount member "
6218 "is greater than 0, its "
6219 "pLibraryInterface member must not be NULL.");
sourav parmarcd5fb182020-07-17 12:58:44 -07006220 }
6221 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006222 }
6223 if (pCreateInfos[i].pLibraryInterface) {
6224 if (pCreateInfos[i].pLibraryInterface->maxPipelineRayHitAttributeSize >
6225 phys_dev_ext_props.ray_tracing_propsKHR.maxRayHitAttributeSize) {
6226 skip |= LogError(device, "VUID-VkRayTracingPipelineInterfaceCreateInfoKHR-maxPipelineRayHitAttributeSize-03605",
6227 "vkCreateRayTracingPipelinesKHR: maxPipelineRayHitAttributeSize must be less than or equal to "
6228 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayHitAttributeSize.");
6229 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006230 }
6231 if (deferredOperation != VK_NULL_HANDLE) {
6232 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT) {
6233 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-deferredOperation-03587",
6234 "vkCreateRayTracingPipelinesKHR: If deferredOperation is not VK_NULL_HANDLE, the flags member of "
6235 "elements of pCreateInfos must not include VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
sourav parmarf4a78252020-04-10 13:04:21 -07006236 }
6237 }
ziga-lunargdea76582021-09-17 14:38:08 +02006238 if (pCreateInfos[i].pDynamicState) {
6239 for (uint32_t j = 0; j < pCreateInfos[i].pDynamicState->dynamicStateCount; ++j) {
6240 if (pCreateInfos[i].pDynamicState->pDynamicStates[j] != VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR) {
6241 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pDynamicStates-03602",
6242 "vkCreateRayTracingPipelinesKHR(): pCreateInfos[%" PRIu32
6243 "].pDynamicState->pDynamicStates[%" PRIu32 "] is %s.",
6244 i, j, string_VkDynamicState(pCreateInfos[i].pDynamicState->pDynamicStates[j]));
6245 }
6246 }
6247 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006248 }
6249
6250 return skip;
6251}
6252
Mike Schuchardt21638df2019-03-16 10:52:02 -07006253#ifdef VK_USE_PLATFORM_WIN32_KHR
6254bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
6255 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006256 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07006257 bool skip = false;
sfricke-samsung45996a42021-09-16 13:45:27 -07006258 if (!IsExtEnabled(device_extensions.vk_khr_swapchain))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006259 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006260 if (!IsExtEnabled(device_extensions.vk_khr_get_surface_capabilities2))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006261 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006262 if (!IsExtEnabled(device_extensions.vk_khr_surface))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006263 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006264 if (!IsExtEnabled(device_extensions.vk_khr_get_physical_device_properties2))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006265 skip |=
6266 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006267 if (!IsExtEnabled(device_extensions.vk_ext_full_screen_exclusive))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006268 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
6269 skip |= validate_struct_type(
6270 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
6271 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
6272 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
6273 if (pSurfaceInfo != NULL) {
6274 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
6275 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
6276 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
6277
6278 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
6279 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
6280 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
6281 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08006282 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
6283 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07006284
Mike Schuchardt05b028d2022-01-05 14:15:00 -08006285 if (pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
6286 skip |= LogError(device, "VUID-vkGetPhysicalDeviceSurfacePresentModes2EXT-pSurfaceInfo-06521",
6287 "vkGetPhysicalDeviceSurfacePresentModes2EXT: pSurfaceInfo->surface is VK_NULL_HANDLE and "
6288 "VK_GOOGLE_surfaceless_query is not enabled.");
6289 }
6290
Mike Schuchardt21638df2019-03-16 10:52:02 -07006291 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
6292 }
6293 return skip;
6294}
6295#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01006296
6297bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
6298 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006299 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01006300 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
6301 bool skip = false;
Mike Schuchardt2df08912020-12-15 16:28:09 -08006302 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT) == 0) {
Tobias Hectorebb855f2019-07-23 12:17:33 +01006303 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
6304 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
6305 }
6306 return skip;
6307}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05006308
6309bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006310 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05006311 bool skip = false;
6312
6313 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006314 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006315 "vkCmdSetLineStippleEXT::lineStippleFactor=%" PRIu32 " is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05006316 }
6317
6318 return skip;
6319}
Piers Daniell8fd03f52019-08-21 12:07:53 -06006320
6321bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006322 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06006323 bool skip = false;
6324
6325 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006326 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
6327 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06006328 }
6329
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006330 const auto *index_type_uint8_features = LvlFindInChain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06006331 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006332 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
6333 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06006334 }
6335
6336 return skip;
6337}
Mark Lobodzinski84988402019-09-11 15:27:30 -06006338
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006339bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
6340 uint32_t bindingCount, const VkBuffer *pBuffers,
6341 const VkDeviceSize *pOffsets) const {
6342 bool skip = false;
6343 if (firstBinding > device_limits.maxVertexInputBindings) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006344 skip |=
6345 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
6346 "vkCmdBindVertexBuffers() firstBinding (%" PRIu32 ") must be less than maxVertexInputBindings (%" PRIu32 ")",
6347 firstBinding, device_limits.maxVertexInputBindings);
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006348 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
6349 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006350 "vkCmdBindVertexBuffers() sum of firstBinding (%" PRIu32 ") and bindingCount (%" PRIu32
6351 ") must be less than "
6352 "maxVertexInputBindings (%" PRIu32 ")",
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006353 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
6354 }
6355
Jeff Bolz165818a2020-05-08 11:19:03 -05006356 for (uint32_t i = 0; i < bindingCount; ++i) {
6357 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006358 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05006359 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006360 skip |=
6361 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
6362 "vkCmdBindVertexBuffers() required parameter pBuffers[%" PRIu32 "] specified as VK_NULL_HANDLE", i);
Jeff Bolz165818a2020-05-08 11:19:03 -05006363 } else {
6364 if (pOffsets[i] != 0) {
6365 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006366 "vkCmdBindVertexBuffers() pBuffers[%" PRIu32 "] is VK_NULL_HANDLE, but pOffsets[%" PRIu32
6367 "] is not 0",
6368 i, i);
Jeff Bolz165818a2020-05-08 11:19:03 -05006369 }
6370 }
6371 }
6372 }
6373
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006374 return skip;
6375}
6376
Mark Lobodzinski84988402019-09-11 15:27:30 -06006377bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006378 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06006379 bool skip = false;
6380 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006381 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
6382 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06006383 }
6384 return skip;
6385}
6386
6387bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006388 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06006389 bool skip = false;
6390 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006391 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
6392 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06006393 }
6394 return skip;
6395}
Petr Kraus3d720392019-11-13 02:52:39 +01006396
6397bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
6398 VkSemaphore semaphore, VkFence fence,
6399 uint32_t *pImageIndex) const {
6400 bool skip = false;
6401
6402 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006403 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
6404 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01006405 }
6406
6407 return skip;
6408}
6409
6410bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
6411 uint32_t *pImageIndex) const {
6412 bool skip = false;
6413
6414 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006415 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
6416 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01006417 }
6418
6419 return skip;
6420}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006421
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06006422bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
6423 uint32_t firstBinding, uint32_t bindingCount,
6424 const VkBuffer *pBuffers,
6425 const VkDeviceSize *pOffsets,
6426 const VkDeviceSize *pSizes) const {
6427 bool skip = false;
6428
6429 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
6430 for (uint32_t i = 0; i < bindingCount; ++i) {
6431 if (pOffsets[i] & 3) {
6432 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
6433 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
6434 }
6435 }
6436
6437 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6438 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
6439 "%s: The firstBinding(%" PRIu32
6440 ") index is greater than or equal to "
6441 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6442 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6443 }
6444
6445 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6446 skip |=
6447 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
6448 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
6449 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6450 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6451 }
6452
6453 for (uint32_t i = 0; i < bindingCount; ++i) {
6454 // pSizes is optional and may be nullptr.
6455 if (pSizes != nullptr) {
6456 if (pSizes[i] != VK_WHOLE_SIZE &&
6457 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
6458 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
6459 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
6460 ") is not VK_WHOLE_SIZE and is greater than "
6461 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
6462 cmd_name, i, pSizes[i]);
6463 }
6464 }
6465 }
6466
6467 return skip;
6468}
6469
6470bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
6471 uint32_t firstCounterBuffer,
6472 uint32_t counterBufferCount,
6473 const VkBuffer *pCounterBuffers,
6474 const VkDeviceSize *pCounterBufferOffsets) const {
6475 bool skip = false;
6476
6477 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
6478 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6479 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
6480 "%s: The firstCounterBuffer(%" PRIu32
6481 ") index is greater than or equal to "
6482 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6483 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6484 }
6485
6486 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6487 skip |=
6488 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
6489 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
6490 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6491 cmd_name, firstCounterBuffer, counterBufferCount,
6492 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6493 }
6494
6495 return skip;
6496}
6497
6498bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
6499 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
6500 const VkBuffer *pCounterBuffers,
6501 const VkDeviceSize *pCounterBufferOffsets) const {
6502 bool skip = false;
6503
6504 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
6505 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6506 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
6507 "%s: The firstCounterBuffer(%" PRIu32
6508 ") index is greater than or equal to "
6509 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6510 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6511 }
6512
6513 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6514 skip |=
6515 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
6516 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
6517 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6518 cmd_name, firstCounterBuffer, counterBufferCount,
6519 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6520 }
6521
6522 return skip;
6523}
6524
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006525bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
6526 uint32_t firstInstance, VkBuffer counterBuffer,
6527 VkDeviceSize counterBufferOffset,
6528 uint32_t counterOffset, uint32_t vertexStride) const {
6529 bool skip = false;
6530
6531 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006532 skip |= LogError(counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
6533 "vkCmdDrawIndirectByteCountEXT: vertexStride (%" PRIu32
6534 ") must be between 0 and maxTransformFeedbackBufferDataStride (%" PRIu32 ").",
6535 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006536 }
6537
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07006538 if ((counterOffset % 4) != 0) {
sfricke-samsung6886c4b2021-01-16 08:37:35 -08006539 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-counterBufferOffset-04568",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006540 "vkCmdDrawIndirectByteCountEXT(): offset (%" PRIu32 ") must be a multiple of 4.", counterOffset);
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07006541 }
6542
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006543 return skip;
6544}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006545
6546bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
6547 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
6548 const VkAllocationCallbacks *pAllocator,
6549 VkSamplerYcbcrConversion *pYcbcrConversion,
6550 const char *apiName) const {
6551 bool skip = false;
6552
6553 // Check samplerYcbcrConversion feature is set
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006554 const auto *ycbcr_features = LvlFindInChain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006555 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006556 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02006557 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
6558 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07006559 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02006560 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006561 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006562
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006563#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006564 const VkExternalFormatANDROID *external_format_android = LvlFindInChain<VkExternalFormatANDROID>(pCreateInfo);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006565 const bool is_external_format = external_format_android != nullptr && external_format_android->externalFormat != 0;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006566#else
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006567 const bool is_external_format = false;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006568#endif
6569
sfricke-samsung1a72f942020-07-25 12:09:18 -07006570 const VkFormat format = pCreateInfo->format;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006571
6572 // If there is a VkExternalFormatANDROID with externalFormat != 0, the value of components is ignored.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006573 if (!is_external_format) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006574 const VkComponentMapping components = pCreateInfo->components;
6575 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
6576 if (FormatIsXChromaSubsampled(format) == true) {
6577 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
6578 skip |=
6579 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
sfricke-samsung83d98122020-07-04 06:21:15 -07006580 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
6581 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006582 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006583 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006584
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006585 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
6586 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
6587 skip |= LogError(
6588 device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
6589 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
6590 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
6591 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
6592 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006593
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006594 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
6595 (components.r != VK_COMPONENT_SWIZZLE_B)) {
6596 skip |=
6597 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
sfricke-samsung83d98122020-07-04 06:21:15 -07006598 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
6599 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006600 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006601 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006602
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006603 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
6604 (components.b != VK_COMPONENT_SWIZZLE_R)) {
6605 skip |=
6606 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
sfricke-samsung83d98122020-07-04 06:21:15 -07006607 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
6608 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006609 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006610 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006611
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006612 // If one is identity, both need to be
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006613 const bool r_identity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
6614 const bool b_identity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
6615 if ((r_identity != b_identity) && ((r_identity == true) || (b_identity == true))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006616 skip |=
6617 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
sfricke-samsung83d98122020-07-04 06:21:15 -07006618 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
6619 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006620 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
6621 string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006622 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07006623 }
6624
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006625 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
6626 // Checks same VU multiple ways in order to give a more useful error message
6627 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
6628 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
6629 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
6630 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
6631 skip |= LogError(
6632 device, vuid,
6633 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6634 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
6635 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6636 string_VkComponentSwizzle(components.b));
6637 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07006638
sfricke-samsunged028b02021-09-06 23:14:51 -07006639 // "must not correspond to a component which contains zero or one as a consequence of conversion to RGBA"
6640 // 4 component format = no issue
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006641 // 3 = no [a]
6642 // 2 = no [b,a]
6643 // 1 = no [g,b,a]
6644 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
sfricke-samsunged028b02021-09-06 23:14:51 -07006645 const uint32_t component_count = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatComponentCount(format);
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006646
sfricke-samsunged028b02021-09-06 23:14:51 -07006647 if ((component_count < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
6648 (components.b == VK_COMPONENT_SWIZZLE_A))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006649 skip |= LogError(device, vuid,
6650 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6651 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
6652 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6653 string_VkComponentSwizzle(components.b));
sfricke-samsunged028b02021-09-06 23:14:51 -07006654 } else if ((component_count < 3) &&
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006655 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
6656 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
6657 skip |= LogError(device, vuid,
6658 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6659 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
6660 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
6661 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6662 string_VkComponentSwizzle(components.b));
sfricke-samsunged028b02021-09-06 23:14:51 -07006663 } else if ((component_count < 2) &&
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006664 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
6665 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
6666 skip |= LogError(device, vuid,
6667 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6668 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
6669 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
6670 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6671 string_VkComponentSwizzle(components.b));
6672 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006673 }
6674 }
6675
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006676 return skip;
6677}
6678
6679bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
6680 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
6681 const VkAllocationCallbacks *pAllocator,
6682 VkSamplerYcbcrConversion *pYcbcrConversion) const {
6683 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
6684 "vkCreateSamplerYcbcrConversion");
6685}
6686
6687bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
6688 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
6689 VkSamplerYcbcrConversion *pYcbcrConversion) const {
6690 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
6691 "vkCreateSamplerYcbcrConversionKHR");
6692}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08006693
6694bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
6695 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
6696 bool skip = false;
6697 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
6698 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
6699
6700 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006701 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
6702 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
6703 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
6704 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
6705 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08006706 }
6707 return skip;
6708}
sourav parmara96ab1a2020-04-25 16:28:23 -07006709
6710bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006711 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006712 bool skip = false;
6713 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
6714 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
6715 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
6716 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006717 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006718 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
6719 skip |= LogError(
6720 device, "VUID-vkCopyAccelerationStructureToMemoryKHR-accelerationStructureHostCommands-03584",
6721 "vkCopyAccelerationStructureToMemoryKHR: The "
6722 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
6723 }
6724 skip |= validate_required_pointer("vkCopyAccelerationStructureToMemoryKHR", "pInfo->dst.hostAddress", pInfo->dst.hostAddress,
6725 "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03732");
6726 if (SafeModulo((VkDeviceSize)pInfo->dst.hostAddress, 16) != 0) {
6727 skip |= LogError(device, "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03751",
6728 "vkCopyAccelerationStructureToMemoryKHR(): pInfo->dst.hostAddress must be aligned to 16 bytes.");
6729 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006730 return skip;
6731}
6732
6733bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
6734 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
6735 bool skip = false;
6736 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
6737 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
6738 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
6739 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
6740 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006741 if (SafeModulo(pInfo->dst.deviceAddress, 256) != 0) {
6742 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pInfo-03740",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006743 "vkCmdCopyAccelerationStructureToMemoryKHR(): pInfo->dst.deviceAddress (0x%" PRIx64 ") must be aligned to 256 bytes.",
sourav parmarcd5fb182020-07-17 12:58:44 -07006744 pInfo->dst.deviceAddress);
sourav parmar83c31b12020-05-06 12:30:54 -07006745 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006746 return skip;
6747}
6748
6749bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
6750 const char *api_name) const {
6751 bool skip = false;
6752 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
6753 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
6754 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
6755 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
6756 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
6757 api_name);
6758 }
6759 return skip;
6760}
6761
6762bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006763 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006764 bool skip = false;
6765 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006766 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006767 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
sourav parmar83c31b12020-05-06 12:30:54 -07006768 skip |= LogError(
sourav parmarcd5fb182020-07-17 12:58:44 -07006769 device, "VUID-vkCopyAccelerationStructureKHR-accelerationStructureHostCommands-03582",
6770 "vkCopyAccelerationStructureKHR: The "
6771 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006772 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006773 return skip;
6774}
6775
6776bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
6777 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
6778 bool skip = false;
6779 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
6780 return skip;
6781}
6782
6783bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06006784 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006785 bool skip = false;
6786 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006787 skip |= LogError(device, "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07006788 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
6789 }
6790 return skip;
6791}
6792
6793bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006794 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006795 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07006796 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006797 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006798 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
6799 skip |= LogError(
6800 device, "VUID-vkCopyMemoryToAccelerationStructureKHR-accelerationStructureHostCommands-03583",
6801 "vkCopyMemoryToAccelerationStructureKHR: The "
6802 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006803 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006804 skip |= validate_required_pointer("vkCopyMemoryToAccelerationStructureKHR", "pInfo->src.hostAddress", pInfo->src.hostAddress,
6805 "VUID-vkCopyMemoryToAccelerationStructureKHR-pInfo-03729");
sourav parmara96ab1a2020-04-25 16:28:23 -07006806 return skip;
6807}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06006808
sourav parmara96ab1a2020-04-25 16:28:23 -07006809bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
6810 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
6811 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07006812 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
sourav parmarcd5fb182020-07-17 12:58:44 -07006813 if (SafeModulo(pInfo->src.deviceAddress, 256) != 0) {
6814 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pInfo-03743",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006815 "vkCmdCopyMemoryToAccelerationStructureKHR(): pInfo->src.deviceAddress (0x%" PRIx64 ") must be aligned to 256 bytes.",
sourav parmarcd5fb182020-07-17 12:58:44 -07006816 pInfo->src.deviceAddress);
6817 }
sourav parmar83c31b12020-05-06 12:30:54 -07006818 return skip;
6819}
6820bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
6821 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
6822 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
6823 bool skip = false;
6824 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
6825 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
6826 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
6827 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
6828 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
6829 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
6830 }
6831 return skip;
6832}
6833bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
6834 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
6835 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
6836 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006837 const auto *acc_structure_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006838 if (!acc_structure_features || acc_structure_features->accelerationStructureHostCommands == VK_FALSE) {
6839 skip |= LogError(
6840 device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-accelerationStructureHostCommands-03585",
6841 "vkCmdWriteAccelerationStructuresPropertiesKHR: The "
6842 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
6843 }
sourav parmar83c31b12020-05-06 12:30:54 -07006844 if (dataSize < accelerationStructureCount * stride) {
6845 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
6846 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006847 "accelerationStructureCount (%" PRIu32 ") *stride(%zu).",
sourav parmar83c31b12020-05-06 12:30:54 -07006848 dataSize, accelerationStructureCount, stride);
6849 }
6850 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
6851 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
6852 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
6853 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
6854 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
6855 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
6856 }
6857 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
6858 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
6859 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
6860 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
6861 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
6862 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
6863 stride);
6864 }
6865 }
6866 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
6867 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
6868 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
6869 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
6870 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
6871 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
6872 stride);
6873 }
6874 }
sourav parmar83c31b12020-05-06 12:30:54 -07006875 return skip;
6876}
6877bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
6878 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
6879 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006880 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006881 if (!raytracing_features || raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE) {
6882 skip |= LogError(
6883 device, "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03606",
6884 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR:VkPhysicalDeviceRayTracingPipelineFeaturesKHR::"
6885 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled to call this function.");
sourav parmar83c31b12020-05-06 12:30:54 -07006886 }
6887 return skip;
6888}
6889
6890bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
sourav parmarcd5fb182020-07-17 12:58:44 -07006891 const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
6892 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable,
6893 const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
6894 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable,
sourav parmar83c31b12020-05-06 12:30:54 -07006895 uint32_t width, uint32_t height, uint32_t depth) const {
6896 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07006897 // RayGen
6898 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
6899 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-size-04023",
6900 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07006901 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006902 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
6903 0) {
6904 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03682",
6905 "vkCmdTraceRaysKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
6906 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
6907 }
6908 // Callable
6909 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
6910 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03694",
6911 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
6912 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006913 }
6914 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
6915 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
6916 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07006917 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
6918 }
6919 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
6920 0) {
6921 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03693",
6922 "vkCmdTraceRaysKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
6923 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006924 }
6925 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07006926 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
6927 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03690",
6928 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple of "
6929 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006930 }
6931 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
6932 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07006933 "vkCmdTraceRaysKHR: TThe stride member of pHitShaderBindingTable must be less than or equal to "
6934 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride");
sourav parmar83c31b12020-05-06 12:30:54 -07006935 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006936 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
6937 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03689",
6938 "vkCmdTraceRaysKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
6939 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
6940 }
sourav parmar83c31b12020-05-06 12:30:54 -07006941 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07006942 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
6943 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03686",
6944 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple of "
6945 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment");
sourav parmar83c31b12020-05-06 12:30:54 -07006946 }
6947 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
6948 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
6949 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07006950 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
6951 }
6952 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
6953 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03685",
6954 "vkCmdTraceRaysKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
6955 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
6956 }
6957 if (width * depth * height > phys_dev_ext_props.ray_tracing_propsKHR.maxRayDispatchInvocationCount) {
6958 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-width-03629",
6959 "vkCmdTraceRaysKHR: width {times} height {times} depth must be less than or equal to "
6960 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayDispatchInvocationCount");
6961 }
6962 if (width > device_limits.maxComputeWorkGroupCount[0] * device_limits.maxComputeWorkGroupSize[0]) {
6963 skip |=
6964 LogError(device, "VUID-vkCmdTraceRaysKHR-width-03626",
6965 "vkCmdTraceRaysKHR: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[0] "
6966 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[0]");
sourav parmar83c31b12020-05-06 12:30:54 -07006967 }
6968
sourav parmarcd5fb182020-07-17 12:58:44 -07006969 if (height > device_limits.maxComputeWorkGroupCount[1] * device_limits.maxComputeWorkGroupSize[1]) {
6970 skip |=
6971 LogError(device, "VUID-vkCmdTraceRaysKHR-height-03627",
6972 "vkCmdTraceRaysKHR: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1] "
6973 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[1]");
6974 }
6975
6976 if (depth > device_limits.maxComputeWorkGroupCount[2] * device_limits.maxComputeWorkGroupSize[2]) {
6977 skip |=
6978 LogError(device, "VUID-vkCmdTraceRaysKHR-depth-03628",
6979 "vkCmdTraceRaysKHR: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2] "
6980 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[2]");
sourav parmar83c31b12020-05-06 12:30:54 -07006981 }
6982 return skip;
6983}
6984
sourav parmarcd5fb182020-07-17 12:58:44 -07006985bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(
6986 VkCommandBuffer commandBuffer, const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
6987 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable, const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
6988 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable, VkDeviceAddress indirectDeviceAddress) const {
sourav parmar83c31b12020-05-06 12:30:54 -07006989 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006990 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006991 if (!raytracing_features || raytracing_features->rayTracingPipelineTraceRaysIndirect == VK_FALSE) {
6992 skip |= LogError(
6993 device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingPipelineTraceRaysIndirect-03637",
6994 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineTraceRaysIndirect "
6995 "feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006996 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006997 // RayGen
6998 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
6999 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-size-04023",
7000 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07007001 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007002 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7003 0) {
7004 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03682",
7005 "vkCmdTraceRaysIndirectKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
7006 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7007 }
7008 // Callabe
7009 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7010 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03694",
7011 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
7012 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007013 }
7014 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7015 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
sourav parmarcd5fb182020-07-17 12:58:44 -07007016 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be less than or equal "
7017 "to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7018 }
7019 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7020 0) {
7021 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03693",
7022 "vkCmdTraceRaysIndirectKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
7023 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007024 }
7025 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007026 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7027 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03690",
7028 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple of "
7029 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007030 }
7031 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7032 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07007033 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be less than or equal to "
7034 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
sourav parmar83c31b12020-05-06 12:30:54 -07007035 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007036 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7037 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03689",
7038 "vkCmdTraceRaysIndirectKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
7039 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7040 }
sourav parmar83c31b12020-05-06 12:30:54 -07007041 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007042 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7043 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03686",
7044 "vkCmdTraceRaysIndirectKHR:The stride member of pMissShaderBindingTable must be a multiple of "
7045 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007046 }
7047 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7048 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
sourav parmarcd5fb182020-07-17 12:58:44 -07007049 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be less than or equal to "
7050 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7051 }
7052 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7053 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03685",
7054 "vkCmdTraceRaysIndirectKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
7055 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007056 }
7057
sourav parmarcd5fb182020-07-17 12:58:44 -07007058 if (SafeModulo(indirectDeviceAddress, 4) != 0) {
7059 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-indirectDeviceAddress-03634",
7060 "vkCmdTraceRaysIndirectKHR: indirectDeviceAddress must be a multiple of 4.");
sourav parmar83c31b12020-05-06 12:30:54 -07007061 }
7062 return skip;
7063}
7064bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
7065 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
7066 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
7067 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
7068 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
7069 uint32_t width, uint32_t height, uint32_t depth) const {
7070 bool skip = false;
7071 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7072 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
7073 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
7074 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7075 }
7076 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
7077 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
7078 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
7079 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
7080 }
7081 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
7082 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
7083 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
7084 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
7085 }
7086
7087 // hitShader
7088 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7089 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
7090 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
7091 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7092 }
7093 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
7094 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
7095 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
7096 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
7097 }
7098 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
7099 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
7100 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
7101 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
7102 }
7103
7104 // missShader
7105 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7106 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
7107 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
7108 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7109 }
7110 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
7111 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
7112 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
7113 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
7114 }
7115 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
7116 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
7117 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
7118 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
7119 }
7120
7121 // raygenShader
7122 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7123 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
7124 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07007125 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7126 }
7127 if (width > device_limits.maxComputeWorkGroupCount[0]) {
7128 skip |=
7129 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
7130 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
7131 }
7132 if (height > device_limits.maxComputeWorkGroupCount[1]) {
7133 skip |=
7134 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
7135 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
7136 }
7137 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
7138 skip |=
7139 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
7140 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07007141 }
7142 return skip;
7143}
7144
sourav parmar83c31b12020-05-06 12:30:54 -07007145bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07007146 VkDevice device, const VkAccelerationStructureVersionInfoKHR *pVersionInfo,
7147 VkAccelerationStructureCompatibilityKHR *pCompatibility) const {
sourav parmar83c31b12020-05-06 12:30:54 -07007148 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007149 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
7150 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07007151 if ((!raytracing_features && !ray_query_features) || ((ray_query_features && !(ray_query_features->rayQuery)) ||
7152 (raytracing_features && !raytracing_features->rayTracingPipeline))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007153 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracingPipeline-03661",
sourav parmar83c31b12020-05-06 12:30:54 -07007154 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
7155 }
7156 return skip;
7157}
7158
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007159bool StatelessValidation::ValidateCmdSetViewportWithCount(VkCommandBuffer commandBuffer, uint32_t viewportCount,
7160 const VkViewport *pViewports, bool is_ext) const {
Piers Daniell39842ee2020-07-10 16:42:33 -06007161 bool skip = false;
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007162 const char *api_call = is_ext ? "vkCmdSetViewportWithCountEXT" : "vkCmdSetViewportWithCount";
Piers Daniell39842ee2020-07-10 16:42:33 -06007163
7164 if (!physical_device_features.multiViewport) {
7165 if (viewportCount != 1) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007166 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCount-viewportCount-03395",
7167 "%s: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.", api_call,
Piers Daniell39842ee2020-07-10 16:42:33 -06007168 viewportCount);
7169 }
7170 } else { // multiViewport enabled
7171 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007172 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCount-viewportCount-03394",
7173 "%s: viewportCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007174 ") must "
7175 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007176 api_call, viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06007177 }
7178 }
7179
7180 if (pViewports) {
7181 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
7182 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Piers Daniell39842ee2020-07-10 16:42:33 -06007183 skip |= manual_PreCallValidateViewport(
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007184 viewport, api_call, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Piers Daniell39842ee2020-07-10 16:42:33 -06007185 }
7186 }
7187
7188 return skip;
7189}
7190
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007191bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
7192 const VkViewport *pViewports) const {
Piers Daniell39842ee2020-07-10 16:42:33 -06007193 bool skip = false;
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007194 skip = ValidateCmdSetViewportWithCount(commandBuffer, viewportCount, pViewports, true);
7195 return skip;
7196}
7197
7198bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCount(VkCommandBuffer commandBuffer, uint32_t viewportCount,
7199 const VkViewport *pViewports) const {
7200 bool skip = false;
7201 skip = ValidateCmdSetViewportWithCount(commandBuffer, viewportCount, pViewports, false);
7202 return skip;
7203}
7204
7205bool StatelessValidation::ValidateCmdSetScissorWithCount(VkCommandBuffer commandBuffer, uint32_t scissorCount,
7206 const VkRect2D *pScissors, bool is_ext) const {
7207 bool skip = false;
7208 const char *api_call = is_ext ? "vkCmdSetScissorWithCountEXT" : "vkCmdSetScissorWithCount";
Piers Daniell39842ee2020-07-10 16:42:33 -06007209
7210 if (!physical_device_features.multiViewport) {
7211 if (scissorCount != 1) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007212 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-scissorCount-03398",
7213 "%s: scissorCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007214 ") must "
7215 "be 1 when the multiViewport feature is disabled.",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007216 api_call, scissorCount);
Piers Daniell39842ee2020-07-10 16:42:33 -06007217 }
7218 } else { // multiViewport enabled
7219 if (scissorCount == 0) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007220 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-scissorCount-03397",
7221 "%s: scissorCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007222 ") must "
7223 "be great than zero.",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007224 api_call, scissorCount);
Piers Daniell39842ee2020-07-10 16:42:33 -06007225 } else if (scissorCount > device_limits.maxViewports) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007226 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-scissorCount-03397",
7227 "%s: scissorCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007228 ") must "
7229 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007230 api_call, scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06007231 }
7232 }
7233
7234 if (pScissors) {
7235 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
7236 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
7237
7238 if (scissor.offset.x < 0) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007239 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-x-03399", "%s: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", api_call,
7240 scissor_i, scissor.offset.x);
Piers Daniell39842ee2020-07-10 16:42:33 -06007241 }
7242
7243 if (scissor.offset.y < 0) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007244 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-x-03399", "%s: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", api_call,
7245 scissor_i, scissor.offset.y);
Piers Daniell39842ee2020-07-10 16:42:33 -06007246 }
7247
7248 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
7249 if (x_sum > INT32_MAX) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007250 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-offset-03400",
7251 "%s: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64 ") of pScissors[%" PRIu32
7252 "] will overflow int32_t.",
7253 api_call, scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Piers Daniell39842ee2020-07-10 16:42:33 -06007254 }
7255
7256 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
7257 if (y_sum > INT32_MAX) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007258 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-offset-03401",
7259 "%s: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64 ") of pScissors[%" PRIu32
7260 "] will overflow int32_t.",
7261 api_call, scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
7262 }
7263 }
7264 }
7265
7266 return skip;
7267}
7268
7269bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
7270 const VkRect2D *pScissors) const {
7271 bool skip = false;
7272 skip = ValidateCmdSetScissorWithCount(commandBuffer, scissorCount, pScissors, true);
7273 return skip;
7274}
7275
7276bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCount(VkCommandBuffer commandBuffer, uint32_t scissorCount,
7277 const VkRect2D *pScissors) const {
7278 bool skip = false;
7279 skip = ValidateCmdSetScissorWithCount(commandBuffer, scissorCount, pScissors, false);
7280 return skip;
7281}
7282
7283bool StatelessValidation::ValidateCmdBindVertexBuffers2(VkCommandBuffer commandBuffer, uint32_t firstBinding, uint32_t bindingCount,
7284 const VkBuffer *pBuffers, const VkDeviceSize *pOffsets,
7285 const VkDeviceSize *pSizes, const VkDeviceSize *pStrides,
7286 bool is_2ext) const {
7287 bool skip = false;
7288 const char *api_call = is_2ext ? "vkCmdBindVertexBuffers2EXT()" : "vkCmdBindVertexBuffers2()";
7289 if (firstBinding >= device_limits.maxVertexInputBindings) {
7290 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-firstBinding-03355",
7291 "%s firstBinding (%" PRIu32 ") must be less than maxVertexInputBindings (%" PRIu32 ")", api_call,
7292 firstBinding, device_limits.maxVertexInputBindings);
7293 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
7294 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-firstBinding-03356",
7295 "%s sum of firstBinding (%" PRIu32 ") and bindingCount (%" PRIu32
7296 ") must be less than "
7297 "maxVertexInputBindings (%" PRIu32 ")",
7298 api_call, firstBinding, bindingCount, device_limits.maxVertexInputBindings);
7299 }
7300
7301 for (uint32_t i = 0; i < bindingCount; ++i) {
7302 if (pBuffers[i] == VK_NULL_HANDLE) {
7303 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
7304 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
7305 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-pBuffers-04111",
7306 "%s required parameter pBuffers[%" PRIu32 "] specified as VK_NULL_HANDLE", api_call, i);
7307 } else {
7308 if (pOffsets[i] != 0) {
7309 skip |=
7310 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-pBuffers-04112",
7311 "%s pBuffers[%" PRIu32 "] is VK_NULL_HANDLE, but pOffsets[%" PRIu32 "] is not 0", api_call, i, i);
7312 }
7313 }
7314 }
7315 if (pStrides) {
7316 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
7317 skip |=
7318 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-pStrides-03362",
7319 "%s pStrides[%" PRIu32 "] (%" PRIu64 ") must be less than maxVertexInputBindingStride (%" PRIu32 ")",
7320 api_call, i, pStrides[i], device_limits.maxVertexInputBindingStride);
Piers Daniell39842ee2020-07-10 16:42:33 -06007321 }
7322 }
7323 }
7324
7325 return skip;
7326}
7327
7328bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
7329 uint32_t bindingCount, const VkBuffer *pBuffers,
7330 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
7331 const VkDeviceSize *pStrides) const {
7332 bool skip = false;
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007333 skip = ValidateCmdBindVertexBuffers2(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets, pSizes, pStrides, true);
7334 return skip;
7335}
Piers Daniell39842ee2020-07-10 16:42:33 -06007336
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007337bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2(VkCommandBuffer commandBuffer, uint32_t firstBinding,
7338 uint32_t bindingCount, const VkBuffer *pBuffers,
7339 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
7340 const VkDeviceSize *pStrides) const {
7341 bool skip = false;
7342 skip = ValidateCmdBindVertexBuffers2(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets, pSizes, pStrides, false);
Piers Daniell39842ee2020-07-10 16:42:33 -06007343 return skip;
7344}
sourav parmarcd5fb182020-07-17 12:58:44 -07007345
7346bool StatelessValidation::ValidateAccelerationStructureBuildGeometryInfoKHR(
7347 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos, uint32_t infoCount, const char *api_name) const {
7348 bool skip = false;
7349 for (uint32_t i = 0; i < infoCount; ++i) {
7350 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
7351 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03654",
7352 "(%s): type must not be VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.", api_name);
7353 }
7354 if (pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
7355 pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
7356 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-flags-03796",
7357 "(%s): If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR bit set,"
7358 "then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.",
7359 api_name);
7360 }
7361 if (pInfos[i].pGeometries && pInfos[i].ppGeometries) {
7362 skip |=
7363 LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-pGeometries-03788",
7364 "(%s): Only one of pGeometries or ppGeometries can be a valid pointer, the other must be NULL", api_name);
7365 }
7366 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pInfos[i].geometryCount != 1) {
7367 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03790",
7368 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, geometryCount must be 1", api_name);
7369 }
7370 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
7371 pInfos[i].geometryCount > phys_dev_ext_props.acc_structure_props.maxGeometryCount) {
7372 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03793",
7373 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then geometryCount must be"
7374 " less than or equal to VkPhysicalDeviceAccelerationStructurePropertiesKHR::maxGeometryCount",
7375 api_name);
7376 }
7377 if (pInfos[i].pGeometries) {
7378 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7379 skip |= validate_ranged_enum(
7380 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometryType", ParameterName::IndexVector{i, j}),
7381 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].pGeometries[j].geometryType,
7382 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
7383 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007384 skip |= validate_struct_type(
7385 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles", ParameterName::IndexVector{i, j}),
7386 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7387 &(pInfos[i].pGeometries[j].geometry.triangles),
7388 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
7389 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
7390 skip |= validate_struct_pnext(
7391 api_name,
7392 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
7393 NULL, pInfos[i].pGeometries[j].geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7394 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
7395 skip |=
7396 validate_ranged_enum(api_name,
7397 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.vertexFormat",
7398 ParameterName::IndexVector{i, j}),
7399 "VkFormat", AllVkFormatEnums, pInfos[i].pGeometries[j].geometry.triangles.vertexFormat,
7400 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
7401 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
7402 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7403 &pInfos[i].pGeometries[j].geometry.triangles,
7404 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
7405 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
7406 skip |= validate_ranged_enum(
7407 api_name,
7408 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.indexType", ParameterName::IndexVector{i, j}),
7409 "VkIndexType", AllVkIndexTypeEnums, pInfos[i].pGeometries[j].geometry.triangles.indexType,
7410 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
7411
7412 if (pInfos[i].pGeometries[j].geometry.triangles.vertexStride > UINT32_MAX) {
7413 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
7414 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
7415 }
7416 if (pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
7417 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
7418 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
7419 skip |=
7420 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
7421 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
7422 api_name);
7423 }
7424 }
7425 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7426 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
7427 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7428 &pInfos[i].pGeometries[j].geometry.instances,
7429 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
7430 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
7431 skip |= validate_struct_type(
7432 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.instances", ParameterName::IndexVector{i, j}),
7433 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7434 &(pInfos[i].pGeometries[j].geometry.instances),
7435 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
7436 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
7437 skip |= validate_struct_pnext(
7438 api_name,
7439 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.pNext", ParameterName::IndexVector{i, j}),
7440 NULL, pInfos[i].pGeometries[j].geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7441 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
7442
7443 skip |= validate_bool32(api_name,
7444 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.arrayOfPointers",
7445 ParameterName::IndexVector{i, j}),
7446 pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers);
7447 }
7448 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7449 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
7450 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7451 &pInfos[i].pGeometries[j].geometry.aabbs,
7452 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
7453 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
7454 skip |= validate_struct_type(
7455 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs", ParameterName::IndexVector{i, j}),
7456 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7457 &(pInfos[i].pGeometries[j].geometry.aabbs),
7458 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
7459 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
7460 skip |= validate_struct_pnext(
7461 api_name,
7462 ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
7463 pInfos[i].pGeometries[j].geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7464 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
7465 if (pInfos[i].pGeometries[j].geometry.aabbs.stride > UINT32_MAX) {
7466 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
7467 "(%s):stride must be less than or equal to 2^32-1", api_name);
7468 }
7469 }
7470 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
7471 pInfos[i].pGeometries[j].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7472 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
7473 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
7474 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7475 api_name);
7476 }
7477 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
7478 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7479 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
7480 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
7481 "of elements of"
7482 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7483 api_name);
7484 }
7485 if (pInfos[i].pGeometries[j].geometryType != pInfos[i].pGeometries[0].geometryType) {
7486 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
7487 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
7488 " member of each geometry in either pGeometries or ppGeometries must be the same.",
7489 api_name);
7490 }
7491 }
7492 }
7493 }
7494 if (pInfos[i].ppGeometries != NULL) {
7495 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7496 skip |= validate_ranged_enum(
7497 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometryType", ParameterName::IndexVector{i, j}),
7498 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].ppGeometries[j]->geometryType,
7499 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
7500 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007501 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
7502 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7503 &pInfos[i].ppGeometries[j]->geometry.triangles,
7504 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
7505 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
7506 skip |= validate_struct_type(
7507 api_name,
7508 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles", ParameterName::IndexVector{i, j}),
7509 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7510 &(pInfos[i].ppGeometries[j]->geometry.triangles),
7511 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
7512 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
7513 skip |= validate_struct_pnext(
7514 api_name,
7515 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
7516 NULL, pInfos[i].ppGeometries[j]->geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7517 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
7518 skip |= validate_ranged_enum(api_name,
7519 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.vertexFormat",
7520 ParameterName::IndexVector{i, j}),
7521 "VkFormat", AllVkFormatEnums,
7522 pInfos[i].ppGeometries[j]->geometry.triangles.vertexFormat,
7523 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
7524 skip |= validate_ranged_enum(api_name,
7525 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.indexType",
7526 ParameterName::IndexVector{i, j}),
7527 "VkIndexType", AllVkIndexTypeEnums,
7528 pInfos[i].ppGeometries[j]->geometry.triangles.indexType,
7529 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
7530 if (pInfos[i].ppGeometries[j]->geometry.triangles.vertexStride > UINT32_MAX) {
7531 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
7532 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
7533 }
7534 if (pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
7535 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
7536 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
7537 skip |=
7538 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
7539 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
7540 api_name);
7541 }
7542 }
7543 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7544 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
7545 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7546 &pInfos[i].ppGeometries[j]->geometry.instances,
7547 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
7548 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
7549 skip |= validate_struct_type(
7550 api_name,
7551 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances", ParameterName::IndexVector{i, j}),
7552 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7553 &(pInfos[i].ppGeometries[j]->geometry.instances),
7554 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
7555 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
7556 skip |= validate_struct_pnext(
7557 api_name,
7558 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.pNext", ParameterName::IndexVector{i, j}),
7559 NULL, pInfos[i].ppGeometries[j]->geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7560 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
7561 skip |= validate_bool32(api_name,
7562 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.arrayOfPointers",
7563 ParameterName::IndexVector{i, j}),
7564 pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers);
7565 }
7566 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7567 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
7568 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7569 &pInfos[i].ppGeometries[j]->geometry.aabbs,
7570 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
7571 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
7572 skip |= validate_struct_type(
7573 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs", ParameterName::IndexVector{i, j}),
7574 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7575 &(pInfos[i].ppGeometries[j]->geometry.aabbs),
7576 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
7577 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
7578 skip |= validate_struct_pnext(
7579 api_name,
7580 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
7581 pInfos[i].ppGeometries[j]->geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7582 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
7583 if (pInfos[i].ppGeometries[j]->geometry.aabbs.stride > UINT32_MAX) {
7584 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
7585 "(%s):stride must be less than or equal to 2^32-1", api_name);
7586 }
7587 }
7588 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
7589 pInfos[i].ppGeometries[j]->geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7590 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
7591 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
7592 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7593 api_name);
7594 }
7595 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
7596 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7597 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
7598 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
7599 "of elements of"
7600 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7601 api_name);
7602 }
7603 if (pInfos[i].ppGeometries[j]->geometryType != pInfos[i].ppGeometries[0]->geometryType) {
7604 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
7605 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
7606 " member of each geometry in either pGeometries or ppGeometries must be the same.",
7607 api_name);
7608 }
7609 }
7610 }
7611 }
7612 }
7613 return skip;
7614}
7615bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresKHR(
7616 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
7617 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
7618 bool skip = false;
7619 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresKHR");
7620 for (uint32_t i = 0; i < infoCount; ++i) {
7621 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
7622 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
7623 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03710",
7624 "vkCmdBuildAccelerationStructuresKHR:For each element of pInfos, its "
7625 "scratchData.deviceAddress member must be a multiple of "
7626 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
7627 }
7628 for (uint32_t k = 0; k < infoCount; ++k) {
7629 if (i == k) continue;
7630 bool found = false;
7631 if (pInfos[i].dstAccelerationStructure == pInfos[k].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007632 skip |=
7633 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
7634 "vkCmdBuildAccelerationStructuresKHR:The dstAccelerationStructure member of any element (%" PRIu32
7635 ") of pInfos must "
7636 "not be "
7637 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7638 ") of pInfos.",
7639 i, k);
sourav parmarcd5fb182020-07-17 12:58:44 -07007640 found = true;
7641 }
7642 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007643 skip |=
7644 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03403",
7645 "vkCmdBuildAccelerationStructuresKHR:The srcAccelerationStructure member of any element (%" PRIu32
7646 ") of pInfos must "
7647 "not be "
7648 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7649 ") of pInfos.",
7650 i, k);
sourav parmarcd5fb182020-07-17 12:58:44 -07007651 found = true;
7652 }
7653 if (found) break;
7654 }
7655 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7656 if (pInfos[i].pGeometries) {
7657 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7658 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
7659 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7660 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
7661 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7662 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7663 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7664 }
7665 } else {
7666 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
7667 skip |=
7668 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
7669 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7670 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7671 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7672 }
7673 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007674 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007675 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7676 skip |= LogError(
7677 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
7678 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7679 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7680 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007681 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7682 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007683 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
7684 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
7685 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7686 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7687 }
7688 }
7689 } else if (pInfos[i].ppGeometries) {
7690 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7691 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
7692 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7693 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
7694 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7695 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7696 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7697 }
7698 } else {
7699 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
7700 skip |=
7701 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
7702 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7703 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7704 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7705 }
7706 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007707 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007708 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7709 skip |= LogError(
7710 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
7711 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7712 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7713 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007714 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7715 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007716 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
7717 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
7718 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7719 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7720 }
7721 }
7722 }
7723 }
7724 }
7725 return skip;
7726}
7727
7728bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresIndirectKHR(
7729 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
7730 const VkDeviceAddress *pIndirectDeviceAddresses, const uint32_t *pIndirectStrides,
7731 const uint32_t *const *ppMaxPrimitiveCounts) const {
7732 bool skip = false;
7733 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresIndirectKHR");
7734 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007735 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07007736 if (!ray_tracing_acceleration_structure_features ||
7737 ray_tracing_acceleration_structure_features->accelerationStructureIndirectBuild == VK_FALSE) {
7738 skip |= LogError(
7739 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-accelerationStructureIndirectBuild-03650",
7740 "vkCmdBuildAccelerationStructuresIndirectKHR: The "
7741 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureIndirectBuild feature must be enabled.");
7742 }
7743 for (uint32_t i = 0; i < infoCount; ++i) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007744 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
7745 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
7746 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03710",
7747 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, its "
7748 "scratchData.deviceAddress member must be a multiple of "
7749 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
7750 }
7751 for (uint32_t k = 0; k < infoCount; ++k) {
7752 if (i == k) continue;
7753 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007754 skip |= LogError(
7755 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03403",
7756 "vkCmdBuildAccelerationStructuresIndirectKHR:The srcAccelerationStructure member of any element (%" PRIu32
7757 ") "
7758 "of pInfos must not be the same acceleration structure as the dstAccelerationStructure member of "
7759 "any other element [%" PRIu32 ") of pInfos.",
7760 i, k);
sourav parmarcd5fb182020-07-17 12:58:44 -07007761 break;
7762 }
7763 }
7764 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7765 if (pInfos[i].pGeometries) {
7766 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7767 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
7768 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7769 skip |= LogError(
7770 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
7771 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7772 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7773 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7774 }
7775 } else {
7776 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
7777 skip |= LogError(
7778 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
7779 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7780 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7781 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7782 }
7783 }
7784 }
7785 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7786 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7787 skip |= LogError(
7788 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
7789 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7790 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7791 }
7792 }
7793 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7794 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.indexData.deviceAddress, 16) != 0) {
7795 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
7796 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
7797 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7798 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7799 }
7800 }
7801 } else if (pInfos[i].ppGeometries) {
7802 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7803 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
7804 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7805 skip |= LogError(
7806 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
7807 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7808 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7809 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7810 }
7811 } else {
7812 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
7813 skip |= LogError(
7814 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
7815 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7816 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7817 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7818 }
7819 }
7820 }
7821 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7822 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7823 skip |= LogError(
7824 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
7825 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7826 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7827 }
7828 }
7829 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7830 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.indexData.deviceAddress, 16) != 0) {
7831 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
7832 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
7833 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7834 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7835 }
7836 }
7837 }
7838 }
7839 }
7840 return skip;
7841}
7842
7843bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructuresKHR(
7844 VkDevice device, VkDeferredOperationKHR deferredOperation, uint32_t infoCount,
7845 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
7846 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
7847 bool skip = false;
7848 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkBuildAccelerationStructuresKHR");
7849 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007850 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07007851 if (!ray_tracing_acceleration_structure_features ||
7852 ray_tracing_acceleration_structure_features->accelerationStructureHostCommands == VK_FALSE) {
7853 skip |=
7854 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581",
7855 "vkBuildAccelerationStructuresKHR: The "
7856 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled");
7857 }
7858 for (uint32_t i = 0; i < infoCount; ++i) {
7859 for (uint32_t j = 0; j < infoCount; ++j) {
7860 if (i == j) continue;
7861 bool found = false;
7862 if (pInfos[i].dstAccelerationStructure == pInfos[j].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007863 skip |=
7864 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
7865 "vkBuildAccelerationStructuresKHR(): The dstAccelerationStructure member of any element (%" PRIu32
7866 ") of pInfos must "
7867 "not be "
7868 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7869 ") of pInfos.",
7870 i, j);
sourav parmarcd5fb182020-07-17 12:58:44 -07007871 found = true;
7872 }
7873 if (pInfos[i].srcAccelerationStructure == pInfos[j].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007874 skip |=
7875 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-pInfos-03403",
7876 "vkBuildAccelerationStructuresKHR(): The srcAccelerationStructure member of any element (%" PRIu32
7877 ") of pInfos must "
7878 "not be "
7879 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7880 ") of pInfos.",
7881 i, j);
sourav parmarcd5fb182020-07-17 12:58:44 -07007882 found = true;
7883 }
7884 if (found) break;
7885 }
7886 }
7887 return skip;
7888}
7889
7890bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureBuildSizesKHR(
7891 VkDevice device, VkAccelerationStructureBuildTypeKHR buildType, const VkAccelerationStructureBuildGeometryInfoKHR *pBuildInfo,
7892 const uint32_t *pMaxPrimitiveCounts, VkAccelerationStructureBuildSizesInfoKHR *pSizeInfo) const {
7893 bool skip = false;
7894 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pBuildInfo, 1, "vkGetAccelerationStructureBuildSizesKHR");
7895 const auto *ray_tracing_pipeline_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007896 LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
7897 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
ziga-lunargbcfba982022-03-19 17:49:55 +01007898 if (!((ray_tracing_pipeline_features && ray_tracing_pipeline_features->rayTracingPipeline == VK_TRUE) ||
7899 (ray_query_features && ray_query_features->rayQuery == VK_TRUE))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007900 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-rayTracingPipeline-03617",
Lars-Ivar Hesselberg Simonsendcd1e402021-11-23 17:14:03 +01007901 "vkGetAccelerationStructureBuildSizesKHR: The rayTracingPipeline or rayQuery feature must be enabled");
7902 }
7903 if (pBuildInfo != nullptr) {
7904 if (pBuildInfo->geometryCount != 0 && pMaxPrimitiveCounts == nullptr) {
7905 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-pBuildInfo-03619",
7906 "vkGetAccelerationStructureBuildSizesKHR: If pBuildInfo->geometryCount is not 0, pMaxPrimitiveCounts "
7907 "must be a valid pointer to an array of pBuildInfo->geometryCount uint32_t values");
7908 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007909 }
7910 return skip;
7911}
sfricke-samsungecafb192021-01-17 08:21:14 -08007912
Piers Daniellcb6d8032021-04-19 18:51:26 -06007913bool StatelessValidation::manual_PreCallValidateCmdSetVertexInputEXT(
7914 VkCommandBuffer commandBuffer, uint32_t vertexBindingDescriptionCount,
7915 const VkVertexInputBindingDescription2EXT *pVertexBindingDescriptions, uint32_t vertexAttributeDescriptionCount,
7916 const VkVertexInputAttributeDescription2EXT *pVertexAttributeDescriptions) const {
7917 bool skip = false;
7918 const auto *vertex_input_dynamic_state_features =
7919 LvlFindInChain<VkPhysicalDeviceVertexInputDynamicStateFeaturesEXT>(device_createinfo_pnext);
7920 const auto *vertex_attribute_divisor_features =
7921 LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(device_createinfo_pnext);
7922
7923 // VUID-vkCmdSetVertexInputEXT-None-04790
7924 if (!vertex_input_dynamic_state_features || vertex_input_dynamic_state_features->vertexInputDynamicState == VK_FALSE) {
7925 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-None-04790",
7926 "vkCmdSetVertexInputEXT(): The vertexInputDynamicState feature must be enabled.");
7927 }
7928
7929 // VUID-vkCmdSetVertexInputEXT-vertexBindingDescriptionCount-04791
7930 if (vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
7931 skip |=
7932 LogError(device, "VUID-vkCmdSetVertexInputEXT-vertexBindingDescriptionCount-04791",
7933 "vkCmdSetVertexInputEXT(): vertexBindingDescriptionCount is greater than the maxVertexInputBindings limit");
7934 }
7935
7936 // VUID-vkCmdSetVertexInputEXT-vertexAttributeDescriptionCount-04792
7937 if (vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
7938 skip |= LogError(
7939 device, "VUID-vkCmdSetVertexInputEXT-vertexAttributeDescriptionCount-04792",
7940 "vkCmdSetVertexInputEXT(): vertexAttributeDescriptionCount is greater than the maxVertexInputAttributes limit");
7941 }
7942
7943 // VUID-vkCmdSetVertexInputEXT-binding-04793
7944 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount; ++attribute) {
7945 bool binding_found = false;
7946 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount; ++binding) {
7947 if (pVertexAttributeDescriptions[attribute].binding == pVertexBindingDescriptions[binding].binding) {
7948 binding_found = true;
7949 break;
7950 }
7951 }
7952 if (!binding_found) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007953 skip |= LogError(
7954 device, "VUID-vkCmdSetVertexInputEXT-binding-04793",
7955 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32 "] references an unspecified binding", attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06007956 }
7957 }
7958
7959 // VUID-vkCmdSetVertexInputEXT-pVertexBindingDescriptions-04794
7960 if (vertexBindingDescriptionCount > 1) {
7961 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount - 1; ++binding) {
7962 uint32_t binding_value = pVertexBindingDescriptions[binding].binding;
7963 for (uint32_t next_binding = binding + 1; next_binding < vertexBindingDescriptionCount; ++next_binding) {
7964 if (binding_value == pVertexBindingDescriptions[next_binding].binding) {
7965 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-pVertexBindingDescriptions-04794",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007966 "vkCmdSetVertexInputEXT(): binding description for binding %" PRIu32 " already specified",
7967 binding_value);
Piers Daniellcb6d8032021-04-19 18:51:26 -06007968 }
7969 }
7970 }
7971 }
7972
7973 // VUID-vkCmdSetVertexInputEXT-pVertexAttributeDescriptions-04795
7974 if (vertexAttributeDescriptionCount > 1) {
7975 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount - 1; ++attribute) {
7976 uint32_t location = pVertexAttributeDescriptions[attribute].location;
7977 for (uint32_t next_attribute = attribute + 1; next_attribute < vertexAttributeDescriptionCount; ++next_attribute) {
7978 if (location == pVertexAttributeDescriptions[next_attribute].location) {
7979 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-pVertexAttributeDescriptions-04795",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007980 "vkCmdSetVertexInputEXT(): attribute description for location %" PRIu32 " already specified",
7981 location);
Piers Daniellcb6d8032021-04-19 18:51:26 -06007982 }
7983 }
7984 }
7985 }
7986
7987 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount; ++binding) {
7988 // VUID-VkVertexInputBindingDescription2EXT-binding-04796
7989 if (pVertexBindingDescriptions[binding].binding > device_limits.maxVertexInputBindings) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007990 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-binding-04796",
7991 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
7992 "].binding is greater than maxVertexInputBindings",
7993 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06007994 }
7995
7996 // VUID-VkVertexInputBindingDescription2EXT-stride-04797
7997 if (pVertexBindingDescriptions[binding].stride > device_limits.maxVertexInputBindingStride) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007998 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-stride-04797",
7999 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8000 "].stride is greater than maxVertexInputBindingStride",
8001 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008002 }
8003
8004 // VUID-VkVertexInputBindingDescription2EXT-divisor-04798
8005 if (pVertexBindingDescriptions[binding].divisor == 0 &&
8006 (!vertex_attribute_divisor_features || !vertex_attribute_divisor_features->vertexAttributeInstanceRateZeroDivisor)) {
8007 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04798",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008008 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8009 "].divisor is zero but "
Piers Daniellcb6d8032021-04-19 18:51:26 -06008010 "vertexAttributeInstanceRateZeroDivisor is not enabled",
8011 binding);
8012 }
8013
8014 if (pVertexBindingDescriptions[binding].divisor > 1) {
8015 // VUID-VkVertexInputBindingDescription2EXT-divisor-04799
8016 if (!vertex_attribute_divisor_features || !vertex_attribute_divisor_features->vertexAttributeInstanceRateDivisor) {
8017 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04799",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008018 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8019 "].divisor is greater than one but "
Piers Daniellcb6d8032021-04-19 18:51:26 -06008020 "vertexAttributeInstanceRateDivisor is not enabled",
8021 binding);
8022 } else {
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008023 // VUID-VkVertexInputBindingDescription2EXT-divisor-06226
Piers Daniellcb6d8032021-04-19 18:51:26 -06008024 if (pVertexBindingDescriptions[binding].divisor >
8025 phys_dev_ext_props.vertex_attribute_divisor_props.maxVertexAttribDivisor) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008026 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-06226",
8027 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8028 "].divisor is greater than maxVertexAttribDivisor",
8029 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008030 }
8031
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008032 // VUID-VkVertexInputBindingDescription2EXT-divisor-06227
Piers Daniellcb6d8032021-04-19 18:51:26 -06008033 if (pVertexBindingDescriptions[binding].inputRate != VK_VERTEX_INPUT_RATE_INSTANCE) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008034 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-06227",
8035 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8036 "].divisor is greater than 1 but inputRate "
8037 "is not VK_VERTEX_INPUT_RATE_INSTANCE",
8038 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008039 }
8040 }
8041 }
8042 }
8043
8044 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount; ++attribute) {
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008045 // VUID-VkVertexInputAttributeDescription2EXT-location-06228
Piers Daniellcb6d8032021-04-19 18:51:26 -06008046 if (pVertexAttributeDescriptions[attribute].location > device_limits.maxVertexInputAttributes) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008047 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-location-06228",
8048 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8049 "].location is greater than maxVertexInputAttributes",
8050 attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008051 }
8052
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008053 // VUID-VkVertexInputAttributeDescription2EXT-binding-06229
Piers Daniellcb6d8032021-04-19 18:51:26 -06008054 if (pVertexAttributeDescriptions[attribute].binding > device_limits.maxVertexInputBindings) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008055 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-binding-06229",
8056 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8057 "].binding is greater than maxVertexInputBindings",
8058 attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008059 }
8060
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008061 // VUID-VkVertexInputAttributeDescription2EXT-offset-06230
Piers Daniellcb6d8032021-04-19 18:51:26 -06008062 if (pVertexAttributeDescriptions[attribute].offset > device_limits.maxVertexInputAttributeOffset) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008063 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-offset-06230",
8064 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8065 "].offset is greater than maxVertexInputAttributeOffset",
8066 attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008067 }
8068
8069 // VUID-VkVertexInputAttributeDescription2EXT-format-04805
8070 VkFormatProperties properties;
8071 DispatchGetPhysicalDeviceFormatProperties(physical_device, pVertexAttributeDescriptions[attribute].format, &properties);
8072 if ((properties.bufferFeatures & VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT) == 0) {
8073 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-format-04805",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008074 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8075 "].format is not a "
Piers Daniellcb6d8032021-04-19 18:51:26 -06008076 "VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT supported format",
8077 attribute);
8078 }
8079 }
8080
8081 return skip;
8082}
sfricke-samsung51303fb2021-05-09 19:09:13 -07008083
8084bool StatelessValidation::manual_PreCallValidateCmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout,
8085 VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size,
8086 const void *pValues) const {
8087 bool skip = false;
8088 const uint32_t max_push_constants_size = device_limits.maxPushConstantsSize;
8089 // Check that offset + size don't exceed the max.
8090 // Prevent arithetic overflow here by avoiding addition and testing in this order.
8091 if (offset >= max_push_constants_size) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008092 skip |=
8093 LogError(device, "VUID-vkCmdPushConstants-offset-00370",
8094 "vkCmdPushConstants(): offset (%" PRIu32 ") that exceeds this device's maxPushConstantSize of %" PRIu32 ".",
8095 offset, max_push_constants_size);
sfricke-samsung51303fb2021-05-09 19:09:13 -07008096 }
8097 if (size > max_push_constants_size - offset) {
8098 skip |= LogError(device, "VUID-vkCmdPushConstants-size-00371",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008099 "vkCmdPushConstants(): offset (%" PRIu32 ") and size (%" PRIu32
8100 ") that exceeds this device's maxPushConstantSize of %" PRIu32 ".",
sfricke-samsung51303fb2021-05-09 19:09:13 -07008101 offset, size, max_push_constants_size);
8102 }
8103
8104 // size needs to be non-zero and a multiple of 4.
8105 if (size & 0x3) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008106 skip |= LogError(device, "VUID-vkCmdPushConstants-size-00369",
8107 "vkCmdPushConstants(): size (%" PRIu32 ") must be a multiple of 4.", size);
sfricke-samsung51303fb2021-05-09 19:09:13 -07008108 }
8109
8110 // offset needs to be a multiple of 4.
8111 if ((offset & 0x3) != 0) {
8112 skip |= LogError(device, "VUID-vkCmdPushConstants-offset-00368",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008113 "vkCmdPushConstants(): offset (%" PRIu32 ") must be a multiple of 4.", offset);
sfricke-samsung51303fb2021-05-09 19:09:13 -07008114 }
8115 return skip;
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06008116}
ziga-lunargb1dd8a22021-07-15 17:47:19 +02008117
8118bool StatelessValidation::manual_PreCallValidateMergePipelineCaches(VkDevice device, VkPipelineCache dstCache,
8119 uint32_t srcCacheCount,
8120 const VkPipelineCache *pSrcCaches) const {
8121 bool skip = false;
8122 if (pSrcCaches) {
8123 for (uint32_t index0 = 0; index0 < srcCacheCount; ++index0) {
8124 if (pSrcCaches[index0] == dstCache) {
8125 skip |= LogError(instance, "VUID-vkMergePipelineCaches-dstCache-00770",
8126 "vkMergePipelineCaches(): dstCache %s is in pSrcCaches list.",
8127 report_data->FormatHandle(dstCache).c_str());
8128 break;
8129 }
8130 }
8131 }
8132 return skip;
8133}
Nathaniel Cesario298d3cb2021-08-03 13:49:02 -06008134
8135bool StatelessValidation::manual_PreCallValidateCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image,
8136 VkImageLayout imageLayout, const VkClearColorValue *pColor,
8137 uint32_t rangeCount,
8138 const VkImageSubresourceRange *pRanges) const {
8139 bool skip = false;
8140 if (!pColor) {
8141 skip |=
8142 LogError(commandBuffer, "VUID-vkCmdClearColorImage-pColor-04961", "vkCmdClearColorImage(): pColor must not be null");
8143 }
8144 return skip;
8145}
8146
8147bool StatelessValidation::ValidateCmdBeginRenderPass(const char *const func_name,
8148 const VkRenderPassBeginInfo *const rp_begin) const {
8149 bool skip = false;
8150 if ((rp_begin->clearValueCount != 0) && !rp_begin->pClearValues) {
8151 skip |= LogError(rp_begin->renderPass, "VUID-VkRenderPassBeginInfo-clearValueCount-04962",
8152 "%s: VkRenderPassBeginInfo::clearValueCount != 0 (%" PRIu32
ziga-lunarg47109fb2021-09-03 18:41:12 +02008153 "), but VkRenderPassBeginInfo::pClearValues is null.",
Nathaniel Cesario298d3cb2021-08-03 13:49:02 -06008154 func_name, rp_begin->clearValueCount);
8155 }
8156 return skip;
8157}
8158
8159bool StatelessValidation::manual_PreCallValidateCmdBeginRenderPass(VkCommandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin,
8160 VkSubpassContents) const {
8161 bool skip = ValidateCmdBeginRenderPass("vkCmdBeginRenderPass", pRenderPassBegin);
8162 return skip;
8163}
8164
8165bool StatelessValidation::manual_PreCallValidateCmdBeginRenderPass2KHR(VkCommandBuffer,
8166 const VkRenderPassBeginInfo *pRenderPassBegin,
8167 const VkSubpassBeginInfo *) const {
8168 bool skip = ValidateCmdBeginRenderPass("vkCmdBeginRenderPass2KHR", pRenderPassBegin);
8169 return skip;
8170}
8171
8172bool StatelessValidation::manual_PreCallValidateCmdBeginRenderPass2(VkCommandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin,
8173 const VkSubpassBeginInfo *) const {
8174 bool skip = ValidateCmdBeginRenderPass("vkCmdBeginRenderPass2", pRenderPassBegin);
8175 return skip;
8176}
ziga-lunargc7bb56a2021-08-10 09:28:52 +02008177
8178bool StatelessValidation::manual_PreCallValidateCmdSetDiscardRectangleEXT(VkCommandBuffer commandBuffer,
8179 uint32_t firstDiscardRectangle,
8180 uint32_t discardRectangleCount,
8181 const VkRect2D *pDiscardRectangles) const {
8182 bool skip = false;
8183
8184 if (pDiscardRectangles) {
8185 for (uint32_t i = 0; i < discardRectangleCount; ++i) {
8186 const int64_t x_sum =
8187 static_cast<int64_t>(pDiscardRectangles[i].offset.x) + static_cast<int64_t>(pDiscardRectangles[i].extent.width);
8188 if (x_sum > std::numeric_limits<int32_t>::max()) {
8189 skip |= LogError(device, "VUID-vkCmdSetDiscardRectangleEXT-offset-00588",
8190 "vkCmdSetDiscardRectangleEXT(): offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
8191 ") of pDiscardRectangles[%" PRIu32 "] will overflow int32_t.",
8192 pDiscardRectangles[i].offset.x, pDiscardRectangles[i].extent.width, x_sum, i);
8193 }
8194
8195 const int64_t y_sum =
8196 static_cast<int64_t>(pDiscardRectangles[i].offset.y) + static_cast<int64_t>(pDiscardRectangles[i].extent.height);
8197 if (y_sum > std::numeric_limits<int32_t>::max()) {
8198 skip |= LogError(device, "VUID-vkCmdSetDiscardRectangleEXT-offset-00589",
8199 "vkCmdSetDiscardRectangleEXT(): offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
8200 ") of pDiscardRectangles[%" PRIu32 "] will overflow int32_t.",
8201 pDiscardRectangles[i].offset.y, pDiscardRectangles[i].extent.height, y_sum, i);
8202 }
8203 }
8204 }
8205
8206 return skip;
8207}
ziga-lunarg3c37dfb2021-08-24 12:51:07 +02008208
8209bool StatelessValidation::manual_PreCallValidateGetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery,
8210 uint32_t queryCount, size_t dataSize, void *pData,
8211 VkDeviceSize stride, VkQueryResultFlags flags) const {
8212 bool skip = false;
8213
8214 if ((flags & VK_QUERY_RESULT_WITH_STATUS_BIT_KHR) && (flags & VK_QUERY_RESULT_WITH_AVAILABILITY_BIT)) {
8215 skip |= LogError(device, "VUID-vkGetQueryPoolResults-flags-04811",
8216 "vkGetQueryPoolResults(): flags include both VK_QUERY_RESULT_WITH_STATUS_BIT_KHR bit and VK_QUERY_RESULT_WITH_AVAILABILITY_BIT bit.");
8217 }
8218
8219 return skip;
8220}
ziga-lunargcf340c42021-08-19 00:13:38 +02008221
8222bool StatelessValidation::manual_PreCallValidateCmdBeginConditionalRenderingEXT(
8223 VkCommandBuffer commandBuffer, const VkConditionalRenderingBeginInfoEXT* pConditionalRenderingBegin) const {
8224 bool skip = false;
8225
8226 if ((pConditionalRenderingBegin->offset & 3) != 0) {
8227 skip |= LogError(commandBuffer, "VUID-VkConditionalRenderingBeginInfoEXT-offset-01984",
8228 "vkCmdBeginConditionalRenderingEXT(): pConditionalRenderingBegin->offset (%" PRIu64
8229 ") is not a multiple of 4.",
8230 pConditionalRenderingBegin->offset);
8231 }
8232
8233 return skip;
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06008234}
Mike Schuchardt05b028d2022-01-05 14:15:00 -08008235
8236bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfaceFormatsKHR(VkPhysicalDevice physicalDevice,
8237 VkSurfaceKHR surface,
8238 uint32_t *pSurfaceFormatCount,
8239 VkSurfaceFormatKHR *pSurfaceFormats) const {
8240 bool skip = false;
8241 if (surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8242 skip |= LogError(
8243 physicalDevice, "VUID-vkGetPhysicalDeviceSurfaceFormatsKHR-surface-06524",
8244 "vkGetPhysicalDeviceSurfaceFormatsKHR(): surface is VK_NULL_HANDLE and VK_GOOGLE_surfaceless_query is not enabled.");
8245 }
8246 return skip;
8247}
8248
8249bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfacePresentModesKHR(VkPhysicalDevice physicalDevice,
8250 VkSurfaceKHR surface,
8251 uint32_t *pPresentModeCount,
8252 VkPresentModeKHR *pPresentModes) const {
8253 bool skip = false;
8254 if (surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8255 skip |= LogError(
8256 physicalDevice, "VUID-vkGetPhysicalDeviceSurfacePresentModesKHR-surface-06524",
8257 "vkGetPhysicalDeviceSurfacePresentModesKHR: surface is VK_NULL_HANDLE and VK_GOOGLE_surfaceless_query is not enabled.");
8258 }
8259 return skip;
8260}
8261
8262bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfaceCapabilities2KHR(
8263 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
8264 VkSurfaceCapabilities2KHR *pSurfaceCapabilities) const {
8265 bool skip = false;
8266 if (pSurfaceInfo && pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8267 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceSurfaceCapabilities2KHR-pSurfaceInfo-06520",
8268 "vkGetPhysicalDeviceSurfaceCapabilities2KHR: pSurfaceInfo->surface is VK_NULL_HANDLE and "
8269 "VK_GOOGLE_surfaceless_query is not enabled.");
8270 }
8271 return skip;
8272}
8273
8274bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfaceFormats2KHR(
8275 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo, uint32_t *pSurfaceFormatCount,
8276 VkSurfaceFormat2KHR *pSurfaceFormats) const {
8277 bool skip = false;
8278 if (pSurfaceInfo && pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8279 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceSurfaceFormats2KHR-pSurfaceInfo-06521",
8280 "vkGetPhysicalDeviceSurfaceFormats2KHR: pSurfaceInfo->surface is VK_NULL_HANDLE and "
8281 "VK_GOOGLE_surfaceless_query is not enabled.");
8282 }
8283 return skip;
8284}
8285
8286#ifdef VK_USE_PLATFORM_WIN32_KHR
8287bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfacePresentModes2EXT(
8288 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo, uint32_t *pPresentModeCount,
8289 VkPresentModeKHR *pPresentModes) const {
8290 bool skip = false;
8291 if (pSurfaceInfo && pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8292 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceSurfacePresentModes2EXT-pSurfaceInfo-06521",
8293 "vkGetPhysicalDeviceSurfacePresentModes2EXT: pSurfaceInfo->surface is VK_NULL_HANDLE and "
8294 "VK_GOOGLE_surfaceless_query is not enabled.");
8295 }
8296 return skip;
8297}
8298#endif // VK_USE_PLATFORM_WIN32_KHR