blob: 2bb54006567f40cd5f11dd2119216b5809407b21 [file] [log] [blame]
Dave Houlton4d9b2f82018-10-24 18:21:06 -06001/* Copyright (c) 2015-2018 The Khronos Group Inc.
2 * Copyright (c) 2015-2018 Valve Corporation
3 * Copyright (c) 2015-2018 LunarG, Inc.
4 * Copyright (C) 2015-2018 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
22
23#include <limits.h>
24#include <math.h>
25#include <stdio.h>
26#include <stdlib.h>
27#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028
29#include <iostream>
30#include <string>
31#include <sstream>
32#include <unordered_map>
33#include <unordered_set>
34#include <vector>
35#include <mutex>
36
37#include "vk_loader_platform.h"
38#include "vulkan/vk_layer.h"
39#include "vk_layer_config.h"
40#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060041#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060042
Mark Lobodzinskid4950072017-08-01 13:02:20 -060043#include "vk_layer_data.h"
44#include "vk_layer_logging.h"
45#include "vk_layer_extension_utils.h"
46#include "vk_layer_utils.h"
Lenny Komow4c0da772018-07-03 10:17:21 -060047#include "vk_layer_dispatch_table.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060048
49#include "parameter_name.h"
50#include "parameter_validation.h"
51
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060052#if defined __ANDROID__
53#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060054#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060055#else
56#define LOGCONSOLE(...) \
57 { \
58 printf(__VA_ARGS__); \
59 printf("\n"); \
60 }
61#endif
62
Mark Lobodzinskid4950072017-08-01 13:02:20 -060063namespace parameter_validation {
64
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060065extern std::unordered_map<std::string, void *> custom_functions;
66
Mark Lobodzinskid4950072017-08-01 13:02:20 -060067extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
68 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
69extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
70extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
71 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
72extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
73extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
74 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
75extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
76 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
77 const VkAllocationCallbacks *pAllocator,
78 VkDebugReportCallbackEXT *pMsgCallback);
79extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
80 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070081extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
82 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
83 const VkAllocationCallbacks *pAllocator,
84 VkDebugUtilsMessengerEXT *pMessenger);
85extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
86 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060087extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
88 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010089extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
90 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Tobias Hectord942eb92018-10-22 15:18:56 +010091extern bool parameter_validation_vkCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
92 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +010093extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
94 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060095
96// TODO : This can be much smarter, using separate locks for separate global data
97std::mutex global_lock;
98
99static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
100std::unordered_map<void *, layer_data *> layer_data_map;
101std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
102
103void InitializeManualParameterValidationFunctionPointers(void);
104
105static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700106 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
107 "lunarg_parameter_validation");
108 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
109 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600110}
111
Mark Young6ba8abe2017-11-09 10:37:04 -0700112static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
113 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600114
115static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700116 "VK_LAYER_LUNARG_parameter_validation",
117 VK_LAYER_API_VERSION,
118 1,
119 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600120};
121
Tobias Hectord942eb92018-10-22 15:18:56 +0100122enum RenderPassCreateVersion { RENDER_PASS_VERSION_1 = 0, RENDER_PASS_VERSION_2 = 1 };
123
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600124static const int MaxParamCheckerStringLength = 256;
125
John Zulauf71968502017-10-26 13:51:15 -0600126template <typename T>
127static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
128 // Using only < for generality and || for early abort
129 return !((value < min) || (max < value));
130}
131
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600132static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600133 const std::string &vuid, const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600134 bool skip = false;
135
136 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
137
138 if (result == VK_STRING_ERROR_NONE) {
139 return skip;
140 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600141 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
142 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600143 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600144 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
145 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600146 }
147 return skip;
148}
149
150static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Dave Houlton13b65502018-05-23 13:35:24 -0600151 const char *parameter_name, const std::string &error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600152 bool skip = false;
153
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600154 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
155 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600156 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600157 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
158 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600159 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600160 skip |=
161 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600162 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600163 "%s: %s (= %" PRIu32
164 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
165 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600166 }
167
168 return skip;
169}
170
171static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
Dave Houlton13b65502018-05-23 13:35:24 -0600172 const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
173 const std::string &valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600174 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600175 if (queue_families) {
176 std::unordered_set<uint32_t> set;
177 for (uint32_t i = 0; i < queue_family_count; ++i) {
178 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
179
180 if (set.count(queue_families[i])) {
181 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600182 HandleToUint64(device_data->device), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600183 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
184 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600185 } else {
186 set.insert(queue_families[i]);
187 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600188 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600189 }
190 }
191 }
192 return skip;
193}
194
John Zulauf620755c2018-04-16 11:00:43 -0600195static bool validate_api_version(const instance_layer_data *instance_data, uint32_t api_version, uint32_t effective_api_version) {
196 bool skip = false;
197 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
198 if (api_version_nopatch != effective_api_version) {
199 if (api_version_nopatch < VK_API_VERSION_1_0) {
200 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600201 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600202 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
203 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
204 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
205 } else {
206 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600207 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600208 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
209 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
210 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
211 }
212 }
213 return skip;
214}
215
216template <typename ExtensionState>
Dave Houlton13b65502018-05-23 13:35:24 -0600217static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
218 const std::string &vuid, const char *extension_type, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -0600219 bool skip = false;
220 if (!extension_name) {
221 return skip; // Robust to invalid char *
222 }
223 auto info = ExtensionState::get_info(extension_name);
224
225 if (!info.state) {
226 return skip; // Unknown extensions cannot be checked so report OK
227 }
228
Pat Brown3eddb062018-09-05 14:07:37 -0400229 // Check against the required list in the info
John Zulauf620755c2018-04-16 11:00:43 -0600230 std::vector<const char *> missing;
231 for (const auto &req : info.requires) {
232 if (!(extensions.*(req.enabled))) {
233 missing.push_back(req.name);
234 }
235 }
236
237 // Report any missing requirements
238 if (missing.size()) {
239 std::string missing_joined_list = string_join(", ", missing);
240 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Pat Brown3eddb062018-09-05 14:07:37 -0400241 HandleToUint64(instance_data->instance), vuid, "Missing extension%s required by the %s extension %s: %s.",
242 ((missing.size() > 1) ? "s" : ""), extension_type, extension_name, missing_joined_list.c_str());
John Zulauf620755c2018-04-16 11:00:43 -0600243 }
244 return skip;
245}
246
247bool validate_instance_extensions(const instance_layer_data *instance_data, const VkInstanceCreateInfo *pCreateInfo) {
248 bool skip = false;
249 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Dave Houlton413a6782018-05-22 13:01:54 -0600250 skip |=
251 validate_extension_reqs(instance_data, instance_data->extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
252 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -0600253 }
254
255 return skip;
256}
257
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600258VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600259 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600260 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
261
262 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
263 assert(chain_info != nullptr);
264 assert(chain_info->u.pLayerInfo != nullptr);
265
266 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
267 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
268 if (fpCreateInstance == NULL) {
269 return VK_ERROR_INITIALIZATION_FAILED;
270 }
271
272 // Advance the link info for the next element on the chain
273 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
274
275 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
276
277 if (result == VK_SUCCESS) {
278 InitializeManualParameterValidationFunctionPointers();
279 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
280 assert(my_instance_data != nullptr);
281
282 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
283 my_instance_data->instance = *pInstance;
284 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700285 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
286 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600287
288 // Look for one or more debug report create info structures
289 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700290 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
291 &my_instance_data->tmp_messenger_create_infos,
292 &my_instance_data->tmp_debug_messengers)) {
293 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600294 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700295 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
296 my_instance_data->tmp_messenger_create_infos,
297 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600298 // Failure of setting up one or more of the callback.
299 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700300 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
301 my_instance_data->tmp_debug_messengers);
302 my_instance_data->num_tmp_debug_messengers = 0;
303 }
304 }
305 }
306 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
307 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
308 if (my_instance_data->num_tmp_report_callbacks > 0) {
309 // Setup the temporary callback(s) here to catch early issues:
310 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
311 my_instance_data->tmp_report_create_infos,
312 my_instance_data->tmp_report_callbacks)) {
313 // Failure of setting up one or more of the callback.
314 // Therefore, clean up and don't use those callbacks:
315 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
316 my_instance_data->tmp_report_callbacks);
317 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600318 }
319 }
320 }
321
322 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600323 // Note: From the spec--
324 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
325 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
326 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
327 ? pCreateInfo->pApplicationInfo->apiVersion
328 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600329
John Zulauf1909e6a2018-09-05 11:43:11 -0600330 my_instance_data->api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600331
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600332 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
333 // survive we can report the issue now.
John Zulauf1909e6a2018-09-05 11:43:11 -0600334 validate_api_version(my_instance_data, api_version, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600335 validate_instance_extensions(my_instance_data, pCreateInfo);
336
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600337 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
338
339 if (pCreateInfo->pApplicationInfo) {
340 if (pCreateInfo->pApplicationInfo->pApplicationName) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600341 validate_string(
342 my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pApplicationName",
343 "VUID-VkApplicationInfo-pApplicationName-parameter", pCreateInfo->pApplicationInfo->pApplicationName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600344 }
345
346 if (pCreateInfo->pApplicationInfo->pEngineName) {
347 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600348 "VUID-VkApplicationInfo-pEngineName-parameter", pCreateInfo->pApplicationInfo->pEngineName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600349 }
350 }
351
352 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700353 if (my_instance_data->num_tmp_debug_messengers > 0) {
354 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
355 my_instance_data->tmp_debug_messengers);
356 }
357 if (my_instance_data->num_tmp_report_callbacks > 0) {
358 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
359 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600360 }
361 }
362
363 return result;
364}
365
366VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
367 // Grab the key before the instance is destroyed.
368 dispatch_key key = get_dispatch_key(instance);
369 bool skip = false;
370 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
371
372 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
373 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700374 if (instance_data->num_tmp_debug_messengers > 0) {
375 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
376 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
377 callback_setup = true;
378 }
379 }
380 if (instance_data->num_tmp_report_callbacks > 0) {
381 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
382 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600383 callback_setup = true;
384 }
385 }
386
387 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
388
389 // Disable and cleanup the temporary callback(s):
390 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700391 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
392 instance_data->tmp_debug_messengers);
393 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
394 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600395 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700396 if (instance_data->num_tmp_debug_messengers > 0) {
397 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
398 instance_data->num_tmp_debug_messengers = 0;
399 }
400 if (instance_data->num_tmp_report_callbacks > 0) {
401 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
402 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600403 }
404
405 if (!skip) {
406 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
407
408 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700409 while (instance_data->logging_messenger.size() > 0) {
410 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
411 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
412 instance_data->logging_messenger.pop_back();
413 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600414 while (instance_data->logging_callback.size() > 0) {
415 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700416 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600417 instance_data->logging_callback.pop_back();
418 }
419
Mark Young6ba8abe2017-11-09 10:37:04 -0700420 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600421 }
422
423 FreeLayerDataPtr(key, instance_layer_data_map);
424}
425
426VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
427 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
428 const VkAllocationCallbacks *pAllocator,
429 VkDebugReportCallbackEXT *pMsgCallback) {
430 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
431 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
432
433 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
434 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
435 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700436 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
437 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
438 if (VK_SUCCESS != result) {
439 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
440 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600441 }
442 return result;
443}
444
445VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
446 const VkAllocationCallbacks *pAllocator) {
447 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
448 if (!skip) {
449 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
450 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700451 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
452 }
453}
454
455VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
456 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
457 const VkAllocationCallbacks *pAllocator,
458 VkDebugUtilsMessengerEXT *pMessenger) {
459 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
460 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
461
462 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
463 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
464 if (VK_SUCCESS == result) {
465 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
466 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
467 if (VK_SUCCESS != result) {
468 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
469 }
470 }
471 return result;
472}
473
474VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
475 const VkAllocationCallbacks *pAllocator) {
476 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
477 if (!skip) {
478 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
479 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
480 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600481 }
482}
483
John Zulauf620755c2018-04-16 11:00:43 -0600484template <typename ExtensionState>
485static bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
486 if (!extension_name) return false; // null strings specify nothing
487 auto info = ExtensionState::get_info(extension_name);
488 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
489 return state;
490}
491
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600492static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
John Zulauf620755c2018-04-16 11:00:43 -0600493 const VkDeviceCreateInfo *pCreateInfo, const DeviceExtensions &extensions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600494 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600495 bool maint1 = false;
496 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600497
498 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
499 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
500 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600501 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600502 }
503 }
504
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600505 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
John Zulauf620755c2018-04-16 11:00:43 -0600506 maint1 = extension_state_by_name(extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
507 negative_viewport = extension_state_by_name(extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
508
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600509 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
510 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600511 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600512 pCreateInfo->ppEnabledExtensionNames[i]);
Dave Houlton413a6782018-05-22 13:01:54 -0600513 skip |= validate_extension_reqs(instance_data, extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387",
514 "device", pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600515 }
516 }
517
518 if (maint1 && negative_viewport) {
519 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600520 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600521 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600522 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600523 }
524
525 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
526 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600527 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
528 if (features2) {
529 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
530 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600531 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600532 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
533 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600534 }
535 }
536
537 // Validate pCreateInfo->pQueueCreateInfos
538 if (pCreateInfo->pQueueCreateInfos) {
539 std::unordered_set<uint32_t> set;
540
541 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
542 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
543 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
544 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600545 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600546 "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600547 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700548 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600549 "index value.",
550 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600551 } else if (set.count(requested_queue_family)) {
552 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600553 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600554 "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600556 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
557 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600558 } else {
559 set.insert(requested_queue_family);
560 }
561
562 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
563 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
564 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
565 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
566 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600567 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600568 "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600569 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600570 "] (=%f) is not between 0 and 1 (inclusive).",
571 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600572 }
573 }
574 }
575 }
576 }
577
578 return skip;
579}
580
581VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
582 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
583 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
584
585 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
586 bool skip = false;
587 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
588 assert(my_instance_data != nullptr);
John Zulauf620755c2018-04-16 11:00:43 -0600589
590 // Query and save physical device limits for this device, needed for validation
591 VkPhysicalDeviceProperties device_properties = {};
592 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
593
John Zulauf1909e6a2018-09-05 11:43:11 -0600594 // Setup the validation tables based on the application API version from the instance and the capabilities of the device driver.
595 uint32_t effective_api_version = std::min(device_properties.apiVersion, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600596 DeviceExtensions extensions;
John Zulauf1909e6a2018-09-05 11:43:11 -0600597 uint32_t api_version = extensions.InitFromDeviceCreateInfo(&my_instance_data->extensions, effective_api_version, pCreateInfo);
John Zulauf620755c2018-04-16 11:00:43 -0600598
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600599 std::unique_lock<std::mutex> lock(global_lock);
600
601 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
602
John Zulauf620755c2018-04-16 11:00:43 -0600603 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo, extensions);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600604
605 if (!skip) {
606 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
607 assert(chain_info != nullptr);
608 assert(chain_info->u.pLayerInfo != nullptr);
609
610 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
611 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
612 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
613 if (fpCreateDevice == NULL) {
614 return VK_ERROR_INITIALIZATION_FAILED;
615 }
616
617 // Advance the link info for the next element on the chain
618 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
619
620 lock.unlock();
621
622 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
623
624 lock.lock();
625
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600626 if (result == VK_SUCCESS) {
627 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
628 assert(my_device_data != nullptr);
629
Mark Young6ba8abe2017-11-09 10:37:04 -0700630 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
John Zulauf9b777302018-10-08 11:15:51 -0600631 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600632
John Zulauf620755c2018-04-16 11:00:43 -0600633 my_device_data->api_version = api_version;
634 my_device_data->extensions = extensions;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600635
636 // Store createdevice data
637 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
638 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
639 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
640 pCreateInfo->pQueueCreateInfos[i].queueCount));
641 }
642 }
643
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600644 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
645 my_device_data->physical_device = physicalDevice;
646 my_device_data->device = *pDevice;
647
Jeff Bolz5d2b7432018-09-06 10:32:36 -0500648 if (my_device_data->extensions.vk_nv_shading_rate_image) {
649 // Get the needed shading rate image limits
650 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
651 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
652 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
653 my_device_data->phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
654 }
655
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500656 if (my_device_data->extensions.vk_nv_mesh_shader) {
657 // Get the needed mesh shader limits
658 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
659 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
660 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
661 my_device_data->phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
662 }
663
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600664 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600665 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
666 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
667 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600668 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
669 if (features2) {
670 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600671 }
672 }
673 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700674 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600675 } else {
676 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
677 }
678 }
679 }
680
681 return result;
682}
683
684VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
685 dispatch_key key = get_dispatch_key(device);
686 bool skip = false;
687 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
688 {
689 std::unique_lock<std::mutex> lock(global_lock);
690 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
691 }
692
693 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700694 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600695 device_data->dispatch_table.DestroyDevice(device, pAllocator);
696 }
697 FreeLayerDataPtr(key, layer_data_map);
698}
699
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600700bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
701 bool skip = false;
702 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
703
Dave Houlton413a6782018-05-22 13:01:54 -0600704 skip |= ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex",
705 "VUID-vkGetDeviceQueue-queueFamilyIndex-00384");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600706 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
707 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
708 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600709 HandleToUint64(device), "VUID-vkGetDeviceQueue-queueIndex-00385",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600710 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700711 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600712 ") when the device was created (i.e. is not less than %" PRIu32 ").",
713 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600714 }
715 return skip;
716}
717
718VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
719 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
720 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
721 bool skip = false;
722 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
723 std::unique_lock<std::mutex> lock(global_lock);
724
725 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
Dave Houlton341c0052018-06-21 15:00:45 -0600726 "pCreateInfo->queueFamilyIndex", "VUID-vkCreateCommandPool-queueFamilyIndex-01937");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600727
728 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
729
730 lock.unlock();
731 if (!skip) {
732 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
733 }
734 return result;
735}
736
737VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
738 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
739 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
740 bool skip = false;
741 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
742
743 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
744
745 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
746 if (pCreateInfo != nullptr) {
747 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
748 // VkQueryPipelineStatisticFlagBits values
749 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
750 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
751 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600752 "VUID-VkQueryPoolCreateInfo-queryType-00792",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700753 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
754 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600755 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600756 }
757 }
758 if (!skip) {
759 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
760 }
761 return result;
762}
763
Tobias Hectord942eb92018-10-22 15:18:56 +0100764template <typename T>
765static void RecordRenderPass(layer_data *device_data, VkRenderPass renderPass, const T *pCreateInfo) {
766 auto &renderpass_state = device_data->renderpasses_states[renderPass];
767
768 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
769 bool uses_color = false;
770 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
771 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
772
773 bool uses_depthstencil = false;
774 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
775 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
776 uses_depthstencil = true;
777
778 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
779 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
780 }
781}
782
Petr Krause91f7a12017-12-14 20:57:36 +0100783VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
784 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
785 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
786 bool skip = false;
787 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
788
789 {
790 std::unique_lock<std::mutex> lock(global_lock);
791 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
792
Dave Houltonb3bbec72018-01-17 10:13:33 -0700793 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
794 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100795 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
796 if (custom_func != nullptr) {
797 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
798 }
799 }
800
801 if (!skip) {
802 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
803
804 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
805 if (result == VK_SUCCESS) {
806 std::unique_lock<std::mutex> lock(global_lock);
Tobias Hectord942eb92018-10-22 15:18:56 +0100807 RecordRenderPass(device_data, *pRenderPass, pCreateInfo);
808 }
809 }
810 return result;
811}
Petr Krause91f7a12017-12-14 20:57:36 +0100812
Tobias Hectord942eb92018-10-22 15:18:56 +0100813VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
814 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
815 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
816 bool skip = false;
817 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
Petr Krause91f7a12017-12-14 20:57:36 +0100818
Tobias Hectord942eb92018-10-22 15:18:56 +0100819 {
820 std::unique_lock<std::mutex> lock(global_lock);
821 skip |= parameter_validation_vkCreateRenderPass2KHR(device, pCreateInfo, pAllocator, pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100822
Tobias Hectord942eb92018-10-22 15:18:56 +0100823 typedef bool (*PFN_manual_vkCreateRenderPass2KHR)(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
824 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
825 PFN_manual_vkCreateRenderPass2KHR custom_func =
826 (PFN_manual_vkCreateRenderPass2KHR)custom_functions["vkCreateRenderPass2KHR"];
827 if (custom_func != nullptr) {
828 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
829 }
830 }
831
832 if (!skip) {
833 result = device_data->dispatch_table.CreateRenderPass2KHR(device, pCreateInfo, pAllocator, pRenderPass);
834
835 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
836 if (result == VK_SUCCESS) {
837 std::unique_lock<std::mutex> lock(global_lock);
838 RecordRenderPass(device_data, *pRenderPass, pCreateInfo);
Petr Krause91f7a12017-12-14 20:57:36 +0100839 }
840 }
841 return result;
842}
843
844VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
845 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
846 bool skip = false;
847
848 {
849 std::unique_lock<std::mutex> lock(global_lock);
850 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
851
Dave Houltonb3bbec72018-01-17 10:13:33 -0700852 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
853 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100854 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
855 if (custom_func != nullptr) {
856 skip |= custom_func(device, renderPass, pAllocator);
857 }
858 }
859
860 if (!skip) {
861 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
862
863 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
864 {
865 std::unique_lock<std::mutex> lock(global_lock);
866 device_data->renderpasses_states.erase(renderPass);
867 }
868 }
869}
870
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600871bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
872 VkBuffer *pBuffer) {
873 bool skip = false;
874 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
875 debug_report_data *report_data = device_data->report_data;
876
Mark Lobodzinski88529492018-04-01 10:38:15 -0600877 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100878
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600879 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600880 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600881
882 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
883 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
884 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
885 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600886 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600887 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600888 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600889 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600890 }
891
892 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
893 // queueFamilyIndexCount uint32_t values
894 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600895 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600896 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600897 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
898 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600899 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600900 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600901 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -0600902 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
903 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600904 }
905 }
906
907 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
908 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
909 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
910 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600911 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600912 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600913 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600914 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600915 }
916 }
917
918 return skip;
919}
920
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600921bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
922 VkImage *pImage) {
923 bool skip = false;
924 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
925 debug_report_data *report_data = device_data->report_data;
926
Mark Lobodzinski88529492018-04-01 10:38:15 -0600927 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100928
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600929 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600930 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
931 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
932 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
933 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600934 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600935 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600936 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600937 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600938 }
939
940 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
941 // queueFamilyIndexCount uint32_t values
942 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600943 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600944 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600945 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
946 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600947 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600948 } else {
Dave Houlton413a6782018-05-22 13:01:54 -0600949 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
950 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
951 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600952 }
953 }
954
Dave Houlton413a6782018-05-22 13:01:54 -0600955 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
956 "VUID-VkImageCreateInfo-extent-00944", log_misc);
957 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
958 "VUID-VkImageCreateInfo-extent-00945", log_misc);
959 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
960 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600961
Dave Houlton413a6782018-05-22 13:01:54 -0600962 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
963 log_misc);
964 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
965 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600966
Dave Houlton130c0212018-01-29 13:39:56 -0700967 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700968 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
969 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
970 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600971 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
972 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600973 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
974 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700975 }
976
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600977 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100978 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
979 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600980 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600981 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700982 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600983 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600984 }
985
986 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100987 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
988 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600989 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600990 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600991 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
992 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
993 ") are not equal.",
994 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100995 }
996
997 if (pCreateInfo->arrayLayers < 6) {
998 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600999 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +01001000 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001001 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
1002 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +01001003 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001004 }
1005
1006 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001007 skip |=
1008 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001009 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001010 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001011 }
1012 }
1013
Dave Houlton130c0212018-01-29 13:39:56 -07001014 // 3D image may have only 1 layer
1015 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001016 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001017 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001018 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -07001019 }
1020
1021 // If multi-sample, validate type, usage, tiling and mip levels.
1022 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1023 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -06001024 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001025 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Shannon McPhersona886c2a2018-10-12 14:38:20 -06001026 "VUID-VkImageCreateInfo-samples-02257",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001027 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -07001028 }
1029
1030 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
1031 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
1032 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1033 // At least one of the legal attachment bits must be set
1034 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001035 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001036 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001037 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001038 }
1039 // No flags other than the legal attachment bits may be set
1040 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1041 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001042 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001043 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001044 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001045 }
1046 }
1047
Jeff Bolzef40fec2018-09-01 22:04:34 -05001048 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001049 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001050 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -06001051 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
1052 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001053 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -06001054 skip |=
1055 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1056 "VUID-VkImageCreateInfo-mipLevels-00958",
1057 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
1058 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001059 }
1060
Mark Lobodzinski69259c52018-09-18 15:14:58 -06001061 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
1062 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
1063 "VUID-VkImageCreateInfo-flags-00950",
1064 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
1065 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
1066 }
1067
Petr Krausb6f97802018-03-13 12:31:39 +01001068 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
1069 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001070 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +01001071 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001072 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +01001073 }
1074
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001075 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
1076 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
1077 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
1078 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001079 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001080 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001081 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001082 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001083 }
1084
1085 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
1086 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
1087 // Linear tiling is unsupported
1088 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -06001089 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1090 kVUID_PVError_InvalidUsage,
1091 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
1092 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001093 }
1094
1095 // Sparse 1D image isn't valid
1096 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001097 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001098 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001099 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001100 }
1101
1102 // Sparse 2D image when device doesn't support it
1103 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1104 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001105 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001106 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001107 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001108 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001109 }
1110
1111 // Sparse 3D image when device doesn't support it
1112 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1113 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001114 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001115 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001116 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001117 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001118 }
1119
1120 // Multi-sample 2D image when device doesn't support it
1121 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1122 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1123 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001124 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001125 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001126 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001127 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001128 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1129 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001130 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001131 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001132 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001133 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001134 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1135 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001136 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001137 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001138 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001139 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001140 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1141 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001142 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001143 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001144 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001145 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001146 }
1147 }
1148 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001149
Jeff Bolz9af91c52018-09-01 21:53:57 -05001150 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
1151 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1152 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1153 "VUID-VkImageCreateInfo-imageType-02082",
1154 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1155 "imageType must be VK_IMAGE_TYPE_2D.");
1156 }
1157 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1158 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1159 "VUID-VkImageCreateInfo-samples-02083",
1160 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1161 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1162 }
1163 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1164 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1165 "VUID-VkImageCreateInfo-tiling-02084",
1166 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1167 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1168 }
1169 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001170
1171 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001172 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001173 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1174 "VUID-VkImageCreateInfo-flags-02050",
1175 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1176 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
1177 }
1178
Dave Houlton142c4cb2018-10-17 15:04:41 -06001179 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001180 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1181 "VUID-VkImageCreateInfo-flags-02051",
1182 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1183 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
1184 "not be a depth/stencil format.");
1185 }
1186
Dave Houlton142c4cb2018-10-17 15:04:41 -06001187 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001188 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1189 "VUID-VkImageCreateInfo-flags-02052",
1190 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1191 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
1192 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001193 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001194 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001195 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1196 "VUID-VkImageCreateInfo-flags-02053",
1197 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1198 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
1199 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -05001200 }
1201 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001202 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001203
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001204 return skip;
1205}
1206
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001207bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1208 VkImageView *pView) {
1209 bool skip = false;
1210 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1211 debug_report_data *report_data = device_data->report_data;
1212
1213 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -06001214 // Validate chained VkImageViewUsageCreateInfo struct, if present
1215 if (nullptr != pCreateInfo->pNext) {
1216 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1217 if (chained_ivuci_struct) {
1218 if (0 == chained_ivuci_struct->usage) {
1219 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001220 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -06001221 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001222 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1223 std::stringstream ss;
1224 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1225 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1226 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001227 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -06001228 }
1229 }
1230 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001231 }
1232 return skip;
1233}
1234
Petr Krausb3fcdb42018-01-09 22:09:09 +01001235bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1236 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1237 bool skip = false;
1238 debug_report_data *report_data = device_data->report_data;
1239
1240 // Note: for numerical correctness
1241 // - float comparisons should expect NaN (comparison always false).
1242 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1243
1244 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001245 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001246 if (v1_f <= 0.0f) return true;
1247
1248 float intpart;
1249 const float fract = modff(v1_f, &intpart);
1250
1251 assert(std::numeric_limits<float>::radix == 2);
1252 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1253 if (intpart >= u32_max_plus1) return false;
1254
1255 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1256 if (v1_u32 < v2_u32)
1257 return true;
1258 else if (v1_u32 == v2_u32 && fract == 0.0f)
1259 return true;
1260 else
1261 return false;
1262 };
1263
1264 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1265 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1266 return (v1_f <= v2_f);
1267 };
1268
1269 // width
1270 bool width_healthy = true;
1271 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1272
1273 if (!(viewport.width > 0.0f)) {
1274 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001275 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001276 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001277 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1278 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001279 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001280 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1281 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001282 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001283 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001284 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001285 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1286 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001287 }
1288
1289 // height
1290 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001291 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1292 device_data->extensions.vk_khr_maintenance1 ||
1293 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001294 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1295
1296 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1297 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001298 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001299 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001300 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1301 height_healthy = false;
1302
Dave Houlton413a6782018-05-22 13:01:54 -06001303 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001304 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1305 ").",
1306 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001307 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1308 height_healthy = false;
1309
1310 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001311 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001312 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001313 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1314 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001315 }
1316
1317 // x
1318 bool x_healthy = true;
1319 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1320 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001321 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001322 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1323 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001324 }
1325
1326 // x + width
1327 if (x_healthy && width_healthy) {
1328 const float right_bound = viewport.x + viewport.width;
1329 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001330 skip |=
Dave Houlton413a6782018-05-22 13:01:54 -06001331 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001332 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1333 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1334 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001335 }
1336 }
1337
1338 // y
1339 bool y_healthy = true;
1340 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1341 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001342 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001343 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1344 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001345 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1346 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001347 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001348 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1349 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001350 }
1351
1352 // y + height
1353 if (y_healthy && height_healthy) {
1354 const float boundary = viewport.y + viewport.height;
1355
1356 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -06001357 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001358 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1359 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1360 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001361 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1362 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001363 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001364 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1365 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001366 }
1367 }
1368
1369 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1370 // minDepth
1371 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001372 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001373
Petr Krausb3fcdb42018-01-09 22:09:09 +01001374 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001375 "[0.0, 1.0] range.",
1376 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001377 }
1378
1379 // maxDepth
1380 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001381 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001382
Petr Krausb3fcdb42018-01-09 22:09:09 +01001383 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001384 "[0.0, 1.0] range.",
1385 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001386 }
1387 }
1388
1389 return skip;
1390}
1391
Dave Houlton142c4cb2018-10-17 15:04:41 -06001392struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001393 VkShadingRatePaletteEntryNV shadingRate;
1394 uint32_t width;
1395 uint32_t height;
1396};
1397
1398// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -06001399static SampleOrderInfo sampleOrderInfos[] = {
1400 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1401 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1402 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1403 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1404 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1405 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001406};
1407
Dave Houlton142c4cb2018-10-17 15:04:41 -06001408bool ValidateCoarseSampleOrderCustomNV(layer_data *device_data, const VkCoarseSampleOrderCustomNV *order) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001409 bool skip = false;
1410 debug_report_data *report_data = device_data->report_data;
1411
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001412 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001413 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001414 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001415 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001416 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001417 break;
1418 }
1419 }
1420
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001421 if (sampleOrderInfo == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001422 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1423 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1424 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1425 "that generates fragments with more than one pixel.");
1426 return skip;
1427 }
1428
Dave Houlton142c4cb2018-10-17 15:04:41 -06001429 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Jeff Bolz9af91c52018-09-01 21:53:57 -05001430 !(order->sampleCount & device_data->device_limits.framebufferNoAttachmentsSampleCounts)) {
1431 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1432 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001433 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1434 ") must "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001435 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1436 "is set in framebufferNoAttachmentsSampleCounts.",
1437 order->sampleCount);
1438 }
1439
Jeff Bolz9af91c52018-09-01 21:53:57 -05001440 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
1441 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1442 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001443 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1444 ") must "
1445 "be equal to the product of sampleCount (=%" PRIu32
1446 "), the fragment width for shadingRate "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001447 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1448 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
1449 }
1450
Jeff Bolz5d2b7432018-09-06 10:32:36 -05001451 if (order->sampleLocationCount > device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001452 skip |= log_msg(
1453 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1454 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
1455 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1456 ") must "
1457 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
1458 order->sampleLocationCount, device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001459 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001460
1461 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001462 // the first width*height*sampleCount bits to all be set. Note: There is no
1463 // guarantee that 64 bits is enough, but practically it's unlikely for an
1464 // implementation to support more than 32 bits for samplemask.
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001465 assert(device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001466 uint64_t sampleLocationsMask = 0;
1467 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1468 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1469 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
1470 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1471 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1472 "pixelX must be less than the width (in pixels) of the fragment.");
1473 }
1474 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
1475 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1476 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1477 "pixelY must be less than the height (in pixels) of the fragment.");
1478 }
1479 if (sampleLoc->sample >= order->sampleCount) {
1480 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1481 "VUID-VkCoarseSampleLocationNV-sample-02080",
1482 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
1483 }
1484 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1485 sampleLocationsMask |= 1ULL << idx;
1486 }
1487
1488 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1489 if (sampleLocationsMask != expectedMask) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001490 skip |= log_msg(
1491 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1492 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
1493 "The array pSampleLocations must contain exactly one entry for "
1494 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001495 }
1496
1497 return skip;
1498}
1499
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001500bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1501 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1502 VkPipeline *pPipelines) {
1503 bool skip = false;
1504 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1505 debug_report_data *report_data = device_data->report_data;
1506
1507 if (pCreateInfos != nullptr) {
1508 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001509 bool has_dynamic_viewport = false;
1510 bool has_dynamic_scissor = false;
1511 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001512 bool has_dynamic_viewport_w_scaling_nv = false;
1513 bool has_dynamic_discard_rectangle_ext = false;
1514 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001515 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001516 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001517 if (pCreateInfos[i].pDynamicState != nullptr) {
1518 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1519 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1520 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1521 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1522 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1523 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001524 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1525 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1526 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001527 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Dave Houlton142c4cb2018-10-17 15:04:41 -06001528 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV)
1529 has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001530 }
1531 }
1532
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001533 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1534 if (pCreateInfos[i].pVertexInputState != nullptr) {
1535 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001536
1537 if (vertex_input_state->vertexBindingDescriptionCount > device_data->device_limits.maxVertexInputBindings) {
1538 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1539 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1540 "vkCreateGraphicsPipelines: pararameter "
1541 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1542 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1543 i, vertex_input_state->vertexBindingDescriptionCount,
1544 device_data->device_limits.maxVertexInputBindings);
1545 }
1546
1547 if (vertex_input_state->vertexAttributeDescriptionCount > device_data->device_limits.maxVertexInputAttributes) {
1548 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1549 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1550 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +02001551 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +02001552 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1553 i, vertex_input_state->vertexBindingDescriptionCount,
1554 device_data->device_limits.maxVertexInputAttributes);
1555 }
1556
1557 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001558 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1559 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001560 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1561 if (binding_it != vertex_bindings.cend()) {
1562 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1563 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1564 "vkCreateGraphicsPipelines: parameter "
1565 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1566 "(%" PRIu32 ") is not distinct.",
1567 i, d, vertex_bind_desc.binding);
1568 }
1569 vertex_bindings.insert(vertex_bind_desc.binding);
1570
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001571 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1572 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001573 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001574 "vkCreateGraphicsPipelines: parameter "
1575 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001576 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1577 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001578 }
1579
1580 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1581 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001582 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001583 "vkCreateGraphicsPipelines: parameter "
1584 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001585 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1586 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001587 }
1588 }
1589
Peter Kohautc7d9d392018-07-15 00:34:07 +02001590 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001591 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1592 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001593 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1594 if (location_it != attribute_locations.cend()) {
1595 skip |= log_msg(
1596 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1597 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
1598 "vkCreateGraphicsPipelines: parameter "
1599 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1600 i, d, vertex_attrib_desc.location);
1601 }
1602 attribute_locations.insert(vertex_attrib_desc.location);
1603
1604 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1605 if (binding_it == vertex_bindings.cend()) {
1606 skip |= log_msg(
1607 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1608 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
1609 "vkCreateGraphicsPipelines: parameter "
1610 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1611 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1612 i, d, vertex_attrib_desc.binding, i);
1613 }
1614
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001615 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1616 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001617 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001618 "vkCreateGraphicsPipelines: parameter "
1619 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001620 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1621 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001622 }
1623
1624 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1625 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001626 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001627 "vkCreateGraphicsPipelines: parameter "
1628 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001629 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1630 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001631 }
1632
1633 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001634 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001635 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001636 "vkCreateGraphicsPipelines: parameter "
1637 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1638 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1639 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001640 }
1641 }
1642 }
1643
1644 if (pCreateInfos[i].pStages != nullptr) {
1645 bool has_control = false;
1646 bool has_eval = false;
1647
1648 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1649 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1650 has_control = true;
1651 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1652 has_eval = true;
1653 }
1654 }
1655
1656 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1657 if (has_control && has_eval) {
1658 if (pCreateInfos[i].pTessellationState == nullptr) {
1659 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001660 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001661 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1662 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001663 "pCreateInfos[%d].pTessellationState must not be NULL.",
1664 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001665 } else {
1666 skip |= validate_struct_pnext(
1667 report_data, "vkCreateGraphicsPipelines",
1668 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001669 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion,
1670 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001671
1672 skip |= validate_reserved_flags(
1673 report_data, "vkCreateGraphicsPipelines",
1674 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001675 pCreateInfos[i].pTessellationState->flags,
1676 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001677
1678 if (pCreateInfos[i].pTessellationState->sType !=
1679 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1680 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001681 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001682 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001683 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1684 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001685 }
1686
1687 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1688 pCreateInfos[i].pTessellationState->patchControlPoints >
1689 device_data->device_limits.maxTessellationPatchSize) {
1690 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001691 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001692 "vkCreateGraphicsPipelines: invalid parameter "
1693 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001694 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001695 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001696 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001697 }
1698 }
1699 }
1700 }
1701
1702 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1703 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1704 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1705 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001706 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001707 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001708 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1709 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001710 "].pViewportState (=NULL) is not a valid pointer.",
1711 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001712 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001713 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1714
1715 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1716 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001717 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001718 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001719 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1720 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001721 }
1722
Petr Krausa6103552017-11-16 21:21:58 +01001723 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1724 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001725 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1726 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001727 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1728 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001729 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001730 skip |= validate_struct_pnext(
1731 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001732 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001733 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001734 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1735 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001736 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001737 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1738 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001739
1740 skip |= validate_reserved_flags(
1741 report_data, "vkCreateGraphicsPipelines",
1742 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001743 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001744
Dave Houlton142c4cb2018-10-17 15:04:41 -06001745 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1746 pCreateInfos[i].pViewportState->pNext);
1747 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1748 pCreateInfos[i].pViewportState->pNext);
1749 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1750 pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001751
Petr Krausa6103552017-11-16 21:21:58 +01001752 if (!device_data->physical_device_features.multiViewport) {
1753 if (viewport_state.viewportCount != 1) {
1754 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001755 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001756 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1757 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001758 ") is not 1.",
1759 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001760 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001761
Petr Krausa6103552017-11-16 21:21:58 +01001762 if (viewport_state.scissorCount != 1) {
1763 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001764 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001765 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1766 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001767 ") is not 1.",
1768 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001769 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001770
Dave Houlton142c4cb2018-10-17 15:04:41 -06001771 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1772 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1773 skip |=
1774 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1775 VK_NULL_HANDLE,
1776 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1777 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1778 "disabled, but pCreateInfos[%" PRIu32
1779 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1780 ") is not 1.",
1781 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001782 }
1783
Jeff Bolz9af91c52018-09-01 21:53:57 -05001784 if (shading_rate_image_struct &&
1785 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1786 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton142c4cb2018-10-17 15:04:41 -06001787 VK_NULL_HANDLE,
1788 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001789 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Dave Houlton142c4cb2018-10-17 15:04:41 -06001790 "disabled, but pCreateInfos[%" PRIu32
1791 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001792 ") is neither 0 nor 1.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001793 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001794 }
1795
Petr Krausa6103552017-11-16 21:21:58 +01001796 } else { // multiViewport enabled
1797 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001798 skip |= log_msg(
1799 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001800 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001801 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001802 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1803 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001804 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001805 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1806 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001807 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1808 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001809 }
Petr Krausa6103552017-11-16 21:21:58 +01001810
1811 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001812 skip |= log_msg(
1813 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001814 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001815 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001816 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1817 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001818 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001819 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1820 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001821 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1822 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001823 }
1824 }
1825
Jeff Bolz3e71f782018-08-29 23:15:45 -05001826 if (exclusive_scissor_struct &&
1827 exclusive_scissor_struct->exclusiveScissorCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001828 skip |= log_msg(
1829 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1830 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1831 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1832 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1833 i, exclusive_scissor_struct->exclusiveScissorCount, device_data->device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001834 }
1835
Jeff Bolz9af91c52018-09-01 21:53:57 -05001836 if (shading_rate_image_struct &&
1837 shading_rate_image_struct->viewportCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001838 skip |=
1839 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1840 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1841 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1842 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1843 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1844 i, shading_rate_image_struct->viewportCount, device_data->device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001845 }
1846
Petr Krausa6103552017-11-16 21:21:58 +01001847 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001848 skip |=
1849 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001850 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001851 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1852 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1853 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001854 }
1855
Dave Houlton142c4cb2018-10-17 15:04:41 -06001856 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001857 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001858 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1859 VK_NULL_HANDLE,
1860 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1861 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1862 ") must be zero or identical to pCreateInfos[%" PRIu32
1863 "].pViewportState->viewportCount (=%" PRIu32 ").",
1864 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001865 }
1866
Dave Houlton142c4cb2018-10-17 15:04:41 -06001867 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001868 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001869 skip |= log_msg(
1870 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1871 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1872 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1873 "] "
1874 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1875 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1876 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001877 }
1878
Petr Krausa6103552017-11-16 21:21:58 +01001879 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1880 skip |= log_msg(
1881 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001882 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001883 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1884 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001885 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1886 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001887 }
1888
1889 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1890 skip |= log_msg(
1891 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001892 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001893 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1894 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001895 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1896 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001897 }
1898
Jeff Bolz3e71f782018-08-29 23:15:45 -05001899 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001900 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1901 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1902 skip |=
1903 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1904 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1905 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1906 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1907 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1908 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001909 }
1910
Jeff Bolz9af91c52018-09-01 21:53:57 -05001911 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001912 shading_rate_image_struct->viewportCount > 0 &&
1913 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001914 skip |= log_msg(
1915 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1916 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1917 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001918 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1919 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001920 i, i);
1921 }
1922
Petr Krausb3fcdb42018-01-09 22:09:09 +01001923 // validate the VkViewports
1924 if (!has_dynamic_viewport && viewport_state.pViewports) {
1925 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1926 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1927 const char fn_name[] = "vkCreateGraphicsPipelines";
1928 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1929 std::to_string(viewport_i) + "]";
1930 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1931 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1932 }
1933 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001934
1935 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1936 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001937 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001938 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001939 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001940 "VK_NV_clip_space_w_scaling extension is not enabled.",
1941 i);
1942 }
1943
1944 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1945 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001946 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001947 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001948 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001949 "VK_EXT_discard_rectangles extension is not enabled.",
1950 i);
1951 }
1952
1953 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1954 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001955 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001956 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001957 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001958 "VK_EXT_sample_locations extension is not enabled.",
1959 i);
1960 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001961
1962 if (has_dynamic_exclusive_scissor_nv && !device_data->extensions.vk_nv_scissor_exclusive) {
1963 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1964 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1965 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1966 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1967 "VK_NV_scissor_exclusive extension is not enabled.",
1968 i);
1969 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001970
1971 if (coarse_sample_order_struct &&
1972 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1973 coarse_sample_order_struct->customSampleOrderCount != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001974 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1975 VK_NULL_HANDLE,
1976 "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1977 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1978 "] "
1979 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1980 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1981 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001982 }
1983
1984 if (coarse_sample_order_struct) {
1985 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001986 skip |= ValidateCoarseSampleOrderCustomNV(device_data,
1987 &coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001988 }
1989 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001990 }
1991
1992 if (pCreateInfos[i].pMultisampleState == nullptr) {
1993 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001994 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001995 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001996 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1997 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001998 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001999 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
2000 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2001 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002002 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002003 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002004 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002005 skip |= validate_struct_pnext(
2006 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002007 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
2008 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06002009 "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002010
2011 skip |= validate_reserved_flags(
2012 report_data, "vkCreateGraphicsPipelines",
2013 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002014 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002015
2016 skip |= validate_bool32(
2017 report_data, "vkCreateGraphicsPipelines",
2018 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2019 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2020
2021 skip |= validate_array(
2022 report_data, "vkCreateGraphicsPipelines",
2023 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2024 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002025 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002026 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002027
2028 skip |= validate_bool32(
2029 report_data, "vkCreateGraphicsPipelines",
2030 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2031 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2032
2033 skip |= validate_bool32(
2034 report_data, "vkCreateGraphicsPipelines",
2035 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2036 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2037
2038 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
2039 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002040 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002041 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2042 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2043 i);
2044 }
John Zulauf7acac592017-11-06 11:15:53 -07002045 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
2046 if (!device_data->physical_device_features.sampleRateShading) {
2047 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002048 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07002049 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002050 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2051 i);
John Zulauf7acac592017-11-06 11:15:53 -07002052 }
2053 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2054 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2055 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
2056 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002057 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002058 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002059 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002060 }
2061 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002062 }
2063
Petr Krause91f7a12017-12-14 20:57:36 +01002064 bool uses_color_attachment = false;
2065 bool uses_depthstencil_attachment = false;
2066 {
2067 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
2068 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
2069 const auto &subpasses_uses = subpasses_uses_it->second;
2070 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2071 uses_color_attachment = true;
2072 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2073 uses_depthstencil_attachment = true;
2074 }
2075 }
2076
2077 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002078 skip |= validate_struct_pnext(
2079 report_data, "vkCreateGraphicsPipelines",
2080 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002081 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion,
2082 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002083
2084 skip |= validate_reserved_flags(
2085 report_data, "vkCreateGraphicsPipelines",
2086 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002087 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002088
2089 skip |= validate_bool32(
2090 report_data, "vkCreateGraphicsPipelines",
2091 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2092 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2093
2094 skip |= validate_bool32(
2095 report_data, "vkCreateGraphicsPipelines",
2096 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2097 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2098
2099 skip |= validate_ranged_enum(
2100 report_data, "vkCreateGraphicsPipelines",
2101 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2102 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002103 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002104
2105 skip |= validate_bool32(
2106 report_data, "vkCreateGraphicsPipelines",
2107 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2108 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2109
2110 skip |= validate_bool32(
2111 report_data, "vkCreateGraphicsPipelines",
2112 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2113 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2114
2115 skip |= validate_ranged_enum(
2116 report_data, "vkCreateGraphicsPipelines",
2117 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2118 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002119 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002120
2121 skip |= validate_ranged_enum(
2122 report_data, "vkCreateGraphicsPipelines",
2123 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2124 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002125 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002126
2127 skip |= validate_ranged_enum(
2128 report_data, "vkCreateGraphicsPipelines",
2129 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2130 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002131 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002132
2133 skip |= validate_ranged_enum(
2134 report_data, "vkCreateGraphicsPipelines",
2135 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2136 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002137 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002138
2139 skip |= validate_ranged_enum(
2140 report_data, "vkCreateGraphicsPipelines",
2141 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2142 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002143 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002144
2145 skip |= validate_ranged_enum(
2146 report_data, "vkCreateGraphicsPipelines",
2147 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2148 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002149 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002150
2151 skip |= validate_ranged_enum(
2152 report_data, "vkCreateGraphicsPipelines",
2153 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2154 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002155 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002156
2157 skip |= validate_ranged_enum(
2158 report_data, "vkCreateGraphicsPipelines",
2159 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2160 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002161 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002162
2163 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
2164 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002165 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002166 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2167 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2168 i);
2169 }
2170 }
2171
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002172 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2173 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2174
Petr Krause91f7a12017-12-14 20:57:36 +01002175 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002176 skip |= validate_struct_pnext(
2177 report_data, "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002178 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2179 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2180 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
2181 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06002182 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002183
2184 skip |= validate_reserved_flags(
2185 report_data, "vkCreateGraphicsPipelines",
2186 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002187 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002188
2189 skip |= validate_bool32(
2190 report_data, "vkCreateGraphicsPipelines",
2191 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2192 pCreateInfos[i].pColorBlendState->logicOpEnable);
2193
2194 skip |= validate_array(
2195 report_data, "vkCreateGraphicsPipelines",
2196 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2197 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002198 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002199 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002200
2201 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2202 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2203 ++attachmentIndex) {
2204 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
2205 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2206 ParameterName::IndexVector{i, attachmentIndex}),
2207 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2208
2209 skip |= validate_ranged_enum(
2210 report_data, "vkCreateGraphicsPipelines",
2211 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2212 ParameterName::IndexVector{i, attachmentIndex}),
2213 "VkBlendFactor", AllVkBlendFactorEnums,
2214 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002215 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002216
2217 skip |= validate_ranged_enum(
2218 report_data, "vkCreateGraphicsPipelines",
2219 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2220 ParameterName::IndexVector{i, attachmentIndex}),
2221 "VkBlendFactor", AllVkBlendFactorEnums,
2222 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002223 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002224
2225 skip |= validate_ranged_enum(
2226 report_data, "vkCreateGraphicsPipelines",
2227 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2228 ParameterName::IndexVector{i, attachmentIndex}),
2229 "VkBlendOp", AllVkBlendOpEnums,
2230 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002231 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002232
2233 skip |= validate_ranged_enum(
2234 report_data, "vkCreateGraphicsPipelines",
2235 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2236 ParameterName::IndexVector{i, attachmentIndex}),
2237 "VkBlendFactor", AllVkBlendFactorEnums,
2238 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002239 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002240
2241 skip |= validate_ranged_enum(
2242 report_data, "vkCreateGraphicsPipelines",
2243 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2244 ParameterName::IndexVector{i, attachmentIndex}),
2245 "VkBlendFactor", AllVkBlendFactorEnums,
2246 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002247 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002248
2249 skip |= validate_ranged_enum(
2250 report_data, "vkCreateGraphicsPipelines",
2251 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2252 ParameterName::IndexVector{i, attachmentIndex}),
2253 "VkBlendOp", AllVkBlendOpEnums,
2254 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002255 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002256
2257 skip |=
2258 validate_flags(report_data, "vkCreateGraphicsPipelines",
2259 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2260 ParameterName::IndexVector{i, attachmentIndex}),
2261 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2262 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002263 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002264 }
2265 }
2266
2267 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
2268 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002269 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002270 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2271 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2272 i);
2273 }
2274
2275 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2276 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2277 skip |= validate_ranged_enum(
2278 report_data, "vkCreateGraphicsPipelines",
2279 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002280 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2281 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002282 }
2283 }
2284 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002285
Petr Kraus9752aae2017-11-24 03:05:50 +01002286 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2287 if (pCreateInfos[i].basePipelineIndex != -1) {
2288 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002289 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002290 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002291 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2292 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002293 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002294 }
2295 }
2296
Petr Kraus9752aae2017-11-24 03:05:50 +01002297 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2298 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002299 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002300 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002301 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2302 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002303 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002304 }
2305 }
2306 }
2307
Petr Kraus9752aae2017-11-24 03:05:50 +01002308 if (pCreateInfos[i].pRasterizationState) {
2309 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002310 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002311 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002312 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002313 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2314 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2315 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002316 }
Petr Kraus299ba622017-11-24 03:09:03 +01002317
2318 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
2319 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Dave Houlton413a6782018-05-22 13:01:54 -06002320 skip |=
2321 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
2322 0, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2323 "The line width state is static (pCreateInfos[%" PRIu32
2324 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2325 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2326 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2327 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002328 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002329 }
2330
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002331 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
2332 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
2333 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002334 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002335 }
2336 }
2337 }
2338
2339 return skip;
2340}
2341
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002342bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
2343 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
2344 VkPipeline *pPipelines) {
2345 bool skip = false;
2346 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2347
2348 for (uint32_t i = 0; i < createInfoCount; i++) {
2349 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
2350 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002351 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002352 }
2353
2354 return skip;
2355}
2356
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002357bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2358 VkSampler *pSampler) {
2359 bool skip = false;
2360 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2361 debug_report_data *report_data = device_data->report_data;
2362
2363 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06002364 const auto &features = device_data->physical_device_features;
2365 const auto &limits = device_data->device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002366
John Zulauf71968502017-10-26 13:51:15 -06002367 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2368 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002369 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002370 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002371 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06002372 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002373 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002374 }
2375
2376 // Anistropy cannot be enabled in sampler unless enabled as a feature
2377 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002378 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002379 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002380 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2381 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002382 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002383 }
John Zulauf71968502017-10-26 13:51:15 -06002384
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002385 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2386 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2387 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2388 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2389 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2390 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2391 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2392 }
2393 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2394 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2395 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2396 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2397 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2398 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2399 }
2400 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
2401 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2402 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2403 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2404 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2405 pCreateInfo->minLod, pCreateInfo->maxLod);
2406 }
2407 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2408 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2409 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2410 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2411 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2412 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2413 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2414 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2415 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2416 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2417 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2418 }
2419 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002420 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002421 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002422 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002423 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002424 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002425 if (pCreateInfo->compareEnable == VK_TRUE) {
2426 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2427 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2428 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2429 "not both be VK_TRUE.");
2430 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002431 }
2432
2433 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2434 if (pCreateInfo->compareEnable == VK_TRUE) {
Dave Houlton413a6782018-05-22 13:01:54 -06002435 skip |=
2436 validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2437 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002438 }
2439
2440 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2441 // valid VkBorderColor value
2442 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2443 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2444 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2445 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
Dave Houlton413a6782018-05-22 13:01:54 -06002446 AllVkBorderColorEnums, pCreateInfo->borderColor,
2447 "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002448 }
2449
2450 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2451 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
2452 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
2453 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2454 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2455 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002456 skip |=
2457 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2458 "VUID-VkSamplerCreateInfo-addressModeU-01079",
2459 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2460 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002461 }
John Zulauf275805c2017-10-26 15:34:49 -06002462
2463 // Checks for the IMG cubic filtering extension
2464 if (device_data->extensions.vk_img_filter_cubic) {
2465 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2466 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002467 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002468 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002469 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002470 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002471 }
2472 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002473 }
2474
2475 return skip;
2476}
2477
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002478bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2479 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2480 bool skip = false;
2481 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2482 debug_report_data *report_data = device_data->report_data;
2483
2484 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2485 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2486 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2487 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2488 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2489 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2490 // valid VkSampler handles
2491 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2492 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2493 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2494 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2495 ++descriptor_index) {
2496 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2497 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002498 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002499 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002500 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002501 i, descriptor_index);
2502 }
2503 }
2504 }
2505
2506 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2507 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2508 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002509 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002510 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002511 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2512 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002513 "values.",
2514 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002515 }
2516 }
2517 }
2518 }
2519
2520 return skip;
2521}
2522
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002523bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2524 const VkDescriptorSet *pDescriptorSets) {
2525 bool skip = false;
2526 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2527 debug_report_data *report_data = device_data->report_data;
2528
2529 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2530 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2531 // validate_array()
2532 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002533 &pDescriptorSets, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002534 return skip;
2535}
2536
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002537bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2538 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2539 bool skip = false;
2540 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2541 debug_report_data *report_data = device_data->report_data;
2542
2543 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2544 if (pDescriptorWrites != NULL) {
2545 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2546 // descriptorCount must be greater than 0
2547 if (pDescriptorWrites[i].descriptorCount == 0) {
2548 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002549 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002550 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002551 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002552 }
2553
2554 // dstSet must be a valid VkDescriptorSet handle
2555 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2556 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2557 pDescriptorWrites[i].dstSet);
2558
2559 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2560 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2561 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2562 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2563 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2564 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2565 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2566 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2567 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2568 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002569 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002570 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2571 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2572 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002573 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2574 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002575 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2576 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2577 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2578 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2579 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2580 ++descriptor_index) {
2581 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2582 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2583 ParameterName::IndexVector{i, descriptor_index}),
2584 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2585 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2586 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2587 ParameterName::IndexVector{i, descriptor_index}),
2588 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002589 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002590 }
2591 }
2592 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2593 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2594 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2595 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2596 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2597 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2598 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2599 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2600 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002601 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002602 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2603 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2604 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002605 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2606 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002607 } else {
2608 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2609 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2610 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2611 ParameterName::IndexVector{i, descriptorIndex}),
2612 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2613 }
2614 }
2615 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2616 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2617 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2618 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2619 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2620 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002621 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002622 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2623 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002624 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2625 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002626 } else {
2627 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2628 ++descriptor_index) {
2629 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2630 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2631 ParameterName::IndexVector{i, descriptor_index}),
2632 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2633 }
2634 }
2635 }
2636
2637 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2638 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2639 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2640 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2641 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2642 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002643 skip |=
2644 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002645 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2646 "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002647 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2648 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2649 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002650 }
2651 }
2652 }
2653 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2654 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2655 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2656 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2657 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2658 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002659 skip |=
2660 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002661 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2662 "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002663 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2664 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2665 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002666 }
2667 }
2668 }
2669 }
2670 }
2671 }
2672 return skip;
2673}
2674
Tobias Hectord942eb92018-10-22 15:18:56 +01002675template <typename RenderPassCreateInfoGeneric>
2676bool pv_CreateRenderPassGeneric(VkDevice device, const RenderPassCreateInfoGeneric *pCreateInfo,
2677 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
2678 RenderPassCreateVersion rp_version) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002679 bool skip = false;
2680 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2681 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
Tobias Hectord942eb92018-10-22 15:18:56 +01002682 bool use_rp2 = (rp_version == RENDER_PASS_VERSION_2);
2683 const char *vuid;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002684
2685 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2686 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2687 std::stringstream ss;
Tobias Hectord942eb92018-10-22 15:18:56 +01002688 ss << (use_rp2 ? "vkCreateRenderPass2KHR" : "vkCreateRenderPass") << ": pCreateInfo->pAttachments[" << i
2689 << "].format is VK_FORMAT_UNDEFINED. ";
2690 vuid = use_rp2 ? "VUID-VkAttachmentDescription2KHR-format-parameter" : "VUID-VkAttachmentDescription-format-parameter";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002691 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Tobias Hectord942eb92018-10-22 15:18:56 +01002692 vuid, "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002693 }
2694 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2695 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
Tobias Hectord942eb92018-10-22 15:18:56 +01002696 vuid =
2697 use_rp2 ? "VUID-VkAttachmentDescription2KHR-finalLayout-03061" : "VUID-VkAttachmentDescription-finalLayout-00843";
2698 skip |=
2699 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
2700 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
2701 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2702 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002703 }
2704 }
2705
2706 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2707 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
Tobias Hectord942eb92018-10-22 15:18:56 +01002708 vuid = use_rp2 ? "VUID-VkSubpassDescription2KHR-colorAttachmentCount-03063"
2709 : "VUID-VkSubpassDescription-colorAttachmentCount-00845";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002710 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Tobias Hectord942eb92018-10-22 15:18:56 +01002711 vuid, "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002712 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002713 }
2714 }
2715 return skip;
2716}
2717
Tobias Hectord942eb92018-10-22 15:18:56 +01002718bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2719 VkRenderPass *pRenderPass) {
2720 return pv_CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
2721}
2722
2723bool pv_vkCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
2724 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
2725 return pv_CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
2726}
2727
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002728bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2729 const VkCommandBuffer *pCommandBuffers) {
2730 bool skip = false;
2731 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2732 debug_report_data *report_data = device_data->report_data;
2733
2734 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2735 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2736 // validate_array()
2737 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002738 &pCommandBuffers, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002739 return skip;
2740}
2741
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002742bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2743 bool skip = false;
2744 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2745 debug_report_data *report_data = device_data->report_data;
2746 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2747
2748 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2749 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2750 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2751 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002752 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2753 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002754
2755 if (pBeginInfo->pInheritanceInfo != NULL) {
Dave Houlton413a6782018-05-22 13:01:54 -06002756 skip |= validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2757 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion,
2758 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002759
2760 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2761 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2762
2763 // TODO: This only needs to be validated when the inherited queries feature is enabled
2764 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2765 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2766
2767 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2768 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2769 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002770 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002771 }
2772
2773 if (pInfo != NULL) {
2774 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2775 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002776 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002777 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002778 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002779 }
2780 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2781 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2782 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002783 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002784 }
2785 }
2786
2787 return skip;
2788}
2789
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002790bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2791 const VkViewport *pViewports) {
2792 bool skip = false;
2793 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2794
Petr Krausd55e77c2018-01-09 22:09:25 +01002795 if (!device_data->physical_device_features.multiViewport) {
2796 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002797 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002798 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002799 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2800 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002801 }
2802 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002803 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002804 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002805 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2806 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002807 }
2808 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002809 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002810 if (sum > device_data->device_limits.maxViewports) {
2811 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002812 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002813 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002814 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2815 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002816 }
2817 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002818
2819 if (pViewports) {
2820 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2821 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2822 const char fn_name[] = "vkCmdSetViewport";
2823 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2824 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2825 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2826 }
2827 }
2828
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002829 return skip;
2830}
2831
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002832bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2833 bool skip = false;
2834 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2835 debug_report_data *report_data = device_data->report_data;
2836
Petr Kraus6260f0a2018-02-27 21:15:55 +01002837 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002838 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002839 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002840 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002841 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2842 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002843 }
2844 if (scissorCount > 1) {
2845 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002846 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002847 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2848 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002849 }
2850 } else { // multiViewport enabled
2851 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2852 if (sum > device_data->device_limits.maxViewports) {
2853 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002854 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002855 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002856 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2857 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002858 }
2859 }
2860
Petr Kraus6260f0a2018-02-27 21:15:55 +01002861 if (pScissors) {
2862 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2863 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002864
Petr Kraus6260f0a2018-02-27 21:15:55 +01002865 if (scissor.offset.x < 0) {
2866 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002867 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002868 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2869 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002870 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002871
Petr Kraus6260f0a2018-02-27 21:15:55 +01002872 if (scissor.offset.y < 0) {
2873 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002874 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002875 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2876 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002877 }
2878
2879 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2880 if (x_sum > INT32_MAX) {
2881 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002882 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002883 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002884 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2885 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002886 }
2887
2888 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2889 if (y_sum > INT32_MAX) {
2890 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002891 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002892 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002893 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2894 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002895 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002896 }
2897 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002898
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002899 return skip;
2900}
2901
Petr Kraus299ba622017-11-24 03:09:03 +01002902bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2903 bool skip = false;
2904 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2905 debug_report_data *report_data = device_data->report_data;
2906
2907 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2908 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002909 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002910 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002911 }
2912
2913 return skip;
2914}
2915
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002916bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2917 uint32_t firstInstance) {
2918 bool skip = false;
2919 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2920 if (vertexCount == 0) {
2921 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2922 // this an error or leave as is.
2923 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002924 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002925 }
2926
2927 if (instanceCount == 0) {
2928 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2929 // this an error or leave as is.
2930 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002931 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002932 }
2933 return skip;
2934}
2935
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002936bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2937 bool skip = false;
2938 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2939
2940 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2941 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002942 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002943 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2944 }
2945 return skip;
2946}
2947
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002948bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2949 uint32_t stride) {
2950 bool skip = false;
2951 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2952 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002953 skip |=
2954 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2955 kVUID_PVError_DeviceFeature,
2956 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002957 }
2958 return skip;
2959}
2960
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002961bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2962 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2963 bool skip = false;
2964 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2965
Dave Houltonf5217612018-02-02 16:18:52 -07002966 VkImageAspectFlags legal_aspect_flags =
2967 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2968 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2969 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2970 }
2971
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002972 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002973 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002974 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002975 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002976 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002977 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002978 }
Dave Houltonf5217612018-02-02 16:18:52 -07002979 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002980 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002981 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002982 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002983 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002984 }
2985 }
2986 return skip;
2987}
2988
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002989bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2990 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2991 bool skip = false;
2992 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2993
Dave Houltonf5217612018-02-02 16:18:52 -07002994 VkImageAspectFlags legal_aspect_flags =
2995 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2996 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2997 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2998 }
2999
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003000 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003001 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003002 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003003 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003004 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003005 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
3006 }
Dave Houltonf5217612018-02-02 16:18:52 -07003007 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003008 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003009 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003010 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003011 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
3012 }
3013 }
3014 return skip;
3015}
3016
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003017bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
3018 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
3019 bool skip = false;
3020 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3021
Dave Houltonf5217612018-02-02 16:18:52 -07003022 VkImageAspectFlags legal_aspect_flags =
3023 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
3024 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
3025 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3026 }
3027
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003028 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003029 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07003030 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003031 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003032 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
3033 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003034 }
3035 }
3036 return skip;
3037}
3038
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003039bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
3040 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
3041 bool skip = false;
3042 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3043
Dave Houltonf5217612018-02-02 16:18:52 -07003044 VkImageAspectFlags legal_aspect_flags =
3045 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
3046 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
3047 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3048 }
3049
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003050 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003051 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003052 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003053 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003054 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
3055 "enumerator");
3056 }
3057 }
3058 return skip;
3059}
3060
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003061bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
3062 const void *pData) {
3063 bool skip = false;
3064 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3065
3066 if (dstOffset & 3) {
3067 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003068 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003069 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3070 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003071 }
3072
3073 if ((dataSize <= 0) || (dataSize > 65536)) {
3074 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003075 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003076 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003077 "), must be greater than zero and less than or equal to 65536.",
3078 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003079 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003080 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003081 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003082 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003083 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003084 }
3085 return skip;
3086}
3087
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003088bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
3089 uint32_t data) {
3090 bool skip = false;
3091 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3092
3093 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003094 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003095 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003096 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003097 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003098 }
3099
3100 if (size != VK_WHOLE_SIZE) {
3101 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003102 skip |=
3103 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003104 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003105 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003106 } else if (size & 3) {
3107 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003108 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003109 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003110 }
3111 }
3112 return skip;
3113}
3114
3115VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
3116 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3117}
3118
3119VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3120 VkLayerProperties *pProperties) {
3121 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3122}
3123
3124VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3125 VkExtensionProperties *pProperties) {
3126 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3127 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
3128
3129 return VK_ERROR_LAYER_NOT_PRESENT;
3130}
3131
3132VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
3133 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
3134 // Parameter_validation does not have any physical device extensions
3135 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3136 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
3137
3138 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
Dave Houlton413a6782018-05-22 13:01:54 -06003139 bool skip = validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
3140 pPropertyCount, &pProperties, true, false, false, kVUIDUndefined,
3141 "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003142 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
3143
3144 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
3145}
3146
3147static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
3148 if (!flag) {
3149 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003150 kVUID_PVError_ExtensionNotEnabled,
3151 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
3152 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003153 }
3154
3155 return false;
3156}
3157
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003158bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3159 VkSwapchainKHR *pSwapchain) {
3160 bool skip = false;
3161 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3162 debug_report_data *report_data = device_data->report_data;
3163
Mark Lobodzinski88529492018-04-01 10:38:15 -06003164 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01003165 "vkCreateSwapchainKHR"};
3166
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003167 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003168 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3169 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3170 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3171 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003172 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003173 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003174 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003175 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003176 }
3177
3178 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3179 // queueFamilyIndexCount uint32_t values
3180 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003181 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003182 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003183 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3184 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003185 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003186 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003187 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -06003188 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices",
3189 kVUID_PVError_InvalidUsage, kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003190 }
3191 }
3192
Dave Houlton413a6782018-05-22 13:01:54 -06003193 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
3194 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003195 }
3196
3197 return skip;
3198}
3199
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003200bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
3201 bool skip = false;
3202 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
3203
3204 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003205 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3206 if (present_regions) {
3207 // TODO: This and all other pNext extension dependencies should be added to code-generation
3208 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
3209 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3210 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
3211 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003212 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003213 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3214 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06003215 pPresentInfo->swapchainCount, present_regions->swapchainCount);
3216 }
Dave Houlton413a6782018-05-22 13:01:54 -06003217 skip |=
3218 validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
3219 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
John Zulaufde972ac2017-10-26 12:07:05 -06003220 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003221 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
Dave Houlton413a6782018-05-22 13:01:54 -06003222 true, false, kVUIDUndefined, kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003223 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
3224 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003225 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003226 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003227 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003228 }
3229 }
3230
3231 return skip;
3232}
3233
3234#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003235bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3236 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
3237 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3238 bool skip = false;
3239
3240 if (pCreateInfo->hwnd == nullptr) {
3241 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003242 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3243 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003244 }
3245
3246 return skip;
3247}
3248#endif // VK_USE_PLATFORM_WIN32_KHR
3249
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003250bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
3251 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3252 if (pNameInfo->pObjectName) {
3253 device_data->report_data->debugObjectNameMap->insert(
3254 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
3255 } else {
3256 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
3257 }
3258 return false;
3259}
3260
Petr Krausc8655be2017-09-27 18:56:51 +02003261bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
3262 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
3263 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3264 bool skip = false;
3265
3266 if (pCreateInfo) {
3267 if (pCreateInfo->maxSets <= 0) {
Dave Houlton413a6782018-05-22 13:01:54 -06003268 skip |=
3269 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3270 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3271 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003272 }
3273
3274 if (pCreateInfo->pPoolSizes) {
3275 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3276 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
3277 skip |= log_msg(
3278 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003279 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003280 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003281 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003282 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3283 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003284 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
3285 VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, VK_NULL_HANDLE,
3286 "VUID-VkDescriptorPoolSize-type-02218",
3287 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3288 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3289 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3290 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003291 }
Petr Krausc8655be2017-09-27 18:56:51 +02003292 }
3293 }
3294 }
3295
3296 return skip;
3297}
3298
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003299bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3300 bool skip = false;
3301 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3302
3303 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003304 skip |=
3305 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003306 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003307 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3308 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003309 }
3310
3311 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003312 skip |=
3313 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003314 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003315 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3316 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003317 }
3318
3319 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003320 skip |=
3321 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003322 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003323 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3324 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003325 }
3326
3327 return skip;
3328}
3329
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003330bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003331 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3332 bool skip = false;
3333 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3334
3335 // Paired if {} else if {} tests used to avoid any possible uint underflow
3336 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
3337 if (baseGroupX >= limit) {
3338 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003339 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003340 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003341 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3342 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003343 } else if (groupCountX > (limit - baseGroupX)) {
3344 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003345 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003346 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003347 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3348 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003349 }
3350
3351 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
3352 if (baseGroupY >= limit) {
3353 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003354 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003355 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003356 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3357 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003358 } else if (groupCountY > (limit - baseGroupY)) {
3359 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003360 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003361 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003362 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3363 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003364 }
3365
3366 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
3367 if (baseGroupZ >= limit) {
3368 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003369 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003370 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003371 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3372 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003373 } else if (groupCountZ > (limit - baseGroupZ)) {
3374 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003375 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003376 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003377 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3378 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003379 }
3380
3381 return skip;
3382}
3383
Dave Houlton142c4cb2018-10-17 15:04:41 -06003384bool pv_vkCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer, uint32_t firstExclusiveScissor, uint32_t exclusiveScissorCount,
3385 const VkRect2D *pExclusiveScissors) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003386 bool skip = false;
3387
3388 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3389 debug_report_data *report_data = device_data->report_data;
3390
3391 if (!device_data->physical_device_features.multiViewport) {
3392 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003393 skip |=
3394 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3395 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3396 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3397 ") is not 0.",
3398 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003399 }
3400 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003401 skip |=
3402 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3403 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3404 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3405 ") is not 1.",
3406 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003407 }
3408 } else { // multiViewport enabled
3409 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
3410 if (sum > device_data->device_limits.maxViewports) {
3411 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3412 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003413 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3414 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003415 firstExclusiveScissor, exclusiveScissorCount, sum, device_data->device_limits.maxViewports);
3416 }
3417 }
3418
3419 if (firstExclusiveScissor >= device_data->device_limits.maxViewports) {
3420 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3421 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003422 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32
3423 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003424 firstExclusiveScissor, device_data->device_limits.maxViewports);
3425 }
3426
3427 if (pExclusiveScissors) {
3428 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3429 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3430
3431 if (scissor.offset.x < 0) {
3432 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3433 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003434 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3435 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003436 }
3437
3438 if (scissor.offset.y < 0) {
3439 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3440 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003441 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3442 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003443 }
3444
3445 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3446 if (x_sum > INT32_MAX) {
3447 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3448 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3449 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3450 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3451 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
3452 }
3453
3454 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3455 if (y_sum > INT32_MAX) {
3456 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3457 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3458 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3459 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3460 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
3461 }
3462 }
3463 }
3464
3465 return skip;
3466}
3467
Dave Houlton142c4cb2018-10-17 15:04:41 -06003468bool pv_vkCmdSetViewportShadingRatePaletteNV(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
3469 const VkShadingRatePaletteNV *pShadingRatePalettes) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003470 bool skip = false;
3471
3472 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3473 debug_report_data *report_data = device_data->report_data;
3474
3475 if (!device_data->physical_device_features.multiViewport) {
3476 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003477 skip |=
3478 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3479 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3480 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3481 ") is not 0.",
3482 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003483 }
3484 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003485 skip |=
3486 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3487 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3488 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3489 ") is not 1.",
3490 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003491 }
3492 }
3493
3494 if (firstViewport >= device_data->device_limits.maxViewports) {
3495 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3496 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003497 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3498 ") must be less than maxViewports (=%" PRIu32 ").",
Jeff Bolz9af91c52018-09-01 21:53:57 -05003499 firstViewport, device_data->device_limits.maxViewports);
3500 }
3501
3502 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3503 if (sum > device_data->device_limits.maxViewports) {
3504 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3505 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3506 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3507 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3508 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
3509 }
3510
3511 return skip;
3512}
3513
Dave Houlton142c4cb2018-10-17 15:04:41 -06003514bool pv_vkCmdSetCoarseSampleOrderNV(VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType,
3515 uint32_t customSampleOrderCount, const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003516 bool skip = false;
3517
3518 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3519 debug_report_data *report_data = device_data->report_data;
3520
Dave Houlton142c4cb2018-10-17 15:04:41 -06003521 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003522 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3523 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3524 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3525 "customSampleOrderCount must be 0.");
3526 }
3527
3528 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
3529 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &pCustomSampleOrders[order_i]);
3530 }
3531
3532 return skip;
3533}
3534
Dave Houlton142c4cb2018-10-17 15:04:41 -06003535bool pv_vkCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount, uint32_t firstTask) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003536 bool skip = false;
3537
3538 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3539
3540 if (taskCount > dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003541 skip |= log_msg(
3542 dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3543 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
3544 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3545 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
3546 taskCount, dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003547 }
3548
3549 return skip;
3550}
3551
Dave Houlton142c4cb2018-10-17 15:04:41 -06003552bool pv_vkCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t drawCount,
3553 uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003554 bool skip = false;
3555
3556 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3557 debug_report_data *report_data = dev_data->report_data;
3558
3559 if (offset & 3) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003560 skip |= log_msg(
3561 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3562 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02145",
3563 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003564 }
3565
3566 if (drawCount > 1 && ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
3567 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3568 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3569 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3570 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3571 stride);
3572 }
3573
3574 return skip;
3575}
3576
Dave Houlton142c4cb2018-10-17 15:04:41 -06003577bool pv_vkCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkBuffer countBuffer,
3578 VkDeviceSize countBufferOffset, uint32_t maxDrawCount, uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003579 bool skip = false;
3580
3581 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3582
3583 if (offset & 3) {
3584 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3585 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02180",
3586 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3587 "), is not a multiple of 4.",
3588 offset);
3589 }
3590
3591 if (countBufferOffset & 3) {
3592 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3593 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02181",
3594 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3595 "), is not a multiple of 4.",
3596 countBufferOffset);
3597 }
3598
3599 if ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV)) {
3600 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3601 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-stride-02182",
3602 "vkCmdDrawMeshTasksIndirectCountNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3603 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3604 stride);
3605 }
3606
3607 return skip;
3608}
3609
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003610VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003611 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3612 if (!ApiParentExtensionEnabled(funcName, device_data->extensions.device_extension_set)) {
3613 return nullptr;
3614 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003615 const auto item = name_to_funcptr_map.find(funcName);
3616 if (item != name_to_funcptr_map.end()) {
3617 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3618 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003619 const auto &table = device_data->dispatch_table;
3620 if (!table.GetDeviceProcAddr) return nullptr;
3621 return table.GetDeviceProcAddr(device, funcName);
3622}
3623
3624VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3625 const auto item = name_to_funcptr_map.find(funcName);
3626 if (item != name_to_funcptr_map.end()) {
3627 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3628 }
3629
3630 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3631 auto &table = instance_data->dispatch_table;
3632 if (!table.GetInstanceProcAddr) return nullptr;
3633 return table.GetInstanceProcAddr(instance, funcName);
3634}
3635
3636VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
3637 assert(instance);
3638 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3639
3640 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
3641 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
3642}
3643
3644// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
3645// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02003646void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07003647 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
3648 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
3649 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
3650 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
3651 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
3652 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
3653 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
3654 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
3655 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
3656 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
3657 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
Tobias Hectord942eb92018-10-22 15:18:56 +01003658 custom_functions["vkCreateRenderPass2KHR"] = (void *)pv_vkCreateRenderPass2KHR;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003659 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
3660 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
3661 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01003662 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003663 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
3664 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
3665 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
3666 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
3667 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
3668 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
3669 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
3670 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
3671 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
3672 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
3673 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
3674 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
3675 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003676 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Jeff Bolz3e71f782018-08-29 23:15:45 -05003677 custom_functions["vkCmdSetExclusiveScissorNV"] = (void *)pv_vkCmdSetExclusiveScissorNV;
Jeff Bolz9af91c52018-09-01 21:53:57 -05003678 custom_functions["vkCmdSetViewportShadingRatePaletteNV"] = (void *)pv_vkCmdSetViewportShadingRatePaletteNV;
3679 custom_functions["vkCmdSetCoarseSampleOrderNV"] = (void *)pv_vkCmdSetCoarseSampleOrderNV;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003680 custom_functions["vkCmdDrawMeshTasksNV"] = (void *)pv_vkCmdDrawMeshTasksNV;
3681 custom_functions["vkCmdDrawMeshTasksIndirectNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectNV;
3682 custom_functions["vkCmdDrawMeshTasksIndirectCountNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectCountNV;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003683}
3684
3685} // namespace parameter_validation
3686
3687VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3688 VkExtensionProperties *pProperties) {
3689 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
3690}
3691
3692VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
3693 VkLayerProperties *pProperties) {
3694 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
3695}
3696
3697VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3698 VkLayerProperties *pProperties) {
3699 // the layer command handles VK_NULL_HANDLE just fine internally
3700 assert(physicalDevice == VK_NULL_HANDLE);
3701 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
3702}
3703
3704VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3705 const char *pLayerName, uint32_t *pCount,
3706 VkExtensionProperties *pProperties) {
3707 // the layer command handles VK_NULL_HANDLE just fine internally
3708 assert(physicalDevice == VK_NULL_HANDLE);
3709 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3710}
3711
3712VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3713 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3714}
3715
3716VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3717 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3718}
3719
3720VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3721 const char *funcName) {
3722 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3723}
3724
Lenny Komow2d0cbbe2018-05-24 13:38:05 -06003725VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL VKAPI_CALL
3726vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003727 assert(pVersionStruct != NULL);
3728 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3729
3730 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3731 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3732 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3733 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3734 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3735 }
3736
3737 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3738 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3739 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3740 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3741 }
3742
3743 return VK_SUCCESS;
3744}