blob: e512964b1d6e2d09c7bcbe3b85fac9a933e95355 [file] [log] [blame]
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08001/* Copyright (c) 2015-2020 The Khronos Group Inc.
2 * Copyright (c) 2015-2020 Valve Corporation
3 * Copyright (c) 2015-2020 LunarG, Inc.
4 * Copyright (C) 2015-2020 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028static const int MaxParamCheckerStringLength = 256;
29
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070036bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050037 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060038 bool skip = false;
39
40 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
41
42 if (result == VK_STRING_ERROR_NONE) {
43 return skip;
44 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070045 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
46 MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070048 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
49 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050 }
51 return skip;
52}
53
Jeff Bolz46c0ea02019-10-09 13:06:29 -050054bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060055 bool skip = false;
56 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
57 if (api_version_nopatch != effective_api_version) {
58 if (api_version_nopatch < VK_API_VERSION_1_0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070059 skip |= LogError(instance, kVUIDUndefined,
60 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
61 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
62 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060063 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070064 skip |= LogWarning(instance, kVUIDUndefined,
65 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
66 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
67 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060068 }
69 }
70 return skip;
71}
72
Jeff Bolz46c0ea02019-10-09 13:06:29 -050073bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060074 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060075 // Create and use a local instance extension object, as an actual instance has not been created yet
76 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
77 InstanceExtensions local_instance_extensions;
78 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
79
John Zulauf620755c2018-04-16 11:00:43 -060080 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060081 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
82 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060083 }
84
85 return skip;
86}
87
John Zulauf620755c2018-04-16 11:00:43 -060088template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -070089ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
90 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -060091 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -070092 ExtEnabled state =
93 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -060094 return state;
95}
96
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070097bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -050098 const VkAllocationCallbacks *pAllocator,
99 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700100 bool skip = false;
101 // Note: From the spec--
102 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
103 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
104 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700105 ? pCreateInfo->pApplicationInfo->apiVersion
106 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700107 skip |= validate_api_version(local_api_version, api_version);
108 skip |= validate_instance_extensions(pCreateInfo);
109 return skip;
110}
111
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700112void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700113 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
114 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700115 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
116 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700117 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700118 this->instance_extensions = instance_data->instance_extensions;
119}
120
121void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700122 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700123 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700124 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700125 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
126 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700127
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700128 // Parmeter validation also uses extension data
129 stateless_validation->device_extensions = this->device_extensions;
130
131 VkPhysicalDeviceProperties device_properties = {};
132 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600133 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700134 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
135
136 if (device_extensions.vk_nv_shading_rate_image) {
137 // Get the needed shading rate image limits
138 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
139 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600140 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700141 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
142 }
143
144 if (device_extensions.vk_nv_mesh_shader) {
145 // Get the needed mesh shader limits
146 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
147 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600148 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700149 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
150 }
151
Jason Macnak5c954952019-07-09 15:46:12 -0700152 if (device_extensions.vk_nv_ray_tracing) {
153 // Get the needed ray tracing limits
154 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesNV>();
155 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
156 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
157 phys_dev_ext_props.ray_tracing_props = ray_tracing_props;
158 }
159
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700160 if (device_extensions.vk_ext_transform_feedback) {
161 // Get the needed transform feedback limits
162 auto transform_feedback_props = lvl_init_struct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
163 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&transform_feedback_props);
164 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
165 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
166 }
167
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800168 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
169
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700170 // Save app-enabled features in this device's validation object
171 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Petr Kraus715bcc72019-08-15 17:17:33 +0200172 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
173 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
174 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
175 if (features2) {
176 tmp_features2_state.features = features2->features;
177 } else if (pCreateInfo->pEnabledFeatures) {
178 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700179 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200180 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700181 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200182 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700183 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200184 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700185}
186
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700187bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500188 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600189 bool skip = false;
190
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200191 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
192 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
193 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600194 }
195
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200196 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
197 skip |=
198 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
199 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
200 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
201 pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600202 }
203
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200204 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700205 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
206 bool negative_viewport =
207 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200208 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700209 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
210 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
211 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200212 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600213 }
214
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600215 {
216 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
217 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
218 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700219 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
220 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
221 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600222 }
223 }
224
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600225 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
226 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600227 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
228 if (features2) {
229 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700230 skip |= LogError(device, kVUID_PVError_InvalidUsage,
231 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
232 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600233 }
234 }
235
Locke77fad1c2019-04-16 13:09:03 -0600236 auto features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
237 if (features2) {
238 if (!instance_extensions.vk_khr_get_physical_device_properties_2) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700239 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
240 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct, "
241 "VK_KHR_get_physical_device_properties2 must be enabled when it creates an instance.");
Locke77fad1c2019-04-16 13:09:03 -0600242 }
243 }
244
245 auto vertex_attribute_divisor_features =
246 lvl_find_in_chain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
247 if (vertex_attribute_divisor_features) {
248 bool extension_found = false;
249 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; ++i) {
250 if (0 == strncmp(pCreateInfo->ppEnabledExtensionNames[i], VK_EXT_VERTEX_ATTRIBUTE_DIVISOR_EXTENSION_NAME,
251 VK_MAX_EXTENSION_NAME_SIZE)) {
252 extension_found = true;
253 break;
254 }
255 }
256 if (!extension_found) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700257 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
258 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
259 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600260 }
261 }
262
Tony-LunarG28017bc2020-01-23 14:40:25 -0700263 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
264 if (vulkan_11_features) {
265 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
266 while (current) {
267 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
268 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
269 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
270 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
271 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
272 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700273 skip |= LogError(
274 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700275 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
276 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
277 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
278 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
279 break;
280 }
281 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
282 }
283 }
284
285 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
286 if (vulkan_12_features) {
287 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
288 while (current) {
289 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
290 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
291 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
292 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
293 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
294 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
295 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
296 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
297 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
298 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
299 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
300 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
301 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700302 skip |= LogError(
303 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700304 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
305 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
306 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
307 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
308 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
309 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
310 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
311 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
312 break;
313 }
314 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
315 }
316 }
317
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600318 // Validate pCreateInfo->pQueueCreateInfos
319 if (pCreateInfo->pQueueCreateInfos) {
320 std::unordered_set<uint32_t> set;
321
322 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
323 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
324 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700325 skip |=
326 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
327 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
328 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
329 "index value.",
330 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600331 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700332 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
333 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
334 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
335 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600336 } else {
337 set.insert(requested_queue_family);
338 }
339
340 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
341 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
342 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
343 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700344 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
345 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
346 "] (=%f) is not between 0 and 1 (inclusive).",
347 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600348 }
349 }
350 }
351 }
352 }
353
354 return skip;
355}
356
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500357bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700358 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700359 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
360 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
361 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600362 }
363
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700364 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600365}
366
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700367bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500368 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100369 bool skip = false;
370
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600371 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700372 skip |=
373 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600374
375 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
376 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
377 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
378 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700379 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
380 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
381 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600382 }
383
384 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
385 // queueFamilyIndexCount uint32_t values
386 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700387 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
388 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
389 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
390 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600391 }
392 }
393
394 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
395 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
396 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
397 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700398 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
399 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
400 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600401 }
402 }
403
404 return skip;
405}
406
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700407bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500408 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600409 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600410
411 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600412 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
413 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
414 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
415 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700416 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
417 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
418 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600419 }
420
421 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
422 // queueFamilyIndexCount uint32_t values
423 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700424 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
425 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
426 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
427 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600428 }
429 }
430
Dave Houlton413a6782018-05-22 13:01:54 -0600431 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700432 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600433 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700434 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600435 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700436 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600437
Dave Houlton413a6782018-05-22 13:01:54 -0600438 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700439 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600440 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700441 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600442
Dave Houlton130c0212018-01-29 13:39:56 -0700443 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700444 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
445 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700446 skip |= LogError(
447 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600448 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
449 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700450 }
451
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600452 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100453 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
454 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700455 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
456 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
457 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600458 }
459
460 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100461 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
462 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700463 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
464 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
465 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
466 ") are not equal.",
467 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100468 }
469
470 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700471 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
472 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
473 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
474 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100475 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600476 }
477
478 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700479 skip |= LogError(
480 device, "VUID-VkImageCreateInfo-imageType-00957",
481 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600482 }
483 }
484
Dave Houlton130c0212018-01-29 13:39:56 -0700485 // 3D image may have only 1 layer
486 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700487 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
488 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700489 }
490
491 // If multi-sample, validate type, usage, tiling and mip levels.
492 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
493 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600494 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700495 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
496 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700497 }
498
499 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
500 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
501 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
502 // At least one of the legal attachment bits must be set
503 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700504 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
505 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700506 }
507 // No flags other than the legal attachment bits may be set
508 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
509 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700510 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
511 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700512 }
513 }
514
Jeff Bolzef40fec2018-09-01 22:04:34 -0500515 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600516 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500517 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -0600518 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
519 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500520 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600521 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700522 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
523 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
524 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600525 }
526
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600527 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700528 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
529 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
530 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600531 }
532
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700533 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700534 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
535 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
536 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100537 }
538
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600539 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
540 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
541 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
542 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700543 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
544 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
545 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600546 }
547
548 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
549 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
550 // Linear tiling is unsupported
551 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700552 skip |= LogError(device, kVUID_PVError_InvalidUsage,
553 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
554 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 }
556
557 // Sparse 1D image isn't valid
558 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700559 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
560 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600561 }
562
563 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700564 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700565 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
566 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
567 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600568 }
569
570 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700571 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700572 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
573 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
574 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600575 }
576
577 // Multi-sample 2D image when device doesn't support it
578 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700579 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600580 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700581 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
582 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
583 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700584 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600585 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700586 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
587 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
588 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700589 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600590 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700591 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
592 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
593 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700594 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600595 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700596 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
597 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
598 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600599 }
600 }
601 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500602
Jeff Bolz9af91c52018-09-01 21:53:57 -0500603 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
604 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700605 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
606 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
607 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500608 }
609 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700610 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
611 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
612 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500613 }
614 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700615 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
616 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
617 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500618 }
619 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500620
621 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600622 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700623 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
624 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
625 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500626 }
627
Dave Houlton142c4cb2018-10-17 15:04:41 -0600628 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700629 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
630 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
631 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
632 "not be a depth/stencil format.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500633 }
634
Dave Houlton142c4cb2018-10-17 15:04:41 -0600635 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700636 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
637 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
638 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
639 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500640 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600641 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700642 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
643 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
644 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
645 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500646 }
647 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500648
649 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pCreateInfo->pNext);
650 if (image_stencil_struct != nullptr) {
651 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
652 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
653 // No flags other than the legal attachment bits may be set
654 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
655 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700656 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
657 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
658 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
659 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500660 }
661 }
662
663 if (FormatIsDepthOrStencil(pCreateInfo->format)) {
664 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
665 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
666 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700667 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
668 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
669 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width exceeds device "
670 "maxFramebufferWidth");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500671 }
672
673 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
674 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700675 LogError(device, "VUID-VkImageCreateInfo-format-02537",
676 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
677 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height exceeds device "
678 "maxFramebufferHeight");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500679 }
680 }
681
682 if (!physical_device_features.shaderStorageImageMultisample &&
683 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
684 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
685 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700686 LogError(device, "VUID-VkImageCreateInfo-format-02538",
687 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
688 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
689 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500690 }
691
692 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
693 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700694 skip |= LogError(
695 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500696 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
697 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
698 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
699 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
700 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700701 skip |= LogError(
702 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500703 "vkCreateImage(): Depth-stencil image in which usage does not include "
704 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
705 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
706 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
707 }
708
709 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
710 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700711 skip |= LogError(
712 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500713 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
714 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
715 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
716 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
717 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700718 skip |= LogError(
719 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500720 "vkCreateImage(): Depth-stencil image in which usage does not include "
721 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
722 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
723 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
724 }
725 }
726 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -0700727
728 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
729 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
730 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
731 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
732 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
733 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600734 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500735
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600736 return skip;
737}
738
Jeff Bolz6d3beaa2019-02-09 21:00:05 -0600739bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700740 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100741 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +0100742
743 // Note: for numerical correctness
744 // - float comparisons should expect NaN (comparison always false).
745 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
746
747 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -0700748 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +0100749 if (v1_f <= 0.0f) return true;
750
751 float intpart;
752 const float fract = modff(v1_f, &intpart);
753
754 assert(std::numeric_limits<float>::radix == 2);
755 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
756 if (intpart >= u32_max_plus1) return false;
757
758 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
759 if (v1_u32 < v2_u32)
760 return true;
761 else if (v1_u32 == v2_u32 && fract == 0.0f)
762 return true;
763 else
764 return false;
765 };
766
767 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
768 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
769 return (v1_f <= v2_f);
770 };
771
772 // width
773 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700774 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +0100775
776 if (!(viewport.width > 0.0f)) {
777 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700778 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
779 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100780 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
781 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700782 skip |= LogError(object, "VUID-VkViewport-width-01771",
783 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
784 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100785 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700786 skip |= LogWarning(object, kVUID_PVError_NONE,
787 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
788 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
789 fn_name, parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100790 }
791
792 // height
793 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -0700794 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700795 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +0100796
797 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
798 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700799 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
800 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100801 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
802 height_healthy = false;
803
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700804 skip |= LogError(object, "VUID-VkViewport-height-01773",
805 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
806 ").",
807 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100808 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
809 height_healthy = false;
810
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700811 skip |= LogWarning(
812 object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +0100813 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600814 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
Jeff Bolz6d3beaa2019-02-09 21:00:05 -0600815 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100816 }
817
818 // x
819 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700820 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100821 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700822 skip |= LogError(object, "VUID-VkViewport-x-01774",
823 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
824 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100825 }
826
827 // x + width
828 if (x_healthy && width_healthy) {
829 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700830 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700831 skip |= LogError(
832 object, "VUID-VkViewport-x-01232",
833 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
834 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
835 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100836 }
837 }
838
839 // y
840 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700841 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100842 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700843 skip |= LogError(object, "VUID-VkViewport-y-01775",
844 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
845 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700846 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100847 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700848 skip |= LogError(object, "VUID-VkViewport-y-01776",
849 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
850 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100851 }
852
853 // y + height
854 if (y_healthy && height_healthy) {
855 const float boundary = viewport.y + viewport.height;
856
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700857 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700858 skip |= LogError(object, "VUID-VkViewport-y-01233",
859 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
860 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
861 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700862 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -0600863 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700864 LogError(object, "VUID-VkViewport-y-01777",
865 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
866 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
867 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100868 }
869 }
870
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700871 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100872 // minDepth
873 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700874 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600875
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700876 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
877 "[0.0, 1.0] range.",
878 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100879 }
880
881 // maxDepth
882 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700883 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600884
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700885 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
886 "[0.0, 1.0] range.",
887 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100888 }
889 }
890
891 return skip;
892}
893
Dave Houlton142c4cb2018-10-17 15:04:41 -0600894struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500895 VkShadingRatePaletteEntryNV shadingRate;
896 uint32_t width;
897 uint32_t height;
898};
899
900// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -0600901static SampleOrderInfo sampleOrderInfos[] = {
902 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
903 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
904 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
905 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
906 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
907 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -0500908};
909
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500910bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500911 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -0500912
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500913 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -0500914 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500915 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500916 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500917 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -0500918 break;
919 }
920 }
921
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500922 if (sampleOrderInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700923 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
924 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
925 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500926 return skip;
927 }
928
Dave Houlton142c4cb2018-10-17 15:04:41 -0600929 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700930 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700931 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
932 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
933 ") must "
934 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
935 "is set in framebufferNoAttachmentsSampleCounts.",
936 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500937 }
938
Jeff Bolz9af91c52018-09-01 21:53:57 -0500939 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700940 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
941 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
942 ") must "
943 "be equal to the product of sampleCount (=%" PRIu32
944 "), the fragment width for shadingRate "
945 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
946 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500947 }
948
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700949 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700950 skip |= LogError(
951 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -0600952 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
953 ") must "
954 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700955 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500956 }
Jeff Bolz9af91c52018-09-01 21:53:57 -0500957
958 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500959 // the first width*height*sampleCount bits to all be set. Note: There is no
960 // guarantee that 64 bits is enough, but practically it's unlikely for an
961 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700962 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500963 uint64_t sampleLocationsMask = 0;
964 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
965 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
966 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700967 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
968 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500969 }
970 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700971 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
972 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500973 }
974 if (sampleLoc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700975 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
976 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500977 }
978 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
979 sampleLocationsMask |= 1ULL << idx;
980 }
981
982 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
983 if (sampleLocationsMask != expectedMask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700984 skip |= LogError(
985 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -0600986 "The array pSampleLocations must contain exactly one entry for "
987 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500988 }
989
990 return skip;
991}
992
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700993bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
994 uint32_t createInfoCount,
995 const VkGraphicsPipelineCreateInfo *pCreateInfos,
996 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500997 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600998 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600999
1000 if (pCreateInfos != nullptr) {
1001 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001002 bool has_dynamic_viewport = false;
1003 bool has_dynamic_scissor = false;
1004 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001005 bool has_dynamic_depth_bias = false;
1006 bool has_dynamic_blend_constant = false;
1007 bool has_dynamic_depth_bounds = false;
1008 bool has_dynamic_stencil_compare = false;
1009 bool has_dynamic_stencil_write = false;
1010 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001011 bool has_dynamic_viewport_w_scaling_nv = false;
1012 bool has_dynamic_discard_rectangle_ext = false;
1013 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001014 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001015 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001016 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001017 bool has_dynamic_line_stipple = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001018 if (pCreateInfos[i].pDynamicState != nullptr) {
1019 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1020 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1021 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001022 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1023 if (has_dynamic_viewport == true) {
1024 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1025 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1026 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1027 i);
1028 }
1029 has_dynamic_viewport = true;
1030 }
1031 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1032 if (has_dynamic_scissor == true) {
1033 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1034 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1035 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1036 i);
1037 }
1038 has_dynamic_scissor = true;
1039 }
1040 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1041 if (has_dynamic_line_width == true) {
1042 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1043 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1044 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1045 i);
1046 }
1047 has_dynamic_line_width = true;
1048 }
1049 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1050 if (has_dynamic_depth_bias == true) {
1051 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1052 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1053 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1054 i);
1055 }
1056 has_dynamic_depth_bias = true;
1057 }
1058 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1059 if (has_dynamic_blend_constant == true) {
1060 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1061 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1062 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1063 i);
1064 }
1065 has_dynamic_blend_constant = true;
1066 }
1067 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1068 if (has_dynamic_depth_bounds == true) {
1069 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1070 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1071 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1072 i);
1073 }
1074 has_dynamic_depth_bounds = true;
1075 }
1076 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1077 if (has_dynamic_stencil_compare == true) {
1078 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1079 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1080 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1081 i);
1082 }
1083 has_dynamic_stencil_compare = true;
1084 }
1085 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1086 if (has_dynamic_stencil_write == true) {
1087 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1088 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1089 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1090 i);
1091 }
1092 has_dynamic_stencil_write = true;
1093 }
1094 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1095 if (has_dynamic_stencil_reference == true) {
1096 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1097 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1098 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1099 i);
1100 }
1101 has_dynamic_stencil_reference = true;
1102 }
1103 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1104 if (has_dynamic_viewport_w_scaling_nv == true) {
1105 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1106 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1107 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1108 i);
1109 }
1110 has_dynamic_viewport_w_scaling_nv = true;
1111 }
1112 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1113 if (has_dynamic_discard_rectangle_ext == true) {
1114 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1115 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1116 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1117 i);
1118 }
1119 has_dynamic_discard_rectangle_ext = true;
1120 }
1121 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1122 if (has_dynamic_sample_locations_ext == true) {
1123 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1124 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1125 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1126 i);
1127 }
1128 has_dynamic_sample_locations_ext = true;
1129 }
1130 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1131 if (has_dynamic_exclusive_scissor_nv == true) {
1132 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1133 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1134 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1135 i);
1136 }
1137 has_dynamic_exclusive_scissor_nv = true;
1138 }
1139 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1140 if (has_dynamic_shading_rate_palette_nv == true) {
1141 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1142 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1143 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1144 i);
1145 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001146 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001147 }
1148 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1149 if (has_dynamic_viewport_course_sample_order_nv == true) {
1150 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1151 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1152 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1153 i);
1154 }
1155 has_dynamic_viewport_course_sample_order_nv = true;
1156 }
1157 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1158 if (has_dynamic_line_stipple == true) {
1159 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1160 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1161 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1162 i);
1163 }
1164 has_dynamic_line_stipple = true;
1165 }
Petr Kraus299ba622017-11-24 03:09:03 +01001166 }
1167 }
1168
Peter Chen85366392019-05-14 15:20:11 -04001169 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
1170 if ((feedback_struct != nullptr) &&
1171 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001172 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1173 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1174 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1175 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1176 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001177 }
1178
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001179 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001180
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001181 // Collect active stages and other information
1182 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001183 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001184 bool has_eval = false;
1185 bool has_control = false;
1186 if (pCreateInfos[i].pStages != nullptr) {
1187 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1188 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1189
1190 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1191 has_control = true;
1192 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1193 has_eval = true;
1194 }
1195
1196 skip |= validate_string(
1197 "vkCreateGraphicsPipelines",
1198 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1199 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1200 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001201 }
1202
1203 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1204 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1205 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1206 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1207 pCreateInfos[i].pTessellationState,
1208 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1209 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1210
1211 const VkStructureType allowed_structs_VkPipelineTessellationStateCreateInfo[] = {
1212 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1213
1214 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1215 "VkPipelineTessellationDomainOriginStateCreateInfo",
1216 pCreateInfos[i].pTessellationState->pNext,
1217 ARRAY_SIZE(allowed_structs_VkPipelineTessellationStateCreateInfo),
1218 allowed_structs_VkPipelineTessellationStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001219 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1220 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001221
1222 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1223 pCreateInfos[i].pTessellationState->flags,
1224 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1225 }
1226
1227 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1228 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1229 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1230 pCreateInfos[i].pInputAssemblyState,
1231 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1232 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1233
1234 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1235 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001236 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001237
1238 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1239 pCreateInfos[i].pInputAssemblyState->flags,
1240 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1241
1242 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1243 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1244 pCreateInfos[i].pInputAssemblyState->topology,
1245 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1246
1247 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1248 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1249 }
1250
1251 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001252 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001253
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001254 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001255 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1256 "vkCreateGraphicsPipelines: pararameter "
1257 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1258 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001259 }
1260
1261 const VkStructureType allowed_structs_VkPipelineVertexInputStateCreateInfo[] = {
1262 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1263 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1264 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1265 pCreateInfos[i].pVertexInputState->pNext, 1,
1266 allowed_structs_VkPipelineVertexInputStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001267 "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
1268 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001269 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1270 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001271 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001272 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1273 skip |=
1274 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1275 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1276 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1277 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1278 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1279
1280 skip |= validate_array(
1281 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1282 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1283 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1284 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1285
1286 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
1287 for (uint32_t vertexBindingDescriptionIndex = 0;
1288 vertexBindingDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1289 ++vertexBindingDescriptionIndex) {
1290 skip |= validate_ranged_enum(
1291 "vkCreateGraphicsPipelines",
1292 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1293 AllVkVertexInputRateEnums,
1294 pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[vertexBindingDescriptionIndex].inputRate,
1295 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1296 }
1297 }
1298
1299 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
1300 for (uint32_t vertexAttributeDescriptionIndex = 0;
1301 vertexAttributeDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1302 ++vertexAttributeDescriptionIndex) {
1303 skip |= validate_ranged_enum(
1304 "vkCreateGraphicsPipelines",
1305 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1306 AllVkFormatEnums,
1307 pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[vertexAttributeDescriptionIndex].format,
1308 "VUID-VkVertexInputAttributeDescription-format-parameter");
1309 }
1310 }
1311
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001312 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001313 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1314 "vkCreateGraphicsPipelines: pararameter "
1315 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1316 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1317 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001318 }
1319
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001320 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001321 skip |=
1322 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1323 "vkCreateGraphicsPipelines: pararameter "
1324 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1325 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1326 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001327 }
1328
1329 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001330 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1331 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001332 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1333 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001334 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1335 "vkCreateGraphicsPipelines: parameter "
1336 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1337 "(%" PRIu32 ") is not distinct.",
1338 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001339 }
1340 vertex_bindings.insert(vertex_bind_desc.binding);
1341
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001342 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001343 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1344 "vkCreateGraphicsPipelines: parameter "
1345 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1346 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1347 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001348 }
1349
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001350 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001351 skip |=
1352 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1353 "vkCreateGraphicsPipelines: parameter "
1354 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1355 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1356 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001357 }
1358 }
1359
Peter Kohautc7d9d392018-07-15 00:34:07 +02001360 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001361 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1362 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001363 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1364 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001365 skip |= LogError(
1366 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001367 "vkCreateGraphicsPipelines: parameter "
1368 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1369 i, d, vertex_attrib_desc.location);
1370 }
1371 attribute_locations.insert(vertex_attrib_desc.location);
1372
1373 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1374 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001375 skip |= LogError(
1376 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001377 "vkCreateGraphicsPipelines: parameter "
1378 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1379 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1380 i, d, vertex_attrib_desc.binding, i);
1381 }
1382
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001383 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001384 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
1385 "vkCreateGraphicsPipelines: parameter "
1386 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
1387 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1388 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001389 }
1390
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001391 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001392 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
1393 "vkCreateGraphicsPipelines: parameter "
1394 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
1395 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1396 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001397 }
1398
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001399 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001400 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
1401 "vkCreateGraphicsPipelines: parameter "
1402 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1403 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1404 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001405 }
1406 }
1407 }
1408
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001409 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1410 if (has_control && has_eval) {
1411 if (pCreateInfos[i].pTessellationState == nullptr) {
1412 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
1413 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1414 "shader stage and a tessellation evaluation shader stage, "
1415 "pCreateInfos[%d].pTessellationState must not be NULL.",
1416 i, i);
1417 } else {
1418 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
1419 skip |= validate_struct_pnext(
1420 "vkCreateGraphicsPipelines",
1421 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
1422 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
1423 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
1424 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001425
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001426 skip |= validate_reserved_flags(
1427 "vkCreateGraphicsPipelines",
1428 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
1429 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001430
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001431 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1432 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
1433 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
1434 "vkCreateGraphicsPipelines: invalid parameter "
1435 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
1436 "should be >0 and <=%u.",
1437 i, pCreateInfos[i].pTessellationState->patchControlPoints,
1438 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001439 }
1440 }
1441 }
1442
1443 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1444 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1445 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1446 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001447 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
1448 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1449 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
1450 "].pViewportState (=NULL) is not a valid pointer.",
1451 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001452 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001453 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1454
1455 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001456 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
1457 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1458 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1459 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001460 }
1461
Petr Krausa6103552017-11-16 21:21:58 +01001462 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1463 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001464 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1465 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001466 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1467 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001468 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001469 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001470 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001471 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001472 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001473 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1474 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001475 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
sfricke-samsung32a27362020-02-28 09:06:42 -08001476 allowed_structs_VkPipelineViewportStateCreateInfo, 65, "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
1477 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001478
1479 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001480 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001481 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001482 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001483
Dave Houlton142c4cb2018-10-17 15:04:41 -06001484 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1485 pCreateInfos[i].pViewportState->pNext);
1486 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1487 pCreateInfos[i].pViewportState->pNext);
1488 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1489 pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01001490 const auto vp_swizzle_struct =
1491 lvl_find_in_chain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001492 const auto vp_w_scaling_struct =
1493 lvl_find_in_chain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001494
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001495 if (!physical_device_features.multiViewport) {
Petr Krausa6103552017-11-16 21:21:58 +01001496 if (viewport_state.viewportCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001497 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
1498 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1499 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
1500 ") is not 1.",
1501 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001502 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001503
Petr Krausa6103552017-11-16 21:21:58 +01001504 if (viewport_state.scissorCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001505 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
1506 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1507 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1508 ") is not 1.",
1509 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001510 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001511
Dave Houlton142c4cb2018-10-17 15:04:41 -06001512 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1513 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001514 skip |= LogError(
1515 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1516 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1517 "disabled, but pCreateInfos[%" PRIu32
1518 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1519 ") is not 1.",
1520 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001521 }
1522
Jeff Bolz9af91c52018-09-01 21:53:57 -05001523 if (shading_rate_image_struct &&
1524 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001525 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
1526 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1527 "disabled, but pCreateInfos[%" PRIu32
1528 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
1529 ") is neither 0 nor 1.",
1530 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001531 }
1532
Petr Krausa6103552017-11-16 21:21:58 +01001533 } else { // multiViewport enabled
1534 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001535 skip |= LogError(
1536 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001537 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001538 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001539 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
1540 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1541 "].pViewportState->viewportCount (=%" PRIu32
1542 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1543 i, viewport_state.viewportCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001544 }
Petr Krausa6103552017-11-16 21:21:58 +01001545
1546 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001547 skip |= LogError(
1548 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001549 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001550 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001551 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
1552 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1553 "].pViewportState->scissorCount (=%" PRIu32
1554 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1555 i, viewport_state.scissorCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001556 }
1557 }
1558
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001559 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001560 skip |=
1561 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1562 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1563 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1564 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001565 }
1566
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001567 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001568 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1569 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1570 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1571 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1572 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001573 }
1574
Petr Krausa6103552017-11-16 21:21:58 +01001575 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001576 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
1577 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1578 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
1579 "].pViewportState->viewportCount (=%" PRIu32 ").",
1580 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001581 }
1582
Dave Houlton142c4cb2018-10-17 15:04:41 -06001583 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001584 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001585 skip |=
1586 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1587 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1588 ") must be zero or identical to pCreateInfos[%" PRIu32
1589 "].pViewportState->viewportCount (=%" PRIu32 ").",
1590 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001591 }
1592
Dave Houlton142c4cb2018-10-17 15:04:41 -06001593 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001594 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001595 skip |= LogError(
1596 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001597 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1598 "] "
1599 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1600 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1601 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001602 }
1603
Petr Krausa6103552017-11-16 21:21:58 +01001604 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001605 skip |= LogError(
1606 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001607 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1608 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001609 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1610 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001611 }
1612
1613 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001614 skip |= LogError(
1615 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001616 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1617 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001618 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1619 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001620 }
1621
Jeff Bolz3e71f782018-08-29 23:15:45 -05001622 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001623 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1624 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1625 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001626 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1627 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1628 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1629 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1630 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001631 }
1632
Jeff Bolz9af91c52018-09-01 21:53:57 -05001633 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001634 shading_rate_image_struct->viewportCount > 0 &&
1635 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001636 skip |= LogError(
1637 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001638 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001639 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1640 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001641 i, i);
1642 }
1643
Chris Mayer328d8212018-12-11 14:16:18 +01001644 if (vp_swizzle_struct) {
1645 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001646 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
1647 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
1648 " does "
1649 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
1650 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01001651 }
1652 }
1653
Petr Krausb3fcdb42018-01-09 22:09:09 +01001654 // validate the VkViewports
1655 if (!has_dynamic_viewport && viewport_state.pViewports) {
1656 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1657 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001658 const char *fn_name = "vkCreateGraphicsPipelines";
1659 skip |= manual_PreCallValidateViewport(viewport, fn_name,
1660 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
1661 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001662 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01001663 }
1664 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001665
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001666 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001667 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1668 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1669 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
1670 "VK_NV_clip_space_w_scaling extension is not enabled.",
1671 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001672 }
1673
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001674 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001675 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1676 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1677 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
1678 "VK_EXT_discard_rectangles extension is not enabled.",
1679 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001680 }
1681
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001682 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001683 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1684 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1685 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
1686 "VK_EXT_sample_locations extension is not enabled.",
1687 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001688 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001689
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001690 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001691 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1692 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1693 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1694 "VK_NV_scissor_exclusive extension is not enabled.",
1695 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001696 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001697
1698 if (coarse_sample_order_struct &&
1699 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1700 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001701 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1702 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1703 "] "
1704 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1705 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1706 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001707 }
1708
1709 if (coarse_sample_order_struct) {
1710 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001711 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001712 }
1713 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001714
1715 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
1716 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001717 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
1718 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1719 "] "
1720 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
1721 ") "
1722 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
1723 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001724 }
1725 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001726 skip |= LogError(
1727 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001728 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1729 "] "
1730 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
1731 i);
1732 }
1733 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001734 }
1735
1736 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001737 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
1738 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
1739 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1740 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001741 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001742 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1743 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1744 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001745 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001746 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001747 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001748 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001749 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001750 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001751 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08001752 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
1753 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001754
1755 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001756 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001757 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001758 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001759
1760 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001761 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001762 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1763 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1764
1765 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001766 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001767 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1768 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001769 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001770 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001771
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001772 skip |= validate_flags(
1773 "vkCreateGraphicsPipelines",
1774 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1775 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02001776 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001777
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001778 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001779 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001780 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1781 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1782
1783 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001784 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001785 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1786 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1787
1788 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001789 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
1790 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
1791 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
1792 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001793 }
John Zulauf7acac592017-11-06 11:15:53 -07001794 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001795 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001796 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
1797 "vkCreateGraphicsPipelines(): parameter "
1798 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
1799 i);
John Zulauf7acac592017-11-06 11:15:53 -07001800 }
1801 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
1802 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
1803 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001804 skip |= LogError(
1805 device,
1806
Dave Houlton413a6782018-05-22 13:01:54 -06001807 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001808 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07001809 }
1810 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001811
1812 const auto *line_state = lvl_find_in_chain<VkPipelineRasterizationLineStateCreateInfoEXT>(
1813 pCreateInfos[i].pRasterizationState->pNext);
1814
1815 if (line_state) {
1816 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
1817 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
1818 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
1819 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001820 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
1821 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
1822 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
1823 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001824 }
1825 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
1826 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001827 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
1828 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
1829 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
1830 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001831 }
1832 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
1833 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001834 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
1835 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
1836 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
1837 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001838 }
1839 }
1840 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
1841 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
1842 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001843 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
1844 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
1845 "range [1,256].",
1846 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001847 }
1848 }
1849 const auto *line_features =
Tony-LunarG6c3c5452019-12-13 10:37:38 -07001850 lvl_find_in_chain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001851 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
1852 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001853 skip |=
1854 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
1855 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1856 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
1857 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001858 }
1859 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
1860 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001861 skip |=
1862 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
1863 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1864 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
1865 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001866 }
1867 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
1868 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001869 skip |=
1870 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
1871 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1872 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
1873 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001874 }
1875 if (line_state->stippledLineEnable) {
1876 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
1877 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001878 skip |=
1879 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
1880 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1881 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
1882 "stippledRectangularLines feature.",
1883 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001884 }
1885 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
1886 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001887 skip |=
1888 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
1889 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1890 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
1891 "stippledBresenhamLines feature.",
1892 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001893 }
1894 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
1895 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001896 skip |=
1897 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
1898 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1899 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
1900 "stippledSmoothLines feature.",
1901 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001902 }
1903 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
1904 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001905 skip |=
1906 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
1907 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1908 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
1909 "stippledRectangularLines and strictLines features.",
1910 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001911 }
1912 }
1913 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001914 }
1915
Petr Krause91f7a12017-12-14 20:57:36 +01001916 bool uses_color_attachment = false;
1917 bool uses_depthstencil_attachment = false;
1918 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07001919 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001920 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
1921 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01001922 const auto &subpasses_uses = subpasses_uses_it->second;
1923 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
1924 uses_color_attachment = true;
1925 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
1926 uses_depthstencil_attachment = true;
1927 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07001928 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01001929 }
1930
1931 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001932 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001933 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001934 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001935 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001936 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001937
1938 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001939 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001940 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001941 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001942
1943 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001944 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001945 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
1946 pCreateInfos[i].pDepthStencilState->depthTestEnable);
1947
1948 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001949 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001950 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
1951 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
1952
1953 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001954 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001955 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
1956 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001957 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001958
1959 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001960 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001961 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
1962 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
1963
1964 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001965 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001966 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
1967 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
1968
1969 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001970 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001971 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
1972 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001973 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001974
1975 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001976 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001977 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
1978 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001979 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001980
1981 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001982 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001983 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
1984 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001985 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001986
1987 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001988 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001989 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
1990 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001991 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001992
1993 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001994 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001995 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
1996 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001997 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001998
1999 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002000 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002001 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2002 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002003 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002004
2005 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002006 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002007 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2008 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002009 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002010
2011 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002012 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002013 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2014 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002015 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002016
2017 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002018 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
2019 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2020 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2021 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002022 }
2023 }
2024
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002025 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2026 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2027
Petr Krause91f7a12017-12-14 20:57:36 +01002028 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002029 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2030 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2031 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2032 pCreateInfos[i].pColorBlendState,
2033 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2034 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2035
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002036 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002037 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002038 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2039 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2040 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002041 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002042 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2043 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002044
2045 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002046 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002047 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002048 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002049
2050 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002051 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002052 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2053 pCreateInfos[i].pColorBlendState->logicOpEnable);
2054
2055 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002056 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002057 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2058 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002059 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002060 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002061
2062 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2063 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2064 ++attachmentIndex) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002065 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002066 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2067 ParameterName::IndexVector{i, attachmentIndex}),
2068 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2069
2070 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002071 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002072 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2073 ParameterName::IndexVector{i, attachmentIndex}),
2074 "VkBlendFactor", AllVkBlendFactorEnums,
2075 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002076 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002077
2078 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002079 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002080 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2081 ParameterName::IndexVector{i, attachmentIndex}),
2082 "VkBlendFactor", AllVkBlendFactorEnums,
2083 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002084 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002085
2086 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002087 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002088 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2089 ParameterName::IndexVector{i, attachmentIndex}),
2090 "VkBlendOp", AllVkBlendOpEnums,
2091 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002092 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002093
2094 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002095 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002096 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2097 ParameterName::IndexVector{i, attachmentIndex}),
2098 "VkBlendFactor", AllVkBlendFactorEnums,
2099 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002100 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002101
2102 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002103 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002104 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2105 ParameterName::IndexVector{i, attachmentIndex}),
2106 "VkBlendFactor", AllVkBlendFactorEnums,
2107 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002108 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002109
2110 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002111 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002112 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2113 ParameterName::IndexVector{i, attachmentIndex}),
2114 "VkBlendOp", AllVkBlendOpEnums,
2115 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002116 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002117
2118 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002119 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002120 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2121 ParameterName::IndexVector{i, attachmentIndex}),
2122 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2123 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002124 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002125 }
2126 }
2127
2128 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002129 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
2130 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2131 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2132 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002133 }
2134
2135 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2136 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2137 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002138 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002139 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002140 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2141 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002142 }
2143 }
2144 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002145
Petr Kraus9752aae2017-11-24 03:05:50 +01002146 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2147 if (pCreateInfos[i].basePipelineIndex != -1) {
2148 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002149 skip |=
2150 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
2151 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2152 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
2153 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002154 }
2155 }
2156
Petr Kraus9752aae2017-11-24 03:05:50 +01002157 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2158 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002159 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
2160 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2161 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
2162 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002163 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002164 } else {
2165 if (static_cast<const uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002166 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2167 "vkCreateGraphicsPipelines parameter pCreateInfos->basePipelineIndex (%d) must be a valid"
2168 "index into the pCreateInfos array, of size %d.",
2169 pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002170 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002171 }
2172 }
2173
Petr Kraus9752aae2017-11-24 03:05:50 +01002174 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002175 if (!device_extensions.vk_nv_fill_rectangle) {
2176 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2177 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002178 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2179 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2180 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2181 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002182 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2183 (physical_device_features.fillModeNonSolid == false)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002184 skip |= LogError(device, kVUID_PVError_DeviceFeature,
2185 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2186 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2187 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002188 }
2189 } else {
2190 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2191 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2192 (physical_device_features.fillModeNonSolid == false)) {
2193 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002194 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2195 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2196 "pCreateInfos->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2197 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002198 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002199 }
Petr Kraus299ba622017-11-24 03:09:03 +01002200
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002201 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002202 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002203 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2204 "The line width state is static (pCreateInfos[%" PRIu32
2205 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2206 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2207 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2208 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002209 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002210 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002211 }
2212 }
2213
2214 return skip;
2215}
2216
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002217bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2218 uint32_t createInfoCount,
2219 const VkComputePipelineCreateInfo *pCreateInfos,
2220 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002221 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002222 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002223 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002224 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002225 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002226 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Peter Chen85366392019-05-14 15:20:11 -04002227 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
2228 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002229 skip |=
2230 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2231 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2232 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2233 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002234 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002235
2236 // Make sure compute stage is selected
2237 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002238 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2239 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2240 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002241 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002242 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002243 return skip;
2244}
2245
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002246bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002247 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002248 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002249
2250 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002251 const auto &features = physical_device_features;
2252 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002253
John Zulauf71968502017-10-26 13:51:15 -06002254 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2255 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002256 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2257 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2258 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2259 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002260 }
2261
2262 // Anistropy cannot be enabled in sampler unless enabled as a feature
2263 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002264 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2265 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2266 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002267 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002268 }
John Zulauf71968502017-10-26 13:51:15 -06002269
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002270 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2271 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002272 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2273 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2274 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2275 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002276 }
2277 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002278 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2279 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2280 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2281 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002282 }
2283 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002284 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2285 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2286 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2287 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002288 }
2289 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2290 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2291 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2292 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002293 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2294 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2295 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2296 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2297 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2298 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002299 }
2300 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002301 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2302 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2303 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002304 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002305 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002306 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2307 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2308 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002309 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002310 }
2311
2312 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2313 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002314 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2315 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002316 }
2317
2318 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2319 // valid VkBorderColor value
2320 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2321 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2322 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002323 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
2324 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002325 }
2326
2327 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2328 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002329 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002330 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2331 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2332 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002333 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002334 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
2335 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2336 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002337 }
John Zulauf275805c2017-10-26 15:34:49 -06002338
2339 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002340 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06002341 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2342 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002343 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
2344 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
2345 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002346 }
2347 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002348
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002349 // Check for valid Lod range
2350 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002351 skip |=
2352 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
2353 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002354 }
2355
2356 // Check mipLodBias to device limit
2357 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002358 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
2359 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
2360 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002361 }
2362
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002363 const auto *sampler_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
2364 if (sampler_conversion != nullptr) {
2365 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2366 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2367 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2368 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002369 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002370 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002371 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
2372 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
2373 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
2374 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
2375 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
2376 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
2377 }
2378 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002379 }
2380
2381 return skip;
2382}
2383
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002384bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
2385 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2386 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002387 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002388 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002389
2390 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2391 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2392 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2393 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2394 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2395 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2396 // valid VkSampler handles
2397 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2398 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2399 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2400 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2401 ++descriptor_index) {
2402 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002403 skip |= LogError(device, kVUID_PVError_RequiredParameter,
2404 "vkCreateDescriptorSetLayout: required parameter "
2405 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
2406 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002407 }
2408 }
2409 }
2410
2411 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2412 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2413 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002414 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
2415 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2416 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
2417 "values.",
2418 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002419 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07002420
2421 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
2422 (pCreateInfo->pBindings[i].stageFlags != 0) &&
2423 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
2424 skip |=
2425 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
2426 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
2427 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
2428 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
2429 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
2430 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002431 }
2432 }
2433 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002434 return skip;
2435}
2436
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002437bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
2438 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002439 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002440 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2441 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2442 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002443 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
2444 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002445}
2446
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002447bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
2448 const VkWriteDescriptorSet *pDescriptorWrites,
2449 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002450 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002451
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002452 if (pDescriptorWrites != NULL) {
2453 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2454 // descriptorCount must be greater than 0
2455 if (pDescriptorWrites[i].descriptorCount == 0) {
2456 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002457 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
2458 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002459 }
2460
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002461 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
2462 if (validateDstSet) {
2463 // dstSet must be a valid VkDescriptorSet handle
2464 skip |= validate_required_handle(vkCallingFunction,
2465 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2466 pDescriptorWrites[i].dstSet);
2467 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002468
2469 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2470 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2471 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2472 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2473 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2474 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2475 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2476 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2477 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002478 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
2479 "%s(): if pDescriptorWrites[%d].descriptorType is "
2480 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2481 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
2482 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2483 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002484 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2485 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2486 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2487 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2488 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2489 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002490 skip |= validate_required_handle(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002491 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2492 ParameterName::IndexVector{i, descriptor_index}),
2493 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002494 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002495 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2496 ParameterName::IndexVector{i, descriptor_index}),
2497 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002498 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002499 }
2500 }
2501 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2502 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2503 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2504 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2505 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2506 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2507 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2508 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002509 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
2510 "%s(): if pDescriptorWrites[%d].descriptorType is "
2511 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2512 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
2513 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2514 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002515 } else {
2516 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002517 skip |= validate_required_handle(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002518 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2519 ParameterName::IndexVector{i, descriptorIndex}),
2520 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2521 }
2522 }
2523 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2524 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2525 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2526 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2527 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002528 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00323",
2529 "%s(): if pDescriptorWrites[%d].descriptorType is "
2530 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
2531 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2532 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002533 } else {
2534 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2535 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002536 skip |= validate_required_handle(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002537 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2538 ParameterName::IndexVector{i, descriptor_index}),
2539 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2540 }
2541 }
2542 }
2543
2544 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2545 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002546 VkDeviceSize uniformAlignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002547 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2548 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2549 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002550 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002551 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
2552 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2553 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2554 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002555 }
2556 }
2557 }
2558 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2559 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002560 VkDeviceSize storageAlignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002561 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2562 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2563 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002564 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002565 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
2566 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2567 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2568 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002569 }
2570 }
2571 }
2572 }
2573 }
2574 }
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002575
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002576 return skip;
2577}
2578
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002579bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
2580 const VkWriteDescriptorSet *pDescriptorWrites,
2581 uint32_t descriptorCopyCount,
2582 const VkCopyDescriptorSet *pDescriptorCopies) const {
2583 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
2584}
2585
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002586bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002587 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002588 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002589 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
2590}
2591
2592bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002593 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002594 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002595 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
2596}
2597
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002598bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
2599 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002600 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002601 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002602
2603 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2604 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2605 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002606 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
2607 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002608 return skip;
2609}
2610
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002611bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002612 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002613 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02002614
2615 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
2616 const char *cmd_name = "vkBeginCommandBuffer";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002617 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2618
Petr Krause7bb9e82019-08-11 21:34:43 +02002619 // Implicit VUs
2620 // validate only sType here; pointer has to be validated in core_validation
2621 const bool kNotRequired = false;
2622 const char *kNoVUID = nullptr;
2623 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
2624 pInfo, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, kNotRequired, kNoVUID,
2625 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002626
Petr Krause7bb9e82019-08-11 21:34:43 +02002627 if (pInfo) {
2628 const VkStructureType allowed_structs_VkCommandBufferInheritanceInfo[] = {
2629 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
2630 skip |= validate_struct_pnext(
2631 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT", pInfo->pNext,
2632 ARRAY_SIZE(allowed_structs_VkCommandBufferInheritanceInfo), allowed_structs_VkCommandBufferInheritanceInfo,
sfricke-samsung32a27362020-02-28 09:06:42 -08002633 GeneratedVulkanHeaderVersion, "VUID-VkCommandBufferInheritanceInfo-pNext-pNext",
2634 "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002635
Petr Krause7bb9e82019-08-11 21:34:43 +02002636 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", pInfo->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002637
Petr Krause7bb9e82019-08-11 21:34:43 +02002638 // Explicit VUs
2639 if (!physical_device_features.inheritedQueries && pInfo->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002640 skip |= LogError(
2641 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Petr Krause7bb9e82019-08-11 21:34:43 +02002642 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
2643 cmd_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002644 }
Petr Krause7bb9e82019-08-11 21:34:43 +02002645
2646 if (physical_device_features.inheritedQueries) {
2647 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02002648 AllVkQueryControlFlagBits, pInfo->queryFlags, kOptionalFlags,
Dave Houlton413a6782018-05-22 13:01:54 -06002649 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Petr Krause7bb9e82019-08-11 21:34:43 +02002650 } else { // !inheritedQueries
Petr Krause7bb9e82019-08-11 21:34:43 +02002651 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", pInfo->queryFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02002652 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Petr Krause7bb9e82019-08-11 21:34:43 +02002653 }
2654
2655 if (physical_device_features.pipelineStatisticsQuery) {
Petr Krause7bb9e82019-08-11 21:34:43 +02002656 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02002657 AllVkQueryPipelineStatisticFlagBits, pInfo->pipelineStatistics, kOptionalFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02002658 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
Petr Krause7bb9e82019-08-11 21:34:43 +02002659 } else { // !pipelineStatisticsQuery
2660 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", pInfo->pipelineStatistics,
2661 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002662 }
Petr Kraus139757b2019-08-15 17:19:33 +02002663
2664 const auto *conditional_rendering = lvl_find_in_chain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(pInfo->pNext);
2665 if (conditional_rendering) {
Tony-LunarG6c3c5452019-12-13 10:37:38 -07002666 const auto *cr_features = lvl_find_in_chain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Petr Kraus139757b2019-08-15 17:19:33 +02002667 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
2668 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002669 skip |= LogError(
2670 commandBuffer, "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Petr Kraus139757b2019-08-15 17:19:33 +02002671 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
2672 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
2673 }
2674 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002675 }
2676
2677 return skip;
2678}
2679
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002680bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002681 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002682 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002683
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002684 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01002685 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002686 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
2687 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2688 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002689 }
2690 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002691 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
2692 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2693 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002694 }
2695 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002696 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002697 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002698 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
2699 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
2700 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2701 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002702 }
2703 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002704
2705 if (pViewports) {
2706 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2707 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002708 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002709 skip |= manual_PreCallValidateViewport(
2710 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01002711 }
2712 }
2713
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002714 return skip;
2715}
2716
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002717bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002718 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002719 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002720
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002721 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002722 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002723 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
2724 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2725 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002726 }
2727 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002728 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
2729 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2730 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002731 }
2732 } else { // multiViewport enabled
2733 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002734 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002735 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
2736 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
2737 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2738 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002739 }
2740 }
2741
Petr Kraus6260f0a2018-02-27 21:15:55 +01002742 if (pScissors) {
2743 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2744 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002745
Petr Kraus6260f0a2018-02-27 21:15:55 +01002746 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002747 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
2748 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2749 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002750 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002751
Petr Kraus6260f0a2018-02-27 21:15:55 +01002752 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002753 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
2754 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2755 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002756 }
2757
2758 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2759 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002760 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
2761 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
2762 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2763 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002764 }
2765
2766 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2767 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002768 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
2769 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
2770 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2771 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002772 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002773 }
2774 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002775
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002776 return skip;
2777}
2778
Jeff Bolz5c801d12019-10-09 10:38:45 -05002779bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01002780 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01002781
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002782 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002783 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
2784 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002785 }
2786
2787 return skip;
2788}
2789
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002790bool StatelessValidation::manual_PreCallValidateCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002791 uint32_t firstVertex, uint32_t firstInstance) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002792 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002793 if (vertexCount == 0) {
2794 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2795 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002796 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002797 }
2798
2799 if (instanceCount == 0) {
2800 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2801 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002802 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002803 }
2804 return skip;
2805}
2806
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002807bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002808 uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002809 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002810
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002811 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002812 skip |= LogError(device, kVUID_PVError_DeviceFeature,
2813 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002814 }
2815 return skip;
2816}
2817
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002818bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002819 VkDeviceSize offset, uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002820 bool skip = false;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002821 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002822 skip |=
2823 LogError(device, kVUID_PVError_DeviceFeature,
2824 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002825 }
2826 return skip;
2827}
2828
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06002829bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
2830 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002831 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06002832 bool skip = false;
2833 for (uint32_t rect = 0; rect < rectCount; rect++) {
2834 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002835 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
2836 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06002837 }
2838 }
2839 return skip;
2840}
2841
Andrew Fobel3abeb992020-01-20 16:33:22 -05002842bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
2843 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
2844 VkImageFormatProperties2 *pImageFormatProperties,
2845 const char *apiName) const {
2846 bool skip = false;
2847
2848 if (pImageFormatInfo != nullptr) {
2849 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pImageFormatInfo->pNext);
2850 if (image_stencil_struct != nullptr) {
2851 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
2852 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
2853 // No flags other than the legal attachment bits may be set
2854 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
2855 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002856 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
2857 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
2858 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
2859 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
2860 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05002861 }
2862 }
2863 }
2864 }
2865
2866 return skip;
2867}
2868
2869bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
2870 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
2871 VkImageFormatProperties2 *pImageFormatProperties) const {
2872 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
2873 "vkGetPhysicalDeviceImageFormatProperties2");
2874}
2875
2876bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
2877 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
2878 VkImageFormatProperties2 *pImageFormatProperties) const {
2879 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
2880 "vkGetPhysicalDeviceImageFormatProperties2KHR");
2881}
2882
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002883bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage,
2884 VkImageLayout srcImageLayout, VkImage dstImage,
2885 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002886 const VkImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002887 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002888
Dave Houltonf5217612018-02-02 16:18:52 -07002889 VkImageAspectFlags legal_aspect_flags =
2890 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002891 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002892 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2893 }
2894
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002895 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002896 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002897 skip |= LogError(
2898 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002899 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002900 }
Dave Houltonf5217612018-02-02 16:18:52 -07002901 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002902 skip |= LogError(
2903 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002904 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002905 }
2906 }
2907 return skip;
2908}
2909
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002910bool StatelessValidation::manual_PreCallValidateCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage,
2911 VkImageLayout srcImageLayout, VkImage dstImage,
2912 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002913 const VkImageBlit *pRegions, VkFilter filter) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002914 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002915
Dave Houltonf5217612018-02-02 16:18:52 -07002916 VkImageAspectFlags legal_aspect_flags =
2917 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002918 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002919 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2920 }
2921
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002922 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002923 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002924 skip |= LogError(
2925 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002926 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2927 }
Dave Houltonf5217612018-02-02 16:18:52 -07002928 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002929 skip |= LogError(
2930 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002931 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2932 }
2933 }
2934 return skip;
2935}
2936
sfricke-samsung3999ef62020-02-09 17:05:59 -08002937bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
2938 uint32_t regionCount, const VkBufferCopy *pRegions) const {
2939 bool skip = false;
2940
2941 if (pRegions != nullptr) {
2942 for (uint32_t i = 0; i < regionCount; i++) {
2943 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002944 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
2945 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08002946 }
2947 }
2948 }
2949 return skip;
2950}
2951
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002952bool StatelessValidation::manual_PreCallValidateCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer,
2953 VkImage dstImage, VkImageLayout dstImageLayout,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002954 uint32_t regionCount,
2955 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002956 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002957
Dave Houltonf5217612018-02-02 16:18:52 -07002958 VkImageAspectFlags legal_aspect_flags =
2959 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002960 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002961 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2962 }
2963
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002964 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002965 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002966 skip |= LogError(device, kVUID_PVError_UnrecognizedValue,
2967 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2968 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002969 }
2970 }
2971 return skip;
2972}
2973
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002974bool StatelessValidation::manual_PreCallValidateCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage,
2975 VkImageLayout srcImageLayout, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002976 uint32_t regionCount,
2977 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002978 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002979
Dave Houltonf5217612018-02-02 16:18:52 -07002980 VkImageAspectFlags legal_aspect_flags =
2981 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002982 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002983 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2984 }
2985
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002986 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002987 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002988 LogError(device, kVUID_PVError_UnrecognizedValue,
2989 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2990 "enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002991 }
2992 }
2993 return skip;
2994}
2995
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002996bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002997 VkDeviceSize dstOffset, VkDeviceSize dataSize,
2998 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002999 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003000
3001 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003002 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
3003 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3004 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003005 }
3006
3007 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003008 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3009 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3010 "), must be greater than zero and less than or equal to 65536.",
3011 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003012 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003013 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3014 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3015 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003016 }
3017 return skip;
3018}
3019
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003020bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003021 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003022 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003023
3024 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003025 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3026 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3027 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003028 }
3029
3030 if (size != VK_WHOLE_SIZE) {
3031 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003032 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003033 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3034 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003035 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003036 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3037 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003038 }
3039 }
3040 return skip;
3041}
3042
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003043bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003044 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003045 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003046 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003047
3048 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003049 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3050 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3051 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3052 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003053 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3054 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3055 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003056 }
3057
3058 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3059 // queueFamilyIndexCount uint32_t values
3060 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003061 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3062 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3063 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3064 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003065 }
3066 }
3067
Dave Houlton413a6782018-05-22 13:01:54 -06003068 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003069 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003070 }
3071
3072 return skip;
3073}
3074
Jeff Bolz5c801d12019-10-09 10:38:45 -05003075bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003076 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003077
3078 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003079 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3080 if (present_regions) {
3081 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003082 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003083 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3084 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003085 skip |= LogError(device, kVUID_PVError_InvalidUsage,
3086 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3087 "extension swapchainCount is %i. These values must be equal.",
3088 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003089 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003090 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003091 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3092 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003093 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3094 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3095 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003096 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003097 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003098 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003099 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003100 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003101 }
3102 }
3103
3104 return skip;
3105}
3106
3107#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003108bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3109 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3110 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003111 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003112 bool skip = false;
3113
3114 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003115 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3116 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003117 }
3118
3119 return skip;
3120}
3121#endif // VK_USE_PLATFORM_WIN32_KHR
3122
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003123bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003124 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003125 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003126 bool skip = false;
3127
3128 if (pCreateInfo) {
3129 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003130 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3131 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003132 }
3133
3134 if (pCreateInfo->pPoolSizes) {
3135 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3136 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003137 skip |= LogError(
3138 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003139 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003140 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003141 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3142 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003143 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3144 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3145 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3146 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3147 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003148 }
Petr Krausc8655be2017-09-27 18:56:51 +02003149 }
3150 }
3151 }
3152
3153 return skip;
3154}
3155
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003156bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003157 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003158 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003159
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003160 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003161 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003162 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
3163 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3164 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003165 }
3166
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003167 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003168 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003169 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
3170 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3171 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003172 }
3173
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003174 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003175 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003176 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
3177 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3178 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003179 }
3180
3181 return skip;
3182}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003183
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003184bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003185 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07003186 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07003187
3188 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003189 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
3190 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07003191 }
3192 return skip;
3193}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003194
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003195bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
3196 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003197 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003198 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003199
3200 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003201 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003202 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003203 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
3204 "vkCmdDispatch(): baseGroupX (%" PRIu32
3205 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3206 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003207 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003208 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
3209 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
3210 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3211 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003212 }
3213
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003214 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003215 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003216 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
3217 "vkCmdDispatch(): baseGroupY (%" PRIu32
3218 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3219 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003220 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003221 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
3222 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
3223 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3224 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003225 }
3226
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003227 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003228 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003229 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
3230 "vkCmdDispatch(): baseGroupZ (%" PRIu32
3231 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3232 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003233 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003234 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
3235 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
3236 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3237 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003238 }
3239
3240 return skip;
3241}
3242
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003243bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
3244 VkPipelineBindPoint pipelineBindPoint,
3245 VkPipelineLayout layout, uint32_t set,
3246 uint32_t descriptorWriteCount,
3247 const VkWriteDescriptorSet *pDescriptorWrites) const {
3248 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
3249}
3250
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003251bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
3252 uint32_t firstExclusiveScissor,
3253 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003254 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003255 bool skip = false;
3256
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003257 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003258 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003259 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003260 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3261 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3262 ") is not 0.",
3263 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003264 }
3265 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003266 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003267 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3268 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3269 ") is not 1.",
3270 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003271 }
3272 } else { // multiViewport enabled
3273 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003274 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003275 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3276 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3277 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3278 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003279 }
3280 }
3281
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003282 if (firstExclusiveScissor >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003283 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3284 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32
3285 ") must be less than maxViewports (=%" PRIu32 ").",
3286 firstExclusiveScissor, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003287 }
3288
3289 if (pExclusiveScissors) {
3290 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3291 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3292
3293 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003294 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3295 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3296 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003297 }
3298
3299 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003300 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3301 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3302 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003303 }
3304
3305 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3306 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003307 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3308 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3309 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3310 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003311 }
3312
3313 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3314 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003315 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3316 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3317 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3318 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003319 }
3320 }
3321 }
3322
3323 return skip;
3324}
3325
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003326bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
3327 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003328 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003329 bool skip = false;
3330 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003331 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01323",
3332 "vkCmdSetViewportWScalingNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3333 firstViewport, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003334 } else {
3335 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3336 if ((sum < 1) || (sum > device_limits.maxViewports)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003337 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
3338 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3339 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
3340 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003341 }
3342 }
3343
3344 return skip;
3345}
3346
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003347bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
3348 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003349 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003350 bool skip = false;
3351
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003352 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003353 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003354 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003355 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3356 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3357 ") is not 0.",
3358 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003359 }
3360 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003361 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003362 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3363 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3364 ") is not 1.",
3365 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003366 }
3367 }
3368
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003369 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003370 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
3371 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3372 ") must be less than maxViewports (=%" PRIu32 ").",
3373 firstViewport, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003374 }
3375
3376 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003377 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003378 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3379 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
3380 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3381 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003382 }
3383
3384 return skip;
3385}
3386
Jeff Bolz5c801d12019-10-09 10:38:45 -05003387bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
3388 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
3389 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003390 bool skip = false;
3391
Dave Houlton142c4cb2018-10-17 15:04:41 -06003392 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003393 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3394 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3395 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05003396 }
3397
3398 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003399 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003400 }
3401
3402 return skip;
3403}
3404
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003405bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003406 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003407 bool skip = false;
3408
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003409 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003410 skip |= LogError(
3411 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003412 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3413 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003414 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003415 }
3416
3417 return skip;
3418}
3419
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003420bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
3421 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003422 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003423 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06003424 static const int condition_multiples = 0b0011;
3425 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003426 skip |= LogError(
3427 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003428 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003429 }
Lockee1c22882019-06-10 16:02:54 -06003430 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003431 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3432 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3433 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3434 stride);
Lockee1c22882019-06-10 16:02:54 -06003435 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003436 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003437 skip |= LogError(
3438 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
3439 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06003440 }
3441
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003442 return skip;
3443}
3444
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003445bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
3446 VkDeviceSize offset, VkBuffer countBuffer,
3447 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003448 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003449 bool skip = false;
3450
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003451 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003452 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
3453 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3454 "), is not a multiple of 4.",
3455 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003456 }
3457
3458 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003459 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
3460 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3461 "), is not a multiple of 4.",
3462 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003463 }
3464
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003465 return skip;
3466}
3467
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003468bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003469 const VkAllocationCallbacks *pAllocator,
3470 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003471 bool skip = false;
3472
3473 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3474 if (pCreateInfo != nullptr) {
3475 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
3476 // VkQueryPipelineStatisticFlagBits values
3477 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
3478 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003479 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
3480 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
3481 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
3482 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003483 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003484 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003485 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003486}
3487
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003488bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3489 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003490 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003491 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
3492 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003493}
3494
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003495void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07003496 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
3497 VkResult result) {
3498 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003499 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003500}
3501
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003502void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07003503 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
3504 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003505 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07003506 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003507 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003508}
3509
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003510void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
3511 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003512 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07003513 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003514 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003515}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003516
3517bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003518 const VkAllocationCallbacks *pAllocator,
3519 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003520 bool skip = false;
3521
3522 if (pAllocateInfo) {
3523 auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
3524 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003525 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
3526 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003527 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003528
3529 VkMemoryAllocateFlags flags = 0;
3530 auto flags_info = lvl_find_in_chain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
3531 if (flags_info) {
3532 flags = flags_info->flags;
3533 }
3534
3535 auto opaque_alloc_info = lvl_find_in_chain<VkMemoryOpaqueCaptureAddressAllocateInfoKHR>(pAllocateInfo->pNext);
3536 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
3537 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003538 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
3539 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
3540 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003541 }
3542
3543#ifdef VK_USE_PLATFORM_WIN32_KHR
3544 auto import_memory_win32_handle = lvl_find_in_chain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
3545#endif
3546 auto import_memory_fd = lvl_find_in_chain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
3547 auto import_memory_host_pointer = lvl_find_in_chain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
3548#ifdef VK_USE_PLATFORM_ANDROID_KHR
3549 auto import_memory_ahb = lvl_find_in_chain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
3550#endif
3551
3552 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003553 skip |= LogError(
3554 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003555 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
3556 }
3557 if (
3558#ifdef VK_USE_PLATFORM_WIN32_KHR
3559 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
3560#endif
3561 (import_memory_fd && import_memory_fd->handleType) ||
3562#ifdef VK_USE_PLATFORM_ANDROID_KHR
3563 (import_memory_ahb && import_memory_ahb->buffer) ||
3564#endif
3565 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003566 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
3567 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003568 }
3569 }
3570
3571 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07003572 VkBool32 capture_replay = false;
3573 VkBool32 buffer_device_address = false;
3574 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
3575 if (vulkan_12_features) {
3576 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
3577 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
3578 } else {
3579 const auto *bda_features =
3580 lvl_find_in_chain<VkPhysicalDeviceBufferDeviceAddressFeaturesKHR>(device_createinfo_pnext);
3581 if (bda_features) {
3582 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
3583 buffer_device_address = bda_features->bufferDeviceAddress;
3584 }
3585 }
3586 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003587 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
3588 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR is set, "
3589 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003590 }
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07003591 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003592 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
3593 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003594 }
3595 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003596 }
3597 return skip;
3598}
Ricardo Garciaa4935972019-02-21 17:43:18 +01003599
Jason Macnak192fa0e2019-07-26 15:07:16 -07003600bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003601 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07003602 bool skip = false;
3603
3604 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
3605 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
3606 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003607 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003608 } else {
3609 uint32_t vertex_component_size = 0;
3610 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
3611 vertex_component_size = 4;
3612 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
3613 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
3614 vertex_component_size = 2;
3615 }
3616 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003617 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003618 }
3619 }
3620
3621 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
3622 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003623 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003624 } else {
3625 uint32_t index_element_size = 0;
3626 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
3627 index_element_size = 4;
3628 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
3629 index_element_size = 2;
3630 }
3631 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003632 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003633 }
3634 }
3635 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
3636 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003637 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003638 }
3639 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003640 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003641 }
3642 }
3643
3644 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003645 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003646 }
3647
3648 return skip;
3649}
3650
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003651bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
3652 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07003653 bool skip = false;
3654
3655 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003656 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003657 }
3658 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003659 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003660 }
3661
3662 return skip;
3663}
3664
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003665bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
3666 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07003667 bool skip = false;
3668 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003669 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003670 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003671 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003672 }
3673 return skip;
3674}
3675
3676bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003677 VkAccelerationStructureNV object_handle,
Jason Macnak192fa0e2019-07-26 15:07:16 -07003678 const char *func_name) const {
Jason Macnak5c954952019-07-09 15:46:12 -07003679 bool skip = false;
3680 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003681 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
3682 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
3683 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07003684 }
3685 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003686 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
3687 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
3688 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07003689 }
3690 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
3691 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003692 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
3693 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
3694 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07003695 }
3696 if (info.geometryCount > phys_dev_ext_props.ray_tracing_props.maxGeometryCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003697 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
3698 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
3699 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07003700 }
3701 if (info.instanceCount > phys_dev_ext_props.ray_tracing_props.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003702 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
3703 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
3704 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07003705 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07003706 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07003707 uint64_t total_triangle_count = 0;
3708 for (uint32_t i = 0; i < info.geometryCount; i++) {
3709 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07003710
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003711 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003712
Jason Macnak5c954952019-07-09 15:46:12 -07003713 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
3714 continue;
3715 }
3716 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
3717 }
3718 if (total_triangle_count > phys_dev_ext_props.ray_tracing_props.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003719 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
3720 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
3721 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07003722 }
3723 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07003724 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
3725 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
3726 for (uint32_t i = 1; i < info.geometryCount; i++) {
3727 const VkGeometryNV &geometry = info.pGeometries[i];
3728 if (geometry.geometryType != first_geometry_type) {
3729 // TODO: update fake VUID below with the real one once it is generated.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003730 skip |= LogError(device, "UNASSIGNED-VkAccelerationStructureInfoNV-pGeometries-XXXX",
3731 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
3732 "info.pGeometries[0].geometryType.",
3733 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07003734 }
3735 }
3736 }
Jason Macnak5c954952019-07-09 15:46:12 -07003737 return skip;
3738}
3739
Ricardo Garciaa4935972019-02-21 17:43:18 +01003740bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
3741 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003742 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01003743 bool skip = false;
3744
3745 if (pCreateInfo) {
3746 if ((pCreateInfo->compactedSize != 0) &&
3747 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003748 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
3749 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
3750 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
3751 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01003752 }
Jason Macnak5c954952019-07-09 15:46:12 -07003753
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003754 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
Jason Macnak192fa0e2019-07-26 15:07:16 -07003755 "vkCreateAccelerationStructureNV()");
Ricardo Garciaa4935972019-02-21 17:43:18 +01003756 }
3757
3758 return skip;
3759}
Mike Schuchardt21638df2019-03-16 10:52:02 -07003760
Jeff Bolz5c801d12019-10-09 10:38:45 -05003761bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
3762 const VkAccelerationStructureInfoNV *pInfo,
3763 VkBuffer instanceData, VkDeviceSize instanceOffset,
3764 VkBool32 update, VkAccelerationStructureNV dst,
3765 VkAccelerationStructureNV src, VkBuffer scratch,
3766 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07003767 bool skip = false;
3768
3769 if (pInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003770 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()");
Jason Macnak5c954952019-07-09 15:46:12 -07003771 }
3772
3773 return skip;
3774}
3775
3776bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
3777 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003778 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07003779 bool skip = false;
3780 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003781 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
3782 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07003783 }
3784 return skip;
3785}
3786
Peter Chen85366392019-05-14 15:20:11 -04003787bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
3788 uint32_t createInfoCount,
3789 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
3790 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003791 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04003792 bool skip = false;
3793
3794 for (uint32_t i = 0; i < createInfoCount; i++) {
3795 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
3796 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003797 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
3798 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
3799 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
3800 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
3801 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04003802 }
3803 }
3804
3805 return skip;
3806}
3807
Mike Schuchardt21638df2019-03-16 10:52:02 -07003808#ifdef VK_USE_PLATFORM_WIN32_KHR
3809bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
3810 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003811 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07003812 bool skip = false;
3813 if (!device_extensions.vk_khr_swapchain)
3814 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
3815 if (!device_extensions.vk_khr_get_surface_capabilities_2)
3816 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
3817 if (!device_extensions.vk_khr_surface)
3818 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
3819 if (!device_extensions.vk_khr_get_physical_device_properties_2)
3820 skip |=
3821 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
3822 if (!device_extensions.vk_ext_full_screen_exclusive)
3823 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
3824 skip |= validate_struct_type(
3825 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
3826 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
3827 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
3828 if (pSurfaceInfo != NULL) {
3829 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
3830 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
3831 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
3832
3833 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
3834 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
3835 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
3836 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08003837 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
3838 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07003839
3840 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
3841 }
3842 return skip;
3843}
3844#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01003845
3846bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
3847 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003848 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01003849 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3850 bool skip = false;
3851 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT_KHR) == 0) {
3852 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
3853 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
3854 }
3855 return skip;
3856}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003857
3858bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003859 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003860 bool skip = false;
3861
3862 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003863 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
3864 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003865 }
3866
3867 return skip;
3868}
Piers Daniell8fd03f52019-08-21 12:07:53 -06003869
3870bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003871 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06003872 bool skip = false;
3873
3874 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003875 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
3876 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06003877 }
3878
Tony-LunarG6c3c5452019-12-13 10:37:38 -07003879 const auto *index_type_uint8_features = lvl_find_in_chain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Piers Daniell8fd03f52019-08-21 12:07:53 -06003880 if (indexType == VK_INDEX_TYPE_UINT8_EXT && !index_type_uint8_features->indexTypeUint8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003881 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
3882 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06003883 }
3884
3885 return skip;
3886}
Mark Lobodzinski84988402019-09-11 15:27:30 -06003887
sfricke-samsung4ada8d42020-02-09 17:43:11 -08003888bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
3889 uint32_t bindingCount, const VkBuffer *pBuffers,
3890 const VkDeviceSize *pOffsets) const {
3891 bool skip = false;
3892 if (firstBinding > device_limits.maxVertexInputBindings) {
3893 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
3894 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
3895 device_limits.maxVertexInputBindings);
3896 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
3897 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
3898 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
3899 "maxVertexInputBindings (%u)",
3900 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
3901 }
3902
3903 return skip;
3904}
3905
Mark Lobodzinski84988402019-09-11 15:27:30 -06003906bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003907 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06003908 bool skip = false;
3909 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003910 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
3911 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06003912 }
3913 return skip;
3914}
3915
3916bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003917 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06003918 bool skip = false;
3919 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003920 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
3921 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06003922 }
3923 return skip;
3924}
Petr Kraus3d720392019-11-13 02:52:39 +01003925
3926bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
3927 VkSemaphore semaphore, VkFence fence,
3928 uint32_t *pImageIndex) const {
3929 bool skip = false;
3930
3931 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003932 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
3933 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01003934 }
3935
3936 return skip;
3937}
3938
3939bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
3940 uint32_t *pImageIndex) const {
3941 bool skip = false;
3942
3943 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003944 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
3945 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01003946 }
3947
3948 return skip;
3949}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07003950
3951bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
3952 uint32_t firstInstance, VkBuffer counterBuffer,
3953 VkDeviceSize counterBufferOffset,
3954 uint32_t counterOffset, uint32_t vertexStride) const {
3955 bool skip = false;
3956
3957 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003958 skip |= LogError(
3959 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07003960 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
3961 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
3962 }
3963
3964 return skip;
3965}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08003966
3967bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
3968 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
3969 const VkAllocationCallbacks *pAllocator,
3970 VkSamplerYcbcrConversion *pYcbcrConversion,
3971 const char *apiName) const {
3972 bool skip = false;
3973
3974 // Check samplerYcbcrConversion feature is set
Tony-LunarG6c3c5452019-12-13 10:37:38 -07003975 const auto *ycbcr_features = lvl_find_in_chain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08003976 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003977 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
3978 "samplerYcbcrConversion must be enabled to call %s.", apiName);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08003979 }
3980 return skip;
3981}
3982
3983bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
3984 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
3985 const VkAllocationCallbacks *pAllocator,
3986 VkSamplerYcbcrConversion *pYcbcrConversion) const {
3987 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
3988 "vkCreateSamplerYcbcrConversion");
3989}
3990
3991bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
3992 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3993 VkSamplerYcbcrConversion *pYcbcrConversion) const {
3994 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
3995 "vkCreateSamplerYcbcrConversionKHR");
3996}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08003997
3998bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
3999 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
4000 bool skip = false;
4001 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
4002 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
4003
4004 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004005 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
4006 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
4007 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
4008 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
4009 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08004010 }
4011 return skip;
4012}