blob: d7b889623568b8248cdea5f231d4cc0c9556abc1 [file] [log] [blame]
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07001/* Copyright (c) 2015-2021 The Khronos Group Inc.
2 * Copyright (c) 2015-2021 Valve Corporation
3 * Copyright (c) 2015-2021 LunarG, Inc.
4 * Copyright (C) 2015-2021 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070028static const int kMaxParamCheckerStringLength = 256;
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinski21b91fe2020-12-03 15:44:24 -070036read_lock_guard_t StatelessValidation::read_lock() { return read_lock_guard_t(validation_object_mutex, std::defer_lock); }
37write_lock_guard_t StatelessValidation::write_lock() { return write_lock_guard_t(validation_object_mutex, std::defer_lock); }
38
Jeremy Gebbencbf22862021-03-03 12:01:22 -070039static layer_data::unordered_map<VkCommandBuffer, VkCommandPool> secondary_cb_map{};
Tony-LunarG3c287f62020-12-17 12:39:49 -070040static ReadWriteLock secondary_cb_map_mutex;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -070041static read_lock_guard_t cb_read_lock() { return read_lock_guard_t(secondary_cb_map_mutex); }
42static write_lock_guard_t cb_write_lock() { return write_lock_guard_t(secondary_cb_map_mutex); }
Tony-LunarG3c287f62020-12-17 12:39:49 -070043
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070044bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050045 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060046 bool skip = false;
47
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070048 VkStringErrorFlags result = vk_string_validate(kMaxParamCheckerStringLength, validateString);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50 if (result == VK_STRING_ERROR_NONE) {
51 return skip;
52 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070053 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070054 kMaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060055 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070056 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
57 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060058 }
59 return skip;
60}
61
Jeff Bolz46c0ea02019-10-09 13:06:29 -050062bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060063 bool skip = false;
64 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
65 if (api_version_nopatch != effective_api_version) {
sfricke-samsung6aec21b2020-11-01 07:49:43 -080066 if ((api_version_nopatch < VK_API_VERSION_1_0) && (api_version != 0)) {
67 skip |= LogError(instance, "VUID-VkApplicationInfo-apiVersion-04010",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070068 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
69 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
70 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060071 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070072 skip |= LogWarning(instance, kVUIDUndefined,
73 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
74 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
75 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060076 }
77 }
78 return skip;
79}
80
Jeff Bolz46c0ea02019-10-09 13:06:29 -050081bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060082 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060083 // Create and use a local instance extension object, as an actual instance has not been created yet
84 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
85 InstanceExtensions local_instance_extensions;
86 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
87
John Zulauf620755c2018-04-16 11:00:43 -060088 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060089 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
90 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060091 }
92
93 return skip;
94}
95
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060096bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
97 if (instance_extensions.vk_khr_get_physical_device_properties_2) {
98 // Struct is legal IF it's supported
99 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
100 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
101 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
102 if (enum_iter != dev_exts_enumerated->second.cend()) {
103 return true;
104 }
105 }
106 return false;
107}
108
Tony-LunarG866843d2020-05-13 11:22:42 -0600109bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
110 const VkValidationFeaturesEXT *validation_features) const {
111 bool skip = false;
112 bool debug_printf = false;
113 bool gpu_assisted = false;
114 bool reserve_slot = false;
115 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
116 switch (validation_features->pEnabledValidationFeatures[i]) {
117 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
118 gpu_assisted = true;
119 break;
120
121 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
122 debug_printf = true;
123 break;
124
125 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
126 reserve_slot = true;
127 break;
128
129 default:
130 break;
131 }
132 }
133 if (reserve_slot && !gpu_assisted) {
134 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
135 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
136 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
137 }
138 if (gpu_assisted && debug_printf) {
139 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
140 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
141 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
142 }
143
144 return skip;
145}
146
John Zulauf620755c2018-04-16 11:00:43 -0600147template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700148ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
149 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600150 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700151 ExtEnabled state =
152 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600153 return state;
154}
155
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700156bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500157 const VkAllocationCallbacks *pAllocator,
158 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700159 bool skip = false;
160 // Note: From the spec--
161 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
162 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
163 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700164 ? pCreateInfo->pApplicationInfo->apiVersion
165 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700166 skip |= validate_api_version(local_api_version, api_version);
167 skip |= validate_instance_extensions(pCreateInfo);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700168 const auto *validation_features = LvlFindInChain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
Tony-LunarG866843d2020-05-13 11:22:42 -0600169 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
170
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700171 return skip;
172}
173
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700174void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700175 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
176 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700177 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
178 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700179 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700180 this->instance_extensions = instance_data->instance_extensions;
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700181}
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600182
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700183void StatelessValidation::CommonPostCallRecordEnumeratePhysicalDevice(const VkPhysicalDevice *phys_devices, const int count) {
184 // Assume phys_devices is valid
185 assert(phys_devices);
186 for (int i = 0; i < count; ++i) {
187 const auto &phys_device = phys_devices[i];
188 if (0 == physical_device_properties_map.count(phys_device)) {
189 auto phys_dev_props = new VkPhysicalDeviceProperties;
190 DispatchGetPhysicalDeviceProperties(phys_device, phys_dev_props);
191 physical_device_properties_map[phys_device] = phys_dev_props;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600192
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700193 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
194 uint32_t ext_count = 0;
Jeremy Gebbencbf22862021-03-03 12:01:22 -0700195 layer_data::unordered_set<std::string> dev_exts_enumerated{};
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700196 std::vector<VkExtensionProperties> ext_props{};
197 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, nullptr);
198 ext_props.resize(ext_count);
199 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, ext_props.data());
200 for (uint32_t j = 0; j < ext_count; j++) {
201 dev_exts_enumerated.insert(ext_props[j].extensionName);
202 }
203 device_extensions_enumerated[phys_device] = std::move(dev_exts_enumerated);
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600204 }
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700205 }
206}
207
208void StatelessValidation::PostCallRecordEnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount,
209 VkPhysicalDevice *pPhysicalDevices, VkResult result) {
210 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
211 return;
212 }
213
214 if (pPhysicalDeviceCount && pPhysicalDevices) {
215 CommonPostCallRecordEnumeratePhysicalDevice(pPhysicalDevices, *pPhysicalDeviceCount);
216 }
217}
218
219void StatelessValidation::PostCallRecordEnumeratePhysicalDeviceGroups(
220 VkInstance instance, uint32_t *pPhysicalDeviceGroupCount, VkPhysicalDeviceGroupProperties *pPhysicalDeviceGroupProperties,
221 VkResult result) {
222 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
223 return;
224 }
225
226 if (pPhysicalDeviceGroupCount && pPhysicalDeviceGroupProperties) {
227 for (uint32_t i = 0; i < *pPhysicalDeviceGroupCount; i++) {
228 const auto &group = pPhysicalDeviceGroupProperties[i];
229 CommonPostCallRecordEnumeratePhysicalDevice(group.physicalDevices, group.physicalDeviceCount);
230 }
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600231 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700232}
233
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600234void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
235 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
236 delete (it->second);
237 it = physical_device_properties_map.erase(it);
238 }
239};
240
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700241void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700242 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700243 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700244 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700245 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
246 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700247
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700248 // Parmeter validation also uses extension data
249 stateless_validation->device_extensions = this->device_extensions;
250
251 VkPhysicalDeviceProperties device_properties = {};
252 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600253 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700254 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
255
256 if (device_extensions.vk_nv_shading_rate_image) {
257 // Get the needed shading rate image limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700258 auto shading_rate_image_props = LvlInitStruct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
259 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600260 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700261 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
262 }
263
264 if (device_extensions.vk_nv_mesh_shader) {
265 // Get the needed mesh shader limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700266 auto mesh_shader_props = LvlInitStruct<VkPhysicalDeviceMeshShaderPropertiesNV>();
267 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600268 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700269 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
270 }
271
Jason Macnak5c954952019-07-09 15:46:12 -0700272 if (device_extensions.vk_nv_ray_tracing) {
273 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700274 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPropertiesNV>();
275 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jason Macnak5c954952019-07-09 15:46:12 -0700276 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500277 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
278 }
279
sourav parmarcd5fb182020-07-17 12:58:44 -0700280 if (device_extensions.vk_khr_ray_tracing_pipeline) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500281 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700282 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPipelinePropertiesKHR>();
283 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500284 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
285 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700286 }
287
sourav parmarcd5fb182020-07-17 12:58:44 -0700288 if (device_extensions.vk_khr_acceleration_structure) {
289 // Get the needed ray tracing acc structure limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700290 auto acc_structure_props = LvlInitStruct<VkPhysicalDeviceAccelerationStructurePropertiesKHR>();
291 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&acc_structure_props);
sourav parmarcd5fb182020-07-17 12:58:44 -0700292 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
293 phys_dev_ext_props.acc_structure_props = acc_structure_props;
294 }
295
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700296 if (device_extensions.vk_ext_transform_feedback) {
297 // Get the needed transform feedback limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700298 auto transform_feedback_props = LvlInitStruct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
299 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&transform_feedback_props);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700300 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
301 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
302 }
303
Piers Daniellcb6d8032021-04-19 18:51:26 -0600304 if (device_extensions.vk_ext_vertex_attribute_divisor) {
305 // Get the needed vertex attribute divisor limits
306 auto vertex_attribute_divisor_props = LvlInitStruct<VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT>();
307 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&vertex_attribute_divisor_props);
308 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
309 phys_dev_ext_props.vertex_attribute_divisor_props = vertex_attribute_divisor_props;
310 }
311
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800312 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
313
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700314 // Save app-enabled features in this device's validation object
315 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700316 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200317 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
318 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
319 if (features2) {
320 tmp_features2_state.features = features2->features;
321 } else if (pCreateInfo->pEnabledFeatures) {
322 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700323 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200324 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700325 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200326 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700327 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200328 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700329}
330
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700331bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500332 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600333 bool skip = false;
334
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200335 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
336 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
337 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600338 }
339
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700340 // If this device supports VK_KHR_portability_subset, it must be enabled
341 const std::string portability_extension_name("VK_KHR_portability_subset");
342 const auto &dev_extensions = device_extensions_enumerated.at(physicalDevice);
343 const bool portability_supported = dev_extensions.count(portability_extension_name) != 0;
344 bool portability_requested = false;
345
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200346 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
347 skip |=
348 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
349 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
350 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
351 pCreateInfo->ppEnabledExtensionNames[i]);
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700352 if (portability_extension_name == pCreateInfo->ppEnabledExtensionNames[i]) {
353 portability_requested = true;
354 }
355 }
356
357 if (portability_supported && !portability_requested) {
358 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-pProperties-04451",
359 "vkCreateDevice: VK_KHR_portability_subset must be enabled because physical device %s supports it",
360 report_data->FormatHandle(physicalDevice).c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600361 }
362
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200363 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700364 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
365 bool negative_viewport =
366 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200367 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700368 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
369 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
370 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200371 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600372 }
373
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600374 {
375 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
376 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
377 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700378 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
379 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
380 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600381 }
382 }
383
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600384 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
385 // Check for get_physical_device_properties2 struct
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700386 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -0600387 if (features2) {
Mike Schuchardt2df08912020-12-15 16:28:09 -0800388 // Cannot include VkPhysicalDeviceFeatures2 and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700389 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mike Schuchardt2df08912020-12-15 16:28:09 -0800390 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct when "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700391 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600392 }
393 }
394
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700395 auto features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500396 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700397 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500398 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
399 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
400 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
401 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700402 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(pCreateInfo->pNext);
sourav parmarcd5fb182020-07-17 12:58:44 -0700403 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplayMixed &&
404 !raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay) {
405 skip |= LogError(
406 device,
407 "VUID-VkPhysicalDeviceRayTracingPipelineFeaturesKHR-rayTracingPipelineShaderGroupHandleCaptureReplayMixed-03575",
408 "If rayTracingPipelineShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingPipelineShaderGroupHandleCaptureReplay "
409 "must also be VK_TRUE.");
sourav parmara24fb7b2020-05-26 10:50:04 -0700410 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700411 auto vertex_attribute_divisor_features = LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600412 if (vertex_attribute_divisor_features && (!device_extensions.vk_ext_vertex_attribute_divisor)) {
413 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
414 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
415 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600416 }
417
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700418 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700419 if (vulkan_11_features) {
420 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
421 while (current) {
422 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
423 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
424 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
425 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
426 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
427 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700428 skip |= LogError(
429 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700430 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
431 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
432 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
433 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
434 break;
435 }
436 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
437 }
sfricke-samsungebda6792021-01-16 08:57:52 -0800438
439 // Check features are enabled if matching extension is passed in as well
440 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
441 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
442 if ((0 == strncmp(extension, VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
443 (vulkan_11_features->shaderDrawParameters == VK_FALSE)) {
444 skip |= LogError(
445 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-04476",
446 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan11Features::shaderDrawParameters is not VK_TRUE.",
447 VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME);
448 }
449 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700450 }
451
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700452 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700453 if (vulkan_12_features) {
454 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
455 while (current) {
456 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
457 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
458 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
459 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
460 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
461 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
462 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
463 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
464 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
465 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
466 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
467 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
468 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700469 skip |= LogError(
470 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700471 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
472 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
473 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
474 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
475 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
476 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
477 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
478 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
479 break;
480 }
481 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
482 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700483 // Check features are enabled if matching extension is passed in as well
484 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
485 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
486 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
487 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
488 skip |= LogError(
489 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02831",
490 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
491 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
492 }
493 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
494 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
495 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02832",
496 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
497 "is not VK_TRUE.",
498 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
499 }
500 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
501 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
502 skip |= LogError(
503 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02833",
504 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
505 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
506 }
507 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
508 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
509 skip |= LogError(
510 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02834",
511 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
512 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
513 }
514 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
515 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
516 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
517 skip |=
518 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02835",
519 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
520 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
521 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
522 }
523 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700524 }
525
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600526 // Validate pCreateInfo->pQueueCreateInfos
527 if (pCreateInfo->pQueueCreateInfos) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600528
529 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700530 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
531 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600532 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700533 skip |=
534 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
535 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
536 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
537 "index value.",
538 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600539 }
540
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700541 if (queue_create_info.pQueuePriorities != nullptr) {
542 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
543 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600544 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700545 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
546 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
547 "] (=%f) is not between 0 and 1 (inclusive).",
548 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600549 }
550 }
551 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700552
553 // Need to know if protectedMemory feature is passed in preCall to creating the device
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700554 VkBool32 protected_memory = VK_FALSE;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700555 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700556 LvlFindInChain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700557 if (protected_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700558 protected_memory = protected_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700559 } else if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700560 protected_memory = vulkan_11_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700561 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700562 if ((queue_create_info.flags == VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) && (protected_memory == VK_FALSE)) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700563 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
564 "vkCreateDevice: pCreateInfo->flags set to VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
565 "protectedMemory feature being set as well.");
566 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600567 }
568 }
569
sfricke-samsung30a57412020-05-15 21:14:54 -0700570 // feature dependencies for VK_KHR_variable_pointers
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700571 const auto *variable_pointers_features = LvlFindInChain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700572 VkBool32 variable_pointers = VK_FALSE;
573 VkBool32 variable_pointers_storage_buffer = VK_FALSE;
sfricke-samsung30a57412020-05-15 21:14:54 -0700574 if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700575 variable_pointers = vulkan_11_features->variablePointers;
576 variable_pointers_storage_buffer = vulkan_11_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700577 } else if (variable_pointers_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700578 variable_pointers = variable_pointers_features->variablePointers;
579 variable_pointers_storage_buffer = variable_pointers_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700580 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700581 if ((variable_pointers == VK_TRUE) && (variable_pointers_storage_buffer == VK_FALSE)) {
sfricke-samsung30a57412020-05-15 21:14:54 -0700582 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
583 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
584 }
585
sfricke-samsungfd76c342020-05-29 23:13:43 -0700586 // feature dependencies for VK_KHR_multiview
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700587 const auto *multiview_features = LvlFindInChain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
sfricke-samsungfd76c342020-05-29 23:13:43 -0700588 VkBool32 multiview = VK_FALSE;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700589 VkBool32 multiview_geometry_shader = VK_FALSE;
590 VkBool32 multiview_tessellation_shader = VK_FALSE;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700591 if (vulkan_11_features) {
592 multiview = vulkan_11_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700593 multiview_geometry_shader = vulkan_11_features->multiviewGeometryShader;
594 multiview_tessellation_shader = vulkan_11_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700595 } else if (multiview_features) {
596 multiview = multiview_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700597 multiview_geometry_shader = multiview_features->multiviewGeometryShader;
598 multiview_tessellation_shader = multiview_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700599 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700600 if ((multiview == VK_FALSE) && (multiview_geometry_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700601 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
602 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
603 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700604 if ((multiview == VK_FALSE) && (multiview_tessellation_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700605 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
606 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
607 }
608
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600609 return skip;
610}
611
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500612bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700613 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700614 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
615 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
616 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600617 }
618
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700619 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600620}
621
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700622bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500623 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100624 bool skip = false;
625
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600626 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700627 skip |=
628 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600629
630 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
631 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
632 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
633 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700634 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
635 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
636 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600637 }
638
639 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
640 // queueFamilyIndexCount uint32_t values
641 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700642 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
643 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
644 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
645 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600646 }
647 }
648
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700649 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
650 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
651 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
652 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
653 }
654
655 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
656 skip |=
657 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
658 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
659 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
660 }
661
662 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
663 skip |=
664 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
665 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
666 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
667 }
668
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600669 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
670 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
671 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
672 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700673 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
674 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
675 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600676 }
677 }
678
679 return skip;
680}
681
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700682bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500683 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600684 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600685
686 if (pCreateInfo != nullptr) {
sfricke-samsung61a57c02021-01-10 21:35:12 -0800687 const VkFormat image_format = pCreateInfo->format;
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700688 const VkImageCreateFlags image_flags = pCreateInfo->flags;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600689 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
690 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
691 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
692 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700693 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
694 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
695 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600696 }
697
698 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
699 // queueFamilyIndexCount uint32_t values
700 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700701 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
702 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
703 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
704 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600705 }
706 }
707
Dave Houlton413a6782018-05-22 13:01:54 -0600708 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700709 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600710 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700711 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600712 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700713 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600714
Dave Houlton413a6782018-05-22 13:01:54 -0600715 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700716 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600717 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700718 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600719
Dave Houlton130c0212018-01-29 13:39:56 -0700720 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700721 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
722 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700723 skip |= LogError(
724 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600725 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
726 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700727 }
728
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600729 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100730 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
731 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700732 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
733 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
734 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600735 }
736
737 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700738 if (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
Petr Kraus3f433212018-03-13 12:31:27 +0100739 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700740 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
741 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
742 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
743 ") are not equal.",
744 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100745 }
746
747 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700748 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
749 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
750 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
751 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100752 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600753 }
754
755 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700756 skip |= LogError(
757 device, "VUID-VkImageCreateInfo-imageType-00957",
758 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600759 }
760 }
761
Dave Houlton130c0212018-01-29 13:39:56 -0700762 // 3D image may have only 1 layer
763 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700764 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
765 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700766 }
767
Dave Houlton130c0212018-01-29 13:39:56 -0700768 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
769 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
770 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
771 // At least one of the legal attachment bits must be set
772 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700773 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
774 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700775 }
776 // No flags other than the legal attachment bits may be set
777 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
778 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700779 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
780 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700781 }
782 }
783
Jeff Bolzef40fec2018-09-01 22:04:34 -0500784 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700785 uint32_t max_dim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500786 // Max mip levels is different for corner-sampled images vs normal images.
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700787 uint32_t max_mip_levels = (image_flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700788 ? static_cast<uint32_t>(ceil(log2(max_dim)))
789 : static_cast<uint32_t>(floor(log2(max_dim)) + 1);
790 if (max_dim > 0 && pCreateInfo->mipLevels > max_mip_levels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600791 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700792 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
793 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
794 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600795 }
796
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700797 if ((image_flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700798 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
799 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
800 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600801 }
802
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700803 if ((image_flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700804 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
805 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
806 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100807 }
808
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700809 if ((image_flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700810 skip |= LogError(
811 device, "VUID-VkImageCreateInfo-flags-01924",
812 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
813 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
814 }
815
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600816 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
817 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700818 if (((image_flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
819 ((image_flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700820 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
821 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
822 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600823 }
824
825 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700826 if ((image_flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600827 // Linear tiling is unsupported
828 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700829 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700830 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
831 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600832 }
833
834 // Sparse 1D image isn't valid
835 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700836 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
837 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600838 }
839
840 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700841 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700842 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
843 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
844 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600845 }
846
847 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700848 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700849 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
850 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
851 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600852 }
853
854 // Multi-sample 2D image when device doesn't support it
855 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700856 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600857 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700858 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
859 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
860 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700861 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600862 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700863 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
864 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
865 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700866 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600867 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700868 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
869 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
870 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700871 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600872 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700873 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
874 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
875 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600876 }
877 }
878 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500879
Jeff Bolz9af91c52018-09-01 21:53:57 -0500880 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
881 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700882 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
883 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
884 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500885 }
886 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700887 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
888 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
889 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500890 }
891 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700892 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
893 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
894 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500895 }
896 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500897
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700898 if (image_flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600899 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700900 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
901 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
902 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500903 }
904
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700905 if ((image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(image_format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700906 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
907 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800908 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format (%s) must not be a "
909 "depth/stencil format.",
910 string_VkFormat(image_format));
Jeff Bolzef40fec2018-09-01 22:04:34 -0500911 }
912
Dave Houlton142c4cb2018-10-17 15:04:41 -0600913 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700914 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
915 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
916 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
917 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500918 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600919 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700920 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
921 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
922 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
923 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500924 }
925 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500926
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700927 if (((image_flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
sfricke-samsung61a57c02021-01-10 21:35:12 -0800928 (FormatHasDepth(image_format) == false)) {
sfricke-samsung8f658d42020-05-03 20:12:24 -0700929 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
930 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800931 "format (%s) must be a depth or depth/stencil format.",
932 string_VkFormat(image_format));
sfricke-samsung8f658d42020-05-03 20:12:24 -0700933 }
934
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700935 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pCreateInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500936 if (image_stencil_struct != nullptr) {
937 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
938 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
939 // No flags other than the legal attachment bits may be set
940 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
941 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700942 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
943 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
944 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
945 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500946 }
947 }
948
sfricke-samsung61a57c02021-01-10 21:35:12 -0800949 if (FormatIsDepthOrStencil(image_format)) {
Andrew Fobel3abeb992020-01-20 16:33:22 -0500950 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
951 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
sfricke-samsungf3a9b5b2021-01-13 13:05:52 -0800952 skip |= LogError(
953 device, "VUID-VkImageCreateInfo-Format-02536",
954 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
955 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width (%u) exceeds device "
956 "maxFramebufferWidth (%u)",
957 pCreateInfo->extent.width, device_limits.maxFramebufferWidth);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500958 }
959
960 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
sfricke-samsungf3a9b5b2021-01-13 13:05:52 -0800961 skip |= LogError(
962 device, "VUID-VkImageCreateInfo-format-02537",
963 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
964 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height (%u) exceeds device "
965 "maxFramebufferHeight (%u)",
966 pCreateInfo->extent.height, device_limits.maxFramebufferHeight);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500967 }
968 }
969
970 if (!physical_device_features.shaderStorageImageMultisample &&
971 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
972 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
973 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700974 LogError(device, "VUID-VkImageCreateInfo-format-02538",
975 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
976 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
977 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500978 }
979
980 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
981 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700982 skip |= LogError(
983 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500984 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
985 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
986 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
987 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
988 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700989 skip |= LogError(
990 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500991 "vkCreateImage(): Depth-stencil image in which usage does not include "
992 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
993 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
994 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
995 }
996
997 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
998 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700999 skip |= LogError(
1000 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001001 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1002 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1003 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1004 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
1005 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001006 skip |= LogError(
1007 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001008 "vkCreateImage(): Depth-stencil image in which usage does not include "
1009 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1010 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1011 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1012 }
1013 }
1014 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -07001015
1016 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1017 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1018 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
1019 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
1020 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
1021 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001022
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001023 std::vector<uint64_t> image_create_drm_format_modifiers;
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001024 if (device_extensions.vk_ext_image_drm_format_modifier) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001025 const auto drm_format_mod_list = LvlFindInChain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
1026 const auto drm_format_mod_explict = LvlFindInChain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001027 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1028 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
1029 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
1030 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
1031 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
1032 "either VkImageDrmFormatModifierListCreateInfoEXT or "
1033 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
Martin Freebody0ec2c7a2021-03-03 16:48:00 +00001034 } else if (drm_format_mod_explict != nullptr) {
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001035 image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
1036 } else if (drm_format_mod_list != nullptr) {
1037 for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {
1038 image_create_drm_format_modifiers.push_back(*drm_format_mod_list->pDrmFormatModifiers);
1039 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001040 }
1041 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
1042 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
1043 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
1044 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
1045 "in the pNext chain");
1046 }
1047 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001048
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001049 static const uint64_t drm_format_mod_linear = 0;
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001050 bool image_create_maybe_linear = false;
1051 if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) {
1052 image_create_maybe_linear = true;
1053 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) {
1054 image_create_maybe_linear = false;
1055 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1056 image_create_maybe_linear =
1057 (std::find(image_create_drm_format_modifiers.begin(), image_create_drm_format_modifiers.end(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001058 drm_format_mod_linear) != image_create_drm_format_modifiers.end());
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001059 }
1060
1061 // If multi-sample, validate type, usage, tiling and mip levels.
1062 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001063 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001064 (pCreateInfo->mipLevels != 1) || image_create_maybe_linear)) {
1065 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
1066 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
1067 }
1068
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001069 if ((image_flags & VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT) &&
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001070 ((pCreateInfo->mipLevels != 1) || (pCreateInfo->arrayLayers != 1) || (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) ||
1071 image_create_maybe_linear)) {
1072 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02259",
1073 "vkCreateImage(): Multi-device image with incompatible type, usage, tiling, or mips.");
1074 }
1075
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001076 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
1077 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1078 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
1079 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1080 "imageType must be VK_IMAGE_TYPE_2D.");
1081 }
1082 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1083 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
1084 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1085 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1086 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001087 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001088 if (image_flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001089 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1090 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
1091 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1092 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1093 }
1094 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1095 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
1096 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1097 "imageType must be VK_IMAGE_TYPE_2D.");
1098 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001099 if (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001100 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1101 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1102 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1103 }
1104 if (pCreateInfo->mipLevels != 1) {
1105 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
1106 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%d) must be 1.",
1107 pCreateInfo->mipLevels);
1108 }
1109 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001110
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001111 const auto swapchain_create_info = LvlFindInChain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001112 if (swapchain_create_info != nullptr) {
1113 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1114 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1115 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1116 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1117 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1118 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1119
1120 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1121 // also implicitly forces the check above that extent.depth is 1
1122 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1123 string_VkImageType(pCreateInfo->imageType));
1124 }
1125 if (pCreateInfo->mipLevels != 1) {
1126 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %u.", base_message,
1127 pCreateInfo->mipLevels);
1128 }
1129 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1130 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1131 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1132 }
1133 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1134 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1135 base_message, string_VkImageTiling(pCreateInfo->tiling));
1136 }
1137 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1138 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1139 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1140 }
1141 const VkImageCreateFlags valid_flags =
1142 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
Mike Schuchardt2df08912020-12-15 16:28:09 -08001143 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT);
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001144 if ((image_flags & ~valid_flags) != 0) {
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001145 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001146 image_flags);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001147 }
1148 }
1149 }
sfricke-samsung61a57c02021-01-10 21:35:12 -08001150
1151 // If Chroma subsampled format ( _420_ or _422_ )
1152 if (FormatIsXChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.width, 2) != 0)) {
1153 skip |=
1154 LogError(device, "VUID-VkImageCreateInfo-format-04712",
1155 "vkCreateImage(): The format (%s) is X Chroma Subsampled (has _422 or _420 suffix) so the width (=%" PRIu32
1156 ") must be a multiple of 2.",
1157 string_VkFormat(image_format), pCreateInfo->extent.width);
1158 }
1159 if (FormatIsYChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.height, 2) != 0)) {
1160 skip |= LogError(device, "VUID-VkImageCreateInfo-format-04713",
1161 "vkCreateImage(): The format (%s) is Y Chroma Subsampled (has _420 suffix) so the height (=%" PRIu32
1162 ") must be a multiple of 2.",
1163 string_VkFormat(image_format), pCreateInfo->extent.height);
1164 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001165
1166 const auto format_list_info = LvlFindInChain<VkImageFormatListCreateInfo>(pCreateInfo->pNext);
1167 if (format_list_info) {
1168 const uint32_t viewFormatCount = format_list_info->viewFormatCount;
1169 if (((image_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) == 0) && (viewFormatCount > 1)) {
1170 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-04738",
1171 "vkCreateImage(): If the VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT is not set, then "
1172 "VkImageFormatListCreateInfo::viewFormatCount (%u) must be 0 or 1.",
1173 viewFormatCount);
1174 }
1175 // Check if viewFormatCount is not zero that it is all compatible
1176 for (uint32_t i = 0; i < viewFormatCount; i++) {
1177 if (FormatCompatibilityClass(format_list_info->pViewFormats[i]) != FormatCompatibilityClass(image_format)) {
1178 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-04737",
1179 "vkCreateImage(): VkImageFormatListCreateInfo::pViewFormats[%u] (%s) and "
1180 "VkImageCreateInfo::format (%s) are not compatible.",
1181 i, string_VkFormat(format_list_info->pViewFormats[0]), string_VkFormat(image_format));
1182 }
1183 }
1184 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001185 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001186
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001187 return skip;
1188}
1189
Jeff Bolz99e3f632020-03-24 22:59:22 -05001190bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1191 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1192 bool skip = false;
1193
1194 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001195 // Validate feature set if using CUBE_ARRAY
1196 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1197 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1198 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1199 "enabling the imageCubeArray feature.");
1200 }
1201
Jeff Bolz99e3f632020-03-24 22:59:22 -05001202 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1203 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1204 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
Spencer Fricke528e0982020-04-19 18:46:01 -07001205 "vkCreateImageView(): subresourceRange.layerCount (%d) must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001206 pCreateInfo->subresourceRange.layerCount);
1207 }
1208 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001209 skip |= LogError(
1210 device, "VUID-VkImageViewCreateInfo-viewType-02961",
1211 "vkCreateImageView(): subresourceRange.layerCount (%d) must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1212 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001213 }
1214 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001215
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001216 auto astc_decode_mode = LvlFindInChain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001217 if ((device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
1218 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1219 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1220 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1221 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1222 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1223 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1224 }
1225 if (FormatIsCompressed_ASTC(pCreateInfo->format) == false) {
1226 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1227 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1228 "not an ASTC format.",
1229 string_VkFormat(pCreateInfo->format));
1230 }
1231 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001232
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001233 auto ycbcr_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
sfricke-samsung83d98122020-07-04 06:21:15 -07001234 if (ycbcr_conversion != nullptr) {
1235 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1236 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1237 skip |= LogError(
1238 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1239 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1240 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1241 "r swizzle = %s\n"
1242 "g swizzle = %s\n"
1243 "b swizzle = %s\n"
1244 "a swizzle = %s\n",
1245 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1246 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1247 }
1248 }
1249 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001250 }
1251 return skip;
1252}
1253
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001254bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001255 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001256 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001257
1258 // Note: for numerical correctness
1259 // - float comparisons should expect NaN (comparison always false).
1260 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1261
1262 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001263 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001264 if (v1_f <= 0.0f) return true;
1265
1266 float intpart;
1267 const float fract = modff(v1_f, &intpart);
1268
1269 assert(std::numeric_limits<float>::radix == 2);
1270 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1271 if (intpart >= u32_max_plus1) return false;
1272
1273 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001274 if (v1_u32 < v2_u32) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001275 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001276 } else if (v1_u32 == v2_u32 && fract == 0.0f) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001277 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001278 } else {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001279 return false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001280 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01001281 };
1282
1283 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1284 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1285 return (v1_f <= v2_f);
1286 };
1287
1288 // width
1289 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001290 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001291
1292 if (!(viewport.width > 0.0f)) {
1293 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001294 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1295 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001296 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1297 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001298 skip |= LogError(object, "VUID-VkViewport-width-01771",
1299 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1300 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001301 }
1302
1303 // height
1304 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -07001305 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001306 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001307
1308 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1309 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001310 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1311 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001312 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1313 height_healthy = false;
1314
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001315 skip |= LogError(object, "VUID-VkViewport-height-01773",
1316 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1317 ").",
1318 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001319 }
1320
1321 // x
1322 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001323 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001324 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001325 skip |= LogError(object, "VUID-VkViewport-x-01774",
1326 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1327 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001328 }
1329
1330 // x + width
1331 if (x_healthy && width_healthy) {
1332 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001333 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001334 skip |= LogError(
1335 object, "VUID-VkViewport-x-01232",
1336 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1337 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1338 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001339 }
1340 }
1341
1342 // y
1343 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001344 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001345 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001346 skip |= LogError(object, "VUID-VkViewport-y-01775",
1347 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1348 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001349 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001350 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001351 skip |= LogError(object, "VUID-VkViewport-y-01776",
1352 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1353 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001354 }
1355
1356 // y + height
1357 if (y_healthy && height_healthy) {
1358 const float boundary = viewport.y + viewport.height;
1359
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001360 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001361 skip |= LogError(object, "VUID-VkViewport-y-01233",
1362 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1363 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1364 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001365 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001366 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001367 LogError(object, "VUID-VkViewport-y-01777",
1368 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1369 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1370 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001371 }
1372 }
1373
sfricke-samsungfd06d422021-01-22 02:17:21 -08001374 // The extension was not created with a feature bit whichs prevents displaying the 2 variations of the VUIDs
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001375 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001376 // minDepth
1377 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001378 // Also VUID-VkViewport-minDepth-02540
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001379 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001380 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1381 "[0.0, 1.0] range.",
1382 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001383 }
1384
1385 // maxDepth
1386 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001387 // Also VUID-VkViewport-maxDepth-02541
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001388 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001389 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1390 "[0.0, 1.0] range.",
1391 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001392 }
1393 }
1394
1395 return skip;
1396}
1397
Dave Houlton142c4cb2018-10-17 15:04:41 -06001398struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001399 VkShadingRatePaletteEntryNV shadingRate;
1400 uint32_t width;
1401 uint32_t height;
1402};
1403
1404// All palette entries with more than one pixel per fragment
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001405static SampleOrderInfo sample_order_infos[] = {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001406 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1407 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1408 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1409 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1410 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1411 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001412};
1413
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001414bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001415 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001416
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001417 SampleOrderInfo *sample_order_info;
1418 uint32_t info_idx = 0;
1419 for (sample_order_info = nullptr; info_idx < ARRAY_SIZE(sample_order_infos); ++info_idx) {
1420 if (sample_order_infos[info_idx].shadingRate == order->shadingRate) {
1421 sample_order_info = &sample_order_infos[info_idx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001422 break;
1423 }
1424 }
1425
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001426 if (sample_order_info == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001427 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1428 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1429 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001430 return skip;
1431 }
1432
Dave Houlton142c4cb2018-10-17 15:04:41 -06001433 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001434 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001435 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1436 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1437 ") must "
1438 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1439 "is set in framebufferNoAttachmentsSampleCounts.",
1440 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001441 }
1442
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001443 if (order->sampleLocationCount != order->sampleCount * sample_order_info->width * sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001444 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1445 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1446 ") must "
1447 "be equal to the product of sampleCount (=%" PRIu32
1448 "), the fragment width for shadingRate "
1449 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001450 order->sampleLocationCount, order->sampleCount, sample_order_info->width, sample_order_info->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001451 }
1452
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001453 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001454 skip |= LogError(
1455 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001456 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1457 ") must "
1458 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001459 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001460 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001461
1462 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001463 // the first width*height*sampleCount bits to all be set. Note: There is no
1464 // guarantee that 64 bits is enough, but practically it's unlikely for an
1465 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001466 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001467 uint64_t sample_locations_mask = 0;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001468 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001469 const VkCoarseSampleLocationNV *sample_loc = &order->pSampleLocations[i];
1470 if (sample_loc->pixelX >= sample_order_info->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001471 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1472 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001473 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001474 if (sample_loc->pixelY >= sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001475 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1476 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001477 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001478 if (sample_loc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001479 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1480 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001481 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001482 uint32_t idx =
1483 sample_loc->sample + order->sampleCount * (sample_loc->pixelX + sample_order_info->width * sample_loc->pixelY);
1484 sample_locations_mask |= 1ULL << idx;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001485 }
1486
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001487 uint64_t expected_mask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1488 if (sample_locations_mask != expected_mask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001489 skip |= LogError(
1490 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001491 "The array pSampleLocations must contain exactly one entry for "
1492 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001493 }
1494
1495 return skip;
1496}
1497
sfricke-samsung51303fb2021-05-09 19:09:13 -07001498bool StatelessValidation::manual_PreCallValidateCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo,
1499 const VkAllocationCallbacks *pAllocator,
1500 VkPipelineLayout *pPipelineLayout) const {
1501 bool skip = false;
1502 // Validate layout count against device physical limit
1503 if (pCreateInfo->setLayoutCount > device_limits.maxBoundDescriptorSets) {
1504 skip |= LogError(device, "VUID-VkPipelineLayoutCreateInfo-setLayoutCount-00286",
1505 "vkCreatePipelineLayout(): setLayoutCount (%d) exceeds physical device maxBoundDescriptorSets limit (%d).",
1506 pCreateInfo->setLayoutCount, device_limits.maxBoundDescriptorSets);
1507 }
1508
1509 // Validate Push Constant ranges
1510 for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
1511 const uint32_t offset = pCreateInfo->pPushConstantRanges[i].offset;
1512 const uint32_t size = pCreateInfo->pPushConstantRanges[i].size;
1513 const uint32_t max_push_constants_size = device_limits.maxPushConstantsSize;
1514 // Check that offset + size don't exceed the max.
1515 // Prevent arithetic overflow here by avoiding addition and testing in this order.
1516 if (offset >= max_push_constants_size) {
1517 skip |= LogError(device, "VUID-VkPushConstantRange-offset-00294",
1518 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%u].offset (%u) that exceeds this "
1519 "device's maxPushConstantSize of %u.",
1520 i, offset, max_push_constants_size);
1521 }
1522 if (size > max_push_constants_size - offset) {
1523 skip |= LogError(device, "VUID-VkPushConstantRange-size-00298",
1524 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%u] offset (%u) and size (%u) "
1525 "together exceeds this device's maxPushConstantSize of %u.",
1526 i, offset, size, max_push_constants_size);
1527 }
1528
1529 // size needs to be non-zero and a multiple of 4.
1530 if (size == 0) {
1531 skip |= LogError(device, "VUID-VkPushConstantRange-size-00296",
1532 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%u].size (%u) is not greater than zero.",
1533 i, size);
1534 }
1535 if (size & 0x3) {
1536 skip |= LogError(device, "VUID-VkPushConstantRange-size-00297",
1537 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%u].size (%u) is not a multiple of 4.", i,
1538 size);
1539 }
1540
1541 // offset needs to be a multiple of 4.
1542 if ((offset & 0x3) != 0) {
1543 skip |= LogError(device, "VUID-VkPushConstantRange-offset-00295",
1544 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%u].offset (%u) is not a multiple of 4.",
1545 i, offset);
1546 }
1547 }
1548
1549 // As of 1.0.28, there is a VU that states that a stage flag cannot appear more than once in the list of push constant ranges.
1550 for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
1551 for (uint32_t j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) {
1552 if (0 != (pCreateInfo->pPushConstantRanges[i].stageFlags & pCreateInfo->pPushConstantRanges[j].stageFlags)) {
1553 skip |= LogError(device, "VUID-VkPipelineLayoutCreateInfo-pPushConstantRanges-00292",
1554 "vkCreatePipelineLayout() Duplicate stage flags found in ranges %d and %d.", i, j);
1555 }
1556 }
1557 }
1558 return skip;
1559}
1560
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001561bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1562 uint32_t createInfoCount,
1563 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1564 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001565 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001566 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001567
1568 if (pCreateInfos != nullptr) {
1569 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001570 bool has_dynamic_viewport = false;
1571 bool has_dynamic_scissor = false;
1572 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001573 bool has_dynamic_depth_bias = false;
1574 bool has_dynamic_blend_constant = false;
1575 bool has_dynamic_depth_bounds = false;
1576 bool has_dynamic_stencil_compare = false;
1577 bool has_dynamic_stencil_write = false;
1578 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001579 bool has_dynamic_viewport_w_scaling_nv = false;
1580 bool has_dynamic_discard_rectangle_ext = false;
1581 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001582 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001583 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001584 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001585 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001586 bool has_dynamic_cull_mode = false;
1587 bool has_dynamic_front_face = false;
1588 bool has_dynamic_primitive_topology = false;
1589 bool has_dynamic_viewport_with_count = false;
1590 bool has_dynamic_scissor_with_count = false;
1591 bool has_dynamic_vertex_input_binding_stride = false;
1592 bool has_dynamic_depth_test_enable = false;
1593 bool has_dynamic_depth_write_enable = false;
1594 bool has_dynamic_depth_compare_op = false;
1595 bool has_dynamic_depth_bounds_test_enable = false;
1596 bool has_dynamic_stencil_test_enable = false;
1597 bool has_dynamic_stencil_op = false;
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07001598 bool has_patch_control_points = false;
1599 bool has_rasterizer_discard_enable = false;
1600 bool has_depth_bias_enable = false;
1601 bool has_logic_op = false;
1602 bool has_primitive_restart_enable = false;
Piers Daniellcb6d8032021-04-19 18:51:26 -06001603 bool has_dynamic_vertex_input = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001604 if (pCreateInfos[i].pDynamicState != nullptr) {
1605 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1606 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1607 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001608 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1609 if (has_dynamic_viewport == true) {
1610 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1611 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1612 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1613 i);
1614 }
1615 has_dynamic_viewport = true;
1616 }
1617 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1618 if (has_dynamic_scissor == true) {
1619 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1620 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1621 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1622 i);
1623 }
1624 has_dynamic_scissor = true;
1625 }
1626 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1627 if (has_dynamic_line_width == true) {
1628 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1629 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1630 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1631 i);
1632 }
1633 has_dynamic_line_width = true;
1634 }
1635 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1636 if (has_dynamic_depth_bias == true) {
1637 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1638 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1639 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1640 i);
1641 }
1642 has_dynamic_depth_bias = true;
1643 }
1644 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1645 if (has_dynamic_blend_constant == true) {
1646 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1647 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1648 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1649 i);
1650 }
1651 has_dynamic_blend_constant = true;
1652 }
1653 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1654 if (has_dynamic_depth_bounds == true) {
1655 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1656 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1657 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1658 i);
1659 }
1660 has_dynamic_depth_bounds = true;
1661 }
1662 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1663 if (has_dynamic_stencil_compare == true) {
1664 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1665 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1666 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1667 i);
1668 }
1669 has_dynamic_stencil_compare = true;
1670 }
1671 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1672 if (has_dynamic_stencil_write == true) {
1673 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1674 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1675 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1676 i);
1677 }
1678 has_dynamic_stencil_write = true;
1679 }
1680 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1681 if (has_dynamic_stencil_reference == true) {
1682 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1683 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1684 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1685 i);
1686 }
1687 has_dynamic_stencil_reference = true;
1688 }
1689 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1690 if (has_dynamic_viewport_w_scaling_nv == true) {
1691 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1692 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1693 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1694 i);
1695 }
1696 has_dynamic_viewport_w_scaling_nv = true;
1697 }
1698 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1699 if (has_dynamic_discard_rectangle_ext == true) {
1700 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1701 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1702 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1703 i);
1704 }
1705 has_dynamic_discard_rectangle_ext = true;
1706 }
1707 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1708 if (has_dynamic_sample_locations_ext == true) {
1709 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1710 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1711 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1712 i);
1713 }
1714 has_dynamic_sample_locations_ext = true;
1715 }
1716 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1717 if (has_dynamic_exclusive_scissor_nv == true) {
1718 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1719 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1720 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1721 i);
1722 }
1723 has_dynamic_exclusive_scissor_nv = true;
1724 }
1725 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1726 if (has_dynamic_shading_rate_palette_nv == true) {
1727 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1728 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1729 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1730 i);
1731 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001732 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001733 }
1734 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1735 if (has_dynamic_viewport_course_sample_order_nv == true) {
1736 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1737 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1738 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1739 i);
1740 }
1741 has_dynamic_viewport_course_sample_order_nv = true;
1742 }
1743 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1744 if (has_dynamic_line_stipple == true) {
1745 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1746 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1747 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1748 i);
1749 }
1750 has_dynamic_line_stipple = true;
1751 }
Piers Daniell39842ee2020-07-10 16:42:33 -06001752 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
1753 if (has_dynamic_cull_mode) {
1754 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1755 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
1756 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1757 i);
1758 }
1759 has_dynamic_cull_mode = true;
1760 }
1761 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
1762 if (has_dynamic_front_face) {
1763 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1764 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
1765 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1766 i);
1767 }
1768 has_dynamic_front_face = true;
1769 }
1770 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
1771 if (has_dynamic_primitive_topology) {
1772 skip |= LogError(
1773 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1774 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
1775 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1776 i);
1777 }
1778 has_dynamic_primitive_topology = true;
1779 }
1780 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
1781 if (has_dynamic_viewport_with_count) {
1782 skip |= LogError(
1783 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1784 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
1785 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1786 i);
1787 }
1788 has_dynamic_viewport_with_count = true;
1789 }
1790 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
1791 if (has_dynamic_scissor_with_count) {
1792 skip |= LogError(
1793 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1794 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
1795 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1796 i);
1797 }
1798 has_dynamic_scissor_with_count = true;
1799 }
1800 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
1801 if (has_dynamic_vertex_input_binding_stride) {
1802 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1803 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
1804 "listed twice in the "
1805 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1806 i);
1807 }
1808 has_dynamic_vertex_input_binding_stride = true;
1809 }
1810 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
1811 if (has_dynamic_depth_test_enable) {
1812 skip |= LogError(
1813 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1814 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
1815 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1816 i);
1817 }
1818 has_dynamic_depth_test_enable = true;
1819 }
1820 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
1821 if (has_dynamic_depth_write_enable) {
1822 skip |= LogError(
1823 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1824 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
1825 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1826 i);
1827 }
1828 has_dynamic_depth_write_enable = true;
1829 }
1830 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
1831 if (has_dynamic_depth_compare_op) {
1832 skip |=
1833 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1834 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
1835 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1836 i);
1837 }
1838 has_dynamic_depth_compare_op = true;
1839 }
1840 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
1841 if (has_dynamic_depth_bounds_test_enable) {
1842 skip |= LogError(
1843 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1844 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
1845 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1846 i);
1847 }
1848 has_dynamic_depth_bounds_test_enable = true;
1849 }
1850 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
1851 if (has_dynamic_stencil_test_enable) {
1852 skip |= LogError(
1853 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1854 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
1855 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1856 i);
1857 }
1858 has_dynamic_stencil_test_enable = true;
1859 }
1860 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
1861 if (has_dynamic_stencil_op) {
1862 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1863 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
1864 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1865 i);
1866 }
1867 has_dynamic_stencil_op = true;
1868 }
sfricke-samsung5f8f9702021-01-29 23:30:30 -08001869 if (dynamic_state == VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR) {
1870 // Not allowed for graphics pipelines
1871 skip |= LogError(
1872 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03578",
1873 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR was listed the "
1874 "pCreateInfos[%d].pDynamicState->pDynamicStates[%d] but not allowed in graphic pipelines.",
1875 i, state_index);
1876 }
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07001877 if (dynamic_state == VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT) {
1878 if (has_patch_control_points) {
1879 skip |= LogError(
1880 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1881 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT was listed twice in the "
1882 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1883 i);
1884 }
1885 has_patch_control_points = true;
1886 }
1887 if (dynamic_state == VK_DYNAMIC_STATE_RASTERIZER_DISCARD_ENABLE_EXT) {
1888 if (has_rasterizer_discard_enable) {
1889 skip |= LogError(
1890 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1891 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_RASTERIZER_DISCARD_ENABLE_EXT was listed twice in the "
1892 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1893 i);
1894 }
1895 has_rasterizer_discard_enable = true;
1896 }
1897 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS_ENABLE_EXT) {
1898 if (has_depth_bias_enable) {
1899 skip |= LogError(
1900 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1901 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS_ENABLE_EXT was listed twice in the "
1902 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1903 i);
1904 }
1905 has_depth_bias_enable = true;
1906 }
1907 if (dynamic_state == VK_DYNAMIC_STATE_LOGIC_OP_EXT) {
1908 if (has_logic_op) {
1909 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1910 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LOGIC_OP_EXT was listed twice in the "
1911 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1912 i);
1913 }
1914 has_logic_op = true;
1915 }
1916 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_RESTART_ENABLE_EXT) {
1917 if (has_primitive_restart_enable) {
1918 skip |= LogError(
1919 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1920 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_RESTART_ENABLE_EXT was listed twice in the "
1921 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1922 i);
1923 }
1924 has_primitive_restart_enable = true;
1925 }
Piers Daniellcb6d8032021-04-19 18:51:26 -06001926 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_EXT) {
1927 if (has_dynamic_vertex_input) {
1928 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1929 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_EXT was listed twice in the "
1930 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1931 i);
1932 }
1933 has_dynamic_vertex_input = true;
1934 }
Petr Kraus299ba622017-11-24 03:09:03 +01001935 }
1936 }
1937
sfricke-samsung3b944422021-01-23 02:15:19 -08001938 if (has_dynamic_viewport_with_count && has_dynamic_viewport) {
1939 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04132",
1940 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT and "
1941 "VK_DYNAMIC_STATE_VIEWPORT both listed in pCreateInfos[%d].pDynamicState->pDynamicStates array",
1942 i);
1943 }
1944
1945 if (has_dynamic_scissor_with_count && has_dynamic_scissor) {
1946 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04133",
1947 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT and VK_DYNAMIC_STATE_SCISSOR "
1948 "both listed in pCreateInfos[%d].pDynamicState->pDynamicStates array",
1949 i);
1950 }
1951
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001952 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04001953 if ((feedback_struct != nullptr) &&
1954 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001955 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1956 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1957 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1958 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1959 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001960 }
1961
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001962 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001963
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001964 // Collect active stages and other information
1965 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001966 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001967 bool has_eval = false;
1968 bool has_control = false;
1969 if (pCreateInfos[i].pStages != nullptr) {
1970 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1971 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1972
1973 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1974 has_control = true;
1975 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1976 has_eval = true;
1977 }
1978
1979 skip |= validate_string(
1980 "vkCreateGraphicsPipelines",
1981 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1982 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1983 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001984 }
1985
1986 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1987 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1988 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1989 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1990 pCreateInfos[i].pTessellationState,
1991 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1992 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1993
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001994 const VkStructureType allowed_structs_vk_pipeline_tessellation_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001995 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1996
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001997 skip |= validate_struct_pnext(
1998 "vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1999 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext,
2000 ARRAY_SIZE(allowed_structs_vk_pipeline_tessellation_state_create_info),
2001 allowed_structs_vk_pipeline_tessellation_state_create_info, GeneratedVulkanHeaderVersion,
2002 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
2003 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002004
2005 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
2006 pCreateInfos[i].pTessellationState->flags,
2007 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
2008 }
2009
2010 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
2011 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
2012 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
2013 pCreateInfos[i].pInputAssemblyState,
2014 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
2015 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
2016
2017 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
2018 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002019 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002020
2021 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
2022 pCreateInfos[i].pInputAssemblyState->flags,
2023 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
2024
2025 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
2026 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
2027 pCreateInfos[i].pInputAssemblyState->topology,
2028 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
2029
2030 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
2031 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
2032 }
2033
2034 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002035 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02002036
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002037 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002038 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
2039 "vkCreateGraphicsPipelines: pararameter "
2040 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
2041 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002042 }
2043
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002044 const VkStructureType allowed_structs_vk_pipeline_vertex_input_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002045 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
2046 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
2047 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
2048 pCreateInfos[i].pVertexInputState->pNext, 1,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002049 allowed_structs_vk_pipeline_vertex_input_state_create_info,
2050 GeneratedVulkanHeaderVersion, "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08002051 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002052 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
2053 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06002054 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002055 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
2056 skip |=
2057 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
2058 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
2059 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
2060 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
2061 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
2062
2063 skip |= validate_array(
2064 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
2065 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
2066 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
2067 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
2068
2069 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002070 for (uint32_t vertex_binding_description_index = 0;
2071 vertex_binding_description_index < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
2072 ++vertex_binding_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002073 skip |= validate_ranged_enum(
2074 "vkCreateGraphicsPipelines",
2075 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
2076 AllVkVertexInputRateEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002077 pCreateInfos[i]
2078 .pVertexInputState->pVertexBindingDescriptions[vertex_binding_description_index]
2079 .inputRate,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002080 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
2081 }
2082 }
2083
2084 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002085 for (uint32_t vertex_attribute_description_index = 0;
2086 vertex_attribute_description_index < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
2087 ++vertex_attribute_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002088 skip |= validate_ranged_enum(
2089 "vkCreateGraphicsPipelines",
2090 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
2091 AllVkFormatEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002092 pCreateInfos[i]
2093 .pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index]
2094 .format,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002095 "VUID-VkVertexInputAttributeDescription-format-parameter");
2096 }
2097 }
2098
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002099 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002100 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
2101 "vkCreateGraphicsPipelines: pararameter "
2102 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
2103 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
2104 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002105 }
2106
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002107 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002108 skip |=
2109 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
2110 "vkCreateGraphicsPipelines: pararameter "
2111 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
2112 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
2113 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002114 }
2115
Jeremy Gebbencbf22862021-03-03 12:01:22 -07002116 layer_data::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002117 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
2118 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02002119 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
2120 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002121 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
2122 "vkCreateGraphicsPipelines: parameter "
2123 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
2124 "(%" PRIu32 ") is not distinct.",
2125 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002126 }
2127 vertex_bindings.insert(vertex_bind_desc.binding);
2128
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002129 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002130 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
2131 "vkCreateGraphicsPipelines: parameter "
2132 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
2133 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
2134 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002135 }
2136
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002137 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002138 skip |=
2139 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
2140 "vkCreateGraphicsPipelines: parameter "
2141 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
2142 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
2143 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002144 }
2145 }
2146
Jeremy Gebbencbf22862021-03-03 12:01:22 -07002147 layer_data::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002148 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
2149 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02002150 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
2151 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002152 skip |= LogError(
2153 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02002154 "vkCreateGraphicsPipelines: parameter "
2155 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
2156 i, d, vertex_attrib_desc.location);
2157 }
2158 attribute_locations.insert(vertex_attrib_desc.location);
2159
2160 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
2161 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002162 skip |= LogError(
2163 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02002164 "vkCreateGraphicsPipelines: parameter "
2165 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
2166 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
2167 i, d, vertex_attrib_desc.binding, i);
2168 }
2169
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002170 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002171 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
2172 "vkCreateGraphicsPipelines: parameter "
2173 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
2174 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
2175 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002176 }
2177
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002178 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002179 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
2180 "vkCreateGraphicsPipelines: parameter "
2181 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
2182 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
2183 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002184 }
2185
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002186 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002187 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
2188 "vkCreateGraphicsPipelines: parameter "
2189 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
2190 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
2191 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002192 }
2193 }
2194 }
2195
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002196 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
2197 if (has_control && has_eval) {
2198 if (pCreateInfos[i].pTessellationState == nullptr) {
2199 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
2200 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
2201 "shader stage and a tessellation evaluation shader stage, "
2202 "pCreateInfos[%d].pTessellationState must not be NULL.",
2203 i, i);
2204 } else {
2205 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
2206 skip |= validate_struct_pnext(
2207 "vkCreateGraphicsPipelines",
2208 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
2209 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
2210 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
2211 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002212
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002213 skip |= validate_reserved_flags(
2214 "vkCreateGraphicsPipelines",
2215 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
2216 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002217
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002218 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
2219 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
2220 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
2221 "vkCreateGraphicsPipelines: invalid parameter "
2222 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
2223 "should be >0 and <=%u.",
2224 i, pCreateInfos[i].pTessellationState->patchControlPoints,
2225 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002226 }
2227 }
2228 }
2229
2230 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
2231 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
2232 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
2233 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002234 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
2235 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
2236 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
2237 "].pViewportState (=NULL) is not a valid pointer.",
2238 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002239 } else {
Petr Krausa6103552017-11-16 21:21:58 +01002240 const auto &viewport_state = *pCreateInfos[i].pViewportState;
2241
2242 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002243 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
2244 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2245 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
2246 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002247 }
2248
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002249 const VkStructureType allowed_structs_vk_pipeline_viewport_state_create_info[] = {
Petr Krausa6103552017-11-16 21:21:58 +01002250 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002251 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
2252 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05002253 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
2254 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002255 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002256 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002257 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01002258 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05002259 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05002260 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
2261 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002262 viewport_state.pNext, ARRAY_SIZE(allowed_structs_vk_pipeline_viewport_state_create_info),
2263 allowed_structs_vk_pipeline_viewport_state_create_info, 65,
2264 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08002265 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002266
2267 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002268 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002269 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002270 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002271
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002272 auto exclusive_scissor_struct =
2273 LvlFindInChain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
2274 auto shading_rate_image_struct =
2275 LvlFindInChain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
2276 auto coarse_sample_order_struct =
2277 LvlFindInChain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01002278 const auto vp_swizzle_struct =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002279 LvlFindInChain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002280 const auto vp_w_scaling_struct =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002281 LvlFindInChain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002282
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002283 if (!physical_device_features.multiViewport) {
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002284 if (!has_dynamic_viewport_with_count && (viewport_state.viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002285 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2286 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2287 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2288 ") is not 1.",
2289 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002290 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002291
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002292 if (!has_dynamic_scissor_with_count && (viewport_state.scissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002293 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2294 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2295 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2296 ") is not 1.",
2297 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002298 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002299
Dave Houlton142c4cb2018-10-17 15:04:41 -06002300 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2301 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002302 skip |= LogError(
2303 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2304 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2305 "disabled, but pCreateInfos[%" PRIu32
2306 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2307 ") is not 1.",
2308 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002309 }
2310
Jeff Bolz9af91c52018-09-01 21:53:57 -05002311 if (shading_rate_image_struct &&
2312 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002313 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2314 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2315 "disabled, but pCreateInfos[%" PRIu32
2316 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2317 ") is neither 0 nor 1.",
2318 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002319 }
2320
Petr Krausa6103552017-11-16 21:21:58 +01002321 } else { // multiViewport enabled
2322 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002323 if (!has_dynamic_viewport_with_count) {
2324 skip |= LogError(
2325 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2326 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2327 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002328 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002329 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2330 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2331 "].pViewportState->viewportCount (=%" PRIu32
2332 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2333 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002334 } else if (has_dynamic_viewport_with_count) {
2335 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2336 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2337 "].pViewportState->viewportCount (=%" PRIu32
2338 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2339 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002340 }
Petr Krausa6103552017-11-16 21:21:58 +01002341
2342 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002343 if (!has_dynamic_scissor_with_count) {
2344 skip |= LogError(
2345 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
2346 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2347 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002348 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002349 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2350 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2351 "].pViewportState->scissorCount (=%" PRIu32
2352 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2353 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002354 } else if (has_dynamic_scissor_with_count) {
2355 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380",
2356 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2357 "].pViewportState->scissorCount (=%" PRIu32
2358 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2359 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002360 }
2361 }
2362
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002363 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002364 skip |=
2365 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2366 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2367 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2368 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002369 }
2370
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002371 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002372 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2373 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2374 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2375 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2376 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002377 }
2378
Piers Daniell39842ee2020-07-10 16:42:33 -06002379 if (viewport_state.scissorCount != viewport_state.viewportCount &&
2380 !(has_dynamic_viewport_with_count || has_dynamic_scissor_with_count)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002381 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
2382 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2383 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
2384 "].pViewportState->viewportCount (=%" PRIu32 ").",
2385 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002386 }
2387
Dave Houlton142c4cb2018-10-17 15:04:41 -06002388 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002389 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002390 skip |=
2391 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2392 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2393 ") must be zero or identical to pCreateInfos[%" PRIu32
2394 "].pViewportState->viewportCount (=%" PRIu32 ").",
2395 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002396 }
2397
Dave Houlton142c4cb2018-10-17 15:04:41 -06002398 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002399 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002400 skip |= LogError(
2401 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002402 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2403 "] "
2404 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2405 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2406 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002407 }
2408
Petr Krausa6103552017-11-16 21:21:58 +01002409 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002410 skip |= LogError(
2411 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002412 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2413 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002414 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2415 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002416 }
2417
2418 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002419 skip |= LogError(
2420 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002421 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2422 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002423 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2424 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002425 }
2426
Jeff Bolz3e71f782018-08-29 23:15:45 -05002427 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002428 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2429 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2430 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002431 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002432 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2433 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2434 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2435 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002436 }
2437
Jeff Bolz9af91c52018-09-01 21:53:57 -05002438 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002439 shading_rate_image_struct->viewportCount > 0 &&
2440 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002441 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002442 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002443 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002444 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2445 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002446 i, i);
2447 }
2448
Chris Mayer328d8212018-12-11 14:16:18 +01002449 if (vp_swizzle_struct) {
2450 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002451 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2452 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2453 " does "
2454 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2455 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002456 }
2457 }
2458
Petr Krausb3fcdb42018-01-09 22:09:09 +01002459 // validate the VkViewports
2460 if (!has_dynamic_viewport && viewport_state.pViewports) {
2461 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2462 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002463 const char *fn_name = "vkCreateGraphicsPipelines";
2464 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2465 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2466 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002467 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002468 }
2469 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002470
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002471 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002472 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2473 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2474 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2475 "VK_NV_clip_space_w_scaling extension is not enabled.",
2476 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002477 }
2478
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002479 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002480 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2481 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2482 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2483 "VK_EXT_discard_rectangles extension is not enabled.",
2484 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002485 }
2486
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002487 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002488 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2489 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2490 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2491 "VK_EXT_sample_locations extension is not enabled.",
2492 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002493 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002494
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002495 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002496 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2497 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2498 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2499 "VK_NV_scissor_exclusive extension is not enabled.",
2500 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002501 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002502
2503 if (coarse_sample_order_struct &&
2504 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2505 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002506 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2507 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2508 "] "
2509 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2510 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2511 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002512 }
2513
2514 if (coarse_sample_order_struct) {
2515 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002516 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002517 }
2518 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002519
2520 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2521 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002522 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2523 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2524 "] "
2525 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2526 ") "
2527 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2528 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002529 }
2530 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002531 skip |= LogError(
2532 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002533 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2534 "] "
2535 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2536 i);
2537 }
2538 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002539 }
2540
2541 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002542 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
2543 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
2544 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
2545 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002546 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002547 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002548 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002549 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2550 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002551 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002552 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002553 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002554 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002555 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002556 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002557 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 4, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08002558 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2559 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002560
2561 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002562 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002563 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002564 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002565
2566 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002567 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002568 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2569 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2570
2571 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002572 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002573 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2574 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002575 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002576 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002577
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002578 skip |= validate_flags(
2579 "vkCreateGraphicsPipelines",
2580 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2581 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02002582 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002583
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002584 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002585 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002586 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2587 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2588
2589 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002590 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002591 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2592 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2593
2594 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002595 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002596 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2597 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2598 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002599 }
John Zulauf7acac592017-11-06 11:15:53 -07002600 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002601 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002602 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2603 "vkCreateGraphicsPipelines(): parameter "
2604 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2605 i);
John Zulauf7acac592017-11-06 11:15:53 -07002606 }
2607 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2608 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2609 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002610 skip |= LogError(
2611 device,
2612
Dave Houlton413a6782018-05-22 13:01:54 -06002613 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002614 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002615 }
2616 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002617
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002618 const auto *line_state =
2619 LvlFindInChain<VkPipelineRasterizationLineStateCreateInfoEXT>(pCreateInfos[i].pRasterizationState->pNext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002620
2621 if (line_state) {
2622 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2623 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
2624 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
2625 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002626 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2627 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2628 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
2629 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002630 }
2631 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
2632 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002633 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2634 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2635 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
2636 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002637 }
2638 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
2639 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002640 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2641 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2642 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
2643 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002644 }
2645 }
2646 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2647 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2648 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002649 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
2650 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
2651 "range [1,256].",
2652 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002653 }
2654 }
2655 const auto *line_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002656 LvlFindInChain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002657 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2658 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002659 skip |=
2660 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
2661 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2662 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2663 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002664 }
2665 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2666 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002667 skip |=
2668 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
2669 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2670 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2671 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002672 }
2673 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2674 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002675 skip |=
2676 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
2677 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2678 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
2679 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002680 }
2681 if (line_state->stippledLineEnable) {
2682 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2683 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002684 skip |=
2685 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
2686 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2687 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
2688 "stippledRectangularLines feature.",
2689 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002690 }
2691 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2692 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002693 skip |=
2694 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
2695 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2696 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
2697 "stippledBresenhamLines feature.",
2698 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002699 }
2700 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2701 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002702 skip |=
2703 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
2704 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2705 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
2706 "stippledSmoothLines feature.",
2707 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002708 }
2709 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
2710 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002711 skip |=
2712 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
2713 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2714 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
2715 "stippledRectangularLines and strictLines features.",
2716 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002717 }
2718 }
2719 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002720 }
2721
Petr Krause91f7a12017-12-14 20:57:36 +01002722 bool uses_color_attachment = false;
2723 bool uses_depthstencil_attachment = false;
2724 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002725 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002726 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
2727 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01002728 const auto &subpasses_uses = subpasses_uses_it->second;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002729 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002730 uses_color_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002731 }
2732 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002733 uses_depthstencil_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002734 }
Petr Krause91f7a12017-12-14 20:57:36 +01002735 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002736 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01002737 }
2738
2739 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002740 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002741 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002742 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002743 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002744 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002745
2746 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002747 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002748 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002749 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002750
2751 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002752 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002753 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2754 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2755
2756 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002757 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002758 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2759 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2760
2761 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002762 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002763 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2764 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002765 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002766
2767 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002768 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002769 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2770 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2771
2772 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002773 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002774 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2775 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2776
2777 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002778 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002779 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2780 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002781 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002782
2783 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002784 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002785 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2786 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002787 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002788
2789 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002790 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002791 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2792 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002793 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002794
2795 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002796 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002797 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2798 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002799 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002800
2801 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002802 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002803 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2804 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002805 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002806
2807 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002808 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002809 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2810 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002811 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002812
2813 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002814 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002815 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2816 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002817 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002818
2819 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002820 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002821 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2822 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002823 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002824
2825 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002826 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002827 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2828 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2829 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002830 }
2831 }
2832
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002833 const VkStructureType allowed_structs_vk_pipeline_color_blend_state_create_info[] = {
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002834 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2835
Petr Krause91f7a12017-12-14 20:57:36 +01002836 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002837 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2838 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2839 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2840 pCreateInfos[i].pColorBlendState,
2841 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2842 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2843
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002844 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002845 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002846 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2847 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002848 ARRAY_SIZE(allowed_structs_vk_pipeline_color_blend_state_create_info),
2849 allowed_structs_vk_pipeline_color_blend_state_create_info, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002850 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2851 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002852
2853 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002854 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002855 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002856 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002857
2858 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002859 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002860 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2861 pCreateInfos[i].pColorBlendState->logicOpEnable);
2862
2863 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002864 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002865 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2866 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002867 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002868 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002869
2870 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002871 for (uint32_t attachment_index = 0; attachment_index < pCreateInfos[i].pColorBlendState->attachmentCount;
2872 ++attachment_index) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002873 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002874 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002875 ParameterName::IndexVector{i, attachment_index}),
2876 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].blendEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002877
2878 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002879 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002880 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002881 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002882 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002883 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002884 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002885
2886 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002887 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002888 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002889 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002890 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002891 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002892 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002893
2894 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002895 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002896 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002897 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002898 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002899 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002900 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002901
2902 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002903 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002904 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002905 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002906 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002907 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002908 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002909
2910 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002911 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002912 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002913 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002914 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002915 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002916 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002917
2918 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002919 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002920 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002921 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002922 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002923 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002924 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002925
2926 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002927 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002928 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002929 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002930 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002931 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002932 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002933 }
2934 }
2935
2936 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002937 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002938 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2939 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2940 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002941 }
2942
2943 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2944 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2945 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002946 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002947 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002948 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2949 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002950 }
2951 }
2952 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002953
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08002954 const VkPipelineCreateFlags flags = pCreateInfos[i].flags;
2955 if (flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
Petr Kraus9752aae2017-11-24 03:05:50 +01002956 if (pCreateInfos[i].basePipelineIndex != -1) {
2957 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002958 skip |=
2959 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002960 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002961 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002962 "and pCreateInfos->basePipelineIndex is not -1.",
2963 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002964 }
2965 }
2966
Petr Kraus9752aae2017-11-24 03:05:50 +01002967 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2968 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002969 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002970 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002971 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002972 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
2973 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002974 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002975 } else {
Mike Schuchardte5c15cf2020-04-06 22:57:13 -07002976 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002977 skip |=
2978 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2979 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->basePipelineIndex (%d) must be a valid"
2980 "index into the pCreateInfos array, of size %d.",
2981 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002982 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002983 }
2984 }
2985
Petr Kraus9752aae2017-11-24 03:05:50 +01002986 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002987 if (!device_extensions.vk_nv_fill_rectangle) {
2988 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2989 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002990 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2991 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2992 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2993 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002994 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2995 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07002996 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002997 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002998 "pCreateInfos[%u]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2999 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
3000 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02003001 }
3002 } else {
3003 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
3004 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
3005 (physical_device_features.fillModeNonSolid == false)) {
3006 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003007 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
3008 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003009 "pCreateInfos[%u]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
3010 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
3011 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02003012 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003013 }
Petr Kraus299ba622017-11-24 03:09:03 +01003014
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003015 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01003016 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003017 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
3018 "The line width state is static (pCreateInfos[%" PRIu32
3019 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
3020 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
3021 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
3022 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003023 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003024 }
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003025
3026 // Validate no flags not allowed are used
3027 if ((flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
sfricke-samsungad008902021-04-16 01:25:34 -07003028 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
3029 "vkCreateGraphicsPipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3030 "VK_PIPELINE_CREATE_DISPATCH_BASE.",
3031 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003032 }
3033 if ((flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
sfricke-samsungad008902021-04-16 01:25:34 -07003034 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03371",
3035 "vkCreateGraphicsPipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3036 "VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.",
3037 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003038 }
3039 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
3040 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03372",
sfricke-samsungad008902021-04-16 01:25:34 -07003041 "vkCreateGraphicsPipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3042 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
3043 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003044 }
3045 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
3046 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03373",
sfricke-samsungad008902021-04-16 01:25:34 -07003047 "vkCreateGraphicsPipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3048 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
3049 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003050 }
3051 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
3052 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03374",
sfricke-samsungad008902021-04-16 01:25:34 -07003053 "vkCreateGraphicsPipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3054 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
3055 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003056 }
3057 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
3058 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03375",
sfricke-samsungad008902021-04-16 01:25:34 -07003059 "vkCreateGraphicsPipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3060 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
3061 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003062 }
3063 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
3064 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03376",
sfricke-samsungad008902021-04-16 01:25:34 -07003065 "vkCreateGraphicsPipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3066 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
3067 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003068 }
3069 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
3070 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03377",
sfricke-samsungad008902021-04-16 01:25:34 -07003071 "vkCreateGraphicsPipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3072 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
3073 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003074 }
3075 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
3076 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03577",
sfricke-samsungad008902021-04-16 01:25:34 -07003077 "vkCreateGraphicsPipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3078 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
3079 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003080 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003081 }
3082 }
3083
3084 return skip;
3085}
3086
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003087bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
3088 uint32_t createInfoCount,
3089 const VkComputePipelineCreateInfo *pCreateInfos,
3090 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003091 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003092 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003093 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003094 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003095 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06003096 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003097 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04003098 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003099 skip |=
3100 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
3101 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
3102 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
3103 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04003104 }
sfricke-samsungc5227152020-02-09 17:36:31 -08003105
3106 // Make sure compute stage is selected
3107 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003108 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
3109 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
3110 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08003111 }
sourav parmarcd5fb182020-07-17 12:58:44 -07003112
sfricke-samsungeb549012021-04-16 01:25:51 -07003113 const VkPipelineCreateFlags flags = pCreateInfos[i].flags;
3114 // Validate no flags not allowed are used
3115 if ((flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
3116 skip |= LogError(
3117 device, "VUID-VkComputePipelineCreateInfo-flags-03364",
3118 "vkCreateComputePipelines(): pCreateInfos[%u]->flags (0x%x) must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.",
3119 i, flags);
3120 }
3121 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
3122 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03365",
3123 "vkCreateComputePipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3124 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
3125 i, flags);
3126 }
3127 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
3128 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03366",
3129 "vkCreateComputePipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3130 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
3131 i, flags);
3132 }
3133 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
3134 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03367",
3135 "vkCreateComputePipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3136 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
3137 i, flags);
3138 }
3139 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
3140 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03368",
3141 "vkCreateComputePipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3142 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
3143 i, flags);
3144 }
3145 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
3146 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03369",
3147 "vkCreateComputePipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3148 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
3149 i, flags);
3150 }
3151 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
3152 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03370",
3153 "vkCreateComputePipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3154 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
3155 i, flags);
3156 }
3157 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
3158 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03576",
3159 "vkCreateComputePipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3160 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
3161 i, flags);
3162 }
3163 if ((flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) != 0) {
3164 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-02874",
3165 "vkCreateComputePipelines(): pCreateInfos[%u]->flags (0x%x) must not include "
3166 "VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.",
3167 i, flags);
sourav parmarcd5fb182020-07-17 12:58:44 -07003168 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003169 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003170 return skip;
3171}
3172
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003173bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003174 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003175 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003176
3177 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003178 const auto &features = physical_device_features;
3179 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003180
John Zulauf71968502017-10-26 13:51:15 -06003181 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
3182 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003183 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
3184 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
3185 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
3186 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06003187 }
3188
3189 // Anistropy cannot be enabled in sampler unless enabled as a feature
3190 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003191 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
3192 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
3193 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06003194 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003195 }
John Zulauf71968502017-10-26 13:51:15 -06003196
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003197 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
3198 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003199 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
3200 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3201 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3202 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003203 }
3204 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003205 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
3206 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3207 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3208 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003209 }
3210 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003211 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
3212 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3213 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
3214 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003215 }
3216 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
3217 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3218 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
3219 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003220 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
3221 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3222 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
3223 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
3224 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3225 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003226 }
3227 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003228 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
3229 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
3230 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06003231 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003232 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003233 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
3234 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
3235 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003236 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003237 }
3238
3239 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
3240 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003241 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
3242 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003243 const auto *sampler_reduction = LvlFindInChain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
sfricke-samsung85252fb2020-05-08 20:44:06 -07003244 if (sampler_reduction != nullptr) {
3245 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
3246 skip |= LogError(
3247 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
3248 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
3249 }
3250 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003251 }
3252
3253 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
3254 // valid VkBorderColor value
3255 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3256 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3257 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003258 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
3259 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003260 }
3261
John Zulauf275805c2017-10-26 15:34:49 -06003262 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003263 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06003264 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
3265 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003266 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
3267 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
3268 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06003269 }
3270 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003271
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003272 // Check for valid Lod range
3273 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003274 skip |=
3275 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
3276 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003277 }
3278
3279 // Check mipLodBias to device limit
3280 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003281 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
3282 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
3283 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003284 }
3285
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003286 const auto *sampler_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003287 if (sampler_conversion != nullptr) {
3288 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3289 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3290 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3291 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003292 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003293 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003294 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
3295 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
3296 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
3297 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
3298 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
3299 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
3300 }
3301 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02003302
3303 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
3304 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
3305 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
3306 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3307 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3308 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
3309 }
3310 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
3311 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
3312 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3313 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3314 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
3315 }
3316 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
3317 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
3318 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3319 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
3320 pCreateInfo->minLod, pCreateInfo->maxLod);
3321 }
3322 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3323 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
3324 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3325 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
3326 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
3327 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3328 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
3329 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
3330 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3331 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
3332 }
3333 if (pCreateInfo->anisotropyEnable) {
3334 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
3335 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3336 "pCreateInfo->anisotropyEnable must be VK_FALSE");
3337 }
3338 if (pCreateInfo->compareEnable) {
3339 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
3340 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3341 "pCreateInfo->compareEnable must be VK_FALSE");
3342 }
3343 if (pCreateInfo->unnormalizedCoordinates) {
3344 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
3345 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3346 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
3347 }
3348 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003349 }
3350
Tony-LunarG7337b312020-04-15 16:40:25 -06003351 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
3352 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
3353 if (!device_extensions.vk_ext_custom_border_color) {
3354 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
3355 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
3356 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
3357 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003358 auto custom_create_info = LvlFindInChain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
Tony-LunarG7337b312020-04-15 16:40:25 -06003359 if (!custom_create_info) {
3360 skip |=
3361 LogError(device, "VUID-VkSamplerCreateInfo-borderColor-04011",
3362 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
3363 "struct in pNext chain.\n",
3364 string_VkBorderColor(pCreateInfo->borderColor));
3365 } else {
3366 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
3367 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT && !FormatIsSampledInt(custom_create_info->format)) ||
3368 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
3369 !FormatIsSampledFloat(custom_create_info->format)))) {
3370 skip |= LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
3371 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
3372 "whose type does not match\n",
3373 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
3374 ;
3375 }
3376 }
3377 }
3378
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003379 return skip;
3380}
3381
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003382bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
3383 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
3384 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003385 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003386 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003387
3388 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3389 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
3390 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
3391 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003392 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3393 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
3394 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
3395 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
3396 ++descriptor_index) {
3397 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07003398 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003399 "vkCreateDescriptorSetLayout: required parameter "
3400 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
3401 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003402 }
3403 }
3404 }
3405
3406 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
3407 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
3408 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003409 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
3410 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
3411 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
3412 "values.",
3413 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003414 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07003415
3416 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
3417 (pCreateInfo->pBindings[i].stageFlags != 0) &&
3418 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
3419 skip |=
3420 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
3421 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
3422 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
3423 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
3424 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
3425 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003426 }
3427 }
3428 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003429 return skip;
3430}
3431
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003432bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
3433 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003434 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003435 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3436 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3437 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003438 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
3439 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003440}
3441
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003442bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
3443 const VkWriteDescriptorSet *pDescriptorWrites,
3444 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003445 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003446
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003447 if (pDescriptorWrites != NULL) {
3448 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
3449 // descriptorCount must be greater than 0
3450 if (pDescriptorWrites[i].descriptorCount == 0) {
3451 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003452 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
3453 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003454 }
3455
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003456 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
3457 if (validateDstSet) {
3458 // dstSet must be a valid VkDescriptorSet handle
3459 skip |= validate_required_handle(vkCallingFunction,
3460 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
3461 pDescriptorWrites[i].dstSet);
3462 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003463
3464 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3465 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
3466 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
3467 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
3468 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
3469 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
3470 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
Jeff Bolz165818a2020-05-08 11:19:03 -05003471 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures.
3472 // Valid imageView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003473 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003474 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
3475 "%s(): if pDescriptorWrites[%d].descriptorType is "
3476 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
3477 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
3478 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
3479 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003480 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
3481 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05003482 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
3483 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003484 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3485 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003486 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003487 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
3488 ParameterName::IndexVector{i, descriptor_index}),
3489 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06003490 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003491 }
3492 }
3493 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3494 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3495 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
3496 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
3497 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
3498 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
3499 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05003500 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003501 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003502 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
3503 "%s(): if pDescriptorWrites[%d].descriptorType is "
3504 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
3505 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
3506 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
3507 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003508 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05003509 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003510 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05003511 if (robustness2_features && robustness2_features->nullDescriptor) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003512 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3513 ++descriptor_index) {
3514 if (pDescriptorWrites[i].pBufferInfo[descriptor_index].buffer == VK_NULL_HANDLE &&
3515 (pDescriptorWrites[i].pBufferInfo[descriptor_index].offset != 0 ||
3516 pDescriptorWrites[i].pBufferInfo[descriptor_index].range != VK_WHOLE_SIZE)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003517 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
3518 "%s(): if pDescriptorWrites[%d].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01003519 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003520 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptor_index].offset,
3521 pDescriptorWrites[i].pBufferInfo[descriptor_index].range);
Jeff Bolz165818a2020-05-08 11:19:03 -05003522 }
3523 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003524 }
3525 }
3526 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
3527 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003528 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003529 }
3530
3531 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3532 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003533 VkDeviceSize uniform_alignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003534 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3535 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003536 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003537 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003538 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
3539 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3540 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003541 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003542 }
3543 }
3544 }
3545 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3546 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003547 VkDeviceSize storage_alignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003548 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3549 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003550 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003551 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003552 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
3553 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3554 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003555 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003556 }
3557 }
3558 }
3559 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003560 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
3561 // or VkWriteDescriptorSetInlineUniformBlockEX
sourav parmarbcee7512020-12-28 14:34:49 -08003562 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003563 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08003564 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
3565 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
3566 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
3567 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
3568 "accelerationStructureCount %d member equals descriptorCount %d.",
3569 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
3570 pDescriptorWrites[i].descriptorCount);
3571 }
3572 // further checks only if we have right structtype
3573 if (pnext_struct) {
3574 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
3575 skip |= LogError(
3576 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
3577 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3578 ".",
3579 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07003580 }
sourav parmarbcee7512020-12-28 14:34:49 -08003581 if (pnext_struct->accelerationStructureCount == 0) {
3582 skip |= LogError(device,
3583 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06003584 "%s(): accelerationStructureCount must be greater than 0 .", vkCallingFunction);
sourav parmarbcee7512020-12-28 14:34:49 -08003585 }
3586 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003587 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08003588 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3589 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3590 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3591 skip |= LogError(device,
3592 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-pAccelerationStructures-03580",
3593 "%s(): If the nullDescriptor feature is not enabled, each member of "
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06003594 "pAccelerationStructures must not be VK_NULL_HANDLE.", vkCallingFunction);
sourav parmarcd5fb182020-07-17 12:58:44 -07003595 }
3596 }
3597 }
sourav parmarbcee7512020-12-28 14:34:49 -08003598 }
3599 } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003600 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureNV>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08003601 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
3602 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-03817",
3603 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV, the pNext"
3604 "chain must include a VkWriteDescriptorSetAccelerationStructureNV structure whose "
3605 "accelerationStructureCount %d member equals descriptorCount %d.",
3606 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
3607 pDescriptorWrites[i].descriptorCount);
3608 }
3609 // further checks only if we have right structtype
3610 if (pnext_struct) {
3611 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
3612 skip |= LogError(
3613 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-03747",
3614 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3615 ".",
3616 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmarcd5fb182020-07-17 12:58:44 -07003617 }
sourav parmarbcee7512020-12-28 14:34:49 -08003618 if (pnext_struct->accelerationStructureCount == 0) {
3619 skip |= LogError(device,
3620 "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-arraylength",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06003621 "%s(): accelerationStructureCount must be greater than 0 .", vkCallingFunction);
sourav parmarbcee7512020-12-28 14:34:49 -08003622 }
3623 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003624 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08003625 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3626 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3627 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3628 skip |= LogError(device,
3629 "VUID-VkWriteDescriptorSetAccelerationStructureNV-pAccelerationStructures-03749",
3630 "%s(): If the nullDescriptor feature is not enabled, each member of "
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06003631 "pAccelerationStructures must not be VK_NULL_HANDLE.", vkCallingFunction);
sourav parmarcd5fb182020-07-17 12:58:44 -07003632 }
3633 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003634 }
3635 }
3636 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003637 }
3638 }
3639 return skip;
3640}
3641
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003642bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
3643 const VkWriteDescriptorSet *pDescriptorWrites,
3644 uint32_t descriptorCopyCount,
3645 const VkCopyDescriptorSet *pDescriptorCopies) const {
3646 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
3647}
3648
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003649bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003650 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003651 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003652 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
3653}
3654
sfricke-samsung681ab7b2020-10-29 01:53:35 -07003655bool StatelessValidation::manual_PreCallValidateCreateRenderPass2(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
3656 const VkAllocationCallbacks *pAllocator,
3657 VkRenderPass *pRenderPass) const {
3658 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3659}
3660
Mike Schuchardt2df08912020-12-15 16:28:09 -08003661bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003662 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003663 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003664 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3665}
3666
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003667bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
3668 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003669 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003670 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003671
3672 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3673 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3674 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003675 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
3676 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003677 return skip;
3678}
3679
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003680bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003681 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003682 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02003683
3684 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
3685 const char *cmd_name = "vkBeginCommandBuffer";
Tony-LunarG3c287f62020-12-17 12:39:49 -07003686 bool cb_is_secondary;
3687 {
3688 auto lock = cb_read_lock();
3689 cb_is_secondary = (secondary_cb_map.find(commandBuffer) != secondary_cb_map.end());
3690 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003691
Tony-LunarG3c287f62020-12-17 12:39:49 -07003692 if (cb_is_secondary) {
3693 // Implicit VUs
3694 // validate only sType here; pointer has to be validated in core_validation
3695 const bool k_not_required = false;
3696 const char *k_no_vuid = nullptr;
3697 const VkCommandBufferInheritanceInfo *info = pBeginInfo->pInheritanceInfo;
3698 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003699 info, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, k_not_required, k_no_vuid,
3700 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003701
Tony-LunarG3c287f62020-12-17 12:39:49 -07003702 if (info) {
3703 const VkStructureType allowed_structs_vk_command_buffer_inheritance_info[] = {
David Zhao Akeley44139b12021-04-26 16:16:13 -07003704 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT,
3705 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_VIEWPORT_SCISSOR_INFO_NV};
Tony-LunarG3c287f62020-12-17 12:39:49 -07003706 skip |= validate_struct_pnext(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003707 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT",
3708 info->pNext, ARRAY_SIZE(allowed_structs_vk_command_buffer_inheritance_info),
3709 allowed_structs_vk_command_buffer_inheritance_info, GeneratedVulkanHeaderVersion,
3710 "VUID-VkCommandBufferInheritanceInfo-pNext-pNext", "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003711
Tony-LunarG3c287f62020-12-17 12:39:49 -07003712 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", info->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003713
Tony-LunarG3c287f62020-12-17 12:39:49 -07003714 // Explicit VUs
3715 if (!physical_device_features.inheritedQueries && info->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003716 skip |= LogError(
Tony-LunarG3c287f62020-12-17 12:39:49 -07003717 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
3718 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
3719 cmd_name);
3720 }
3721
3722 if (physical_device_features.inheritedQueries) {
3723 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003724 AllVkQueryControlFlagBits, info->queryFlags, kOptionalFlags,
3725 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
3726 } else { // !inheritedQueries
Tony-LunarG3c287f62020-12-17 12:39:49 -07003727 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", info->queryFlags,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003728 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Tony-LunarG3c287f62020-12-17 12:39:49 -07003729 }
3730
3731 if (physical_device_features.pipelineStatisticsQuery) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003732 skip |=
3733 validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
3734 AllVkQueryPipelineStatisticFlagBits, info->pipelineStatistics, kOptionalFlags,
3735 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
3736 } else { // !pipelineStatisticsQuery
3737 skip |=
3738 validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", info->pipelineStatistics,
3739 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Tony-LunarG3c287f62020-12-17 12:39:49 -07003740 }
3741
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003742 const auto *conditional_rendering = LvlFindInChain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(info->pNext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07003743 if (conditional_rendering) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003744 const auto *cr_features = LvlFindInChain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07003745 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
3746 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
3747 skip |= LogError(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003748 commandBuffer,
3749 "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Tony-LunarG3c287f62020-12-17 12:39:49 -07003750 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
3751 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
3752 }
Petr Kraus139757b2019-08-15 17:19:33 +02003753 }
3754 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003755 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003756 return skip;
3757}
3758
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003759bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003760 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003761 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003762
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003763 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01003764 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003765 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
3766 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3767 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01003768 }
3769 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003770 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
3771 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3772 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01003773 }
3774 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01003775 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003776 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003777 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
3778 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3779 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3780 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003781 }
3782 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01003783
3784 if (pViewports) {
3785 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
3786 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06003787 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003788 skip |= manual_PreCallValidateViewport(
3789 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01003790 }
3791 }
3792
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003793 return skip;
3794}
3795
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003796bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003797 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003798 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003799
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003800 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003801 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003802 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
3803 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
3804 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003805 }
3806 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003807 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
3808 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
3809 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003810 }
3811 } else { // multiViewport enabled
3812 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003813 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003814 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
3815 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3816 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3817 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003818 }
3819 }
3820
Petr Kraus6260f0a2018-02-27 21:15:55 +01003821 if (pScissors) {
3822 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
3823 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003824
Petr Kraus6260f0a2018-02-27 21:15:55 +01003825 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003826 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3827 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3828 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003829 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003830
Petr Kraus6260f0a2018-02-27 21:15:55 +01003831 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003832 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3833 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3834 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003835 }
3836
3837 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3838 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003839 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
3840 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3841 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3842 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003843 }
3844
3845 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3846 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003847 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
3848 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3849 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3850 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003851 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003852 }
3853 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01003854
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003855 return skip;
3856}
3857
Jeff Bolz5c801d12019-10-09 10:38:45 -05003858bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01003859 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01003860
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003861 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003862 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
3863 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003864 }
3865
3866 return skip;
3867}
3868
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003869bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003870 uint32_t drawCount, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003871 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003872
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003873 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski41ce65b2020-10-30 12:17:06 -06003874 skip |= LogError(device, "VUID-vkCmdDrawIndirect-drawCount-02718",
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003875 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
3876 }
3877 if (drawCount > device_limits.maxDrawIndirectCount) {
3878 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirect-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003879 "CmdDrawIndirect(): drawCount (%u) is not less than or equal to the maximum allowed (%u).", drawCount,
3880 device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003881 }
3882 return skip;
3883}
3884
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003885bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003886 VkDeviceSize offset, uint32_t drawCount,
3887 uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003888 bool skip = false;
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003889 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003890 skip |= LogError(device, "VUID-vkCmdDrawIndexedIndirect-drawCount-02718",
3891 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d",
3892 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003893 }
3894 if (drawCount > device_limits.maxDrawIndirectCount) {
3895 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirect-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003896 "CmdDrawIndexedIndirect(): drawCount (%u) is not less than or equal to the maximum allowed (%u).",
3897 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003898 }
3899 return skip;
3900}
3901
sfricke-samsungf692b972020-05-02 08:00:45 -07003902bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3903 VkDeviceSize countBufferOffset, bool khr) const {
3904 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003905 const char *api_name = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07003906 if (offset & 3) {
3907 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003908 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07003909 }
3910
3911 if (countBufferOffset & 3) {
3912 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003913 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07003914 countBufferOffset);
3915 }
3916 return skip;
3917}
3918
3919bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3920 VkDeviceSize offset, VkBuffer countBuffer,
3921 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3922 uint32_t stride) const {
3923 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
3924}
3925
3926bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3927 VkDeviceSize offset, VkBuffer countBuffer,
3928 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3929 uint32_t stride) const {
3930 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
3931}
3932
3933bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3934 VkDeviceSize countBufferOffset, bool khr) const {
3935 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003936 const char *api_name = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07003937 if (offset & 3) {
3938 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003939 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07003940 }
3941
3942 if (countBufferOffset & 3) {
3943 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003944 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07003945 countBufferOffset);
3946 }
3947 return skip;
3948}
3949
3950bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3951 VkDeviceSize offset, VkBuffer countBuffer,
3952 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3953 uint32_t stride) const {
3954 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
3955}
3956
3957bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3958 VkDeviceSize offset, VkBuffer countBuffer,
3959 VkDeviceSize countBufferOffset,
3960 uint32_t maxDrawCount, uint32_t stride) const {
3961 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
3962}
3963
Tony-LunarG4490de42021-06-21 15:49:19 -06003964bool StatelessValidation::manual_PreCallValidateCmdDrawMultiEXT(VkCommandBuffer commandBuffer, uint32_t drawCount,
3965 const VkMultiDrawInfoEXT *pVertexInfo, uint32_t instanceCount,
3966 uint32_t firstInstance, uint32_t stride) const {
3967 bool skip = false;
3968 if (stride & 3) {
3969 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiEXT-stride-04936",
3970 "CmdDrawMultiEXT: parameter, uint32_t stride (%" PRIu32 ") is not a multiple of 4.", stride);
3971 }
3972 if (drawCount && nullptr == pVertexInfo) {
3973 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiEXT-drawCount-04935",
3974 "CmdDrawMultiEXT: parameter, VkMultiDrawInfoEXT *pVertexInfo must be a valid pointer to memory containing "
3975 "one or more valid instances of VkMultiDrawInfoEXT structures");
3976 }
3977 return skip;
3978}
3979
3980bool StatelessValidation::manual_PreCallValidateCmdDrawMultiIndexedEXT(VkCommandBuffer commandBuffer, uint32_t drawCount,
3981 const VkMultiDrawIndexedInfoEXT *pIndexInfo,
3982 uint32_t instanceCount, uint32_t firstInstance,
3983 uint32_t stride, const int32_t *pVertexOffset) const {
3984 bool skip = false;
3985 if (stride & 3) {
3986 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiIndexedEXT-stride-04941",
3987 "CmdDrawMultiIndexedEXT: parameter, uint32_t stride (%" PRIu32 ") is not a multiple of 4.", stride);
3988 }
3989 if (drawCount && nullptr == pIndexInfo) {
3990 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiIndexedEXT-drawCount-04940",
3991 "CmdDrawMultiIndexedEXT: parameter, VkMultiDrawIndexedInfoEXT *pIndexInfo must be a valid pointer to "
3992 "memory containing one or more valid instances of VkMultiDrawIndexedInfoEXT structures");
3993 }
3994 return skip;
3995}
3996
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003997bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
3998 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003999 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004000 bool skip = false;
4001 for (uint32_t rect = 0; rect < rectCount; rect++) {
4002 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004003 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
4004 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004005 }
sfricke-samsung10867682020-04-25 02:20:39 -07004006 if (pRects[rect].rect.extent.width == 0) {
4007 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
4008 "CmdClearAttachments(): pRects[%d].rect.extent.width is zero.", rect);
4009 }
4010 if (pRects[rect].rect.extent.height == 0) {
4011 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
4012 "CmdClearAttachments(): pRects[%d].rect.extent.height is zero.", rect);
4013 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004014 }
4015 return skip;
4016}
4017
Andrew Fobel3abeb992020-01-20 16:33:22 -05004018bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
4019 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4020 VkImageFormatProperties2 *pImageFormatProperties,
4021 const char *apiName) const {
4022 bool skip = false;
4023
4024 if (pImageFormatInfo != nullptr) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004025 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pImageFormatInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05004026 if (image_stencil_struct != nullptr) {
4027 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
4028 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
4029 // No flags other than the legal attachment bits may be set
4030 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
4031 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004032 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
4033 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
4034 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
4035 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
4036 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05004037 }
4038 }
4039 }
4040 }
4041
4042 return skip;
4043}
4044
4045bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
4046 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4047 VkImageFormatProperties2 *pImageFormatProperties) const {
4048 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
4049 "vkGetPhysicalDeviceImageFormatProperties2");
4050}
4051
4052bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
4053 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4054 VkImageFormatProperties2 *pImageFormatProperties) const {
4055 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
4056 "vkGetPhysicalDeviceImageFormatProperties2KHR");
4057}
4058
Lionel Landwerlin5fe52752020-07-22 08:18:14 +03004059bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties(
4060 VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage,
4061 VkImageCreateFlags flags, VkImageFormatProperties *pImageFormatProperties) const {
4062 bool skip = false;
4063
4064 if (tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4065 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceImageFormatProperties-tiling-02248",
4066 "vkGetPhysicalDeviceImageFormatProperties(): tiling must not be VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.");
4067 }
4068
4069 return skip;
4070}
4071
sfricke-samsung3999ef62020-02-09 17:05:59 -08004072bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
4073 uint32_t regionCount, const VkBufferCopy *pRegions) const {
4074 bool skip = false;
4075
4076 if (pRegions != nullptr) {
4077 for (uint32_t i = 0; i < regionCount; i++) {
4078 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004079 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
4080 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08004081 }
4082 }
4083 }
4084 return skip;
4085}
4086
Jeff Leger178b1e52020-10-05 12:22:23 -04004087bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2KHR(VkCommandBuffer commandBuffer,
4088 const VkCopyBufferInfo2KHR *pCopyBufferInfo) const {
4089 bool skip = false;
4090
4091 if (pCopyBufferInfo->pRegions != nullptr) {
4092 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
4093 if (pCopyBufferInfo->pRegions[i].size == 0) {
4094 skip |= LogError(device, "VUID-VkBufferCopy2KHR-size-01988",
4095 "vkCmdCopyBuffer2KHR() pCopyBufferInfo->pRegions[%u].size must be greater than zero", i);
4096 }
4097 }
4098 }
4099 return skip;
4100}
4101
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004102bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004103 VkDeviceSize dstOffset, VkDeviceSize dataSize,
4104 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004105 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004106
4107 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004108 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
4109 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4110 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004111 }
4112
4113 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004114 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
4115 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
4116 "), must be greater than zero and less than or equal to 65536.",
4117 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004118 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004119 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
4120 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4121 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004122 }
4123 return skip;
4124}
4125
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004126bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004127 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004128 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004129
4130 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004131 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
4132 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4133 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004134 }
4135
4136 if (size != VK_WHOLE_SIZE) {
4137 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004138 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004139 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
4140 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004141 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004142 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
4143 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004144 }
4145 }
4146 return skip;
4147}
4148
sfricke-samsunga1d00272021-03-10 21:37:41 -08004149bool StatelessValidation::ValidateSwapchainCreateInfo(const char *func_name, VkSwapchainCreateInfoKHR const *pCreateInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004150 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004151
4152 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004153 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4154 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
4155 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
4156 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004157 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004158 "%s: if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
4159 "pCreateInfo->queueFamilyIndexCount must be greater than 1.",
4160 func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004161 }
4162
4163 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
4164 // queueFamilyIndexCount uint32_t values
4165 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004166 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004167 "%s: if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004168 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
sfricke-samsunga1d00272021-03-10 21:37:41 -08004169 "pCreateInfo->queueFamilyIndexCount uint32_t values.",
4170 func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004171 }
4172 }
4173
Dave Houlton413a6782018-05-22 13:01:54 -06004174 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004175 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004176
sfricke-samsunga1d00272021-03-10 21:37:41 -08004177 // Validate VK_KHR_image_format_list VkImageFormatListCreateInfo
4178 const auto format_list_info = LvlFindInChain<VkImageFormatListCreateInfo>(pCreateInfo->pNext);
4179 if (format_list_info) {
4180 const uint32_t viewFormatCount = format_list_info->viewFormatCount;
4181 if (((pCreateInfo->flags & VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR) == 0) && (viewFormatCount > 1)) {
4182 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-flags-04100",
4183 "%s: If the VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR is not set, then "
4184 "VkImageFormatListCreateInfo::viewFormatCount (%u) must be 0 or 1 if it is in the pNext chain.",
4185 func_name, viewFormatCount);
4186 }
4187
4188 // Using the first format, compare the rest of the formats against it that they are compatible
4189 for (uint32_t i = 1; i < viewFormatCount; i++) {
4190 if (FormatCompatibilityClass(format_list_info->pViewFormats[0]) !=
4191 FormatCompatibilityClass(format_list_info->pViewFormats[i])) {
4192 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-pNext-04099",
4193 "%s: VkImageFormatListCreateInfo::pViewFormats[0] (%s) and "
4194 "VkImageFormatListCreateInfo::pViewFormats[%u] (%s) are not compatible in the pNext chain.",
4195 func_name, string_VkFormat(format_list_info->pViewFormats[0]), i,
4196 string_VkFormat(format_list_info->pViewFormats[i]));
4197 }
4198 }
4199 }
4200
4201 // Validate VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR
4202 if ((pCreateInfo->flags & VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR) != 0) {
4203 if (!IsExtEnabled(device_extensions.vk_khr_swapchain_mutable_format)) {
4204 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
4205 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR which requires the "
4206 "VK_KHR_swapchain_mutable_format extension, which has not been enabled.",
4207 func_name);
4208 } else {
4209 if (format_list_info == nullptr) {
4210 skip |= LogError(
4211 device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
4212 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but the pNext chain of "
4213 "pCreateInfo does not contain an instance of VkImageFormatListCreateInfo.",
4214 func_name);
4215 } else if (format_list_info->viewFormatCount == 0) {
4216 skip |= LogError(
4217 device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
4218 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but the viewFormatCount "
4219 "member of VkImageFormatListCreateInfo in the pNext chain is zero.",
4220 func_name);
4221 } else {
4222 bool found_base_format = false;
4223 for (uint32_t i = 0; i < format_list_info->viewFormatCount; ++i) {
4224 if (format_list_info->pViewFormats[i] == pCreateInfo->imageFormat) {
4225 found_base_format = true;
4226 break;
4227 }
4228 }
4229 if (!found_base_format) {
4230 skip |=
4231 LogError(device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
4232 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but none of the "
4233 "elements of the pViewFormats member of VkImageFormatListCreateInfo match "
4234 "pCreateInfo->imageFormat.",
4235 func_name);
4236 }
4237 }
4238 }
4239 }
4240 }
4241 return skip;
4242}
4243
4244bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
4245 const VkAllocationCallbacks *pAllocator,
4246 VkSwapchainKHR *pSwapchain) const {
4247 bool skip = false;
4248 skip |= ValidateSwapchainCreateInfo("vkCreateSwapchainKHR()", pCreateInfo);
4249 return skip;
4250}
4251
4252bool StatelessValidation::manual_PreCallValidateCreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount,
4253 const VkSwapchainCreateInfoKHR *pCreateInfos,
4254 const VkAllocationCallbacks *pAllocator,
4255 VkSwapchainKHR *pSwapchains) const {
4256 bool skip = false;
4257 if (pCreateInfos) {
4258 for (uint32_t i = 0; i < swapchainCount; i++) {
4259 std::stringstream func_name;
4260 func_name << "vkCreateSharedSwapchainsKHR[" << swapchainCount << "]()";
4261 skip |= ValidateSwapchainCreateInfo(func_name.str().c_str(), &pCreateInfos[i]);
4262 }
4263 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004264 return skip;
4265}
4266
Jeff Bolz5c801d12019-10-09 10:38:45 -05004267bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004268 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004269
4270 if (pPresentInfo && pPresentInfo->pNext) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004271 const auto *present_regions = LvlFindInChain<VkPresentRegionsKHR>(pPresentInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -06004272 if (present_regions) {
4273 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07004274 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06004275 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
4276 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07004277 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004278 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
4279 "extension swapchainCount is %i. These values must be equal.",
4280 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06004281 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004282 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08004283 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
4284 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004285 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
4286 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
4287 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06004288 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004289 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004290 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06004291 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004292 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004293 }
4294 }
4295
4296 return skip;
4297}
4298
sfricke-samsung5c1b7392020-12-13 22:17:15 -08004299bool StatelessValidation::manual_PreCallValidateCreateDisplayModeKHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
4300 const VkDisplayModeCreateInfoKHR *pCreateInfo,
4301 const VkAllocationCallbacks *pAllocator,
4302 VkDisplayModeKHR *pMode) const {
4303 bool skip = false;
4304
4305 const VkDisplayModeParametersKHR display_mode_parameters = pCreateInfo->parameters;
4306 if (display_mode_parameters.visibleRegion.width == 0) {
4307 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-width-01990",
4308 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.width must be greater than 0.");
4309 }
4310 if (display_mode_parameters.visibleRegion.height == 0) {
4311 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-height-01991",
4312 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.height must be greater than 0.");
4313 }
4314 if (display_mode_parameters.refreshRate == 0) {
4315 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-refreshRate-01992",
4316 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.refreshRate must be greater than 0.");
4317 }
4318
4319 return skip;
4320}
4321
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004322#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004323bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
4324 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
4325 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004326 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004327 bool skip = false;
4328
4329 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004330 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
4331 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004332 }
4333
4334 return skip;
4335}
4336#endif // VK_USE_PLATFORM_WIN32_KHR
4337
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004338bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004339 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004340 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02004341 bool skip = false;
4342
4343 if (pCreateInfo) {
4344 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004345 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
4346 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02004347 }
4348
4349 if (pCreateInfo->pPoolSizes) {
4350 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
4351 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004352 skip |= LogError(
4353 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004354 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02004355 }
Jeff Bolze54ae892018-09-08 12:16:29 -05004356 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
4357 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004358 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
4359 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
4360 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
4361 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
4362 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05004363 }
Petr Krausc8655be2017-09-27 18:56:51 +02004364 }
4365 }
4366 }
4367
4368 return skip;
4369}
4370
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004371bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004372 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004373 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004374
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004375 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004376 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004377 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
4378 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4379 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004380 }
4381
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004382 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004383 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004384 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
4385 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4386 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004387 }
4388
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004389 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004390 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004391 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
4392 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4393 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004394 }
4395
4396 return skip;
4397}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004398
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004399bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004400 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07004401 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07004402
4403 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004404 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
4405 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07004406 }
4407 return skip;
4408}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004409
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004410bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
4411 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004412 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004413 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004414
4415 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004416 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004417 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004418 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
4419 "vkCmdDispatch(): baseGroupX (%" PRIu32
4420 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4421 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004422 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004423 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
4424 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
4425 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4426 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004427 }
4428
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004429 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004430 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004431 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
4432 "vkCmdDispatch(): baseGroupY (%" PRIu32
4433 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4434 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004435 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004436 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
4437 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
4438 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4439 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004440 }
4441
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004442 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004443 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004444 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
4445 "vkCmdDispatch(): baseGroupZ (%" PRIu32
4446 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4447 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004448 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004449 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
4450 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
4451 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4452 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004453 }
4454
4455 return skip;
4456}
4457
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004458bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
4459 VkPipelineBindPoint pipelineBindPoint,
4460 VkPipelineLayout layout, uint32_t set,
4461 uint32_t descriptorWriteCount,
4462 const VkWriteDescriptorSet *pDescriptorWrites) const {
4463 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
4464}
4465
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004466bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
4467 uint32_t firstExclusiveScissor,
4468 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004469 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05004470 bool skip = false;
4471
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004472 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05004473 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004474 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004475 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
4476 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
4477 ") is not 0.",
4478 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004479 }
4480 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004481 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004482 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
4483 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
4484 ") is not 1.",
4485 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004486 }
4487 } else { // multiViewport enabled
4488 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004489 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004490 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
4491 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
4492 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4493 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004494 }
4495 }
4496
Jeff Bolz3e71f782018-08-29 23:15:45 -05004497 if (pExclusiveScissors) {
4498 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
4499 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
4500
4501 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004502 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4503 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
4504 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004505 }
4506
4507 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004508 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4509 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
4510 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004511 }
4512
4513 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
4514 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004515 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
4516 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4517 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4518 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004519 }
4520
4521 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
4522 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004523 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
4524 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4525 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4526 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004527 }
4528 }
4529 }
4530
4531 return skip;
4532}
4533
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004534bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
4535 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004536 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004537 bool skip = false;
Shannon McPherson169d0c72020-11-13 18:48:19 -07004538 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
4539 if ((sum < 1) || (sum > device_limits.maxViewports)) {
4540 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
4541 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4542 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
4543 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004544 }
4545
4546 return skip;
4547}
4548
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004549bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
4550 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004551 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004552 bool skip = false;
4553
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004554 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004555 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004556 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004557 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
4558 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
4559 ") is not 0.",
4560 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004561 }
4562 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004563 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004564 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
4565 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
4566 ") is not 1.",
4567 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004568 }
4569 }
4570
Jeff Bolz9af91c52018-09-01 21:53:57 -05004571 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004572 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004573 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
4574 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
4575 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4576 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004577 }
4578
4579 return skip;
4580}
4581
Jeff Bolz5c801d12019-10-09 10:38:45 -05004582bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
4583 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
4584 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004585 bool skip = false;
4586
Dave Houlton142c4cb2018-10-17 15:04:41 -06004587 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004588 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
4589 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
4590 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05004591 }
4592
4593 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004594 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004595 }
4596
4597 return skip;
4598}
4599
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004600bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004601 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004602 bool skip = false;
4603
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004604 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004605 skip |= LogError(
4606 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004607 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
4608 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004609 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004610 }
4611
4612 return skip;
4613}
4614
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004615bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4616 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004617 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004618 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06004619 static const int condition_multiples = 0b0011;
4620 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004621 skip |= LogError(
4622 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004623 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004624 }
Lockee1c22882019-06-10 16:02:54 -06004625 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004626 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
4627 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
4628 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
4629 stride);
Lockee1c22882019-06-10 16:02:54 -06004630 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004631 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004632 skip |= LogError(
4633 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
4634 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06004635 }
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004636 if (drawCount > device_limits.maxDrawIndirectCount) {
4637 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004638 "vkCmdDrawMeshTasksIndirectNV: drawCount (%u) is not less than or equal to the maximum allowed (%u).",
4639 drawCount, device_limits.maxDrawIndirectCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004640 }
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004641 return skip;
4642}
4643
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004644bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4645 VkDeviceSize offset, VkBuffer countBuffer,
4646 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004647 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004648 bool skip = false;
4649
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004650 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004651 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
4652 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
4653 "), is not a multiple of 4.",
4654 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004655 }
4656
4657 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004658 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
4659 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
4660 "), is not a multiple of 4.",
4661 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004662 }
4663
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004664 return skip;
4665}
4666
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004667bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004668 const VkAllocationCallbacks *pAllocator,
4669 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004670 bool skip = false;
4671
4672 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4673 if (pCreateInfo != nullptr) {
4674 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
4675 // VkQueryPipelineStatisticFlagBits values
4676 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
4677 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004678 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
4679 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
4680 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
4681 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004682 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07004683 if (pCreateInfo->queryCount == 0) {
4684 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
4685 "vkCreateQueryPool(): queryCount must be greater than zero.");
4686 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06004687 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004688 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004689}
4690
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004691bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
4692 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004693 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004694 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
4695 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004696}
4697
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004698void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004699 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4700 VkResult result) {
4701 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004702 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004703}
4704
Mike Schuchardt2df08912020-12-15 16:28:09 -08004705void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004706 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4707 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004708 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004709 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004710 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004711}
4712
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004713void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
4714 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004715 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07004716 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004717 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004718}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004719
Tony-LunarG3c287f62020-12-17 12:39:49 -07004720void StatelessValidation::PostCallRecordAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pAllocateInfo,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004721 VkCommandBuffer *pCommandBuffers, VkResult result) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004722 if ((result == VK_SUCCESS) && pAllocateInfo && (pAllocateInfo->level == VK_COMMAND_BUFFER_LEVEL_SECONDARY)) {
4723 auto lock = cb_write_lock();
4724 for (uint32_t cb_index = 0; cb_index < pAllocateInfo->commandBufferCount; cb_index++) {
Jeremy Gebbenfc6f8152021-03-18 16:58:55 -06004725 secondary_cb_map.emplace(pCommandBuffers[cb_index], pAllocateInfo->commandPool);
Tony-LunarG3c287f62020-12-17 12:39:49 -07004726 }
4727 }
4728}
4729
4730void StatelessValidation::PostCallRecordFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004731 const VkCommandBuffer *pCommandBuffers) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004732 auto lock = cb_write_lock();
4733 for (uint32_t cb_index = 0; cb_index < commandBufferCount; cb_index++) {
4734 secondary_cb_map.erase(pCommandBuffers[cb_index]);
4735 }
4736}
4737
4738void StatelessValidation::PostCallRecordDestroyCommandPool(VkDevice device, VkCommandPool commandPool,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004739 const VkAllocationCallbacks *pAllocator) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004740 auto lock = cb_write_lock();
4741 for (auto item = secondary_cb_map.begin(); item != secondary_cb_map.end();) {
4742 if (item->second == commandPool) {
4743 item = secondary_cb_map.erase(item);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004744 } else {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004745 ++item;
4746 }
4747 }
4748}
4749
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004750bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004751 const VkAllocationCallbacks *pAllocator,
4752 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004753 bool skip = false;
4754
4755 if (pAllocateInfo) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004756 auto chained_prio_struct = LvlFindInChain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004757 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004758 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
4759 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004760 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004761
4762 VkMemoryAllocateFlags flags = 0;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004763 auto flags_info = LvlFindInChain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004764 if (flags_info) {
4765 flags = flags_info->flags;
4766 }
4767
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004768 auto opaque_alloc_info = LvlFindInChain<VkMemoryOpaqueCaptureAddressAllocateInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004769 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08004770 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004771 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
4772 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
Mike Schuchardt2df08912020-12-15 16:28:09 -08004773 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004774 }
4775
4776#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004777 auto import_memory_win32_handle = LvlFindInChain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004778#endif
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004779 auto import_memory_fd = LvlFindInChain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
4780 auto import_memory_host_pointer = LvlFindInChain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004781#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004782 auto import_memory_ahb = LvlFindInChain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004783#endif
4784
4785 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004786 skip |= LogError(
4787 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004788 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
4789 }
4790 if (
4791#ifdef VK_USE_PLATFORM_WIN32_KHR
4792 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
4793#endif
4794 (import_memory_fd && import_memory_fd->handleType) ||
4795#ifdef VK_USE_PLATFORM_ANDROID_KHR
4796 (import_memory_ahb && import_memory_ahb->buffer) ||
4797#endif
4798 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004799 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
4800 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004801 }
4802 }
4803
4804 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004805 VkBool32 capture_replay = false;
4806 VkBool32 buffer_device_address = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004807 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004808 if (vulkan_12_features) {
4809 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
4810 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
4811 } else {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004812 const auto *bda_features = LvlFindInChain<VkPhysicalDeviceBufferDeviceAddressFeatures>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004813 if (bda_features) {
4814 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
4815 buffer_device_address = bda_features->bufferDeviceAddress;
4816 }
4817 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08004818 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004819 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
Mike Schuchardt2df08912020-12-15 16:28:09 -08004820 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT is set, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004821 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004822 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08004823 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004824 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
Mike Schuchardt2df08912020-12-15 16:28:09 -08004825 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004826 }
4827 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004828 }
4829 return skip;
4830}
Ricardo Garciaa4935972019-02-21 17:43:18 +01004831
Jason Macnak192fa0e2019-07-26 15:07:16 -07004832bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004833 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004834 bool skip = false;
4835
4836 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
4837 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
4838 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004839 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004840 } else {
4841 uint32_t vertex_component_size = 0;
4842 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
4843 vertex_component_size = 4;
4844 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
4845 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
4846 vertex_component_size = 2;
4847 }
4848 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004849 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004850 }
4851 }
4852
4853 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
4854 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004855 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004856 } else {
4857 uint32_t index_element_size = 0;
4858 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
4859 index_element_size = 4;
4860 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
4861 index_element_size = 2;
4862 }
4863 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004864 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004865 }
4866 }
4867 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
4868 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004869 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004870 }
4871 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004872 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004873 }
4874 }
4875
4876 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004877 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004878 }
4879
4880 return skip;
4881}
4882
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004883bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
4884 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004885 bool skip = false;
4886
4887 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004888 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004889 }
4890 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004891 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004892 }
4893
4894 return skip;
4895}
4896
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004897bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
4898 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004899 bool skip = false;
4900 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004901 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004902 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004903 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004904 }
4905 return skip;
4906}
4907
4908bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07004909 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004910 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004911 bool skip = false;
4912 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004913 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
4914 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
4915 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004916 }
4917 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004918 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
4919 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
4920 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004921 }
4922 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
4923 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004924 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
4925 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
4926 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07004927 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004928 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004929 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004930 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
4931 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004932 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
4933 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004934 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004935 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004936 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
4937 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
4938 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004939 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004940 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07004941 uint64_t total_triangle_count = 0;
4942 for (uint32_t i = 0; i < info.geometryCount; i++) {
4943 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07004944
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004945 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004946
Jason Macnak5c954952019-07-09 15:46:12 -07004947 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
4948 continue;
4949 }
4950 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
4951 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004952 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004953 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
4954 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
4955 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004956 }
4957 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004958 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
4959 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
4960 for (uint32_t i = 1; i < info.geometryCount; i++) {
4961 const VkGeometryNV &geometry = info.pGeometries[i];
4962 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004963 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004964 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
4965 "info.pGeometries[0].geometryType.",
4966 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07004967 }
4968 }
4969 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004970 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
4971 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
4972 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
4973 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
4974 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
4975 "or VK_GEOMETRY_TYPE_AABBS_NV.");
4976 }
4977 }
4978 skip |=
4979 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06004980 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07004981 return skip;
4982}
4983
Ricardo Garciaa4935972019-02-21 17:43:18 +01004984bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
4985 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004986 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01004987 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01004988 if (pCreateInfo) {
4989 if ((pCreateInfo->compactedSize != 0) &&
4990 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004991 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
4992 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
4993 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
4994 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004995 }
Jason Macnak5c954952019-07-09 15:46:12 -07004996
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004997 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07004998 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004999 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01005000 return skip;
5001}
Mike Schuchardt21638df2019-03-16 10:52:02 -07005002
Jeff Bolz5c801d12019-10-09 10:38:45 -05005003bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
5004 const VkAccelerationStructureInfoNV *pInfo,
5005 VkBuffer instanceData, VkDeviceSize instanceOffset,
5006 VkBool32 update, VkAccelerationStructureNV dst,
5007 VkAccelerationStructureNV src, VkBuffer scratch,
5008 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07005009 bool skip = false;
5010
5011 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005012 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07005013 }
5014
5015 return skip;
5016}
5017
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005018bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
5019 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5020 VkAccelerationStructureKHR *pAccelerationStructure) const {
5021 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005022 const auto *acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005023 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005024 if (!acceleration_structure_features ||
5025 (acceleration_structure_features && acceleration_structure_features->accelerationStructure == VK_FALSE)) {
5026 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-accelerationStructure-03611",
5027 "vkCreateAccelerationStructureKHR(): The accelerationStructure feature must be enabled");
5028 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005029 if (pCreateInfo) {
sourav parmarcd5fb182020-07-17 12:58:44 -07005030 if (pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR &&
5031 (!acceleration_structure_features ||
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005032 (acceleration_structure_features &&
5033 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
sourav parmara96ab1a2020-04-25 16:28:23 -07005034 skip |=
sourav parmarcd5fb182020-07-17 12:58:44 -07005035 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-createFlags-03613",
5036 "vkCreateAccelerationStructureKHR(): If createFlags includes "
5037 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR, "
5038 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay must be VK_TRUE");
sourav parmara96ab1a2020-04-25 16:28:23 -07005039 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005040 if (pCreateInfo->deviceAddress &&
5041 !(pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
5042 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03612",
5043 "vkCreateAccelerationStructureKHR(): If deviceAddress is not zero, createFlags must include "
5044 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR");
5045 }
5046 if (SafeModulo(pCreateInfo->offset, 256) != 0) {
5047 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-offset-03734",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06005048 "vkCreateAccelerationStructureKHR(): offset %" PRIu64 " must be a multiple of 256 bytes", pCreateInfo->offset);
sourav parmarcd5fb182020-07-17 12:58:44 -07005049 }
sourav parmar83c31b12020-05-06 12:30:54 -07005050 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005051 return skip;
5052}
5053
Jason Macnak5c954952019-07-09 15:46:12 -07005054bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
5055 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005056 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07005057 bool skip = false;
5058 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005059 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
5060 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07005061 }
5062 return skip;
5063}
5064
sourav parmarcd5fb182020-07-17 12:58:44 -07005065bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesNV(
5066 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureNV *pAccelerationStructures,
5067 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5068 bool skip = false;
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07005069 if (queryType != VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07005070 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesNV-queryType-03432",
5071 "vkCmdWriteAccelerationStructuresPropertiesNV: queryType must be "
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07005072 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV.");
sourav parmarcd5fb182020-07-17 12:58:44 -07005073 }
5074 return skip;
5075}
5076
Peter Chen85366392019-05-14 15:20:11 -04005077bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
5078 uint32_t createInfoCount,
5079 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
5080 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005081 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04005082 bool skip = false;
5083
5084 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005085 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04005086 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
sourav parmar83c31b12020-05-06 12:30:54 -07005087 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005088 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
5089 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
5090 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
5091 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04005092 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005093
5094 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005095 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07005096 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
5097 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
5098 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
5099 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
5100 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
5101 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
5102 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
5103 }
5104 }
5105
sourav parmarf4a78252020-04-10 13:04:21 -07005106 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
5107 skip |=
5108 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
5109 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
5110 }
5111 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
5112 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
5113 skip |=
5114 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
5115 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
5116 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
5117 }
5118 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
5119 if (pCreateInfos[i].basePipelineIndex != -1) {
5120 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
5121 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
5122 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
5123 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
5124 "and pCreateInfos->basePipelineIndex is not -1.");
5125 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005126 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005127 skip |=
5128 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
5129 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
5130 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
5131 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
5132 "that element.");
5133 }
sourav parmarf4a78252020-04-10 13:04:21 -07005134 }
5135 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04005136 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07005137 skip |=
5138 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
5139 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
5140 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
5141 "commands pCreateInfos parameter.");
5142 }
5143 } else {
5144 if (pCreateInfos[i].basePipelineIndex != -1) {
5145 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
5146 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
5147 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
5148 }
5149 }
5150 }
5151 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
5152 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
5153 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
5154 }
5155 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
5156 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
5157 "vkCreateRayTracingPipelinesNV: flags must not include "
5158 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
5159 }
5160 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
5161 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
5162 "vkCreateRayTracingPipelinesNV: flags must not include "
5163 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
5164 }
5165 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
5166 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
5167 "vkCreateRayTracingPipelinesNV: flags must not include "
5168 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
5169 }
5170 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
5171 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
5172 "vkCreateRayTracingPipelinesNV: flags must not include "
5173 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
5174 }
5175 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
5176 skip |= LogError(
5177 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
5178 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
5179 }
5180 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
5181 skip |= LogError(
5182 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
5183 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
5184 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005185 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) {
5186 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03588",
5187 "vkCreateRayTracingPipelinesNV: flags must not include "
5188 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
5189 }
5190 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
5191 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03816",
5192 "vkCreateRayTracingPipelinesNV: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
5193 }
Peter Chen85366392019-05-14 15:20:11 -04005194 }
5195
5196 return skip;
5197}
5198
sourav parmarcd5fb182020-07-17 12:58:44 -07005199bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(
5200 VkDevice device, VkDeferredOperationKHR deferredOperation, VkPipelineCache pipelineCache, uint32_t createInfoCount,
5201 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos, const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) const {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005202 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005203 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005204 if (!raytracing_features || raytracing_features->rayTracingPipeline == VK_FALSE) {
5205 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracingPipeline-03586",
5206 "vkCreateRayTracingPipelinesKHR: The rayTracingPipeline feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005207 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005208 for (uint32_t i = 0; i < createInfoCount; i++) {
sourav parmarcd5fb182020-07-17 12:58:44 -07005209 if (!raytracing_features || (raytracing_features && raytracing_features->rayTraversalPrimitiveCulling == VK_FALSE)) {
5210 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
5211 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03596",
5212 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
5213 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
5214 }
5215 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
5216 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03597",
5217 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
5218 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.");
5219 }
5220 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005221 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005222 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
5223 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
sourav parmarcd5fb182020-07-17 12:58:44 -07005224 "vkCreateRayTracingPipelinesKHR: in pCreateInfo[%" PRIu32
5225 "], When chained to VkRayTracingPipelineCreateInfoKHR, "
5226 "VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005227 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
5228 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
5229 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005230 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005231 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07005232 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
5233 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
5234 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
5235 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
sourav parmarcd5fb182020-07-17 12:58:44 -07005236 "vkCreateRayTracingPipelinesKHR: If the pipelineCreationCacheControl feature is not enabled,"
sourav parmara96ab1a2020-04-25 16:28:23 -07005237 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
5238 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
5239 }
5240 }
sourav parmarf4a78252020-04-10 13:04:21 -07005241 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07005242 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
5243 "vkCreateRayTracingPipelinesKHR: flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
sourav parmarf4a78252020-04-10 13:04:21 -07005244 }
5245 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005246 if (pCreateInfos[i].pLibraryInterface == NULL) {
sourav parmarf4a78252020-04-10 13:04:21 -07005247 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
sourav parmarcd5fb182020-07-17 12:58:44 -07005248 "vkCreateRayTracingPipelinesKHR: If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, "
5249 "pLibraryInterface must not be NULL.");
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005250 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005251 }
5252 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
5253 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03816",
5254 "vkCreateRayTracingPipelinesKHR: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
sourav parmarf4a78252020-04-10 13:04:21 -07005255 }
5256 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
5257 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
5258 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
5259 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
5260 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
5261 skip |= LogError(
5262 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
sourav parmarcd5fb182020-07-17 12:58:44 -07005263 "vkCreateRayTracingPipelinesKHR: If flags includes "
5264 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07005265 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
5266 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
5267 "must not be VK_SHADER_UNUSED_KHR");
5268 }
5269 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
5270 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
5271 skip |= LogError(
5272 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
sourav parmarcd5fb182020-07-17 12:58:44 -07005273 "vkCreateRayTracingPipelinesKHR: If flags includes "
5274 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07005275 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
5276 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
5277 "element must not be VK_SHADER_UNUSED_KHR");
5278 }
5279 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005280 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_TRUE &&
5281 pCreateInfos[i].pGroups[group_index].pShaderGroupCaptureReplayHandle) {
5282 if (!(pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR)) {
5283 skip |= LogError(
5284 device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03599",
5285 "vkCreateRayTracingPipelinesKHR: If "
5286 "VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineShaderGroupHandleCaptureReplay is "
5287 "VK_TRUE and the pShaderGroupCaptureReplayHandle member of any element of pGroups is not NULL, flags must "
5288 "include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
5289 }
5290 }
sourav parmarf4a78252020-04-10 13:04:21 -07005291 }
5292 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
5293 if (pCreateInfos[i].basePipelineIndex != -1) {
5294 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
5295 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
sourav parmarcd5fb182020-07-17 12:58:44 -07005296 "vkCreateRayTracingPipelinesKHR: parameter, pCreateInfos->basePipelineHandle, must be "
sourav parmarf4a78252020-04-10 13:04:21 -07005297 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
5298 "and pCreateInfos->basePipelineIndex is not -1.");
5299 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005300 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005301 skip |=
5302 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
5303 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
5304 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
5305 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
5306 "element.");
5307 }
sourav parmarf4a78252020-04-10 13:04:21 -07005308 }
5309 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04005310 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07005311 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
sourav parmarcd5fb182020-07-17 12:58:44 -07005312 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07005313 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%d) must be a valid into the calling"
5314 "commands pCreateInfos parameter %d.",
5315 pCreateInfos[i].basePipelineIndex, createInfoCount);
5316 }
5317 } else {
5318 if (pCreateInfos[i].basePipelineIndex != -1) {
5319 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
sourav parmarcd5fb182020-07-17 12:58:44 -07005320 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07005321 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
5322 }
5323 }
5324 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005325 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR &&
5326 (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE)) {
5327 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03598",
5328 "vkCreateRayTracingPipelinesKHR: If flags includes "
5329 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR, "
5330 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled.");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005331 }
5332 bool library_enabled = IsExtEnabled(device_extensions.vk_khr_pipeline_library);
5333 if (!library_enabled && (pCreateInfos[i].pLibraryInfo || pCreateInfos[i].pLibraryInterface)) {
5334 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03595",
5335 "vkCreateRayTracingPipelinesKHR: If the VK_KHR_pipeline_library extension is not enabled, "
5336 "pLibraryInfo and pLibraryInterface must be NULL.");
5337 }
5338 if (pCreateInfos[i].pLibraryInfo) {
5339 if (pCreateInfos[i].pLibraryInfo->libraryCount == 0) {
5340 if (pCreateInfos[i].stageCount == 0) {
5341 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03600",
5342 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
5343 "stageCount must not be 0.");
5344 }
5345 if (pCreateInfos[i].groupCount == 0) {
5346 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03601",
5347 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
5348 "groupCount must not be 0.");
5349 }
5350 } else {
5351 if (pCreateInfos[i].pLibraryInterface == NULL) {
5352 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03590",
5353 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount member "
5354 "is greater than 0, its "
5355 "pLibraryInterface member must not be NULL.");
sourav parmarcd5fb182020-07-17 12:58:44 -07005356 }
5357 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005358 }
5359 if (pCreateInfos[i].pLibraryInterface) {
5360 if (pCreateInfos[i].pLibraryInterface->maxPipelineRayHitAttributeSize >
5361 phys_dev_ext_props.ray_tracing_propsKHR.maxRayHitAttributeSize) {
5362 skip |= LogError(device, "VUID-VkRayTracingPipelineInterfaceCreateInfoKHR-maxPipelineRayHitAttributeSize-03605",
5363 "vkCreateRayTracingPipelinesKHR: maxPipelineRayHitAttributeSize must be less than or equal to "
5364 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayHitAttributeSize.");
5365 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005366 }
5367 if (deferredOperation != VK_NULL_HANDLE) {
5368 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT) {
5369 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-deferredOperation-03587",
5370 "vkCreateRayTracingPipelinesKHR: If deferredOperation is not VK_NULL_HANDLE, the flags member of "
5371 "elements of pCreateInfos must not include VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
sourav parmarf4a78252020-04-10 13:04:21 -07005372 }
5373 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005374 }
5375
5376 return skip;
5377}
5378
Mike Schuchardt21638df2019-03-16 10:52:02 -07005379#ifdef VK_USE_PLATFORM_WIN32_KHR
5380bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
5381 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005382 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07005383 bool skip = false;
5384 if (!device_extensions.vk_khr_swapchain)
5385 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
5386 if (!device_extensions.vk_khr_get_surface_capabilities_2)
5387 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
5388 if (!device_extensions.vk_khr_surface)
5389 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
5390 if (!device_extensions.vk_khr_get_physical_device_properties_2)
5391 skip |=
5392 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
5393 if (!device_extensions.vk_ext_full_screen_exclusive)
5394 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
5395 skip |= validate_struct_type(
5396 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
5397 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
5398 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
5399 if (pSurfaceInfo != NULL) {
5400 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
5401 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
5402 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
5403
5404 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
5405 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
5406 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
5407 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08005408 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
5409 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07005410
5411 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
5412 }
5413 return skip;
5414}
5415#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01005416
5417bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
5418 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005419 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01005420 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
5421 bool skip = false;
Mike Schuchardt2df08912020-12-15 16:28:09 -08005422 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT) == 0) {
Tobias Hectorebb855f2019-07-23 12:17:33 +01005423 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
5424 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
5425 }
5426 return skip;
5427}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005428
5429bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005430 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005431 bool skip = false;
5432
5433 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005434 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
5435 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005436 }
5437
5438 return skip;
5439}
Piers Daniell8fd03f52019-08-21 12:07:53 -06005440
5441bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005442 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06005443 bool skip = false;
5444
5445 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005446 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
5447 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06005448 }
5449
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005450 const auto *index_type_uint8_features = LvlFindInChain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06005451 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005452 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
5453 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06005454 }
5455
5456 return skip;
5457}
Mark Lobodzinski84988402019-09-11 15:27:30 -06005458
sfricke-samsung4ada8d42020-02-09 17:43:11 -08005459bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
5460 uint32_t bindingCount, const VkBuffer *pBuffers,
5461 const VkDeviceSize *pOffsets) const {
5462 bool skip = false;
5463 if (firstBinding > device_limits.maxVertexInputBindings) {
5464 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
5465 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
5466 device_limits.maxVertexInputBindings);
5467 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
5468 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
5469 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
5470 "maxVertexInputBindings (%u)",
5471 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
5472 }
5473
Jeff Bolz165818a2020-05-08 11:19:03 -05005474 for (uint32_t i = 0; i < bindingCount; ++i) {
5475 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005476 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05005477 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
5478 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
5479 "vkCmdBindVertexBuffers() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
5480 } else {
5481 if (pOffsets[i] != 0) {
5482 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
5483 "vkCmdBindVertexBuffers() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
5484 }
5485 }
5486 }
5487 }
5488
sfricke-samsung4ada8d42020-02-09 17:43:11 -08005489 return skip;
5490}
5491
Mark Lobodzinski84988402019-09-11 15:27:30 -06005492bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005493 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06005494 bool skip = false;
5495 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005496 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
5497 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06005498 }
5499 return skip;
5500}
5501
5502bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005503 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06005504 bool skip = false;
5505 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005506 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
5507 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06005508 }
5509 return skip;
5510}
Petr Kraus3d720392019-11-13 02:52:39 +01005511
5512bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
5513 VkSemaphore semaphore, VkFence fence,
5514 uint32_t *pImageIndex) const {
5515 bool skip = false;
5516
5517 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005518 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
5519 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005520 }
5521
5522 return skip;
5523}
5524
5525bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
5526 uint32_t *pImageIndex) const {
5527 bool skip = false;
5528
5529 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005530 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
5531 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005532 }
5533
5534 return skip;
5535}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005536
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005537bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
5538 uint32_t firstBinding, uint32_t bindingCount,
5539 const VkBuffer *pBuffers,
5540 const VkDeviceSize *pOffsets,
5541 const VkDeviceSize *pSizes) const {
5542 bool skip = false;
5543
5544 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
5545 for (uint32_t i = 0; i < bindingCount; ++i) {
5546 if (pOffsets[i] & 3) {
5547 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
5548 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
5549 }
5550 }
5551
5552 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5553 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
5554 "%s: The firstBinding(%" PRIu32
5555 ") index is greater than or equal to "
5556 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5557 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5558 }
5559
5560 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5561 skip |=
5562 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
5563 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
5564 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5565 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5566 }
5567
5568 for (uint32_t i = 0; i < bindingCount; ++i) {
5569 // pSizes is optional and may be nullptr.
5570 if (pSizes != nullptr) {
5571 if (pSizes[i] != VK_WHOLE_SIZE &&
5572 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
5573 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
5574 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
5575 ") is not VK_WHOLE_SIZE and is greater than "
5576 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
5577 cmd_name, i, pSizes[i]);
5578 }
5579 }
5580 }
5581
5582 return skip;
5583}
5584
5585bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5586 uint32_t firstCounterBuffer,
5587 uint32_t counterBufferCount,
5588 const VkBuffer *pCounterBuffers,
5589 const VkDeviceSize *pCounterBufferOffsets) const {
5590 bool skip = false;
5591
5592 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
5593 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5594 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
5595 "%s: The firstCounterBuffer(%" PRIu32
5596 ") index is greater than or equal to "
5597 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5598 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5599 }
5600
5601 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5602 skip |=
5603 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
5604 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5605 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5606 cmd_name, firstCounterBuffer, counterBufferCount,
5607 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5608 }
5609
5610 return skip;
5611}
5612
5613bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5614 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
5615 const VkBuffer *pCounterBuffers,
5616 const VkDeviceSize *pCounterBufferOffsets) const {
5617 bool skip = false;
5618
5619 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
5620 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5621 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
5622 "%s: The firstCounterBuffer(%" PRIu32
5623 ") index is greater than or equal to "
5624 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5625 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5626 }
5627
5628 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5629 skip |=
5630 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
5631 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5632 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5633 cmd_name, firstCounterBuffer, counterBufferCount,
5634 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5635 }
5636
5637 return skip;
5638}
5639
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005640bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
5641 uint32_t firstInstance, VkBuffer counterBuffer,
5642 VkDeviceSize counterBufferOffset,
5643 uint32_t counterOffset, uint32_t vertexStride) const {
5644 bool skip = false;
5645
5646 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005647 skip |= LogError(
5648 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005649 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
5650 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
5651 }
5652
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005653 if ((counterOffset % 4) != 0) {
sfricke-samsung6886c4b2021-01-16 08:37:35 -08005654 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-counterBufferOffset-04568",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06005655 "vkCmdDrawIndirectByteCountEXT(): offset (%" PRIu32 ") must be a multiple of 4.", counterOffset);
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005656 }
5657
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005658 return skip;
5659}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005660
5661bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
5662 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5663 const VkAllocationCallbacks *pAllocator,
5664 VkSamplerYcbcrConversion *pYcbcrConversion,
5665 const char *apiName) const {
5666 bool skip = false;
5667
5668 // Check samplerYcbcrConversion feature is set
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005669 const auto *ycbcr_features = LvlFindInChain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005670 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005671 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005672 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
5673 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07005674 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005675 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005676 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005677
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005678#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005679 const VkExternalFormatANDROID *external_format_android = LvlFindInChain<VkExternalFormatANDROID>(pCreateInfo);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005680 const bool is_external_format = external_format_android != nullptr && external_format_android->externalFormat != 0;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005681#else
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005682 const bool is_external_format = false;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005683#endif
5684
sfricke-samsung1a72f942020-07-25 12:09:18 -07005685 const VkFormat format = pCreateInfo->format;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005686
5687 // If there is a VkExternalFormatANDROID with externalFormat != 0, the value of components is ignored.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005688 if (!is_external_format) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005689 const VkComponentMapping components = pCreateInfo->components;
5690 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
5691 if (FormatIsXChromaSubsampled(format) == true) {
5692 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
5693 skip |=
5694 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
sfricke-samsung83d98122020-07-04 06:21:15 -07005695 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
5696 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005697 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005698 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005699
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005700 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5701 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
5702 skip |= LogError(
5703 device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
5704 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
5705 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
5706 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
5707 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005708
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005709 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5710 (components.r != VK_COMPONENT_SWIZZLE_B)) {
5711 skip |=
5712 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
sfricke-samsung83d98122020-07-04 06:21:15 -07005713 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
5714 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005715 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005716 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005717
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005718 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5719 (components.b != VK_COMPONENT_SWIZZLE_R)) {
5720 skip |=
5721 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
sfricke-samsung83d98122020-07-04 06:21:15 -07005722 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
5723 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005724 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005725 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005726
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005727 // If one is identity, both need to be
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005728 const bool r_identity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
5729 const bool b_identity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
5730 if ((r_identity != b_identity) && ((r_identity == true) || (b_identity == true))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005731 skip |=
5732 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
sfricke-samsung83d98122020-07-04 06:21:15 -07005733 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
5734 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005735 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
5736 string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005737 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005738 }
5739
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005740 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
5741 // Checks same VU multiple ways in order to give a more useful error message
5742 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
5743 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
5744 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
5745 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
5746 skip |= LogError(
5747 device, vuid,
5748 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5749 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
5750 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5751 string_VkComponentSwizzle(components.b));
5752 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005753
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005754 // "must not correspond to a channel which contains zero or one as a consequence of conversion to RGBA"
5755 // 4 channel format = no issue
5756 // 3 = no [a]
5757 // 2 = no [b,a]
5758 // 1 = no [g,b,a]
5759 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
5760 const uint32_t channels = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatChannelCount(format);
5761
5762 if ((channels < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
5763 (components.b == VK_COMPONENT_SWIZZLE_A))) {
5764 skip |= LogError(device, vuid,
5765 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5766 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
5767 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5768 string_VkComponentSwizzle(components.b));
5769 } else if ((channels < 3) &&
5770 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
5771 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
5772 skip |= LogError(device, vuid,
5773 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5774 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
5775 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5776 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5777 string_VkComponentSwizzle(components.b));
5778 } else if ((channels < 2) &&
5779 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
5780 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
5781 skip |= LogError(device, vuid,
5782 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5783 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
5784 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5785 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5786 string_VkComponentSwizzle(components.b));
5787 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005788 }
5789 }
5790
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005791 return skip;
5792}
5793
5794bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
5795 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5796 const VkAllocationCallbacks *pAllocator,
5797 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5798 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5799 "vkCreateSamplerYcbcrConversion");
5800}
5801
5802bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
5803 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5804 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5805 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5806 "vkCreateSamplerYcbcrConversionKHR");
5807}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005808
5809bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
5810 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
5811 bool skip = false;
5812 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
5813 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
5814
5815 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005816 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
5817 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
5818 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
5819 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
5820 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005821 }
5822 return skip;
5823}
sourav parmara96ab1a2020-04-25 16:28:23 -07005824
5825bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005826 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005827 bool skip = false;
5828 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5829 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5830 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5831 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005832 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005833 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5834 skip |= LogError(
5835 device, "VUID-vkCopyAccelerationStructureToMemoryKHR-accelerationStructureHostCommands-03584",
5836 "vkCopyAccelerationStructureToMemoryKHR: The "
5837 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5838 }
5839 skip |= validate_required_pointer("vkCopyAccelerationStructureToMemoryKHR", "pInfo->dst.hostAddress", pInfo->dst.hostAddress,
5840 "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03732");
5841 if (SafeModulo((VkDeviceSize)pInfo->dst.hostAddress, 16) != 0) {
5842 skip |= LogError(device, "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03751",
5843 "vkCopyAccelerationStructureToMemoryKHR(): pInfo->dst.hostAddress must be aligned to 16 bytes.");
5844 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005845 return skip;
5846}
5847
5848bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
5849 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5850 bool skip = false;
5851 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5852 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
5853 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5854 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5855 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005856 if (SafeModulo(pInfo->dst.deviceAddress, 256) != 0) {
5857 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pInfo-03740",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06005858 "vkCmdCopyAccelerationStructureToMemoryKHR(): pInfo->dst.deviceAddress (0x%" PRIx64 ") must be aligned to 256 bytes.",
sourav parmarcd5fb182020-07-17 12:58:44 -07005859 pInfo->dst.deviceAddress);
sourav parmar83c31b12020-05-06 12:30:54 -07005860 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005861 return skip;
5862}
5863
5864bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
5865 const char *api_name) const {
5866 bool skip = false;
5867 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
5868 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
5869 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
5870 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
5871 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
5872 api_name);
5873 }
5874 return skip;
5875}
5876
5877bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005878 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005879 bool skip = false;
5880 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005881 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005882 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
sourav parmar83c31b12020-05-06 12:30:54 -07005883 skip |= LogError(
sourav parmarcd5fb182020-07-17 12:58:44 -07005884 device, "VUID-vkCopyAccelerationStructureKHR-accelerationStructureHostCommands-03582",
5885 "vkCopyAccelerationStructureKHR: The "
5886 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005887 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005888 return skip;
5889}
5890
5891bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
5892 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5893 bool skip = false;
5894 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
5895 return skip;
5896}
5897
5898bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005899 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005900 bool skip = false;
5901 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005902 skip |= LogError(device, "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07005903 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
5904 }
5905 return skip;
5906}
5907
5908bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005909 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005910 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005911 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005912 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005913 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5914 skip |= LogError(
5915 device, "VUID-vkCopyMemoryToAccelerationStructureKHR-accelerationStructureHostCommands-03583",
5916 "vkCopyMemoryToAccelerationStructureKHR: The "
5917 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005918 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005919 skip |= validate_required_pointer("vkCopyMemoryToAccelerationStructureKHR", "pInfo->src.hostAddress", pInfo->src.hostAddress,
5920 "VUID-vkCopyMemoryToAccelerationStructureKHR-pInfo-03729");
sourav parmara96ab1a2020-04-25 16:28:23 -07005921 return skip;
5922}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005923
sourav parmara96ab1a2020-04-25 16:28:23 -07005924bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
5925 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5926 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005927 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
sourav parmarcd5fb182020-07-17 12:58:44 -07005928 if (SafeModulo(pInfo->src.deviceAddress, 256) != 0) {
5929 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pInfo-03743",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06005930 "vkCmdCopyMemoryToAccelerationStructureKHR(): pInfo->src.deviceAddress (0x%" PRIx64 ") must be aligned to 256 bytes.",
sourav parmarcd5fb182020-07-17 12:58:44 -07005931 pInfo->src.deviceAddress);
5932 }
sourav parmar83c31b12020-05-06 12:30:54 -07005933 return skip;
5934}
5935bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
5936 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5937 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5938 bool skip = false;
5939 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5940 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5941 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5942 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
5943 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5944 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5945 }
5946 return skip;
5947}
5948bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
5949 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5950 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
5951 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005952 const auto *acc_structure_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005953 if (!acc_structure_features || acc_structure_features->accelerationStructureHostCommands == VK_FALSE) {
5954 skip |= LogError(
5955 device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-accelerationStructureHostCommands-03585",
5956 "vkCmdWriteAccelerationStructuresPropertiesKHR: The "
5957 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5958 }
sourav parmar83c31b12020-05-06 12:30:54 -07005959 if (dataSize < accelerationStructureCount * stride) {
5960 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
5961 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
5962 "accelerationStructureCount (%d) *stride(%zu).",
5963 dataSize, accelerationStructureCount, stride);
5964 }
5965 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5966 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5967 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5968 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
5969 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5970 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5971 }
5972 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
5973 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5974 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
5975 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5976 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
5977 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5978 stride);
5979 }
5980 }
5981 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
5982 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5983 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
5984 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5985 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
5986 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5987 stride);
5988 }
5989 }
sourav parmar83c31b12020-05-06 12:30:54 -07005990 return skip;
5991}
5992bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
5993 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
5994 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005995 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005996 if (!raytracing_features || raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE) {
5997 skip |= LogError(
5998 device, "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03606",
5999 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR:VkPhysicalDeviceRayTracingPipelineFeaturesKHR::"
6000 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled to call this function.");
sourav parmar83c31b12020-05-06 12:30:54 -07006001 }
6002 return skip;
6003}
6004
6005bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
sourav parmarcd5fb182020-07-17 12:58:44 -07006006 const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
6007 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable,
6008 const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
6009 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable,
sourav parmar83c31b12020-05-06 12:30:54 -07006010 uint32_t width, uint32_t height, uint32_t depth) const {
6011 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07006012 // RayGen
6013 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
6014 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-size-04023",
6015 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07006016 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006017 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
6018 0) {
6019 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03682",
6020 "vkCmdTraceRaysKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
6021 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
6022 }
6023 // Callable
6024 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
6025 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03694",
6026 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
6027 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006028 }
6029 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
6030 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
6031 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07006032 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
6033 }
6034 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
6035 0) {
6036 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03693",
6037 "vkCmdTraceRaysKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
6038 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006039 }
6040 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07006041 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
6042 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03690",
6043 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple of "
6044 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006045 }
6046 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
6047 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07006048 "vkCmdTraceRaysKHR: TThe stride member of pHitShaderBindingTable must be less than or equal to "
6049 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride");
sourav parmar83c31b12020-05-06 12:30:54 -07006050 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006051 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
6052 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03689",
6053 "vkCmdTraceRaysKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
6054 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
6055 }
sourav parmar83c31b12020-05-06 12:30:54 -07006056 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07006057 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
6058 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03686",
6059 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple of "
6060 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment");
sourav parmar83c31b12020-05-06 12:30:54 -07006061 }
6062 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
6063 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
6064 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07006065 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
6066 }
6067 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
6068 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03685",
6069 "vkCmdTraceRaysKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
6070 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
6071 }
6072 if (width * depth * height > phys_dev_ext_props.ray_tracing_propsKHR.maxRayDispatchInvocationCount) {
6073 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-width-03629",
6074 "vkCmdTraceRaysKHR: width {times} height {times} depth must be less than or equal to "
6075 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayDispatchInvocationCount");
6076 }
6077 if (width > device_limits.maxComputeWorkGroupCount[0] * device_limits.maxComputeWorkGroupSize[0]) {
6078 skip |=
6079 LogError(device, "VUID-vkCmdTraceRaysKHR-width-03626",
6080 "vkCmdTraceRaysKHR: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[0] "
6081 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[0]");
sourav parmar83c31b12020-05-06 12:30:54 -07006082 }
6083
sourav parmarcd5fb182020-07-17 12:58:44 -07006084 if (height > device_limits.maxComputeWorkGroupCount[1] * device_limits.maxComputeWorkGroupSize[1]) {
6085 skip |=
6086 LogError(device, "VUID-vkCmdTraceRaysKHR-height-03627",
6087 "vkCmdTraceRaysKHR: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1] "
6088 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[1]");
6089 }
6090
6091 if (depth > device_limits.maxComputeWorkGroupCount[2] * device_limits.maxComputeWorkGroupSize[2]) {
6092 skip |=
6093 LogError(device, "VUID-vkCmdTraceRaysKHR-depth-03628",
6094 "vkCmdTraceRaysKHR: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2] "
6095 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[2]");
sourav parmar83c31b12020-05-06 12:30:54 -07006096 }
6097 return skip;
6098}
6099
sourav parmarcd5fb182020-07-17 12:58:44 -07006100bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(
6101 VkCommandBuffer commandBuffer, const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
6102 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable, const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
6103 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable, VkDeviceAddress indirectDeviceAddress) const {
sourav parmar83c31b12020-05-06 12:30:54 -07006104 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006105 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006106 if (!raytracing_features || raytracing_features->rayTracingPipelineTraceRaysIndirect == VK_FALSE) {
6107 skip |= LogError(
6108 device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingPipelineTraceRaysIndirect-03637",
6109 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineTraceRaysIndirect "
6110 "feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006111 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006112 // RayGen
6113 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
6114 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-size-04023",
6115 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07006116 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006117 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
6118 0) {
6119 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03682",
6120 "vkCmdTraceRaysIndirectKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
6121 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
6122 }
6123 // Callabe
6124 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
6125 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03694",
6126 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
6127 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006128 }
6129 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
6130 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
sourav parmarcd5fb182020-07-17 12:58:44 -07006131 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be less than or equal "
6132 "to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
6133 }
6134 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
6135 0) {
6136 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03693",
6137 "vkCmdTraceRaysIndirectKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
6138 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006139 }
6140 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07006141 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
6142 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03690",
6143 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple of "
6144 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006145 }
6146 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
6147 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07006148 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be less than or equal to "
6149 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
sourav parmar83c31b12020-05-06 12:30:54 -07006150 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006151 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
6152 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03689",
6153 "vkCmdTraceRaysIndirectKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
6154 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
6155 }
sourav parmar83c31b12020-05-06 12:30:54 -07006156 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07006157 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
6158 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03686",
6159 "vkCmdTraceRaysIndirectKHR:The stride member of pMissShaderBindingTable must be a multiple of "
6160 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006161 }
6162 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
6163 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
sourav parmarcd5fb182020-07-17 12:58:44 -07006164 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be less than or equal to "
6165 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
6166 }
6167 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
6168 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03685",
6169 "vkCmdTraceRaysIndirectKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
6170 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07006171 }
6172
sourav parmarcd5fb182020-07-17 12:58:44 -07006173 if (SafeModulo(indirectDeviceAddress, 4) != 0) {
6174 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-indirectDeviceAddress-03634",
6175 "vkCmdTraceRaysIndirectKHR: indirectDeviceAddress must be a multiple of 4.");
sourav parmar83c31b12020-05-06 12:30:54 -07006176 }
6177 return skip;
6178}
6179bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
6180 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
6181 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
6182 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
6183 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
6184 uint32_t width, uint32_t height, uint32_t depth) const {
6185 bool skip = false;
6186 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
6187 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
6188 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
6189 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
6190 }
6191 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
6192 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
6193 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
6194 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
6195 }
6196 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
6197 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
6198 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
6199 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
6200 }
6201
6202 // hitShader
6203 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
6204 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
6205 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
6206 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
6207 }
6208 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
6209 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
6210 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
6211 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
6212 }
6213 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
6214 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
6215 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
6216 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
6217 }
6218
6219 // missShader
6220 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
6221 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
6222 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
6223 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
6224 }
6225 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
6226 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
6227 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
6228 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
6229 }
6230 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
6231 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
6232 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
6233 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
6234 }
6235
6236 // raygenShader
6237 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
6238 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
6239 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07006240 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
6241 }
6242 if (width > device_limits.maxComputeWorkGroupCount[0]) {
6243 skip |=
6244 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
6245 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
6246 }
6247 if (height > device_limits.maxComputeWorkGroupCount[1]) {
6248 skip |=
6249 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
6250 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
6251 }
6252 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
6253 skip |=
6254 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
6255 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07006256 }
6257 return skip;
6258}
6259
sourav parmar83c31b12020-05-06 12:30:54 -07006260bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006261 VkDevice device, const VkAccelerationStructureVersionInfoKHR *pVersionInfo,
6262 VkAccelerationStructureCompatibilityKHR *pCompatibility) const {
sourav parmar83c31b12020-05-06 12:30:54 -07006263 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006264 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
6265 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006266 if ((!raytracing_features && !ray_query_features) || ((ray_query_features && !(ray_query_features->rayQuery)) ||
6267 (raytracing_features && !raytracing_features->rayTracingPipeline))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006268 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracingPipeline-03661",
sourav parmar83c31b12020-05-06 12:30:54 -07006269 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
6270 }
6271 return skip;
6272}
6273
Piers Daniell39842ee2020-07-10 16:42:33 -06006274bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
6275 const VkViewport *pViewports) const {
6276 bool skip = false;
6277
6278 if (!physical_device_features.multiViewport) {
6279 if (viewportCount != 1) {
6280 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03395",
6281 "vkCmdSetViewportWithCountEXT: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
6282 ") is not 1.",
6283 viewportCount);
6284 }
6285 } else { // multiViewport enabled
6286 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
6287 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03394",
6288 "vkCmdSetViewportWithCountEXT: viewportCount (=%" PRIu32
6289 ") must "
6290 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
6291 viewportCount, device_limits.maxViewports);
6292 }
6293 }
6294
6295 if (pViewports) {
6296 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
6297 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
6298 const char *fn_name = "vkCmdSetViewportWithCountEXT";
6299 skip |= manual_PreCallValidateViewport(
6300 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
6301 }
6302 }
6303
6304 return skip;
6305}
6306
6307bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
6308 const VkRect2D *pScissors) const {
6309 bool skip = false;
6310
6311 if (!physical_device_features.multiViewport) {
6312 if (scissorCount != 1) {
6313 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03398",
6314 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
6315 ") must "
6316 "be 1 when the multiViewport feature is disabled.",
6317 scissorCount);
6318 }
6319 } else { // multiViewport enabled
6320 if (scissorCount == 0) {
6321 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
6322 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
6323 ") must "
6324 "be great than zero.",
6325 scissorCount);
6326 } else if (scissorCount > device_limits.maxViewports) {
6327 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
6328 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
6329 ") must "
6330 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
6331 scissorCount, device_limits.maxViewports);
6332 }
6333 }
6334
6335 if (pScissors) {
6336 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
6337 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
6338
6339 if (scissor.offset.x < 0) {
6340 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
6341 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
6342 scissor.offset.x);
6343 }
6344
6345 if (scissor.offset.y < 0) {
6346 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
6347 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
6348 scissor.offset.y);
6349 }
6350
6351 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
6352 if (x_sum > INT32_MAX) {
6353 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03400",
6354 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
6355 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
6356 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
6357 }
6358
6359 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
6360 if (y_sum > INT32_MAX) {
6361 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03401",
6362 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
6363 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
6364 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
6365 }
6366 }
6367 }
6368
6369 return skip;
6370}
6371
6372bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
6373 uint32_t bindingCount, const VkBuffer *pBuffers,
6374 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
6375 const VkDeviceSize *pStrides) const {
6376 bool skip = false;
6377 if (firstBinding >= device_limits.maxVertexInputBindings) {
6378 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03355",
6379 "vkCmdBindVertexBuffers2EXT() firstBinding (%u) must be less than maxVertexInputBindings (%u)",
6380 firstBinding, device_limits.maxVertexInputBindings);
6381 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
6382 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03356",
6383 "vkCmdBindVertexBuffers2EXT() sum of firstBinding (%u) and bindingCount (%u) must be less than "
6384 "maxVertexInputBindings (%u)",
6385 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
6386 }
6387
6388 for (uint32_t i = 0; i < bindingCount; ++i) {
6389 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006390 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Piers Daniell39842ee2020-07-10 16:42:33 -06006391 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
6392 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04111",
6393 "vkCmdBindVertexBuffers2EXT() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
6394 } else {
6395 if (pOffsets[i] != 0) {
6396 skip |=
6397 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04112",
6398 "vkCmdBindVertexBuffers2EXT() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
6399 }
6400 }
6401 }
6402 if (pStrides) {
6403 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
6404 skip |=
6405 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pStrides-03362",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006406 "vkCmdBindVertexBuffers2EXT() pStrides[%d] (%" PRIu64 ") must be less than maxVertexInputBindingStride (%u)", i,
Piers Daniell39842ee2020-07-10 16:42:33 -06006407 pStrides[i], device_limits.maxVertexInputBindingStride);
6408 }
6409 }
6410 }
6411
6412 return skip;
6413}
sourav parmarcd5fb182020-07-17 12:58:44 -07006414
6415bool StatelessValidation::ValidateAccelerationStructureBuildGeometryInfoKHR(
6416 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos, uint32_t infoCount, const char *api_name) const {
6417 bool skip = false;
6418 for (uint32_t i = 0; i < infoCount; ++i) {
6419 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
6420 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03654",
6421 "(%s): type must not be VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.", api_name);
6422 }
6423 if (pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
6424 pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
6425 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-flags-03796",
6426 "(%s): If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR bit set,"
6427 "then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.",
6428 api_name);
6429 }
6430 if (pInfos[i].pGeometries && pInfos[i].ppGeometries) {
6431 skip |=
6432 LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-pGeometries-03788",
6433 "(%s): Only one of pGeometries or ppGeometries can be a valid pointer, the other must be NULL", api_name);
6434 }
6435 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pInfos[i].geometryCount != 1) {
6436 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03790",
6437 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, geometryCount must be 1", api_name);
6438 }
6439 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
6440 pInfos[i].geometryCount > phys_dev_ext_props.acc_structure_props.maxGeometryCount) {
6441 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03793",
6442 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then geometryCount must be"
6443 " less than or equal to VkPhysicalDeviceAccelerationStructurePropertiesKHR::maxGeometryCount",
6444 api_name);
6445 }
6446 if (pInfos[i].pGeometries) {
6447 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6448 skip |= validate_ranged_enum(
6449 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometryType", ParameterName::IndexVector{i, j}),
6450 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].pGeometries[j].geometryType,
6451 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
6452 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006453 skip |= validate_struct_type(
6454 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles", ParameterName::IndexVector{i, j}),
6455 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6456 &(pInfos[i].pGeometries[j].geometry.triangles),
6457 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
6458 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
6459 skip |= validate_struct_pnext(
6460 api_name,
6461 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
6462 NULL, pInfos[i].pGeometries[j].geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6463 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
6464 skip |=
6465 validate_ranged_enum(api_name,
6466 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.vertexFormat",
6467 ParameterName::IndexVector{i, j}),
6468 "VkFormat", AllVkFormatEnums, pInfos[i].pGeometries[j].geometry.triangles.vertexFormat,
6469 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
6470 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
6471 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6472 &pInfos[i].pGeometries[j].geometry.triangles,
6473 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
6474 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
6475 skip |= validate_ranged_enum(
6476 api_name,
6477 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.indexType", ParameterName::IndexVector{i, j}),
6478 "VkIndexType", AllVkIndexTypeEnums, pInfos[i].pGeometries[j].geometry.triangles.indexType,
6479 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
6480
6481 if (pInfos[i].pGeometries[j].geometry.triangles.vertexStride > UINT32_MAX) {
6482 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
6483 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
6484 }
6485 if (pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
6486 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
6487 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
6488 skip |=
6489 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
6490 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
6491 api_name);
6492 }
6493 }
6494 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6495 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
6496 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6497 &pInfos[i].pGeometries[j].geometry.instances,
6498 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
6499 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
6500 skip |= validate_struct_type(
6501 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.instances", ParameterName::IndexVector{i, j}),
6502 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6503 &(pInfos[i].pGeometries[j].geometry.instances),
6504 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
6505 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
6506 skip |= validate_struct_pnext(
6507 api_name,
6508 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.pNext", ParameterName::IndexVector{i, j}),
6509 NULL, pInfos[i].pGeometries[j].geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6510 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
6511
6512 skip |= validate_bool32(api_name,
6513 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.arrayOfPointers",
6514 ParameterName::IndexVector{i, j}),
6515 pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers);
6516 }
6517 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6518 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6519 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6520 &pInfos[i].pGeometries[j].geometry.aabbs,
6521 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6522 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6523 skip |= validate_struct_type(
6524 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs", ParameterName::IndexVector{i, j}),
6525 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6526 &(pInfos[i].pGeometries[j].geometry.aabbs),
6527 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6528 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6529 skip |= validate_struct_pnext(
6530 api_name,
6531 ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6532 pInfos[i].pGeometries[j].geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6533 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6534 if (pInfos[i].pGeometries[j].geometry.aabbs.stride > UINT32_MAX) {
6535 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6536 "(%s):stride must be less than or equal to 2^32-1", api_name);
6537 }
6538 }
6539 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6540 pInfos[i].pGeometries[j].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6541 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6542 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6543 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6544 api_name);
6545 }
6546 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6547 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6548 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6549 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6550 "of elements of"
6551 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6552 api_name);
6553 }
6554 if (pInfos[i].pGeometries[j].geometryType != pInfos[i].pGeometries[0].geometryType) {
6555 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6556 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6557 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6558 api_name);
6559 }
6560 }
6561 }
6562 }
6563 if (pInfos[i].ppGeometries != NULL) {
6564 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6565 skip |= validate_ranged_enum(
6566 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometryType", ParameterName::IndexVector{i, j}),
6567 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].ppGeometries[j]->geometryType,
6568 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
6569 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006570 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
6571 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6572 &pInfos[i].ppGeometries[j]->geometry.triangles,
6573 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
6574 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
6575 skip |= validate_struct_type(
6576 api_name,
6577 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles", ParameterName::IndexVector{i, j}),
6578 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6579 &(pInfos[i].ppGeometries[j]->geometry.triangles),
6580 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
6581 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
6582 skip |= validate_struct_pnext(
6583 api_name,
6584 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
6585 NULL, pInfos[i].ppGeometries[j]->geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6586 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
6587 skip |= validate_ranged_enum(api_name,
6588 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.vertexFormat",
6589 ParameterName::IndexVector{i, j}),
6590 "VkFormat", AllVkFormatEnums,
6591 pInfos[i].ppGeometries[j]->geometry.triangles.vertexFormat,
6592 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
6593 skip |= validate_ranged_enum(api_name,
6594 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.indexType",
6595 ParameterName::IndexVector{i, j}),
6596 "VkIndexType", AllVkIndexTypeEnums,
6597 pInfos[i].ppGeometries[j]->geometry.triangles.indexType,
6598 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
6599 if (pInfos[i].ppGeometries[j]->geometry.triangles.vertexStride > UINT32_MAX) {
6600 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
6601 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
6602 }
6603 if (pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
6604 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
6605 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
6606 skip |=
6607 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
6608 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
6609 api_name);
6610 }
6611 }
6612 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6613 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
6614 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6615 &pInfos[i].ppGeometries[j]->geometry.instances,
6616 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
6617 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
6618 skip |= validate_struct_type(
6619 api_name,
6620 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances", ParameterName::IndexVector{i, j}),
6621 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6622 &(pInfos[i].ppGeometries[j]->geometry.instances),
6623 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
6624 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
6625 skip |= validate_struct_pnext(
6626 api_name,
6627 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.pNext", ParameterName::IndexVector{i, j}),
6628 NULL, pInfos[i].ppGeometries[j]->geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6629 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
6630 skip |= validate_bool32(api_name,
6631 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.arrayOfPointers",
6632 ParameterName::IndexVector{i, j}),
6633 pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers);
6634 }
6635 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6636 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6637 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6638 &pInfos[i].ppGeometries[j]->geometry.aabbs,
6639 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6640 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6641 skip |= validate_struct_type(
6642 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs", ParameterName::IndexVector{i, j}),
6643 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6644 &(pInfos[i].ppGeometries[j]->geometry.aabbs),
6645 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6646 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6647 skip |= validate_struct_pnext(
6648 api_name,
6649 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6650 pInfos[i].ppGeometries[j]->geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6651 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6652 if (pInfos[i].ppGeometries[j]->geometry.aabbs.stride > UINT32_MAX) {
6653 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6654 "(%s):stride must be less than or equal to 2^32-1", api_name);
6655 }
6656 }
6657 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6658 pInfos[i].ppGeometries[j]->geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6659 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6660 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6661 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6662 api_name);
6663 }
6664 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6665 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6666 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6667 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6668 "of elements of"
6669 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6670 api_name);
6671 }
6672 if (pInfos[i].ppGeometries[j]->geometryType != pInfos[i].ppGeometries[0]->geometryType) {
6673 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6674 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6675 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6676 api_name);
6677 }
6678 }
6679 }
6680 }
6681 }
6682 return skip;
6683}
6684bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresKHR(
6685 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6686 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6687 bool skip = false;
6688 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresKHR");
6689 for (uint32_t i = 0; i < infoCount; ++i) {
6690 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6691 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6692 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03710",
6693 "vkCmdBuildAccelerationStructuresKHR:For each element of pInfos, its "
6694 "scratchData.deviceAddress member must be a multiple of "
6695 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6696 }
6697 for (uint32_t k = 0; k < infoCount; ++k) {
6698 if (i == k) continue;
6699 bool found = false;
6700 if (pInfos[i].dstAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6701 skip |= LogError(
6702 device, "VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6703 "vkCmdBuildAccelerationStructuresKHR:The dstAccelerationStructure member of any element (%d) of pInfos must "
6704 "not be "
6705 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6706 i, k);
6707 found = true;
6708 }
6709 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6710 skip |= LogError(
6711 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03403",
6712 "vkCmdBuildAccelerationStructuresKHR:The srcAccelerationStructure member of any element (%d) of pInfos must "
6713 "not be "
6714 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6715 i, k);
6716 found = true;
6717 }
6718 if (found) break;
6719 }
6720 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6721 if (pInfos[i].pGeometries) {
6722 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6723 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6724 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6725 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6726 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6727 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6728 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6729 }
6730 } else {
6731 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6732 skip |=
6733 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6734 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6735 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6736 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6737 }
6738 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006739 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006740 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6741 skip |= LogError(
6742 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6743 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6744 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6745 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006746 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6747 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006748 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6749 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6750 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6751 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6752 }
6753 }
6754 } else if (pInfos[i].ppGeometries) {
6755 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6756 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6757 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6758 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6759 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6760 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6761 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6762 }
6763 } else {
6764 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6765 skip |=
6766 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6767 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6768 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6769 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6770 }
6771 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006772 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006773 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6774 skip |= LogError(
6775 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6776 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6777 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6778 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006779 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6780 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006781 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6782 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6783 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6784 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6785 }
6786 }
6787 }
6788 }
6789 }
6790 return skip;
6791}
6792
6793bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresIndirectKHR(
6794 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6795 const VkDeviceAddress *pIndirectDeviceAddresses, const uint32_t *pIndirectStrides,
6796 const uint32_t *const *ppMaxPrimitiveCounts) const {
6797 bool skip = false;
6798 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresIndirectKHR");
6799 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006800 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006801 if (!ray_tracing_acceleration_structure_features ||
6802 ray_tracing_acceleration_structure_features->accelerationStructureIndirectBuild == VK_FALSE) {
6803 skip |= LogError(
6804 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-accelerationStructureIndirectBuild-03650",
6805 "vkCmdBuildAccelerationStructuresIndirectKHR: The "
6806 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureIndirectBuild feature must be enabled.");
6807 }
6808 for (uint32_t i = 0; i < infoCount; ++i) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006809 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6810 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6811 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03710",
6812 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, its "
6813 "scratchData.deviceAddress member must be a multiple of "
6814 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6815 }
6816 for (uint32_t k = 0; k < infoCount; ++k) {
6817 if (i == k) continue;
6818 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6819 skip |=
6820 LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03403",
6821 "vkCmdBuildAccelerationStructuresIndirectKHR:The srcAccelerationStructure member of any element (%d) "
6822 "of pInfos must not be the same acceleration structure as the dstAccelerationStructure member of "
6823 "any other element [%d) of pInfos.",
6824 i, k);
6825 break;
6826 }
6827 }
6828 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6829 if (pInfos[i].pGeometries) {
6830 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6831 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6832 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6833 skip |= LogError(
6834 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6835 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6836 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6837 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6838 }
6839 } else {
6840 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6841 skip |= LogError(
6842 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6843 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6844 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6845 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6846 }
6847 }
6848 }
6849 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6850 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6851 skip |= LogError(
6852 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6853 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6854 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6855 }
6856 }
6857 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6858 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.indexData.deviceAddress, 16) != 0) {
6859 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6860 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6861 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6862 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6863 }
6864 }
6865 } else if (pInfos[i].ppGeometries) {
6866 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6867 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6868 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6869 skip |= LogError(
6870 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6871 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6872 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6873 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6874 }
6875 } else {
6876 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6877 skip |= LogError(
6878 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6879 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6880 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6881 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6882 }
6883 }
6884 }
6885 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6886 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6887 skip |= LogError(
6888 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6889 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6890 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6891 }
6892 }
6893 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6894 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.indexData.deviceAddress, 16) != 0) {
6895 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6896 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6897 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6898 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6899 }
6900 }
6901 }
6902 }
6903 }
6904 return skip;
6905}
6906
6907bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructuresKHR(
6908 VkDevice device, VkDeferredOperationKHR deferredOperation, uint32_t infoCount,
6909 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6910 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6911 bool skip = false;
6912 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkBuildAccelerationStructuresKHR");
6913 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006914 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006915 if (!ray_tracing_acceleration_structure_features ||
6916 ray_tracing_acceleration_structure_features->accelerationStructureHostCommands == VK_FALSE) {
6917 skip |=
6918 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581",
6919 "vkBuildAccelerationStructuresKHR: The "
6920 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled");
6921 }
6922 for (uint32_t i = 0; i < infoCount; ++i) {
6923 for (uint32_t j = 0; j < infoCount; ++j) {
6924 if (i == j) continue;
6925 bool found = false;
6926 if (pInfos[i].dstAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6927 skip |= LogError(
6928 device, "VUID-vkBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6929 "vkBuildAccelerationStructuresKHR(): The dstAccelerationStructure member of any element (%d) of pInfos must "
6930 "not be "
6931 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6932 i, j);
6933 found = true;
6934 }
6935 if (pInfos[i].srcAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6936 skip |= LogError(
6937 device, "VUID-vkBuildAccelerationStructuresKHR-pInfos-03403",
6938 "vkBuildAccelerationStructuresKHR(): The srcAccelerationStructure member of any element (%d) of pInfos must "
6939 "not be "
6940 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6941 i, j);
6942 found = true;
6943 }
6944 if (found) break;
6945 }
6946 }
6947 return skip;
6948}
6949
6950bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureBuildSizesKHR(
6951 VkDevice device, VkAccelerationStructureBuildTypeKHR buildType, const VkAccelerationStructureBuildGeometryInfoKHR *pBuildInfo,
6952 const uint32_t *pMaxPrimitiveCounts, VkAccelerationStructureBuildSizesInfoKHR *pSizeInfo) const {
6953 bool skip = false;
6954 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pBuildInfo, 1, "vkGetAccelerationStructureBuildSizesKHR");
6955 const auto *ray_tracing_pipeline_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006956 LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
6957 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006958 if (!(ray_tracing_pipeline_features || ray_query_features) ||
6959 ((ray_tracing_pipeline_features && ray_tracing_pipeline_features->rayTracingPipeline == VK_FALSE) ||
6960 (ray_query_features && ray_query_features->rayQuery == VK_FALSE))) {
6961 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-rayTracingPipeline-03617",
6962 "vkGetAccelerationStructureBuildSizesKHR:The rayTracingPipeline or rayQuery feature must be enabled");
6963 }
6964 return skip;
6965}
sfricke-samsungecafb192021-01-17 08:21:14 -08006966
6967bool StatelessValidation::manual_PreCallValidateCreatePrivateDataSlotEXT(VkDevice device,
6968 const VkPrivateDataSlotCreateInfoEXT *pCreateInfo,
6969 const VkAllocationCallbacks *pAllocator,
6970 VkPrivateDataSlotEXT *pPrivateDataSlot) const {
6971 bool skip = false;
6972 const auto *private_data_features = LvlFindInChain<VkPhysicalDevicePrivateDataFeaturesEXT>(device_createinfo_pnext);
6973 if (private_data_features && private_data_features->privateData == VK_FALSE) {
6974 skip |= LogError(device, "VUID-vkCreatePrivateDataSlotEXT-privateData-04564",
6975 "vkCreatePrivateDataSlotEXT(): The privateData feature must be enabled.");
6976 }
6977 return skip;
Jeremy Gebbencbf22862021-03-03 12:01:22 -07006978}
Piers Daniellcb6d8032021-04-19 18:51:26 -06006979
6980bool StatelessValidation::manual_PreCallValidateCmdSetVertexInputEXT(
6981 VkCommandBuffer commandBuffer, uint32_t vertexBindingDescriptionCount,
6982 const VkVertexInputBindingDescription2EXT *pVertexBindingDescriptions, uint32_t vertexAttributeDescriptionCount,
6983 const VkVertexInputAttributeDescription2EXT *pVertexAttributeDescriptions) const {
6984 bool skip = false;
6985 const auto *vertex_input_dynamic_state_features =
6986 LvlFindInChain<VkPhysicalDeviceVertexInputDynamicStateFeaturesEXT>(device_createinfo_pnext);
6987 const auto *vertex_attribute_divisor_features =
6988 LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(device_createinfo_pnext);
6989
6990 // VUID-vkCmdSetVertexInputEXT-None-04790
6991 if (!vertex_input_dynamic_state_features || vertex_input_dynamic_state_features->vertexInputDynamicState == VK_FALSE) {
6992 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-None-04790",
6993 "vkCmdSetVertexInputEXT(): The vertexInputDynamicState feature must be enabled.");
6994 }
6995
6996 // VUID-vkCmdSetVertexInputEXT-vertexBindingDescriptionCount-04791
6997 if (vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
6998 skip |=
6999 LogError(device, "VUID-vkCmdSetVertexInputEXT-vertexBindingDescriptionCount-04791",
7000 "vkCmdSetVertexInputEXT(): vertexBindingDescriptionCount is greater than the maxVertexInputBindings limit");
7001 }
7002
7003 // VUID-vkCmdSetVertexInputEXT-vertexAttributeDescriptionCount-04792
7004 if (vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
7005 skip |= LogError(
7006 device, "VUID-vkCmdSetVertexInputEXT-vertexAttributeDescriptionCount-04792",
7007 "vkCmdSetVertexInputEXT(): vertexAttributeDescriptionCount is greater than the maxVertexInputAttributes limit");
7008 }
7009
7010 // VUID-vkCmdSetVertexInputEXT-binding-04793
7011 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount; ++attribute) {
7012 bool binding_found = false;
7013 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount; ++binding) {
7014 if (pVertexAttributeDescriptions[attribute].binding == pVertexBindingDescriptions[binding].binding) {
7015 binding_found = true;
7016 break;
7017 }
7018 }
7019 if (!binding_found) {
7020 skip |=
7021 LogError(device, "VUID-vkCmdSetVertexInputEXT-binding-04793",
7022 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%u] references an unspecified binding", attribute);
7023 }
7024 }
7025
7026 // VUID-vkCmdSetVertexInputEXT-pVertexBindingDescriptions-04794
7027 if (vertexBindingDescriptionCount > 1) {
7028 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount - 1; ++binding) {
7029 uint32_t binding_value = pVertexBindingDescriptions[binding].binding;
7030 for (uint32_t next_binding = binding + 1; next_binding < vertexBindingDescriptionCount; ++next_binding) {
7031 if (binding_value == pVertexBindingDescriptions[next_binding].binding) {
7032 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-pVertexBindingDescriptions-04794",
7033 "vkCmdSetVertexInputEXT(): binding description for binding %u already specified", binding_value);
7034 }
7035 }
7036 }
7037 }
7038
7039 // VUID-vkCmdSetVertexInputEXT-pVertexAttributeDescriptions-04795
7040 if (vertexAttributeDescriptionCount > 1) {
7041 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount - 1; ++attribute) {
7042 uint32_t location = pVertexAttributeDescriptions[attribute].location;
7043 for (uint32_t next_attribute = attribute + 1; next_attribute < vertexAttributeDescriptionCount; ++next_attribute) {
7044 if (location == pVertexAttributeDescriptions[next_attribute].location) {
7045 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-pVertexAttributeDescriptions-04795",
7046 "vkCmdSetVertexInputEXT(): attribute description for location %u already specified", location);
7047 }
7048 }
7049 }
7050 }
7051
7052 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount; ++binding) {
7053 // VUID-VkVertexInputBindingDescription2EXT-binding-04796
7054 if (pVertexBindingDescriptions[binding].binding > device_limits.maxVertexInputBindings) {
7055 skip |= LogError(
7056 device, "VUID-VkVertexInputBindingDescription2EXT-binding-04796",
7057 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%u].binding is greater than maxVertexInputBindings", binding);
7058 }
7059
7060 // VUID-VkVertexInputBindingDescription2EXT-stride-04797
7061 if (pVertexBindingDescriptions[binding].stride > device_limits.maxVertexInputBindingStride) {
7062 skip |= LogError(
7063 device, "VUID-VkVertexInputBindingDescription2EXT-stride-04797",
7064 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%u].stride is greater than maxVertexInputBindingStride",
7065 binding);
7066 }
7067
7068 // VUID-VkVertexInputBindingDescription2EXT-divisor-04798
7069 if (pVertexBindingDescriptions[binding].divisor == 0 &&
7070 (!vertex_attribute_divisor_features || !vertex_attribute_divisor_features->vertexAttributeInstanceRateZeroDivisor)) {
7071 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04798",
7072 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%u].divisor is zero but "
7073 "vertexAttributeInstanceRateZeroDivisor is not enabled",
7074 binding);
7075 }
7076
7077 if (pVertexBindingDescriptions[binding].divisor > 1) {
7078 // VUID-VkVertexInputBindingDescription2EXT-divisor-04799
7079 if (!vertex_attribute_divisor_features || !vertex_attribute_divisor_features->vertexAttributeInstanceRateDivisor) {
7080 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04799",
7081 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%u].divisor is greater than one but "
7082 "vertexAttributeInstanceRateDivisor is not enabled",
7083 binding);
7084 } else {
7085 // VUID-VkVertexInputBindingDescription2EXT-divisor-04800
7086 if (pVertexBindingDescriptions[binding].divisor >
7087 phys_dev_ext_props.vertex_attribute_divisor_props.maxVertexAttribDivisor) {
7088 skip |= LogError(
7089 device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04800",
7090 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%u].divisor is greater than maxVertexAttribDivisor",
7091 binding);
7092 }
7093
7094 // VUID-VkVertexInputBindingDescription2EXT-divisor-04801
7095 if (pVertexBindingDescriptions[binding].inputRate != VK_VERTEX_INPUT_RATE_INSTANCE) {
7096 skip |=
7097 LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04801",
7098 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%u].divisor is greater than 1 but inputRate "
7099 "is not VK_VERTEX_INPUT_RATE_INSTANCE",
7100 binding);
7101 }
7102 }
7103 }
7104 }
7105
7106 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount; ++attribute) {
7107 // VUID-VkVertexInputAttributeDescription2EXT-location-04802
7108 if (pVertexAttributeDescriptions[attribute].location > device_limits.maxVertexInputAttributes) {
7109 skip |= LogError(
7110 device, "VUID-VkVertexInputAttributeDescription2EXT-location-04802",
7111 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%u].location is greater than maxVertexInputAttributes",
7112 attribute);
7113 }
7114
7115 // VUID-VkVertexInputAttributeDescription2EXT-binding-04803
7116 if (pVertexAttributeDescriptions[attribute].binding > device_limits.maxVertexInputBindings) {
7117 skip |= LogError(
7118 device, "VUID-VkVertexInputAttributeDescription2EXT-binding-04803",
7119 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%u].binding is greater than maxVertexInputBindings",
7120 attribute);
7121 }
7122
7123 // VUID-VkVertexInputAttributeDescription2EXT-offset-04804
7124 if (pVertexAttributeDescriptions[attribute].offset > device_limits.maxVertexInputAttributeOffset) {
7125 skip |= LogError(
7126 device, "VUID-VkVertexInputAttributeDescription2EXT-offset-04804",
7127 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%u].offset is greater than maxVertexInputAttributeOffset",
7128 attribute);
7129 }
7130
7131 // VUID-VkVertexInputAttributeDescription2EXT-format-04805
7132 VkFormatProperties properties;
7133 DispatchGetPhysicalDeviceFormatProperties(physical_device, pVertexAttributeDescriptions[attribute].format, &properties);
7134 if ((properties.bufferFeatures & VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT) == 0) {
7135 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-format-04805",
7136 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%u].format is not a "
7137 "VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT supported format",
7138 attribute);
7139 }
7140 }
7141
7142 return skip;
7143}
sfricke-samsung51303fb2021-05-09 19:09:13 -07007144
7145bool StatelessValidation::manual_PreCallValidateCmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout,
7146 VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size,
7147 const void *pValues) const {
7148 bool skip = false;
7149 const uint32_t max_push_constants_size = device_limits.maxPushConstantsSize;
7150 // Check that offset + size don't exceed the max.
7151 // Prevent arithetic overflow here by avoiding addition and testing in this order.
7152 if (offset >= max_push_constants_size) {
7153 skip |= LogError(device, "VUID-vkCmdPushConstants-offset-00370",
7154 "vkCmdPushConstants(): offset (%u) that exceeds this device's maxPushConstantSize of %u.", offset,
7155 max_push_constants_size);
7156 }
7157 if (size > max_push_constants_size - offset) {
7158 skip |= LogError(device, "VUID-vkCmdPushConstants-size-00371",
7159 "vkCmdPushConstants(): offset (%u) and size (%u) that exceeds this device's maxPushConstantSize of %u.",
7160 offset, size, max_push_constants_size);
7161 }
7162
7163 // size needs to be non-zero and a multiple of 4.
7164 if (size & 0x3) {
7165 skip |= LogError(device, "VUID-vkCmdPushConstants-size-00369", "vkCmdPushConstants(): size (%u) must be a multiple of 4.",
7166 size);
7167 }
7168
7169 // offset needs to be a multiple of 4.
7170 if ((offset & 0x3) != 0) {
7171 skip |= LogError(device, "VUID-vkCmdPushConstants-offset-00368",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06007172 "vkCmdPushConstants(): offset (%u) must be a multiple of 4.", offset);
sfricke-samsung51303fb2021-05-09 19:09:13 -07007173 }
7174 return skip;
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06007175}