blob: d5a72e3b2f6ef52e6384e764859d7c41771776aa [file] [log] [blame]
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08001/* Copyright (c) 2015-2020 The Khronos Group Inc.
2 * Copyright (c) 2015-2020 Valve Corporation
3 * Copyright (c) 2015-2020 LunarG, Inc.
4 * Copyright (C) 2015-2020 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028static const int MaxParamCheckerStringLength = 256;
29
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070036bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050037 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060038 bool skip = false;
39
40 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
41
42 if (result == VK_STRING_ERROR_NONE) {
43 return skip;
44 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070045 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
46 MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070048 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
49 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050 }
51 return skip;
52}
53
Jeff Bolz46c0ea02019-10-09 13:06:29 -050054bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060055 bool skip = false;
56 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
57 if (api_version_nopatch != effective_api_version) {
58 if (api_version_nopatch < VK_API_VERSION_1_0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070059 skip |= LogError(instance, kVUIDUndefined,
60 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
61 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
62 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060063 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070064 skip |= LogWarning(instance, kVUIDUndefined,
65 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
66 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
67 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060068 }
69 }
70 return skip;
71}
72
Jeff Bolz46c0ea02019-10-09 13:06:29 -050073bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060074 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060075 // Create and use a local instance extension object, as an actual instance has not been created yet
76 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
77 InstanceExtensions local_instance_extensions;
78 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
79
John Zulauf620755c2018-04-16 11:00:43 -060080 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060081 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
82 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060083 }
84
85 return skip;
86}
87
Tony-LunarG866843d2020-05-13 11:22:42 -060088bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
89 const VkValidationFeaturesEXT *validation_features) const {
90 bool skip = false;
91 bool debug_printf = false;
92 bool gpu_assisted = false;
93 bool reserve_slot = false;
94 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
95 switch (validation_features->pEnabledValidationFeatures[i]) {
96 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
97 gpu_assisted = true;
98 break;
99
100 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
101 debug_printf = true;
102 break;
103
104 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
105 reserve_slot = true;
106 break;
107
108 default:
109 break;
110 }
111 }
112 if (reserve_slot && !gpu_assisted) {
113 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
114 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
115 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
116 }
117 if (gpu_assisted && debug_printf) {
118 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
119 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
120 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
121 }
122
123 return skip;
124}
125
John Zulauf620755c2018-04-16 11:00:43 -0600126template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700127ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
128 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600129 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700130 ExtEnabled state =
131 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600132 return state;
133}
134
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700135bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500136 const VkAllocationCallbacks *pAllocator,
137 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700138 bool skip = false;
139 // Note: From the spec--
140 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
141 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
142 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700143 ? pCreateInfo->pApplicationInfo->apiVersion
144 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700145 skip |= validate_api_version(local_api_version, api_version);
146 skip |= validate_instance_extensions(pCreateInfo);
Tony-LunarG866843d2020-05-13 11:22:42 -0600147 const auto *validation_features = lvl_find_in_chain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
148 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
149
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700150 return skip;
151}
152
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700153void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700154 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
155 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700156 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
157 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700158 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700159 this->instance_extensions = instance_data->instance_extensions;
160}
161
162void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700163 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700164 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700165 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700166 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
167 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700168
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700169 // Parmeter validation also uses extension data
170 stateless_validation->device_extensions = this->device_extensions;
171
172 VkPhysicalDeviceProperties device_properties = {};
173 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600174 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700175 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
176
177 if (device_extensions.vk_nv_shading_rate_image) {
178 // Get the needed shading rate image limits
179 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
180 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600181 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700182 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
183 }
184
185 if (device_extensions.vk_nv_mesh_shader) {
186 // Get the needed mesh shader limits
187 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
188 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600189 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700190 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
191 }
192
Jason Macnak5c954952019-07-09 15:46:12 -0700193 if (device_extensions.vk_nv_ray_tracing) {
194 // Get the needed ray tracing limits
195 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesNV>();
196 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
197 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500198 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
199 }
200
201 if (device_extensions.vk_khr_ray_tracing) {
202 // Get the needed ray tracing limits
203 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesKHR>();
204 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
205 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
206 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700207 }
208
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700209 if (device_extensions.vk_ext_transform_feedback) {
210 // Get the needed transform feedback limits
211 auto transform_feedback_props = lvl_init_struct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
212 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&transform_feedback_props);
213 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
214 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
215 }
216
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800217 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
218
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700219 // Save app-enabled features in this device's validation object
220 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Petr Kraus715bcc72019-08-15 17:17:33 +0200221 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
222 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
223 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
224 if (features2) {
225 tmp_features2_state.features = features2->features;
226 } else if (pCreateInfo->pEnabledFeatures) {
227 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700228 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200229 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700230 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200231 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700232 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200233 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700234}
235
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700236bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500237 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600238 bool skip = false;
239
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200240 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
241 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
242 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600243 }
244
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200245 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
246 skip |=
247 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
248 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
249 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
250 pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600251 }
252
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200253 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700254 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
255 bool negative_viewport =
256 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200257 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700258 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
259 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
260 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200261 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600262 }
263
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600264 {
265 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
266 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
267 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700268 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
269 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
270 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600271 }
272 }
273
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600274 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
275 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600276 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
277 if (features2) {
278 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700279 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700280 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
281 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600282 }
283 }
284
Locke77fad1c2019-04-16 13:09:03 -0600285 auto features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
286 if (features2) {
287 if (!instance_extensions.vk_khr_get_physical_device_properties_2) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700288 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
289 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct, "
290 "VK_KHR_get_physical_device_properties2 must be enabled when it creates an instance.");
Locke77fad1c2019-04-16 13:09:03 -0600291 }
292 }
293
Jeff Bolz165818a2020-05-08 11:19:03 -0500294 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
295 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
296 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
297 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
298 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
299 }
sourav parmara24fb7b2020-05-26 10:50:04 -0700300 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(pCreateInfo->pNext);
301 if (raytracing_features && raytracing_features->rayTracingShaderGroupHandleCaptureReplayMixed &&
302 !raytracing_features->rayTracingShaderGroupHandleCaptureReplay) {
303 skip |= LogError(device, "VUID-VkPhysicalDeviceRayTracingFeaturesKHR-rayTracingShaderGroupHandleCaptureReplayMixed-03348",
304 "If rayTracingShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingShaderGroupHandleCaptureReplay "
305 "must also be VK_TRUE.");
306 }
Locke77fad1c2019-04-16 13:09:03 -0600307 auto vertex_attribute_divisor_features =
308 lvl_find_in_chain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
309 if (vertex_attribute_divisor_features) {
310 bool extension_found = false;
311 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; ++i) {
312 if (0 == strncmp(pCreateInfo->ppEnabledExtensionNames[i], VK_EXT_VERTEX_ATTRIBUTE_DIVISOR_EXTENSION_NAME,
313 VK_MAX_EXTENSION_NAME_SIZE)) {
314 extension_found = true;
315 break;
316 }
317 }
318 if (!extension_found) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700319 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
320 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
321 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600322 }
323 }
324
Tony-LunarG28017bc2020-01-23 14:40:25 -0700325 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
326 if (vulkan_11_features) {
327 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
328 while (current) {
329 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
330 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
331 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
332 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
333 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
334 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700335 skip |= LogError(
336 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700337 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
338 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
339 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
340 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
341 break;
342 }
343 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
344 }
345 }
346
347 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
348 if (vulkan_12_features) {
349 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
350 while (current) {
351 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
352 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
353 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
354 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
355 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
356 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
357 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
358 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
359 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
360 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
361 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
362 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
363 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700364 skip |= LogError(
365 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700366 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
367 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
368 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
369 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
370 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
371 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
372 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
373 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
374 break;
375 }
376 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
377 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700378 // Check features are enabled if matching extension is passed in as well
379 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
380 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
381 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
382 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
383 skip |= LogError(
384 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02831",
385 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
386 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
387 }
388 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
389 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
390 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02832",
391 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
392 "is not VK_TRUE.",
393 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
394 }
395 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
396 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
397 skip |= LogError(
398 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02833",
399 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
400 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
401 }
402 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
403 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
404 skip |= LogError(
405 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02834",
406 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
407 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
408 }
409 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
410 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
411 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
412 skip |=
413 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02835",
414 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
415 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
416 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
417 }
418 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700419 }
420
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600421 // Validate pCreateInfo->pQueueCreateInfos
422 if (pCreateInfo->pQueueCreateInfos) {
423 std::unordered_set<uint32_t> set;
424
425 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700426 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
427 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600428 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700429 skip |=
430 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
431 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
432 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
433 "index value.",
434 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600435 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700436 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
437 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
438 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
439 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600440 } else {
441 set.insert(requested_queue_family);
442 }
443
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700444 if (queue_create_info.pQueuePriorities != nullptr) {
445 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
446 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600447 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700448 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
449 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
450 "] (=%f) is not between 0 and 1 (inclusive).",
451 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600452 }
453 }
454 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700455
456 // Need to know if protectedMemory feature is passed in preCall to creating the device
457 VkBool32 protectedMemory = VK_FALSE;
458 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
459 lvl_find_in_chain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
460 if (protected_features) {
461 protectedMemory = protected_features->protectedMemory;
462 } else if (vulkan_11_features) {
463 protectedMemory = vulkan_11_features->protectedMemory;
464 }
465 if ((queue_create_info.flags == VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) && (protectedMemory == VK_FALSE)) {
466 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
467 "vkCreateDevice: pCreateInfo->flags set to VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
468 "protectedMemory feature being set as well.");
469 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600470 }
471 }
472
sfricke-samsung30a57412020-05-15 21:14:54 -0700473 // feature dependencies for VK_KHR_variable_pointers
474 const auto *variable_pointers_features = lvl_find_in_chain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
475 VkBool32 variablePointers = VK_FALSE;
476 VkBool32 variablePointersStorageBuffer = VK_FALSE;
477 if (vulkan_11_features) {
478 variablePointers = vulkan_11_features->variablePointers;
479 variablePointersStorageBuffer = vulkan_11_features->variablePointersStorageBuffer;
480 } else if (variable_pointers_features) {
481 variablePointers = variable_pointers_features->variablePointers;
482 variablePointersStorageBuffer = variable_pointers_features->variablePointersStorageBuffer;
483 }
484 if ((variablePointers == VK_TRUE) && (variablePointersStorageBuffer == VK_FALSE)) {
485 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
486 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
487 }
488
sfricke-samsungfd76c342020-05-29 23:13:43 -0700489 // feature dependencies for VK_KHR_multiview
490 const auto *multiview_features = lvl_find_in_chain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
491 VkBool32 multiview = VK_FALSE;
492 VkBool32 multiviewGeometryShader = VK_FALSE;
493 VkBool32 multiviewTessellationShader = VK_FALSE;
494 if (vulkan_11_features) {
495 multiview = vulkan_11_features->multiview;
496 multiviewGeometryShader = vulkan_11_features->multiviewGeometryShader;
497 multiviewTessellationShader = vulkan_11_features->multiviewTessellationShader;
498 } else if (multiview_features) {
499 multiview = multiview_features->multiview;
500 multiviewGeometryShader = multiview_features->multiviewGeometryShader;
501 multiviewTessellationShader = multiview_features->multiviewTessellationShader;
502 }
503 if ((multiview == VK_FALSE) && (multiviewGeometryShader == VK_TRUE)) {
504 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
505 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
506 }
507 if ((multiview == VK_FALSE) && (multiviewTessellationShader == VK_TRUE)) {
508 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
509 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
510 }
511
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600512 return skip;
513}
514
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500515bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700516 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700517 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
518 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
519 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600520 }
521
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700522 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600523}
524
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700525bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500526 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100527 bool skip = false;
528
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600529 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700530 skip |=
531 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600532
533 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
534 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
535 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
536 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700537 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
538 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
539 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600540 }
541
542 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
543 // queueFamilyIndexCount uint32_t values
544 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700545 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
546 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
547 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
548 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600549 }
550 }
551
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700552 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
553 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
554 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
555 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
556 }
557
558 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
559 skip |=
560 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
561 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
562 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
563 }
564
565 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
566 skip |=
567 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
568 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
569 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
570 }
571
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600572 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
573 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
574 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
575 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700576 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
577 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
578 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600579 }
580 }
581
582 return skip;
583}
584
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700585bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500586 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600587 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600588
589 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600590 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
591 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
592 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
593 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700594 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
595 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
596 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600597 }
598
599 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
600 // queueFamilyIndexCount uint32_t values
601 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700602 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
603 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
604 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
605 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600606 }
607 }
608
Dave Houlton413a6782018-05-22 13:01:54 -0600609 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700610 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600611 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700612 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600613 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700614 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600615
Dave Houlton413a6782018-05-22 13:01:54 -0600616 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700617 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600618 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700619 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600620
Dave Houlton130c0212018-01-29 13:39:56 -0700621 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700622 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
623 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700624 skip |= LogError(
625 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600626 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
627 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700628 }
629
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600630 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100631 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
632 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700633 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
634 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
635 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600636 }
637
638 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100639 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
640 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700641 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
642 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
643 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
644 ") are not equal.",
645 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100646 }
647
648 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700649 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
650 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
651 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
652 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100653 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600654 }
655
656 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700657 skip |= LogError(
658 device, "VUID-VkImageCreateInfo-imageType-00957",
659 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600660 }
661 }
662
Dave Houlton130c0212018-01-29 13:39:56 -0700663 // 3D image may have only 1 layer
664 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700665 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
666 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700667 }
668
669 // If multi-sample, validate type, usage, tiling and mip levels.
670 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
671 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600672 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700673 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
674 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700675 }
676
677 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
678 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
679 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
680 // At least one of the legal attachment bits must be set
681 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700682 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
683 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700684 }
685 // No flags other than the legal attachment bits may be set
686 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
687 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700688 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
689 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700690 }
691 }
692
Jeff Bolzef40fec2018-09-01 22:04:34 -0500693 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600694 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500695 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -0600696 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
697 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500698 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600699 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700700 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
701 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
702 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600703 }
704
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600705 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700706 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
707 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
708 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600709 }
710
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700711 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700712 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
713 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
714 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100715 }
716
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700717 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
718 skip |= LogError(
719 device, "VUID-VkImageCreateInfo-flags-01924",
720 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
721 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
722 }
723
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600724 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
725 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
726 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
727 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700728 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
729 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
730 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600731 }
732
733 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
734 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
735 // Linear tiling is unsupported
736 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700737 skip |= LogError(device, kVUID_PVError_InvalidUsage,
738 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
739 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600740 }
741
742 // Sparse 1D image isn't valid
743 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700744 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
745 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600746 }
747
748 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700749 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700750 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
751 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
752 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600753 }
754
755 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700756 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700757 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
758 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
759 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600760 }
761
762 // Multi-sample 2D image when device doesn't support it
763 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700764 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600765 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700766 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
767 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
768 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700769 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600770 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700771 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
772 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
773 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700774 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600775 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700776 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
777 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
778 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700779 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600780 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700781 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
782 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
783 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600784 }
785 }
786 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500787
Jeff Bolz9af91c52018-09-01 21:53:57 -0500788 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
789 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700790 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
791 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
792 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500793 }
794 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700795 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
796 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
797 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500798 }
799 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700800 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
801 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
802 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500803 }
804 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500805
806 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600807 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700808 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
809 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
810 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500811 }
812
Dave Houlton142c4cb2018-10-17 15:04:41 -0600813 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700814 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
815 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
816 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
817 "not be a depth/stencil format.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500818 }
819
Dave Houlton142c4cb2018-10-17 15:04:41 -0600820 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700821 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
822 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
823 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
824 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500825 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600826 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700827 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
828 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
829 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
830 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500831 }
832 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500833
sfricke-samsung8f658d42020-05-03 20:12:24 -0700834 if (((pCreateInfo->flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
835 (FormatHasDepth(pCreateInfo->format) == false)) {
836 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
837 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
838 "format must be a depth or depth/stencil format.");
839 }
840
Andrew Fobel3abeb992020-01-20 16:33:22 -0500841 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pCreateInfo->pNext);
842 if (image_stencil_struct != nullptr) {
843 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
844 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
845 // No flags other than the legal attachment bits may be set
846 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
847 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700848 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
849 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
850 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
851 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500852 }
853 }
854
855 if (FormatIsDepthOrStencil(pCreateInfo->format)) {
856 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
857 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
858 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700859 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
860 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
861 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width exceeds device "
862 "maxFramebufferWidth");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500863 }
864
865 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
866 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700867 LogError(device, "VUID-VkImageCreateInfo-format-02537",
868 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
869 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height exceeds device "
870 "maxFramebufferHeight");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500871 }
872 }
873
874 if (!physical_device_features.shaderStorageImageMultisample &&
875 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
876 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
877 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700878 LogError(device, "VUID-VkImageCreateInfo-format-02538",
879 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
880 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
881 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500882 }
883
884 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
885 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700886 skip |= LogError(
887 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500888 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
889 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
890 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
891 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
892 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700893 skip |= LogError(
894 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500895 "vkCreateImage(): Depth-stencil image in which usage does not include "
896 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
897 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
898 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
899 }
900
901 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
902 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700903 skip |= LogError(
904 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500905 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
906 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
907 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
908 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
909 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700910 skip |= LogError(
911 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500912 "vkCreateImage(): Depth-stencil image in which usage does not include "
913 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
914 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
915 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
916 }
917 }
918 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -0700919
920 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
921 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
922 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
923 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
924 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
925 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -0700926
927 if (device_extensions.vk_ext_image_drm_format_modifier) {
928 const auto drm_format_mod_list = lvl_find_in_chain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
929 const auto drm_format_mod_explict =
930 lvl_find_in_chain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
931 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
932 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
933 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
934 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
935 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
936 "either VkImageDrmFormatModifierListCreateInfoEXT or "
937 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
938 }
939 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
940 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
941 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
942 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
943 "in the pNext chain");
944 }
945 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +0200946
947 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
948 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
949 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
950 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
951 "imageType must be VK_IMAGE_TYPE_2D.");
952 }
953 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
954 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
955 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
956 "samples must be VK_SAMPLE_COUNT_1_BIT.");
957 }
958 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
959 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
960 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
961 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
962 }
963 }
964 if (pCreateInfo->flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
965 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
966 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
967 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
968 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
969 }
970 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
971 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
972 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
973 "imageType must be VK_IMAGE_TYPE_2D.");
974 }
975 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
976 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
977 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
978 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
979 }
980 if (pCreateInfo->mipLevels != 1) {
981 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
982 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%d) must be 1.",
983 pCreateInfo->mipLevels);
984 }
985 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -0700986
987 const auto swapchain_create_info = lvl_find_in_chain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
988 if (swapchain_create_info != nullptr) {
989 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
990 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
991 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
992 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
993 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
994 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
995
996 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
997 // also implicitly forces the check above that extent.depth is 1
998 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
999 string_VkImageType(pCreateInfo->imageType));
1000 }
1001 if (pCreateInfo->mipLevels != 1) {
1002 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %u.", base_message,
1003 pCreateInfo->mipLevels);
1004 }
1005 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1006 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1007 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1008 }
1009 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1010 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1011 base_message, string_VkImageTiling(pCreateInfo->tiling));
1012 }
1013 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1014 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1015 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1016 }
1017 const VkImageCreateFlags valid_flags =
1018 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
1019 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT_KHR);
1020 if ((pCreateInfo->flags & ~valid_flags) != 0) {
1021 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
1022 pCreateInfo->flags);
1023 }
1024 }
1025 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001026 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001027
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001028 return skip;
1029}
1030
Jeff Bolz99e3f632020-03-24 22:59:22 -05001031bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1032 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1033 bool skip = false;
1034
1035 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001036 // Validate feature set if using CUBE_ARRAY
1037 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1038 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1039 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1040 "enabling the imageCubeArray feature.");
1041 }
1042
Jeff Bolz99e3f632020-03-24 22:59:22 -05001043 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1044 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1045 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
Spencer Fricke528e0982020-04-19 18:46:01 -07001046 "vkCreateImageView(): subresourceRange.layerCount (%d) must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001047 pCreateInfo->subresourceRange.layerCount);
1048 }
1049 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001050 skip |= LogError(
1051 device, "VUID-VkImageViewCreateInfo-viewType-02961",
1052 "vkCreateImageView(): subresourceRange.layerCount (%d) must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1053 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001054 }
1055 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001056
1057 auto astc_decode_mode = lvl_find_in_chain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
1058 if ((device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
1059 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1060 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1061 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1062 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1063 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1064 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1065 }
1066 if (FormatIsCompressed_ASTC(pCreateInfo->format) == false) {
1067 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1068 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1069 "not an ASTC format.",
1070 string_VkFormat(pCreateInfo->format));
1071 }
1072 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001073 }
1074 return skip;
1075}
1076
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001077bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001078 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001079 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001080
1081 // Note: for numerical correctness
1082 // - float comparisons should expect NaN (comparison always false).
1083 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1084
1085 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001086 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001087 if (v1_f <= 0.0f) return true;
1088
1089 float intpart;
1090 const float fract = modff(v1_f, &intpart);
1091
1092 assert(std::numeric_limits<float>::radix == 2);
1093 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1094 if (intpart >= u32_max_plus1) return false;
1095
1096 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1097 if (v1_u32 < v2_u32)
1098 return true;
1099 else if (v1_u32 == v2_u32 && fract == 0.0f)
1100 return true;
1101 else
1102 return false;
1103 };
1104
1105 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1106 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1107 return (v1_f <= v2_f);
1108 };
1109
1110 // width
1111 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001112 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001113
1114 if (!(viewport.width > 0.0f)) {
1115 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001116 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1117 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001118 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1119 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001120 skip |= LogError(object, "VUID-VkViewport-width-01771",
1121 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1122 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001123 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001124 skip |= LogWarning(object, kVUID_PVError_NONE,
1125 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
1126 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1127 fn_name, parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001128 }
1129
1130 // height
1131 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -07001132 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001133 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001134
1135 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1136 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001137 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1138 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001139 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1140 height_healthy = false;
1141
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001142 skip |= LogError(object, "VUID-VkViewport-height-01773",
1143 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1144 ").",
1145 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001146 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1147 height_healthy = false;
1148
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001149 skip |= LogWarning(
1150 object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001151 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001152 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001153 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001154 }
1155
1156 // x
1157 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001158 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001159 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001160 skip |= LogError(object, "VUID-VkViewport-x-01774",
1161 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1162 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001163 }
1164
1165 // x + width
1166 if (x_healthy && width_healthy) {
1167 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001168 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001169 skip |= LogError(
1170 object, "VUID-VkViewport-x-01232",
1171 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1172 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1173 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001174 }
1175 }
1176
1177 // y
1178 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001179 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001180 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001181 skip |= LogError(object, "VUID-VkViewport-y-01775",
1182 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1183 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001184 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001185 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001186 skip |= LogError(object, "VUID-VkViewport-y-01776",
1187 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1188 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001189 }
1190
1191 // y + height
1192 if (y_healthy && height_healthy) {
1193 const float boundary = viewport.y + viewport.height;
1194
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001195 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001196 skip |= LogError(object, "VUID-VkViewport-y-01233",
1197 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1198 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1199 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001200 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001201 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001202 LogError(object, "VUID-VkViewport-y-01777",
1203 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1204 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1205 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001206 }
1207 }
1208
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001209 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001210 // minDepth
1211 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001212 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001213
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001214 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1215 "[0.0, 1.0] range.",
1216 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001217 }
1218
1219 // maxDepth
1220 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001221 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001222
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001223 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1224 "[0.0, 1.0] range.",
1225 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001226 }
1227 }
1228
1229 return skip;
1230}
1231
Dave Houlton142c4cb2018-10-17 15:04:41 -06001232struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001233 VkShadingRatePaletteEntryNV shadingRate;
1234 uint32_t width;
1235 uint32_t height;
1236};
1237
1238// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -06001239static SampleOrderInfo sampleOrderInfos[] = {
1240 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1241 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1242 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1243 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1244 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1245 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001246};
1247
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001248bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001249 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001250
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001251 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001252 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001253 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001254 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001255 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001256 break;
1257 }
1258 }
1259
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001260 if (sampleOrderInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001261 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1262 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1263 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001264 return skip;
1265 }
1266
Dave Houlton142c4cb2018-10-17 15:04:41 -06001267 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001268 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001269 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1270 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1271 ") must "
1272 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1273 "is set in framebufferNoAttachmentsSampleCounts.",
1274 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001275 }
1276
Jeff Bolz9af91c52018-09-01 21:53:57 -05001277 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001278 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1279 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1280 ") must "
1281 "be equal to the product of sampleCount (=%" PRIu32
1282 "), the fragment width for shadingRate "
1283 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1284 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001285 }
1286
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001287 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001288 skip |= LogError(
1289 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001290 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1291 ") must "
1292 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001293 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001294 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001295
1296 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001297 // the first width*height*sampleCount bits to all be set. Note: There is no
1298 // guarantee that 64 bits is enough, but practically it's unlikely for an
1299 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001300 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001301 uint64_t sampleLocationsMask = 0;
1302 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1303 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1304 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001305 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1306 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001307 }
1308 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001309 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1310 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001311 }
1312 if (sampleLoc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001313 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1314 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001315 }
1316 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1317 sampleLocationsMask |= 1ULL << idx;
1318 }
1319
1320 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1321 if (sampleLocationsMask != expectedMask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001322 skip |= LogError(
1323 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001324 "The array pSampleLocations must contain exactly one entry for "
1325 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001326 }
1327
1328 return skip;
1329}
1330
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001331bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1332 uint32_t createInfoCount,
1333 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1334 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001335 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001336 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001337
1338 if (pCreateInfos != nullptr) {
1339 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001340 bool has_dynamic_viewport = false;
1341 bool has_dynamic_scissor = false;
1342 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001343 bool has_dynamic_depth_bias = false;
1344 bool has_dynamic_blend_constant = false;
1345 bool has_dynamic_depth_bounds = false;
1346 bool has_dynamic_stencil_compare = false;
1347 bool has_dynamic_stencil_write = false;
1348 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001349 bool has_dynamic_viewport_w_scaling_nv = false;
1350 bool has_dynamic_discard_rectangle_ext = false;
1351 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001352 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001353 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001354 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001355 bool has_dynamic_line_stipple = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001356 if (pCreateInfos[i].pDynamicState != nullptr) {
1357 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1358 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1359 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001360 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1361 if (has_dynamic_viewport == true) {
1362 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1363 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1364 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1365 i);
1366 }
1367 has_dynamic_viewport = true;
1368 }
1369 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1370 if (has_dynamic_scissor == true) {
1371 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1372 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1373 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1374 i);
1375 }
1376 has_dynamic_scissor = true;
1377 }
1378 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1379 if (has_dynamic_line_width == true) {
1380 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1381 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1382 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1383 i);
1384 }
1385 has_dynamic_line_width = true;
1386 }
1387 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1388 if (has_dynamic_depth_bias == true) {
1389 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1390 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1391 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1392 i);
1393 }
1394 has_dynamic_depth_bias = true;
1395 }
1396 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1397 if (has_dynamic_blend_constant == true) {
1398 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1399 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1400 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1401 i);
1402 }
1403 has_dynamic_blend_constant = true;
1404 }
1405 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1406 if (has_dynamic_depth_bounds == true) {
1407 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1408 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1409 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1410 i);
1411 }
1412 has_dynamic_depth_bounds = true;
1413 }
1414 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1415 if (has_dynamic_stencil_compare == true) {
1416 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1417 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1418 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1419 i);
1420 }
1421 has_dynamic_stencil_compare = true;
1422 }
1423 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1424 if (has_dynamic_stencil_write == true) {
1425 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1426 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1427 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1428 i);
1429 }
1430 has_dynamic_stencil_write = true;
1431 }
1432 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1433 if (has_dynamic_stencil_reference == true) {
1434 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1435 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1436 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1437 i);
1438 }
1439 has_dynamic_stencil_reference = true;
1440 }
1441 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1442 if (has_dynamic_viewport_w_scaling_nv == true) {
1443 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1444 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1445 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1446 i);
1447 }
1448 has_dynamic_viewport_w_scaling_nv = true;
1449 }
1450 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1451 if (has_dynamic_discard_rectangle_ext == true) {
1452 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1453 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1454 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1455 i);
1456 }
1457 has_dynamic_discard_rectangle_ext = true;
1458 }
1459 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1460 if (has_dynamic_sample_locations_ext == true) {
1461 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1462 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1463 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1464 i);
1465 }
1466 has_dynamic_sample_locations_ext = true;
1467 }
1468 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1469 if (has_dynamic_exclusive_scissor_nv == true) {
1470 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1471 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1472 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1473 i);
1474 }
1475 has_dynamic_exclusive_scissor_nv = true;
1476 }
1477 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1478 if (has_dynamic_shading_rate_palette_nv == true) {
1479 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1480 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1481 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1482 i);
1483 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001484 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001485 }
1486 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1487 if (has_dynamic_viewport_course_sample_order_nv == true) {
1488 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1489 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1490 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1491 i);
1492 }
1493 has_dynamic_viewport_course_sample_order_nv = true;
1494 }
1495 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1496 if (has_dynamic_line_stipple == true) {
1497 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1498 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1499 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1500 i);
1501 }
1502 has_dynamic_line_stipple = true;
1503 }
Petr Kraus299ba622017-11-24 03:09:03 +01001504 }
1505 }
1506
Peter Chen85366392019-05-14 15:20:11 -04001507 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
1508 if ((feedback_struct != nullptr) &&
1509 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001510 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1511 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1512 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1513 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1514 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001515 }
1516
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001517 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001518
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001519 // Collect active stages and other information
1520 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001521 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001522 bool has_eval = false;
1523 bool has_control = false;
1524 if (pCreateInfos[i].pStages != nullptr) {
1525 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1526 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1527
1528 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1529 has_control = true;
1530 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1531 has_eval = true;
1532 }
1533
1534 skip |= validate_string(
1535 "vkCreateGraphicsPipelines",
1536 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1537 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1538 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001539 }
1540
1541 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1542 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1543 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1544 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1545 pCreateInfos[i].pTessellationState,
1546 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1547 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1548
1549 const VkStructureType allowed_structs_VkPipelineTessellationStateCreateInfo[] = {
1550 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1551
1552 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1553 "VkPipelineTessellationDomainOriginStateCreateInfo",
1554 pCreateInfos[i].pTessellationState->pNext,
1555 ARRAY_SIZE(allowed_structs_VkPipelineTessellationStateCreateInfo),
1556 allowed_structs_VkPipelineTessellationStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001557 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1558 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001559
1560 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1561 pCreateInfos[i].pTessellationState->flags,
1562 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1563 }
1564
1565 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1566 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1567 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1568 pCreateInfos[i].pInputAssemblyState,
1569 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1570 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1571
1572 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1573 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001574 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001575
1576 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1577 pCreateInfos[i].pInputAssemblyState->flags,
1578 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1579
1580 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1581 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1582 pCreateInfos[i].pInputAssemblyState->topology,
1583 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1584
1585 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1586 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1587 }
1588
1589 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001590 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001591
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001592 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001593 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1594 "vkCreateGraphicsPipelines: pararameter "
1595 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1596 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001597 }
1598
1599 const VkStructureType allowed_structs_VkPipelineVertexInputStateCreateInfo[] = {
1600 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1601 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1602 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1603 pCreateInfos[i].pVertexInputState->pNext, 1,
1604 allowed_structs_VkPipelineVertexInputStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001605 "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
1606 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001607 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1608 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001609 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001610 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1611 skip |=
1612 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1613 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1614 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1615 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1616 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1617
1618 skip |= validate_array(
1619 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1620 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1621 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1622 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1623
1624 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
1625 for (uint32_t vertexBindingDescriptionIndex = 0;
1626 vertexBindingDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1627 ++vertexBindingDescriptionIndex) {
1628 skip |= validate_ranged_enum(
1629 "vkCreateGraphicsPipelines",
1630 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1631 AllVkVertexInputRateEnums,
1632 pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[vertexBindingDescriptionIndex].inputRate,
1633 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1634 }
1635 }
1636
1637 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
1638 for (uint32_t vertexAttributeDescriptionIndex = 0;
1639 vertexAttributeDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1640 ++vertexAttributeDescriptionIndex) {
1641 skip |= validate_ranged_enum(
1642 "vkCreateGraphicsPipelines",
1643 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1644 AllVkFormatEnums,
1645 pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[vertexAttributeDescriptionIndex].format,
1646 "VUID-VkVertexInputAttributeDescription-format-parameter");
1647 }
1648 }
1649
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001650 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001651 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1652 "vkCreateGraphicsPipelines: pararameter "
1653 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1654 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1655 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001656 }
1657
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001658 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001659 skip |=
1660 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1661 "vkCreateGraphicsPipelines: pararameter "
1662 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1663 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1664 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001665 }
1666
1667 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001668 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1669 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001670 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1671 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001672 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1673 "vkCreateGraphicsPipelines: parameter "
1674 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1675 "(%" PRIu32 ") is not distinct.",
1676 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001677 }
1678 vertex_bindings.insert(vertex_bind_desc.binding);
1679
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001680 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001681 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1682 "vkCreateGraphicsPipelines: parameter "
1683 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1684 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1685 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001686 }
1687
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001688 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001689 skip |=
1690 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1691 "vkCreateGraphicsPipelines: parameter "
1692 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1693 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1694 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001695 }
1696 }
1697
Peter Kohautc7d9d392018-07-15 00:34:07 +02001698 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001699 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1700 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001701 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1702 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001703 skip |= LogError(
1704 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001705 "vkCreateGraphicsPipelines: parameter "
1706 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1707 i, d, vertex_attrib_desc.location);
1708 }
1709 attribute_locations.insert(vertex_attrib_desc.location);
1710
1711 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1712 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001713 skip |= LogError(
1714 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001715 "vkCreateGraphicsPipelines: parameter "
1716 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1717 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1718 i, d, vertex_attrib_desc.binding, i);
1719 }
1720
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001721 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001722 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
1723 "vkCreateGraphicsPipelines: parameter "
1724 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
1725 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1726 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001727 }
1728
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001729 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001730 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
1731 "vkCreateGraphicsPipelines: parameter "
1732 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
1733 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1734 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001735 }
1736
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001737 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001738 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
1739 "vkCreateGraphicsPipelines: parameter "
1740 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1741 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1742 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001743 }
1744 }
1745 }
1746
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001747 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1748 if (has_control && has_eval) {
1749 if (pCreateInfos[i].pTessellationState == nullptr) {
1750 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
1751 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1752 "shader stage and a tessellation evaluation shader stage, "
1753 "pCreateInfos[%d].pTessellationState must not be NULL.",
1754 i, i);
1755 } else {
1756 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
1757 skip |= validate_struct_pnext(
1758 "vkCreateGraphicsPipelines",
1759 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
1760 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
1761 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
1762 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001763
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001764 skip |= validate_reserved_flags(
1765 "vkCreateGraphicsPipelines",
1766 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
1767 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001768
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001769 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1770 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
1771 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
1772 "vkCreateGraphicsPipelines: invalid parameter "
1773 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
1774 "should be >0 and <=%u.",
1775 i, pCreateInfos[i].pTessellationState->patchControlPoints,
1776 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001777 }
1778 }
1779 }
1780
1781 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1782 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1783 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1784 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001785 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
1786 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1787 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
1788 "].pViewportState (=NULL) is not a valid pointer.",
1789 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001790 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001791 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1792
1793 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001794 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
1795 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1796 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1797 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001798 }
1799
Petr Krausa6103552017-11-16 21:21:58 +01001800 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1801 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001802 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1803 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001804 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1805 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001806 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001807 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001808 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001809 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001810 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001811 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1812 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001813 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
sfricke-samsung32a27362020-02-28 09:06:42 -08001814 allowed_structs_VkPipelineViewportStateCreateInfo, 65, "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
1815 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001816
1817 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001818 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001819 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001820 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001821
Dave Houlton142c4cb2018-10-17 15:04:41 -06001822 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1823 pCreateInfos[i].pViewportState->pNext);
1824 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1825 pCreateInfos[i].pViewportState->pNext);
1826 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1827 pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01001828 const auto vp_swizzle_struct =
1829 lvl_find_in_chain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001830 const auto vp_w_scaling_struct =
1831 lvl_find_in_chain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001832
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001833 if (!physical_device_features.multiViewport) {
Petr Krausa6103552017-11-16 21:21:58 +01001834 if (viewport_state.viewportCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001835 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
1836 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1837 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
1838 ") is not 1.",
1839 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001840 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001841
Petr Krausa6103552017-11-16 21:21:58 +01001842 if (viewport_state.scissorCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001843 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
1844 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1845 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1846 ") is not 1.",
1847 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001848 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001849
Dave Houlton142c4cb2018-10-17 15:04:41 -06001850 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1851 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001852 skip |= LogError(
1853 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1854 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1855 "disabled, but pCreateInfos[%" PRIu32
1856 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1857 ") is not 1.",
1858 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001859 }
1860
Jeff Bolz9af91c52018-09-01 21:53:57 -05001861 if (shading_rate_image_struct &&
1862 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001863 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
1864 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1865 "disabled, but pCreateInfos[%" PRIu32
1866 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
1867 ") is neither 0 nor 1.",
1868 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001869 }
1870
Petr Krausa6103552017-11-16 21:21:58 +01001871 } else { // multiViewport enabled
1872 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001873 skip |= LogError(
1874 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001875 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001876 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001877 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
1878 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1879 "].pViewportState->viewportCount (=%" PRIu32
1880 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1881 i, viewport_state.viewportCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001882 }
Petr Krausa6103552017-11-16 21:21:58 +01001883
1884 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001885 skip |= LogError(
1886 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001887 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001888 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001889 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
1890 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1891 "].pViewportState->scissorCount (=%" PRIu32
1892 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1893 i, viewport_state.scissorCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001894 }
1895 }
1896
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001897 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001898 skip |=
1899 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1900 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1901 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1902 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001903 }
1904
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001905 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001906 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1907 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1908 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1909 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1910 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001911 }
1912
Petr Krausa6103552017-11-16 21:21:58 +01001913 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001914 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
1915 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1916 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
1917 "].pViewportState->viewportCount (=%" PRIu32 ").",
1918 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001919 }
1920
Dave Houlton142c4cb2018-10-17 15:04:41 -06001921 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001922 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001923 skip |=
1924 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1925 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1926 ") must be zero or identical to pCreateInfos[%" PRIu32
1927 "].pViewportState->viewportCount (=%" PRIu32 ").",
1928 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001929 }
1930
Dave Houlton142c4cb2018-10-17 15:04:41 -06001931 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001932 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001933 skip |= LogError(
1934 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001935 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1936 "] "
1937 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1938 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1939 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001940 }
1941
Petr Krausa6103552017-11-16 21:21:58 +01001942 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001943 skip |= LogError(
1944 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001945 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1946 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001947 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1948 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001949 }
1950
1951 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001952 skip |= LogError(
1953 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001954 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1955 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001956 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1957 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001958 }
1959
Jeff Bolz3e71f782018-08-29 23:15:45 -05001960 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001961 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1962 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1963 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06001964 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001965 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1966 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1967 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1968 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001969 }
1970
Jeff Bolz9af91c52018-09-01 21:53:57 -05001971 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001972 shading_rate_image_struct->viewportCount > 0 &&
1973 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001974 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06001975 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001976 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001977 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1978 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001979 i, i);
1980 }
1981
Chris Mayer328d8212018-12-11 14:16:18 +01001982 if (vp_swizzle_struct) {
1983 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001984 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
1985 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
1986 " does "
1987 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
1988 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01001989 }
1990 }
1991
Petr Krausb3fcdb42018-01-09 22:09:09 +01001992 // validate the VkViewports
1993 if (!has_dynamic_viewport && viewport_state.pViewports) {
1994 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1995 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001996 const char *fn_name = "vkCreateGraphicsPipelines";
1997 skip |= manual_PreCallValidateViewport(viewport, fn_name,
1998 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
1999 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002000 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002001 }
2002 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002003
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002004 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002005 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2006 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2007 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2008 "VK_NV_clip_space_w_scaling extension is not enabled.",
2009 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002010 }
2011
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002012 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002013 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2014 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2015 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2016 "VK_EXT_discard_rectangles extension is not enabled.",
2017 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002018 }
2019
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002020 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002021 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2022 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2023 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2024 "VK_EXT_sample_locations extension is not enabled.",
2025 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002026 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002027
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002028 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002029 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2030 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2031 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2032 "VK_NV_scissor_exclusive extension is not enabled.",
2033 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002034 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002035
2036 if (coarse_sample_order_struct &&
2037 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2038 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002039 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2040 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2041 "] "
2042 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2043 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2044 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002045 }
2046
2047 if (coarse_sample_order_struct) {
2048 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002049 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002050 }
2051 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002052
2053 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2054 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002055 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2056 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2057 "] "
2058 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2059 ") "
2060 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2061 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002062 }
2063 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002064 skip |= LogError(
2065 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002066 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2067 "] "
2068 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2069 i);
2070 }
2071 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002072 }
2073
2074 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002075 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
2076 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
2077 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
2078 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002079 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002080 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
2081 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2082 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002083 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002084 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002085 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002086 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002087 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002088 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002089 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08002090 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2091 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002092
2093 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002094 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002095 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002096 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002097
2098 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002099 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002100 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2101 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2102
2103 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002104 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002105 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2106 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002107 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002108 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002109
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002110 skip |= validate_flags(
2111 "vkCreateGraphicsPipelines",
2112 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2113 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02002114 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002115
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002116 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002117 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002118 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2119 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2120
2121 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002122 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002123 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2124 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2125
2126 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002127 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
2128 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2129 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2130 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002131 }
John Zulauf7acac592017-11-06 11:15:53 -07002132 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002133 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002134 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2135 "vkCreateGraphicsPipelines(): parameter "
2136 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2137 i);
John Zulauf7acac592017-11-06 11:15:53 -07002138 }
2139 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2140 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2141 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002142 skip |= LogError(
2143 device,
2144
Dave Houlton413a6782018-05-22 13:01:54 -06002145 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002146 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002147 }
2148 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002149
2150 const auto *line_state = lvl_find_in_chain<VkPipelineRasterizationLineStateCreateInfoEXT>(
2151 pCreateInfos[i].pRasterizationState->pNext);
2152
2153 if (line_state) {
2154 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2155 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
2156 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
2157 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002158 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2159 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2160 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
2161 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002162 }
2163 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
2164 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002165 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2166 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2167 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
2168 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002169 }
2170 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
2171 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002172 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2173 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2174 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
2175 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002176 }
2177 }
2178 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2179 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2180 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002181 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
2182 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
2183 "range [1,256].",
2184 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002185 }
2186 }
2187 const auto *line_features =
Tony-LunarG6c3c5452019-12-13 10:37:38 -07002188 lvl_find_in_chain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002189 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2190 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002191 skip |=
2192 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
2193 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2194 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2195 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002196 }
2197 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2198 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002199 skip |=
2200 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
2201 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2202 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2203 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002204 }
2205 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2206 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002207 skip |=
2208 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
2209 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2210 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
2211 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002212 }
2213 if (line_state->stippledLineEnable) {
2214 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2215 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002216 skip |=
2217 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
2218 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2219 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
2220 "stippledRectangularLines feature.",
2221 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002222 }
2223 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2224 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002225 skip |=
2226 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
2227 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2228 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
2229 "stippledBresenhamLines feature.",
2230 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002231 }
2232 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2233 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002234 skip |=
2235 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
2236 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2237 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
2238 "stippledSmoothLines feature.",
2239 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002240 }
2241 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
2242 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002243 skip |=
2244 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
2245 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2246 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
2247 "stippledRectangularLines and strictLines features.",
2248 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002249 }
2250 }
2251 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002252 }
2253
Petr Krause91f7a12017-12-14 20:57:36 +01002254 bool uses_color_attachment = false;
2255 bool uses_depthstencil_attachment = false;
2256 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002257 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002258 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
2259 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01002260 const auto &subpasses_uses = subpasses_uses_it->second;
2261 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2262 uses_color_attachment = true;
2263 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2264 uses_depthstencil_attachment = true;
2265 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002266 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01002267 }
2268
2269 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002270 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002271 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002272 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002273 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002274 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002275
2276 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002277 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002278 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002279 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002280
2281 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002282 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002283 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2284 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2285
2286 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002287 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002288 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2289 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2290
2291 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002292 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002293 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2294 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002295 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002296
2297 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002298 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002299 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2300 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2301
2302 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002303 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002304 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2305 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2306
2307 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002308 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002309 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2310 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002311 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002312
2313 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002314 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002315 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2316 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002317 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002318
2319 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002320 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002321 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2322 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002323 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002324
2325 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002326 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002327 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2328 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002329 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002330
2331 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002332 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002333 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2334 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002335 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002336
2337 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002338 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002339 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2340 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002341 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002342
2343 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002344 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002345 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2346 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002347 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002348
2349 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002350 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002351 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2352 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002353 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002354
2355 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002356 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
2357 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2358 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2359 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002360 }
2361 }
2362
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002363 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2364 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2365
Petr Krause91f7a12017-12-14 20:57:36 +01002366 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002367 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2368 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2369 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2370 pCreateInfos[i].pColorBlendState,
2371 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2372 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2373
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002374 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002375 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002376 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2377 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2378 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002379 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002380 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2381 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002382
2383 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002384 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002385 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002386 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002387
2388 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002389 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002390 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2391 pCreateInfos[i].pColorBlendState->logicOpEnable);
2392
2393 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002394 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002395 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2396 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002397 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002398 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002399
2400 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2401 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2402 ++attachmentIndex) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002403 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002404 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2405 ParameterName::IndexVector{i, attachmentIndex}),
2406 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2407
2408 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002409 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002410 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2411 ParameterName::IndexVector{i, attachmentIndex}),
2412 "VkBlendFactor", AllVkBlendFactorEnums,
2413 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002414 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002415
2416 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002417 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002418 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2419 ParameterName::IndexVector{i, attachmentIndex}),
2420 "VkBlendFactor", AllVkBlendFactorEnums,
2421 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002422 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002423
2424 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002425 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002426 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2427 ParameterName::IndexVector{i, attachmentIndex}),
2428 "VkBlendOp", AllVkBlendOpEnums,
2429 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002430 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002431
2432 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002433 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002434 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2435 ParameterName::IndexVector{i, attachmentIndex}),
2436 "VkBlendFactor", AllVkBlendFactorEnums,
2437 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002438 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002439
2440 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002441 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002442 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2443 ParameterName::IndexVector{i, attachmentIndex}),
2444 "VkBlendFactor", AllVkBlendFactorEnums,
2445 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002446 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002447
2448 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002449 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002450 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2451 ParameterName::IndexVector{i, attachmentIndex}),
2452 "VkBlendOp", AllVkBlendOpEnums,
2453 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002454 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002455
2456 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002457 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002458 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2459 ParameterName::IndexVector{i, attachmentIndex}),
2460 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2461 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002462 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002463 }
2464 }
2465
2466 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002467 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
2468 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2469 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2470 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002471 }
2472
2473 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2474 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2475 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002476 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002477 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002478 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2479 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002480 }
2481 }
2482 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002483
Petr Kraus9752aae2017-11-24 03:05:50 +01002484 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2485 if (pCreateInfos[i].basePipelineIndex != -1) {
2486 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002487 skip |=
2488 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002489 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002490 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002491 "and pCreateInfos->basePipelineIndex is not -1.",
2492 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002493 }
2494 }
2495
Petr Kraus9752aae2017-11-24 03:05:50 +01002496 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2497 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002498 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002499 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002500 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002501 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
2502 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002503 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002504 } else {
Mike Schuchardte5c15cf2020-04-06 22:57:13 -07002505 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002506 skip |=
2507 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2508 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->basePipelineIndex (%d) must be a valid"
2509 "index into the pCreateInfos array, of size %d.",
2510 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002511 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002512 }
2513 }
2514
sfricke-samsung898cf222020-05-15 23:10:19 -07002515 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
2516 skip |= LogError(
2517 device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
2518 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->flags must not contain VK_PIPELINE_CREATE_DISPATCH_BASE",
2519 i);
2520 }
2521
Petr Kraus9752aae2017-11-24 03:05:50 +01002522 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002523 if (!device_extensions.vk_nv_fill_rectangle) {
2524 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2525 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002526 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2527 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2528 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2529 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002530 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2531 (physical_device_features.fillModeNonSolid == false)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002532 skip |= LogError(device, kVUID_PVError_DeviceFeature,
2533 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002534 "pCreateInfos[%u]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2535 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2536 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002537 }
2538 } else {
2539 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2540 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2541 (physical_device_features.fillModeNonSolid == false)) {
2542 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002543 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2544 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002545 "pCreateInfos[%u]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2546 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2547 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002548 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002549 }
Petr Kraus299ba622017-11-24 03:09:03 +01002550
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002551 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002552 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002553 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2554 "The line width state is static (pCreateInfos[%" PRIu32
2555 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2556 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2557 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2558 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002559 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002560 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002561 }
2562 }
2563
2564 return skip;
2565}
2566
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002567bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2568 uint32_t createInfoCount,
2569 const VkComputePipelineCreateInfo *pCreateInfos,
2570 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002571 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002572 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002573 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002574 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002575 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002576 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Peter Chen85366392019-05-14 15:20:11 -04002577 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
2578 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002579 skip |=
2580 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2581 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2582 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2583 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002584 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002585
2586 // Make sure compute stage is selected
2587 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002588 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2589 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2590 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002591 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002592 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002593 return skip;
2594}
2595
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002596bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002597 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002598 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002599
2600 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002601 const auto &features = physical_device_features;
2602 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002603
John Zulauf71968502017-10-26 13:51:15 -06002604 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2605 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002606 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2607 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2608 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2609 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002610 }
2611
2612 // Anistropy cannot be enabled in sampler unless enabled as a feature
2613 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002614 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2615 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2616 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002617 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002618 }
John Zulauf71968502017-10-26 13:51:15 -06002619
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002620 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2621 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002622 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2623 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2624 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2625 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002626 }
2627 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002628 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2629 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2630 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2631 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002632 }
2633 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002634 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2635 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2636 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2637 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002638 }
2639 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2640 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2641 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2642 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002643 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2644 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2645 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2646 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2647 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2648 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002649 }
2650 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002651 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2652 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2653 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002654 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002655 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002656 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2657 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2658 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002659 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002660 }
2661
2662 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2663 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002664 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2665 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
sfricke-samsung85252fb2020-05-08 20:44:06 -07002666 const auto *sampler_reduction = lvl_find_in_chain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
2667 if (sampler_reduction != nullptr) {
2668 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
2669 skip |= LogError(
2670 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
2671 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
2672 }
2673 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002674 }
2675
2676 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2677 // valid VkBorderColor value
2678 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2679 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2680 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002681 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
2682 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002683 }
2684
2685 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2686 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002687 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002688 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2689 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2690 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002691 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002692 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
2693 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2694 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002695 }
John Zulauf275805c2017-10-26 15:34:49 -06002696
2697 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002698 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06002699 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2700 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002701 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
2702 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
2703 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002704 }
2705 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002706
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002707 // Check for valid Lod range
2708 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002709 skip |=
2710 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
2711 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002712 }
2713
2714 // Check mipLodBias to device limit
2715 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002716 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
2717 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
2718 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002719 }
2720
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002721 const auto *sampler_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
2722 if (sampler_conversion != nullptr) {
2723 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2724 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2725 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2726 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002727 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002728 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002729 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
2730 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
2731 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
2732 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
2733 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
2734 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
2735 }
2736 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02002737
2738 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
2739 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2740 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
2741 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2742 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2743 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2744 }
2745 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2746 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
2747 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2748 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2749 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2750 }
2751 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
2752 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
2753 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2754 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
2755 pCreateInfo->minLod, pCreateInfo->maxLod);
2756 }
2757 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
2758 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
2759 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
2760 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
2761 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
2762 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2763 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
2764 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
2765 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2766 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2767 }
2768 if (pCreateInfo->anisotropyEnable) {
2769 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
2770 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2771 "pCreateInfo->anisotropyEnable must be VK_FALSE");
2772 }
2773 if (pCreateInfo->compareEnable) {
2774 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
2775 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2776 "pCreateInfo->compareEnable must be VK_FALSE");
2777 }
2778 if (pCreateInfo->unnormalizedCoordinates) {
2779 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
2780 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2781 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
2782 }
2783 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002784 }
2785
Tony-LunarG7337b312020-04-15 16:40:25 -06002786 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
2787 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
2788 if (!device_extensions.vk_ext_custom_border_color) {
2789 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2790 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
2791 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
2792 }
2793 auto custom_create_info = lvl_find_in_chain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
2794 if (!custom_create_info) {
2795 skip |=
2796 LogError(device, "VUID-VkSamplerCreateInfo-borderColor-04011",
2797 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
2798 "struct in pNext chain.\n",
2799 string_VkBorderColor(pCreateInfo->borderColor));
2800 } else {
2801 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
2802 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT && !FormatIsSampledInt(custom_create_info->format)) ||
2803 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
2804 !FormatIsSampledFloat(custom_create_info->format)))) {
2805 skip |= LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
2806 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
2807 "whose type does not match\n",
2808 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
2809 ;
2810 }
2811 }
2812 }
2813
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002814 return skip;
2815}
2816
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002817bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
2818 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2819 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002820 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002821 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002822
2823 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2824 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2825 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2826 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002827 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2828 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2829 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2830 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2831 ++descriptor_index) {
2832 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07002833 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002834 "vkCreateDescriptorSetLayout: required parameter "
2835 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
2836 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002837 }
2838 }
2839 }
2840
2841 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2842 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2843 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002844 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
2845 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2846 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
2847 "values.",
2848 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002849 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07002850
2851 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
2852 (pCreateInfo->pBindings[i].stageFlags != 0) &&
2853 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
2854 skip |=
2855 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
2856 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
2857 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
2858 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
2859 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
2860 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002861 }
2862 }
2863 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002864 return skip;
2865}
2866
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002867bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
2868 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002869 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002870 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2871 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2872 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002873 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
2874 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002875}
2876
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002877bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
2878 const VkWriteDescriptorSet *pDescriptorWrites,
2879 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002880 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002881
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002882 if (pDescriptorWrites != NULL) {
2883 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2884 // descriptorCount must be greater than 0
2885 if (pDescriptorWrites[i].descriptorCount == 0) {
2886 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002887 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
2888 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002889 }
2890
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002891 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
2892 if (validateDstSet) {
2893 // dstSet must be a valid VkDescriptorSet handle
2894 skip |= validate_required_handle(vkCallingFunction,
2895 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2896 pDescriptorWrites[i].dstSet);
2897 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002898
2899 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2900 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2901 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2902 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2903 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2904 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2905 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
Jeff Bolz165818a2020-05-08 11:19:03 -05002906 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures.
2907 // Valid imageView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002908 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002909 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
2910 "%s(): if pDescriptorWrites[%d].descriptorType is "
2911 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2912 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
2913 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2914 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002915 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2916 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05002917 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
2918 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002919 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2920 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002921 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002922 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2923 ParameterName::IndexVector{i, descriptor_index}),
2924 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002925 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002926 }
2927 }
2928 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2929 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2930 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2931 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2932 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2933 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2934 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05002935 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002936 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002937 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
2938 "%s(): if pDescriptorWrites[%d].descriptorType is "
2939 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2940 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
2941 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2942 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002943 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05002944 const auto *robustness2_features =
2945 lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
2946 if (robustness2_features && robustness2_features->nullDescriptor) {
2947 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount;
2948 ++descriptorIndex) {
2949 if (pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer == VK_NULL_HANDLE &&
2950 (pDescriptorWrites[i].pBufferInfo[descriptorIndex].offset != 0 ||
2951 pDescriptorWrites[i].pBufferInfo[descriptorIndex].range != VK_WHOLE_SIZE)) {
2952 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
2953 "%s(): if pDescriptorWrites[%d].buffer is VK_NULL_HANDLE, "
2954 "offset (" PRIu64 ") must be zero and range (" PRIu64 ") must be VK_WHOLE_SIZE.",
2955 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptorIndex].offset,
2956 pDescriptorWrites[i].pBufferInfo[descriptorIndex].range);
2957 }
2958 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002959 }
2960 }
2961 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2962 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05002963 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002964 }
2965
2966 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2967 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002968 VkDeviceSize uniformAlignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002969 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2970 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2971 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002972 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002973 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
2974 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2975 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2976 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002977 }
2978 }
2979 }
2980 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2981 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002982 VkDeviceSize storageAlignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002983 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2984 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2985 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002986 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002987 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
2988 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2989 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2990 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002991 }
2992 }
2993 }
2994 }
sourav parmara96ab1a2020-04-25 16:28:23 -07002995 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
2996 // or VkWriteDescriptorSetInlineUniformBlockEX
2997 if (pDescriptorWrites[i].pNext) {
2998 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06002999 const auto *pnext_struct =
sourav parmara96ab1a2020-04-25 16:28:23 -07003000 lvl_find_in_chain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003001 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003002 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
3003 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
3004 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
3005 "accelerationStructureCount %d member equals descriptorCount %d.",
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003006 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
sourav parmara96ab1a2020-04-25 16:28:23 -07003007 pDescriptorWrites[i].descriptorCount);
3008 }
3009 // further checks only if we have right structtype
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003010 if (pnext_struct) {
3011 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003012 skip |= LogError(
3013 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
3014 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3015 ".",
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003016 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07003017 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003018 if (pnext_struct->accelerationStructureCount == 0) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003019 skip |= LogError(
3020 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
3021 "%s(): accelerationStructureCount must be greater than 0 .");
3022 }
3023 }
3024 }
3025 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003026 }
3027 }
3028 return skip;
3029}
3030
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003031bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
3032 const VkWriteDescriptorSet *pDescriptorWrites,
3033 uint32_t descriptorCopyCount,
3034 const VkCopyDescriptorSet *pDescriptorCopies) const {
3035 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
3036}
3037
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003038bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003039 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003040 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003041 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
3042}
3043
3044bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003045 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003046 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003047 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3048}
3049
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003050bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
3051 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003052 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003053 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003054
3055 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3056 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3057 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003058 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
3059 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003060 return skip;
3061}
3062
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003063bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003064 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003065 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02003066
3067 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
3068 const char *cmd_name = "vkBeginCommandBuffer";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003069 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
3070
Petr Krause7bb9e82019-08-11 21:34:43 +02003071 // Implicit VUs
3072 // validate only sType here; pointer has to be validated in core_validation
3073 const bool kNotRequired = false;
3074 const char *kNoVUID = nullptr;
3075 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
3076 pInfo, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, kNotRequired, kNoVUID,
3077 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003078
Petr Krause7bb9e82019-08-11 21:34:43 +02003079 if (pInfo) {
3080 const VkStructureType allowed_structs_VkCommandBufferInheritanceInfo[] = {
3081 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
3082 skip |= validate_struct_pnext(
3083 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT", pInfo->pNext,
3084 ARRAY_SIZE(allowed_structs_VkCommandBufferInheritanceInfo), allowed_structs_VkCommandBufferInheritanceInfo,
sfricke-samsung32a27362020-02-28 09:06:42 -08003085 GeneratedVulkanHeaderVersion, "VUID-VkCommandBufferInheritanceInfo-pNext-pNext",
3086 "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003087
Petr Krause7bb9e82019-08-11 21:34:43 +02003088 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", pInfo->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003089
Petr Krause7bb9e82019-08-11 21:34:43 +02003090 // Explicit VUs
3091 if (!physical_device_features.inheritedQueries && pInfo->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003092 skip |= LogError(
3093 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Petr Krause7bb9e82019-08-11 21:34:43 +02003094 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
3095 cmd_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003096 }
Petr Krause7bb9e82019-08-11 21:34:43 +02003097
3098 if (physical_device_features.inheritedQueries) {
3099 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02003100 AllVkQueryControlFlagBits, pInfo->queryFlags, kOptionalFlags,
Dave Houlton413a6782018-05-22 13:01:54 -06003101 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Petr Krause7bb9e82019-08-11 21:34:43 +02003102 } else { // !inheritedQueries
Petr Krause7bb9e82019-08-11 21:34:43 +02003103 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", pInfo->queryFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02003104 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Petr Krause7bb9e82019-08-11 21:34:43 +02003105 }
3106
3107 if (physical_device_features.pipelineStatisticsQuery) {
Petr Krause7bb9e82019-08-11 21:34:43 +02003108 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02003109 AllVkQueryPipelineStatisticFlagBits, pInfo->pipelineStatistics, kOptionalFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02003110 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
Petr Krause7bb9e82019-08-11 21:34:43 +02003111 } else { // !pipelineStatisticsQuery
3112 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", pInfo->pipelineStatistics,
3113 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003114 }
Petr Kraus139757b2019-08-15 17:19:33 +02003115
3116 const auto *conditional_rendering = lvl_find_in_chain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(pInfo->pNext);
3117 if (conditional_rendering) {
Tony-LunarG6c3c5452019-12-13 10:37:38 -07003118 const auto *cr_features = lvl_find_in_chain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Petr Kraus139757b2019-08-15 17:19:33 +02003119 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
3120 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003121 skip |= LogError(
3122 commandBuffer, "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Petr Kraus139757b2019-08-15 17:19:33 +02003123 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
3124 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
3125 }
3126 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003127 }
3128
3129 return skip;
3130}
3131
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003132bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003133 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003134 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003135
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003136 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01003137 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003138 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
3139 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3140 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01003141 }
3142 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003143 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
3144 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3145 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01003146 }
3147 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01003148 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003149 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003150 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
3151 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3152 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3153 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003154 }
3155 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01003156
3157 if (pViewports) {
3158 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
3159 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06003160 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003161 skip |= manual_PreCallValidateViewport(
3162 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01003163 }
3164 }
3165
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003166 return skip;
3167}
3168
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003169bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003170 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003171 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003172
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003173 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003174 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003175 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
3176 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
3177 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003178 }
3179 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003180 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
3181 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
3182 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003183 }
3184 } else { // multiViewport enabled
3185 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003186 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003187 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
3188 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3189 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3190 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003191 }
3192 }
3193
Petr Kraus6260f0a2018-02-27 21:15:55 +01003194 if (pScissors) {
3195 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
3196 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003197
Petr Kraus6260f0a2018-02-27 21:15:55 +01003198 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003199 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3200 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3201 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003202 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003203
Petr Kraus6260f0a2018-02-27 21:15:55 +01003204 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003205 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3206 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3207 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003208 }
3209
3210 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3211 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003212 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
3213 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3214 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3215 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003216 }
3217
3218 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3219 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003220 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
3221 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3222 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3223 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003224 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003225 }
3226 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01003227
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003228 return skip;
3229}
3230
Jeff Bolz5c801d12019-10-09 10:38:45 -05003231bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01003232 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01003233
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003234 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003235 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
3236 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003237 }
3238
3239 return skip;
3240}
3241
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003242bool StatelessValidation::manual_PreCallValidateCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003243 uint32_t firstVertex, uint32_t firstInstance) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003244 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003245 if (vertexCount == 0) {
3246 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
3247 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003248 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003249 }
3250
3251 if (instanceCount == 0) {
3252 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
3253 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003254 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003255 }
3256 return skip;
3257}
3258
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003259bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003260 uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003261 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003262
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003263 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003264 skip |= LogError(device, kVUID_PVError_DeviceFeature,
3265 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003266 }
3267 return skip;
3268}
3269
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003270bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003271 VkDeviceSize offset, uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003272 bool skip = false;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003273 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003274 skip |=
3275 LogError(device, kVUID_PVError_DeviceFeature,
3276 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003277 }
3278 return skip;
3279}
3280
sfricke-samsungf692b972020-05-02 08:00:45 -07003281bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3282 VkDeviceSize countBufferOffset, bool khr) const {
3283 bool skip = false;
3284 const char *apiName = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
3285 if (offset & 3) {
3286 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
3287 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName, offset);
3288 }
3289
3290 if (countBufferOffset & 3) {
3291 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
3292 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName,
3293 countBufferOffset);
3294 }
3295 return skip;
3296}
3297
3298bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3299 VkDeviceSize offset, VkBuffer countBuffer,
3300 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3301 uint32_t stride) const {
3302 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
3303}
3304
3305bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3306 VkDeviceSize offset, VkBuffer countBuffer,
3307 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3308 uint32_t stride) const {
3309 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
3310}
3311
3312bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3313 VkDeviceSize countBufferOffset, bool khr) const {
3314 bool skip = false;
3315 const char *apiName = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
3316 if (offset & 3) {
3317 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
3318 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName, offset);
3319 }
3320
3321 if (countBufferOffset & 3) {
3322 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
3323 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName,
3324 countBufferOffset);
3325 }
3326 return skip;
3327}
3328
3329bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3330 VkDeviceSize offset, VkBuffer countBuffer,
3331 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3332 uint32_t stride) const {
3333 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
3334}
3335
3336bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3337 VkDeviceSize offset, VkBuffer countBuffer,
3338 VkDeviceSize countBufferOffset,
3339 uint32_t maxDrawCount, uint32_t stride) const {
3340 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
3341}
3342
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003343bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
3344 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003345 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003346 bool skip = false;
3347 for (uint32_t rect = 0; rect < rectCount; rect++) {
3348 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003349 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
3350 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003351 }
sfricke-samsung10867682020-04-25 02:20:39 -07003352 if (pRects[rect].rect.extent.width == 0) {
3353 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
3354 "CmdClearAttachments(): pRects[%d].rect.extent.width is zero.", rect);
3355 }
3356 if (pRects[rect].rect.extent.height == 0) {
3357 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
3358 "CmdClearAttachments(): pRects[%d].rect.extent.height is zero.", rect);
3359 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003360 }
3361 return skip;
3362}
3363
Andrew Fobel3abeb992020-01-20 16:33:22 -05003364bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
3365 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3366 VkImageFormatProperties2 *pImageFormatProperties,
3367 const char *apiName) const {
3368 bool skip = false;
3369
3370 if (pImageFormatInfo != nullptr) {
3371 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pImageFormatInfo->pNext);
3372 if (image_stencil_struct != nullptr) {
3373 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
3374 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
3375 // No flags other than the legal attachment bits may be set
3376 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
3377 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003378 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
3379 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
3380 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
3381 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
3382 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003383 }
3384 }
3385 }
3386 }
3387
3388 return skip;
3389}
3390
3391bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
3392 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3393 VkImageFormatProperties2 *pImageFormatProperties) const {
3394 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3395 "vkGetPhysicalDeviceImageFormatProperties2");
3396}
3397
3398bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
3399 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3400 VkImageFormatProperties2 *pImageFormatProperties) const {
3401 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3402 "vkGetPhysicalDeviceImageFormatProperties2KHR");
3403}
3404
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003405bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage,
3406 VkImageLayout srcImageLayout, VkImage dstImage,
3407 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003408 const VkImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003409 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003410
Dave Houltonf5217612018-02-02 16:18:52 -07003411 VkImageAspectFlags legal_aspect_flags =
3412 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003413 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07003414 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3415 }
3416
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003417 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003418 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003419 skip |= LogError(
3420 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003421 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003422 }
Dave Houltonf5217612018-02-02 16:18:52 -07003423 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003424 skip |= LogError(
3425 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003426 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003427 }
3428 }
3429 return skip;
3430}
3431
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003432bool StatelessValidation::manual_PreCallValidateCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage,
3433 VkImageLayout srcImageLayout, VkImage dstImage,
3434 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003435 const VkImageBlit *pRegions, VkFilter filter) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003436 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003437
Dave Houltonf5217612018-02-02 16:18:52 -07003438 VkImageAspectFlags legal_aspect_flags =
3439 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003440 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07003441 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3442 }
3443
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003444 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003445 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003446 skip |= LogError(
3447 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003448 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
3449 }
Dave Houltonf5217612018-02-02 16:18:52 -07003450 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003451 skip |= LogError(
3452 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003453 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
3454 }
3455 }
3456 return skip;
3457}
3458
sfricke-samsung3999ef62020-02-09 17:05:59 -08003459bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
3460 uint32_t regionCount, const VkBufferCopy *pRegions) const {
3461 bool skip = false;
3462
3463 if (pRegions != nullptr) {
3464 for (uint32_t i = 0; i < regionCount; i++) {
3465 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003466 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
3467 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08003468 }
3469 }
3470 }
3471 return skip;
3472}
3473
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003474bool StatelessValidation::manual_PreCallValidateCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer,
3475 VkImage dstImage, VkImageLayout dstImageLayout,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003476 uint32_t regionCount,
3477 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003478 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003479
Dave Houltonf5217612018-02-02 16:18:52 -07003480 VkImageAspectFlags legal_aspect_flags =
3481 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003482 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07003483 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3484 }
3485
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003486 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003487 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003488 skip |= LogError(device, kVUID_PVError_UnrecognizedValue,
3489 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
3490 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003491 }
3492 }
3493 return skip;
3494}
3495
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003496bool StatelessValidation::manual_PreCallValidateCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage,
3497 VkImageLayout srcImageLayout, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003498 uint32_t regionCount,
3499 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003500 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003501
Dave Houltonf5217612018-02-02 16:18:52 -07003502 VkImageAspectFlags legal_aspect_flags =
3503 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003504 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07003505 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3506 }
3507
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003508 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003509 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Petr Kraus3e6cd032020-04-14 20:41:16 +02003510 skip |= LogError(
3511 device, kVUID_PVError_UnrecognizedValue,
3512 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
3513 "enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003514 }
3515 }
3516 return skip;
3517}
3518
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003519bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003520 VkDeviceSize dstOffset, VkDeviceSize dataSize,
3521 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003522 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003523
3524 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003525 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
3526 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3527 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003528 }
3529
3530 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003531 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3532 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3533 "), must be greater than zero and less than or equal to 65536.",
3534 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003535 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003536 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3537 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3538 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003539 }
3540 return skip;
3541}
3542
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003543bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003544 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003545 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003546
3547 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003548 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3549 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3550 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003551 }
3552
3553 if (size != VK_WHOLE_SIZE) {
3554 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003555 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003556 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3557 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003558 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003559 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3560 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003561 }
3562 }
3563 return skip;
3564}
3565
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003566bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003567 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003568 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003569 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003570
3571 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003572 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3573 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3574 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3575 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003576 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3577 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3578 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003579 }
3580
3581 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3582 // queueFamilyIndexCount uint32_t values
3583 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003584 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3585 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3586 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3587 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003588 }
3589 }
3590
Dave Houlton413a6782018-05-22 13:01:54 -06003591 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003592 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003593 }
3594
3595 return skip;
3596}
3597
Jeff Bolz5c801d12019-10-09 10:38:45 -05003598bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003599 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003600
3601 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003602 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3603 if (present_regions) {
3604 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003605 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003606 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3607 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003608 skip |= LogError(device, kVUID_PVError_InvalidUsage,
3609 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3610 "extension swapchainCount is %i. These values must be equal.",
3611 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003612 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003613 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003614 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3615 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003616 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3617 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3618 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003619 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003620 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003621 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003622 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003623 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003624 }
3625 }
3626
3627 return skip;
3628}
3629
3630#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003631bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3632 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3633 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003634 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003635 bool skip = false;
3636
3637 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003638 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3639 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003640 }
3641
3642 return skip;
3643}
3644#endif // VK_USE_PLATFORM_WIN32_KHR
3645
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003646bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003647 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003648 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003649 bool skip = false;
3650
3651 if (pCreateInfo) {
3652 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003653 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3654 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003655 }
3656
3657 if (pCreateInfo->pPoolSizes) {
3658 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3659 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003660 skip |= LogError(
3661 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003662 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003663 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003664 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3665 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003666 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3667 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3668 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3669 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3670 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003671 }
Petr Krausc8655be2017-09-27 18:56:51 +02003672 }
3673 }
3674 }
3675
3676 return skip;
3677}
3678
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003679bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003680 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003681 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003682
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003683 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003684 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003685 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
3686 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3687 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003688 }
3689
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003690 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003691 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003692 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
3693 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3694 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003695 }
3696
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003697 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003698 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003699 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
3700 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3701 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003702 }
3703
3704 return skip;
3705}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003706
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003707bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003708 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07003709 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07003710
3711 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003712 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
3713 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07003714 }
3715 return skip;
3716}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003717
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003718bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
3719 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003720 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003721 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003722
3723 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003724 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003725 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003726 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
3727 "vkCmdDispatch(): baseGroupX (%" PRIu32
3728 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3729 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003730 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003731 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
3732 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
3733 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3734 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003735 }
3736
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003737 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003738 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003739 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
3740 "vkCmdDispatch(): baseGroupY (%" PRIu32
3741 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3742 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003743 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003744 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
3745 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
3746 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3747 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003748 }
3749
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003750 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003751 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003752 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
3753 "vkCmdDispatch(): baseGroupZ (%" PRIu32
3754 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3755 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003756 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003757 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
3758 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
3759 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3760 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003761 }
3762
3763 return skip;
3764}
3765
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003766bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
3767 VkPipelineBindPoint pipelineBindPoint,
3768 VkPipelineLayout layout, uint32_t set,
3769 uint32_t descriptorWriteCount,
3770 const VkWriteDescriptorSet *pDescriptorWrites) const {
3771 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
3772}
3773
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003774bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
3775 uint32_t firstExclusiveScissor,
3776 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003777 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003778 bool skip = false;
3779
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003780 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003781 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003782 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003783 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3784 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3785 ") is not 0.",
3786 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003787 }
3788 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003789 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003790 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3791 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3792 ") is not 1.",
3793 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003794 }
3795 } else { // multiViewport enabled
3796 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003797 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003798 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3799 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3800 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3801 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003802 }
3803 }
3804
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003805 if (firstExclusiveScissor >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003806 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3807 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32
3808 ") must be less than maxViewports (=%" PRIu32 ").",
3809 firstExclusiveScissor, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003810 }
3811
3812 if (pExclusiveScissors) {
3813 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3814 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3815
3816 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003817 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3818 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3819 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003820 }
3821
3822 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003823 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3824 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3825 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003826 }
3827
3828 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3829 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003830 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3831 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3832 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3833 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003834 }
3835
3836 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3837 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003838 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3839 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3840 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3841 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003842 }
3843 }
3844 }
3845
3846 return skip;
3847}
3848
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003849bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
3850 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003851 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003852 bool skip = false;
3853 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003854 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01323",
3855 "vkCmdSetViewportWScalingNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3856 firstViewport, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003857 } else {
3858 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3859 if ((sum < 1) || (sum > device_limits.maxViewports)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003860 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
3861 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3862 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
3863 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003864 }
3865 }
3866
3867 return skip;
3868}
3869
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003870bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
3871 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003872 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003873 bool skip = false;
3874
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003875 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003876 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003877 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003878 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3879 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3880 ") is not 0.",
3881 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003882 }
3883 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003884 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003885 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3886 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3887 ") is not 1.",
3888 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003889 }
3890 }
3891
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003892 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003893 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
3894 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3895 ") must be less than maxViewports (=%" PRIu32 ").",
3896 firstViewport, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003897 }
3898
3899 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003900 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003901 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3902 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
3903 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3904 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003905 }
3906
3907 return skip;
3908}
3909
Jeff Bolz5c801d12019-10-09 10:38:45 -05003910bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
3911 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
3912 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003913 bool skip = false;
3914
Dave Houlton142c4cb2018-10-17 15:04:41 -06003915 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003916 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3917 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3918 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05003919 }
3920
3921 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003922 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003923 }
3924
3925 return skip;
3926}
3927
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003928bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003929 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003930 bool skip = false;
3931
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003932 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003933 skip |= LogError(
3934 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003935 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3936 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003937 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003938 }
3939
3940 return skip;
3941}
3942
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003943bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
3944 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003945 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003946 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06003947 static const int condition_multiples = 0b0011;
3948 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003949 skip |= LogError(
3950 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003951 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003952 }
Lockee1c22882019-06-10 16:02:54 -06003953 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003954 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3955 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3956 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3957 stride);
Lockee1c22882019-06-10 16:02:54 -06003958 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003959 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003960 skip |= LogError(
3961 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
3962 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06003963 }
3964
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003965 return skip;
3966}
3967
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003968bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
3969 VkDeviceSize offset, VkBuffer countBuffer,
3970 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003971 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003972 bool skip = false;
3973
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003974 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003975 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
3976 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3977 "), is not a multiple of 4.",
3978 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003979 }
3980
3981 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003982 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
3983 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3984 "), is not a multiple of 4.",
3985 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003986 }
3987
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003988 return skip;
3989}
3990
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003991bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003992 const VkAllocationCallbacks *pAllocator,
3993 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003994 bool skip = false;
3995
3996 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3997 if (pCreateInfo != nullptr) {
3998 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
3999 // VkQueryPipelineStatisticFlagBits values
4000 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
4001 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004002 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
4003 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
4004 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
4005 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004006 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07004007 if (pCreateInfo->queryCount == 0) {
4008 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
4009 "vkCreateQueryPool(): queryCount must be greater than zero.");
4010 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06004011 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004012 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004013}
4014
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004015bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
4016 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004017 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004018 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
4019 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004020}
4021
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004022void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004023 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4024 VkResult result) {
4025 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004026 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004027}
4028
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004029void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004030 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4031 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004032 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004033 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004034 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004035}
4036
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004037void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
4038 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004039 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07004040 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004041 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004042}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004043
4044bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004045 const VkAllocationCallbacks *pAllocator,
4046 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004047 bool skip = false;
4048
4049 if (pAllocateInfo) {
4050 auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
4051 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004052 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
4053 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004054 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004055
4056 VkMemoryAllocateFlags flags = 0;
4057 auto flags_info = lvl_find_in_chain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
4058 if (flags_info) {
4059 flags = flags_info->flags;
4060 }
4061
4062 auto opaque_alloc_info = lvl_find_in_chain<VkMemoryOpaqueCaptureAddressAllocateInfoKHR>(pAllocateInfo->pNext);
4063 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
4064 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004065 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
4066 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
4067 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004068 }
4069
4070#ifdef VK_USE_PLATFORM_WIN32_KHR
4071 auto import_memory_win32_handle = lvl_find_in_chain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
4072#endif
4073 auto import_memory_fd = lvl_find_in_chain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
4074 auto import_memory_host_pointer = lvl_find_in_chain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
4075#ifdef VK_USE_PLATFORM_ANDROID_KHR
4076 auto import_memory_ahb = lvl_find_in_chain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
4077#endif
4078
4079 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004080 skip |= LogError(
4081 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004082 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
4083 }
4084 if (
4085#ifdef VK_USE_PLATFORM_WIN32_KHR
4086 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
4087#endif
4088 (import_memory_fd && import_memory_fd->handleType) ||
4089#ifdef VK_USE_PLATFORM_ANDROID_KHR
4090 (import_memory_ahb && import_memory_ahb->buffer) ||
4091#endif
4092 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004093 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
4094 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004095 }
4096 }
4097
4098 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004099 VkBool32 capture_replay = false;
4100 VkBool32 buffer_device_address = false;
4101 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
4102 if (vulkan_12_features) {
4103 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
4104 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
4105 } else {
4106 const auto *bda_features =
4107 lvl_find_in_chain<VkPhysicalDeviceBufferDeviceAddressFeaturesKHR>(device_createinfo_pnext);
4108 if (bda_features) {
4109 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
4110 buffer_device_address = bda_features->bufferDeviceAddress;
4111 }
4112 }
4113 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004114 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
4115 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR is set, "
4116 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004117 }
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004118 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004119 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
4120 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004121 }
4122 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004123 }
4124 return skip;
4125}
Ricardo Garciaa4935972019-02-21 17:43:18 +01004126
Jason Macnak192fa0e2019-07-26 15:07:16 -07004127bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004128 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004129 bool skip = false;
4130
4131 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
4132 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
4133 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004134 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004135 } else {
4136 uint32_t vertex_component_size = 0;
4137 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
4138 vertex_component_size = 4;
4139 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
4140 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
4141 vertex_component_size = 2;
4142 }
4143 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004144 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004145 }
4146 }
4147
4148 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
4149 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004150 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004151 } else {
4152 uint32_t index_element_size = 0;
4153 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
4154 index_element_size = 4;
4155 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
4156 index_element_size = 2;
4157 }
4158 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004159 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004160 }
4161 }
4162 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
4163 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004164 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004165 }
4166 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004167 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004168 }
4169 }
4170
4171 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004172 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004173 }
4174
4175 return skip;
4176}
4177
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004178bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
4179 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004180 bool skip = false;
4181
4182 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004183 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004184 }
4185 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004186 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004187 }
4188
4189 return skip;
4190}
4191
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004192bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
4193 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004194 bool skip = false;
4195 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004196 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004197 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004198 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004199 }
4200 return skip;
4201}
4202
4203bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07004204 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004205 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004206 bool skip = false;
4207 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004208 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
4209 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
4210 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004211 }
4212 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004213 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
4214 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
4215 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004216 }
4217 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
4218 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004219 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
4220 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
4221 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07004222 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004223 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004224 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004225 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
4226 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004227 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
4228 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004229 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004230 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004231 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
4232 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
4233 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004234 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004235 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07004236 uint64_t total_triangle_count = 0;
4237 for (uint32_t i = 0; i < info.geometryCount; i++) {
4238 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07004239
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004240 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004241
Jason Macnak5c954952019-07-09 15:46:12 -07004242 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
4243 continue;
4244 }
4245 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
4246 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004247 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004248 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
4249 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
4250 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004251 }
4252 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004253 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
4254 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
4255 for (uint32_t i = 1; i < info.geometryCount; i++) {
4256 const VkGeometryNV &geometry = info.pGeometries[i];
4257 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004258 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004259 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
4260 "info.pGeometries[0].geometryType.",
4261 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07004262 }
4263 }
4264 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004265 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
4266 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
4267 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
4268 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
4269 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
4270 "or VK_GEOMETRY_TYPE_AABBS_NV.");
4271 }
4272 }
4273 skip |=
4274 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06004275 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07004276 return skip;
4277}
4278
Ricardo Garciaa4935972019-02-21 17:43:18 +01004279bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
4280 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004281 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01004282 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01004283 if (pCreateInfo) {
4284 if ((pCreateInfo->compactedSize != 0) &&
4285 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004286 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
4287 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
4288 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
4289 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004290 }
Jason Macnak5c954952019-07-09 15:46:12 -07004291
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004292 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07004293 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004294 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01004295 return skip;
4296}
Mike Schuchardt21638df2019-03-16 10:52:02 -07004297
Jeff Bolz5c801d12019-10-09 10:38:45 -05004298bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
4299 const VkAccelerationStructureInfoNV *pInfo,
4300 VkBuffer instanceData, VkDeviceSize instanceOffset,
4301 VkBool32 update, VkAccelerationStructureNV dst,
4302 VkAccelerationStructureNV src, VkBuffer scratch,
4303 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004304 bool skip = false;
4305
4306 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004307 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07004308 }
4309
4310 return skip;
4311}
4312
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004313bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
4314 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
4315 VkAccelerationStructureKHR *pAccelerationStructure) const {
4316 bool skip = false;
4317
4318 if (pCreateInfo) {
4319 for (uint32_t i = 0; i < pCreateInfo->maxGeometryCount; ++i) {
4320 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pCreateInfo->compactedSize == 0) {
4321 if (pCreateInfo->pGeometryInfos[i].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
4322 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03496",
4323 "VkAccelerationStructureCreateInfoKHR: Top-level acceleration structure "
4324 "pGeometryInfos[%d].geometryType must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
4325 i);
4326 }
4327 }
4328
4329 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR && pCreateInfo->compactedSize == 0) {
4330 if (pCreateInfo->pGeometryInfos[i].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
4331 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03497",
4332 "VkAccelerationStructureCreateInfoKHR: Bottom-level acceleration structure "
4333 "pGeometryInfos[%d].geometryType must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
4334 i);
4335 }
4336 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004337 if (pCreateInfo->pGeometryInfos[i].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
4338 if (!(pCreateInfo->pGeometryInfos[i].indexType == VK_INDEX_TYPE_UINT16 ||
4339 pCreateInfo->pGeometryInfos[i].indexType == VK_INDEX_TYPE_UINT32 ||
4340 pCreateInfo->pGeometryInfos[i].indexType == VK_INDEX_TYPE_NONE_KHR)) {
4341 skip |= LogError(
4342 device, "VUID-VkAccelerationStructureCreateGeometryTypeInfoKHR-geometryType-03502",
4343 "VkAccelerationStructureCreateInfoKHR: If geometryType is VK_GEOMETRY_TYPE_TRIANGLES_KHR, indexType"
4344 "must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR.");
4345 }
4346 }
4347 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR) {
4348 if (pCreateInfo->pGeometryInfos[i].maxPrimitiveCount > phys_dev_ext_props.ray_tracing_propsKHR.maxInstanceCount) {
4349 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03492",
4350 "VkAccelerationStructureCreateInfoKHR: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR"
4351 "then pGeometryInfos->maxPrimitiveCount %d must be less than or equal to "
4352 "VkPhysicalDeviceRayTracingPropertiesKHR::maxInstanceCount %d.",
4353 pCreateInfo->pGeometryInfos[i].maxPrimitiveCount,
4354 phys_dev_ext_props.ray_tracing_propsKHR.maxInstanceCount);
4355 }
4356 }
4357 }
4358
4359 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pCreateInfo->compactedSize == 0 &&
4360 pCreateInfo->maxGeometryCount != 1) {
4361 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03495",
4362 "VkAccelerationStructureCreateInfoKHR: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR"
4363 "and compactedSize is 0, maxGeometryCount must be 1.");
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004364 }
sourav parmard1521802020-06-07 21:49:02 -07004365 // or VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-03490
4366 if (pCreateInfo->compactedSize == 0 && pCreateInfo->maxGeometryCount == 0) {
4367 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-02993",
4368 "VkAccelerationStructureCreateInfoKHR: If compactedSize is 0 then maxGeometryCount must not be 0.");
4369 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004370
4371 if (pCreateInfo->flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
4372 pCreateInfo->flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
4373 skip |= LogError(
4374 device, "VUID-VkAccelerationStructureCreateInfoKHR-flags-03499",
4375 "VkAccelerationStructureCreateInfoKHR: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR"
4376 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.");
4377 }
4378
4379 if (pCreateInfo->compactedSize != 0 && pCreateInfo->maxGeometryCount != 0) {
4380 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-compactedSize-03490",
4381 "VkAccelerationStructureCreateInfoKHR: pCreateInfo->compactedSize nonzero (%" PRIu64
4382 ") with maxGeometryCount (%" PRIu32 ") nonzero.",
4383 pCreateInfo->compactedSize, pCreateInfo->maxGeometryCount);
4384 }
4385
4386 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && pCreateInfo->maxGeometryCount > 1) {
4387 const VkGeometryTypeKHR first_geometry_type = pCreateInfo->pGeometryInfos[0].geometryType;
4388 for (uint32_t i = 1; i < pCreateInfo->maxGeometryCount; i++) {
4389 const VkGeometryTypeKHR geometry_type = pCreateInfo->pGeometryInfos[i].geometryType;
4390 if (geometry_type != first_geometry_type) {
4391 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03498",
4392 "VkAccelerationStructureCreateInfoKHR: pGeometryInfos[%d].geometryType does not match "
4393 "pGeometryInfos[0].geometryType.",
4394 i);
4395 }
4396 }
4397 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004398 if (pCreateInfo->type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
4399 (pCreateInfo->maxGeometryCount > phys_dev_ext_props.ray_tracing_propsKHR.maxGeometryCount)) {
4400 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-type-03491",
4401 "VkAccelerationStructureCreateInfoKHR: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR"
4402 "then maxGeometryCount %d must be less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR "
4403 "maxGeometryCount %d.",
4404 pCreateInfo->maxGeometryCount, phys_dev_ext_props.ray_tracing_propsKHR.maxGeometryCount);
4405 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004406 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004407 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
4408 if (!raytracing_features || raytracing_features->rayTracingAccelerationStructureCaptureReplay == VK_FALSE) {
4409 if (pCreateInfo->deviceAddress != 0) {
4410 skip |=
4411 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03500",
4412 "VkAccelerationStructureCreateInfoKHR: If deviceAddress is not 0, "
4413 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingAccelerationStructureCaptureReplay must be VK_TRUE.");
4414 }
4415 }
sourav parmar83c31b12020-05-06 12:30:54 -07004416 if (!raytracing_features || !(raytracing_features->rayQuery == VK_TRUE || raytracing_features->rayTracing == VK_TRUE)) {
4417 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-rayTracing-03487",
4418 "vkCreateAccelerationStructureKHR: The rayTracing or rayQuery feature must be enabled.");
4419 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004420 return skip;
4421}
4422
Jason Macnak5c954952019-07-09 15:46:12 -07004423bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
4424 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004425 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004426 bool skip = false;
4427 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004428 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
4429 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07004430 }
4431 return skip;
4432}
4433
Peter Chen85366392019-05-14 15:20:11 -04004434bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
4435 uint32_t createInfoCount,
4436 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
4437 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004438 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04004439 bool skip = false;
4440
4441 for (uint32_t i = 0; i < createInfoCount; i++) {
4442 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
4443 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
sourav parmar83c31b12020-05-06 12:30:54 -07004444 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004445 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
4446 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4447 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
4448 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04004449 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004450
4451 const auto *pipeline_cache_contol_features =
4452 lvl_find_in_chain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
4453 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4454 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4455 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4456 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
4457 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
4458 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4459 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4460 }
4461 }
4462
sourav parmarf4a78252020-04-10 13:04:21 -07004463 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4464 skip |=
4465 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
4466 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4467 }
4468 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
4469 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
4470 skip |=
4471 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
4472 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
4473 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
4474 }
4475 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4476 if (pCreateInfos[i].basePipelineIndex != -1) {
4477 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4478 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
4479 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
4480 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4481 "and pCreateInfos->basePipelineIndex is not -1.");
4482 }
sourav parmara24fb7b2020-05-26 10:50:04 -07004483 if (pCreateInfos[i].basePipelineIndex > (int32_t)(i)) {
4484 skip |=
4485 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
4486 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
4487 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
4488 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
4489 "that element.");
4490 }
sourav parmarf4a78252020-04-10 13:04:21 -07004491 }
4492 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
4493 if (static_cast<const uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
4494 skip |=
4495 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
4496 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4497 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
4498 "commands pCreateInfos parameter.");
4499 }
4500 } else {
4501 if (pCreateInfos[i].basePipelineIndex != -1) {
4502 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
4503 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4504 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4505 }
4506 }
4507 }
4508 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4509 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
4510 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
4511 }
4512 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
4513 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
4514 "vkCreateRayTracingPipelinesNV: flags must not include "
4515 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
4516 }
4517 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
4518 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
4519 "vkCreateRayTracingPipelinesNV: flags must not include "
4520 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
4521 }
4522 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
4523 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
4524 "vkCreateRayTracingPipelinesNV: flags must not include "
4525 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
4526 }
4527 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
4528 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
4529 "vkCreateRayTracingPipelinesNV: flags must not include "
4530 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
4531 }
4532 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4533 skip |= LogError(
4534 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
4535 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4536 }
4537 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4538 skip |= LogError(
4539 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
4540 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4541 }
Peter Chen85366392019-05-14 15:20:11 -04004542 }
4543
4544 return skip;
4545}
4546
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004547bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(VkDevice device, VkPipelineCache pipelineCache,
4548 uint32_t createInfoCount,
4549 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos,
4550 const VkAllocationCallbacks *pAllocator,
4551 VkPipeline *pPipelines) const {
4552 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07004553 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
4554 if (!raytracing_features || raytracing_features->rayTracing == VK_FALSE) {
4555 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracing-03455",
4556 "vkCreateRayTracingPipelinesKHR(): The rayTracing feature must be enabled.");
4557 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004558 for (uint32_t i = 0; i < createInfoCount; i++) {
4559 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
4560 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
4561 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
4562 "vkCreateRayTracingPipelinesKHR(): in pCreateInfo[%" PRIu32
4563 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4564 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
4565 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
4566 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004567 const auto *pipeline_cache_contol_features =
4568 lvl_find_in_chain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
4569 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4570 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4571 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4572 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
4573 "vkCreateRayTracingPipelinesKHR(): If the pipelineCreationCacheControl feature is not enabled,"
4574 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4575 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4576 }
4577 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004578 if (!raytracing_features || raytracing_features->rayTracingPrimitiveCulling == VK_FALSE) {
4579 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4580 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPrimitiveCulling-03472",
4581 "vkCreateRayTracingPipelinesKHR(): If the rayTracingPrimitiveCulling feature is not enabled,"
4582 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4583 }
4584 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4585 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPrimitiveCulling-03473",
4586 "vkCreateRayTracingPipelinesKHR(): If the rayTracingPrimitiveCulling feature is not enabled,"
4587 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4588 }
4589 }
4590
sourav parmarf4a78252020-04-10 13:04:21 -07004591 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4592 skip |=
4593 LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
4594 "vkCreateRayTracingPipelinesKHR(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4595 }
4596 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4597 if (pCreateInfos[i].pLibraryInterface == NULL)
4598 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
4599 "If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, pLibraryInterface must not be NULL.");
4600 }
4601 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
4602 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
4603 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
4604 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
4605 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
4606 skip |= LogError(
4607 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
4608 "If flags includes VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
4609 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4610 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
4611 "must not be VK_SHADER_UNUSED_KHR");
4612 }
4613 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
4614 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
4615 skip |= LogError(
4616 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
4617 "If flags includes VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
4618 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4619 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
4620 "element must not be VK_SHADER_UNUSED_KHR");
4621 }
4622 }
4623 }
4624 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4625 if (pCreateInfos[i].basePipelineIndex != -1) {
4626 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4627 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
4628 "vkCreateRayTracingPipelinesKHR parameter, pCreateInfos->basePipelineHandle, must be "
4629 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4630 "and pCreateInfos->basePipelineIndex is not -1.");
4631 }
sourav parmara24fb7b2020-05-26 10:50:04 -07004632 if (pCreateInfos[i].basePipelineIndex > (int32_t)i) {
4633 skip |=
4634 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
4635 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
4636 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
4637 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
4638 "element.");
4639 }
sourav parmarf4a78252020-04-10 13:04:21 -07004640 }
4641 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
4642 if (static_cast<const uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
4643 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
4644 "vkCreateRayTracingPipelinesKHR if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4645 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%d) must be a valid into the calling"
4646 "commands pCreateInfos parameter %d.",
4647 pCreateInfos[i].basePipelineIndex, createInfoCount);
4648 }
4649 } else {
4650 if (pCreateInfos[i].basePipelineIndex != -1) {
4651 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
4652 "vkCreateRayTracingPipelinesKHR if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4653 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4654 }
4655 }
4656 }
4657 if (pCreateInfos[i].libraries.libraryCount == 0) {
4658 if (pCreateInfos[i].stageCount == 0) {
4659 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-libraries-02958",
4660 "If libraries.libraryCount is zero, then stageCount must not be zero .");
4661 }
4662 if (pCreateInfos[i].groupCount == 0) {
4663 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-libraries-02959",
4664 "If libraries.libraryCount is zero, then groupCount must not be zero .");
4665 }
4666 } else {
4667 if (pCreateInfos[i].pLibraryInterface == NULL) {
4668 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-libraryCount-03466",
4669 "If the libraryCount member of libraries is greater than 0, pLibraryInterface must not be NULL.");
4670 }
4671 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004672 }
4673
4674 return skip;
4675}
4676
Mike Schuchardt21638df2019-03-16 10:52:02 -07004677#ifdef VK_USE_PLATFORM_WIN32_KHR
4678bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
4679 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004680 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07004681 bool skip = false;
4682 if (!device_extensions.vk_khr_swapchain)
4683 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
4684 if (!device_extensions.vk_khr_get_surface_capabilities_2)
4685 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
4686 if (!device_extensions.vk_khr_surface)
4687 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
4688 if (!device_extensions.vk_khr_get_physical_device_properties_2)
4689 skip |=
4690 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
4691 if (!device_extensions.vk_ext_full_screen_exclusive)
4692 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
4693 skip |= validate_struct_type(
4694 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
4695 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
4696 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
4697 if (pSurfaceInfo != NULL) {
4698 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
4699 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
4700 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
4701
4702 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
4703 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
4704 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
4705 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08004706 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
4707 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07004708
4709 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
4710 }
4711 return skip;
4712}
4713#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01004714
4715bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
4716 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004717 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01004718 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4719 bool skip = false;
4720 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT_KHR) == 0) {
4721 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
4722 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
4723 }
4724 return skip;
4725}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004726
4727bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004728 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004729 bool skip = false;
4730
4731 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004732 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
4733 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004734 }
4735
4736 return skip;
4737}
Piers Daniell8fd03f52019-08-21 12:07:53 -06004738
4739bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004740 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06004741 bool skip = false;
4742
4743 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004744 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
4745 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06004746 }
4747
Tony-LunarG6c3c5452019-12-13 10:37:38 -07004748 const auto *index_type_uint8_features = lvl_find_in_chain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06004749 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004750 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
4751 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06004752 }
4753
4754 return skip;
4755}
Mark Lobodzinski84988402019-09-11 15:27:30 -06004756
sfricke-samsung4ada8d42020-02-09 17:43:11 -08004757bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
4758 uint32_t bindingCount, const VkBuffer *pBuffers,
4759 const VkDeviceSize *pOffsets) const {
4760 bool skip = false;
4761 if (firstBinding > device_limits.maxVertexInputBindings) {
4762 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
4763 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
4764 device_limits.maxVertexInputBindings);
4765 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
4766 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
4767 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
4768 "maxVertexInputBindings (%u)",
4769 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
4770 }
4771
Jeff Bolz165818a2020-05-08 11:19:03 -05004772 for (uint32_t i = 0; i < bindingCount; ++i) {
4773 if (pBuffers[i] == VK_NULL_HANDLE) {
4774 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
4775 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
4776 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
4777 "vkCmdBindVertexBuffers() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
4778 } else {
4779 if (pOffsets[i] != 0) {
4780 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
4781 "vkCmdBindVertexBuffers() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
4782 }
4783 }
4784 }
4785 }
4786
sfricke-samsung4ada8d42020-02-09 17:43:11 -08004787 return skip;
4788}
4789
Mark Lobodzinski84988402019-09-11 15:27:30 -06004790bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004791 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06004792 bool skip = false;
4793 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004794 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
4795 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06004796 }
4797 return skip;
4798}
4799
4800bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004801 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06004802 bool skip = false;
4803 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004804 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
4805 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06004806 }
4807 return skip;
4808}
Petr Kraus3d720392019-11-13 02:52:39 +01004809
4810bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
4811 VkSemaphore semaphore, VkFence fence,
4812 uint32_t *pImageIndex) const {
4813 bool skip = false;
4814
4815 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004816 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
4817 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01004818 }
4819
4820 return skip;
4821}
4822
4823bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
4824 uint32_t *pImageIndex) const {
4825 bool skip = false;
4826
4827 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004828 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
4829 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01004830 }
4831
4832 return skip;
4833}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07004834
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06004835bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
4836 uint32_t firstBinding, uint32_t bindingCount,
4837 const VkBuffer *pBuffers,
4838 const VkDeviceSize *pOffsets,
4839 const VkDeviceSize *pSizes) const {
4840 bool skip = false;
4841
4842 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
4843 for (uint32_t i = 0; i < bindingCount; ++i) {
4844 if (pOffsets[i] & 3) {
4845 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
4846 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
4847 }
4848 }
4849
4850 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4851 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
4852 "%s: The firstBinding(%" PRIu32
4853 ") index is greater than or equal to "
4854 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
4855 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
4856 }
4857
4858 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4859 skip |=
4860 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
4861 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
4862 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
4863 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
4864 }
4865
4866 for (uint32_t i = 0; i < bindingCount; ++i) {
4867 // pSizes is optional and may be nullptr.
4868 if (pSizes != nullptr) {
4869 if (pSizes[i] != VK_WHOLE_SIZE &&
4870 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
4871 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
4872 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
4873 ") is not VK_WHOLE_SIZE and is greater than "
4874 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
4875 cmd_name, i, pSizes[i]);
4876 }
4877 }
4878 }
4879
4880 return skip;
4881}
4882
4883bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
4884 uint32_t firstCounterBuffer,
4885 uint32_t counterBufferCount,
4886 const VkBuffer *pCounterBuffers,
4887 const VkDeviceSize *pCounterBufferOffsets) const {
4888 bool skip = false;
4889
4890 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
4891 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4892 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
4893 "%s: The firstCounterBuffer(%" PRIu32
4894 ") index is greater than or equal to "
4895 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
4896 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
4897 }
4898
4899 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4900 skip |=
4901 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
4902 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
4903 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
4904 cmd_name, firstCounterBuffer, counterBufferCount,
4905 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
4906 }
4907
4908 return skip;
4909}
4910
4911bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
4912 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
4913 const VkBuffer *pCounterBuffers,
4914 const VkDeviceSize *pCounterBufferOffsets) const {
4915 bool skip = false;
4916
4917 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
4918 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4919 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
4920 "%s: The firstCounterBuffer(%" PRIu32
4921 ") index is greater than or equal to "
4922 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
4923 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
4924 }
4925
4926 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
4927 skip |=
4928 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
4929 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
4930 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
4931 cmd_name, firstCounterBuffer, counterBufferCount,
4932 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
4933 }
4934
4935 return skip;
4936}
4937
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07004938bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
4939 uint32_t firstInstance, VkBuffer counterBuffer,
4940 VkDeviceSize counterBufferOffset,
4941 uint32_t counterOffset, uint32_t vertexStride) const {
4942 bool skip = false;
4943
4944 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004945 skip |= LogError(
4946 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07004947 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
4948 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
4949 }
4950
4951 return skip;
4952}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08004953
4954bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
4955 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
4956 const VkAllocationCallbacks *pAllocator,
4957 VkSamplerYcbcrConversion *pYcbcrConversion,
4958 const char *apiName) const {
4959 bool skip = false;
4960
4961 // Check samplerYcbcrConversion feature is set
Tony-LunarG6c3c5452019-12-13 10:37:38 -07004962 const auto *ycbcr_features = lvl_find_in_chain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08004963 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02004964 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
4965 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
4966 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
4967 "samplerYcbcrConversion must be enabled to call %s.", apiName);
4968 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08004969 }
4970 return skip;
4971}
4972
4973bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
4974 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
4975 const VkAllocationCallbacks *pAllocator,
4976 VkSamplerYcbcrConversion *pYcbcrConversion) const {
4977 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
4978 "vkCreateSamplerYcbcrConversion");
4979}
4980
4981bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
4982 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
4983 VkSamplerYcbcrConversion *pYcbcrConversion) const {
4984 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
4985 "vkCreateSamplerYcbcrConversionKHR");
4986}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08004987
4988bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
4989 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
4990 bool skip = false;
4991 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
4992 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
4993
4994 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004995 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
4996 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
4997 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
4998 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
4999 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005000 }
5001 return skip;
5002}
sourav parmara96ab1a2020-04-25 16:28:23 -07005003
5004bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
5005 VkDevice device, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5006 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005007 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5008 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5009 skip |=
5010 LogError(device, "", "VUID-vkCopyAccelerationStructureToMemoryKHR-rayTracingHostAccelerationStructureCommands-03447",
5011 "vkCopyAccelerationStructureToMemoryKHR: the "
5012 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands feature must be enabled.");
5013 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005014 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5015 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5016 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5017 }
5018 return skip;
5019}
5020
5021bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
5022 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5023 bool skip = false;
5024 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5025 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
5026 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5027 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5028 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005029 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5030 if (pnext_struct) {
sourav parmar83c31b12020-05-06 12:30:54 -07005031 skip |= LogError(
5032 commandBuffer, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pNext-03560",
5033 "vkCmdCopyAccelerationStructureToMemoryKHR: The VkDeferredOperationInfoKHR structure must not be included in the"
5034 "pNext chain of the VkCopyAccelerationStructureToMemoryInfoKHR structure.");
5035 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005036 return skip;
5037}
5038
5039bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
5040 const char *api_name) const {
5041 bool skip = false;
5042 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
5043 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
5044 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
5045 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
5046 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
5047 api_name);
5048 }
5049 return skip;
5050}
5051
5052bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
5053 VkDevice device, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5054 bool skip = false;
5055 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
sourav parmar83c31b12020-05-06 12:30:54 -07005056 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5057 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5058 skip |= LogError(
5059 device, "VUID-vkCopyAccelerationStructureKHR-rayTracingHostAccelerationStructureCommands-03441",
5060 "vkCopyAccelerationStructureKHR(): the "
5061 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands feature must be enabled .");
5062 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005063 return skip;
5064}
5065
5066bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
5067 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5068 bool skip = false;
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005069 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5070 if (pnext_struct) {
sourav parmar83c31b12020-05-06 12:30:54 -07005071 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureKHR-pNext-03557",
5072 "vkCmdCopyAccelerationStructureKHR(): The VkDeferredOperationInfoKHR structure must not be included in "
5073 "the pNext chain of the VkCopyAccelerationStructureInfoKHR structure.");
5074 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005075 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
5076 return skip;
5077}
5078
5079bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005080 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005081 bool skip = false;
5082 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
sourav parmar83c31b12020-05-06 12:30:54 -07005083 skip |= LogError(device,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005084 is_cmd ? "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-mode-03413"
Shannon McPhersonafe55122020-05-25 16:20:19 -06005085 : "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07005086 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
5087 }
5088 return skip;
5089}
5090
5091bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
5092 VkDevice device, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5093 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005094 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
5095 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5096 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5097 skip |=
5098 LogError(device, "VUID-vkCopyMemoryToAccelerationStructureKHR-rayTracingHostAccelerationStructureCommands-03444",
5099 "vkCopyMemoryToAccelerationStructureKHR() :the "
5100 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands feature must be enabled.");
5101 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005102 return skip;
5103}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005104
sourav parmara96ab1a2020-04-25 16:28:23 -07005105bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
5106 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5107 bool skip = false;
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005108 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5109 if (pnext_struct) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005110 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pNext-03564",
5111 "vkCmdCopyMemoryToAccelerationStructureKHR: The VkDeferredOperationInfoKHR structure must"
5112 "not be included in the pNext chain of the VkCopyMemoryToAccelerationStructureInfoKHR structure.");
5113 }
sourav parmar83c31b12020-05-06 12:30:54 -07005114 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
5115 return skip;
5116}
5117bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
5118 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5119 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5120 bool skip = false;
5121 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5122 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5123 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5124 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
5125 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5126 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5127 }
5128 return skip;
5129}
5130bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
5131 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5132 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
5133 bool skip = false;
5134 if (dataSize < accelerationStructureCount * stride) {
5135 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
5136 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
5137 "accelerationStructureCount (%d) *stride(%zu).",
5138 dataSize, accelerationStructureCount, stride);
5139 }
5140 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5141 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5142 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5143 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
5144 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5145 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5146 }
5147 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
5148 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5149 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
5150 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5151 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
5152 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5153 stride);
5154 }
5155 }
5156 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
5157 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5158 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
5159 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5160 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
5161 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5162 stride);
5163 }
5164 }
5165 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5166 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
5167 skip |=
5168 LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-rayTracingHostAccelerationStructureCommands-03454",
5169 "vkWriteAccelerationStructuresPropertiesKHR: the "
5170 "vkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands"
5171 "feature must be enabled ");
5172 }
5173 return skip;
5174}
5175bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
5176 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
5177 bool skip = false;
5178 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5179 if (!raytracing_features || raytracing_features->rayTracingShaderGroupHandleCaptureReplay == VK_FALSE) {
5180 skip |= LogError(device,
5181 "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingShaderGroupHandleCaptureReplay-03485",
5182 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR: "
5183 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingShaderGroupHandleCaptureReplay"
5184 "must be enabled to call this function.");
5185 }
5186 return skip;
5187}
5188
5189bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
5190 const VkStridedBufferRegionKHR *pRaygenShaderBindingTable,
5191 const VkStridedBufferRegionKHR *pMissShaderBindingTable,
5192 const VkStridedBufferRegionKHR *pHitShaderBindingTable,
5193 const VkStridedBufferRegionKHR *pCallableShaderBindingTable,
5194 uint32_t width, uint32_t height, uint32_t depth) const {
5195 bool skip = false;
5196 if (SafeModulo(pCallableShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5197 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-offset-04038",
5198 "vkCmdTraceRaysKHR: The offset member of pCallableShaderBindingTable"
5199 "must be a multiple of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5200 }
5201 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5202 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04040",
5203 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple"
5204 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5205 }
5206 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5207 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
5208 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
5209 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5210 }
5211 // hitShader
5212 if (SafeModulo(pHitShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5213 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-offset-04032",
5214 "vkCmdTraceRaysKHR: The offset member of pHitShaderBindingTable must be a multiple"
5215 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5216 }
5217 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5218 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04034",
5219 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple"
5220 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5221 }
5222 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5223 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
5224 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be"
5225 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5226 }
5227
5228 // missShader
5229 if (SafeModulo(pMissShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5230 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-offset-04026",
5231 "vkCmdTraceRaysKHR: The offset member of pMissShaderBindingTable must be a multiple"
5232 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5233 }
5234 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5235 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04028",
5236 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple"
5237 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5238 }
5239 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5240 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
5241 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
5242 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5243 }
5244
5245 // raygenShader
5246 if (SafeModulo(pRaygenShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5247 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-04021",
5248 "vkCmdTraceRaysKHR: pRayGenShaderBindingTable->offset must be a multiple"
5249 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5250 }
5251 return skip;
5252}
5253
5254bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(VkCommandBuffer commandBuffer,
5255 const VkStridedBufferRegionKHR *pRaygenShaderBindingTable,
5256 const VkStridedBufferRegionKHR *pMissShaderBindingTable,
5257 const VkStridedBufferRegionKHR *pHitShaderBindingTable,
5258 const VkStridedBufferRegionKHR *pCallableShaderBindingTable,
5259 VkBuffer buffer, VkDeviceSize offset) const {
5260 bool skip = false;
5261 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5262 if (!raytracing_features || raytracing_features->rayTracingIndirectTraceRays == VK_FALSE) {
5263 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingIndirectTraceRays-03518",
5264 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingIndirectTraceRays "
5265 "feature must be enabled.");
5266 }
5267 if (SafeModulo(pCallableShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5268 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-offset-04038",
5269 "vkCmdTraceRaysIndirectKHR: The offset member of pCallableShaderBindingTable"
5270 "must be a multiple of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5271 }
5272 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5273 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04040",
5274 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple"
5275 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5276 }
5277 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5278 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
5279 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be"
5280 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5281 }
5282 // hitShader
5283 if (SafeModulo(pHitShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5284 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-offset-04032",
5285 "vkCmdTraceRaysIndirectKHR: The offset member of pHitShaderBindingTable must be a multiple"
5286 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5287 }
5288 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5289 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04034",
5290 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple"
5291 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5292 }
5293 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5294 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
5295 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be"
5296 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5297 }
5298
5299 // missShader
5300 if (SafeModulo(pMissShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5301 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-offset-04026",
5302 "vkCmdTraceRaysIndirectKHR: The offset member of pMissShaderBindingTable must be a multiple"
5303 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5304 }
5305 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleSize) != 0) {
5306 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04028",
5307 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be a multiple"
5308 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupHandleSize.");
5309 }
5310 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5311 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
5312 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be"
5313 "less than or equal to VkPhysicalDeviceRayTracingPropertiesKHR::maxShaderGroupStride.");
5314 }
5315
5316 // raygenShader
5317 if (SafeModulo(pRaygenShaderBindingTable->offset, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5318 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-04021",
5319 "vkCmdTraceRaysIndirectKHR: pRayGenShaderBindingTable->offset must be a multiple"
5320 "of VkPhysicalDeviceRayTracingPropertiesKHR::shaderGroupBaseAlignment.");
5321 }
5322 return skip;
5323}
5324bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
5325 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
5326 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
5327 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
5328 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
5329 uint32_t width, uint32_t height, uint32_t depth) const {
5330 bool skip = false;
5331 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5332 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
5333 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
5334 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5335 }
5336 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5337 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
5338 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
5339 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5340 }
5341 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5342 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
5343 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
5344 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
5345 }
5346
5347 // hitShader
5348 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5349 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
5350 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
5351 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5352 }
5353 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5354 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
5355 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
5356 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5357 }
5358 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5359 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
5360 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
5361 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5362 }
5363
5364 // missShader
5365 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5366 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
5367 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
5368 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5369 }
5370 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5371 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
5372 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
5373 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5374 }
5375 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5376 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
5377 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
5378 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5379 }
5380
5381 // raygenShader
5382 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5383 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
5384 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07005385 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5386 }
5387 if (width > device_limits.maxComputeWorkGroupCount[0]) {
5388 skip |=
5389 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
5390 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
5391 }
5392 if (height > device_limits.maxComputeWorkGroupCount[1]) {
5393 skip |=
5394 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
5395 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
5396 }
5397 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
5398 skip |=
5399 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
5400 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07005401 }
5402 return skip;
5403}
5404
5405bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureIndirectKHR(
5406 VkCommandBuffer commandBuffer, const VkAccelerationStructureBuildGeometryInfoKHR *pInfo, VkBuffer indirectBuffer,
5407 VkDeviceSize indirectOffset, uint32_t indirectStride) const {
5408 bool skip = false;
5409 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5410 if (!raytracing_features || raytracing_features->rayTracingIndirectAccelerationStructureBuild == VK_FALSE) {
5411 skip |= LogError(
5412 device, "VUID-vkCmdBuildAccelerationStructureIndirectKHR-rayTracingIndirectAccelerationStructureBuild-03535",
5413 "vkCmdBuildAccelerationStructureIndirectKHR: The "
5414 "VkPhysicalDeviceRayTracingFeaturesKHR::rayTracingIndirectAccelerationStructureBuild feature must be enabled.");
5415 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005416 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfo->pNext);
5417 if (pnext_struct) {
sourav parmar83c31b12020-05-06 12:30:54 -07005418 skip |=
5419 LogError(device, "VUID-vkCmdBuildAccelerationStructureIndirectKHR-pNext-03536",
5420 "vkCmdBuildAccelerationStructureIndirectKHR: The VkDeferredOperationInfoKHR structure must not be included in "
5421 "the pNext chain of any of the provided VkAccelerationStructureBuildGeometryInfoKHR structures.");
5422 }
5423 return false;
5424}
5425
5426bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
5427 VkDevice device, const VkAccelerationStructureVersionKHR *version) const {
5428 bool skip = false;
5429 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5430 if (!raytracing_features || !(raytracing_features->rayQuery || raytracing_features->rayTracing)) {
5431 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracing-03565",
5432 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
5433 }
5434 return skip;
5435}
5436
5437bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructureKHR(
5438 VkDevice device, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
5439 const VkAccelerationStructureBuildOffsetInfoKHR *const *ppOffsetInfos) const {
5440 bool skip = false;
5441 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingFeaturesKHR>(device_createinfo_pnext);
5442 if (!raytracing_features || raytracing_features->rayTracingHostAccelerationStructureCommands == VK_FALSE) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005443 skip |= LogError(device, "VUID-vkBuildAccelerationStructureKHR-rayTracingHostAccelerationStructureCommands-03439",
5444 "vkBuildAccelerationStructureKHR: The "
5445 "vkPhysicalDeviceRayTracingFeaturesKHR::rayTracingHostAccelerationStructureCommands"
5446 "feature must be enabled .");
sourav parmar83c31b12020-05-06 12:30:54 -07005447 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005448 return skip;
5449}
sourav parmara24fb7b2020-05-26 10:50:04 -07005450bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureKHR(
5451 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
5452 const VkAccelerationStructureBuildOffsetInfoKHR *const *ppOffsetInfos) const {
5453 bool skip = false;
5454 for (uint32_t i = 0; i < infoCount; ++i) {
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005455 const auto *pnext_struct = lvl_find_in_chain<VkDeferredOperationInfoKHR>(pInfos->pNext);
5456 if (pnext_struct) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005457 skip |=
5458 LogError(commandBuffer, "VUID-vkCmdBuildAccelerationStructureKHR-pNext-03532",
5459 "vkCmdBuildAccelerationStructureKHR: The VkDeferredOperationInfoKHR structure must not be included in the"
5460 "pNext chain of any of the provided VkAccelerationStructureBuildGeometryInfoKHR structures.");
5461 }
5462 }
5463 return skip;
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005464}