blob: 9d7b13766653fa5e499175fde14ea6ba9b04eda1 [file] [log] [blame]
aitor-lunargd5301592022-01-05 22:38:16 +01001/* Copyright (c) 2015-2022 The Khronos Group Inc.
2 * Copyright (c) 2015-2022 Valve Corporation
3 * Copyright (c) 2015-2022 LunarG, Inc.
4 * Copyright (C) 2015-2022 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
sfricke-samsung2e827212021-09-28 07:52:08 -070027#include "core_validation_error_enums.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010028
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070029static const int kMaxParamCheckerStringLength = 256;
Mark Lobodzinskid4950072017-08-01 13:02:20 -060030
John Zulauf71968502017-10-26 13:51:15 -060031template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070032inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060033 // Using only < for generality and || for early abort
34 return !((value < min) || (max < value));
35}
36
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -060037ReadLockGuard StatelessValidation::ReadLock() { return ReadLockGuard(validation_object_mutex, std::defer_lock); }
38WriteLockGuard StatelessValidation::WriteLock() { return WriteLockGuard(validation_object_mutex, std::defer_lock); }
Mark Lobodzinski21b91fe2020-12-03 15:44:24 -070039
Jeremy Gebbencbf22862021-03-03 12:01:22 -070040static layer_data::unordered_map<VkCommandBuffer, VkCommandPool> secondary_cb_map{};
Tony-LunarG3c287f62020-12-17 12:39:49 -070041static ReadWriteLock secondary_cb_map_mutex;
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -060042static ReadLockGuard CBReadLock() { return ReadLockGuard(secondary_cb_map_mutex); }
43static WriteLockGuard CBWriteLock() { return WriteLockGuard(secondary_cb_map_mutex); }
Tony-LunarG3c287f62020-12-17 12:39:49 -070044
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070045bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050046 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 bool skip = false;
48
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070049 VkStringErrorFlags result = vk_string_validate(kMaxParamCheckerStringLength, validateString);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050
51 if (result == VK_STRING_ERROR_NONE) {
52 return skip;
53 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070054 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070055 kMaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060056 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070057 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
58 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060059 }
60 return skip;
61}
62
Jeff Bolz46c0ea02019-10-09 13:06:29 -050063bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060064 bool skip = false;
65 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
66 if (api_version_nopatch != effective_api_version) {
sfricke-samsung6aec21b2020-11-01 07:49:43 -080067 if ((api_version_nopatch < VK_API_VERSION_1_0) && (api_version != 0)) {
68 skip |= LogError(instance, "VUID-VkApplicationInfo-apiVersion-04010",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070069 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
70 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
71 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060072 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070073 skip |= LogWarning(instance, kVUIDUndefined,
74 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
75 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
76 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060077 }
78 }
79 return skip;
80}
81
Jeff Bolz46c0ea02019-10-09 13:06:29 -050082bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060083 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060084 // Create and use a local instance extension object, as an actual instance has not been created yet
85 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
86 InstanceExtensions local_instance_extensions;
87 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
88
John Zulauf620755c2018-04-16 11:00:43 -060089 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060090 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
91 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060092 }
93
94 return skip;
95}
96
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060097bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
Mike Schuchardtc57de4a2021-07-20 17:26:32 -070098 if (instance_extensions.vk_khr_get_physical_device_properties2) {
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060099 // Struct is legal IF it's supported
100 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
101 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
102 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
103 if (enum_iter != dev_exts_enumerated->second.cend()) {
104 return true;
105 }
106 }
107 return false;
108}
109
Tony-LunarG866843d2020-05-13 11:22:42 -0600110bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
111 const VkValidationFeaturesEXT *validation_features) const {
112 bool skip = false;
113 bool debug_printf = false;
114 bool gpu_assisted = false;
115 bool reserve_slot = false;
116 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
117 switch (validation_features->pEnabledValidationFeatures[i]) {
118 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
119 gpu_assisted = true;
120 break;
121
122 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
123 debug_printf = true;
124 break;
125
126 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
127 reserve_slot = true;
128 break;
129
130 default:
131 break;
132 }
133 }
134 if (reserve_slot && !gpu_assisted) {
135 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
136 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
137 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
138 }
139 if (gpu_assisted && debug_printf) {
140 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
141 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
142 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
143 }
144
145 return skip;
146}
147
John Zulauf620755c2018-04-16 11:00:43 -0600148template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700149ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
150 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600151 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700152 ExtEnabled state =
153 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600154 return state;
155}
156
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700157bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500158 const VkAllocationCallbacks *pAllocator,
159 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700160 bool skip = false;
161 // Note: From the spec--
162 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
163 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
164 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700165 ? pCreateInfo->pApplicationInfo->apiVersion
166 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700167 skip |= validate_api_version(local_api_version, api_version);
168 skip |= validate_instance_extensions(pCreateInfo);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700169 const auto *validation_features = LvlFindInChain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
Tony-LunarG866843d2020-05-13 11:22:42 -0600170 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
171
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700172 return skip;
173}
174
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700175void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700176 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
177 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700178 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
179 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700180 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700181 this->instance_extensions = instance_data->instance_extensions;
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700182}
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600183
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700184void StatelessValidation::CommonPostCallRecordEnumeratePhysicalDevice(const VkPhysicalDevice *phys_devices, const int count) {
185 // Assume phys_devices is valid
186 assert(phys_devices);
187 for (int i = 0; i < count; ++i) {
188 const auto &phys_device = phys_devices[i];
189 if (0 == physical_device_properties_map.count(phys_device)) {
190 auto phys_dev_props = new VkPhysicalDeviceProperties;
191 DispatchGetPhysicalDeviceProperties(phys_device, phys_dev_props);
192 physical_device_properties_map[phys_device] = phys_dev_props;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600193
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700194 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
195 uint32_t ext_count = 0;
Jeremy Gebbencbf22862021-03-03 12:01:22 -0700196 layer_data::unordered_set<std::string> dev_exts_enumerated{};
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700197 std::vector<VkExtensionProperties> ext_props{};
198 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, nullptr);
199 ext_props.resize(ext_count);
200 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, ext_props.data());
201 for (uint32_t j = 0; j < ext_count; j++) {
202 dev_exts_enumerated.insert(ext_props[j].extensionName);
203 }
204 device_extensions_enumerated[phys_device] = std::move(dev_exts_enumerated);
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600205 }
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700206 }
207}
208
209void StatelessValidation::PostCallRecordEnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount,
210 VkPhysicalDevice *pPhysicalDevices, VkResult result) {
211 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
212 return;
213 }
214
215 if (pPhysicalDeviceCount && pPhysicalDevices) {
216 CommonPostCallRecordEnumeratePhysicalDevice(pPhysicalDevices, *pPhysicalDeviceCount);
217 }
218}
219
220void StatelessValidation::PostCallRecordEnumeratePhysicalDeviceGroups(
221 VkInstance instance, uint32_t *pPhysicalDeviceGroupCount, VkPhysicalDeviceGroupProperties *pPhysicalDeviceGroupProperties,
222 VkResult result) {
223 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
224 return;
225 }
226
227 if (pPhysicalDeviceGroupCount && pPhysicalDeviceGroupProperties) {
228 for (uint32_t i = 0; i < *pPhysicalDeviceGroupCount; i++) {
229 const auto &group = pPhysicalDeviceGroupProperties[i];
230 CommonPostCallRecordEnumeratePhysicalDevice(group.physicalDevices, group.physicalDeviceCount);
231 }
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600232 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700233}
234
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600235void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
236 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
237 delete (it->second);
238 it = physical_device_properties_map.erase(it);
239 }
240};
241
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700242void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700243 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700244 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700245 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700246 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
247 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700248
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700249 // Parmeter validation also uses extension data
250 stateless_validation->device_extensions = this->device_extensions;
251
252 VkPhysicalDeviceProperties device_properties = {};
253 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600254 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700255 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
256
sfricke-samsung45996a42021-09-16 13:45:27 -0700257 if (IsExtEnabled(device_extensions.vk_nv_shading_rate_image)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700258 // Get the needed shading rate image limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700259 auto shading_rate_image_props = LvlInitStruct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
260 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600261 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700262 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
263 }
264
sfricke-samsung45996a42021-09-16 13:45:27 -0700265 if (IsExtEnabled(device_extensions.vk_nv_mesh_shader)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700266 // Get the needed mesh shader limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700267 auto mesh_shader_props = LvlInitStruct<VkPhysicalDeviceMeshShaderPropertiesNV>();
268 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600269 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700270 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
271 }
272
sfricke-samsung45996a42021-09-16 13:45:27 -0700273 if (IsExtEnabled(device_extensions.vk_nv_ray_tracing)) {
Jason Macnak5c954952019-07-09 15:46:12 -0700274 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700275 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPropertiesNV>();
276 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jason Macnak5c954952019-07-09 15:46:12 -0700277 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500278 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
279 }
280
sfricke-samsung45996a42021-09-16 13:45:27 -0700281 if (IsExtEnabled(device_extensions.vk_khr_ray_tracing_pipeline)) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500282 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700283 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPipelinePropertiesKHR>();
284 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500285 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
286 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700287 }
288
sfricke-samsung45996a42021-09-16 13:45:27 -0700289 if (IsExtEnabled(device_extensions.vk_khr_acceleration_structure)) {
sourav parmarcd5fb182020-07-17 12:58:44 -0700290 // Get the needed ray tracing acc structure limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700291 auto acc_structure_props = LvlInitStruct<VkPhysicalDeviceAccelerationStructurePropertiesKHR>();
292 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&acc_structure_props);
sourav parmarcd5fb182020-07-17 12:58:44 -0700293 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
294 phys_dev_ext_props.acc_structure_props = acc_structure_props;
295 }
296
sfricke-samsung45996a42021-09-16 13:45:27 -0700297 if (IsExtEnabled(device_extensions.vk_ext_transform_feedback)) {
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700298 // Get the needed transform feedback limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700299 auto transform_feedback_props = LvlInitStruct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
300 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&transform_feedback_props);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700301 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
302 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
303 }
304
sfricke-samsung45996a42021-09-16 13:45:27 -0700305 if (IsExtEnabled(device_extensions.vk_ext_vertex_attribute_divisor)) {
Piers Daniellcb6d8032021-04-19 18:51:26 -0600306 // Get the needed vertex attribute divisor limits
307 auto vertex_attribute_divisor_props = LvlInitStruct<VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT>();
308 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&vertex_attribute_divisor_props);
309 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
310 phys_dev_ext_props.vertex_attribute_divisor_props = vertex_attribute_divisor_props;
311 }
312
sfricke-samsung45996a42021-09-16 13:45:27 -0700313 if (IsExtEnabled(device_extensions.vk_ext_blend_operation_advanced)) {
Piers Daniella7f93b62021-11-20 12:32:04 -0700314 // Get the needed blend operation advanced properties
ziga-lunarga283d022021-08-04 18:35:23 +0200315 auto blend_operation_advanced_props = LvlInitStruct<VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT>();
316 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&blend_operation_advanced_props);
317 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
318 phys_dev_ext_props.blend_operation_advanced_props = blend_operation_advanced_props;
319 }
320
Piers Daniella7f93b62021-11-20 12:32:04 -0700321 if (IsExtEnabled(device_extensions.vk_khr_maintenance4)) {
322 // Get the needed maintenance4 properties
323 auto maintance4_props = LvlInitStruct<VkPhysicalDeviceMaintenance4PropertiesKHR>();
324 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&maintance4_props);
325 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
326 phys_dev_ext_props.maintenance4_props = maintance4_props;
327 }
328
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800329 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
330
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700331 // Save app-enabled features in this device's validation object
332 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700333 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200334 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
335 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
336 if (features2) {
337 tmp_features2_state.features = features2->features;
338 } else if (pCreateInfo->pEnabledFeatures) {
339 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700340 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200341 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700342 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200343 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700344 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200345 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700346}
347
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700348bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500349 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600350 bool skip = false;
351
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200352 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
353 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
354 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600355 }
356
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700357 // If this device supports VK_KHR_portability_subset, it must be enabled
358 const std::string portability_extension_name("VK_KHR_portability_subset");
359 const auto &dev_extensions = device_extensions_enumerated.at(physicalDevice);
360 const bool portability_supported = dev_extensions.count(portability_extension_name) != 0;
361 bool portability_requested = false;
362
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200363 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
364 skip |=
365 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
366 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
367 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
368 pCreateInfo->ppEnabledExtensionNames[i]);
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700369 if (portability_extension_name == pCreateInfo->ppEnabledExtensionNames[i]) {
370 portability_requested = true;
371 }
372 }
373
374 if (portability_supported && !portability_requested) {
375 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-pProperties-04451",
376 "vkCreateDevice: VK_KHR_portability_subset must be enabled because physical device %s supports it",
377 report_data->FormatHandle(physicalDevice).c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600378 }
379
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200380 {
aitor-lunargd5301592022-01-05 22:38:16 +0100381 bool maint1 = IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE_1_EXTENSION_NAME));
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700382 bool negative_viewport =
aitor-lunargd5301592022-01-05 22:38:16 +0100383 IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
384 if (negative_viewport) {
385 // Only need to check for VK_KHR_MAINTENANCE_1_EXTENSION_NAME if api version is 1.0, otherwise it's deprecated due to
386 // integration into api version 1.1
387 if (api_version >= VK_API_VERSION_1_1) {
388 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-01840",
389 "vkCreateDevice(): VkDeviceCreateInfo->ppEnabledExtensionNames must not include "
390 "VK_AMD_negative_viewport_height if api version is greater than or equal to 1.1.");
391 } else if (maint1) {
392 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
393 "vkCreateDevice(): VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include "
394 "VK_KHR_maintenance1 and VK_AMD_negative_viewport_height.");
395 }
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200396 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600397 }
398
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600399 {
ziga-lunarg9271a7c2021-07-19 16:37:06 +0200400 bool khr_bda =
401 IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
402 bool ext_bda =
403 IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600404 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700405 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
406 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
407 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600408 }
409 }
410
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600411 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
412 // Check for get_physical_device_properties2 struct
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700413 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -0600414 if (features2) {
Mike Schuchardt2df08912020-12-15 16:28:09 -0800415 // Cannot include VkPhysicalDeviceFeatures2 and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700416 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mike Schuchardt2df08912020-12-15 16:28:09 -0800417 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct when "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700418 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600419 }
420 }
421
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700422 auto features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500423 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700424 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500425 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
426 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
427 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
428 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700429 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(pCreateInfo->pNext);
sourav parmarcd5fb182020-07-17 12:58:44 -0700430 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplayMixed &&
431 !raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay) {
432 skip |= LogError(
433 device,
434 "VUID-VkPhysicalDeviceRayTracingPipelineFeaturesKHR-rayTracingPipelineShaderGroupHandleCaptureReplayMixed-03575",
435 "If rayTracingPipelineShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingPipelineShaderGroupHandleCaptureReplay "
436 "must also be VK_TRUE.");
sourav parmara24fb7b2020-05-26 10:50:04 -0700437 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700438 auto vertex_attribute_divisor_features = LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
sfricke-samsung45996a42021-09-16 13:45:27 -0700439 if (vertex_attribute_divisor_features && (!IsExtEnabled(device_extensions.vk_ext_vertex_attribute_divisor))) {
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600440 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
441 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
442 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600443 }
444
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700445 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700446 if (vulkan_11_features) {
447 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
448 while (current) {
449 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
450 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
451 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
452 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
453 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
454 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700455 skip |= LogError(
456 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700457 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
458 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
459 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
460 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
461 break;
462 }
463 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
464 }
sfricke-samsungebda6792021-01-16 08:57:52 -0800465
466 // Check features are enabled if matching extension is passed in as well
467 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
468 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
469 if ((0 == strncmp(extension, VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
470 (vulkan_11_features->shaderDrawParameters == VK_FALSE)) {
471 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800472 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-04476",
sfricke-samsungebda6792021-01-16 08:57:52 -0800473 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan11Features::shaderDrawParameters is not VK_TRUE.",
474 VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME);
475 }
476 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700477 }
478
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700479 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700480 if (vulkan_12_features) {
481 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
482 while (current) {
483 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
484 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
485 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
486 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
487 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
488 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
489 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
490 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
491 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
492 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
493 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
494 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
495 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700496 skip |= LogError(
497 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700498 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
499 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
500 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
501 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
502 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
503 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
504 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
505 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
506 break;
507 }
508 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
509 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700510 // Check features are enabled if matching extension is passed in as well
511 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
512 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
513 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
514 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
515 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800516 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02831",
sfricke-samsungabab4632020-05-04 06:51:46 -0700517 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
518 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
519 }
520 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
521 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
Mike Schuchardt9969d022021-12-20 15:51:55 -0800522 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02832",
sfricke-samsungabab4632020-05-04 06:51:46 -0700523 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
524 "is not VK_TRUE.",
525 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
526 }
527 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
528 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
529 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800530 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02833",
sfricke-samsungabab4632020-05-04 06:51:46 -0700531 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
532 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
533 }
534 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
535 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
536 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800537 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02834",
sfricke-samsungabab4632020-05-04 06:51:46 -0700538 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
539 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
540 }
541 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
542 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
543 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
544 skip |=
Mike Schuchardt9969d022021-12-20 15:51:55 -0800545 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02835",
sfricke-samsungabab4632020-05-04 06:51:46 -0700546 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
547 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
548 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
549 }
550 }
ziga-lunarg27f88fd2021-08-01 15:47:30 +0200551 if (vulkan_12_features->bufferDeviceAddress == VK_TRUE) {
552 if (IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME))) {
553 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-pNext-04748",
554 "vkCreateDevice(): pNext chain includes VkPhysicalDeviceVulkan12Features with bufferDeviceAddress "
555 "set to VK_TRUE and ppEnabledExtensionNames contains VK_EXT_buffer_device_address");
556 }
557 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700558 }
559
Tony-LunarG273f32f2021-09-28 08:56:30 -0600560 const auto *vulkan_13_features = LvlFindInChain<VkPhysicalDeviceVulkan13Features>(pCreateInfo->pNext);
561 if (vulkan_13_features) {
562 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
563 while (current) {
564 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DYNAMIC_RENDERING_FEATURES ||
565 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGE_ROBUSTNESS_FEATURES ||
566 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_INLINE_UNIFORM_BLOCK_FEATURES ||
567 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MAINTENANCE_4_FEATURES ||
568 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PIPELINE_CREATION_CACHE_CONTROL_FEATURES ||
569 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PRIVATE_DATA_FEATURES ||
570 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DEMOTE_TO_HELPER_INVOCATION_FEATURES ||
571 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_INTEGER_DOT_PRODUCT_FEATURES ||
572 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_TERMINATE_INVOCATION_FEATURES ||
573 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SUBGROUP_SIZE_CONTROL_FEATURES ||
574 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SYNCHRONIZATION_2_FEATURES ||
575 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TEXTURE_COMPRESSION_ASTC_HDR_FEATURES ||
576 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_ZERO_INITIALIZE_WORKGROUP_MEMORY_FEATURES) {
577 skip |= LogError(
578 instance, "VUID-VkDeviceCreateInfo-pNext-06532",
579 "If the pNext chain includes a VkPhysicalDeviceVulkan13Features structure, then it must not include a "
580 "VkPhysicalDeviceDynamicRenderingFeatures, VkPhysicalDeviceImageRobustnessFeatures, "
581 "VkPhysicalDeviceInlineUniformBlockFeatures, VkPhysicalDeviceMaintenance4Features, "
582 "VkPhysicalDevicePipelineCreationCacheControlFeatures, VkPhysicalDevicePrivateDataFeatures, "
583 "VkPhysicalDeviceShaderDemoteToHelperInvocationFeatures, VkPhysicalDeviceShaderIntegerDotProductFeatures, "
584 "VkPhysicalDeviceShaderTerminateInvocationFeatures, VkPhysicalDeviceSubgroupSizeControlFeatures, "
585 "VkPhysicalDeviceSynchronization2Features, VkPhysicalDeviceTextureCompressionASTCHDRFeatures, or "
586 "VkPhysicalDeviceZeroInitializeWorkgroupMemoryFeatures structure");
587 break;
588 }
589 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
590 }
591 }
592
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600593 // Validate pCreateInfo->pQueueCreateInfos
594 if (pCreateInfo->pQueueCreateInfos) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600595
596 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700597 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
598 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600599 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700600 skip |=
601 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
602 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
603 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
604 "index value.",
605 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600606 }
607
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700608 if (queue_create_info.pQueuePriorities != nullptr) {
609 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
610 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600611 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700612 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
613 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
614 "] (=%f) is not between 0 and 1 (inclusive).",
615 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600616 }
617 }
618 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700619
620 // Need to know if protectedMemory feature is passed in preCall to creating the device
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700621 VkBool32 protected_memory = VK_FALSE;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700622 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700623 LvlFindInChain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700624 if (protected_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700625 protected_memory = protected_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700626 } else if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700627 protected_memory = vulkan_11_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700628 }
Mike Schuchardta9101d32021-11-12 12:24:08 -0800629 if (((queue_create_info.flags & VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) != 0) && (protected_memory == VK_FALSE)) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700630 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
Mike Schuchardta9101d32021-11-12 12:24:08 -0800631 "vkCreateDevice: pCreateInfo->flags contains VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
632 "protectedMemory feature being enabled as well.");
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700633 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600634 }
635 }
636
sfricke-samsung30a57412020-05-15 21:14:54 -0700637 // feature dependencies for VK_KHR_variable_pointers
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700638 const auto *variable_pointers_features = LvlFindInChain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700639 VkBool32 variable_pointers = VK_FALSE;
640 VkBool32 variable_pointers_storage_buffer = VK_FALSE;
sfricke-samsung30a57412020-05-15 21:14:54 -0700641 if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700642 variable_pointers = vulkan_11_features->variablePointers;
643 variable_pointers_storage_buffer = vulkan_11_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700644 } else if (variable_pointers_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700645 variable_pointers = variable_pointers_features->variablePointers;
646 variable_pointers_storage_buffer = variable_pointers_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700647 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700648 if ((variable_pointers == VK_TRUE) && (variable_pointers_storage_buffer == VK_FALSE)) {
sfricke-samsung30a57412020-05-15 21:14:54 -0700649 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
650 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
651 }
652
sfricke-samsungfd76c342020-05-29 23:13:43 -0700653 // feature dependencies for VK_KHR_multiview
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700654 const auto *multiview_features = LvlFindInChain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
sfricke-samsungfd76c342020-05-29 23:13:43 -0700655 VkBool32 multiview = VK_FALSE;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700656 VkBool32 multiview_geometry_shader = VK_FALSE;
657 VkBool32 multiview_tessellation_shader = VK_FALSE;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700658 if (vulkan_11_features) {
659 multiview = vulkan_11_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700660 multiview_geometry_shader = vulkan_11_features->multiviewGeometryShader;
661 multiview_tessellation_shader = vulkan_11_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700662 } else if (multiview_features) {
663 multiview = multiview_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700664 multiview_geometry_shader = multiview_features->multiviewGeometryShader;
665 multiview_tessellation_shader = multiview_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700666 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700667 if ((multiview == VK_FALSE) && (multiview_geometry_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700668 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
669 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
670 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700671 if ((multiview == VK_FALSE) && (multiview_tessellation_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700672 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
673 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
674 }
675
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600676 return skip;
677}
678
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500679bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700680 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700681 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
682 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
683 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600684 }
685
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700686 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600687}
688
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700689bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500690 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100691 bool skip = false;
692
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600693 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700694 skip |=
695 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600696
697 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
698 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
699 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
700 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700701 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
702 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
703 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600704 }
705
706 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
707 // queueFamilyIndexCount uint32_t values
708 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700709 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
710 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
711 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
712 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600713 }
714 }
715
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700716 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
717 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
718 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
719 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
720 }
721
722 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
723 skip |=
724 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
725 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
726 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
727 }
728
729 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
730 skip |=
731 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
732 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
733 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
734 }
735
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600736 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
737 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
738 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
739 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700740 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
741 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
742 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600743 }
Piers Daniella7f93b62021-11-20 12:32:04 -0700744
745 const auto *maintenance4_features = LvlFindInChain<VkPhysicalDeviceMaintenance4FeaturesKHR>(device_createinfo_pnext);
746 if (maintenance4_features && maintenance4_features->maintenance4) {
747 if (pCreateInfo->size > phys_dev_ext_props.maintenance4_props.maxBufferSize) {
748 skip |= LogError(device, "VUID-VkBufferCreateInfo-size-06409",
749 "vkCreateBuffer: pCreateInfo->size is larger than the maximum allowed buffer size "
750 "VkPhysicalDeviceMaintenance4Properties.maxBufferSize");
751 }
752 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600753 }
754
755 return skip;
756}
757
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700758bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500759 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600760 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600761
762 if (pCreateInfo != nullptr) {
sfricke-samsung61a57c02021-01-10 21:35:12 -0800763 const VkFormat image_format = pCreateInfo->format;
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700764 const VkImageCreateFlags image_flags = pCreateInfo->flags;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600765 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
766 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
767 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
768 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700769 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
770 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
771 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600772 }
773
774 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
775 // queueFamilyIndexCount uint32_t values
776 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700777 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
778 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
779 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
780 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600781 }
782 }
783
Dave Houlton413a6782018-05-22 13:01:54 -0600784 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700785 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600786 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700787 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600788 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700789 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600790
Dave Houlton413a6782018-05-22 13:01:54 -0600791 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700792 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600793 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700794 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600795
Dave Houlton130c0212018-01-29 13:39:56 -0700796 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700797 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
798 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700799 skip |= LogError(
800 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600801 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
802 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700803 }
804
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600805 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100806 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
807 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700808 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
809 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
810 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600811 }
812
813 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700814 if (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
Petr Kraus3f433212018-03-13 12:31:27 +0100815 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700816 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
817 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
818 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
819 ") are not equal.",
820 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100821 }
822
823 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700824 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
825 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
826 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
827 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100828 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600829 }
830
831 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700832 skip |= LogError(
833 device, "VUID-VkImageCreateInfo-imageType-00957",
834 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600835 }
836 }
837
Dave Houlton130c0212018-01-29 13:39:56 -0700838 // 3D image may have only 1 layer
839 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700840 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
841 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700842 }
843
Dave Houlton130c0212018-01-29 13:39:56 -0700844 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
845 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
846 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
847 // At least one of the legal attachment bits must be set
848 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700849 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
850 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700851 }
852 // No flags other than the legal attachment bits may be set
853 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
854 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700855 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
856 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700857 }
858 }
859
Jeff Bolzef40fec2018-09-01 22:04:34 -0500860 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700861 uint32_t max_dim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500862 // Max mip levels is different for corner-sampled images vs normal images.
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700863 uint32_t max_mip_levels = (image_flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700864 ? static_cast<uint32_t>(ceil(log2(max_dim)))
865 : static_cast<uint32_t>(floor(log2(max_dim)) + 1);
866 if (max_dim > 0 && pCreateInfo->mipLevels > max_mip_levels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600867 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700868 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
869 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
870 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600871 }
872
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700873 if ((image_flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700874 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
875 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
876 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600877 }
878
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700879 if ((image_flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700880 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
881 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
882 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100883 }
884
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700885 if ((image_flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700886 skip |= LogError(
887 device, "VUID-VkImageCreateInfo-flags-01924",
888 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
889 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
890 }
891
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600892 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
893 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700894 if (((image_flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
895 ((image_flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700896 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
897 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
898 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600899 }
900
901 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700902 if ((image_flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600903 // Linear tiling is unsupported
904 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700905 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700906 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
907 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600908 }
909
910 // Sparse 1D image isn't valid
911 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700912 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
913 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600914 }
915
916 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700917 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700918 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
919 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
920 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600921 }
922
923 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700924 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700925 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
926 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
927 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600928 }
929
930 // Multi-sample 2D image when device doesn't support it
931 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700932 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600933 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700934 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
935 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
936 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700937 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600938 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700939 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
940 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
941 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700942 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600943 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700944 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
945 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
946 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700947 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600948 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700949 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
950 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
951 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600952 }
953 }
954 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500955
Jeff Bolz9af91c52018-09-01 21:53:57 -0500956 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
957 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700958 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
959 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
960 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500961 }
962 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700963 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
964 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
965 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500966 }
967 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700968 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
969 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
970 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500971 }
972 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500973
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700974 if (image_flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600975 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700976 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
977 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
978 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500979 }
980
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700981 if ((image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(image_format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700982 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
983 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800984 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format (%s) must not be a "
985 "depth/stencil format.",
986 string_VkFormat(image_format));
Jeff Bolzef40fec2018-09-01 22:04:34 -0500987 }
988
Dave Houlton142c4cb2018-10-17 15:04:41 -0600989 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700990 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
991 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
992 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
993 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500994 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600995 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700996 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
997 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
998 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
999 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -05001000 }
1001 }
Andrew Fobel3abeb992020-01-20 16:33:22 -05001002
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001003 if (((image_flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
sfricke-samsung61a57c02021-01-10 21:35:12 -08001004 (FormatHasDepth(image_format) == false)) {
sfricke-samsung8f658d42020-05-03 20:12:24 -07001005 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
1006 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
sfricke-samsung61a57c02021-01-10 21:35:12 -08001007 "format (%s) must be a depth or depth/stencil format.",
1008 string_VkFormat(image_format));
sfricke-samsung8f658d42020-05-03 20:12:24 -07001009 }
1010
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001011 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pCreateInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05001012 if (image_stencil_struct != nullptr) {
1013 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
1014 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1015 // No flags other than the legal attachment bits may be set
1016 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1017 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001018 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
1019 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
1020 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
1021 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -05001022 }
1023 }
1024
sfricke-samsung61a57c02021-01-10 21:35:12 -08001025 if (FormatIsDepthOrStencil(image_format)) {
Andrew Fobel3abeb992020-01-20 16:33:22 -05001026 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
1027 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001028 skip |=
1029 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
1030 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
1031 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width (%" PRIu32
1032 ") exceeds device "
1033 "maxFramebufferWidth (%" PRIu32 ")",
1034 pCreateInfo->extent.width, device_limits.maxFramebufferWidth);
Andrew Fobel3abeb992020-01-20 16:33:22 -05001035 }
1036
1037 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001038 skip |=
1039 LogError(device, "VUID-VkImageCreateInfo-format-02537",
1040 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
1041 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height (%" PRIu32
1042 ") exceeds device "
1043 "maxFramebufferHeight (%" PRIu32 ")",
1044 pCreateInfo->extent.height, device_limits.maxFramebufferHeight);
Andrew Fobel3abeb992020-01-20 16:33:22 -05001045 }
1046 }
1047
1048 if (!physical_device_features.shaderStorageImageMultisample &&
1049 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1050 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1051 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001052 LogError(device, "VUID-VkImageCreateInfo-format-02538",
1053 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
1054 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
1055 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -05001056 }
1057
1058 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
1059 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001060 skip |= LogError(
1061 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001062 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
1063 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1064 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
1065 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
1066 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001067 skip |= LogError(
1068 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001069 "vkCreateImage(): Depth-stencil image in which usage does not include "
1070 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
1071 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1072 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
1073 }
1074
1075 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
1076 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001077 skip |= LogError(
1078 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001079 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1080 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1081 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1082 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
1083 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001084 skip |= LogError(
1085 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001086 "vkCreateImage(): Depth-stencil image in which usage does not include "
1087 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1088 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1089 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1090 }
1091 }
1092 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -07001093
1094 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1095 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1096 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
1097 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
1098 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
1099 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001100
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001101 std::vector<uint64_t> image_create_drm_format_modifiers;
sfricke-samsung45996a42021-09-16 13:45:27 -07001102 if (IsExtEnabled(device_extensions.vk_ext_image_drm_format_modifier)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001103 const auto drm_format_mod_list = LvlFindInChain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
1104 const auto drm_format_mod_explict = LvlFindInChain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001105 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1106 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
1107 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
1108 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
1109 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
1110 "either VkImageDrmFormatModifierListCreateInfoEXT or "
1111 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
Martin Freebody0ec2c7a2021-03-03 16:48:00 +00001112 } else if (drm_format_mod_explict != nullptr) {
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001113 image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
1114 } else if (drm_format_mod_list != nullptr) {
1115 for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {
1116 image_create_drm_format_modifiers.push_back(*drm_format_mod_list->pDrmFormatModifiers);
1117 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001118 }
1119 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
1120 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
1121 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
1122 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
1123 "in the pNext chain");
1124 }
1125 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001126
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001127 static const uint64_t drm_format_mod_linear = 0;
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001128 bool image_create_maybe_linear = false;
1129 if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) {
1130 image_create_maybe_linear = true;
1131 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) {
1132 image_create_maybe_linear = false;
1133 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1134 image_create_maybe_linear =
1135 (std::find(image_create_drm_format_modifiers.begin(), image_create_drm_format_modifiers.end(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001136 drm_format_mod_linear) != image_create_drm_format_modifiers.end());
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001137 }
1138
1139 // If multi-sample, validate type, usage, tiling and mip levels.
1140 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001141 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001142 (pCreateInfo->mipLevels != 1) || image_create_maybe_linear)) {
1143 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
1144 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
1145 }
1146
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001147 if ((image_flags & VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT) &&
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001148 ((pCreateInfo->mipLevels != 1) || (pCreateInfo->arrayLayers != 1) || (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) ||
1149 image_create_maybe_linear)) {
1150 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02259",
1151 "vkCreateImage(): Multi-device image with incompatible type, usage, tiling, or mips.");
1152 }
1153
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001154 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
1155 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1156 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
1157 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1158 "imageType must be VK_IMAGE_TYPE_2D.");
1159 }
1160 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1161 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
1162 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1163 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1164 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001165 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001166 if (image_flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001167 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1168 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
1169 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1170 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1171 }
1172 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1173 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
1174 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1175 "imageType must be VK_IMAGE_TYPE_2D.");
1176 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001177 if (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001178 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1179 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1180 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1181 }
1182 if (pCreateInfo->mipLevels != 1) {
1183 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001184 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%" PRIu32
1185 ") must be 1.",
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001186 pCreateInfo->mipLevels);
1187 }
1188 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001189
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001190 const auto swapchain_create_info = LvlFindInChain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001191 if (swapchain_create_info != nullptr) {
1192 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1193 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1194 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1195 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1196 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1197 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1198
1199 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1200 // also implicitly forces the check above that extent.depth is 1
1201 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1202 string_VkImageType(pCreateInfo->imageType));
1203 }
1204 if (pCreateInfo->mipLevels != 1) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001205 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %" PRIu32 ".", base_message,
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001206 pCreateInfo->mipLevels);
1207 }
1208 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1209 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1210 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1211 }
1212 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1213 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1214 base_message, string_VkImageTiling(pCreateInfo->tiling));
1215 }
1216 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1217 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1218 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1219 }
1220 const VkImageCreateFlags valid_flags =
1221 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
Mike Schuchardt2df08912020-12-15 16:28:09 -08001222 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT);
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001223 if ((image_flags & ~valid_flags) != 0) {
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001224 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001225 image_flags);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001226 }
1227 }
1228 }
sfricke-samsung61a57c02021-01-10 21:35:12 -08001229
1230 // If Chroma subsampled format ( _420_ or _422_ )
1231 if (FormatIsXChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.width, 2) != 0)) {
1232 skip |=
1233 LogError(device, "VUID-VkImageCreateInfo-format-04712",
1234 "vkCreateImage(): The format (%s) is X Chroma Subsampled (has _422 or _420 suffix) so the width (=%" PRIu32
1235 ") must be a multiple of 2.",
1236 string_VkFormat(image_format), pCreateInfo->extent.width);
1237 }
1238 if (FormatIsYChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.height, 2) != 0)) {
1239 skip |= LogError(device, "VUID-VkImageCreateInfo-format-04713",
1240 "vkCreateImage(): The format (%s) is Y Chroma Subsampled (has _420 suffix) so the height (=%" PRIu32
1241 ") must be a multiple of 2.",
1242 string_VkFormat(image_format), pCreateInfo->extent.height);
1243 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001244
1245 const auto format_list_info = LvlFindInChain<VkImageFormatListCreateInfo>(pCreateInfo->pNext);
1246 if (format_list_info) {
1247 const uint32_t viewFormatCount = format_list_info->viewFormatCount;
1248 if (((image_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) == 0) && (viewFormatCount > 1)) {
1249 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-04738",
1250 "vkCreateImage(): If the VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT is not set, then "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001251 "VkImageFormatListCreateInfo::viewFormatCount (%" PRIu32 ") must be 0 or 1.",
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001252 viewFormatCount);
1253 }
1254 // Check if viewFormatCount is not zero that it is all compatible
1255 for (uint32_t i = 0; i < viewFormatCount; i++) {
Mike Schuchardtb0608492022-04-05 18:52:48 -07001256 const bool class_compatible =
1257 FormatCompatibilityClass(format_list_info->pViewFormats[i]) == FormatCompatibilityClass(image_format);
1258 if (!class_compatible) {
1259 if (image_flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT) {
1260 const bool size_compatible =
1261 FormatIsCompressed(format_list_info->pViewFormats[i])
1262 ? false
1263 : FormatElementSize(format_list_info->pViewFormats[i]) == FormatElementSize(image_format);
1264 if (!size_compatible) {
1265 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-06722",
1266 "vkCreateImage(): VkImageFormatListCreateInfo::pViewFormats[%" PRIu32
1267 "] (%s) and VkImageCreateInfo::format (%s) are not compatible or size-compatible.",
1268 i, string_VkFormat(format_list_info->pViewFormats[i]), string_VkFormat(image_format));
1269 }
1270 } else {
1271 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-06722",
1272 "vkCreateImage(): VkImageFormatListCreateInfo::pViewFormats[%" PRIu32
1273 "] (%s) and VkImageCreateInfo::format (%s) are not compatible.",
1274 i, string_VkFormat(format_list_info->pViewFormats[i]), string_VkFormat(image_format));
1275 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001276 }
1277 }
1278 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001279 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001280
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001281 return skip;
1282}
1283
Jeff Bolz99e3f632020-03-24 22:59:22 -05001284bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1285 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1286 bool skip = false;
1287
1288 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001289 // Validate feature set if using CUBE_ARRAY
1290 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1291 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1292 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1293 "enabling the imageCubeArray feature.");
1294 }
1295
Jeff Bolz99e3f632020-03-24 22:59:22 -05001296 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1297 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1298 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001299 "vkCreateImageView(): subresourceRange.layerCount (%" PRIu32
1300 ") must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001301 pCreateInfo->subresourceRange.layerCount);
1302 }
1303 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001304 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02961",
1305 "vkCreateImageView(): subresourceRange.layerCount (%" PRIu32
1306 ") must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1307 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001308 }
1309 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001310
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001311 auto astc_decode_mode = LvlFindInChain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
sfricke-samsung45996a42021-09-16 13:45:27 -07001312 if (IsExtEnabled(device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001313 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1314 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1315 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1316 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1317 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1318 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1319 }
sfricke-samsunge3086292021-11-18 23:02:35 -08001320 if ((FormatIsCompressed_ASTC_LDR(pCreateInfo->format) == false) &&
1321 (FormatIsCompressed_ASTC_HDR(pCreateInfo->format) == false)) {
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001322 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1323 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1324 "not an ASTC format.",
1325 string_VkFormat(pCreateInfo->format));
1326 }
1327 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001328
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001329 auto ycbcr_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
sfricke-samsung83d98122020-07-04 06:21:15 -07001330 if (ycbcr_conversion != nullptr) {
1331 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1332 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1333 skip |= LogError(
1334 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1335 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1336 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1337 "r swizzle = %s\n"
1338 "g swizzle = %s\n"
1339 "b swizzle = %s\n"
1340 "a swizzle = %s\n",
1341 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1342 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1343 }
1344 }
1345 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001346 }
1347 return skip;
1348}
1349
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001350bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001351 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001352 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001353
1354 // Note: for numerical correctness
1355 // - float comparisons should expect NaN (comparison always false).
1356 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1357
1358 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001359 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001360 if (v1_f <= 0.0f) return true;
1361
1362 float intpart;
1363 const float fract = modff(v1_f, &intpart);
1364
1365 assert(std::numeric_limits<float>::radix == 2);
1366 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1367 if (intpart >= u32_max_plus1) return false;
1368
1369 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001370 if (v1_u32 < v2_u32) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001371 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001372 } else if (v1_u32 == v2_u32 && fract == 0.0f) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001373 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001374 } else {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001375 return false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001376 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01001377 };
1378
1379 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1380 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1381 return (v1_f <= v2_f);
1382 };
1383
1384 // width
1385 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001386 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001387
1388 if (!(viewport.width > 0.0f)) {
1389 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001390 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1391 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001392 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1393 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001394 skip |= LogError(object, "VUID-VkViewport-width-01771",
1395 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1396 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001397 }
1398
1399 // height
1400 bool height_healthy = true;
sfricke-samsung45996a42021-09-16 13:45:27 -07001401 const bool negative_height_enabled =
1402 IsExtEnabled(device_extensions.vk_khr_maintenance1) || IsExtEnabled(device_extensions.vk_amd_negative_viewport_height);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001403 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001404
1405 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1406 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001407 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1408 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001409 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1410 height_healthy = false;
1411
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001412 skip |= LogError(object, "VUID-VkViewport-height-01773",
1413 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1414 ").",
1415 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001416 }
1417
1418 // x
1419 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001420 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001421 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001422 skip |= LogError(object, "VUID-VkViewport-x-01774",
1423 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1424 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001425 }
1426
1427 // x + width
1428 if (x_healthy && width_healthy) {
1429 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001430 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001431 skip |= LogError(
1432 object, "VUID-VkViewport-x-01232",
1433 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1434 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1435 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001436 }
1437 }
1438
1439 // y
1440 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001441 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001442 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001443 skip |= LogError(object, "VUID-VkViewport-y-01775",
1444 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1445 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001446 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001447 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001448 skip |= LogError(object, "VUID-VkViewport-y-01776",
1449 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1450 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001451 }
1452
1453 // y + height
1454 if (y_healthy && height_healthy) {
1455 const float boundary = viewport.y + viewport.height;
1456
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001457 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001458 skip |= LogError(object, "VUID-VkViewport-y-01233",
1459 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1460 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1461 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001462 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001463 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001464 LogError(object, "VUID-VkViewport-y-01777",
1465 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1466 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1467 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001468 }
1469 }
1470
sfricke-samsungfd06d422021-01-22 02:17:21 -08001471 // The extension was not created with a feature bit whichs prevents displaying the 2 variations of the VUIDs
sfricke-samsung45996a42021-09-16 13:45:27 -07001472 if (!IsExtEnabled(device_extensions.vk_ext_depth_range_unrestricted)) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001473 // minDepth
1474 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001475 // Also VUID-VkViewport-minDepth-02540
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001476 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001477 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1478 "[0.0, 1.0] range.",
1479 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001480 }
1481
1482 // maxDepth
1483 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001484 // Also VUID-VkViewport-maxDepth-02541
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001485 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001486 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1487 "[0.0, 1.0] range.",
1488 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001489 }
1490 }
1491
1492 return skip;
1493}
1494
Dave Houlton142c4cb2018-10-17 15:04:41 -06001495struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001496 VkShadingRatePaletteEntryNV shadingRate;
1497 uint32_t width;
1498 uint32_t height;
1499};
1500
1501// All palette entries with more than one pixel per fragment
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001502static SampleOrderInfo sample_order_infos[] = {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001503 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1504 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1505 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1506 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1507 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1508 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001509};
1510
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001511bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001512 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001513
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001514 SampleOrderInfo *sample_order_info;
1515 uint32_t info_idx = 0;
1516 for (sample_order_info = nullptr; info_idx < ARRAY_SIZE(sample_order_infos); ++info_idx) {
1517 if (sample_order_infos[info_idx].shadingRate == order->shadingRate) {
1518 sample_order_info = &sample_order_infos[info_idx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001519 break;
1520 }
1521 }
1522
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001523 if (sample_order_info == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001524 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1525 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1526 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001527 return skip;
1528 }
1529
Dave Houlton142c4cb2018-10-17 15:04:41 -06001530 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001531 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001532 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1533 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1534 ") must "
1535 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1536 "is set in framebufferNoAttachmentsSampleCounts.",
1537 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001538 }
1539
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001540 if (order->sampleLocationCount != order->sampleCount * sample_order_info->width * sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001541 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1542 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1543 ") must "
1544 "be equal to the product of sampleCount (=%" PRIu32
1545 "), the fragment width for shadingRate "
1546 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001547 order->sampleLocationCount, order->sampleCount, sample_order_info->width, sample_order_info->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001548 }
1549
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001550 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001551 skip |= LogError(
1552 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001553 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1554 ") must "
1555 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001556 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001557 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001558
1559 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001560 // the first width*height*sampleCount bits to all be set. Note: There is no
1561 // guarantee that 64 bits is enough, but practically it's unlikely for an
1562 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001563 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001564 uint64_t sample_locations_mask = 0;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001565 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001566 const VkCoarseSampleLocationNV *sample_loc = &order->pSampleLocations[i];
1567 if (sample_loc->pixelX >= sample_order_info->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001568 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1569 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001570 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001571 if (sample_loc->pixelY >= sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001572 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1573 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001574 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001575 if (sample_loc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001576 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1577 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001578 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001579 uint32_t idx =
1580 sample_loc->sample + order->sampleCount * (sample_loc->pixelX + sample_order_info->width * sample_loc->pixelY);
1581 sample_locations_mask |= 1ULL << idx;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001582 }
1583
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001584 uint64_t expected_mask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1585 if (sample_locations_mask != expected_mask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001586 skip |= LogError(
1587 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001588 "The array pSampleLocations must contain exactly one entry for "
1589 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001590 }
1591
1592 return skip;
1593}
1594
sfricke-samsung51303fb2021-05-09 19:09:13 -07001595bool StatelessValidation::manual_PreCallValidateCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo,
1596 const VkAllocationCallbacks *pAllocator,
1597 VkPipelineLayout *pPipelineLayout) const {
1598 bool skip = false;
1599 // Validate layout count against device physical limit
1600 if (pCreateInfo->setLayoutCount > device_limits.maxBoundDescriptorSets) {
1601 skip |= LogError(device, "VUID-VkPipelineLayoutCreateInfo-setLayoutCount-00286",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001602 "vkCreatePipelineLayout(): setLayoutCount (%" PRIu32
1603 ") exceeds physical device maxBoundDescriptorSets limit (%" PRIu32 ").",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001604 pCreateInfo->setLayoutCount, device_limits.maxBoundDescriptorSets);
1605 }
1606
Nathaniel Cesariodb38b7a2022-03-10 22:16:51 -07001607 const bool has_independent_sets = (pCreateInfo->flags & VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT) != 0;
1608 const bool graphics_pipeline_library = IsExtEnabled(device_extensions.vk_ext_graphics_pipeline_library);
1609 const char *const valid_dsl_vuid = (!graphics_pipeline_library)
1610 ? "VUID-VkPipelineLayoutCreateInfo-pSetLayouts-06561"
1611 : ((!has_independent_sets) ? "VUID-VkPipelineLayoutCreateInfo-flags-06562" : nullptr);
1612 if (valid_dsl_vuid) {
1613 for (uint32_t i = 0; i < pCreateInfo->setLayoutCount; ++i) {
1614 if (!pCreateInfo->pSetLayouts[i]) {
1615 skip |=
1616 LogError(device, valid_dsl_vuid, "vkCreatePipelineLayout(): pSetLayouts[%" PRIu32 "] is VK_NULL_HANDLE.", i);
1617 }
1618 }
1619 }
1620
sfricke-samsung51303fb2021-05-09 19:09:13 -07001621 // Validate Push Constant ranges
1622 for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
1623 const uint32_t offset = pCreateInfo->pPushConstantRanges[i].offset;
1624 const uint32_t size = pCreateInfo->pPushConstantRanges[i].size;
1625 const uint32_t max_push_constants_size = device_limits.maxPushConstantsSize;
1626 // Check that offset + size don't exceed the max.
1627 // Prevent arithetic overflow here by avoiding addition and testing in this order.
1628 if (offset >= max_push_constants_size) {
1629 skip |= LogError(device, "VUID-VkPushConstantRange-offset-00294",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001630 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].offset (%" PRIu32
1631 ") that exceeds this "
1632 "device's maxPushConstantSize of %" PRIu32 ".",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001633 i, offset, max_push_constants_size);
1634 }
1635 if (size > max_push_constants_size - offset) {
1636 skip |= LogError(device, "VUID-VkPushConstantRange-size-00298",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001637 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "] offset (%" PRIu32
1638 ") and size (%" PRIu32
1639 ") "
1640 "together exceeds this device's maxPushConstantSize of %" PRIu32 ".",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001641 i, offset, size, max_push_constants_size);
1642 }
1643
1644 // size needs to be non-zero and a multiple of 4.
1645 if (size == 0) {
1646 skip |= LogError(device, "VUID-VkPushConstantRange-size-00296",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001647 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].size (%" PRIu32
1648 ") is not greater than zero.",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001649 i, size);
1650 }
1651 if (size & 0x3) {
1652 skip |= LogError(device, "VUID-VkPushConstantRange-size-00297",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001653 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].size (%" PRIu32
1654 ") is not a multiple of 4.",
1655 i, size);
sfricke-samsung51303fb2021-05-09 19:09:13 -07001656 }
1657
1658 // offset needs to be a multiple of 4.
1659 if ((offset & 0x3) != 0) {
1660 skip |= LogError(device, "VUID-VkPushConstantRange-offset-00295",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001661 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].offset (%" PRIu32
1662 ") is not a multiple of 4.",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001663 i, offset);
1664 }
1665 }
1666
1667 // As of 1.0.28, there is a VU that states that a stage flag cannot appear more than once in the list of push constant ranges.
1668 for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
1669 for (uint32_t j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) {
1670 if (0 != (pCreateInfo->pPushConstantRanges[i].stageFlags & pCreateInfo->pPushConstantRanges[j].stageFlags)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001671 skip |=
1672 LogError(device, "VUID-VkPipelineLayoutCreateInfo-pPushConstantRanges-00292",
1673 "vkCreatePipelineLayout() Duplicate stage flags found in ranges %" PRIu32 " and %" PRIu32 ".", i, j);
sfricke-samsung51303fb2021-05-09 19:09:13 -07001674 }
1675 }
1676 }
1677 return skip;
1678}
1679
ziga-lunargc6341372021-07-28 12:57:42 +02001680bool StatelessValidation::ValidatePipelineShaderStageCreateInfo(const char *func_name, const char *msg,
1681 const VkPipelineShaderStageCreateInfo *pCreateInfo) const {
1682 bool skip = false;
1683
1684 const auto *required_subgroup_size_features =
1685 LvlFindInChain<VkPipelineShaderStageRequiredSubgroupSizeCreateInfoEXT>(pCreateInfo->pNext);
1686
1687 if (required_subgroup_size_features) {
1688 if ((pCreateInfo->flags & VK_PIPELINE_SHADER_STAGE_CREATE_ALLOW_VARYING_SUBGROUP_SIZE_BIT_EXT) != 0) {
1689 skip |= LogError(
1690 device, "VUID-VkPipelineShaderStageCreateInfo-pNext-02754",
1691 "%s(): %s->flags (0x%x) includes VK_PIPELINE_SHADER_STAGE_CREATE_ALLOW_VARYING_SUBGROUP_SIZE_BIT_EXT while "
1692 "VkPipelineShaderStageRequiredSubgroupSizeCreateInfoEXT is included in the pNext chain.",
1693 func_name, msg, pCreateInfo->flags);
1694 }
1695 }
1696
1697 return skip;
1698}
1699
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001700bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1701 uint32_t createInfoCount,
1702 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1703 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001704 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001705 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001706
1707 if (pCreateInfos != nullptr) {
1708 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001709 bool has_dynamic_viewport = false;
1710 bool has_dynamic_scissor = false;
1711 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001712 bool has_dynamic_depth_bias = false;
1713 bool has_dynamic_blend_constant = false;
1714 bool has_dynamic_depth_bounds = false;
1715 bool has_dynamic_stencil_compare = false;
1716 bool has_dynamic_stencil_write = false;
1717 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001718 bool has_dynamic_viewport_w_scaling_nv = false;
1719 bool has_dynamic_discard_rectangle_ext = false;
1720 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001721 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001722 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001723 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001724 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001725 bool has_dynamic_cull_mode = false;
1726 bool has_dynamic_front_face = false;
1727 bool has_dynamic_primitive_topology = false;
1728 bool has_dynamic_viewport_with_count = false;
1729 bool has_dynamic_scissor_with_count = false;
1730 bool has_dynamic_vertex_input_binding_stride = false;
1731 bool has_dynamic_depth_test_enable = false;
1732 bool has_dynamic_depth_write_enable = false;
1733 bool has_dynamic_depth_compare_op = false;
1734 bool has_dynamic_depth_bounds_test_enable = false;
1735 bool has_dynamic_stencil_test_enable = false;
1736 bool has_dynamic_stencil_op = false;
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07001737 bool has_patch_control_points = false;
1738 bool has_rasterizer_discard_enable = false;
1739 bool has_depth_bias_enable = false;
1740 bool has_logic_op = false;
1741 bool has_primitive_restart_enable = false;
Piers Daniellcb6d8032021-04-19 18:51:26 -06001742 bool has_dynamic_vertex_input = false;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07001743
1744 // Create a copy of create_info and set non-included sub-state to null
1745 auto create_info = pCreateInfos[i];
1746 const auto *graphics_lib_info = LvlFindInChain<VkGraphicsPipelineLibraryCreateInfoEXT>(create_info.pNext);
1747 if (graphics_lib_info) {
Nathaniel Cesariobcb79682022-03-31 21:13:52 -06001748 // TODO (ncesario) Remove this once GPU-AV and debug printf is supported with pipeline libraries
1749 if (enabled[gpu_validation]) {
1750 skip |=
1751 LogError(device, kVUIDUndefined, "GPU-AV with VK_EXT_graphics_pipeline_library is not currently supported");
1752 }
1753 if (enabled[gpu_validation]) {
1754 skip |= LogError(device, kVUIDUndefined,
1755 "Debug printf with VK_EXT_graphics_pipeline_library is not currently supported");
1756 }
1757
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07001758 if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_VERTEX_INPUT_INTERFACE_BIT_EXT)) {
1759 create_info.pVertexInputState = nullptr;
1760 create_info.pInputAssemblyState = nullptr;
1761 }
1762 if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT)) {
1763 create_info.pViewportState = nullptr;
1764 create_info.pRasterizationState = nullptr;
1765 create_info.pTessellationState = nullptr;
1766 }
1767 if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT)) {
1768 create_info.pDepthStencilState = nullptr;
1769 }
1770 if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT)) {
1771 create_info.pColorBlendState = nullptr;
1772 }
1773 if (!(graphics_lib_info->flags & (VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT |
1774 VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT))) {
1775 create_info.pMultisampleState = nullptr;
1776 }
1777 if (!(graphics_lib_info->flags & (VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT |
1778 VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT))) {
1779 create_info.layout = VK_NULL_HANDLE;
1780 }
1781 if (!(graphics_lib_info->flags & (VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT |
1782 VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT |
1783 VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT))) {
1784 create_info.renderPass = VK_NULL_HANDLE;
1785 create_info.subpass = 0;
1786 }
1787 }
1788
Nathaniel Cesario72f29552022-03-24 05:11:11 -06001789 if (!create_info.renderPass) {
1790 if (create_info.pColorBlendState && create_info.pMultisampleState) {
1791 // Pipeline has fragment outout state
1792 const auto rendering_struct = LvlFindInChain<VkPipelineRenderingCreateInfo>(create_info.pNext);
1793 if (rendering_struct) {
1794 if ((rendering_struct->depthAttachmentFormat != VK_FORMAT_UNDEFINED)) {
1795 skip |= validate_ranged_enum("VkPipelineRenderingCreateInfo", "stencilAttachmentFormat", "VkFormat",
1796 AllVkFormatEnums, rendering_struct->stencilAttachmentFormat,
1797 "VUID-VkGraphicsPipelineCreateInfo-renderPass-06583");
Nathaniel Cesarioe77320e2022-04-11 17:32:33 -06001798
1799 if (!FormatHasDepth(rendering_struct->depthAttachmentFormat)) {
1800 skip |= LogError(
1801 device, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06587",
1802 "vkCreateGraphicsPipelines() pCreateInfos[%" PRIu32
1803 "]: VkPipelineRenderingCreateInfo::depthAttachmentFormat (%s) does not have a depth aspect.",
1804 i, string_VkFormat(rendering_struct->depthAttachmentFormat));
1805 }
Nathaniel Cesario72f29552022-03-24 05:11:11 -06001806 }
1807
1808 if ((rendering_struct->stencilAttachmentFormat != VK_FORMAT_UNDEFINED)) {
1809 skip |= validate_ranged_enum("VkPipelineRenderingCreateInfo", "stencilAttachmentFormat", "VkFormat",
1810 AllVkFormatEnums, rendering_struct->stencilAttachmentFormat,
1811 "VUID-VkGraphicsPipelineCreateInfo-renderPass-06584");
Nathaniel Cesarioe77320e2022-04-11 17:32:33 -06001812 if (!FormatHasStencil(rendering_struct->stencilAttachmentFormat)) {
1813 skip |= LogError(
1814 device, "VUID-VkGraphicsPipelineCreateInfo-renderPass-06588",
1815 "vkCreateGraphicsPipelines() pCreateInfos[%" PRIu32
1816 "]: VkPipelineRenderingCreateInfo::stencilAttachmentFormat (%s) does not have a depth aspect.",
1817 i, string_VkFormat(rendering_struct->stencilAttachmentFormat));
1818 }
Nathaniel Cesario72f29552022-03-24 05:11:11 -06001819 }
1820 }
1821 }
1822 }
1823
Nathaniel Cesario617ffdc2022-03-11 17:02:45 -07001824 if (!IsExtEnabled(device_extensions.vk_ext_graphics_pipeline_library)) {
1825 if (create_info.stageCount == 0) {
1826 skip |=
1827 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stageCount-06604",
1828 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32 "].stageCount is 0, but %s is not enabled", i,
1829 VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME);
1830 }
1831 // TODO while PRIu32 should probably be used instead of %i below, %i is necessary due to
1832 // ParameterName::IndexFormatSpecifier
1833 skip |= validate_struct_type_array(
1834 "vkCreateGraphicsPipelines", ParameterName("pCreateInfos[%i].stageCount", ParameterName::IndexVector{i}),
1835 ParameterName("pCreateInfos[%i].pStages", ParameterName::IndexVector{i}),
1836 "VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO", pCreateInfos[i].stageCount, pCreateInfos[i].pStages,
1837 VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO, true, true,
1838 "VUID-VkPipelineShaderStageCreateInfo-sType-sType", "VUID-VkGraphicsPipelineCreateInfo-pStages-06600",
Nathaniel Cesario6a0ce2f2022-04-02 21:47:54 -06001839 "VUID-VkGraphicsPipelineCreateInfo-pStages-06600");
Nathaniel Cesario617ffdc2022-03-11 17:02:45 -07001840 skip |= validate_struct_type("vkCreateGraphicsPipelines",
1841 ParameterName("pCreateInfos[%i].pRasterizationState", ParameterName::IndexVector{i}),
1842 "VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_CREATE_INFO",
1843 pCreateInfos[i].pRasterizationState,
1844 VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_CREATE_INFO, true,
1845 "VUID-VkGraphicsPipelineCreateInfo-pRasterizationState-06601",
1846 "VUID-VkPipelineRasterizationStateCreateInfo-sType-sType");
1847 if (!create_info.layout) {
1848 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-layout-06602",
1849 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
1850 "].layout is VK_NULL_HANDLE, but %s is not enabled.",
1851 i, VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME);
1852 }
1853 }
1854
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07001855 // TODO probably should check dynamic state from graphics libraries, at least when creating an "executable pipeline"
1856 if (create_info.pDynamicState != nullptr) {
1857 const auto &dynamic_state_info = *create_info.pDynamicState;
Petr Kraus299ba622017-11-24 03:09:03 +01001858 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1859 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001860 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1861 if (has_dynamic_viewport == true) {
1862 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1863 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001864 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001865 i);
1866 }
1867 has_dynamic_viewport = true;
1868 }
1869 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1870 if (has_dynamic_scissor == true) {
1871 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1872 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001873 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001874 i);
1875 }
1876 has_dynamic_scissor = true;
1877 }
1878 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1879 if (has_dynamic_line_width == true) {
1880 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1881 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001882 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001883 i);
1884 }
1885 has_dynamic_line_width = true;
1886 }
1887 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1888 if (has_dynamic_depth_bias == true) {
1889 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1890 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001891 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001892 i);
1893 }
1894 has_dynamic_depth_bias = true;
1895 }
1896 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1897 if (has_dynamic_blend_constant == true) {
1898 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1899 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001900 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001901 i);
1902 }
1903 has_dynamic_blend_constant = true;
1904 }
1905 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1906 if (has_dynamic_depth_bounds == true) {
1907 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1908 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001909 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001910 i);
1911 }
1912 has_dynamic_depth_bounds = true;
1913 }
1914 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1915 if (has_dynamic_stencil_compare == true) {
1916 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1917 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001918 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001919 i);
1920 }
1921 has_dynamic_stencil_compare = true;
1922 }
1923 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1924 if (has_dynamic_stencil_write == true) {
1925 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1926 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001927 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001928 i);
1929 }
1930 has_dynamic_stencil_write = true;
1931 }
1932 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1933 if (has_dynamic_stencil_reference == true) {
1934 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1935 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001936 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001937 i);
1938 }
1939 has_dynamic_stencil_reference = true;
1940 }
1941 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1942 if (has_dynamic_viewport_w_scaling_nv == true) {
1943 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1944 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001945 "in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001946 i);
1947 }
1948 has_dynamic_viewport_w_scaling_nv = true;
1949 }
1950 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1951 if (has_dynamic_discard_rectangle_ext == true) {
1952 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1953 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001954 "in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001955 i);
1956 }
1957 has_dynamic_discard_rectangle_ext = true;
1958 }
1959 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1960 if (has_dynamic_sample_locations_ext == true) {
1961 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1962 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001963 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001964 i);
1965 }
1966 has_dynamic_sample_locations_ext = true;
1967 }
1968 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1969 if (has_dynamic_exclusive_scissor_nv == true) {
1970 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1971 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001972 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001973 i);
1974 }
1975 has_dynamic_exclusive_scissor_nv = true;
1976 }
1977 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1978 if (has_dynamic_shading_rate_palette_nv == true) {
1979 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1980 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001981 "listed twice in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001982 i);
1983 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001984 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001985 }
1986 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1987 if (has_dynamic_viewport_course_sample_order_nv == true) {
1988 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1989 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001990 "listed twice in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001991 i);
1992 }
1993 has_dynamic_viewport_course_sample_order_nv = true;
1994 }
1995 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1996 if (has_dynamic_line_stipple == true) {
1997 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1998 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001999 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07002000 i);
2001 }
2002 has_dynamic_line_stipple = true;
2003 }
Piers Daniell39842ee2020-07-10 16:42:33 -06002004 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
2005 if (has_dynamic_cull_mode) {
2006 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2007 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002008 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002009 i);
2010 }
2011 has_dynamic_cull_mode = true;
2012 }
2013 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
2014 if (has_dynamic_front_face) {
2015 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2016 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002017 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002018 i);
2019 }
2020 has_dynamic_front_face = true;
2021 }
2022 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
2023 if (has_dynamic_primitive_topology) {
2024 skip |= LogError(
2025 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2026 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002027 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002028 i);
2029 }
2030 has_dynamic_primitive_topology = true;
2031 }
2032 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
2033 if (has_dynamic_viewport_with_count) {
2034 skip |= LogError(
2035 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2036 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002037 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002038 i);
2039 }
2040 has_dynamic_viewport_with_count = true;
2041 }
2042 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
2043 if (has_dynamic_scissor_with_count) {
2044 skip |= LogError(
2045 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2046 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002047 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002048 i);
2049 }
2050 has_dynamic_scissor_with_count = true;
2051 }
2052 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
2053 if (has_dynamic_vertex_input_binding_stride) {
2054 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2055 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
2056 "listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002057 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002058 i);
2059 }
2060 has_dynamic_vertex_input_binding_stride = true;
2061 }
2062 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
2063 if (has_dynamic_depth_test_enable) {
2064 skip |= LogError(
2065 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2066 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002067 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002068 i);
2069 }
2070 has_dynamic_depth_test_enable = true;
2071 }
2072 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
2073 if (has_dynamic_depth_write_enable) {
2074 skip |= LogError(
2075 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2076 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002077 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002078 i);
2079 }
2080 has_dynamic_depth_write_enable = true;
2081 }
2082 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
2083 if (has_dynamic_depth_compare_op) {
2084 skip |=
2085 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2086 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002087 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002088 i);
2089 }
2090 has_dynamic_depth_compare_op = true;
2091 }
2092 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
2093 if (has_dynamic_depth_bounds_test_enable) {
2094 skip |= LogError(
2095 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2096 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002097 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002098 i);
2099 }
2100 has_dynamic_depth_bounds_test_enable = true;
2101 }
2102 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
2103 if (has_dynamic_stencil_test_enable) {
2104 skip |= LogError(
2105 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2106 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002107 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002108 i);
2109 }
2110 has_dynamic_stencil_test_enable = true;
2111 }
2112 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
2113 if (has_dynamic_stencil_op) {
2114 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2115 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002116 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002117 i);
2118 }
2119 has_dynamic_stencil_op = true;
2120 }
sfricke-samsung5f8f9702021-01-29 23:30:30 -08002121 if (dynamic_state == VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR) {
2122 // Not allowed for graphics pipelines
2123 skip |= LogError(
2124 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03578",
2125 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR was listed the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002126 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates[%" PRIu32
2127 "] but not allowed in graphic pipelines.",
sfricke-samsung5f8f9702021-01-29 23:30:30 -08002128 i, state_index);
2129 }
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002130 if (dynamic_state == VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT) {
2131 if (has_patch_control_points) {
2132 skip |= LogError(
2133 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2134 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002135 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002136 i);
2137 }
2138 has_patch_control_points = true;
2139 }
2140 if (dynamic_state == VK_DYNAMIC_STATE_RASTERIZER_DISCARD_ENABLE_EXT) {
2141 if (has_rasterizer_discard_enable) {
2142 skip |= LogError(
2143 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2144 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_RASTERIZER_DISCARD_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002145 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002146 i);
2147 }
2148 has_rasterizer_discard_enable = true;
2149 }
2150 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS_ENABLE_EXT) {
2151 if (has_depth_bias_enable) {
2152 skip |= LogError(
2153 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2154 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002155 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002156 i);
2157 }
2158 has_depth_bias_enable = true;
2159 }
2160 if (dynamic_state == VK_DYNAMIC_STATE_LOGIC_OP_EXT) {
2161 if (has_logic_op) {
2162 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2163 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LOGIC_OP_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002164 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002165 i);
2166 }
2167 has_logic_op = true;
2168 }
2169 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_RESTART_ENABLE_EXT) {
2170 if (has_primitive_restart_enable) {
2171 skip |= LogError(
2172 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2173 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_RESTART_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002174 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002175 i);
2176 }
2177 has_primitive_restart_enable = true;
2178 }
Piers Daniellcb6d8032021-04-19 18:51:26 -06002179 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_EXT) {
2180 if (has_dynamic_vertex_input) {
2181 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002182 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_EXT was listed twice in the "
2183 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
2184 i);
Piers Daniellcb6d8032021-04-19 18:51:26 -06002185 }
2186 has_dynamic_vertex_input = true;
2187 }
Petr Kraus299ba622017-11-24 03:09:03 +01002188 }
2189 }
2190
sfricke-samsung3b944422021-01-23 02:15:19 -08002191 if (has_dynamic_viewport_with_count && has_dynamic_viewport) {
2192 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04132",
2193 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT and "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002194 "VK_DYNAMIC_STATE_VIEWPORT both listed in pCreateInfos[%" PRIu32
2195 "].pDynamicState->pDynamicStates array",
sfricke-samsung3b944422021-01-23 02:15:19 -08002196 i);
2197 }
2198
2199 if (has_dynamic_scissor_with_count && has_dynamic_scissor) {
2200 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04133",
2201 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT and VK_DYNAMIC_STATE_SCISSOR "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002202 "both listed in pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
sfricke-samsung3b944422021-01-23 02:15:19 -08002203 i);
2204 }
2205
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002206 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(create_info.pNext);
2207 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != create_info.stageCount)) {
Nathaniel Cesario6a0ce2f2022-04-02 21:47:54 -06002208 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pipelineStageCreationFeedbackCount-06594",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002209 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
2210 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
2211 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002212 i, feedback_struct->pipelineStageCreationFeedbackCount, create_info.stageCount);
Peter Chen85366392019-05-14 15:20:11 -04002213 }
2214
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002215 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002216
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002217 // Collect active stages and other information
2218 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002219 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002220 bool has_eval = false;
2221 bool has_control = false;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002222 if (create_info.pStages != nullptr) {
2223 for (uint32_t stage_index = 0; stage_index < create_info.stageCount; ++stage_index) {
2224 active_shaders |= create_info.pStages[stage_index].stage;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002225
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002226 if (create_info.pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002227 has_control = true;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002228 } else if (create_info.pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002229 has_eval = true;
2230 }
2231
2232 skip |= validate_string(
2233 "vkCreateGraphicsPipelines",
2234 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
Nathaniel Cesario6a0ce2f2022-04-02 21:47:54 -06002235 kVUID_Stateless_InvalidShaderStagesArray, create_info.pStages[stage_index].pName);
ziga-lunargc6341372021-07-28 12:57:42 +02002236
2237 std::stringstream msg;
2238 msg << "pCreateInfos[%" << i << "].pStages[%" << stage_index << "]";
2239 ValidatePipelineShaderStageCreateInfo("vkCreateGraphicsPipelines", msg.str().c_str(),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002240 &create_info.pStages[stage_index]);
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002241 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002242 }
2243
2244 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002245 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (create_info.pTessellationState != nullptr)) {
2246 skip |=
2247 validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
2248 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
2249 create_info.pTessellationState, VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO,
2250 false, kVUIDUndefined, "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002251
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002252 const VkStructureType allowed_structs_vk_pipeline_tessellation_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002253 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
2254
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002255 skip |= validate_struct_pnext(
2256 "vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002257 "VkPipelineTessellationDomainOriginStateCreateInfo", create_info.pTessellationState->pNext,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002258 ARRAY_SIZE(allowed_structs_vk_pipeline_tessellation_state_create_info),
2259 allowed_structs_vk_pipeline_tessellation_state_create_info, GeneratedVulkanHeaderVersion,
2260 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
2261 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002262
2263 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002264 create_info.pTessellationState->flags,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002265 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
2266 }
2267
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002268 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (create_info.pInputAssemblyState != nullptr)) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002269 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
2270 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002271 create_info.pInputAssemblyState,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002272 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
2273 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
2274
2275 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002276 create_info.pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002277 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002278
2279 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002280 create_info.pInputAssemblyState->flags,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002281 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
2282
2283 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
2284 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002285 create_info.pInputAssemblyState->topology,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002286 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
2287
2288 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002289 create_info.pInputAssemblyState->primitiveRestartEnable);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002290 }
2291
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002292 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (create_info.pVertexInputState != nullptr)) {
2293 auto const &vertex_input_state = create_info.pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02002294
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002295 if (create_info.pVertexInputState->flags != 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002296 skip |=
2297 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
2298 "vkCreateGraphicsPipelines: pararameter "
2299 "pCreateInfos[%" PRIu32 "].pVertexInputState->flags (%" PRIu32 ") is reserved and must be zero.",
2300 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002301 }
2302
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002303 const VkStructureType allowed_structs_vk_pipeline_vertex_input_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002304 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002305 skip |=
2306 validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
2307 "VkPipelineVertexInputDivisorStateCreateInfoEXT", create_info.pVertexInputState->pNext, 1,
2308 allowed_structs_vk_pipeline_vertex_input_state_create_info, GeneratedVulkanHeaderVersion,
2309 "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
2310 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002311 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
2312 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06002313 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002314 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
2315 skip |=
2316 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
2317 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002318 create_info.pVertexInputState->vertexBindingDescriptionCount,
2319 &create_info.pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002320 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
2321
2322 skip |= validate_array(
2323 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
2324 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
2325 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
2326 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
2327
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002328 if (create_info.pVertexInputState->pVertexBindingDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002329 for (uint32_t vertex_binding_description_index = 0;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002330 vertex_binding_description_index < create_info.pVertexInputState->vertexBindingDescriptionCount;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002331 ++vertex_binding_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002332 skip |= validate_ranged_enum(
2333 "vkCreateGraphicsPipelines",
2334 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
2335 AllVkVertexInputRateEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002336 create_info.pVertexInputState->pVertexBindingDescriptions[vertex_binding_description_index].inputRate,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002337 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
2338 }
2339 }
2340
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002341 if (create_info.pVertexInputState->pVertexAttributeDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002342 for (uint32_t vertex_attribute_description_index = 0;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002343 vertex_attribute_description_index < create_info.pVertexInputState->vertexAttributeDescriptionCount;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002344 ++vertex_attribute_description_index) {
sfricke-samsung2e827212021-09-28 07:52:08 -07002345 const VkFormat format =
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002346 create_info.pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index].format;
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002347 skip |= validate_ranged_enum(
2348 "vkCreateGraphicsPipelines",
2349 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
2350 AllVkFormatEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002351 create_info.pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index].format,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002352 "VUID-VkVertexInputAttributeDescription-format-parameter");
sfricke-samsung2e827212021-09-28 07:52:08 -07002353 if (FormatIsDepthOrStencil(format)) {
2354 // Should never hopefully get here, but there are known driver advertising the wrong feature flags
2355 // see https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/4849
2356 skip |= LogError(device, kVUID_Core_invalidDepthStencilFormat,
2357 "vkCreateGraphicsPipelines: "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002358 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2359 "].format is a "
sfricke-samsung2e827212021-09-28 07:52:08 -07002360 "depth/stencil format (%s) but depth/stencil formats do not have a defined sizes for "
2361 "alignment, replace with a color format.",
2362 i, vertex_attribute_description_index, string_VkFormat(format));
2363 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002364 }
2365 }
2366
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002367 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002368 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
2369 "vkCreateGraphicsPipelines: pararameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002370 "pCreateInfo[%" PRIu32 "].pVertexInputState->vertexBindingDescriptionCount (%" PRIu32
2371 ") is "
2372 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002373 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002374 }
2375
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002376 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002377 skip |=
2378 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
2379 "vkCreateGraphicsPipelines: pararameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002380 "pCreateInfo[%" PRIu32 "].pVertexInputState->vertexAttributeDescriptionCount (%" PRIu32
2381 ") is "
2382 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002383 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002384 }
2385
Jeremy Gebbencbf22862021-03-03 12:01:22 -07002386 layer_data::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002387 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
2388 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02002389 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
2390 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002391 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
2392 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002393 "pCreateInfo[%" PRIu32 "].pVertexInputState->pVertexBindingDescription[%" PRIu32
2394 "].binding "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002395 "(%" PRIu32 ") is not distinct.",
2396 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002397 }
2398 vertex_bindings.insert(vertex_bind_desc.binding);
2399
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002400 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002401 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
2402 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002403 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexBindingDescriptions[%" PRIu32
2404 "].binding (%" PRIu32
2405 ") is "
2406 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002407 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002408 }
2409
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002410 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002411 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
2412 "vkCreateGraphicsPipelines: parameter "
2413 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexBindingDescriptions[%" PRIu32
2414 "].stride (%" PRIu32
2415 ") is greater "
2416 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%" PRIu32 ").",
2417 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002418 }
2419 }
2420
Jeremy Gebbencbf22862021-03-03 12:01:22 -07002421 layer_data::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002422 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
2423 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02002424 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
2425 if (location_it != attribute_locations.cend()) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002426 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
2427 "vkCreateGraphicsPipelines: parameter "
2428 "pCreateInfo[%" PRIu32 "].pVertexInputState->vertexAttributeDescriptions[%" PRIu32
2429 "].location (%" PRIu32 ") is not distinct.",
2430 i, d, vertex_attrib_desc.location);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002431 }
2432 attribute_locations.insert(vertex_attrib_desc.location);
2433
2434 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
2435 if (binding_it == vertex_bindings.cend()) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002436 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
2437 "vkCreateGraphicsPipelines: parameter "
2438 " pCreateInfo[%" PRIu32 "].pVertexInputState->vertexAttributeDescriptions[%" PRIu32
2439 "].binding (%" PRIu32
2440 ") does not exist "
2441 "in any pCreateInfo[%" PRIu32 "].pVertexInputState->pVertexBindingDescription.",
2442 i, d, vertex_attrib_desc.binding, i);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002443 }
2444
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002445 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002446 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
2447 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002448 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2449 "].location (%" PRIu32
2450 ") is "
2451 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002452 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002453 }
2454
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002455 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002456 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
2457 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002458 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2459 "].binding (%" PRIu32
2460 ") is "
2461 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002462 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002463 }
2464
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002465 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002466 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
2467 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002468 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2469 "].offset (%" PRIu32
2470 ") is "
2471 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002472 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002473 }
2474 }
2475 }
2476
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002477 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
2478 if (has_control && has_eval) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002479 if (create_info.pTessellationState == nullptr) {
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002480 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002481 "vkCreateGraphicsPipelines: if pCreateInfos[%" PRIu32
2482 "].pStages includes a tessellation control "
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002483 "shader stage and a tessellation evaluation shader stage, "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002484 "pCreateInfos[%" PRIu32 "].pTessellationState must not be NULL.",
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002485 i, i);
2486 } else {
2487 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
2488 skip |= validate_struct_pnext(
2489 "vkCreateGraphicsPipelines",
2490 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002491 "VkPipelineTessellationDomainOriginStateCreateInfo", create_info.pTessellationState->pNext, 1,
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002492 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
2493 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002494
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002495 skip |= validate_reserved_flags(
2496 "vkCreateGraphicsPipelines",
2497 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002498 create_info.pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002499
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002500 if (create_info.pTessellationState->patchControlPoints == 0 ||
2501 create_info.pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
2502 skip |=
2503 LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
2504 "vkCreateGraphicsPipelines: invalid parameter "
2505 "pCreateInfos[%" PRIu32 "].pTessellationState->patchControlPoints value %" PRIu32
2506 ". patchControlPoints "
2507 "should be >0 and <=%" PRIu32 ".",
2508 i, create_info.pTessellationState->patchControlPoints, device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002509 }
2510 }
2511 }
2512
2513 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002514 if ((create_info.pRasterizationState != nullptr) &&
2515 (create_info.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
2516 if (create_info.pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002517 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
2518 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
2519 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
2520 "].pViewportState (=NULL) is not a valid pointer.",
2521 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002522 } else {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002523 const auto &viewport_state = *create_info.pViewportState;
Petr Krausa6103552017-11-16 21:21:58 +01002524
2525 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002526 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
2527 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2528 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
2529 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002530 }
2531
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002532 const VkStructureType allowed_structs_vk_pipeline_viewport_state_create_info[] = {
Petr Krausa6103552017-11-16 21:21:58 +01002533 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002534 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
2535 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05002536 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
2537 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002538 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_DEPTH_CLIP_CONTROL_CREATE_INFO_EXT,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002539 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002540 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002541 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01002542 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05002543 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05002544 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002545 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV, VkPipelineViewportDepthClipControlCreateInfoEXT",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002546 viewport_state.pNext, ARRAY_SIZE(allowed_structs_vk_pipeline_viewport_state_create_info),
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002547 allowed_structs_vk_pipeline_viewport_state_create_info, 200,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002548 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08002549 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002550
2551 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002552 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002553 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002554 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002555
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002556 auto exclusive_scissor_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002557 LvlFindInChain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(viewport_state.pNext);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002558 auto shading_rate_image_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002559 LvlFindInChain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(viewport_state.pNext);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002560 auto coarse_sample_order_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002561 LvlFindInChain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(viewport_state.pNext);
2562 const auto vp_swizzle_struct = LvlFindInChain<VkPipelineViewportSwizzleStateCreateInfoNV>(viewport_state.pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002563 const auto vp_w_scaling_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002564 LvlFindInChain<VkPipelineViewportWScalingStateCreateInfoNV>(viewport_state.pNext);
2565 const auto depth_clip_control_struct =
2566 LvlFindInChain<VkPipelineViewportDepthClipControlCreateInfoEXT>(viewport_state.pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002567
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002568 if (!physical_device_features.multiViewport) {
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002569 if (!has_dynamic_viewport_with_count && (viewport_state.viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002570 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2571 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2572 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2573 ") is not 1.",
2574 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002575 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002576
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002577 if (!has_dynamic_scissor_with_count && (viewport_state.scissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002578 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2579 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2580 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2581 ") is not 1.",
2582 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002583 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002584
Dave Houlton142c4cb2018-10-17 15:04:41 -06002585 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2586 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002587 skip |= LogError(
2588 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2589 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2590 "disabled, but pCreateInfos[%" PRIu32
2591 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2592 ") is not 1.",
2593 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002594 }
2595
Jeff Bolz9af91c52018-09-01 21:53:57 -05002596 if (shading_rate_image_struct &&
2597 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002598 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2599 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2600 "disabled, but pCreateInfos[%" PRIu32
2601 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2602 ") is neither 0 nor 1.",
2603 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002604 }
2605
Petr Krausa6103552017-11-16 21:21:58 +01002606 } else { // multiViewport enabled
2607 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002608 if (!has_dynamic_viewport_with_count) {
2609 skip |= LogError(
2610 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2611 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2612 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002613 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002614 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2615 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2616 "].pViewportState->viewportCount (=%" PRIu32
2617 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2618 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002619 } else if (has_dynamic_viewport_with_count) {
2620 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2621 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2622 "].pViewportState->viewportCount (=%" PRIu32
2623 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2624 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002625 }
Petr Krausa6103552017-11-16 21:21:58 +01002626
2627 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002628 if (!has_dynamic_scissor_with_count) {
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002629 const char *vuid = IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state)
2630 ? "VUID-VkPipelineViewportStateCreateInfo-scissorCount-04136"
2631 : "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength";
Piers Daniell39842ee2020-07-10 16:42:33 -06002632 skip |= LogError(
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002633 device, vuid,
Piers Daniell39842ee2020-07-10 16:42:33 -06002634 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2635 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002636 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002637 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2638 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2639 "].pViewportState->scissorCount (=%" PRIu32
2640 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2641 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002642 } else if (has_dynamic_scissor_with_count) {
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002643 const char *vuid = IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state)
2644 ? "VUID-VkPipelineViewportStateCreateInfo-scissorCount-04136"
2645 : "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380";
2646 skip |= LogError(device, vuid,
Piers Daniell39842ee2020-07-10 16:42:33 -06002647 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2648 "].pViewportState->scissorCount (=%" PRIu32
2649 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2650 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002651 }
2652 }
2653
ziga-lunarg845883b2021-07-14 15:05:00 +02002654 if (!has_dynamic_scissor && viewport_state.pScissors) {
2655 for (uint32_t scissor_i = 0; scissor_i < viewport_state.scissorCount; ++scissor_i) {
2656 const auto &scissor = viewport_state.pScissors[scissor_i];
ziga-lunarga77dc802021-07-15 13:19:06 +02002657
2658 if (scissor.offset.x < 0) {
2659 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-x-02821",
2660 "vkCreateGraphicsPipelines: offset.x (=%" PRIi32 ") of pCreateInfos[%" PRIu32
2661 "].pViewportState->pScissors[%" PRIu32 "] is negative.",
2662 scissor.offset.x, i, scissor_i);
2663 }
2664
2665 if (scissor.offset.y < 0) {
2666 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-x-02821",
2667 "vkCreateGraphicsPipelines: offset.y (=%" PRIi32 ") of pCreateInfos[%" PRIu32
2668 "].pViewportState->pScissors[%" PRIu32 "] is negative.",
2669 scissor.offset.y, i, scissor_i);
2670 }
2671
ziga-lunarg845883b2021-07-14 15:05:00 +02002672 const int64_t x_sum =
2673 static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2674 if (x_sum > std::numeric_limits<int32_t>::max()) {
2675 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-offset-02822",
2676 "vkCreateGraphicsPipelines: offset.x + extent.width (=%" PRIi32 " + %" PRIu32
2677 " = %" PRIi64 ") of pCreateInfos[%" PRIu32 "].pViewportState->pScissors[%" PRIu32
2678 "] will overflow int32_t.",
2679 scissor.offset.x, scissor.extent.width, x_sum, i, scissor_i);
2680 }
ziga-lunarga77dc802021-07-15 13:19:06 +02002681
ziga-lunarg845883b2021-07-14 15:05:00 +02002682 const int64_t y_sum =
2683 static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2684 if (y_sum > std::numeric_limits<int32_t>::max()) {
2685 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-offset-02823",
2686 "vkCreateGraphicsPipelines: offset.y + extent.height (=%" PRIi32 " + %" PRIu32
2687 " = %" PRIi64 ") of pCreateInfos[%" PRIu32 "].pViewportState->pScissors[%" PRIu32
2688 "] will overflow int32_t.",
2689 scissor.offset.y, scissor.extent.height, y_sum, i, scissor_i);
2690 }
2691 }
2692 }
2693
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002694 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002695 skip |=
2696 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2697 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2698 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2699 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002700 }
2701
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002702 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002703 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2704 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2705 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2706 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2707 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002708 }
2709
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002710 if (viewport_state.scissorCount != viewport_state.viewportCount) {
2711 if (!IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state) ||
2712 (!has_dynamic_viewport_with_count && !has_dynamic_scissor_with_count)) {
2713 const char *vuid = IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state)
2714 ? "VUID-VkPipelineViewportStateCreateInfo-scissorCount-04134"
2715 : "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220";
2716 skip |= LogError(
2717 device, vuid,
2718 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2719 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2720 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
2721 }
Petr Krausa6103552017-11-16 21:21:58 +01002722 }
2723
Dave Houlton142c4cb2018-10-17 15:04:41 -06002724 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002725 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002726 skip |=
2727 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2728 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2729 ") must be zero or identical to pCreateInfos[%" PRIu32
2730 "].pViewportState->viewportCount (=%" PRIu32 ").",
2731 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002732 }
2733
Dave Houlton142c4cb2018-10-17 15:04:41 -06002734 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002735 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002736 skip |= LogError(
2737 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002738 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2739 "] "
2740 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2741 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2742 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002743 }
2744
Petr Krausa6103552017-11-16 21:21:58 +01002745 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002746 skip |= LogError(
2747 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002748 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2749 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002750 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2751 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002752 }
2753
2754 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002755 skip |= LogError(
2756 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002757 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2758 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002759 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2760 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002761 }
2762
Jeff Bolz3e71f782018-08-29 23:15:45 -05002763 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002764 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2765 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2766 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002767 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002768 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2769 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2770 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2771 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002772 }
2773
Jeff Bolz9af91c52018-09-01 21:53:57 -05002774 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002775 shading_rate_image_struct->viewportCount > 0 &&
2776 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002777 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002778 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002779 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002780 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2781 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002782 i, i);
2783 }
2784
Chris Mayer328d8212018-12-11 14:16:18 +01002785 if (vp_swizzle_struct) {
2786 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002787 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2788 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2789 " does "
2790 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2791 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002792 }
2793 }
2794
Petr Krausb3fcdb42018-01-09 22:09:09 +01002795 // validate the VkViewports
2796 if (!has_dynamic_viewport && viewport_state.pViewports) {
2797 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2798 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002799 const char *fn_name = "vkCreateGraphicsPipelines";
2800 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2801 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2802 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002803 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002804 }
2805 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002806
sfricke-samsung45996a42021-09-16 13:45:27 -07002807 if (has_dynamic_viewport_w_scaling_nv && !IsExtEnabled(device_extensions.vk_nv_clip_space_w_scaling)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002808 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2809 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2810 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2811 "VK_NV_clip_space_w_scaling extension is not enabled.",
2812 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002813 }
2814
sfricke-samsung45996a42021-09-16 13:45:27 -07002815 if (has_dynamic_discard_rectangle_ext && !IsExtEnabled(device_extensions.vk_ext_discard_rectangles)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002816 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2817 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2818 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2819 "VK_EXT_discard_rectangles extension is not enabled.",
2820 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002821 }
2822
sfricke-samsung45996a42021-09-16 13:45:27 -07002823 if (has_dynamic_sample_locations_ext && !IsExtEnabled(device_extensions.vk_ext_sample_locations)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002824 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2825 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2826 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2827 "VK_EXT_sample_locations extension is not enabled.",
2828 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002829 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002830
sfricke-samsung45996a42021-09-16 13:45:27 -07002831 if (has_dynamic_exclusive_scissor_nv && !IsExtEnabled(device_extensions.vk_nv_scissor_exclusive)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002832 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2833 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2834 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2835 "VK_NV_scissor_exclusive extension is not enabled.",
2836 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002837 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002838
2839 if (coarse_sample_order_struct &&
2840 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2841 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002842 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2843 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2844 "] "
2845 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2846 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2847 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002848 }
2849
2850 if (coarse_sample_order_struct) {
2851 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002852 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002853 }
2854 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002855
2856 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2857 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002858 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2859 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2860 "] "
2861 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2862 ") "
2863 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2864 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002865 }
2866 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002867 skip |= LogError(
2868 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002869 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2870 "] "
2871 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2872 i);
2873 }
2874 }
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002875
2876 if (depth_clip_control_struct) {
2877 const auto *depth_clip_control_features =
2878 LvlFindInChain<VkPhysicalDeviceDepthClipControlFeaturesEXT>(device_createinfo_pnext);
2879 const bool enabled_depth_clip_control =
2880 depth_clip_control_features && depth_clip_control_features->depthClipControl;
2881 if (depth_clip_control_struct->negativeOneToOne && !enabled_depth_clip_control) {
2882 skip |= LogError(device, "VUID-VkPipelineViewportDepthClipControlCreateInfoEXT-negativeOneToOne-06470",
2883 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2884 "].pViewportState has negativeOneToOne set to VK_TRUE in the pNext chain, but the "
2885 "depthClipControl feature is not enabled. ",
2886 i);
2887 }
2888 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002889 }
2890
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002891 const bool is_frag_out_graphics_lib =
2892 graphics_lib_info &&
2893 ((graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT) != 0);
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002894 if (is_frag_out_graphics_lib && (create_info.pMultisampleState == nullptr)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002895 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002896 "vkCreateGraphicsPipelines: if pCreateInfos[%" PRIu32
2897 "].pRasterizationState->rasterizerDiscardEnable "
2898 "is VK_FALSE, pCreateInfos[%" PRIu32 "].pMultisampleState must not be NULL.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002899 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002900 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002901 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002902 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002903 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2904 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002905 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002906 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002907 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002908
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002909 // It is possible for pCreateInfos[i].pMultisampleState to be null when creating a graphics library
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002910 if (create_info.pMultisampleState) {
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002911 skip |= validate_struct_pnext(
2912 "vkCreateGraphicsPipelines",
2913 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002914 valid_struct_names, create_info.pMultisampleState->pNext, 4, valid_next_stypes,
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002915 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2916 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002917
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002918 skip |= validate_reserved_flags(
2919 "vkCreateGraphicsPipelines",
2920 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002921 create_info.pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002922
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002923 skip |= validate_bool32(
2924 "vkCreateGraphicsPipelines",
2925 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002926 create_info.pMultisampleState->sampleShadingEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002927
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002928 skip |= validate_array(
2929 "vkCreateGraphicsPipelines",
2930 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples",
2931 ParameterName::IndexVector{i}),
2932 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002933 create_info.pMultisampleState->rasterizationSamples, &create_info.pMultisampleState->pSampleMask, true,
2934 false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002935
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002936 skip |= validate_flags("vkCreateGraphicsPipelines",
2937 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples",
2938 ParameterName::IndexVector{i}),
2939 "VkSampleCountFlagBits", AllVkSampleCountFlagBits,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002940 create_info.pMultisampleState->rasterizationSamples, kRequiredSingleBit,
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002941 "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002942
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002943 skip |= validate_bool32("vkCreateGraphicsPipelines",
2944 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable",
2945 ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002946 create_info.pMultisampleState->alphaToCoverageEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002947
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002948 skip |= validate_bool32(
2949 "vkCreateGraphicsPipelines",
2950 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002951 create_info.pMultisampleState->alphaToOneEnable);
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002952
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002953 if (create_info.pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002954 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
2955 "vkCreateGraphicsPipelines: parameter pCreateInfos[%" PRIu32
2956 "].pMultisampleState->sType must be "
2957 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002958 i);
John Zulauf7acac592017-11-06 11:15:53 -07002959 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002960 if (create_info.pMultisampleState->sampleShadingEnable == VK_TRUE) {
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002961 if (!physical_device_features.sampleRateShading) {
2962 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2963 "vkCreateGraphicsPipelines(): parameter "
2964 "pCreateInfos[%" PRIu32 "].pMultisampleState->sampleShadingEnable.",
2965 i);
2966 }
2967 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2968 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002969 if (!in_inclusive_range(create_info.pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002970 skip |= LogError(device,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002971
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002972 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
2973 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%" PRIu32
2974 "].pMultisampleState->minSampleShading.",
2975 i);
2976 }
John Zulauf7acac592017-11-06 11:15:53 -07002977 }
2978 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002979
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002980 const auto *line_state =
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002981 LvlFindInChain<VkPipelineRasterizationLineStateCreateInfoEXT>(create_info.pRasterizationState->pNext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002982
2983 if (line_state) {
2984 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2985 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002986 if (create_info.pMultisampleState->alphaToCoverageEnable) {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002987 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002988 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2989 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002990 "pCreateInfos[%" PRIu32 "].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002991 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002992 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002993 if (create_info.pMultisampleState->alphaToOneEnable) {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002994 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002995 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2996 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002997 "pCreateInfos[%" PRIu32 "].pMultisampleState->alphaToOneEnable == VK_TRUE.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002998 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002999 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003000 if (create_info.pMultisampleState->sampleShadingEnable) {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003001 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003002 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
3003 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003004 "pCreateInfos[%" PRIu32 "].pMultisampleState->sampleShadingEnable == VK_TRUE.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003005 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003006 }
3007 }
3008 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
3009 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
3010 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003011 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003012 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32 "] lineStippleFactor = %" PRIu32
3013 " must be in the "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003014 "range [1,256].",
3015 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003016 }
3017 }
3018 const auto *line_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003019 LvlFindInChain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003020 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
3021 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003022 skip |=
3023 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003024 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3025 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003026 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
3027 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003028 }
3029 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
3030 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003031 skip |=
3032 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003033 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3034 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003035 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
3036 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003037 }
3038 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
3039 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003040 skip |=
3041 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003042 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3043 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003044 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
3045 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003046 }
3047 if (line_state->stippledLineEnable) {
3048 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
3049 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003050 skip |=
3051 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003052 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3053 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003054 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
3055 "stippledRectangularLines feature.",
3056 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003057 }
3058 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
3059 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003060 skip |=
3061 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003062 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3063 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003064 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
3065 "stippledBresenhamLines feature.",
3066 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003067 }
3068 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
3069 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003070 skip |=
3071 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003072 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3073 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003074 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
3075 "stippledSmoothLines feature.",
3076 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003077 }
3078 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
Malcolm Bechardfc509002021-11-17 21:57:28 -05003079 (!line_features || !line_features->stippledRectangularLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003080 skip |=
3081 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003082 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3083 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003084 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
3085 "stippledRectangularLines and strictLines features.",
3086 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003087 }
3088 }
3089 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003090 }
3091
Petr Krause91f7a12017-12-14 20:57:36 +01003092 bool uses_color_attachment = false;
3093 bool uses_depthstencil_attachment = false;
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003094 VkSubpassDescriptionFlags subpass_flags = 0;
Petr Krause91f7a12017-12-14 20:57:36 +01003095 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07003096 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003097 const auto subpasses_uses_it = renderpasses_states.find(create_info.renderPass);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003098 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01003099 const auto &subpasses_uses = subpasses_uses_it->second;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003100 if (subpasses_uses.subpasses_using_color_attachment.count(create_info.subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01003101 uses_color_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003102 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003103 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(create_info.subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01003104 uses_depthstencil_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003105 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003106 subpass_flags = subpasses_uses.subpasses_flags[create_info.subpass];
Petr Krause91f7a12017-12-14 20:57:36 +01003107 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07003108 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01003109 }
3110
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003111 if (create_info.pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003112 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003113 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003114 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003115 create_info.pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08003116 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003117
Mike Schuchardt00e81452021-11-29 11:11:20 -08003118 skip |=
3119 validate_flags("vkCreateGraphicsPipelines",
3120 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
3121 "VkPipelineDepthStencilStateCreateFlagBits", AllVkPipelineDepthStencilStateCreateFlagBits,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003122 create_info.pDepthStencilState->flags, kOptionalFlags,
Mike Schuchardt00e81452021-11-29 11:11:20 -08003123 "VUID-VkPipelineDepthStencilStateCreateInfo-flags-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003124
3125 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003126 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003127 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003128 create_info.pDepthStencilState->depthTestEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003129
3130 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003131 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003132 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003133 create_info.pDepthStencilState->depthWriteEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003134
3135 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003136 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003137 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003138 "VkCompareOp", AllVkCompareOpEnums, create_info.pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003139 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003140
3141 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003142 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003143 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003144 create_info.pDepthStencilState->depthBoundsTestEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003145
3146 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003147 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003148 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003149 create_info.pDepthStencilState->stencilTestEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003150
3151 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003152 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003153 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003154 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003155 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003156
3157 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003158 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003159 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003160 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003161 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003162
3163 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003164 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003165 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003166 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003167 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003168
3169 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003170 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003171 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003172 "VkCompareOp", AllVkCompareOpEnums, create_info.pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003173 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003174
3175 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003176 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003177 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003178 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003179 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003180
3181 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003182 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003183 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003184 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003185 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003186
3187 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003188 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003189 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003190 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003191 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003192
3193 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003194 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003195 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003196 "VkCompareOp", AllVkCompareOpEnums, create_info.pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003197 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003198
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003199 if (create_info.pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07003200 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003201 "vkCreateGraphicsPipelines: parameter pCreateInfos[%" PRIu32
3202 "].pDepthStencilState->sType must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003203 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
3204 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003205 }
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003206
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003207 if ((create_info.pDepthStencilState->flags &
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003208 VK_PIPELINE_DEPTH_STENCIL_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_DEPTH_ACCESS_BIT_ARM) != 0) {
3209 const auto *rasterization_order_attachment_access_feature =
3210 LvlFindInChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
3211 const bool rasterization_order_depth_attachment_access_feature_enabled =
3212 rasterization_order_attachment_access_feature &&
3213 rasterization_order_attachment_access_feature->rasterizationOrderDepthAttachmentAccess == VK_TRUE;
3214 if (!rasterization_order_depth_attachment_access_feature_enabled) {
3215 skip |= LogError(
3216 device, "VUID-VkPipelineDepthStencilStateCreateInfo-rasterizationOrderDepthAttachmentAccess-06463",
3217 "VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
3218 "rasterizationOrderDepthAttachmentAccess == VK_FALSE, but "
3219 "VkPipelineDepthStencilStateCreateInfo::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003220 string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str());
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003221 }
3222
3223 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_DEPTH_ACCESS_BIT_ARM) == 0) {
3224 skip |= LogError(
Mike Schuchardt979898a2022-01-11 10:46:59 -08003225 device, "VUID-VkGraphicsPipelineCreateInfo-flags-06485",
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003226 "VkPipelineDepthStencilStateCreateInfo::flags == %s but "
3227 "VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003228 string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str(),
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003229 string_VkSubpassDescriptionFlags(subpass_flags).c_str());
3230 }
3231 }
3232
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003233 if ((create_info.pDepthStencilState->flags &
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003234 VK_PIPELINE_DEPTH_STENCIL_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_STENCIL_ACCESS_BIT_ARM) != 0) {
3235 const auto *rasterization_order_attachment_access_feature =
3236 LvlFindInChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
3237 const bool rasterization_order_stencil_attachment_access_feature_enabled =
3238 rasterization_order_attachment_access_feature &&
3239 rasterization_order_attachment_access_feature->rasterizationOrderStencilAttachmentAccess == VK_TRUE;
3240 if (!rasterization_order_stencil_attachment_access_feature_enabled) {
3241 skip |= LogError(
3242 device,
3243 "VUID-VkPipelineDepthStencilStateCreateInfo-rasterizationOrderStencilAttachmentAccess-06464",
3244 "VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
3245 "rasterizationOrderStencilAttachmentAccess == VK_FALSE, but "
3246 "VkPipelineDepthStencilStateCreateInfo::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003247 string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str());
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003248 }
3249
3250 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_STENCIL_ACCESS_BIT_ARM) == 0) {
3251 skip |= LogError(
Mike Schuchardt979898a2022-01-11 10:46:59 -08003252 device, "VUID-VkGraphicsPipelineCreateInfo-flags-06486",
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003253 "VkPipelineDepthStencilStateCreateInfo::flags == %s but "
3254 "VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003255 string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str(),
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003256 string_VkSubpassDescriptionFlags(subpass_flags).c_str());
3257 }
3258 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003259 }
3260
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003261 const VkStructureType allowed_structs_vk_pipeline_color_blend_state_create_info[] = {
ziga-lunarg8de09162021-08-05 15:21:33 +02003262 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT,
3263 VK_STRUCTURE_TYPE_PIPELINE_COLOR_WRITE_CREATE_INFO_EXT};
Shannon McPherson9b9532b2018-10-24 12:00:09 -06003264
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003265 if (create_info.pColorBlendState != nullptr && uses_color_attachment) {
3266 skip |=
3267 validate_struct_type("vkCreateGraphicsPipelines",
3268 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
3269 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
3270 create_info.pColorBlendState, VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO,
3271 false, kVUIDUndefined, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06003272
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003273 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003274 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06003275 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003276 "VkPipelineColorBlendAdvancedStateCreateInfoEXT, VkPipelineColorWriteCreateInfoEXT",
3277 create_info.pColorBlendState->pNext, ARRAY_SIZE(allowed_structs_vk_pipeline_color_blend_state_create_info),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003278 allowed_structs_vk_pipeline_color_blend_state_create_info, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08003279 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
3280 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003281
Mike Schuchardt00e81452021-11-29 11:11:20 -08003282 skip |= validate_flags("vkCreateGraphicsPipelines",
3283 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
3284 "VkPipelineColorBlendStateCreateFlagBits", AllVkPipelineColorBlendStateCreateFlagBits,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003285 create_info.pColorBlendState->flags, kOptionalFlags,
Mike Schuchardt00e81452021-11-29 11:11:20 -08003286 "VUID-VkPipelineColorBlendStateCreateInfo-flags-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003287
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003288 if ((create_info.pColorBlendState->flags &
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003289 VK_PIPELINE_COLOR_BLEND_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_ACCESS_BIT_ARM) != 0) {
3290 const auto *rasterization_order_attachment_access_feature =
3291 LvlFindInChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
3292 const bool rasterization_order_color_attachment_access_feature_enabled =
3293 rasterization_order_attachment_access_feature &&
3294 rasterization_order_attachment_access_feature->rasterizationOrderColorAttachmentAccess == VK_TRUE;
3295
3296 if (!rasterization_order_color_attachment_access_feature_enabled) {
3297 skip |= LogError(
3298 device, "VUID-VkPipelineColorBlendStateCreateInfo-rasterizationOrderColorAttachmentAccess-06465",
3299 "VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
3300 "rasterizationColorAttachmentAccess == VK_FALSE, but "
3301 "VkPipelineColorBlendStateCreateInfo::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003302 string_VkPipelineColorBlendStateCreateFlags(create_info.pColorBlendState->flags).c_str());
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003303 }
3304
3305 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_COLOR_ACCESS_BIT_ARM) == 0) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003306 skip |=
3307 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-06484",
3308 "VkPipelineColorBlendStateCreateInfo::flags == %s but "
3309 "VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
3310 string_VkPipelineColorBlendStateCreateFlags(create_info.pColorBlendState->flags).c_str(),
3311 string_VkSubpassDescriptionFlags(subpass_flags).c_str());
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003312 }
3313 }
3314
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003315 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003316 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003317 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003318 create_info.pColorBlendState->logicOpEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003319
3320 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003321 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003322 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
3323 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003324 create_info.pColorBlendState->attachmentCount, &create_info.pColorBlendState->pAttachments, false, true,
3325 kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003326
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003327 if (create_info.pColorBlendState->pAttachments != NULL) {
3328 for (uint32_t attachment_index = 0; attachment_index < create_info.pColorBlendState->attachmentCount;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003329 ++attachment_index) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003330 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003331 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003332 ParameterName::IndexVector{i, attachment_index}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003333 create_info.pColorBlendState->pAttachments[attachment_index].blendEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003334
3335 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003336 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003337 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003338 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003339 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003340 create_info.pColorBlendState->pAttachments[attachment_index].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003341 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003342
3343 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003344 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003345 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003346 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003347 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003348 create_info.pColorBlendState->pAttachments[attachment_index].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003349 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003350
3351 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003352 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003353 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003354 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003355 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003356 create_info.pColorBlendState->pAttachments[attachment_index].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003357 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003358
3359 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003360 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003361 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003362 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003363 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003364 create_info.pColorBlendState->pAttachments[attachment_index].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003365 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003366
3367 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003368 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003369 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003370 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003371 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003372 create_info.pColorBlendState->pAttachments[attachment_index].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003373 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003374
3375 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003376 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003377 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003378 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003379 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003380 create_info.pColorBlendState->pAttachments[attachment_index].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003381 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003382
3383 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003384 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003385 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003386 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003387 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003388 create_info.pColorBlendState->pAttachments[attachment_index].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02003389 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
ziga-lunarga283d022021-08-04 18:35:23 +02003390
3391 if (phys_dev_ext_props.blend_operation_advanced_props.advancedBlendAllOperations == VK_FALSE) {
3392 bool invalid = false;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003393 switch (create_info.pColorBlendState->pAttachments[attachment_index].colorBlendOp) {
ziga-lunarga283d022021-08-04 18:35:23 +02003394 case VK_BLEND_OP_ZERO_EXT:
3395 case VK_BLEND_OP_SRC_EXT:
3396 case VK_BLEND_OP_DST_EXT:
3397 case VK_BLEND_OP_SRC_OVER_EXT:
3398 case VK_BLEND_OP_DST_OVER_EXT:
3399 case VK_BLEND_OP_SRC_IN_EXT:
3400 case VK_BLEND_OP_DST_IN_EXT:
3401 case VK_BLEND_OP_SRC_OUT_EXT:
3402 case VK_BLEND_OP_DST_OUT_EXT:
3403 case VK_BLEND_OP_SRC_ATOP_EXT:
3404 case VK_BLEND_OP_DST_ATOP_EXT:
3405 case VK_BLEND_OP_XOR_EXT:
3406 case VK_BLEND_OP_INVERT_EXT:
3407 case VK_BLEND_OP_INVERT_RGB_EXT:
3408 case VK_BLEND_OP_LINEARDODGE_EXT:
3409 case VK_BLEND_OP_LINEARBURN_EXT:
3410 case VK_BLEND_OP_VIVIDLIGHT_EXT:
3411 case VK_BLEND_OP_LINEARLIGHT_EXT:
3412 case VK_BLEND_OP_PINLIGHT_EXT:
3413 case VK_BLEND_OP_HARDMIX_EXT:
3414 case VK_BLEND_OP_PLUS_EXT:
3415 case VK_BLEND_OP_PLUS_CLAMPED_EXT:
3416 case VK_BLEND_OP_PLUS_CLAMPED_ALPHA_EXT:
3417 case VK_BLEND_OP_PLUS_DARKER_EXT:
3418 case VK_BLEND_OP_MINUS_EXT:
3419 case VK_BLEND_OP_MINUS_CLAMPED_EXT:
3420 case VK_BLEND_OP_CONTRAST_EXT:
3421 case VK_BLEND_OP_INVERT_OVG_EXT:
3422 case VK_BLEND_OP_RED_EXT:
3423 case VK_BLEND_OP_GREEN_EXT:
3424 case VK_BLEND_OP_BLUE_EXT:
3425 invalid = true;
3426 break;
3427 default:
3428 break;
3429 }
3430 if (invalid) {
3431 skip |= LogError(
3432 device, "VUID-VkPipelineColorBlendAttachmentState-advancedBlendAllOperations-01409",
3433 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
3434 "].pColorBlendState->pAttachments[%" PRIu32
3435 "].colorBlendOp (%s) is not valid when "
3436 "VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT::advancedBlendAllOperations is "
3437 "VK_FALSE",
3438 i, attachment_index,
3439 string_VkBlendOp(
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003440 create_info.pColorBlendState->pAttachments[attachment_index].colorBlendOp));
ziga-lunarga283d022021-08-04 18:35:23 +02003441 }
3442 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003443 }
3444 }
3445
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003446 if (create_info.pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07003447 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003448 "vkCreateGraphicsPipelines: parameter pCreateInfos[%" PRIu32
3449 "].pColorBlendState->sType must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003450 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
3451 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003452 }
3453
3454 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003455 if (create_info.pColorBlendState->logicOpEnable == VK_TRUE) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003456 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003457 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003458 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003459 AllVkLogicOpEnums, create_info.pColorBlendState->logicOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003460 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003461 }
3462 }
3463 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003464
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003465 const VkPipelineCreateFlags flags = create_info.flags;
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003466 if (flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003467 if (create_info.basePipelineIndex != -1) {
3468 if (create_info.basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003469 skip |=
3470 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003471 "vkCreateGraphicsPipelines parameter, pCreateInfos[%" PRIu32
3472 "]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003473 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003474 "and pCreateInfos->basePipelineIndex is not -1.",
3475 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003476 }
3477 }
3478
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003479 if (create_info.basePipelineHandle != VK_NULL_HANDLE) {
3480 if (create_info.basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003481 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003482 "vkCreateGraphicsPipelines parameter, pCreateInfos[%" PRIu32
3483 "]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003484 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003485 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
3486 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003487 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06003488 } else {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003489 if (static_cast<uint32_t>(create_info.basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003490 skip |=
3491 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003492 "vkCreateGraphicsPipelines parameter pCreateInfos[%" PRIu32 "]->basePipelineIndex (%" PRId32
3493 ") must be a valid"
3494 "index into the pCreateInfos array, of size %" PRIu32 ".",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003495 i, create_info.basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06003496 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003497 }
3498 }
3499
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003500 if (create_info.pRasterizationState) {
sfricke-samsung45996a42021-09-16 13:45:27 -07003501 if (!IsExtEnabled(device_extensions.vk_nv_fill_rectangle)) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003502 if (create_info.pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
Chris Mayer840b2c42019-08-22 18:12:22 +02003503 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003504 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
3505 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
3506 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
3507 "if the extension VK_NV_fill_rectangle is not enabled.");
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003508 } else if ((create_info.pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Chris Mayer840b2c42019-08-22 18:12:22 +02003509 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07003510 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003511 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003512 "pCreateInfos[%" PRIu32
3513 "]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003514 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
3515 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02003516 }
3517 } else {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003518 if ((create_info.pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
3519 (create_info.pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
Chris Mayer840b2c42019-08-22 18:12:22 +02003520 (physical_device_features.fillModeNonSolid == false)) {
3521 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003522 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
3523 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003524 "pCreateInfos[%" PRIu32
3525 "]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003526 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
3527 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02003528 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003529 }
Petr Kraus299ba622017-11-24 03:09:03 +01003530
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003531 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003532 (create_info.pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003533 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
3534 "The line width state is static (pCreateInfos[%" PRIu32
3535 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
3536 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
3537 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003538 i, i, create_info.pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003539 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003540 }
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003541
3542 // Validate no flags not allowed are used
3543 if ((flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
sfricke-samsungad008902021-04-16 01:25:34 -07003544 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003545 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3546 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003547 "VK_PIPELINE_CREATE_DISPATCH_BASE.",
3548 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003549 }
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07003550 if (!IsExtEnabled(device_extensions.vk_ext_graphics_pipeline_library) &&
3551 (flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
sfricke-samsungad008902021-04-16 01:25:34 -07003552 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03371",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003553 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3554 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003555 "VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.",
3556 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003557 }
3558 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
3559 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03372",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003560 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3561 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003562 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
3563 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003564 }
3565 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
3566 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03373",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003567 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3568 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003569 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
3570 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003571 }
3572 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
3573 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03374",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003574 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3575 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003576 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
3577 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003578 }
3579 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
3580 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03375",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003581 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3582 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003583 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
3584 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003585 }
3586 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
3587 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03376",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003588 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3589 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003590 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
3591 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003592 }
3593 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
3594 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03377",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003595 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3596 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003597 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
3598 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003599 }
3600 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
3601 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03577",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003602 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3603 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003604 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
3605 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003606 }
ziga-lunarg4bd42e42021-10-04 13:19:29 +02003607 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) != 0) {
3608 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-04947",
3609 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3610 "]->flags (0x%x) must not include "
3611 "VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV.",
3612 i, flags);
3613 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003614 }
3615 }
3616
3617 return skip;
3618}
3619
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003620bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
3621 uint32_t createInfoCount,
3622 const VkComputePipelineCreateInfo *pCreateInfos,
3623 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003624 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003625 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003626 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003627 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003628 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06003629 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003630 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Nathaniel Cesario29e12402022-03-14 09:45:23 -06003631 if (feedback_struct && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
3632 const auto feedback_count = feedback_struct->pipelineStageCreationFeedbackCount;
Nathaniel Cesario6a0ce2f2022-04-02 21:47:54 -06003633 if ((feedback_count != 0) && (feedback_count != 1)) {
Nathaniel Cesario29e12402022-03-14 09:45:23 -06003634 skip |= LogError(
3635 device, "VUID-VkComputePipelineCreateInfo-pipelineStageCreationFeedbackCount-06566",
3636 "vkCreateComputePipelines(): VkPipelineCreationFeedbackCreateInfo::pipelineStageCreationFeedbackCount (%" PRIu32
3637 ") is not 0 or 1 in pCreateInfos[%" PRIu32 "].",
3638 feedback_count, i);
3639 }
Peter Chen85366392019-05-14 15:20:11 -04003640 }
sfricke-samsungc5227152020-02-09 17:36:31 -08003641
3642 // Make sure compute stage is selected
3643 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003644 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003645 "vkCreateComputePipelines(): the pCreateInfo[%" PRIu32
3646 "].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003647 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08003648 }
sourav parmarcd5fb182020-07-17 12:58:44 -07003649
sfricke-samsungeb549012021-04-16 01:25:51 -07003650 const VkPipelineCreateFlags flags = pCreateInfos[i].flags;
3651 // Validate no flags not allowed are used
3652 if ((flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003653 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03364",
3654 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3655 "]->flags (0x%x) must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.",
3656 i, flags);
sfricke-samsungeb549012021-04-16 01:25:51 -07003657 }
3658 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
3659 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03365",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003660 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3661 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003662 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
3663 i, flags);
3664 }
3665 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
3666 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03366",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003667 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3668 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003669 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
3670 i, flags);
3671 }
3672 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
3673 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03367",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003674 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3675 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003676 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
3677 i, flags);
3678 }
3679 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
3680 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03368",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003681 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3682 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003683 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
3684 i, flags);
3685 }
3686 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
3687 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03369",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003688 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3689 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003690 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
3691 i, flags);
3692 }
3693 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
3694 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03370",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003695 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3696 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003697 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
3698 i, flags);
3699 }
3700 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
3701 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03576",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003702 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3703 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003704 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
3705 i, flags);
3706 }
ziga-lunargf51e65f2021-07-18 23:51:57 +02003707 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) != 0) {
3708 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-04945",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003709 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3710 "]->flags (0x%x) must not include "
ziga-lunargf51e65f2021-07-18 23:51:57 +02003711 "VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV.",
3712 i, flags);
3713 }
sfricke-samsungeb549012021-04-16 01:25:51 -07003714 if ((flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) != 0) {
3715 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-02874",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003716 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3717 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003718 "VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.",
3719 i, flags);
sourav parmarcd5fb182020-07-17 12:58:44 -07003720 }
ziga-lunarg065f2402021-07-22 11:56:05 +02003721 if (flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
3722 if (pCreateInfos[i].basePipelineIndex != -1) {
3723 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
3724 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-00699",
3725 "vkCreateComputePipelines parameter, pCreateInfos[%" PRIu32
3726 "]->basePipelineHandle, must be VK_NULL_HANDLE if pCreateInfos->flags contains the "
3727 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and pCreateInfos->basePipelineIndex is not -1.",
3728 i);
3729 }
3730 }
3731
3732 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
3733 if (pCreateInfos[i].basePipelineIndex != -1) {
3734 skip |= LogError(
3735 device, "VUID-VkComputePipelineCreateInfo-flags-00700",
3736 "vkCreateComputePipelines parameter, pCreateInfos[%" PRIu32
3737 "]->basePipelineIndex, must be -1 if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT "
3738 "flag and pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
3739 i);
3740 }
3741 } else {
3742 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
3743 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-00698",
3744 "vkCreateComputePipelines parameter pCreateInfos[%" PRIu32 "]->basePipelineIndex (%" PRIi32
3745 ") must be a valid index into the pCreateInfos array, of size %" PRIu32 ".",
3746 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
3747 }
3748 }
3749 }
ziga-lunargc6341372021-07-28 12:57:42 +02003750
3751 std::stringstream msg;
3752 msg << "pCreateInfos[%" << i << "].stage";
3753 ValidatePipelineShaderStageCreateInfo("vkCreateComputePipelines", msg.str().c_str(), &pCreateInfos[i].stage);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003754 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003755 return skip;
3756}
3757
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003758bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003759 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003760 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003761
3762 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003763 const auto &features = physical_device_features;
3764 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003765
John Zulauf71968502017-10-26 13:51:15 -06003766 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
3767 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003768 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
3769 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
3770 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
3771 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06003772 }
3773
3774 // Anistropy cannot be enabled in sampler unless enabled as a feature
3775 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003776 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
3777 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
3778 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06003779 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003780 }
John Zulauf71968502017-10-26 13:51:15 -06003781
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003782 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
3783 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003784 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
3785 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3786 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3787 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003788 }
3789 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003790 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
3791 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3792 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3793 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003794 }
3795 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003796 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
3797 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3798 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
3799 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003800 }
3801 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
3802 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3803 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
3804 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003805 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
3806 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3807 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
3808 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
3809 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3810 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003811 }
3812 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003813 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
3814 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
3815 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06003816 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003817 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003818 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
3819 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
3820 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003821 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003822 }
3823
3824 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
ziga-lunarg9fc3e9b2022-04-11 12:04:56 +02003825 const auto *sampler_reduction = LvlFindInChain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003826 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003827 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
3828 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
sfricke-samsung85252fb2020-05-08 20:44:06 -07003829 if (sampler_reduction != nullptr) {
3830 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
sjfricke751b7092022-04-12 21:49:37 +09003831 skip |= LogError(device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
3832 "vkCreateSampler(): copmareEnable is true so the sampler reduction mode must be "
3833 "VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
sfricke-samsung85252fb2020-05-08 20:44:06 -07003834 }
3835 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003836 }
ziga-lunarg9fc3e9b2022-04-11 12:04:56 +02003837 if (sampler_reduction && sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
sjfricke751b7092022-04-12 21:49:37 +09003838 if (!IsExtEnabled(device_extensions.vk_ext_sampler_filter_minmax)) {
ziga-lunarg9fc3e9b2022-04-11 12:04:56 +02003839 skip |= LogError(device, "VUID-VkSamplerCreateInfo-pNext-06726",
sjfricke751b7092022-04-12 21:49:37 +09003840 "vkCreateSampler(): sampler reduction mode is %s, but extension %s is not enabled.",
ziga-lunarg9fc3e9b2022-04-11 12:04:56 +02003841 string_VkSamplerReductionMode(sampler_reduction->reductionMode),
3842 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
3843 }
3844 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003845
3846 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
3847 // valid VkBorderColor value
3848 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3849 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3850 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003851 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
3852 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003853 }
3854
John Zulauf275805c2017-10-26 15:34:49 -06003855 // Checks for the IMG cubic filtering extension
sfricke-samsung45996a42021-09-16 13:45:27 -07003856 if (IsExtEnabled(device_extensions.vk_img_filter_cubic)) {
John Zulauf275805c2017-10-26 15:34:49 -06003857 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
3858 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003859 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
3860 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
3861 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06003862 }
3863 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003864
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003865 // Check for valid Lod range
3866 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003867 skip |=
3868 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
3869 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003870 }
3871
3872 // Check mipLodBias to device limit
3873 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003874 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
3875 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
3876 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003877 }
3878
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003879 const auto *sampler_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003880 if (sampler_conversion != nullptr) {
3881 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3882 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3883 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3884 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003885 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003886 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003887 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
3888 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
3889 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
3890 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
3891 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
3892 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
3893 }
3894 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02003895
3896 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
3897 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
3898 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
3899 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3900 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3901 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
3902 }
3903 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
3904 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
3905 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3906 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3907 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
3908 }
3909 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
3910 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
3911 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3912 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
3913 pCreateInfo->minLod, pCreateInfo->maxLod);
3914 }
3915 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3916 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
3917 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3918 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
3919 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
3920 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3921 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
3922 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
3923 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3924 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
3925 }
3926 if (pCreateInfo->anisotropyEnable) {
3927 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
3928 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3929 "pCreateInfo->anisotropyEnable must be VK_FALSE");
3930 }
3931 if (pCreateInfo->compareEnable) {
3932 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
3933 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3934 "pCreateInfo->compareEnable must be VK_FALSE");
3935 }
3936 if (pCreateInfo->unnormalizedCoordinates) {
3937 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
3938 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3939 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
3940 }
3941 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003942
Piers Daniell833b9492021-11-20 11:47:10 -07003943 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
3944 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
3945 if (!IsExtEnabled(device_extensions.vk_ext_custom_border_color)) {
3946 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
3947 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
3948 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
3949 }
3950 auto custom_create_info = LvlFindInChain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
3951 if (!custom_create_info) {
3952 skip |= LogError(
3953 device, "VUID-VkSamplerCreateInfo-borderColor-04011",
3954 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
3955 "struct in pNext chain.\n",
3956 string_VkBorderColor(pCreateInfo->borderColor));
3957 } else {
3958 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
3959 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT &&
3960 !FormatIsSampledInt(custom_create_info->format)) ||
3961 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
3962 !FormatIsSampledFloat(custom_create_info->format)))) {
3963 skip |=
3964 LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
Tony-LunarG7337b312020-04-15 16:40:25 -06003965 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
3966 "whose type does not match\n",
3967 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
Piers Daniell833b9492021-11-20 11:47:10 -07003968 ;
3969 }
3970 }
3971 }
3972
3973 const auto *border_color_component_mapping =
3974 LvlFindInChain<VkSamplerBorderColorComponentMappingCreateInfoEXT>(pCreateInfo->pNext);
3975 if (border_color_component_mapping) {
3976 const auto *border_color_swizzle_features =
3977 LvlFindInChain<VkPhysicalDeviceBorderColorSwizzleFeaturesEXT>(device_createinfo_pnext);
3978 bool border_color_swizzle_features_enabled =
3979 border_color_swizzle_features && border_color_swizzle_features->borderColorSwizzle;
3980 if (!border_color_swizzle_features_enabled) {
3981 skip |= LogError(device, "VUID-VkSamplerBorderColorComponentMappingCreateInfoEXT-borderColorSwizzle-06437",
3982 "vkCreateSampler(): The borderColorSwizzle feature must be enabled to use "
3983 "VkPhysicalDeviceBorderColorSwizzleFeaturesEXT");
Tony-LunarG7337b312020-04-15 16:40:25 -06003984 }
3985 }
3986 }
3987
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003988 return skip;
3989}
3990
ziga-lunarg8a4d3192021-10-13 19:54:19 +02003991bool StatelessValidation::ValidateMutableDescriptorTypeCreateInfo(const VkDescriptorSetLayoutCreateInfo &create_info,
3992 const VkMutableDescriptorTypeCreateInfoVALVE &mutable_create_info,
3993 const char *func_name) const {
3994 bool skip = false;
3995
3996 for (uint32_t i = 0; i < create_info.bindingCount; ++i) {
3997 uint32_t mutable_type_count = 0;
3998 if (mutable_create_info.mutableDescriptorTypeListCount > i) {
3999 mutable_type_count = mutable_create_info.pMutableDescriptorTypeLists[i].descriptorTypeCount;
4000 }
4001 if (create_info.pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
4002 if (mutable_type_count == 0) {
4003 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-descriptorTypeCount-04597",
4004 "%s: VkDescriptorSetLayoutCreateInfo::pBindings[%" PRIu32
4005 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE, but "
4006 "VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4007 "].descriptorTypeCount is 0.",
4008 func_name, i, i);
4009 }
4010 } else {
4011 if (mutable_type_count > 0) {
4012 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-descriptorTypeCount-04599",
4013 "%s: VkDescriptorSetLayoutCreateInfo::pBindings[%" PRIu32
4014 "].descriptorType is %s, but "
4015 "VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4016 "].descriptorTypeCount is not 0.",
4017 func_name, i, string_VkDescriptorType(create_info.pBindings[i].descriptorType), i);
4018 }
4019 }
4020 }
4021
4022 for (uint32_t j = 0; j < mutable_create_info.mutableDescriptorTypeListCount; ++j) {
4023 for (uint32_t k = 0; k < mutable_create_info.pMutableDescriptorTypeLists[j].descriptorTypeCount; ++k) {
4024 switch (mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[k]) {
4025 case VK_DESCRIPTOR_TYPE_MUTABLE_VALVE:
4026 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04600",
4027 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4028 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE.",
4029 func_name, j, k);
4030 break;
4031 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
4032 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04601",
4033 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4034 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC.",
4035 func_name, j, k);
4036 break;
4037 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
4038 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04602",
4039 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4040 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC.",
4041 func_name, j, k);
4042 break;
4043 case VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT:
4044 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04603",
4045 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4046 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT.",
4047 func_name, j, k);
4048 break;
4049 default:
4050 break;
4051 }
4052 for (uint32_t l = k + 1; l < mutable_create_info.pMutableDescriptorTypeLists[j].descriptorTypeCount; ++l) {
4053 if (mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[k] ==
4054 mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[l]) {
4055 skip |=
4056 LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04598",
4057 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4058 "].pDescriptorTypes[%" PRIu32
4059 "] and VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4060 "].pDescriptorTypes[%" PRIu32 "] are both %s.",
4061 func_name, j, k, j, l,
4062 string_VkDescriptorType(mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[k]));
4063 }
4064 }
4065 }
4066 }
4067
4068 return skip;
4069}
4070
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004071bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
4072 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
4073 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004074 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004075 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004076
ziga-lunargfc6896f2021-10-15 18:46:12 +02004077 const auto *mutable_descriptor_type = LvlFindInChain<VkMutableDescriptorTypeCreateInfoVALVE>(pCreateInfo->pNext);
4078 const auto *mutable_descriptor_type_features = LvlFindInChain<VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE>(device_createinfo_pnext);
4079 bool mutable_descriptor_type_features_enabled =
4080 mutable_descriptor_type_features && mutable_descriptor_type_features->mutableDescriptorType == VK_TRUE;
4081
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004082 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4083 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
4084 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
4085 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004086 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
4087 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
4088 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
4089 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
4090 ++descriptor_index) {
4091 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07004092 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004093 "vkCreateDescriptorSetLayout: required parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004094 "pCreateInfo->pBindings[%" PRIu32 "].pImmutableSamplers[%" PRIu32
4095 "] specified as VK_NULL_HANDLE",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004096 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004097 }
4098 }
4099 }
4100
4101 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
4102 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
4103 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004104 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004105 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%" PRIu32
4106 "].descriptorCount is not 0, "
4107 "pCreateInfo->pBindings[%" PRIu32
4108 "].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004109 "values.",
4110 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004111 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07004112
4113 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
4114 (pCreateInfo->pBindings[i].stageFlags != 0) &&
4115 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004116 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
4117 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%" PRIu32
4118 "].descriptorCount is not 0 and "
4119 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%" PRIu32
4120 "].stageFlags "
4121 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
4122 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
Spencer Fricke84d0cc02020-03-16 17:21:59 -07004123 }
ziga-lunargfc6896f2021-10-15 18:46:12 +02004124
4125 if (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
4126 if (!mutable_descriptor_type) {
4127 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-descriptorType-04593",
4128 "vkCreateDescriptorSetLayout(): pCreateInfo->pBindings[%" PRIu32
4129 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE but "
4130 "VkMutableDescriptorTypeCreateInfoVALVE is not included in the pNext chain.",
4131 i);
4132 }
4133 if (pCreateInfo->pBindings[i].pImmutableSamplers) {
4134 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-descriptorType-04594",
4135 "vkCreateDescriptorSetLayout(): pCreateInfo->pBindings[%" PRIu32
4136 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE but "
4137 "pImmutableSamplers is not NULL.",
4138 i);
4139 }
4140 if (!mutable_descriptor_type_features_enabled) {
4141 skip |= LogError(
4142 device, "VUID-VkDescriptorSetLayoutCreateInfo-mutableDescriptorType-04595",
4143 "vkCreateDescriptorSetLayout(): pCreateInfo->pBindings[%" PRIu32
4144 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE but "
4145 "VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType feature is not enabled.",
4146 i);
4147 }
4148 }
4149
4150 if (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR &&
4151 pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
4152 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04591",
4153 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains "
4154 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR, but pCreateInfo->pBindings[%" PRIu32
4155 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE.", i);
4156 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004157 }
4158 }
ziga-lunarg8a4d3192021-10-13 19:54:19 +02004159
4160 if (mutable_descriptor_type) {
4161 ValidateMutableDescriptorTypeCreateInfo(*pCreateInfo, *mutable_descriptor_type,
4162 "vkDescriptorSetLayoutCreateInfo");
4163 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004164 }
ziga-lunargfc6896f2021-10-15 18:46:12 +02004165 if (pCreateInfo) {
4166 if ((pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR) &&
4167 (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE)) {
4168 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04590",
4169 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains both "
4170 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR and "
4171 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE.");
4172 }
4173 if ((pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT) &&
4174 (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE)) {
4175 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04592",
4176 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains both "
4177 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT and "
4178 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE.");
4179 }
4180 if (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE &&
4181 !mutable_descriptor_type_features_enabled) {
4182 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04596",
4183 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains "
4184 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE, but "
4185 "VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType feature is not enabled.");
4186 }
4187 }
4188
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004189 return skip;
4190}
4191
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004192bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
4193 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004194 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004195 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4196 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
4197 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004198 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
4199 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004200}
4201
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004202bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
4203 const VkWriteDescriptorSet *pDescriptorWrites,
Mike Schuchardt979898a2022-01-11 10:46:59 -08004204 const bool isPushDescriptor) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004205 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004206
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004207 if (pDescriptorWrites != NULL) {
4208 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
4209 // descriptorCount must be greater than 0
4210 if (pDescriptorWrites[i].descriptorCount == 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004211 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
4212 "%s(): parameter pDescriptorWrites[%" PRIu32 "].descriptorCount must be greater than 0.",
4213 vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004214 }
4215
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004216 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
Mike Schuchardt979898a2022-01-11 10:46:59 -08004217 if (!isPushDescriptor) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004218 // dstSet must be a valid VkDescriptorSet handle
4219 skip |= validate_required_handle(vkCallingFunction,
4220 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
4221 pDescriptorWrites[i].dstSet);
4222 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004223
4224 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
4225 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
4226 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
4227 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
4228 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004229 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mike Schuchardt979898a2022-01-11 10:46:59 -08004230 if (!isPushDescriptor) {
4231 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
4232 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or
4233 // VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pImageInfo must be a pointer to an array of descriptorCount valid
4234 // VkDescriptorImageInfo structures. Valid imageView handles are checked in
4235 // ObjectLifetimes::ValidateDescriptorWrite.
4236 skip |= LogError(
4237 device, "VUID-vkUpdateDescriptorSets-pDescriptorWrites-06493",
4238 "%s(): if pDescriptorWrites[%" PRIu32
4239 "].descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
4240 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
4241 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%" PRIu32 "].pImageInfo must not be NULL.",
4242 vkCallingFunction, i, i);
4243 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
4244 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
4245 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
4246 // If called from vkCmdPushDescriptorSetKHR, pImageInfo is only requred for descriptor types
4247 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, and
4248 // VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT
4249 skip |= LogError(device, "VUID-vkCmdPushDescriptorSetKHR-pDescriptorWrites-06494",
4250 "%s(): if pDescriptorWrites[%" PRIu32
4251 "].descriptorType is VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE "
4252 "or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%" PRIu32
4253 "].pImageInfo must not be NULL.",
4254 vkCallingFunction, i, i);
4255 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004256 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
4257 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05004258 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
4259 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004260 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
4261 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004262 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004263 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
4264 ParameterName::IndexVector{i, descriptor_index}),
4265 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06004266 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004267 }
4268 }
4269 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
4270 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
4271 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
4272 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
4273 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
4274 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
4275 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05004276 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004277 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004278 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004279 "%s(): if pDescriptorWrites[%" PRIu32
4280 "].descriptorType is "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004281 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
4282 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004283 "pDescriptorWrites[%" PRIu32 "].pBufferInfo must not be NULL.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004284 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004285 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05004286 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004287 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05004288 if (robustness2_features && robustness2_features->nullDescriptor) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004289 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
4290 ++descriptor_index) {
4291 if (pDescriptorWrites[i].pBufferInfo[descriptor_index].buffer == VK_NULL_HANDLE &&
4292 (pDescriptorWrites[i].pBufferInfo[descriptor_index].offset != 0 ||
4293 pDescriptorWrites[i].pBufferInfo[descriptor_index].range != VK_WHOLE_SIZE)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05004294 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004295 "%s(): if pDescriptorWrites[%" PRIu32
4296 "].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01004297 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004298 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptor_index].offset,
4299 pDescriptorWrites[i].pBufferInfo[descriptor_index].range);
Jeff Bolz165818a2020-05-08 11:19:03 -05004300 }
4301 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004302 }
4303 }
4304 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
4305 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05004306 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004307 }
4308
4309 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
4310 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004311 VkDeviceSize uniform_alignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004312 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
4313 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004314 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06004315 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004316 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004317 "%s(): pDescriptorWrites[%" PRIu32 "].pBufferInfo[%" PRIu32 "].offset (0x%" PRIxLEAST64
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004318 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004319 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004320 }
4321 }
4322 }
4323 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
4324 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004325 VkDeviceSize storage_alignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004326 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
4327 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004328 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06004329 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004330 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004331 "%s(): pDescriptorWrites[%" PRIu32 "].pBufferInfo[%" PRIu32 "].offset (0x%" PRIxLEAST64
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004332 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004333 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004334 }
4335 }
4336 }
4337 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004338 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
4339 // or VkWriteDescriptorSetInlineUniformBlockEX
sourav parmarbcee7512020-12-28 14:34:49 -08004340 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004341 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08004342 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
4343 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
4344 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
4345 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004346 "accelerationStructureCount %" PRIu32 " member equals descriptorCount %" PRIu32 ".",
sourav parmarbcee7512020-12-28 14:34:49 -08004347 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
4348 pDescriptorWrites[i].descriptorCount);
4349 }
4350 // further checks only if we have right structtype
4351 if (pnext_struct) {
4352 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
4353 skip |= LogError(
4354 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004355 "%s(): accelerationStructureCount %" PRIu32 " must be equal to descriptorCount %" PRIu32
4356 " in the extended structure "
sourav parmarbcee7512020-12-28 14:34:49 -08004357 ".",
4358 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07004359 }
sourav parmarbcee7512020-12-28 14:34:49 -08004360 if (pnext_struct->accelerationStructureCount == 0) {
4361 skip |= LogError(device,
4362 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004363 "%s(): accelerationStructureCount must be greater than 0 .", vkCallingFunction);
sourav parmarbcee7512020-12-28 14:34:49 -08004364 }
4365 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004366 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08004367 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
4368 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
4369 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
4370 skip |= LogError(device,
4371 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-pAccelerationStructures-03580",
4372 "%s(): If the nullDescriptor feature is not enabled, each member of "
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004373 "pAccelerationStructures must not be VK_NULL_HANDLE.", vkCallingFunction);
sourav parmarcd5fb182020-07-17 12:58:44 -07004374 }
4375 }
4376 }
sourav parmarbcee7512020-12-28 14:34:49 -08004377 }
4378 } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004379 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureNV>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08004380 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
4381 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-03817",
4382 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV, the pNext"
4383 "chain must include a VkWriteDescriptorSetAccelerationStructureNV structure whose "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004384 "accelerationStructureCount %" PRIu32 " member equals descriptorCount %" PRIu32 ".",
sourav parmarbcee7512020-12-28 14:34:49 -08004385 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
4386 pDescriptorWrites[i].descriptorCount);
4387 }
4388 // further checks only if we have right structtype
4389 if (pnext_struct) {
4390 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
4391 skip |= LogError(
4392 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-03747",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004393 "%s(): accelerationStructureCount %" PRIu32 " must be equal to descriptorCount %" PRIu32
4394 " in the extended structure "
sourav parmarbcee7512020-12-28 14:34:49 -08004395 ".",
4396 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmarcd5fb182020-07-17 12:58:44 -07004397 }
sourav parmarbcee7512020-12-28 14:34:49 -08004398 if (pnext_struct->accelerationStructureCount == 0) {
4399 skip |= LogError(device,
4400 "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-arraylength",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004401 "%s(): accelerationStructureCount must be greater than 0 .", vkCallingFunction);
sourav parmarbcee7512020-12-28 14:34:49 -08004402 }
4403 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004404 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08004405 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
4406 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
4407 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
4408 skip |= LogError(device,
4409 "VUID-VkWriteDescriptorSetAccelerationStructureNV-pAccelerationStructures-03749",
4410 "%s(): If the nullDescriptor feature is not enabled, each member of "
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004411 "pAccelerationStructures must not be VK_NULL_HANDLE.", vkCallingFunction);
sourav parmarcd5fb182020-07-17 12:58:44 -07004412 }
4413 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004414 }
4415 }
4416 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004417 }
4418 }
4419 return skip;
4420}
4421
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004422bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
4423 const VkWriteDescriptorSet *pDescriptorWrites,
4424 uint32_t descriptorCopyCount,
4425 const VkCopyDescriptorSet *pDescriptorCopies) const {
Mike Schuchardt979898a2022-01-11 10:46:59 -08004426 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites, false);
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004427}
4428
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004429bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004430 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004431 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004432 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
4433}
4434
sfricke-samsung681ab7b2020-10-29 01:53:35 -07004435bool StatelessValidation::manual_PreCallValidateCreateRenderPass2(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
4436 const VkAllocationCallbacks *pAllocator,
4437 VkRenderPass *pRenderPass) const {
4438 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
4439}
4440
Mike Schuchardt2df08912020-12-15 16:28:09 -08004441bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004442 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004443 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004444 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
4445}
4446
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004447bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
4448 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004449 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004450 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004451
4452 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4453 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
4454 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004455 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
4456 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004457 return skip;
4458}
4459
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004460bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004461 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004462 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02004463
4464 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
4465 const char *cmd_name = "vkBeginCommandBuffer";
Tony-LunarG3c287f62020-12-17 12:39:49 -07004466 bool cb_is_secondary;
4467 {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06004468 auto lock = CBReadLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07004469 cb_is_secondary = (secondary_cb_map.find(commandBuffer) != secondary_cb_map.end());
4470 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004471
Tony-LunarG3c287f62020-12-17 12:39:49 -07004472 if (cb_is_secondary) {
4473 // Implicit VUs
4474 // validate only sType here; pointer has to be validated in core_validation
4475 const bool k_not_required = false;
4476 const char *k_no_vuid = nullptr;
4477 const VkCommandBufferInheritanceInfo *info = pBeginInfo->pInheritanceInfo;
4478 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004479 info, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, k_not_required, k_no_vuid,
4480 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004481
Tony-LunarG3c287f62020-12-17 12:39:49 -07004482 if (info) {
4483 const VkStructureType allowed_structs_vk_command_buffer_inheritance_info[] = {
David Zhao Akeley44139b12021-04-26 16:16:13 -07004484 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT,
amhagana448ea52021-11-02 14:09:14 -04004485 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_RENDERING_INFO_KHR,
4486 VK_STRUCTURE_TYPE_ATTACHMENT_SAMPLE_COUNT_INFO_AMD,
David Zhao Akeley44139b12021-04-26 16:16:13 -07004487 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_VIEWPORT_SCISSOR_INFO_NV};
Tony-LunarG3c287f62020-12-17 12:39:49 -07004488 skip |= validate_struct_pnext(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004489 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT",
4490 info->pNext, ARRAY_SIZE(allowed_structs_vk_command_buffer_inheritance_info),
4491 allowed_structs_vk_command_buffer_inheritance_info, GeneratedVulkanHeaderVersion,
4492 "VUID-VkCommandBufferInheritanceInfo-pNext-pNext", "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004493
Tony-LunarG3c287f62020-12-17 12:39:49 -07004494 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", info->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004495
Tony-LunarG3c287f62020-12-17 12:39:49 -07004496 // Explicit VUs
4497 if (!physical_device_features.inheritedQueries && info->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004498 skip |= LogError(
Tony-LunarG3c287f62020-12-17 12:39:49 -07004499 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
4500 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
4501 cmd_name);
4502 }
4503
4504 if (physical_device_features.inheritedQueries) {
4505 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004506 AllVkQueryControlFlagBits, info->queryFlags, kOptionalFlags,
4507 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
4508 } else { // !inheritedQueries
Tony-LunarG3c287f62020-12-17 12:39:49 -07004509 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", info->queryFlags,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004510 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Tony-LunarG3c287f62020-12-17 12:39:49 -07004511 }
4512
4513 if (physical_device_features.pipelineStatisticsQuery) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004514 skip |=
4515 validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
4516 AllVkQueryPipelineStatisticFlagBits, info->pipelineStatistics, kOptionalFlags,
4517 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
4518 } else { // !pipelineStatisticsQuery
4519 skip |=
4520 validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", info->pipelineStatistics,
4521 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Tony-LunarG3c287f62020-12-17 12:39:49 -07004522 }
4523
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004524 const auto *conditional_rendering = LvlFindInChain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(info->pNext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07004525 if (conditional_rendering) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004526 const auto *cr_features = LvlFindInChain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07004527 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
4528 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
4529 skip |= LogError(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004530 commandBuffer,
4531 "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Tony-LunarG3c287f62020-12-17 12:39:49 -07004532 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
4533 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
4534 }
Petr Kraus139757b2019-08-15 17:19:33 +02004535 }
ziga-lunarg9d019132021-07-19 01:05:31 +02004536
4537 auto p_inherited_viewport_scissor_info = LvlFindInChain<VkCommandBufferInheritanceViewportScissorInfoNV>(info->pNext);
4538 if (p_inherited_viewport_scissor_info != nullptr && !physical_device_features.multiViewport &&
4539 p_inherited_viewport_scissor_info->viewportScissor2D == VK_TRUE &&
4540 p_inherited_viewport_scissor_info->viewportDepthCount != 1) {
4541 skip |= LogError(commandBuffer, "VUID-VkCommandBufferInheritanceViewportScissorInfoNV-viewportScissor2D-04783",
4542 "vkBeginCommandBuffer: multiViewport feature is disabled, but "
4543 "VkCommandBufferInheritanceViewportScissorInfoNV::viewportScissor2D in "
4544 "pBeginInfo->pInheritanceInfo->pNext is VK_TRUE and viewportDepthCount is not 1.");
4545 }
Petr Kraus139757b2019-08-15 17:19:33 +02004546 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004547 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004548 return skip;
4549}
4550
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004551bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004552 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004553 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004554
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004555 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01004556 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004557 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
4558 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
4559 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01004560 }
4561 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004562 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
4563 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
4564 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01004565 }
4566 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01004567 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004568 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004569 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
4570 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4571 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4572 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004573 }
4574 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01004575
4576 if (pViewports) {
4577 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
4578 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06004579 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004580 skip |= manual_PreCallValidateViewport(
4581 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01004582 }
4583 }
4584
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004585 return skip;
4586}
4587
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004588bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004589 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004590 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004591
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004592 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004593 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004594 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
4595 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
4596 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004597 }
4598 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004599 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
4600 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
4601 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004602 }
4603 } else { // multiViewport enabled
4604 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004605 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004606 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
4607 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4608 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4609 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004610 }
4611 }
4612
Petr Kraus6260f0a2018-02-27 21:15:55 +01004613 if (pScissors) {
4614 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
4615 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004616
Petr Kraus6260f0a2018-02-27 21:15:55 +01004617 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004618 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
4619 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
4620 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004621 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004622
Petr Kraus6260f0a2018-02-27 21:15:55 +01004623 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004624 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
4625 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
4626 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004627 }
4628
4629 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
4630 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004631 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
4632 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4633 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4634 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004635 }
4636
4637 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
4638 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004639 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
4640 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4641 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4642 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004643 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004644 }
4645 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01004646
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004647 return skip;
4648}
4649
Jeff Bolz5c801d12019-10-09 10:38:45 -05004650bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01004651 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01004652
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004653 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004654 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
4655 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01004656 }
4657
4658 return skip;
4659}
4660
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004661bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004662 uint32_t drawCount, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004663 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004664
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004665 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski41ce65b2020-10-30 12:17:06 -06004666 skip |= LogError(device, "VUID-vkCmdDrawIndirect-drawCount-02718",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004667 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %" PRIu32 "",
4668 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004669 }
4670 if (drawCount > device_limits.maxDrawIndirectCount) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004671 skip |=
4672 LogError(commandBuffer, "VUID-vkCmdDrawIndirect-drawCount-02719",
4673 "CmdDrawIndirect(): drawCount (%" PRIu32 ") is not less than or equal to the maximum allowed (%" PRIu32 ").",
4674 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004675 }
4676 return skip;
4677}
4678
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004679bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004680 VkDeviceSize offset, uint32_t drawCount,
4681 uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004682 bool skip = false;
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004683 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004684 skip |=
4685 LogError(device, "VUID-vkCmdDrawIndexedIndirect-drawCount-02718",
4686 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %" PRIu32 "",
4687 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004688 }
4689 if (drawCount > device_limits.maxDrawIndirectCount) {
4690 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirect-drawCount-02719",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004691 "CmdDrawIndexedIndirect(): drawCount (%" PRIu32
4692 ") is not less than or equal to the maximum allowed (%" PRIu32 ").",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004693 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004694 }
4695 return skip;
4696}
4697
sfricke-samsungf692b972020-05-02 08:00:45 -07004698bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
4699 VkDeviceSize countBufferOffset, bool khr) const {
4700 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004701 const char *api_name = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07004702 if (offset & 3) {
4703 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004704 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07004705 }
4706
4707 if (countBufferOffset & 3) {
4708 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004709 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07004710 countBufferOffset);
4711 }
4712 return skip;
4713}
4714
4715bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
4716 VkDeviceSize offset, VkBuffer countBuffer,
4717 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
4718 uint32_t stride) const {
4719 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
4720}
4721
4722bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
4723 VkDeviceSize offset, VkBuffer countBuffer,
4724 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
4725 uint32_t stride) const {
4726 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
4727}
4728
4729bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
4730 VkDeviceSize countBufferOffset, bool khr) const {
4731 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004732 const char *api_name = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07004733 if (offset & 3) {
4734 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004735 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07004736 }
4737
4738 if (countBufferOffset & 3) {
4739 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004740 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07004741 countBufferOffset);
4742 }
4743 return skip;
4744}
4745
4746bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
4747 VkDeviceSize offset, VkBuffer countBuffer,
4748 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
4749 uint32_t stride) const {
4750 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
4751}
4752
4753bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
4754 VkDeviceSize offset, VkBuffer countBuffer,
4755 VkDeviceSize countBufferOffset,
4756 uint32_t maxDrawCount, uint32_t stride) const {
4757 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
4758}
4759
Tony-LunarG4490de42021-06-21 15:49:19 -06004760bool StatelessValidation::manual_PreCallValidateCmdDrawMultiEXT(VkCommandBuffer commandBuffer, uint32_t drawCount,
4761 const VkMultiDrawInfoEXT *pVertexInfo, uint32_t instanceCount,
4762 uint32_t firstInstance, uint32_t stride) const {
4763 bool skip = false;
4764 if (stride & 3) {
4765 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiEXT-stride-04936",
4766 "CmdDrawMultiEXT: parameter, uint32_t stride (%" PRIu32 ") is not a multiple of 4.", stride);
4767 }
4768 if (drawCount && nullptr == pVertexInfo) {
4769 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiEXT-drawCount-04935",
4770 "CmdDrawMultiEXT: parameter, VkMultiDrawInfoEXT *pVertexInfo must be a valid pointer to memory containing "
4771 "one or more valid instances of VkMultiDrawInfoEXT structures");
4772 }
4773 return skip;
4774}
4775
4776bool StatelessValidation::manual_PreCallValidateCmdDrawMultiIndexedEXT(VkCommandBuffer commandBuffer, uint32_t drawCount,
4777 const VkMultiDrawIndexedInfoEXT *pIndexInfo,
4778 uint32_t instanceCount, uint32_t firstInstance,
4779 uint32_t stride, const int32_t *pVertexOffset) const {
4780 bool skip = false;
4781 if (stride & 3) {
4782 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiIndexedEXT-stride-04941",
4783 "CmdDrawMultiIndexedEXT: parameter, uint32_t stride (%" PRIu32 ") is not a multiple of 4.", stride);
4784 }
4785 if (drawCount && nullptr == pIndexInfo) {
4786 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiIndexedEXT-drawCount-04940",
4787 "CmdDrawMultiIndexedEXT: parameter, VkMultiDrawIndexedInfoEXT *pIndexInfo must be a valid pointer to "
4788 "memory containing one or more valid instances of VkMultiDrawIndexedInfoEXT structures");
4789 }
4790 return skip;
4791}
4792
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004793bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
4794 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004795 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004796 bool skip = false;
4797 for (uint32_t rect = 0; rect < rectCount; rect++) {
4798 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004799 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004800 "CmdClearAttachments(): pRects[%" PRIu32 "].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004801 }
sfricke-samsung10867682020-04-25 02:20:39 -07004802 if (pRects[rect].rect.extent.width == 0) {
4803 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004804 "CmdClearAttachments(): pRects[%" PRIu32 "].rect.extent.width is zero.", rect);
sfricke-samsung10867682020-04-25 02:20:39 -07004805 }
4806 if (pRects[rect].rect.extent.height == 0) {
4807 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004808 "CmdClearAttachments(): pRects[%" PRIu32 "].rect.extent.height is zero.", rect);
sfricke-samsung10867682020-04-25 02:20:39 -07004809 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004810 }
4811 return skip;
4812}
4813
Andrew Fobel3abeb992020-01-20 16:33:22 -05004814bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
4815 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4816 VkImageFormatProperties2 *pImageFormatProperties,
4817 const char *apiName) const {
4818 bool skip = false;
4819
4820 if (pImageFormatInfo != nullptr) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004821 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pImageFormatInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05004822 if (image_stencil_struct != nullptr) {
4823 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
4824 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
4825 // No flags other than the legal attachment bits may be set
4826 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
4827 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004828 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
4829 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
4830 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
4831 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
4832 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05004833 }
4834 }
4835 }
ziga-lunargd3da2532021-08-11 11:50:12 +02004836 const auto image_drm_format = LvlFindInChain<VkPhysicalDeviceImageDrmFormatModifierInfoEXT>(pImageFormatInfo->pNext);
4837 if (image_drm_format) {
4838 if (pImageFormatInfo->tiling != VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4839 skip |= LogError(
4840 physicalDevice, "VUID-VkPhysicalDeviceImageFormatInfo2-tiling-02249",
4841 "%s(): pNext chain of VkPhysicalDeviceImageFormatInfo2 includes VkPhysicalDeviceImageDrmFormatModifierInfoEXT, "
4842 "but tiling (%s) is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.",
4843 apiName, string_VkImageTiling(pImageFormatInfo->tiling));
4844 }
ziga-lunarg27e256d2021-10-07 23:38:12 +02004845 if (image_drm_format->sharingMode == VK_SHARING_MODE_CONCURRENT && image_drm_format->queueFamilyIndexCount <= 1) {
4846 skip |= LogError(
4847 physicalDevice, "VUID-VkPhysicalDeviceImageDrmFormatModifierInfoEXT-sharingMode-02315",
4848 "%s: pNext chain of VkPhysicalDeviceImageFormatInfo2 includes VkPhysicalDeviceImageDrmFormatModifierInfoEXT, "
4849 "with sharing mode VK_SHARING_MODE_CONCURRENT, but queueFamilyIndexCount is %" PRIu32 ".",
4850 apiName, image_drm_format->queueFamilyIndexCount);
4851 }
ziga-lunargd3da2532021-08-11 11:50:12 +02004852 } else {
4853 if (pImageFormatInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4854 skip |= LogError(
4855 physicalDevice, "VUID-VkPhysicalDeviceImageFormatInfo2-tiling-02249",
4856 "%s(): pNext chain of VkPhysicalDeviceImageFormatInfo2 does not include "
4857 "VkPhysicalDeviceImageDrmFormatModifierInfoEXT, but tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.",
4858 apiName);
4859 }
4860 }
4861 if (pImageFormatInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT &&
4862 (pImageFormatInfo->flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT)) {
4863 const auto format_list = LvlFindInChain<VkImageFormatListCreateInfo>(pImageFormatInfo->pNext);
4864 if (!format_list || format_list->viewFormatCount == 0) {
4865 skip |= LogError(
4866 physicalDevice, "VUID-VkPhysicalDeviceImageFormatInfo2-tiling-02313",
4867 "%s(): tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT and flags contain VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT "
4868 "bit, but the pNext chain does not include VkImageFormatListCreateInfo with non-zero viewFormatCount.",
4869 apiName);
4870 }
4871 }
Andrew Fobel3abeb992020-01-20 16:33:22 -05004872 }
4873
4874 return skip;
4875}
4876
4877bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
4878 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4879 VkImageFormatProperties2 *pImageFormatProperties) const {
4880 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
4881 "vkGetPhysicalDeviceImageFormatProperties2");
4882}
4883
4884bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
4885 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4886 VkImageFormatProperties2 *pImageFormatProperties) const {
4887 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
4888 "vkGetPhysicalDeviceImageFormatProperties2KHR");
4889}
4890
Lionel Landwerlin5fe52752020-07-22 08:18:14 +03004891bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties(
4892 VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage,
4893 VkImageCreateFlags flags, VkImageFormatProperties *pImageFormatProperties) const {
4894 bool skip = false;
4895
4896 if (tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4897 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceImageFormatProperties-tiling-02248",
4898 "vkGetPhysicalDeviceImageFormatProperties(): tiling must not be VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.");
4899 }
4900
4901 return skip;
4902}
4903
ziga-lunarg73b5ef22021-07-29 20:25:06 +02004904bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceVideoFormatPropertiesKHR(
4905 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceVideoFormatInfoKHR *pVideoFormatInfo,
4906 uint32_t *pVideoFormatPropertyCount, VkVideoFormatPropertiesKHR *pVideoFormatProperties) const {
4907 bool skip = false;
4908
4909 if ((pVideoFormatInfo->imageUsage & (VK_IMAGE_USAGE_VIDEO_DECODE_DST_BIT_KHR | VK_IMAGE_USAGE_VIDEO_DECODE_DPB_BIT_KHR |
4910 VK_IMAGE_USAGE_VIDEO_ENCODE_SRC_BIT_KHR | VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR)) == 0) {
4911 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceVideoFormatPropertiesKHR-imageUsage-04844",
4912 "vkGetPhysicalDeviceVideoFormatPropertiesKHR(): pVideoFormatInfo->imageUsage does not contain any of "
4913 "VK_IMAGE_USAGE_VIDEO_DECODE_DST_BIT_KHR, VK_IMAGE_USAGE_VIDEO_DECODE_DPB_BIT_KHR, "
4914 "VK_IMAGE_USAGE_VIDEO_ENCODE_SRC_BIT_KHR, or VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR.");
4915 }
4916
ziga-lunarg42f884b2021-08-25 16:13:20 +02004917 return skip;
ziga-lunarg73b5ef22021-07-29 20:25:06 +02004918}
4919
sfricke-samsung3999ef62020-02-09 17:05:59 -08004920bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
4921 uint32_t regionCount, const VkBufferCopy *pRegions) const {
4922 bool skip = false;
4923
4924 if (pRegions != nullptr) {
4925 for (uint32_t i = 0; i < regionCount; i++) {
4926 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004927 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004928 "vkCmdCopyBuffer() pRegions[%" PRIu32 "].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08004929 }
4930 }
4931 }
4932 return skip;
4933}
4934
Jeff Leger178b1e52020-10-05 12:22:23 -04004935bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2KHR(VkCommandBuffer commandBuffer,
4936 const VkCopyBufferInfo2KHR *pCopyBufferInfo) const {
4937 bool skip = false;
4938
4939 if (pCopyBufferInfo->pRegions != nullptr) {
4940 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
4941 if (pCopyBufferInfo->pRegions[i].size == 0) {
Tony-LunarGef035472021-11-02 10:23:33 -06004942 skip |= LogError(device, "VUID-VkBufferCopy2-size-01988",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004943 "vkCmdCopyBuffer2KHR() pCopyBufferInfo->pRegions[%" PRIu32 "].size must be greater than zero", i);
Jeff Leger178b1e52020-10-05 12:22:23 -04004944 }
4945 }
4946 }
4947 return skip;
4948}
4949
Tony-LunarGef035472021-11-02 10:23:33 -06004950bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2(VkCommandBuffer commandBuffer,
4951 const VkCopyBufferInfo2 *pCopyBufferInfo) const {
4952 bool skip = false;
4953
4954 if (pCopyBufferInfo->pRegions != nullptr) {
4955 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
4956 if (pCopyBufferInfo->pRegions[i].size == 0) {
4957 skip |= LogError(device, "VUID-VkBufferCopy2-size-01988",
4958 "vkCmdCopyBuffer2() pCopyBufferInfo->pRegions[%" PRIu32 "].size must be greater than zero", i);
4959 }
4960 }
4961 }
4962 return skip;
4963}
4964
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004965bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004966 VkDeviceSize dstOffset, VkDeviceSize dataSize,
4967 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004968 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004969
4970 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004971 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
4972 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4973 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004974 }
4975
4976 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004977 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
4978 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
4979 "), must be greater than zero and less than or equal to 65536.",
4980 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004981 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004982 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
4983 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4984 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004985 }
4986 return skip;
4987}
4988
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004989bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004990 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004991 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004992
4993 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004994 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
4995 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4996 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004997 }
4998
4999 if (size != VK_WHOLE_SIZE) {
5000 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005001 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005002 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
5003 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005004 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005005 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
5006 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005007 }
5008 }
5009 return skip;
5010}
5011
sfricke-samsunga1d00272021-03-10 21:37:41 -08005012bool StatelessValidation::ValidateSwapchainCreateInfo(const char *func_name, VkSwapchainCreateInfoKHR const *pCreateInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005013 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005014
5015 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005016 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
5017 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
5018 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
5019 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005020 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
sfricke-samsunga1d00272021-03-10 21:37:41 -08005021 "%s: if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
5022 "pCreateInfo->queueFamilyIndexCount must be greater than 1.",
5023 func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005024 }
5025
5026 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
5027 // queueFamilyIndexCount uint32_t values
5028 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005029 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
sfricke-samsunga1d00272021-03-10 21:37:41 -08005030 "%s: if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005031 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
sfricke-samsunga1d00272021-03-10 21:37:41 -08005032 "pCreateInfo->queueFamilyIndexCount uint32_t values.",
5033 func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005034 }
5035 }
5036
Dave Houlton413a6782018-05-22 13:01:54 -06005037 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
sfricke-samsunga1d00272021-03-10 21:37:41 -08005038 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005039
sfricke-samsunga1d00272021-03-10 21:37:41 -08005040 // Validate VK_KHR_image_format_list VkImageFormatListCreateInfo
5041 const auto format_list_info = LvlFindInChain<VkImageFormatListCreateInfo>(pCreateInfo->pNext);
5042 if (format_list_info) {
5043 const uint32_t viewFormatCount = format_list_info->viewFormatCount;
5044 if (((pCreateInfo->flags & VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR) == 0) && (viewFormatCount > 1)) {
5045 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-flags-04100",
5046 "%s: If the VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR is not set, then "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005047 "VkImageFormatListCreateInfo::viewFormatCount (%" PRIu32
5048 ") must be 0 or 1 if it is in the pNext chain.",
sfricke-samsunga1d00272021-03-10 21:37:41 -08005049 func_name, viewFormatCount);
5050 }
5051
5052 // Using the first format, compare the rest of the formats against it that they are compatible
5053 for (uint32_t i = 1; i < viewFormatCount; i++) {
5054 if (FormatCompatibilityClass(format_list_info->pViewFormats[0]) !=
5055 FormatCompatibilityClass(format_list_info->pViewFormats[i])) {
5056 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-pNext-04099",
5057 "%s: VkImageFormatListCreateInfo::pViewFormats[0] (%s) and "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005058 "VkImageFormatListCreateInfo::pViewFormats[%" PRIu32
5059 "] (%s) are not compatible in the pNext chain.",
sfricke-samsunga1d00272021-03-10 21:37:41 -08005060 func_name, string_VkFormat(format_list_info->pViewFormats[0]), i,
5061 string_VkFormat(format_list_info->pViewFormats[i]));
5062 }
5063 }
5064 }
5065
5066 // Validate VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR
5067 if ((pCreateInfo->flags & VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR) != 0) {
5068 if (!IsExtEnabled(device_extensions.vk_khr_swapchain_mutable_format)) {
5069 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
5070 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR which requires the "
5071 "VK_KHR_swapchain_mutable_format extension, which has not been enabled.",
5072 func_name);
5073 } else {
5074 if (format_list_info == nullptr) {
5075 skip |= LogError(
5076 device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
5077 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but the pNext chain of "
5078 "pCreateInfo does not contain an instance of VkImageFormatListCreateInfo.",
5079 func_name);
5080 } else if (format_list_info->viewFormatCount == 0) {
5081 skip |= LogError(
5082 device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
5083 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but the viewFormatCount "
5084 "member of VkImageFormatListCreateInfo in the pNext chain is zero.",
5085 func_name);
5086 } else {
5087 bool found_base_format = false;
5088 for (uint32_t i = 0; i < format_list_info->viewFormatCount; ++i) {
5089 if (format_list_info->pViewFormats[i] == pCreateInfo->imageFormat) {
5090 found_base_format = true;
5091 break;
5092 }
5093 }
5094 if (!found_base_format) {
5095 skip |=
5096 LogError(device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
5097 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but none of the "
5098 "elements of the pViewFormats member of VkImageFormatListCreateInfo match "
5099 "pCreateInfo->imageFormat.",
5100 func_name);
5101 }
5102 }
5103 }
5104 }
5105 }
5106 return skip;
5107}
5108
5109bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
5110 const VkAllocationCallbacks *pAllocator,
5111 VkSwapchainKHR *pSwapchain) const {
5112 bool skip = false;
5113 skip |= ValidateSwapchainCreateInfo("vkCreateSwapchainKHR()", pCreateInfo);
5114 return skip;
5115}
5116
5117bool StatelessValidation::manual_PreCallValidateCreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount,
5118 const VkSwapchainCreateInfoKHR *pCreateInfos,
5119 const VkAllocationCallbacks *pAllocator,
5120 VkSwapchainKHR *pSwapchains) const {
5121 bool skip = false;
5122 if (pCreateInfos) {
5123 for (uint32_t i = 0; i < swapchainCount; i++) {
5124 std::stringstream func_name;
5125 func_name << "vkCreateSharedSwapchainsKHR[" << swapchainCount << "]()";
5126 skip |= ValidateSwapchainCreateInfo(func_name.str().c_str(), &pCreateInfos[i]);
5127 }
5128 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005129 return skip;
5130}
5131
Jeff Bolz5c801d12019-10-09 10:38:45 -05005132bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005133 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005134
5135 if (pPresentInfo && pPresentInfo->pNext) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005136 const auto *present_regions = LvlFindInChain<VkPresentRegionsKHR>(pPresentInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -06005137 if (present_regions) {
5138 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07005139 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06005140 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
5141 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07005142 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005143 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
5144 "extension swapchainCount is %i. These values must be equal.",
5145 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06005146 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005147 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08005148 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
5149 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005150 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
5151 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
5152 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06005153 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005154 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005155 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06005156 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005157 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005158 }
5159 }
5160
5161 return skip;
5162}
5163
sfricke-samsung5c1b7392020-12-13 22:17:15 -08005164bool StatelessValidation::manual_PreCallValidateCreateDisplayModeKHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
5165 const VkDisplayModeCreateInfoKHR *pCreateInfo,
5166 const VkAllocationCallbacks *pAllocator,
5167 VkDisplayModeKHR *pMode) const {
5168 bool skip = false;
5169
5170 const VkDisplayModeParametersKHR display_mode_parameters = pCreateInfo->parameters;
5171 if (display_mode_parameters.visibleRegion.width == 0) {
5172 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-width-01990",
5173 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.width must be greater than 0.");
5174 }
5175 if (display_mode_parameters.visibleRegion.height == 0) {
5176 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-height-01991",
5177 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.height must be greater than 0.");
5178 }
5179 if (display_mode_parameters.refreshRate == 0) {
5180 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-refreshRate-01992",
5181 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.refreshRate must be greater than 0.");
5182 }
5183
5184 return skip;
5185}
5186
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005187#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005188bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
5189 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
5190 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005191 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005192 bool skip = false;
5193
5194 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005195 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
5196 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005197 }
5198
5199 return skip;
5200}
5201#endif // VK_USE_PLATFORM_WIN32_KHR
5202
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005203static bool MutableDescriptorTypePartialOverlap(const VkDescriptorPoolCreateInfo *pCreateInfo, uint32_t i, uint32_t j) {
5204 bool partial_overlap = false;
5205
5206 static const std::vector<VkDescriptorType> all_descriptor_types = {
5207 VK_DESCRIPTOR_TYPE_SAMPLER,
5208 VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
5209 VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
5210 VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
5211 VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER,
5212 VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
5213 VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
5214 VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
5215 VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC,
5216 VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC,
5217 VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
5218 VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT,
5219 VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR,
5220 VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV,
5221 };
5222
5223 const auto *mutable_descriptor_type = LvlFindInChain<VkMutableDescriptorTypeCreateInfoVALVE>(pCreateInfo->pNext);
5224 if (mutable_descriptor_type) {
5225 std::vector<VkDescriptorType> first_types, second_types;
5226 if (mutable_descriptor_type->mutableDescriptorTypeListCount > i) {
5227 for (uint32_t k = 0; k < mutable_descriptor_type->pMutableDescriptorTypeLists[i].descriptorTypeCount; ++k) {
5228 first_types.push_back(mutable_descriptor_type->pMutableDescriptorTypeLists[i].pDescriptorTypes[k]);
5229 }
5230 } else {
5231 first_types = all_descriptor_types;
5232 }
5233 if (mutable_descriptor_type->mutableDescriptorTypeListCount > j) {
5234 for (uint32_t k = 0; k < mutable_descriptor_type->pMutableDescriptorTypeLists[j].descriptorTypeCount; ++k) {
5235 second_types.push_back(mutable_descriptor_type->pMutableDescriptorTypeLists[j].pDescriptorTypes[k]);
5236 }
5237 } else {
5238 second_types = all_descriptor_types;
5239 }
5240
5241 bool complete_overlap = first_types.size() == second_types.size();
5242 bool disjoint = true;
5243 for (const auto first_type : first_types) {
5244 bool found = false;
5245 for (const auto second_type : second_types) {
5246 if (first_type == second_type) {
5247 found = true;
5248 break;
5249 }
5250 }
5251 if (found) {
5252 disjoint = false;
5253 } else {
5254 complete_overlap = false;
5255 }
5256 if (!disjoint && !complete_overlap) {
5257 partial_overlap = true;
5258 break;
5259 }
5260 }
5261 }
5262
5263 return partial_overlap;
5264}
5265
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005266bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005267 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005268 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02005269 bool skip = false;
5270
5271 if (pCreateInfo) {
5272 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005273 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
5274 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02005275 }
5276
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005277 const auto *mutable_descriptor_type_features =
5278 LvlFindInChain<VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE>(device_createinfo_pnext);
5279 bool mutable_descriptor_type_enabled =
5280 mutable_descriptor_type_features && mutable_descriptor_type_features->mutableDescriptorType == VK_TRUE;
5281
Petr Krausc8655be2017-09-27 18:56:51 +02005282 if (pCreateInfo->pPoolSizes) {
5283 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
5284 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005285 skip |= LogError(
5286 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005287 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02005288 }
Jeff Bolze54ae892018-09-08 12:16:29 -05005289 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
5290 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005291 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
5292 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
5293 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
5294 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
5295 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05005296 }
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005297 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE && !mutable_descriptor_type_enabled) {
5298 skip |=
5299 LogError(device, "VUID-VkDescriptorPoolCreateInfo-mutableDescriptorType-04608",
5300 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
5301 "].type is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE "
5302 ", but VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType is not enabled.",
5303 i);
5304 }
5305 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
5306 for (uint32_t j = i + 1; j < pCreateInfo->poolSizeCount; ++j) {
5307 if (pCreateInfo->pPoolSizes[j].type == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
5308 if (MutableDescriptorTypePartialOverlap(pCreateInfo, i, j)) {
5309 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-pPoolSizes-04787",
5310 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
5311 "].type and pCreateInfo->pPoolSizes[%" PRIu32
5312 "].type are both VK_DESCRIPTOR_TYPE_MUTABLE_VALVE "
5313 " and have sets which partially overlap.",
5314 i, j);
5315 }
5316 }
5317 }
5318 }
Petr Krausc8655be2017-09-27 18:56:51 +02005319 }
5320 }
ziga-lunarg0cf85212021-07-19 01:26:17 +02005321
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005322 if (pCreateInfo->flags & VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE && (!mutable_descriptor_type_enabled)) {
5323 skip |=
5324 LogError(device, "VUID-VkDescriptorPoolCreateInfo-flags-04609",
5325 "vkCreateDescriptorPool(): pCreateInfo->flags contains VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE, "
5326 "but VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType is not enabled.");
5327 }
ziga-lunarg0cf85212021-07-19 01:26:17 +02005328 if ((pCreateInfo->flags & VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE) &&
5329 (pCreateInfo->flags & VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT)) {
5330 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-flags-04607",
5331 "vkCreateDescriptorPool(): pCreateInfo->flags must not contain both "
5332 "VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE and VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT");
5333 }
Petr Krausc8655be2017-09-27 18:56:51 +02005334 }
5335
5336 return skip;
5337}
5338
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005339bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005340 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005341 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005342
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005343 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005344 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005345 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
5346 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
5347 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005348 }
5349
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005350 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005351 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005352 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
5353 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
5354 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005355 }
5356
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005357 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005358 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005359 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
5360 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
5361 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005362 }
5363
5364 return skip;
5365}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005366
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005367bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005368 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07005369 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07005370
5371 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005372 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
5373 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07005374 }
5375 return skip;
5376}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005377
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005378bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
5379 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005380 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005381 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005382
5383 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005384 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005385 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005386 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
5387 "vkCmdDispatch(): baseGroupX (%" PRIu32
5388 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
5389 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005390 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005391 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
5392 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
5393 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
5394 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005395 }
5396
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005397 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005398 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005399 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
5400 "vkCmdDispatch(): baseGroupY (%" PRIu32
5401 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
5402 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005403 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005404 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
5405 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
5406 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
5407 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005408 }
5409
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005410 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005411 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005412 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
5413 "vkCmdDispatch(): baseGroupZ (%" PRIu32
5414 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
5415 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005416 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005417 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
5418 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
5419 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
5420 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005421 }
5422
5423 return skip;
5424}
5425
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07005426bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
5427 VkPipelineBindPoint pipelineBindPoint,
5428 VkPipelineLayout layout, uint32_t set,
5429 uint32_t descriptorWriteCount,
5430 const VkWriteDescriptorSet *pDescriptorWrites) const {
Mike Schuchardt979898a2022-01-11 10:46:59 -08005431 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, true);
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07005432}
5433
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005434bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
5435 uint32_t firstExclusiveScissor,
5436 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005437 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05005438 bool skip = false;
5439
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005440 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05005441 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005442 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005443 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
5444 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
5445 ") is not 0.",
5446 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005447 }
5448 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005449 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005450 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
5451 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
5452 ") is not 1.",
5453 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005454 }
5455 } else { // multiViewport enabled
5456 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005457 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005458 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
5459 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
5460 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5461 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005462 }
5463 }
5464
Jeff Bolz3e71f782018-08-29 23:15:45 -05005465 if (pExclusiveScissors) {
5466 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
5467 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
5468
5469 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005470 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
5471 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
5472 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005473 }
5474
5475 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005476 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
5477 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
5478 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005479 }
5480
5481 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
5482 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005483 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
5484 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5485 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5486 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005487 }
5488
5489 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
5490 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005491 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
5492 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5493 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5494 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005495 }
5496 }
5497 }
5498
5499 return skip;
5500}
5501
Chris Mayer9ded5eb2019-09-19 16:33:26 +02005502bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
5503 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005504 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02005505 bool skip = false;
Shannon McPherson169d0c72020-11-13 18:48:19 -07005506 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
5507 if ((sum < 1) || (sum > device_limits.maxViewports)) {
5508 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
5509 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
5510 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
5511 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02005512 }
5513
5514 return skip;
5515}
5516
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005517bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
5518 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005519 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05005520 bool skip = false;
5521
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005522 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05005523 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005524 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005525 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
5526 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
5527 ") is not 0.",
5528 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005529 }
5530 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005531 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005532 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
5533 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
5534 ") is not 1.",
5535 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005536 }
5537 }
5538
Jeff Bolz9af91c52018-09-01 21:53:57 -05005539 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005540 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005541 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
5542 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
5543 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5544 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005545 }
5546
5547 return skip;
5548}
5549
Jeff Bolz5c801d12019-10-09 10:38:45 -05005550bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
5551 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
5552 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05005553 bool skip = false;
5554
Dave Houlton142c4cb2018-10-17 15:04:41 -06005555 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005556 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
5557 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
5558 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05005559 }
5560
5561 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005562 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005563 }
5564
5565 return skip;
5566}
5567
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005568bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005569 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005570 bool skip = false;
5571
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005572 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005573 skip |= LogError(
5574 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06005575 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
5576 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005577 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005578 }
5579
5580 return skip;
5581}
5582
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005583bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
5584 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005585 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005586 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06005587 static const int condition_multiples = 0b0011;
5588 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005589 skip |= LogError(
5590 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06005591 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005592 }
Lockee1c22882019-06-10 16:02:54 -06005593 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005594 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
5595 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
5596 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
5597 stride);
Lockee1c22882019-06-10 16:02:54 -06005598 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005599 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005600 skip |= LogError(
5601 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005602 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %" PRIu32 "",
5603 drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06005604 }
Tony-LunarGc0c3df52020-11-20 13:47:10 -07005605 if (drawCount > device_limits.maxDrawIndirectCount) {
5606 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02719",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005607 "vkCmdDrawMeshTasksIndirectNV: drawCount (%" PRIu32
5608 ") is not less than or equal to the maximum allowed (%" PRIu32 ").",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005609 drawCount, device_limits.maxDrawIndirectCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07005610 }
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005611 return skip;
5612}
5613
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005614bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
5615 VkDeviceSize offset, VkBuffer countBuffer,
5616 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005617 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005618 bool skip = false;
5619
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005620 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005621 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
5622 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
5623 "), is not a multiple of 4.",
5624 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005625 }
5626
5627 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005628 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
5629 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
5630 "), is not a multiple of 4.",
5631 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005632 }
5633
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005634 return skip;
5635}
5636
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005637bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005638 const VkAllocationCallbacks *pAllocator,
5639 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005640 bool skip = false;
5641
5642 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
5643 if (pCreateInfo != nullptr) {
5644 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
5645 // VkQueryPipelineStatisticFlagBits values
5646 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
5647 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005648 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
5649 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
5650 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
5651 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005652 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07005653 if (pCreateInfo->queryCount == 0) {
5654 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
5655 "vkCreateQueryPool(): queryCount must be greater than zero.");
5656 }
ziga-lunarg1052d492022-04-03 20:12:15 +02005657 if (pCreateInfo->queryType == VK_QUERY_TYPE_PRIMITIVES_GENERATED_EXT) {
5658 const auto *primitives_generated_query_features =
5659 LvlFindInChain<VkPhysicalDevicePrimitivesGeneratedQueryFeaturesEXT>(device_createinfo_pnext);
5660 if (!primitives_generated_query_features || primitives_generated_query_features->primitivesGeneratedQuery == VK_FALSE) {
5661 skip |= LogError(device, "VUID-vkCmdBeginQuery-queryType-06688",
5662 "vkCreateQueryPool(): If pCreateInfo->queryType is VK_QUERY_TYPE_PRIMITIVES_GENERATED_EXT primitivesGeneratedQuery feature must be enabled.");
5663 }
5664 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06005665 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005666 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005667}
5668
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005669bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
5670 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005671 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005672 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
5673 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005674}
5675
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005676void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07005677 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
5678 VkResult result) {
5679 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005680 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005681}
5682
Mike Schuchardt2df08912020-12-15 16:28:09 -08005683void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07005684 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
5685 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005686 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07005687 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005688 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005689}
5690
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005691void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
5692 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005693 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07005694 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005695 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005696}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005697
Tony-LunarG3c287f62020-12-17 12:39:49 -07005698void StatelessValidation::PostCallRecordAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pAllocateInfo,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005699 VkCommandBuffer *pCommandBuffers, VkResult result) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07005700 if ((result == VK_SUCCESS) && pAllocateInfo && (pAllocateInfo->level == VK_COMMAND_BUFFER_LEVEL_SECONDARY)) {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06005701 auto lock = CBWriteLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07005702 for (uint32_t cb_index = 0; cb_index < pAllocateInfo->commandBufferCount; cb_index++) {
Jeremy Gebbenfc6f8152021-03-18 16:58:55 -06005703 secondary_cb_map.emplace(pCommandBuffers[cb_index], pAllocateInfo->commandPool);
Tony-LunarG3c287f62020-12-17 12:39:49 -07005704 }
5705 }
5706}
5707
5708void StatelessValidation::PostCallRecordFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005709 const VkCommandBuffer *pCommandBuffers) {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06005710 auto lock = CBWriteLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07005711 for (uint32_t cb_index = 0; cb_index < commandBufferCount; cb_index++) {
5712 secondary_cb_map.erase(pCommandBuffers[cb_index]);
5713 }
5714}
5715
5716void StatelessValidation::PostCallRecordDestroyCommandPool(VkDevice device, VkCommandPool commandPool,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005717 const VkAllocationCallbacks *pAllocator) {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06005718 auto lock = CBWriteLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07005719 for (auto item = secondary_cb_map.begin(); item != secondary_cb_map.end();) {
5720 if (item->second == commandPool) {
5721 item = secondary_cb_map.erase(item);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005722 } else {
Tony-LunarG3c287f62020-12-17 12:39:49 -07005723 ++item;
5724 }
5725 }
5726}
5727
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005728bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005729 const VkAllocationCallbacks *pAllocator,
5730 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005731 bool skip = false;
5732
5733 if (pAllocateInfo) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005734 auto chained_prio_struct = LvlFindInChain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005735 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005736 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
5737 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005738 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005739
5740 VkMemoryAllocateFlags flags = 0;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005741 auto flags_info = LvlFindInChain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005742 if (flags_info) {
5743 flags = flags_info->flags;
5744 }
5745
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005746 auto opaque_alloc_info = LvlFindInChain<VkMemoryOpaqueCaptureAddressAllocateInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005747 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08005748 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005749 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
5750 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
Mike Schuchardt2df08912020-12-15 16:28:09 -08005751 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005752 }
5753
5754#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005755 auto import_memory_win32_handle = LvlFindInChain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005756#endif
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005757 auto import_memory_fd = LvlFindInChain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
5758 auto import_memory_host_pointer = LvlFindInChain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005759#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005760 auto import_memory_ahb = LvlFindInChain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005761#endif
5762
5763 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005764 skip |= LogError(
5765 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005766 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
5767 }
5768 if (
5769#ifdef VK_USE_PLATFORM_WIN32_KHR
5770 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
5771#endif
5772 (import_memory_fd && import_memory_fd->handleType) ||
5773#ifdef VK_USE_PLATFORM_ANDROID_KHR
5774 (import_memory_ahb && import_memory_ahb->buffer) ||
5775#endif
5776 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005777 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
5778 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005779 }
5780 }
5781
ziga-lunarg1d5e11d2021-07-18 13:13:40 +02005782 auto export_memory = LvlFindInChain<VkExportMemoryAllocateInfo>(pAllocateInfo->pNext);
5783 if (export_memory) {
5784 auto export_memory_nv = LvlFindInChain<VkExportMemoryAllocateInfoNV>(pAllocateInfo->pNext);
5785 if (export_memory_nv) {
5786 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-pNext-00640",
5787 "pNext chain of VkMemoryAllocateInfo includes both VkExportMemoryAllocateInfo and "
5788 "VkExportMemoryAllocateInfoNV");
5789 }
5790#ifdef VK_USE_PLATFORM_WIN32_KHR
5791 auto export_memory_win32_nv = LvlFindInChain<VkExportMemoryWin32HandleInfoNV>(pAllocateInfo->pNext);
5792 if (export_memory_win32_nv) {
5793 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-pNext-00640",
5794 "pNext chain of VkMemoryAllocateInfo includes both VkExportMemoryAllocateInfo and "
5795 "VkExportMemoryWin32HandleInfoNV");
5796 }
5797#endif
5798 }
5799
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005800 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07005801 VkBool32 capture_replay = false;
5802 VkBool32 buffer_device_address = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005803 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07005804 if (vulkan_12_features) {
5805 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
5806 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
5807 } else {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005808 const auto *bda_features = LvlFindInChain<VkPhysicalDeviceBufferDeviceAddressFeatures>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07005809 if (bda_features) {
5810 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
5811 buffer_device_address = bda_features->bufferDeviceAddress;
5812 }
5813 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08005814 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005815 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
Mike Schuchardt2df08912020-12-15 16:28:09 -08005816 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT is set, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005817 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005818 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08005819 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005820 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
Mike Schuchardt2df08912020-12-15 16:28:09 -08005821 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005822 }
5823 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005824 }
5825 return skip;
5826}
Ricardo Garciaa4935972019-02-21 17:43:18 +01005827
Jason Macnak192fa0e2019-07-26 15:07:16 -07005828bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005829 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07005830 bool skip = false;
5831
5832 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
5833 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
5834 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005835 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005836 } else {
5837 uint32_t vertex_component_size = 0;
5838 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
5839 vertex_component_size = 4;
5840 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
5841 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
5842 vertex_component_size = 2;
5843 }
5844 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005845 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005846 }
5847 }
5848
5849 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
5850 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005851 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005852 } else {
5853 uint32_t index_element_size = 0;
5854 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
5855 index_element_size = 4;
5856 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
5857 index_element_size = 2;
5858 }
5859 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005860 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005861 }
5862 }
5863 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
5864 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005865 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005866 }
5867 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005868 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005869 }
5870 }
5871
5872 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005873 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005874 }
5875
5876 return skip;
5877}
5878
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005879bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
5880 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07005881 bool skip = false;
5882
5883 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005884 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005885 }
5886 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005887 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005888 }
5889
5890 return skip;
5891}
5892
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005893bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
5894 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07005895 bool skip = false;
5896 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005897 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005898 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005899 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005900 }
5901 return skip;
5902}
5903
5904bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07005905 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005906 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07005907 bool skip = false;
5908 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005909 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
5910 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
5911 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07005912 }
5913 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005914 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
5915 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
5916 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07005917 }
ziga-lunarg10309ee2021-08-02 13:11:21 +02005918 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
5919 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-04623",
5920 "VkAccelerationStructureInfoNV: type is invalid VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.");
5921 }
Jason Macnak5c954952019-07-09 15:46:12 -07005922 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
5923 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005924 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
5925 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
5926 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07005927 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005928 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005929 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005930 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
5931 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005932 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
5933 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07005934 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005935 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005936 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
5937 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
5938 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07005939 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07005940 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07005941 uint64_t total_triangle_count = 0;
5942 for (uint32_t i = 0; i < info.geometryCount; i++) {
5943 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07005944
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005945 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005946
Jason Macnak5c954952019-07-09 15:46:12 -07005947 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
5948 continue;
5949 }
5950 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
5951 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005952 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005953 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
5954 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
5955 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07005956 }
5957 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07005958 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
5959 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
5960 for (uint32_t i = 1; i < info.geometryCount; i++) {
5961 const VkGeometryNV &geometry = info.pGeometries[i];
5962 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005963 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005964 "VkAccelerationStructureInfoNV: info.pGeometries[%" PRIu32
5965 "].geometryType does not match "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005966 "info.pGeometries[0].geometryType.",
5967 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07005968 }
5969 }
5970 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005971 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
5972 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
5973 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
5974 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
5975 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
5976 "or VK_GEOMETRY_TYPE_AABBS_NV.");
5977 }
5978 }
5979 skip |=
5980 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06005981 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07005982 return skip;
5983}
5984
Ricardo Garciaa4935972019-02-21 17:43:18 +01005985bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
5986 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005987 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01005988 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01005989 if (pCreateInfo) {
5990 if ((pCreateInfo->compactedSize != 0) &&
5991 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005992 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
5993 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
5994 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
5995 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01005996 }
Jason Macnak5c954952019-07-09 15:46:12 -07005997
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005998 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07005999 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01006000 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01006001 return skip;
6002}
Mike Schuchardt21638df2019-03-16 10:52:02 -07006003
Jeff Bolz5c801d12019-10-09 10:38:45 -05006004bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
6005 const VkAccelerationStructureInfoNV *pInfo,
6006 VkBuffer instanceData, VkDeviceSize instanceOffset,
6007 VkBool32 update, VkAccelerationStructureNV dst,
6008 VkAccelerationStructureNV src, VkBuffer scratch,
6009 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07006010 bool skip = false;
6011
6012 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07006013 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07006014 }
6015
6016 return skip;
6017}
6018
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006019bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
6020 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
6021 VkAccelerationStructureKHR *pAccelerationStructure) const {
6022 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07006023 const auto *acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006024 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006025 if (!acceleration_structure_features ||
6026 (acceleration_structure_features && acceleration_structure_features->accelerationStructure == VK_FALSE)) {
6027 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-accelerationStructure-03611",
6028 "vkCreateAccelerationStructureKHR(): The accelerationStructure feature must be enabled");
6029 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006030 if (pCreateInfo) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006031 if (pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR &&
6032 (!acceleration_structure_features ||
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006033 (acceleration_structure_features &&
6034 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
sourav parmara96ab1a2020-04-25 16:28:23 -07006035 skip |=
sourav parmarcd5fb182020-07-17 12:58:44 -07006036 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-createFlags-03613",
6037 "vkCreateAccelerationStructureKHR(): If createFlags includes "
6038 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR, "
6039 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay must be VK_TRUE");
sourav parmara96ab1a2020-04-25 16:28:23 -07006040 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006041 if (pCreateInfo->deviceAddress &&
6042 !(pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
6043 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03612",
6044 "vkCreateAccelerationStructureKHR(): If deviceAddress is not zero, createFlags must include "
6045 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR");
6046 }
ziga-lunarg8ddbe462021-09-06 16:14:17 +02006047 if (pCreateInfo->deviceAddress && (!acceleration_structure_features ||
6048 (acceleration_structure_features &&
6049 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
6050 skip |= LogError(
6051 device, "VUID-vkCreateAccelerationStructureKHR-deviceAddress-03488",
6052 "VkAccelerationStructureCreateInfoKHR(): VkAccelerationStructureCreateInfoKHR::deviceAddress is not zero, but "
6053 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay is not enabled.");
6054 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006055 if (SafeModulo(pCreateInfo->offset, 256) != 0) {
6056 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-offset-03734",
ziga-lunarg8ddbe462021-09-06 16:14:17 +02006057 "vkCreateAccelerationStructureKHR(): offset %" PRIu64 " must be a multiple of 256 bytes",
6058 pCreateInfo->offset);
sourav parmarcd5fb182020-07-17 12:58:44 -07006059 }
sourav parmar83c31b12020-05-06 12:30:54 -07006060 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006061 return skip;
6062}
6063
Jason Macnak5c954952019-07-09 15:46:12 -07006064bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
6065 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006066 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07006067 bool skip = false;
6068 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006069 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
6070 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07006071 }
6072 return skip;
6073}
6074
sourav parmarcd5fb182020-07-17 12:58:44 -07006075bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesNV(
6076 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureNV *pAccelerationStructures,
6077 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
6078 bool skip = false;
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07006079 if (queryType != VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV) {
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07006080 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesNV-queryType-06216",
sourav parmarcd5fb182020-07-17 12:58:44 -07006081 "vkCmdWriteAccelerationStructuresPropertiesNV: queryType must be "
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07006082 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV.");
sourav parmarcd5fb182020-07-17 12:58:44 -07006083 }
6084 return skip;
6085}
6086
Peter Chen85366392019-05-14 15:20:11 -04006087bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
6088 uint32_t createInfoCount,
6089 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
6090 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006091 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04006092 bool skip = false;
6093
6094 for (uint32_t i = 0; i < createInfoCount; i++) {
ziga-lunargc6341372021-07-28 12:57:42 +02006095 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
6096 std::stringstream msg;
6097 msg << "pCreateInfos[%" << i << "].pStages[%" << stage_index << "]";
6098 ValidatePipelineShaderStageCreateInfo("vkCreateRayTracingPipelinesNV", msg.str().c_str(), &pCreateInfos[i].pStages[i]);
6099 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006100 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04006101 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Nathaniel Cesario6a0ce2f2022-04-02 21:47:54 -06006102 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineStageCreationFeedbackCount-06651",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006103 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
6104 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
6105 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
6106 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04006107 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006108
6109 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006110 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07006111 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
6112 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
6113 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
6114 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
6115 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
6116 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
6117 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
6118 }
6119 }
6120
sourav parmarf4a78252020-04-10 13:04:21 -07006121 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
6122 skip |=
6123 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
6124 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
6125 }
6126 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
6127 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
6128 skip |=
6129 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
6130 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
6131 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
6132 }
6133 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
6134 if (pCreateInfos[i].basePipelineIndex != -1) {
6135 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
6136 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
6137 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
6138 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
6139 "and pCreateInfos->basePipelineIndex is not -1.");
6140 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006141 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07006142 skip |=
6143 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
6144 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
6145 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
6146 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
6147 "that element.");
6148 }
sourav parmarf4a78252020-04-10 13:04:21 -07006149 }
6150 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04006151 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07006152 skip |=
6153 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
6154 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
6155 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
6156 "commands pCreateInfos parameter.");
6157 }
6158 } else {
6159 if (pCreateInfos[i].basePipelineIndex != -1) {
6160 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
6161 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
6162 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
6163 }
6164 }
6165 }
6166 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
6167 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
6168 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
6169 }
6170 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
6171 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
6172 "vkCreateRayTracingPipelinesNV: flags must not include "
6173 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
6174 }
6175 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
6176 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
6177 "vkCreateRayTracingPipelinesNV: flags must not include "
6178 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
6179 }
6180 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
6181 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
6182 "vkCreateRayTracingPipelinesNV: flags must not include "
6183 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
6184 }
6185 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
6186 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
6187 "vkCreateRayTracingPipelinesNV: flags must not include "
6188 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
6189 }
6190 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
6191 skip |= LogError(
6192 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
6193 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
6194 }
6195 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
6196 skip |= LogError(
6197 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
6198 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
6199 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006200 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) {
6201 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03588",
6202 "vkCreateRayTracingPipelinesNV: flags must not include "
6203 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
6204 }
6205 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
6206 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03816",
6207 "vkCreateRayTracingPipelinesNV: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
6208 }
ziga-lunargdfffee42021-10-10 11:49:59 +02006209 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) {
6210 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-04948",
6211 "vkCreateRayTracingPipelinesNV: flags must not contain the "
6212 "VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV flag.");
6213 }
Peter Chen85366392019-05-14 15:20:11 -04006214 }
6215
6216 return skip;
6217}
6218
sourav parmarcd5fb182020-07-17 12:58:44 -07006219bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(
6220 VkDevice device, VkDeferredOperationKHR deferredOperation, VkPipelineCache pipelineCache, uint32_t createInfoCount,
6221 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos, const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) const {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006222 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006223 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006224 if (!raytracing_features || raytracing_features->rayTracingPipeline == VK_FALSE) {
6225 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracingPipeline-03586",
6226 "vkCreateRayTracingPipelinesKHR: The rayTracingPipeline feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006227 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006228 for (uint32_t i = 0; i < createInfoCount; i++) {
ziga-lunargc6341372021-07-28 12:57:42 +02006229 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
6230 std::stringstream msg;
6231 msg << "pCreateInfos[%" << i << "].pStages[%" << stage_index << "]";
6232 ValidatePipelineShaderStageCreateInfo("vkCreateRayTracingPipelinesKHR", msg.str().c_str(),
aitor-lunargdbd9e652022-02-23 19:12:53 +01006233 &pCreateInfos[i].pStages[stage_index]);
ziga-lunargc6341372021-07-28 12:57:42 +02006234 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006235 if (!raytracing_features || (raytracing_features && raytracing_features->rayTraversalPrimitiveCulling == VK_FALSE)) {
6236 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
6237 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03596",
6238 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
6239 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
6240 }
6241 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
6242 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03597",
6243 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
6244 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.");
6245 }
6246 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006247 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006248 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Nathaniel Cesario6a0ce2f2022-04-02 21:47:54 -06006249 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineStageCreationFeedbackCount-06652",
sourav parmarcd5fb182020-07-17 12:58:44 -07006250 "vkCreateRayTracingPipelinesKHR: in pCreateInfo[%" PRIu32
6251 "], When chained to VkRayTracingPipelineCreateInfoKHR, "
6252 "VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006253 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
6254 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
6255 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006256 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006257 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07006258 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
6259 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
6260 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
6261 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
sourav parmarcd5fb182020-07-17 12:58:44 -07006262 "vkCreateRayTracingPipelinesKHR: If the pipelineCreationCacheControl feature is not enabled,"
sourav parmara96ab1a2020-04-25 16:28:23 -07006263 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
6264 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
6265 }
6266 }
sourav parmarf4a78252020-04-10 13:04:21 -07006267 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006268 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
6269 "vkCreateRayTracingPipelinesKHR: flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
sourav parmarf4a78252020-04-10 13:04:21 -07006270 }
6271 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006272 if (pCreateInfos[i].pLibraryInterface == NULL) {
sourav parmarf4a78252020-04-10 13:04:21 -07006273 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
sourav parmarcd5fb182020-07-17 12:58:44 -07006274 "vkCreateRayTracingPipelinesKHR: If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, "
6275 "pLibraryInterface must not be NULL.");
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006276 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006277 }
6278 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
6279 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03816",
6280 "vkCreateRayTracingPipelinesKHR: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
sourav parmarf4a78252020-04-10 13:04:21 -07006281 }
6282 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
6283 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
6284 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
6285 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
6286 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
6287 skip |= LogError(
6288 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
sourav parmarcd5fb182020-07-17 12:58:44 -07006289 "vkCreateRayTracingPipelinesKHR: If flags includes "
6290 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07006291 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
6292 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
6293 "must not be VK_SHADER_UNUSED_KHR");
6294 }
6295 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
6296 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
6297 skip |= LogError(
6298 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
sourav parmarcd5fb182020-07-17 12:58:44 -07006299 "vkCreateRayTracingPipelinesKHR: If flags includes "
6300 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07006301 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
6302 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
6303 "element must not be VK_SHADER_UNUSED_KHR");
6304 }
6305 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006306 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_TRUE &&
6307 pCreateInfos[i].pGroups[group_index].pShaderGroupCaptureReplayHandle) {
6308 if (!(pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR)) {
6309 skip |= LogError(
6310 device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03599",
6311 "vkCreateRayTracingPipelinesKHR: If "
6312 "VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineShaderGroupHandleCaptureReplay is "
6313 "VK_TRUE and the pShaderGroupCaptureReplayHandle member of any element of pGroups is not NULL, flags must "
6314 "include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
6315 }
6316 }
sourav parmarf4a78252020-04-10 13:04:21 -07006317 }
6318 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
6319 if (pCreateInfos[i].basePipelineIndex != -1) {
6320 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
6321 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
sourav parmarcd5fb182020-07-17 12:58:44 -07006322 "vkCreateRayTracingPipelinesKHR: parameter, pCreateInfos->basePipelineHandle, must be "
sourav parmarf4a78252020-04-10 13:04:21 -07006323 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
6324 "and pCreateInfos->basePipelineIndex is not -1.");
6325 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006326 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07006327 skip |=
6328 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
6329 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
6330 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
6331 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
6332 "element.");
6333 }
sourav parmarf4a78252020-04-10 13:04:21 -07006334 }
6335 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04006336 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07006337 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
sourav parmarcd5fb182020-07-17 12:58:44 -07006338 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006339 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%" PRId32
6340 ") must be a valid into the calling"
6341 "commands pCreateInfos parameter %" PRIu32 ".",
sourav parmarf4a78252020-04-10 13:04:21 -07006342 pCreateInfos[i].basePipelineIndex, createInfoCount);
6343 }
6344 } else {
6345 if (pCreateInfos[i].basePipelineIndex != -1) {
6346 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
sourav parmarcd5fb182020-07-17 12:58:44 -07006347 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07006348 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
6349 }
6350 }
6351 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006352 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR &&
6353 (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE)) {
6354 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03598",
6355 "vkCreateRayTracingPipelinesKHR: If flags includes "
6356 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR, "
6357 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled.");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006358 }
6359 bool library_enabled = IsExtEnabled(device_extensions.vk_khr_pipeline_library);
6360 if (!library_enabled && (pCreateInfos[i].pLibraryInfo || pCreateInfos[i].pLibraryInterface)) {
6361 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03595",
6362 "vkCreateRayTracingPipelinesKHR: If the VK_KHR_pipeline_library extension is not enabled, "
6363 "pLibraryInfo and pLibraryInterface must be NULL.");
6364 }
6365 if (pCreateInfos[i].pLibraryInfo) {
6366 if (pCreateInfos[i].pLibraryInfo->libraryCount == 0) {
6367 if (pCreateInfos[i].stageCount == 0) {
6368 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03600",
6369 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
6370 "stageCount must not be 0.");
6371 }
6372 if (pCreateInfos[i].groupCount == 0) {
6373 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03601",
6374 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
6375 "groupCount must not be 0.");
6376 }
6377 } else {
6378 if (pCreateInfos[i].pLibraryInterface == NULL) {
6379 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03590",
6380 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount member "
6381 "is greater than 0, its "
6382 "pLibraryInterface member must not be NULL.");
sourav parmarcd5fb182020-07-17 12:58:44 -07006383 }
6384 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006385 }
6386 if (pCreateInfos[i].pLibraryInterface) {
6387 if (pCreateInfos[i].pLibraryInterface->maxPipelineRayHitAttributeSize >
6388 phys_dev_ext_props.ray_tracing_propsKHR.maxRayHitAttributeSize) {
6389 skip |= LogError(device, "VUID-VkRayTracingPipelineInterfaceCreateInfoKHR-maxPipelineRayHitAttributeSize-03605",
6390 "vkCreateRayTracingPipelinesKHR: maxPipelineRayHitAttributeSize must be less than or equal to "
6391 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayHitAttributeSize.");
6392 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006393 }
6394 if (deferredOperation != VK_NULL_HANDLE) {
6395 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT) {
6396 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-deferredOperation-03587",
6397 "vkCreateRayTracingPipelinesKHR: If deferredOperation is not VK_NULL_HANDLE, the flags member of "
6398 "elements of pCreateInfos must not include VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
sourav parmarf4a78252020-04-10 13:04:21 -07006399 }
6400 }
ziga-lunargdea76582021-09-17 14:38:08 +02006401 if (pCreateInfos[i].pDynamicState) {
6402 for (uint32_t j = 0; j < pCreateInfos[i].pDynamicState->dynamicStateCount; ++j) {
6403 if (pCreateInfos[i].pDynamicState->pDynamicStates[j] != VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR) {
6404 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pDynamicStates-03602",
6405 "vkCreateRayTracingPipelinesKHR(): pCreateInfos[%" PRIu32
6406 "].pDynamicState->pDynamicStates[%" PRIu32 "] is %s.",
6407 i, j, string_VkDynamicState(pCreateInfos[i].pDynamicState->pDynamicStates[j]));
6408 }
6409 }
6410 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006411 }
6412
6413 return skip;
6414}
6415
Mike Schuchardt21638df2019-03-16 10:52:02 -07006416#ifdef VK_USE_PLATFORM_WIN32_KHR
6417bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
6418 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006419 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07006420 bool skip = false;
sfricke-samsung45996a42021-09-16 13:45:27 -07006421 if (!IsExtEnabled(device_extensions.vk_khr_swapchain))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006422 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006423 if (!IsExtEnabled(device_extensions.vk_khr_get_surface_capabilities2))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006424 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006425 if (!IsExtEnabled(device_extensions.vk_khr_surface))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006426 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006427 if (!IsExtEnabled(device_extensions.vk_khr_get_physical_device_properties2))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006428 skip |=
6429 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006430 if (!IsExtEnabled(device_extensions.vk_ext_full_screen_exclusive))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006431 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
6432 skip |= validate_struct_type(
6433 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
6434 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
6435 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
6436 if (pSurfaceInfo != NULL) {
6437 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
6438 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
6439 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
6440
6441 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
6442 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
6443 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
6444 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08006445 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
6446 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07006447
Mike Schuchardt05b028d2022-01-05 14:15:00 -08006448 if (pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
6449 skip |= LogError(device, "VUID-vkGetPhysicalDeviceSurfacePresentModes2EXT-pSurfaceInfo-06521",
6450 "vkGetPhysicalDeviceSurfacePresentModes2EXT: pSurfaceInfo->surface is VK_NULL_HANDLE and "
6451 "VK_GOOGLE_surfaceless_query is not enabled.");
6452 }
6453
Mike Schuchardt21638df2019-03-16 10:52:02 -07006454 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
6455 }
6456 return skip;
6457}
6458#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01006459
6460bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
6461 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006462 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01006463 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
6464 bool skip = false;
Mike Schuchardt2df08912020-12-15 16:28:09 -08006465 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT) == 0) {
Tobias Hectorebb855f2019-07-23 12:17:33 +01006466 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
6467 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
6468 }
6469 return skip;
6470}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05006471
6472bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006473 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05006474 bool skip = false;
6475
6476 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006477 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006478 "vkCmdSetLineStippleEXT::lineStippleFactor=%" PRIu32 " is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05006479 }
6480
6481 return skip;
6482}
Piers Daniell8fd03f52019-08-21 12:07:53 -06006483
6484bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006485 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06006486 bool skip = false;
6487
6488 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006489 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
6490 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06006491 }
6492
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006493 const auto *index_type_uint8_features = LvlFindInChain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06006494 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006495 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
6496 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06006497 }
6498
6499 return skip;
6500}
Mark Lobodzinski84988402019-09-11 15:27:30 -06006501
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006502bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
6503 uint32_t bindingCount, const VkBuffer *pBuffers,
6504 const VkDeviceSize *pOffsets) const {
6505 bool skip = false;
6506 if (firstBinding > device_limits.maxVertexInputBindings) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006507 skip |=
6508 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
6509 "vkCmdBindVertexBuffers() firstBinding (%" PRIu32 ") must be less than maxVertexInputBindings (%" PRIu32 ")",
6510 firstBinding, device_limits.maxVertexInputBindings);
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006511 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
6512 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006513 "vkCmdBindVertexBuffers() sum of firstBinding (%" PRIu32 ") and bindingCount (%" PRIu32
6514 ") must be less than "
6515 "maxVertexInputBindings (%" PRIu32 ")",
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006516 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
6517 }
6518
Jeff Bolz165818a2020-05-08 11:19:03 -05006519 for (uint32_t i = 0; i < bindingCount; ++i) {
6520 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006521 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05006522 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006523 skip |=
6524 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
6525 "vkCmdBindVertexBuffers() required parameter pBuffers[%" PRIu32 "] specified as VK_NULL_HANDLE", i);
Jeff Bolz165818a2020-05-08 11:19:03 -05006526 } else {
6527 if (pOffsets[i] != 0) {
6528 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006529 "vkCmdBindVertexBuffers() pBuffers[%" PRIu32 "] is VK_NULL_HANDLE, but pOffsets[%" PRIu32
6530 "] is not 0",
6531 i, i);
Jeff Bolz165818a2020-05-08 11:19:03 -05006532 }
6533 }
6534 }
6535 }
6536
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006537 return skip;
6538}
6539
Mark Lobodzinski84988402019-09-11 15:27:30 -06006540bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006541 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06006542 bool skip = false;
6543 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006544 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
6545 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06006546 }
6547 return skip;
6548}
6549
6550bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006551 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06006552 bool skip = false;
6553 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006554 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
6555 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06006556 }
6557 return skip;
6558}
Petr Kraus3d720392019-11-13 02:52:39 +01006559
6560bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
6561 VkSemaphore semaphore, VkFence fence,
6562 uint32_t *pImageIndex) const {
6563 bool skip = false;
6564
6565 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006566 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
6567 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01006568 }
6569
6570 return skip;
6571}
6572
6573bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
6574 uint32_t *pImageIndex) const {
6575 bool skip = false;
6576
6577 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006578 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
6579 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01006580 }
6581
6582 return skip;
6583}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006584
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06006585bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
6586 uint32_t firstBinding, uint32_t bindingCount,
6587 const VkBuffer *pBuffers,
6588 const VkDeviceSize *pOffsets,
6589 const VkDeviceSize *pSizes) const {
6590 bool skip = false;
6591
6592 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
6593 for (uint32_t i = 0; i < bindingCount; ++i) {
6594 if (pOffsets[i] & 3) {
6595 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
6596 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
6597 }
6598 }
6599
6600 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6601 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
6602 "%s: The firstBinding(%" PRIu32
6603 ") index is greater than or equal to "
6604 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6605 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6606 }
6607
6608 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6609 skip |=
6610 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
6611 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
6612 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6613 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6614 }
6615
6616 for (uint32_t i = 0; i < bindingCount; ++i) {
6617 // pSizes is optional and may be nullptr.
6618 if (pSizes != nullptr) {
6619 if (pSizes[i] != VK_WHOLE_SIZE &&
6620 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
6621 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
6622 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
6623 ") is not VK_WHOLE_SIZE and is greater than "
6624 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
6625 cmd_name, i, pSizes[i]);
6626 }
6627 }
6628 }
6629
6630 return skip;
6631}
6632
6633bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
6634 uint32_t firstCounterBuffer,
6635 uint32_t counterBufferCount,
6636 const VkBuffer *pCounterBuffers,
6637 const VkDeviceSize *pCounterBufferOffsets) const {
6638 bool skip = false;
6639
6640 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
6641 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6642 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
6643 "%s: The firstCounterBuffer(%" PRIu32
6644 ") index is greater than or equal to "
6645 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6646 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6647 }
6648
6649 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6650 skip |=
6651 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
6652 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
6653 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6654 cmd_name, firstCounterBuffer, counterBufferCount,
6655 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6656 }
6657
6658 return skip;
6659}
6660
6661bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
6662 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
6663 const VkBuffer *pCounterBuffers,
6664 const VkDeviceSize *pCounterBufferOffsets) const {
6665 bool skip = false;
6666
6667 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
6668 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6669 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
6670 "%s: The firstCounterBuffer(%" PRIu32
6671 ") index is greater than or equal to "
6672 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6673 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6674 }
6675
6676 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6677 skip |=
6678 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
6679 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
6680 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6681 cmd_name, firstCounterBuffer, counterBufferCount,
6682 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6683 }
6684
6685 return skip;
6686}
6687
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006688bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
6689 uint32_t firstInstance, VkBuffer counterBuffer,
6690 VkDeviceSize counterBufferOffset,
6691 uint32_t counterOffset, uint32_t vertexStride) const {
6692 bool skip = false;
6693
6694 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006695 skip |= LogError(counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
6696 "vkCmdDrawIndirectByteCountEXT: vertexStride (%" PRIu32
6697 ") must be between 0 and maxTransformFeedbackBufferDataStride (%" PRIu32 ").",
6698 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006699 }
6700
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07006701 if ((counterOffset % 4) != 0) {
sfricke-samsung6886c4b2021-01-16 08:37:35 -08006702 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-counterBufferOffset-04568",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006703 "vkCmdDrawIndirectByteCountEXT(): offset (%" PRIu32 ") must be a multiple of 4.", counterOffset);
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07006704 }
6705
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006706 return skip;
6707}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006708
6709bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
6710 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
6711 const VkAllocationCallbacks *pAllocator,
6712 VkSamplerYcbcrConversion *pYcbcrConversion,
6713 const char *apiName) const {
6714 bool skip = false;
6715
6716 // Check samplerYcbcrConversion feature is set
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006717 const auto *ycbcr_features = LvlFindInChain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006718 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006719 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02006720 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
6721 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07006722 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02006723 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006724 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006725
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006726#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006727 const VkExternalFormatANDROID *external_format_android = LvlFindInChain<VkExternalFormatANDROID>(pCreateInfo);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006728 const bool is_external_format = external_format_android != nullptr && external_format_android->externalFormat != 0;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006729#else
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006730 const bool is_external_format = false;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006731#endif
6732
sfricke-samsung1a72f942020-07-25 12:09:18 -07006733 const VkFormat format = pCreateInfo->format;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006734
6735 // If there is a VkExternalFormatANDROID with externalFormat != 0, the value of components is ignored.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006736 if (!is_external_format) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006737 const VkComponentMapping components = pCreateInfo->components;
6738 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
6739 if (FormatIsXChromaSubsampled(format) == true) {
6740 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
6741 skip |=
6742 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
sfricke-samsung83d98122020-07-04 06:21:15 -07006743 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
6744 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006745 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006746 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006747
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006748 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
6749 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
6750 skip |= LogError(
6751 device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
6752 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
6753 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
6754 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
6755 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006756
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006757 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
6758 (components.r != VK_COMPONENT_SWIZZLE_B)) {
6759 skip |=
6760 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
sfricke-samsung83d98122020-07-04 06:21:15 -07006761 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
6762 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006763 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006764 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006765
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006766 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
6767 (components.b != VK_COMPONENT_SWIZZLE_R)) {
6768 skip |=
6769 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
sfricke-samsung83d98122020-07-04 06:21:15 -07006770 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
6771 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006772 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006773 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006774
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006775 // If one is identity, both need to be
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006776 const bool r_identity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
6777 const bool b_identity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
6778 if ((r_identity != b_identity) && ((r_identity == true) || (b_identity == true))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006779 skip |=
6780 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
sfricke-samsung83d98122020-07-04 06:21:15 -07006781 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
6782 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006783 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
6784 string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006785 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07006786 }
6787
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006788 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
6789 // Checks same VU multiple ways in order to give a more useful error message
6790 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
6791 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
6792 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
6793 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
6794 skip |= LogError(
6795 device, vuid,
6796 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6797 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
6798 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6799 string_VkComponentSwizzle(components.b));
6800 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07006801
sfricke-samsunged028b02021-09-06 23:14:51 -07006802 // "must not correspond to a component which contains zero or one as a consequence of conversion to RGBA"
6803 // 4 component format = no issue
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006804 // 3 = no [a]
6805 // 2 = no [b,a]
6806 // 1 = no [g,b,a]
6807 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
sfricke-samsunged028b02021-09-06 23:14:51 -07006808 const uint32_t component_count = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatComponentCount(format);
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006809
sfricke-samsunged028b02021-09-06 23:14:51 -07006810 if ((component_count < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
6811 (components.b == VK_COMPONENT_SWIZZLE_A))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006812 skip |= LogError(device, vuid,
6813 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6814 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
6815 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6816 string_VkComponentSwizzle(components.b));
sfricke-samsunged028b02021-09-06 23:14:51 -07006817 } else if ((component_count < 3) &&
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006818 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
6819 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
6820 skip |= LogError(device, vuid,
6821 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6822 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
6823 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
6824 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6825 string_VkComponentSwizzle(components.b));
sfricke-samsunged028b02021-09-06 23:14:51 -07006826 } else if ((component_count < 2) &&
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006827 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
6828 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
6829 skip |= LogError(device, vuid,
6830 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6831 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
6832 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
6833 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6834 string_VkComponentSwizzle(components.b));
6835 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006836 }
6837 }
6838
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006839 return skip;
6840}
6841
6842bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
6843 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
6844 const VkAllocationCallbacks *pAllocator,
6845 VkSamplerYcbcrConversion *pYcbcrConversion) const {
6846 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
6847 "vkCreateSamplerYcbcrConversion");
6848}
6849
6850bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
6851 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
6852 VkSamplerYcbcrConversion *pYcbcrConversion) const {
6853 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
6854 "vkCreateSamplerYcbcrConversionKHR");
6855}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08006856
6857bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
6858 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
6859 bool skip = false;
6860 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
6861 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
6862
6863 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006864 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
6865 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
6866 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
6867 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
6868 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08006869 }
6870 return skip;
6871}
sourav parmara96ab1a2020-04-25 16:28:23 -07006872
6873bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006874 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006875 bool skip = false;
6876 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
6877 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
6878 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
6879 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006880 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006881 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
6882 skip |= LogError(
6883 device, "VUID-vkCopyAccelerationStructureToMemoryKHR-accelerationStructureHostCommands-03584",
6884 "vkCopyAccelerationStructureToMemoryKHR: The "
6885 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
6886 }
6887 skip |= validate_required_pointer("vkCopyAccelerationStructureToMemoryKHR", "pInfo->dst.hostAddress", pInfo->dst.hostAddress,
6888 "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03732");
6889 if (SafeModulo((VkDeviceSize)pInfo->dst.hostAddress, 16) != 0) {
6890 skip |= LogError(device, "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03751",
6891 "vkCopyAccelerationStructureToMemoryKHR(): pInfo->dst.hostAddress must be aligned to 16 bytes.");
6892 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006893 return skip;
6894}
6895
6896bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
6897 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
6898 bool skip = false;
6899 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
6900 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
6901 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
6902 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
6903 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006904 if (SafeModulo(pInfo->dst.deviceAddress, 256) != 0) {
6905 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pInfo-03740",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006906 "vkCmdCopyAccelerationStructureToMemoryKHR(): pInfo->dst.deviceAddress (0x%" PRIx64 ") must be aligned to 256 bytes.",
sourav parmarcd5fb182020-07-17 12:58:44 -07006907 pInfo->dst.deviceAddress);
sourav parmar83c31b12020-05-06 12:30:54 -07006908 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006909 return skip;
6910}
6911
6912bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
6913 const char *api_name) const {
6914 bool skip = false;
6915 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
6916 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
6917 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
6918 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
6919 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
6920 api_name);
6921 }
6922 return skip;
6923}
6924
6925bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006926 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006927 bool skip = false;
6928 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006929 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006930 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
sourav parmar83c31b12020-05-06 12:30:54 -07006931 skip |= LogError(
sourav parmarcd5fb182020-07-17 12:58:44 -07006932 device, "VUID-vkCopyAccelerationStructureKHR-accelerationStructureHostCommands-03582",
6933 "vkCopyAccelerationStructureKHR: The "
6934 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006935 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006936 return skip;
6937}
6938
6939bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
6940 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
6941 bool skip = false;
6942 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
6943 return skip;
6944}
6945
6946bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06006947 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006948 bool skip = false;
6949 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006950 skip |= LogError(device, "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07006951 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
6952 }
6953 return skip;
6954}
6955
6956bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006957 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006958 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07006959 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006960 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006961 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
6962 skip |= LogError(
6963 device, "VUID-vkCopyMemoryToAccelerationStructureKHR-accelerationStructureHostCommands-03583",
6964 "vkCopyMemoryToAccelerationStructureKHR: The "
6965 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006966 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006967 skip |= validate_required_pointer("vkCopyMemoryToAccelerationStructureKHR", "pInfo->src.hostAddress", pInfo->src.hostAddress,
6968 "VUID-vkCopyMemoryToAccelerationStructureKHR-pInfo-03729");
sourav parmara96ab1a2020-04-25 16:28:23 -07006969 return skip;
6970}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06006971
sourav parmara96ab1a2020-04-25 16:28:23 -07006972bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
6973 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
6974 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07006975 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
sourav parmarcd5fb182020-07-17 12:58:44 -07006976 if (SafeModulo(pInfo->src.deviceAddress, 256) != 0) {
6977 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pInfo-03743",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006978 "vkCmdCopyMemoryToAccelerationStructureKHR(): pInfo->src.deviceAddress (0x%" PRIx64 ") must be aligned to 256 bytes.",
sourav parmarcd5fb182020-07-17 12:58:44 -07006979 pInfo->src.deviceAddress);
6980 }
sourav parmar83c31b12020-05-06 12:30:54 -07006981 return skip;
6982}
6983bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
6984 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
6985 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
6986 bool skip = false;
6987 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
6988 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
6989 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
6990 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
6991 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
6992 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
6993 }
6994 return skip;
6995}
6996bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
6997 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
6998 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
6999 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007000 const auto *acc_structure_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07007001 if (!acc_structure_features || acc_structure_features->accelerationStructureHostCommands == VK_FALSE) {
7002 skip |= LogError(
7003 device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-accelerationStructureHostCommands-03585",
7004 "vkCmdWriteAccelerationStructuresPropertiesKHR: The "
7005 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
7006 }
sourav parmar83c31b12020-05-06 12:30:54 -07007007 if (dataSize < accelerationStructureCount * stride) {
7008 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
7009 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007010 "accelerationStructureCount (%" PRIu32 ") *stride(%zu).",
sourav parmar83c31b12020-05-06 12:30:54 -07007011 dataSize, accelerationStructureCount, stride);
7012 }
7013 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
7014 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
7015 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
7016 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
7017 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
7018 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
7019 }
7020 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
7021 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
7022 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
7023 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
7024 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
7025 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
7026 stride);
7027 }
7028 }
7029 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
7030 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
7031 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
7032 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
7033 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
7034 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
7035 stride);
7036 }
7037 }
sourav parmar83c31b12020-05-06 12:30:54 -07007038 return skip;
7039}
7040bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
7041 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
7042 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007043 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07007044 if (!raytracing_features || raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE) {
7045 skip |= LogError(
7046 device, "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03606",
7047 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR:VkPhysicalDeviceRayTracingPipelineFeaturesKHR::"
7048 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled to call this function.");
sourav parmar83c31b12020-05-06 12:30:54 -07007049 }
7050 return skip;
7051}
7052
7053bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
sourav parmarcd5fb182020-07-17 12:58:44 -07007054 const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
7055 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable,
7056 const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
7057 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable,
sourav parmar83c31b12020-05-06 12:30:54 -07007058 uint32_t width, uint32_t height, uint32_t depth) const {
7059 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07007060 // RayGen
7061 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
7062 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-size-04023",
7063 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07007064 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007065 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7066 0) {
7067 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03682",
7068 "vkCmdTraceRaysKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
7069 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7070 }
7071 // Callable
7072 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7073 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03694",
7074 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
7075 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007076 }
7077 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7078 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
7079 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07007080 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7081 }
7082 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7083 0) {
7084 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03693",
7085 "vkCmdTraceRaysKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
7086 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007087 }
7088 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007089 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7090 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03690",
7091 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple of "
7092 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007093 }
7094 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7095 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07007096 "vkCmdTraceRaysKHR: TThe stride member of pHitShaderBindingTable must be less than or equal to "
7097 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride");
sourav parmar83c31b12020-05-06 12:30:54 -07007098 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007099 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7100 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03689",
7101 "vkCmdTraceRaysKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
7102 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7103 }
sourav parmar83c31b12020-05-06 12:30:54 -07007104 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007105 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7106 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03686",
7107 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple of "
7108 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment");
sourav parmar83c31b12020-05-06 12:30:54 -07007109 }
7110 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7111 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
7112 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07007113 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7114 }
7115 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7116 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03685",
7117 "vkCmdTraceRaysKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
7118 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7119 }
7120 if (width * depth * height > phys_dev_ext_props.ray_tracing_propsKHR.maxRayDispatchInvocationCount) {
7121 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-width-03629",
7122 "vkCmdTraceRaysKHR: width {times} height {times} depth must be less than or equal to "
7123 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayDispatchInvocationCount");
7124 }
7125 if (width > device_limits.maxComputeWorkGroupCount[0] * device_limits.maxComputeWorkGroupSize[0]) {
7126 skip |=
7127 LogError(device, "VUID-vkCmdTraceRaysKHR-width-03626",
7128 "vkCmdTraceRaysKHR: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[0] "
7129 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[0]");
sourav parmar83c31b12020-05-06 12:30:54 -07007130 }
7131
sourav parmarcd5fb182020-07-17 12:58:44 -07007132 if (height > device_limits.maxComputeWorkGroupCount[1] * device_limits.maxComputeWorkGroupSize[1]) {
7133 skip |=
7134 LogError(device, "VUID-vkCmdTraceRaysKHR-height-03627",
7135 "vkCmdTraceRaysKHR: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1] "
7136 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[1]");
7137 }
7138
7139 if (depth > device_limits.maxComputeWorkGroupCount[2] * device_limits.maxComputeWorkGroupSize[2]) {
7140 skip |=
7141 LogError(device, "VUID-vkCmdTraceRaysKHR-depth-03628",
7142 "vkCmdTraceRaysKHR: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2] "
7143 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[2]");
sourav parmar83c31b12020-05-06 12:30:54 -07007144 }
7145 return skip;
7146}
7147
sourav parmarcd5fb182020-07-17 12:58:44 -07007148bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(
7149 VkCommandBuffer commandBuffer, const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
7150 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable, const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
7151 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable, VkDeviceAddress indirectDeviceAddress) const {
sourav parmar83c31b12020-05-06 12:30:54 -07007152 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007153 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07007154 if (!raytracing_features || raytracing_features->rayTracingPipelineTraceRaysIndirect == VK_FALSE) {
7155 skip |= LogError(
7156 device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingPipelineTraceRaysIndirect-03637",
7157 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineTraceRaysIndirect "
7158 "feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07007159 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007160 // RayGen
7161 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
7162 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-size-04023",
7163 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07007164 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007165 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7166 0) {
7167 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03682",
7168 "vkCmdTraceRaysIndirectKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
7169 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7170 }
7171 // Callabe
7172 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7173 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03694",
7174 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
7175 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007176 }
7177 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7178 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
sourav parmarcd5fb182020-07-17 12:58:44 -07007179 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be less than or equal "
7180 "to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7181 }
7182 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7183 0) {
7184 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03693",
7185 "vkCmdTraceRaysIndirectKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
7186 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007187 }
7188 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007189 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7190 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03690",
7191 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple of "
7192 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007193 }
7194 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7195 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07007196 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be less than or equal to "
7197 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
sourav parmar83c31b12020-05-06 12:30:54 -07007198 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007199 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7200 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03689",
7201 "vkCmdTraceRaysIndirectKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
7202 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7203 }
sourav parmar83c31b12020-05-06 12:30:54 -07007204 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007205 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7206 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03686",
7207 "vkCmdTraceRaysIndirectKHR:The stride member of pMissShaderBindingTable must be a multiple of "
7208 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007209 }
7210 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7211 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
sourav parmarcd5fb182020-07-17 12:58:44 -07007212 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be less than or equal to "
7213 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7214 }
7215 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7216 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03685",
7217 "vkCmdTraceRaysIndirectKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
7218 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007219 }
7220
sourav parmarcd5fb182020-07-17 12:58:44 -07007221 if (SafeModulo(indirectDeviceAddress, 4) != 0) {
7222 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-indirectDeviceAddress-03634",
7223 "vkCmdTraceRaysIndirectKHR: indirectDeviceAddress must be a multiple of 4.");
sourav parmar83c31b12020-05-06 12:30:54 -07007224 }
7225 return skip;
7226}
7227bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
7228 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
7229 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
7230 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
7231 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
7232 uint32_t width, uint32_t height, uint32_t depth) const {
7233 bool skip = false;
7234 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7235 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
7236 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
7237 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7238 }
7239 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
7240 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
7241 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
7242 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
7243 }
7244 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
7245 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
7246 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
7247 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
7248 }
7249
7250 // hitShader
7251 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7252 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
7253 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
7254 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7255 }
7256 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
7257 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
7258 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
7259 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
7260 }
7261 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
7262 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
7263 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
7264 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
7265 }
7266
7267 // missShader
7268 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7269 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
7270 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
7271 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7272 }
7273 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
7274 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
7275 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
7276 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
7277 }
7278 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
7279 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
7280 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
7281 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
7282 }
7283
7284 // raygenShader
7285 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7286 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
7287 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07007288 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7289 }
7290 if (width > device_limits.maxComputeWorkGroupCount[0]) {
7291 skip |=
7292 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
7293 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
7294 }
7295 if (height > device_limits.maxComputeWorkGroupCount[1]) {
7296 skip |=
7297 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
7298 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
7299 }
7300 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
7301 skip |=
7302 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
7303 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07007304 }
7305 return skip;
7306}
7307
sourav parmar83c31b12020-05-06 12:30:54 -07007308bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07007309 VkDevice device, const VkAccelerationStructureVersionInfoKHR *pVersionInfo,
7310 VkAccelerationStructureCompatibilityKHR *pCompatibility) const {
sourav parmar83c31b12020-05-06 12:30:54 -07007311 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007312 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
7313 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07007314 if ((!raytracing_features && !ray_query_features) || ((ray_query_features && !(ray_query_features->rayQuery)) ||
7315 (raytracing_features && !raytracing_features->rayTracingPipeline))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007316 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracingPipeline-03661",
sourav parmar83c31b12020-05-06 12:30:54 -07007317 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
7318 }
7319 return skip;
7320}
7321
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007322bool StatelessValidation::ValidateCmdSetViewportWithCount(VkCommandBuffer commandBuffer, uint32_t viewportCount,
7323 const VkViewport *pViewports, bool is_ext) const {
Piers Daniell39842ee2020-07-10 16:42:33 -06007324 bool skip = false;
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007325 const char *api_call = is_ext ? "vkCmdSetViewportWithCountEXT" : "vkCmdSetViewportWithCount";
Piers Daniell39842ee2020-07-10 16:42:33 -06007326
7327 if (!physical_device_features.multiViewport) {
7328 if (viewportCount != 1) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007329 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCount-viewportCount-03395",
7330 "%s: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.", api_call,
Piers Daniell39842ee2020-07-10 16:42:33 -06007331 viewportCount);
7332 }
7333 } else { // multiViewport enabled
7334 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007335 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCount-viewportCount-03394",
7336 "%s: viewportCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007337 ") must "
7338 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007339 api_call, viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06007340 }
7341 }
7342
7343 if (pViewports) {
7344 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
7345 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Piers Daniell39842ee2020-07-10 16:42:33 -06007346 skip |= manual_PreCallValidateViewport(
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007347 viewport, api_call, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Piers Daniell39842ee2020-07-10 16:42:33 -06007348 }
7349 }
7350
7351 return skip;
7352}
7353
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007354bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
7355 const VkViewport *pViewports) const {
Piers Daniell39842ee2020-07-10 16:42:33 -06007356 bool skip = false;
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007357 skip = ValidateCmdSetViewportWithCount(commandBuffer, viewportCount, pViewports, true);
7358 return skip;
7359}
7360
7361bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCount(VkCommandBuffer commandBuffer, uint32_t viewportCount,
7362 const VkViewport *pViewports) const {
7363 bool skip = false;
7364 skip = ValidateCmdSetViewportWithCount(commandBuffer, viewportCount, pViewports, false);
7365 return skip;
7366}
7367
7368bool StatelessValidation::ValidateCmdSetScissorWithCount(VkCommandBuffer commandBuffer, uint32_t scissorCount,
7369 const VkRect2D *pScissors, bool is_ext) const {
7370 bool skip = false;
7371 const char *api_call = is_ext ? "vkCmdSetScissorWithCountEXT" : "vkCmdSetScissorWithCount";
Piers Daniell39842ee2020-07-10 16:42:33 -06007372
7373 if (!physical_device_features.multiViewport) {
7374 if (scissorCount != 1) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007375 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-scissorCount-03398",
7376 "%s: scissorCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007377 ") must "
7378 "be 1 when the multiViewport feature is disabled.",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007379 api_call, scissorCount);
Piers Daniell39842ee2020-07-10 16:42:33 -06007380 }
7381 } else { // multiViewport enabled
7382 if (scissorCount == 0) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007383 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-scissorCount-03397",
7384 "%s: scissorCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007385 ") must "
7386 "be great than zero.",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007387 api_call, scissorCount);
Piers Daniell39842ee2020-07-10 16:42:33 -06007388 } else if (scissorCount > device_limits.maxViewports) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007389 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-scissorCount-03397",
7390 "%s: scissorCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007391 ") must "
7392 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007393 api_call, scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06007394 }
7395 }
7396
7397 if (pScissors) {
7398 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
7399 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
7400
7401 if (scissor.offset.x < 0) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007402 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-x-03399", "%s: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", api_call,
7403 scissor_i, scissor.offset.x);
Piers Daniell39842ee2020-07-10 16:42:33 -06007404 }
7405
7406 if (scissor.offset.y < 0) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007407 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-x-03399", "%s: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", api_call,
7408 scissor_i, scissor.offset.y);
Piers Daniell39842ee2020-07-10 16:42:33 -06007409 }
7410
7411 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
7412 if (x_sum > INT32_MAX) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007413 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-offset-03400",
7414 "%s: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64 ") of pScissors[%" PRIu32
7415 "] will overflow int32_t.",
7416 api_call, scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Piers Daniell39842ee2020-07-10 16:42:33 -06007417 }
7418
7419 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
7420 if (y_sum > INT32_MAX) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007421 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-offset-03401",
7422 "%s: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64 ") of pScissors[%" PRIu32
7423 "] will overflow int32_t.",
7424 api_call, scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
7425 }
7426 }
7427 }
7428
7429 return skip;
7430}
7431
7432bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
7433 const VkRect2D *pScissors) const {
7434 bool skip = false;
7435 skip = ValidateCmdSetScissorWithCount(commandBuffer, scissorCount, pScissors, true);
7436 return skip;
7437}
7438
7439bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCount(VkCommandBuffer commandBuffer, uint32_t scissorCount,
7440 const VkRect2D *pScissors) const {
7441 bool skip = false;
7442 skip = ValidateCmdSetScissorWithCount(commandBuffer, scissorCount, pScissors, false);
7443 return skip;
7444}
7445
7446bool StatelessValidation::ValidateCmdBindVertexBuffers2(VkCommandBuffer commandBuffer, uint32_t firstBinding, uint32_t bindingCount,
7447 const VkBuffer *pBuffers, const VkDeviceSize *pOffsets,
7448 const VkDeviceSize *pSizes, const VkDeviceSize *pStrides,
7449 bool is_2ext) const {
7450 bool skip = false;
7451 const char *api_call = is_2ext ? "vkCmdBindVertexBuffers2EXT()" : "vkCmdBindVertexBuffers2()";
7452 if (firstBinding >= device_limits.maxVertexInputBindings) {
7453 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-firstBinding-03355",
7454 "%s firstBinding (%" PRIu32 ") must be less than maxVertexInputBindings (%" PRIu32 ")", api_call,
7455 firstBinding, device_limits.maxVertexInputBindings);
7456 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
7457 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-firstBinding-03356",
7458 "%s sum of firstBinding (%" PRIu32 ") and bindingCount (%" PRIu32
7459 ") must be less than "
7460 "maxVertexInputBindings (%" PRIu32 ")",
7461 api_call, firstBinding, bindingCount, device_limits.maxVertexInputBindings);
7462 }
7463
7464 for (uint32_t i = 0; i < bindingCount; ++i) {
7465 if (pBuffers[i] == VK_NULL_HANDLE) {
7466 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
7467 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
7468 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-pBuffers-04111",
7469 "%s required parameter pBuffers[%" PRIu32 "] specified as VK_NULL_HANDLE", api_call, i);
7470 } else {
7471 if (pOffsets[i] != 0) {
7472 skip |=
7473 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-pBuffers-04112",
7474 "%s pBuffers[%" PRIu32 "] is VK_NULL_HANDLE, but pOffsets[%" PRIu32 "] is not 0", api_call, i, i);
7475 }
7476 }
7477 }
7478 if (pStrides) {
7479 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
7480 skip |=
7481 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-pStrides-03362",
7482 "%s pStrides[%" PRIu32 "] (%" PRIu64 ") must be less than maxVertexInputBindingStride (%" PRIu32 ")",
7483 api_call, i, pStrides[i], device_limits.maxVertexInputBindingStride);
Piers Daniell39842ee2020-07-10 16:42:33 -06007484 }
7485 }
7486 }
7487
7488 return skip;
7489}
7490
7491bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
7492 uint32_t bindingCount, const VkBuffer *pBuffers,
7493 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
7494 const VkDeviceSize *pStrides) const {
7495 bool skip = false;
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007496 skip = ValidateCmdBindVertexBuffers2(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets, pSizes, pStrides, true);
7497 return skip;
7498}
Piers Daniell39842ee2020-07-10 16:42:33 -06007499
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007500bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2(VkCommandBuffer commandBuffer, uint32_t firstBinding,
7501 uint32_t bindingCount, const VkBuffer *pBuffers,
7502 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
7503 const VkDeviceSize *pStrides) const {
7504 bool skip = false;
7505 skip = ValidateCmdBindVertexBuffers2(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets, pSizes, pStrides, false);
Piers Daniell39842ee2020-07-10 16:42:33 -06007506 return skip;
7507}
sourav parmarcd5fb182020-07-17 12:58:44 -07007508
7509bool StatelessValidation::ValidateAccelerationStructureBuildGeometryInfoKHR(
7510 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos, uint32_t infoCount, const char *api_name) const {
7511 bool skip = false;
7512 for (uint32_t i = 0; i < infoCount; ++i) {
7513 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
7514 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03654",
7515 "(%s): type must not be VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.", api_name);
7516 }
7517 if (pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
7518 pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
7519 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-flags-03796",
7520 "(%s): If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR bit set,"
7521 "then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.",
7522 api_name);
7523 }
7524 if (pInfos[i].pGeometries && pInfos[i].ppGeometries) {
7525 skip |=
7526 LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-pGeometries-03788",
7527 "(%s): Only one of pGeometries or ppGeometries can be a valid pointer, the other must be NULL", api_name);
7528 }
7529 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pInfos[i].geometryCount != 1) {
7530 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03790",
7531 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, geometryCount must be 1", api_name);
7532 }
7533 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
7534 pInfos[i].geometryCount > phys_dev_ext_props.acc_structure_props.maxGeometryCount) {
7535 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03793",
7536 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then geometryCount must be"
7537 " less than or equal to VkPhysicalDeviceAccelerationStructurePropertiesKHR::maxGeometryCount",
7538 api_name);
7539 }
7540 if (pInfos[i].pGeometries) {
7541 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7542 skip |= validate_ranged_enum(
7543 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometryType", ParameterName::IndexVector{i, j}),
7544 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].pGeometries[j].geometryType,
7545 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
7546 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007547 skip |= validate_struct_type(
7548 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles", ParameterName::IndexVector{i, j}),
7549 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7550 &(pInfos[i].pGeometries[j].geometry.triangles),
7551 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
7552 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
7553 skip |= validate_struct_pnext(
7554 api_name,
7555 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
7556 NULL, pInfos[i].pGeometries[j].geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7557 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
7558 skip |=
7559 validate_ranged_enum(api_name,
7560 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.vertexFormat",
7561 ParameterName::IndexVector{i, j}),
7562 "VkFormat", AllVkFormatEnums, pInfos[i].pGeometries[j].geometry.triangles.vertexFormat,
7563 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
7564 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
7565 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7566 &pInfos[i].pGeometries[j].geometry.triangles,
7567 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
7568 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
7569 skip |= validate_ranged_enum(
7570 api_name,
7571 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.indexType", ParameterName::IndexVector{i, j}),
7572 "VkIndexType", AllVkIndexTypeEnums, pInfos[i].pGeometries[j].geometry.triangles.indexType,
7573 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
7574
7575 if (pInfos[i].pGeometries[j].geometry.triangles.vertexStride > UINT32_MAX) {
7576 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
7577 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
7578 }
7579 if (pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
7580 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
7581 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
7582 skip |=
7583 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
7584 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
7585 api_name);
7586 }
7587 }
7588 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7589 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
7590 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7591 &pInfos[i].pGeometries[j].geometry.instances,
7592 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
7593 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
7594 skip |= validate_struct_type(
7595 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.instances", ParameterName::IndexVector{i, j}),
7596 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7597 &(pInfos[i].pGeometries[j].geometry.instances),
7598 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
7599 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
7600 skip |= validate_struct_pnext(
7601 api_name,
7602 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.pNext", ParameterName::IndexVector{i, j}),
7603 NULL, pInfos[i].pGeometries[j].geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7604 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
7605
7606 skip |= validate_bool32(api_name,
7607 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.arrayOfPointers",
7608 ParameterName::IndexVector{i, j}),
7609 pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers);
7610 }
7611 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7612 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
7613 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7614 &pInfos[i].pGeometries[j].geometry.aabbs,
7615 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
7616 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
7617 skip |= validate_struct_type(
7618 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs", ParameterName::IndexVector{i, j}),
7619 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7620 &(pInfos[i].pGeometries[j].geometry.aabbs),
7621 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
7622 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
7623 skip |= validate_struct_pnext(
7624 api_name,
7625 ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
7626 pInfos[i].pGeometries[j].geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7627 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
7628 if (pInfos[i].pGeometries[j].geometry.aabbs.stride > UINT32_MAX) {
7629 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
7630 "(%s):stride must be less than or equal to 2^32-1", api_name);
7631 }
7632 }
7633 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
7634 pInfos[i].pGeometries[j].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7635 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
7636 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
7637 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7638 api_name);
7639 }
7640 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
7641 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7642 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
7643 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
7644 "of elements of"
7645 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7646 api_name);
7647 }
7648 if (pInfos[i].pGeometries[j].geometryType != pInfos[i].pGeometries[0].geometryType) {
7649 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
7650 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
7651 " member of each geometry in either pGeometries or ppGeometries must be the same.",
7652 api_name);
7653 }
7654 }
7655 }
7656 }
7657 if (pInfos[i].ppGeometries != NULL) {
7658 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7659 skip |= validate_ranged_enum(
7660 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometryType", ParameterName::IndexVector{i, j}),
7661 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].ppGeometries[j]->geometryType,
7662 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
7663 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007664 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
7665 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7666 &pInfos[i].ppGeometries[j]->geometry.triangles,
7667 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
7668 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
7669 skip |= validate_struct_type(
7670 api_name,
7671 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles", ParameterName::IndexVector{i, j}),
7672 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7673 &(pInfos[i].ppGeometries[j]->geometry.triangles),
7674 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
7675 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
7676 skip |= validate_struct_pnext(
7677 api_name,
7678 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
7679 NULL, pInfos[i].ppGeometries[j]->geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7680 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
7681 skip |= validate_ranged_enum(api_name,
7682 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.vertexFormat",
7683 ParameterName::IndexVector{i, j}),
7684 "VkFormat", AllVkFormatEnums,
7685 pInfos[i].ppGeometries[j]->geometry.triangles.vertexFormat,
7686 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
7687 skip |= validate_ranged_enum(api_name,
7688 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.indexType",
7689 ParameterName::IndexVector{i, j}),
7690 "VkIndexType", AllVkIndexTypeEnums,
7691 pInfos[i].ppGeometries[j]->geometry.triangles.indexType,
7692 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
7693 if (pInfos[i].ppGeometries[j]->geometry.triangles.vertexStride > UINT32_MAX) {
7694 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
7695 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
7696 }
7697 if (pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
7698 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
7699 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
7700 skip |=
7701 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
7702 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
7703 api_name);
7704 }
7705 }
7706 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7707 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
7708 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7709 &pInfos[i].ppGeometries[j]->geometry.instances,
7710 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
7711 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
7712 skip |= validate_struct_type(
7713 api_name,
7714 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances", ParameterName::IndexVector{i, j}),
7715 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7716 &(pInfos[i].ppGeometries[j]->geometry.instances),
7717 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
7718 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
7719 skip |= validate_struct_pnext(
7720 api_name,
7721 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.pNext", ParameterName::IndexVector{i, j}),
7722 NULL, pInfos[i].ppGeometries[j]->geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7723 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
7724 skip |= validate_bool32(api_name,
7725 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.arrayOfPointers",
7726 ParameterName::IndexVector{i, j}),
7727 pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers);
7728 }
7729 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7730 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
7731 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7732 &pInfos[i].ppGeometries[j]->geometry.aabbs,
7733 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
7734 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
7735 skip |= validate_struct_type(
7736 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs", ParameterName::IndexVector{i, j}),
7737 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7738 &(pInfos[i].ppGeometries[j]->geometry.aabbs),
7739 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
7740 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
7741 skip |= validate_struct_pnext(
7742 api_name,
7743 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
7744 pInfos[i].ppGeometries[j]->geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7745 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
7746 if (pInfos[i].ppGeometries[j]->geometry.aabbs.stride > UINT32_MAX) {
7747 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
7748 "(%s):stride must be less than or equal to 2^32-1", api_name);
7749 }
7750 }
7751 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
7752 pInfos[i].ppGeometries[j]->geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7753 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
7754 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
7755 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7756 api_name);
7757 }
7758 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
7759 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7760 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
7761 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
7762 "of elements of"
7763 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7764 api_name);
7765 }
7766 if (pInfos[i].ppGeometries[j]->geometryType != pInfos[i].ppGeometries[0]->geometryType) {
7767 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
7768 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
7769 " member of each geometry in either pGeometries or ppGeometries must be the same.",
7770 api_name);
7771 }
7772 }
7773 }
7774 }
7775 }
7776 return skip;
7777}
7778bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresKHR(
7779 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
7780 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
7781 bool skip = false;
7782 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresKHR");
7783 for (uint32_t i = 0; i < infoCount; ++i) {
7784 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
7785 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
7786 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03710",
7787 "vkCmdBuildAccelerationStructuresKHR:For each element of pInfos, its "
7788 "scratchData.deviceAddress member must be a multiple of "
7789 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
7790 }
7791 for (uint32_t k = 0; k < infoCount; ++k) {
7792 if (i == k) continue;
7793 bool found = false;
7794 if (pInfos[i].dstAccelerationStructure == pInfos[k].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007795 skip |=
7796 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
7797 "vkCmdBuildAccelerationStructuresKHR:The dstAccelerationStructure member of any element (%" PRIu32
7798 ") of pInfos must "
7799 "not be "
7800 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7801 ") of pInfos.",
7802 i, k);
sourav parmarcd5fb182020-07-17 12:58:44 -07007803 found = true;
7804 }
7805 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007806 skip |=
7807 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03403",
7808 "vkCmdBuildAccelerationStructuresKHR:The srcAccelerationStructure member of any element (%" PRIu32
7809 ") of pInfos must "
7810 "not be "
7811 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7812 ") of pInfos.",
7813 i, k);
sourav parmarcd5fb182020-07-17 12:58:44 -07007814 found = true;
7815 }
7816 if (found) break;
7817 }
7818 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7819 if (pInfos[i].pGeometries) {
7820 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7821 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
7822 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7823 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
7824 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7825 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7826 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7827 }
7828 } else {
7829 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
7830 skip |=
7831 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
7832 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7833 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7834 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7835 }
7836 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007837 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007838 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7839 skip |= LogError(
7840 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
7841 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7842 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7843 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007844 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7845 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007846 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
7847 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
7848 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7849 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7850 }
7851 }
7852 } else if (pInfos[i].ppGeometries) {
7853 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7854 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
7855 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7856 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
7857 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7858 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7859 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7860 }
7861 } else {
7862 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
7863 skip |=
7864 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
7865 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7866 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7867 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7868 }
7869 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007870 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007871 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7872 skip |= LogError(
7873 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
7874 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7875 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7876 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007877 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7878 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007879 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
7880 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
7881 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7882 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7883 }
7884 }
7885 }
7886 }
7887 }
7888 return skip;
7889}
7890
7891bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresIndirectKHR(
7892 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
7893 const VkDeviceAddress *pIndirectDeviceAddresses, const uint32_t *pIndirectStrides,
7894 const uint32_t *const *ppMaxPrimitiveCounts) const {
7895 bool skip = false;
7896 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresIndirectKHR");
7897 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007898 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07007899 if (!ray_tracing_acceleration_structure_features ||
7900 ray_tracing_acceleration_structure_features->accelerationStructureIndirectBuild == VK_FALSE) {
7901 skip |= LogError(
7902 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-accelerationStructureIndirectBuild-03650",
7903 "vkCmdBuildAccelerationStructuresIndirectKHR: The "
7904 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureIndirectBuild feature must be enabled.");
7905 }
7906 for (uint32_t i = 0; i < infoCount; ++i) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007907 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
7908 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
7909 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03710",
7910 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, its "
7911 "scratchData.deviceAddress member must be a multiple of "
7912 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
7913 }
7914 for (uint32_t k = 0; k < infoCount; ++k) {
7915 if (i == k) continue;
7916 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007917 skip |= LogError(
7918 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03403",
7919 "vkCmdBuildAccelerationStructuresIndirectKHR:The srcAccelerationStructure member of any element (%" PRIu32
7920 ") "
7921 "of pInfos must not be the same acceleration structure as the dstAccelerationStructure member of "
7922 "any other element [%" PRIu32 ") of pInfos.",
7923 i, k);
sourav parmarcd5fb182020-07-17 12:58:44 -07007924 break;
7925 }
7926 }
7927 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7928 if (pInfos[i].pGeometries) {
7929 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7930 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
7931 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7932 skip |= LogError(
7933 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
7934 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7935 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7936 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7937 }
7938 } else {
7939 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
7940 skip |= LogError(
7941 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
7942 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7943 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7944 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7945 }
7946 }
7947 }
7948 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7949 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7950 skip |= LogError(
7951 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
7952 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7953 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7954 }
7955 }
7956 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7957 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.indexData.deviceAddress, 16) != 0) {
7958 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
7959 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
7960 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7961 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7962 }
7963 }
7964 } else if (pInfos[i].ppGeometries) {
7965 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7966 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
7967 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7968 skip |= LogError(
7969 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
7970 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7971 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7972 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7973 }
7974 } else {
7975 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
7976 skip |= LogError(
7977 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
7978 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7979 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7980 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7981 }
7982 }
7983 }
7984 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7985 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7986 skip |= LogError(
7987 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
7988 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7989 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7990 }
7991 }
7992 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7993 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.indexData.deviceAddress, 16) != 0) {
7994 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
7995 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
7996 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7997 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7998 }
7999 }
8000 }
8001 }
8002 }
8003 return skip;
8004}
8005
8006bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructuresKHR(
8007 VkDevice device, VkDeferredOperationKHR deferredOperation, uint32_t infoCount,
8008 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
8009 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
8010 bool skip = false;
8011 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkBuildAccelerationStructuresKHR");
8012 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07008013 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07008014 if (!ray_tracing_acceleration_structure_features ||
8015 ray_tracing_acceleration_structure_features->accelerationStructureHostCommands == VK_FALSE) {
8016 skip |=
8017 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581",
8018 "vkBuildAccelerationStructuresKHR: The "
8019 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled");
8020 }
8021 for (uint32_t i = 0; i < infoCount; ++i) {
8022 for (uint32_t j = 0; j < infoCount; ++j) {
8023 if (i == j) continue;
8024 bool found = false;
8025 if (pInfos[i].dstAccelerationStructure == pInfos[j].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008026 skip |=
8027 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
8028 "vkBuildAccelerationStructuresKHR(): The dstAccelerationStructure member of any element (%" PRIu32
8029 ") of pInfos must "
8030 "not be "
8031 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
8032 ") of pInfos.",
8033 i, j);
sourav parmarcd5fb182020-07-17 12:58:44 -07008034 found = true;
8035 }
8036 if (pInfos[i].srcAccelerationStructure == pInfos[j].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008037 skip |=
8038 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-pInfos-03403",
8039 "vkBuildAccelerationStructuresKHR(): The srcAccelerationStructure member of any element (%" PRIu32
8040 ") of pInfos must "
8041 "not be "
8042 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
8043 ") of pInfos.",
8044 i, j);
sourav parmarcd5fb182020-07-17 12:58:44 -07008045 found = true;
8046 }
8047 if (found) break;
8048 }
8049 }
8050 return skip;
8051}
8052
8053bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureBuildSizesKHR(
8054 VkDevice device, VkAccelerationStructureBuildTypeKHR buildType, const VkAccelerationStructureBuildGeometryInfoKHR *pBuildInfo,
8055 const uint32_t *pMaxPrimitiveCounts, VkAccelerationStructureBuildSizesInfoKHR *pSizeInfo) const {
8056 bool skip = false;
8057 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pBuildInfo, 1, "vkGetAccelerationStructureBuildSizesKHR");
8058 const auto *ray_tracing_pipeline_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07008059 LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
8060 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
ziga-lunargbcfba982022-03-19 17:49:55 +01008061 if (!((ray_tracing_pipeline_features && ray_tracing_pipeline_features->rayTracingPipeline == VK_TRUE) ||
8062 (ray_query_features && ray_query_features->rayQuery == VK_TRUE))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07008063 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-rayTracingPipeline-03617",
Lars-Ivar Hesselberg Simonsendcd1e402021-11-23 17:14:03 +01008064 "vkGetAccelerationStructureBuildSizesKHR: The rayTracingPipeline or rayQuery feature must be enabled");
8065 }
8066 if (pBuildInfo != nullptr) {
8067 if (pBuildInfo->geometryCount != 0 && pMaxPrimitiveCounts == nullptr) {
8068 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-pBuildInfo-03619",
8069 "vkGetAccelerationStructureBuildSizesKHR: If pBuildInfo->geometryCount is not 0, pMaxPrimitiveCounts "
8070 "must be a valid pointer to an array of pBuildInfo->geometryCount uint32_t values");
8071 }
sourav parmarcd5fb182020-07-17 12:58:44 -07008072 }
8073 return skip;
8074}
sfricke-samsungecafb192021-01-17 08:21:14 -08008075
Piers Daniellcb6d8032021-04-19 18:51:26 -06008076bool StatelessValidation::manual_PreCallValidateCmdSetVertexInputEXT(
8077 VkCommandBuffer commandBuffer, uint32_t vertexBindingDescriptionCount,
8078 const VkVertexInputBindingDescription2EXT *pVertexBindingDescriptions, uint32_t vertexAttributeDescriptionCount,
8079 const VkVertexInputAttributeDescription2EXT *pVertexAttributeDescriptions) const {
8080 bool skip = false;
Piers Daniellcb6d8032021-04-19 18:51:26 -06008081 const auto *vertex_attribute_divisor_features =
8082 LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(device_createinfo_pnext);
8083
Piers Daniellcb6d8032021-04-19 18:51:26 -06008084 // VUID-vkCmdSetVertexInputEXT-vertexBindingDescriptionCount-04791
8085 if (vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
8086 skip |=
8087 LogError(device, "VUID-vkCmdSetVertexInputEXT-vertexBindingDescriptionCount-04791",
8088 "vkCmdSetVertexInputEXT(): vertexBindingDescriptionCount is greater than the maxVertexInputBindings limit");
8089 }
8090
8091 // VUID-vkCmdSetVertexInputEXT-vertexAttributeDescriptionCount-04792
8092 if (vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
8093 skip |= LogError(
8094 device, "VUID-vkCmdSetVertexInputEXT-vertexAttributeDescriptionCount-04792",
8095 "vkCmdSetVertexInputEXT(): vertexAttributeDescriptionCount is greater than the maxVertexInputAttributes limit");
8096 }
8097
8098 // VUID-vkCmdSetVertexInputEXT-binding-04793
8099 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount; ++attribute) {
8100 bool binding_found = false;
8101 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount; ++binding) {
8102 if (pVertexAttributeDescriptions[attribute].binding == pVertexBindingDescriptions[binding].binding) {
8103 binding_found = true;
8104 break;
8105 }
8106 }
8107 if (!binding_found) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008108 skip |= LogError(
8109 device, "VUID-vkCmdSetVertexInputEXT-binding-04793",
8110 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32 "] references an unspecified binding", attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008111 }
8112 }
8113
8114 // VUID-vkCmdSetVertexInputEXT-pVertexBindingDescriptions-04794
8115 if (vertexBindingDescriptionCount > 1) {
8116 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount - 1; ++binding) {
8117 uint32_t binding_value = pVertexBindingDescriptions[binding].binding;
8118 for (uint32_t next_binding = binding + 1; next_binding < vertexBindingDescriptionCount; ++next_binding) {
8119 if (binding_value == pVertexBindingDescriptions[next_binding].binding) {
8120 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-pVertexBindingDescriptions-04794",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008121 "vkCmdSetVertexInputEXT(): binding description for binding %" PRIu32 " already specified",
8122 binding_value);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008123 }
8124 }
8125 }
8126 }
8127
8128 // VUID-vkCmdSetVertexInputEXT-pVertexAttributeDescriptions-04795
8129 if (vertexAttributeDescriptionCount > 1) {
8130 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount - 1; ++attribute) {
8131 uint32_t location = pVertexAttributeDescriptions[attribute].location;
8132 for (uint32_t next_attribute = attribute + 1; next_attribute < vertexAttributeDescriptionCount; ++next_attribute) {
8133 if (location == pVertexAttributeDescriptions[next_attribute].location) {
8134 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-pVertexAttributeDescriptions-04795",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008135 "vkCmdSetVertexInputEXT(): attribute description for location %" PRIu32 " already specified",
8136 location);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008137 }
8138 }
8139 }
8140 }
8141
8142 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount; ++binding) {
8143 // VUID-VkVertexInputBindingDescription2EXT-binding-04796
8144 if (pVertexBindingDescriptions[binding].binding > device_limits.maxVertexInputBindings) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008145 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-binding-04796",
8146 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8147 "].binding is greater than maxVertexInputBindings",
8148 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008149 }
8150
8151 // VUID-VkVertexInputBindingDescription2EXT-stride-04797
8152 if (pVertexBindingDescriptions[binding].stride > device_limits.maxVertexInputBindingStride) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008153 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-stride-04797",
8154 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8155 "].stride is greater than maxVertexInputBindingStride",
8156 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008157 }
8158
8159 // VUID-VkVertexInputBindingDescription2EXT-divisor-04798
8160 if (pVertexBindingDescriptions[binding].divisor == 0 &&
8161 (!vertex_attribute_divisor_features || !vertex_attribute_divisor_features->vertexAttributeInstanceRateZeroDivisor)) {
8162 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04798",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008163 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8164 "].divisor is zero but "
Piers Daniellcb6d8032021-04-19 18:51:26 -06008165 "vertexAttributeInstanceRateZeroDivisor is not enabled",
8166 binding);
8167 }
8168
8169 if (pVertexBindingDescriptions[binding].divisor > 1) {
8170 // VUID-VkVertexInputBindingDescription2EXT-divisor-04799
8171 if (!vertex_attribute_divisor_features || !vertex_attribute_divisor_features->vertexAttributeInstanceRateDivisor) {
8172 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04799",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008173 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8174 "].divisor is greater than one but "
Piers Daniellcb6d8032021-04-19 18:51:26 -06008175 "vertexAttributeInstanceRateDivisor is not enabled",
8176 binding);
8177 } else {
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008178 // VUID-VkVertexInputBindingDescription2EXT-divisor-06226
Piers Daniellcb6d8032021-04-19 18:51:26 -06008179 if (pVertexBindingDescriptions[binding].divisor >
8180 phys_dev_ext_props.vertex_attribute_divisor_props.maxVertexAttribDivisor) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008181 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-06226",
8182 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8183 "].divisor is greater than maxVertexAttribDivisor",
8184 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008185 }
8186
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008187 // VUID-VkVertexInputBindingDescription2EXT-divisor-06227
Piers Daniellcb6d8032021-04-19 18:51:26 -06008188 if (pVertexBindingDescriptions[binding].inputRate != VK_VERTEX_INPUT_RATE_INSTANCE) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008189 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-06227",
8190 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8191 "].divisor is greater than 1 but inputRate "
8192 "is not VK_VERTEX_INPUT_RATE_INSTANCE",
8193 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008194 }
8195 }
8196 }
8197 }
8198
8199 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount; ++attribute) {
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008200 // VUID-VkVertexInputAttributeDescription2EXT-location-06228
Piers Daniellcb6d8032021-04-19 18:51:26 -06008201 if (pVertexAttributeDescriptions[attribute].location > device_limits.maxVertexInputAttributes) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008202 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-location-06228",
8203 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8204 "].location is greater than maxVertexInputAttributes",
8205 attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008206 }
8207
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008208 // VUID-VkVertexInputAttributeDescription2EXT-binding-06229
Piers Daniellcb6d8032021-04-19 18:51:26 -06008209 if (pVertexAttributeDescriptions[attribute].binding > device_limits.maxVertexInputBindings) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008210 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-binding-06229",
8211 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8212 "].binding is greater than maxVertexInputBindings",
8213 attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008214 }
8215
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008216 // VUID-VkVertexInputAttributeDescription2EXT-offset-06230
Piers Daniellcb6d8032021-04-19 18:51:26 -06008217 if (pVertexAttributeDescriptions[attribute].offset > device_limits.maxVertexInputAttributeOffset) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008218 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-offset-06230",
8219 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8220 "].offset is greater than maxVertexInputAttributeOffset",
8221 attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008222 }
8223
8224 // VUID-VkVertexInputAttributeDescription2EXT-format-04805
8225 VkFormatProperties properties;
8226 DispatchGetPhysicalDeviceFormatProperties(physical_device, pVertexAttributeDescriptions[attribute].format, &properties);
8227 if ((properties.bufferFeatures & VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT) == 0) {
8228 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-format-04805",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008229 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8230 "].format is not a "
Piers Daniellcb6d8032021-04-19 18:51:26 -06008231 "VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT supported format",
8232 attribute);
8233 }
8234 }
8235
8236 return skip;
8237}
sfricke-samsung51303fb2021-05-09 19:09:13 -07008238
8239bool StatelessValidation::manual_PreCallValidateCmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout,
8240 VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size,
8241 const void *pValues) const {
8242 bool skip = false;
8243 const uint32_t max_push_constants_size = device_limits.maxPushConstantsSize;
8244 // Check that offset + size don't exceed the max.
8245 // Prevent arithetic overflow here by avoiding addition and testing in this order.
8246 if (offset >= max_push_constants_size) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008247 skip |=
8248 LogError(device, "VUID-vkCmdPushConstants-offset-00370",
8249 "vkCmdPushConstants(): offset (%" PRIu32 ") that exceeds this device's maxPushConstantSize of %" PRIu32 ".",
8250 offset, max_push_constants_size);
sfricke-samsung51303fb2021-05-09 19:09:13 -07008251 }
8252 if (size > max_push_constants_size - offset) {
8253 skip |= LogError(device, "VUID-vkCmdPushConstants-size-00371",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008254 "vkCmdPushConstants(): offset (%" PRIu32 ") and size (%" PRIu32
8255 ") that exceeds this device's maxPushConstantSize of %" PRIu32 ".",
sfricke-samsung51303fb2021-05-09 19:09:13 -07008256 offset, size, max_push_constants_size);
8257 }
8258
8259 // size needs to be non-zero and a multiple of 4.
8260 if (size & 0x3) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008261 skip |= LogError(device, "VUID-vkCmdPushConstants-size-00369",
8262 "vkCmdPushConstants(): size (%" PRIu32 ") must be a multiple of 4.", size);
sfricke-samsung51303fb2021-05-09 19:09:13 -07008263 }
8264
8265 // offset needs to be a multiple of 4.
8266 if ((offset & 0x3) != 0) {
8267 skip |= LogError(device, "VUID-vkCmdPushConstants-offset-00368",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008268 "vkCmdPushConstants(): offset (%" PRIu32 ") must be a multiple of 4.", offset);
sfricke-samsung51303fb2021-05-09 19:09:13 -07008269 }
8270 return skip;
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06008271}
ziga-lunargb1dd8a22021-07-15 17:47:19 +02008272
8273bool StatelessValidation::manual_PreCallValidateMergePipelineCaches(VkDevice device, VkPipelineCache dstCache,
8274 uint32_t srcCacheCount,
8275 const VkPipelineCache *pSrcCaches) const {
8276 bool skip = false;
8277 if (pSrcCaches) {
8278 for (uint32_t index0 = 0; index0 < srcCacheCount; ++index0) {
8279 if (pSrcCaches[index0] == dstCache) {
8280 skip |= LogError(instance, "VUID-vkMergePipelineCaches-dstCache-00770",
8281 "vkMergePipelineCaches(): dstCache %s is in pSrcCaches list.",
8282 report_data->FormatHandle(dstCache).c_str());
8283 break;
8284 }
8285 }
8286 }
8287 return skip;
8288}
Nathaniel Cesario298d3cb2021-08-03 13:49:02 -06008289
8290bool StatelessValidation::manual_PreCallValidateCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image,
8291 VkImageLayout imageLayout, const VkClearColorValue *pColor,
8292 uint32_t rangeCount,
8293 const VkImageSubresourceRange *pRanges) const {
8294 bool skip = false;
8295 if (!pColor) {
8296 skip |=
8297 LogError(commandBuffer, "VUID-vkCmdClearColorImage-pColor-04961", "vkCmdClearColorImage(): pColor must not be null");
8298 }
8299 return skip;
8300}
8301
8302bool StatelessValidation::ValidateCmdBeginRenderPass(const char *const func_name,
8303 const VkRenderPassBeginInfo *const rp_begin) const {
8304 bool skip = false;
8305 if ((rp_begin->clearValueCount != 0) && !rp_begin->pClearValues) {
8306 skip |= LogError(rp_begin->renderPass, "VUID-VkRenderPassBeginInfo-clearValueCount-04962",
8307 "%s: VkRenderPassBeginInfo::clearValueCount != 0 (%" PRIu32
ziga-lunarg47109fb2021-09-03 18:41:12 +02008308 "), but VkRenderPassBeginInfo::pClearValues is null.",
Nathaniel Cesario298d3cb2021-08-03 13:49:02 -06008309 func_name, rp_begin->clearValueCount);
8310 }
8311 return skip;
8312}
8313
8314bool StatelessValidation::manual_PreCallValidateCmdBeginRenderPass(VkCommandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin,
8315 VkSubpassContents) const {
8316 bool skip = ValidateCmdBeginRenderPass("vkCmdBeginRenderPass", pRenderPassBegin);
8317 return skip;
8318}
8319
8320bool StatelessValidation::manual_PreCallValidateCmdBeginRenderPass2KHR(VkCommandBuffer,
8321 const VkRenderPassBeginInfo *pRenderPassBegin,
8322 const VkSubpassBeginInfo *) const {
8323 bool skip = ValidateCmdBeginRenderPass("vkCmdBeginRenderPass2KHR", pRenderPassBegin);
8324 return skip;
8325}
8326
8327bool StatelessValidation::manual_PreCallValidateCmdBeginRenderPass2(VkCommandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin,
8328 const VkSubpassBeginInfo *) const {
8329 bool skip = ValidateCmdBeginRenderPass("vkCmdBeginRenderPass2", pRenderPassBegin);
8330 return skip;
8331}
ziga-lunargc7bb56a2021-08-10 09:28:52 +02008332
8333bool StatelessValidation::manual_PreCallValidateCmdSetDiscardRectangleEXT(VkCommandBuffer commandBuffer,
8334 uint32_t firstDiscardRectangle,
8335 uint32_t discardRectangleCount,
8336 const VkRect2D *pDiscardRectangles) const {
8337 bool skip = false;
8338
8339 if (pDiscardRectangles) {
8340 for (uint32_t i = 0; i < discardRectangleCount; ++i) {
8341 const int64_t x_sum =
8342 static_cast<int64_t>(pDiscardRectangles[i].offset.x) + static_cast<int64_t>(pDiscardRectangles[i].extent.width);
8343 if (x_sum > std::numeric_limits<int32_t>::max()) {
8344 skip |= LogError(device, "VUID-vkCmdSetDiscardRectangleEXT-offset-00588",
8345 "vkCmdSetDiscardRectangleEXT(): offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
8346 ") of pDiscardRectangles[%" PRIu32 "] will overflow int32_t.",
8347 pDiscardRectangles[i].offset.x, pDiscardRectangles[i].extent.width, x_sum, i);
8348 }
8349
8350 const int64_t y_sum =
8351 static_cast<int64_t>(pDiscardRectangles[i].offset.y) + static_cast<int64_t>(pDiscardRectangles[i].extent.height);
8352 if (y_sum > std::numeric_limits<int32_t>::max()) {
8353 skip |= LogError(device, "VUID-vkCmdSetDiscardRectangleEXT-offset-00589",
8354 "vkCmdSetDiscardRectangleEXT(): offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
8355 ") of pDiscardRectangles[%" PRIu32 "] will overflow int32_t.",
8356 pDiscardRectangles[i].offset.y, pDiscardRectangles[i].extent.height, y_sum, i);
8357 }
8358 }
8359 }
8360
8361 return skip;
8362}
ziga-lunarg3c37dfb2021-08-24 12:51:07 +02008363
8364bool StatelessValidation::manual_PreCallValidateGetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery,
8365 uint32_t queryCount, size_t dataSize, void *pData,
8366 VkDeviceSize stride, VkQueryResultFlags flags) const {
8367 bool skip = false;
8368
8369 if ((flags & VK_QUERY_RESULT_WITH_STATUS_BIT_KHR) && (flags & VK_QUERY_RESULT_WITH_AVAILABILITY_BIT)) {
8370 skip |= LogError(device, "VUID-vkGetQueryPoolResults-flags-04811",
8371 "vkGetQueryPoolResults(): flags include both VK_QUERY_RESULT_WITH_STATUS_BIT_KHR bit and VK_QUERY_RESULT_WITH_AVAILABILITY_BIT bit.");
8372 }
8373
8374 return skip;
8375}
ziga-lunargcf340c42021-08-19 00:13:38 +02008376
8377bool StatelessValidation::manual_PreCallValidateCmdBeginConditionalRenderingEXT(
8378 VkCommandBuffer commandBuffer, const VkConditionalRenderingBeginInfoEXT* pConditionalRenderingBegin) const {
8379 bool skip = false;
8380
8381 if ((pConditionalRenderingBegin->offset & 3) != 0) {
8382 skip |= LogError(commandBuffer, "VUID-VkConditionalRenderingBeginInfoEXT-offset-01984",
8383 "vkCmdBeginConditionalRenderingEXT(): pConditionalRenderingBegin->offset (%" PRIu64
8384 ") is not a multiple of 4.",
8385 pConditionalRenderingBegin->offset);
8386 }
8387
8388 return skip;
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06008389}
Mike Schuchardt05b028d2022-01-05 14:15:00 -08008390
8391bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfaceFormatsKHR(VkPhysicalDevice physicalDevice,
8392 VkSurfaceKHR surface,
8393 uint32_t *pSurfaceFormatCount,
8394 VkSurfaceFormatKHR *pSurfaceFormats) const {
8395 bool skip = false;
8396 if (surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8397 skip |= LogError(
8398 physicalDevice, "VUID-vkGetPhysicalDeviceSurfaceFormatsKHR-surface-06524",
8399 "vkGetPhysicalDeviceSurfaceFormatsKHR(): surface is VK_NULL_HANDLE and VK_GOOGLE_surfaceless_query is not enabled.");
8400 }
8401 return skip;
8402}
8403
8404bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfacePresentModesKHR(VkPhysicalDevice physicalDevice,
8405 VkSurfaceKHR surface,
8406 uint32_t *pPresentModeCount,
8407 VkPresentModeKHR *pPresentModes) const {
8408 bool skip = false;
8409 if (surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8410 skip |= LogError(
8411 physicalDevice, "VUID-vkGetPhysicalDeviceSurfacePresentModesKHR-surface-06524",
8412 "vkGetPhysicalDeviceSurfacePresentModesKHR: surface is VK_NULL_HANDLE and VK_GOOGLE_surfaceless_query is not enabled.");
8413 }
8414 return skip;
8415}
8416
8417bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfaceCapabilities2KHR(
8418 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
8419 VkSurfaceCapabilities2KHR *pSurfaceCapabilities) const {
8420 bool skip = false;
8421 if (pSurfaceInfo && pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8422 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceSurfaceCapabilities2KHR-pSurfaceInfo-06520",
8423 "vkGetPhysicalDeviceSurfaceCapabilities2KHR: pSurfaceInfo->surface is VK_NULL_HANDLE and "
8424 "VK_GOOGLE_surfaceless_query is not enabled.");
8425 }
8426 return skip;
8427}
8428
8429bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfaceFormats2KHR(
8430 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo, uint32_t *pSurfaceFormatCount,
8431 VkSurfaceFormat2KHR *pSurfaceFormats) const {
8432 bool skip = false;
8433 if (pSurfaceInfo && pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8434 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceSurfaceFormats2KHR-pSurfaceInfo-06521",
8435 "vkGetPhysicalDeviceSurfaceFormats2KHR: pSurfaceInfo->surface is VK_NULL_HANDLE and "
8436 "VK_GOOGLE_surfaceless_query is not enabled.");
8437 }
8438 return skip;
8439}
8440
8441#ifdef VK_USE_PLATFORM_WIN32_KHR
8442bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfacePresentModes2EXT(
8443 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo, uint32_t *pPresentModeCount,
8444 VkPresentModeKHR *pPresentModes) const {
8445 bool skip = false;
8446 if (pSurfaceInfo && pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8447 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceSurfacePresentModes2EXT-pSurfaceInfo-06521",
8448 "vkGetPhysicalDeviceSurfacePresentModes2EXT: pSurfaceInfo->surface is VK_NULL_HANDLE and "
8449 "VK_GOOGLE_surfaceless_query is not enabled.");
8450 }
8451 return skip;
8452}
ziga-lunarg50f8e6b2021-12-18 20:24:35 +01008453
Mike Schuchardt05b028d2022-01-05 14:15:00 -08008454#endif // VK_USE_PLATFORM_WIN32_KHR
ziga-lunarg50f8e6b2021-12-18 20:24:35 +01008455
8456bool StatelessValidation::ValidateDeviceImageMemoryRequirements(VkDevice device, const VkDeviceImageMemoryRequirementsKHR *pInfo,
8457 const char *func_name) const {
8458 bool skip = false;
8459
8460 if (pInfo && pInfo->pCreateInfo) {
8461 const auto *image_swapchain_create_info = LvlFindInChain<VkImageSwapchainCreateInfoKHR>(pInfo->pCreateInfo);
8462 if (image_swapchain_create_info) {
8463 skip |= LogError(device, "VUID-VkDeviceImageMemoryRequirementsKHR-pCreateInfo-06416",
8464 "%s(): pInfo->pCreateInfo->pNext chain contains VkImageSwapchainCreateInfoKHR.", func_name);
8465 }
8466 }
8467
8468 return skip;
8469}
8470
8471bool StatelessValidation::manual_PreCallValidateGetDeviceImageMemoryRequirementsKHR(
8472 VkDevice device, const VkDeviceImageMemoryRequirements *pInfo, VkMemoryRequirements2 *pMemoryRequirements) const {
8473 bool skip = false;
8474
8475 skip |= ValidateDeviceImageMemoryRequirements(device, pInfo, "vkGetDeviceImageMemoryRequirementsKHR");
8476
8477 return skip;
8478}
8479
8480bool StatelessValidation::manual_PreCallValidateGetDeviceImageSparseMemoryRequirementsKHR(
8481 VkDevice device, const VkDeviceImageMemoryRequirements *pInfo, uint32_t *pSparseMemoryRequirementCount,
8482 VkSparseImageMemoryRequirements2 *pSparseMemoryRequirements) const {
8483 bool skip = false;
8484
8485 skip |= ValidateDeviceImageMemoryRequirements(device, pInfo, "vkGetDeviceImageSparseMemoryRequirementsKHR");
8486
8487 return skip;
8488}