blob: 3faf94eaa717131e1d613c2808787442bf37a2fd [file] [log] [blame]
aitor-lunargd5301592022-01-05 22:38:16 +01001/* Copyright (c) 2015-2022 The Khronos Group Inc.
2 * Copyright (c) 2015-2022 Valve Corporation
3 * Copyright (c) 2015-2022 LunarG, Inc.
4 * Copyright (C) 2015-2022 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
sfricke-samsung2e827212021-09-28 07:52:08 -070027#include "core_validation_error_enums.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010028
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070029static const int kMaxParamCheckerStringLength = 256;
Mark Lobodzinskid4950072017-08-01 13:02:20 -060030
John Zulauf71968502017-10-26 13:51:15 -060031template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070032inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060033 // Using only < for generality and || for early abort
34 return !((value < min) || (max < value));
35}
36
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -060037ReadLockGuard StatelessValidation::ReadLock() { return ReadLockGuard(validation_object_mutex, std::defer_lock); }
38WriteLockGuard StatelessValidation::WriteLock() { return WriteLockGuard(validation_object_mutex, std::defer_lock); }
Mark Lobodzinski21b91fe2020-12-03 15:44:24 -070039
Jeremy Gebbencbf22862021-03-03 12:01:22 -070040static layer_data::unordered_map<VkCommandBuffer, VkCommandPool> secondary_cb_map{};
Tony-LunarG3c287f62020-12-17 12:39:49 -070041static ReadWriteLock secondary_cb_map_mutex;
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -060042static ReadLockGuard CBReadLock() { return ReadLockGuard(secondary_cb_map_mutex); }
43static WriteLockGuard CBWriteLock() { return WriteLockGuard(secondary_cb_map_mutex); }
Tony-LunarG3c287f62020-12-17 12:39:49 -070044
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070045bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050046 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 bool skip = false;
48
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070049 VkStringErrorFlags result = vk_string_validate(kMaxParamCheckerStringLength, validateString);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050
51 if (result == VK_STRING_ERROR_NONE) {
52 return skip;
53 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070054 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070055 kMaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060056 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070057 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
58 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060059 }
60 return skip;
61}
62
Jeff Bolz46c0ea02019-10-09 13:06:29 -050063bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060064 bool skip = false;
65 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
66 if (api_version_nopatch != effective_api_version) {
sfricke-samsung6aec21b2020-11-01 07:49:43 -080067 if ((api_version_nopatch < VK_API_VERSION_1_0) && (api_version != 0)) {
68 skip |= LogError(instance, "VUID-VkApplicationInfo-apiVersion-04010",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070069 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
70 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
71 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060072 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070073 skip |= LogWarning(instance, kVUIDUndefined,
74 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
75 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
76 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060077 }
78 }
79 return skip;
80}
81
Jeff Bolz46c0ea02019-10-09 13:06:29 -050082bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060083 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060084 // Create and use a local instance extension object, as an actual instance has not been created yet
85 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
86 InstanceExtensions local_instance_extensions;
87 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
88
John Zulauf620755c2018-04-16 11:00:43 -060089 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060090 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
91 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060092 }
93
94 return skip;
95}
96
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060097bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
Mike Schuchardtc57de4a2021-07-20 17:26:32 -070098 if (instance_extensions.vk_khr_get_physical_device_properties2) {
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060099 // Struct is legal IF it's supported
100 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
101 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
102 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
103 if (enum_iter != dev_exts_enumerated->second.cend()) {
104 return true;
105 }
106 }
107 return false;
108}
109
Tony-LunarG866843d2020-05-13 11:22:42 -0600110bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
111 const VkValidationFeaturesEXT *validation_features) const {
112 bool skip = false;
113 bool debug_printf = false;
114 bool gpu_assisted = false;
115 bool reserve_slot = false;
116 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
117 switch (validation_features->pEnabledValidationFeatures[i]) {
118 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
119 gpu_assisted = true;
120 break;
121
122 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
123 debug_printf = true;
124 break;
125
126 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
127 reserve_slot = true;
128 break;
129
130 default:
131 break;
132 }
133 }
134 if (reserve_slot && !gpu_assisted) {
135 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
136 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
137 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
138 }
139 if (gpu_assisted && debug_printf) {
140 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
141 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
142 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
143 }
144
145 return skip;
146}
147
John Zulauf620755c2018-04-16 11:00:43 -0600148template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700149ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
150 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600151 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700152 ExtEnabled state =
153 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600154 return state;
155}
156
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700157bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500158 const VkAllocationCallbacks *pAllocator,
159 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700160 bool skip = false;
161 // Note: From the spec--
162 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
163 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
164 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700165 ? pCreateInfo->pApplicationInfo->apiVersion
166 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700167 skip |= validate_api_version(local_api_version, api_version);
168 skip |= validate_instance_extensions(pCreateInfo);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700169 const auto *validation_features = LvlFindInChain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
Tony-LunarG866843d2020-05-13 11:22:42 -0600170 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
171
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700172 return skip;
173}
174
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700175void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700176 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
177 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700178 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
179 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700180 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700181 this->instance_extensions = instance_data->instance_extensions;
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700182}
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600183
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700184void StatelessValidation::CommonPostCallRecordEnumeratePhysicalDevice(const VkPhysicalDevice *phys_devices, const int count) {
185 // Assume phys_devices is valid
186 assert(phys_devices);
187 for (int i = 0; i < count; ++i) {
188 const auto &phys_device = phys_devices[i];
189 if (0 == physical_device_properties_map.count(phys_device)) {
190 auto phys_dev_props = new VkPhysicalDeviceProperties;
191 DispatchGetPhysicalDeviceProperties(phys_device, phys_dev_props);
192 physical_device_properties_map[phys_device] = phys_dev_props;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600193
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700194 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
195 uint32_t ext_count = 0;
Jeremy Gebbencbf22862021-03-03 12:01:22 -0700196 layer_data::unordered_set<std::string> dev_exts_enumerated{};
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700197 std::vector<VkExtensionProperties> ext_props{};
198 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, nullptr);
199 ext_props.resize(ext_count);
200 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, ext_props.data());
201 for (uint32_t j = 0; j < ext_count; j++) {
202 dev_exts_enumerated.insert(ext_props[j].extensionName);
203 }
204 device_extensions_enumerated[phys_device] = std::move(dev_exts_enumerated);
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600205 }
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700206 }
207}
208
209void StatelessValidation::PostCallRecordEnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount,
210 VkPhysicalDevice *pPhysicalDevices, VkResult result) {
211 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
212 return;
213 }
214
215 if (pPhysicalDeviceCount && pPhysicalDevices) {
216 CommonPostCallRecordEnumeratePhysicalDevice(pPhysicalDevices, *pPhysicalDeviceCount);
217 }
218}
219
220void StatelessValidation::PostCallRecordEnumeratePhysicalDeviceGroups(
221 VkInstance instance, uint32_t *pPhysicalDeviceGroupCount, VkPhysicalDeviceGroupProperties *pPhysicalDeviceGroupProperties,
222 VkResult result) {
223 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
224 return;
225 }
226
227 if (pPhysicalDeviceGroupCount && pPhysicalDeviceGroupProperties) {
228 for (uint32_t i = 0; i < *pPhysicalDeviceGroupCount; i++) {
229 const auto &group = pPhysicalDeviceGroupProperties[i];
230 CommonPostCallRecordEnumeratePhysicalDevice(group.physicalDevices, group.physicalDeviceCount);
231 }
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600232 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700233}
234
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600235void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
236 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
237 delete (it->second);
238 it = physical_device_properties_map.erase(it);
239 }
240};
241
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700242void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700243 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700244 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700245 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700246 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
247 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700248
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700249 // Parmeter validation also uses extension data
250 stateless_validation->device_extensions = this->device_extensions;
251
252 VkPhysicalDeviceProperties device_properties = {};
253 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600254 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700255 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
256
sfricke-samsung45996a42021-09-16 13:45:27 -0700257 if (IsExtEnabled(device_extensions.vk_nv_shading_rate_image)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700258 // Get the needed shading rate image limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700259 auto shading_rate_image_props = LvlInitStruct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
260 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600261 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700262 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
263 }
264
sfricke-samsung45996a42021-09-16 13:45:27 -0700265 if (IsExtEnabled(device_extensions.vk_nv_mesh_shader)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700266 // Get the needed mesh shader limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700267 auto mesh_shader_props = LvlInitStruct<VkPhysicalDeviceMeshShaderPropertiesNV>();
268 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600269 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700270 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
271 }
272
sfricke-samsung45996a42021-09-16 13:45:27 -0700273 if (IsExtEnabled(device_extensions.vk_nv_ray_tracing)) {
Jason Macnak5c954952019-07-09 15:46:12 -0700274 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700275 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPropertiesNV>();
276 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jason Macnak5c954952019-07-09 15:46:12 -0700277 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500278 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
279 }
280
sfricke-samsung45996a42021-09-16 13:45:27 -0700281 if (IsExtEnabled(device_extensions.vk_khr_ray_tracing_pipeline)) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500282 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700283 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPipelinePropertiesKHR>();
284 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500285 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
286 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700287 }
288
sfricke-samsung45996a42021-09-16 13:45:27 -0700289 if (IsExtEnabled(device_extensions.vk_khr_acceleration_structure)) {
sourav parmarcd5fb182020-07-17 12:58:44 -0700290 // Get the needed ray tracing acc structure limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700291 auto acc_structure_props = LvlInitStruct<VkPhysicalDeviceAccelerationStructurePropertiesKHR>();
292 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&acc_structure_props);
sourav parmarcd5fb182020-07-17 12:58:44 -0700293 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
294 phys_dev_ext_props.acc_structure_props = acc_structure_props;
295 }
296
sfricke-samsung45996a42021-09-16 13:45:27 -0700297 if (IsExtEnabled(device_extensions.vk_ext_transform_feedback)) {
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700298 // Get the needed transform feedback limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700299 auto transform_feedback_props = LvlInitStruct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
300 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&transform_feedback_props);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700301 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
302 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
303 }
304
sfricke-samsung45996a42021-09-16 13:45:27 -0700305 if (IsExtEnabled(device_extensions.vk_ext_vertex_attribute_divisor)) {
Piers Daniellcb6d8032021-04-19 18:51:26 -0600306 // Get the needed vertex attribute divisor limits
307 auto vertex_attribute_divisor_props = LvlInitStruct<VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT>();
308 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&vertex_attribute_divisor_props);
309 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
310 phys_dev_ext_props.vertex_attribute_divisor_props = vertex_attribute_divisor_props;
311 }
312
sfricke-samsung45996a42021-09-16 13:45:27 -0700313 if (IsExtEnabled(device_extensions.vk_ext_blend_operation_advanced)) {
Piers Daniella7f93b62021-11-20 12:32:04 -0700314 // Get the needed blend operation advanced properties
ziga-lunarga283d022021-08-04 18:35:23 +0200315 auto blend_operation_advanced_props = LvlInitStruct<VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT>();
316 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&blend_operation_advanced_props);
317 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
318 phys_dev_ext_props.blend_operation_advanced_props = blend_operation_advanced_props;
319 }
320
Piers Daniella7f93b62021-11-20 12:32:04 -0700321 if (IsExtEnabled(device_extensions.vk_khr_maintenance4)) {
322 // Get the needed maintenance4 properties
323 auto maintance4_props = LvlInitStruct<VkPhysicalDeviceMaintenance4PropertiesKHR>();
324 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&maintance4_props);
325 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
326 phys_dev_ext_props.maintenance4_props = maintance4_props;
327 }
328
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800329 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
330
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700331 // Save app-enabled features in this device's validation object
332 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700333 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200334 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
335 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
336 if (features2) {
337 tmp_features2_state.features = features2->features;
338 } else if (pCreateInfo->pEnabledFeatures) {
339 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700340 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200341 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700342 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200343 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700344 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200345 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700346}
347
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700348bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500349 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600350 bool skip = false;
351
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200352 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
353 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
354 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600355 }
356
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700357 // If this device supports VK_KHR_portability_subset, it must be enabled
358 const std::string portability_extension_name("VK_KHR_portability_subset");
359 const auto &dev_extensions = device_extensions_enumerated.at(physicalDevice);
360 const bool portability_supported = dev_extensions.count(portability_extension_name) != 0;
361 bool portability_requested = false;
362
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200363 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
364 skip |=
365 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
366 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
367 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
368 pCreateInfo->ppEnabledExtensionNames[i]);
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700369 if (portability_extension_name == pCreateInfo->ppEnabledExtensionNames[i]) {
370 portability_requested = true;
371 }
372 }
373
374 if (portability_supported && !portability_requested) {
375 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-pProperties-04451",
376 "vkCreateDevice: VK_KHR_portability_subset must be enabled because physical device %s supports it",
377 report_data->FormatHandle(physicalDevice).c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600378 }
379
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200380 {
aitor-lunargd5301592022-01-05 22:38:16 +0100381 bool maint1 = IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE_1_EXTENSION_NAME));
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700382 bool negative_viewport =
aitor-lunargd5301592022-01-05 22:38:16 +0100383 IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
384 if (negative_viewport) {
385 // Only need to check for VK_KHR_MAINTENANCE_1_EXTENSION_NAME if api version is 1.0, otherwise it's deprecated due to
386 // integration into api version 1.1
387 if (api_version >= VK_API_VERSION_1_1) {
388 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-01840",
389 "vkCreateDevice(): VkDeviceCreateInfo->ppEnabledExtensionNames must not include "
390 "VK_AMD_negative_viewport_height if api version is greater than or equal to 1.1.");
391 } else if (maint1) {
392 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
393 "vkCreateDevice(): VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include "
394 "VK_KHR_maintenance1 and VK_AMD_negative_viewport_height.");
395 }
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200396 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600397 }
398
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600399 {
ziga-lunarg9271a7c2021-07-19 16:37:06 +0200400 bool khr_bda =
401 IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
402 bool ext_bda =
403 IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600404 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700405 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
406 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
407 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600408 }
409 }
410
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600411 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
412 // Check for get_physical_device_properties2 struct
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700413 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -0600414 if (features2) {
Mike Schuchardt2df08912020-12-15 16:28:09 -0800415 // Cannot include VkPhysicalDeviceFeatures2 and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700416 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mike Schuchardt2df08912020-12-15 16:28:09 -0800417 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct when "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700418 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600419 }
420 }
421
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700422 auto features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500423 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700424 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500425 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
426 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
427 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
428 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700429 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(pCreateInfo->pNext);
sourav parmarcd5fb182020-07-17 12:58:44 -0700430 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplayMixed &&
431 !raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay) {
432 skip |= LogError(
433 device,
434 "VUID-VkPhysicalDeviceRayTracingPipelineFeaturesKHR-rayTracingPipelineShaderGroupHandleCaptureReplayMixed-03575",
435 "If rayTracingPipelineShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingPipelineShaderGroupHandleCaptureReplay "
436 "must also be VK_TRUE.");
sourav parmara24fb7b2020-05-26 10:50:04 -0700437 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700438 auto vertex_attribute_divisor_features = LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
sfricke-samsung45996a42021-09-16 13:45:27 -0700439 if (vertex_attribute_divisor_features && (!IsExtEnabled(device_extensions.vk_ext_vertex_attribute_divisor))) {
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600440 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
441 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
442 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600443 }
444
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700445 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700446 if (vulkan_11_features) {
447 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
448 while (current) {
449 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
450 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
451 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
452 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
453 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
454 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700455 skip |= LogError(
456 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700457 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
458 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
459 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
460 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
461 break;
462 }
463 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
464 }
sfricke-samsungebda6792021-01-16 08:57:52 -0800465
466 // Check features are enabled if matching extension is passed in as well
467 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
468 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
469 if ((0 == strncmp(extension, VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
470 (vulkan_11_features->shaderDrawParameters == VK_FALSE)) {
471 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800472 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-04476",
sfricke-samsungebda6792021-01-16 08:57:52 -0800473 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan11Features::shaderDrawParameters is not VK_TRUE.",
474 VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME);
475 }
476 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700477 }
478
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700479 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700480 if (vulkan_12_features) {
481 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
482 while (current) {
483 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
484 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
485 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
486 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
487 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
488 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
489 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
490 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
491 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
492 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
493 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
494 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
495 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700496 skip |= LogError(
497 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700498 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
499 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
500 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
501 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
502 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
503 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
504 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
505 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
506 break;
507 }
508 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
509 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700510 // Check features are enabled if matching extension is passed in as well
511 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
512 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
513 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
514 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
515 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800516 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02831",
sfricke-samsungabab4632020-05-04 06:51:46 -0700517 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
518 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
519 }
520 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
521 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
Mike Schuchardt9969d022021-12-20 15:51:55 -0800522 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02832",
sfricke-samsungabab4632020-05-04 06:51:46 -0700523 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
524 "is not VK_TRUE.",
525 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
526 }
527 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
528 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
529 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800530 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02833",
sfricke-samsungabab4632020-05-04 06:51:46 -0700531 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
532 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
533 }
534 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
535 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
536 skip |= LogError(
Mike Schuchardt9969d022021-12-20 15:51:55 -0800537 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02834",
sfricke-samsungabab4632020-05-04 06:51:46 -0700538 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
539 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
540 }
541 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
542 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
543 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
544 skip |=
Mike Schuchardt9969d022021-12-20 15:51:55 -0800545 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-02835",
sfricke-samsungabab4632020-05-04 06:51:46 -0700546 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
547 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
548 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
549 }
550 }
ziga-lunarg27f88fd2021-08-01 15:47:30 +0200551 if (vulkan_12_features->bufferDeviceAddress == VK_TRUE) {
552 if (IsExtEnabledByCreateinfo(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME))) {
553 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-pNext-04748",
554 "vkCreateDevice(): pNext chain includes VkPhysicalDeviceVulkan12Features with bufferDeviceAddress "
555 "set to VK_TRUE and ppEnabledExtensionNames contains VK_EXT_buffer_device_address");
556 }
557 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700558 }
559
Tony-LunarG273f32f2021-09-28 08:56:30 -0600560 const auto *vulkan_13_features = LvlFindInChain<VkPhysicalDeviceVulkan13Features>(pCreateInfo->pNext);
561 if (vulkan_13_features) {
562 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
563 while (current) {
564 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DYNAMIC_RENDERING_FEATURES ||
565 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGE_ROBUSTNESS_FEATURES ||
566 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_INLINE_UNIFORM_BLOCK_FEATURES ||
567 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MAINTENANCE_4_FEATURES ||
568 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PIPELINE_CREATION_CACHE_CONTROL_FEATURES ||
569 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PRIVATE_DATA_FEATURES ||
570 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DEMOTE_TO_HELPER_INVOCATION_FEATURES ||
571 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_INTEGER_DOT_PRODUCT_FEATURES ||
572 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_TERMINATE_INVOCATION_FEATURES ||
573 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SUBGROUP_SIZE_CONTROL_FEATURES ||
574 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SYNCHRONIZATION_2_FEATURES ||
575 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TEXTURE_COMPRESSION_ASTC_HDR_FEATURES ||
576 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_ZERO_INITIALIZE_WORKGROUP_MEMORY_FEATURES) {
577 skip |= LogError(
578 instance, "VUID-VkDeviceCreateInfo-pNext-06532",
579 "If the pNext chain includes a VkPhysicalDeviceVulkan13Features structure, then it must not include a "
580 "VkPhysicalDeviceDynamicRenderingFeatures, VkPhysicalDeviceImageRobustnessFeatures, "
581 "VkPhysicalDeviceInlineUniformBlockFeatures, VkPhysicalDeviceMaintenance4Features, "
582 "VkPhysicalDevicePipelineCreationCacheControlFeatures, VkPhysicalDevicePrivateDataFeatures, "
583 "VkPhysicalDeviceShaderDemoteToHelperInvocationFeatures, VkPhysicalDeviceShaderIntegerDotProductFeatures, "
584 "VkPhysicalDeviceShaderTerminateInvocationFeatures, VkPhysicalDeviceSubgroupSizeControlFeatures, "
585 "VkPhysicalDeviceSynchronization2Features, VkPhysicalDeviceTextureCompressionASTCHDRFeatures, or "
586 "VkPhysicalDeviceZeroInitializeWorkgroupMemoryFeatures structure");
587 break;
588 }
589 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
590 }
591 }
592
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600593 // Validate pCreateInfo->pQueueCreateInfos
594 if (pCreateInfo->pQueueCreateInfos) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600595
596 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700597 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
598 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600599 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700600 skip |=
601 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
602 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
603 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
604 "index value.",
605 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600606 }
607
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700608 if (queue_create_info.pQueuePriorities != nullptr) {
609 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
610 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600611 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700612 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
613 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
614 "] (=%f) is not between 0 and 1 (inclusive).",
615 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600616 }
617 }
618 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700619
620 // Need to know if protectedMemory feature is passed in preCall to creating the device
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700621 VkBool32 protected_memory = VK_FALSE;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700622 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700623 LvlFindInChain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700624 if (protected_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700625 protected_memory = protected_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700626 } else if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700627 protected_memory = vulkan_11_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700628 }
Mike Schuchardta9101d32021-11-12 12:24:08 -0800629 if (((queue_create_info.flags & VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) != 0) && (protected_memory == VK_FALSE)) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700630 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
Mike Schuchardta9101d32021-11-12 12:24:08 -0800631 "vkCreateDevice: pCreateInfo->flags contains VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
632 "protectedMemory feature being enabled as well.");
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700633 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600634 }
635 }
636
sfricke-samsung30a57412020-05-15 21:14:54 -0700637 // feature dependencies for VK_KHR_variable_pointers
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700638 const auto *variable_pointers_features = LvlFindInChain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700639 VkBool32 variable_pointers = VK_FALSE;
640 VkBool32 variable_pointers_storage_buffer = VK_FALSE;
sfricke-samsung30a57412020-05-15 21:14:54 -0700641 if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700642 variable_pointers = vulkan_11_features->variablePointers;
643 variable_pointers_storage_buffer = vulkan_11_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700644 } else if (variable_pointers_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700645 variable_pointers = variable_pointers_features->variablePointers;
646 variable_pointers_storage_buffer = variable_pointers_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700647 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700648 if ((variable_pointers == VK_TRUE) && (variable_pointers_storage_buffer == VK_FALSE)) {
sfricke-samsung30a57412020-05-15 21:14:54 -0700649 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
650 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
651 }
652
sfricke-samsungfd76c342020-05-29 23:13:43 -0700653 // feature dependencies for VK_KHR_multiview
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700654 const auto *multiview_features = LvlFindInChain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
sfricke-samsungfd76c342020-05-29 23:13:43 -0700655 VkBool32 multiview = VK_FALSE;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700656 VkBool32 multiview_geometry_shader = VK_FALSE;
657 VkBool32 multiview_tessellation_shader = VK_FALSE;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700658 if (vulkan_11_features) {
659 multiview = vulkan_11_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700660 multiview_geometry_shader = vulkan_11_features->multiviewGeometryShader;
661 multiview_tessellation_shader = vulkan_11_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700662 } else if (multiview_features) {
663 multiview = multiview_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700664 multiview_geometry_shader = multiview_features->multiviewGeometryShader;
665 multiview_tessellation_shader = multiview_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700666 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700667 if ((multiview == VK_FALSE) && (multiview_geometry_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700668 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
669 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
670 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700671 if ((multiview == VK_FALSE) && (multiview_tessellation_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700672 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
673 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
674 }
675
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600676 return skip;
677}
678
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500679bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700680 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700681 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
682 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
683 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600684 }
685
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700686 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600687}
688
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700689bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500690 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100691 bool skip = false;
692
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600693 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700694 skip |=
695 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600696
697 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
698 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
699 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
700 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700701 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
702 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
703 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600704 }
705
706 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
707 // queueFamilyIndexCount uint32_t values
708 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700709 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
710 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
711 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
712 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600713 }
714 }
715
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700716 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
717 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
718 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
719 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
720 }
721
722 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
723 skip |=
724 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
725 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
726 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
727 }
728
729 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
730 skip |=
731 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
732 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
733 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
734 }
735
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600736 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
737 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
738 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
739 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700740 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
741 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
742 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600743 }
Piers Daniella7f93b62021-11-20 12:32:04 -0700744
745 const auto *maintenance4_features = LvlFindInChain<VkPhysicalDeviceMaintenance4FeaturesKHR>(device_createinfo_pnext);
746 if (maintenance4_features && maintenance4_features->maintenance4) {
747 if (pCreateInfo->size > phys_dev_ext_props.maintenance4_props.maxBufferSize) {
748 skip |= LogError(device, "VUID-VkBufferCreateInfo-size-06409",
749 "vkCreateBuffer: pCreateInfo->size is larger than the maximum allowed buffer size "
750 "VkPhysicalDeviceMaintenance4Properties.maxBufferSize");
751 }
752 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600753 }
754
755 return skip;
756}
757
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700758bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500759 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600760 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600761
762 if (pCreateInfo != nullptr) {
sfricke-samsung61a57c02021-01-10 21:35:12 -0800763 const VkFormat image_format = pCreateInfo->format;
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700764 const VkImageCreateFlags image_flags = pCreateInfo->flags;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600765 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
766 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
767 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
768 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700769 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
770 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
771 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600772 }
773
774 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
775 // queueFamilyIndexCount uint32_t values
776 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700777 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
778 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
779 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
780 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600781 }
782 }
783
Dave Houlton413a6782018-05-22 13:01:54 -0600784 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700785 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600786 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700787 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600788 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700789 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600790
Dave Houlton413a6782018-05-22 13:01:54 -0600791 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700792 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600793 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700794 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600795
Dave Houlton130c0212018-01-29 13:39:56 -0700796 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700797 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
798 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700799 skip |= LogError(
800 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600801 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
802 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700803 }
804
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600805 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100806 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
807 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700808 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
809 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
810 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600811 }
812
813 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700814 if (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
Petr Kraus3f433212018-03-13 12:31:27 +0100815 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700816 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
817 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
818 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
819 ") are not equal.",
820 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100821 }
822
823 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700824 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
825 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
826 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
827 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100828 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600829 }
830
831 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700832 skip |= LogError(
833 device, "VUID-VkImageCreateInfo-imageType-00957",
834 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600835 }
836 }
837
Dave Houlton130c0212018-01-29 13:39:56 -0700838 // 3D image may have only 1 layer
839 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700840 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
841 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700842 }
843
Dave Houlton130c0212018-01-29 13:39:56 -0700844 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
845 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
846 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
847 // At least one of the legal attachment bits must be set
848 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700849 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
850 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700851 }
852 // No flags other than the legal attachment bits may be set
853 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
854 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700855 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
856 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700857 }
858 }
859
Jeff Bolzef40fec2018-09-01 22:04:34 -0500860 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700861 uint32_t max_dim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500862 // Max mip levels is different for corner-sampled images vs normal images.
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700863 uint32_t max_mip_levels = (image_flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700864 ? static_cast<uint32_t>(ceil(log2(max_dim)))
865 : static_cast<uint32_t>(floor(log2(max_dim)) + 1);
866 if (max_dim > 0 && pCreateInfo->mipLevels > max_mip_levels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600867 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700868 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
869 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
870 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600871 }
872
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700873 if ((image_flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700874 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
875 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
876 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600877 }
878
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700879 if ((image_flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700880 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
881 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
882 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100883 }
884
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700885 if ((image_flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700886 skip |= LogError(
887 device, "VUID-VkImageCreateInfo-flags-01924",
888 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
889 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
890 }
891
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600892 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
893 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700894 if (((image_flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
895 ((image_flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700896 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
897 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
898 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600899 }
900
901 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700902 if ((image_flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600903 // Linear tiling is unsupported
904 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700905 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700906 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
907 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600908 }
909
910 // Sparse 1D image isn't valid
911 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700912 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
913 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600914 }
915
916 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700917 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700918 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
919 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
920 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600921 }
922
923 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700924 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700925 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
926 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
927 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600928 }
929
930 // Multi-sample 2D image when device doesn't support it
931 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700932 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600933 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700934 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
935 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
936 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700937 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600938 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700939 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
940 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
941 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700942 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600943 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700944 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
945 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
946 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700947 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600948 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700949 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
950 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
951 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600952 }
953 }
954 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500955
Jeff Bolz9af91c52018-09-01 21:53:57 -0500956 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
957 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700958 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
959 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
960 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500961 }
962 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700963 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
964 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
965 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500966 }
967 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700968 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
969 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
970 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500971 }
972 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500973
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700974 if (image_flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600975 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700976 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
977 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
978 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500979 }
980
sfricke-samsungf60b6c82021-04-05 22:59:20 -0700981 if ((image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(image_format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700982 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
983 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800984 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format (%s) must not be a "
985 "depth/stencil format.",
986 string_VkFormat(image_format));
Jeff Bolzef40fec2018-09-01 22:04:34 -0500987 }
988
Dave Houlton142c4cb2018-10-17 15:04:41 -0600989 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700990 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
991 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
992 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
993 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500994 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600995 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700996 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
997 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
998 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
999 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -05001000 }
1001 }
Andrew Fobel3abeb992020-01-20 16:33:22 -05001002
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001003 if (((image_flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
sfricke-samsung61a57c02021-01-10 21:35:12 -08001004 (FormatHasDepth(image_format) == false)) {
sfricke-samsung8f658d42020-05-03 20:12:24 -07001005 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
1006 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
sfricke-samsung61a57c02021-01-10 21:35:12 -08001007 "format (%s) must be a depth or depth/stencil format.",
1008 string_VkFormat(image_format));
sfricke-samsung8f658d42020-05-03 20:12:24 -07001009 }
1010
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001011 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pCreateInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05001012 if (image_stencil_struct != nullptr) {
1013 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
1014 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1015 // No flags other than the legal attachment bits may be set
1016 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1017 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001018 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
1019 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
1020 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
1021 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -05001022 }
1023 }
1024
sfricke-samsung61a57c02021-01-10 21:35:12 -08001025 if (FormatIsDepthOrStencil(image_format)) {
Andrew Fobel3abeb992020-01-20 16:33:22 -05001026 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
1027 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001028 skip |=
1029 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
1030 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
1031 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width (%" PRIu32
1032 ") exceeds device "
1033 "maxFramebufferWidth (%" PRIu32 ")",
1034 pCreateInfo->extent.width, device_limits.maxFramebufferWidth);
Andrew Fobel3abeb992020-01-20 16:33:22 -05001035 }
1036
1037 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001038 skip |=
1039 LogError(device, "VUID-VkImageCreateInfo-format-02537",
1040 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
1041 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height (%" PRIu32
1042 ") exceeds device "
1043 "maxFramebufferHeight (%" PRIu32 ")",
1044 pCreateInfo->extent.height, device_limits.maxFramebufferHeight);
Andrew Fobel3abeb992020-01-20 16:33:22 -05001045 }
1046 }
1047
1048 if (!physical_device_features.shaderStorageImageMultisample &&
1049 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1050 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1051 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001052 LogError(device, "VUID-VkImageCreateInfo-format-02538",
1053 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
1054 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
1055 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -05001056 }
1057
1058 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
1059 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001060 skip |= LogError(
1061 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001062 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
1063 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1064 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
1065 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
1066 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001067 skip |= LogError(
1068 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001069 "vkCreateImage(): Depth-stencil image in which usage does not include "
1070 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
1071 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1072 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
1073 }
1074
1075 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
1076 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001077 skip |= LogError(
1078 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001079 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1080 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1081 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1082 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
1083 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001084 skip |= LogError(
1085 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001086 "vkCreateImage(): Depth-stencil image in which usage does not include "
1087 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1088 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1089 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1090 }
1091 }
1092 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -07001093
1094 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1095 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1096 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
1097 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
1098 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
1099 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001100
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001101 std::vector<uint64_t> image_create_drm_format_modifiers;
sfricke-samsung45996a42021-09-16 13:45:27 -07001102 if (IsExtEnabled(device_extensions.vk_ext_image_drm_format_modifier)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001103 const auto drm_format_mod_list = LvlFindInChain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
1104 const auto drm_format_mod_explict = LvlFindInChain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001105 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1106 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
1107 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
1108 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
1109 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
1110 "either VkImageDrmFormatModifierListCreateInfoEXT or "
1111 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
Martin Freebody0ec2c7a2021-03-03 16:48:00 +00001112 } else if (drm_format_mod_explict != nullptr) {
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001113 image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
1114 } else if (drm_format_mod_list != nullptr) {
1115 for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {
1116 image_create_drm_format_modifiers.push_back(*drm_format_mod_list->pDrmFormatModifiers);
1117 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001118 }
1119 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
1120 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
1121 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
1122 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
1123 "in the pNext chain");
1124 }
1125 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001126
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001127 static const uint64_t drm_format_mod_linear = 0;
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001128 bool image_create_maybe_linear = false;
1129 if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) {
1130 image_create_maybe_linear = true;
1131 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) {
1132 image_create_maybe_linear = false;
1133 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1134 image_create_maybe_linear =
1135 (std::find(image_create_drm_format_modifiers.begin(), image_create_drm_format_modifiers.end(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001136 drm_format_mod_linear) != image_create_drm_format_modifiers.end());
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001137 }
1138
1139 // If multi-sample, validate type, usage, tiling and mip levels.
1140 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001141 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001142 (pCreateInfo->mipLevels != 1) || image_create_maybe_linear)) {
1143 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
1144 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
1145 }
1146
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001147 if ((image_flags & VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT) &&
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001148 ((pCreateInfo->mipLevels != 1) || (pCreateInfo->arrayLayers != 1) || (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) ||
1149 image_create_maybe_linear)) {
1150 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02259",
1151 "vkCreateImage(): Multi-device image with incompatible type, usage, tiling, or mips.");
1152 }
1153
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001154 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
1155 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1156 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
1157 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1158 "imageType must be VK_IMAGE_TYPE_2D.");
1159 }
1160 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1161 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
1162 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1163 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1164 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001165 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001166 if (image_flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001167 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1168 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
1169 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1170 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1171 }
1172 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1173 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
1174 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1175 "imageType must be VK_IMAGE_TYPE_2D.");
1176 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001177 if (image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001178 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1179 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1180 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1181 }
1182 if (pCreateInfo->mipLevels != 1) {
1183 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001184 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%" PRIu32
1185 ") must be 1.",
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001186 pCreateInfo->mipLevels);
1187 }
1188 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001189
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001190 const auto swapchain_create_info = LvlFindInChain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001191 if (swapchain_create_info != nullptr) {
1192 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1193 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1194 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1195 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1196 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1197 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1198
1199 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1200 // also implicitly forces the check above that extent.depth is 1
1201 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1202 string_VkImageType(pCreateInfo->imageType));
1203 }
1204 if (pCreateInfo->mipLevels != 1) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001205 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %" PRIu32 ".", base_message,
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001206 pCreateInfo->mipLevels);
1207 }
1208 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1209 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1210 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1211 }
1212 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1213 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1214 base_message, string_VkImageTiling(pCreateInfo->tiling));
1215 }
1216 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1217 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1218 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1219 }
1220 const VkImageCreateFlags valid_flags =
1221 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
Mike Schuchardt2df08912020-12-15 16:28:09 -08001222 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT);
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001223 if ((image_flags & ~valid_flags) != 0) {
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001224 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001225 image_flags);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001226 }
1227 }
1228 }
sfricke-samsung61a57c02021-01-10 21:35:12 -08001229
1230 // If Chroma subsampled format ( _420_ or _422_ )
1231 if (FormatIsXChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.width, 2) != 0)) {
1232 skip |=
1233 LogError(device, "VUID-VkImageCreateInfo-format-04712",
1234 "vkCreateImage(): The format (%s) is X Chroma Subsampled (has _422 or _420 suffix) so the width (=%" PRIu32
1235 ") must be a multiple of 2.",
1236 string_VkFormat(image_format), pCreateInfo->extent.width);
1237 }
1238 if (FormatIsYChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.height, 2) != 0)) {
1239 skip |= LogError(device, "VUID-VkImageCreateInfo-format-04713",
1240 "vkCreateImage(): The format (%s) is Y Chroma Subsampled (has _420 suffix) so the height (=%" PRIu32
1241 ") must be a multiple of 2.",
1242 string_VkFormat(image_format), pCreateInfo->extent.height);
1243 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001244
1245 const auto format_list_info = LvlFindInChain<VkImageFormatListCreateInfo>(pCreateInfo->pNext);
1246 if (format_list_info) {
1247 const uint32_t viewFormatCount = format_list_info->viewFormatCount;
1248 if (((image_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) == 0) && (viewFormatCount > 1)) {
1249 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-04738",
1250 "vkCreateImage(): If the VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT is not set, then "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001251 "VkImageFormatListCreateInfo::viewFormatCount (%" PRIu32 ") must be 0 or 1.",
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001252 viewFormatCount);
1253 }
1254 // Check if viewFormatCount is not zero that it is all compatible
1255 for (uint32_t i = 0; i < viewFormatCount; i++) {
Mike Schuchardtb0608492022-04-05 18:52:48 -07001256 const bool class_compatible =
1257 FormatCompatibilityClass(format_list_info->pViewFormats[i]) == FormatCompatibilityClass(image_format);
1258 if (!class_compatible) {
1259 if (image_flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT) {
1260 const bool size_compatible =
1261 FormatIsCompressed(format_list_info->pViewFormats[i])
1262 ? false
1263 : FormatElementSize(format_list_info->pViewFormats[i]) == FormatElementSize(image_format);
1264 if (!size_compatible) {
1265 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-06722",
1266 "vkCreateImage(): VkImageFormatListCreateInfo::pViewFormats[%" PRIu32
1267 "] (%s) and VkImageCreateInfo::format (%s) are not compatible or size-compatible.",
1268 i, string_VkFormat(format_list_info->pViewFormats[i]), string_VkFormat(image_format));
1269 }
1270 } else {
1271 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-06722",
1272 "vkCreateImage(): VkImageFormatListCreateInfo::pViewFormats[%" PRIu32
1273 "] (%s) and VkImageCreateInfo::format (%s) are not compatible.",
1274 i, string_VkFormat(format_list_info->pViewFormats[i]), string_VkFormat(image_format));
1275 }
sfricke-samsungf60b6c82021-04-05 22:59:20 -07001276 }
1277 }
1278 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001279 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001280
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001281 return skip;
1282}
1283
Jeff Bolz99e3f632020-03-24 22:59:22 -05001284bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1285 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1286 bool skip = false;
1287
1288 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001289 // Validate feature set if using CUBE_ARRAY
1290 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1291 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1292 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1293 "enabling the imageCubeArray feature.");
1294 }
1295
Jeff Bolz99e3f632020-03-24 22:59:22 -05001296 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1297 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1298 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001299 "vkCreateImageView(): subresourceRange.layerCount (%" PRIu32
1300 ") must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001301 pCreateInfo->subresourceRange.layerCount);
1302 }
1303 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001304 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02961",
1305 "vkCreateImageView(): subresourceRange.layerCount (%" PRIu32
1306 ") must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1307 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001308 }
1309 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001310
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001311 auto astc_decode_mode = LvlFindInChain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
sfricke-samsung45996a42021-09-16 13:45:27 -07001312 if (IsExtEnabled(device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001313 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1314 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1315 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1316 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1317 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1318 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1319 }
sfricke-samsunge3086292021-11-18 23:02:35 -08001320 if ((FormatIsCompressed_ASTC_LDR(pCreateInfo->format) == false) &&
1321 (FormatIsCompressed_ASTC_HDR(pCreateInfo->format) == false)) {
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001322 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1323 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1324 "not an ASTC format.",
1325 string_VkFormat(pCreateInfo->format));
1326 }
1327 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001328
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001329 auto ycbcr_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
sfricke-samsung83d98122020-07-04 06:21:15 -07001330 if (ycbcr_conversion != nullptr) {
1331 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1332 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1333 skip |= LogError(
1334 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1335 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1336 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1337 "r swizzle = %s\n"
1338 "g swizzle = %s\n"
1339 "b swizzle = %s\n"
1340 "a swizzle = %s\n",
1341 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1342 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1343 }
1344 }
1345 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001346 }
1347 return skip;
1348}
1349
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001350bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001351 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001352 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001353
1354 // Note: for numerical correctness
1355 // - float comparisons should expect NaN (comparison always false).
1356 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1357
1358 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001359 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001360 if (v1_f <= 0.0f) return true;
1361
1362 float intpart;
1363 const float fract = modff(v1_f, &intpart);
1364
1365 assert(std::numeric_limits<float>::radix == 2);
1366 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1367 if (intpart >= u32_max_plus1) return false;
1368
1369 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001370 if (v1_u32 < v2_u32) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001371 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001372 } else if (v1_u32 == v2_u32 && fract == 0.0f) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001373 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001374 } else {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001375 return false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001376 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01001377 };
1378
1379 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1380 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1381 return (v1_f <= v2_f);
1382 };
1383
1384 // width
1385 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001386 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001387
1388 if (!(viewport.width > 0.0f)) {
1389 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001390 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1391 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001392 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1393 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001394 skip |= LogError(object, "VUID-VkViewport-width-01771",
1395 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1396 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001397 }
1398
1399 // height
1400 bool height_healthy = true;
sfricke-samsung45996a42021-09-16 13:45:27 -07001401 const bool negative_height_enabled =
1402 IsExtEnabled(device_extensions.vk_khr_maintenance1) || IsExtEnabled(device_extensions.vk_amd_negative_viewport_height);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001403 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001404
1405 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1406 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001407 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1408 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001409 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1410 height_healthy = false;
1411
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001412 skip |= LogError(object, "VUID-VkViewport-height-01773",
1413 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1414 ").",
1415 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001416 }
1417
1418 // x
1419 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001420 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001421 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001422 skip |= LogError(object, "VUID-VkViewport-x-01774",
1423 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1424 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001425 }
1426
1427 // x + width
1428 if (x_healthy && width_healthy) {
1429 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001430 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001431 skip |= LogError(
1432 object, "VUID-VkViewport-x-01232",
1433 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1434 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1435 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001436 }
1437 }
1438
1439 // y
1440 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001441 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001442 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001443 skip |= LogError(object, "VUID-VkViewport-y-01775",
1444 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1445 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001446 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001447 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001448 skip |= LogError(object, "VUID-VkViewport-y-01776",
1449 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1450 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001451 }
1452
1453 // y + height
1454 if (y_healthy && height_healthy) {
1455 const float boundary = viewport.y + viewport.height;
1456
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001457 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001458 skip |= LogError(object, "VUID-VkViewport-y-01233",
1459 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1460 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1461 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001462 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001463 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001464 LogError(object, "VUID-VkViewport-y-01777",
1465 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1466 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1467 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001468 }
1469 }
1470
sfricke-samsungfd06d422021-01-22 02:17:21 -08001471 // The extension was not created with a feature bit whichs prevents displaying the 2 variations of the VUIDs
sfricke-samsung45996a42021-09-16 13:45:27 -07001472 if (!IsExtEnabled(device_extensions.vk_ext_depth_range_unrestricted)) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001473 // minDepth
1474 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001475 // Also VUID-VkViewport-minDepth-02540
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001476 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001477 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1478 "[0.0, 1.0] range.",
1479 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001480 }
1481
1482 // maxDepth
1483 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001484 // Also VUID-VkViewport-maxDepth-02541
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001485 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001486 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1487 "[0.0, 1.0] range.",
1488 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001489 }
1490 }
1491
1492 return skip;
1493}
1494
Dave Houlton142c4cb2018-10-17 15:04:41 -06001495struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001496 VkShadingRatePaletteEntryNV shadingRate;
1497 uint32_t width;
1498 uint32_t height;
1499};
1500
1501// All palette entries with more than one pixel per fragment
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001502static SampleOrderInfo sample_order_infos[] = {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001503 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1504 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1505 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1506 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1507 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1508 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001509};
1510
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001511bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001512 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001513
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001514 SampleOrderInfo *sample_order_info;
1515 uint32_t info_idx = 0;
1516 for (sample_order_info = nullptr; info_idx < ARRAY_SIZE(sample_order_infos); ++info_idx) {
1517 if (sample_order_infos[info_idx].shadingRate == order->shadingRate) {
1518 sample_order_info = &sample_order_infos[info_idx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001519 break;
1520 }
1521 }
1522
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001523 if (sample_order_info == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001524 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1525 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1526 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001527 return skip;
1528 }
1529
Dave Houlton142c4cb2018-10-17 15:04:41 -06001530 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001531 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001532 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1533 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1534 ") must "
1535 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1536 "is set in framebufferNoAttachmentsSampleCounts.",
1537 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001538 }
1539
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001540 if (order->sampleLocationCount != order->sampleCount * sample_order_info->width * sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001541 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1542 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1543 ") must "
1544 "be equal to the product of sampleCount (=%" PRIu32
1545 "), the fragment width for shadingRate "
1546 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001547 order->sampleLocationCount, order->sampleCount, sample_order_info->width, sample_order_info->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001548 }
1549
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001550 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001551 skip |= LogError(
1552 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001553 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1554 ") must "
1555 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001556 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001557 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001558
1559 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001560 // the first width*height*sampleCount bits to all be set. Note: There is no
1561 // guarantee that 64 bits is enough, but practically it's unlikely for an
1562 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001563 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001564 uint64_t sample_locations_mask = 0;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001565 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001566 const VkCoarseSampleLocationNV *sample_loc = &order->pSampleLocations[i];
1567 if (sample_loc->pixelX >= sample_order_info->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001568 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1569 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001570 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001571 if (sample_loc->pixelY >= sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001572 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1573 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001574 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001575 if (sample_loc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001576 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1577 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001578 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001579 uint32_t idx =
1580 sample_loc->sample + order->sampleCount * (sample_loc->pixelX + sample_order_info->width * sample_loc->pixelY);
1581 sample_locations_mask |= 1ULL << idx;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001582 }
1583
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001584 uint64_t expected_mask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1585 if (sample_locations_mask != expected_mask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001586 skip |= LogError(
1587 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001588 "The array pSampleLocations must contain exactly one entry for "
1589 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001590 }
1591
1592 return skip;
1593}
1594
sfricke-samsung51303fb2021-05-09 19:09:13 -07001595bool StatelessValidation::manual_PreCallValidateCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo,
1596 const VkAllocationCallbacks *pAllocator,
1597 VkPipelineLayout *pPipelineLayout) const {
1598 bool skip = false;
1599 // Validate layout count against device physical limit
1600 if (pCreateInfo->setLayoutCount > device_limits.maxBoundDescriptorSets) {
1601 skip |= LogError(device, "VUID-VkPipelineLayoutCreateInfo-setLayoutCount-00286",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001602 "vkCreatePipelineLayout(): setLayoutCount (%" PRIu32
1603 ") exceeds physical device maxBoundDescriptorSets limit (%" PRIu32 ").",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001604 pCreateInfo->setLayoutCount, device_limits.maxBoundDescriptorSets);
1605 }
1606
Nathaniel Cesariodb38b7a2022-03-10 22:16:51 -07001607 const bool has_independent_sets = (pCreateInfo->flags & VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT) != 0;
1608 const bool graphics_pipeline_library = IsExtEnabled(device_extensions.vk_ext_graphics_pipeline_library);
1609 const char *const valid_dsl_vuid = (!graphics_pipeline_library)
1610 ? "VUID-VkPipelineLayoutCreateInfo-pSetLayouts-06561"
1611 : ((!has_independent_sets) ? "VUID-VkPipelineLayoutCreateInfo-flags-06562" : nullptr);
1612 if (valid_dsl_vuid) {
1613 for (uint32_t i = 0; i < pCreateInfo->setLayoutCount; ++i) {
1614 if (!pCreateInfo->pSetLayouts[i]) {
1615 skip |=
1616 LogError(device, valid_dsl_vuid, "vkCreatePipelineLayout(): pSetLayouts[%" PRIu32 "] is VK_NULL_HANDLE.", i);
1617 }
1618 }
1619 }
1620
sfricke-samsung51303fb2021-05-09 19:09:13 -07001621 // Validate Push Constant ranges
1622 for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
1623 const uint32_t offset = pCreateInfo->pPushConstantRanges[i].offset;
1624 const uint32_t size = pCreateInfo->pPushConstantRanges[i].size;
1625 const uint32_t max_push_constants_size = device_limits.maxPushConstantsSize;
1626 // Check that offset + size don't exceed the max.
1627 // Prevent arithetic overflow here by avoiding addition and testing in this order.
1628 if (offset >= max_push_constants_size) {
1629 skip |= LogError(device, "VUID-VkPushConstantRange-offset-00294",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001630 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].offset (%" PRIu32
1631 ") that exceeds this "
1632 "device's maxPushConstantSize of %" PRIu32 ".",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001633 i, offset, max_push_constants_size);
1634 }
1635 if (size > max_push_constants_size - offset) {
1636 skip |= LogError(device, "VUID-VkPushConstantRange-size-00298",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001637 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "] offset (%" PRIu32
1638 ") and size (%" PRIu32
1639 ") "
1640 "together exceeds this device's maxPushConstantSize of %" PRIu32 ".",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001641 i, offset, size, max_push_constants_size);
1642 }
1643
1644 // size needs to be non-zero and a multiple of 4.
1645 if (size == 0) {
1646 skip |= LogError(device, "VUID-VkPushConstantRange-size-00296",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001647 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].size (%" PRIu32
1648 ") is not greater than zero.",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001649 i, size);
1650 }
1651 if (size & 0x3) {
1652 skip |= LogError(device, "VUID-VkPushConstantRange-size-00297",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001653 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].size (%" PRIu32
1654 ") is not a multiple of 4.",
1655 i, size);
sfricke-samsung51303fb2021-05-09 19:09:13 -07001656 }
1657
1658 // offset needs to be a multiple of 4.
1659 if ((offset & 0x3) != 0) {
1660 skip |= LogError(device, "VUID-VkPushConstantRange-offset-00295",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001661 "vkCreatePipelineLayout(): pCreateInfo->pPushConstantRanges[%" PRIu32 "].offset (%" PRIu32
1662 ") is not a multiple of 4.",
sfricke-samsung51303fb2021-05-09 19:09:13 -07001663 i, offset);
1664 }
1665 }
1666
1667 // As of 1.0.28, there is a VU that states that a stage flag cannot appear more than once in the list of push constant ranges.
1668 for (uint32_t i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) {
1669 for (uint32_t j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) {
1670 if (0 != (pCreateInfo->pPushConstantRanges[i].stageFlags & pCreateInfo->pPushConstantRanges[j].stageFlags)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001671 skip |=
1672 LogError(device, "VUID-VkPipelineLayoutCreateInfo-pPushConstantRanges-00292",
1673 "vkCreatePipelineLayout() Duplicate stage flags found in ranges %" PRIu32 " and %" PRIu32 ".", i, j);
sfricke-samsung51303fb2021-05-09 19:09:13 -07001674 }
1675 }
1676 }
1677 return skip;
1678}
1679
ziga-lunargc6341372021-07-28 12:57:42 +02001680bool StatelessValidation::ValidatePipelineShaderStageCreateInfo(const char *func_name, const char *msg,
1681 const VkPipelineShaderStageCreateInfo *pCreateInfo) const {
1682 bool skip = false;
1683
1684 const auto *required_subgroup_size_features =
1685 LvlFindInChain<VkPipelineShaderStageRequiredSubgroupSizeCreateInfoEXT>(pCreateInfo->pNext);
1686
1687 if (required_subgroup_size_features) {
1688 if ((pCreateInfo->flags & VK_PIPELINE_SHADER_STAGE_CREATE_ALLOW_VARYING_SUBGROUP_SIZE_BIT_EXT) != 0) {
1689 skip |= LogError(
1690 device, "VUID-VkPipelineShaderStageCreateInfo-pNext-02754",
1691 "%s(): %s->flags (0x%x) includes VK_PIPELINE_SHADER_STAGE_CREATE_ALLOW_VARYING_SUBGROUP_SIZE_BIT_EXT while "
1692 "VkPipelineShaderStageRequiredSubgroupSizeCreateInfoEXT is included in the pNext chain.",
1693 func_name, msg, pCreateInfo->flags);
1694 }
1695 }
1696
1697 return skip;
1698}
1699
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001700bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1701 uint32_t createInfoCount,
1702 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1703 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001704 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001705 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001706
1707 if (pCreateInfos != nullptr) {
1708 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001709 bool has_dynamic_viewport = false;
1710 bool has_dynamic_scissor = false;
1711 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001712 bool has_dynamic_depth_bias = false;
1713 bool has_dynamic_blend_constant = false;
1714 bool has_dynamic_depth_bounds = false;
1715 bool has_dynamic_stencil_compare = false;
1716 bool has_dynamic_stencil_write = false;
1717 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001718 bool has_dynamic_viewport_w_scaling_nv = false;
1719 bool has_dynamic_discard_rectangle_ext = false;
1720 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001721 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001722 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001723 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001724 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001725 bool has_dynamic_cull_mode = false;
1726 bool has_dynamic_front_face = false;
1727 bool has_dynamic_primitive_topology = false;
1728 bool has_dynamic_viewport_with_count = false;
1729 bool has_dynamic_scissor_with_count = false;
1730 bool has_dynamic_vertex_input_binding_stride = false;
1731 bool has_dynamic_depth_test_enable = false;
1732 bool has_dynamic_depth_write_enable = false;
1733 bool has_dynamic_depth_compare_op = false;
1734 bool has_dynamic_depth_bounds_test_enable = false;
1735 bool has_dynamic_stencil_test_enable = false;
1736 bool has_dynamic_stencil_op = false;
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07001737 bool has_patch_control_points = false;
1738 bool has_rasterizer_discard_enable = false;
1739 bool has_depth_bias_enable = false;
1740 bool has_logic_op = false;
1741 bool has_primitive_restart_enable = false;
Piers Daniellcb6d8032021-04-19 18:51:26 -06001742 bool has_dynamic_vertex_input = false;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07001743
1744 // Create a copy of create_info and set non-included sub-state to null
1745 auto create_info = pCreateInfos[i];
1746 const auto *graphics_lib_info = LvlFindInChain<VkGraphicsPipelineLibraryCreateInfoEXT>(create_info.pNext);
1747 if (graphics_lib_info) {
1748 if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_VERTEX_INPUT_INTERFACE_BIT_EXT)) {
1749 create_info.pVertexInputState = nullptr;
1750 create_info.pInputAssemblyState = nullptr;
1751 }
1752 if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT)) {
1753 create_info.pViewportState = nullptr;
1754 create_info.pRasterizationState = nullptr;
1755 create_info.pTessellationState = nullptr;
1756 }
1757 if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT)) {
1758 create_info.pDepthStencilState = nullptr;
1759 }
1760 if (!(graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT)) {
1761 create_info.pColorBlendState = nullptr;
1762 }
1763 if (!(graphics_lib_info->flags & (VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT |
1764 VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT))) {
1765 create_info.pMultisampleState = nullptr;
1766 }
1767 if (!(graphics_lib_info->flags & (VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT |
1768 VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT))) {
1769 create_info.layout = VK_NULL_HANDLE;
1770 }
1771 if (!(graphics_lib_info->flags & (VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT |
1772 VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT |
1773 VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT))) {
1774 create_info.renderPass = VK_NULL_HANDLE;
1775 create_info.subpass = 0;
1776 }
1777 }
1778
Nathaniel Cesario617ffdc2022-03-11 17:02:45 -07001779 if (!IsExtEnabled(device_extensions.vk_ext_graphics_pipeline_library)) {
1780 if (create_info.stageCount == 0) {
1781 skip |=
1782 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stageCount-06604",
1783 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32 "].stageCount is 0, but %s is not enabled", i,
1784 VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME);
1785 }
1786 // TODO while PRIu32 should probably be used instead of %i below, %i is necessary due to
1787 // ParameterName::IndexFormatSpecifier
1788 skip |= validate_struct_type_array(
1789 "vkCreateGraphicsPipelines", ParameterName("pCreateInfos[%i].stageCount", ParameterName::IndexVector{i}),
1790 ParameterName("pCreateInfos[%i].pStages", ParameterName::IndexVector{i}),
1791 "VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO", pCreateInfos[i].stageCount, pCreateInfos[i].pStages,
1792 VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO, true, true,
1793 "VUID-VkPipelineShaderStageCreateInfo-sType-sType", "VUID-VkGraphicsPipelineCreateInfo-pStages-06600",
1794 "VUID-VkGraphicsPipelineCreateInfo-stageCount-arraylength");
1795 skip |= validate_struct_type("vkCreateGraphicsPipelines",
1796 ParameterName("pCreateInfos[%i].pRasterizationState", ParameterName::IndexVector{i}),
1797 "VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_CREATE_INFO",
1798 pCreateInfos[i].pRasterizationState,
1799 VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_CREATE_INFO, true,
1800 "VUID-VkGraphicsPipelineCreateInfo-pRasterizationState-06601",
1801 "VUID-VkPipelineRasterizationStateCreateInfo-sType-sType");
1802 if (!create_info.layout) {
1803 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-layout-06602",
1804 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
1805 "].layout is VK_NULL_HANDLE, but %s is not enabled.",
1806 i, VK_EXT_GRAPHICS_PIPELINE_LIBRARY_EXTENSION_NAME);
1807 }
1808 }
1809
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07001810 // TODO probably should check dynamic state from graphics libraries, at least when creating an "executable pipeline"
1811 if (create_info.pDynamicState != nullptr) {
1812 const auto &dynamic_state_info = *create_info.pDynamicState;
Petr Kraus299ba622017-11-24 03:09:03 +01001813 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1814 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001815 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1816 if (has_dynamic_viewport == true) {
1817 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1818 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001819 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001820 i);
1821 }
1822 has_dynamic_viewport = true;
1823 }
1824 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1825 if (has_dynamic_scissor == true) {
1826 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1827 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001828 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001829 i);
1830 }
1831 has_dynamic_scissor = true;
1832 }
1833 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1834 if (has_dynamic_line_width == true) {
1835 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1836 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001837 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001838 i);
1839 }
1840 has_dynamic_line_width = true;
1841 }
1842 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1843 if (has_dynamic_depth_bias == true) {
1844 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1845 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001846 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001847 i);
1848 }
1849 has_dynamic_depth_bias = true;
1850 }
1851 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1852 if (has_dynamic_blend_constant == true) {
1853 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1854 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001855 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001856 i);
1857 }
1858 has_dynamic_blend_constant = true;
1859 }
1860 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1861 if (has_dynamic_depth_bounds == true) {
1862 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1863 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001864 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001865 i);
1866 }
1867 has_dynamic_depth_bounds = true;
1868 }
1869 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1870 if (has_dynamic_stencil_compare == true) {
1871 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1872 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001873 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001874 i);
1875 }
1876 has_dynamic_stencil_compare = true;
1877 }
1878 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1879 if (has_dynamic_stencil_write == true) {
1880 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1881 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001882 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001883 i);
1884 }
1885 has_dynamic_stencil_write = true;
1886 }
1887 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1888 if (has_dynamic_stencil_reference == true) {
1889 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1890 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001891 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001892 i);
1893 }
1894 has_dynamic_stencil_reference = true;
1895 }
1896 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1897 if (has_dynamic_viewport_w_scaling_nv == true) {
1898 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1899 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001900 "in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001901 i);
1902 }
1903 has_dynamic_viewport_w_scaling_nv = true;
1904 }
1905 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1906 if (has_dynamic_discard_rectangle_ext == true) {
1907 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1908 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001909 "in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001910 i);
1911 }
1912 has_dynamic_discard_rectangle_ext = true;
1913 }
1914 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1915 if (has_dynamic_sample_locations_ext == true) {
1916 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1917 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001918 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001919 i);
1920 }
1921 has_dynamic_sample_locations_ext = true;
1922 }
1923 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1924 if (has_dynamic_exclusive_scissor_nv == true) {
1925 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1926 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001927 "the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001928 i);
1929 }
1930 has_dynamic_exclusive_scissor_nv = true;
1931 }
1932 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1933 if (has_dynamic_shading_rate_palette_nv == true) {
1934 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1935 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001936 "listed twice in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001937 i);
1938 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001939 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001940 }
1941 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1942 if (has_dynamic_viewport_course_sample_order_nv == true) {
1943 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1944 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001945 "listed twice in the pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001946 i);
1947 }
1948 has_dynamic_viewport_course_sample_order_nv = true;
1949 }
1950 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1951 if (has_dynamic_line_stipple == true) {
1952 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1953 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001954 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Spencer Fricke8d428882020-03-16 17:23:33 -07001955 i);
1956 }
1957 has_dynamic_line_stipple = true;
1958 }
Piers Daniell39842ee2020-07-10 16:42:33 -06001959 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
1960 if (has_dynamic_cull_mode) {
1961 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1962 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001963 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001964 i);
1965 }
1966 has_dynamic_cull_mode = true;
1967 }
1968 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
1969 if (has_dynamic_front_face) {
1970 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1971 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001972 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001973 i);
1974 }
1975 has_dynamic_front_face = true;
1976 }
1977 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
1978 if (has_dynamic_primitive_topology) {
1979 skip |= LogError(
1980 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1981 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001982 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001983 i);
1984 }
1985 has_dynamic_primitive_topology = true;
1986 }
1987 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
1988 if (has_dynamic_viewport_with_count) {
1989 skip |= LogError(
1990 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1991 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07001992 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06001993 i);
1994 }
1995 has_dynamic_viewport_with_count = true;
1996 }
1997 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
1998 if (has_dynamic_scissor_with_count) {
1999 skip |= LogError(
2000 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2001 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002002 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002003 i);
2004 }
2005 has_dynamic_scissor_with_count = true;
2006 }
2007 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
2008 if (has_dynamic_vertex_input_binding_stride) {
2009 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2010 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
2011 "listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002012 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002013 i);
2014 }
2015 has_dynamic_vertex_input_binding_stride = true;
2016 }
2017 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
2018 if (has_dynamic_depth_test_enable) {
2019 skip |= LogError(
2020 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2021 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002022 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002023 i);
2024 }
2025 has_dynamic_depth_test_enable = true;
2026 }
2027 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
2028 if (has_dynamic_depth_write_enable) {
2029 skip |= LogError(
2030 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2031 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002032 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002033 i);
2034 }
2035 has_dynamic_depth_write_enable = true;
2036 }
2037 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
2038 if (has_dynamic_depth_compare_op) {
2039 skip |=
2040 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2041 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002042 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002043 i);
2044 }
2045 has_dynamic_depth_compare_op = true;
2046 }
2047 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
2048 if (has_dynamic_depth_bounds_test_enable) {
2049 skip |= LogError(
2050 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2051 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002052 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002053 i);
2054 }
2055 has_dynamic_depth_bounds_test_enable = true;
2056 }
2057 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
2058 if (has_dynamic_stencil_test_enable) {
2059 skip |= LogError(
2060 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2061 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002062 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002063 i);
2064 }
2065 has_dynamic_stencil_test_enable = true;
2066 }
2067 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
2068 if (has_dynamic_stencil_op) {
2069 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2070 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002071 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Piers Daniell39842ee2020-07-10 16:42:33 -06002072 i);
2073 }
2074 has_dynamic_stencil_op = true;
2075 }
sfricke-samsung5f8f9702021-01-29 23:30:30 -08002076 if (dynamic_state == VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR) {
2077 // Not allowed for graphics pipelines
2078 skip |= LogError(
2079 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03578",
2080 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR was listed the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002081 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates[%" PRIu32
2082 "] but not allowed in graphic pipelines.",
sfricke-samsung5f8f9702021-01-29 23:30:30 -08002083 i, state_index);
2084 }
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002085 if (dynamic_state == VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT) {
2086 if (has_patch_control_points) {
2087 skip |= LogError(
2088 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2089 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002090 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002091 i);
2092 }
2093 has_patch_control_points = true;
2094 }
2095 if (dynamic_state == VK_DYNAMIC_STATE_RASTERIZER_DISCARD_ENABLE_EXT) {
2096 if (has_rasterizer_discard_enable) {
2097 skip |= LogError(
2098 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2099 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_RASTERIZER_DISCARD_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002100 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002101 i);
2102 }
2103 has_rasterizer_discard_enable = true;
2104 }
2105 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS_ENABLE_EXT) {
2106 if (has_depth_bias_enable) {
2107 skip |= LogError(
2108 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2109 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002110 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002111 i);
2112 }
2113 has_depth_bias_enable = true;
2114 }
2115 if (dynamic_state == VK_DYNAMIC_STATE_LOGIC_OP_EXT) {
2116 if (has_logic_op) {
2117 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2118 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LOGIC_OP_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002119 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002120 i);
2121 }
2122 has_logic_op = true;
2123 }
2124 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_RESTART_ENABLE_EXT) {
2125 if (has_primitive_restart_enable) {
2126 skip |= LogError(
2127 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
2128 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_RESTART_ENABLE_EXT was listed twice in the "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002129 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
Vikram Kushwahaa57b0c32021-04-19 12:21:46 -07002130 i);
2131 }
2132 has_primitive_restart_enable = true;
2133 }
Piers Daniellcb6d8032021-04-19 18:51:26 -06002134 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_EXT) {
2135 if (has_dynamic_vertex_input) {
2136 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002137 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_EXT was listed twice in the "
2138 "pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
2139 i);
Piers Daniellcb6d8032021-04-19 18:51:26 -06002140 }
2141 has_dynamic_vertex_input = true;
2142 }
Petr Kraus299ba622017-11-24 03:09:03 +01002143 }
2144 }
2145
sfricke-samsung3b944422021-01-23 02:15:19 -08002146 if (has_dynamic_viewport_with_count && has_dynamic_viewport) {
2147 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04132",
2148 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT and "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002149 "VK_DYNAMIC_STATE_VIEWPORT both listed in pCreateInfos[%" PRIu32
2150 "].pDynamicState->pDynamicStates array",
sfricke-samsung3b944422021-01-23 02:15:19 -08002151 i);
2152 }
2153
2154 if (has_dynamic_scissor_with_count && has_dynamic_scissor) {
2155 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04133",
2156 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT and VK_DYNAMIC_STATE_SCISSOR "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002157 "both listed in pCreateInfos[%" PRIu32 "].pDynamicState->pDynamicStates array",
sfricke-samsung3b944422021-01-23 02:15:19 -08002158 i);
2159 }
2160
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002161 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(create_info.pNext);
2162 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != create_info.stageCount)) {
Tony-LunarGce3244a2021-11-19 12:33:40 -07002163 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfo-pipelineStageCreationFeedbackCount-02668",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002164 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
2165 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
2166 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002167 i, feedback_struct->pipelineStageCreationFeedbackCount, create_info.stageCount);
Peter Chen85366392019-05-14 15:20:11 -04002168 }
2169
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002170 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002171
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002172 // Collect active stages and other information
2173 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002174 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002175 bool has_eval = false;
2176 bool has_control = false;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002177 if (create_info.pStages != nullptr) {
2178 for (uint32_t stage_index = 0; stage_index < create_info.stageCount; ++stage_index) {
2179 active_shaders |= create_info.pStages[stage_index].stage;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002180
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002181 if (create_info.pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002182 has_control = true;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002183 } else if (create_info.pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002184 has_eval = true;
2185 }
2186
2187 skip |= validate_string(
2188 "vkCreateGraphicsPipelines",
2189 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002190 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", create_info.pStages[stage_index].pName);
ziga-lunargc6341372021-07-28 12:57:42 +02002191
2192 std::stringstream msg;
2193 msg << "pCreateInfos[%" << i << "].pStages[%" << stage_index << "]";
2194 ValidatePipelineShaderStageCreateInfo("vkCreateGraphicsPipelines", msg.str().c_str(),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002195 &create_info.pStages[stage_index]);
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002196 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002197 }
2198
2199 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002200 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (create_info.pTessellationState != nullptr)) {
2201 skip |=
2202 validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
2203 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
2204 create_info.pTessellationState, VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO,
2205 false, kVUIDUndefined, "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002206
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002207 const VkStructureType allowed_structs_vk_pipeline_tessellation_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002208 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
2209
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002210 skip |= validate_struct_pnext(
2211 "vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002212 "VkPipelineTessellationDomainOriginStateCreateInfo", create_info.pTessellationState->pNext,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002213 ARRAY_SIZE(allowed_structs_vk_pipeline_tessellation_state_create_info),
2214 allowed_structs_vk_pipeline_tessellation_state_create_info, GeneratedVulkanHeaderVersion,
2215 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
2216 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002217
2218 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002219 create_info.pTessellationState->flags,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002220 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
2221 }
2222
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002223 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (create_info.pInputAssemblyState != nullptr)) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002224 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
2225 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002226 create_info.pInputAssemblyState,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002227 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
2228 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
2229
2230 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002231 create_info.pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002232 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002233
2234 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002235 create_info.pInputAssemblyState->flags,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002236 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
2237
2238 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
2239 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002240 create_info.pInputAssemblyState->topology,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002241 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
2242
2243 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002244 create_info.pInputAssemblyState->primitiveRestartEnable);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002245 }
2246
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002247 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (create_info.pVertexInputState != nullptr)) {
2248 auto const &vertex_input_state = create_info.pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02002249
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002250 if (create_info.pVertexInputState->flags != 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002251 skip |=
2252 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
2253 "vkCreateGraphicsPipelines: pararameter "
2254 "pCreateInfos[%" PRIu32 "].pVertexInputState->flags (%" PRIu32 ") is reserved and must be zero.",
2255 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002256 }
2257
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002258 const VkStructureType allowed_structs_vk_pipeline_vertex_input_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002259 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002260 skip |=
2261 validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
2262 "VkPipelineVertexInputDivisorStateCreateInfoEXT", create_info.pVertexInputState->pNext, 1,
2263 allowed_structs_vk_pipeline_vertex_input_state_create_info, GeneratedVulkanHeaderVersion,
2264 "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
2265 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002266 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
2267 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06002268 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002269 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
2270 skip |=
2271 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
2272 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002273 create_info.pVertexInputState->vertexBindingDescriptionCount,
2274 &create_info.pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002275 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
2276
2277 skip |= validate_array(
2278 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
2279 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
2280 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
2281 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
2282
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002283 if (create_info.pVertexInputState->pVertexBindingDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002284 for (uint32_t vertex_binding_description_index = 0;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002285 vertex_binding_description_index < create_info.pVertexInputState->vertexBindingDescriptionCount;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002286 ++vertex_binding_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002287 skip |= validate_ranged_enum(
2288 "vkCreateGraphicsPipelines",
2289 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
2290 AllVkVertexInputRateEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002291 create_info.pVertexInputState->pVertexBindingDescriptions[vertex_binding_description_index].inputRate,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002292 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
2293 }
2294 }
2295
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002296 if (create_info.pVertexInputState->pVertexAttributeDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002297 for (uint32_t vertex_attribute_description_index = 0;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002298 vertex_attribute_description_index < create_info.pVertexInputState->vertexAttributeDescriptionCount;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002299 ++vertex_attribute_description_index) {
sfricke-samsung2e827212021-09-28 07:52:08 -07002300 const VkFormat format =
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002301 create_info.pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index].format;
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002302 skip |= validate_ranged_enum(
2303 "vkCreateGraphicsPipelines",
2304 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
2305 AllVkFormatEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002306 create_info.pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index].format,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002307 "VUID-VkVertexInputAttributeDescription-format-parameter");
sfricke-samsung2e827212021-09-28 07:52:08 -07002308 if (FormatIsDepthOrStencil(format)) {
2309 // Should never hopefully get here, but there are known driver advertising the wrong feature flags
2310 // see https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/4849
2311 skip |= LogError(device, kVUID_Core_invalidDepthStencilFormat,
2312 "vkCreateGraphicsPipelines: "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002313 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2314 "].format is a "
sfricke-samsung2e827212021-09-28 07:52:08 -07002315 "depth/stencil format (%s) but depth/stencil formats do not have a defined sizes for "
2316 "alignment, replace with a color format.",
2317 i, vertex_attribute_description_index, string_VkFormat(format));
2318 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002319 }
2320 }
2321
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002322 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002323 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
2324 "vkCreateGraphicsPipelines: pararameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002325 "pCreateInfo[%" PRIu32 "].pVertexInputState->vertexBindingDescriptionCount (%" PRIu32
2326 ") is "
2327 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002328 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002329 }
2330
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002331 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002332 skip |=
2333 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
2334 "vkCreateGraphicsPipelines: pararameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002335 "pCreateInfo[%" PRIu32 "].pVertexInputState->vertexAttributeDescriptionCount (%" PRIu32
2336 ") is "
2337 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002338 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002339 }
2340
Jeremy Gebbencbf22862021-03-03 12:01:22 -07002341 layer_data::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002342 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
2343 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02002344 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
2345 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002346 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
2347 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002348 "pCreateInfo[%" PRIu32 "].pVertexInputState->pVertexBindingDescription[%" PRIu32
2349 "].binding "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002350 "(%" PRIu32 ") is not distinct.",
2351 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002352 }
2353 vertex_bindings.insert(vertex_bind_desc.binding);
2354
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002355 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002356 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
2357 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002358 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexBindingDescriptions[%" PRIu32
2359 "].binding (%" PRIu32
2360 ") is "
2361 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002362 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002363 }
2364
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002365 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002366 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
2367 "vkCreateGraphicsPipelines: parameter "
2368 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexBindingDescriptions[%" PRIu32
2369 "].stride (%" PRIu32
2370 ") is greater "
2371 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%" PRIu32 ").",
2372 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002373 }
2374 }
2375
Jeremy Gebbencbf22862021-03-03 12:01:22 -07002376 layer_data::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002377 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
2378 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02002379 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
2380 if (location_it != attribute_locations.cend()) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002381 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
2382 "vkCreateGraphicsPipelines: parameter "
2383 "pCreateInfo[%" PRIu32 "].pVertexInputState->vertexAttributeDescriptions[%" PRIu32
2384 "].location (%" PRIu32 ") is not distinct.",
2385 i, d, vertex_attrib_desc.location);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002386 }
2387 attribute_locations.insert(vertex_attrib_desc.location);
2388
2389 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
2390 if (binding_it == vertex_bindings.cend()) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002391 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
2392 "vkCreateGraphicsPipelines: parameter "
2393 " pCreateInfo[%" PRIu32 "].pVertexInputState->vertexAttributeDescriptions[%" PRIu32
2394 "].binding (%" PRIu32
2395 ") does not exist "
2396 "in any pCreateInfo[%" PRIu32 "].pVertexInputState->pVertexBindingDescription.",
2397 i, d, vertex_attrib_desc.binding, i);
Peter Kohautc7d9d392018-07-15 00:34:07 +02002398 }
2399
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002400 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002401 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
2402 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002403 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2404 "].location (%" PRIu32
2405 ") is "
2406 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002407 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002408 }
2409
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002410 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002411 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
2412 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002413 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2414 "].binding (%" PRIu32
2415 ") is "
2416 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002417 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002418 }
2419
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002420 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002421 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
2422 "vkCreateGraphicsPipelines: parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002423 "pCreateInfos[%" PRIu32 "].pVertexInputState->pVertexAttributeDescriptions[%" PRIu32
2424 "].offset (%" PRIu32
2425 ") is "
2426 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%" PRIu32 ").",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002427 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002428 }
2429 }
2430 }
2431
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002432 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
2433 if (has_control && has_eval) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002434 if (create_info.pTessellationState == nullptr) {
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002435 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002436 "vkCreateGraphicsPipelines: if pCreateInfos[%" PRIu32
2437 "].pStages includes a tessellation control "
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002438 "shader stage and a tessellation evaluation shader stage, "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002439 "pCreateInfos[%" PRIu32 "].pTessellationState must not be NULL.",
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002440 i, i);
2441 } else {
2442 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
2443 skip |= validate_struct_pnext(
2444 "vkCreateGraphicsPipelines",
2445 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002446 "VkPipelineTessellationDomainOriginStateCreateInfo", create_info.pTessellationState->pNext, 1,
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002447 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
2448 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002449
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002450 skip |= validate_reserved_flags(
2451 "vkCreateGraphicsPipelines",
2452 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002453 create_info.pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002454
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002455 if (create_info.pTessellationState->patchControlPoints == 0 ||
2456 create_info.pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
2457 skip |=
2458 LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
2459 "vkCreateGraphicsPipelines: invalid parameter "
2460 "pCreateInfos[%" PRIu32 "].pTessellationState->patchControlPoints value %" PRIu32
2461 ". patchControlPoints "
2462 "should be >0 and <=%" PRIu32 ".",
2463 i, create_info.pTessellationState->patchControlPoints, device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002464 }
2465 }
2466 }
2467
2468 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002469 if ((create_info.pRasterizationState != nullptr) &&
2470 (create_info.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
2471 if (create_info.pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002472 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
2473 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
2474 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
2475 "].pViewportState (=NULL) is not a valid pointer.",
2476 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002477 } else {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002478 const auto &viewport_state = *create_info.pViewportState;
Petr Krausa6103552017-11-16 21:21:58 +01002479
2480 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002481 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
2482 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2483 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
2484 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002485 }
2486
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002487 const VkStructureType allowed_structs_vk_pipeline_viewport_state_create_info[] = {
Petr Krausa6103552017-11-16 21:21:58 +01002488 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002489 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
2490 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05002491 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
2492 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002493 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_DEPTH_CLIP_CONTROL_CREATE_INFO_EXT,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002494 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002495 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002496 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01002497 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05002498 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05002499 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002500 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV, VkPipelineViewportDepthClipControlCreateInfoEXT",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002501 viewport_state.pNext, ARRAY_SIZE(allowed_structs_vk_pipeline_viewport_state_create_info),
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002502 allowed_structs_vk_pipeline_viewport_state_create_info, 200,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002503 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08002504 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002505
2506 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002507 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002508 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002509 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002510
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002511 auto exclusive_scissor_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002512 LvlFindInChain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(viewport_state.pNext);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002513 auto shading_rate_image_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002514 LvlFindInChain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(viewport_state.pNext);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002515 auto coarse_sample_order_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002516 LvlFindInChain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(viewport_state.pNext);
2517 const auto vp_swizzle_struct = LvlFindInChain<VkPipelineViewportSwizzleStateCreateInfoNV>(viewport_state.pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002518 const auto vp_w_scaling_struct =
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002519 LvlFindInChain<VkPipelineViewportWScalingStateCreateInfoNV>(viewport_state.pNext);
2520 const auto depth_clip_control_struct =
2521 LvlFindInChain<VkPipelineViewportDepthClipControlCreateInfoEXT>(viewport_state.pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002522
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002523 if (!physical_device_features.multiViewport) {
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002524 if (!has_dynamic_viewport_with_count && (viewport_state.viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002525 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2526 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2527 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2528 ") is not 1.",
2529 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002530 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002531
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002532 if (!has_dynamic_scissor_with_count && (viewport_state.scissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002533 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2534 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2535 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2536 ") is not 1.",
2537 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002538 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002539
Dave Houlton142c4cb2018-10-17 15:04:41 -06002540 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2541 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002542 skip |= LogError(
2543 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2544 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2545 "disabled, but pCreateInfos[%" PRIu32
2546 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2547 ") is not 1.",
2548 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002549 }
2550
Jeff Bolz9af91c52018-09-01 21:53:57 -05002551 if (shading_rate_image_struct &&
2552 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002553 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2554 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2555 "disabled, but pCreateInfos[%" PRIu32
2556 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2557 ") is neither 0 nor 1.",
2558 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002559 }
2560
Petr Krausa6103552017-11-16 21:21:58 +01002561 } else { // multiViewport enabled
2562 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002563 if (!has_dynamic_viewport_with_count) {
2564 skip |= LogError(
2565 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2566 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2567 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002568 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002569 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2570 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2571 "].pViewportState->viewportCount (=%" PRIu32
2572 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2573 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002574 } else if (has_dynamic_viewport_with_count) {
2575 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2576 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2577 "].pViewportState->viewportCount (=%" PRIu32
2578 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2579 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002580 }
Petr Krausa6103552017-11-16 21:21:58 +01002581
2582 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002583 if (!has_dynamic_scissor_with_count) {
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002584 const char *vuid = IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state)
2585 ? "VUID-VkPipelineViewportStateCreateInfo-scissorCount-04136"
2586 : "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength";
Piers Daniell39842ee2020-07-10 16:42:33 -06002587 skip |= LogError(
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002588 device, vuid,
Piers Daniell39842ee2020-07-10 16:42:33 -06002589 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2590 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002591 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002592 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2593 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2594 "].pViewportState->scissorCount (=%" PRIu32
2595 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2596 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002597 } else if (has_dynamic_scissor_with_count) {
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002598 const char *vuid = IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state)
2599 ? "VUID-VkPipelineViewportStateCreateInfo-scissorCount-04136"
2600 : "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380";
2601 skip |= LogError(device, vuid,
Piers Daniell39842ee2020-07-10 16:42:33 -06002602 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2603 "].pViewportState->scissorCount (=%" PRIu32
2604 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2605 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002606 }
2607 }
2608
ziga-lunarg845883b2021-07-14 15:05:00 +02002609 if (!has_dynamic_scissor && viewport_state.pScissors) {
2610 for (uint32_t scissor_i = 0; scissor_i < viewport_state.scissorCount; ++scissor_i) {
2611 const auto &scissor = viewport_state.pScissors[scissor_i];
ziga-lunarga77dc802021-07-15 13:19:06 +02002612
2613 if (scissor.offset.x < 0) {
2614 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-x-02821",
2615 "vkCreateGraphicsPipelines: offset.x (=%" PRIi32 ") of pCreateInfos[%" PRIu32
2616 "].pViewportState->pScissors[%" PRIu32 "] is negative.",
2617 scissor.offset.x, i, scissor_i);
2618 }
2619
2620 if (scissor.offset.y < 0) {
2621 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-x-02821",
2622 "vkCreateGraphicsPipelines: offset.y (=%" PRIi32 ") of pCreateInfos[%" PRIu32
2623 "].pViewportState->pScissors[%" PRIu32 "] is negative.",
2624 scissor.offset.y, i, scissor_i);
2625 }
2626
ziga-lunarg845883b2021-07-14 15:05:00 +02002627 const int64_t x_sum =
2628 static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2629 if (x_sum > std::numeric_limits<int32_t>::max()) {
2630 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-offset-02822",
2631 "vkCreateGraphicsPipelines: offset.x + extent.width (=%" PRIi32 " + %" PRIu32
2632 " = %" PRIi64 ") of pCreateInfos[%" PRIu32 "].pViewportState->pScissors[%" PRIu32
2633 "] will overflow int32_t.",
2634 scissor.offset.x, scissor.extent.width, x_sum, i, scissor_i);
2635 }
ziga-lunarga77dc802021-07-15 13:19:06 +02002636
ziga-lunarg845883b2021-07-14 15:05:00 +02002637 const int64_t y_sum =
2638 static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2639 if (y_sum > std::numeric_limits<int32_t>::max()) {
2640 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-offset-02823",
2641 "vkCreateGraphicsPipelines: offset.y + extent.height (=%" PRIi32 " + %" PRIu32
2642 " = %" PRIi64 ") of pCreateInfos[%" PRIu32 "].pViewportState->pScissors[%" PRIu32
2643 "] will overflow int32_t.",
2644 scissor.offset.y, scissor.extent.height, y_sum, i, scissor_i);
2645 }
2646 }
2647 }
2648
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002649 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002650 skip |=
2651 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2652 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2653 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2654 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002655 }
2656
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002657 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002658 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2659 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2660 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2661 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2662 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002663 }
2664
ziga-lunarg0f0d6582022-03-13 16:17:40 +01002665 if (viewport_state.scissorCount != viewport_state.viewportCount) {
2666 if (!IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state) ||
2667 (!has_dynamic_viewport_with_count && !has_dynamic_scissor_with_count)) {
2668 const char *vuid = IsExtEnabled(device_extensions.vk_ext_extended_dynamic_state)
2669 ? "VUID-VkPipelineViewportStateCreateInfo-scissorCount-04134"
2670 : "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220";
2671 skip |= LogError(
2672 device, vuid,
2673 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2674 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2675 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
2676 }
Petr Krausa6103552017-11-16 21:21:58 +01002677 }
2678
Dave Houlton142c4cb2018-10-17 15:04:41 -06002679 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002680 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002681 skip |=
2682 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2683 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2684 ") must be zero or identical to pCreateInfos[%" PRIu32
2685 "].pViewportState->viewportCount (=%" PRIu32 ").",
2686 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002687 }
2688
Dave Houlton142c4cb2018-10-17 15:04:41 -06002689 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002690 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002691 skip |= LogError(
2692 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002693 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2694 "] "
2695 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2696 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2697 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002698 }
2699
Petr Krausa6103552017-11-16 21:21:58 +01002700 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002701 skip |= LogError(
2702 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002703 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2704 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002705 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2706 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002707 }
2708
2709 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002710 skip |= LogError(
2711 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002712 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2713 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002714 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2715 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002716 }
2717
Jeff Bolz3e71f782018-08-29 23:15:45 -05002718 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002719 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2720 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2721 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002722 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002723 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2724 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2725 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2726 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002727 }
2728
Jeff Bolz9af91c52018-09-01 21:53:57 -05002729 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002730 shading_rate_image_struct->viewportCount > 0 &&
2731 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002732 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002733 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002734 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002735 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2736 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002737 i, i);
2738 }
2739
Chris Mayer328d8212018-12-11 14:16:18 +01002740 if (vp_swizzle_struct) {
2741 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002742 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2743 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2744 " does "
2745 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2746 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002747 }
2748 }
2749
Petr Krausb3fcdb42018-01-09 22:09:09 +01002750 // validate the VkViewports
2751 if (!has_dynamic_viewport && viewport_state.pViewports) {
2752 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2753 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002754 const char *fn_name = "vkCreateGraphicsPipelines";
2755 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2756 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2757 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002758 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002759 }
2760 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002761
sfricke-samsung45996a42021-09-16 13:45:27 -07002762 if (has_dynamic_viewport_w_scaling_nv && !IsExtEnabled(device_extensions.vk_nv_clip_space_w_scaling)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002763 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2764 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2765 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2766 "VK_NV_clip_space_w_scaling extension is not enabled.",
2767 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002768 }
2769
sfricke-samsung45996a42021-09-16 13:45:27 -07002770 if (has_dynamic_discard_rectangle_ext && !IsExtEnabled(device_extensions.vk_ext_discard_rectangles)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002771 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2772 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2773 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2774 "VK_EXT_discard_rectangles extension is not enabled.",
2775 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002776 }
2777
sfricke-samsung45996a42021-09-16 13:45:27 -07002778 if (has_dynamic_sample_locations_ext && !IsExtEnabled(device_extensions.vk_ext_sample_locations)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002779 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2780 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2781 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2782 "VK_EXT_sample_locations extension is not enabled.",
2783 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002784 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002785
sfricke-samsung45996a42021-09-16 13:45:27 -07002786 if (has_dynamic_exclusive_scissor_nv && !IsExtEnabled(device_extensions.vk_nv_scissor_exclusive)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002787 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2788 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2789 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2790 "VK_NV_scissor_exclusive extension is not enabled.",
2791 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002792 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002793
2794 if (coarse_sample_order_struct &&
2795 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2796 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002797 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2798 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2799 "] "
2800 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2801 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2802 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002803 }
2804
2805 if (coarse_sample_order_struct) {
2806 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002807 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002808 }
2809 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002810
2811 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2812 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002813 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2814 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2815 "] "
2816 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2817 ") "
2818 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2819 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002820 }
2821 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002822 skip |= LogError(
2823 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002824 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2825 "] "
2826 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2827 i);
2828 }
2829 }
sfricke-samsunge6669ec2021-11-29 23:33:03 -06002830
2831 if (depth_clip_control_struct) {
2832 const auto *depth_clip_control_features =
2833 LvlFindInChain<VkPhysicalDeviceDepthClipControlFeaturesEXT>(device_createinfo_pnext);
2834 const bool enabled_depth_clip_control =
2835 depth_clip_control_features && depth_clip_control_features->depthClipControl;
2836 if (depth_clip_control_struct->negativeOneToOne && !enabled_depth_clip_control) {
2837 skip |= LogError(device, "VUID-VkPipelineViewportDepthClipControlCreateInfoEXT-negativeOneToOne-06470",
2838 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2839 "].pViewportState has negativeOneToOne set to VK_TRUE in the pNext chain, but the "
2840 "depthClipControl feature is not enabled. ",
2841 i);
2842 }
2843 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002844 }
2845
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002846 const bool is_frag_out_graphics_lib =
2847 graphics_lib_info &&
2848 ((graphics_lib_info->flags & VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_OUTPUT_INTERFACE_BIT_EXT) != 0);
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002849 if (is_frag_out_graphics_lib && (create_info.pMultisampleState == nullptr)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002850 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002851 "vkCreateGraphicsPipelines: if pCreateInfos[%" PRIu32
2852 "].pRasterizationState->rasterizerDiscardEnable "
2853 "is VK_FALSE, pCreateInfos[%" PRIu32 "].pMultisampleState must not be NULL.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002854 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002855 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002856 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002857 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002858 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2859 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002860 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002861 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002862 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002863
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002864 // It is possible for pCreateInfos[i].pMultisampleState to be null when creating a graphics library
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002865 if (create_info.pMultisampleState) {
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002866 skip |= validate_struct_pnext(
2867 "vkCreateGraphicsPipelines",
2868 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002869 valid_struct_names, create_info.pMultisampleState->pNext, 4, valid_next_stypes,
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002870 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2871 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002872
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002873 skip |= validate_reserved_flags(
2874 "vkCreateGraphicsPipelines",
2875 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002876 create_info.pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002877
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002878 skip |= validate_bool32(
2879 "vkCreateGraphicsPipelines",
2880 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002881 create_info.pMultisampleState->sampleShadingEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002882
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002883 skip |= validate_array(
2884 "vkCreateGraphicsPipelines",
2885 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples",
2886 ParameterName::IndexVector{i}),
2887 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002888 create_info.pMultisampleState->rasterizationSamples, &create_info.pMultisampleState->pSampleMask, true,
2889 false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002890
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002891 skip |= validate_flags("vkCreateGraphicsPipelines",
2892 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples",
2893 ParameterName::IndexVector{i}),
2894 "VkSampleCountFlagBits", AllVkSampleCountFlagBits,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002895 create_info.pMultisampleState->rasterizationSamples, kRequiredSingleBit,
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002896 "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002897
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002898 skip |= validate_bool32("vkCreateGraphicsPipelines",
2899 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable",
2900 ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002901 create_info.pMultisampleState->alphaToCoverageEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002902
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002903 skip |= validate_bool32(
2904 "vkCreateGraphicsPipelines",
2905 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002906 create_info.pMultisampleState->alphaToOneEnable);
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002907
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002908 if (create_info.pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002909 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
2910 "vkCreateGraphicsPipelines: parameter pCreateInfos[%" PRIu32
2911 "].pMultisampleState->sType must be "
2912 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002913 i);
John Zulauf7acac592017-11-06 11:15:53 -07002914 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002915 if (create_info.pMultisampleState->sampleShadingEnable == VK_TRUE) {
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002916 if (!physical_device_features.sampleRateShading) {
2917 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2918 "vkCreateGraphicsPipelines(): parameter "
2919 "pCreateInfos[%" PRIu32 "].pMultisampleState->sampleShadingEnable.",
2920 i);
2921 }
2922 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2923 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002924 if (!in_inclusive_range(create_info.pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002925 skip |= LogError(device,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002926
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07002927 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
2928 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%" PRIu32
2929 "].pMultisampleState->minSampleShading.",
2930 i);
2931 }
John Zulauf7acac592017-11-06 11:15:53 -07002932 }
2933 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002934
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002935 const auto *line_state =
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002936 LvlFindInChain<VkPipelineRasterizationLineStateCreateInfoEXT>(create_info.pRasterizationState->pNext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002937
2938 if (line_state) {
2939 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2940 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002941 if (create_info.pMultisampleState->alphaToCoverageEnable) {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002942 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002943 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2944 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002945 "pCreateInfos[%" PRIu32 "].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002946 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002947 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002948 if (create_info.pMultisampleState->alphaToOneEnable) {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002949 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002950 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2951 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002952 "pCreateInfos[%" PRIu32 "].pMultisampleState->alphaToOneEnable == VK_TRUE.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002953 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002954 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07002955 if (create_info.pMultisampleState->sampleShadingEnable) {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002956 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002957 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2958 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002959 "pCreateInfos[%" PRIu32 "].pMultisampleState->sampleShadingEnable == VK_TRUE.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002960 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002961 }
2962 }
2963 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2964 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2965 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002966 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002967 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32 "] lineStippleFactor = %" PRIu32
2968 " must be in the "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002969 "range [1,256].",
2970 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002971 }
2972 }
2973 const auto *line_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002974 LvlFindInChain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002975 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2976 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002977 skip |=
2978 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002979 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2980 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002981 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2982 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002983 }
2984 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2985 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002986 skip |=
2987 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002988 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2989 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002990 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2991 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002992 }
2993 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2994 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002995 skip |=
2996 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07002997 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
2998 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002999 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
3000 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003001 }
3002 if (line_state->stippledLineEnable) {
3003 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
3004 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003005 skip |=
3006 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003007 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3008 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003009 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
3010 "stippledRectangularLines feature.",
3011 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003012 }
3013 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
3014 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003015 skip |=
3016 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003017 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3018 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003019 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
3020 "stippledBresenhamLines feature.",
3021 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003022 }
3023 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
3024 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003025 skip |=
3026 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003027 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3028 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003029 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
3030 "stippledSmoothLines feature.",
3031 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003032 }
3033 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
Malcolm Bechardfc509002021-11-17 21:57:28 -05003034 (!line_features || !line_features->stippledRectangularLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003035 skip |=
3036 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003037 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3038 "] lineRasterizationMode = "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003039 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
3040 "stippledRectangularLines and strictLines features.",
3041 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003042 }
3043 }
3044 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003045 }
3046
Petr Krause91f7a12017-12-14 20:57:36 +01003047 bool uses_color_attachment = false;
3048 bool uses_depthstencil_attachment = false;
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003049 VkSubpassDescriptionFlags subpass_flags = 0;
Petr Krause91f7a12017-12-14 20:57:36 +01003050 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07003051 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003052 const auto subpasses_uses_it = renderpasses_states.find(create_info.renderPass);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003053 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01003054 const auto &subpasses_uses = subpasses_uses_it->second;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003055 if (subpasses_uses.subpasses_using_color_attachment.count(create_info.subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01003056 uses_color_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003057 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003058 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(create_info.subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01003059 uses_depthstencil_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003060 }
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003061 subpass_flags = subpasses_uses.subpasses_flags[create_info.subpass];
Petr Krause91f7a12017-12-14 20:57:36 +01003062 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07003063 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01003064 }
3065
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003066 if (create_info.pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003067 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003068 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003069 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003070 create_info.pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08003071 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003072
Mike Schuchardt00e81452021-11-29 11:11:20 -08003073 skip |=
3074 validate_flags("vkCreateGraphicsPipelines",
3075 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
3076 "VkPipelineDepthStencilStateCreateFlagBits", AllVkPipelineDepthStencilStateCreateFlagBits,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003077 create_info.pDepthStencilState->flags, kOptionalFlags,
Mike Schuchardt00e81452021-11-29 11:11:20 -08003078 "VUID-VkPipelineDepthStencilStateCreateInfo-flags-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003079
3080 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003081 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003082 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003083 create_info.pDepthStencilState->depthTestEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003084
3085 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003086 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003087 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003088 create_info.pDepthStencilState->depthWriteEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003089
3090 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003091 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003092 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003093 "VkCompareOp", AllVkCompareOpEnums, create_info.pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003094 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003095
3096 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003097 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003098 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003099 create_info.pDepthStencilState->depthBoundsTestEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003100
3101 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003102 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003103 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003104 create_info.pDepthStencilState->stencilTestEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003105
3106 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003107 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003108 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003109 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003110 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003111
3112 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003113 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003114 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003115 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003116 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003117
3118 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003119 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003120 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003121 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003122 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003123
3124 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003125 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003126 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003127 "VkCompareOp", AllVkCompareOpEnums, create_info.pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003128 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003129
3130 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003131 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003132 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003133 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003134 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003135
3136 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003137 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003138 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003139 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003140 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003141
3142 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003143 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003144 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003145 "VkStencilOp", AllVkStencilOpEnums, create_info.pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003146 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003147
3148 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003149 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003150 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003151 "VkCompareOp", AllVkCompareOpEnums, create_info.pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003152 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003153
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003154 if (create_info.pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07003155 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003156 "vkCreateGraphicsPipelines: parameter pCreateInfos[%" PRIu32
3157 "].pDepthStencilState->sType must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003158 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
3159 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003160 }
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003161
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003162 if ((create_info.pDepthStencilState->flags &
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003163 VK_PIPELINE_DEPTH_STENCIL_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_DEPTH_ACCESS_BIT_ARM) != 0) {
3164 const auto *rasterization_order_attachment_access_feature =
3165 LvlFindInChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
3166 const bool rasterization_order_depth_attachment_access_feature_enabled =
3167 rasterization_order_attachment_access_feature &&
3168 rasterization_order_attachment_access_feature->rasterizationOrderDepthAttachmentAccess == VK_TRUE;
3169 if (!rasterization_order_depth_attachment_access_feature_enabled) {
3170 skip |= LogError(
3171 device, "VUID-VkPipelineDepthStencilStateCreateInfo-rasterizationOrderDepthAttachmentAccess-06463",
3172 "VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
3173 "rasterizationOrderDepthAttachmentAccess == VK_FALSE, but "
3174 "VkPipelineDepthStencilStateCreateInfo::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003175 string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str());
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003176 }
3177
3178 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_DEPTH_ACCESS_BIT_ARM) == 0) {
3179 skip |= LogError(
Mike Schuchardt979898a2022-01-11 10:46:59 -08003180 device, "VUID-VkGraphicsPipelineCreateInfo-flags-06485",
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003181 "VkPipelineDepthStencilStateCreateInfo::flags == %s but "
3182 "VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003183 string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str(),
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003184 string_VkSubpassDescriptionFlags(subpass_flags).c_str());
3185 }
3186 }
3187
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003188 if ((create_info.pDepthStencilState->flags &
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003189 VK_PIPELINE_DEPTH_STENCIL_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_STENCIL_ACCESS_BIT_ARM) != 0) {
3190 const auto *rasterization_order_attachment_access_feature =
3191 LvlFindInChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
3192 const bool rasterization_order_stencil_attachment_access_feature_enabled =
3193 rasterization_order_attachment_access_feature &&
3194 rasterization_order_attachment_access_feature->rasterizationOrderStencilAttachmentAccess == VK_TRUE;
3195 if (!rasterization_order_stencil_attachment_access_feature_enabled) {
3196 skip |= LogError(
3197 device,
3198 "VUID-VkPipelineDepthStencilStateCreateInfo-rasterizationOrderStencilAttachmentAccess-06464",
3199 "VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
3200 "rasterizationOrderStencilAttachmentAccess == VK_FALSE, but "
3201 "VkPipelineDepthStencilStateCreateInfo::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003202 string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str());
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003203 }
3204
3205 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_STENCIL_ACCESS_BIT_ARM) == 0) {
3206 skip |= LogError(
Mike Schuchardt979898a2022-01-11 10:46:59 -08003207 device, "VUID-VkGraphicsPipelineCreateInfo-flags-06486",
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003208 "VkPipelineDepthStencilStateCreateInfo::flags == %s but "
3209 "VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003210 string_VkPipelineDepthStencilStateCreateFlags(create_info.pDepthStencilState->flags).c_str(),
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003211 string_VkSubpassDescriptionFlags(subpass_flags).c_str());
3212 }
3213 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003214 }
3215
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003216 const VkStructureType allowed_structs_vk_pipeline_color_blend_state_create_info[] = {
ziga-lunarg8de09162021-08-05 15:21:33 +02003217 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT,
3218 VK_STRUCTURE_TYPE_PIPELINE_COLOR_WRITE_CREATE_INFO_EXT};
Shannon McPherson9b9532b2018-10-24 12:00:09 -06003219
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003220 if (create_info.pColorBlendState != nullptr && uses_color_attachment) {
3221 skip |=
3222 validate_struct_type("vkCreateGraphicsPipelines",
3223 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
3224 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
3225 create_info.pColorBlendState, VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO,
3226 false, kVUIDUndefined, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06003227
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003228 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003229 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06003230 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003231 "VkPipelineColorBlendAdvancedStateCreateInfoEXT, VkPipelineColorWriteCreateInfoEXT",
3232 create_info.pColorBlendState->pNext, ARRAY_SIZE(allowed_structs_vk_pipeline_color_blend_state_create_info),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003233 allowed_structs_vk_pipeline_color_blend_state_create_info, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08003234 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
3235 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003236
Mike Schuchardt00e81452021-11-29 11:11:20 -08003237 skip |= validate_flags("vkCreateGraphicsPipelines",
3238 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
3239 "VkPipelineColorBlendStateCreateFlagBits", AllVkPipelineColorBlendStateCreateFlagBits,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003240 create_info.pColorBlendState->flags, kOptionalFlags,
Mike Schuchardt00e81452021-11-29 11:11:20 -08003241 "VUID-VkPipelineColorBlendStateCreateInfo-flags-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003242
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003243 if ((create_info.pColorBlendState->flags &
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003244 VK_PIPELINE_COLOR_BLEND_STATE_CREATE_RASTERIZATION_ORDER_ATTACHMENT_ACCESS_BIT_ARM) != 0) {
3245 const auto *rasterization_order_attachment_access_feature =
3246 LvlFindInChain<VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM>(device_createinfo_pnext);
3247 const bool rasterization_order_color_attachment_access_feature_enabled =
3248 rasterization_order_attachment_access_feature &&
3249 rasterization_order_attachment_access_feature->rasterizationOrderColorAttachmentAccess == VK_TRUE;
3250
3251 if (!rasterization_order_color_attachment_access_feature_enabled) {
3252 skip |= LogError(
3253 device, "VUID-VkPipelineColorBlendStateCreateInfo-rasterizationOrderColorAttachmentAccess-06465",
3254 "VkPhysicalDeviceRasterizationOrderAttachmentAccessFeaturesARM::"
3255 "rasterizationColorAttachmentAccess == VK_FALSE, but "
3256 "VkPipelineColorBlendStateCreateInfo::flags == %s",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003257 string_VkPipelineColorBlendStateCreateFlags(create_info.pColorBlendState->flags).c_str());
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003258 }
3259
3260 if ((subpass_flags & VK_SUBPASS_DESCRIPTION_RASTERIZATION_ORDER_ATTACHMENT_COLOR_ACCESS_BIT_ARM) == 0) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003261 skip |=
3262 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-06484",
3263 "VkPipelineColorBlendStateCreateInfo::flags == %s but "
3264 "VkRenderPassCreateInfo::VkSubpassDescription::flags == %s",
3265 string_VkPipelineColorBlendStateCreateFlags(create_info.pColorBlendState->flags).c_str(),
3266 string_VkSubpassDescriptionFlags(subpass_flags).c_str());
Younggwan Kim26b9abd2021-12-07 21:22:03 +00003267 }
3268 }
3269
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003270 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003271 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003272 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003273 create_info.pColorBlendState->logicOpEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003274
3275 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003276 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003277 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
3278 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003279 create_info.pColorBlendState->attachmentCount, &create_info.pColorBlendState->pAttachments, false, true,
3280 kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003281
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003282 if (create_info.pColorBlendState->pAttachments != NULL) {
3283 for (uint32_t attachment_index = 0; attachment_index < create_info.pColorBlendState->attachmentCount;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003284 ++attachment_index) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003285 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003286 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003287 ParameterName::IndexVector{i, attachment_index}),
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003288 create_info.pColorBlendState->pAttachments[attachment_index].blendEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003289
3290 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003291 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003292 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003293 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003294 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003295 create_info.pColorBlendState->pAttachments[attachment_index].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003296 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003297
3298 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003299 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003300 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003301 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003302 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003303 create_info.pColorBlendState->pAttachments[attachment_index].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003304 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003305
3306 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003307 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003308 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003309 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003310 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003311 create_info.pColorBlendState->pAttachments[attachment_index].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003312 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003313
3314 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003315 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003316 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003317 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003318 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003319 create_info.pColorBlendState->pAttachments[attachment_index].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003320 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003321
3322 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003323 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003324 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003325 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003326 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003327 create_info.pColorBlendState->pAttachments[attachment_index].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06003328 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003329
3330 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003331 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003332 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003333 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003334 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003335 create_info.pColorBlendState->pAttachments[attachment_index].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003336 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003337
3338 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003339 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003340 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003341 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003342 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003343 create_info.pColorBlendState->pAttachments[attachment_index].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02003344 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
ziga-lunarga283d022021-08-04 18:35:23 +02003345
3346 if (phys_dev_ext_props.blend_operation_advanced_props.advancedBlendAllOperations == VK_FALSE) {
3347 bool invalid = false;
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003348 switch (create_info.pColorBlendState->pAttachments[attachment_index].colorBlendOp) {
ziga-lunarga283d022021-08-04 18:35:23 +02003349 case VK_BLEND_OP_ZERO_EXT:
3350 case VK_BLEND_OP_SRC_EXT:
3351 case VK_BLEND_OP_DST_EXT:
3352 case VK_BLEND_OP_SRC_OVER_EXT:
3353 case VK_BLEND_OP_DST_OVER_EXT:
3354 case VK_BLEND_OP_SRC_IN_EXT:
3355 case VK_BLEND_OP_DST_IN_EXT:
3356 case VK_BLEND_OP_SRC_OUT_EXT:
3357 case VK_BLEND_OP_DST_OUT_EXT:
3358 case VK_BLEND_OP_SRC_ATOP_EXT:
3359 case VK_BLEND_OP_DST_ATOP_EXT:
3360 case VK_BLEND_OP_XOR_EXT:
3361 case VK_BLEND_OP_INVERT_EXT:
3362 case VK_BLEND_OP_INVERT_RGB_EXT:
3363 case VK_BLEND_OP_LINEARDODGE_EXT:
3364 case VK_BLEND_OP_LINEARBURN_EXT:
3365 case VK_BLEND_OP_VIVIDLIGHT_EXT:
3366 case VK_BLEND_OP_LINEARLIGHT_EXT:
3367 case VK_BLEND_OP_PINLIGHT_EXT:
3368 case VK_BLEND_OP_HARDMIX_EXT:
3369 case VK_BLEND_OP_PLUS_EXT:
3370 case VK_BLEND_OP_PLUS_CLAMPED_EXT:
3371 case VK_BLEND_OP_PLUS_CLAMPED_ALPHA_EXT:
3372 case VK_BLEND_OP_PLUS_DARKER_EXT:
3373 case VK_BLEND_OP_MINUS_EXT:
3374 case VK_BLEND_OP_MINUS_CLAMPED_EXT:
3375 case VK_BLEND_OP_CONTRAST_EXT:
3376 case VK_BLEND_OP_INVERT_OVG_EXT:
3377 case VK_BLEND_OP_RED_EXT:
3378 case VK_BLEND_OP_GREEN_EXT:
3379 case VK_BLEND_OP_BLUE_EXT:
3380 invalid = true;
3381 break;
3382 default:
3383 break;
3384 }
3385 if (invalid) {
3386 skip |= LogError(
3387 device, "VUID-VkPipelineColorBlendAttachmentState-advancedBlendAllOperations-01409",
3388 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
3389 "].pColorBlendState->pAttachments[%" PRIu32
3390 "].colorBlendOp (%s) is not valid when "
3391 "VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT::advancedBlendAllOperations is "
3392 "VK_FALSE",
3393 i, attachment_index,
3394 string_VkBlendOp(
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003395 create_info.pColorBlendState->pAttachments[attachment_index].colorBlendOp));
ziga-lunarga283d022021-08-04 18:35:23 +02003396 }
3397 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003398 }
3399 }
3400
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003401 if (create_info.pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07003402 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003403 "vkCreateGraphicsPipelines: parameter pCreateInfos[%" PRIu32
3404 "].pColorBlendState->sType must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003405 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
3406 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003407 }
3408
3409 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003410 if (create_info.pColorBlendState->logicOpEnable == VK_TRUE) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003411 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003412 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003413 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003414 AllVkLogicOpEnums, create_info.pColorBlendState->logicOp,
Dave Houlton413a6782018-05-22 13:01:54 -06003415 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003416 }
3417 }
3418 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003419
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003420 const VkPipelineCreateFlags flags = create_info.flags;
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003421 if (flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003422 if (create_info.basePipelineIndex != -1) {
3423 if (create_info.basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003424 skip |=
3425 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003426 "vkCreateGraphicsPipelines parameter, pCreateInfos[%" PRIu32
3427 "]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003428 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003429 "and pCreateInfos->basePipelineIndex is not -1.",
3430 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003431 }
3432 }
3433
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003434 if (create_info.basePipelineHandle != VK_NULL_HANDLE) {
3435 if (create_info.basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003436 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003437 "vkCreateGraphicsPipelines parameter, pCreateInfos[%" PRIu32
3438 "]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003439 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003440 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
3441 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003442 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06003443 } else {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003444 if (static_cast<uint32_t>(create_info.basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003445 skip |=
3446 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003447 "vkCreateGraphicsPipelines parameter pCreateInfos[%" PRIu32 "]->basePipelineIndex (%" PRId32
3448 ") must be a valid"
3449 "index into the pCreateInfos array, of size %" PRIu32 ".",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003450 i, create_info.basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06003451 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003452 }
3453 }
3454
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003455 if (create_info.pRasterizationState) {
sfricke-samsung45996a42021-09-16 13:45:27 -07003456 if (!IsExtEnabled(device_extensions.vk_nv_fill_rectangle)) {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003457 if (create_info.pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
Chris Mayer840b2c42019-08-22 18:12:22 +02003458 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003459 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
3460 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
3461 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
3462 "if the extension VK_NV_fill_rectangle is not enabled.");
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003463 } else if ((create_info.pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Chris Mayer840b2c42019-08-22 18:12:22 +02003464 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07003465 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003466 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003467 "pCreateInfos[%" PRIu32
3468 "]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003469 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
3470 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02003471 }
3472 } else {
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003473 if ((create_info.pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
3474 (create_info.pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
Chris Mayer840b2c42019-08-22 18:12:22 +02003475 (physical_device_features.fillModeNonSolid == false)) {
3476 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003477 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
3478 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003479 "pCreateInfos[%" PRIu32
3480 "]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07003481 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
3482 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02003483 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003484 }
Petr Kraus299ba622017-11-24 03:09:03 +01003485
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003486 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003487 (create_info.pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003488 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
3489 "The line width state is static (pCreateInfos[%" PRIu32
3490 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
3491 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
3492 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
Nathaniel Cesario66ca3982022-03-01 15:51:11 -07003493 i, i, create_info.pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003494 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003495 }
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003496
3497 // Validate no flags not allowed are used
3498 if ((flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
sfricke-samsungad008902021-04-16 01:25:34 -07003499 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003500 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3501 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003502 "VK_PIPELINE_CREATE_DISPATCH_BASE.",
3503 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003504 }
Nathaniel Cesario81257cb2022-02-16 17:15:58 -07003505 if (!IsExtEnabled(device_extensions.vk_ext_graphics_pipeline_library) &&
3506 (flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
sfricke-samsungad008902021-04-16 01:25:34 -07003507 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03371",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003508 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3509 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003510 "VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.",
3511 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003512 }
3513 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
3514 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03372",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003515 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3516 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003517 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
3518 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003519 }
3520 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
3521 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03373",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003522 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3523 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003524 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
3525 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003526 }
3527 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
3528 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03374",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003529 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3530 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003531 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
3532 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003533 }
3534 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
3535 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03375",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003536 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3537 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003538 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
3539 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003540 }
3541 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
3542 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03376",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003543 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3544 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003545 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
3546 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003547 }
3548 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
3549 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03377",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003550 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3551 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003552 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
3553 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003554 }
3555 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
3556 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03577",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003557 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3558 "]->flags (0x%x) must not include "
sfricke-samsungad008902021-04-16 01:25:34 -07003559 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
3560 i, flags);
sfricke-samsung5ea45bd2021-01-23 02:38:36 -08003561 }
ziga-lunarg4bd42e42021-10-04 13:19:29 +02003562 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) != 0) {
3563 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-04947",
3564 "vkCreateGraphicsPipelines(): pCreateInfos[%" PRIu32
3565 "]->flags (0x%x) must not include "
3566 "VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV.",
3567 i, flags);
3568 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003569 }
3570 }
3571
3572 return skip;
3573}
3574
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003575bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
3576 uint32_t createInfoCount,
3577 const VkComputePipelineCreateInfo *pCreateInfos,
3578 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003579 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003580 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003581 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003582 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003583 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06003584 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003585 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04003586 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003587 skip |=
Tony-LunarGce3244a2021-11-19 12:33:40 -07003588 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfo-pipelineStageCreationFeedbackCount-02669",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003589 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
3590 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
3591 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04003592 }
sfricke-samsungc5227152020-02-09 17:36:31 -08003593
3594 // Make sure compute stage is selected
3595 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003596 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003597 "vkCreateComputePipelines(): the pCreateInfo[%" PRIu32
3598 "].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003599 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08003600 }
sourav parmarcd5fb182020-07-17 12:58:44 -07003601
sfricke-samsungeb549012021-04-16 01:25:51 -07003602 const VkPipelineCreateFlags flags = pCreateInfos[i].flags;
3603 // Validate no flags not allowed are used
3604 if ((flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) != 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003605 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03364",
3606 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3607 "]->flags (0x%x) must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.",
3608 i, flags);
sfricke-samsungeb549012021-04-16 01:25:51 -07003609 }
3610 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) != 0) {
3611 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03365",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003612 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3613 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003614 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.",
3615 i, flags);
3616 }
3617 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) != 0) {
3618 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03366",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003619 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3620 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003621 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.",
3622 i, flags);
3623 }
3624 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) != 0) {
3625 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03367",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003626 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3627 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003628 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.",
3629 i, flags);
3630 }
3631 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) != 0) {
3632 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03368",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003633 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3634 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003635 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.",
3636 i, flags);
3637 }
3638 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) != 0) {
3639 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03369",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003640 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3641 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003642 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.",
3643 i, flags);
3644 }
3645 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) != 0) {
3646 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03370",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003647 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3648 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003649 "VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.",
3650 i, flags);
3651 }
3652 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) != 0) {
3653 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03576",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003654 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3655 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003656 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.",
3657 i, flags);
3658 }
ziga-lunargf51e65f2021-07-18 23:51:57 +02003659 if ((flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) != 0) {
3660 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-04945",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003661 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3662 "]->flags (0x%x) must not include "
ziga-lunargf51e65f2021-07-18 23:51:57 +02003663 "VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV.",
3664 i, flags);
3665 }
sfricke-samsungeb549012021-04-16 01:25:51 -07003666 if ((flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) != 0) {
3667 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-02874",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07003668 "vkCreateComputePipelines(): pCreateInfos[%" PRIu32
3669 "]->flags (0x%x) must not include "
sfricke-samsungeb549012021-04-16 01:25:51 -07003670 "VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.",
3671 i, flags);
sourav parmarcd5fb182020-07-17 12:58:44 -07003672 }
ziga-lunarg065f2402021-07-22 11:56:05 +02003673 if (flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
3674 if (pCreateInfos[i].basePipelineIndex != -1) {
3675 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
3676 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-00699",
3677 "vkCreateComputePipelines parameter, pCreateInfos[%" PRIu32
3678 "]->basePipelineHandle, must be VK_NULL_HANDLE if pCreateInfos->flags contains the "
3679 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and pCreateInfos->basePipelineIndex is not -1.",
3680 i);
3681 }
3682 }
3683
3684 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
3685 if (pCreateInfos[i].basePipelineIndex != -1) {
3686 skip |= LogError(
3687 device, "VUID-VkComputePipelineCreateInfo-flags-00700",
3688 "vkCreateComputePipelines parameter, pCreateInfos[%" PRIu32
3689 "]->basePipelineIndex, must be -1 if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT "
3690 "flag and pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
3691 i);
3692 }
3693 } else {
3694 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
3695 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-flags-00698",
3696 "vkCreateComputePipelines parameter pCreateInfos[%" PRIu32 "]->basePipelineIndex (%" PRIi32
3697 ") must be a valid index into the pCreateInfos array, of size %" PRIu32 ".",
3698 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
3699 }
3700 }
3701 }
ziga-lunargc6341372021-07-28 12:57:42 +02003702
3703 std::stringstream msg;
3704 msg << "pCreateInfos[%" << i << "].stage";
3705 ValidatePipelineShaderStageCreateInfo("vkCreateComputePipelines", msg.str().c_str(), &pCreateInfos[i].stage);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003706 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003707 return skip;
3708}
3709
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003710bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003711 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003712 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003713
3714 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003715 const auto &features = physical_device_features;
3716 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003717
John Zulauf71968502017-10-26 13:51:15 -06003718 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
3719 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003720 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
3721 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
3722 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
3723 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06003724 }
3725
3726 // Anistropy cannot be enabled in sampler unless enabled as a feature
3727 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003728 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
3729 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
3730 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06003731 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003732 }
John Zulauf71968502017-10-26 13:51:15 -06003733
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003734 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
3735 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003736 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
3737 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3738 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3739 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003740 }
3741 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003742 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
3743 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3744 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3745 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003746 }
3747 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003748 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
3749 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3750 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
3751 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003752 }
3753 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
3754 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3755 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
3756 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003757 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
3758 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
3759 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
3760 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
3761 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3762 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003763 }
3764 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003765 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
3766 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
3767 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06003768 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003769 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003770 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
3771 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
3772 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07003773 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003774 }
3775
3776 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
3777 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003778 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
3779 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003780 const auto *sampler_reduction = LvlFindInChain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
sfricke-samsung85252fb2020-05-08 20:44:06 -07003781 if (sampler_reduction != nullptr) {
3782 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
3783 skip |= LogError(
3784 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
3785 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
3786 }
3787 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003788 }
3789
3790 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
3791 // valid VkBorderColor value
3792 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3793 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3794 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003795 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
3796 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003797 }
3798
John Zulauf275805c2017-10-26 15:34:49 -06003799 // Checks for the IMG cubic filtering extension
sfricke-samsung45996a42021-09-16 13:45:27 -07003800 if (IsExtEnabled(device_extensions.vk_img_filter_cubic)) {
John Zulauf275805c2017-10-26 15:34:49 -06003801 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
3802 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003803 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
3804 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
3805 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06003806 }
3807 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003808
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003809 // Check for valid Lod range
3810 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003811 skip |=
3812 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
3813 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003814 }
3815
3816 // Check mipLodBias to device limit
3817 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003818 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
3819 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
3820 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003821 }
3822
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003823 const auto *sampler_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003824 if (sampler_conversion != nullptr) {
3825 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3826 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3827 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3828 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003829 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003830 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003831 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
3832 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
3833 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
3834 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
3835 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
3836 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
3837 }
3838 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02003839
3840 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
3841 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
3842 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
3843 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3844 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3845 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
3846 }
3847 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
3848 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
3849 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3850 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3851 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
3852 }
3853 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
3854 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
3855 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3856 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
3857 pCreateInfo->minLod, pCreateInfo->maxLod);
3858 }
3859 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3860 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
3861 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3862 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
3863 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
3864 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3865 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
3866 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
3867 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3868 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
3869 }
3870 if (pCreateInfo->anisotropyEnable) {
3871 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
3872 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3873 "pCreateInfo->anisotropyEnable must be VK_FALSE");
3874 }
3875 if (pCreateInfo->compareEnable) {
3876 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
3877 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3878 "pCreateInfo->compareEnable must be VK_FALSE");
3879 }
3880 if (pCreateInfo->unnormalizedCoordinates) {
3881 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
3882 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3883 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
3884 }
3885 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003886
Piers Daniell833b9492021-11-20 11:47:10 -07003887 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
3888 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
3889 if (!IsExtEnabled(device_extensions.vk_ext_custom_border_color)) {
3890 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
3891 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
3892 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
3893 }
3894 auto custom_create_info = LvlFindInChain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
3895 if (!custom_create_info) {
3896 skip |= LogError(
3897 device, "VUID-VkSamplerCreateInfo-borderColor-04011",
3898 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
3899 "struct in pNext chain.\n",
3900 string_VkBorderColor(pCreateInfo->borderColor));
3901 } else {
3902 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
3903 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT &&
3904 !FormatIsSampledInt(custom_create_info->format)) ||
3905 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
3906 !FormatIsSampledFloat(custom_create_info->format)))) {
3907 skip |=
3908 LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
Tony-LunarG7337b312020-04-15 16:40:25 -06003909 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
3910 "whose type does not match\n",
3911 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
Piers Daniell833b9492021-11-20 11:47:10 -07003912 ;
3913 }
3914 }
3915 }
3916
3917 const auto *border_color_component_mapping =
3918 LvlFindInChain<VkSamplerBorderColorComponentMappingCreateInfoEXT>(pCreateInfo->pNext);
3919 if (border_color_component_mapping) {
3920 const auto *border_color_swizzle_features =
3921 LvlFindInChain<VkPhysicalDeviceBorderColorSwizzleFeaturesEXT>(device_createinfo_pnext);
3922 bool border_color_swizzle_features_enabled =
3923 border_color_swizzle_features && border_color_swizzle_features->borderColorSwizzle;
3924 if (!border_color_swizzle_features_enabled) {
3925 skip |= LogError(device, "VUID-VkSamplerBorderColorComponentMappingCreateInfoEXT-borderColorSwizzle-06437",
3926 "vkCreateSampler(): The borderColorSwizzle feature must be enabled to use "
3927 "VkPhysicalDeviceBorderColorSwizzleFeaturesEXT");
Tony-LunarG7337b312020-04-15 16:40:25 -06003928 }
3929 }
3930 }
3931
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003932 return skip;
3933}
3934
ziga-lunarg8a4d3192021-10-13 19:54:19 +02003935bool StatelessValidation::ValidateMutableDescriptorTypeCreateInfo(const VkDescriptorSetLayoutCreateInfo &create_info,
3936 const VkMutableDescriptorTypeCreateInfoVALVE &mutable_create_info,
3937 const char *func_name) const {
3938 bool skip = false;
3939
3940 for (uint32_t i = 0; i < create_info.bindingCount; ++i) {
3941 uint32_t mutable_type_count = 0;
3942 if (mutable_create_info.mutableDescriptorTypeListCount > i) {
3943 mutable_type_count = mutable_create_info.pMutableDescriptorTypeLists[i].descriptorTypeCount;
3944 }
3945 if (create_info.pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
3946 if (mutable_type_count == 0) {
3947 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-descriptorTypeCount-04597",
3948 "%s: VkDescriptorSetLayoutCreateInfo::pBindings[%" PRIu32
3949 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE, but "
3950 "VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3951 "].descriptorTypeCount is 0.",
3952 func_name, i, i);
3953 }
3954 } else {
3955 if (mutable_type_count > 0) {
3956 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-descriptorTypeCount-04599",
3957 "%s: VkDescriptorSetLayoutCreateInfo::pBindings[%" PRIu32
3958 "].descriptorType is %s, but "
3959 "VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3960 "].descriptorTypeCount is not 0.",
3961 func_name, i, string_VkDescriptorType(create_info.pBindings[i].descriptorType), i);
3962 }
3963 }
3964 }
3965
3966 for (uint32_t j = 0; j < mutable_create_info.mutableDescriptorTypeListCount; ++j) {
3967 for (uint32_t k = 0; k < mutable_create_info.pMutableDescriptorTypeLists[j].descriptorTypeCount; ++k) {
3968 switch (mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[k]) {
3969 case VK_DESCRIPTOR_TYPE_MUTABLE_VALVE:
3970 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04600",
3971 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3972 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE.",
3973 func_name, j, k);
3974 break;
3975 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
3976 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04601",
3977 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3978 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC.",
3979 func_name, j, k);
3980 break;
3981 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
3982 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04602",
3983 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3984 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC.",
3985 func_name, j, k);
3986 break;
3987 case VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT:
3988 skip |= LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04603",
3989 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
3990 "].pDescriptorTypes[%" PRIu32 "] is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT.",
3991 func_name, j, k);
3992 break;
3993 default:
3994 break;
3995 }
3996 for (uint32_t l = k + 1; l < mutable_create_info.pMutableDescriptorTypeLists[j].descriptorTypeCount; ++l) {
3997 if (mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[k] ==
3998 mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[l]) {
3999 skip |=
4000 LogError(device, "VUID-VkMutableDescriptorTypeListVALVE-pDescriptorTypes-04598",
4001 "%s: VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4002 "].pDescriptorTypes[%" PRIu32
4003 "] and VkMutableDescriptorTypeCreateInfoVALVE::pMutableDescriptorTypeLists[%" PRIu32
4004 "].pDescriptorTypes[%" PRIu32 "] are both %s.",
4005 func_name, j, k, j, l,
4006 string_VkDescriptorType(mutable_create_info.pMutableDescriptorTypeLists[j].pDescriptorTypes[k]));
4007 }
4008 }
4009 }
4010 }
4011
4012 return skip;
4013}
4014
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004015bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
4016 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
4017 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004018 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004019 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004020
ziga-lunargfc6896f2021-10-15 18:46:12 +02004021 const auto *mutable_descriptor_type = LvlFindInChain<VkMutableDescriptorTypeCreateInfoVALVE>(pCreateInfo->pNext);
4022 const auto *mutable_descriptor_type_features = LvlFindInChain<VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE>(device_createinfo_pnext);
4023 bool mutable_descriptor_type_features_enabled =
4024 mutable_descriptor_type_features && mutable_descriptor_type_features->mutableDescriptorType == VK_TRUE;
4025
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004026 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4027 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
4028 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
4029 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004030 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
4031 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
4032 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
4033 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
4034 ++descriptor_index) {
4035 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07004036 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004037 "vkCreateDescriptorSetLayout: required parameter "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004038 "pCreateInfo->pBindings[%" PRIu32 "].pImmutableSamplers[%" PRIu32
4039 "] specified as VK_NULL_HANDLE",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004040 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004041 }
4042 }
4043 }
4044
4045 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
4046 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
4047 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004048 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004049 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%" PRIu32
4050 "].descriptorCount is not 0, "
4051 "pCreateInfo->pBindings[%" PRIu32
4052 "].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004053 "values.",
4054 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004055 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07004056
4057 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
4058 (pCreateInfo->pBindings[i].stageFlags != 0) &&
4059 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004060 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
4061 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%" PRIu32
4062 "].descriptorCount is not 0 and "
4063 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%" PRIu32
4064 "].stageFlags "
4065 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
4066 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
Spencer Fricke84d0cc02020-03-16 17:21:59 -07004067 }
ziga-lunargfc6896f2021-10-15 18:46:12 +02004068
4069 if (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
4070 if (!mutable_descriptor_type) {
4071 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-descriptorType-04593",
4072 "vkCreateDescriptorSetLayout(): pCreateInfo->pBindings[%" PRIu32
4073 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE but "
4074 "VkMutableDescriptorTypeCreateInfoVALVE is not included in the pNext chain.",
4075 i);
4076 }
4077 if (pCreateInfo->pBindings[i].pImmutableSamplers) {
4078 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-descriptorType-04594",
4079 "vkCreateDescriptorSetLayout(): pCreateInfo->pBindings[%" PRIu32
4080 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE but "
4081 "pImmutableSamplers is not NULL.",
4082 i);
4083 }
4084 if (!mutable_descriptor_type_features_enabled) {
4085 skip |= LogError(
4086 device, "VUID-VkDescriptorSetLayoutCreateInfo-mutableDescriptorType-04595",
4087 "vkCreateDescriptorSetLayout(): pCreateInfo->pBindings[%" PRIu32
4088 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE but "
4089 "VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType feature is not enabled.",
4090 i);
4091 }
4092 }
4093
4094 if (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR &&
4095 pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
4096 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04591",
4097 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains "
4098 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR, but pCreateInfo->pBindings[%" PRIu32
4099 "].descriptorType is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE.", i);
4100 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004101 }
4102 }
ziga-lunarg8a4d3192021-10-13 19:54:19 +02004103
4104 if (mutable_descriptor_type) {
4105 ValidateMutableDescriptorTypeCreateInfo(*pCreateInfo, *mutable_descriptor_type,
4106 "vkDescriptorSetLayoutCreateInfo");
4107 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004108 }
ziga-lunargfc6896f2021-10-15 18:46:12 +02004109 if (pCreateInfo) {
4110 if ((pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR) &&
4111 (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE)) {
4112 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04590",
4113 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains both "
4114 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR and "
4115 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE.");
4116 }
4117 if ((pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT) &&
4118 (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE)) {
4119 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04592",
4120 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains both "
4121 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT and "
4122 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE.");
4123 }
4124 if (pCreateInfo->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE &&
4125 !mutable_descriptor_type_features_enabled) {
4126 skip |= LogError(device, "VUID-VkDescriptorSetLayoutCreateInfo-flags-04596",
4127 "vkCreateDescriptorSetLayout(): pCreateInfo->flags contains "
4128 "VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE, but "
4129 "VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType feature is not enabled.");
4130 }
4131 }
4132
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004133 return skip;
4134}
4135
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004136bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
4137 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004138 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004139 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4140 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
4141 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004142 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
4143 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004144}
4145
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004146bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
4147 const VkWriteDescriptorSet *pDescriptorWrites,
Mike Schuchardt979898a2022-01-11 10:46:59 -08004148 const bool isPushDescriptor) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004149 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004150
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004151 if (pDescriptorWrites != NULL) {
4152 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
4153 // descriptorCount must be greater than 0
4154 if (pDescriptorWrites[i].descriptorCount == 0) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004155 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
4156 "%s(): parameter pDescriptorWrites[%" PRIu32 "].descriptorCount must be greater than 0.",
4157 vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004158 }
4159
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004160 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
Mike Schuchardt979898a2022-01-11 10:46:59 -08004161 if (!isPushDescriptor) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004162 // dstSet must be a valid VkDescriptorSet handle
4163 skip |= validate_required_handle(vkCallingFunction,
4164 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
4165 pDescriptorWrites[i].dstSet);
4166 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004167
4168 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
4169 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
4170 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
4171 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
4172 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004173 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mike Schuchardt979898a2022-01-11 10:46:59 -08004174 if (!isPushDescriptor) {
4175 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
4176 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or
4177 // VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pImageInfo must be a pointer to an array of descriptorCount valid
4178 // VkDescriptorImageInfo structures. Valid imageView handles are checked in
4179 // ObjectLifetimes::ValidateDescriptorWrite.
4180 skip |= LogError(
4181 device, "VUID-vkUpdateDescriptorSets-pDescriptorWrites-06493",
4182 "%s(): if pDescriptorWrites[%" PRIu32
4183 "].descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
4184 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
4185 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%" PRIu32 "].pImageInfo must not be NULL.",
4186 vkCallingFunction, i, i);
4187 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
4188 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
4189 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
4190 // If called from vkCmdPushDescriptorSetKHR, pImageInfo is only requred for descriptor types
4191 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, and
4192 // VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT
4193 skip |= LogError(device, "VUID-vkCmdPushDescriptorSetKHR-pDescriptorWrites-06494",
4194 "%s(): if pDescriptorWrites[%" PRIu32
4195 "].descriptorType is VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE "
4196 "or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%" PRIu32
4197 "].pImageInfo must not be NULL.",
4198 vkCallingFunction, i, i);
4199 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004200 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
4201 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05004202 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
4203 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004204 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
4205 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004206 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004207 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
4208 ParameterName::IndexVector{i, descriptor_index}),
4209 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06004210 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004211 }
4212 }
4213 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
4214 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
4215 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
4216 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
4217 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
4218 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
4219 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05004220 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004221 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004222 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004223 "%s(): if pDescriptorWrites[%" PRIu32
4224 "].descriptorType is "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004225 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
4226 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004227 "pDescriptorWrites[%" PRIu32 "].pBufferInfo must not be NULL.",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004228 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004229 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05004230 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004231 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05004232 if (robustness2_features && robustness2_features->nullDescriptor) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004233 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
4234 ++descriptor_index) {
4235 if (pDescriptorWrites[i].pBufferInfo[descriptor_index].buffer == VK_NULL_HANDLE &&
4236 (pDescriptorWrites[i].pBufferInfo[descriptor_index].offset != 0 ||
4237 pDescriptorWrites[i].pBufferInfo[descriptor_index].range != VK_WHOLE_SIZE)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05004238 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004239 "%s(): if pDescriptorWrites[%" PRIu32
4240 "].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01004241 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004242 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptor_index].offset,
4243 pDescriptorWrites[i].pBufferInfo[descriptor_index].range);
Jeff Bolz165818a2020-05-08 11:19:03 -05004244 }
4245 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004246 }
4247 }
4248 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
4249 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05004250 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004251 }
4252
4253 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
4254 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004255 VkDeviceSize uniform_alignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004256 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
4257 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004258 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06004259 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004260 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004261 "%s(): pDescriptorWrites[%" PRIu32 "].pBufferInfo[%" PRIu32 "].offset (0x%" PRIxLEAST64
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004262 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004263 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004264 }
4265 }
4266 }
4267 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
4268 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004269 VkDeviceSize storage_alignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004270 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
4271 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004272 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06004273 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004274 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004275 "%s(): pDescriptorWrites[%" PRIu32 "].pBufferInfo[%" PRIu32 "].offset (0x%" PRIxLEAST64
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004276 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004277 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004278 }
4279 }
4280 }
4281 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004282 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
4283 // or VkWriteDescriptorSetInlineUniformBlockEX
sourav parmarbcee7512020-12-28 14:34:49 -08004284 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004285 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08004286 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
4287 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
4288 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
4289 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004290 "accelerationStructureCount %" PRIu32 " member equals descriptorCount %" PRIu32 ".",
sourav parmarbcee7512020-12-28 14:34:49 -08004291 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
4292 pDescriptorWrites[i].descriptorCount);
4293 }
4294 // further checks only if we have right structtype
4295 if (pnext_struct) {
4296 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
4297 skip |= LogError(
4298 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004299 "%s(): accelerationStructureCount %" PRIu32 " must be equal to descriptorCount %" PRIu32
4300 " in the extended structure "
sourav parmarbcee7512020-12-28 14:34:49 -08004301 ".",
4302 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07004303 }
sourav parmarbcee7512020-12-28 14:34:49 -08004304 if (pnext_struct->accelerationStructureCount == 0) {
4305 skip |= LogError(device,
4306 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004307 "%s(): accelerationStructureCount must be greater than 0 .", vkCallingFunction);
sourav parmarbcee7512020-12-28 14:34:49 -08004308 }
4309 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004310 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08004311 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
4312 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
4313 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
4314 skip |= LogError(device,
4315 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-pAccelerationStructures-03580",
4316 "%s(): If the nullDescriptor feature is not enabled, each member of "
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004317 "pAccelerationStructures must not be VK_NULL_HANDLE.", vkCallingFunction);
sourav parmarcd5fb182020-07-17 12:58:44 -07004318 }
4319 }
4320 }
sourav parmarbcee7512020-12-28 14:34:49 -08004321 }
4322 } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004323 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureNV>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08004324 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
4325 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-03817",
4326 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV, the pNext"
4327 "chain must include a VkWriteDescriptorSetAccelerationStructureNV structure whose "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004328 "accelerationStructureCount %" PRIu32 " member equals descriptorCount %" PRIu32 ".",
sourav parmarbcee7512020-12-28 14:34:49 -08004329 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
4330 pDescriptorWrites[i].descriptorCount);
4331 }
4332 // further checks only if we have right structtype
4333 if (pnext_struct) {
4334 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
4335 skip |= LogError(
4336 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-03747",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004337 "%s(): accelerationStructureCount %" PRIu32 " must be equal to descriptorCount %" PRIu32
4338 " in the extended structure "
sourav parmarbcee7512020-12-28 14:34:49 -08004339 ".",
4340 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmarcd5fb182020-07-17 12:58:44 -07004341 }
sourav parmarbcee7512020-12-28 14:34:49 -08004342 if (pnext_struct->accelerationStructureCount == 0) {
4343 skip |= LogError(device,
4344 "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-arraylength",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004345 "%s(): accelerationStructureCount must be greater than 0 .", vkCallingFunction);
sourav parmarbcee7512020-12-28 14:34:49 -08004346 }
4347 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004348 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08004349 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
4350 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
4351 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
4352 skip |= LogError(device,
4353 "VUID-VkWriteDescriptorSetAccelerationStructureNV-pAccelerationStructures-03749",
4354 "%s(): If the nullDescriptor feature is not enabled, each member of "
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06004355 "pAccelerationStructures must not be VK_NULL_HANDLE.", vkCallingFunction);
sourav parmarcd5fb182020-07-17 12:58:44 -07004356 }
4357 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004358 }
4359 }
4360 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004361 }
4362 }
4363 return skip;
4364}
4365
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004366bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
4367 const VkWriteDescriptorSet *pDescriptorWrites,
4368 uint32_t descriptorCopyCount,
4369 const VkCopyDescriptorSet *pDescriptorCopies) const {
Mike Schuchardt979898a2022-01-11 10:46:59 -08004370 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites, false);
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004371}
4372
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004373bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004374 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004375 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004376 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
4377}
4378
sfricke-samsung681ab7b2020-10-29 01:53:35 -07004379bool StatelessValidation::manual_PreCallValidateCreateRenderPass2(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
4380 const VkAllocationCallbacks *pAllocator,
4381 VkRenderPass *pRenderPass) const {
4382 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
4383}
4384
Mike Schuchardt2df08912020-12-15 16:28:09 -08004385bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004386 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004387 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004388 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
4389}
4390
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004391bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
4392 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004393 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004394 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004395
4396 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4397 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
4398 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004399 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
4400 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004401 return skip;
4402}
4403
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004404bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004405 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004406 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02004407
4408 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
4409 const char *cmd_name = "vkBeginCommandBuffer";
Tony-LunarG3c287f62020-12-17 12:39:49 -07004410 bool cb_is_secondary;
4411 {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06004412 auto lock = CBReadLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07004413 cb_is_secondary = (secondary_cb_map.find(commandBuffer) != secondary_cb_map.end());
4414 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004415
Tony-LunarG3c287f62020-12-17 12:39:49 -07004416 if (cb_is_secondary) {
4417 // Implicit VUs
4418 // validate only sType here; pointer has to be validated in core_validation
4419 const bool k_not_required = false;
4420 const char *k_no_vuid = nullptr;
4421 const VkCommandBufferInheritanceInfo *info = pBeginInfo->pInheritanceInfo;
4422 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004423 info, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, k_not_required, k_no_vuid,
4424 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004425
Tony-LunarG3c287f62020-12-17 12:39:49 -07004426 if (info) {
4427 const VkStructureType allowed_structs_vk_command_buffer_inheritance_info[] = {
David Zhao Akeley44139b12021-04-26 16:16:13 -07004428 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT,
amhagana448ea52021-11-02 14:09:14 -04004429 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_RENDERING_INFO_KHR,
4430 VK_STRUCTURE_TYPE_ATTACHMENT_SAMPLE_COUNT_INFO_AMD,
David Zhao Akeley44139b12021-04-26 16:16:13 -07004431 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_VIEWPORT_SCISSOR_INFO_NV};
Tony-LunarG3c287f62020-12-17 12:39:49 -07004432 skip |= validate_struct_pnext(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004433 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT",
4434 info->pNext, ARRAY_SIZE(allowed_structs_vk_command_buffer_inheritance_info),
4435 allowed_structs_vk_command_buffer_inheritance_info, GeneratedVulkanHeaderVersion,
4436 "VUID-VkCommandBufferInheritanceInfo-pNext-pNext", "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004437
Tony-LunarG3c287f62020-12-17 12:39:49 -07004438 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", info->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004439
Tony-LunarG3c287f62020-12-17 12:39:49 -07004440 // Explicit VUs
4441 if (!physical_device_features.inheritedQueries && info->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004442 skip |= LogError(
Tony-LunarG3c287f62020-12-17 12:39:49 -07004443 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
4444 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
4445 cmd_name);
4446 }
4447
4448 if (physical_device_features.inheritedQueries) {
4449 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004450 AllVkQueryControlFlagBits, info->queryFlags, kOptionalFlags,
4451 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
4452 } else { // !inheritedQueries
Tony-LunarG3c287f62020-12-17 12:39:49 -07004453 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", info->queryFlags,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004454 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Tony-LunarG3c287f62020-12-17 12:39:49 -07004455 }
4456
4457 if (physical_device_features.pipelineStatisticsQuery) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004458 skip |=
4459 validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
4460 AllVkQueryPipelineStatisticFlagBits, info->pipelineStatistics, kOptionalFlags,
4461 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
4462 } else { // !pipelineStatisticsQuery
4463 skip |=
4464 validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", info->pipelineStatistics,
4465 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Tony-LunarG3c287f62020-12-17 12:39:49 -07004466 }
4467
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004468 const auto *conditional_rendering = LvlFindInChain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(info->pNext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07004469 if (conditional_rendering) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004470 const auto *cr_features = LvlFindInChain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07004471 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
4472 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
4473 skip |= LogError(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004474 commandBuffer,
4475 "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Tony-LunarG3c287f62020-12-17 12:39:49 -07004476 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
4477 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
4478 }
Petr Kraus139757b2019-08-15 17:19:33 +02004479 }
ziga-lunarg9d019132021-07-19 01:05:31 +02004480
4481 auto p_inherited_viewport_scissor_info = LvlFindInChain<VkCommandBufferInheritanceViewportScissorInfoNV>(info->pNext);
4482 if (p_inherited_viewport_scissor_info != nullptr && !physical_device_features.multiViewport &&
4483 p_inherited_viewport_scissor_info->viewportScissor2D == VK_TRUE &&
4484 p_inherited_viewport_scissor_info->viewportDepthCount != 1) {
4485 skip |= LogError(commandBuffer, "VUID-VkCommandBufferInheritanceViewportScissorInfoNV-viewportScissor2D-04783",
4486 "vkBeginCommandBuffer: multiViewport feature is disabled, but "
4487 "VkCommandBufferInheritanceViewportScissorInfoNV::viewportScissor2D in "
4488 "pBeginInfo->pInheritanceInfo->pNext is VK_TRUE and viewportDepthCount is not 1.");
4489 }
Petr Kraus139757b2019-08-15 17:19:33 +02004490 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004491 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004492 return skip;
4493}
4494
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004495bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004496 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004497 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004498
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004499 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01004500 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004501 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
4502 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
4503 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01004504 }
4505 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004506 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
4507 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
4508 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01004509 }
4510 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01004511 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004512 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004513 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
4514 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4515 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4516 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004517 }
4518 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01004519
4520 if (pViewports) {
4521 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
4522 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06004523 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004524 skip |= manual_PreCallValidateViewport(
4525 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01004526 }
4527 }
4528
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004529 return skip;
4530}
4531
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004532bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004533 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004534 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004535
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004536 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004537 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004538 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
4539 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
4540 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004541 }
4542 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004543 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
4544 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
4545 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004546 }
4547 } else { // multiViewport enabled
4548 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004549 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004550 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
4551 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4552 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4553 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004554 }
4555 }
4556
Petr Kraus6260f0a2018-02-27 21:15:55 +01004557 if (pScissors) {
4558 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
4559 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004560
Petr Kraus6260f0a2018-02-27 21:15:55 +01004561 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004562 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
4563 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
4564 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004565 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004566
Petr Kraus6260f0a2018-02-27 21:15:55 +01004567 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004568 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
4569 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
4570 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004571 }
4572
4573 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
4574 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004575 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
4576 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4577 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4578 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004579 }
4580
4581 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
4582 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004583 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
4584 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4585 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4586 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01004587 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004588 }
4589 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01004590
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004591 return skip;
4592}
4593
Jeff Bolz5c801d12019-10-09 10:38:45 -05004594bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01004595 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01004596
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004597 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004598 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
4599 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01004600 }
4601
4602 return skip;
4603}
4604
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004605bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004606 uint32_t drawCount, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004607 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004608
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004609 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski41ce65b2020-10-30 12:17:06 -06004610 skip |= LogError(device, "VUID-vkCmdDrawIndirect-drawCount-02718",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004611 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %" PRIu32 "",
4612 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004613 }
4614 if (drawCount > device_limits.maxDrawIndirectCount) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004615 skip |=
4616 LogError(commandBuffer, "VUID-vkCmdDrawIndirect-drawCount-02719",
4617 "CmdDrawIndirect(): drawCount (%" PRIu32 ") is not less than or equal to the maximum allowed (%" PRIu32 ").",
4618 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004619 }
4620 return skip;
4621}
4622
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004623bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004624 VkDeviceSize offset, uint32_t drawCount,
4625 uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004626 bool skip = false;
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004627 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004628 skip |=
4629 LogError(device, "VUID-vkCmdDrawIndexedIndirect-drawCount-02718",
4630 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %" PRIu32 "",
4631 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004632 }
4633 if (drawCount > device_limits.maxDrawIndirectCount) {
4634 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirect-drawCount-02719",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004635 "CmdDrawIndexedIndirect(): drawCount (%" PRIu32
4636 ") is not less than or equal to the maximum allowed (%" PRIu32 ").",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004637 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004638 }
4639 return skip;
4640}
4641
sfricke-samsungf692b972020-05-02 08:00:45 -07004642bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
4643 VkDeviceSize countBufferOffset, bool khr) const {
4644 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004645 const char *api_name = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07004646 if (offset & 3) {
4647 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004648 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07004649 }
4650
4651 if (countBufferOffset & 3) {
4652 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004653 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07004654 countBufferOffset);
4655 }
4656 return skip;
4657}
4658
4659bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
4660 VkDeviceSize offset, VkBuffer countBuffer,
4661 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
4662 uint32_t stride) const {
4663 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
4664}
4665
4666bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
4667 VkDeviceSize offset, VkBuffer countBuffer,
4668 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
4669 uint32_t stride) const {
4670 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
4671}
4672
4673bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
4674 VkDeviceSize countBufferOffset, bool khr) const {
4675 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004676 const char *api_name = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07004677 if (offset & 3) {
4678 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004679 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07004680 }
4681
4682 if (countBufferOffset & 3) {
4683 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004684 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07004685 countBufferOffset);
4686 }
4687 return skip;
4688}
4689
4690bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
4691 VkDeviceSize offset, VkBuffer countBuffer,
4692 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
4693 uint32_t stride) const {
4694 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
4695}
4696
4697bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
4698 VkDeviceSize offset, VkBuffer countBuffer,
4699 VkDeviceSize countBufferOffset,
4700 uint32_t maxDrawCount, uint32_t stride) const {
4701 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
4702}
4703
Tony-LunarG4490de42021-06-21 15:49:19 -06004704bool StatelessValidation::manual_PreCallValidateCmdDrawMultiEXT(VkCommandBuffer commandBuffer, uint32_t drawCount,
4705 const VkMultiDrawInfoEXT *pVertexInfo, uint32_t instanceCount,
4706 uint32_t firstInstance, uint32_t stride) const {
4707 bool skip = false;
4708 if (stride & 3) {
4709 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiEXT-stride-04936",
4710 "CmdDrawMultiEXT: parameter, uint32_t stride (%" PRIu32 ") is not a multiple of 4.", stride);
4711 }
4712 if (drawCount && nullptr == pVertexInfo) {
4713 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiEXT-drawCount-04935",
4714 "CmdDrawMultiEXT: parameter, VkMultiDrawInfoEXT *pVertexInfo must be a valid pointer to memory containing "
4715 "one or more valid instances of VkMultiDrawInfoEXT structures");
4716 }
4717 return skip;
4718}
4719
4720bool StatelessValidation::manual_PreCallValidateCmdDrawMultiIndexedEXT(VkCommandBuffer commandBuffer, uint32_t drawCount,
4721 const VkMultiDrawIndexedInfoEXT *pIndexInfo,
4722 uint32_t instanceCount, uint32_t firstInstance,
4723 uint32_t stride, const int32_t *pVertexOffset) const {
4724 bool skip = false;
4725 if (stride & 3) {
4726 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiIndexedEXT-stride-04941",
4727 "CmdDrawMultiIndexedEXT: parameter, uint32_t stride (%" PRIu32 ") is not a multiple of 4.", stride);
4728 }
4729 if (drawCount && nullptr == pIndexInfo) {
4730 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMultiIndexedEXT-drawCount-04940",
4731 "CmdDrawMultiIndexedEXT: parameter, VkMultiDrawIndexedInfoEXT *pIndexInfo must be a valid pointer to "
4732 "memory containing one or more valid instances of VkMultiDrawIndexedInfoEXT structures");
4733 }
4734 return skip;
4735}
4736
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004737bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
4738 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004739 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004740 bool skip = false;
4741 for (uint32_t rect = 0; rect < rectCount; rect++) {
4742 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004743 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004744 "CmdClearAttachments(): pRects[%" PRIu32 "].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004745 }
sfricke-samsung10867682020-04-25 02:20:39 -07004746 if (pRects[rect].rect.extent.width == 0) {
4747 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004748 "CmdClearAttachments(): pRects[%" PRIu32 "].rect.extent.width is zero.", rect);
sfricke-samsung10867682020-04-25 02:20:39 -07004749 }
4750 if (pRects[rect].rect.extent.height == 0) {
4751 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004752 "CmdClearAttachments(): pRects[%" PRIu32 "].rect.extent.height is zero.", rect);
sfricke-samsung10867682020-04-25 02:20:39 -07004753 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06004754 }
4755 return skip;
4756}
4757
Andrew Fobel3abeb992020-01-20 16:33:22 -05004758bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
4759 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4760 VkImageFormatProperties2 *pImageFormatProperties,
4761 const char *apiName) const {
4762 bool skip = false;
4763
4764 if (pImageFormatInfo != nullptr) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004765 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pImageFormatInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05004766 if (image_stencil_struct != nullptr) {
4767 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
4768 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
4769 // No flags other than the legal attachment bits may be set
4770 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
4771 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004772 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
4773 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
4774 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
4775 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
4776 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05004777 }
4778 }
4779 }
ziga-lunargd3da2532021-08-11 11:50:12 +02004780 const auto image_drm_format = LvlFindInChain<VkPhysicalDeviceImageDrmFormatModifierInfoEXT>(pImageFormatInfo->pNext);
4781 if (image_drm_format) {
4782 if (pImageFormatInfo->tiling != VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4783 skip |= LogError(
4784 physicalDevice, "VUID-VkPhysicalDeviceImageFormatInfo2-tiling-02249",
4785 "%s(): pNext chain of VkPhysicalDeviceImageFormatInfo2 includes VkPhysicalDeviceImageDrmFormatModifierInfoEXT, "
4786 "but tiling (%s) is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.",
4787 apiName, string_VkImageTiling(pImageFormatInfo->tiling));
4788 }
ziga-lunarg27e256d2021-10-07 23:38:12 +02004789 if (image_drm_format->sharingMode == VK_SHARING_MODE_CONCURRENT && image_drm_format->queueFamilyIndexCount <= 1) {
4790 skip |= LogError(
4791 physicalDevice, "VUID-VkPhysicalDeviceImageDrmFormatModifierInfoEXT-sharingMode-02315",
4792 "%s: pNext chain of VkPhysicalDeviceImageFormatInfo2 includes VkPhysicalDeviceImageDrmFormatModifierInfoEXT, "
4793 "with sharing mode VK_SHARING_MODE_CONCURRENT, but queueFamilyIndexCount is %" PRIu32 ".",
4794 apiName, image_drm_format->queueFamilyIndexCount);
4795 }
ziga-lunargd3da2532021-08-11 11:50:12 +02004796 } else {
4797 if (pImageFormatInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4798 skip |= LogError(
4799 physicalDevice, "VUID-VkPhysicalDeviceImageFormatInfo2-tiling-02249",
4800 "%s(): pNext chain of VkPhysicalDeviceImageFormatInfo2 does not include "
4801 "VkPhysicalDeviceImageDrmFormatModifierInfoEXT, but tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.",
4802 apiName);
4803 }
4804 }
4805 if (pImageFormatInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT &&
4806 (pImageFormatInfo->flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT)) {
4807 const auto format_list = LvlFindInChain<VkImageFormatListCreateInfo>(pImageFormatInfo->pNext);
4808 if (!format_list || format_list->viewFormatCount == 0) {
4809 skip |= LogError(
4810 physicalDevice, "VUID-VkPhysicalDeviceImageFormatInfo2-tiling-02313",
4811 "%s(): tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT and flags contain VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT "
4812 "bit, but the pNext chain does not include VkImageFormatListCreateInfo with non-zero viewFormatCount.",
4813 apiName);
4814 }
4815 }
Andrew Fobel3abeb992020-01-20 16:33:22 -05004816 }
4817
4818 return skip;
4819}
4820
4821bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
4822 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4823 VkImageFormatProperties2 *pImageFormatProperties) const {
4824 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
4825 "vkGetPhysicalDeviceImageFormatProperties2");
4826}
4827
4828bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
4829 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
4830 VkImageFormatProperties2 *pImageFormatProperties) const {
4831 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
4832 "vkGetPhysicalDeviceImageFormatProperties2KHR");
4833}
4834
Lionel Landwerlin5fe52752020-07-22 08:18:14 +03004835bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties(
4836 VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage,
4837 VkImageCreateFlags flags, VkImageFormatProperties *pImageFormatProperties) const {
4838 bool skip = false;
4839
4840 if (tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
4841 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceImageFormatProperties-tiling-02248",
4842 "vkGetPhysicalDeviceImageFormatProperties(): tiling must not be VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.");
4843 }
4844
4845 return skip;
4846}
4847
ziga-lunarg73b5ef22021-07-29 20:25:06 +02004848bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceVideoFormatPropertiesKHR(
4849 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceVideoFormatInfoKHR *pVideoFormatInfo,
4850 uint32_t *pVideoFormatPropertyCount, VkVideoFormatPropertiesKHR *pVideoFormatProperties) const {
4851 bool skip = false;
4852
4853 if ((pVideoFormatInfo->imageUsage & (VK_IMAGE_USAGE_VIDEO_DECODE_DST_BIT_KHR | VK_IMAGE_USAGE_VIDEO_DECODE_DPB_BIT_KHR |
4854 VK_IMAGE_USAGE_VIDEO_ENCODE_SRC_BIT_KHR | VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR)) == 0) {
4855 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceVideoFormatPropertiesKHR-imageUsage-04844",
4856 "vkGetPhysicalDeviceVideoFormatPropertiesKHR(): pVideoFormatInfo->imageUsage does not contain any of "
4857 "VK_IMAGE_USAGE_VIDEO_DECODE_DST_BIT_KHR, VK_IMAGE_USAGE_VIDEO_DECODE_DPB_BIT_KHR, "
4858 "VK_IMAGE_USAGE_VIDEO_ENCODE_SRC_BIT_KHR, or VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR.");
4859 }
4860
ziga-lunarg42f884b2021-08-25 16:13:20 +02004861 return skip;
ziga-lunarg73b5ef22021-07-29 20:25:06 +02004862}
4863
sfricke-samsung3999ef62020-02-09 17:05:59 -08004864bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
4865 uint32_t regionCount, const VkBufferCopy *pRegions) const {
4866 bool skip = false;
4867
4868 if (pRegions != nullptr) {
4869 for (uint32_t i = 0; i < regionCount; i++) {
4870 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004871 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004872 "vkCmdCopyBuffer() pRegions[%" PRIu32 "].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08004873 }
4874 }
4875 }
4876 return skip;
4877}
4878
Jeff Leger178b1e52020-10-05 12:22:23 -04004879bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2KHR(VkCommandBuffer commandBuffer,
4880 const VkCopyBufferInfo2KHR *pCopyBufferInfo) const {
4881 bool skip = false;
4882
4883 if (pCopyBufferInfo->pRegions != nullptr) {
4884 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
4885 if (pCopyBufferInfo->pRegions[i].size == 0) {
Tony-LunarGef035472021-11-02 10:23:33 -06004886 skip |= LogError(device, "VUID-VkBufferCopy2-size-01988",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004887 "vkCmdCopyBuffer2KHR() pCopyBufferInfo->pRegions[%" PRIu32 "].size must be greater than zero", i);
Jeff Leger178b1e52020-10-05 12:22:23 -04004888 }
4889 }
4890 }
4891 return skip;
4892}
4893
Tony-LunarGef035472021-11-02 10:23:33 -06004894bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2(VkCommandBuffer commandBuffer,
4895 const VkCopyBufferInfo2 *pCopyBufferInfo) const {
4896 bool skip = false;
4897
4898 if (pCopyBufferInfo->pRegions != nullptr) {
4899 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
4900 if (pCopyBufferInfo->pRegions[i].size == 0) {
4901 skip |= LogError(device, "VUID-VkBufferCopy2-size-01988",
4902 "vkCmdCopyBuffer2() pCopyBufferInfo->pRegions[%" PRIu32 "].size must be greater than zero", i);
4903 }
4904 }
4905 }
4906 return skip;
4907}
4908
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004909bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004910 VkDeviceSize dstOffset, VkDeviceSize dataSize,
4911 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004912 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004913
4914 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004915 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
4916 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4917 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004918 }
4919
4920 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004921 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
4922 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
4923 "), must be greater than zero and less than or equal to 65536.",
4924 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004925 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004926 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
4927 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4928 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004929 }
4930 return skip;
4931}
4932
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004933bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004934 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004935 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004936
4937 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004938 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
4939 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
4940 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004941 }
4942
4943 if (size != VK_WHOLE_SIZE) {
4944 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004945 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004946 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
4947 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004948 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004949 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
4950 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004951 }
4952 }
4953 return skip;
4954}
4955
sfricke-samsunga1d00272021-03-10 21:37:41 -08004956bool StatelessValidation::ValidateSwapchainCreateInfo(const char *func_name, VkSwapchainCreateInfoKHR const *pCreateInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004957 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004958
4959 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004960 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4961 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
4962 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
4963 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004964 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004965 "%s: if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
4966 "pCreateInfo->queueFamilyIndexCount must be greater than 1.",
4967 func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004968 }
4969
4970 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
4971 // queueFamilyIndexCount uint32_t values
4972 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004973 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004974 "%s: if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004975 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
sfricke-samsunga1d00272021-03-10 21:37:41 -08004976 "pCreateInfo->queueFamilyIndexCount uint32_t values.",
4977 func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004978 }
4979 }
4980
Dave Houlton413a6782018-05-22 13:01:54 -06004981 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004982 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", func_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004983
sfricke-samsunga1d00272021-03-10 21:37:41 -08004984 // Validate VK_KHR_image_format_list VkImageFormatListCreateInfo
4985 const auto format_list_info = LvlFindInChain<VkImageFormatListCreateInfo>(pCreateInfo->pNext);
4986 if (format_list_info) {
4987 const uint32_t viewFormatCount = format_list_info->viewFormatCount;
4988 if (((pCreateInfo->flags & VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR) == 0) && (viewFormatCount > 1)) {
4989 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-flags-04100",
4990 "%s: If the VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR is not set, then "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07004991 "VkImageFormatListCreateInfo::viewFormatCount (%" PRIu32
4992 ") must be 0 or 1 if it is in the pNext chain.",
sfricke-samsunga1d00272021-03-10 21:37:41 -08004993 func_name, viewFormatCount);
4994 }
4995
4996 // Using the first format, compare the rest of the formats against it that they are compatible
4997 for (uint32_t i = 1; i < viewFormatCount; i++) {
4998 if (FormatCompatibilityClass(format_list_info->pViewFormats[0]) !=
4999 FormatCompatibilityClass(format_list_info->pViewFormats[i])) {
5000 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-pNext-04099",
5001 "%s: VkImageFormatListCreateInfo::pViewFormats[0] (%s) and "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005002 "VkImageFormatListCreateInfo::pViewFormats[%" PRIu32
5003 "] (%s) are not compatible in the pNext chain.",
sfricke-samsunga1d00272021-03-10 21:37:41 -08005004 func_name, string_VkFormat(format_list_info->pViewFormats[0]), i,
5005 string_VkFormat(format_list_info->pViewFormats[i]));
5006 }
5007 }
5008 }
5009
5010 // Validate VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR
5011 if ((pCreateInfo->flags & VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR) != 0) {
5012 if (!IsExtEnabled(device_extensions.vk_khr_swapchain_mutable_format)) {
5013 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
5014 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR which requires the "
5015 "VK_KHR_swapchain_mutable_format extension, which has not been enabled.",
5016 func_name);
5017 } else {
5018 if (format_list_info == nullptr) {
5019 skip |= LogError(
5020 device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
5021 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but the pNext chain of "
5022 "pCreateInfo does not contain an instance of VkImageFormatListCreateInfo.",
5023 func_name);
5024 } else if (format_list_info->viewFormatCount == 0) {
5025 skip |= LogError(
5026 device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
5027 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but the viewFormatCount "
5028 "member of VkImageFormatListCreateInfo in the pNext chain is zero.",
5029 func_name);
5030 } else {
5031 bool found_base_format = false;
5032 for (uint32_t i = 0; i < format_list_info->viewFormatCount; ++i) {
5033 if (format_list_info->pViewFormats[i] == pCreateInfo->imageFormat) {
5034 found_base_format = true;
5035 break;
5036 }
5037 }
5038 if (!found_base_format) {
5039 skip |=
5040 LogError(device, "VUID-VkSwapchainCreateInfoKHR-flags-03168",
5041 "%s: pCreateInfo->flags contains VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR but none of the "
5042 "elements of the pViewFormats member of VkImageFormatListCreateInfo match "
5043 "pCreateInfo->imageFormat.",
5044 func_name);
5045 }
5046 }
5047 }
5048 }
5049 }
5050 return skip;
5051}
5052
5053bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
5054 const VkAllocationCallbacks *pAllocator,
5055 VkSwapchainKHR *pSwapchain) const {
5056 bool skip = false;
5057 skip |= ValidateSwapchainCreateInfo("vkCreateSwapchainKHR()", pCreateInfo);
5058 return skip;
5059}
5060
5061bool StatelessValidation::manual_PreCallValidateCreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount,
5062 const VkSwapchainCreateInfoKHR *pCreateInfos,
5063 const VkAllocationCallbacks *pAllocator,
5064 VkSwapchainKHR *pSwapchains) const {
5065 bool skip = false;
5066 if (pCreateInfos) {
5067 for (uint32_t i = 0; i < swapchainCount; i++) {
5068 std::stringstream func_name;
5069 func_name << "vkCreateSharedSwapchainsKHR[" << swapchainCount << "]()";
5070 skip |= ValidateSwapchainCreateInfo(func_name.str().c_str(), &pCreateInfos[i]);
5071 }
5072 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005073 return skip;
5074}
5075
Jeff Bolz5c801d12019-10-09 10:38:45 -05005076bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005077 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005078
5079 if (pPresentInfo && pPresentInfo->pNext) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005080 const auto *present_regions = LvlFindInChain<VkPresentRegionsKHR>(pPresentInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -06005081 if (present_regions) {
5082 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07005083 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06005084 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
5085 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07005086 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005087 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
5088 "extension swapchainCount is %i. These values must be equal.",
5089 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06005090 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005091 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08005092 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
5093 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005094 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
5095 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
5096 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06005097 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005098 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005099 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06005100 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005101 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005102 }
5103 }
5104
5105 return skip;
5106}
5107
sfricke-samsung5c1b7392020-12-13 22:17:15 -08005108bool StatelessValidation::manual_PreCallValidateCreateDisplayModeKHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
5109 const VkDisplayModeCreateInfoKHR *pCreateInfo,
5110 const VkAllocationCallbacks *pAllocator,
5111 VkDisplayModeKHR *pMode) const {
5112 bool skip = false;
5113
5114 const VkDisplayModeParametersKHR display_mode_parameters = pCreateInfo->parameters;
5115 if (display_mode_parameters.visibleRegion.width == 0) {
5116 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-width-01990",
5117 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.width must be greater than 0.");
5118 }
5119 if (display_mode_parameters.visibleRegion.height == 0) {
5120 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-height-01991",
5121 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.height must be greater than 0.");
5122 }
5123 if (display_mode_parameters.refreshRate == 0) {
5124 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-refreshRate-01992",
5125 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.refreshRate must be greater than 0.");
5126 }
5127
5128 return skip;
5129}
5130
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005131#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005132bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
5133 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
5134 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005135 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005136 bool skip = false;
5137
5138 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005139 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
5140 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005141 }
5142
5143 return skip;
5144}
5145#endif // VK_USE_PLATFORM_WIN32_KHR
5146
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005147static bool MutableDescriptorTypePartialOverlap(const VkDescriptorPoolCreateInfo *pCreateInfo, uint32_t i, uint32_t j) {
5148 bool partial_overlap = false;
5149
5150 static const std::vector<VkDescriptorType> all_descriptor_types = {
5151 VK_DESCRIPTOR_TYPE_SAMPLER,
5152 VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
5153 VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
5154 VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
5155 VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER,
5156 VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
5157 VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
5158 VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
5159 VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC,
5160 VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC,
5161 VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
5162 VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT,
5163 VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR,
5164 VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV,
5165 };
5166
5167 const auto *mutable_descriptor_type = LvlFindInChain<VkMutableDescriptorTypeCreateInfoVALVE>(pCreateInfo->pNext);
5168 if (mutable_descriptor_type) {
5169 std::vector<VkDescriptorType> first_types, second_types;
5170 if (mutable_descriptor_type->mutableDescriptorTypeListCount > i) {
5171 for (uint32_t k = 0; k < mutable_descriptor_type->pMutableDescriptorTypeLists[i].descriptorTypeCount; ++k) {
5172 first_types.push_back(mutable_descriptor_type->pMutableDescriptorTypeLists[i].pDescriptorTypes[k]);
5173 }
5174 } else {
5175 first_types = all_descriptor_types;
5176 }
5177 if (mutable_descriptor_type->mutableDescriptorTypeListCount > j) {
5178 for (uint32_t k = 0; k < mutable_descriptor_type->pMutableDescriptorTypeLists[j].descriptorTypeCount; ++k) {
5179 second_types.push_back(mutable_descriptor_type->pMutableDescriptorTypeLists[j].pDescriptorTypes[k]);
5180 }
5181 } else {
5182 second_types = all_descriptor_types;
5183 }
5184
5185 bool complete_overlap = first_types.size() == second_types.size();
5186 bool disjoint = true;
5187 for (const auto first_type : first_types) {
5188 bool found = false;
5189 for (const auto second_type : second_types) {
5190 if (first_type == second_type) {
5191 found = true;
5192 break;
5193 }
5194 }
5195 if (found) {
5196 disjoint = false;
5197 } else {
5198 complete_overlap = false;
5199 }
5200 if (!disjoint && !complete_overlap) {
5201 partial_overlap = true;
5202 break;
5203 }
5204 }
5205 }
5206
5207 return partial_overlap;
5208}
5209
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005210bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005211 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005212 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02005213 bool skip = false;
5214
5215 if (pCreateInfo) {
5216 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005217 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
5218 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02005219 }
5220
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005221 const auto *mutable_descriptor_type_features =
5222 LvlFindInChain<VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE>(device_createinfo_pnext);
5223 bool mutable_descriptor_type_enabled =
5224 mutable_descriptor_type_features && mutable_descriptor_type_features->mutableDescriptorType == VK_TRUE;
5225
Petr Krausc8655be2017-09-27 18:56:51 +02005226 if (pCreateInfo->pPoolSizes) {
5227 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
5228 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005229 skip |= LogError(
5230 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005231 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02005232 }
Jeff Bolze54ae892018-09-08 12:16:29 -05005233 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
5234 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005235 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
5236 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
5237 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
5238 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
5239 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05005240 }
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005241 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE && !mutable_descriptor_type_enabled) {
5242 skip |=
5243 LogError(device, "VUID-VkDescriptorPoolCreateInfo-mutableDescriptorType-04608",
5244 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
5245 "].type is VK_DESCRIPTOR_TYPE_MUTABLE_VALVE "
5246 ", but VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType is not enabled.",
5247 i);
5248 }
5249 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
5250 for (uint32_t j = i + 1; j < pCreateInfo->poolSizeCount; ++j) {
5251 if (pCreateInfo->pPoolSizes[j].type == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
5252 if (MutableDescriptorTypePartialOverlap(pCreateInfo, i, j)) {
5253 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-pPoolSizes-04787",
5254 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
5255 "].type and pCreateInfo->pPoolSizes[%" PRIu32
5256 "].type are both VK_DESCRIPTOR_TYPE_MUTABLE_VALVE "
5257 " and have sets which partially overlap.",
5258 i, j);
5259 }
5260 }
5261 }
5262 }
Petr Krausc8655be2017-09-27 18:56:51 +02005263 }
5264 }
ziga-lunarg0cf85212021-07-19 01:26:17 +02005265
ziga-lunarg0bc679d2021-10-15 15:55:19 +02005266 if (pCreateInfo->flags & VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE && (!mutable_descriptor_type_enabled)) {
5267 skip |=
5268 LogError(device, "VUID-VkDescriptorPoolCreateInfo-flags-04609",
5269 "vkCreateDescriptorPool(): pCreateInfo->flags contains VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE, "
5270 "but VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE::mutableDescriptorType is not enabled.");
5271 }
ziga-lunarg0cf85212021-07-19 01:26:17 +02005272 if ((pCreateInfo->flags & VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE) &&
5273 (pCreateInfo->flags & VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT)) {
5274 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-flags-04607",
5275 "vkCreateDescriptorPool(): pCreateInfo->flags must not contain both "
5276 "VK_DESCRIPTOR_POOL_CREATE_HOST_ONLY_BIT_VALVE and VK_DESCRIPTOR_POOL_CREATE_UPDATE_AFTER_BIND_BIT");
5277 }
Petr Krausc8655be2017-09-27 18:56:51 +02005278 }
5279
5280 return skip;
5281}
5282
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005283bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005284 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005285 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005286
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005287 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005288 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005289 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
5290 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
5291 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005292 }
5293
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005294 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005295 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005296 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
5297 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
5298 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005299 }
5300
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005301 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06005302 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005303 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
5304 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
5305 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005306 }
5307
5308 return skip;
5309}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005310
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005311bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005312 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07005313 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07005314
5315 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005316 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
5317 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07005318 }
5319 return skip;
5320}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005321
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005322bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
5323 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005324 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005325 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005326
5327 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005328 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005329 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005330 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
5331 "vkCmdDispatch(): baseGroupX (%" PRIu32
5332 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
5333 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005334 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005335 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
5336 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
5337 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
5338 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005339 }
5340
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005341 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005342 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005343 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
5344 "vkCmdDispatch(): baseGroupY (%" PRIu32
5345 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
5346 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005347 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005348 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
5349 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
5350 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
5351 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005352 }
5353
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005354 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005355 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005356 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
5357 "vkCmdDispatch(): baseGroupZ (%" PRIu32
5358 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
5359 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005360 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005361 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
5362 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
5363 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
5364 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07005365 }
5366
5367 return skip;
5368}
5369
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07005370bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
5371 VkPipelineBindPoint pipelineBindPoint,
5372 VkPipelineLayout layout, uint32_t set,
5373 uint32_t descriptorWriteCount,
5374 const VkWriteDescriptorSet *pDescriptorWrites) const {
Mike Schuchardt979898a2022-01-11 10:46:59 -08005375 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, true);
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07005376}
5377
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005378bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
5379 uint32_t firstExclusiveScissor,
5380 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005381 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05005382 bool skip = false;
5383
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005384 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05005385 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005386 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005387 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
5388 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
5389 ") is not 0.",
5390 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005391 }
5392 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005393 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005394 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
5395 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
5396 ") is not 1.",
5397 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005398 }
5399 } else { // multiViewport enabled
5400 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005401 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005402 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
5403 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
5404 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5405 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005406 }
5407 }
5408
Jeff Bolz3e71f782018-08-29 23:15:45 -05005409 if (pExclusiveScissors) {
5410 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
5411 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
5412
5413 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005414 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
5415 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
5416 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005417 }
5418
5419 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005420 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
5421 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
5422 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005423 }
5424
5425 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
5426 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005427 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
5428 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5429 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5430 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005431 }
5432
5433 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
5434 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005435 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
5436 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5437 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5438 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05005439 }
5440 }
5441 }
5442
5443 return skip;
5444}
5445
Chris Mayer9ded5eb2019-09-19 16:33:26 +02005446bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
5447 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005448 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02005449 bool skip = false;
Shannon McPherson169d0c72020-11-13 18:48:19 -07005450 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
5451 if ((sum < 1) || (sum > device_limits.maxViewports)) {
5452 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
5453 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
5454 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
5455 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02005456 }
5457
5458 return skip;
5459}
5460
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005461bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
5462 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005463 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05005464 bool skip = false;
5465
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005466 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05005467 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005468 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005469 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
5470 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
5471 ") is not 0.",
5472 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005473 }
5474 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06005475 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005476 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
5477 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
5478 ") is not 1.",
5479 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005480 }
5481 }
5482
Jeff Bolz9af91c52018-09-01 21:53:57 -05005483 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005484 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005485 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
5486 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
5487 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5488 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005489 }
5490
5491 return skip;
5492}
5493
Jeff Bolz5c801d12019-10-09 10:38:45 -05005494bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
5495 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
5496 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05005497 bool skip = false;
5498
Dave Houlton142c4cb2018-10-17 15:04:41 -06005499 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005500 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
5501 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
5502 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05005503 }
5504
5505 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005506 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05005507 }
5508
5509 return skip;
5510}
5511
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005512bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005513 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005514 bool skip = false;
5515
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005516 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005517 skip |= LogError(
5518 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06005519 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
5520 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005521 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005522 }
5523
5524 return skip;
5525}
5526
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005527bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
5528 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005529 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005530 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06005531 static const int condition_multiples = 0b0011;
5532 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005533 skip |= LogError(
5534 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06005535 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005536 }
Lockee1c22882019-06-10 16:02:54 -06005537 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005538 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
5539 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
5540 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
5541 stride);
Lockee1c22882019-06-10 16:02:54 -06005542 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005543 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005544 skip |= LogError(
5545 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005546 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %" PRIu32 "",
5547 drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06005548 }
Tony-LunarGc0c3df52020-11-20 13:47:10 -07005549 if (drawCount > device_limits.maxDrawIndirectCount) {
5550 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02719",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005551 "vkCmdDrawMeshTasksIndirectNV: drawCount (%" PRIu32
5552 ") is not less than or equal to the maximum allowed (%" PRIu32 ").",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005553 drawCount, device_limits.maxDrawIndirectCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07005554 }
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005555 return skip;
5556}
5557
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005558bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
5559 VkDeviceSize offset, VkBuffer countBuffer,
5560 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005561 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005562 bool skip = false;
5563
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005564 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005565 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
5566 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
5567 "), is not a multiple of 4.",
5568 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005569 }
5570
5571 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005572 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
5573 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
5574 "), is not a multiple of 4.",
5575 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005576 }
5577
Jeff Bolz45bf7d62018-09-18 15:39:58 -05005578 return skip;
5579}
5580
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005581bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005582 const VkAllocationCallbacks *pAllocator,
5583 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005584 bool skip = false;
5585
5586 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
5587 if (pCreateInfo != nullptr) {
5588 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
5589 // VkQueryPipelineStatisticFlagBits values
5590 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
5591 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005592 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
5593 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
5594 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
5595 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005596 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07005597 if (pCreateInfo->queryCount == 0) {
5598 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
5599 "vkCreateQueryPool(): queryCount must be greater than zero.");
5600 }
ziga-lunarg1052d492022-04-03 20:12:15 +02005601 if (pCreateInfo->queryType == VK_QUERY_TYPE_PRIMITIVES_GENERATED_EXT) {
5602 const auto *primitives_generated_query_features =
5603 LvlFindInChain<VkPhysicalDevicePrimitivesGeneratedQueryFeaturesEXT>(device_createinfo_pnext);
5604 if (!primitives_generated_query_features || primitives_generated_query_features->primitivesGeneratedQuery == VK_FALSE) {
5605 skip |= LogError(device, "VUID-vkCmdBeginQuery-queryType-06688",
5606 "vkCreateQueryPool(): If pCreateInfo->queryType is VK_QUERY_TYPE_PRIMITIVES_GENERATED_EXT primitivesGeneratedQuery feature must be enabled.");
5607 }
5608 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06005609 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005610 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005611}
5612
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005613bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
5614 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005615 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005616 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
5617 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005618}
5619
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005620void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07005621 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
5622 VkResult result) {
5623 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005624 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005625}
5626
Mike Schuchardt2df08912020-12-15 16:28:09 -08005627void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07005628 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
5629 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005630 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07005631 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005632 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005633}
5634
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07005635void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
5636 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005637 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07005638 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07005639 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005640}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005641
Tony-LunarG3c287f62020-12-17 12:39:49 -07005642void StatelessValidation::PostCallRecordAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pAllocateInfo,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005643 VkCommandBuffer *pCommandBuffers, VkResult result) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07005644 if ((result == VK_SUCCESS) && pAllocateInfo && (pAllocateInfo->level == VK_COMMAND_BUFFER_LEVEL_SECONDARY)) {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06005645 auto lock = CBWriteLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07005646 for (uint32_t cb_index = 0; cb_index < pAllocateInfo->commandBufferCount; cb_index++) {
Jeremy Gebbenfc6f8152021-03-18 16:58:55 -06005647 secondary_cb_map.emplace(pCommandBuffers[cb_index], pAllocateInfo->commandPool);
Tony-LunarG3c287f62020-12-17 12:39:49 -07005648 }
5649 }
5650}
5651
5652void StatelessValidation::PostCallRecordFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005653 const VkCommandBuffer *pCommandBuffers) {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06005654 auto lock = CBWriteLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07005655 for (uint32_t cb_index = 0; cb_index < commandBufferCount; cb_index++) {
5656 secondary_cb_map.erase(pCommandBuffers[cb_index]);
5657 }
5658}
5659
5660void StatelessValidation::PostCallRecordDestroyCommandPool(VkDevice device, VkCommandPool commandPool,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005661 const VkAllocationCallbacks *pAllocator) {
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06005662 auto lock = CBWriteLock();
Tony-LunarG3c287f62020-12-17 12:39:49 -07005663 for (auto item = secondary_cb_map.begin(); item != secondary_cb_map.end();) {
5664 if (item->second == commandPool) {
5665 item = secondary_cb_map.erase(item);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005666 } else {
Tony-LunarG3c287f62020-12-17 12:39:49 -07005667 ++item;
5668 }
5669 }
5670}
5671
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005672bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005673 const VkAllocationCallbacks *pAllocator,
5674 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005675 bool skip = false;
5676
5677 if (pAllocateInfo) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005678 auto chained_prio_struct = LvlFindInChain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005679 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005680 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
5681 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005682 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005683
5684 VkMemoryAllocateFlags flags = 0;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005685 auto flags_info = LvlFindInChain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005686 if (flags_info) {
5687 flags = flags_info->flags;
5688 }
5689
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005690 auto opaque_alloc_info = LvlFindInChain<VkMemoryOpaqueCaptureAddressAllocateInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005691 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08005692 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005693 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
5694 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
Mike Schuchardt2df08912020-12-15 16:28:09 -08005695 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005696 }
5697
5698#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005699 auto import_memory_win32_handle = LvlFindInChain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005700#endif
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005701 auto import_memory_fd = LvlFindInChain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
5702 auto import_memory_host_pointer = LvlFindInChain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005703#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005704 auto import_memory_ahb = LvlFindInChain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005705#endif
5706
5707 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005708 skip |= LogError(
5709 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005710 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
5711 }
5712 if (
5713#ifdef VK_USE_PLATFORM_WIN32_KHR
5714 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
5715#endif
5716 (import_memory_fd && import_memory_fd->handleType) ||
5717#ifdef VK_USE_PLATFORM_ANDROID_KHR
5718 (import_memory_ahb && import_memory_ahb->buffer) ||
5719#endif
5720 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005721 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
5722 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005723 }
5724 }
5725
ziga-lunarg1d5e11d2021-07-18 13:13:40 +02005726 auto export_memory = LvlFindInChain<VkExportMemoryAllocateInfo>(pAllocateInfo->pNext);
5727 if (export_memory) {
5728 auto export_memory_nv = LvlFindInChain<VkExportMemoryAllocateInfoNV>(pAllocateInfo->pNext);
5729 if (export_memory_nv) {
5730 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-pNext-00640",
5731 "pNext chain of VkMemoryAllocateInfo includes both VkExportMemoryAllocateInfo and "
5732 "VkExportMemoryAllocateInfoNV");
5733 }
5734#ifdef VK_USE_PLATFORM_WIN32_KHR
5735 auto export_memory_win32_nv = LvlFindInChain<VkExportMemoryWin32HandleInfoNV>(pAllocateInfo->pNext);
5736 if (export_memory_win32_nv) {
5737 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-pNext-00640",
5738 "pNext chain of VkMemoryAllocateInfo includes both VkExportMemoryAllocateInfo and "
5739 "VkExportMemoryWin32HandleInfoNV");
5740 }
5741#endif
5742 }
5743
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005744 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07005745 VkBool32 capture_replay = false;
5746 VkBool32 buffer_device_address = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005747 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07005748 if (vulkan_12_features) {
5749 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
5750 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
5751 } else {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005752 const auto *bda_features = LvlFindInChain<VkPhysicalDeviceBufferDeviceAddressFeatures>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07005753 if (bda_features) {
5754 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
5755 buffer_device_address = bda_features->bufferDeviceAddress;
5756 }
5757 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08005758 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005759 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
Mike Schuchardt2df08912020-12-15 16:28:09 -08005760 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT is set, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005761 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005762 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08005763 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005764 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
Mike Schuchardt2df08912020-12-15 16:28:09 -08005765 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06005766 }
5767 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06005768 }
5769 return skip;
5770}
Ricardo Garciaa4935972019-02-21 17:43:18 +01005771
Jason Macnak192fa0e2019-07-26 15:07:16 -07005772bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005773 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07005774 bool skip = false;
5775
5776 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
5777 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
5778 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005779 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005780 } else {
5781 uint32_t vertex_component_size = 0;
5782 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
5783 vertex_component_size = 4;
5784 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
5785 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
5786 vertex_component_size = 2;
5787 }
5788 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005789 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005790 }
5791 }
5792
5793 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
5794 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005795 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005796 } else {
5797 uint32_t index_element_size = 0;
5798 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
5799 index_element_size = 4;
5800 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
5801 index_element_size = 2;
5802 }
5803 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005804 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005805 }
5806 }
5807 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
5808 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005809 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005810 }
5811 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005812 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005813 }
5814 }
5815
5816 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005817 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005818 }
5819
5820 return skip;
5821}
5822
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005823bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
5824 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07005825 bool skip = false;
5826
5827 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005828 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005829 }
5830 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005831 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005832 }
5833
5834 return skip;
5835}
5836
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005837bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
5838 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07005839 bool skip = false;
5840 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005841 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005842 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005843 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005844 }
5845 return skip;
5846}
5847
5848bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07005849 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005850 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07005851 bool skip = false;
5852 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005853 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
5854 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
5855 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07005856 }
5857 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005858 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
5859 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
5860 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07005861 }
ziga-lunarg10309ee2021-08-02 13:11:21 +02005862 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
5863 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-04623",
5864 "VkAccelerationStructureInfoNV: type is invalid VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.");
5865 }
Jason Macnak5c954952019-07-09 15:46:12 -07005866 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
5867 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005868 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
5869 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
5870 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07005871 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005872 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005873 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06005874 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
5875 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005876 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
5877 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07005878 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005879 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005880 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
5881 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
5882 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07005883 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07005884 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07005885 uint64_t total_triangle_count = 0;
5886 for (uint32_t i = 0; i < info.geometryCount; i++) {
5887 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07005888
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005889 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07005890
Jason Macnak5c954952019-07-09 15:46:12 -07005891 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
5892 continue;
5893 }
5894 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
5895 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005896 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005897 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
5898 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
5899 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07005900 }
5901 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07005902 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
5903 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
5904 for (uint32_t i = 1; i < info.geometryCount; i++) {
5905 const VkGeometryNV &geometry = info.pGeometries[i];
5906 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005907 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07005908 "VkAccelerationStructureInfoNV: info.pGeometries[%" PRIu32
5909 "].geometryType does not match "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005910 "info.pGeometries[0].geometryType.",
5911 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07005912 }
5913 }
5914 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005915 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
5916 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
5917 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
5918 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
5919 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
5920 "or VK_GEOMETRY_TYPE_AABBS_NV.");
5921 }
5922 }
5923 skip |=
5924 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06005925 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07005926 return skip;
5927}
5928
Ricardo Garciaa4935972019-02-21 17:43:18 +01005929bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
5930 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005931 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01005932 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01005933 if (pCreateInfo) {
5934 if ((pCreateInfo->compactedSize != 0) &&
5935 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005936 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
5937 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
5938 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
5939 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01005940 }
Jason Macnak5c954952019-07-09 15:46:12 -07005941
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005942 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07005943 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01005944 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01005945 return skip;
5946}
Mike Schuchardt21638df2019-03-16 10:52:02 -07005947
Jeff Bolz5c801d12019-10-09 10:38:45 -05005948bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
5949 const VkAccelerationStructureInfoNV *pInfo,
5950 VkBuffer instanceData, VkDeviceSize instanceOffset,
5951 VkBool32 update, VkAccelerationStructureNV dst,
5952 VkAccelerationStructureNV src, VkBuffer scratch,
5953 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07005954 bool skip = false;
5955
5956 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07005957 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07005958 }
5959
5960 return skip;
5961}
5962
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005963bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
5964 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5965 VkAccelerationStructureKHR *pAccelerationStructure) const {
5966 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005967 const auto *acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005968 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005969 if (!acceleration_structure_features ||
5970 (acceleration_structure_features && acceleration_structure_features->accelerationStructure == VK_FALSE)) {
5971 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-accelerationStructure-03611",
5972 "vkCreateAccelerationStructureKHR(): The accelerationStructure feature must be enabled");
5973 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005974 if (pCreateInfo) {
sourav parmarcd5fb182020-07-17 12:58:44 -07005975 if (pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR &&
5976 (!acceleration_structure_features ||
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005977 (acceleration_structure_features &&
5978 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
sourav parmara96ab1a2020-04-25 16:28:23 -07005979 skip |=
sourav parmarcd5fb182020-07-17 12:58:44 -07005980 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-createFlags-03613",
5981 "vkCreateAccelerationStructureKHR(): If createFlags includes "
5982 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR, "
5983 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay must be VK_TRUE");
sourav parmara96ab1a2020-04-25 16:28:23 -07005984 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005985 if (pCreateInfo->deviceAddress &&
5986 !(pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
5987 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03612",
5988 "vkCreateAccelerationStructureKHR(): If deviceAddress is not zero, createFlags must include "
5989 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR");
5990 }
ziga-lunarg8ddbe462021-09-06 16:14:17 +02005991 if (pCreateInfo->deviceAddress && (!acceleration_structure_features ||
5992 (acceleration_structure_features &&
5993 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
5994 skip |= LogError(
5995 device, "VUID-vkCreateAccelerationStructureKHR-deviceAddress-03488",
5996 "VkAccelerationStructureCreateInfoKHR(): VkAccelerationStructureCreateInfoKHR::deviceAddress is not zero, but "
5997 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay is not enabled.");
5998 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005999 if (SafeModulo(pCreateInfo->offset, 256) != 0) {
6000 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-offset-03734",
ziga-lunarg8ddbe462021-09-06 16:14:17 +02006001 "vkCreateAccelerationStructureKHR(): offset %" PRIu64 " must be a multiple of 256 bytes",
6002 pCreateInfo->offset);
sourav parmarcd5fb182020-07-17 12:58:44 -07006003 }
sourav parmar83c31b12020-05-06 12:30:54 -07006004 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006005 return skip;
6006}
6007
Jason Macnak5c954952019-07-09 15:46:12 -07006008bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
6009 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006010 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07006011 bool skip = false;
6012 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006013 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
6014 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07006015 }
6016 return skip;
6017}
6018
sourav parmarcd5fb182020-07-17 12:58:44 -07006019bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesNV(
6020 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureNV *pAccelerationStructures,
6021 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
6022 bool skip = false;
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07006023 if (queryType != VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV) {
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07006024 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesNV-queryType-06216",
sourav parmarcd5fb182020-07-17 12:58:44 -07006025 "vkCmdWriteAccelerationStructuresPropertiesNV: queryType must be "
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07006026 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV.");
sourav parmarcd5fb182020-07-17 12:58:44 -07006027 }
6028 return skip;
6029}
6030
Peter Chen85366392019-05-14 15:20:11 -04006031bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
6032 uint32_t createInfoCount,
6033 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
6034 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006035 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04006036 bool skip = false;
6037
6038 for (uint32_t i = 0; i < createInfoCount; i++) {
ziga-lunargc6341372021-07-28 12:57:42 +02006039 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
6040 std::stringstream msg;
6041 msg << "pCreateInfos[%" << i << "].pStages[%" << stage_index << "]";
6042 ValidatePipelineShaderStageCreateInfo("vkCreateRayTracingPipelinesNV", msg.str().c_str(), &pCreateInfos[i].pStages[i]);
6043 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006044 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04006045 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Tony-LunarGce3244a2021-11-19 12:33:40 -07006046 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfo-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006047 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
6048 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
6049 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
6050 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04006051 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006052
6053 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006054 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07006055 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
6056 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
6057 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
6058 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
6059 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
6060 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
6061 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
6062 }
6063 }
6064
sourav parmarf4a78252020-04-10 13:04:21 -07006065 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
6066 skip |=
6067 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
6068 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
6069 }
6070 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
6071 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
6072 skip |=
6073 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
6074 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
6075 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
6076 }
6077 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
6078 if (pCreateInfos[i].basePipelineIndex != -1) {
6079 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
6080 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
6081 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
6082 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
6083 "and pCreateInfos->basePipelineIndex is not -1.");
6084 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006085 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07006086 skip |=
6087 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
6088 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
6089 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
6090 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
6091 "that element.");
6092 }
sourav parmarf4a78252020-04-10 13:04:21 -07006093 }
6094 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04006095 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07006096 skip |=
6097 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
6098 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
6099 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
6100 "commands pCreateInfos parameter.");
6101 }
6102 } else {
6103 if (pCreateInfos[i].basePipelineIndex != -1) {
6104 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
6105 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
6106 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
6107 }
6108 }
6109 }
6110 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
6111 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
6112 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
6113 }
6114 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
6115 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
6116 "vkCreateRayTracingPipelinesNV: flags must not include "
6117 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
6118 }
6119 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
6120 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
6121 "vkCreateRayTracingPipelinesNV: flags must not include "
6122 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
6123 }
6124 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
6125 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
6126 "vkCreateRayTracingPipelinesNV: flags must not include "
6127 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
6128 }
6129 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
6130 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
6131 "vkCreateRayTracingPipelinesNV: flags must not include "
6132 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
6133 }
6134 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
6135 skip |= LogError(
6136 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
6137 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
6138 }
6139 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
6140 skip |= LogError(
6141 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
6142 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
6143 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006144 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) {
6145 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03588",
6146 "vkCreateRayTracingPipelinesNV: flags must not include "
6147 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
6148 }
6149 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
6150 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03816",
6151 "vkCreateRayTracingPipelinesNV: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
6152 }
ziga-lunargdfffee42021-10-10 11:49:59 +02006153 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV) {
6154 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-04948",
6155 "vkCreateRayTracingPipelinesNV: flags must not contain the "
6156 "VK_PIPELINE_CREATE_RAY_TRACING_ALLOW_MOTION_BIT_NV flag.");
6157 }
Peter Chen85366392019-05-14 15:20:11 -04006158 }
6159
6160 return skip;
6161}
6162
sourav parmarcd5fb182020-07-17 12:58:44 -07006163bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(
6164 VkDevice device, VkDeferredOperationKHR deferredOperation, VkPipelineCache pipelineCache, uint32_t createInfoCount,
6165 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos, const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) const {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006166 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006167 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006168 if (!raytracing_features || raytracing_features->rayTracingPipeline == VK_FALSE) {
6169 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracingPipeline-03586",
6170 "vkCreateRayTracingPipelinesKHR: The rayTracingPipeline feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006171 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006172 for (uint32_t i = 0; i < createInfoCount; i++) {
ziga-lunargc6341372021-07-28 12:57:42 +02006173 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
6174 std::stringstream msg;
6175 msg << "pCreateInfos[%" << i << "].pStages[%" << stage_index << "]";
6176 ValidatePipelineShaderStageCreateInfo("vkCreateRayTracingPipelinesKHR", msg.str().c_str(),
aitor-lunargdbd9e652022-02-23 19:12:53 +01006177 &pCreateInfos[i].pStages[stage_index]);
ziga-lunargc6341372021-07-28 12:57:42 +02006178 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006179 if (!raytracing_features || (raytracing_features && raytracing_features->rayTraversalPrimitiveCulling == VK_FALSE)) {
6180 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
6181 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03596",
6182 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
6183 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
6184 }
6185 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
6186 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03597",
6187 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
6188 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.");
6189 }
6190 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006191 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006192 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Tony-LunarGce3244a2021-11-19 12:33:40 -07006193 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfo-pipelineStageCreationFeedbackCount-02670",
sourav parmarcd5fb182020-07-17 12:58:44 -07006194 "vkCreateRayTracingPipelinesKHR: in pCreateInfo[%" PRIu32
6195 "], When chained to VkRayTracingPipelineCreateInfoKHR, "
6196 "VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006197 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
6198 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
6199 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006200 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006201 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07006202 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
6203 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
6204 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
6205 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
sourav parmarcd5fb182020-07-17 12:58:44 -07006206 "vkCreateRayTracingPipelinesKHR: If the pipelineCreationCacheControl feature is not enabled,"
sourav parmara96ab1a2020-04-25 16:28:23 -07006207 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
6208 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
6209 }
6210 }
sourav parmarf4a78252020-04-10 13:04:21 -07006211 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006212 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
6213 "vkCreateRayTracingPipelinesKHR: flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
sourav parmarf4a78252020-04-10 13:04:21 -07006214 }
6215 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006216 if (pCreateInfos[i].pLibraryInterface == NULL) {
sourav parmarf4a78252020-04-10 13:04:21 -07006217 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
sourav parmarcd5fb182020-07-17 12:58:44 -07006218 "vkCreateRayTracingPipelinesKHR: If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, "
6219 "pLibraryInterface must not be NULL.");
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006220 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006221 }
6222 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
6223 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03816",
6224 "vkCreateRayTracingPipelinesKHR: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
sourav parmarf4a78252020-04-10 13:04:21 -07006225 }
6226 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
6227 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
6228 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
6229 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
6230 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
6231 skip |= LogError(
6232 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
sourav parmarcd5fb182020-07-17 12:58:44 -07006233 "vkCreateRayTracingPipelinesKHR: If flags includes "
6234 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07006235 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
6236 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
6237 "must not be VK_SHADER_UNUSED_KHR");
6238 }
6239 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
6240 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
6241 skip |= LogError(
6242 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
sourav parmarcd5fb182020-07-17 12:58:44 -07006243 "vkCreateRayTracingPipelinesKHR: If flags includes "
6244 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07006245 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
6246 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
6247 "element must not be VK_SHADER_UNUSED_KHR");
6248 }
6249 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006250 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_TRUE &&
6251 pCreateInfos[i].pGroups[group_index].pShaderGroupCaptureReplayHandle) {
6252 if (!(pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR)) {
6253 skip |= LogError(
6254 device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03599",
6255 "vkCreateRayTracingPipelinesKHR: If "
6256 "VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineShaderGroupHandleCaptureReplay is "
6257 "VK_TRUE and the pShaderGroupCaptureReplayHandle member of any element of pGroups is not NULL, flags must "
6258 "include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
6259 }
6260 }
sourav parmarf4a78252020-04-10 13:04:21 -07006261 }
6262 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
6263 if (pCreateInfos[i].basePipelineIndex != -1) {
6264 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
6265 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
sourav parmarcd5fb182020-07-17 12:58:44 -07006266 "vkCreateRayTracingPipelinesKHR: parameter, pCreateInfos->basePipelineHandle, must be "
sourav parmarf4a78252020-04-10 13:04:21 -07006267 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
6268 "and pCreateInfos->basePipelineIndex is not -1.");
6269 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006270 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07006271 skip |=
6272 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
6273 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
6274 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
6275 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
6276 "element.");
6277 }
sourav parmarf4a78252020-04-10 13:04:21 -07006278 }
6279 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04006280 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07006281 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
sourav parmarcd5fb182020-07-17 12:58:44 -07006282 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006283 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%" PRId32
6284 ") must be a valid into the calling"
6285 "commands pCreateInfos parameter %" PRIu32 ".",
sourav parmarf4a78252020-04-10 13:04:21 -07006286 pCreateInfos[i].basePipelineIndex, createInfoCount);
6287 }
6288 } else {
6289 if (pCreateInfos[i].basePipelineIndex != -1) {
6290 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
sourav parmarcd5fb182020-07-17 12:58:44 -07006291 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07006292 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
6293 }
6294 }
6295 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006296 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR &&
6297 (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE)) {
6298 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03598",
6299 "vkCreateRayTracingPipelinesKHR: If flags includes "
6300 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR, "
6301 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled.");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006302 }
6303 bool library_enabled = IsExtEnabled(device_extensions.vk_khr_pipeline_library);
6304 if (!library_enabled && (pCreateInfos[i].pLibraryInfo || pCreateInfos[i].pLibraryInterface)) {
6305 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03595",
6306 "vkCreateRayTracingPipelinesKHR: If the VK_KHR_pipeline_library extension is not enabled, "
6307 "pLibraryInfo and pLibraryInterface must be NULL.");
6308 }
6309 if (pCreateInfos[i].pLibraryInfo) {
6310 if (pCreateInfos[i].pLibraryInfo->libraryCount == 0) {
6311 if (pCreateInfos[i].stageCount == 0) {
6312 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03600",
6313 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
6314 "stageCount must not be 0.");
6315 }
6316 if (pCreateInfos[i].groupCount == 0) {
6317 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03601",
6318 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
6319 "groupCount must not be 0.");
6320 }
6321 } else {
6322 if (pCreateInfos[i].pLibraryInterface == NULL) {
6323 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03590",
6324 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount member "
6325 "is greater than 0, its "
6326 "pLibraryInterface member must not be NULL.");
sourav parmarcd5fb182020-07-17 12:58:44 -07006327 }
6328 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006329 }
6330 if (pCreateInfos[i].pLibraryInterface) {
6331 if (pCreateInfos[i].pLibraryInterface->maxPipelineRayHitAttributeSize >
6332 phys_dev_ext_props.ray_tracing_propsKHR.maxRayHitAttributeSize) {
6333 skip |= LogError(device, "VUID-VkRayTracingPipelineInterfaceCreateInfoKHR-maxPipelineRayHitAttributeSize-03605",
6334 "vkCreateRayTracingPipelinesKHR: maxPipelineRayHitAttributeSize must be less than or equal to "
6335 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayHitAttributeSize.");
6336 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006337 }
6338 if (deferredOperation != VK_NULL_HANDLE) {
6339 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT) {
6340 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-deferredOperation-03587",
6341 "vkCreateRayTracingPipelinesKHR: If deferredOperation is not VK_NULL_HANDLE, the flags member of "
6342 "elements of pCreateInfos must not include VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
sourav parmarf4a78252020-04-10 13:04:21 -07006343 }
6344 }
ziga-lunargdea76582021-09-17 14:38:08 +02006345 if (pCreateInfos[i].pDynamicState) {
6346 for (uint32_t j = 0; j < pCreateInfos[i].pDynamicState->dynamicStateCount; ++j) {
6347 if (pCreateInfos[i].pDynamicState->pDynamicStates[j] != VK_DYNAMIC_STATE_RAY_TRACING_PIPELINE_STACK_SIZE_KHR) {
6348 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pDynamicStates-03602",
6349 "vkCreateRayTracingPipelinesKHR(): pCreateInfos[%" PRIu32
6350 "].pDynamicState->pDynamicStates[%" PRIu32 "] is %s.",
6351 i, j, string_VkDynamicState(pCreateInfos[i].pDynamicState->pDynamicStates[j]));
6352 }
6353 }
6354 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05006355 }
6356
6357 return skip;
6358}
6359
Mike Schuchardt21638df2019-03-16 10:52:02 -07006360#ifdef VK_USE_PLATFORM_WIN32_KHR
6361bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
6362 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006363 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07006364 bool skip = false;
sfricke-samsung45996a42021-09-16 13:45:27 -07006365 if (!IsExtEnabled(device_extensions.vk_khr_swapchain))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006366 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006367 if (!IsExtEnabled(device_extensions.vk_khr_get_surface_capabilities2))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006368 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006369 if (!IsExtEnabled(device_extensions.vk_khr_surface))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006370 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006371 if (!IsExtEnabled(device_extensions.vk_khr_get_physical_device_properties2))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006372 skip |=
6373 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
sfricke-samsung45996a42021-09-16 13:45:27 -07006374 if (!IsExtEnabled(device_extensions.vk_ext_full_screen_exclusive))
Mike Schuchardt21638df2019-03-16 10:52:02 -07006375 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
6376 skip |= validate_struct_type(
6377 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
6378 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
6379 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
6380 if (pSurfaceInfo != NULL) {
6381 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
6382 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
6383 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
6384
6385 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
6386 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
6387 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
6388 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08006389 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
6390 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07006391
Mike Schuchardt05b028d2022-01-05 14:15:00 -08006392 if (pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
6393 skip |= LogError(device, "VUID-vkGetPhysicalDeviceSurfacePresentModes2EXT-pSurfaceInfo-06521",
6394 "vkGetPhysicalDeviceSurfacePresentModes2EXT: pSurfaceInfo->surface is VK_NULL_HANDLE and "
6395 "VK_GOOGLE_surfaceless_query is not enabled.");
6396 }
6397
Mike Schuchardt21638df2019-03-16 10:52:02 -07006398 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
6399 }
6400 return skip;
6401}
6402#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01006403
6404bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
6405 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006406 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01006407 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
6408 bool skip = false;
Mike Schuchardt2df08912020-12-15 16:28:09 -08006409 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT) == 0) {
Tobias Hectorebb855f2019-07-23 12:17:33 +01006410 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
6411 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
6412 }
6413 return skip;
6414}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05006415
6416bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006417 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05006418 bool skip = false;
6419
6420 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006421 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006422 "vkCmdSetLineStippleEXT::lineStippleFactor=%" PRIu32 " is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05006423 }
6424
6425 return skip;
6426}
Piers Daniell8fd03f52019-08-21 12:07:53 -06006427
6428bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006429 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06006430 bool skip = false;
6431
6432 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006433 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
6434 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06006435 }
6436
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006437 const auto *index_type_uint8_features = LvlFindInChain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06006438 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006439 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
6440 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06006441 }
6442
6443 return skip;
6444}
Mark Lobodzinski84988402019-09-11 15:27:30 -06006445
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006446bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
6447 uint32_t bindingCount, const VkBuffer *pBuffers,
6448 const VkDeviceSize *pOffsets) const {
6449 bool skip = false;
6450 if (firstBinding > device_limits.maxVertexInputBindings) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006451 skip |=
6452 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
6453 "vkCmdBindVertexBuffers() firstBinding (%" PRIu32 ") must be less than maxVertexInputBindings (%" PRIu32 ")",
6454 firstBinding, device_limits.maxVertexInputBindings);
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006455 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
6456 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006457 "vkCmdBindVertexBuffers() sum of firstBinding (%" PRIu32 ") and bindingCount (%" PRIu32
6458 ") must be less than "
6459 "maxVertexInputBindings (%" PRIu32 ")",
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006460 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
6461 }
6462
Jeff Bolz165818a2020-05-08 11:19:03 -05006463 for (uint32_t i = 0; i < bindingCount; ++i) {
6464 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006465 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05006466 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006467 skip |=
6468 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
6469 "vkCmdBindVertexBuffers() required parameter pBuffers[%" PRIu32 "] specified as VK_NULL_HANDLE", i);
Jeff Bolz165818a2020-05-08 11:19:03 -05006470 } else {
6471 if (pOffsets[i] != 0) {
6472 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006473 "vkCmdBindVertexBuffers() pBuffers[%" PRIu32 "] is VK_NULL_HANDLE, but pOffsets[%" PRIu32
6474 "] is not 0",
6475 i, i);
Jeff Bolz165818a2020-05-08 11:19:03 -05006476 }
6477 }
6478 }
6479 }
6480
sfricke-samsung4ada8d42020-02-09 17:43:11 -08006481 return skip;
6482}
6483
Mark Lobodzinski84988402019-09-11 15:27:30 -06006484bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006485 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06006486 bool skip = false;
6487 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006488 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
6489 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06006490 }
6491 return skip;
6492}
6493
6494bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05006495 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06006496 bool skip = false;
6497 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006498 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
6499 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06006500 }
6501 return skip;
6502}
Petr Kraus3d720392019-11-13 02:52:39 +01006503
6504bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
6505 VkSemaphore semaphore, VkFence fence,
6506 uint32_t *pImageIndex) const {
6507 bool skip = false;
6508
6509 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006510 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
6511 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01006512 }
6513
6514 return skip;
6515}
6516
6517bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
6518 uint32_t *pImageIndex) const {
6519 bool skip = false;
6520
6521 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006522 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
6523 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01006524 }
6525
6526 return skip;
6527}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006528
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06006529bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
6530 uint32_t firstBinding, uint32_t bindingCount,
6531 const VkBuffer *pBuffers,
6532 const VkDeviceSize *pOffsets,
6533 const VkDeviceSize *pSizes) const {
6534 bool skip = false;
6535
6536 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
6537 for (uint32_t i = 0; i < bindingCount; ++i) {
6538 if (pOffsets[i] & 3) {
6539 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
6540 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
6541 }
6542 }
6543
6544 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6545 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
6546 "%s: The firstBinding(%" PRIu32
6547 ") index is greater than or equal to "
6548 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6549 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6550 }
6551
6552 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6553 skip |=
6554 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
6555 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
6556 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6557 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6558 }
6559
6560 for (uint32_t i = 0; i < bindingCount; ++i) {
6561 // pSizes is optional and may be nullptr.
6562 if (pSizes != nullptr) {
6563 if (pSizes[i] != VK_WHOLE_SIZE &&
6564 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
6565 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
6566 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
6567 ") is not VK_WHOLE_SIZE and is greater than "
6568 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
6569 cmd_name, i, pSizes[i]);
6570 }
6571 }
6572 }
6573
6574 return skip;
6575}
6576
6577bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
6578 uint32_t firstCounterBuffer,
6579 uint32_t counterBufferCount,
6580 const VkBuffer *pCounterBuffers,
6581 const VkDeviceSize *pCounterBufferOffsets) const {
6582 bool skip = false;
6583
6584 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
6585 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6586 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
6587 "%s: The firstCounterBuffer(%" PRIu32
6588 ") index is greater than or equal to "
6589 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6590 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6591 }
6592
6593 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6594 skip |=
6595 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
6596 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
6597 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6598 cmd_name, firstCounterBuffer, counterBufferCount,
6599 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6600 }
6601
6602 return skip;
6603}
6604
6605bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
6606 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
6607 const VkBuffer *pCounterBuffers,
6608 const VkDeviceSize *pCounterBufferOffsets) const {
6609 bool skip = false;
6610
6611 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
6612 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6613 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
6614 "%s: The firstCounterBuffer(%" PRIu32
6615 ") index is greater than or equal to "
6616 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6617 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6618 }
6619
6620 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
6621 skip |=
6622 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
6623 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
6624 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
6625 cmd_name, firstCounterBuffer, counterBufferCount,
6626 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
6627 }
6628
6629 return skip;
6630}
6631
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006632bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
6633 uint32_t firstInstance, VkBuffer counterBuffer,
6634 VkDeviceSize counterBufferOffset,
6635 uint32_t counterOffset, uint32_t vertexStride) const {
6636 bool skip = false;
6637
6638 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006639 skip |= LogError(counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
6640 "vkCmdDrawIndirectByteCountEXT: vertexStride (%" PRIu32
6641 ") must be between 0 and maxTransformFeedbackBufferDataStride (%" PRIu32 ").",
6642 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006643 }
6644
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07006645 if ((counterOffset % 4) != 0) {
sfricke-samsung6886c4b2021-01-16 08:37:35 -08006646 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-counterBufferOffset-04568",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006647 "vkCmdDrawIndirectByteCountEXT(): offset (%" PRIu32 ") must be a multiple of 4.", counterOffset);
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07006648 }
6649
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07006650 return skip;
6651}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006652
6653bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
6654 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
6655 const VkAllocationCallbacks *pAllocator,
6656 VkSamplerYcbcrConversion *pYcbcrConversion,
6657 const char *apiName) const {
6658 bool skip = false;
6659
6660 // Check samplerYcbcrConversion feature is set
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006661 const auto *ycbcr_features = LvlFindInChain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006662 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006663 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02006664 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
6665 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07006666 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02006667 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006668 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006669
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006670#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006671 const VkExternalFormatANDROID *external_format_android = LvlFindInChain<VkExternalFormatANDROID>(pCreateInfo);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006672 const bool is_external_format = external_format_android != nullptr && external_format_android->externalFormat != 0;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006673#else
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006674 const bool is_external_format = false;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006675#endif
6676
sfricke-samsung1a72f942020-07-25 12:09:18 -07006677 const VkFormat format = pCreateInfo->format;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006678
6679 // If there is a VkExternalFormatANDROID with externalFormat != 0, the value of components is ignored.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006680 if (!is_external_format) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006681 const VkComponentMapping components = pCreateInfo->components;
6682 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
6683 if (FormatIsXChromaSubsampled(format) == true) {
6684 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
6685 skip |=
6686 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
sfricke-samsung83d98122020-07-04 06:21:15 -07006687 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
6688 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006689 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006690 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006691
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006692 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
6693 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
6694 skip |= LogError(
6695 device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
6696 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
6697 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
6698 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
6699 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006700
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006701 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
6702 (components.r != VK_COMPONENT_SWIZZLE_B)) {
6703 skip |=
6704 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
sfricke-samsung83d98122020-07-04 06:21:15 -07006705 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
6706 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006707 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006708 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006709
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006710 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
6711 (components.b != VK_COMPONENT_SWIZZLE_R)) {
6712 skip |=
6713 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
sfricke-samsung83d98122020-07-04 06:21:15 -07006714 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
6715 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006716 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006717 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006718
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006719 // If one is identity, both need to be
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07006720 const bool r_identity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
6721 const bool b_identity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
6722 if ((r_identity != b_identity) && ((r_identity == true) || (b_identity == true))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006723 skip |=
6724 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
sfricke-samsung83d98122020-07-04 06:21:15 -07006725 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
6726 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07006727 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
6728 string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006729 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07006730 }
6731
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006732 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
6733 // Checks same VU multiple ways in order to give a more useful error message
6734 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
6735 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
6736 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
6737 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
6738 skip |= LogError(
6739 device, vuid,
6740 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6741 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
6742 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6743 string_VkComponentSwizzle(components.b));
6744 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07006745
sfricke-samsunged028b02021-09-06 23:14:51 -07006746 // "must not correspond to a component which contains zero or one as a consequence of conversion to RGBA"
6747 // 4 component format = no issue
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006748 // 3 = no [a]
6749 // 2 = no [b,a]
6750 // 1 = no [g,b,a]
6751 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
sfricke-samsunged028b02021-09-06 23:14:51 -07006752 const uint32_t component_count = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatComponentCount(format);
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006753
sfricke-samsunged028b02021-09-06 23:14:51 -07006754 if ((component_count < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
6755 (components.b == VK_COMPONENT_SWIZZLE_A))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006756 skip |= LogError(device, vuid,
6757 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6758 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
6759 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6760 string_VkComponentSwizzle(components.b));
sfricke-samsunged028b02021-09-06 23:14:51 -07006761 } else if ((component_count < 3) &&
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006762 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
6763 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
6764 skip |= LogError(device, vuid,
6765 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6766 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
6767 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
6768 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6769 string_VkComponentSwizzle(components.b));
sfricke-samsunged028b02021-09-06 23:14:51 -07006770 } else if ((component_count < 2) &&
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02006771 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
6772 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
6773 skip |= LogError(device, vuid,
6774 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
6775 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
6776 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
6777 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
6778 string_VkComponentSwizzle(components.b));
6779 }
sfricke-samsung83d98122020-07-04 06:21:15 -07006780 }
6781 }
6782
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08006783 return skip;
6784}
6785
6786bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
6787 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
6788 const VkAllocationCallbacks *pAllocator,
6789 VkSamplerYcbcrConversion *pYcbcrConversion) const {
6790 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
6791 "vkCreateSamplerYcbcrConversion");
6792}
6793
6794bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
6795 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
6796 VkSamplerYcbcrConversion *pYcbcrConversion) const {
6797 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
6798 "vkCreateSamplerYcbcrConversionKHR");
6799}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08006800
6801bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
6802 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
6803 bool skip = false;
6804 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
6805 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
6806
6807 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07006808 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
6809 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
6810 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
6811 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
6812 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08006813 }
6814 return skip;
6815}
sourav parmara96ab1a2020-04-25 16:28:23 -07006816
6817bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006818 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006819 bool skip = false;
6820 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
6821 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
6822 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
6823 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006824 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006825 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
6826 skip |= LogError(
6827 device, "VUID-vkCopyAccelerationStructureToMemoryKHR-accelerationStructureHostCommands-03584",
6828 "vkCopyAccelerationStructureToMemoryKHR: The "
6829 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
6830 }
6831 skip |= validate_required_pointer("vkCopyAccelerationStructureToMemoryKHR", "pInfo->dst.hostAddress", pInfo->dst.hostAddress,
6832 "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03732");
6833 if (SafeModulo((VkDeviceSize)pInfo->dst.hostAddress, 16) != 0) {
6834 skip |= LogError(device, "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03751",
6835 "vkCopyAccelerationStructureToMemoryKHR(): pInfo->dst.hostAddress must be aligned to 16 bytes.");
6836 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006837 return skip;
6838}
6839
6840bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
6841 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
6842 bool skip = false;
6843 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
6844 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
6845 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
6846 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
6847 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006848 if (SafeModulo(pInfo->dst.deviceAddress, 256) != 0) {
6849 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pInfo-03740",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006850 "vkCmdCopyAccelerationStructureToMemoryKHR(): pInfo->dst.deviceAddress (0x%" PRIx64 ") must be aligned to 256 bytes.",
sourav parmarcd5fb182020-07-17 12:58:44 -07006851 pInfo->dst.deviceAddress);
sourav parmar83c31b12020-05-06 12:30:54 -07006852 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006853 return skip;
6854}
6855
6856bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
6857 const char *api_name) const {
6858 bool skip = false;
6859 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
6860 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
6861 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
6862 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
6863 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
6864 api_name);
6865 }
6866 return skip;
6867}
6868
6869bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006870 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006871 bool skip = false;
6872 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006873 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006874 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
sourav parmar83c31b12020-05-06 12:30:54 -07006875 skip |= LogError(
sourav parmarcd5fb182020-07-17 12:58:44 -07006876 device, "VUID-vkCopyAccelerationStructureKHR-accelerationStructureHostCommands-03582",
6877 "vkCopyAccelerationStructureKHR: The "
6878 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006879 }
sourav parmara96ab1a2020-04-25 16:28:23 -07006880 return skip;
6881}
6882
6883bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
6884 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
6885 bool skip = false;
6886 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
6887 return skip;
6888}
6889
6890bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06006891 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006892 bool skip = false;
6893 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006894 skip |= LogError(device, "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07006895 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
6896 }
6897 return skip;
6898}
6899
6900bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07006901 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07006902 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07006903 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006904 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006905 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
6906 skip |= LogError(
6907 device, "VUID-vkCopyMemoryToAccelerationStructureKHR-accelerationStructureHostCommands-03583",
6908 "vkCopyMemoryToAccelerationStructureKHR: The "
6909 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07006910 }
sourav parmarcd5fb182020-07-17 12:58:44 -07006911 skip |= validate_required_pointer("vkCopyMemoryToAccelerationStructureKHR", "pInfo->src.hostAddress", pInfo->src.hostAddress,
6912 "VUID-vkCopyMemoryToAccelerationStructureKHR-pInfo-03729");
sourav parmara96ab1a2020-04-25 16:28:23 -07006913 return skip;
6914}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06006915
sourav parmara96ab1a2020-04-25 16:28:23 -07006916bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
6917 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
6918 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07006919 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
sourav parmarcd5fb182020-07-17 12:58:44 -07006920 if (SafeModulo(pInfo->src.deviceAddress, 256) != 0) {
6921 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pInfo-03743",
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06006922 "vkCmdCopyMemoryToAccelerationStructureKHR(): pInfo->src.deviceAddress (0x%" PRIx64 ") must be aligned to 256 bytes.",
sourav parmarcd5fb182020-07-17 12:58:44 -07006923 pInfo->src.deviceAddress);
6924 }
sourav parmar83c31b12020-05-06 12:30:54 -07006925 return skip;
6926}
6927bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
6928 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
6929 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
6930 bool skip = false;
6931 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
6932 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
6933 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
6934 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
6935 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
6936 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
6937 }
6938 return skip;
6939}
6940bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
6941 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
6942 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
6943 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006944 const auto *acc_structure_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006945 if (!acc_structure_features || acc_structure_features->accelerationStructureHostCommands == VK_FALSE) {
6946 skip |= LogError(
6947 device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-accelerationStructureHostCommands-03585",
6948 "vkCmdWriteAccelerationStructuresPropertiesKHR: The "
6949 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
6950 }
sourav parmar83c31b12020-05-06 12:30:54 -07006951 if (dataSize < accelerationStructureCount * stride) {
6952 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
6953 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07006954 "accelerationStructureCount (%" PRIu32 ") *stride(%zu).",
sourav parmar83c31b12020-05-06 12:30:54 -07006955 dataSize, accelerationStructureCount, stride);
6956 }
6957 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
6958 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
6959 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
6960 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
6961 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
6962 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
6963 }
6964 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
6965 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
6966 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
6967 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
6968 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
6969 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
6970 stride);
6971 }
6972 }
6973 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
6974 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
6975 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
6976 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
6977 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
6978 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
6979 stride);
6980 }
6981 }
sourav parmar83c31b12020-05-06 12:30:54 -07006982 return skip;
6983}
6984bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
6985 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
6986 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006987 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006988 if (!raytracing_features || raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE) {
6989 skip |= LogError(
6990 device, "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03606",
6991 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR:VkPhysicalDeviceRayTracingPipelineFeaturesKHR::"
6992 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled to call this function.");
sourav parmar83c31b12020-05-06 12:30:54 -07006993 }
6994 return skip;
6995}
6996
6997bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
sourav parmarcd5fb182020-07-17 12:58:44 -07006998 const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
6999 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable,
7000 const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
7001 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable,
sourav parmar83c31b12020-05-06 12:30:54 -07007002 uint32_t width, uint32_t height, uint32_t depth) const {
7003 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07007004 // RayGen
7005 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
7006 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-size-04023",
7007 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07007008 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007009 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7010 0) {
7011 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03682",
7012 "vkCmdTraceRaysKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
7013 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7014 }
7015 // Callable
7016 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7017 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03694",
7018 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
7019 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007020 }
7021 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7022 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
7023 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07007024 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7025 }
7026 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7027 0) {
7028 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03693",
7029 "vkCmdTraceRaysKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
7030 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007031 }
7032 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007033 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7034 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03690",
7035 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple of "
7036 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007037 }
7038 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7039 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07007040 "vkCmdTraceRaysKHR: TThe stride member of pHitShaderBindingTable must be less than or equal to "
7041 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride");
sourav parmar83c31b12020-05-06 12:30:54 -07007042 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007043 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7044 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03689",
7045 "vkCmdTraceRaysKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
7046 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7047 }
sourav parmar83c31b12020-05-06 12:30:54 -07007048 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007049 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7050 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03686",
7051 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple of "
7052 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment");
sourav parmar83c31b12020-05-06 12:30:54 -07007053 }
7054 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7055 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
7056 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07007057 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7058 }
7059 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7060 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03685",
7061 "vkCmdTraceRaysKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
7062 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7063 }
7064 if (width * depth * height > phys_dev_ext_props.ray_tracing_propsKHR.maxRayDispatchInvocationCount) {
7065 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-width-03629",
7066 "vkCmdTraceRaysKHR: width {times} height {times} depth must be less than or equal to "
7067 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayDispatchInvocationCount");
7068 }
7069 if (width > device_limits.maxComputeWorkGroupCount[0] * device_limits.maxComputeWorkGroupSize[0]) {
7070 skip |=
7071 LogError(device, "VUID-vkCmdTraceRaysKHR-width-03626",
7072 "vkCmdTraceRaysKHR: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[0] "
7073 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[0]");
sourav parmar83c31b12020-05-06 12:30:54 -07007074 }
7075
sourav parmarcd5fb182020-07-17 12:58:44 -07007076 if (height > device_limits.maxComputeWorkGroupCount[1] * device_limits.maxComputeWorkGroupSize[1]) {
7077 skip |=
7078 LogError(device, "VUID-vkCmdTraceRaysKHR-height-03627",
7079 "vkCmdTraceRaysKHR: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1] "
7080 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[1]");
7081 }
7082
7083 if (depth > device_limits.maxComputeWorkGroupCount[2] * device_limits.maxComputeWorkGroupSize[2]) {
7084 skip |=
7085 LogError(device, "VUID-vkCmdTraceRaysKHR-depth-03628",
7086 "vkCmdTraceRaysKHR: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2] "
7087 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[2]");
sourav parmar83c31b12020-05-06 12:30:54 -07007088 }
7089 return skip;
7090}
7091
sourav parmarcd5fb182020-07-17 12:58:44 -07007092bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(
7093 VkCommandBuffer commandBuffer, const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
7094 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable, const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
7095 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable, VkDeviceAddress indirectDeviceAddress) const {
sourav parmar83c31b12020-05-06 12:30:54 -07007096 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007097 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07007098 if (!raytracing_features || raytracing_features->rayTracingPipelineTraceRaysIndirect == VK_FALSE) {
7099 skip |= LogError(
7100 device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingPipelineTraceRaysIndirect-03637",
7101 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineTraceRaysIndirect "
7102 "feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07007103 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007104 // RayGen
7105 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
7106 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-size-04023",
7107 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07007108 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007109 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7110 0) {
7111 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03682",
7112 "vkCmdTraceRaysIndirectKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
7113 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7114 }
7115 // Callabe
7116 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7117 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03694",
7118 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
7119 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007120 }
7121 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7122 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
sourav parmarcd5fb182020-07-17 12:58:44 -07007123 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be less than or equal "
7124 "to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7125 }
7126 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
7127 0) {
7128 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03693",
7129 "vkCmdTraceRaysIndirectKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
7130 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007131 }
7132 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007133 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7134 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03690",
7135 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple of "
7136 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007137 }
7138 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7139 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07007140 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be less than or equal to "
7141 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
sourav parmar83c31b12020-05-06 12:30:54 -07007142 }
sourav parmarcd5fb182020-07-17 12:58:44 -07007143 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7144 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03689",
7145 "vkCmdTraceRaysIndirectKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
7146 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
7147 }
sourav parmar83c31b12020-05-06 12:30:54 -07007148 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07007149 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
7150 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03686",
7151 "vkCmdTraceRaysIndirectKHR:The stride member of pMissShaderBindingTable must be a multiple of "
7152 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007153 }
7154 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
7155 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
sourav parmarcd5fb182020-07-17 12:58:44 -07007156 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be less than or equal to "
7157 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
7158 }
7159 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
7160 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03685",
7161 "vkCmdTraceRaysIndirectKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
7162 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07007163 }
7164
sourav parmarcd5fb182020-07-17 12:58:44 -07007165 if (SafeModulo(indirectDeviceAddress, 4) != 0) {
7166 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-indirectDeviceAddress-03634",
7167 "vkCmdTraceRaysIndirectKHR: indirectDeviceAddress must be a multiple of 4.");
sourav parmar83c31b12020-05-06 12:30:54 -07007168 }
7169 return skip;
7170}
7171bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
7172 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
7173 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
7174 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
7175 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
7176 uint32_t width, uint32_t height, uint32_t depth) const {
7177 bool skip = false;
7178 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7179 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
7180 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
7181 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7182 }
7183 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
7184 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
7185 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
7186 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
7187 }
7188 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
7189 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
7190 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
7191 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
7192 }
7193
7194 // hitShader
7195 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7196 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
7197 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
7198 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7199 }
7200 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
7201 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
7202 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
7203 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
7204 }
7205 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
7206 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
7207 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
7208 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
7209 }
7210
7211 // missShader
7212 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7213 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
7214 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
7215 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7216 }
7217 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
7218 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
7219 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
7220 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
7221 }
7222 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
7223 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
7224 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
7225 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
7226 }
7227
7228 // raygenShader
7229 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
7230 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
7231 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07007232 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
7233 }
7234 if (width > device_limits.maxComputeWorkGroupCount[0]) {
7235 skip |=
7236 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
7237 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
7238 }
7239 if (height > device_limits.maxComputeWorkGroupCount[1]) {
7240 skip |=
7241 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
7242 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
7243 }
7244 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
7245 skip |=
7246 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
7247 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07007248 }
7249 return skip;
7250}
7251
sourav parmar83c31b12020-05-06 12:30:54 -07007252bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07007253 VkDevice device, const VkAccelerationStructureVersionInfoKHR *pVersionInfo,
7254 VkAccelerationStructureCompatibilityKHR *pCompatibility) const {
sourav parmar83c31b12020-05-06 12:30:54 -07007255 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007256 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
7257 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07007258 if ((!raytracing_features && !ray_query_features) || ((ray_query_features && !(ray_query_features->rayQuery)) ||
7259 (raytracing_features && !raytracing_features->rayTracingPipeline))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007260 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracingPipeline-03661",
sourav parmar83c31b12020-05-06 12:30:54 -07007261 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
7262 }
7263 return skip;
7264}
7265
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007266bool StatelessValidation::ValidateCmdSetViewportWithCount(VkCommandBuffer commandBuffer, uint32_t viewportCount,
7267 const VkViewport *pViewports, bool is_ext) const {
Piers Daniell39842ee2020-07-10 16:42:33 -06007268 bool skip = false;
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007269 const char *api_call = is_ext ? "vkCmdSetViewportWithCountEXT" : "vkCmdSetViewportWithCount";
Piers Daniell39842ee2020-07-10 16:42:33 -06007270
7271 if (!physical_device_features.multiViewport) {
7272 if (viewportCount != 1) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007273 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCount-viewportCount-03395",
7274 "%s: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.", api_call,
Piers Daniell39842ee2020-07-10 16:42:33 -06007275 viewportCount);
7276 }
7277 } else { // multiViewport enabled
7278 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007279 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCount-viewportCount-03394",
7280 "%s: viewportCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007281 ") must "
7282 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007283 api_call, viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06007284 }
7285 }
7286
7287 if (pViewports) {
7288 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
7289 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Piers Daniell39842ee2020-07-10 16:42:33 -06007290 skip |= manual_PreCallValidateViewport(
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007291 viewport, api_call, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Piers Daniell39842ee2020-07-10 16:42:33 -06007292 }
7293 }
7294
7295 return skip;
7296}
7297
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007298bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
7299 const VkViewport *pViewports) const {
Piers Daniell39842ee2020-07-10 16:42:33 -06007300 bool skip = false;
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007301 skip = ValidateCmdSetViewportWithCount(commandBuffer, viewportCount, pViewports, true);
7302 return skip;
7303}
7304
7305bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCount(VkCommandBuffer commandBuffer, uint32_t viewportCount,
7306 const VkViewport *pViewports) const {
7307 bool skip = false;
7308 skip = ValidateCmdSetViewportWithCount(commandBuffer, viewportCount, pViewports, false);
7309 return skip;
7310}
7311
7312bool StatelessValidation::ValidateCmdSetScissorWithCount(VkCommandBuffer commandBuffer, uint32_t scissorCount,
7313 const VkRect2D *pScissors, bool is_ext) const {
7314 bool skip = false;
7315 const char *api_call = is_ext ? "vkCmdSetScissorWithCountEXT" : "vkCmdSetScissorWithCount";
Piers Daniell39842ee2020-07-10 16:42:33 -06007316
7317 if (!physical_device_features.multiViewport) {
7318 if (scissorCount != 1) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007319 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-scissorCount-03398",
7320 "%s: scissorCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007321 ") must "
7322 "be 1 when the multiViewport feature is disabled.",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007323 api_call, scissorCount);
Piers Daniell39842ee2020-07-10 16:42:33 -06007324 }
7325 } else { // multiViewport enabled
7326 if (scissorCount == 0) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007327 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-scissorCount-03397",
7328 "%s: scissorCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007329 ") must "
7330 "be great than zero.",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007331 api_call, scissorCount);
Piers Daniell39842ee2020-07-10 16:42:33 -06007332 } else if (scissorCount > device_limits.maxViewports) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007333 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-scissorCount-03397",
7334 "%s: scissorCount (=%" PRIu32
Piers Daniell39842ee2020-07-10 16:42:33 -06007335 ") must "
7336 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007337 api_call, scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06007338 }
7339 }
7340
7341 if (pScissors) {
7342 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
7343 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
7344
7345 if (scissor.offset.x < 0) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007346 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-x-03399", "%s: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", api_call,
7347 scissor_i, scissor.offset.x);
Piers Daniell39842ee2020-07-10 16:42:33 -06007348 }
7349
7350 if (scissor.offset.y < 0) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007351 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-x-03399", "%s: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", api_call,
7352 scissor_i, scissor.offset.y);
Piers Daniell39842ee2020-07-10 16:42:33 -06007353 }
7354
7355 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
7356 if (x_sum > INT32_MAX) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007357 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-offset-03400",
7358 "%s: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64 ") of pScissors[%" PRIu32
7359 "] will overflow int32_t.",
7360 api_call, scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Piers Daniell39842ee2020-07-10 16:42:33 -06007361 }
7362
7363 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
7364 if (y_sum > INT32_MAX) {
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007365 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCount-offset-03401",
7366 "%s: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64 ") of pScissors[%" PRIu32
7367 "] will overflow int32_t.",
7368 api_call, scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
7369 }
7370 }
7371 }
7372
7373 return skip;
7374}
7375
7376bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
7377 const VkRect2D *pScissors) const {
7378 bool skip = false;
7379 skip = ValidateCmdSetScissorWithCount(commandBuffer, scissorCount, pScissors, true);
7380 return skip;
7381}
7382
7383bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCount(VkCommandBuffer commandBuffer, uint32_t scissorCount,
7384 const VkRect2D *pScissors) const {
7385 bool skip = false;
7386 skip = ValidateCmdSetScissorWithCount(commandBuffer, scissorCount, pScissors, false);
7387 return skip;
7388}
7389
7390bool StatelessValidation::ValidateCmdBindVertexBuffers2(VkCommandBuffer commandBuffer, uint32_t firstBinding, uint32_t bindingCount,
7391 const VkBuffer *pBuffers, const VkDeviceSize *pOffsets,
7392 const VkDeviceSize *pSizes, const VkDeviceSize *pStrides,
7393 bool is_2ext) const {
7394 bool skip = false;
7395 const char *api_call = is_2ext ? "vkCmdBindVertexBuffers2EXT()" : "vkCmdBindVertexBuffers2()";
7396 if (firstBinding >= device_limits.maxVertexInputBindings) {
7397 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-firstBinding-03355",
7398 "%s firstBinding (%" PRIu32 ") must be less than maxVertexInputBindings (%" PRIu32 ")", api_call,
7399 firstBinding, device_limits.maxVertexInputBindings);
7400 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
7401 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-firstBinding-03356",
7402 "%s sum of firstBinding (%" PRIu32 ") and bindingCount (%" PRIu32
7403 ") must be less than "
7404 "maxVertexInputBindings (%" PRIu32 ")",
7405 api_call, firstBinding, bindingCount, device_limits.maxVertexInputBindings);
7406 }
7407
7408 for (uint32_t i = 0; i < bindingCount; ++i) {
7409 if (pBuffers[i] == VK_NULL_HANDLE) {
7410 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
7411 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
7412 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-pBuffers-04111",
7413 "%s required parameter pBuffers[%" PRIu32 "] specified as VK_NULL_HANDLE", api_call, i);
7414 } else {
7415 if (pOffsets[i] != 0) {
7416 skip |=
7417 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-pBuffers-04112",
7418 "%s pBuffers[%" PRIu32 "] is VK_NULL_HANDLE, but pOffsets[%" PRIu32 "] is not 0", api_call, i, i);
7419 }
7420 }
7421 }
7422 if (pStrides) {
7423 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
7424 skip |=
7425 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2-pStrides-03362",
7426 "%s pStrides[%" PRIu32 "] (%" PRIu64 ") must be less than maxVertexInputBindingStride (%" PRIu32 ")",
7427 api_call, i, pStrides[i], device_limits.maxVertexInputBindingStride);
Piers Daniell39842ee2020-07-10 16:42:33 -06007428 }
7429 }
7430 }
7431
7432 return skip;
7433}
7434
7435bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
7436 uint32_t bindingCount, const VkBuffer *pBuffers,
7437 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
7438 const VkDeviceSize *pStrides) const {
7439 bool skip = false;
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007440 skip = ValidateCmdBindVertexBuffers2(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets, pSizes, pStrides, true);
7441 return skip;
7442}
Piers Daniell39842ee2020-07-10 16:42:33 -06007443
Tony-LunarG3f953ba2021-10-15 15:35:39 -06007444bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2(VkCommandBuffer commandBuffer, uint32_t firstBinding,
7445 uint32_t bindingCount, const VkBuffer *pBuffers,
7446 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
7447 const VkDeviceSize *pStrides) const {
7448 bool skip = false;
7449 skip = ValidateCmdBindVertexBuffers2(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets, pSizes, pStrides, false);
Piers Daniell39842ee2020-07-10 16:42:33 -06007450 return skip;
7451}
sourav parmarcd5fb182020-07-17 12:58:44 -07007452
7453bool StatelessValidation::ValidateAccelerationStructureBuildGeometryInfoKHR(
7454 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos, uint32_t infoCount, const char *api_name) const {
7455 bool skip = false;
7456 for (uint32_t i = 0; i < infoCount; ++i) {
7457 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
7458 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03654",
7459 "(%s): type must not be VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.", api_name);
7460 }
7461 if (pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
7462 pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
7463 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-flags-03796",
7464 "(%s): If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR bit set,"
7465 "then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.",
7466 api_name);
7467 }
7468 if (pInfos[i].pGeometries && pInfos[i].ppGeometries) {
7469 skip |=
7470 LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-pGeometries-03788",
7471 "(%s): Only one of pGeometries or ppGeometries can be a valid pointer, the other must be NULL", api_name);
7472 }
7473 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pInfos[i].geometryCount != 1) {
7474 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03790",
7475 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, geometryCount must be 1", api_name);
7476 }
7477 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
7478 pInfos[i].geometryCount > phys_dev_ext_props.acc_structure_props.maxGeometryCount) {
7479 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03793",
7480 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then geometryCount must be"
7481 " less than or equal to VkPhysicalDeviceAccelerationStructurePropertiesKHR::maxGeometryCount",
7482 api_name);
7483 }
7484 if (pInfos[i].pGeometries) {
7485 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7486 skip |= validate_ranged_enum(
7487 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometryType", ParameterName::IndexVector{i, j}),
7488 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].pGeometries[j].geometryType,
7489 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
7490 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007491 skip |= validate_struct_type(
7492 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles", ParameterName::IndexVector{i, j}),
7493 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7494 &(pInfos[i].pGeometries[j].geometry.triangles),
7495 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
7496 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
7497 skip |= validate_struct_pnext(
7498 api_name,
7499 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
7500 NULL, pInfos[i].pGeometries[j].geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7501 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
7502 skip |=
7503 validate_ranged_enum(api_name,
7504 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.vertexFormat",
7505 ParameterName::IndexVector{i, j}),
7506 "VkFormat", AllVkFormatEnums, pInfos[i].pGeometries[j].geometry.triangles.vertexFormat,
7507 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
7508 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
7509 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7510 &pInfos[i].pGeometries[j].geometry.triangles,
7511 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
7512 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
7513 skip |= validate_ranged_enum(
7514 api_name,
7515 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.indexType", ParameterName::IndexVector{i, j}),
7516 "VkIndexType", AllVkIndexTypeEnums, pInfos[i].pGeometries[j].geometry.triangles.indexType,
7517 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
7518
7519 if (pInfos[i].pGeometries[j].geometry.triangles.vertexStride > UINT32_MAX) {
7520 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
7521 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
7522 }
7523 if (pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
7524 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
7525 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
7526 skip |=
7527 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
7528 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
7529 api_name);
7530 }
7531 }
7532 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7533 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
7534 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7535 &pInfos[i].pGeometries[j].geometry.instances,
7536 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
7537 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
7538 skip |= validate_struct_type(
7539 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.instances", ParameterName::IndexVector{i, j}),
7540 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7541 &(pInfos[i].pGeometries[j].geometry.instances),
7542 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
7543 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
7544 skip |= validate_struct_pnext(
7545 api_name,
7546 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.pNext", ParameterName::IndexVector{i, j}),
7547 NULL, pInfos[i].pGeometries[j].geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7548 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
7549
7550 skip |= validate_bool32(api_name,
7551 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.arrayOfPointers",
7552 ParameterName::IndexVector{i, j}),
7553 pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers);
7554 }
7555 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7556 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
7557 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7558 &pInfos[i].pGeometries[j].geometry.aabbs,
7559 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
7560 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
7561 skip |= validate_struct_type(
7562 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs", ParameterName::IndexVector{i, j}),
7563 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7564 &(pInfos[i].pGeometries[j].geometry.aabbs),
7565 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
7566 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
7567 skip |= validate_struct_pnext(
7568 api_name,
7569 ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
7570 pInfos[i].pGeometries[j].geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7571 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
7572 if (pInfos[i].pGeometries[j].geometry.aabbs.stride > UINT32_MAX) {
7573 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
7574 "(%s):stride must be less than or equal to 2^32-1", api_name);
7575 }
7576 }
7577 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
7578 pInfos[i].pGeometries[j].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7579 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
7580 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
7581 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7582 api_name);
7583 }
7584 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
7585 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7586 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
7587 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
7588 "of elements of"
7589 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7590 api_name);
7591 }
7592 if (pInfos[i].pGeometries[j].geometryType != pInfos[i].pGeometries[0].geometryType) {
7593 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
7594 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
7595 " member of each geometry in either pGeometries or ppGeometries must be the same.",
7596 api_name);
7597 }
7598 }
7599 }
7600 }
7601 if (pInfos[i].ppGeometries != NULL) {
7602 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7603 skip |= validate_ranged_enum(
7604 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometryType", ParameterName::IndexVector{i, j}),
7605 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].ppGeometries[j]->geometryType,
7606 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
7607 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007608 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
7609 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7610 &pInfos[i].ppGeometries[j]->geometry.triangles,
7611 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
7612 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
7613 skip |= validate_struct_type(
7614 api_name,
7615 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles", ParameterName::IndexVector{i, j}),
7616 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
7617 &(pInfos[i].ppGeometries[j]->geometry.triangles),
7618 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
7619 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
7620 skip |= validate_struct_pnext(
7621 api_name,
7622 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
7623 NULL, pInfos[i].ppGeometries[j]->geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7624 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
7625 skip |= validate_ranged_enum(api_name,
7626 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.vertexFormat",
7627 ParameterName::IndexVector{i, j}),
7628 "VkFormat", AllVkFormatEnums,
7629 pInfos[i].ppGeometries[j]->geometry.triangles.vertexFormat,
7630 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
7631 skip |= validate_ranged_enum(api_name,
7632 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.indexType",
7633 ParameterName::IndexVector{i, j}),
7634 "VkIndexType", AllVkIndexTypeEnums,
7635 pInfos[i].ppGeometries[j]->geometry.triangles.indexType,
7636 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
7637 if (pInfos[i].ppGeometries[j]->geometry.triangles.vertexStride > UINT32_MAX) {
7638 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
7639 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
7640 }
7641 if (pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
7642 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
7643 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
7644 skip |=
7645 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
7646 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
7647 api_name);
7648 }
7649 }
7650 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7651 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
7652 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7653 &pInfos[i].ppGeometries[j]->geometry.instances,
7654 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
7655 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
7656 skip |= validate_struct_type(
7657 api_name,
7658 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances", ParameterName::IndexVector{i, j}),
7659 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
7660 &(pInfos[i].ppGeometries[j]->geometry.instances),
7661 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
7662 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
7663 skip |= validate_struct_pnext(
7664 api_name,
7665 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.pNext", ParameterName::IndexVector{i, j}),
7666 NULL, pInfos[i].ppGeometries[j]->geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7667 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
7668 skip |= validate_bool32(api_name,
7669 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.arrayOfPointers",
7670 ParameterName::IndexVector{i, j}),
7671 pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers);
7672 }
7673 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7674 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
7675 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7676 &pInfos[i].ppGeometries[j]->geometry.aabbs,
7677 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
7678 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
7679 skip |= validate_struct_type(
7680 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs", ParameterName::IndexVector{i, j}),
7681 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
7682 &(pInfos[i].ppGeometries[j]->geometry.aabbs),
7683 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
7684 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
7685 skip |= validate_struct_pnext(
7686 api_name,
7687 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
7688 pInfos[i].ppGeometries[j]->geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
7689 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
7690 if (pInfos[i].ppGeometries[j]->geometry.aabbs.stride > UINT32_MAX) {
7691 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
7692 "(%s):stride must be less than or equal to 2^32-1", api_name);
7693 }
7694 }
7695 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
7696 pInfos[i].ppGeometries[j]->geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7697 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
7698 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
7699 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7700 api_name);
7701 }
7702 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
7703 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7704 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
7705 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
7706 "of elements of"
7707 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
7708 api_name);
7709 }
7710 if (pInfos[i].ppGeometries[j]->geometryType != pInfos[i].ppGeometries[0]->geometryType) {
7711 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
7712 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
7713 " member of each geometry in either pGeometries or ppGeometries must be the same.",
7714 api_name);
7715 }
7716 }
7717 }
7718 }
7719 }
7720 return skip;
7721}
7722bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresKHR(
7723 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
7724 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
7725 bool skip = false;
7726 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresKHR");
7727 for (uint32_t i = 0; i < infoCount; ++i) {
7728 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
7729 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
7730 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03710",
7731 "vkCmdBuildAccelerationStructuresKHR:For each element of pInfos, its "
7732 "scratchData.deviceAddress member must be a multiple of "
7733 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
7734 }
7735 for (uint32_t k = 0; k < infoCount; ++k) {
7736 if (i == k) continue;
7737 bool found = false;
7738 if (pInfos[i].dstAccelerationStructure == pInfos[k].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007739 skip |=
7740 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
7741 "vkCmdBuildAccelerationStructuresKHR:The dstAccelerationStructure member of any element (%" PRIu32
7742 ") of pInfos must "
7743 "not be "
7744 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7745 ") of pInfos.",
7746 i, k);
sourav parmarcd5fb182020-07-17 12:58:44 -07007747 found = true;
7748 }
7749 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007750 skip |=
7751 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03403",
7752 "vkCmdBuildAccelerationStructuresKHR:The srcAccelerationStructure member of any element (%" PRIu32
7753 ") of pInfos must "
7754 "not be "
7755 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7756 ") of pInfos.",
7757 i, k);
sourav parmarcd5fb182020-07-17 12:58:44 -07007758 found = true;
7759 }
7760 if (found) break;
7761 }
7762 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7763 if (pInfos[i].pGeometries) {
7764 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7765 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
7766 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7767 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
7768 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7769 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7770 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7771 }
7772 } else {
7773 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
7774 skip |=
7775 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
7776 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7777 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7778 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7779 }
7780 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007781 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007782 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7783 skip |= LogError(
7784 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
7785 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7786 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7787 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007788 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7789 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007790 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
7791 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
7792 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7793 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7794 }
7795 }
7796 } else if (pInfos[i].ppGeometries) {
7797 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7798 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
7799 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7800 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
7801 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7802 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7803 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7804 }
7805 } else {
7806 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
7807 skip |=
7808 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
7809 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7810 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7811 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7812 }
7813 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007814 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007815 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7816 skip |= LogError(
7817 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
7818 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
7819 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7820 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01007821 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7822 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007823 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
7824 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
7825 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7826 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7827 }
7828 }
7829 }
7830 }
7831 }
7832 return skip;
7833}
7834
7835bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresIndirectKHR(
7836 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
7837 const VkDeviceAddress *pIndirectDeviceAddresses, const uint32_t *pIndirectStrides,
7838 const uint32_t *const *ppMaxPrimitiveCounts) const {
7839 bool skip = false;
7840 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresIndirectKHR");
7841 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007842 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07007843 if (!ray_tracing_acceleration_structure_features ||
7844 ray_tracing_acceleration_structure_features->accelerationStructureIndirectBuild == VK_FALSE) {
7845 skip |= LogError(
7846 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-accelerationStructureIndirectBuild-03650",
7847 "vkCmdBuildAccelerationStructuresIndirectKHR: The "
7848 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureIndirectBuild feature must be enabled.");
7849 }
7850 for (uint32_t i = 0; i < infoCount; ++i) {
sourav parmarcd5fb182020-07-17 12:58:44 -07007851 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
7852 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
7853 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03710",
7854 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, its "
7855 "scratchData.deviceAddress member must be a multiple of "
7856 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
7857 }
7858 for (uint32_t k = 0; k < infoCount; ++k) {
7859 if (i == k) continue;
7860 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007861 skip |= LogError(
7862 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03403",
7863 "vkCmdBuildAccelerationStructuresIndirectKHR:The srcAccelerationStructure member of any element (%" PRIu32
7864 ") "
7865 "of pInfos must not be the same acceleration structure as the dstAccelerationStructure member of "
7866 "any other element [%" PRIu32 ") of pInfos.",
7867 i, k);
sourav parmarcd5fb182020-07-17 12:58:44 -07007868 break;
7869 }
7870 }
7871 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
7872 if (pInfos[i].pGeometries) {
7873 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7874 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
7875 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7876 skip |= LogError(
7877 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
7878 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7879 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7880 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7881 }
7882 } else {
7883 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
7884 skip |= LogError(
7885 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
7886 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7887 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7888 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7889 }
7890 }
7891 }
7892 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7893 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
7894 skip |= LogError(
7895 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
7896 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7897 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7898 }
7899 }
7900 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7901 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.indexData.deviceAddress, 16) != 0) {
7902 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
7903 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
7904 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7905 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7906 }
7907 }
7908 } else if (pInfos[i].ppGeometries) {
7909 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
7910 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
7911 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7912 skip |= LogError(
7913 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
7914 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7915 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
7916 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
7917 }
7918 } else {
7919 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
7920 skip |= LogError(
7921 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
7922 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7923 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
7924 "geometry.data->deviceAddress must be aligned to 16 bytes.");
7925 }
7926 }
7927 }
7928 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
7929 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
7930 skip |= LogError(
7931 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
7932 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
7933 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
7934 }
7935 }
7936 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
7937 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.indexData.deviceAddress, 16) != 0) {
7938 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
7939 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
7940 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
7941 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
7942 }
7943 }
7944 }
7945 }
7946 }
7947 return skip;
7948}
7949
7950bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructuresKHR(
7951 VkDevice device, VkDeferredOperationKHR deferredOperation, uint32_t infoCount,
7952 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
7953 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
7954 bool skip = false;
7955 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkBuildAccelerationStructuresKHR");
7956 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07007957 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07007958 if (!ray_tracing_acceleration_structure_features ||
7959 ray_tracing_acceleration_structure_features->accelerationStructureHostCommands == VK_FALSE) {
7960 skip |=
7961 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581",
7962 "vkBuildAccelerationStructuresKHR: The "
7963 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled");
7964 }
7965 for (uint32_t i = 0; i < infoCount; ++i) {
7966 for (uint32_t j = 0; j < infoCount; ++j) {
7967 if (i == j) continue;
7968 bool found = false;
7969 if (pInfos[i].dstAccelerationStructure == pInfos[j].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007970 skip |=
7971 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
7972 "vkBuildAccelerationStructuresKHR(): The dstAccelerationStructure member of any element (%" PRIu32
7973 ") of pInfos must "
7974 "not be "
7975 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7976 ") of pInfos.",
7977 i, j);
sourav parmarcd5fb182020-07-17 12:58:44 -07007978 found = true;
7979 }
7980 if (pInfos[i].srcAccelerationStructure == pInfos[j].dstAccelerationStructure) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07007981 skip |=
7982 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-pInfos-03403",
7983 "vkBuildAccelerationStructuresKHR(): The srcAccelerationStructure member of any element (%" PRIu32
7984 ") of pInfos must "
7985 "not be "
7986 "the same acceleration structure as the dstAccelerationStructure member of any other element (%" PRIu32
7987 ") of pInfos.",
7988 i, j);
sourav parmarcd5fb182020-07-17 12:58:44 -07007989 found = true;
7990 }
7991 if (found) break;
7992 }
7993 }
7994 return skip;
7995}
7996
7997bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureBuildSizesKHR(
7998 VkDevice device, VkAccelerationStructureBuildTypeKHR buildType, const VkAccelerationStructureBuildGeometryInfoKHR *pBuildInfo,
7999 const uint32_t *pMaxPrimitiveCounts, VkAccelerationStructureBuildSizesInfoKHR *pSizeInfo) const {
8000 bool skip = false;
8001 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pBuildInfo, 1, "vkGetAccelerationStructureBuildSizesKHR");
8002 const auto *ray_tracing_pipeline_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07008003 LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
8004 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
ziga-lunargbcfba982022-03-19 17:49:55 +01008005 if (!((ray_tracing_pipeline_features && ray_tracing_pipeline_features->rayTracingPipeline == VK_TRUE) ||
8006 (ray_query_features && ray_query_features->rayQuery == VK_TRUE))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07008007 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-rayTracingPipeline-03617",
Lars-Ivar Hesselberg Simonsendcd1e402021-11-23 17:14:03 +01008008 "vkGetAccelerationStructureBuildSizesKHR: The rayTracingPipeline or rayQuery feature must be enabled");
8009 }
8010 if (pBuildInfo != nullptr) {
8011 if (pBuildInfo->geometryCount != 0 && pMaxPrimitiveCounts == nullptr) {
8012 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-pBuildInfo-03619",
8013 "vkGetAccelerationStructureBuildSizesKHR: If pBuildInfo->geometryCount is not 0, pMaxPrimitiveCounts "
8014 "must be a valid pointer to an array of pBuildInfo->geometryCount uint32_t values");
8015 }
sourav parmarcd5fb182020-07-17 12:58:44 -07008016 }
8017 return skip;
8018}
sfricke-samsungecafb192021-01-17 08:21:14 -08008019
Piers Daniellcb6d8032021-04-19 18:51:26 -06008020bool StatelessValidation::manual_PreCallValidateCmdSetVertexInputEXT(
8021 VkCommandBuffer commandBuffer, uint32_t vertexBindingDescriptionCount,
8022 const VkVertexInputBindingDescription2EXT *pVertexBindingDescriptions, uint32_t vertexAttributeDescriptionCount,
8023 const VkVertexInputAttributeDescription2EXT *pVertexAttributeDescriptions) const {
8024 bool skip = false;
Piers Daniellcb6d8032021-04-19 18:51:26 -06008025 const auto *vertex_attribute_divisor_features =
8026 LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(device_createinfo_pnext);
8027
Piers Daniellcb6d8032021-04-19 18:51:26 -06008028 // VUID-vkCmdSetVertexInputEXT-vertexBindingDescriptionCount-04791
8029 if (vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
8030 skip |=
8031 LogError(device, "VUID-vkCmdSetVertexInputEXT-vertexBindingDescriptionCount-04791",
8032 "vkCmdSetVertexInputEXT(): vertexBindingDescriptionCount is greater than the maxVertexInputBindings limit");
8033 }
8034
8035 // VUID-vkCmdSetVertexInputEXT-vertexAttributeDescriptionCount-04792
8036 if (vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
8037 skip |= LogError(
8038 device, "VUID-vkCmdSetVertexInputEXT-vertexAttributeDescriptionCount-04792",
8039 "vkCmdSetVertexInputEXT(): vertexAttributeDescriptionCount is greater than the maxVertexInputAttributes limit");
8040 }
8041
8042 // VUID-vkCmdSetVertexInputEXT-binding-04793
8043 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount; ++attribute) {
8044 bool binding_found = false;
8045 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount; ++binding) {
8046 if (pVertexAttributeDescriptions[attribute].binding == pVertexBindingDescriptions[binding].binding) {
8047 binding_found = true;
8048 break;
8049 }
8050 }
8051 if (!binding_found) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008052 skip |= LogError(
8053 device, "VUID-vkCmdSetVertexInputEXT-binding-04793",
8054 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32 "] references an unspecified binding", attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008055 }
8056 }
8057
8058 // VUID-vkCmdSetVertexInputEXT-pVertexBindingDescriptions-04794
8059 if (vertexBindingDescriptionCount > 1) {
8060 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount - 1; ++binding) {
8061 uint32_t binding_value = pVertexBindingDescriptions[binding].binding;
8062 for (uint32_t next_binding = binding + 1; next_binding < vertexBindingDescriptionCount; ++next_binding) {
8063 if (binding_value == pVertexBindingDescriptions[next_binding].binding) {
8064 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-pVertexBindingDescriptions-04794",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008065 "vkCmdSetVertexInputEXT(): binding description for binding %" PRIu32 " already specified",
8066 binding_value);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008067 }
8068 }
8069 }
8070 }
8071
8072 // VUID-vkCmdSetVertexInputEXT-pVertexAttributeDescriptions-04795
8073 if (vertexAttributeDescriptionCount > 1) {
8074 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount - 1; ++attribute) {
8075 uint32_t location = pVertexAttributeDescriptions[attribute].location;
8076 for (uint32_t next_attribute = attribute + 1; next_attribute < vertexAttributeDescriptionCount; ++next_attribute) {
8077 if (location == pVertexAttributeDescriptions[next_attribute].location) {
8078 skip |= LogError(device, "VUID-vkCmdSetVertexInputEXT-pVertexAttributeDescriptions-04795",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008079 "vkCmdSetVertexInputEXT(): attribute description for location %" PRIu32 " already specified",
8080 location);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008081 }
8082 }
8083 }
8084 }
8085
8086 for (uint32_t binding = 0; binding < vertexBindingDescriptionCount; ++binding) {
8087 // VUID-VkVertexInputBindingDescription2EXT-binding-04796
8088 if (pVertexBindingDescriptions[binding].binding > device_limits.maxVertexInputBindings) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008089 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-binding-04796",
8090 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8091 "].binding is greater than maxVertexInputBindings",
8092 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008093 }
8094
8095 // VUID-VkVertexInputBindingDescription2EXT-stride-04797
8096 if (pVertexBindingDescriptions[binding].stride > device_limits.maxVertexInputBindingStride) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008097 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-stride-04797",
8098 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8099 "].stride is greater than maxVertexInputBindingStride",
8100 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008101 }
8102
8103 // VUID-VkVertexInputBindingDescription2EXT-divisor-04798
8104 if (pVertexBindingDescriptions[binding].divisor == 0 &&
8105 (!vertex_attribute_divisor_features || !vertex_attribute_divisor_features->vertexAttributeInstanceRateZeroDivisor)) {
8106 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04798",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008107 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8108 "].divisor is zero but "
Piers Daniellcb6d8032021-04-19 18:51:26 -06008109 "vertexAttributeInstanceRateZeroDivisor is not enabled",
8110 binding);
8111 }
8112
8113 if (pVertexBindingDescriptions[binding].divisor > 1) {
8114 // VUID-VkVertexInputBindingDescription2EXT-divisor-04799
8115 if (!vertex_attribute_divisor_features || !vertex_attribute_divisor_features->vertexAttributeInstanceRateDivisor) {
8116 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-04799",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008117 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8118 "].divisor is greater than one but "
Piers Daniellcb6d8032021-04-19 18:51:26 -06008119 "vertexAttributeInstanceRateDivisor is not enabled",
8120 binding);
8121 } else {
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008122 // VUID-VkVertexInputBindingDescription2EXT-divisor-06226
Piers Daniellcb6d8032021-04-19 18:51:26 -06008123 if (pVertexBindingDescriptions[binding].divisor >
8124 phys_dev_ext_props.vertex_attribute_divisor_props.maxVertexAttribDivisor) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008125 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-06226",
8126 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8127 "].divisor is greater than maxVertexAttribDivisor",
8128 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008129 }
8130
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008131 // VUID-VkVertexInputBindingDescription2EXT-divisor-06227
Piers Daniellcb6d8032021-04-19 18:51:26 -06008132 if (pVertexBindingDescriptions[binding].inputRate != VK_VERTEX_INPUT_RATE_INSTANCE) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008133 skip |= LogError(device, "VUID-VkVertexInputBindingDescription2EXT-divisor-06227",
8134 "vkCmdSetVertexInputEXT(): pVertexBindingDescriptions[%" PRIu32
8135 "].divisor is greater than 1 but inputRate "
8136 "is not VK_VERTEX_INPUT_RATE_INSTANCE",
8137 binding);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008138 }
8139 }
8140 }
8141 }
8142
8143 for (uint32_t attribute = 0; attribute < vertexAttributeDescriptionCount; ++attribute) {
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008144 // VUID-VkVertexInputAttributeDescription2EXT-location-06228
Piers Daniellcb6d8032021-04-19 18:51:26 -06008145 if (pVertexAttributeDescriptions[attribute].location > device_limits.maxVertexInputAttributes) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008146 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-location-06228",
8147 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8148 "].location is greater than maxVertexInputAttributes",
8149 attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008150 }
8151
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008152 // VUID-VkVertexInputAttributeDescription2EXT-binding-06229
Piers Daniellcb6d8032021-04-19 18:51:26 -06008153 if (pVertexAttributeDescriptions[attribute].binding > device_limits.maxVertexInputBindings) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008154 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-binding-06229",
8155 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8156 "].binding is greater than maxVertexInputBindings",
8157 attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008158 }
8159
Mike Schuchardt7b152fa2021-08-03 16:30:27 -07008160 // VUID-VkVertexInputAttributeDescription2EXT-offset-06230
Piers Daniellcb6d8032021-04-19 18:51:26 -06008161 if (pVertexAttributeDescriptions[attribute].offset > device_limits.maxVertexInputAttributeOffset) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008162 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-offset-06230",
8163 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8164 "].offset is greater than maxVertexInputAttributeOffset",
8165 attribute);
Piers Daniellcb6d8032021-04-19 18:51:26 -06008166 }
8167
8168 // VUID-VkVertexInputAttributeDescription2EXT-format-04805
8169 VkFormatProperties properties;
8170 DispatchGetPhysicalDeviceFormatProperties(physical_device, pVertexAttributeDescriptions[attribute].format, &properties);
8171 if ((properties.bufferFeatures & VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT) == 0) {
8172 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription2EXT-format-04805",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008173 "vkCmdSetVertexInputEXT(): pVertexAttributeDescriptions[%" PRIu32
8174 "].format is not a "
Piers Daniellcb6d8032021-04-19 18:51:26 -06008175 "VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT supported format",
8176 attribute);
8177 }
8178 }
8179
8180 return skip;
8181}
sfricke-samsung51303fb2021-05-09 19:09:13 -07008182
8183bool StatelessValidation::manual_PreCallValidateCmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout,
8184 VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size,
8185 const void *pValues) const {
8186 bool skip = false;
8187 const uint32_t max_push_constants_size = device_limits.maxPushConstantsSize;
8188 // Check that offset + size don't exceed the max.
8189 // Prevent arithetic overflow here by avoiding addition and testing in this order.
8190 if (offset >= max_push_constants_size) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008191 skip |=
8192 LogError(device, "VUID-vkCmdPushConstants-offset-00370",
8193 "vkCmdPushConstants(): offset (%" PRIu32 ") that exceeds this device's maxPushConstantSize of %" PRIu32 ".",
8194 offset, max_push_constants_size);
sfricke-samsung51303fb2021-05-09 19:09:13 -07008195 }
8196 if (size > max_push_constants_size - offset) {
8197 skip |= LogError(device, "VUID-vkCmdPushConstants-size-00371",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008198 "vkCmdPushConstants(): offset (%" PRIu32 ") and size (%" PRIu32
8199 ") that exceeds this device's maxPushConstantSize of %" PRIu32 ".",
sfricke-samsung51303fb2021-05-09 19:09:13 -07008200 offset, size, max_push_constants_size);
8201 }
8202
8203 // size needs to be non-zero and a multiple of 4.
8204 if (size & 0x3) {
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008205 skip |= LogError(device, "VUID-vkCmdPushConstants-size-00369",
8206 "vkCmdPushConstants(): size (%" PRIu32 ") must be a multiple of 4.", size);
sfricke-samsung51303fb2021-05-09 19:09:13 -07008207 }
8208
8209 // offset needs to be a multiple of 4.
8210 if ((offset & 0x3) != 0) {
8211 skip |= LogError(device, "VUID-vkCmdPushConstants-offset-00368",
sfricke-samsunga3d4fc12021-09-28 22:25:46 -07008212 "vkCmdPushConstants(): offset (%" PRIu32 ") must be a multiple of 4.", offset);
sfricke-samsung51303fb2021-05-09 19:09:13 -07008213 }
8214 return skip;
Jeremy Gebbenda6b48f2021-05-13 10:46:18 -06008215}
ziga-lunargb1dd8a22021-07-15 17:47:19 +02008216
8217bool StatelessValidation::manual_PreCallValidateMergePipelineCaches(VkDevice device, VkPipelineCache dstCache,
8218 uint32_t srcCacheCount,
8219 const VkPipelineCache *pSrcCaches) const {
8220 bool skip = false;
8221 if (pSrcCaches) {
8222 for (uint32_t index0 = 0; index0 < srcCacheCount; ++index0) {
8223 if (pSrcCaches[index0] == dstCache) {
8224 skip |= LogError(instance, "VUID-vkMergePipelineCaches-dstCache-00770",
8225 "vkMergePipelineCaches(): dstCache %s is in pSrcCaches list.",
8226 report_data->FormatHandle(dstCache).c_str());
8227 break;
8228 }
8229 }
8230 }
8231 return skip;
8232}
Nathaniel Cesario298d3cb2021-08-03 13:49:02 -06008233
8234bool StatelessValidation::manual_PreCallValidateCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image,
8235 VkImageLayout imageLayout, const VkClearColorValue *pColor,
8236 uint32_t rangeCount,
8237 const VkImageSubresourceRange *pRanges) const {
8238 bool skip = false;
8239 if (!pColor) {
8240 skip |=
8241 LogError(commandBuffer, "VUID-vkCmdClearColorImage-pColor-04961", "vkCmdClearColorImage(): pColor must not be null");
8242 }
8243 return skip;
8244}
8245
8246bool StatelessValidation::ValidateCmdBeginRenderPass(const char *const func_name,
8247 const VkRenderPassBeginInfo *const rp_begin) const {
8248 bool skip = false;
8249 if ((rp_begin->clearValueCount != 0) && !rp_begin->pClearValues) {
8250 skip |= LogError(rp_begin->renderPass, "VUID-VkRenderPassBeginInfo-clearValueCount-04962",
8251 "%s: VkRenderPassBeginInfo::clearValueCount != 0 (%" PRIu32
ziga-lunarg47109fb2021-09-03 18:41:12 +02008252 "), but VkRenderPassBeginInfo::pClearValues is null.",
Nathaniel Cesario298d3cb2021-08-03 13:49:02 -06008253 func_name, rp_begin->clearValueCount);
8254 }
8255 return skip;
8256}
8257
8258bool StatelessValidation::manual_PreCallValidateCmdBeginRenderPass(VkCommandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin,
8259 VkSubpassContents) const {
8260 bool skip = ValidateCmdBeginRenderPass("vkCmdBeginRenderPass", pRenderPassBegin);
8261 return skip;
8262}
8263
8264bool StatelessValidation::manual_PreCallValidateCmdBeginRenderPass2KHR(VkCommandBuffer,
8265 const VkRenderPassBeginInfo *pRenderPassBegin,
8266 const VkSubpassBeginInfo *) const {
8267 bool skip = ValidateCmdBeginRenderPass("vkCmdBeginRenderPass2KHR", pRenderPassBegin);
8268 return skip;
8269}
8270
8271bool StatelessValidation::manual_PreCallValidateCmdBeginRenderPass2(VkCommandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin,
8272 const VkSubpassBeginInfo *) const {
8273 bool skip = ValidateCmdBeginRenderPass("vkCmdBeginRenderPass2", pRenderPassBegin);
8274 return skip;
8275}
ziga-lunargc7bb56a2021-08-10 09:28:52 +02008276
8277bool StatelessValidation::manual_PreCallValidateCmdSetDiscardRectangleEXT(VkCommandBuffer commandBuffer,
8278 uint32_t firstDiscardRectangle,
8279 uint32_t discardRectangleCount,
8280 const VkRect2D *pDiscardRectangles) const {
8281 bool skip = false;
8282
8283 if (pDiscardRectangles) {
8284 for (uint32_t i = 0; i < discardRectangleCount; ++i) {
8285 const int64_t x_sum =
8286 static_cast<int64_t>(pDiscardRectangles[i].offset.x) + static_cast<int64_t>(pDiscardRectangles[i].extent.width);
8287 if (x_sum > std::numeric_limits<int32_t>::max()) {
8288 skip |= LogError(device, "VUID-vkCmdSetDiscardRectangleEXT-offset-00588",
8289 "vkCmdSetDiscardRectangleEXT(): offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
8290 ") of pDiscardRectangles[%" PRIu32 "] will overflow int32_t.",
8291 pDiscardRectangles[i].offset.x, pDiscardRectangles[i].extent.width, x_sum, i);
8292 }
8293
8294 const int64_t y_sum =
8295 static_cast<int64_t>(pDiscardRectangles[i].offset.y) + static_cast<int64_t>(pDiscardRectangles[i].extent.height);
8296 if (y_sum > std::numeric_limits<int32_t>::max()) {
8297 skip |= LogError(device, "VUID-vkCmdSetDiscardRectangleEXT-offset-00589",
8298 "vkCmdSetDiscardRectangleEXT(): offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
8299 ") of pDiscardRectangles[%" PRIu32 "] will overflow int32_t.",
8300 pDiscardRectangles[i].offset.y, pDiscardRectangles[i].extent.height, y_sum, i);
8301 }
8302 }
8303 }
8304
8305 return skip;
8306}
ziga-lunarg3c37dfb2021-08-24 12:51:07 +02008307
8308bool StatelessValidation::manual_PreCallValidateGetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery,
8309 uint32_t queryCount, size_t dataSize, void *pData,
8310 VkDeviceSize stride, VkQueryResultFlags flags) const {
8311 bool skip = false;
8312
8313 if ((flags & VK_QUERY_RESULT_WITH_STATUS_BIT_KHR) && (flags & VK_QUERY_RESULT_WITH_AVAILABILITY_BIT)) {
8314 skip |= LogError(device, "VUID-vkGetQueryPoolResults-flags-04811",
8315 "vkGetQueryPoolResults(): flags include both VK_QUERY_RESULT_WITH_STATUS_BIT_KHR bit and VK_QUERY_RESULT_WITH_AVAILABILITY_BIT bit.");
8316 }
8317
8318 return skip;
8319}
ziga-lunargcf340c42021-08-19 00:13:38 +02008320
8321bool StatelessValidation::manual_PreCallValidateCmdBeginConditionalRenderingEXT(
8322 VkCommandBuffer commandBuffer, const VkConditionalRenderingBeginInfoEXT* pConditionalRenderingBegin) const {
8323 bool skip = false;
8324
8325 if ((pConditionalRenderingBegin->offset & 3) != 0) {
8326 skip |= LogError(commandBuffer, "VUID-VkConditionalRenderingBeginInfoEXT-offset-01984",
8327 "vkCmdBeginConditionalRenderingEXT(): pConditionalRenderingBegin->offset (%" PRIu64
8328 ") is not a multiple of 4.",
8329 pConditionalRenderingBegin->offset);
8330 }
8331
8332 return skip;
Jeremy Gebben2e5b41b2021-10-11 16:41:49 -06008333}
Mike Schuchardt05b028d2022-01-05 14:15:00 -08008334
8335bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfaceFormatsKHR(VkPhysicalDevice physicalDevice,
8336 VkSurfaceKHR surface,
8337 uint32_t *pSurfaceFormatCount,
8338 VkSurfaceFormatKHR *pSurfaceFormats) const {
8339 bool skip = false;
8340 if (surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8341 skip |= LogError(
8342 physicalDevice, "VUID-vkGetPhysicalDeviceSurfaceFormatsKHR-surface-06524",
8343 "vkGetPhysicalDeviceSurfaceFormatsKHR(): surface is VK_NULL_HANDLE and VK_GOOGLE_surfaceless_query is not enabled.");
8344 }
8345 return skip;
8346}
8347
8348bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfacePresentModesKHR(VkPhysicalDevice physicalDevice,
8349 VkSurfaceKHR surface,
8350 uint32_t *pPresentModeCount,
8351 VkPresentModeKHR *pPresentModes) const {
8352 bool skip = false;
8353 if (surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8354 skip |= LogError(
8355 physicalDevice, "VUID-vkGetPhysicalDeviceSurfacePresentModesKHR-surface-06524",
8356 "vkGetPhysicalDeviceSurfacePresentModesKHR: surface is VK_NULL_HANDLE and VK_GOOGLE_surfaceless_query is not enabled.");
8357 }
8358 return skip;
8359}
8360
8361bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfaceCapabilities2KHR(
8362 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
8363 VkSurfaceCapabilities2KHR *pSurfaceCapabilities) const {
8364 bool skip = false;
8365 if (pSurfaceInfo && pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8366 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceSurfaceCapabilities2KHR-pSurfaceInfo-06520",
8367 "vkGetPhysicalDeviceSurfaceCapabilities2KHR: pSurfaceInfo->surface is VK_NULL_HANDLE and "
8368 "VK_GOOGLE_surfaceless_query is not enabled.");
8369 }
8370 return skip;
8371}
8372
8373bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfaceFormats2KHR(
8374 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo, uint32_t *pSurfaceFormatCount,
8375 VkSurfaceFormat2KHR *pSurfaceFormats) const {
8376 bool skip = false;
8377 if (pSurfaceInfo && pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8378 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceSurfaceFormats2KHR-pSurfaceInfo-06521",
8379 "vkGetPhysicalDeviceSurfaceFormats2KHR: pSurfaceInfo->surface is VK_NULL_HANDLE and "
8380 "VK_GOOGLE_surfaceless_query is not enabled.");
8381 }
8382 return skip;
8383}
8384
8385#ifdef VK_USE_PLATFORM_WIN32_KHR
8386bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceSurfacePresentModes2EXT(
8387 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo, uint32_t *pPresentModeCount,
8388 VkPresentModeKHR *pPresentModes) const {
8389 bool skip = false;
8390 if (pSurfaceInfo && pSurfaceInfo->surface == VK_NULL_HANDLE && !instance_extensions.vk_google_surfaceless_query) {
8391 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceSurfacePresentModes2EXT-pSurfaceInfo-06521",
8392 "vkGetPhysicalDeviceSurfacePresentModes2EXT: pSurfaceInfo->surface is VK_NULL_HANDLE and "
8393 "VK_GOOGLE_surfaceless_query is not enabled.");
8394 }
8395 return skip;
8396}
ziga-lunarg50f8e6b2021-12-18 20:24:35 +01008397
Mike Schuchardt05b028d2022-01-05 14:15:00 -08008398#endif // VK_USE_PLATFORM_WIN32_KHR
ziga-lunarg50f8e6b2021-12-18 20:24:35 +01008399
8400bool StatelessValidation::ValidateDeviceImageMemoryRequirements(VkDevice device, const VkDeviceImageMemoryRequirementsKHR *pInfo,
8401 const char *func_name) const {
8402 bool skip = false;
8403
8404 if (pInfo && pInfo->pCreateInfo) {
8405 const auto *image_swapchain_create_info = LvlFindInChain<VkImageSwapchainCreateInfoKHR>(pInfo->pCreateInfo);
8406 if (image_swapchain_create_info) {
8407 skip |= LogError(device, "VUID-VkDeviceImageMemoryRequirementsKHR-pCreateInfo-06416",
8408 "%s(): pInfo->pCreateInfo->pNext chain contains VkImageSwapchainCreateInfoKHR.", func_name);
8409 }
8410 }
8411
8412 return skip;
8413}
8414
8415bool StatelessValidation::manual_PreCallValidateGetDeviceImageMemoryRequirementsKHR(
8416 VkDevice device, const VkDeviceImageMemoryRequirements *pInfo, VkMemoryRequirements2 *pMemoryRequirements) const {
8417 bool skip = false;
8418
8419 skip |= ValidateDeviceImageMemoryRequirements(device, pInfo, "vkGetDeviceImageMemoryRequirementsKHR");
8420
8421 return skip;
8422}
8423
8424bool StatelessValidation::manual_PreCallValidateGetDeviceImageSparseMemoryRequirementsKHR(
8425 VkDevice device, const VkDeviceImageMemoryRequirements *pInfo, uint32_t *pSparseMemoryRequirementCount,
8426 VkSparseImageMemoryRequirements2 *pSparseMemoryRequirements) const {
8427 bool skip = false;
8428
8429 skip |= ValidateDeviceImageMemoryRequirements(device, pInfo, "vkGetDeviceImageSparseMemoryRequirementsKHR");
8430
8431 return skip;
8432}