blob: 1ad85f54983fade9c4242143eba9b3937249234c [file] [log] [blame]
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07001/* Copyright (c) 2015-2021 The Khronos Group Inc.
2 * Copyright (c) 2015-2021 Valve Corporation
3 * Copyright (c) 2015-2021 LunarG, Inc.
4 * Copyright (C) 2015-2021 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070028static const int kMaxParamCheckerStringLength = 256;
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinski21b91fe2020-12-03 15:44:24 -070036read_lock_guard_t StatelessValidation::read_lock() { return read_lock_guard_t(validation_object_mutex, std::defer_lock); }
37write_lock_guard_t StatelessValidation::write_lock() { return write_lock_guard_t(validation_object_mutex, std::defer_lock); }
38
Tony-LunarG3c287f62020-12-17 12:39:49 -070039static std::unordered_map<VkCommandBuffer, VkCommandPool> secondary_cb_map{};
40static ReadWriteLock secondary_cb_map_mutex;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -070041static read_lock_guard_t cb_read_lock() { return read_lock_guard_t(secondary_cb_map_mutex); }
42static write_lock_guard_t cb_write_lock() { return write_lock_guard_t(secondary_cb_map_mutex); }
Tony-LunarG3c287f62020-12-17 12:39:49 -070043
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070044bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050045 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060046 bool skip = false;
47
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070048 VkStringErrorFlags result = vk_string_validate(kMaxParamCheckerStringLength, validateString);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50 if (result == VK_STRING_ERROR_NONE) {
51 return skip;
52 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070053 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -070054 kMaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060055 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070056 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
57 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060058 }
59 return skip;
60}
61
Jeff Bolz46c0ea02019-10-09 13:06:29 -050062bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060063 bool skip = false;
64 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
65 if (api_version_nopatch != effective_api_version) {
sfricke-samsung6aec21b2020-11-01 07:49:43 -080066 if ((api_version_nopatch < VK_API_VERSION_1_0) && (api_version != 0)) {
67 skip |= LogError(instance, "VUID-VkApplicationInfo-apiVersion-04010",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070068 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
69 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
70 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060071 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070072 skip |= LogWarning(instance, kVUIDUndefined,
73 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
74 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
75 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060076 }
77 }
78 return skip;
79}
80
Jeff Bolz46c0ea02019-10-09 13:06:29 -050081bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060082 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060083 // Create and use a local instance extension object, as an actual instance has not been created yet
84 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
85 InstanceExtensions local_instance_extensions;
86 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
87
John Zulauf620755c2018-04-16 11:00:43 -060088 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060089 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
90 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060091 }
92
93 return skip;
94}
95
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060096bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
97 if (instance_extensions.vk_khr_get_physical_device_properties_2) {
98 // Struct is legal IF it's supported
99 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
100 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
101 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
102 if (enum_iter != dev_exts_enumerated->second.cend()) {
103 return true;
104 }
105 }
106 return false;
107}
108
Tony-LunarG866843d2020-05-13 11:22:42 -0600109bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
110 const VkValidationFeaturesEXT *validation_features) const {
111 bool skip = false;
112 bool debug_printf = false;
113 bool gpu_assisted = false;
114 bool reserve_slot = false;
115 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
116 switch (validation_features->pEnabledValidationFeatures[i]) {
117 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
118 gpu_assisted = true;
119 break;
120
121 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
122 debug_printf = true;
123 break;
124
125 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
126 reserve_slot = true;
127 break;
128
129 default:
130 break;
131 }
132 }
133 if (reserve_slot && !gpu_assisted) {
134 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
135 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
136 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
137 }
138 if (gpu_assisted && debug_printf) {
139 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
140 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
141 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
142 }
143
144 return skip;
145}
146
John Zulauf620755c2018-04-16 11:00:43 -0600147template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700148ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
149 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600150 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700151 ExtEnabled state =
152 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600153 return state;
154}
155
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700156bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500157 const VkAllocationCallbacks *pAllocator,
158 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700159 bool skip = false;
160 // Note: From the spec--
161 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
162 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
163 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700164 ? pCreateInfo->pApplicationInfo->apiVersion
165 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700166 skip |= validate_api_version(local_api_version, api_version);
167 skip |= validate_instance_extensions(pCreateInfo);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700168 const auto *validation_features = LvlFindInChain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
Tony-LunarG866843d2020-05-13 11:22:42 -0600169 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
170
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700171 return skip;
172}
173
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700174void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700175 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
176 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700177 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
178 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700179 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700180 this->instance_extensions = instance_data->instance_extensions;
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700181}
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600182
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700183void StatelessValidation::CommonPostCallRecordEnumeratePhysicalDevice(const VkPhysicalDevice *phys_devices, const int count) {
184 // Assume phys_devices is valid
185 assert(phys_devices);
186 for (int i = 0; i < count; ++i) {
187 const auto &phys_device = phys_devices[i];
188 if (0 == physical_device_properties_map.count(phys_device)) {
189 auto phys_dev_props = new VkPhysicalDeviceProperties;
190 DispatchGetPhysicalDeviceProperties(phys_device, phys_dev_props);
191 physical_device_properties_map[phys_device] = phys_dev_props;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600192
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700193 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
194 uint32_t ext_count = 0;
195 std::unordered_set<std::string> dev_exts_enumerated{};
196 std::vector<VkExtensionProperties> ext_props{};
197 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, nullptr);
198 ext_props.resize(ext_count);
199 instance_dispatch_table.EnumerateDeviceExtensionProperties(phys_device, nullptr, &ext_count, ext_props.data());
200 for (uint32_t j = 0; j < ext_count; j++) {
201 dev_exts_enumerated.insert(ext_props[j].extensionName);
202 }
203 device_extensions_enumerated[phys_device] = std::move(dev_exts_enumerated);
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600204 }
Nathaniel Cesario645a15b2021-01-08 22:40:21 -0700205 }
206}
207
208void StatelessValidation::PostCallRecordEnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount,
209 VkPhysicalDevice *pPhysicalDevices, VkResult result) {
210 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
211 return;
212 }
213
214 if (pPhysicalDeviceCount && pPhysicalDevices) {
215 CommonPostCallRecordEnumeratePhysicalDevice(pPhysicalDevices, *pPhysicalDeviceCount);
216 }
217}
218
219void StatelessValidation::PostCallRecordEnumeratePhysicalDeviceGroups(
220 VkInstance instance, uint32_t *pPhysicalDeviceGroupCount, VkPhysicalDeviceGroupProperties *pPhysicalDeviceGroupProperties,
221 VkResult result) {
222 if ((VK_SUCCESS != result) && (VK_INCOMPLETE != result)) {
223 return;
224 }
225
226 if (pPhysicalDeviceGroupCount && pPhysicalDeviceGroupProperties) {
227 for (uint32_t i = 0; i < *pPhysicalDeviceGroupCount; i++) {
228 const auto &group = pPhysicalDeviceGroupProperties[i];
229 CommonPostCallRecordEnumeratePhysicalDevice(group.physicalDevices, group.physicalDeviceCount);
230 }
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600231 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700232}
233
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600234void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
235 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
236 delete (it->second);
237 it = physical_device_properties_map.erase(it);
238 }
239};
240
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700241void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700242 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700243 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700244 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700245 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
246 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700247
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700248 // Parmeter validation also uses extension data
249 stateless_validation->device_extensions = this->device_extensions;
250
251 VkPhysicalDeviceProperties device_properties = {};
252 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600253 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700254 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
255
256 if (device_extensions.vk_nv_shading_rate_image) {
257 // Get the needed shading rate image limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700258 auto shading_rate_image_props = LvlInitStruct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
259 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600260 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700261 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
262 }
263
264 if (device_extensions.vk_nv_mesh_shader) {
265 // Get the needed mesh shader limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700266 auto mesh_shader_props = LvlInitStruct<VkPhysicalDeviceMeshShaderPropertiesNV>();
267 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600268 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700269 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
270 }
271
Jason Macnak5c954952019-07-09 15:46:12 -0700272 if (device_extensions.vk_nv_ray_tracing) {
273 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700274 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPropertiesNV>();
275 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jason Macnak5c954952019-07-09 15:46:12 -0700276 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500277 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
278 }
279
sourav parmarcd5fb182020-07-17 12:58:44 -0700280 if (device_extensions.vk_khr_ray_tracing_pipeline) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500281 // Get the needed ray tracing limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700282 auto ray_tracing_props = LvlInitStruct<VkPhysicalDeviceRayTracingPipelinePropertiesKHR>();
283 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&ray_tracing_props);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500284 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
285 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700286 }
287
sourav parmarcd5fb182020-07-17 12:58:44 -0700288 if (device_extensions.vk_khr_acceleration_structure) {
289 // Get the needed ray tracing acc structure limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700290 auto acc_structure_props = LvlInitStruct<VkPhysicalDeviceAccelerationStructurePropertiesKHR>();
291 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&acc_structure_props);
sourav parmarcd5fb182020-07-17 12:58:44 -0700292 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
293 phys_dev_ext_props.acc_structure_props = acc_structure_props;
294 }
295
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700296 if (device_extensions.vk_ext_transform_feedback) {
297 // Get the needed transform feedback limits
Mark Lobodzinski6fe9e702020-12-30 15:36:39 -0700298 auto transform_feedback_props = LvlInitStruct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
299 auto prop2 = LvlInitStruct<VkPhysicalDeviceProperties2>(&transform_feedback_props);
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700300 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
301 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
302 }
303
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800304 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
305
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700306 // Save app-enabled features in this device's validation object
307 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700308 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200309 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
310 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
311 if (features2) {
312 tmp_features2_state.features = features2->features;
313 } else if (pCreateInfo->pEnabledFeatures) {
314 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700315 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200316 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700317 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200318 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700319 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200320 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700321}
322
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700323bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500324 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600325 bool skip = false;
326
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200327 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
328 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
329 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600330 }
331
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700332 // If this device supports VK_KHR_portability_subset, it must be enabled
333 const std::string portability_extension_name("VK_KHR_portability_subset");
334 const auto &dev_extensions = device_extensions_enumerated.at(physicalDevice);
335 const bool portability_supported = dev_extensions.count(portability_extension_name) != 0;
336 bool portability_requested = false;
337
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200338 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
339 skip |=
340 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
341 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
342 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
343 pCreateInfo->ppEnabledExtensionNames[i]);
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700344 if (portability_extension_name == pCreateInfo->ppEnabledExtensionNames[i]) {
345 portability_requested = true;
346 }
347 }
348
349 if (portability_supported && !portability_requested) {
350 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-pProperties-04451",
351 "vkCreateDevice: VK_KHR_portability_subset must be enabled because physical device %s supports it",
352 report_data->FormatHandle(physicalDevice).c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600353 }
354
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200355 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700356 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
357 bool negative_viewport =
358 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200359 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700360 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
361 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
362 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200363 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600364 }
365
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600366 {
367 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
368 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
369 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700370 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
371 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
372 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600373 }
374 }
375
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600376 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
377 // Check for get_physical_device_properties2 struct
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700378 const auto *features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -0600379 if (features2) {
Mike Schuchardt2df08912020-12-15 16:28:09 -0800380 // Cannot include VkPhysicalDeviceFeatures2 and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700381 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mike Schuchardt2df08912020-12-15 16:28:09 -0800382 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct when "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700383 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600384 }
385 }
386
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700387 auto features2 = LvlFindInChain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500388 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700389 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500390 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
391 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
392 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
393 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700394 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(pCreateInfo->pNext);
sourav parmarcd5fb182020-07-17 12:58:44 -0700395 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplayMixed &&
396 !raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay) {
397 skip |= LogError(
398 device,
399 "VUID-VkPhysicalDeviceRayTracingPipelineFeaturesKHR-rayTracingPipelineShaderGroupHandleCaptureReplayMixed-03575",
400 "If rayTracingPipelineShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingPipelineShaderGroupHandleCaptureReplay "
401 "must also be VK_TRUE.");
sourav parmara24fb7b2020-05-26 10:50:04 -0700402 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700403 auto vertex_attribute_divisor_features = LvlFindInChain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600404 if (vertex_attribute_divisor_features && (!device_extensions.vk_ext_vertex_attribute_divisor)) {
405 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
406 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
407 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600408 }
409
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700410 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700411 if (vulkan_11_features) {
412 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
413 while (current) {
414 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
415 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
416 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
417 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
418 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
419 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700420 skip |= LogError(
421 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700422 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
423 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
424 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
425 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
426 break;
427 }
428 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
429 }
sfricke-samsungebda6792021-01-16 08:57:52 -0800430
431 // Check features are enabled if matching extension is passed in as well
432 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
433 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
434 if ((0 == strncmp(extension, VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
435 (vulkan_11_features->shaderDrawParameters == VK_FALSE)) {
436 skip |= LogError(
437 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-04476",
438 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan11Features::shaderDrawParameters is not VK_TRUE.",
439 VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME);
440 }
441 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700442 }
443
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700444 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
Tony-LunarG28017bc2020-01-23 14:40:25 -0700445 if (vulkan_12_features) {
446 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
447 while (current) {
448 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
449 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
450 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
451 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
452 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
453 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
454 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
455 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
456 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
457 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
458 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
459 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
460 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700461 skip |= LogError(
462 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700463 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
464 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
465 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
466 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
467 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
468 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
469 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
470 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
471 break;
472 }
473 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
474 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700475 // Check features are enabled if matching extension is passed in as well
476 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
477 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
478 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
479 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
480 skip |= LogError(
481 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02831",
482 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
483 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
484 }
485 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
486 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
487 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02832",
488 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
489 "is not VK_TRUE.",
490 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
491 }
492 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
493 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
494 skip |= LogError(
495 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02833",
496 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
497 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
498 }
499 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
500 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
501 skip |= LogError(
502 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02834",
503 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
504 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
505 }
506 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
507 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
508 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
509 skip |=
510 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02835",
511 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
512 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
513 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
514 }
515 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700516 }
517
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600518 // Validate pCreateInfo->pQueueCreateInfos
519 if (pCreateInfo->pQueueCreateInfos) {
520 std::unordered_set<uint32_t> set;
521
522 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700523 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
524 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600525 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700526 skip |=
527 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
528 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
529 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
530 "index value.",
531 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600532 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700533 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
534 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
535 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
536 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600537 } else {
538 set.insert(requested_queue_family);
539 }
540
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700541 if (queue_create_info.pQueuePriorities != nullptr) {
542 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
543 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600544 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700545 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
546 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
547 "] (=%f) is not between 0 and 1 (inclusive).",
548 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600549 }
550 }
551 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700552
553 // Need to know if protectedMemory feature is passed in preCall to creating the device
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700554 VkBool32 protected_memory = VK_FALSE;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700555 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700556 LvlFindInChain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700557 if (protected_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700558 protected_memory = protected_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700559 } else if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700560 protected_memory = vulkan_11_features->protectedMemory;
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700561 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700562 if ((queue_create_info.flags == VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) && (protected_memory == VK_FALSE)) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700563 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
564 "vkCreateDevice: pCreateInfo->flags set to VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
565 "protectedMemory feature being set as well.");
566 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600567 }
568 }
569
sfricke-samsung30a57412020-05-15 21:14:54 -0700570 // feature dependencies for VK_KHR_variable_pointers
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700571 const auto *variable_pointers_features = LvlFindInChain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700572 VkBool32 variable_pointers = VK_FALSE;
573 VkBool32 variable_pointers_storage_buffer = VK_FALSE;
sfricke-samsung30a57412020-05-15 21:14:54 -0700574 if (vulkan_11_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700575 variable_pointers = vulkan_11_features->variablePointers;
576 variable_pointers_storage_buffer = vulkan_11_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700577 } else if (variable_pointers_features) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700578 variable_pointers = variable_pointers_features->variablePointers;
579 variable_pointers_storage_buffer = variable_pointers_features->variablePointersStorageBuffer;
sfricke-samsung30a57412020-05-15 21:14:54 -0700580 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700581 if ((variable_pointers == VK_TRUE) && (variable_pointers_storage_buffer == VK_FALSE)) {
sfricke-samsung30a57412020-05-15 21:14:54 -0700582 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
583 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
584 }
585
sfricke-samsungfd76c342020-05-29 23:13:43 -0700586 // feature dependencies for VK_KHR_multiview
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700587 const auto *multiview_features = LvlFindInChain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
sfricke-samsungfd76c342020-05-29 23:13:43 -0700588 VkBool32 multiview = VK_FALSE;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700589 VkBool32 multiview_geometry_shader = VK_FALSE;
590 VkBool32 multiview_tessellation_shader = VK_FALSE;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700591 if (vulkan_11_features) {
592 multiview = vulkan_11_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700593 multiview_geometry_shader = vulkan_11_features->multiviewGeometryShader;
594 multiview_tessellation_shader = vulkan_11_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700595 } else if (multiview_features) {
596 multiview = multiview_features->multiview;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700597 multiview_geometry_shader = multiview_features->multiviewGeometryShader;
598 multiview_tessellation_shader = multiview_features->multiviewTessellationShader;
sfricke-samsungfd76c342020-05-29 23:13:43 -0700599 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700600 if ((multiview == VK_FALSE) && (multiview_geometry_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700601 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
602 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
603 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700604 if ((multiview == VK_FALSE) && (multiview_tessellation_shader == VK_TRUE)) {
sfricke-samsungfd76c342020-05-29 23:13:43 -0700605 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
606 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
607 }
608
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600609 return skip;
610}
611
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500612bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700613 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700614 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
615 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
616 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600617 }
618
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700619 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600620}
621
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700622bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500623 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100624 bool skip = false;
625
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600626 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700627 skip |=
628 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600629
630 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
631 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
632 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
633 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700634 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
635 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
636 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600637 }
638
639 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
640 // queueFamilyIndexCount uint32_t values
641 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700642 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
643 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
644 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
645 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600646 }
647 }
648
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700649 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
650 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
651 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
652 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
653 }
654
655 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
656 skip |=
657 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
658 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
659 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
660 }
661
662 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
663 skip |=
664 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
665 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
666 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
667 }
668
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600669 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
670 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
671 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
672 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700673 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
674 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
675 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600676 }
677 }
678
679 return skip;
680}
681
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700682bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500683 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600684 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600685
686 if (pCreateInfo != nullptr) {
sfricke-samsung61a57c02021-01-10 21:35:12 -0800687 const VkFormat image_format = pCreateInfo->format;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600688 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
689 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
690 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
691 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700692 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
693 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
694 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600695 }
696
697 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
698 // queueFamilyIndexCount uint32_t values
699 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700700 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
701 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
702 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
703 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600704 }
705 }
706
Dave Houlton413a6782018-05-22 13:01:54 -0600707 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700708 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600709 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700710 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600711 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700712 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600713
Dave Houlton413a6782018-05-22 13:01:54 -0600714 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700715 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600716 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700717 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600718
Dave Houlton130c0212018-01-29 13:39:56 -0700719 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700720 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
721 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700722 skip |= LogError(
723 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600724 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
725 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700726 }
727
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600728 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100729 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
730 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700731 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
732 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
733 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600734 }
735
736 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100737 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
738 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700739 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
740 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
741 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
742 ") are not equal.",
743 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100744 }
745
746 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700747 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
748 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
749 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
750 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100751 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600752 }
753
754 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700755 skip |= LogError(
756 device, "VUID-VkImageCreateInfo-imageType-00957",
757 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600758 }
759 }
760
Dave Houlton130c0212018-01-29 13:39:56 -0700761 // 3D image may have only 1 layer
762 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700763 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
764 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700765 }
766
Dave Houlton130c0212018-01-29 13:39:56 -0700767 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
768 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
769 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
770 // At least one of the legal attachment bits must be set
771 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700772 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
773 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700774 }
775 // No flags other than the legal attachment bits may be set
776 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
777 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700778 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
779 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700780 }
781 }
782
Jeff Bolzef40fec2018-09-01 22:04:34 -0500783 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700784 uint32_t max_dim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500785 // Max mip levels is different for corner-sampled images vs normal images.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -0700786 uint32_t max_mip_levels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
787 ? static_cast<uint32_t>(ceil(log2(max_dim)))
788 : static_cast<uint32_t>(floor(log2(max_dim)) + 1);
789 if (max_dim > 0 && pCreateInfo->mipLevels > max_mip_levels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600790 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700791 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
792 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
793 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600794 }
795
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600796 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700797 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
798 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
799 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600800 }
801
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700802 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700803 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
804 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
805 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100806 }
807
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700808 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
809 skip |= LogError(
810 device, "VUID-VkImageCreateInfo-flags-01924",
811 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
812 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
813 }
814
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600815 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
816 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
817 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
818 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700819 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
820 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
821 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600822 }
823
824 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
825 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
826 // Linear tiling is unsupported
827 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700828 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700829 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
830 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600831 }
832
833 // Sparse 1D image isn't valid
834 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700835 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
836 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600837 }
838
839 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700840 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700841 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
842 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
843 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600844 }
845
846 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700847 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700848 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
849 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
850 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600851 }
852
853 // Multi-sample 2D image when device doesn't support it
854 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700855 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600856 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700857 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
858 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
859 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700860 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600861 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700862 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
863 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
864 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700865 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600866 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700867 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
868 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
869 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700870 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600871 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700872 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
873 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
874 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600875 }
876 }
877 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500878
Jeff Bolz9af91c52018-09-01 21:53:57 -0500879 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
880 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700881 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
882 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
883 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500884 }
885 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700886 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
887 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
888 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500889 }
890 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700891 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
892 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
893 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500894 }
895 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500896
897 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600898 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700899 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
900 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
901 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500902 }
903
sfricke-samsung61a57c02021-01-10 21:35:12 -0800904 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(image_format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700905 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
906 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800907 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format (%s) must not be a "
908 "depth/stencil format.",
909 string_VkFormat(image_format));
Jeff Bolzef40fec2018-09-01 22:04:34 -0500910 }
911
Dave Houlton142c4cb2018-10-17 15:04:41 -0600912 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700913 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
914 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
915 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
916 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500917 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600918 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700919 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
920 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
921 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
922 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500923 }
924 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500925
sfricke-samsung8f658d42020-05-03 20:12:24 -0700926 if (((pCreateInfo->flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
sfricke-samsung61a57c02021-01-10 21:35:12 -0800927 (FormatHasDepth(image_format) == false)) {
sfricke-samsung8f658d42020-05-03 20:12:24 -0700928 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
929 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
sfricke-samsung61a57c02021-01-10 21:35:12 -0800930 "format (%s) must be a depth or depth/stencil format.",
931 string_VkFormat(image_format));
sfricke-samsung8f658d42020-05-03 20:12:24 -0700932 }
933
Mark Lobodzinski1f887d32020-12-30 15:31:33 -0700934 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pCreateInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500935 if (image_stencil_struct != nullptr) {
936 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
937 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
938 // No flags other than the legal attachment bits may be set
939 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
940 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700941 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
942 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
943 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
944 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500945 }
946 }
947
sfricke-samsung61a57c02021-01-10 21:35:12 -0800948 if (FormatIsDepthOrStencil(image_format)) {
Andrew Fobel3abeb992020-01-20 16:33:22 -0500949 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
950 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
sfricke-samsungf3a9b5b2021-01-13 13:05:52 -0800951 skip |= LogError(
952 device, "VUID-VkImageCreateInfo-Format-02536",
953 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
954 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width (%u) exceeds device "
955 "maxFramebufferWidth (%u)",
956 pCreateInfo->extent.width, device_limits.maxFramebufferWidth);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500957 }
958
959 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
sfricke-samsungf3a9b5b2021-01-13 13:05:52 -0800960 skip |= LogError(
961 device, "VUID-VkImageCreateInfo-format-02537",
962 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
963 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height (%u) exceeds device "
964 "maxFramebufferHeight (%u)",
965 pCreateInfo->extent.height, device_limits.maxFramebufferHeight);
Andrew Fobel3abeb992020-01-20 16:33:22 -0500966 }
967 }
968
969 if (!physical_device_features.shaderStorageImageMultisample &&
970 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
971 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
972 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700973 LogError(device, "VUID-VkImageCreateInfo-format-02538",
974 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
975 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
976 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500977 }
978
979 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
980 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700981 skip |= LogError(
982 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500983 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
984 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
985 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
986 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
987 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700988 skip |= LogError(
989 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500990 "vkCreateImage(): Depth-stencil image in which usage does not include "
991 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
992 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
993 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
994 }
995
996 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
997 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700998 skip |= LogError(
999 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001000 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1001 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1002 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1003 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
1004 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001005 skip |= LogError(
1006 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -05001007 "vkCreateImage(): Depth-stencil image in which usage does not include "
1008 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
1009 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
1010 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
1011 }
1012 }
1013 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -07001014
1015 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
1016 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
1017 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
1018 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
1019 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
1020 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001021
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001022 std::vector<uint64_t> image_create_drm_format_modifiers;
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001023 if (device_extensions.vk_ext_image_drm_format_modifier) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001024 const auto drm_format_mod_list = LvlFindInChain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
1025 const auto drm_format_mod_explict = LvlFindInChain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001026 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1027 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
1028 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
1029 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
1030 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
1031 "either VkImageDrmFormatModifierListCreateInfoEXT or "
1032 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001033 } else if (drm_format_mod_list != nullptr) {
1034 image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
1035 } else if (drm_format_mod_list != nullptr) {
1036 for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {
1037 image_create_drm_format_modifiers.push_back(*drm_format_mod_list->pDrmFormatModifiers);
1038 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -07001039 }
1040 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
1041 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
1042 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
1043 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
1044 "in the pNext chain");
1045 }
1046 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001047
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001048 static const uint64_t drm_format_mod_linear = 0;
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001049 bool image_create_maybe_linear = false;
1050 if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) {
1051 image_create_maybe_linear = true;
1052 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) {
1053 image_create_maybe_linear = false;
1054 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1055 image_create_maybe_linear =
1056 (std::find(image_create_drm_format_modifiers.begin(), image_create_drm_format_modifiers.end(),
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001057 drm_format_mod_linear) != image_create_drm_format_modifiers.end());
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -07001058 }
1059
1060 // If multi-sample, validate type, usage, tiling and mip levels.
1061 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1062 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1063 (pCreateInfo->mipLevels != 1) || image_create_maybe_linear)) {
1064 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
1065 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
1066 }
1067
1068 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT) &&
1069 ((pCreateInfo->mipLevels != 1) || (pCreateInfo->arrayLayers != 1) || (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) ||
1070 image_create_maybe_linear)) {
1071 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02259",
1072 "vkCreateImage(): Multi-device image with incompatible type, usage, tiling, or mips.");
1073 }
1074
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001075 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
1076 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1077 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
1078 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1079 "imageType must be VK_IMAGE_TYPE_2D.");
1080 }
1081 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1082 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
1083 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1084 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1085 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001086 }
1087 if (pCreateInfo->flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
1088 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1089 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
1090 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1091 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1092 }
1093 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1094 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
1095 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1096 "imageType must be VK_IMAGE_TYPE_2D.");
1097 }
1098 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
1099 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1100 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1101 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1102 }
1103 if (pCreateInfo->mipLevels != 1) {
1104 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
1105 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%d) must be 1.",
1106 pCreateInfo->mipLevels);
1107 }
1108 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001109
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001110 const auto swapchain_create_info = LvlFindInChain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001111 if (swapchain_create_info != nullptr) {
1112 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1113 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1114 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1115 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1116 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1117 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1118
1119 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1120 // also implicitly forces the check above that extent.depth is 1
1121 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1122 string_VkImageType(pCreateInfo->imageType));
1123 }
1124 if (pCreateInfo->mipLevels != 1) {
1125 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %u.", base_message,
1126 pCreateInfo->mipLevels);
1127 }
1128 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1129 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1130 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1131 }
1132 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1133 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1134 base_message, string_VkImageTiling(pCreateInfo->tiling));
1135 }
1136 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1137 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1138 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1139 }
1140 const VkImageCreateFlags valid_flags =
1141 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
Mike Schuchardt2df08912020-12-15 16:28:09 -08001142 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT);
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001143 if ((pCreateInfo->flags & ~valid_flags) != 0) {
1144 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
1145 pCreateInfo->flags);
1146 }
1147 }
1148 }
sfricke-samsung61a57c02021-01-10 21:35:12 -08001149
1150 // If Chroma subsampled format ( _420_ or _422_ )
1151 if (FormatIsXChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.width, 2) != 0)) {
1152 skip |=
1153 LogError(device, "VUID-VkImageCreateInfo-format-04712",
1154 "vkCreateImage(): The format (%s) is X Chroma Subsampled (has _422 or _420 suffix) so the width (=%" PRIu32
1155 ") must be a multiple of 2.",
1156 string_VkFormat(image_format), pCreateInfo->extent.width);
1157 }
1158 if (FormatIsYChromaSubsampled(image_format) && (SafeModulo(pCreateInfo->extent.height, 2) != 0)) {
1159 skip |= LogError(device, "VUID-VkImageCreateInfo-format-04713",
1160 "vkCreateImage(): The format (%s) is Y Chroma Subsampled (has _420 suffix) so the height (=%" PRIu32
1161 ") must be a multiple of 2.",
1162 string_VkFormat(image_format), pCreateInfo->extent.height);
1163 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001164 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001165
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001166 return skip;
1167}
1168
Jeff Bolz99e3f632020-03-24 22:59:22 -05001169bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1170 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1171 bool skip = false;
1172
1173 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001174 // Validate feature set if using CUBE_ARRAY
1175 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1176 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1177 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1178 "enabling the imageCubeArray feature.");
1179 }
1180
Jeff Bolz99e3f632020-03-24 22:59:22 -05001181 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1182 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1183 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
Spencer Fricke528e0982020-04-19 18:46:01 -07001184 "vkCreateImageView(): subresourceRange.layerCount (%d) must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001185 pCreateInfo->subresourceRange.layerCount);
1186 }
1187 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001188 skip |= LogError(
1189 device, "VUID-VkImageViewCreateInfo-viewType-02961",
1190 "vkCreateImageView(): subresourceRange.layerCount (%d) must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1191 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001192 }
1193 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001194
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001195 auto astc_decode_mode = LvlFindInChain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001196 if ((device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
1197 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1198 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1199 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1200 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1201 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1202 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1203 }
1204 if (FormatIsCompressed_ASTC(pCreateInfo->format) == false) {
1205 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1206 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1207 "not an ASTC format.",
1208 string_VkFormat(pCreateInfo->format));
1209 }
1210 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001211
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001212 auto ycbcr_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
sfricke-samsung83d98122020-07-04 06:21:15 -07001213 if (ycbcr_conversion != nullptr) {
1214 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1215 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1216 skip |= LogError(
1217 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1218 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1219 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1220 "r swizzle = %s\n"
1221 "g swizzle = %s\n"
1222 "b swizzle = %s\n"
1223 "a swizzle = %s\n",
1224 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1225 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1226 }
1227 }
1228 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001229 }
1230 return skip;
1231}
1232
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001233bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001234 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001235 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001236
1237 // Note: for numerical correctness
1238 // - float comparisons should expect NaN (comparison always false).
1239 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1240
1241 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001242 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001243 if (v1_f <= 0.0f) return true;
1244
1245 float intpart;
1246 const float fract = modff(v1_f, &intpart);
1247
1248 assert(std::numeric_limits<float>::radix == 2);
1249 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1250 if (intpart >= u32_max_plus1) return false;
1251
1252 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001253 if (v1_u32 < v2_u32) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001254 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001255 } else if (v1_u32 == v2_u32 && fract == 0.0f) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001256 return true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001257 } else {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001258 return false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001259 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01001260 };
1261
1262 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1263 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1264 return (v1_f <= v2_f);
1265 };
1266
1267 // width
1268 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001269 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001270
1271 if (!(viewport.width > 0.0f)) {
1272 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001273 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1274 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001275 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1276 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001277 skip |= LogError(object, "VUID-VkViewport-width-01771",
1278 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1279 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001280 }
1281
1282 // height
1283 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -07001284 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001285 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001286
1287 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1288 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001289 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1290 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001291 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1292 height_healthy = false;
1293
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001294 skip |= LogError(object, "VUID-VkViewport-height-01773",
1295 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1296 ").",
1297 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001298 }
1299
1300 // x
1301 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001302 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001303 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001304 skip |= LogError(object, "VUID-VkViewport-x-01774",
1305 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1306 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001307 }
1308
1309 // x + width
1310 if (x_healthy && width_healthy) {
1311 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001312 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001313 skip |= LogError(
1314 object, "VUID-VkViewport-x-01232",
1315 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1316 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1317 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001318 }
1319 }
1320
1321 // y
1322 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001323 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001324 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001325 skip |= LogError(object, "VUID-VkViewport-y-01775",
1326 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1327 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001328 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001329 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001330 skip |= LogError(object, "VUID-VkViewport-y-01776",
1331 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1332 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001333 }
1334
1335 // y + height
1336 if (y_healthy && height_healthy) {
1337 const float boundary = viewport.y + viewport.height;
1338
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001339 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001340 skip |= LogError(object, "VUID-VkViewport-y-01233",
1341 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1342 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1343 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001344 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001345 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001346 LogError(object, "VUID-VkViewport-y-01777",
1347 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1348 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1349 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001350 }
1351 }
1352
sfricke-samsungfd06d422021-01-22 02:17:21 -08001353 // The extension was not created with a feature bit whichs prevents displaying the 2 variations of the VUIDs
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001354 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001355 // minDepth
1356 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001357 // Also VUID-VkViewport-minDepth-02540
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001358 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001359 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1360 "[0.0, 1.0] range.",
1361 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001362 }
1363
1364 // maxDepth
1365 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
sfricke-samsungfd06d422021-01-22 02:17:21 -08001366 // Also VUID-VkViewport-maxDepth-02541
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001367 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001368 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1369 "[0.0, 1.0] range.",
1370 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001371 }
1372 }
1373
1374 return skip;
1375}
1376
Dave Houlton142c4cb2018-10-17 15:04:41 -06001377struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001378 VkShadingRatePaletteEntryNV shadingRate;
1379 uint32_t width;
1380 uint32_t height;
1381};
1382
1383// All palette entries with more than one pixel per fragment
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001384static SampleOrderInfo sample_order_infos[] = {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001385 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1386 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1387 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1388 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1389 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1390 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001391};
1392
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001393bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001394 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001395
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001396 SampleOrderInfo *sample_order_info;
1397 uint32_t info_idx = 0;
1398 for (sample_order_info = nullptr; info_idx < ARRAY_SIZE(sample_order_infos); ++info_idx) {
1399 if (sample_order_infos[info_idx].shadingRate == order->shadingRate) {
1400 sample_order_info = &sample_order_infos[info_idx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001401 break;
1402 }
1403 }
1404
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001405 if (sample_order_info == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001406 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1407 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1408 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001409 return skip;
1410 }
1411
Dave Houlton142c4cb2018-10-17 15:04:41 -06001412 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001413 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001414 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1415 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1416 ") must "
1417 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1418 "is set in framebufferNoAttachmentsSampleCounts.",
1419 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001420 }
1421
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001422 if (order->sampleLocationCount != order->sampleCount * sample_order_info->width * sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001423 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1424 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1425 ") must "
1426 "be equal to the product of sampleCount (=%" PRIu32
1427 "), the fragment width for shadingRate "
1428 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001429 order->sampleLocationCount, order->sampleCount, sample_order_info->width, sample_order_info->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001430 }
1431
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001432 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001433 skip |= LogError(
1434 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001435 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1436 ") must "
1437 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001438 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001439 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001440
1441 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001442 // the first width*height*sampleCount bits to all be set. Note: There is no
1443 // guarantee that 64 bits is enough, but practically it's unlikely for an
1444 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001445 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001446 uint64_t sample_locations_mask = 0;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001447 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001448 const VkCoarseSampleLocationNV *sample_loc = &order->pSampleLocations[i];
1449 if (sample_loc->pixelX >= sample_order_info->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001450 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1451 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001452 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001453 if (sample_loc->pixelY >= sample_order_info->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001454 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1455 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001456 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001457 if (sample_loc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001458 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1459 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001460 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001461 uint32_t idx =
1462 sample_loc->sample + order->sampleCount * (sample_loc->pixelX + sample_order_info->width * sample_loc->pixelY);
1463 sample_locations_mask |= 1ULL << idx;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001464 }
1465
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001466 uint64_t expected_mask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1467 if (sample_locations_mask != expected_mask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001468 skip |= LogError(
1469 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001470 "The array pSampleLocations must contain exactly one entry for "
1471 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001472 }
1473
1474 return skip;
1475}
1476
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001477bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1478 uint32_t createInfoCount,
1479 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1480 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001481 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001482 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001483
1484 if (pCreateInfos != nullptr) {
1485 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001486 bool has_dynamic_viewport = false;
1487 bool has_dynamic_scissor = false;
1488 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001489 bool has_dynamic_depth_bias = false;
1490 bool has_dynamic_blend_constant = false;
1491 bool has_dynamic_depth_bounds = false;
1492 bool has_dynamic_stencil_compare = false;
1493 bool has_dynamic_stencil_write = false;
1494 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001495 bool has_dynamic_viewport_w_scaling_nv = false;
1496 bool has_dynamic_discard_rectangle_ext = false;
1497 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001498 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001499 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001500 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001501 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001502 bool has_dynamic_cull_mode = false;
1503 bool has_dynamic_front_face = false;
1504 bool has_dynamic_primitive_topology = false;
1505 bool has_dynamic_viewport_with_count = false;
1506 bool has_dynamic_scissor_with_count = false;
1507 bool has_dynamic_vertex_input_binding_stride = false;
1508 bool has_dynamic_depth_test_enable = false;
1509 bool has_dynamic_depth_write_enable = false;
1510 bool has_dynamic_depth_compare_op = false;
1511 bool has_dynamic_depth_bounds_test_enable = false;
1512 bool has_dynamic_stencil_test_enable = false;
1513 bool has_dynamic_stencil_op = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07001514 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
1515 skip |=
1516 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03377",
1517 "vkCreateGraphicsPipelines: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR");
1518 }
Petr Kraus299ba622017-11-24 03:09:03 +01001519 if (pCreateInfos[i].pDynamicState != nullptr) {
1520 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1521 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1522 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001523 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1524 if (has_dynamic_viewport == true) {
1525 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1526 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1527 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1528 i);
1529 }
1530 has_dynamic_viewport = true;
1531 }
1532 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1533 if (has_dynamic_scissor == true) {
1534 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1535 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1536 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1537 i);
1538 }
1539 has_dynamic_scissor = true;
1540 }
1541 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1542 if (has_dynamic_line_width == true) {
1543 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1544 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1545 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1546 i);
1547 }
1548 has_dynamic_line_width = true;
1549 }
1550 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1551 if (has_dynamic_depth_bias == true) {
1552 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1553 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1554 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1555 i);
1556 }
1557 has_dynamic_depth_bias = true;
1558 }
1559 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1560 if (has_dynamic_blend_constant == true) {
1561 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1562 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1563 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1564 i);
1565 }
1566 has_dynamic_blend_constant = true;
1567 }
1568 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1569 if (has_dynamic_depth_bounds == true) {
1570 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1571 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1572 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1573 i);
1574 }
1575 has_dynamic_depth_bounds = true;
1576 }
1577 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1578 if (has_dynamic_stencil_compare == true) {
1579 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1580 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1581 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1582 i);
1583 }
1584 has_dynamic_stencil_compare = true;
1585 }
1586 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1587 if (has_dynamic_stencil_write == true) {
1588 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1589 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1590 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1591 i);
1592 }
1593 has_dynamic_stencil_write = true;
1594 }
1595 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1596 if (has_dynamic_stencil_reference == true) {
1597 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1598 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1599 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1600 i);
1601 }
1602 has_dynamic_stencil_reference = true;
1603 }
1604 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1605 if (has_dynamic_viewport_w_scaling_nv == true) {
1606 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1607 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1608 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1609 i);
1610 }
1611 has_dynamic_viewport_w_scaling_nv = true;
1612 }
1613 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1614 if (has_dynamic_discard_rectangle_ext == true) {
1615 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1616 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1617 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1618 i);
1619 }
1620 has_dynamic_discard_rectangle_ext = true;
1621 }
1622 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1623 if (has_dynamic_sample_locations_ext == true) {
1624 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1625 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1626 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1627 i);
1628 }
1629 has_dynamic_sample_locations_ext = true;
1630 }
1631 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1632 if (has_dynamic_exclusive_scissor_nv == true) {
1633 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1634 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1635 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1636 i);
1637 }
1638 has_dynamic_exclusive_scissor_nv = true;
1639 }
1640 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1641 if (has_dynamic_shading_rate_palette_nv == true) {
1642 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1643 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1644 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1645 i);
1646 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001647 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001648 }
1649 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1650 if (has_dynamic_viewport_course_sample_order_nv == true) {
1651 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1652 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1653 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1654 i);
1655 }
1656 has_dynamic_viewport_course_sample_order_nv = true;
1657 }
1658 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1659 if (has_dynamic_line_stipple == true) {
1660 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1661 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1662 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1663 i);
1664 }
1665 has_dynamic_line_stipple = true;
1666 }
Piers Daniell39842ee2020-07-10 16:42:33 -06001667 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
1668 if (has_dynamic_cull_mode) {
1669 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1670 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
1671 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1672 i);
1673 }
1674 has_dynamic_cull_mode = true;
1675 }
1676 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
1677 if (has_dynamic_front_face) {
1678 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1679 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
1680 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1681 i);
1682 }
1683 has_dynamic_front_face = true;
1684 }
1685 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
1686 if (has_dynamic_primitive_topology) {
1687 skip |= LogError(
1688 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1689 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
1690 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1691 i);
1692 }
1693 has_dynamic_primitive_topology = true;
1694 }
1695 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
1696 if (has_dynamic_viewport_with_count) {
1697 skip |= LogError(
1698 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1699 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
1700 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1701 i);
1702 }
1703 has_dynamic_viewport_with_count = true;
1704 }
1705 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
1706 if (has_dynamic_scissor_with_count) {
1707 skip |= LogError(
1708 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1709 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
1710 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1711 i);
1712 }
1713 has_dynamic_scissor_with_count = true;
1714 }
1715 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
1716 if (has_dynamic_vertex_input_binding_stride) {
1717 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1718 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
1719 "listed twice in the "
1720 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1721 i);
1722 }
1723 has_dynamic_vertex_input_binding_stride = true;
1724 }
1725 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
1726 if (has_dynamic_depth_test_enable) {
1727 skip |= LogError(
1728 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1729 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
1730 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1731 i);
1732 }
1733 has_dynamic_depth_test_enable = true;
1734 }
1735 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
1736 if (has_dynamic_depth_write_enable) {
1737 skip |= LogError(
1738 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1739 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
1740 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1741 i);
1742 }
1743 has_dynamic_depth_write_enable = true;
1744 }
1745 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
1746 if (has_dynamic_depth_compare_op) {
1747 skip |=
1748 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1749 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
1750 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1751 i);
1752 }
1753 has_dynamic_depth_compare_op = true;
1754 }
1755 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
1756 if (has_dynamic_depth_bounds_test_enable) {
1757 skip |= LogError(
1758 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1759 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
1760 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1761 i);
1762 }
1763 has_dynamic_depth_bounds_test_enable = true;
1764 }
1765 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
1766 if (has_dynamic_stencil_test_enable) {
1767 skip |= LogError(
1768 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1769 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
1770 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1771 i);
1772 }
1773 has_dynamic_stencil_test_enable = true;
1774 }
1775 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
1776 if (has_dynamic_stencil_op) {
1777 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1778 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
1779 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1780 i);
1781 }
1782 has_dynamic_stencil_op = true;
1783 }
Petr Kraus299ba622017-11-24 03:09:03 +01001784 }
1785 }
1786
sfricke-samsung3b944422021-01-23 02:15:19 -08001787 if (has_dynamic_viewport_with_count && has_dynamic_viewport) {
1788 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04132",
1789 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT and "
1790 "VK_DYNAMIC_STATE_VIEWPORT both listed in pCreateInfos[%d].pDynamicState->pDynamicStates array",
1791 i);
1792 }
1793
1794 if (has_dynamic_scissor_with_count && has_dynamic_scissor) {
1795 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04133",
1796 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT and VK_DYNAMIC_STATE_SCISSOR "
1797 "both listed in pCreateInfos[%d].pDynamicState->pDynamicStates array",
1798 i);
1799 }
1800
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07001801 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04001802 if ((feedback_struct != nullptr) &&
1803 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001804 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1805 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1806 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1807 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1808 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001809 }
1810
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001811 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001812
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001813 // Collect active stages and other information
1814 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001815 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001816 bool has_eval = false;
1817 bool has_control = false;
1818 if (pCreateInfos[i].pStages != nullptr) {
1819 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1820 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1821
1822 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1823 has_control = true;
1824 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1825 has_eval = true;
1826 }
1827
1828 skip |= validate_string(
1829 "vkCreateGraphicsPipelines",
1830 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1831 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1832 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001833 }
1834
1835 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1836 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1837 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1838 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1839 pCreateInfos[i].pTessellationState,
1840 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1841 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1842
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001843 const VkStructureType allowed_structs_vk_pipeline_tessellation_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001844 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1845
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001846 skip |= validate_struct_pnext(
1847 "vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1848 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext,
1849 ARRAY_SIZE(allowed_structs_vk_pipeline_tessellation_state_create_info),
1850 allowed_structs_vk_pipeline_tessellation_state_create_info, GeneratedVulkanHeaderVersion,
1851 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1852 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001853
1854 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1855 pCreateInfos[i].pTessellationState->flags,
1856 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1857 }
1858
1859 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1860 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1861 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1862 pCreateInfos[i].pInputAssemblyState,
1863 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1864 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1865
1866 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1867 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001868 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001869
1870 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1871 pCreateInfos[i].pInputAssemblyState->flags,
1872 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1873
1874 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1875 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1876 pCreateInfos[i].pInputAssemblyState->topology,
1877 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1878
1879 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1880 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1881 }
1882
1883 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001884 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001885
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001886 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001887 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1888 "vkCreateGraphicsPipelines: pararameter "
1889 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1890 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001891 }
1892
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001893 const VkStructureType allowed_structs_vk_pipeline_vertex_input_state_create_info[] = {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001894 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1895 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1896 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1897 pCreateInfos[i].pVertexInputState->pNext, 1,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001898 allowed_structs_vk_pipeline_vertex_input_state_create_info,
1899 GeneratedVulkanHeaderVersion, "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08001900 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001901 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1902 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001903 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001904 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1905 skip |=
1906 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1907 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1908 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1909 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1910 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1911
1912 skip |= validate_array(
1913 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1914 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1915 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1916 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1917
1918 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001919 for (uint32_t vertex_binding_description_index = 0;
1920 vertex_binding_description_index < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1921 ++vertex_binding_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001922 skip |= validate_ranged_enum(
1923 "vkCreateGraphicsPipelines",
1924 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1925 AllVkVertexInputRateEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001926 pCreateInfos[i]
1927 .pVertexInputState->pVertexBindingDescriptions[vertex_binding_description_index]
1928 .inputRate,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001929 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1930 }
1931 }
1932
1933 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001934 for (uint32_t vertex_attribute_description_index = 0;
1935 vertex_attribute_description_index < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1936 ++vertex_attribute_description_index) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001937 skip |= validate_ranged_enum(
1938 "vkCreateGraphicsPipelines",
1939 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1940 AllVkFormatEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07001941 pCreateInfos[i]
1942 .pVertexInputState->pVertexAttributeDescriptions[vertex_attribute_description_index]
1943 .format,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001944 "VUID-VkVertexInputAttributeDescription-format-parameter");
1945 }
1946 }
1947
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001948 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001949 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1950 "vkCreateGraphicsPipelines: pararameter "
1951 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1952 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1953 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001954 }
1955
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001956 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001957 skip |=
1958 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1959 "vkCreateGraphicsPipelines: pararameter "
1960 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1961 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1962 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001963 }
1964
1965 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001966 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1967 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001968 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1969 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001970 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1971 "vkCreateGraphicsPipelines: parameter "
1972 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1973 "(%" PRIu32 ") is not distinct.",
1974 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001975 }
1976 vertex_bindings.insert(vertex_bind_desc.binding);
1977
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001978 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001979 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1980 "vkCreateGraphicsPipelines: parameter "
1981 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1982 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1983 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001984 }
1985
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001986 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001987 skip |=
1988 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1989 "vkCreateGraphicsPipelines: parameter "
1990 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1991 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1992 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001993 }
1994 }
1995
Peter Kohautc7d9d392018-07-15 00:34:07 +02001996 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001997 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1998 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001999 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
2000 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002001 skip |= LogError(
2002 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02002003 "vkCreateGraphicsPipelines: parameter "
2004 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
2005 i, d, vertex_attrib_desc.location);
2006 }
2007 attribute_locations.insert(vertex_attrib_desc.location);
2008
2009 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
2010 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002011 skip |= LogError(
2012 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02002013 "vkCreateGraphicsPipelines: parameter "
2014 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
2015 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
2016 i, d, vertex_attrib_desc.binding, i);
2017 }
2018
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002019 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002020 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
2021 "vkCreateGraphicsPipelines: parameter "
2022 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
2023 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
2024 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002025 }
2026
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002027 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002028 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
2029 "vkCreateGraphicsPipelines: parameter "
2030 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
2031 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
2032 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002033 }
2034
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002035 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002036 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
2037 "vkCreateGraphicsPipelines: parameter "
2038 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
2039 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
2040 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002041 }
2042 }
2043 }
2044
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002045 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
2046 if (has_control && has_eval) {
2047 if (pCreateInfos[i].pTessellationState == nullptr) {
2048 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
2049 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
2050 "shader stage and a tessellation evaluation shader stage, "
2051 "pCreateInfos[%d].pTessellationState must not be NULL.",
2052 i, i);
2053 } else {
2054 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
2055 skip |= validate_struct_pnext(
2056 "vkCreateGraphicsPipelines",
2057 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
2058 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
2059 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
2060 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002061
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002062 skip |= validate_reserved_flags(
2063 "vkCreateGraphicsPipelines",
2064 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
2065 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002066
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07002067 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
2068 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
2069 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
2070 "vkCreateGraphicsPipelines: invalid parameter "
2071 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
2072 "should be >0 and <=%u.",
2073 i, pCreateInfos[i].pTessellationState->patchControlPoints,
2074 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002075 }
2076 }
2077 }
2078
2079 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
2080 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
2081 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
2082 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002083 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
2084 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
2085 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
2086 "].pViewportState (=NULL) is not a valid pointer.",
2087 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002088 } else {
Petr Krausa6103552017-11-16 21:21:58 +01002089 const auto &viewport_state = *pCreateInfos[i].pViewportState;
2090
2091 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002092 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
2093 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2094 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
2095 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002096 }
2097
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002098 const VkStructureType allowed_structs_vk_pipeline_viewport_state_create_info[] = {
Petr Krausa6103552017-11-16 21:21:58 +01002099 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002100 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
2101 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05002102 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
2103 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002104 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002105 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002106 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01002107 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05002108 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05002109 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
2110 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002111 viewport_state.pNext, ARRAY_SIZE(allowed_structs_vk_pipeline_viewport_state_create_info),
2112 allowed_structs_vk_pipeline_viewport_state_create_info, 65,
2113 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
sfricke-samsung32a27362020-02-28 09:06:42 -08002114 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002115
2116 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002117 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002118 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002119 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002120
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002121 auto exclusive_scissor_struct =
2122 LvlFindInChain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
2123 auto shading_rate_image_struct =
2124 LvlFindInChain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
2125 auto coarse_sample_order_struct =
2126 LvlFindInChain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01002127 const auto vp_swizzle_struct =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002128 LvlFindInChain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002129 const auto vp_w_scaling_struct =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002130 LvlFindInChain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002131
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002132 if (!physical_device_features.multiViewport) {
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002133 if (!has_dynamic_viewport_with_count && (viewport_state.viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002134 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2135 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2136 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2137 ") is not 1.",
2138 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002139 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002140
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002141 if (!has_dynamic_scissor_with_count && (viewport_state.scissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002142 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2143 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2144 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2145 ") is not 1.",
2146 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002147 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002148
Dave Houlton142c4cb2018-10-17 15:04:41 -06002149 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2150 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002151 skip |= LogError(
2152 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2153 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2154 "disabled, but pCreateInfos[%" PRIu32
2155 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2156 ") is not 1.",
2157 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002158 }
2159
Jeff Bolz9af91c52018-09-01 21:53:57 -05002160 if (shading_rate_image_struct &&
2161 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002162 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2163 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2164 "disabled, but pCreateInfos[%" PRIu32
2165 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2166 ") is neither 0 nor 1.",
2167 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002168 }
2169
Petr Krausa6103552017-11-16 21:21:58 +01002170 } else { // multiViewport enabled
2171 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002172 if (!has_dynamic_viewport_with_count) {
2173 skip |= LogError(
2174 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2175 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2176 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002177 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002178 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2179 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2180 "].pViewportState->viewportCount (=%" PRIu32
2181 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2182 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002183 } else if (has_dynamic_viewport_with_count) {
2184 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2185 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2186 "].pViewportState->viewportCount (=%" PRIu32
2187 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2188 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002189 }
Petr Krausa6103552017-11-16 21:21:58 +01002190
2191 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002192 if (!has_dynamic_scissor_with_count) {
2193 skip |= LogError(
2194 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
2195 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2196 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002197 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002198 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2199 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2200 "].pViewportState->scissorCount (=%" PRIu32
2201 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2202 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002203 } else if (has_dynamic_scissor_with_count) {
2204 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380",
2205 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2206 "].pViewportState->scissorCount (=%" PRIu32
2207 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2208 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002209 }
2210 }
2211
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002212 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002213 skip |=
2214 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2215 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2216 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2217 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002218 }
2219
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002220 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002221 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2222 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2223 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2224 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2225 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002226 }
2227
Piers Daniell39842ee2020-07-10 16:42:33 -06002228 if (viewport_state.scissorCount != viewport_state.viewportCount &&
2229 !(has_dynamic_viewport_with_count || has_dynamic_scissor_with_count)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002230 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
2231 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2232 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
2233 "].pViewportState->viewportCount (=%" PRIu32 ").",
2234 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002235 }
2236
Dave Houlton142c4cb2018-10-17 15:04:41 -06002237 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002238 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002239 skip |=
2240 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2241 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2242 ") must be zero or identical to pCreateInfos[%" PRIu32
2243 "].pViewportState->viewportCount (=%" PRIu32 ").",
2244 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002245 }
2246
Dave Houlton142c4cb2018-10-17 15:04:41 -06002247 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002248 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002249 skip |= LogError(
2250 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002251 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2252 "] "
2253 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2254 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2255 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002256 }
2257
Petr Krausa6103552017-11-16 21:21:58 +01002258 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002259 skip |= LogError(
2260 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002261 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2262 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002263 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2264 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002265 }
2266
2267 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002268 skip |= LogError(
2269 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002270 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2271 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002272 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2273 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002274 }
2275
Jeff Bolz3e71f782018-08-29 23:15:45 -05002276 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002277 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2278 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2279 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002280 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002281 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2282 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2283 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2284 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002285 }
2286
Jeff Bolz9af91c52018-09-01 21:53:57 -05002287 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002288 shading_rate_image_struct->viewportCount > 0 &&
2289 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002290 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002291 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002292 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002293 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2294 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002295 i, i);
2296 }
2297
Chris Mayer328d8212018-12-11 14:16:18 +01002298 if (vp_swizzle_struct) {
2299 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002300 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2301 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2302 " does "
2303 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2304 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002305 }
2306 }
2307
Petr Krausb3fcdb42018-01-09 22:09:09 +01002308 // validate the VkViewports
2309 if (!has_dynamic_viewport && viewport_state.pViewports) {
2310 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2311 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002312 const char *fn_name = "vkCreateGraphicsPipelines";
2313 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2314 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2315 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002316 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002317 }
2318 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002319
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002320 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002321 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2322 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2323 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2324 "VK_NV_clip_space_w_scaling extension is not enabled.",
2325 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002326 }
2327
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002328 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002329 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2330 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2331 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2332 "VK_EXT_discard_rectangles extension is not enabled.",
2333 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002334 }
2335
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002336 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002337 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2338 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2339 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2340 "VK_EXT_sample_locations extension is not enabled.",
2341 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002342 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002343
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002344 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002345 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2346 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2347 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2348 "VK_NV_scissor_exclusive extension is not enabled.",
2349 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002350 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002351
2352 if (coarse_sample_order_struct &&
2353 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2354 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002355 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2356 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2357 "] "
2358 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2359 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2360 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002361 }
2362
2363 if (coarse_sample_order_struct) {
2364 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002365 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002366 }
2367 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002368
2369 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2370 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002371 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2372 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2373 "] "
2374 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2375 ") "
2376 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2377 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002378 }
2379 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002380 skip |= LogError(
2381 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002382 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2383 "] "
2384 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2385 i);
2386 }
2387 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002388 }
2389
2390 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002391 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
2392 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
2393 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
2394 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002395 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002396 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002397 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002398 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2399 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002400 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002401 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002402 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002403 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002404 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002405 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002406 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 4, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08002407 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2408 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002409
2410 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002411 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002412 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002413 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002414
2415 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002416 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002417 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2418 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2419
2420 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002421 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002422 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2423 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002424 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002425 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002426
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002427 skip |= validate_flags(
2428 "vkCreateGraphicsPipelines",
2429 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2430 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02002431 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002432
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002433 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002434 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002435 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2436 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2437
2438 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002439 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002440 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2441 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2442
2443 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002444 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002445 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2446 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2447 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002448 }
John Zulauf7acac592017-11-06 11:15:53 -07002449 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002450 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002451 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2452 "vkCreateGraphicsPipelines(): parameter "
2453 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2454 i);
John Zulauf7acac592017-11-06 11:15:53 -07002455 }
2456 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2457 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2458 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002459 skip |= LogError(
2460 device,
2461
Dave Houlton413a6782018-05-22 13:01:54 -06002462 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002463 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002464 }
2465 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002466
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002467 const auto *line_state =
2468 LvlFindInChain<VkPipelineRasterizationLineStateCreateInfoEXT>(pCreateInfos[i].pRasterizationState->pNext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002469
2470 if (line_state) {
2471 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2472 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
2473 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
2474 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002475 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2476 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2477 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
2478 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002479 }
2480 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
2481 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002482 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2483 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2484 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
2485 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002486 }
2487 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
2488 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002489 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2490 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2491 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
2492 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002493 }
2494 }
2495 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2496 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2497 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002498 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
2499 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
2500 "range [1,256].",
2501 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002502 }
2503 }
2504 const auto *line_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002505 LvlFindInChain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002506 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2507 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002508 skip |=
2509 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
2510 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2511 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2512 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002513 }
2514 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2515 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002516 skip |=
2517 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
2518 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2519 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2520 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002521 }
2522 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2523 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002524 skip |=
2525 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
2526 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2527 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
2528 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002529 }
2530 if (line_state->stippledLineEnable) {
2531 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2532 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002533 skip |=
2534 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
2535 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2536 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
2537 "stippledRectangularLines feature.",
2538 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002539 }
2540 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2541 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002542 skip |=
2543 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
2544 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2545 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
2546 "stippledBresenhamLines feature.",
2547 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002548 }
2549 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2550 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002551 skip |=
2552 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
2553 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2554 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
2555 "stippledSmoothLines feature.",
2556 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002557 }
2558 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
2559 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002560 skip |=
2561 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
2562 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2563 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
2564 "stippledRectangularLines and strictLines features.",
2565 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002566 }
2567 }
2568 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002569 }
2570
Petr Krause91f7a12017-12-14 20:57:36 +01002571 bool uses_color_attachment = false;
2572 bool uses_depthstencil_attachment = false;
2573 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002574 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002575 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
2576 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01002577 const auto &subpasses_uses = subpasses_uses_it->second;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002578 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002579 uses_color_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002580 }
2581 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass)) {
Petr Krause91f7a12017-12-14 20:57:36 +01002582 uses_depthstencil_attachment = true;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002583 }
Petr Krause91f7a12017-12-14 20:57:36 +01002584 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002585 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01002586 }
2587
2588 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002589 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002590 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002591 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002592 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002593 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002594
2595 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002596 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002597 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002598 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002599
2600 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002601 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002602 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2603 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2604
2605 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002606 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002607 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2608 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2609
2610 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002611 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002612 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2613 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002614 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002615
2616 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002617 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002618 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2619 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2620
2621 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002622 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002623 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2624 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2625
2626 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002627 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002628 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2629 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002630 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002631
2632 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002633 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002634 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2635 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002636 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002637
2638 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002639 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002640 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2641 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002642 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002643
2644 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002645 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002646 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2647 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002648 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002649
2650 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002651 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002652 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2653 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002654 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002655
2656 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002657 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002658 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2659 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002660 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002661
2662 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002663 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002664 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2665 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002666 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002667
2668 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002669 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002670 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2671 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002672 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002673
2674 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002675 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002676 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2677 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2678 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002679 }
2680 }
2681
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002682 const VkStructureType allowed_structs_vk_pipeline_color_blend_state_create_info[] = {
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002683 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2684
Petr Krause91f7a12017-12-14 20:57:36 +01002685 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002686 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2687 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2688 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2689 pCreateInfos[i].pColorBlendState,
2690 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2691 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2692
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002693 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002694 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002695 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2696 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002697 ARRAY_SIZE(allowed_structs_vk_pipeline_color_blend_state_create_info),
2698 allowed_structs_vk_pipeline_color_blend_state_create_info, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002699 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2700 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002701
2702 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002703 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002704 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002705 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002706
2707 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002708 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002709 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2710 pCreateInfos[i].pColorBlendState->logicOpEnable);
2711
2712 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002713 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002714 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2715 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002716 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002717 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002718
2719 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002720 for (uint32_t attachment_index = 0; attachment_index < pCreateInfos[i].pColorBlendState->attachmentCount;
2721 ++attachment_index) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002722 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002723 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002724 ParameterName::IndexVector{i, attachment_index}),
2725 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].blendEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002726
2727 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002728 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002729 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002730 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002731 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002732 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002733 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002734
2735 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002736 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002737 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002738 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002739 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002740 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002741 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002742
2743 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002744 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002745 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002746 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002747 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002748 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002749 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002750
2751 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002752 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002753 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002754 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002755 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002756 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002757 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002758
2759 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002760 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002761 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002762 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002763 "VkBlendFactor", AllVkBlendFactorEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002764 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002765 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002766
2767 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002768 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002769 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002770 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002771 "VkBlendOp", AllVkBlendOpEnums,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002772 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002773 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002774
2775 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002776 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002777 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002778 ParameterName::IndexVector{i, attachment_index}),
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002779 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07002780 pCreateInfos[i].pColorBlendState->pAttachments[attachment_index].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002781 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002782 }
2783 }
2784
2785 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002786 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002787 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2788 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2789 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002790 }
2791
2792 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2793 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2794 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002795 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002796 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002797 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2798 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002799 }
2800 }
2801 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002802
Petr Kraus9752aae2017-11-24 03:05:50 +01002803 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2804 if (pCreateInfos[i].basePipelineIndex != -1) {
2805 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002806 skip |=
2807 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002808 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002809 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002810 "and pCreateInfos->basePipelineIndex is not -1.",
2811 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002812 }
2813 }
2814
Petr Kraus9752aae2017-11-24 03:05:50 +01002815 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2816 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002817 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002818 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002819 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002820 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
2821 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002822 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002823 } else {
Mike Schuchardte5c15cf2020-04-06 22:57:13 -07002824 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002825 skip |=
2826 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2827 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->basePipelineIndex (%d) must be a valid"
2828 "index into the pCreateInfos array, of size %d.",
2829 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002830 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002831 }
2832 }
2833
sfricke-samsung898cf222020-05-15 23:10:19 -07002834 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
2835 skip |= LogError(
2836 device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
2837 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->flags must not contain VK_PIPELINE_CREATE_DISPATCH_BASE",
2838 i);
2839 }
2840
Petr Kraus9752aae2017-11-24 03:05:50 +01002841 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002842 if (!device_extensions.vk_nv_fill_rectangle) {
2843 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2844 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002845 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2846 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2847 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2848 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002849 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2850 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07002851 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002852 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002853 "pCreateInfos[%u]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2854 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2855 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002856 }
2857 } else {
2858 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2859 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2860 (physical_device_features.fillModeNonSolid == false)) {
2861 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002862 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2863 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002864 "pCreateInfos[%u]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2865 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2866 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002867 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002868 }
Petr Kraus299ba622017-11-24 03:09:03 +01002869
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002870 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002871 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002872 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2873 "The line width state is static (pCreateInfos[%" PRIu32
2874 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2875 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2876 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2877 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002878 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002879 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002880 }
2881 }
2882
2883 return skip;
2884}
2885
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002886bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2887 uint32_t createInfoCount,
2888 const VkComputePipelineCreateInfo *pCreateInfos,
2889 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002890 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002891 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002892 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002893 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002894 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002895 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002896 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04002897 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002898 skip |=
2899 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2900 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2901 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2902 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002903 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002904
2905 // Make sure compute stage is selected
2906 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002907 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2908 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2909 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002910 }
sourav parmarcd5fb182020-07-17 12:58:44 -07002911
2912 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
2913 skip |=
2914 LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03370",
2915 "vkCreateComputePipelines(): flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR");
2916 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002917 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002918 return skip;
2919}
2920
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002921bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002922 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002923 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002924
2925 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002926 const auto &features = physical_device_features;
2927 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002928
John Zulauf71968502017-10-26 13:51:15 -06002929 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2930 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002931 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2932 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2933 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2934 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002935 }
2936
2937 // Anistropy cannot be enabled in sampler unless enabled as a feature
2938 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002939 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2940 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2941 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002942 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002943 }
John Zulauf71968502017-10-26 13:51:15 -06002944
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002945 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2946 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002947 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2948 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2949 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2950 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002951 }
2952 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002953 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2954 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2955 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2956 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002957 }
2958 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002959 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2960 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2961 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2962 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002963 }
2964 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2965 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2966 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2967 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002968 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2969 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2970 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2971 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2972 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2973 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002974 }
2975 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002976 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2977 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2978 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002979 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002980 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002981 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2982 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2983 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002984 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002985 }
2986
2987 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2988 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002989 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2990 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07002991 const auto *sampler_reduction = LvlFindInChain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
sfricke-samsung85252fb2020-05-08 20:44:06 -07002992 if (sampler_reduction != nullptr) {
2993 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
2994 skip |= LogError(
2995 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
2996 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
2997 }
2998 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002999 }
3000
3001 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
3002 // valid VkBorderColor value
3003 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3004 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
3005 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003006 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
3007 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003008 }
3009
3010 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
3011 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003012 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003013 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
3014 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
3015 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06003016 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003017 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
3018 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
3019 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003020 }
John Zulauf275805c2017-10-26 15:34:49 -06003021
3022 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003023 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06003024 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
3025 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003026 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
3027 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
3028 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06003029 }
3030 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003031
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003032 // Check for valid Lod range
3033 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003034 skip |=
3035 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
3036 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003037 }
3038
3039 // Check mipLodBias to device limit
3040 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003041 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
3042 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
3043 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08003044 }
3045
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003046 const auto *sampler_conversion = LvlFindInChain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003047 if (sampler_conversion != nullptr) {
3048 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3049 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3050 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
3051 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003052 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07003053 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07003054 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
3055 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
3056 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
3057 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
3058 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
3059 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
3060 }
3061 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02003062
3063 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
3064 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
3065 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
3066 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3067 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
3068 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
3069 }
3070 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
3071 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
3072 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3073 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
3074 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
3075 }
3076 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
3077 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
3078 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3079 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
3080 pCreateInfo->minLod, pCreateInfo->maxLod);
3081 }
3082 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3083 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
3084 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
3085 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
3086 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
3087 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3088 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
3089 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
3090 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3091 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
3092 }
3093 if (pCreateInfo->anisotropyEnable) {
3094 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
3095 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3096 "pCreateInfo->anisotropyEnable must be VK_FALSE");
3097 }
3098 if (pCreateInfo->compareEnable) {
3099 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
3100 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3101 "pCreateInfo->compareEnable must be VK_FALSE");
3102 }
3103 if (pCreateInfo->unnormalizedCoordinates) {
3104 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
3105 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3106 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
3107 }
3108 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003109 }
3110
Tony-LunarG7337b312020-04-15 16:40:25 -06003111 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
3112 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
3113 if (!device_extensions.vk_ext_custom_border_color) {
3114 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
3115 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
3116 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
3117 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003118 auto custom_create_info = LvlFindInChain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
Tony-LunarG7337b312020-04-15 16:40:25 -06003119 if (!custom_create_info) {
3120 skip |=
3121 LogError(device, "VUID-VkSamplerCreateInfo-borderColor-04011",
3122 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
3123 "struct in pNext chain.\n",
3124 string_VkBorderColor(pCreateInfo->borderColor));
3125 } else {
3126 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
3127 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT && !FormatIsSampledInt(custom_create_info->format)) ||
3128 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
3129 !FormatIsSampledFloat(custom_create_info->format)))) {
3130 skip |= LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
3131 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
3132 "whose type does not match\n",
3133 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
3134 ;
3135 }
3136 }
3137 }
3138
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003139 return skip;
3140}
3141
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003142bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
3143 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
3144 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003145 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003146 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003147
3148 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3149 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
3150 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
3151 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003152 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3153 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
3154 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
3155 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
3156 ++descriptor_index) {
3157 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07003158 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003159 "vkCreateDescriptorSetLayout: required parameter "
3160 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
3161 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003162 }
3163 }
3164 }
3165
3166 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
3167 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
3168 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003169 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
3170 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
3171 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
3172 "values.",
3173 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003174 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07003175
3176 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
3177 (pCreateInfo->pBindings[i].stageFlags != 0) &&
3178 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
3179 skip |=
3180 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
3181 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
3182 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
3183 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
3184 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
3185 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003186 }
3187 }
3188 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003189 return skip;
3190}
3191
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003192bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
3193 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003194 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003195 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3196 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3197 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003198 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
3199 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003200}
3201
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003202bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
3203 const VkWriteDescriptorSet *pDescriptorWrites,
3204 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003205 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003206
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003207 if (pDescriptorWrites != NULL) {
3208 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
3209 // descriptorCount must be greater than 0
3210 if (pDescriptorWrites[i].descriptorCount == 0) {
3211 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003212 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
3213 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003214 }
3215
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003216 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
3217 if (validateDstSet) {
3218 // dstSet must be a valid VkDescriptorSet handle
3219 skip |= validate_required_handle(vkCallingFunction,
3220 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
3221 pDescriptorWrites[i].dstSet);
3222 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003223
3224 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3225 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
3226 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
3227 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
3228 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
3229 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
3230 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
Jeff Bolz165818a2020-05-08 11:19:03 -05003231 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures.
3232 // Valid imageView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003233 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003234 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
3235 "%s(): if pDescriptorWrites[%d].descriptorType is "
3236 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
3237 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
3238 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
3239 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003240 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
3241 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05003242 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
3243 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003244 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3245 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003246 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003247 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
3248 ParameterName::IndexVector{i, descriptor_index}),
3249 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06003250 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003251 }
3252 }
3253 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3254 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3255 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
3256 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
3257 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
3258 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
3259 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05003260 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003261 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003262 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
3263 "%s(): if pDescriptorWrites[%d].descriptorType is "
3264 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
3265 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
3266 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
3267 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003268 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05003269 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003270 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05003271 if (robustness2_features && robustness2_features->nullDescriptor) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003272 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3273 ++descriptor_index) {
3274 if (pDescriptorWrites[i].pBufferInfo[descriptor_index].buffer == VK_NULL_HANDLE &&
3275 (pDescriptorWrites[i].pBufferInfo[descriptor_index].offset != 0 ||
3276 pDescriptorWrites[i].pBufferInfo[descriptor_index].range != VK_WHOLE_SIZE)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003277 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
3278 "%s(): if pDescriptorWrites[%d].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01003279 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003280 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptor_index].offset,
3281 pDescriptorWrites[i].pBufferInfo[descriptor_index].range);
Jeff Bolz165818a2020-05-08 11:19:03 -05003282 }
3283 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003284 }
3285 }
3286 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
3287 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003288 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003289 }
3290
3291 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3292 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003293 VkDeviceSize uniform_alignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003294 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3295 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003296 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003297 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003298 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
3299 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3300 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003301 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniform_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003302 }
3303 }
3304 }
3305 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3306 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003307 VkDeviceSize storage_alignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003308 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3309 if (pDescriptorWrites[i].pBufferInfo != NULL) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003310 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003311 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003312 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
3313 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3314 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003315 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storage_alignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003316 }
3317 }
3318 }
3319 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003320 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
3321 // or VkWriteDescriptorSetInlineUniformBlockEX
sourav parmarbcee7512020-12-28 14:34:49 -08003322 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003323 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08003324 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
3325 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
3326 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
3327 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
3328 "accelerationStructureCount %d member equals descriptorCount %d.",
3329 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
3330 pDescriptorWrites[i].descriptorCount);
3331 }
3332 // further checks only if we have right structtype
3333 if (pnext_struct) {
3334 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
3335 skip |= LogError(
3336 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
3337 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3338 ".",
3339 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07003340 }
sourav parmarbcee7512020-12-28 14:34:49 -08003341 if (pnext_struct->accelerationStructureCount == 0) {
3342 skip |= LogError(device,
3343 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
3344 "%s(): accelerationStructureCount must be greater than 0 .");
3345 }
3346 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003347 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08003348 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3349 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3350 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3351 skip |= LogError(device,
3352 "VUID-VkWriteDescriptorSetAccelerationStructureKHR-pAccelerationStructures-03580",
3353 "%s(): If the nullDescriptor feature is not enabled, each member of "
3354 "pAccelerationStructures must not be VK_NULL_HANDLE.");
sourav parmarcd5fb182020-07-17 12:58:44 -07003355 }
3356 }
3357 }
sourav parmarbcee7512020-12-28 14:34:49 -08003358 }
3359 } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003360 const auto *pnext_struct = LvlFindInChain<VkWriteDescriptorSetAccelerationStructureNV>(pDescriptorWrites[i].pNext);
sourav parmarbcee7512020-12-28 14:34:49 -08003361 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
3362 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-03817",
3363 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV, the pNext"
3364 "chain must include a VkWriteDescriptorSetAccelerationStructureNV structure whose "
3365 "accelerationStructureCount %d member equals descriptorCount %d.",
3366 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
3367 pDescriptorWrites[i].descriptorCount);
3368 }
3369 // further checks only if we have right structtype
3370 if (pnext_struct) {
3371 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
3372 skip |= LogError(
3373 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-03747",
3374 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3375 ".",
3376 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmarcd5fb182020-07-17 12:58:44 -07003377 }
sourav parmarbcee7512020-12-28 14:34:49 -08003378 if (pnext_struct->accelerationStructureCount == 0) {
3379 skip |= LogError(device,
3380 "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-arraylength",
3381 "%s(): accelerationStructureCount must be greater than 0 .");
3382 }
3383 const auto *robustness2_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003384 LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
sourav parmarbcee7512020-12-28 14:34:49 -08003385 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3386 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3387 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3388 skip |= LogError(device,
3389 "VUID-VkWriteDescriptorSetAccelerationStructureNV-pAccelerationStructures-03749",
3390 "%s(): If the nullDescriptor feature is not enabled, each member of "
3391 "pAccelerationStructures must not be VK_NULL_HANDLE.");
sourav parmarcd5fb182020-07-17 12:58:44 -07003392 }
3393 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003394 }
3395 }
3396 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003397 }
3398 }
3399 return skip;
3400}
3401
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003402bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
3403 const VkWriteDescriptorSet *pDescriptorWrites,
3404 uint32_t descriptorCopyCount,
3405 const VkCopyDescriptorSet *pDescriptorCopies) const {
3406 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
3407}
3408
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003409bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003410 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003411 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003412 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
3413}
3414
sfricke-samsung681ab7b2020-10-29 01:53:35 -07003415bool StatelessValidation::manual_PreCallValidateCreateRenderPass2(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
3416 const VkAllocationCallbacks *pAllocator,
3417 VkRenderPass *pRenderPass) const {
3418 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3419}
3420
Mike Schuchardt2df08912020-12-15 16:28:09 -08003421bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003422 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003423 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003424 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3425}
3426
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003427bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
3428 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003429 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003430 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003431
3432 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3433 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3434 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003435 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
3436 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003437 return skip;
3438}
3439
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003440bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003441 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003442 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02003443
3444 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
3445 const char *cmd_name = "vkBeginCommandBuffer";
Tony-LunarG3c287f62020-12-17 12:39:49 -07003446 bool cb_is_secondary;
3447 {
3448 auto lock = cb_read_lock();
3449 cb_is_secondary = (secondary_cb_map.find(commandBuffer) != secondary_cb_map.end());
3450 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003451
Tony-LunarG3c287f62020-12-17 12:39:49 -07003452 if (cb_is_secondary) {
3453 // Implicit VUs
3454 // validate only sType here; pointer has to be validated in core_validation
3455 const bool k_not_required = false;
3456 const char *k_no_vuid = nullptr;
3457 const VkCommandBufferInheritanceInfo *info = pBeginInfo->pInheritanceInfo;
3458 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003459 info, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, k_not_required, k_no_vuid,
3460 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003461
Tony-LunarG3c287f62020-12-17 12:39:49 -07003462 if (info) {
3463 const VkStructureType allowed_structs_vk_command_buffer_inheritance_info[] = {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003464 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
Tony-LunarG3c287f62020-12-17 12:39:49 -07003465 skip |= validate_struct_pnext(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003466 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT",
3467 info->pNext, ARRAY_SIZE(allowed_structs_vk_command_buffer_inheritance_info),
3468 allowed_structs_vk_command_buffer_inheritance_info, GeneratedVulkanHeaderVersion,
3469 "VUID-VkCommandBufferInheritanceInfo-pNext-pNext", "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003470
Tony-LunarG3c287f62020-12-17 12:39:49 -07003471 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", info->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003472
Tony-LunarG3c287f62020-12-17 12:39:49 -07003473 // Explicit VUs
3474 if (!physical_device_features.inheritedQueries && info->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003475 skip |= LogError(
Tony-LunarG3c287f62020-12-17 12:39:49 -07003476 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
3477 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
3478 cmd_name);
3479 }
3480
3481 if (physical_device_features.inheritedQueries) {
3482 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003483 AllVkQueryControlFlagBits, info->queryFlags, kOptionalFlags,
3484 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
3485 } else { // !inheritedQueries
Tony-LunarG3c287f62020-12-17 12:39:49 -07003486 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", info->queryFlags,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003487 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Tony-LunarG3c287f62020-12-17 12:39:49 -07003488 }
3489
3490 if (physical_device_features.pipelineStatisticsQuery) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003491 skip |=
3492 validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
3493 AllVkQueryPipelineStatisticFlagBits, info->pipelineStatistics, kOptionalFlags,
3494 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
3495 } else { // !pipelineStatisticsQuery
3496 skip |=
3497 validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", info->pipelineStatistics,
3498 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Tony-LunarG3c287f62020-12-17 12:39:49 -07003499 }
3500
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003501 const auto *conditional_rendering = LvlFindInChain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(info->pNext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07003502 if (conditional_rendering) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003503 const auto *cr_features = LvlFindInChain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Tony-LunarG3c287f62020-12-17 12:39:49 -07003504 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
3505 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
3506 skip |= LogError(
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003507 commandBuffer,
3508 "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Tony-LunarG3c287f62020-12-17 12:39:49 -07003509 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
3510 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
3511 }
Petr Kraus139757b2019-08-15 17:19:33 +02003512 }
3513 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003514 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003515 return skip;
3516}
3517
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003518bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003519 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003520 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003521
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003522 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01003523 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003524 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
3525 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3526 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01003527 }
3528 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003529 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
3530 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3531 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01003532 }
3533 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01003534 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003535 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003536 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
3537 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3538 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3539 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003540 }
3541 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01003542
3543 if (pViewports) {
3544 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
3545 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06003546 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003547 skip |= manual_PreCallValidateViewport(
3548 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01003549 }
3550 }
3551
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003552 return skip;
3553}
3554
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003555bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003556 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003557 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003558
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003559 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003560 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003561 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
3562 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
3563 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003564 }
3565 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003566 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
3567 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
3568 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003569 }
3570 } else { // multiViewport enabled
3571 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003572 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003573 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
3574 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3575 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3576 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003577 }
3578 }
3579
Petr Kraus6260f0a2018-02-27 21:15:55 +01003580 if (pScissors) {
3581 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
3582 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003583
Petr Kraus6260f0a2018-02-27 21:15:55 +01003584 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003585 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3586 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3587 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003588 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003589
Petr Kraus6260f0a2018-02-27 21:15:55 +01003590 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003591 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3592 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3593 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003594 }
3595
3596 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3597 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003598 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
3599 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3600 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3601 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003602 }
3603
3604 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3605 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003606 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
3607 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3608 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3609 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003610 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003611 }
3612 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01003613
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003614 return skip;
3615}
3616
Jeff Bolz5c801d12019-10-09 10:38:45 -05003617bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01003618 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01003619
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003620 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003621 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
3622 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003623 }
3624
3625 return skip;
3626}
3627
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003628bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003629 uint32_t drawCount, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003630 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003631
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003632 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski41ce65b2020-10-30 12:17:06 -06003633 skip |= LogError(device, "VUID-vkCmdDrawIndirect-drawCount-02718",
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003634 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
3635 }
3636 if (drawCount > device_limits.maxDrawIndirectCount) {
3637 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirect-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003638 "CmdDrawIndirect(): drawCount (%u) is not less than or equal to the maximum allowed (%u).", drawCount,
3639 device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003640 }
3641 return skip;
3642}
3643
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003644bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003645 VkDeviceSize offset, uint32_t drawCount,
3646 uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003647 bool skip = false;
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003648 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003649 skip |= LogError(device, "VUID-vkCmdDrawIndexedIndirect-drawCount-02718",
3650 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d",
3651 drawCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07003652 }
3653 if (drawCount > device_limits.maxDrawIndirectCount) {
3654 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirect-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003655 "CmdDrawIndexedIndirect(): drawCount (%u) is not less than or equal to the maximum allowed (%u).",
3656 drawCount, device_limits.maxDrawIndirectCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003657 }
3658 return skip;
3659}
3660
sfricke-samsungf692b972020-05-02 08:00:45 -07003661bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3662 VkDeviceSize countBufferOffset, bool khr) const {
3663 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003664 const char *api_name = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07003665 if (offset & 3) {
3666 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003667 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07003668 }
3669
3670 if (countBufferOffset & 3) {
3671 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003672 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07003673 countBufferOffset);
3674 }
3675 return skip;
3676}
3677
3678bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3679 VkDeviceSize offset, VkBuffer countBuffer,
3680 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3681 uint32_t stride) const {
3682 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
3683}
3684
3685bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3686 VkDeviceSize offset, VkBuffer countBuffer,
3687 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3688 uint32_t stride) const {
3689 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
3690}
3691
3692bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3693 VkDeviceSize countBufferOffset, bool khr) const {
3694 bool skip = false;
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003695 const char *api_name = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
sfricke-samsungf692b972020-05-02 08:00:45 -07003696 if (offset & 3) {
3697 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003698 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name, offset);
sfricke-samsungf692b972020-05-02 08:00:45 -07003699 }
3700
3701 if (countBufferOffset & 3) {
3702 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07003703 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", api_name,
sfricke-samsungf692b972020-05-02 08:00:45 -07003704 countBufferOffset);
3705 }
3706 return skip;
3707}
3708
3709bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3710 VkDeviceSize offset, VkBuffer countBuffer,
3711 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3712 uint32_t stride) const {
3713 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
3714}
3715
3716bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3717 VkDeviceSize offset, VkBuffer countBuffer,
3718 VkDeviceSize countBufferOffset,
3719 uint32_t maxDrawCount, uint32_t stride) const {
3720 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
3721}
3722
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003723bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
3724 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003725 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003726 bool skip = false;
3727 for (uint32_t rect = 0; rect < rectCount; rect++) {
3728 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003729 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
3730 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003731 }
sfricke-samsung10867682020-04-25 02:20:39 -07003732 if (pRects[rect].rect.extent.width == 0) {
3733 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
3734 "CmdClearAttachments(): pRects[%d].rect.extent.width is zero.", rect);
3735 }
3736 if (pRects[rect].rect.extent.height == 0) {
3737 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
3738 "CmdClearAttachments(): pRects[%d].rect.extent.height is zero.", rect);
3739 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003740 }
3741 return skip;
3742}
3743
Andrew Fobel3abeb992020-01-20 16:33:22 -05003744bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
3745 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3746 VkImageFormatProperties2 *pImageFormatProperties,
3747 const char *apiName) const {
3748 bool skip = false;
3749
3750 if (pImageFormatInfo != nullptr) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003751 const auto image_stencil_struct = LvlFindInChain<VkImageStencilUsageCreateInfo>(pImageFormatInfo->pNext);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003752 if (image_stencil_struct != nullptr) {
3753 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
3754 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
3755 // No flags other than the legal attachment bits may be set
3756 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
3757 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003758 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
3759 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
3760 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
3761 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
3762 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003763 }
3764 }
3765 }
3766 }
3767
3768 return skip;
3769}
3770
3771bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
3772 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3773 VkImageFormatProperties2 *pImageFormatProperties) const {
3774 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3775 "vkGetPhysicalDeviceImageFormatProperties2");
3776}
3777
3778bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
3779 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3780 VkImageFormatProperties2 *pImageFormatProperties) const {
3781 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3782 "vkGetPhysicalDeviceImageFormatProperties2KHR");
3783}
3784
Lionel Landwerlin5fe52752020-07-22 08:18:14 +03003785bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties(
3786 VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage,
3787 VkImageCreateFlags flags, VkImageFormatProperties *pImageFormatProperties) const {
3788 bool skip = false;
3789
3790 if (tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
3791 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceImageFormatProperties-tiling-02248",
3792 "vkGetPhysicalDeviceImageFormatProperties(): tiling must not be VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.");
3793 }
3794
3795 return skip;
3796}
3797
sfricke-samsung3999ef62020-02-09 17:05:59 -08003798bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
3799 uint32_t regionCount, const VkBufferCopy *pRegions) const {
3800 bool skip = false;
3801
3802 if (pRegions != nullptr) {
3803 for (uint32_t i = 0; i < regionCount; i++) {
3804 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003805 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
3806 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08003807 }
3808 }
3809 }
3810 return skip;
3811}
3812
Jeff Leger178b1e52020-10-05 12:22:23 -04003813bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2KHR(VkCommandBuffer commandBuffer,
3814 const VkCopyBufferInfo2KHR *pCopyBufferInfo) const {
3815 bool skip = false;
3816
3817 if (pCopyBufferInfo->pRegions != nullptr) {
3818 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
3819 if (pCopyBufferInfo->pRegions[i].size == 0) {
3820 skip |= LogError(device, "VUID-VkBufferCopy2KHR-size-01988",
3821 "vkCmdCopyBuffer2KHR() pCopyBufferInfo->pRegions[%u].size must be greater than zero", i);
3822 }
3823 }
3824 }
3825 return skip;
3826}
3827
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003828bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003829 VkDeviceSize dstOffset, VkDeviceSize dataSize,
3830 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003831 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003832
3833 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003834 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
3835 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3836 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003837 }
3838
3839 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003840 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3841 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3842 "), must be greater than zero and less than or equal to 65536.",
3843 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003844 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003845 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3846 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3847 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003848 }
3849 return skip;
3850}
3851
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003852bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003853 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003854 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003855
3856 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003857 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3858 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3859 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003860 }
3861
3862 if (size != VK_WHOLE_SIZE) {
3863 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003864 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003865 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3866 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003867 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003868 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3869 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003870 }
3871 }
3872 return skip;
3873}
3874
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003875bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003876 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003877 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003878 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003879
3880 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003881 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3882 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3883 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3884 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003885 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3886 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3887 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003888 }
3889
3890 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3891 // queueFamilyIndexCount uint32_t values
3892 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003893 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3894 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3895 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3896 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003897 }
3898 }
3899
Dave Houlton413a6782018-05-22 13:01:54 -06003900 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003901 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003902 }
3903
3904 return skip;
3905}
3906
Jeff Bolz5c801d12019-10-09 10:38:45 -05003907bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003908 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003909
3910 if (pPresentInfo && pPresentInfo->pNext) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07003911 const auto *present_regions = LvlFindInChain<VkPresentRegionsKHR>(pPresentInfo->pNext);
John Zulaufde972ac2017-10-26 12:07:05 -06003912 if (present_regions) {
3913 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003914 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003915 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3916 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07003917 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003918 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3919 "extension swapchainCount is %i. These values must be equal.",
3920 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003921 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003922 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003923 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3924 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003925 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3926 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3927 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003928 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003929 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003930 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003931 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003932 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003933 }
3934 }
3935
3936 return skip;
3937}
3938
sfricke-samsung5c1b7392020-12-13 22:17:15 -08003939bool StatelessValidation::manual_PreCallValidateCreateDisplayModeKHR(VkPhysicalDevice physicalDevice, VkDisplayKHR display,
3940 const VkDisplayModeCreateInfoKHR *pCreateInfo,
3941 const VkAllocationCallbacks *pAllocator,
3942 VkDisplayModeKHR *pMode) const {
3943 bool skip = false;
3944
3945 const VkDisplayModeParametersKHR display_mode_parameters = pCreateInfo->parameters;
3946 if (display_mode_parameters.visibleRegion.width == 0) {
3947 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-width-01990",
3948 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.width must be greater than 0.");
3949 }
3950 if (display_mode_parameters.visibleRegion.height == 0) {
3951 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-height-01991",
3952 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.visibleRegion.height must be greater than 0.");
3953 }
3954 if (display_mode_parameters.refreshRate == 0) {
3955 skip |= LogError(device, "VUID-VkDisplayModeParametersKHR-refreshRate-01992",
3956 "vkCreateDisplayModeKHR(): pCreateInfo->parameters.refreshRate must be greater than 0.");
3957 }
3958
3959 return skip;
3960}
3961
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003962#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003963bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3964 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3965 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003966 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003967 bool skip = false;
3968
3969 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003970 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3971 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003972 }
3973
3974 return skip;
3975}
3976#endif // VK_USE_PLATFORM_WIN32_KHR
3977
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003978bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003979 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003980 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003981 bool skip = false;
3982
3983 if (pCreateInfo) {
3984 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003985 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3986 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003987 }
3988
3989 if (pCreateInfo->pPoolSizes) {
3990 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3991 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003992 skip |= LogError(
3993 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003994 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003995 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003996 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3997 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003998 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3999 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
4000 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
4001 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
4002 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05004003 }
Petr Krausc8655be2017-09-27 18:56:51 +02004004 }
4005 }
4006 }
4007
4008 return skip;
4009}
4010
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004011bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004012 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004013 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004014
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004015 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004016 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004017 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
4018 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4019 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004020 }
4021
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004022 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004023 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004024 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
4025 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4026 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004027 }
4028
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004029 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06004030 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004031 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
4032 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4033 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004034 }
4035
4036 return skip;
4037}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004038
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004039bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004040 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07004041 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07004042
4043 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004044 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
4045 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07004046 }
4047 return skip;
4048}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004049
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004050bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
4051 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004052 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004053 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004054
4055 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004056 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004057 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004058 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
4059 "vkCmdDispatch(): baseGroupX (%" PRIu32
4060 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4061 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004062 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004063 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
4064 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
4065 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
4066 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004067 }
4068
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004069 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004070 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004071 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
4072 "vkCmdDispatch(): baseGroupY (%" PRIu32
4073 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4074 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004075 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004076 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
4077 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
4078 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
4079 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004080 }
4081
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004082 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004083 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004084 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
4085 "vkCmdDispatch(): baseGroupZ (%" PRIu32
4086 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4087 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004088 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004089 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
4090 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
4091 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
4092 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07004093 }
4094
4095 return skip;
4096}
4097
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07004098bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
4099 VkPipelineBindPoint pipelineBindPoint,
4100 VkPipelineLayout layout, uint32_t set,
4101 uint32_t descriptorWriteCount,
4102 const VkWriteDescriptorSet *pDescriptorWrites) const {
4103 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
4104}
4105
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004106bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
4107 uint32_t firstExclusiveScissor,
4108 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004109 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05004110 bool skip = false;
4111
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004112 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05004113 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004114 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004115 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
4116 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
4117 ") is not 0.",
4118 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004119 }
4120 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004121 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004122 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
4123 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
4124 ") is not 1.",
4125 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004126 }
4127 } else { // multiViewport enabled
4128 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004129 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004130 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
4131 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
4132 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4133 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004134 }
4135 }
4136
Jeff Bolz3e71f782018-08-29 23:15:45 -05004137 if (pExclusiveScissors) {
4138 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
4139 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
4140
4141 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004142 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4143 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
4144 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004145 }
4146
4147 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004148 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4149 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
4150 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004151 }
4152
4153 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
4154 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004155 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
4156 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4157 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4158 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004159 }
4160
4161 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
4162 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004163 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
4164 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4165 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4166 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004167 }
4168 }
4169 }
4170
4171 return skip;
4172}
4173
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004174bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
4175 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004176 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004177 bool skip = false;
Shannon McPherson169d0c72020-11-13 18:48:19 -07004178 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
4179 if ((sum < 1) || (sum > device_limits.maxViewports)) {
4180 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
4181 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4182 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
4183 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004184 }
4185
4186 return skip;
4187}
4188
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004189bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
4190 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004191 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004192 bool skip = false;
4193
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004194 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004195 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004196 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004197 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
4198 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
4199 ") is not 0.",
4200 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004201 }
4202 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004203 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004204 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
4205 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
4206 ") is not 1.",
4207 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004208 }
4209 }
4210
Jeff Bolz9af91c52018-09-01 21:53:57 -05004211 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004212 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004213 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
4214 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
4215 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4216 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004217 }
4218
4219 return skip;
4220}
4221
Jeff Bolz5c801d12019-10-09 10:38:45 -05004222bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
4223 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
4224 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004225 bool skip = false;
4226
Dave Houlton142c4cb2018-10-17 15:04:41 -06004227 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004228 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
4229 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
4230 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05004231 }
4232
4233 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004234 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004235 }
4236
4237 return skip;
4238}
4239
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004240bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004241 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004242 bool skip = false;
4243
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004244 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004245 skip |= LogError(
4246 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004247 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
4248 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004249 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004250 }
4251
4252 return skip;
4253}
4254
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004255bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4256 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004257 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004258 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06004259 static const int condition_multiples = 0b0011;
4260 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004261 skip |= LogError(
4262 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004263 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004264 }
Lockee1c22882019-06-10 16:02:54 -06004265 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004266 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
4267 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
4268 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
4269 stride);
Lockee1c22882019-06-10 16:02:54 -06004270 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004271 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004272 skip |= LogError(
4273 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
4274 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06004275 }
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004276 if (drawCount > device_limits.maxDrawIndirectCount) {
4277 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02719",
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004278 "vkCmdDrawMeshTasksIndirectNV: drawCount (%u) is not less than or equal to the maximum allowed (%u).",
4279 drawCount, device_limits.maxDrawIndirectCount);
Tony-LunarGc0c3df52020-11-20 13:47:10 -07004280 }
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004281 return skip;
4282}
4283
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004284bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4285 VkDeviceSize offset, VkBuffer countBuffer,
4286 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004287 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004288 bool skip = false;
4289
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004290 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004291 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
4292 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
4293 "), is not a multiple of 4.",
4294 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004295 }
4296
4297 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004298 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
4299 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
4300 "), is not a multiple of 4.",
4301 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004302 }
4303
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004304 return skip;
4305}
4306
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004307bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004308 const VkAllocationCallbacks *pAllocator,
4309 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004310 bool skip = false;
4311
4312 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4313 if (pCreateInfo != nullptr) {
4314 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
4315 // VkQueryPipelineStatisticFlagBits values
4316 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
4317 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004318 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
4319 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
4320 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
4321 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004322 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07004323 if (pCreateInfo->queryCount == 0) {
4324 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
4325 "vkCreateQueryPool(): queryCount must be greater than zero.");
4326 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06004327 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004328 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004329}
4330
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004331bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
4332 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004333 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004334 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
4335 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004336}
4337
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004338void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004339 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4340 VkResult result) {
4341 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004342 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004343}
4344
Mike Schuchardt2df08912020-12-15 16:28:09 -08004345void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004346 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4347 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004348 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004349 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004350 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004351}
4352
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004353void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
4354 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004355 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07004356 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004357 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004358}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004359
Tony-LunarG3c287f62020-12-17 12:39:49 -07004360void StatelessValidation::PostCallRecordAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pAllocateInfo,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004361 VkCommandBuffer *pCommandBuffers, VkResult result) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004362 if ((result == VK_SUCCESS) && pAllocateInfo && (pAllocateInfo->level == VK_COMMAND_BUFFER_LEVEL_SECONDARY)) {
4363 auto lock = cb_write_lock();
4364 for (uint32_t cb_index = 0; cb_index < pAllocateInfo->commandBufferCount; cb_index++) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004365 secondary_cb_map.insert({pCommandBuffers[cb_index], pAllocateInfo->commandPool});
Tony-LunarG3c287f62020-12-17 12:39:49 -07004366 }
4367 }
4368}
4369
4370void StatelessValidation::PostCallRecordFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004371 const VkCommandBuffer *pCommandBuffers) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004372 auto lock = cb_write_lock();
4373 for (uint32_t cb_index = 0; cb_index < commandBufferCount; cb_index++) {
4374 secondary_cb_map.erase(pCommandBuffers[cb_index]);
4375 }
4376}
4377
4378void StatelessValidation::PostCallRecordDestroyCommandPool(VkDevice device, VkCommandPool commandPool,
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004379 const VkAllocationCallbacks *pAllocator) {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004380 auto lock = cb_write_lock();
4381 for (auto item = secondary_cb_map.begin(); item != secondary_cb_map.end();) {
4382 if (item->second == commandPool) {
4383 item = secondary_cb_map.erase(item);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004384 } else {
Tony-LunarG3c287f62020-12-17 12:39:49 -07004385 ++item;
4386 }
4387 }
4388}
4389
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004390bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004391 const VkAllocationCallbacks *pAllocator,
4392 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004393 bool skip = false;
4394
4395 if (pAllocateInfo) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004396 auto chained_prio_struct = LvlFindInChain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004397 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004398 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
4399 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004400 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004401
4402 VkMemoryAllocateFlags flags = 0;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004403 auto flags_info = LvlFindInChain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004404 if (flags_info) {
4405 flags = flags_info->flags;
4406 }
4407
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004408 auto opaque_alloc_info = LvlFindInChain<VkMemoryOpaqueCaptureAddressAllocateInfo>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004409 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
Mike Schuchardt2df08912020-12-15 16:28:09 -08004410 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004411 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
4412 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
Mike Schuchardt2df08912020-12-15 16:28:09 -08004413 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004414 }
4415
4416#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004417 auto import_memory_win32_handle = LvlFindInChain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004418#endif
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004419 auto import_memory_fd = LvlFindInChain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
4420 auto import_memory_host_pointer = LvlFindInChain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004421#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004422 auto import_memory_ahb = LvlFindInChain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004423#endif
4424
4425 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004426 skip |= LogError(
4427 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004428 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
4429 }
4430 if (
4431#ifdef VK_USE_PLATFORM_WIN32_KHR
4432 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
4433#endif
4434 (import_memory_fd && import_memory_fd->handleType) ||
4435#ifdef VK_USE_PLATFORM_ANDROID_KHR
4436 (import_memory_ahb && import_memory_ahb->buffer) ||
4437#endif
4438 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004439 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
4440 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004441 }
4442 }
4443
4444 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004445 VkBool32 capture_replay = false;
4446 VkBool32 buffer_device_address = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004447 const auto *vulkan_12_features = LvlFindInChain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004448 if (vulkan_12_features) {
4449 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
4450 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
4451 } else {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004452 const auto *bda_features = LvlFindInChain<VkPhysicalDeviceBufferDeviceAddressFeatures>(device_createinfo_pnext);
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004453 if (bda_features) {
4454 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
4455 buffer_device_address = bda_features->bufferDeviceAddress;
4456 }
4457 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08004458 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004459 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
Mike Schuchardt2df08912020-12-15 16:28:09 -08004460 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT is set, "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004461 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004462 }
Mike Schuchardt2df08912020-12-15 16:28:09 -08004463 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004464 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
Mike Schuchardt2df08912020-12-15 16:28:09 -08004465 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004466 }
4467 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004468 }
4469 return skip;
4470}
Ricardo Garciaa4935972019-02-21 17:43:18 +01004471
Jason Macnak192fa0e2019-07-26 15:07:16 -07004472bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004473 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004474 bool skip = false;
4475
4476 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
4477 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
4478 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004479 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004480 } else {
4481 uint32_t vertex_component_size = 0;
4482 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
4483 vertex_component_size = 4;
4484 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
4485 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
4486 vertex_component_size = 2;
4487 }
4488 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004489 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004490 }
4491 }
4492
4493 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
4494 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004495 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004496 } else {
4497 uint32_t index_element_size = 0;
4498 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
4499 index_element_size = 4;
4500 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
4501 index_element_size = 2;
4502 }
4503 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004504 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004505 }
4506 }
4507 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
4508 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004509 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004510 }
4511 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004512 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004513 }
4514 }
4515
4516 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004517 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004518 }
4519
4520 return skip;
4521}
4522
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004523bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
4524 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004525 bool skip = false;
4526
4527 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004528 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004529 }
4530 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004531 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004532 }
4533
4534 return skip;
4535}
4536
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004537bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
4538 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004539 bool skip = false;
4540 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004541 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004542 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004543 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004544 }
4545 return skip;
4546}
4547
4548bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07004549 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004550 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004551 bool skip = false;
4552 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004553 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
4554 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
4555 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004556 }
4557 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004558 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
4559 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
4560 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004561 }
4562 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
4563 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004564 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
4565 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
4566 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07004567 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004568 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004569 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004570 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
4571 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004572 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
4573 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004574 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004575 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004576 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
4577 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
4578 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004579 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004580 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07004581 uint64_t total_triangle_count = 0;
4582 for (uint32_t i = 0; i < info.geometryCount; i++) {
4583 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07004584
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004585 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004586
Jason Macnak5c954952019-07-09 15:46:12 -07004587 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
4588 continue;
4589 }
4590 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
4591 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004592 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004593 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
4594 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
4595 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004596 }
4597 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004598 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
4599 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
4600 for (uint32_t i = 1; i < info.geometryCount; i++) {
4601 const VkGeometryNV &geometry = info.pGeometries[i];
4602 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004603 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004604 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
4605 "info.pGeometries[0].geometryType.",
4606 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07004607 }
4608 }
4609 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004610 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
4611 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
4612 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
4613 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
4614 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
4615 "or VK_GEOMETRY_TYPE_AABBS_NV.");
4616 }
4617 }
4618 skip |=
4619 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06004620 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07004621 return skip;
4622}
4623
Ricardo Garciaa4935972019-02-21 17:43:18 +01004624bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
4625 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004626 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01004627 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01004628 if (pCreateInfo) {
4629 if ((pCreateInfo->compactedSize != 0) &&
4630 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004631 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
4632 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
4633 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
4634 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004635 }
Jason Macnak5c954952019-07-09 15:46:12 -07004636
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004637 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07004638 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004639 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01004640 return skip;
4641}
Mike Schuchardt21638df2019-03-16 10:52:02 -07004642
Jeff Bolz5c801d12019-10-09 10:38:45 -05004643bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
4644 const VkAccelerationStructureInfoNV *pInfo,
4645 VkBuffer instanceData, VkDeviceSize instanceOffset,
4646 VkBool32 update, VkAccelerationStructureNV dst,
4647 VkAccelerationStructureNV src, VkBuffer scratch,
4648 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004649 bool skip = false;
4650
4651 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004652 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07004653 }
4654
4655 return skip;
4656}
4657
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004658bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
4659 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
4660 VkAccelerationStructureKHR *pAccelerationStructure) const {
4661 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07004662 const auto *acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004663 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07004664 if (!acceleration_structure_features ||
4665 (acceleration_structure_features && acceleration_structure_features->accelerationStructure == VK_FALSE)) {
4666 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-accelerationStructure-03611",
4667 "vkCreateAccelerationStructureKHR(): The accelerationStructure feature must be enabled");
4668 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004669 if (pCreateInfo) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004670 if (pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR &&
4671 (!acceleration_structure_features ||
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004672 (acceleration_structure_features &&
4673 acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
sourav parmara96ab1a2020-04-25 16:28:23 -07004674 skip |=
sourav parmarcd5fb182020-07-17 12:58:44 -07004675 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-createFlags-03613",
4676 "vkCreateAccelerationStructureKHR(): If createFlags includes "
4677 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR, "
4678 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay must be VK_TRUE");
sourav parmara96ab1a2020-04-25 16:28:23 -07004679 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004680 if (pCreateInfo->deviceAddress &&
4681 !(pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
4682 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03612",
4683 "vkCreateAccelerationStructureKHR(): If deviceAddress is not zero, createFlags must include "
4684 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR");
4685 }
4686 if (SafeModulo(pCreateInfo->offset, 256) != 0) {
4687 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-offset-03734",
4688 "vkCreateAccelerationStructureKHR(): offset must be a multiple of 256 bytes", pCreateInfo->offset);
4689 }
sourav parmar83c31b12020-05-06 12:30:54 -07004690 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004691 return skip;
4692}
4693
Jason Macnak5c954952019-07-09 15:46:12 -07004694bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
4695 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004696 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004697 bool skip = false;
4698 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004699 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
4700 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07004701 }
4702 return skip;
4703}
4704
sourav parmarcd5fb182020-07-17 12:58:44 -07004705bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesNV(
4706 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureNV *pAccelerationStructures,
4707 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
4708 bool skip = false;
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07004709 if (queryType != VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004710 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesNV-queryType-03432",
4711 "vkCmdWriteAccelerationStructuresPropertiesNV: queryType must be "
Mark Lobodzinskic0df6b62021-01-08 12:34:11 -07004712 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_NV.");
sourav parmarcd5fb182020-07-17 12:58:44 -07004713 }
4714 return skip;
4715}
4716
Peter Chen85366392019-05-14 15:20:11 -04004717bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
4718 uint32_t createInfoCount,
4719 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
4720 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004721 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04004722 bool skip = false;
4723
4724 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004725 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Peter Chen85366392019-05-14 15:20:11 -04004726 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
sourav parmar83c31b12020-05-06 12:30:54 -07004727 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004728 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
4729 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4730 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
4731 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04004732 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004733
4734 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004735 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07004736 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4737 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4738 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4739 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
4740 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
4741 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4742 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4743 }
4744 }
4745
sourav parmarf4a78252020-04-10 13:04:21 -07004746 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4747 skip |=
4748 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
4749 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4750 }
4751 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
4752 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
4753 skip |=
4754 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
4755 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
4756 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
4757 }
4758 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4759 if (pCreateInfos[i].basePipelineIndex != -1) {
4760 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4761 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
4762 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
4763 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4764 "and pCreateInfos->basePipelineIndex is not -1.");
4765 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004766 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004767 skip |=
4768 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
4769 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
4770 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
4771 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
4772 "that element.");
4773 }
sourav parmarf4a78252020-04-10 13:04:21 -07004774 }
4775 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004776 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004777 skip |=
4778 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
4779 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4780 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
4781 "commands pCreateInfos parameter.");
4782 }
4783 } else {
4784 if (pCreateInfos[i].basePipelineIndex != -1) {
4785 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
4786 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4787 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4788 }
4789 }
4790 }
4791 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4792 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
4793 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
4794 }
4795 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
4796 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
4797 "vkCreateRayTracingPipelinesNV: flags must not include "
4798 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
4799 }
4800 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
4801 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
4802 "vkCreateRayTracingPipelinesNV: flags must not include "
4803 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
4804 }
4805 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
4806 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
4807 "vkCreateRayTracingPipelinesNV: flags must not include "
4808 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
4809 }
4810 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
4811 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
4812 "vkCreateRayTracingPipelinesNV: flags must not include "
4813 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
4814 }
4815 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4816 skip |= LogError(
4817 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
4818 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4819 }
4820 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4821 skip |= LogError(
4822 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
4823 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4824 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004825 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) {
4826 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03588",
4827 "vkCreateRayTracingPipelinesNV: flags must not include "
4828 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
4829 }
4830 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
4831 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03816",
4832 "vkCreateRayTracingPipelinesNV: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
4833 }
Peter Chen85366392019-05-14 15:20:11 -04004834 }
4835
4836 return skip;
4837}
4838
sourav parmarcd5fb182020-07-17 12:58:44 -07004839bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(
4840 VkDevice device, VkDeferredOperationKHR deferredOperation, VkPipelineCache pipelineCache, uint32_t createInfoCount,
4841 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos, const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) const {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004842 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004843 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07004844 if (!raytracing_features || raytracing_features->rayTracingPipeline == VK_FALSE) {
4845 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracingPipeline-03586",
4846 "vkCreateRayTracingPipelinesKHR: The rayTracingPipeline feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07004847 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004848 for (uint32_t i = 0; i < createInfoCount; i++) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004849 if (!raytracing_features || (raytracing_features && raytracing_features->rayTraversalPrimitiveCulling == VK_FALSE)) {
4850 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4851 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03596",
4852 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
4853 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4854 }
4855 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4856 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03597",
4857 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
4858 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.");
4859 }
4860 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004861 auto feedback_struct = LvlFindInChain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004862 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
4863 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
sourav parmarcd5fb182020-07-17 12:58:44 -07004864 "vkCreateRayTracingPipelinesKHR: in pCreateInfo[%" PRIu32
4865 "], When chained to VkRayTracingPipelineCreateInfoKHR, "
4866 "VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004867 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
4868 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
4869 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004870 const auto *pipeline_cache_contol_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004871 LvlFindInChain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
sourav parmara96ab1a2020-04-25 16:28:23 -07004872 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4873 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4874 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4875 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
sourav parmarcd5fb182020-07-17 12:58:44 -07004876 "vkCreateRayTracingPipelinesKHR: If the pipelineCreationCacheControl feature is not enabled,"
sourav parmara96ab1a2020-04-25 16:28:23 -07004877 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4878 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4879 }
4880 }
sourav parmarf4a78252020-04-10 13:04:21 -07004881 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004882 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
4883 "vkCreateRayTracingPipelinesKHR: flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
sourav parmarf4a78252020-04-10 13:04:21 -07004884 }
4885 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004886 if (pCreateInfos[i].pLibraryInterface == NULL) {
sourav parmarf4a78252020-04-10 13:04:21 -07004887 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
sourav parmarcd5fb182020-07-17 12:58:44 -07004888 "vkCreateRayTracingPipelinesKHR: If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, "
4889 "pLibraryInterface must not be NULL.");
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004890 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004891 }
4892 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
4893 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03816",
4894 "vkCreateRayTracingPipelinesKHR: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
sourav parmarf4a78252020-04-10 13:04:21 -07004895 }
4896 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
4897 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
4898 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
4899 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
4900 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
4901 skip |= LogError(
4902 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
sourav parmarcd5fb182020-07-17 12:58:44 -07004903 "vkCreateRayTracingPipelinesKHR: If flags includes "
4904 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07004905 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4906 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
4907 "must not be VK_SHADER_UNUSED_KHR");
4908 }
4909 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
4910 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
4911 skip |= LogError(
4912 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
sourav parmarcd5fb182020-07-17 12:58:44 -07004913 "vkCreateRayTracingPipelinesKHR: If flags includes "
4914 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07004915 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4916 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
4917 "element must not be VK_SHADER_UNUSED_KHR");
4918 }
4919 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004920 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_TRUE &&
4921 pCreateInfos[i].pGroups[group_index].pShaderGroupCaptureReplayHandle) {
4922 if (!(pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR)) {
4923 skip |= LogError(
4924 device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03599",
4925 "vkCreateRayTracingPipelinesKHR: If "
4926 "VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineShaderGroupHandleCaptureReplay is "
4927 "VK_TRUE and the pShaderGroupCaptureReplayHandle member of any element of pGroups is not NULL, flags must "
4928 "include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
4929 }
4930 }
sourav parmarf4a78252020-04-10 13:04:21 -07004931 }
4932 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4933 if (pCreateInfos[i].basePipelineIndex != -1) {
4934 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4935 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
sourav parmarcd5fb182020-07-17 12:58:44 -07004936 "vkCreateRayTracingPipelinesKHR: parameter, pCreateInfos->basePipelineHandle, must be "
sourav parmarf4a78252020-04-10 13:04:21 -07004937 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4938 "and pCreateInfos->basePipelineIndex is not -1.");
4939 }
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07004940 if (pCreateInfos[i].basePipelineIndex > static_cast<int32_t>(i)) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004941 skip |=
4942 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
4943 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
4944 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
4945 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
4946 "element.");
4947 }
sourav parmarf4a78252020-04-10 13:04:21 -07004948 }
4949 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004950 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004951 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
sourav parmarcd5fb182020-07-17 12:58:44 -07004952 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07004953 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%d) must be a valid into the calling"
4954 "commands pCreateInfos parameter %d.",
4955 pCreateInfos[i].basePipelineIndex, createInfoCount);
4956 }
4957 } else {
4958 if (pCreateInfos[i].basePipelineIndex != -1) {
4959 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
sourav parmarcd5fb182020-07-17 12:58:44 -07004960 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07004961 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4962 }
4963 }
4964 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004965 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR &&
4966 (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE)) {
4967 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03598",
4968 "vkCreateRayTracingPipelinesKHR: If flags includes "
4969 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR, "
4970 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled.");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004971 }
4972 bool library_enabled = IsExtEnabled(device_extensions.vk_khr_pipeline_library);
4973 if (!library_enabled && (pCreateInfos[i].pLibraryInfo || pCreateInfos[i].pLibraryInterface)) {
4974 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03595",
4975 "vkCreateRayTracingPipelinesKHR: If the VK_KHR_pipeline_library extension is not enabled, "
4976 "pLibraryInfo and pLibraryInterface must be NULL.");
4977 }
4978 if (pCreateInfos[i].pLibraryInfo) {
4979 if (pCreateInfos[i].pLibraryInfo->libraryCount == 0) {
4980 if (pCreateInfos[i].stageCount == 0) {
4981 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03600",
4982 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
4983 "stageCount must not be 0.");
4984 }
4985 if (pCreateInfos[i].groupCount == 0) {
4986 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03601",
4987 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
4988 "groupCount must not be 0.");
4989 }
4990 } else {
4991 if (pCreateInfos[i].pLibraryInterface == NULL) {
4992 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03590",
4993 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount member "
4994 "is greater than 0, its "
4995 "pLibraryInterface member must not be NULL.");
sourav parmarcd5fb182020-07-17 12:58:44 -07004996 }
4997 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07004998 }
4999 if (pCreateInfos[i].pLibraryInterface) {
5000 if (pCreateInfos[i].pLibraryInterface->maxPipelineRayHitAttributeSize >
5001 phys_dev_ext_props.ray_tracing_propsKHR.maxRayHitAttributeSize) {
5002 skip |= LogError(device, "VUID-VkRayTracingPipelineInterfaceCreateInfoKHR-maxPipelineRayHitAttributeSize-03605",
5003 "vkCreateRayTracingPipelinesKHR: maxPipelineRayHitAttributeSize must be less than or equal to "
5004 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayHitAttributeSize.");
5005 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005006 }
5007 if (deferredOperation != VK_NULL_HANDLE) {
5008 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT) {
5009 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-deferredOperation-03587",
5010 "vkCreateRayTracingPipelinesKHR: If deferredOperation is not VK_NULL_HANDLE, the flags member of "
5011 "elements of pCreateInfos must not include VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
sourav parmarf4a78252020-04-10 13:04:21 -07005012 }
5013 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05005014 }
5015
5016 return skip;
5017}
5018
Mike Schuchardt21638df2019-03-16 10:52:02 -07005019#ifdef VK_USE_PLATFORM_WIN32_KHR
5020bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
5021 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005022 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07005023 bool skip = false;
5024 if (!device_extensions.vk_khr_swapchain)
5025 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
5026 if (!device_extensions.vk_khr_get_surface_capabilities_2)
5027 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
5028 if (!device_extensions.vk_khr_surface)
5029 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
5030 if (!device_extensions.vk_khr_get_physical_device_properties_2)
5031 skip |=
5032 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
5033 if (!device_extensions.vk_ext_full_screen_exclusive)
5034 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
5035 skip |= validate_struct_type(
5036 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
5037 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
5038 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
5039 if (pSurfaceInfo != NULL) {
5040 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
5041 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
5042 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
5043
5044 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
5045 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
5046 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
5047 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08005048 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
5049 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07005050
5051 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
5052 }
5053 return skip;
5054}
5055#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01005056
5057bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
5058 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005059 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01005060 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
5061 bool skip = false;
Mike Schuchardt2df08912020-12-15 16:28:09 -08005062 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT) == 0) {
Tobias Hectorebb855f2019-07-23 12:17:33 +01005063 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
5064 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
5065 }
5066 return skip;
5067}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005068
5069bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005070 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005071 bool skip = false;
5072
5073 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005074 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
5075 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05005076 }
5077
5078 return skip;
5079}
Piers Daniell8fd03f52019-08-21 12:07:53 -06005080
5081bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005082 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06005083 bool skip = false;
5084
5085 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005086 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
5087 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06005088 }
5089
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005090 const auto *index_type_uint8_features = LvlFindInChain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06005091 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005092 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
5093 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06005094 }
5095
5096 return skip;
5097}
Mark Lobodzinski84988402019-09-11 15:27:30 -06005098
sfricke-samsung4ada8d42020-02-09 17:43:11 -08005099bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
5100 uint32_t bindingCount, const VkBuffer *pBuffers,
5101 const VkDeviceSize *pOffsets) const {
5102 bool skip = false;
5103 if (firstBinding > device_limits.maxVertexInputBindings) {
5104 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
5105 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
5106 device_limits.maxVertexInputBindings);
5107 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
5108 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
5109 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
5110 "maxVertexInputBindings (%u)",
5111 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
5112 }
5113
Jeff Bolz165818a2020-05-08 11:19:03 -05005114 for (uint32_t i = 0; i < bindingCount; ++i) {
5115 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005116 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Jeff Bolz165818a2020-05-08 11:19:03 -05005117 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
5118 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
5119 "vkCmdBindVertexBuffers() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
5120 } else {
5121 if (pOffsets[i] != 0) {
5122 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
5123 "vkCmdBindVertexBuffers() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
5124 }
5125 }
5126 }
5127 }
5128
sfricke-samsung4ada8d42020-02-09 17:43:11 -08005129 return skip;
5130}
5131
Mark Lobodzinski84988402019-09-11 15:27:30 -06005132bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005133 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06005134 bool skip = false;
5135 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005136 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
5137 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06005138 }
5139 return skip;
5140}
5141
5142bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05005143 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06005144 bool skip = false;
5145 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005146 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
5147 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06005148 }
5149 return skip;
5150}
Petr Kraus3d720392019-11-13 02:52:39 +01005151
5152bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
5153 VkSemaphore semaphore, VkFence fence,
5154 uint32_t *pImageIndex) const {
5155 bool skip = false;
5156
5157 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005158 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
5159 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005160 }
5161
5162 return skip;
5163}
5164
5165bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
5166 uint32_t *pImageIndex) const {
5167 bool skip = false;
5168
5169 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005170 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
5171 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005172 }
5173
5174 return skip;
5175}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005176
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005177bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
5178 uint32_t firstBinding, uint32_t bindingCount,
5179 const VkBuffer *pBuffers,
5180 const VkDeviceSize *pOffsets,
5181 const VkDeviceSize *pSizes) const {
5182 bool skip = false;
5183
5184 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
5185 for (uint32_t i = 0; i < bindingCount; ++i) {
5186 if (pOffsets[i] & 3) {
5187 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
5188 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
5189 }
5190 }
5191
5192 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5193 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
5194 "%s: The firstBinding(%" PRIu32
5195 ") index is greater than or equal to "
5196 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5197 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5198 }
5199
5200 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5201 skip |=
5202 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
5203 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
5204 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5205 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5206 }
5207
5208 for (uint32_t i = 0; i < bindingCount; ++i) {
5209 // pSizes is optional and may be nullptr.
5210 if (pSizes != nullptr) {
5211 if (pSizes[i] != VK_WHOLE_SIZE &&
5212 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
5213 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
5214 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
5215 ") is not VK_WHOLE_SIZE and is greater than "
5216 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
5217 cmd_name, i, pSizes[i]);
5218 }
5219 }
5220 }
5221
5222 return skip;
5223}
5224
5225bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5226 uint32_t firstCounterBuffer,
5227 uint32_t counterBufferCount,
5228 const VkBuffer *pCounterBuffers,
5229 const VkDeviceSize *pCounterBufferOffsets) const {
5230 bool skip = false;
5231
5232 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
5233 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5234 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
5235 "%s: The firstCounterBuffer(%" PRIu32
5236 ") index is greater than or equal to "
5237 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5238 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5239 }
5240
5241 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5242 skip |=
5243 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
5244 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5245 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5246 cmd_name, firstCounterBuffer, counterBufferCount,
5247 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5248 }
5249
5250 return skip;
5251}
5252
5253bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5254 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
5255 const VkBuffer *pCounterBuffers,
5256 const VkDeviceSize *pCounterBufferOffsets) const {
5257 bool skip = false;
5258
5259 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
5260 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5261 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
5262 "%s: The firstCounterBuffer(%" PRIu32
5263 ") index is greater than or equal to "
5264 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5265 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5266 }
5267
5268 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5269 skip |=
5270 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
5271 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5272 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5273 cmd_name, firstCounterBuffer, counterBufferCount,
5274 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5275 }
5276
5277 return skip;
5278}
5279
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005280bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
5281 uint32_t firstInstance, VkBuffer counterBuffer,
5282 VkDeviceSize counterBufferOffset,
5283 uint32_t counterOffset, uint32_t vertexStride) const {
5284 bool skip = false;
5285
5286 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005287 skip |= LogError(
5288 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005289 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
5290 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
5291 }
5292
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005293 if ((counterOffset % 4) != 0) {
sfricke-samsung6886c4b2021-01-16 08:37:35 -08005294 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-counterBufferOffset-04568",
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005295 "vkCmdDrawIndirectByteCountEXT(): offset (%" PRIu64 ") must be a multiple of 4.", counterOffset);
5296 }
5297
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005298 return skip;
5299}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005300
5301bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
5302 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5303 const VkAllocationCallbacks *pAllocator,
5304 VkSamplerYcbcrConversion *pYcbcrConversion,
5305 const char *apiName) const {
5306 bool skip = false;
5307
5308 // Check samplerYcbcrConversion feature is set
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005309 const auto *ycbcr_features = LvlFindInChain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005310 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005311 const auto *vulkan_11_features = LvlFindInChain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005312 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
5313 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07005314 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005315 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005316 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005317
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005318#ifdef VK_USE_PLATFORM_ANDROID_KHR
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005319 const VkExternalFormatANDROID *external_format_android = LvlFindInChain<VkExternalFormatANDROID>(pCreateInfo);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005320 const bool is_external_format = external_format_android != nullptr && external_format_android->externalFormat != 0;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005321#else
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005322 const bool is_external_format = false;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005323#endif
5324
sfricke-samsung1a72f942020-07-25 12:09:18 -07005325 const VkFormat format = pCreateInfo->format;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005326
5327 // If there is a VkExternalFormatANDROID with externalFormat != 0, the value of components is ignored.
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005328 if (!is_external_format) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005329 const VkComponentMapping components = pCreateInfo->components;
5330 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
5331 if (FormatIsXChromaSubsampled(format) == true) {
5332 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
5333 skip |=
5334 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
sfricke-samsung83d98122020-07-04 06:21:15 -07005335 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
5336 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005337 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005338 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005339
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005340 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5341 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
5342 skip |= LogError(
5343 device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
5344 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
5345 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
5346 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
5347 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005348
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005349 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5350 (components.r != VK_COMPONENT_SWIZZLE_B)) {
5351 skip |=
5352 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
sfricke-samsung83d98122020-07-04 06:21:15 -07005353 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
5354 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005355 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005356 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005357
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005358 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5359 (components.b != VK_COMPONENT_SWIZZLE_R)) {
5360 skip |=
5361 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
sfricke-samsung83d98122020-07-04 06:21:15 -07005362 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
5363 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005364 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005365 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005366
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005367 // If one is identity, both need to be
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005368 const bool r_identity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
5369 const bool b_identity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
5370 if ((r_identity != b_identity) && ((r_identity == true) || (b_identity == true))) {
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005371 skip |=
5372 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
sfricke-samsung83d98122020-07-04 06:21:15 -07005373 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
5374 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005375 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
5376 string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005377 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005378 }
5379
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005380 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
5381 // Checks same VU multiple ways in order to give a more useful error message
5382 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
5383 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
5384 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
5385 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
5386 skip |= LogError(
5387 device, vuid,
5388 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5389 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
5390 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5391 string_VkComponentSwizzle(components.b));
5392 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005393
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005394 // "must not correspond to a channel which contains zero or one as a consequence of conversion to RGBA"
5395 // 4 channel format = no issue
5396 // 3 = no [a]
5397 // 2 = no [b,a]
5398 // 1 = no [g,b,a]
5399 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
5400 const uint32_t channels = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatChannelCount(format);
5401
5402 if ((channels < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
5403 (components.b == VK_COMPONENT_SWIZZLE_A))) {
5404 skip |= LogError(device, vuid,
5405 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5406 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
5407 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5408 string_VkComponentSwizzle(components.b));
5409 } else if ((channels < 3) &&
5410 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
5411 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
5412 skip |= LogError(device, vuid,
5413 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5414 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
5415 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5416 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5417 string_VkComponentSwizzle(components.b));
5418 } else if ((channels < 2) &&
5419 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
5420 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
5421 skip |= LogError(device, vuid,
5422 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5423 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
5424 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5425 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5426 string_VkComponentSwizzle(components.b));
5427 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005428 }
5429 }
5430
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005431 return skip;
5432}
5433
5434bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
5435 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5436 const VkAllocationCallbacks *pAllocator,
5437 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5438 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5439 "vkCreateSamplerYcbcrConversion");
5440}
5441
5442bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
5443 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5444 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5445 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5446 "vkCreateSamplerYcbcrConversionKHR");
5447}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005448
5449bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
5450 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
5451 bool skip = false;
5452 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
5453 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
5454
5455 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005456 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
5457 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
5458 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
5459 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
5460 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005461 }
5462 return skip;
5463}
sourav parmara96ab1a2020-04-25 16:28:23 -07005464
5465bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005466 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005467 bool skip = false;
5468 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5469 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5470 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5471 }
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005472 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005473 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5474 skip |= LogError(
5475 device, "VUID-vkCopyAccelerationStructureToMemoryKHR-accelerationStructureHostCommands-03584",
5476 "vkCopyAccelerationStructureToMemoryKHR: The "
5477 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5478 }
5479 skip |= validate_required_pointer("vkCopyAccelerationStructureToMemoryKHR", "pInfo->dst.hostAddress", pInfo->dst.hostAddress,
5480 "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03732");
5481 if (SafeModulo((VkDeviceSize)pInfo->dst.hostAddress, 16) != 0) {
5482 skip |= LogError(device, "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03751",
5483 "vkCopyAccelerationStructureToMemoryKHR(): pInfo->dst.hostAddress must be aligned to 16 bytes.");
5484 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005485 return skip;
5486}
5487
5488bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
5489 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5490 bool skip = false;
5491 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5492 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
5493 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5494 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5495 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005496 if (SafeModulo(pInfo->dst.deviceAddress, 256) != 0) {
5497 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pInfo-03740",
5498 "vkCmdCopyAccelerationStructureToMemoryKHR(): pInfo->dst.deviceAddress must be aligned to 256 bytes.",
5499 pInfo->dst.deviceAddress);
sourav parmar83c31b12020-05-06 12:30:54 -07005500 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005501 return skip;
5502}
5503
5504bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
5505 const char *api_name) const {
5506 bool skip = false;
5507 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
5508 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
5509 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
5510 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
5511 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
5512 api_name);
5513 }
5514 return skip;
5515}
5516
5517bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005518 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005519 bool skip = false;
5520 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005521 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005522 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
sourav parmar83c31b12020-05-06 12:30:54 -07005523 skip |= LogError(
sourav parmarcd5fb182020-07-17 12:58:44 -07005524 device, "VUID-vkCopyAccelerationStructureKHR-accelerationStructureHostCommands-03582",
5525 "vkCopyAccelerationStructureKHR: The "
5526 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005527 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005528 return skip;
5529}
5530
5531bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
5532 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5533 bool skip = false;
5534 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
5535 return skip;
5536}
5537
5538bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005539 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005540 bool skip = false;
5541 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005542 skip |= LogError(device, "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07005543 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
5544 }
5545 return skip;
5546}
5547
5548bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005549 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005550 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005551 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005552 const auto *acc_struct_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005553 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5554 skip |= LogError(
5555 device, "VUID-vkCopyMemoryToAccelerationStructureKHR-accelerationStructureHostCommands-03583",
5556 "vkCopyMemoryToAccelerationStructureKHR: The "
5557 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005558 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005559 skip |= validate_required_pointer("vkCopyMemoryToAccelerationStructureKHR", "pInfo->src.hostAddress", pInfo->src.hostAddress,
5560 "VUID-vkCopyMemoryToAccelerationStructureKHR-pInfo-03729");
sourav parmara96ab1a2020-04-25 16:28:23 -07005561 return skip;
5562}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005563
sourav parmara96ab1a2020-04-25 16:28:23 -07005564bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
5565 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5566 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005567 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
sourav parmarcd5fb182020-07-17 12:58:44 -07005568 if (SafeModulo(pInfo->src.deviceAddress, 256) != 0) {
5569 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pInfo-03743",
5570 "vkCmdCopyMemoryToAccelerationStructureKHR(): pInfo->src.deviceAddress must be aligned to 256 bytes.",
5571 pInfo->src.deviceAddress);
5572 }
sourav parmar83c31b12020-05-06 12:30:54 -07005573 return skip;
5574}
5575bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
5576 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5577 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5578 bool skip = false;
5579 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5580 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5581 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5582 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
5583 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5584 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5585 }
5586 return skip;
5587}
5588bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
5589 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5590 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
5591 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005592 const auto *acc_structure_features = LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005593 if (!acc_structure_features || acc_structure_features->accelerationStructureHostCommands == VK_FALSE) {
5594 skip |= LogError(
5595 device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-accelerationStructureHostCommands-03585",
5596 "vkCmdWriteAccelerationStructuresPropertiesKHR: The "
5597 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5598 }
sourav parmar83c31b12020-05-06 12:30:54 -07005599 if (dataSize < accelerationStructureCount * stride) {
5600 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
5601 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
5602 "accelerationStructureCount (%d) *stride(%zu).",
5603 dataSize, accelerationStructureCount, stride);
5604 }
5605 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5606 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5607 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5608 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
5609 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5610 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5611 }
5612 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
5613 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5614 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
5615 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5616 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
5617 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5618 stride);
5619 }
5620 }
5621 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
5622 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5623 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
5624 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5625 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
5626 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5627 stride);
5628 }
5629 }
sourav parmar83c31b12020-05-06 12:30:54 -07005630 return skip;
5631}
5632bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
5633 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
5634 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005635 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005636 if (!raytracing_features || raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE) {
5637 skip |= LogError(
5638 device, "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03606",
5639 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR:VkPhysicalDeviceRayTracingPipelineFeaturesKHR::"
5640 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled to call this function.");
sourav parmar83c31b12020-05-06 12:30:54 -07005641 }
5642 return skip;
5643}
5644
5645bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
sourav parmarcd5fb182020-07-17 12:58:44 -07005646 const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
5647 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable,
5648 const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
5649 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable,
sourav parmar83c31b12020-05-06 12:30:54 -07005650 uint32_t width, uint32_t height, uint32_t depth) const {
5651 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005652 // RayGen
5653 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
5654 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-size-04023",
5655 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07005656 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005657 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5658 0) {
5659 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03682",
5660 "vkCmdTraceRaysKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
5661 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5662 }
5663 // Callable
5664 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5665 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03694",
5666 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
5667 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005668 }
5669 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5670 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
5671 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07005672 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5673 }
5674 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5675 0) {
5676 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03693",
5677 "vkCmdTraceRaysKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
5678 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005679 }
5680 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005681 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5682 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03690",
5683 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple of "
5684 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005685 }
5686 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5687 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07005688 "vkCmdTraceRaysKHR: TThe stride member of pHitShaderBindingTable must be less than or equal to "
5689 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride");
sourav parmar83c31b12020-05-06 12:30:54 -07005690 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005691 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5692 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03689",
5693 "vkCmdTraceRaysKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
5694 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5695 }
sourav parmar83c31b12020-05-06 12:30:54 -07005696 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005697 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5698 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03686",
5699 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple of "
5700 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment");
sourav parmar83c31b12020-05-06 12:30:54 -07005701 }
5702 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5703 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
5704 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07005705 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5706 }
5707 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5708 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03685",
5709 "vkCmdTraceRaysKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
5710 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5711 }
5712 if (width * depth * height > phys_dev_ext_props.ray_tracing_propsKHR.maxRayDispatchInvocationCount) {
5713 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-width-03629",
5714 "vkCmdTraceRaysKHR: width {times} height {times} depth must be less than or equal to "
5715 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayDispatchInvocationCount");
5716 }
5717 if (width > device_limits.maxComputeWorkGroupCount[0] * device_limits.maxComputeWorkGroupSize[0]) {
5718 skip |=
5719 LogError(device, "VUID-vkCmdTraceRaysKHR-width-03626",
5720 "vkCmdTraceRaysKHR: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[0] "
5721 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[0]");
sourav parmar83c31b12020-05-06 12:30:54 -07005722 }
5723
sourav parmarcd5fb182020-07-17 12:58:44 -07005724 if (height > device_limits.maxComputeWorkGroupCount[1] * device_limits.maxComputeWorkGroupSize[1]) {
5725 skip |=
5726 LogError(device, "VUID-vkCmdTraceRaysKHR-height-03627",
5727 "vkCmdTraceRaysKHR: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1] "
5728 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[1]");
5729 }
5730
5731 if (depth > device_limits.maxComputeWorkGroupCount[2] * device_limits.maxComputeWorkGroupSize[2]) {
5732 skip |=
5733 LogError(device, "VUID-vkCmdTraceRaysKHR-depth-03628",
5734 "vkCmdTraceRaysKHR: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2] "
5735 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[2]");
sourav parmar83c31b12020-05-06 12:30:54 -07005736 }
5737 return skip;
5738}
5739
sourav parmarcd5fb182020-07-17 12:58:44 -07005740bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(
5741 VkCommandBuffer commandBuffer, const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
5742 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable, const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
5743 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable, VkDeviceAddress indirectDeviceAddress) const {
sourav parmar83c31b12020-05-06 12:30:54 -07005744 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005745 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07005746 if (!raytracing_features || raytracing_features->rayTracingPipelineTraceRaysIndirect == VK_FALSE) {
5747 skip |= LogError(
5748 device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingPipelineTraceRaysIndirect-03637",
5749 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineTraceRaysIndirect "
5750 "feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005751 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005752 // RayGen
5753 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
5754 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-size-04023",
5755 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07005756 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005757 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5758 0) {
5759 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03682",
5760 "vkCmdTraceRaysIndirectKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
5761 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5762 }
5763 // Callabe
5764 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5765 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03694",
5766 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
5767 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005768 }
5769 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5770 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
sourav parmarcd5fb182020-07-17 12:58:44 -07005771 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be less than or equal "
5772 "to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5773 }
5774 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5775 0) {
5776 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03693",
5777 "vkCmdTraceRaysIndirectKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
5778 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005779 }
5780 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005781 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5782 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03690",
5783 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple of "
5784 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005785 }
5786 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5787 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07005788 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be less than or equal to "
5789 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
sourav parmar83c31b12020-05-06 12:30:54 -07005790 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005791 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5792 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03689",
5793 "vkCmdTraceRaysIndirectKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
5794 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5795 }
sourav parmar83c31b12020-05-06 12:30:54 -07005796 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005797 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5798 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03686",
5799 "vkCmdTraceRaysIndirectKHR:The stride member of pMissShaderBindingTable must be a multiple of "
5800 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005801 }
5802 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5803 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
sourav parmarcd5fb182020-07-17 12:58:44 -07005804 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be less than or equal to "
5805 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5806 }
5807 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5808 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03685",
5809 "vkCmdTraceRaysIndirectKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
5810 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005811 }
5812
sourav parmarcd5fb182020-07-17 12:58:44 -07005813 if (SafeModulo(indirectDeviceAddress, 4) != 0) {
5814 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-indirectDeviceAddress-03634",
5815 "vkCmdTraceRaysIndirectKHR: indirectDeviceAddress must be a multiple of 4.");
sourav parmar83c31b12020-05-06 12:30:54 -07005816 }
5817 return skip;
5818}
5819bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
5820 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
5821 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
5822 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
5823 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
5824 uint32_t width, uint32_t height, uint32_t depth) const {
5825 bool skip = false;
5826 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5827 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
5828 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
5829 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5830 }
5831 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5832 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
5833 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
5834 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5835 }
5836 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5837 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
5838 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
5839 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
5840 }
5841
5842 // hitShader
5843 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5844 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
5845 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
5846 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5847 }
5848 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5849 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
5850 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
5851 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5852 }
5853 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5854 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
5855 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
5856 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5857 }
5858
5859 // missShader
5860 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5861 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
5862 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
5863 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5864 }
5865 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5866 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
5867 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
5868 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5869 }
5870 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5871 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
5872 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
5873 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5874 }
5875
5876 // raygenShader
5877 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5878 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
5879 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07005880 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5881 }
5882 if (width > device_limits.maxComputeWorkGroupCount[0]) {
5883 skip |=
5884 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
5885 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
5886 }
5887 if (height > device_limits.maxComputeWorkGroupCount[1]) {
5888 skip |=
5889 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
5890 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
5891 }
5892 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
5893 skip |=
5894 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
5895 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07005896 }
5897 return skip;
5898}
5899
sourav parmar83c31b12020-05-06 12:30:54 -07005900bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005901 VkDevice device, const VkAccelerationStructureVersionInfoKHR *pVersionInfo,
5902 VkAccelerationStructureCompatibilityKHR *pCompatibility) const {
sourav parmar83c31b12020-05-06 12:30:54 -07005903 bool skip = false;
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07005904 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
5905 const auto *raytracing_features = LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
Nathaniel Cesarioce9b4812020-12-17 08:55:28 -07005906 if ((!raytracing_features && !ray_query_features) || ((ray_query_features && !(ray_query_features->rayQuery)) ||
5907 (raytracing_features && !raytracing_features->rayTracingPipeline))) {
sourav parmarcd5fb182020-07-17 12:58:44 -07005908 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracingPipeline-03661",
sourav parmar83c31b12020-05-06 12:30:54 -07005909 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
5910 }
5911 return skip;
5912}
5913
Piers Daniell39842ee2020-07-10 16:42:33 -06005914bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
5915 const VkViewport *pViewports) const {
5916 bool skip = false;
5917
5918 if (!physical_device_features.multiViewport) {
5919 if (viewportCount != 1) {
5920 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03395",
5921 "vkCmdSetViewportWithCountEXT: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
5922 ") is not 1.",
5923 viewportCount);
5924 }
5925 } else { // multiViewport enabled
5926 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
5927 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03394",
5928 "vkCmdSetViewportWithCountEXT: viewportCount (=%" PRIu32
5929 ") must "
5930 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5931 viewportCount, device_limits.maxViewports);
5932 }
5933 }
5934
5935 if (pViewports) {
5936 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
5937 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
5938 const char *fn_name = "vkCmdSetViewportWithCountEXT";
5939 skip |= manual_PreCallValidateViewport(
5940 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
5941 }
5942 }
5943
5944 return skip;
5945}
5946
5947bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
5948 const VkRect2D *pScissors) const {
5949 bool skip = false;
5950
5951 if (!physical_device_features.multiViewport) {
5952 if (scissorCount != 1) {
5953 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03398",
5954 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5955 ") must "
5956 "be 1 when the multiViewport feature is disabled.",
5957 scissorCount);
5958 }
5959 } else { // multiViewport enabled
5960 if (scissorCount == 0) {
5961 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5962 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5963 ") must "
5964 "be great than zero.",
5965 scissorCount);
5966 } else if (scissorCount > device_limits.maxViewports) {
5967 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5968 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5969 ") must "
5970 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5971 scissorCount, device_limits.maxViewports);
5972 }
5973 }
5974
5975 if (pScissors) {
5976 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
5977 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
5978
5979 if (scissor.offset.x < 0) {
5980 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5981 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
5982 scissor.offset.x);
5983 }
5984
5985 if (scissor.offset.y < 0) {
5986 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5987 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
5988 scissor.offset.y);
5989 }
5990
5991 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
5992 if (x_sum > INT32_MAX) {
5993 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03400",
5994 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5995 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5996 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
5997 }
5998
5999 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
6000 if (y_sum > INT32_MAX) {
6001 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03401",
6002 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
6003 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
6004 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
6005 }
6006 }
6007 }
6008
6009 return skip;
6010}
6011
6012bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
6013 uint32_t bindingCount, const VkBuffer *pBuffers,
6014 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
6015 const VkDeviceSize *pStrides) const {
6016 bool skip = false;
6017 if (firstBinding >= device_limits.maxVertexInputBindings) {
6018 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03355",
6019 "vkCmdBindVertexBuffers2EXT() firstBinding (%u) must be less than maxVertexInputBindings (%u)",
6020 firstBinding, device_limits.maxVertexInputBindings);
6021 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
6022 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03356",
6023 "vkCmdBindVertexBuffers2EXT() sum of firstBinding (%u) and bindingCount (%u) must be less than "
6024 "maxVertexInputBindings (%u)",
6025 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
6026 }
6027
6028 for (uint32_t i = 0; i < bindingCount; ++i) {
6029 if (pBuffers[i] == VK_NULL_HANDLE) {
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006030 const auto *robustness2_features = LvlFindInChain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
Piers Daniell39842ee2020-07-10 16:42:33 -06006031 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
6032 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04111",
6033 "vkCmdBindVertexBuffers2EXT() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
6034 } else {
6035 if (pOffsets[i] != 0) {
6036 skip |=
6037 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04112",
6038 "vkCmdBindVertexBuffers2EXT() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
6039 }
6040 }
6041 }
6042 if (pStrides) {
6043 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
6044 skip |=
6045 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pStrides-03362",
6046 "vkCmdBindVertexBuffers2EXT() pStrides[%d] (%u) must be less than maxVertexInputBindingStride (%u)", i,
6047 pStrides[i], device_limits.maxVertexInputBindingStride);
6048 }
6049 }
6050 }
6051
6052 return skip;
6053}
sourav parmarcd5fb182020-07-17 12:58:44 -07006054
6055bool StatelessValidation::ValidateAccelerationStructureBuildGeometryInfoKHR(
6056 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos, uint32_t infoCount, const char *api_name) const {
6057 bool skip = false;
6058 for (uint32_t i = 0; i < infoCount; ++i) {
6059 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
6060 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03654",
6061 "(%s): type must not be VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.", api_name);
6062 }
6063 if (pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
6064 pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
6065 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-flags-03796",
6066 "(%s): If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR bit set,"
6067 "then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.",
6068 api_name);
6069 }
6070 if (pInfos[i].pGeometries && pInfos[i].ppGeometries) {
6071 skip |=
6072 LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-pGeometries-03788",
6073 "(%s): Only one of pGeometries or ppGeometries can be a valid pointer, the other must be NULL", api_name);
6074 }
6075 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pInfos[i].geometryCount != 1) {
6076 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03790",
6077 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, geometryCount must be 1", api_name);
6078 }
6079 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
6080 pInfos[i].geometryCount > phys_dev_ext_props.acc_structure_props.maxGeometryCount) {
6081 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03793",
6082 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then geometryCount must be"
6083 " less than or equal to VkPhysicalDeviceAccelerationStructurePropertiesKHR::maxGeometryCount",
6084 api_name);
6085 }
6086 if (pInfos[i].pGeometries) {
6087 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6088 skip |= validate_ranged_enum(
6089 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometryType", ParameterName::IndexVector{i, j}),
6090 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].pGeometries[j].geometryType,
6091 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
6092 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006093 skip |= validate_struct_type(
6094 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles", ParameterName::IndexVector{i, j}),
6095 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6096 &(pInfos[i].pGeometries[j].geometry.triangles),
6097 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
6098 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
6099 skip |= validate_struct_pnext(
6100 api_name,
6101 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
6102 NULL, pInfos[i].pGeometries[j].geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6103 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
6104 skip |=
6105 validate_ranged_enum(api_name,
6106 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.vertexFormat",
6107 ParameterName::IndexVector{i, j}),
6108 "VkFormat", AllVkFormatEnums, pInfos[i].pGeometries[j].geometry.triangles.vertexFormat,
6109 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
6110 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
6111 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6112 &pInfos[i].pGeometries[j].geometry.triangles,
6113 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
6114 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
6115 skip |= validate_ranged_enum(
6116 api_name,
6117 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.indexType", ParameterName::IndexVector{i, j}),
6118 "VkIndexType", AllVkIndexTypeEnums, pInfos[i].pGeometries[j].geometry.triangles.indexType,
6119 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
6120
6121 if (pInfos[i].pGeometries[j].geometry.triangles.vertexStride > UINT32_MAX) {
6122 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
6123 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
6124 }
6125 if (pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
6126 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
6127 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
6128 skip |=
6129 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
6130 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
6131 api_name);
6132 }
6133 }
6134 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6135 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
6136 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6137 &pInfos[i].pGeometries[j].geometry.instances,
6138 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
6139 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
6140 skip |= validate_struct_type(
6141 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.instances", ParameterName::IndexVector{i, j}),
6142 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6143 &(pInfos[i].pGeometries[j].geometry.instances),
6144 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
6145 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
6146 skip |= validate_struct_pnext(
6147 api_name,
6148 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.pNext", ParameterName::IndexVector{i, j}),
6149 NULL, pInfos[i].pGeometries[j].geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6150 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
6151
6152 skip |= validate_bool32(api_name,
6153 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.arrayOfPointers",
6154 ParameterName::IndexVector{i, j}),
6155 pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers);
6156 }
6157 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6158 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6159 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6160 &pInfos[i].pGeometries[j].geometry.aabbs,
6161 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6162 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6163 skip |= validate_struct_type(
6164 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs", ParameterName::IndexVector{i, j}),
6165 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6166 &(pInfos[i].pGeometries[j].geometry.aabbs),
6167 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6168 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6169 skip |= validate_struct_pnext(
6170 api_name,
6171 ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6172 pInfos[i].pGeometries[j].geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6173 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6174 if (pInfos[i].pGeometries[j].geometry.aabbs.stride > UINT32_MAX) {
6175 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6176 "(%s):stride must be less than or equal to 2^32-1", api_name);
6177 }
6178 }
6179 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6180 pInfos[i].pGeometries[j].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6181 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6182 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6183 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6184 api_name);
6185 }
6186 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6187 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6188 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6189 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6190 "of elements of"
6191 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6192 api_name);
6193 }
6194 if (pInfos[i].pGeometries[j].geometryType != pInfos[i].pGeometries[0].geometryType) {
6195 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6196 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6197 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6198 api_name);
6199 }
6200 }
6201 }
6202 }
6203 if (pInfos[i].ppGeometries != NULL) {
6204 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6205 skip |= validate_ranged_enum(
6206 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometryType", ParameterName::IndexVector{i, j}),
6207 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].ppGeometries[j]->geometryType,
6208 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
6209 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006210 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
6211 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6212 &pInfos[i].ppGeometries[j]->geometry.triangles,
6213 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
6214 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
6215 skip |= validate_struct_type(
6216 api_name,
6217 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles", ParameterName::IndexVector{i, j}),
6218 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6219 &(pInfos[i].ppGeometries[j]->geometry.triangles),
6220 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
6221 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
6222 skip |= validate_struct_pnext(
6223 api_name,
6224 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
6225 NULL, pInfos[i].ppGeometries[j]->geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6226 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
6227 skip |= validate_ranged_enum(api_name,
6228 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.vertexFormat",
6229 ParameterName::IndexVector{i, j}),
6230 "VkFormat", AllVkFormatEnums,
6231 pInfos[i].ppGeometries[j]->geometry.triangles.vertexFormat,
6232 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
6233 skip |= validate_ranged_enum(api_name,
6234 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.indexType",
6235 ParameterName::IndexVector{i, j}),
6236 "VkIndexType", AllVkIndexTypeEnums,
6237 pInfos[i].ppGeometries[j]->geometry.triangles.indexType,
6238 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
6239 if (pInfos[i].ppGeometries[j]->geometry.triangles.vertexStride > UINT32_MAX) {
6240 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
6241 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
6242 }
6243 if (pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
6244 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
6245 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
6246 skip |=
6247 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
6248 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
6249 api_name);
6250 }
6251 }
6252 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6253 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
6254 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6255 &pInfos[i].ppGeometries[j]->geometry.instances,
6256 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
6257 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
6258 skip |= validate_struct_type(
6259 api_name,
6260 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances", ParameterName::IndexVector{i, j}),
6261 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6262 &(pInfos[i].ppGeometries[j]->geometry.instances),
6263 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
6264 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
6265 skip |= validate_struct_pnext(
6266 api_name,
6267 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.pNext", ParameterName::IndexVector{i, j}),
6268 NULL, pInfos[i].ppGeometries[j]->geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6269 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
6270 skip |= validate_bool32(api_name,
6271 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.arrayOfPointers",
6272 ParameterName::IndexVector{i, j}),
6273 pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers);
6274 }
6275 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6276 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6277 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6278 &pInfos[i].ppGeometries[j]->geometry.aabbs,
6279 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6280 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6281 skip |= validate_struct_type(
6282 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs", ParameterName::IndexVector{i, j}),
6283 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6284 &(pInfos[i].ppGeometries[j]->geometry.aabbs),
6285 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6286 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6287 skip |= validate_struct_pnext(
6288 api_name,
6289 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6290 pInfos[i].ppGeometries[j]->geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6291 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6292 if (pInfos[i].ppGeometries[j]->geometry.aabbs.stride > UINT32_MAX) {
6293 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6294 "(%s):stride must be less than or equal to 2^32-1", api_name);
6295 }
6296 }
6297 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6298 pInfos[i].ppGeometries[j]->geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6299 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6300 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6301 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6302 api_name);
6303 }
6304 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6305 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6306 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6307 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6308 "of elements of"
6309 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6310 api_name);
6311 }
6312 if (pInfos[i].ppGeometries[j]->geometryType != pInfos[i].ppGeometries[0]->geometryType) {
6313 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6314 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6315 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6316 api_name);
6317 }
6318 }
6319 }
6320 }
6321 }
6322 return skip;
6323}
6324bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresKHR(
6325 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6326 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6327 bool skip = false;
6328 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresKHR");
6329 for (uint32_t i = 0; i < infoCount; ++i) {
6330 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6331 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6332 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03710",
6333 "vkCmdBuildAccelerationStructuresKHR:For each element of pInfos, its "
6334 "scratchData.deviceAddress member must be a multiple of "
6335 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6336 }
6337 for (uint32_t k = 0; k < infoCount; ++k) {
6338 if (i == k) continue;
6339 bool found = false;
6340 if (pInfos[i].dstAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6341 skip |= LogError(
6342 device, "VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6343 "vkCmdBuildAccelerationStructuresKHR:The dstAccelerationStructure member of any element (%d) of pInfos must "
6344 "not be "
6345 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6346 i, k);
6347 found = true;
6348 }
6349 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6350 skip |= LogError(
6351 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03403",
6352 "vkCmdBuildAccelerationStructuresKHR:The srcAccelerationStructure member of any element (%d) of pInfos must "
6353 "not be "
6354 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6355 i, k);
6356 found = true;
6357 }
6358 if (found) break;
6359 }
6360 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6361 if (pInfos[i].pGeometries) {
6362 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6363 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6364 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6365 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6366 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6367 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6368 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6369 }
6370 } else {
6371 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6372 skip |=
6373 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6374 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6375 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6376 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6377 }
6378 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006379 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006380 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6381 skip |= LogError(
6382 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6383 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6384 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6385 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006386 } else if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6387 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006388 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6389 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6390 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6391 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6392 }
6393 }
6394 } else if (pInfos[i].ppGeometries) {
6395 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6396 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6397 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6398 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6399 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6400 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6401 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6402 }
6403 } else {
6404 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6405 skip |=
6406 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6407 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6408 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6409 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6410 }
6411 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006412 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006413 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6414 skip |= LogError(
6415 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6416 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6417 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6418 }
Ricardo Garcia2ba3da82020-12-02 11:27:53 +01006419 } else if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6420 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.transformData.deviceAddress, 16) != 0) {
sourav parmarcd5fb182020-07-17 12:58:44 -07006421 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6422 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6423 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6424 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6425 }
6426 }
6427 }
6428 }
6429 }
6430 return skip;
6431}
6432
6433bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresIndirectKHR(
6434 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6435 const VkDeviceAddress *pIndirectDeviceAddresses, const uint32_t *pIndirectStrides,
6436 const uint32_t *const *ppMaxPrimitiveCounts) const {
6437 bool skip = false;
6438 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresIndirectKHR");
6439 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006440 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006441 if (!ray_tracing_acceleration_structure_features ||
6442 ray_tracing_acceleration_structure_features->accelerationStructureIndirectBuild == VK_FALSE) {
6443 skip |= LogError(
6444 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-accelerationStructureIndirectBuild-03650",
6445 "vkCmdBuildAccelerationStructuresIndirectKHR: The "
6446 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureIndirectBuild feature must be enabled.");
6447 }
6448 for (uint32_t i = 0; i < infoCount; ++i) {
6449 if (pInfos[i].mode == VK_BUILD_ACCELERATION_STRUCTURE_MODE_UPDATE_KHR) {
6450 if (pInfos[i].srcAccelerationStructure == VK_NULL_HANDLE) {
6451 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03666",
6452 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, if its mode member is "
6453 "VK_BUILD_ACCELERATION_STRUCTURE_MODE_UPDATE_KHR, its srcAccelerationStructure member must not be "
6454 "VK_NULL_HANDLE.");
6455 }
6456 }
6457 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6458 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6459 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03710",
6460 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, its "
6461 "scratchData.deviceAddress member must be a multiple of "
6462 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6463 }
6464 for (uint32_t k = 0; k < infoCount; ++k) {
6465 if (i == k) continue;
6466 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6467 skip |=
6468 LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03403",
6469 "vkCmdBuildAccelerationStructuresIndirectKHR:The srcAccelerationStructure member of any element (%d) "
6470 "of pInfos must not be the same acceleration structure as the dstAccelerationStructure member of "
6471 "any other element [%d) of pInfos.",
6472 i, k);
6473 break;
6474 }
6475 }
6476 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6477 if (pInfos[i].pGeometries) {
6478 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6479 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6480 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6481 skip |= LogError(
6482 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6483 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6484 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6485 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6486 }
6487 } else {
6488 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6489 skip |= LogError(
6490 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6491 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6492 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6493 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6494 }
6495 }
6496 }
6497 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6498 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6499 skip |= LogError(
6500 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6501 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6502 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6503 }
6504 }
6505 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6506 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.indexData.deviceAddress, 16) != 0) {
6507 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6508 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6509 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6510 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6511 }
6512 }
6513 } else if (pInfos[i].ppGeometries) {
6514 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6515 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6516 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6517 skip |= LogError(
6518 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6519 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6520 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6521 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6522 }
6523 } else {
6524 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6525 skip |= LogError(
6526 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6527 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6528 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6529 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6530 }
6531 }
6532 }
6533 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6534 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6535 skip |= LogError(
6536 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6537 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6538 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6539 }
6540 }
6541 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6542 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.indexData.deviceAddress, 16) != 0) {
6543 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6544 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6545 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6546 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6547 }
6548 }
6549 }
6550 }
6551 }
6552 return skip;
6553}
6554
6555bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructuresKHR(
6556 VkDevice device, VkDeferredOperationKHR deferredOperation, uint32_t infoCount,
6557 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6558 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6559 bool skip = false;
6560 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkBuildAccelerationStructuresKHR");
6561 const auto *ray_tracing_acceleration_structure_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006562 LvlFindInChain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006563 if (!ray_tracing_acceleration_structure_features ||
6564 ray_tracing_acceleration_structure_features->accelerationStructureHostCommands == VK_FALSE) {
6565 skip |=
6566 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581",
6567 "vkBuildAccelerationStructuresKHR: The "
6568 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled");
6569 }
6570 for (uint32_t i = 0; i < infoCount; ++i) {
6571 for (uint32_t j = 0; j < infoCount; ++j) {
6572 if (i == j) continue;
6573 bool found = false;
6574 if (pInfos[i].dstAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6575 skip |= LogError(
6576 device, "VUID-vkBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6577 "vkBuildAccelerationStructuresKHR(): The dstAccelerationStructure member of any element (%d) of pInfos must "
6578 "not be "
6579 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6580 i, j);
6581 found = true;
6582 }
6583 if (pInfos[i].srcAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6584 skip |= LogError(
6585 device, "VUID-vkBuildAccelerationStructuresKHR-pInfos-03403",
6586 "vkBuildAccelerationStructuresKHR(): The srcAccelerationStructure member of any element (%d) of pInfos must "
6587 "not be "
6588 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6589 i, j);
6590 found = true;
6591 }
6592 if (found) break;
6593 }
6594 }
6595 return skip;
6596}
6597
6598bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureBuildSizesKHR(
6599 VkDevice device, VkAccelerationStructureBuildTypeKHR buildType, const VkAccelerationStructureBuildGeometryInfoKHR *pBuildInfo,
6600 const uint32_t *pMaxPrimitiveCounts, VkAccelerationStructureBuildSizesInfoKHR *pSizeInfo) const {
6601 bool skip = false;
6602 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pBuildInfo, 1, "vkGetAccelerationStructureBuildSizesKHR");
6603 const auto *ray_tracing_pipeline_features =
Mark Lobodzinski1f887d32020-12-30 15:31:33 -07006604 LvlFindInChain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
6605 const auto *ray_query_features = LvlFindInChain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
sourav parmarcd5fb182020-07-17 12:58:44 -07006606 if (!(ray_tracing_pipeline_features || ray_query_features) ||
6607 ((ray_tracing_pipeline_features && ray_tracing_pipeline_features->rayTracingPipeline == VK_FALSE) ||
6608 (ray_query_features && ray_query_features->rayQuery == VK_FALSE))) {
6609 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-rayTracingPipeline-03617",
6610 "vkGetAccelerationStructureBuildSizesKHR:The rayTracingPipeline or rayQuery feature must be enabled");
6611 }
6612 return skip;
6613}
sfricke-samsungecafb192021-01-17 08:21:14 -08006614
6615bool StatelessValidation::manual_PreCallValidateCreatePrivateDataSlotEXT(VkDevice device,
6616 const VkPrivateDataSlotCreateInfoEXT *pCreateInfo,
6617 const VkAllocationCallbacks *pAllocator,
6618 VkPrivateDataSlotEXT *pPrivateDataSlot) const {
6619 bool skip = false;
6620 const auto *private_data_features = LvlFindInChain<VkPhysicalDevicePrivateDataFeaturesEXT>(device_createinfo_pnext);
6621 if (private_data_features && private_data_features->privateData == VK_FALSE) {
6622 skip |= LogError(device, "VUID-vkCreatePrivateDataSlotEXT-privateData-04564",
6623 "vkCreatePrivateDataSlotEXT(): The privateData feature must be enabled.");
6624 }
6625 return skip;
6626}