blob: 3644096e1df5311277ae94f5dfc4971da6f7b861 [file] [log] [blame]
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001/* Copyright (c) 2015-2017 The Khronos Group Inc.
2 * Copyright (c) 2015-2017 Valve Corporation
3 * Copyright (c) 2015-2017 LunarG, Inc.
4 * Copyright (C) 2015-2017 Google Inc.
5 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
22
23#include <limits.h>
24#include <math.h>
25#include <stdio.h>
26#include <stdlib.h>
27#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028
29#include <iostream>
30#include <string>
31#include <sstream>
32#include <unordered_map>
33#include <unordered_set>
34#include <vector>
35#include <mutex>
36
37#include "vk_loader_platform.h"
38#include "vulkan/vk_layer.h"
39#include "vk_layer_config.h"
40#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060041#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060042
43#include "vk_layer_table.h"
44#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
48
49#include "parameter_name.h"
50#include "parameter_validation.h"
51
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060052#if defined __ANDROID__
53#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060054#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060055#else
56#define LOGCONSOLE(...) \
57 { \
58 printf(__VA_ARGS__); \
59 printf("\n"); \
60 }
61#endif
62
Mark Lobodzinskid4950072017-08-01 13:02:20 -060063namespace parameter_validation {
64
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060065extern std::unordered_map<std::string, void *> custom_functions;
66
Mark Lobodzinskid4950072017-08-01 13:02:20 -060067extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
68 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
69extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
70extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
71 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
72extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
73extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
74 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
75extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
76 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
77 const VkAllocationCallbacks *pAllocator,
78 VkDebugReportCallbackEXT *pMsgCallback);
79extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
80 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070081extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
82 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
83 const VkAllocationCallbacks *pAllocator,
84 VkDebugUtilsMessengerEXT *pMessenger);
85extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
86 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060087extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
88 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010089extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
90 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
91extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
92 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060093
94// TODO : This can be much smarter, using separate locks for separate global data
95std::mutex global_lock;
96
97static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
98std::unordered_map<void *, layer_data *> layer_data_map;
99std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
100
101void InitializeManualParameterValidationFunctionPointers(void);
102
103static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700104 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
105 "lunarg_parameter_validation");
106 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
107 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600108}
109
Mark Young6ba8abe2017-11-09 10:37:04 -0700110static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
111 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600112
113static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700114 "VK_LAYER_LUNARG_parameter_validation",
115 VK_LAYER_API_VERSION,
116 1,
117 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600118};
119
120static const int MaxParamCheckerStringLength = 256;
121
John Zulauf71968502017-10-26 13:51:15 -0600122template <typename T>
123static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
124 // Using only < for generality and || for early abort
125 return !((value < min) || (max < value));
126}
127
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600128static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
129 const char *validateString) {
130 assert(apiName != nullptr);
131 assert(validateString != nullptr);
132
133 bool skip = false;
134
135 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
136
137 if (result == VK_STRING_ERROR_NONE) {
138 return skip;
139 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600140 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, INVALID_USAGE,
141 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600142 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600143 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, INVALID_USAGE,
144 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600145 }
146 return skip;
147}
148
149static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600150 const char *parameter_name, int32_t error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600151 bool skip = false;
152
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600153 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
154 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600155 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600156 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
157 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600158 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600159 skip |=
160 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600161 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600162 "%s: %s (= %" PRIu32
163 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
164 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600165 }
166
167 return skip;
168}
169
170static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
171 const char *cmd_name, const char *array_parameter_name, int32_t unique_error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600172 int32_t valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600173 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600174 if (queue_families) {
175 std::unordered_set<uint32_t> set;
176 for (uint32_t i = 0; i < queue_family_count; ++i) {
177 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
178
179 if (set.count(queue_families[i])) {
180 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600181 HandleToUint64(device_data->device), VALIDATION_ERROR_056002e8,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600182 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
183 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600184 } else {
185 set.insert(queue_families[i]);
186 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600187 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600188 }
189 }
190 }
191 return skip;
192}
193
194VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600195 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600196 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
197
198 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
199 assert(chain_info != nullptr);
200 assert(chain_info->u.pLayerInfo != nullptr);
201
202 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
203 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
204 if (fpCreateInstance == NULL) {
205 return VK_ERROR_INITIALIZATION_FAILED;
206 }
207
208 // Advance the link info for the next element on the chain
209 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
210
211 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
212
213 if (result == VK_SUCCESS) {
214 InitializeManualParameterValidationFunctionPointers();
215 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
216 assert(my_instance_data != nullptr);
217
218 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
219 my_instance_data->instance = *pInstance;
220 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700221 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
222 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600223
224 // Look for one or more debug report create info structures
225 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700226 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
227 &my_instance_data->tmp_messenger_create_infos,
228 &my_instance_data->tmp_debug_messengers)) {
229 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600230 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700231 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
232 my_instance_data->tmp_messenger_create_infos,
233 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600234 // Failure of setting up one or more of the callback.
235 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700236 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
237 my_instance_data->tmp_debug_messengers);
238 my_instance_data->num_tmp_debug_messengers = 0;
239 }
240 }
241 }
242 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
243 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
244 if (my_instance_data->num_tmp_report_callbacks > 0) {
245 // Setup the temporary callback(s) here to catch early issues:
246 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
247 my_instance_data->tmp_report_create_infos,
248 my_instance_data->tmp_report_callbacks)) {
249 // Failure of setting up one or more of the callback.
250 // Therefore, clean up and don't use those callbacks:
251 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
252 my_instance_data->tmp_report_callbacks);
253 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600254 }
255 }
256 }
257
258 init_parameter_validation(my_instance_data, pAllocator);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600259
260 uint32_t api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(
261 (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0), pCreateInfo);
262
263 if (pCreateInfo->pApplicationInfo) {
264 uint32_t specified_api_version = pCreateInfo->pApplicationInfo->apiVersion & ~VK_VERSION_PATCH(~0);
265 if (!(specified_api_version == VK_API_VERSION_1_0) && !(specified_api_version == VK_API_VERSION_1_1)) {
266 LOGCONSOLE(
267 "Warning: Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number -- (0x%08x) assuming "
268 "%s.\n",
269 pCreateInfo->pApplicationInfo->apiVersion,
270 (api_version == VK_API_VERSION_1_0) ? "VK_API_VERSION_1_0" : "VK_API_VERSION_1_1");
271 }
272 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600273
274 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
275 // survive we can report the issue now.
276 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
277
278 if (pCreateInfo->pApplicationInfo) {
279 if (pCreateInfo->pApplicationInfo->pApplicationName) {
280 validate_string(my_instance_data->report_data, "vkCreateInstance",
281 "pCreateInfo->VkApplicationInfo->pApplicationName",
282 pCreateInfo->pApplicationInfo->pApplicationName);
283 }
284
285 if (pCreateInfo->pApplicationInfo->pEngineName) {
286 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
287 pCreateInfo->pApplicationInfo->pEngineName);
288 }
289 }
290
291 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700292 if (my_instance_data->num_tmp_debug_messengers > 0) {
293 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
294 my_instance_data->tmp_debug_messengers);
295 }
296 if (my_instance_data->num_tmp_report_callbacks > 0) {
297 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
298 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600299 }
300 }
301
302 return result;
303}
304
305VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
306 // Grab the key before the instance is destroyed.
307 dispatch_key key = get_dispatch_key(instance);
308 bool skip = false;
309 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
310
311 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
312 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700313 if (instance_data->num_tmp_debug_messengers > 0) {
314 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
315 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
316 callback_setup = true;
317 }
318 }
319 if (instance_data->num_tmp_report_callbacks > 0) {
320 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
321 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600322 callback_setup = true;
323 }
324 }
325
326 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
327
328 // Disable and cleanup the temporary callback(s):
329 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700330 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
331 instance_data->tmp_debug_messengers);
332 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
333 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600334 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700335 if (instance_data->num_tmp_debug_messengers > 0) {
336 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
337 instance_data->num_tmp_debug_messengers = 0;
338 }
339 if (instance_data->num_tmp_report_callbacks > 0) {
340 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
341 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600342 }
343
344 if (!skip) {
345 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
346
347 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700348 while (instance_data->logging_messenger.size() > 0) {
349 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
350 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
351 instance_data->logging_messenger.pop_back();
352 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600353 while (instance_data->logging_callback.size() > 0) {
354 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700355 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600356 instance_data->logging_callback.pop_back();
357 }
358
Mark Young6ba8abe2017-11-09 10:37:04 -0700359 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600360 }
361
362 FreeLayerDataPtr(key, instance_layer_data_map);
363}
364
365VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
366 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
367 const VkAllocationCallbacks *pAllocator,
368 VkDebugReportCallbackEXT *pMsgCallback) {
369 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
370 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
371
372 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
373 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
374 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700375 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
376 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
377 if (VK_SUCCESS != result) {
378 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
379 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600380 }
381 return result;
382}
383
384VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
385 const VkAllocationCallbacks *pAllocator) {
386 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
387 if (!skip) {
388 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
389 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700390 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
391 }
392}
393
394VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
395 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
396 const VkAllocationCallbacks *pAllocator,
397 VkDebugUtilsMessengerEXT *pMessenger) {
398 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
399 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
400
401 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
402 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
403 if (VK_SUCCESS == result) {
404 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
405 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
406 if (VK_SUCCESS != result) {
407 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
408 }
409 }
410 return result;
411}
412
413VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
414 const VkAllocationCallbacks *pAllocator) {
415 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
416 if (!skip) {
417 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
418 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
419 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600420 }
421}
422
423static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
424 const VkDeviceCreateInfo *pCreateInfo) {
425 bool skip = false;
426
427 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
428 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
429 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
430 pCreateInfo->ppEnabledLayerNames[i]);
431 }
432 }
433
434 bool maint1 = false;
435 bool negative_viewport = false;
436
437 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
438 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
439 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
440 pCreateInfo->ppEnabledExtensionNames[i]);
441 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_MAINTENANCE1_EXTENSION_NAME) == 0) maint1 = true;
442 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME) == 0)
443 negative_viewport = true;
444 }
445 }
446
447 if (maint1 && negative_viewport) {
448 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600449 VALIDATION_ERROR_056002ec,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600450 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600451 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600452 }
453
454 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
455 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600456 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
457 if (features2) {
458 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
459 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600460 INVALID_USAGE,
John Zulaufde972ac2017-10-26 12:07:05 -0600461 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
462 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600463 }
464 }
465
466 // Validate pCreateInfo->pQueueCreateInfos
467 if (pCreateInfo->pQueueCreateInfos) {
468 std::unordered_set<uint32_t> set;
469
470 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
471 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
472 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
473 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600474 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Mark Lobodzinski88529492018-04-01 10:38:15 -0600475 VALIDATION_ERROR_06c002fa,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600476 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700477 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600478 "index value.",
479 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600480 } else if (set.count(requested_queue_family)) {
481 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600482 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Mark Lobodzinski88529492018-04-01 10:38:15 -0600483 VALIDATION_ERROR_056002e8,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600484 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600485 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
486 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600487 } else {
488 set.insert(requested_queue_family);
489 }
490
491 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
492 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
493 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
494 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
495 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600496 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Mark Lobodzinski88529492018-04-01 10:38:15 -0600497 VALIDATION_ERROR_06c002fe,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600498 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600499 "] (=%f) is not between 0 and 1 (inclusive).",
500 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600501 }
502 }
503 }
504 }
505 }
506
507 return skip;
508}
509
510VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
511 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
512 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
513
514 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
515 bool skip = false;
516 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
517 assert(my_instance_data != nullptr);
518 std::unique_lock<std::mutex> lock(global_lock);
519
520 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
521
522 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo);
523
524 if (!skip) {
525 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
526 assert(chain_info != nullptr);
527 assert(chain_info->u.pLayerInfo != nullptr);
528
529 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
530 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
531 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
532 if (fpCreateDevice == NULL) {
533 return VK_ERROR_INITIALIZATION_FAILED;
534 }
535
536 // Advance the link info for the next element on the chain
537 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
538
539 lock.unlock();
540
541 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
542
543 lock.lock();
544
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600545 if (result == VK_SUCCESS) {
546 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
547 assert(my_device_data != nullptr);
548
Mark Young6ba8abe2017-11-09 10:37:04 -0700549 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600550 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
551
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600552 // Query and save physical device limits for this device
553 VkPhysicalDeviceProperties device_properties = {};
554 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
555
556 my_device_data->api_version = my_device_data->extensions.InitFromDeviceCreateInfo(
557 &my_instance_data->extensions, device_properties.apiVersion, pCreateInfo);
558
559 uint32_t specified_api_version = device_properties.apiVersion & ~VK_VERSION_PATCH(~0);
560 if (!(specified_api_version == VK_API_VERSION_1_0) && !(specified_api_version == VK_API_VERSION_1_1)) {
561 LOGCONSOLE(
562 "Warning: Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number -- (0x%8x) assuming "
563 "%s.\n",
564 device_properties.apiVersion,
565 (my_device_data->api_version == VK_API_VERSION_1_0) ? "VK_API_VERSION_1_0" : "VK_API_VERSION_1_1");
566 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600567
568 // Store createdevice data
569 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
570 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
571 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
572 pCreateInfo->pQueueCreateInfos[i].queueCount));
573 }
574 }
575
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600576 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
577 my_device_data->physical_device = physicalDevice;
578 my_device_data->device = *pDevice;
579
580 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600581 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
582 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
583 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600584 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
585 if (features2) {
586 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600587 }
588 }
589 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700590 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600591 } else {
592 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
593 }
594 }
595 }
596
597 return result;
598}
599
600VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
601 dispatch_key key = get_dispatch_key(device);
602 bool skip = false;
603 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
604 {
605 std::unique_lock<std::mutex> lock(global_lock);
606 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
607 }
608
609 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700610 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600611 device_data->dispatch_table.DestroyDevice(device, pAllocator);
612 }
613 FreeLayerDataPtr(key, layer_data_map);
614}
615
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600616bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
617 bool skip = false;
618 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
619
620 skip |=
621 ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex", VALIDATION_ERROR_29600300);
622 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
623 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
624 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600625 HandleToUint64(device), VALIDATION_ERROR_29600302,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600626 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700627 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600628 ") when the device was created (i.e. is not less than %" PRIu32 ").",
629 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600630 }
631 return skip;
632}
633
634VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
635 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
636 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
637 bool skip = false;
638 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
639 std::unique_lock<std::mutex> lock(global_lock);
640
641 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
642 "pCreateInfo->queueFamilyIndex", VALIDATION_ERROR_02c0004e);
643
644 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
645
646 lock.unlock();
647 if (!skip) {
648 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
649 }
650 return result;
651}
652
653VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
654 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
655 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
656 bool skip = false;
657 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
658
659 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
660
661 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
662 if (pCreateInfo != nullptr) {
663 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
664 // VkQueryPipelineStatisticFlagBits values
665 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
666 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
667 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600668 VALIDATION_ERROR_11c00630,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700669 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
670 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600671 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600672 }
673 }
674 if (!skip) {
675 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
676 }
677 return result;
678}
679
Petr Krause91f7a12017-12-14 20:57:36 +0100680VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
681 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
682 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
683 bool skip = false;
684 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
685
686 {
687 std::unique_lock<std::mutex> lock(global_lock);
688 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
689
Dave Houltonb3bbec72018-01-17 10:13:33 -0700690 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
691 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100692 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
693 if (custom_func != nullptr) {
694 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
695 }
696 }
697
698 if (!skip) {
699 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
700
701 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
702 if (result == VK_SUCCESS) {
703 std::unique_lock<std::mutex> lock(global_lock);
704 const auto renderPass = *pRenderPass;
705 auto &renderpass_state = device_data->renderpasses_states[renderPass];
706
707 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
708 bool uses_color = false;
709 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
710 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
711
712 bool uses_depthstencil = false;
713 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
714 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
715 uses_depthstencil = true;
716
717 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
718 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
719 }
720 }
721 }
722 return result;
723}
724
725VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
726 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
727 bool skip = false;
728
729 {
730 std::unique_lock<std::mutex> lock(global_lock);
731 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
732
Dave Houltonb3bbec72018-01-17 10:13:33 -0700733 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
734 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100735 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
736 if (custom_func != nullptr) {
737 skip |= custom_func(device, renderPass, pAllocator);
738 }
739 }
740
741 if (!skip) {
742 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
743
744 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
745 {
746 std::unique_lock<std::mutex> lock(global_lock);
747 device_data->renderpasses_states.erase(renderPass);
748 }
749 }
750}
751
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600752bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
753 VkBuffer *pBuffer) {
754 bool skip = false;
755 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
756 debug_report_data *report_data = device_data->report_data;
757
Mark Lobodzinski88529492018-04-01 10:38:15 -0600758 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100759
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600760 if (pCreateInfo != nullptr) {
Petr Krause5c37652018-01-05 04:05:12 +0100761 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", VALIDATION_ERROR_01400720, log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600762
763 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
764 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
765 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
766 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600767 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600768 VALIDATION_ERROR_01400724,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600769 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600770 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600771 }
772
773 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
774 // queueFamilyIndexCount uint32_t values
775 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600776 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600777 VALIDATION_ERROR_01400722,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600778 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
779 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600780 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600781 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600782 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
783 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", INVALID_USAGE, INVALID_USAGE,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600784 false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600785 }
786 }
787
788 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
789 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
790 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
791 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600792 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600793 VALIDATION_ERROR_0140072c,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600794 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600795 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600796 }
797 }
798
799 return skip;
800}
801
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600802bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
803 VkImage *pImage) {
804 bool skip = false;
805 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
806 debug_report_data *report_data = device_data->report_data;
807
Mark Lobodzinski88529492018-04-01 10:38:15 -0600808 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100809
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600810 if (pCreateInfo != nullptr) {
811 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
812 FormatIsCompressed_ETC2_EAC(pCreateInfo->format)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600813 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600814 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionETC2 feature is "
815 "not enabled: neither ETC2 nor EAC formats can be used to create images.",
816 string_VkFormat(pCreateInfo->format));
817 }
818
819 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
820 FormatIsCompressed_ASTC_LDR(pCreateInfo->format)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600821 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700822 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionASTC_LDR feature "
823 "is not enabled: ASTC formats cannot be used to create images.",
824 string_VkFormat(pCreateInfo->format));
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600825 }
826
827 if ((device_data->physical_device_features.textureCompressionBC == false) && FormatIsCompressed_BC(pCreateInfo->format)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600828 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700829 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionBC feature is not "
830 "enabled: BC compressed formats cannot be used to create images.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600831 string_VkFormat(pCreateInfo->format));
832 }
833
834 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
835 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
836 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
837 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600838 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600839 VALIDATION_ERROR_09e0075c,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600840 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600841 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600842 }
843
844 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
845 // queueFamilyIndexCount uint32_t values
846 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600847 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600848 VALIDATION_ERROR_09e0075a,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600849 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
850 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600851 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600852 } else {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600853 skip |=
854 ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
855 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", INVALID_USAGE, INVALID_USAGE, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600856 }
857 }
858
Petr Krause5c37652018-01-05 04:05:12 +0100859 skip |=
860 ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width", VALIDATION_ERROR_09e00760, log_misc);
861 skip |=
862 ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height", VALIDATION_ERROR_09e00762, log_misc);
863 skip |=
864 ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth", VALIDATION_ERROR_09e00764, log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600865
Petr Krause5c37652018-01-05 04:05:12 +0100866 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", VALIDATION_ERROR_09e00766, log_misc);
867 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers", VALIDATION_ERROR_09e00768, log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600868
Dave Houlton130c0212018-01-29 13:39:56 -0700869 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700870 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
871 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
872 skip |= log_msg(
Mark Lobodzinski88529492018-04-01 10:38:15 -0600873 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, VALIDATION_ERROR_09e007c2,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600874 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
875 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700876 }
877
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600878 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100879 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
880 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600881 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600882 VALIDATION_ERROR_09e00778,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700883 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600884 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600885 }
886
887 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100888 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
889 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600890 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600891 VK_NULL_HANDLE, VALIDATION_ERROR_09e00774,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600892 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
893 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
894 ") are not equal.",
895 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100896 }
897
898 if (pCreateInfo->arrayLayers < 6) {
899 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600900 VK_NULL_HANDLE, VALIDATION_ERROR_09e00774,
Petr Kraus3f433212018-03-13 12:31:27 +0100901 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600902 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
903 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100904 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600905 }
906
907 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600908 skip |=
909 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
910 VALIDATION_ERROR_09e0077a,
911 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600912 }
913 }
914
Dave Houlton130c0212018-01-29 13:39:56 -0700915 // 3D image may have only 1 layer
916 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600917 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
918 VALIDATION_ERROR_09e00782,
919 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700920 }
921
922 // If multi-sample, validate type, usage, tiling and mip levels.
923 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
924 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
925 (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) || (pCreateInfo->mipLevels != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600926 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600927 VALIDATION_ERROR_09e00784,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600928 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700929 }
930
931 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
932 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
933 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
934 // At least one of the legal attachment bits must be set
935 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600936 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600937 VALIDATION_ERROR_09e0078c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600938 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700939 }
940 // No flags other than the legal attachment bits may be set
941 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
942 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600943 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600944 VALIDATION_ERROR_09e00786,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600945 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700946 }
947 }
948
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600949 // mipLevels must be less than or equal to floor(log2(max(extent.width,extent.height,extent.depth)))+1
950 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Petr Krause5c37652018-01-05 04:05:12 +0100951 if (maxDim > 0 && pCreateInfo->mipLevels > (floor(log2(maxDim)) + 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600952 skip |= log_msg(
953 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, VALIDATION_ERROR_09e0077c,
954 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
955 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600956 }
957
Petr Krausb6f97802018-03-13 12:31:39 +0100958 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
959 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600960 VALIDATION_ERROR_09e00792,
Petr Krausb6f97802018-03-13 12:31:39 +0100961 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600962 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100963 }
964
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600965 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
966 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
967 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
968 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600969 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600970 VALIDATION_ERROR_09e007b6,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600971 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600972 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600973 }
974
975 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
976 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
977 // Linear tiling is unsupported
978 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600979 skip |=
980 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, INVALID_USAGE,
981 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
982 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600983 }
984
985 // Sparse 1D image isn't valid
986 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600987 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600988 VALIDATION_ERROR_09e00794,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600989 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600990 }
991
992 // Sparse 2D image when device doesn't support it
993 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
994 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600995 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600996 VALIDATION_ERROR_09e00796,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600997 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600998 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600999 }
1000
1001 // Sparse 3D image when device doesn't support it
1002 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1003 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001004 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001005 VALIDATION_ERROR_09e00798,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001006 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001007 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001008 }
1009
1010 // Multi-sample 2D image when device doesn't support it
1011 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1012 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1013 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001014 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001015 VALIDATION_ERROR_09e0079a,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001016 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001017 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001018 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1019 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001020 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001021 VALIDATION_ERROR_09e0079c,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001022 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001023 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001024 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1025 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001026 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001027 VALIDATION_ERROR_09e0079e,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001028 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001029 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001030 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1031 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001032 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001033 VALIDATION_ERROR_09e007a0,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001034 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001035 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001036 }
1037 }
1038 }
1039 }
1040 return skip;
1041}
1042
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001043bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1044 VkImageView *pView) {
1045 bool skip = false;
1046 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1047 debug_report_data *report_data = device_data->report_data;
1048
1049 if (pCreateInfo != nullptr) {
1050 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D) || (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_2D)) {
1051 if ((pCreateInfo->subresourceRange.layerCount != 1) &&
1052 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001053 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001054
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001055 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_%dD, "
1056 "pCreateInfo->subresourceRange.layerCount must be 1",
1057 ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D) ? 1 : 2));
1058 }
1059 } else if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D_ARRAY) ||
1060 (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_2D_ARRAY)) {
1061 if ((pCreateInfo->subresourceRange.layerCount < 1) &&
1062 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001063 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001064
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001065 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_%dD_ARRAY, "
1066 "pCreateInfo->subresourceRange.layerCount must be >= 1",
1067 ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D_ARRAY) ? 1 : 2));
1068 }
1069 } else if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE) {
1070 if ((pCreateInfo->subresourceRange.layerCount != 6) &&
1071 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001072 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001073
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001074 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_CUBE, "
1075 "pCreateInfo->subresourceRange.layerCount must be 6");
1076 }
1077 } else if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) {
1078 if (((pCreateInfo->subresourceRange.layerCount == 0) || ((pCreateInfo->subresourceRange.layerCount % 6) != 0)) &&
1079 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001080 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001081
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001082 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_CUBE_ARRAY, "
1083 "pCreateInfo->subresourceRange.layerCount must be a multiple of 6");
1084 }
1085 if (!device_data->physical_device_features.imageCubeArray) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001086 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001087 "vkCreateImageView: Device feature imageCubeArray not enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001088 }
1089 } else if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_3D) {
1090 if (pCreateInfo->subresourceRange.baseArrayLayer != 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001091 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001092
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001093 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_3D, "
1094 "pCreateInfo->subresourceRange.baseArrayLayer must be 0");
1095 }
1096
1097 if ((pCreateInfo->subresourceRange.layerCount != 1) &&
1098 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001099 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001100
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001101 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_3D, "
1102 "pCreateInfo->subresourceRange.layerCount must be 1");
1103 }
1104 }
1105 }
1106 return skip;
1107}
1108
Petr Krausb3fcdb42018-01-09 22:09:09 +01001109bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1110 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1111 bool skip = false;
1112 debug_report_data *report_data = device_data->report_data;
1113
1114 // Note: for numerical correctness
1115 // - float comparisons should expect NaN (comparison always false).
1116 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1117
1118 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001119 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001120 if (v1_f <= 0.0f) return true;
1121
1122 float intpart;
1123 const float fract = modff(v1_f, &intpart);
1124
1125 assert(std::numeric_limits<float>::radix == 2);
1126 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1127 if (intpart >= u32_max_plus1) return false;
1128
1129 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1130 if (v1_u32 < v2_u32)
1131 return true;
1132 else if (v1_u32 == v2_u32 && fract == 0.0f)
1133 return true;
1134 else
1135 return false;
1136 };
1137
1138 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1139 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1140 return (v1_f <= v2_f);
1141 };
1142
1143 // width
1144 bool width_healthy = true;
1145 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1146
1147 if (!(viewport.width > 0.0f)) {
1148 width_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001149 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dd4,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001150 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001151 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1152 width_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001153 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dd6,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001154 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1155 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001156 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001157 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001158 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001159 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1160 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001161 }
1162
1163 // height
1164 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001165 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1166 device_data->extensions.vk_khr_maintenance1 ||
1167 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001168 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1169
1170 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1171 height_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001172 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dd8,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001173 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001174 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1175 height_healthy = false;
1176
Mark Lobodzinski88529492018-04-01 10:38:15 -06001177 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dda,
1178 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1179 ").",
1180 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001181 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1182 height_healthy = false;
1183
1184 skip |= log_msg(
Mark Lobodzinski88529492018-04-01 10:38:15 -06001185 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001186 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001187 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1188 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001189 }
1190
1191 // x
1192 bool x_healthy = true;
1193 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1194 x_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001195 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000ddc,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001196 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1197 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001198 }
1199
1200 // x + width
1201 if (x_healthy && width_healthy) {
1202 const float right_bound = viewport.x + viewport.width;
1203 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001204 skip |=
1205 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a0,
1206 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1207 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1208 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001209 }
1210 }
1211
1212 // y
1213 bool y_healthy = true;
1214 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1215 y_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001216 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dde,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001217 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1218 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001219 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1220 y_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001221 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000de0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001222 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1223 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001224 }
1225
1226 // y + height
1227 if (y_healthy && height_healthy) {
1228 const float boundary = viewport.y + viewport.height;
1229
1230 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001231 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a2,
1232 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1233 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1234 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001235 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1236 skip |= log_msg(
Mark Lobodzinski88529492018-04-01 10:38:15 -06001237 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000de2,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001238 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1239 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001240 }
1241 }
1242
1243 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1244 // minDepth
1245 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001246 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a4,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001247
Petr Krausb3fcdb42018-01-09 22:09:09 +01001248 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001249 "[0.0, 1.0] range.",
1250 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001251 }
1252
1253 // maxDepth
1254 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001255 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a6,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001256
Petr Krausb3fcdb42018-01-09 22:09:09 +01001257 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001258 "[0.0, 1.0] range.",
1259 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001260 }
1261 }
1262
1263 return skip;
1264}
1265
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001266bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1267 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1268 VkPipeline *pPipelines) {
1269 bool skip = false;
1270 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1271 debug_report_data *report_data = device_data->report_data;
1272
1273 if (pCreateInfos != nullptr) {
1274 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001275 bool has_dynamic_viewport = false;
1276 bool has_dynamic_scissor = false;
1277 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001278 bool has_dynamic_viewport_w_scaling_nv = false;
1279 bool has_dynamic_discard_rectangle_ext = false;
1280 bool has_dynamic_sample_locations_ext = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001281 if (pCreateInfos[i].pDynamicState != nullptr) {
1282 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1283 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1284 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1285 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1286 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1287 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001288 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1289 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1290 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001291 }
1292 }
1293
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001294 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1295 if (pCreateInfos[i].pVertexInputState != nullptr) {
1296 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
1297 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1298 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
1299 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1300 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001301 VALIDATION_ERROR_14c004d4,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001302 "vkCreateGraphicsPipelines: parameter "
1303 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001304 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1305 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001306 }
1307
1308 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1309 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001310 VALIDATION_ERROR_14c004d6,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001311 "vkCreateGraphicsPipelines: parameter "
1312 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001313 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1314 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001315 }
1316 }
1317
1318 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1319 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
1320 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1321 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001322 VALIDATION_ERROR_14a004d8,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001323 "vkCreateGraphicsPipelines: parameter "
1324 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001325 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1326 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001327 }
1328
1329 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1330 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001331 VALIDATION_ERROR_14a004da,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001332 "vkCreateGraphicsPipelines: parameter "
1333 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001334 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1335 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001336 }
1337
1338 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001339 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1340 VALIDATION_ERROR_14a004dc,
1341 "vkCreateGraphicsPipelines: parameter "
1342 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1343 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1344 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001345 }
1346 }
1347 }
1348
1349 if (pCreateInfos[i].pStages != nullptr) {
1350 bool has_control = false;
1351 bool has_eval = false;
1352
1353 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1354 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1355 has_control = true;
1356 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1357 has_eval = true;
1358 }
1359 }
1360
1361 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1362 if (has_control && has_eval) {
1363 if (pCreateInfos[i].pTessellationState == nullptr) {
1364 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001365 VALIDATION_ERROR_096005b6,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001366 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1367 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001368 "pCreateInfos[%d].pTessellationState must not be NULL.",
1369 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001370 } else {
1371 skip |= validate_struct_pnext(
1372 report_data, "vkCreateGraphicsPipelines",
1373 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
1374 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0961c40d);
1375
1376 skip |= validate_reserved_flags(
1377 report_data, "vkCreateGraphicsPipelines",
1378 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
1379 pCreateInfos[i].pTessellationState->flags, VALIDATION_ERROR_10809005);
1380
1381 if (pCreateInfos[i].pTessellationState->sType !=
1382 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1383 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001384 VALIDATION_ERROR_1082b00b,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001385 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001386 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1387 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001388 }
1389
1390 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1391 pCreateInfos[i].pTessellationState->patchControlPoints >
1392 device_data->device_limits.maxTessellationPatchSize) {
1393 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001394 VALIDATION_ERROR_1080097c,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001395 "vkCreateGraphicsPipelines: invalid parameter "
1396 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001397 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001398 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001399 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001400 }
1401 }
1402 }
1403 }
1404
1405 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1406 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1407 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1408 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001409 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001410 VK_NULL_HANDLE, VALIDATION_ERROR_096005dc,
Petr Krausa6103552017-11-16 21:21:58 +01001411 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1412 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001413 "].pViewportState (=NULL) is not a valid pointer.",
1414 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001415 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001416 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1417
1418 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1419 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001420 VK_NULL_HANDLE, VALIDATION_ERROR_10c2b00b,
Petr Krausa6103552017-11-16 21:21:58 +01001421 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001422 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1423 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001424 }
1425
Petr Krausa6103552017-11-16 21:21:58 +01001426 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1427 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
1428 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV};
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001429 skip |= validate_struct_pnext(
1430 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001431 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
1432 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV",
1433 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
1434 allowed_structs_VkPipelineViewportStateCreateInfo, 65, VALIDATION_ERROR_10c1c40d);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001435
1436 skip |= validate_reserved_flags(
1437 report_data, "vkCreateGraphicsPipelines",
1438 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Petr Krausa6103552017-11-16 21:21:58 +01001439 viewport_state.flags, VALIDATION_ERROR_10c09005);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001440
Petr Krausa6103552017-11-16 21:21:58 +01001441 if (!device_data->physical_device_features.multiViewport) {
1442 if (viewport_state.viewportCount != 1) {
1443 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001444 VK_NULL_HANDLE, VALIDATION_ERROR_10c00980,
Petr Krausa6103552017-11-16 21:21:58 +01001445 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1446 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001447 ") is not 1.",
1448 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001449 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001450
Petr Krausa6103552017-11-16 21:21:58 +01001451 if (viewport_state.scissorCount != 1) {
1452 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001453 VK_NULL_HANDLE, VALIDATION_ERROR_10c00982,
Petr Krausa6103552017-11-16 21:21:58 +01001454 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1455 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001456 ") is not 1.",
1457 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001458 }
Petr Krausa6103552017-11-16 21:21:58 +01001459 } else { // multiViewport enabled
1460 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001461 skip |= log_msg(
1462 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001463 VK_NULL_HANDLE, VALIDATION_ERROR_10c30a1b,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001464 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001465 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1466 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001467 VK_NULL_HANDLE, VALIDATION_ERROR_10c00984,
Petr Krausa6103552017-11-16 21:21:58 +01001468 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1469 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001470 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1471 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001472 }
Petr Krausa6103552017-11-16 21:21:58 +01001473
1474 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001475 skip |= log_msg(
1476 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001477 VK_NULL_HANDLE, VALIDATION_ERROR_10c2b61b,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001478 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001479 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1480 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001481 VK_NULL_HANDLE, VALIDATION_ERROR_10c00986,
Petr Krausa6103552017-11-16 21:21:58 +01001482 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1483 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001484 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1485 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001486 }
1487 }
1488
Petr Krausa6103552017-11-16 21:21:58 +01001489 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001490 skip |=
1491 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001492 VK_NULL_HANDLE, VALIDATION_ERROR_10c00988,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001493 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1494 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1495 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001496 }
1497
Petr Krausa6103552017-11-16 21:21:58 +01001498 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1499 skip |= log_msg(
1500 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001501 VALIDATION_ERROR_096005d6,
Petr Krausa6103552017-11-16 21:21:58 +01001502 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1503 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001504 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1505 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001506 }
1507
1508 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1509 skip |= log_msg(
1510 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001511 VALIDATION_ERROR_096005d8,
Petr Krausa6103552017-11-16 21:21:58 +01001512 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1513 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001514 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1515 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001516 }
1517
Petr Krausb3fcdb42018-01-09 22:09:09 +01001518 // validate the VkViewports
1519 if (!has_dynamic_viewport && viewport_state.pViewports) {
1520 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1521 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1522 const char fn_name[] = "vkCreateGraphicsPipelines";
1523 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1524 std::to_string(viewport_i) + "]";
1525 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1526 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1527 }
1528 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001529
1530 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1531 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001532 VK_NULL_HANDLE, EXTENSION_NOT_ENABLED,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001533 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001534 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001535 "VK_NV_clip_space_w_scaling extension is not enabled.",
1536 i);
1537 }
1538
1539 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1540 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001541 VK_NULL_HANDLE, EXTENSION_NOT_ENABLED,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001542 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001543 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001544 "VK_EXT_discard_rectangles extension is not enabled.",
1545 i);
1546 }
1547
1548 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1549 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001550 VK_NULL_HANDLE, EXTENSION_NOT_ENABLED,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001551 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001552 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001553 "VK_EXT_sample_locations extension is not enabled.",
1554 i);
1555 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001556 }
1557
1558 if (pCreateInfos[i].pMultisampleState == nullptr) {
1559 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001560 VALIDATION_ERROR_096005de,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001561 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001562 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1563 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001564 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001565 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1566 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1567 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001568 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001569 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001570 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001571 skip |= validate_struct_pnext(
1572 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001573 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1574 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
1575 VALIDATION_ERROR_1001c40d);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001576
1577 skip |= validate_reserved_flags(
1578 report_data, "vkCreateGraphicsPipelines",
1579 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
1580 pCreateInfos[i].pMultisampleState->flags, VALIDATION_ERROR_10009005);
1581
1582 skip |= validate_bool32(
1583 report_data, "vkCreateGraphicsPipelines",
1584 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1585 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1586
1587 skip |= validate_array(
1588 report_data, "vkCreateGraphicsPipelines",
1589 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1590 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
1591 pCreateInfos[i].pMultisampleState->rasterizationSamples, pCreateInfos[i].pMultisampleState->pSampleMask,
1592 true, false, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
1593
1594 skip |= validate_bool32(
1595 report_data, "vkCreateGraphicsPipelines",
1596 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1597 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1598
1599 skip |= validate_bool32(
1600 report_data, "vkCreateGraphicsPipelines",
1601 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1602 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1603
1604 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
1605 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001606 INVALID_STRUCT_STYPE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001607 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
1608 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
1609 i);
1610 }
John Zulauf7acac592017-11-06 11:15:53 -07001611 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
1612 if (!device_data->physical_device_features.sampleRateShading) {
1613 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001614 VALIDATION_ERROR_10000620,
John Zulauf7acac592017-11-06 11:15:53 -07001615 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001616 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
1617 i);
John Zulauf7acac592017-11-06 11:15:53 -07001618 }
1619 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
1620 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
1621 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
1622 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001623 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001624 VALIDATION_ERROR_10000624,
1625 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07001626 }
1627 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001628 }
1629
Petr Krause91f7a12017-12-14 20:57:36 +01001630 bool uses_color_attachment = false;
1631 bool uses_depthstencil_attachment = false;
1632 {
1633 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
1634 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
1635 const auto &subpasses_uses = subpasses_uses_it->second;
1636 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
1637 uses_color_attachment = true;
1638 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
1639 uses_depthstencil_attachment = true;
1640 }
1641 }
1642
1643 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001644 skip |= validate_struct_pnext(
1645 report_data, "vkCreateGraphicsPipelines",
1646 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
1647 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0f61c40d);
1648
1649 skip |= validate_reserved_flags(
1650 report_data, "vkCreateGraphicsPipelines",
1651 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
1652 pCreateInfos[i].pDepthStencilState->flags, VALIDATION_ERROR_0f609005);
1653
1654 skip |= validate_bool32(
1655 report_data, "vkCreateGraphicsPipelines",
1656 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
1657 pCreateInfos[i].pDepthStencilState->depthTestEnable);
1658
1659 skip |= validate_bool32(
1660 report_data, "vkCreateGraphicsPipelines",
1661 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
1662 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
1663
1664 skip |= validate_ranged_enum(
1665 report_data, "vkCreateGraphicsPipelines",
1666 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
1667 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
1668 VALIDATION_ERROR_0f604001);
1669
1670 skip |= validate_bool32(
1671 report_data, "vkCreateGraphicsPipelines",
1672 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
1673 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
1674
1675 skip |= validate_bool32(
1676 report_data, "vkCreateGraphicsPipelines",
1677 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
1678 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
1679
1680 skip |= validate_ranged_enum(
1681 report_data, "vkCreateGraphicsPipelines",
1682 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
1683 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
1684 VALIDATION_ERROR_13a08601);
1685
1686 skip |= validate_ranged_enum(
1687 report_data, "vkCreateGraphicsPipelines",
1688 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
1689 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
1690 VALIDATION_ERROR_13a27801);
1691
1692 skip |= validate_ranged_enum(
1693 report_data, "vkCreateGraphicsPipelines",
1694 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
1695 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
1696 VALIDATION_ERROR_13a04201);
1697
1698 skip |= validate_ranged_enum(
1699 report_data, "vkCreateGraphicsPipelines",
1700 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
1701 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
1702 VALIDATION_ERROR_0f604001);
1703
1704 skip |= validate_ranged_enum(
1705 report_data, "vkCreateGraphicsPipelines",
1706 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
1707 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
1708 VALIDATION_ERROR_13a08601);
1709
1710 skip |= validate_ranged_enum(
1711 report_data, "vkCreateGraphicsPipelines",
1712 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
1713 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
1714 VALIDATION_ERROR_13a27801);
1715
1716 skip |= validate_ranged_enum(
1717 report_data, "vkCreateGraphicsPipelines",
1718 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
1719 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
1720 VALIDATION_ERROR_13a04201);
1721
1722 skip |= validate_ranged_enum(
1723 report_data, "vkCreateGraphicsPipelines",
1724 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
1725 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
1726 VALIDATION_ERROR_0f604001);
1727
1728 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
1729 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001730 INVALID_STRUCT_STYPE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001731 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
1732 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
1733 i);
1734 }
1735 }
1736
Petr Krause91f7a12017-12-14 20:57:36 +01001737 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001738 skip |= validate_struct_pnext(
1739 report_data, "vkCreateGraphicsPipelines",
1740 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}), NULL,
1741 pCreateInfos[i].pColorBlendState->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0f41c40d);
1742
1743 skip |= validate_reserved_flags(
1744 report_data, "vkCreateGraphicsPipelines",
1745 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
1746 pCreateInfos[i].pColorBlendState->flags, VALIDATION_ERROR_0f409005);
1747
1748 skip |= validate_bool32(
1749 report_data, "vkCreateGraphicsPipelines",
1750 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
1751 pCreateInfos[i].pColorBlendState->logicOpEnable);
1752
1753 skip |= validate_array(
1754 report_data, "vkCreateGraphicsPipelines",
1755 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
1756 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
1757 pCreateInfos[i].pColorBlendState->attachmentCount, pCreateInfos[i].pColorBlendState->pAttachments, false,
1758 true, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
1759
1760 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
1761 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
1762 ++attachmentIndex) {
1763 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
1764 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
1765 ParameterName::IndexVector{i, attachmentIndex}),
1766 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
1767
1768 skip |= validate_ranged_enum(
1769 report_data, "vkCreateGraphicsPipelines",
1770 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
1771 ParameterName::IndexVector{i, attachmentIndex}),
1772 "VkBlendFactor", AllVkBlendFactorEnums,
1773 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
1774 VALIDATION_ERROR_0f22cc01);
1775
1776 skip |= validate_ranged_enum(
1777 report_data, "vkCreateGraphicsPipelines",
1778 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
1779 ParameterName::IndexVector{i, attachmentIndex}),
1780 "VkBlendFactor", AllVkBlendFactorEnums,
1781 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
1782 VALIDATION_ERROR_0f207001);
1783
1784 skip |= validate_ranged_enum(
1785 report_data, "vkCreateGraphicsPipelines",
1786 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
1787 ParameterName::IndexVector{i, attachmentIndex}),
1788 "VkBlendOp", AllVkBlendOpEnums,
1789 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
1790 VALIDATION_ERROR_0f202001);
1791
1792 skip |= validate_ranged_enum(
1793 report_data, "vkCreateGraphicsPipelines",
1794 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
1795 ParameterName::IndexVector{i, attachmentIndex}),
1796 "VkBlendFactor", AllVkBlendFactorEnums,
1797 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
1798 VALIDATION_ERROR_0f22c601);
1799
1800 skip |= validate_ranged_enum(
1801 report_data, "vkCreateGraphicsPipelines",
1802 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
1803 ParameterName::IndexVector{i, attachmentIndex}),
1804 "VkBlendFactor", AllVkBlendFactorEnums,
1805 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
1806 VALIDATION_ERROR_0f206a01);
1807
1808 skip |= validate_ranged_enum(
1809 report_data, "vkCreateGraphicsPipelines",
1810 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
1811 ParameterName::IndexVector{i, attachmentIndex}),
1812 "VkBlendOp", AllVkBlendOpEnums,
1813 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
1814 VALIDATION_ERROR_0f200801);
1815
1816 skip |=
1817 validate_flags(report_data, "vkCreateGraphicsPipelines",
1818 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
1819 ParameterName::IndexVector{i, attachmentIndex}),
1820 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
1821 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
1822 false, false, VALIDATION_ERROR_0f202201);
1823 }
1824 }
1825
1826 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
1827 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001828 INVALID_STRUCT_STYPE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001829 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
1830 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
1831 i);
1832 }
1833
1834 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
1835 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
1836 skip |= validate_ranged_enum(
1837 report_data, "vkCreateGraphicsPipelines",
1838 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
1839 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp, VALIDATION_ERROR_0f4004be);
1840 }
1841 }
1842 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001843
Petr Kraus9752aae2017-11-24 03:05:50 +01001844 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
1845 if (pCreateInfos[i].basePipelineIndex != -1) {
1846 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001847 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001848 VALIDATION_ERROR_096005a8,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001849 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
1850 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001851 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001852 }
1853 }
1854
Petr Kraus9752aae2017-11-24 03:05:50 +01001855 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
1856 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001857 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001858 VALIDATION_ERROR_096005aa,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001859 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
1860 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001861 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001862 }
1863 }
1864 }
1865
Petr Kraus9752aae2017-11-24 03:05:50 +01001866 if (pCreateInfos[i].pRasterizationState) {
1867 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001868 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001869 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001870 DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001871 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
1872 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
1873 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001874 }
Petr Kraus299ba622017-11-24 03:09:03 +01001875
1876 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
1877 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
1878 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001879 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 0, VALIDATION_ERROR_096005da,
Petr Kraus299ba622017-11-24 03:09:03 +01001880 "The line width state is static (pCreateInfos[%" PRIu32
1881 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
1882 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001883 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
1884 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01001885 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001886 }
1887
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001888 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
1889 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
1890 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
1891 pCreateInfos[i].pStages[j].pName);
1892 }
1893 }
1894 }
1895
1896 return skip;
1897}
1898
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001899bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1900 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1901 VkPipeline *pPipelines) {
1902 bool skip = false;
1903 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1904
1905 for (uint32_t i = 0; i < createInfoCount; i++) {
1906 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
1907 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
1908 pCreateInfos[i].stage.pName);
1909 }
1910
1911 return skip;
1912}
1913
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001914bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1915 VkSampler *pSampler) {
1916 bool skip = false;
1917 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1918 debug_report_data *report_data = device_data->report_data;
1919
1920 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06001921 const auto &features = device_data->physical_device_features;
1922 const auto &limits = device_data->device_limits;
1923 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
1924 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001925 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001926 VALIDATION_ERROR_1260085e,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001927 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06001928 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001929 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06001930 }
1931
1932 // Anistropy cannot be enabled in sampler unless enabled as a feature
1933 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001934 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001935 VALIDATION_ERROR_1260085c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001936 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
1937 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06001938 }
1939
1940 // Anistropy and unnormalized coordinates cannot be enabled simultaneously
1941 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001942 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001943 VALIDATION_ERROR_12600868,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001944 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001945 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06001946 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001947 }
1948
1949 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
1950 if (pCreateInfo->compareEnable == VK_TRUE) {
1951 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp",
1952 AllVkCompareOpEnums, pCreateInfo->compareOp, VALIDATION_ERROR_12600870);
1953 }
1954
1955 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
1956 // valid VkBorderColor value
1957 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
1958 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
1959 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
1960 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
1961 AllVkBorderColorEnums, pCreateInfo->borderColor, VALIDATION_ERROR_1260086c);
1962 }
1963
1964 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
1965 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
1966 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
1967 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
1968 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
1969 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001970 skip |= log_msg(
1971 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, VALIDATION_ERROR_1260086e,
1972 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
1973 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001974 }
John Zulauf275805c2017-10-26 15:34:49 -06001975
1976 // Checks for the IMG cubic filtering extension
1977 if (device_data->extensions.vk_img_filter_cubic) {
1978 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
1979 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001980 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001981 VALIDATION_ERROR_12600872,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001982 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001983 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06001984 }
1985 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001986 }
1987
1988 return skip;
1989}
1990
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001991bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
1992 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
1993 bool skip = false;
1994 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1995 debug_report_data *report_data = device_data->report_data;
1996
1997 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1998 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
1999 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2000 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2001 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2002 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2003 // valid VkSampler handles
2004 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2005 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2006 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2007 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2008 ++descriptor_index) {
2009 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2010 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002011 REQUIRED_PARAMETER,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002012 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002013 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002014 i, descriptor_index);
2015 }
2016 }
2017 }
2018
2019 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2020 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2021 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002022 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002023 VALIDATION_ERROR_04e00236,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002024 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2025 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002026 "values.",
2027 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002028 }
2029 }
2030 }
2031 }
2032
2033 return skip;
2034}
2035
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002036bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2037 const VkDescriptorSet *pDescriptorSets) {
2038 bool skip = false;
2039 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2040 debug_report_data *report_data = device_data->report_data;
2041
2042 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2043 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2044 // validate_array()
2045 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
2046 pDescriptorSets, true, true, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
2047 return skip;
2048}
2049
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002050bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2051 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2052 bool skip = false;
2053 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2054 debug_report_data *report_data = device_data->report_data;
2055
2056 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2057 if (pDescriptorWrites != NULL) {
2058 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2059 // descriptorCount must be greater than 0
2060 if (pDescriptorWrites[i].descriptorCount == 0) {
2061 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002062 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002063 VALIDATION_ERROR_15c0441b,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002064 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002065 }
2066
2067 // dstSet must be a valid VkDescriptorSet handle
2068 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2069 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2070 pDescriptorWrites[i].dstSet);
2071
2072 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2073 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2074 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2075 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2076 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2077 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2078 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2079 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2080 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2081 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002082 VALIDATION_ERROR_15c00284,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002083 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2084 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2085 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002086 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2087 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002088 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2089 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2090 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2091 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2092 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2093 ++descriptor_index) {
2094 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2095 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2096 ParameterName::IndexVector{i, descriptor_index}),
2097 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2098 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2099 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2100 ParameterName::IndexVector{i, descriptor_index}),
2101 "VkImageLayout", AllVkImageLayoutEnums,
2102 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout,
2103 VALIDATION_ERROR_UNDEFINED);
2104 }
2105 }
2106 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2107 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2108 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2109 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2110 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2111 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2112 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2113 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2114 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002115 VALIDATION_ERROR_15c00288,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002116 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2117 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2118 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002119 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2120 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002121 } else {
2122 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2123 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2124 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2125 ParameterName::IndexVector{i, descriptorIndex}),
2126 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2127 }
2128 }
2129 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2130 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2131 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2132 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2133 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2134 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002135 VALIDATION_ERROR_15c00286,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002136 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2137 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002138 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2139 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002140 } else {
2141 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2142 ++descriptor_index) {
2143 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2144 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2145 ParameterName::IndexVector{i, descriptor_index}),
2146 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2147 }
2148 }
2149 }
2150
2151 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2152 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2153 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2154 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2155 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2156 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002157 skip |=
2158 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
2159 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, VALIDATION_ERROR_15c0028e,
2160 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2161 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2162 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002163 }
2164 }
2165 }
2166 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2167 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2168 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2169 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2170 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2171 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002172 skip |=
2173 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
2174 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, VALIDATION_ERROR_15c00290,
2175 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2176 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2177 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002178 }
2179 }
2180 }
2181 }
2182 }
2183 }
2184 return skip;
2185}
2186
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002187bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2188 VkRenderPass *pRenderPass) {
2189 bool skip = false;
2190 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2191 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
2192
2193 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2194 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2195 std::stringstream ss;
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002196 ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED. ";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002197 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002198 VALIDATION_ERROR_00809201, "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002199 }
2200 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2201 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
2202 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002203 VALIDATION_ERROR_00800696,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002204 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002205 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2206 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002207 }
2208 }
2209
2210 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2211 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
2212 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002213 VALIDATION_ERROR_1400069a, "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002214 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002215 }
2216 }
2217 return skip;
2218}
2219
2220bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2221 const VkCommandBuffer *pCommandBuffers) {
2222 bool skip = false;
2223 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2224 debug_report_data *report_data = device_data->report_data;
2225
2226 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2227 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2228 // validate_array()
2229 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
2230 pCommandBuffers, true, true, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
2231 return skip;
2232}
2233
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002234bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2235 bool skip = false;
2236 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2237 debug_report_data *report_data = device_data->report_data;
2238 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2239
2240 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2241 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2242 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2243 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
2244 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false, VALIDATION_ERROR_UNDEFINED);
2245
2246 if (pBeginInfo->pInheritanceInfo != NULL) {
2247 skip |=
2248 validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2249 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0281c40d);
2250
2251 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2252 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2253
2254 // TODO: This only needs to be validated when the inherited queries feature is enabled
2255 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2256 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2257
2258 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2259 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2260 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
2261 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, VALIDATION_ERROR_UNDEFINED);
2262 }
2263
2264 if (pInfo != NULL) {
2265 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2266 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002267 HandleToUint64(commandBuffer), VALIDATION_ERROR_02a00070,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002268 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002269 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002270 }
2271 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2272 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2273 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
2274 VALIDATION_ERROR_02a00072);
2275 }
2276 }
2277
2278 return skip;
2279}
2280
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002281bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2282 const VkViewport *pViewports) {
2283 bool skip = false;
2284 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2285
Petr Krausd55e77c2018-01-09 22:09:25 +01002286 if (!device_data->physical_device_features.multiViewport) {
2287 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002288 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002289 HandleToUint64(commandBuffer), VALIDATION_ERROR_1e000990,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002290 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2291 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002292 }
2293 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002294 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002295 HandleToUint64(commandBuffer), VALIDATION_ERROR_1e000992,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002296 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2297 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002298 }
2299 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002300 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002301 if (sum > device_data->device_limits.maxViewports) {
2302 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002303 HandleToUint64(commandBuffer), VALIDATION_ERROR_1e00098e,
Petr Krausd55e77c2018-01-09 22:09:25 +01002304 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002305 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2306 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002307 }
2308 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002309
2310 if (pViewports) {
2311 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2312 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2313 const char fn_name[] = "vkCmdSetViewport";
2314 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2315 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2316 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2317 }
2318 }
2319
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002320 return skip;
2321}
2322
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002323bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2324 bool skip = false;
2325 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2326 debug_report_data *report_data = device_data->report_data;
2327
Petr Kraus6260f0a2018-02-27 21:15:55 +01002328 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002329 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002330 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002331 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a2,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002332 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2333 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002334 }
2335 if (scissorCount > 1) {
2336 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002337 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a4,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002338 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2339 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002340 }
2341 } else { // multiViewport enabled
2342 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2343 if (sum > device_data->device_limits.maxViewports) {
2344 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002345 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a0,
Petr Kraus6260f0a2018-02-27 21:15:55 +01002346 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002347 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2348 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002349 }
2350 }
2351
Petr Kraus6260f0a2018-02-27 21:15:55 +01002352 if (pScissors) {
2353 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2354 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002355
Petr Kraus6260f0a2018-02-27 21:15:55 +01002356 if (scissor.offset.x < 0) {
2357 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002358 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a6,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002359 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2360 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002361 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002362
Petr Kraus6260f0a2018-02-27 21:15:55 +01002363 if (scissor.offset.y < 0) {
2364 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002365 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a6,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002366 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2367 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002368 }
2369
2370 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2371 if (x_sum > INT32_MAX) {
2372 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002373 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a8,
Petr Kraus6260f0a2018-02-27 21:15:55 +01002374 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002375 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2376 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002377 }
2378
2379 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2380 if (y_sum > INT32_MAX) {
2381 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002382 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004aa,
Petr Kraus6260f0a2018-02-27 21:15:55 +01002383 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002384 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2385 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002386 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002387 }
2388 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002389
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002390 return skip;
2391}
2392
Petr Kraus299ba622017-11-24 03:09:03 +01002393bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2394 bool skip = false;
2395 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2396 debug_report_data *report_data = device_data->report_data;
2397
2398 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2399 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002400 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d600628,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002401 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002402 }
2403
2404 return skip;
2405}
2406
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002407bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2408 uint32_t firstInstance) {
2409 bool skip = false;
2410 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2411 if (vertexCount == 0) {
2412 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2413 // this an error or leave as is.
2414 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002415 REQUIRED_PARAMETER, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002416 }
2417
2418 if (instanceCount == 0) {
2419 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2420 // this an error or leave as is.
2421 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002422 REQUIRED_PARAMETER, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002423 }
2424 return skip;
2425}
2426
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002427bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2428 bool skip = false;
2429 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2430
2431 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2432 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002433 DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002434 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2435 }
2436 return skip;
2437}
2438
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002439bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2440 uint32_t stride) {
2441 bool skip = false;
2442 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2443 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002444 skip |= log_msg(
2445 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
2446 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002447 }
2448 return skip;
2449}
2450
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002451bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2452 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2453 bool skip = false;
2454 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2455
Dave Houltonf5217612018-02-02 16:18:52 -07002456 VkImageAspectFlags legal_aspect_flags =
2457 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2458 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2459 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2460 }
2461
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002462 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002463 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002464 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002465 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002466 VALIDATION_ERROR_0a600c01,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002467 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002468 }
Dave Houltonf5217612018-02-02 16:18:52 -07002469 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002470 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002471 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002472 VALIDATION_ERROR_0a600c01,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002473 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002474 }
2475 }
2476 return skip;
2477}
2478
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002479bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2480 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2481 bool skip = false;
2482 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2483
Dave Houltonf5217612018-02-02 16:18:52 -07002484 VkImageAspectFlags legal_aspect_flags =
2485 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2486 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2487 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2488 }
2489
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002490 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002491 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002492 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002493 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002494 UNRECOGNIZED_VALUE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002495 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2496 }
Dave Houltonf5217612018-02-02 16:18:52 -07002497 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002498 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002499 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002500 UNRECOGNIZED_VALUE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002501 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2502 }
2503 }
2504 return skip;
2505}
2506
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002507bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
2508 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2509 bool skip = false;
2510 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2511
Dave Houltonf5217612018-02-02 16:18:52 -07002512 VkImageAspectFlags legal_aspect_flags =
2513 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2514 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2515 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2516 }
2517
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002518 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002519 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002520 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002521 UNRECOGNIZED_VALUE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002522 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2523 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002524 }
2525 }
2526 return skip;
2527}
2528
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002529bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2530 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2531 bool skip = false;
2532 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2533
Dave Houltonf5217612018-02-02 16:18:52 -07002534 VkImageAspectFlags legal_aspect_flags =
2535 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2536 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2537 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2538 }
2539
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002540 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002541 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002542 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002543 UNRECOGNIZED_VALUE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002544 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2545 "enumerator");
2546 }
2547 }
2548 return skip;
2549}
2550
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002551bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
2552 const void *pData) {
2553 bool skip = false;
2554 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2555
2556 if (dstOffset & 3) {
2557 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002558 VALIDATION_ERROR_1e400048,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002559 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
2560 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002561 }
2562
2563 if ((dataSize <= 0) || (dataSize > 65536)) {
2564 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002565 VALIDATION_ERROR_1e40004a,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002566 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002567 "), must be greater than zero and less than or equal to 65536.",
2568 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002569 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002570 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002571 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002572 VALIDATION_ERROR_1e40004c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002573 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002574 }
2575 return skip;
2576}
2577
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002578bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
2579 uint32_t data) {
2580 bool skip = false;
2581 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2582
2583 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002584 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002585 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002586 VALIDATION_ERROR_1b400032,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002587 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002588 }
2589
2590 if (size != VK_WHOLE_SIZE) {
2591 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002592 skip |=
2593 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002594 VALIDATION_ERROR_1b400034,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002595 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002596 } else if (size & 3) {
2597 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002598 VALIDATION_ERROR_1b400038,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002599 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002600 }
2601 }
2602 return skip;
2603}
2604
2605VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
2606 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
2607}
2608
2609VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
2610 VkLayerProperties *pProperties) {
2611 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
2612}
2613
2614VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
2615 VkExtensionProperties *pProperties) {
2616 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
2617 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
2618
2619 return VK_ERROR_LAYER_NOT_PRESENT;
2620}
2621
2622VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
2623 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
2624 // Parameter_validation does not have any physical device extensions
2625 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
2626 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
2627
2628 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
2629 bool skip =
2630 validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
2631 pPropertyCount, pProperties, true, false, false, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_2761f401);
2632 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
2633
2634 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
2635}
2636
2637static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
2638 if (!flag) {
2639 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002640 EXTENSION_NOT_ENABLED, "%s() called even though the %s extension was not enabled for this VkDevice.",
2641 function_name, extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002642 }
2643
2644 return false;
2645}
2646
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002647bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2648 VkSwapchainKHR *pSwapchain) {
2649 bool skip = false;
2650 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2651 debug_report_data *report_data = device_data->report_data;
2652
Mark Lobodzinski88529492018-04-01 10:38:15 -06002653 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01002654 "vkCreateSwapchainKHR"};
2655
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002656 if (pCreateInfo != nullptr) {
2657 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
2658 FormatIsCompressed_ETC2_EAC(pCreateInfo->imageFormat)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002659 skip |=
Mark Lobodzinski88529492018-04-01 10:38:15 -06002660 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002661 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The textureCompressionETC2 "
2662 "feature is not enabled: neither ETC2 nor EAC formats can be used to create images.",
2663 string_VkFormat(pCreateInfo->imageFormat));
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002664 }
2665
2666 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
2667 FormatIsCompressed_ASTC_LDR(pCreateInfo->imageFormat)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002668 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002669 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
2670 "textureCompressionASTC_LDR feature is not enabled: ASTC formats cannot be used to create images.",
2671 string_VkFormat(pCreateInfo->imageFormat));
2672 }
2673
2674 if ((device_data->physical_device_features.textureCompressionBC == false) &&
2675 FormatIsCompressed_BC(pCreateInfo->imageFormat)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002676 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002677 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
2678 "textureCompressionBC feature is not enabled: BC compressed formats cannot be used to create images.",
2679 string_VkFormat(pCreateInfo->imageFormat));
2680 }
2681
2682 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2683 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
2684 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
2685 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002686 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002687 VALIDATION_ERROR_146009fc,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002688 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002689 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002690 }
2691
2692 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
2693 // queueFamilyIndexCount uint32_t values
2694 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002695 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002696 VALIDATION_ERROR_146009fa,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002697 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
2698 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002699 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002700 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002701 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
2702 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices", INVALID_USAGE,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002703 INVALID_USAGE, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002704 }
2705 }
2706
Petr Krause5c37652018-01-05 04:05:12 +01002707 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers", VALIDATION_ERROR_146009f6,
2708 log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002709 }
2710
2711 return skip;
2712}
2713
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002714bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
2715 bool skip = false;
2716 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
2717
2718 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06002719 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
2720 if (present_regions) {
2721 // TODO: This and all other pNext extension dependencies should be added to code-generation
2722 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
2723 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
2724 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
2725 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002726 INVALID_USAGE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002727 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
2728 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06002729 pPresentInfo->swapchainCount, present_regions->swapchainCount);
2730 }
2731 skip |= validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
2732 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_1121c40d);
2733 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
2734 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, present_regions->pRegions, true,
2735 false, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
2736 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
2737 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002738 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
2739 present_regions->pRegions[i].pRectangles, true, false, VALIDATION_ERROR_UNDEFINED,
2740 VALIDATION_ERROR_UNDEFINED);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002741 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002742 }
2743 }
2744
2745 return skip;
2746}
2747
2748#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002749bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
2750 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
2751 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
2752 bool skip = false;
2753
2754 if (pCreateInfo->hwnd == nullptr) {
2755 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002756 VALIDATION_ERROR_15a00a38, "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002757 }
2758
2759 return skip;
2760}
2761#endif // VK_USE_PLATFORM_WIN32_KHR
2762
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002763bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
2764 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2765 if (pNameInfo->pObjectName) {
2766 device_data->report_data->debugObjectNameMap->insert(
2767 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
2768 } else {
2769 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
2770 }
2771 return false;
2772}
2773
Petr Krausc8655be2017-09-27 18:56:51 +02002774bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
2775 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
2776 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2777 bool skip = false;
2778
2779 if (pCreateInfo) {
2780 if (pCreateInfo->maxSets <= 0) {
2781 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002782 VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, VK_NULL_HANDLE, VALIDATION_ERROR_0480025a,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002783 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02002784 }
2785
2786 if (pCreateInfo->pPoolSizes) {
2787 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
2788 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
2789 skip |= log_msg(
2790 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002791 VK_NULL_HANDLE, VALIDATION_ERROR_04a0025c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002792 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02002793 }
2794 }
2795 }
2796 }
2797
2798 return skip;
2799}
2800
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002801bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
2802 bool skip = false;
2803 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2804
2805 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002806 skip |=
2807 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002808 HandleToUint64(commandBuffer), VALIDATION_ERROR_19c00304,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002809 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2810 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002811 }
2812
2813 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002814 skip |=
2815 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002816 HandleToUint64(commandBuffer), VALIDATION_ERROR_19c00306,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002817 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2818 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002819 }
2820
2821 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002822 skip |=
2823 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002824 HandleToUint64(commandBuffer), VALIDATION_ERROR_19c00308,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002825 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2826 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002827 }
2828
2829 return skip;
2830}
2831
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002832bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002833 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
2834 bool skip = false;
2835 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2836
2837 // Paired if {} else if {} tests used to avoid any possible uint underflow
2838 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
2839 if (baseGroupX >= limit) {
2840 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002841 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e0034a,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002842 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002843 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2844 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002845 } else if (groupCountX > (limit - baseGroupX)) {
2846 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002847 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e00350,
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002848 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002849 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2850 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002851 }
2852
2853 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
2854 if (baseGroupY >= limit) {
2855 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002856 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e0034c,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002857 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002858 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2859 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002860 } else if (groupCountY > (limit - baseGroupY)) {
2861 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002862 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e00352,
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002863 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002864 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2865 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002866 }
2867
2868 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
2869 if (baseGroupZ >= limit) {
2870 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002871 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e0034e,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002872 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002873 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2874 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002875 } else if (groupCountZ > (limit - baseGroupZ)) {
2876 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002877 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e00354,
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002878 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002879 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2880 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002881 }
2882
2883 return skip;
2884}
2885
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002886VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
2887 const auto item = name_to_funcptr_map.find(funcName);
2888 if (item != name_to_funcptr_map.end()) {
2889 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
2890 }
2891
2892 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2893 const auto &table = device_data->dispatch_table;
2894 if (!table.GetDeviceProcAddr) return nullptr;
2895 return table.GetDeviceProcAddr(device, funcName);
2896}
2897
2898VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
2899 const auto item = name_to_funcptr_map.find(funcName);
2900 if (item != name_to_funcptr_map.end()) {
2901 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
2902 }
2903
2904 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
2905 auto &table = instance_data->dispatch_table;
2906 if (!table.GetInstanceProcAddr) return nullptr;
2907 return table.GetInstanceProcAddr(instance, funcName);
2908}
2909
2910VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
2911 assert(instance);
2912 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
2913
2914 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
2915 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
2916}
2917
2918// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
2919// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02002920void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002921 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
2922 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
2923 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
2924 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
2925 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
2926 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
2927 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
2928 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
2929 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
2930 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
2931 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
2932 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
2933 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
2934 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01002935 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07002936 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
2937 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
2938 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
2939 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
2940 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
2941 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
2942 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
2943 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
2944 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
2945 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
2946 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
2947 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
2948 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002949 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002950}
2951
2952} // namespace parameter_validation
2953
2954VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
2955 VkExtensionProperties *pProperties) {
2956 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
2957}
2958
2959VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
2960 VkLayerProperties *pProperties) {
2961 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
2962}
2963
2964VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
2965 VkLayerProperties *pProperties) {
2966 // the layer command handles VK_NULL_HANDLE just fine internally
2967 assert(physicalDevice == VK_NULL_HANDLE);
2968 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
2969}
2970
2971VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
2972 const char *pLayerName, uint32_t *pCount,
2973 VkExtensionProperties *pProperties) {
2974 // the layer command handles VK_NULL_HANDLE just fine internally
2975 assert(physicalDevice == VK_NULL_HANDLE);
2976 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
2977}
2978
2979VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
2980 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
2981}
2982
2983VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
2984 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
2985}
2986
2987VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
2988 const char *funcName) {
2989 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
2990}
2991
2992VK_LAYER_EXPORT bool pv_vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
2993 assert(pVersionStruct != NULL);
2994 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
2995
2996 // Fill in the function pointers if our version is at least capable of having the structure contain them.
2997 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
2998 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
2999 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3000 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3001 }
3002
3003 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3004 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3005 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3006 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3007 }
3008
3009 return VK_SUCCESS;
3010}