blob: 6adb003eb96e8a617a04ceb12cdeaef8e294cfec [file] [log] [blame]
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001/* Copyright (c) 2015-2017 The Khronos Group Inc.
2 * Copyright (c) 2015-2017 Valve Corporation
3 * Copyright (c) 2015-2017 LunarG, Inc.
4 * Copyright (C) 2015-2017 Google Inc.
5 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
22
23#include <limits.h>
24#include <math.h>
25#include <stdio.h>
26#include <stdlib.h>
27#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028
29#include <iostream>
30#include <string>
31#include <sstream>
32#include <unordered_map>
33#include <unordered_set>
34#include <vector>
35#include <mutex>
36
37#include "vk_loader_platform.h"
38#include "vulkan/vk_layer.h"
39#include "vk_layer_config.h"
40#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060041#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060042
43#include "vk_layer_table.h"
44#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
48
49#include "parameter_name.h"
50#include "parameter_validation.h"
51
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060052#if defined __ANDROID__
53#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060054#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060055#else
56#define LOGCONSOLE(...) \
57 { \
58 printf(__VA_ARGS__); \
59 printf("\n"); \
60 }
61#endif
62
Mark Lobodzinskid4950072017-08-01 13:02:20 -060063namespace parameter_validation {
64
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060065extern std::unordered_map<std::string, void *> custom_functions;
66
Mark Lobodzinskid4950072017-08-01 13:02:20 -060067extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
68 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
69extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
70extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
71 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
72extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
73extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
74 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
75extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
76 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
77 const VkAllocationCallbacks *pAllocator,
78 VkDebugReportCallbackEXT *pMsgCallback);
79extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
80 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070081extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
82 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
83 const VkAllocationCallbacks *pAllocator,
84 VkDebugUtilsMessengerEXT *pMessenger);
85extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
86 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060087extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
88 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010089extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
90 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
91extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
92 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060093
94// TODO : This can be much smarter, using separate locks for separate global data
95std::mutex global_lock;
96
97static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
98std::unordered_map<void *, layer_data *> layer_data_map;
99std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
100
101void InitializeManualParameterValidationFunctionPointers(void);
102
103static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700104 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
105 "lunarg_parameter_validation");
106 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
107 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600108}
109
Mark Young6ba8abe2017-11-09 10:37:04 -0700110static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
111 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600112
113static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700114 "VK_LAYER_LUNARG_parameter_validation",
115 VK_LAYER_API_VERSION,
116 1,
117 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600118};
119
120static const int MaxParamCheckerStringLength = 256;
121
John Zulauf71968502017-10-26 13:51:15 -0600122template <typename T>
123static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
124 // Using only < for generality and || for early abort
125 return !((value < min) || (max < value));
126}
127
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600128static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
129 const char *validateString) {
130 assert(apiName != nullptr);
131 assert(validateString != nullptr);
132
133 bool skip = false;
134
135 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
136
137 if (result == VK_STRING_ERROR_NONE) {
138 return skip;
139 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600140 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, INVALID_USAGE,
141 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600142 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600143 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, INVALID_USAGE,
144 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600145 }
146 return skip;
147}
148
149static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600150 const char *parameter_name, int32_t error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600151 bool skip = false;
152
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600153 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
154 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600155 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600156 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
157 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600158 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600159 skip |=
160 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600161 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600162 "%s: %s (= %" PRIu32
163 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
164 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600165 }
166
167 return skip;
168}
169
170static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
171 const char *cmd_name, const char *array_parameter_name, int32_t unique_error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600172 int32_t valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600173 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600174 if (queue_families) {
175 std::unordered_set<uint32_t> set;
176 for (uint32_t i = 0; i < queue_family_count; ++i) {
177 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
178
179 if (set.count(queue_families[i])) {
180 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600181 HandleToUint64(device_data->device), VALIDATION_ERROR_056002e8,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600182 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
183 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600184 } else {
185 set.insert(queue_families[i]);
186 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600187 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600188 }
189 }
190 }
191 return skip;
192}
193
194VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600195 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600196 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
197
198 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
199 assert(chain_info != nullptr);
200 assert(chain_info->u.pLayerInfo != nullptr);
201
202 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
203 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
204 if (fpCreateInstance == NULL) {
205 return VK_ERROR_INITIALIZATION_FAILED;
206 }
207
208 // Advance the link info for the next element on the chain
209 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
210
211 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
212
213 if (result == VK_SUCCESS) {
214 InitializeManualParameterValidationFunctionPointers();
215 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
216 assert(my_instance_data != nullptr);
217
218 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
219 my_instance_data->instance = *pInstance;
220 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700221 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
222 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600223
224 // Look for one or more debug report create info structures
225 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700226 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
227 &my_instance_data->tmp_messenger_create_infos,
228 &my_instance_data->tmp_debug_messengers)) {
229 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600230 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700231 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
232 my_instance_data->tmp_messenger_create_infos,
233 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600234 // Failure of setting up one or more of the callback.
235 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700236 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
237 my_instance_data->tmp_debug_messengers);
238 my_instance_data->num_tmp_debug_messengers = 0;
239 }
240 }
241 }
242 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
243 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
244 if (my_instance_data->num_tmp_report_callbacks > 0) {
245 // Setup the temporary callback(s) here to catch early issues:
246 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
247 my_instance_data->tmp_report_create_infos,
248 my_instance_data->tmp_report_callbacks)) {
249 // Failure of setting up one or more of the callback.
250 // Therefore, clean up and don't use those callbacks:
251 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
252 my_instance_data->tmp_report_callbacks);
253 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600254 }
255 }
256 }
257
258 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600259 // Note: From the spec--
260 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
261 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
262 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
263 ? pCreateInfo->pApplicationInfo->apiVersion
264 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600265
John Zulaufe6db8a32018-03-30 14:51:59 -0600266 uint32_t effective_api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600267
John Zulaufe6db8a32018-03-30 14:51:59 -0600268 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
269 if (api_version_nopatch != effective_api_version) {
270 const char *effective_api_string =
271 (effective_api_version == VK_API_VERSION_1_0) ? "VK_API_VERSION_1_0" : "VK_API_VERSION_1_1";
272 if (api_version_nopatch < VK_API_VERSION_1_0) {
273 log_msg(my_instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
274 VALIDATION_ERROR_UNDEFINED,
275 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). Using %s.\n",
276 api_version, effective_api_string);
277 } else {
278 log_msg(my_instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
279 VALIDATION_ERROR_UNDEFINED,
280 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). Assuming %s.\n",
281 api_version, effective_api_string);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600282 }
283 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600284
285 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
286 // survive we can report the issue now.
287 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
288
289 if (pCreateInfo->pApplicationInfo) {
290 if (pCreateInfo->pApplicationInfo->pApplicationName) {
291 validate_string(my_instance_data->report_data, "vkCreateInstance",
292 "pCreateInfo->VkApplicationInfo->pApplicationName",
293 pCreateInfo->pApplicationInfo->pApplicationName);
294 }
295
296 if (pCreateInfo->pApplicationInfo->pEngineName) {
297 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
298 pCreateInfo->pApplicationInfo->pEngineName);
299 }
300 }
301
302 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700303 if (my_instance_data->num_tmp_debug_messengers > 0) {
304 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
305 my_instance_data->tmp_debug_messengers);
306 }
307 if (my_instance_data->num_tmp_report_callbacks > 0) {
308 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
309 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600310 }
311 }
312
313 return result;
314}
315
316VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
317 // Grab the key before the instance is destroyed.
318 dispatch_key key = get_dispatch_key(instance);
319 bool skip = false;
320 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
321
322 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
323 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700324 if (instance_data->num_tmp_debug_messengers > 0) {
325 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
326 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
327 callback_setup = true;
328 }
329 }
330 if (instance_data->num_tmp_report_callbacks > 0) {
331 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
332 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600333 callback_setup = true;
334 }
335 }
336
337 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
338
339 // Disable and cleanup the temporary callback(s):
340 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700341 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
342 instance_data->tmp_debug_messengers);
343 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
344 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600345 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700346 if (instance_data->num_tmp_debug_messengers > 0) {
347 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
348 instance_data->num_tmp_debug_messengers = 0;
349 }
350 if (instance_data->num_tmp_report_callbacks > 0) {
351 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
352 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600353 }
354
355 if (!skip) {
356 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
357
358 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700359 while (instance_data->logging_messenger.size() > 0) {
360 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
361 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
362 instance_data->logging_messenger.pop_back();
363 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600364 while (instance_data->logging_callback.size() > 0) {
365 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700366 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600367 instance_data->logging_callback.pop_back();
368 }
369
Mark Young6ba8abe2017-11-09 10:37:04 -0700370 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600371 }
372
373 FreeLayerDataPtr(key, instance_layer_data_map);
374}
375
376VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
377 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
378 const VkAllocationCallbacks *pAllocator,
379 VkDebugReportCallbackEXT *pMsgCallback) {
380 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
381 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
382
383 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
384 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
385 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700386 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
387 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
388 if (VK_SUCCESS != result) {
389 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
390 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600391 }
392 return result;
393}
394
395VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
396 const VkAllocationCallbacks *pAllocator) {
397 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
398 if (!skip) {
399 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
400 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700401 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
402 }
403}
404
405VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
406 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
407 const VkAllocationCallbacks *pAllocator,
408 VkDebugUtilsMessengerEXT *pMessenger) {
409 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
410 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
411
412 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
413 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
414 if (VK_SUCCESS == result) {
415 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
416 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
417 if (VK_SUCCESS != result) {
418 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
419 }
420 }
421 return result;
422}
423
424VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
425 const VkAllocationCallbacks *pAllocator) {
426 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
427 if (!skip) {
428 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
429 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
430 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600431 }
432}
433
434static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
435 const VkDeviceCreateInfo *pCreateInfo) {
436 bool skip = false;
437
438 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
439 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
440 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
441 pCreateInfo->ppEnabledLayerNames[i]);
442 }
443 }
444
445 bool maint1 = false;
446 bool negative_viewport = false;
447
448 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
449 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
450 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
451 pCreateInfo->ppEnabledExtensionNames[i]);
452 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_MAINTENANCE1_EXTENSION_NAME) == 0) maint1 = true;
453 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME) == 0)
454 negative_viewport = true;
455 }
456 }
457
458 if (maint1 && negative_viewport) {
459 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600460 VALIDATION_ERROR_056002ec,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600461 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600462 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600463 }
464
465 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
466 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600467 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
468 if (features2) {
469 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
470 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600471 INVALID_USAGE,
John Zulaufde972ac2017-10-26 12:07:05 -0600472 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
473 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600474 }
475 }
476
477 // Validate pCreateInfo->pQueueCreateInfos
478 if (pCreateInfo->pQueueCreateInfos) {
479 std::unordered_set<uint32_t> set;
480
481 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
482 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
483 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
484 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600485 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Mark Lobodzinski88529492018-04-01 10:38:15 -0600486 VALIDATION_ERROR_06c002fa,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600487 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700488 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600489 "index value.",
490 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600491 } else if (set.count(requested_queue_family)) {
492 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600493 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Mark Lobodzinski88529492018-04-01 10:38:15 -0600494 VALIDATION_ERROR_056002e8,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600495 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600496 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
497 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600498 } else {
499 set.insert(requested_queue_family);
500 }
501
502 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
503 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
504 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
505 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
506 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600507 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Mark Lobodzinski88529492018-04-01 10:38:15 -0600508 VALIDATION_ERROR_06c002fe,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600509 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600510 "] (=%f) is not between 0 and 1 (inclusive).",
511 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600512 }
513 }
514 }
515 }
516 }
517
518 return skip;
519}
520
521VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
522 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
523 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
524
525 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
526 bool skip = false;
527 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
528 assert(my_instance_data != nullptr);
529 std::unique_lock<std::mutex> lock(global_lock);
530
531 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
532
533 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo);
534
535 if (!skip) {
536 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
537 assert(chain_info != nullptr);
538 assert(chain_info->u.pLayerInfo != nullptr);
539
540 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
541 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
542 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
543 if (fpCreateDevice == NULL) {
544 return VK_ERROR_INITIALIZATION_FAILED;
545 }
546
547 // Advance the link info for the next element on the chain
548 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
549
550 lock.unlock();
551
552 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
553
554 lock.lock();
555
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600556 if (result == VK_SUCCESS) {
557 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
558 assert(my_device_data != nullptr);
559
Mark Young6ba8abe2017-11-09 10:37:04 -0700560 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600561 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
562
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600563 // Query and save physical device limits for this device
564 VkPhysicalDeviceProperties device_properties = {};
565 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
566
567 my_device_data->api_version = my_device_data->extensions.InitFromDeviceCreateInfo(
568 &my_instance_data->extensions, device_properties.apiVersion, pCreateInfo);
569
570 uint32_t specified_api_version = device_properties.apiVersion & ~VK_VERSION_PATCH(~0);
571 if (!(specified_api_version == VK_API_VERSION_1_0) && !(specified_api_version == VK_API_VERSION_1_1)) {
572 LOGCONSOLE(
573 "Warning: Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number -- (0x%8x) assuming "
574 "%s.\n",
575 device_properties.apiVersion,
576 (my_device_data->api_version == VK_API_VERSION_1_0) ? "VK_API_VERSION_1_0" : "VK_API_VERSION_1_1");
577 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600578
579 // Store createdevice data
580 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
581 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
582 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
583 pCreateInfo->pQueueCreateInfos[i].queueCount));
584 }
585 }
586
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600587 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
588 my_device_data->physical_device = physicalDevice;
589 my_device_data->device = *pDevice;
590
591 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600592 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
593 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
594 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600595 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
596 if (features2) {
597 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600598 }
599 }
600 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700601 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600602 } else {
603 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
604 }
605 }
606 }
607
608 return result;
609}
610
611VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
612 dispatch_key key = get_dispatch_key(device);
613 bool skip = false;
614 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
615 {
616 std::unique_lock<std::mutex> lock(global_lock);
617 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
618 }
619
620 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700621 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600622 device_data->dispatch_table.DestroyDevice(device, pAllocator);
623 }
624 FreeLayerDataPtr(key, layer_data_map);
625}
626
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600627bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
628 bool skip = false;
629 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
630
631 skip |=
632 ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex", VALIDATION_ERROR_29600300);
633 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
634 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
635 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600636 HandleToUint64(device), VALIDATION_ERROR_29600302,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600637 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700638 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600639 ") when the device was created (i.e. is not less than %" PRIu32 ").",
640 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641 }
642 return skip;
643}
644
645VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
646 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
647 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
648 bool skip = false;
649 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
650 std::unique_lock<std::mutex> lock(global_lock);
651
652 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
653 "pCreateInfo->queueFamilyIndex", VALIDATION_ERROR_02c0004e);
654
655 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
656
657 lock.unlock();
658 if (!skip) {
659 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
660 }
661 return result;
662}
663
664VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
665 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
666 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
667 bool skip = false;
668 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
669
670 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
671
672 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
673 if (pCreateInfo != nullptr) {
674 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
675 // VkQueryPipelineStatisticFlagBits values
676 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
677 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
678 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600679 VALIDATION_ERROR_11c00630,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700680 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
681 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600682 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600683 }
684 }
685 if (!skip) {
686 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
687 }
688 return result;
689}
690
Petr Krause91f7a12017-12-14 20:57:36 +0100691VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
692 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
693 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
694 bool skip = false;
695 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
696
697 {
698 std::unique_lock<std::mutex> lock(global_lock);
699 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
700
Dave Houltonb3bbec72018-01-17 10:13:33 -0700701 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
702 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100703 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
704 if (custom_func != nullptr) {
705 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
706 }
707 }
708
709 if (!skip) {
710 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
711
712 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
713 if (result == VK_SUCCESS) {
714 std::unique_lock<std::mutex> lock(global_lock);
715 const auto renderPass = *pRenderPass;
716 auto &renderpass_state = device_data->renderpasses_states[renderPass];
717
718 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
719 bool uses_color = false;
720 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
721 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
722
723 bool uses_depthstencil = false;
724 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
725 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
726 uses_depthstencil = true;
727
728 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
729 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
730 }
731 }
732 }
733 return result;
734}
735
736VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
737 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
738 bool skip = false;
739
740 {
741 std::unique_lock<std::mutex> lock(global_lock);
742 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
743
Dave Houltonb3bbec72018-01-17 10:13:33 -0700744 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
745 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100746 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
747 if (custom_func != nullptr) {
748 skip |= custom_func(device, renderPass, pAllocator);
749 }
750 }
751
752 if (!skip) {
753 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
754
755 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
756 {
757 std::unique_lock<std::mutex> lock(global_lock);
758 device_data->renderpasses_states.erase(renderPass);
759 }
760 }
761}
762
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600763bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
764 VkBuffer *pBuffer) {
765 bool skip = false;
766 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
767 debug_report_data *report_data = device_data->report_data;
768
Mark Lobodzinski88529492018-04-01 10:38:15 -0600769 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100770
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600771 if (pCreateInfo != nullptr) {
Petr Krause5c37652018-01-05 04:05:12 +0100772 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", VALIDATION_ERROR_01400720, log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600773
774 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
775 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
776 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
777 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600778 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600779 VALIDATION_ERROR_01400724,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600780 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600781 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600782 }
783
784 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
785 // queueFamilyIndexCount uint32_t values
786 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600787 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600788 VALIDATION_ERROR_01400722,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600789 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
790 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600791 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600792 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600793 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
794 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", INVALID_USAGE, INVALID_USAGE,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600795 false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600796 }
797 }
798
799 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
800 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
801 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
802 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600803 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600804 VALIDATION_ERROR_0140072c,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600805 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600806 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600807 }
808 }
809
810 return skip;
811}
812
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600813bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
814 VkImage *pImage) {
815 bool skip = false;
816 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
817 debug_report_data *report_data = device_data->report_data;
818
Mark Lobodzinski88529492018-04-01 10:38:15 -0600819 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100820
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600821 if (pCreateInfo != nullptr) {
822 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
823 FormatIsCompressed_ETC2_EAC(pCreateInfo->format)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600824 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600825 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionETC2 feature is "
826 "not enabled: neither ETC2 nor EAC formats can be used to create images.",
827 string_VkFormat(pCreateInfo->format));
828 }
829
830 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
831 FormatIsCompressed_ASTC_LDR(pCreateInfo->format)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600832 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700833 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionASTC_LDR feature "
834 "is not enabled: ASTC formats cannot be used to create images.",
835 string_VkFormat(pCreateInfo->format));
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600836 }
837
838 if ((device_data->physical_device_features.textureCompressionBC == false) && FormatIsCompressed_BC(pCreateInfo->format)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600839 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700840 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionBC feature is not "
841 "enabled: BC compressed formats cannot be used to create images.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600842 string_VkFormat(pCreateInfo->format));
843 }
844
845 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
846 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
847 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
848 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600849 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600850 VALIDATION_ERROR_09e0075c,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600851 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600852 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600853 }
854
855 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
856 // queueFamilyIndexCount uint32_t values
857 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600858 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600859 VALIDATION_ERROR_09e0075a,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600860 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
861 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600862 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600863 } else {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600864 skip |=
865 ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
866 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", INVALID_USAGE, INVALID_USAGE, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600867 }
868 }
869
Petr Krause5c37652018-01-05 04:05:12 +0100870 skip |=
871 ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width", VALIDATION_ERROR_09e00760, log_misc);
872 skip |=
873 ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height", VALIDATION_ERROR_09e00762, log_misc);
874 skip |=
875 ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth", VALIDATION_ERROR_09e00764, log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600876
Petr Krause5c37652018-01-05 04:05:12 +0100877 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", VALIDATION_ERROR_09e00766, log_misc);
878 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers", VALIDATION_ERROR_09e00768, log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600879
Dave Houlton130c0212018-01-29 13:39:56 -0700880 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700881 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
882 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
883 skip |= log_msg(
Mark Lobodzinski88529492018-04-01 10:38:15 -0600884 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, VALIDATION_ERROR_09e007c2,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600885 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
886 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700887 }
888
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600889 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100890 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
891 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600892 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600893 VALIDATION_ERROR_09e00778,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700894 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600895 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600896 }
897
898 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100899 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
900 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600901 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600902 VK_NULL_HANDLE, VALIDATION_ERROR_09e00774,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600903 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
904 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
905 ") are not equal.",
906 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100907 }
908
909 if (pCreateInfo->arrayLayers < 6) {
910 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600911 VK_NULL_HANDLE, VALIDATION_ERROR_09e00774,
Petr Kraus3f433212018-03-13 12:31:27 +0100912 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600913 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
914 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100915 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600916 }
917
918 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600919 skip |=
920 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
921 VALIDATION_ERROR_09e0077a,
922 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600923 }
924 }
925
Dave Houlton130c0212018-01-29 13:39:56 -0700926 // 3D image may have only 1 layer
927 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600928 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
929 VALIDATION_ERROR_09e00782,
930 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700931 }
932
933 // If multi-sample, validate type, usage, tiling and mip levels.
934 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
935 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
936 (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) || (pCreateInfo->mipLevels != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600937 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600938 VALIDATION_ERROR_09e00784,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600939 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700940 }
941
942 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
943 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
944 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
945 // At least one of the legal attachment bits must be set
946 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600947 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600948 VALIDATION_ERROR_09e0078c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600949 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700950 }
951 // No flags other than the legal attachment bits may be set
952 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
953 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600954 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600955 VALIDATION_ERROR_09e00786,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600956 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700957 }
958 }
959
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600960 // mipLevels must be less than or equal to floor(log2(max(extent.width,extent.height,extent.depth)))+1
961 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Petr Krause5c37652018-01-05 04:05:12 +0100962 if (maxDim > 0 && pCreateInfo->mipLevels > (floor(log2(maxDim)) + 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600963 skip |= log_msg(
964 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, VALIDATION_ERROR_09e0077c,
965 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
966 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600967 }
968
Petr Krausb6f97802018-03-13 12:31:39 +0100969 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
970 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600971 VALIDATION_ERROR_09e00792,
Petr Krausb6f97802018-03-13 12:31:39 +0100972 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600973 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100974 }
975
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600976 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
977 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
978 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
979 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600980 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600981 VALIDATION_ERROR_09e007b6,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600982 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600983 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600984 }
985
986 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
987 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
988 // Linear tiling is unsupported
989 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600990 skip |=
991 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, INVALID_USAGE,
992 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
993 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600994 }
995
996 // Sparse 1D image isn't valid
997 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600998 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600999 VALIDATION_ERROR_09e00794,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001000 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001001 }
1002
1003 // Sparse 2D image when device doesn't support it
1004 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1005 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001006 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001007 VALIDATION_ERROR_09e00796,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001008 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001009 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001010 }
1011
1012 // Sparse 3D image when device doesn't support it
1013 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1014 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001015 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001016 VALIDATION_ERROR_09e00798,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001017 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001018 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001019 }
1020
1021 // Multi-sample 2D image when device doesn't support it
1022 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1023 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1024 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001025 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001026 VALIDATION_ERROR_09e0079a,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001027 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001028 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001029 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1030 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001031 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001032 VALIDATION_ERROR_09e0079c,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001033 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001034 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001035 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1036 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001037 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001038 VALIDATION_ERROR_09e0079e,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001039 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001040 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001041 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1042 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001043 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001044 VALIDATION_ERROR_09e007a0,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001045 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001046 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001047 }
1048 }
1049 }
1050 }
1051 return skip;
1052}
1053
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001054bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1055 VkImageView *pView) {
1056 bool skip = false;
1057 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1058 debug_report_data *report_data = device_data->report_data;
1059
1060 if (pCreateInfo != nullptr) {
1061 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D) || (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_2D)) {
1062 if ((pCreateInfo->subresourceRange.layerCount != 1) &&
1063 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001064 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001065
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001066 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_%dD, "
1067 "pCreateInfo->subresourceRange.layerCount must be 1",
1068 ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D) ? 1 : 2));
1069 }
1070 } else if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D_ARRAY) ||
1071 (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_2D_ARRAY)) {
1072 if ((pCreateInfo->subresourceRange.layerCount < 1) &&
1073 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001074 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001075
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001076 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_%dD_ARRAY, "
1077 "pCreateInfo->subresourceRange.layerCount must be >= 1",
1078 ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_1D_ARRAY) ? 1 : 2));
1079 }
1080 } else if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE) {
1081 if ((pCreateInfo->subresourceRange.layerCount != 6) &&
1082 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001083 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001084
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001085 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_CUBE, "
1086 "pCreateInfo->subresourceRange.layerCount must be 6");
1087 }
1088 } else if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) {
1089 if (((pCreateInfo->subresourceRange.layerCount == 0) || ((pCreateInfo->subresourceRange.layerCount % 6) != 0)) &&
1090 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001091 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001092
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001093 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_CUBE_ARRAY, "
1094 "pCreateInfo->subresourceRange.layerCount must be a multiple of 6");
1095 }
1096 if (!device_data->physical_device_features.imageCubeArray) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001097 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001098 "vkCreateImageView: Device feature imageCubeArray not enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001099 }
1100 } else if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_3D) {
1101 if (pCreateInfo->subresourceRange.baseArrayLayer != 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001102 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001103
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001104 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_3D, "
1105 "pCreateInfo->subresourceRange.baseArrayLayer must be 0");
1106 }
1107
1108 if ((pCreateInfo->subresourceRange.layerCount != 1) &&
1109 (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001110 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 1,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001111
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001112 "vkCreateImageView: if pCreateInfo->viewType is VK_IMAGE_TYPE_3D, "
1113 "pCreateInfo->subresourceRange.layerCount must be 1");
1114 }
1115 }
Dave Houltonbd2e2622018-04-10 16:41:14 -06001116
1117 // Validate chained VkImageViewUsageCreateInfo struct, if present
1118 if (nullptr != pCreateInfo->pNext) {
1119 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1120 if (chained_ivuci_struct) {
1121 if (0 == chained_ivuci_struct->usage) {
1122 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1123 VALIDATION_ERROR_3f230603,
Dave Houlton0f3795b2018-04-13 15:04:35 -06001124 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001125 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1126 std::stringstream ss;
1127 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1128 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1129 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1130 VALIDATION_ERROR_3f230601, "%s", ss.str().c_str());
1131 }
1132 }
1133 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001134 }
1135 return skip;
1136}
1137
Petr Krausb3fcdb42018-01-09 22:09:09 +01001138bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1139 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1140 bool skip = false;
1141 debug_report_data *report_data = device_data->report_data;
1142
1143 // Note: for numerical correctness
1144 // - float comparisons should expect NaN (comparison always false).
1145 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1146
1147 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001148 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001149 if (v1_f <= 0.0f) return true;
1150
1151 float intpart;
1152 const float fract = modff(v1_f, &intpart);
1153
1154 assert(std::numeric_limits<float>::radix == 2);
1155 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1156 if (intpart >= u32_max_plus1) return false;
1157
1158 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1159 if (v1_u32 < v2_u32)
1160 return true;
1161 else if (v1_u32 == v2_u32 && fract == 0.0f)
1162 return true;
1163 else
1164 return false;
1165 };
1166
1167 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1168 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1169 return (v1_f <= v2_f);
1170 };
1171
1172 // width
1173 bool width_healthy = true;
1174 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1175
1176 if (!(viewport.width > 0.0f)) {
1177 width_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001178 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dd4,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001179 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001180 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1181 width_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001182 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dd6,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001183 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1184 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001185 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001186 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001187 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001188 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1189 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001190 }
1191
1192 // height
1193 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001194 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1195 device_data->extensions.vk_khr_maintenance1 ||
1196 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001197 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1198
1199 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1200 height_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001201 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dd8,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001202 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001203 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1204 height_healthy = false;
1205
Mark Lobodzinski88529492018-04-01 10:38:15 -06001206 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dda,
1207 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1208 ").",
1209 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001210 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1211 height_healthy = false;
1212
1213 skip |= log_msg(
Mark Lobodzinski88529492018-04-01 10:38:15 -06001214 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001215 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001216 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1217 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001218 }
1219
1220 // x
1221 bool x_healthy = true;
1222 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1223 x_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001224 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000ddc,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001225 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1226 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001227 }
1228
1229 // x + width
1230 if (x_healthy && width_healthy) {
1231 const float right_bound = viewport.x + viewport.width;
1232 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001233 skip |=
1234 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a0,
1235 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1236 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1237 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001238 }
1239 }
1240
1241 // y
1242 bool y_healthy = true;
1243 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1244 y_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001245 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000dde,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001246 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1247 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001248 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1249 y_healthy = false;
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001250 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000de0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001251 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1252 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001253 }
1254
1255 // y + height
1256 if (y_healthy && height_healthy) {
1257 const float boundary = viewport.y + viewport.height;
1258
1259 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001260 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a2,
1261 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1262 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1263 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001264 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1265 skip |= log_msg(
Mark Lobodzinski88529492018-04-01 10:38:15 -06001266 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_15000de2,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001267 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1268 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001269 }
1270 }
1271
1272 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1273 // minDepth
1274 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001275 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a4,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001276
Petr Krausb3fcdb42018-01-09 22:09:09 +01001277 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001278 "[0.0, 1.0] range.",
1279 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001280 }
1281
1282 // maxDepth
1283 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001284 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, VALIDATION_ERROR_150009a6,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001285
Petr Krausb3fcdb42018-01-09 22:09:09 +01001286 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001287 "[0.0, 1.0] range.",
1288 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001289 }
1290 }
1291
1292 return skip;
1293}
1294
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001295bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1296 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1297 VkPipeline *pPipelines) {
1298 bool skip = false;
1299 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1300 debug_report_data *report_data = device_data->report_data;
1301
1302 if (pCreateInfos != nullptr) {
1303 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001304 bool has_dynamic_viewport = false;
1305 bool has_dynamic_scissor = false;
1306 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001307 bool has_dynamic_viewport_w_scaling_nv = false;
1308 bool has_dynamic_discard_rectangle_ext = false;
1309 bool has_dynamic_sample_locations_ext = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001310 if (pCreateInfos[i].pDynamicState != nullptr) {
1311 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1312 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1313 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1314 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1315 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1316 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001317 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1318 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1319 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001320 }
1321 }
1322
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001323 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1324 if (pCreateInfos[i].pVertexInputState != nullptr) {
1325 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
1326 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1327 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
1328 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1329 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001330 VALIDATION_ERROR_14c004d4,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001331 "vkCreateGraphicsPipelines: parameter "
1332 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001333 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1334 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001335 }
1336
1337 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1338 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001339 VALIDATION_ERROR_14c004d6,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001340 "vkCreateGraphicsPipelines: parameter "
1341 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001342 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1343 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001344 }
1345 }
1346
1347 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1348 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
1349 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1350 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001351 VALIDATION_ERROR_14a004d8,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001352 "vkCreateGraphicsPipelines: parameter "
1353 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001354 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1355 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001356 }
1357
1358 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1359 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001360 VALIDATION_ERROR_14a004da,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001361 "vkCreateGraphicsPipelines: parameter "
1362 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001363 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1364 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001365 }
1366
1367 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001368 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1369 VALIDATION_ERROR_14a004dc,
1370 "vkCreateGraphicsPipelines: parameter "
1371 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1372 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1373 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001374 }
1375 }
1376 }
1377
1378 if (pCreateInfos[i].pStages != nullptr) {
1379 bool has_control = false;
1380 bool has_eval = false;
1381
1382 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1383 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1384 has_control = true;
1385 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1386 has_eval = true;
1387 }
1388 }
1389
1390 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1391 if (has_control && has_eval) {
1392 if (pCreateInfos[i].pTessellationState == nullptr) {
1393 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001394 VALIDATION_ERROR_096005b6,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001395 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1396 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001397 "pCreateInfos[%d].pTessellationState must not be NULL.",
1398 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001399 } else {
1400 skip |= validate_struct_pnext(
1401 report_data, "vkCreateGraphicsPipelines",
1402 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
1403 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0961c40d);
1404
1405 skip |= validate_reserved_flags(
1406 report_data, "vkCreateGraphicsPipelines",
1407 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
1408 pCreateInfos[i].pTessellationState->flags, VALIDATION_ERROR_10809005);
1409
1410 if (pCreateInfos[i].pTessellationState->sType !=
1411 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1412 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001413 VALIDATION_ERROR_1082b00b,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001414 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001415 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1416 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001417 }
1418
1419 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1420 pCreateInfos[i].pTessellationState->patchControlPoints >
1421 device_data->device_limits.maxTessellationPatchSize) {
1422 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001423 VALIDATION_ERROR_1080097c,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001424 "vkCreateGraphicsPipelines: invalid parameter "
1425 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001426 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001427 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001428 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001429 }
1430 }
1431 }
1432 }
1433
1434 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1435 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1436 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1437 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001438 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001439 VK_NULL_HANDLE, VALIDATION_ERROR_096005dc,
Petr Krausa6103552017-11-16 21:21:58 +01001440 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1441 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001442 "].pViewportState (=NULL) is not a valid pointer.",
1443 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001444 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001445 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1446
1447 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1448 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001449 VK_NULL_HANDLE, VALIDATION_ERROR_10c2b00b,
Petr Krausa6103552017-11-16 21:21:58 +01001450 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001451 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1452 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001453 }
1454
Petr Krausa6103552017-11-16 21:21:58 +01001455 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1456 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
1457 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV};
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001458 skip |= validate_struct_pnext(
1459 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001460 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
1461 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV",
1462 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
1463 allowed_structs_VkPipelineViewportStateCreateInfo, 65, VALIDATION_ERROR_10c1c40d);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001464
1465 skip |= validate_reserved_flags(
1466 report_data, "vkCreateGraphicsPipelines",
1467 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Petr Krausa6103552017-11-16 21:21:58 +01001468 viewport_state.flags, VALIDATION_ERROR_10c09005);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001469
Petr Krausa6103552017-11-16 21:21:58 +01001470 if (!device_data->physical_device_features.multiViewport) {
1471 if (viewport_state.viewportCount != 1) {
1472 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001473 VK_NULL_HANDLE, VALIDATION_ERROR_10c00980,
Petr Krausa6103552017-11-16 21:21:58 +01001474 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1475 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001476 ") is not 1.",
1477 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001478 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001479
Petr Krausa6103552017-11-16 21:21:58 +01001480 if (viewport_state.scissorCount != 1) {
1481 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001482 VK_NULL_HANDLE, VALIDATION_ERROR_10c00982,
Petr Krausa6103552017-11-16 21:21:58 +01001483 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1484 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001485 ") is not 1.",
1486 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001487 }
Petr Krausa6103552017-11-16 21:21:58 +01001488 } else { // multiViewport enabled
1489 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001490 skip |= log_msg(
1491 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001492 VK_NULL_HANDLE, VALIDATION_ERROR_10c30a1b,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001493 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001494 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1495 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001496 VK_NULL_HANDLE, VALIDATION_ERROR_10c00984,
Petr Krausa6103552017-11-16 21:21:58 +01001497 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1498 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001499 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1500 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001501 }
Petr Krausa6103552017-11-16 21:21:58 +01001502
1503 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001504 skip |= log_msg(
1505 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001506 VK_NULL_HANDLE, VALIDATION_ERROR_10c2b61b,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001507 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001508 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1509 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001510 VK_NULL_HANDLE, VALIDATION_ERROR_10c00986,
Petr Krausa6103552017-11-16 21:21:58 +01001511 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1512 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001513 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1514 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001515 }
1516 }
1517
Petr Krausa6103552017-11-16 21:21:58 +01001518 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001519 skip |=
1520 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001521 VK_NULL_HANDLE, VALIDATION_ERROR_10c00988,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001522 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1523 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1524 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001525 }
1526
Petr Krausa6103552017-11-16 21:21:58 +01001527 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1528 skip |= log_msg(
1529 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001530 VALIDATION_ERROR_096005d6,
Petr Krausa6103552017-11-16 21:21:58 +01001531 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1532 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001533 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1534 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001535 }
1536
1537 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1538 skip |= log_msg(
1539 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001540 VALIDATION_ERROR_096005d8,
Petr Krausa6103552017-11-16 21:21:58 +01001541 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1542 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001543 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1544 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001545 }
1546
Petr Krausb3fcdb42018-01-09 22:09:09 +01001547 // validate the VkViewports
1548 if (!has_dynamic_viewport && viewport_state.pViewports) {
1549 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1550 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1551 const char fn_name[] = "vkCreateGraphicsPipelines";
1552 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1553 std::to_string(viewport_i) + "]";
1554 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1555 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1556 }
1557 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001558
1559 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1560 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001561 VK_NULL_HANDLE, EXTENSION_NOT_ENABLED,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001562 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001563 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001564 "VK_NV_clip_space_w_scaling extension is not enabled.",
1565 i);
1566 }
1567
1568 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1569 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001570 VK_NULL_HANDLE, EXTENSION_NOT_ENABLED,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001571 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001572 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001573 "VK_EXT_discard_rectangles extension is not enabled.",
1574 i);
1575 }
1576
1577 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1578 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001579 VK_NULL_HANDLE, EXTENSION_NOT_ENABLED,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001580 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001581 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001582 "VK_EXT_sample_locations extension is not enabled.",
1583 i);
1584 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001585 }
1586
1587 if (pCreateInfos[i].pMultisampleState == nullptr) {
1588 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001589 VALIDATION_ERROR_096005de,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001590 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001591 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1592 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001593 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001594 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1595 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1596 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001597 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001598 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001599 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001600 skip |= validate_struct_pnext(
1601 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001602 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1603 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
1604 VALIDATION_ERROR_1001c40d);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001605
1606 skip |= validate_reserved_flags(
1607 report_data, "vkCreateGraphicsPipelines",
1608 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
1609 pCreateInfos[i].pMultisampleState->flags, VALIDATION_ERROR_10009005);
1610
1611 skip |= validate_bool32(
1612 report_data, "vkCreateGraphicsPipelines",
1613 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1614 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1615
1616 skip |= validate_array(
1617 report_data, "vkCreateGraphicsPipelines",
1618 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1619 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001620 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001621 true, false, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
1622
1623 skip |= validate_bool32(
1624 report_data, "vkCreateGraphicsPipelines",
1625 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1626 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1627
1628 skip |= validate_bool32(
1629 report_data, "vkCreateGraphicsPipelines",
1630 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1631 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1632
1633 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
1634 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001635 INVALID_STRUCT_STYPE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001636 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
1637 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
1638 i);
1639 }
John Zulauf7acac592017-11-06 11:15:53 -07001640 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
1641 if (!device_data->physical_device_features.sampleRateShading) {
1642 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001643 VALIDATION_ERROR_10000620,
John Zulauf7acac592017-11-06 11:15:53 -07001644 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001645 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
1646 i);
John Zulauf7acac592017-11-06 11:15:53 -07001647 }
1648 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
1649 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
1650 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
1651 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001652 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001653 VALIDATION_ERROR_10000624,
1654 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07001655 }
1656 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001657 }
1658
Petr Krause91f7a12017-12-14 20:57:36 +01001659 bool uses_color_attachment = false;
1660 bool uses_depthstencil_attachment = false;
1661 {
1662 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
1663 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
1664 const auto &subpasses_uses = subpasses_uses_it->second;
1665 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
1666 uses_color_attachment = true;
1667 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
1668 uses_depthstencil_attachment = true;
1669 }
1670 }
1671
1672 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001673 skip |= validate_struct_pnext(
1674 report_data, "vkCreateGraphicsPipelines",
1675 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
1676 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0f61c40d);
1677
1678 skip |= validate_reserved_flags(
1679 report_data, "vkCreateGraphicsPipelines",
1680 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
1681 pCreateInfos[i].pDepthStencilState->flags, VALIDATION_ERROR_0f609005);
1682
1683 skip |= validate_bool32(
1684 report_data, "vkCreateGraphicsPipelines",
1685 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
1686 pCreateInfos[i].pDepthStencilState->depthTestEnable);
1687
1688 skip |= validate_bool32(
1689 report_data, "vkCreateGraphicsPipelines",
1690 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
1691 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
1692
1693 skip |= validate_ranged_enum(
1694 report_data, "vkCreateGraphicsPipelines",
1695 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
1696 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
1697 VALIDATION_ERROR_0f604001);
1698
1699 skip |= validate_bool32(
1700 report_data, "vkCreateGraphicsPipelines",
1701 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
1702 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
1703
1704 skip |= validate_bool32(
1705 report_data, "vkCreateGraphicsPipelines",
1706 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
1707 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
1708
1709 skip |= validate_ranged_enum(
1710 report_data, "vkCreateGraphicsPipelines",
1711 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
1712 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
1713 VALIDATION_ERROR_13a08601);
1714
1715 skip |= validate_ranged_enum(
1716 report_data, "vkCreateGraphicsPipelines",
1717 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
1718 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
1719 VALIDATION_ERROR_13a27801);
1720
1721 skip |= validate_ranged_enum(
1722 report_data, "vkCreateGraphicsPipelines",
1723 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
1724 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
1725 VALIDATION_ERROR_13a04201);
1726
1727 skip |= validate_ranged_enum(
1728 report_data, "vkCreateGraphicsPipelines",
1729 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
1730 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
1731 VALIDATION_ERROR_0f604001);
1732
1733 skip |= validate_ranged_enum(
1734 report_data, "vkCreateGraphicsPipelines",
1735 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
1736 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
1737 VALIDATION_ERROR_13a08601);
1738
1739 skip |= validate_ranged_enum(
1740 report_data, "vkCreateGraphicsPipelines",
1741 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
1742 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
1743 VALIDATION_ERROR_13a27801);
1744
1745 skip |= validate_ranged_enum(
1746 report_data, "vkCreateGraphicsPipelines",
1747 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
1748 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
1749 VALIDATION_ERROR_13a04201);
1750
1751 skip |= validate_ranged_enum(
1752 report_data, "vkCreateGraphicsPipelines",
1753 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
1754 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
1755 VALIDATION_ERROR_0f604001);
1756
1757 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
1758 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001759 INVALID_STRUCT_STYPE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001760 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
1761 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
1762 i);
1763 }
1764 }
1765
Petr Krause91f7a12017-12-14 20:57:36 +01001766 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001767 skip |= validate_struct_pnext(
1768 report_data, "vkCreateGraphicsPipelines",
1769 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}), NULL,
1770 pCreateInfos[i].pColorBlendState->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0f41c40d);
1771
1772 skip |= validate_reserved_flags(
1773 report_data, "vkCreateGraphicsPipelines",
1774 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
1775 pCreateInfos[i].pColorBlendState->flags, VALIDATION_ERROR_0f409005);
1776
1777 skip |= validate_bool32(
1778 report_data, "vkCreateGraphicsPipelines",
1779 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
1780 pCreateInfos[i].pColorBlendState->logicOpEnable);
1781
1782 skip |= validate_array(
1783 report_data, "vkCreateGraphicsPipelines",
1784 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
1785 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001786 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001787 true, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
1788
1789 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
1790 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
1791 ++attachmentIndex) {
1792 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
1793 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
1794 ParameterName::IndexVector{i, attachmentIndex}),
1795 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
1796
1797 skip |= validate_ranged_enum(
1798 report_data, "vkCreateGraphicsPipelines",
1799 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
1800 ParameterName::IndexVector{i, attachmentIndex}),
1801 "VkBlendFactor", AllVkBlendFactorEnums,
1802 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
1803 VALIDATION_ERROR_0f22cc01);
1804
1805 skip |= validate_ranged_enum(
1806 report_data, "vkCreateGraphicsPipelines",
1807 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
1808 ParameterName::IndexVector{i, attachmentIndex}),
1809 "VkBlendFactor", AllVkBlendFactorEnums,
1810 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
1811 VALIDATION_ERROR_0f207001);
1812
1813 skip |= validate_ranged_enum(
1814 report_data, "vkCreateGraphicsPipelines",
1815 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
1816 ParameterName::IndexVector{i, attachmentIndex}),
1817 "VkBlendOp", AllVkBlendOpEnums,
1818 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
1819 VALIDATION_ERROR_0f202001);
1820
1821 skip |= validate_ranged_enum(
1822 report_data, "vkCreateGraphicsPipelines",
1823 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
1824 ParameterName::IndexVector{i, attachmentIndex}),
1825 "VkBlendFactor", AllVkBlendFactorEnums,
1826 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
1827 VALIDATION_ERROR_0f22c601);
1828
1829 skip |= validate_ranged_enum(
1830 report_data, "vkCreateGraphicsPipelines",
1831 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
1832 ParameterName::IndexVector{i, attachmentIndex}),
1833 "VkBlendFactor", AllVkBlendFactorEnums,
1834 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
1835 VALIDATION_ERROR_0f206a01);
1836
1837 skip |= validate_ranged_enum(
1838 report_data, "vkCreateGraphicsPipelines",
1839 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
1840 ParameterName::IndexVector{i, attachmentIndex}),
1841 "VkBlendOp", AllVkBlendOpEnums,
1842 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
1843 VALIDATION_ERROR_0f200801);
1844
1845 skip |=
1846 validate_flags(report_data, "vkCreateGraphicsPipelines",
1847 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
1848 ParameterName::IndexVector{i, attachmentIndex}),
1849 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
1850 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
1851 false, false, VALIDATION_ERROR_0f202201);
1852 }
1853 }
1854
1855 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
1856 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001857 INVALID_STRUCT_STYPE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001858 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
1859 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
1860 i);
1861 }
1862
1863 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
1864 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
1865 skip |= validate_ranged_enum(
1866 report_data, "vkCreateGraphicsPipelines",
1867 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
1868 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp, VALIDATION_ERROR_0f4004be);
1869 }
1870 }
1871 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001872
Petr Kraus9752aae2017-11-24 03:05:50 +01001873 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
1874 if (pCreateInfos[i].basePipelineIndex != -1) {
1875 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001876 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001877 VALIDATION_ERROR_096005a8,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001878 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
1879 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001880 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001881 }
1882 }
1883
Petr Kraus9752aae2017-11-24 03:05:50 +01001884 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
1885 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001886 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001887 VALIDATION_ERROR_096005aa,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001888 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
1889 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001890 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001891 }
1892 }
1893 }
1894
Petr Kraus9752aae2017-11-24 03:05:50 +01001895 if (pCreateInfos[i].pRasterizationState) {
1896 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001897 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001898 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001899 DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001900 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
1901 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
1902 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001903 }
Petr Kraus299ba622017-11-24 03:09:03 +01001904
1905 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
1906 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
1907 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001908 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 0, VALIDATION_ERROR_096005da,
Petr Kraus299ba622017-11-24 03:09:03 +01001909 "The line width state is static (pCreateInfos[%" PRIu32
1910 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
1911 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001912 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
1913 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01001914 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001915 }
1916
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001917 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
1918 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
1919 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
1920 pCreateInfos[i].pStages[j].pName);
1921 }
1922 }
1923 }
1924
1925 return skip;
1926}
1927
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001928bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1929 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1930 VkPipeline *pPipelines) {
1931 bool skip = false;
1932 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1933
1934 for (uint32_t i = 0; i < createInfoCount; i++) {
1935 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
1936 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
1937 pCreateInfos[i].stage.pName);
1938 }
1939
1940 return skip;
1941}
1942
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001943bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1944 VkSampler *pSampler) {
1945 bool skip = false;
1946 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1947 debug_report_data *report_data = device_data->report_data;
1948
1949 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06001950 const auto &features = device_data->physical_device_features;
1951 const auto &limits = device_data->device_limits;
1952 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
1953 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001954 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001955 VALIDATION_ERROR_1260085e,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001956 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06001957 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001958 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06001959 }
1960
1961 // Anistropy cannot be enabled in sampler unless enabled as a feature
1962 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001963 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001964 VALIDATION_ERROR_1260085c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001965 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
1966 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06001967 }
1968
1969 // Anistropy and unnormalized coordinates cannot be enabled simultaneously
1970 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001971 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06001972 VALIDATION_ERROR_12600868,
Dave Houltona9df0ce2018-02-07 10:51:23 -07001973 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001974 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06001975 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001976 }
1977
1978 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
1979 if (pCreateInfo->compareEnable == VK_TRUE) {
1980 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp",
1981 AllVkCompareOpEnums, pCreateInfo->compareOp, VALIDATION_ERROR_12600870);
1982 }
1983
1984 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
1985 // valid VkBorderColor value
1986 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
1987 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
1988 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
1989 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
1990 AllVkBorderColorEnums, pCreateInfo->borderColor, VALIDATION_ERROR_1260086c);
1991 }
1992
1993 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
1994 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
1995 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
1996 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
1997 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
1998 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001999 skip |= log_msg(
2000 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, VALIDATION_ERROR_1260086e,
2001 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2002 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002003 }
John Zulauf275805c2017-10-26 15:34:49 -06002004
2005 // Checks for the IMG cubic filtering extension
2006 if (device_data->extensions.vk_img_filter_cubic) {
2007 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2008 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002009 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002010 VALIDATION_ERROR_12600872,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002011 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002012 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002013 }
2014 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002015 }
2016
2017 return skip;
2018}
2019
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002020bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2021 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2022 bool skip = false;
2023 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2024 debug_report_data *report_data = device_data->report_data;
2025
2026 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2027 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2028 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2029 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2030 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2031 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2032 // valid VkSampler handles
2033 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2034 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2035 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2036 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2037 ++descriptor_index) {
2038 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2039 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002040 REQUIRED_PARAMETER,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002041 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002042 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002043 i, descriptor_index);
2044 }
2045 }
2046 }
2047
2048 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2049 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2050 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002051 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002052 VALIDATION_ERROR_04e00236,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002053 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2054 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002055 "values.",
2056 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002057 }
2058 }
2059 }
2060 }
2061
2062 return skip;
2063}
2064
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002065bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2066 const VkDescriptorSet *pDescriptorSets) {
2067 bool skip = false;
2068 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2069 debug_report_data *report_data = device_data->report_data;
2070
2071 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2072 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2073 // validate_array()
2074 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002075 &pDescriptorSets, true, true, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002076 return skip;
2077}
2078
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002079bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2080 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2081 bool skip = false;
2082 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2083 debug_report_data *report_data = device_data->report_data;
2084
2085 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2086 if (pDescriptorWrites != NULL) {
2087 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2088 // descriptorCount must be greater than 0
2089 if (pDescriptorWrites[i].descriptorCount == 0) {
2090 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002091 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002092 VALIDATION_ERROR_15c0441b,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002093 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002094 }
2095
2096 // dstSet must be a valid VkDescriptorSet handle
2097 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2098 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2099 pDescriptorWrites[i].dstSet);
2100
2101 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2102 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2103 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2104 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2105 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2106 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2107 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2108 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2109 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2110 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002111 VALIDATION_ERROR_15c00284,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002112 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2113 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2114 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002115 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2116 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002117 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2118 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2119 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2120 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2121 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2122 ++descriptor_index) {
2123 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2124 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2125 ParameterName::IndexVector{i, descriptor_index}),
2126 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2127 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2128 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2129 ParameterName::IndexVector{i, descriptor_index}),
2130 "VkImageLayout", AllVkImageLayoutEnums,
2131 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout,
2132 VALIDATION_ERROR_UNDEFINED);
2133 }
2134 }
2135 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2136 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2137 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2138 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2139 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2140 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2141 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2142 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2143 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002144 VALIDATION_ERROR_15c00288,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002145 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2146 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2147 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002148 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2149 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002150 } else {
2151 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2152 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2153 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2154 ParameterName::IndexVector{i, descriptorIndex}),
2155 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2156 }
2157 }
2158 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2159 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2160 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2161 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2162 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2163 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002164 VALIDATION_ERROR_15c00286,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002165 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2166 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002167 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2168 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002169 } else {
2170 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2171 ++descriptor_index) {
2172 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2173 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2174 ParameterName::IndexVector{i, descriptor_index}),
2175 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2176 }
2177 }
2178 }
2179
2180 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2181 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2182 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2183 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2184 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2185 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002186 skip |=
2187 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
2188 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, VALIDATION_ERROR_15c0028e,
2189 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2190 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2191 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002192 }
2193 }
2194 }
2195 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2196 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2197 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2198 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2199 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2200 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002201 skip |=
2202 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
2203 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, VALIDATION_ERROR_15c00290,
2204 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2205 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2206 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002207 }
2208 }
2209 }
2210 }
2211 }
2212 }
2213 return skip;
2214}
2215
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002216bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2217 VkRenderPass *pRenderPass) {
2218 bool skip = false;
2219 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2220 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
2221
2222 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2223 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2224 std::stringstream ss;
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002225 ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED. ";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002226 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002227 VALIDATION_ERROR_00809201, "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002228 }
2229 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2230 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
2231 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002232 VALIDATION_ERROR_00800696,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002233 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002234 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2235 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002236 }
2237 }
2238
2239 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2240 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
2241 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002242 VALIDATION_ERROR_1400069a, "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002243 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002244 }
2245 }
2246 return skip;
2247}
2248
2249bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2250 const VkCommandBuffer *pCommandBuffers) {
2251 bool skip = false;
2252 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2253 debug_report_data *report_data = device_data->report_data;
2254
2255 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2256 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2257 // validate_array()
2258 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002259 &pCommandBuffers, true, true, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002260 return skip;
2261}
2262
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002263bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2264 bool skip = false;
2265 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2266 debug_report_data *report_data = device_data->report_data;
2267 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2268
2269 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2270 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2271 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2272 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
2273 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false, VALIDATION_ERROR_UNDEFINED);
2274
2275 if (pBeginInfo->pInheritanceInfo != NULL) {
2276 skip |=
2277 validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2278 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_0281c40d);
2279
2280 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2281 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2282
2283 // TODO: This only needs to be validated when the inherited queries feature is enabled
2284 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2285 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2286
2287 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2288 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2289 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
2290 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, VALIDATION_ERROR_UNDEFINED);
2291 }
2292
2293 if (pInfo != NULL) {
2294 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2295 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002296 HandleToUint64(commandBuffer), VALIDATION_ERROR_02a00070,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002297 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002298 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002299 }
2300 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2301 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2302 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
2303 VALIDATION_ERROR_02a00072);
2304 }
2305 }
2306
2307 return skip;
2308}
2309
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002310bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2311 const VkViewport *pViewports) {
2312 bool skip = false;
2313 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2314
Petr Krausd55e77c2018-01-09 22:09:25 +01002315 if (!device_data->physical_device_features.multiViewport) {
2316 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002317 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002318 HandleToUint64(commandBuffer), VALIDATION_ERROR_1e000990,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002319 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2320 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002321 }
2322 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002323 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002324 HandleToUint64(commandBuffer), VALIDATION_ERROR_1e000992,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002325 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2326 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002327 }
2328 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002329 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002330 if (sum > device_data->device_limits.maxViewports) {
2331 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002332 HandleToUint64(commandBuffer), VALIDATION_ERROR_1e00098e,
Petr Krausd55e77c2018-01-09 22:09:25 +01002333 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002334 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2335 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002336 }
2337 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002338
2339 if (pViewports) {
2340 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2341 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2342 const char fn_name[] = "vkCmdSetViewport";
2343 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2344 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2345 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2346 }
2347 }
2348
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002349 return skip;
2350}
2351
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002352bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2353 bool skip = false;
2354 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2355 debug_report_data *report_data = device_data->report_data;
2356
Petr Kraus6260f0a2018-02-27 21:15:55 +01002357 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002358 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002359 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002360 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a2,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002361 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2362 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002363 }
2364 if (scissorCount > 1) {
2365 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002366 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a4,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002367 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2368 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002369 }
2370 } else { // multiViewport enabled
2371 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2372 if (sum > device_data->device_limits.maxViewports) {
2373 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002374 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a0,
Petr Kraus6260f0a2018-02-27 21:15:55 +01002375 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002376 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2377 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002378 }
2379 }
2380
Petr Kraus6260f0a2018-02-27 21:15:55 +01002381 if (pScissors) {
2382 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2383 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002384
Petr Kraus6260f0a2018-02-27 21:15:55 +01002385 if (scissor.offset.x < 0) {
2386 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002387 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a6,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002388 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2389 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002390 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002391
Petr Kraus6260f0a2018-02-27 21:15:55 +01002392 if (scissor.offset.y < 0) {
2393 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002394 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a6,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002395 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2396 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002397 }
2398
2399 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2400 if (x_sum > INT32_MAX) {
2401 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002402 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004a8,
Petr Kraus6260f0a2018-02-27 21:15:55 +01002403 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002404 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2405 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002406 }
2407
2408 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2409 if (y_sum > INT32_MAX) {
2410 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002411 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d8004aa,
Petr Kraus6260f0a2018-02-27 21:15:55 +01002412 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002413 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2414 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002415 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002416 }
2417 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002418
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002419 return skip;
2420}
2421
Petr Kraus299ba622017-11-24 03:09:03 +01002422bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2423 bool skip = false;
2424 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2425 debug_report_data *report_data = device_data->report_data;
2426
2427 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2428 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002429 HandleToUint64(commandBuffer), VALIDATION_ERROR_1d600628,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002430 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002431 }
2432
2433 return skip;
2434}
2435
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002436bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2437 uint32_t firstInstance) {
2438 bool skip = false;
2439 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2440 if (vertexCount == 0) {
2441 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2442 // this an error or leave as is.
2443 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002444 REQUIRED_PARAMETER, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002445 }
2446
2447 if (instanceCount == 0) {
2448 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2449 // this an error or leave as is.
2450 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002451 REQUIRED_PARAMETER, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002452 }
2453 return skip;
2454}
2455
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002456bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2457 bool skip = false;
2458 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2459
2460 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2461 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002462 DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002463 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2464 }
2465 return skip;
2466}
2467
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002468bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2469 uint32_t stride) {
2470 bool skip = false;
2471 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2472 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002473 skip |= log_msg(
2474 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
2475 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002476 }
2477 return skip;
2478}
2479
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002480bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2481 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2482 bool skip = false;
2483 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2484
Dave Houltonf5217612018-02-02 16:18:52 -07002485 VkImageAspectFlags legal_aspect_flags =
2486 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2487 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2488 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2489 }
2490
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002491 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002492 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002493 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002494 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002495 VALIDATION_ERROR_0a600c01,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002496 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002497 }
Dave Houltonf5217612018-02-02 16:18:52 -07002498 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002499 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002500 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002501 VALIDATION_ERROR_0a600c01,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002502 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002503 }
2504 }
2505 return skip;
2506}
2507
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002508bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2509 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2510 bool skip = false;
2511 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2512
Dave Houltonf5217612018-02-02 16:18:52 -07002513 VkImageAspectFlags legal_aspect_flags =
2514 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2515 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2516 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2517 }
2518
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002519 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002520 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002521 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002522 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002523 UNRECOGNIZED_VALUE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002524 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2525 }
Dave Houltonf5217612018-02-02 16:18:52 -07002526 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002527 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002528 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002529 UNRECOGNIZED_VALUE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002530 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2531 }
2532 }
2533 return skip;
2534}
2535
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002536bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
2537 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2538 bool skip = false;
2539 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2540
Dave Houltonf5217612018-02-02 16:18:52 -07002541 VkImageAspectFlags legal_aspect_flags =
2542 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2543 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2544 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2545 }
2546
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002547 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002548 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002549 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002550 UNRECOGNIZED_VALUE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002551 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2552 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002553 }
2554 }
2555 return skip;
2556}
2557
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002558bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2559 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2560 bool skip = false;
2561 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2562
Dave Houltonf5217612018-02-02 16:18:52 -07002563 VkImageAspectFlags legal_aspect_flags =
2564 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2565 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2566 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2567 }
2568
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002569 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002570 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002571 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002572 UNRECOGNIZED_VALUE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002573 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2574 "enumerator");
2575 }
2576 }
2577 return skip;
2578}
2579
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002580bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
2581 const void *pData) {
2582 bool skip = false;
2583 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2584
2585 if (dstOffset & 3) {
2586 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002587 VALIDATION_ERROR_1e400048,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002588 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
2589 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002590 }
2591
2592 if ((dataSize <= 0) || (dataSize > 65536)) {
2593 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002594 VALIDATION_ERROR_1e40004a,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002595 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002596 "), must be greater than zero and less than or equal to 65536.",
2597 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002598 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002599 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002600 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002601 VALIDATION_ERROR_1e40004c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002602 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002603 }
2604 return skip;
2605}
2606
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002607bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
2608 uint32_t data) {
2609 bool skip = false;
2610 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2611
2612 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002613 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002614 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002615 VALIDATION_ERROR_1b400032,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002616 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002617 }
2618
2619 if (size != VK_WHOLE_SIZE) {
2620 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002621 skip |=
2622 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002623 VALIDATION_ERROR_1b400034,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002624 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002625 } else if (size & 3) {
2626 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002627 VALIDATION_ERROR_1b400038,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002628 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002629 }
2630 }
2631 return skip;
2632}
2633
2634VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
2635 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
2636}
2637
2638VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
2639 VkLayerProperties *pProperties) {
2640 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
2641}
2642
2643VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
2644 VkExtensionProperties *pProperties) {
2645 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
2646 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
2647
2648 return VK_ERROR_LAYER_NOT_PRESENT;
2649}
2650
2651VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
2652 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
2653 // Parameter_validation does not have any physical device extensions
2654 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
2655 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
2656
2657 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
2658 bool skip =
2659 validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002660 pPropertyCount, &pProperties, true, false, false, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_2761f401);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002661 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
2662
2663 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
2664}
2665
2666static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
2667 if (!flag) {
2668 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002669 EXTENSION_NOT_ENABLED, "%s() called even though the %s extension was not enabled for this VkDevice.",
2670 function_name, extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002671 }
2672
2673 return false;
2674}
2675
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002676bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2677 VkSwapchainKHR *pSwapchain) {
2678 bool skip = false;
2679 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2680 debug_report_data *report_data = device_data->report_data;
2681
Mark Lobodzinski88529492018-04-01 10:38:15 -06002682 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01002683 "vkCreateSwapchainKHR"};
2684
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002685 if (pCreateInfo != nullptr) {
2686 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
2687 FormatIsCompressed_ETC2_EAC(pCreateInfo->imageFormat)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002688 skip |=
Mark Lobodzinski88529492018-04-01 10:38:15 -06002689 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002690 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The textureCompressionETC2 "
2691 "feature is not enabled: neither ETC2 nor EAC formats can be used to create images.",
2692 string_VkFormat(pCreateInfo->imageFormat));
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002693 }
2694
2695 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
2696 FormatIsCompressed_ASTC_LDR(pCreateInfo->imageFormat)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002697 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002698 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
2699 "textureCompressionASTC_LDR feature is not enabled: ASTC formats cannot be used to create images.",
2700 string_VkFormat(pCreateInfo->imageFormat));
2701 }
2702
2703 if ((device_data->physical_device_features.textureCompressionBC == false) &&
2704 FormatIsCompressed_BC(pCreateInfo->imageFormat)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002705 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, DEVICE_FEATURE,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002706 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
2707 "textureCompressionBC feature is not enabled: BC compressed formats cannot be used to create images.",
2708 string_VkFormat(pCreateInfo->imageFormat));
2709 }
2710
2711 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2712 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
2713 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
2714 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002715 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002716 VALIDATION_ERROR_146009fc,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002717 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002718 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002719 }
2720
2721 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
2722 // queueFamilyIndexCount uint32_t values
2723 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002724 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002725 VALIDATION_ERROR_146009fa,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002726 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
2727 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002728 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002729 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002730 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
2731 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices", INVALID_USAGE,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002732 INVALID_USAGE, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002733 }
2734 }
2735
Petr Krause5c37652018-01-05 04:05:12 +01002736 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers", VALIDATION_ERROR_146009f6,
2737 log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002738 }
2739
2740 return skip;
2741}
2742
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002743bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
2744 bool skip = false;
2745 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
2746
2747 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06002748 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
2749 if (present_regions) {
2750 // TODO: This and all other pNext extension dependencies should be added to code-generation
2751 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
2752 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
2753 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
2754 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002755 INVALID_USAGE,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002756 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
2757 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06002758 pPresentInfo->swapchainCount, present_regions->swapchainCount);
2759 }
2760 skip |= validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
2761 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, VALIDATION_ERROR_1121c40d);
2762 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002763 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
2764 true, false, VALIDATION_ERROR_UNDEFINED, VALIDATION_ERROR_UNDEFINED);
John Zulaufde972ac2017-10-26 12:07:05 -06002765 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
2766 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002767 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002768 &present_regions->pRegions[i].pRectangles, true, false, VALIDATION_ERROR_UNDEFINED,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002769 VALIDATION_ERROR_UNDEFINED);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002770 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002771 }
2772 }
2773
2774 return skip;
2775}
2776
2777#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002778bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
2779 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
2780 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
2781 bool skip = false;
2782
2783 if (pCreateInfo->hwnd == nullptr) {
2784 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002785 VALIDATION_ERROR_15a00a38, "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002786 }
2787
2788 return skip;
2789}
2790#endif // VK_USE_PLATFORM_WIN32_KHR
2791
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002792bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
2793 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2794 if (pNameInfo->pObjectName) {
2795 device_data->report_data->debugObjectNameMap->insert(
2796 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
2797 } else {
2798 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
2799 }
2800 return false;
2801}
2802
Petr Krausc8655be2017-09-27 18:56:51 +02002803bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
2804 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
2805 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2806 bool skip = false;
2807
2808 if (pCreateInfo) {
2809 if (pCreateInfo->maxSets <= 0) {
2810 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002811 VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, VK_NULL_HANDLE, VALIDATION_ERROR_0480025a,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002812 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02002813 }
2814
2815 if (pCreateInfo->pPoolSizes) {
2816 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
2817 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
2818 skip |= log_msg(
2819 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002820 VK_NULL_HANDLE, VALIDATION_ERROR_04a0025c,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002821 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02002822 }
2823 }
2824 }
2825 }
2826
2827 return skip;
2828}
2829
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002830bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
2831 bool skip = false;
2832 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2833
2834 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002835 skip |=
2836 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002837 HandleToUint64(commandBuffer), VALIDATION_ERROR_19c00304,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002838 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2839 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002840 }
2841
2842 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002843 skip |=
2844 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002845 HandleToUint64(commandBuffer), VALIDATION_ERROR_19c00306,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002846 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2847 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002848 }
2849
2850 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002851 skip |=
2852 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002853 HandleToUint64(commandBuffer), VALIDATION_ERROR_19c00308,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002854 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2855 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002856 }
2857
2858 return skip;
2859}
2860
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002861bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002862 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
2863 bool skip = false;
2864 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2865
2866 // Paired if {} else if {} tests used to avoid any possible uint underflow
2867 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
2868 if (baseGroupX >= limit) {
2869 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002870 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e0034a,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002871 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002872 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2873 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002874 } else if (groupCountX > (limit - baseGroupX)) {
2875 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002876 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e00350,
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002877 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002878 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
2879 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002880 }
2881
2882 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
2883 if (baseGroupY >= limit) {
2884 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002885 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e0034c,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002886 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002887 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2888 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002889 } else if (groupCountY > (limit - baseGroupY)) {
2890 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002891 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e00352,
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002892 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002893 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
2894 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002895 }
2896
2897 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
2898 if (baseGroupZ >= limit) {
2899 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002900 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e0034e,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002901 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002902 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2903 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002904 } else if (groupCountZ > (limit - baseGroupZ)) {
2905 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -06002906 HandleToUint64(commandBuffer), VALIDATION_ERROR_19e00354,
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002907 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002908 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
2909 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07002910 }
2911
2912 return skip;
2913}
2914
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002915VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
2916 const auto item = name_to_funcptr_map.find(funcName);
2917 if (item != name_to_funcptr_map.end()) {
2918 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
2919 }
2920
2921 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2922 const auto &table = device_data->dispatch_table;
2923 if (!table.GetDeviceProcAddr) return nullptr;
2924 return table.GetDeviceProcAddr(device, funcName);
2925}
2926
2927VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
2928 const auto item = name_to_funcptr_map.find(funcName);
2929 if (item != name_to_funcptr_map.end()) {
2930 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
2931 }
2932
2933 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
2934 auto &table = instance_data->dispatch_table;
2935 if (!table.GetInstanceProcAddr) return nullptr;
2936 return table.GetInstanceProcAddr(instance, funcName);
2937}
2938
2939VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
2940 assert(instance);
2941 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
2942
2943 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
2944 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
2945}
2946
2947// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
2948// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02002949void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002950 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
2951 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
2952 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
2953 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
2954 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
2955 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
2956 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
2957 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
2958 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
2959 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
2960 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
2961 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
2962 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
2963 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01002964 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07002965 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
2966 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
2967 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
2968 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
2969 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
2970 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
2971 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
2972 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
2973 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
2974 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
2975 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
2976 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
2977 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07002978 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002979}
2980
2981} // namespace parameter_validation
2982
2983VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
2984 VkExtensionProperties *pProperties) {
2985 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
2986}
2987
2988VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
2989 VkLayerProperties *pProperties) {
2990 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
2991}
2992
2993VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
2994 VkLayerProperties *pProperties) {
2995 // the layer command handles VK_NULL_HANDLE just fine internally
2996 assert(physicalDevice == VK_NULL_HANDLE);
2997 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
2998}
2999
3000VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3001 const char *pLayerName, uint32_t *pCount,
3002 VkExtensionProperties *pProperties) {
3003 // the layer command handles VK_NULL_HANDLE just fine internally
3004 assert(physicalDevice == VK_NULL_HANDLE);
3005 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3006}
3007
3008VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3009 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3010}
3011
3012VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3013 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3014}
3015
3016VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3017 const char *funcName) {
3018 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3019}
3020
3021VK_LAYER_EXPORT bool pv_vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
3022 assert(pVersionStruct != NULL);
3023 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3024
3025 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3026 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3027 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3028 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3029 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3030 }
3031
3032 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3033 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3034 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3035 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3036 }
3037
3038 return VK_SUCCESS;
3039}