blob: 13e355cb047f34e05aea4faccedb16ccaa261ad2 [file] [log] [blame]
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08001/* Copyright (c) 2015-2020 The Khronos Group Inc.
2 * Copyright (c) 2015-2020 Valve Corporation
3 * Copyright (c) 2015-2020 LunarG, Inc.
4 * Copyright (C) 2015-2020 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028static const int MaxParamCheckerStringLength = 256;
29
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070036bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050037 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060038 bool skip = false;
39
40 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
41
42 if (result == VK_STRING_ERROR_NONE) {
43 return skip;
44 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070045 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
46 MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070048 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
49 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050 }
51 return skip;
52}
53
Jeff Bolz46c0ea02019-10-09 13:06:29 -050054bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060055 bool skip = false;
56 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
57 if (api_version_nopatch != effective_api_version) {
sfricke-samsung6aec21b2020-11-01 07:49:43 -080058 if ((api_version_nopatch < VK_API_VERSION_1_0) && (api_version != 0)) {
59 skip |= LogError(instance, "VUID-VkApplicationInfo-apiVersion-04010",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070060 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
61 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
62 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060063 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070064 skip |= LogWarning(instance, kVUIDUndefined,
65 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
66 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
67 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060068 }
69 }
70 return skip;
71}
72
Jeff Bolz46c0ea02019-10-09 13:06:29 -050073bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060074 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060075 // Create and use a local instance extension object, as an actual instance has not been created yet
76 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
77 InstanceExtensions local_instance_extensions;
78 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
79
John Zulauf620755c2018-04-16 11:00:43 -060080 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060081 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
82 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060083 }
84
85 return skip;
86}
87
Mark Lobodzinskibece6c12020-08-27 15:34:02 -060088bool StatelessValidation::SupportedByPdev(const VkPhysicalDevice physical_device, const std::string ext_name) const {
89 if (instance_extensions.vk_khr_get_physical_device_properties_2) {
90 // Struct is legal IF it's supported
91 const auto &dev_exts_enumerated = device_extensions_enumerated.find(physical_device);
92 if (dev_exts_enumerated == device_extensions_enumerated.end()) return true;
93 auto enum_iter = dev_exts_enumerated->second.find(ext_name);
94 if (enum_iter != dev_exts_enumerated->second.cend()) {
95 return true;
96 }
97 }
98 return false;
99}
100
Tony-LunarG866843d2020-05-13 11:22:42 -0600101bool StatelessValidation::validate_validation_features(const VkInstanceCreateInfo *pCreateInfo,
102 const VkValidationFeaturesEXT *validation_features) const {
103 bool skip = false;
104 bool debug_printf = false;
105 bool gpu_assisted = false;
106 bool reserve_slot = false;
107 for (uint32_t i = 0; i < validation_features->enabledValidationFeatureCount; i++) {
108 switch (validation_features->pEnabledValidationFeatures[i]) {
109 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT:
110 gpu_assisted = true;
111 break;
112
113 case VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT:
114 debug_printf = true;
115 break;
116
117 case VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT:
118 reserve_slot = true;
119 break;
120
121 default:
122 break;
123 }
124 }
125 if (reserve_slot && !gpu_assisted) {
126 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02967",
127 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT is in pEnabledValidationFeatures, "
128 "VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT must also be in pEnabledValidationFeatures.");
129 }
130 if (gpu_assisted && debug_printf) {
131 skip |= LogError(instance, "VUID-VkValidationFeaturesEXT-pEnabledValidationFeatures-02968",
132 "If VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT is in pEnabledValidationFeatures, "
133 "VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT must not also be in pEnabledValidationFeatures.");
134 }
135
136 return skip;
137}
138
John Zulauf620755c2018-04-16 11:00:43 -0600139template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700140ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
141 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -0600142 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700143 ExtEnabled state =
144 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -0600145 return state;
146}
147
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700148bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500149 const VkAllocationCallbacks *pAllocator,
150 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700151 bool skip = false;
152 // Note: From the spec--
153 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
154 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
155 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700156 ? pCreateInfo->pApplicationInfo->apiVersion
157 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700158 skip |= validate_api_version(local_api_version, api_version);
159 skip |= validate_instance_extensions(pCreateInfo);
Tony-LunarG866843d2020-05-13 11:22:42 -0600160 const auto *validation_features = lvl_find_in_chain<VkValidationFeaturesEXT>(pCreateInfo->pNext);
161 if (validation_features) skip |= validate_validation_features(pCreateInfo, validation_features);
162
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700163 return skip;
164}
165
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700166void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700167 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
168 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700169 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
170 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700171 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700172 this->instance_extensions = instance_data->instance_extensions;
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600173
174 uint32_t pdev_count = 0;
175 DispatchEnumeratePhysicalDevices(*pInstance, &pdev_count, nullptr);
176 std::vector<VkPhysicalDevice> physical_devices;
177 physical_devices.resize(pdev_count);
178 DispatchEnumeratePhysicalDevices(*pInstance, &pdev_count, physical_devices.data());
179
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600180 for (uint32_t i = 0; i < physical_devices.size(); i++) {
181 auto phys_dev_props = new VkPhysicalDeviceProperties;
182 DispatchGetPhysicalDeviceProperties(physical_devices[i], phys_dev_props);
183 physical_device_properties_map[physical_devices[i]] = phys_dev_props;
Mark Lobodzinskibece6c12020-08-27 15:34:02 -0600184
185 // Enumerate the Device Ext Properties to save the PhysicalDevice supported extension state
186 uint32_t ext_count = 0;
187 std::unordered_set<std::string> dev_exts_enumerated{};
188 std::vector<VkExtensionProperties> ext_props{};
189 instance_dispatch_table.EnumerateDeviceExtensionProperties(physical_devices[i], nullptr, &ext_count, nullptr);
190 ext_props.resize(ext_count);
191 instance_dispatch_table.EnumerateDeviceExtensionProperties(physical_devices[i], nullptr, &ext_count, ext_props.data());
192 for (uint32_t j = 0; j < ext_count; j++) {
193 dev_exts_enumerated.insert(ext_props[j].extensionName);
194 }
195 device_extensions_enumerated[physical_devices[i]] = std::move(dev_exts_enumerated);
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600196 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700197}
198
Mark Lobodzinski2e40a132020-08-10 14:51:41 -0600199void StatelessValidation::PreCallRecordDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
200 for (auto it = physical_device_properties_map.begin(); it != physical_device_properties_map.end();) {
201 delete (it->second);
202 it = physical_device_properties_map.erase(it);
203 }
204};
205
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700206void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700207 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700208 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700209 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700210 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
211 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700212
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700213 // Parmeter validation also uses extension data
214 stateless_validation->device_extensions = this->device_extensions;
215
216 VkPhysicalDeviceProperties device_properties = {};
217 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600218 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700219 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
220
221 if (device_extensions.vk_nv_shading_rate_image) {
222 // Get the needed shading rate image limits
223 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
224 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600225 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700226 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
227 }
228
229 if (device_extensions.vk_nv_mesh_shader) {
230 // Get the needed mesh shader limits
231 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
232 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600233 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700234 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
235 }
236
Jason Macnak5c954952019-07-09 15:46:12 -0700237 if (device_extensions.vk_nv_ray_tracing) {
238 // Get the needed ray tracing limits
239 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesNV>();
240 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
241 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500242 phys_dev_ext_props.ray_tracing_propsNV = ray_tracing_props;
243 }
244
sourav parmarcd5fb182020-07-17 12:58:44 -0700245 if (device_extensions.vk_khr_ray_tracing_pipeline) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500246 // Get the needed ray tracing limits
sourav parmarcd5fb182020-07-17 12:58:44 -0700247 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPipelinePropertiesKHR>();
Jeff Bolz443c2ca2020-03-19 12:11:51 -0500248 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
249 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
250 phys_dev_ext_props.ray_tracing_propsKHR = ray_tracing_props;
Jason Macnak5c954952019-07-09 15:46:12 -0700251 }
252
sourav parmarcd5fb182020-07-17 12:58:44 -0700253 if (device_extensions.vk_khr_acceleration_structure) {
254 // Get the needed ray tracing acc structure limits
255 auto acc_structure_props = lvl_init_struct<VkPhysicalDeviceAccelerationStructurePropertiesKHR>();
256 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&acc_structure_props);
257 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
258 phys_dev_ext_props.acc_structure_props = acc_structure_props;
259 }
260
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700261 if (device_extensions.vk_ext_transform_feedback) {
262 // Get the needed transform feedback limits
263 auto transform_feedback_props = lvl_init_struct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
264 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&transform_feedback_props);
265 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
266 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
267 }
268
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800269 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
270
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700271 // Save app-enabled features in this device's validation object
272 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Petr Kraus715bcc72019-08-15 17:17:33 +0200273 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
274 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
275 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
276 if (features2) {
277 tmp_features2_state.features = features2->features;
278 } else if (pCreateInfo->pEnabledFeatures) {
279 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700280 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200281 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700282 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200283 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700284 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200285 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700286}
287
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700288bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500289 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600290 bool skip = false;
291
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200292 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
293 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
294 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600295 }
296
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700297 // If this device supports VK_KHR_portability_subset, it must be enabled
298 const std::string portability_extension_name("VK_KHR_portability_subset");
299 const auto &dev_extensions = device_extensions_enumerated.at(physicalDevice);
300 const bool portability_supported = dev_extensions.count(portability_extension_name) != 0;
301 bool portability_requested = false;
302
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200303 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
304 skip |=
305 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
306 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
307 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
308 pCreateInfo->ppEnabledExtensionNames[i]);
Nathaniel Cesariob3f2d702020-11-09 09:20:49 -0700309 if (portability_extension_name == pCreateInfo->ppEnabledExtensionNames[i]) {
310 portability_requested = true;
311 }
312 }
313
314 if (portability_supported && !portability_requested) {
315 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-pProperties-04451",
316 "vkCreateDevice: VK_KHR_portability_subset must be enabled because physical device %s supports it",
317 report_data->FormatHandle(physicalDevice).c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600318 }
319
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200320 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700321 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
322 bool negative_viewport =
323 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200324 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700325 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
326 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
327 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200328 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600329 }
330
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600331 {
332 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
333 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
334 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700335 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
336 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
337 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600338 }
339 }
340
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600341 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
342 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600343 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
344 if (features2) {
345 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700346 skip |= LogError(device, "VUID-VkDeviceCreateInfo-pNext-00373",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700347 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
348 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600349 }
350 }
351
Locke77fad1c2019-04-16 13:09:03 -0600352 auto features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
Jeff Bolz165818a2020-05-08 11:19:03 -0500353 const VkPhysicalDeviceFeatures *features = features2 ? &features2->features : pCreateInfo->pEnabledFeatures;
354 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(pCreateInfo->pNext);
355 if (features && robustness2_features && robustness2_features->robustBufferAccess2 && !features->robustBufferAccess) {
356 skip |= LogError(device, "VUID-VkPhysicalDeviceRobustness2FeaturesEXT-robustBufferAccess2-04000",
357 "If robustBufferAccess2 is enabled then robustBufferAccess must be enabled.");
358 }
sourav parmarcd5fb182020-07-17 12:58:44 -0700359 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(pCreateInfo->pNext);
360 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplayMixed &&
361 !raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay) {
362 skip |= LogError(
363 device,
364 "VUID-VkPhysicalDeviceRayTracingPipelineFeaturesKHR-rayTracingPipelineShaderGroupHandleCaptureReplayMixed-03575",
365 "If rayTracingPipelineShaderGroupHandleCaptureReplayMixed is VK_TRUE, rayTracingPipelineShaderGroupHandleCaptureReplay "
366 "must also be VK_TRUE.");
sourav parmara24fb7b2020-05-26 10:50:04 -0700367 }
Locke77fad1c2019-04-16 13:09:03 -0600368 auto vertex_attribute_divisor_features =
369 lvl_find_in_chain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
Mark Lobodzinski3e66ae82020-08-12 16:27:29 -0600370 if (vertex_attribute_divisor_features && (!device_extensions.vk_ext_vertex_attribute_divisor)) {
371 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
372 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
373 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600374 }
375
Tony-LunarG28017bc2020-01-23 14:40:25 -0700376 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
377 if (vulkan_11_features) {
378 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
379 while (current) {
380 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
381 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
382 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
383 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
384 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
385 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700386 skip |= LogError(
387 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700388 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
389 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
390 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
391 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
392 break;
393 }
394 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
395 }
396 }
397
398 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
399 if (vulkan_12_features) {
400 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
401 while (current) {
402 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
403 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
404 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
405 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
406 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
407 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
408 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
409 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
410 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
411 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
412 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
413 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
414 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700415 skip |= LogError(
416 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700417 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
418 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
419 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
420 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
421 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
422 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
423 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
424 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
425 break;
426 }
427 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
428 }
sfricke-samsungabab4632020-05-04 06:51:46 -0700429 // Check features are enabled if matching extension is passed in as well
430 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
431 const char *extension = pCreateInfo->ppEnabledExtensionNames[i];
432 if ((0 == strncmp(extension, VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
433 (vulkan_12_features->drawIndirectCount == VK_FALSE)) {
434 skip |= LogError(
435 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02831",
436 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::drawIndirectCount is not VK_TRUE.",
437 VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);
438 }
439 if ((0 == strncmp(extension, VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
440 (vulkan_12_features->samplerMirrorClampToEdge == VK_FALSE)) {
441 skip |= LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02832",
442 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerMirrorClampToEdge "
443 "is not VK_TRUE.",
444 VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME);
445 }
446 if ((0 == strncmp(extension, VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
447 (vulkan_12_features->descriptorIndexing == VK_FALSE)) {
448 skip |= LogError(
449 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02833",
450 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::descriptorIndexing is not VK_TRUE.",
451 VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME);
452 }
453 if ((0 == strncmp(extension, VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
454 (vulkan_12_features->samplerFilterMinmax == VK_FALSE)) {
455 skip |= LogError(
456 instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02834",
457 "vkCreateDevice(): %s is enabled but VkPhysicalDeviceVulkan12Features::samplerFilterMinmax is not VK_TRUE.",
458 VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME);
459 }
460 if ((0 == strncmp(extension, VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, VK_MAX_EXTENSION_NAME_SIZE)) &&
461 ((vulkan_12_features->shaderOutputViewportIndex == VK_FALSE) ||
462 (vulkan_12_features->shaderOutputLayer == VK_FALSE))) {
463 skip |=
464 LogError(instance, "VUID-VkDeviceCreateInfo-ppEnabledExtensions-02835",
465 "vkCreateDevice(): %s is enabled but both VkPhysicalDeviceVulkan12Features::shaderOutputViewportIndex "
466 "and VkPhysicalDeviceVulkan12Features::shaderOutputLayer are not VK_TRUE.",
467 VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME);
468 }
469 }
Tony-LunarG28017bc2020-01-23 14:40:25 -0700470 }
471
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600472 // Validate pCreateInfo->pQueueCreateInfos
473 if (pCreateInfo->pQueueCreateInfos) {
474 std::unordered_set<uint32_t> set;
475
476 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700477 const VkDeviceQueueCreateInfo &queue_create_info = pCreateInfo->pQueueCreateInfos[i];
478 const uint32_t requested_queue_family = queue_create_info.queueFamilyIndex;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600479 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700480 skip |=
481 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
482 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
483 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
484 "index value.",
485 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600486 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700487 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
488 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
489 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
490 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600491 } else {
492 set.insert(requested_queue_family);
493 }
494
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700495 if (queue_create_info.pQueuePriorities != nullptr) {
496 for (uint32_t j = 0; j < queue_create_info.queueCount; ++j) {
497 const float queue_priority = queue_create_info.pQueuePriorities[j];
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600498 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700499 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
500 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
501 "] (=%f) is not between 0 and 1 (inclusive).",
502 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600503 }
504 }
505 }
sfricke-samsung590ae1e2020-04-25 01:18:05 -0700506
507 // Need to know if protectedMemory feature is passed in preCall to creating the device
508 VkBool32 protectedMemory = VK_FALSE;
509 const VkPhysicalDeviceProtectedMemoryFeatures *protected_features =
510 lvl_find_in_chain<VkPhysicalDeviceProtectedMemoryFeatures>(pCreateInfo->pNext);
511 if (protected_features) {
512 protectedMemory = protected_features->protectedMemory;
513 } else if (vulkan_11_features) {
514 protectedMemory = vulkan_11_features->protectedMemory;
515 }
516 if ((queue_create_info.flags == VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) && (protectedMemory == VK_FALSE)) {
517 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-flags-02861",
518 "vkCreateDevice: pCreateInfo->flags set to VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT without the "
519 "protectedMemory feature being set as well.");
520 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600521 }
522 }
523
sfricke-samsung30a57412020-05-15 21:14:54 -0700524 // feature dependencies for VK_KHR_variable_pointers
525 const auto *variable_pointers_features = lvl_find_in_chain<VkPhysicalDeviceVariablePointersFeatures>(pCreateInfo->pNext);
526 VkBool32 variablePointers = VK_FALSE;
527 VkBool32 variablePointersStorageBuffer = VK_FALSE;
528 if (vulkan_11_features) {
529 variablePointers = vulkan_11_features->variablePointers;
530 variablePointersStorageBuffer = vulkan_11_features->variablePointersStorageBuffer;
531 } else if (variable_pointers_features) {
532 variablePointers = variable_pointers_features->variablePointers;
533 variablePointersStorageBuffer = variable_pointers_features->variablePointersStorageBuffer;
534 }
535 if ((variablePointers == VK_TRUE) && (variablePointersStorageBuffer == VK_FALSE)) {
536 skip |= LogError(instance, "VUID-VkPhysicalDeviceVariablePointersFeatures-variablePointers-01431",
537 "If variablePointers is VK_TRUE then variablePointersStorageBuffer also needs to be VK_TRUE");
538 }
539
sfricke-samsungfd76c342020-05-29 23:13:43 -0700540 // feature dependencies for VK_KHR_multiview
541 const auto *multiview_features = lvl_find_in_chain<VkPhysicalDeviceMultiviewFeatures>(pCreateInfo->pNext);
542 VkBool32 multiview = VK_FALSE;
543 VkBool32 multiviewGeometryShader = VK_FALSE;
544 VkBool32 multiviewTessellationShader = VK_FALSE;
545 if (vulkan_11_features) {
546 multiview = vulkan_11_features->multiview;
547 multiviewGeometryShader = vulkan_11_features->multiviewGeometryShader;
548 multiviewTessellationShader = vulkan_11_features->multiviewTessellationShader;
549 } else if (multiview_features) {
550 multiview = multiview_features->multiview;
551 multiviewGeometryShader = multiview_features->multiviewGeometryShader;
552 multiviewTessellationShader = multiview_features->multiviewTessellationShader;
553 }
554 if ((multiview == VK_FALSE) && (multiviewGeometryShader == VK_TRUE)) {
555 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewGeometryShader-00580",
556 "If multiviewGeometryShader is VK_TRUE then multiview also needs to be VK_TRUE");
557 }
558 if ((multiview == VK_FALSE) && (multiviewTessellationShader == VK_TRUE)) {
559 skip |= LogError(instance, "VUID-VkPhysicalDeviceMultiviewFeatures-multiviewTessellationShader-00581",
560 "If multiviewTessellationShader is VK_TRUE then multiview also needs to be VK_TRUE");
561 }
562
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600563 return skip;
564}
565
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500566bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700567 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700568 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
569 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
570 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600571 }
572
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700573 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600574}
575
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700576bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500577 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100578 bool skip = false;
579
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600580 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700581 skip |=
582 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600583
584 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
585 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
586 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
587 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700588 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
589 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
590 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600591 }
592
593 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
594 // queueFamilyIndexCount uint32_t values
595 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700596 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
597 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
598 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
599 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600600 }
601 }
602
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700603 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
604 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00915",
605 "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the "
606 "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set.");
607 }
608
609 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!physical_device_features.sparseResidencyBuffer)) {
610 skip |=
611 LogError(device, "VUID-VkBufferCreateInfo-flags-00916",
612 "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with "
613 "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
614 }
615
616 if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
617 skip |=
618 LogError(device, "VUID-VkBufferCreateInfo-flags-00917",
619 "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with "
620 "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
621 }
622
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600623 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
624 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
625 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
626 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700627 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
628 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
629 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600630 }
631 }
632
633 return skip;
634}
635
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700636bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500637 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600638 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600639
640 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
642 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
643 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
644 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700645 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
646 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
647 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600648 }
649
650 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
651 // queueFamilyIndexCount uint32_t values
652 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700653 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
654 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
655 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
656 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600657 }
658 }
659
Dave Houlton413a6782018-05-22 13:01:54 -0600660 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700661 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600662 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700663 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600664 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700665 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600666
Dave Houlton413a6782018-05-22 13:01:54 -0600667 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700668 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600669 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700670 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600671
Dave Houlton130c0212018-01-29 13:39:56 -0700672 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700673 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
674 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700675 skip |= LogError(
676 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600677 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
678 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700679 }
680
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600681 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100682 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
683 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700684 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
685 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
686 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600687 }
688
689 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100690 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
691 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700692 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
693 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
694 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
695 ") are not equal.",
696 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100697 }
698
699 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700700 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
701 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
702 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
703 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100704 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600705 }
706
707 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700708 skip |= LogError(
709 device, "VUID-VkImageCreateInfo-imageType-00957",
710 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600711 }
712 }
713
Dave Houlton130c0212018-01-29 13:39:56 -0700714 // 3D image may have only 1 layer
715 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700716 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
717 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700718 }
719
Dave Houlton130c0212018-01-29 13:39:56 -0700720 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
721 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
722 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
723 // At least one of the legal attachment bits must be set
724 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700725 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
726 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700727 }
728 // No flags other than the legal attachment bits may be set
729 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
730 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700731 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
732 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700733 }
734 }
735
Jeff Bolzef40fec2018-09-01 22:04:34 -0500736 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600737 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500738 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -0600739 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
740 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500741 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600742 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700743 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
744 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
745 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600746 }
747
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600748 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700749 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
750 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
751 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600752 }
753
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700754 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700755 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
756 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
757 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100758 }
759
sfricke-samsung8f8cf052020-07-03 22:44:29 -0700760 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!physical_device_features.sparseResidencyAliased)) {
761 skip |= LogError(
762 device, "VUID-VkImageCreateInfo-flags-01924",
763 "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the "
764 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set.");
765 }
766
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600767 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
768 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
769 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
770 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700771 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
772 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
773 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600774 }
775
776 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
777 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
778 // Linear tiling is unsupported
779 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
sfricke-samsung9801d752020-08-23 22:00:16 -0700780 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-04121",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700781 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
782 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600783 }
784
785 // Sparse 1D image isn't valid
786 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700787 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
788 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600789 }
790
791 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700792 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700793 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
794 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
795 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600796 }
797
798 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700799 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700800 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
801 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
802 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600803 }
804
805 // Multi-sample 2D image when device doesn't support it
806 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700807 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600808 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700809 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
810 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
811 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700812 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600813 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700814 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
815 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
816 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700817 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600818 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700819 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
820 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
821 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700822 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600823 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700824 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
825 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
826 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600827 }
828 }
829 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500830
Jeff Bolz9af91c52018-09-01 21:53:57 -0500831 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
832 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700833 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
834 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
835 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500836 }
837 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700838 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
839 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
840 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500841 }
842 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700843 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
844 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
845 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500846 }
847 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500848
849 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600850 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700851 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
852 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
853 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500854 }
855
Dave Houlton142c4cb2018-10-17 15:04:41 -0600856 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700857 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
858 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
859 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
860 "not be a depth/stencil format.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500861 }
862
Dave Houlton142c4cb2018-10-17 15:04:41 -0600863 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700864 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
865 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
866 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
867 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500868 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600869 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700870 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
871 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
872 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
873 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500874 }
875 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500876
sfricke-samsung8f658d42020-05-03 20:12:24 -0700877 if (((pCreateInfo->flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) != 0) &&
878 (FormatHasDepth(pCreateInfo->format) == false)) {
879 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-01533",
880 "vkCreateImage(): if flags contain VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT the "
881 "format must be a depth or depth/stencil format.");
882 }
883
Andrew Fobel3abeb992020-01-20 16:33:22 -0500884 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pCreateInfo->pNext);
885 if (image_stencil_struct != nullptr) {
886 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
887 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
888 // No flags other than the legal attachment bits may be set
889 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
890 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700891 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
892 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
893 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
894 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500895 }
896 }
897
898 if (FormatIsDepthOrStencil(pCreateInfo->format)) {
899 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
900 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
901 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700902 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
903 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
904 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width exceeds device "
905 "maxFramebufferWidth");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500906 }
907
908 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
909 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700910 LogError(device, "VUID-VkImageCreateInfo-format-02537",
911 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
912 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height exceeds device "
913 "maxFramebufferHeight");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500914 }
915 }
916
917 if (!physical_device_features.shaderStorageImageMultisample &&
918 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
919 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
920 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700921 LogError(device, "VUID-VkImageCreateInfo-format-02538",
922 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
923 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
924 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500925 }
926
927 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
928 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700929 skip |= LogError(
930 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500931 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
932 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
933 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
934 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
935 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700936 skip |= LogError(
937 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500938 "vkCreateImage(): Depth-stencil image in which usage does not include "
939 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
940 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
941 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
942 }
943
944 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
945 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700946 skip |= LogError(
947 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500948 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
949 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
950 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
951 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
952 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700953 skip |= LogError(
954 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500955 "vkCreateImage(): Depth-stencil image in which usage does not include "
956 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
957 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
958 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
959 }
960 }
961 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -0700962
963 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
964 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
965 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
966 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
967 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
968 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -0700969
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -0700970 std::vector<uint64_t> image_create_drm_format_modifiers;
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -0700971 if (device_extensions.vk_ext_image_drm_format_modifier) {
972 const auto drm_format_mod_list = lvl_find_in_chain<VkImageDrmFormatModifierListCreateInfoEXT>(pCreateInfo->pNext);
973 const auto drm_format_mod_explict =
974 lvl_find_in_chain<VkImageDrmFormatModifierExplicitCreateInfoEXT>(pCreateInfo->pNext);
975 if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
976 if (((drm_format_mod_list != nullptr) && (drm_format_mod_explict != nullptr)) ||
977 ((drm_format_mod_list == nullptr) && (drm_format_mod_explict == nullptr))) {
978 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02261",
979 "vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have "
980 "either VkImageDrmFormatModifierListCreateInfoEXT or "
981 "VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain");
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -0700982 } else if (drm_format_mod_list != nullptr) {
983 image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
984 } else if (drm_format_mod_list != nullptr) {
985 for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {
986 image_create_drm_format_modifiers.push_back(*drm_format_mod_list->pDrmFormatModifiers);
987 }
Spencer Fricke6f8b8ac2020-04-06 07:36:50 -0700988 }
989 } else if ((drm_format_mod_list != nullptr) || (drm_format_mod_explict != nullptr)) {
990 skip |= LogError(device, "VUID-VkImageCreateInfo-pNext-02262",
991 "vkCreateImage(): Tiling is not VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but there is a "
992 "VkImageDrmFormatModifierListCreateInfoEXT or VkImageDrmFormatModifierExplicitCreateInfoEXT "
993 "in the pNext chain");
994 }
995 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +0200996
Mark Lobodzinski09b4caa2020-11-20 17:26:46 -0700997 static const uint64_t DRM_FORMAT_MOD_LINEAR = 0;
998 bool image_create_maybe_linear = false;
999 if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) {
1000 image_create_maybe_linear = true;
1001 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL) {
1002 image_create_maybe_linear = false;
1003 } else if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
1004 image_create_maybe_linear =
1005 (std::find(image_create_drm_format_modifiers.begin(), image_create_drm_format_modifiers.end(),
1006 DRM_FORMAT_MOD_LINEAR) != image_create_drm_format_modifiers.end());
1007 }
1008
1009 // If multi-sample, validate type, usage, tiling and mip levels.
1010 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1011 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1012 (pCreateInfo->mipLevels != 1) || image_create_maybe_linear)) {
1013 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
1014 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
1015 }
1016
1017 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT) &&
1018 ((pCreateInfo->mipLevels != 1) || (pCreateInfo->arrayLayers != 1) || (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) ||
1019 image_create_maybe_linear)) {
1020 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02259",
1021 "vkCreateImage(): Multi-device image with incompatible type, usage, tiling, or mips.");
1022 }
1023
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001024 if (pCreateInfo->usage & VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT) {
1025 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1026 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02557",
1027 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1028 "imageType must be VK_IMAGE_TYPE_2D.");
1029 }
1030 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1031 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02558",
1032 "vkCreateImage: if usage includes VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT, "
1033 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1034 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02001035 }
1036 if (pCreateInfo->flags & VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT) {
1037 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1038 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02565",
1039 "vkCreateImage: if usage includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1040 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1041 }
1042 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1043 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02566",
1044 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1045 "imageType must be VK_IMAGE_TYPE_2D.");
1046 }
1047 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
1048 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02567",
1049 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, "
1050 "flags must not include VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT.");
1051 }
1052 if (pCreateInfo->mipLevels != 1) {
1053 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02568",
1054 "vkCreateImage: if flags includes VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT, mipLevels (%d) must be 1.",
1055 pCreateInfo->mipLevels);
1056 }
1057 }
sfricke-samsungddaf72b2020-06-23 21:39:28 -07001058
1059 const auto swapchain_create_info = lvl_find_in_chain<VkImageSwapchainCreateInfoKHR>(pCreateInfo->pNext);
1060 if (swapchain_create_info != nullptr) {
1061 if (swapchain_create_info->swapchain != VK_NULL_HANDLE) {
1062 // All the following fall under the same VU that checks that the swapchain image uses parameters limited by the
1063 // table in #swapchain-wsi-image-create-info. Breaking up into multiple checks allows for more useful information
1064 // returned why this error occured. Check for matching Swapchain flags is done later in state tracking validation
1065 const char *vuid = "VUID-VkImageSwapchainCreateInfoKHR-swapchain-00995";
1066 const char *base_message = "vkCreateImage(): The image used for creating a presentable swapchain image";
1067
1068 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1069 // also implicitly forces the check above that extent.depth is 1
1070 skip |= LogError(device, vuid, "%s must have a imageType value VK_IMAGE_TYPE_2D instead of %s.", base_message,
1071 string_VkImageType(pCreateInfo->imageType));
1072 }
1073 if (pCreateInfo->mipLevels != 1) {
1074 skip |= LogError(device, vuid, "%s must have a mipLevels value of 1 instead of %u.", base_message,
1075 pCreateInfo->mipLevels);
1076 }
1077 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1078 skip |= LogError(device, vuid, "%s must have a samples value of VK_SAMPLE_COUNT_1_BIT instead of %s.",
1079 base_message, string_VkSampleCountFlagBits(pCreateInfo->samples));
1080 }
1081 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1082 skip |= LogError(device, vuid, "%s must have a tiling value of VK_IMAGE_TILING_OPTIMAL instead of %s.",
1083 base_message, string_VkImageTiling(pCreateInfo->tiling));
1084 }
1085 if (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) {
1086 skip |= LogError(device, vuid, "%s must have a initialLayout value of VK_IMAGE_LAYOUT_UNDEFINED instead of %s.",
1087 base_message, string_VkImageLayout(pCreateInfo->initialLayout));
1088 }
1089 const VkImageCreateFlags valid_flags =
1090 (VK_IMAGE_CREATE_SPLIT_INSTANCE_BIND_REGIONS_BIT | VK_IMAGE_CREATE_PROTECTED_BIT |
1091 VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT | VK_IMAGE_CREATE_EXTENDED_USAGE_BIT_KHR);
1092 if ((pCreateInfo->flags & ~valid_flags) != 0) {
1093 skip |= LogError(device, vuid, "%s flags are %" PRIu32 "and must only have valid flags set.", base_message,
1094 pCreateInfo->flags);
1095 }
1096 }
1097 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001098 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001099
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001100 return skip;
1101}
1102
Jeff Bolz99e3f632020-03-24 22:59:22 -05001103bool StatelessValidation::manual_PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo,
1104 const VkAllocationCallbacks *pAllocator, VkImageView *pView) const {
1105 bool skip = false;
1106
1107 if (pCreateInfo != nullptr) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001108 // Validate feature set if using CUBE_ARRAY
1109 if ((pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && (physical_device_features.imageCubeArray == false)) {
1110 skip |= LogError(pCreateInfo->image, "VUID-VkImageViewCreateInfo-viewType-01004",
1111 "vkCreateImageView(): pCreateInfo->viewType can't be VK_IMAGE_VIEW_TYPE_CUBE_ARRAY without "
1112 "enabling the imageCubeArray feature.");
1113 }
1114
Jeff Bolz99e3f632020-03-24 22:59:22 -05001115 if (pCreateInfo->subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) {
1116 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE && pCreateInfo->subresourceRange.layerCount != 6) {
1117 skip |= LogError(device, "VUID-VkImageViewCreateInfo-viewType-02960",
Spencer Fricke528e0982020-04-19 18:46:01 -07001118 "vkCreateImageView(): subresourceRange.layerCount (%d) must be 6 or VK_REMAINING_ARRAY_LAYERS.",
Jeff Bolz99e3f632020-03-24 22:59:22 -05001119 pCreateInfo->subresourceRange.layerCount);
1120 }
1121 if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY && (pCreateInfo->subresourceRange.layerCount % 6) != 0) {
Spencer Fricke528e0982020-04-19 18:46:01 -07001122 skip |= LogError(
1123 device, "VUID-VkImageViewCreateInfo-viewType-02961",
1124 "vkCreateImageView(): subresourceRange.layerCount (%d) must be a multiple of 6 or VK_REMAINING_ARRAY_LAYERS.",
1125 pCreateInfo->subresourceRange.layerCount);
Jeff Bolz99e3f632020-03-24 22:59:22 -05001126 }
1127 }
sfricke-samsung0c4a06f2020-06-27 01:24:32 -07001128
1129 auto astc_decode_mode = lvl_find_in_chain<VkImageViewASTCDecodeModeEXT>(pCreateInfo->pNext);
1130 if ((device_extensions.vk_ext_astc_decode_mode) && (astc_decode_mode != nullptr)) {
1131 if ((astc_decode_mode->decodeMode != VK_FORMAT_R16G16B16A16_SFLOAT) &&
1132 (astc_decode_mode->decodeMode != VK_FORMAT_R8G8B8A8_UNORM) &&
1133 (astc_decode_mode->decodeMode != VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)) {
1134 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-decodeMode-02230",
1135 "vkCreateImageView(): VkImageViewASTCDecodeModeEXT::decodeMode must be "
1136 "VK_FORMAT_R16G16B16A16_SFLOAT, VK_FORMAT_R8G8B8A8_UNORM, or VK_FORMAT_E5B9G9R9_UFLOAT_PACK32.");
1137 }
1138 if (FormatIsCompressed_ASTC(pCreateInfo->format) == false) {
1139 skip |= LogError(device, "VUID-VkImageViewASTCDecodeModeEXT-format-04084",
1140 "vkCreateImageView(): is using a VkImageViewASTCDecodeModeEXT but the image view format is %s and "
1141 "not an ASTC format.",
1142 string_VkFormat(pCreateInfo->format));
1143 }
1144 }
sfricke-samsung83d98122020-07-04 06:21:15 -07001145
1146 auto ycbcr_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
1147 if (ycbcr_conversion != nullptr) {
1148 if (ycbcr_conversion->conversion != VK_NULL_HANDLE) {
1149 if (IsIdentitySwizzle(pCreateInfo->components) == false) {
1150 skip |= LogError(
1151 device, "VUID-VkImageViewCreateInfo-pNext-01970",
1152 "vkCreateImageView(): If there is a VkSamplerYcbcrConversion, the imageView must "
1153 "be created with the identity swizzle. Here are the actual swizzle values:\n"
1154 "r swizzle = %s\n"
1155 "g swizzle = %s\n"
1156 "b swizzle = %s\n"
1157 "a swizzle = %s\n",
1158 string_VkComponentSwizzle(pCreateInfo->components.r), string_VkComponentSwizzle(pCreateInfo->components.g),
1159 string_VkComponentSwizzle(pCreateInfo->components.b), string_VkComponentSwizzle(pCreateInfo->components.a));
1160 }
1161 }
1162 }
Jeff Bolz99e3f632020-03-24 22:59:22 -05001163 }
1164 return skip;
1165}
1166
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001167bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001168 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001169 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001170
1171 // Note: for numerical correctness
1172 // - float comparisons should expect NaN (comparison always false).
1173 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1174
1175 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001176 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001177 if (v1_f <= 0.0f) return true;
1178
1179 float intpart;
1180 const float fract = modff(v1_f, &intpart);
1181
1182 assert(std::numeric_limits<float>::radix == 2);
1183 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1184 if (intpart >= u32_max_plus1) return false;
1185
1186 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1187 if (v1_u32 < v2_u32)
1188 return true;
1189 else if (v1_u32 == v2_u32 && fract == 0.0f)
1190 return true;
1191 else
1192 return false;
1193 };
1194
1195 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1196 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1197 return (v1_f <= v2_f);
1198 };
1199
1200 // width
1201 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001202 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001203
1204 if (!(viewport.width > 0.0f)) {
1205 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001206 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
1207 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001208 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1209 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001210 skip |= LogError(object, "VUID-VkViewport-width-01771",
1211 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1212 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001213 }
1214
1215 // height
1216 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -07001217 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001218 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +01001219
1220 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1221 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001222 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
1223 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001224 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1225 height_healthy = false;
1226
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001227 skip |= LogError(object, "VUID-VkViewport-height-01773",
1228 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1229 ").",
1230 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001231 }
1232
1233 // x
1234 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001235 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001236 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001237 skip |= LogError(object, "VUID-VkViewport-x-01774",
1238 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1239 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001240 }
1241
1242 // x + width
1243 if (x_healthy && width_healthy) {
1244 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001245 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001246 skip |= LogError(
1247 object, "VUID-VkViewport-x-01232",
1248 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1249 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
1250 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001251 }
1252 }
1253
1254 // y
1255 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001256 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001257 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001258 skip |= LogError(object, "VUID-VkViewport-y-01775",
1259 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1260 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001261 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001262 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001263 skip |= LogError(object, "VUID-VkViewport-y-01776",
1264 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
1265 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001266 }
1267
1268 // y + height
1269 if (y_healthy && height_healthy) {
1270 const float boundary = viewport.y + viewport.height;
1271
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001272 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001273 skip |= LogError(object, "VUID-VkViewport-y-01233",
1274 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1275 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
1276 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001277 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001278 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001279 LogError(object, "VUID-VkViewport-y-01777",
1280 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
1281 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
1282 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001283 }
1284 }
1285
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001286 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +01001287 // minDepth
1288 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001289 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001290
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001291 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
1292 "[0.0, 1.0] range.",
1293 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001294 }
1295
1296 // maxDepth
1297 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001298 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001299
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001300 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
1301 "[0.0, 1.0] range.",
1302 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001303 }
1304 }
1305
1306 return skip;
1307}
1308
Dave Houlton142c4cb2018-10-17 15:04:41 -06001309struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001310 VkShadingRatePaletteEntryNV shadingRate;
1311 uint32_t width;
1312 uint32_t height;
1313};
1314
1315// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -06001316static SampleOrderInfo sampleOrderInfos[] = {
1317 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1318 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1319 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1320 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1321 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1322 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001323};
1324
Jeff Bolz46c0ea02019-10-09 13:06:29 -05001325bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001326 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001327
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001328 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001329 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001330 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001331 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001332 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001333 break;
1334 }
1335 }
1336
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001337 if (sampleOrderInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001338 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1339 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1340 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001341 return skip;
1342 }
1343
Dave Houlton142c4cb2018-10-17 15:04:41 -06001344 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001345 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001346 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1347 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1348 ") must "
1349 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1350 "is set in framebufferNoAttachmentsSampleCounts.",
1351 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001352 }
1353
Jeff Bolz9af91c52018-09-01 21:53:57 -05001354 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001355 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1356 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1357 ") must "
1358 "be equal to the product of sampleCount (=%" PRIu32
1359 "), the fragment width for shadingRate "
1360 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1361 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001362 }
1363
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001364 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001365 skip |= LogError(
1366 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001367 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1368 ") must "
1369 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001370 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001371 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001372
1373 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001374 // the first width*height*sampleCount bits to all be set. Note: There is no
1375 // guarantee that 64 bits is enough, but practically it's unlikely for an
1376 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001377 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001378 uint64_t sampleLocationsMask = 0;
1379 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1380 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1381 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001382 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1383 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001384 }
1385 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001386 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1387 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001388 }
1389 if (sampleLoc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001390 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
1391 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001392 }
1393 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1394 sampleLocationsMask |= 1ULL << idx;
1395 }
1396
1397 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1398 if (sampleLocationsMask != expectedMask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001399 skip |= LogError(
1400 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001401 "The array pSampleLocations must contain exactly one entry for "
1402 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001403 }
1404
1405 return skip;
1406}
1407
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001408bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
1409 uint32_t createInfoCount,
1410 const VkGraphicsPipelineCreateInfo *pCreateInfos,
1411 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05001412 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001413 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001414
1415 if (pCreateInfos != nullptr) {
1416 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001417 bool has_dynamic_viewport = false;
1418 bool has_dynamic_scissor = false;
1419 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001420 bool has_dynamic_depth_bias = false;
1421 bool has_dynamic_blend_constant = false;
1422 bool has_dynamic_depth_bounds = false;
1423 bool has_dynamic_stencil_compare = false;
1424 bool has_dynamic_stencil_write = false;
1425 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001426 bool has_dynamic_viewport_w_scaling_nv = false;
1427 bool has_dynamic_discard_rectangle_ext = false;
1428 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001429 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001430 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001431 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001432 bool has_dynamic_line_stipple = false;
Piers Daniell39842ee2020-07-10 16:42:33 -06001433 bool has_dynamic_cull_mode = false;
1434 bool has_dynamic_front_face = false;
1435 bool has_dynamic_primitive_topology = false;
1436 bool has_dynamic_viewport_with_count = false;
1437 bool has_dynamic_scissor_with_count = false;
1438 bool has_dynamic_vertex_input_binding_stride = false;
1439 bool has_dynamic_depth_test_enable = false;
1440 bool has_dynamic_depth_write_enable = false;
1441 bool has_dynamic_depth_compare_op = false;
1442 bool has_dynamic_depth_bounds_test_enable = false;
1443 bool has_dynamic_stencil_test_enable = false;
1444 bool has_dynamic_stencil_op = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07001445 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
1446 skip |=
1447 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-03377",
1448 "vkCreateGraphicsPipelines: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR");
1449 }
Petr Kraus299ba622017-11-24 03:09:03 +01001450 if (pCreateInfos[i].pDynamicState != nullptr) {
1451 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1452 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1453 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001454 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1455 if (has_dynamic_viewport == true) {
1456 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1457 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1458 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1459 i);
1460 }
1461 has_dynamic_viewport = true;
1462 }
1463 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1464 if (has_dynamic_scissor == true) {
1465 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1466 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1467 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1468 i);
1469 }
1470 has_dynamic_scissor = true;
1471 }
1472 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1473 if (has_dynamic_line_width == true) {
1474 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1475 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1476 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1477 i);
1478 }
1479 has_dynamic_line_width = true;
1480 }
1481 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1482 if (has_dynamic_depth_bias == true) {
1483 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1484 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1485 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1486 i);
1487 }
1488 has_dynamic_depth_bias = true;
1489 }
1490 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1491 if (has_dynamic_blend_constant == true) {
1492 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1493 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1494 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1495 i);
1496 }
1497 has_dynamic_blend_constant = true;
1498 }
1499 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1500 if (has_dynamic_depth_bounds == true) {
1501 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1502 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1503 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1504 i);
1505 }
1506 has_dynamic_depth_bounds = true;
1507 }
1508 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1509 if (has_dynamic_stencil_compare == true) {
1510 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1511 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1512 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1513 i);
1514 }
1515 has_dynamic_stencil_compare = true;
1516 }
1517 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1518 if (has_dynamic_stencil_write == true) {
1519 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1520 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1521 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1522 i);
1523 }
1524 has_dynamic_stencil_write = true;
1525 }
1526 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1527 if (has_dynamic_stencil_reference == true) {
1528 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1529 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1530 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1531 i);
1532 }
1533 has_dynamic_stencil_reference = true;
1534 }
1535 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1536 if (has_dynamic_viewport_w_scaling_nv == true) {
1537 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1538 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1539 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1540 i);
1541 }
1542 has_dynamic_viewport_w_scaling_nv = true;
1543 }
1544 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1545 if (has_dynamic_discard_rectangle_ext == true) {
1546 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1547 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1548 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1549 i);
1550 }
1551 has_dynamic_discard_rectangle_ext = true;
1552 }
1553 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1554 if (has_dynamic_sample_locations_ext == true) {
1555 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1556 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1557 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1558 i);
1559 }
1560 has_dynamic_sample_locations_ext = true;
1561 }
1562 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1563 if (has_dynamic_exclusive_scissor_nv == true) {
1564 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1565 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1566 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1567 i);
1568 }
1569 has_dynamic_exclusive_scissor_nv = true;
1570 }
1571 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1572 if (has_dynamic_shading_rate_palette_nv == true) {
1573 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1574 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1575 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1576 i);
1577 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001578 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001579 }
1580 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1581 if (has_dynamic_viewport_course_sample_order_nv == true) {
1582 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1583 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1584 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1585 i);
1586 }
1587 has_dynamic_viewport_course_sample_order_nv = true;
1588 }
1589 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1590 if (has_dynamic_line_stipple == true) {
1591 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1592 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1593 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1594 i);
1595 }
1596 has_dynamic_line_stipple = true;
1597 }
Piers Daniell39842ee2020-07-10 16:42:33 -06001598 if (dynamic_state == VK_DYNAMIC_STATE_CULL_MODE_EXT) {
1599 if (has_dynamic_cull_mode) {
1600 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1601 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_CULL_MODE_EXT was listed twice in the "
1602 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1603 i);
1604 }
1605 has_dynamic_cull_mode = true;
1606 }
1607 if (dynamic_state == VK_DYNAMIC_STATE_FRONT_FACE_EXT) {
1608 if (has_dynamic_front_face) {
1609 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1610 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_FRONT_FACE_EXT was listed twice in the "
1611 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1612 i);
1613 }
1614 has_dynamic_front_face = true;
1615 }
1616 if (dynamic_state == VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT) {
1617 if (has_dynamic_primitive_topology) {
1618 skip |= LogError(
1619 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1620 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_PRIMITIVE_TOPOLOGY_EXT was listed twice in the "
1621 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1622 i);
1623 }
1624 has_dynamic_primitive_topology = true;
1625 }
1626 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT) {
1627 if (has_dynamic_viewport_with_count) {
1628 skip |= LogError(
1629 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1630 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT was listed twice in the "
1631 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1632 i);
1633 }
1634 has_dynamic_viewport_with_count = true;
1635 }
1636 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT) {
1637 if (has_dynamic_scissor_with_count) {
1638 skip |= LogError(
1639 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1640 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT was listed twice in the "
1641 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1642 i);
1643 }
1644 has_dynamic_scissor_with_count = true;
1645 }
1646 if (dynamic_state == VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT) {
1647 if (has_dynamic_vertex_input_binding_stride) {
1648 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1649 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT was "
1650 "listed twice in the "
1651 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1652 i);
1653 }
1654 has_dynamic_vertex_input_binding_stride = true;
1655 }
1656 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT) {
1657 if (has_dynamic_depth_test_enable) {
1658 skip |= LogError(
1659 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1660 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_TEST_ENABLE_EXT was listed twice in the "
1661 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1662 i);
1663 }
1664 has_dynamic_depth_test_enable = true;
1665 }
1666 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT) {
1667 if (has_dynamic_depth_write_enable) {
1668 skip |= LogError(
1669 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1670 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_WRITE_ENABLE_EXT was listed twice in the "
1671 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1672 i);
1673 }
1674 has_dynamic_depth_write_enable = true;
1675 }
1676 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT) {
1677 if (has_dynamic_depth_compare_op) {
1678 skip |=
1679 LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1680 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_COMPARE_OP_EXT was listed twice in the "
1681 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1682 i);
1683 }
1684 has_dynamic_depth_compare_op = true;
1685 }
1686 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT) {
1687 if (has_dynamic_depth_bounds_test_enable) {
1688 skip |= LogError(
1689 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1690 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS_TEST_ENABLE_EXT was listed twice in the "
1691 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1692 i);
1693 }
1694 has_dynamic_depth_bounds_test_enable = true;
1695 }
1696 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT) {
1697 if (has_dynamic_stencil_test_enable) {
1698 skip |= LogError(
1699 device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1700 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT was listed twice in the "
1701 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1702 i);
1703 }
1704 has_dynamic_stencil_test_enable = true;
1705 }
1706 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_OP_EXT) {
1707 if (has_dynamic_stencil_op) {
1708 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1709 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_OP_EXT was listed twice in the "
1710 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1711 i);
1712 }
1713 has_dynamic_stencil_op = true;
1714 }
Petr Kraus299ba622017-11-24 03:09:03 +01001715 }
1716 }
1717
Peter Chen85366392019-05-14 15:20:11 -04001718 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
1719 if ((feedback_struct != nullptr) &&
1720 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001721 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1722 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1723 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1724 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1725 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001726 }
1727
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001728 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001729
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001730 // Collect active stages and other information
1731 // Only want to loop through pStages once
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001732 uint32_t active_shaders = 0;
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001733 bool has_eval = false;
1734 bool has_control = false;
1735 if (pCreateInfos[i].pStages != nullptr) {
1736 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1737 active_shaders |= pCreateInfos[i].pStages[stage_index].stage;
1738
1739 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1740 has_control = true;
1741 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1742 has_eval = true;
1743 }
1744
1745 skip |= validate_string(
1746 "vkCreateGraphicsPipelines",
1747 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, stage_index}),
1748 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[stage_index].pName);
1749 }
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001750 }
1751
1752 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1753 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1754 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1755 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1756 pCreateInfos[i].pTessellationState,
1757 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1758 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1759
1760 const VkStructureType allowed_structs_VkPipelineTessellationStateCreateInfo[] = {
1761 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1762
1763 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1764 "VkPipelineTessellationDomainOriginStateCreateInfo",
1765 pCreateInfos[i].pTessellationState->pNext,
1766 ARRAY_SIZE(allowed_structs_VkPipelineTessellationStateCreateInfo),
1767 allowed_structs_VkPipelineTessellationStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001768 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1769 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001770
1771 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1772 pCreateInfos[i].pTessellationState->flags,
1773 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1774 }
1775
1776 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1777 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1778 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1779 pCreateInfos[i].pInputAssemblyState,
1780 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1781 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1782
1783 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1784 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001785 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001786
1787 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1788 pCreateInfos[i].pInputAssemblyState->flags,
1789 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1790
1791 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1792 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1793 pCreateInfos[i].pInputAssemblyState->topology,
1794 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1795
1796 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1797 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1798 }
1799
1800 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001801 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001802
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001803 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001804 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1805 "vkCreateGraphicsPipelines: pararameter "
1806 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1807 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001808 }
1809
1810 const VkStructureType allowed_structs_VkPipelineVertexInputStateCreateInfo[] = {
1811 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1812 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1813 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1814 pCreateInfos[i].pVertexInputState->pNext, 1,
1815 allowed_structs_VkPipelineVertexInputStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001816 "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
1817 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001818 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1819 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001820 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001821 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1822 skip |=
1823 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1824 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1825 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1826 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1827 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1828
1829 skip |= validate_array(
1830 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1831 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1832 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1833 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1834
1835 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
1836 for (uint32_t vertexBindingDescriptionIndex = 0;
1837 vertexBindingDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1838 ++vertexBindingDescriptionIndex) {
1839 skip |= validate_ranged_enum(
1840 "vkCreateGraphicsPipelines",
1841 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1842 AllVkVertexInputRateEnums,
1843 pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[vertexBindingDescriptionIndex].inputRate,
1844 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1845 }
1846 }
1847
1848 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
1849 for (uint32_t vertexAttributeDescriptionIndex = 0;
1850 vertexAttributeDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1851 ++vertexAttributeDescriptionIndex) {
1852 skip |= validate_ranged_enum(
1853 "vkCreateGraphicsPipelines",
1854 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1855 AllVkFormatEnums,
1856 pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[vertexAttributeDescriptionIndex].format,
1857 "VUID-VkVertexInputAttributeDescription-format-parameter");
1858 }
1859 }
1860
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001861 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001862 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1863 "vkCreateGraphicsPipelines: pararameter "
1864 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1865 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1866 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001867 }
1868
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001869 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001870 skip |=
1871 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1872 "vkCreateGraphicsPipelines: pararameter "
1873 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1874 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1875 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001876 }
1877
1878 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001879 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1880 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001881 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1882 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001883 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1884 "vkCreateGraphicsPipelines: parameter "
1885 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1886 "(%" PRIu32 ") is not distinct.",
1887 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001888 }
1889 vertex_bindings.insert(vertex_bind_desc.binding);
1890
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001891 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001892 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1893 "vkCreateGraphicsPipelines: parameter "
1894 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1895 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1896 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001897 }
1898
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001899 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001900 skip |=
1901 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1902 "vkCreateGraphicsPipelines: parameter "
1903 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1904 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1905 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001906 }
1907 }
1908
Peter Kohautc7d9d392018-07-15 00:34:07 +02001909 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001910 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1911 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001912 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1913 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001914 skip |= LogError(
1915 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001916 "vkCreateGraphicsPipelines: parameter "
1917 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1918 i, d, vertex_attrib_desc.location);
1919 }
1920 attribute_locations.insert(vertex_attrib_desc.location);
1921
1922 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1923 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001924 skip |= LogError(
1925 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001926 "vkCreateGraphicsPipelines: parameter "
1927 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1928 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1929 i, d, vertex_attrib_desc.binding, i);
1930 }
1931
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001932 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001933 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
1934 "vkCreateGraphicsPipelines: parameter "
1935 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
1936 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1937 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001938 }
1939
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001940 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001941 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
1942 "vkCreateGraphicsPipelines: parameter "
1943 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
1944 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1945 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001946 }
1947
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001948 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001949 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
1950 "vkCreateGraphicsPipelines: parameter "
1951 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1952 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1953 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001954 }
1955 }
1956 }
1957
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001958 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1959 if (has_control && has_eval) {
1960 if (pCreateInfos[i].pTessellationState == nullptr) {
1961 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
1962 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1963 "shader stage and a tessellation evaluation shader stage, "
1964 "pCreateInfos[%d].pTessellationState must not be NULL.",
1965 i, i);
1966 } else {
1967 const VkStructureType allowed_type = VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
1968 skip |= validate_struct_pnext(
1969 "vkCreateGraphicsPipelines",
1970 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
1971 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
1972 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
1973 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001974
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001975 skip |= validate_reserved_flags(
1976 "vkCreateGraphicsPipelines",
1977 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
1978 pCreateInfos[i].pTessellationState->flags, "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001979
Spencer Frickef1b0a7d2020-03-16 17:38:55 -07001980 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1981 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
1982 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
1983 "vkCreateGraphicsPipelines: invalid parameter "
1984 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
1985 "should be >0 and <=%u.",
1986 i, pCreateInfos[i].pTessellationState->patchControlPoints,
1987 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001988 }
1989 }
1990 }
1991
1992 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1993 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1994 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1995 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001996 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
1997 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1998 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
1999 "].pViewportState (=NULL) is not a valid pointer.",
2000 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002001 } else {
Petr Krausa6103552017-11-16 21:21:58 +01002002 const auto &viewport_state = *pCreateInfos[i].pViewportState;
2003
2004 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002005 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
2006 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2007 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
2008 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002009 }
2010
Petr Krausa6103552017-11-16 21:21:58 +01002011 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
2012 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002013 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
2014 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05002015 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
2016 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05002017 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002018 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002019 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01002020 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05002021 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05002022 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
2023 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01002024 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
sfricke-samsung32a27362020-02-28 09:06:42 -08002025 allowed_structs_VkPipelineViewportStateCreateInfo, 65, "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
2026 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002027
2028 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002029 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002030 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002031 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002032
Dave Houlton142c4cb2018-10-17 15:04:41 -06002033 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
2034 pCreateInfos[i].pViewportState->pNext);
2035 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
2036 pCreateInfos[i].pViewportState->pNext);
2037 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
2038 pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01002039 const auto vp_swizzle_struct =
2040 lvl_find_in_chain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002041 const auto vp_w_scaling_struct =
2042 lvl_find_in_chain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002043
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002044 if (!physical_device_features.multiViewport) {
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002045 if (!has_dynamic_viewport_with_count && (viewport_state.viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002046 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
2047 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2048 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
2049 ") is not 1.",
2050 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002051 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002052
Mark Lobodzinski8b9ddab2020-10-15 14:38:43 -06002053 if (!has_dynamic_scissor_with_count && (viewport_state.scissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002054 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
2055 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2056 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
2057 ") is not 1.",
2058 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002059 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002060
Dave Houlton142c4cb2018-10-17 15:04:41 -06002061 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
2062 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002063 skip |= LogError(
2064 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
2065 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2066 "disabled, but pCreateInfos[%" PRIu32
2067 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
2068 ") is not 1.",
2069 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002070 }
2071
Jeff Bolz9af91c52018-09-01 21:53:57 -05002072 if (shading_rate_image_struct &&
2073 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002074 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
2075 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
2076 "disabled, but pCreateInfos[%" PRIu32
2077 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
2078 ") is neither 0 nor 1.",
2079 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002080 }
2081
Petr Krausa6103552017-11-16 21:21:58 +01002082 } else { // multiViewport enabled
2083 if (viewport_state.viewportCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002084 if (!has_dynamic_viewport_with_count) {
2085 skip |= LogError(
2086 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
2087 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
2088 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002089 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002090 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
2091 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2092 "].pViewportState->viewportCount (=%" PRIu32
2093 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2094 i, viewport_state.viewportCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002095 } else if (has_dynamic_viewport_with_count) {
2096 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03379",
2097 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2098 "].pViewportState->viewportCount (=%" PRIu32
2099 ") must be zero when VK_DYNAMIC_STATE_VIEWPORT_WITH_COUNT_EXT is used.",
2100 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002101 }
Petr Krausa6103552017-11-16 21:21:58 +01002102
2103 if (viewport_state.scissorCount == 0) {
Piers Daniell39842ee2020-07-10 16:42:33 -06002104 if (!has_dynamic_scissor_with_count) {
2105 skip |= LogError(
2106 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
2107 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
2108 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002109 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002110 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
2111 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2112 "].pViewportState->scissorCount (=%" PRIu32
2113 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2114 i, viewport_state.scissorCount, device_limits.maxViewports);
Piers Daniell39842ee2020-07-10 16:42:33 -06002115 } else if (has_dynamic_scissor_with_count) {
2116 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-03380",
2117 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2118 "].pViewportState->scissorCount (=%" PRIu32
2119 ") must be zero when VK_DYNAMIC_STATE_SCISSOR_WITH_COUNT_EXT is used.",
2120 i, viewport_state.viewportCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002121 }
2122 }
2123
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002124 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002125 skip |=
2126 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
2127 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2128 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2129 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002130 }
2131
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002132 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002133 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
2134 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2135 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2136 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2137 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002138 }
2139
Piers Daniell39842ee2020-07-10 16:42:33 -06002140 if (viewport_state.scissorCount != viewport_state.viewportCount &&
2141 !(has_dynamic_viewport_with_count || has_dynamic_scissor_with_count)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002142 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
2143 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2144 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
2145 "].pViewportState->viewportCount (=%" PRIu32 ").",
2146 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01002147 }
2148
Dave Houlton142c4cb2018-10-17 15:04:41 -06002149 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05002150 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002151 skip |=
2152 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
2153 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
2154 ") must be zero or identical to pCreateInfos[%" PRIu32
2155 "].pViewportState->viewportCount (=%" PRIu32 ").",
2156 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002157 }
2158
Dave Houlton142c4cb2018-10-17 15:04:41 -06002159 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05002160 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002161 skip |= LogError(
2162 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06002163 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
2164 "] "
2165 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
2166 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
2167 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002168 }
2169
Petr Krausa6103552017-11-16 21:21:58 +01002170 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002171 skip |= LogError(
2172 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01002173 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
2174 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002175 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
2176 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002177 }
2178
2179 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002180 skip |= LogError(
2181 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01002182 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
2183 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002184 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
2185 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01002186 }
2187
Jeff Bolz3e71f782018-08-29 23:15:45 -05002188 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002189 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
2190 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
2191 skip |=
Shannon McPherson24c13d12020-06-18 15:51:41 -06002192 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002193 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
2194 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
2195 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
2196 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002197 }
2198
Jeff Bolz9af91c52018-09-01 21:53:57 -05002199 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06002200 shading_rate_image_struct->viewportCount > 0 &&
2201 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002202 skip |= LogError(
Shannon McPherson24c13d12020-06-18 15:51:41 -06002203 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002204 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06002205 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
2206 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05002207 i, i);
2208 }
2209
Chris Mayer328d8212018-12-11 14:16:18 +01002210 if (vp_swizzle_struct) {
2211 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002212 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
2213 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
2214 " does "
2215 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
2216 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01002217 }
2218 }
2219
Petr Krausb3fcdb42018-01-09 22:09:09 +01002220 // validate the VkViewports
2221 if (!has_dynamic_viewport && viewport_state.pViewports) {
2222 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
2223 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002224 const char *fn_name = "vkCreateGraphicsPipelines";
2225 skip |= manual_PreCallValidateViewport(viewport, fn_name,
2226 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
2227 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002228 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01002229 }
2230 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002231
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002232 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002233 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2234 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2235 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
2236 "VK_NV_clip_space_w_scaling extension is not enabled.",
2237 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002238 }
2239
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002240 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002241 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2242 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2243 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
2244 "VK_EXT_discard_rectangles extension is not enabled.",
2245 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002246 }
2247
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002248 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002249 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2250 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2251 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
2252 "VK_EXT_sample_locations extension is not enabled.",
2253 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07002254 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05002255
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002256 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002257 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
2258 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2259 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
2260 "VK_NV_scissor_exclusive extension is not enabled.",
2261 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05002262 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05002263
2264 if (coarse_sample_order_struct &&
2265 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
2266 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002267 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
2268 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2269 "] "
2270 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
2271 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
2272 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002273 }
2274
2275 if (coarse_sample_order_struct) {
2276 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002277 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05002278 }
2279 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002280
2281 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
2282 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002283 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
2284 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2285 "] "
2286 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
2287 ") "
2288 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
2289 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002290 }
2291 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002292 skip |= LogError(
2293 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02002294 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
2295 "] "
2296 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
2297 i);
2298 }
2299 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002300 }
2301
2302 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002303 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
2304 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
2305 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
2306 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002307 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07002308 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002309 LvlTypeMap<VkPipelineCoverageReductionStateCreateInfoNV>::kSType,
Dave Houltonb3bbec72018-01-17 10:13:33 -07002310 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
2311 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07002312 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07002313 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07002314 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002315 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002316 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07002317 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinski1ddf16f2020-08-13 08:58:13 -06002318 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 4, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08002319 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
2320 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002321
2322 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002323 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002324 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002325 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002326
2327 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002328 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002329 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2330 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2331
2332 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002333 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002334 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2335 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002336 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002337 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002338
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002339 skip |= validate_flags(
2340 "vkCreateGraphicsPipelines",
2341 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2342 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02002343 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002344
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002345 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002346 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002347 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2348 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2349
2350 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002351 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002352 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2353 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2354
2355 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002356 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002357 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2358 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2359 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002360 }
John Zulauf7acac592017-11-06 11:15:53 -07002361 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002362 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002363 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
2364 "vkCreateGraphicsPipelines(): parameter "
2365 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2366 i);
John Zulauf7acac592017-11-06 11:15:53 -07002367 }
2368 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2369 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2370 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002371 skip |= LogError(
2372 device,
2373
Dave Houlton413a6782018-05-22 13:01:54 -06002374 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002375 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002376 }
2377 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002378
2379 const auto *line_state = lvl_find_in_chain<VkPipelineRasterizationLineStateCreateInfoEXT>(
2380 pCreateInfos[i].pRasterizationState->pNext);
2381
2382 if (line_state) {
2383 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
2384 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
2385 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
2386 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002387 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2388 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2389 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
2390 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002391 }
2392 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
2393 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002394 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2395 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2396 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
2397 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002398 }
2399 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
2400 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002401 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
2402 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
2403 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
2404 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002405 }
2406 }
2407 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
2408 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
2409 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002410 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
2411 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
2412 "range [1,256].",
2413 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002414 }
2415 }
2416 const auto *line_features =
Tony-LunarG6c3c5452019-12-13 10:37:38 -07002417 lvl_find_in_chain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002418 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2419 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002420 skip |=
2421 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
2422 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2423 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
2424 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002425 }
2426 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2427 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002428 skip |=
2429 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
2430 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2431 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
2432 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002433 }
2434 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2435 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002436 skip |=
2437 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
2438 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2439 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
2440 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002441 }
2442 if (line_state->stippledLineEnable) {
2443 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
2444 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002445 skip |=
2446 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
2447 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2448 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
2449 "stippledRectangularLines feature.",
2450 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002451 }
2452 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
2453 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002454 skip |=
2455 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
2456 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2457 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
2458 "stippledBresenhamLines feature.",
2459 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002460 }
2461 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
2462 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002463 skip |=
2464 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
2465 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2466 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
2467 "stippledSmoothLines feature.",
2468 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002469 }
2470 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
2471 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002472 skip |=
2473 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
2474 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
2475 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
2476 "stippledRectangularLines and strictLines features.",
2477 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05002478 }
2479 }
2480 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002481 }
2482
Petr Krause91f7a12017-12-14 20:57:36 +01002483 bool uses_color_attachment = false;
2484 bool uses_depthstencil_attachment = false;
2485 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002486 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002487 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
2488 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01002489 const auto &subpasses_uses = subpasses_uses_it->second;
2490 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2491 uses_color_attachment = true;
2492 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2493 uses_depthstencil_attachment = true;
2494 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07002495 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01002496 }
2497
2498 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002499 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002500 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002501 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002502 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002503 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002504
2505 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002506 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002507 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002508 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002509
2510 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002511 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002512 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2513 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2514
2515 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002516 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002517 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2518 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2519
2520 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002521 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002522 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2523 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002524 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002525
2526 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002527 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002528 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2529 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2530
2531 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002532 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002533 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2534 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2535
2536 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002537 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002538 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2539 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002540 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002541
2542 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002543 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002544 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2545 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002546 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002547
2548 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002549 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002550 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2551 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002552 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002553
2554 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002555 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002556 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2557 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002558 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002559
2560 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002561 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002562 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2563 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002564 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002565
2566 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002567 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002568 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2569 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002570 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002571
2572 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002573 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002574 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2575 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002576 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002577
2578 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002579 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002580 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2581 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002582 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002583
2584 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002585 skip |= LogError(device, "VUID-VkPipelineDepthStencilStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002586 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2587 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2588 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002589 }
2590 }
2591
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002592 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2593 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2594
Petr Krause91f7a12017-12-14 20:57:36 +01002595 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002596 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2597 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2598 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2599 pCreateInfos[i].pColorBlendState,
2600 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2601 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2602
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002603 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002604 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002605 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2606 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2607 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002608 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002609 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2610 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002611
2612 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002613 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002614 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002615 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002616
2617 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002618 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002619 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2620 pCreateInfos[i].pColorBlendState->logicOpEnable);
2621
2622 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002623 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002624 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2625 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002626 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002627 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002628
2629 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2630 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2631 ++attachmentIndex) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002632 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002633 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2634 ParameterName::IndexVector{i, attachmentIndex}),
2635 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2636
2637 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002638 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002639 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2640 ParameterName::IndexVector{i, attachmentIndex}),
2641 "VkBlendFactor", AllVkBlendFactorEnums,
2642 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002643 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002644
2645 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002646 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002647 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2648 ParameterName::IndexVector{i, attachmentIndex}),
2649 "VkBlendFactor", AllVkBlendFactorEnums,
2650 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002651 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002652
2653 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002654 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002655 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2656 ParameterName::IndexVector{i, attachmentIndex}),
2657 "VkBlendOp", AllVkBlendOpEnums,
2658 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002659 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002660
2661 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002662 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002663 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2664 ParameterName::IndexVector{i, attachmentIndex}),
2665 "VkBlendFactor", AllVkBlendFactorEnums,
2666 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002667 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002668
2669 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002670 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002671 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2672 ParameterName::IndexVector{i, attachmentIndex}),
2673 "VkBlendFactor", AllVkBlendFactorEnums,
2674 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002675 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002676
2677 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002678 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002679 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2680 ParameterName::IndexVector{i, attachmentIndex}),
2681 "VkBlendOp", AllVkBlendOpEnums,
2682 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002683 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002684
2685 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002686 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002687 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2688 ParameterName::IndexVector{i, attachmentIndex}),
2689 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2690 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002691 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002692 }
2693 }
2694
2695 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
sfricke-samsung81c56f72020-08-23 22:14:41 -07002696 skip |= LogError(device, "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002697 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2698 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2699 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002700 }
2701
2702 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2703 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2704 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002705 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002706 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002707 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2708 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002709 }
2710 }
2711 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002712
Petr Kraus9752aae2017-11-24 03:05:50 +01002713 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2714 if (pCreateInfos[i].basePipelineIndex != -1) {
2715 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002716 skip |=
2717 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002718 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineHandle, must be "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002719 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002720 "and pCreateInfos->basePipelineIndex is not -1.",
2721 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002722 }
2723 }
2724
Petr Kraus9752aae2017-11-24 03:05:50 +01002725 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2726 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002727 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002728 "vkCreateGraphicsPipelines parameter, pCreateInfos[%u]->basePipelineIndex, must be -1 if "
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002729 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002730 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.",
2731 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002732 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002733 } else {
Mike Schuchardte5c15cf2020-04-06 22:57:13 -07002734 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002735 skip |=
2736 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2737 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->basePipelineIndex (%d) must be a valid"
2738 "index into the pCreateInfos array, of size %d.",
2739 i, pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002740 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002741 }
2742 }
2743
sfricke-samsung898cf222020-05-15 23:10:19 -07002744 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) != 0) {
2745 skip |= LogError(
2746 device, "VUID-VkGraphicsPipelineCreateInfo-flags-00764",
2747 "vkCreateGraphicsPipelines parameter pCreateInfos[%u]->flags must not contain VK_PIPELINE_CREATE_DISPATCH_BASE",
2748 i);
2749 }
2750
Petr Kraus9752aae2017-11-24 03:05:50 +01002751 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002752 if (!device_extensions.vk_nv_fill_rectangle) {
2753 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2754 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002755 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2756 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2757 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2758 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002759 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2760 (physical_device_features.fillModeNonSolid == false)) {
sfricke-samsunga44586f2020-08-23 22:19:44 -07002761 skip |= LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002762 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002763 "pCreateInfos[%u]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2764 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2765 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002766 }
2767 } else {
2768 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2769 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2770 (physical_device_features.fillModeNonSolid == false)) {
2771 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002772 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2773 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
sfricke-samsunga470e0e2020-05-16 00:47:36 -07002774 "pCreateInfos[%u]->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2775 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.",
2776 i);
Chris Mayer840b2c42019-08-22 18:12:22 +02002777 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002778 }
Petr Kraus299ba622017-11-24 03:09:03 +01002779
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002780 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002781 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002782 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2783 "The line width state is static (pCreateInfos[%" PRIu32
2784 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2785 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2786 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2787 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002788 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002789 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002790 }
2791 }
2792
2793 return skip;
2794}
2795
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002796bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2797 uint32_t createInfoCount,
2798 const VkComputePipelineCreateInfo *pCreateInfos,
2799 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002800 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002801 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002802 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002803 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002804 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002805 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Peter Chen85366392019-05-14 15:20:11 -04002806 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
2807 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002808 skip |=
2809 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2810 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2811 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2812 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002813 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002814
2815 // Make sure compute stage is selected
2816 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002817 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2818 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2819 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002820 }
sourav parmarcd5fb182020-07-17 12:58:44 -07002821
2822 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
2823 skip |=
2824 LogError(device, "VUID-VkComputePipelineCreateInfo-flags-03370",
2825 "vkCreateComputePipelines(): flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR");
2826 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002827 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002828 return skip;
2829}
2830
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002831bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002832 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002833 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002834
2835 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002836 const auto &features = physical_device_features;
2837 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002838
John Zulauf71968502017-10-26 13:51:15 -06002839 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2840 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002841 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2842 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2843 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2844 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002845 }
2846
2847 // Anistropy cannot be enabled in sampler unless enabled as a feature
2848 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002849 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2850 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2851 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002852 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002853 }
John Zulauf71968502017-10-26 13:51:15 -06002854
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002855 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2856 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002857 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2858 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2859 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2860 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002861 }
2862 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002863 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2864 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2865 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2866 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002867 }
2868 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002869 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2870 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2871 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2872 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002873 }
2874 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2875 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2876 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2877 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002878 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2879 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2880 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2881 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2882 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2883 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002884 }
2885 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002886 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2887 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2888 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002889 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002890 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002891 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2892 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2893 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002894 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002895 }
2896
2897 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2898 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002899 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2900 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
sfricke-samsung85252fb2020-05-08 20:44:06 -07002901 const auto *sampler_reduction = lvl_find_in_chain<VkSamplerReductionModeCreateInfo>(pCreateInfo->pNext);
2902 if (sampler_reduction != nullptr) {
2903 if (sampler_reduction->reductionMode != VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE) {
2904 skip |= LogError(
2905 device, "VUID-VkSamplerCreateInfo-compareEnable-01423",
2906 "copmareEnable is true so the sampler reduction mode must be VK_SAMPLER_REDUCTION_MODE_WEIGHTED_AVERAGE.");
2907 }
2908 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002909 }
2910
2911 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2912 // valid VkBorderColor value
2913 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2914 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2915 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002916 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
2917 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002918 }
2919
2920 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2921 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002922 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002923 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2924 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2925 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002926 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002927 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
2928 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2929 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002930 }
John Zulauf275805c2017-10-26 15:34:49 -06002931
2932 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002933 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06002934 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2935 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002936 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
2937 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
2938 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002939 }
2940 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002941
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002942 // Check for valid Lod range
2943 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002944 skip |=
2945 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
2946 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002947 }
2948
2949 // Check mipLodBias to device limit
2950 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002951 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
2952 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
2953 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002954 }
2955
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002956 const auto *sampler_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
2957 if (sampler_conversion != nullptr) {
2958 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2959 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2960 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2961 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002962 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002963 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002964 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
2965 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
2966 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
2967 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
2968 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
2969 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
2970 }
2971 }
janharaldfredriksen-arm3b793772020-05-12 18:55:53 +02002972
2973 if (pCreateInfo->flags & VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT) {
2974 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2975 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02574",
2976 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2977 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2978 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2979 }
2980 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2981 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02575",
2982 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2983 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2984 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2985 }
2986 if (pCreateInfo->minLod != 0.0 || pCreateInfo->maxLod != 0.0) {
2987 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02576",
2988 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2989 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must be zero.",
2990 pCreateInfo->minLod, pCreateInfo->maxLod);
2991 }
2992 if (((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
2993 (pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) ||
2994 ((pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) &&
2995 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER))) {
2996 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02577",
2997 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
2998 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must be "
2999 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER",
3000 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
3001 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
3002 }
3003 if (pCreateInfo->anisotropyEnable) {
3004 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02578",
3005 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3006 "pCreateInfo->anisotropyEnable must be VK_FALSE");
3007 }
3008 if (pCreateInfo->compareEnable) {
3009 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02579",
3010 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3011 "pCreateInfo->compareEnable must be VK_FALSE");
3012 }
3013 if (pCreateInfo->unnormalizedCoordinates) {
3014 skip |= LogError(device, "VUID-VkSamplerCreateInfo-flags-02580",
3015 "vkCreateSampler(): when flags includes VK_SAMPLER_CREATE_SUBSAMPLED_BIT_EXT, "
3016 "pCreateInfo->unnormalizedCoordinates must be VK_FALSE");
3017 }
3018 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003019 }
3020
Tony-LunarG7337b312020-04-15 16:40:25 -06003021 if (pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT ||
3022 pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT) {
3023 if (!device_extensions.vk_ext_custom_border_color) {
3024 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
3025 "VkSamplerCreateInfo->borderColor is %s but %s is not enabled.\n",
3026 string_VkBorderColor(pCreateInfo->borderColor), VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
3027 }
3028 auto custom_create_info = lvl_find_in_chain<VkSamplerCustomBorderColorCreateInfoEXT>(pCreateInfo->pNext);
3029 if (!custom_create_info) {
3030 skip |=
3031 LogError(device, "VUID-VkSamplerCreateInfo-borderColor-04011",
3032 "VkSamplerCreateInfo->borderColor is set to %s but there is no VkSamplerCustomBorderColorCreateInfoEXT "
3033 "struct in pNext chain.\n",
3034 string_VkBorderColor(pCreateInfo->borderColor));
3035 } else {
3036 if ((custom_create_info->format != VK_FORMAT_UNDEFINED) &&
3037 ((pCreateInfo->borderColor == VK_BORDER_COLOR_INT_CUSTOM_EXT && !FormatIsSampledInt(custom_create_info->format)) ||
3038 (pCreateInfo->borderColor == VK_BORDER_COLOR_FLOAT_CUSTOM_EXT &&
3039 !FormatIsSampledFloat(custom_create_info->format)))) {
3040 skip |= LogError(device, "VUID-VkSamplerCustomBorderColorCreateInfoEXT-format-04013",
3041 "VkSamplerCreateInfo->borderColor is %s but VkSamplerCustomBorderColorCreateInfoEXT.format = %s "
3042 "whose type does not match\n",
3043 string_VkBorderColor(pCreateInfo->borderColor), string_VkFormat(custom_create_info->format));
3044 ;
3045 }
3046 }
3047 }
3048
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003049 return skip;
3050}
3051
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003052bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
3053 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
3054 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003055 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003056 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003057
3058 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3059 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
3060 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
3061 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003062 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3063 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
3064 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
3065 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
3066 ++descriptor_index) {
3067 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Spencer Frickeb0e30822020-03-23 10:32:30 -07003068 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-00282",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003069 "vkCreateDescriptorSetLayout: required parameter "
3070 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
3071 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003072 }
3073 }
3074 }
3075
3076 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
3077 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
3078 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003079 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
3080 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
3081 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
3082 "values.",
3083 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003084 }
Spencer Fricke84d0cc02020-03-16 17:21:59 -07003085
3086 if ((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT) &&
3087 (pCreateInfo->pBindings[i].stageFlags != 0) &&
3088 (pCreateInfo->pBindings[i].stageFlags != VK_SHADER_STAGE_FRAGMENT_BIT)) {
3089 skip |=
3090 LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorType-01510",
3091 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0 and "
3092 "descriptorType is VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT then pCreateInfo->pBindings[%d].stageFlags "
3093 "must be 0 or VK_SHADER_STAGE_FRAGMENT_BIT but is currently %s",
3094 i, i, string_VkShaderStageFlags(pCreateInfo->pBindings[i].stageFlags).c_str());
3095 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003096 }
3097 }
3098 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003099 return skip;
3100}
3101
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003102bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
3103 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003104 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003105 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3106 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3107 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003108 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
3109 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003110}
3111
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003112bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
3113 const VkWriteDescriptorSet *pDescriptorWrites,
3114 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003115 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003116
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003117 if (pDescriptorWrites != NULL) {
3118 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
3119 // descriptorCount must be greater than 0
3120 if (pDescriptorWrites[i].descriptorCount == 0) {
3121 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003122 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
3123 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003124 }
3125
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003126 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
3127 if (validateDstSet) {
3128 // dstSet must be a valid VkDescriptorSet handle
3129 skip |= validate_required_handle(vkCallingFunction,
3130 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
3131 pDescriptorWrites[i].dstSet);
3132 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003133
3134 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
3135 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
3136 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
3137 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
3138 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
3139 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
3140 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
Jeff Bolz165818a2020-05-08 11:19:03 -05003141 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures.
3142 // Valid imageView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003143 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003144 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
3145 "%s(): if pDescriptorWrites[%d].descriptorType is "
3146 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
3147 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
3148 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
3149 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003150 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
3151 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
Jeff Bolz165818a2020-05-08 11:19:03 -05003152 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageLayout
3153 // member of any given element of pImageInfo must be a valid VkImageLayout
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003154 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
3155 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003156 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003157 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
3158 ParameterName::IndexVector{i, descriptor_index}),
3159 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06003160 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003161 }
3162 }
3163 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3164 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3165 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
3166 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
3167 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
3168 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
3169 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
Jeff Bolz165818a2020-05-08 11:19:03 -05003170 // Valid buffer handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003171 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003172 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
3173 "%s(): if pDescriptorWrites[%d].descriptorType is "
3174 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
3175 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
3176 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
3177 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003178 } else {
Jeff Bolz165818a2020-05-08 11:19:03 -05003179 const auto *robustness2_features =
3180 lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
3181 if (robustness2_features && robustness2_features->nullDescriptor) {
3182 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount;
3183 ++descriptorIndex) {
3184 if (pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer == VK_NULL_HANDLE &&
3185 (pDescriptorWrites[i].pBufferInfo[descriptorIndex].offset != 0 ||
3186 pDescriptorWrites[i].pBufferInfo[descriptorIndex].range != VK_WHOLE_SIZE)) {
3187 skip |= LogError(device, "VUID-VkDescriptorBufferInfo-buffer-02999",
3188 "%s(): if pDescriptorWrites[%d].buffer is VK_NULL_HANDLE, "
baldurk751594b2020-09-09 09:41:02 +01003189 "offset (%" PRIu64 ") must be zero and range (%" PRIu64 ") must be VK_WHOLE_SIZE.",
Jeff Bolz165818a2020-05-08 11:19:03 -05003190 vkCallingFunction, i, pDescriptorWrites[i].pBufferInfo[descriptorIndex].offset,
3191 pDescriptorWrites[i].pBufferInfo[descriptorIndex].range);
3192 }
3193 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003194 }
3195 }
3196 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
3197 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
Jeff Bolz165818a2020-05-08 11:19:03 -05003198 // Valid bufferView handles are checked in ObjectLifetimes::ValidateDescriptorWrite.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003199 }
3200
3201 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
3202 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003203 VkDeviceSize uniformAlignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003204 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3205 if (pDescriptorWrites[i].pBufferInfo != NULL) {
3206 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003207 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003208 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
3209 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3210 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
3211 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003212 }
3213 }
3214 }
3215 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
3216 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003217 VkDeviceSize storageAlignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003218 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
3219 if (pDescriptorWrites[i].pBufferInfo != NULL) {
3220 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06003221 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003222 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
3223 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
3224 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
3225 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003226 }
3227 }
3228 }
3229 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003230 // pNext chain must be either NULL or a pointer to a valid instance of VkWriteDescriptorSetAccelerationStructureKHR
3231 // or VkWriteDescriptorSetInlineUniformBlockEX
3232 if (pDescriptorWrites[i].pNext) {
3233 if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR) {
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003234 const auto *pnext_struct =
sourav parmara96ab1a2020-04-25 16:28:23 -07003235 lvl_find_in_chain<VkWriteDescriptorSetAccelerationStructureKHR>(pDescriptorWrites[i].pNext);
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003236 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003237 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-02382",
3238 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, the pNext"
3239 "chain must include a VkWriteDescriptorSetAccelerationStructureKHR structure whose "
3240 "accelerationStructureCount %d member equals descriptorCount %d.",
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003241 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
sourav parmara96ab1a2020-04-25 16:28:23 -07003242 pDescriptorWrites[i].descriptorCount);
3243 }
3244 // further checks only if we have right structtype
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003245 if (pnext_struct) {
3246 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003247 skip |= LogError(
3248 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-02236",
3249 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3250 ".",
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003251 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
sourav parmara96ab1a2020-04-25 16:28:23 -07003252 }
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06003253 if (pnext_struct->accelerationStructureCount == 0) {
sourav parmara96ab1a2020-04-25 16:28:23 -07003254 skip |= LogError(
3255 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-accelerationStructureCount-arraylength",
3256 "%s(): accelerationStructureCount must be greater than 0 .");
3257 }
sourav parmarcd5fb182020-07-17 12:58:44 -07003258 const auto *robustness2_features =
3259 lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
3260 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3261 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3262 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3263 skip |= LogError(
3264 device, "VUID-VkWriteDescriptorSetAccelerationStructureKHR-pAccelerationStructures-03580",
3265 "%s(): If the nullDescriptor feature is not enabled, each member of "
3266 "pAccelerationStructures must not be VK_NULL_HANDLE.");
3267 }
3268 }
3269 }
3270 }
3271 } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV) {
3272 const auto *pnext_struct =
3273 lvl_find_in_chain<VkWriteDescriptorSetAccelerationStructureNV>(pDescriptorWrites[i].pNext);
3274 if (!pnext_struct || (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount)) {
3275 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-03817",
3276 "%s(): If descriptorType is VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV, the pNext"
3277 "chain must include a VkWriteDescriptorSetAccelerationStructureNV structure whose "
3278 "accelerationStructureCount %d member equals descriptorCount %d.",
3279 vkCallingFunction, pnext_struct ? pnext_struct->accelerationStructureCount : -1,
3280 pDescriptorWrites[i].descriptorCount);
3281 }
3282 // further checks only if we have right structtype
3283 if (pnext_struct) {
3284 if (pnext_struct->accelerationStructureCount != pDescriptorWrites[i].descriptorCount) {
3285 skip |= LogError(
3286 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-03747",
3287 "%s(): accelerationStructureCount %d must be equal to descriptorCount %d in the extended structure "
3288 ".",
3289 vkCallingFunction, pnext_struct->accelerationStructureCount, pDescriptorWrites[i].descriptorCount);
3290 }
3291 if (pnext_struct->accelerationStructureCount == 0) {
3292 skip |= LogError(
3293 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-accelerationStructureCount-arraylength",
3294 "%s(): accelerationStructureCount must be greater than 0 .");
3295 }
3296 const auto *robustness2_features =
3297 lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
3298 if (robustness2_features && robustness2_features->nullDescriptor == VK_FALSE) {
3299 for (uint32_t j = 0; j < pnext_struct->accelerationStructureCount; ++j) {
3300 if (pnext_struct->pAccelerationStructures[j] == VK_NULL_HANDLE) {
3301 skip |= LogError(
3302 device, "VUID-VkWriteDescriptorSetAccelerationStructureNV-pAccelerationStructures-03749",
3303 "%s(): If the nullDescriptor feature is not enabled, each member of "
3304 "pAccelerationStructures must not be VK_NULL_HANDLE.");
3305 }
3306 }
3307 }
sourav parmara96ab1a2020-04-25 16:28:23 -07003308 }
3309 }
3310 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003311 }
3312 }
3313 return skip;
3314}
3315
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003316bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
3317 const VkWriteDescriptorSet *pDescriptorWrites,
3318 uint32_t descriptorCopyCount,
3319 const VkCopyDescriptorSet *pDescriptorCopies) const {
3320 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
3321}
3322
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003323bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003324 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003325 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003326 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
3327}
3328
sfricke-samsung681ab7b2020-10-29 01:53:35 -07003329bool StatelessValidation::manual_PreCallValidateCreateRenderPass2(VkDevice device, const VkRenderPassCreateInfo2 *pCreateInfo,
3330 const VkAllocationCallbacks *pAllocator,
3331 VkRenderPass *pRenderPass) const {
3332 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3333}
3334
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003335bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003336 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003337 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003338 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
3339}
3340
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003341bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
3342 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003343 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003344 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003345
3346 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3347 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
3348 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003349 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
3350 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003351 return skip;
3352}
3353
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003354bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003355 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003356 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02003357
3358 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
3359 const char *cmd_name = "vkBeginCommandBuffer";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003360 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
3361
Petr Krause7bb9e82019-08-11 21:34:43 +02003362 // Implicit VUs
3363 // validate only sType here; pointer has to be validated in core_validation
3364 const bool kNotRequired = false;
3365 const char *kNoVUID = nullptr;
3366 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
3367 pInfo, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, kNotRequired, kNoVUID,
3368 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003369
Petr Krause7bb9e82019-08-11 21:34:43 +02003370 if (pInfo) {
3371 const VkStructureType allowed_structs_VkCommandBufferInheritanceInfo[] = {
3372 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
3373 skip |= validate_struct_pnext(
3374 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT", pInfo->pNext,
3375 ARRAY_SIZE(allowed_structs_VkCommandBufferInheritanceInfo), allowed_structs_VkCommandBufferInheritanceInfo,
sfricke-samsung32a27362020-02-28 09:06:42 -08003376 GeneratedVulkanHeaderVersion, "VUID-VkCommandBufferInheritanceInfo-pNext-pNext",
3377 "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003378
Petr Krause7bb9e82019-08-11 21:34:43 +02003379 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", pInfo->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003380
Petr Krause7bb9e82019-08-11 21:34:43 +02003381 // Explicit VUs
3382 if (!physical_device_features.inheritedQueries && pInfo->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003383 skip |= LogError(
3384 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Petr Krause7bb9e82019-08-11 21:34:43 +02003385 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
3386 cmd_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003387 }
Petr Krause7bb9e82019-08-11 21:34:43 +02003388
3389 if (physical_device_features.inheritedQueries) {
3390 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02003391 AllVkQueryControlFlagBits, pInfo->queryFlags, kOptionalFlags,
Dave Houlton413a6782018-05-22 13:01:54 -06003392 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Petr Krause7bb9e82019-08-11 21:34:43 +02003393 } else { // !inheritedQueries
Petr Krause7bb9e82019-08-11 21:34:43 +02003394 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", pInfo->queryFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02003395 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Petr Krause7bb9e82019-08-11 21:34:43 +02003396 }
3397
3398 if (physical_device_features.pipelineStatisticsQuery) {
Petr Krause7bb9e82019-08-11 21:34:43 +02003399 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02003400 AllVkQueryPipelineStatisticFlagBits, pInfo->pipelineStatistics, kOptionalFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02003401 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
Petr Krause7bb9e82019-08-11 21:34:43 +02003402 } else { // !pipelineStatisticsQuery
3403 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", pInfo->pipelineStatistics,
3404 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003405 }
Petr Kraus139757b2019-08-15 17:19:33 +02003406
3407 const auto *conditional_rendering = lvl_find_in_chain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(pInfo->pNext);
3408 if (conditional_rendering) {
Tony-LunarG6c3c5452019-12-13 10:37:38 -07003409 const auto *cr_features = lvl_find_in_chain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Petr Kraus139757b2019-08-15 17:19:33 +02003410 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
3411 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003412 skip |= LogError(
3413 commandBuffer, "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Petr Kraus139757b2019-08-15 17:19:33 +02003414 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
3415 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
3416 }
3417 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003418 }
3419
3420 return skip;
3421}
3422
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003423bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003424 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003425 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003426
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003427 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01003428 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003429 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
3430 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3431 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01003432 }
3433 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003434 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
3435 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3436 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01003437 }
3438 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01003439 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003440 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003441 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
3442 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3443 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3444 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003445 }
3446 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01003447
3448 if (pViewports) {
3449 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
3450 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06003451 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003452 skip |= manual_PreCallValidateViewport(
3453 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01003454 }
3455 }
3456
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003457 return skip;
3458}
3459
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003460bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003461 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003462 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003463
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003464 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003465 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003466 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
3467 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
3468 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003469 }
3470 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003471 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
3472 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
3473 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003474 }
3475 } else { // multiViewport enabled
3476 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003477 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003478 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
3479 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3480 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3481 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003482 }
3483 }
3484
Petr Kraus6260f0a2018-02-27 21:15:55 +01003485 if (pScissors) {
3486 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
3487 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003488
Petr Kraus6260f0a2018-02-27 21:15:55 +01003489 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003490 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3491 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3492 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003493 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003494
Petr Kraus6260f0a2018-02-27 21:15:55 +01003495 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003496 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
3497 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3498 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003499 }
3500
3501 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3502 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003503 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
3504 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3505 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3506 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003507 }
3508
3509 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3510 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003511 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
3512 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3513 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3514 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01003515 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003516 }
3517 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01003518
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003519 return skip;
3520}
3521
Jeff Bolz5c801d12019-10-09 10:38:45 -05003522bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01003523 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01003524
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003525 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003526 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
3527 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01003528 }
3529
3530 return skip;
3531}
3532
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003533bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003534 uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003535 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003536
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003537 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski41ce65b2020-10-30 12:17:06 -06003538 skip |= LogError(device, "VUID-vkCmdDrawIndirect-drawCount-02718",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003539 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003540 }
3541 return skip;
3542}
3543
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003544bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003545 VkDeviceSize offset, uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003546 bool skip = false;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003547 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003548 skip |=
Mark Lobodzinski41ce65b2020-10-30 12:17:06 -06003549 LogError(device, "VUID-vkCmdDrawIndexedIndirect-drawCount-02718",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003550 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003551 }
3552 return skip;
3553}
3554
sfricke-samsungf692b972020-05-02 08:00:45 -07003555bool StatelessValidation::ValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3556 VkDeviceSize countBufferOffset, bool khr) const {
3557 bool skip = false;
3558 const char *apiName = khr ? "vkCmdDrawIndirectCountKHR()" : "vkCmdDrawIndirectCount()";
3559 if (offset & 3) {
3560 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-offset-02710",
3561 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName, offset);
3562 }
3563
3564 if (countBufferOffset & 3) {
3565 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndirectCount-countBufferOffset-02716",
3566 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName,
3567 countBufferOffset);
3568 }
3569 return skip;
3570}
3571
3572bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3573 VkDeviceSize offset, VkBuffer countBuffer,
3574 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3575 uint32_t stride) const {
3576 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, false);
3577}
3578
3579bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3580 VkDeviceSize offset, VkBuffer countBuffer,
3581 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3582 uint32_t stride) const {
3583 return ValidateCmdDrawIndirectCount(commandBuffer, offset, countBufferOffset, true);
3584}
3585
3586bool StatelessValidation::ValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkDeviceSize offset,
3587 VkDeviceSize countBufferOffset, bool khr) const {
3588 bool skip = false;
3589 const char *apiName = khr ? "vkCmdDrawIndexedIndirectCountKHR()" : "vkCmdDrawIndexedIndirectCount()";
3590 if (offset & 3) {
3591 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-offset-02710",
3592 "%s: parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName, offset);
3593 }
3594
3595 if (countBufferOffset & 3) {
3596 skip |= LogError(commandBuffer, "VUID-vkCmdDrawIndexedIndirectCount-countBufferOffset-02716",
3597 "%s: parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", apiName,
3598 countBufferOffset);
3599 }
3600 return skip;
3601}
3602
3603bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCount(VkCommandBuffer commandBuffer, VkBuffer buffer,
3604 VkDeviceSize offset, VkBuffer countBuffer,
3605 VkDeviceSize countBufferOffset, uint32_t maxDrawCount,
3606 uint32_t stride) const {
3607 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, false);
3608}
3609
3610bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirectCountKHR(VkCommandBuffer commandBuffer, VkBuffer buffer,
3611 VkDeviceSize offset, VkBuffer countBuffer,
3612 VkDeviceSize countBufferOffset,
3613 uint32_t maxDrawCount, uint32_t stride) const {
3614 return ValidateCmdDrawIndexedIndirectCount(commandBuffer, offset, countBufferOffset, true);
3615}
3616
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003617bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
3618 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003619 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003620 bool skip = false;
3621 for (uint32_t rect = 0; rect < rectCount; rect++) {
3622 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003623 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
3624 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003625 }
sfricke-samsung10867682020-04-25 02:20:39 -07003626 if (pRects[rect].rect.extent.width == 0) {
3627 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02682",
3628 "CmdClearAttachments(): pRects[%d].rect.extent.width is zero.", rect);
3629 }
3630 if (pRects[rect].rect.extent.height == 0) {
3631 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-rect-02683",
3632 "CmdClearAttachments(): pRects[%d].rect.extent.height is zero.", rect);
3633 }
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06003634 }
3635 return skip;
3636}
3637
Andrew Fobel3abeb992020-01-20 16:33:22 -05003638bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
3639 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3640 VkImageFormatProperties2 *pImageFormatProperties,
3641 const char *apiName) const {
3642 bool skip = false;
3643
3644 if (pImageFormatInfo != nullptr) {
3645 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pImageFormatInfo->pNext);
3646 if (image_stencil_struct != nullptr) {
3647 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
3648 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
3649 // No flags other than the legal attachment bits may be set
3650 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
3651 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003652 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
3653 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
3654 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
3655 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
3656 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05003657 }
3658 }
3659 }
3660 }
3661
3662 return skip;
3663}
3664
3665bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
3666 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3667 VkImageFormatProperties2 *pImageFormatProperties) const {
3668 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3669 "vkGetPhysicalDeviceImageFormatProperties2");
3670}
3671
3672bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
3673 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
3674 VkImageFormatProperties2 *pImageFormatProperties) const {
3675 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
3676 "vkGetPhysicalDeviceImageFormatProperties2KHR");
3677}
3678
Lionel Landwerlin5fe52752020-07-22 08:18:14 +03003679bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties(
3680 VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage,
3681 VkImageCreateFlags flags, VkImageFormatProperties *pImageFormatProperties) const {
3682 bool skip = false;
3683
3684 if (tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
3685 skip |= LogError(physicalDevice, "VUID-vkGetPhysicalDeviceImageFormatProperties-tiling-02248",
3686 "vkGetPhysicalDeviceImageFormatProperties(): tiling must not be VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT.");
3687 }
3688
3689 return skip;
3690}
3691
sfricke-samsung3999ef62020-02-09 17:05:59 -08003692bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
3693 uint32_t regionCount, const VkBufferCopy *pRegions) const {
3694 bool skip = false;
3695
3696 if (pRegions != nullptr) {
3697 for (uint32_t i = 0; i < regionCount; i++) {
3698 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003699 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
3700 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08003701 }
3702 }
3703 }
3704 return skip;
3705}
3706
Jeff Leger178b1e52020-10-05 12:22:23 -04003707bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer2KHR(VkCommandBuffer commandBuffer,
3708 const VkCopyBufferInfo2KHR *pCopyBufferInfo) const {
3709 bool skip = false;
3710
3711 if (pCopyBufferInfo->pRegions != nullptr) {
3712 for (uint32_t i = 0; i < pCopyBufferInfo->regionCount; i++) {
3713 if (pCopyBufferInfo->pRegions[i].size == 0) {
3714 skip |= LogError(device, "VUID-VkBufferCopy2KHR-size-01988",
3715 "vkCmdCopyBuffer2KHR() pCopyBufferInfo->pRegions[%u].size must be greater than zero", i);
3716 }
3717 }
3718 }
3719 return skip;
3720}
3721
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003722bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003723 VkDeviceSize dstOffset, VkDeviceSize dataSize,
3724 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003725 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003726
3727 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003728 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
3729 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3730 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003731 }
3732
3733 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003734 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3735 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3736 "), must be greater than zero and less than or equal to 65536.",
3737 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003738 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003739 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3740 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3741 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003742 }
3743 return skip;
3744}
3745
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003746bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003747 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003748 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003749
3750 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003751 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3752 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3753 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003754 }
3755
3756 if (size != VK_WHOLE_SIZE) {
3757 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003758 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003759 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3760 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003761 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003762 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3763 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003764 }
3765 }
3766 return skip;
3767}
3768
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003769bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003770 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003771 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003772 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003773
3774 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003775 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3776 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3777 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3778 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003779 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3780 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3781 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003782 }
3783
3784 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3785 // queueFamilyIndexCount uint32_t values
3786 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003787 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3788 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3789 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3790 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003791 }
3792 }
3793
Dave Houlton413a6782018-05-22 13:01:54 -06003794 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003795 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003796 }
3797
3798 return skip;
3799}
3800
Jeff Bolz5c801d12019-10-09 10:38:45 -05003801bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003802 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003803
3804 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003805 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3806 if (present_regions) {
3807 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003808 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003809 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3810 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
sfricke-samsunga4cc4ff2020-08-23 22:05:49 -07003811 skip |= LogError(device, "VUID-VkPresentRegionsKHR-swapchainCount-01260",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003812 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3813 "extension swapchainCount is %i. These values must be equal.",
3814 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003815 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003816 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003817 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3818 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003819 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3820 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3821 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003822 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003823 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003824 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003825 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003826 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003827 }
3828 }
3829
3830 return skip;
3831}
3832
3833#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003834bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3835 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3836 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003837 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003838 bool skip = false;
3839
3840 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003841 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3842 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003843 }
3844
3845 return skip;
3846}
3847#endif // VK_USE_PLATFORM_WIN32_KHR
3848
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003849bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003850 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003851 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003852 bool skip = false;
3853
3854 if (pCreateInfo) {
3855 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003856 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3857 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003858 }
3859
3860 if (pCreateInfo->pPoolSizes) {
3861 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3862 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003863 skip |= LogError(
3864 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003865 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003866 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003867 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3868 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003869 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3870 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3871 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3872 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3873 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003874 }
Petr Krausc8655be2017-09-27 18:56:51 +02003875 }
3876 }
3877 }
3878
3879 return skip;
3880}
3881
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003882bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003883 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003884 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003885
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003886 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003887 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003888 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
3889 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3890 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003891 }
3892
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003893 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003894 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003895 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
3896 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3897 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003898 }
3899
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003900 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003901 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003902 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
3903 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3904 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003905 }
3906
3907 return skip;
3908}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003909
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003910bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003911 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07003912 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07003913
3914 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003915 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
3916 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07003917 }
3918 return skip;
3919}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003920
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003921bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
3922 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003923 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003924 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003925
3926 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003927 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003928 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003929 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
3930 "vkCmdDispatch(): baseGroupX (%" PRIu32
3931 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3932 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003933 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003934 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
3935 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
3936 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3937 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003938 }
3939
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003940 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003941 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003942 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
3943 "vkCmdDispatch(): baseGroupY (%" PRIu32
3944 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3945 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003946 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003947 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
3948 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
3949 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3950 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003951 }
3952
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003953 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003954 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003955 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
3956 "vkCmdDispatch(): baseGroupZ (%" PRIu32
3957 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3958 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003959 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003960 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
3961 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
3962 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3963 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003964 }
3965
3966 return skip;
3967}
3968
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003969bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
3970 VkPipelineBindPoint pipelineBindPoint,
3971 VkPipelineLayout layout, uint32_t set,
3972 uint32_t descriptorWriteCount,
3973 const VkWriteDescriptorSet *pDescriptorWrites) const {
3974 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
3975}
3976
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003977bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
3978 uint32_t firstExclusiveScissor,
3979 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003980 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003981 bool skip = false;
3982
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003983 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003984 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003985 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003986 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3987 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3988 ") is not 0.",
3989 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003990 }
3991 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003992 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003993 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3994 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3995 ") is not 1.",
3996 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003997 }
3998 } else { // multiViewport enabled
3999 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004000 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004001 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
4002 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
4003 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4004 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004005 }
4006 }
4007
Jeff Bolz3e71f782018-08-29 23:15:45 -05004008 if (pExclusiveScissors) {
4009 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
4010 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
4011
4012 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004013 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4014 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
4015 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004016 }
4017
4018 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004019 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
4020 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
4021 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004022 }
4023
4024 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
4025 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004026 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
4027 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4028 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4029 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004030 }
4031
4032 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
4033 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004034 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
4035 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
4036 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
4037 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05004038 }
4039 }
4040 }
4041
4042 return skip;
4043}
4044
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004045bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
4046 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004047 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004048 bool skip = false;
Shannon McPherson169d0c72020-11-13 18:48:19 -07004049 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
4050 if ((sum < 1) || (sum > device_limits.maxViewports)) {
4051 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
4052 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
4053 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
4054 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02004055 }
4056
4057 return skip;
4058}
4059
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004060bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
4061 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004062 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004063 bool skip = false;
4064
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004065 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004066 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004067 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004068 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
4069 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
4070 ") is not 0.",
4071 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004072 }
4073 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06004074 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004075 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
4076 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
4077 ") is not 1.",
4078 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004079 }
4080 }
4081
Jeff Bolz9af91c52018-09-01 21:53:57 -05004082 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004083 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004084 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
4085 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
4086 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
4087 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004088 }
4089
4090 return skip;
4091}
4092
Jeff Bolz5c801d12019-10-09 10:38:45 -05004093bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
4094 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
4095 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05004096 bool skip = false;
4097
Dave Houlton142c4cb2018-10-17 15:04:41 -06004098 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004099 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
4100 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
4101 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05004102 }
4103
4104 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004105 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05004106 }
4107
4108 return skip;
4109}
4110
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004111bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004112 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004113 bool skip = false;
4114
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004115 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004116 skip |= LogError(
4117 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004118 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
4119 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004120 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004121 }
4122
4123 return skip;
4124}
4125
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004126bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4127 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004128 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004129 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06004130 static const int condition_multiples = 0b0011;
4131 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004132 skip |= LogError(
4133 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06004134 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004135 }
Lockee1c22882019-06-10 16:02:54 -06004136 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004137 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
4138 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
4139 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
4140 stride);
Lockee1c22882019-06-10 16:02:54 -06004141 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004142 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004143 skip |= LogError(
4144 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
4145 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06004146 }
4147
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004148 return skip;
4149}
4150
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004151bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
4152 VkDeviceSize offset, VkBuffer countBuffer,
4153 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004154 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004155 bool skip = false;
4156
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004157 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004158 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
4159 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
4160 "), is not a multiple of 4.",
4161 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004162 }
4163
4164 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004165 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
4166 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
4167 "), is not a multiple of 4.",
4168 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004169 }
4170
Jeff Bolz45bf7d62018-09-18 15:39:58 -05004171 return skip;
4172}
4173
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004174bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004175 const VkAllocationCallbacks *pAllocator,
4176 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004177 bool skip = false;
4178
4179 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4180 if (pCreateInfo != nullptr) {
4181 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
4182 // VkQueryPipelineStatisticFlagBits values
4183 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
4184 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004185 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
4186 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
4187 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
4188 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004189 }
sfricke-samsung7d69d0d2020-04-25 10:27:27 -07004190 if (pCreateInfo->queryCount == 0) {
4191 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryCount-02763",
4192 "vkCreateQueryPool(): queryCount must be greater than zero.");
4193 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06004194 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004195 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004196}
4197
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004198bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
4199 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004200 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004201 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
4202 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004203}
4204
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004205void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004206 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4207 VkResult result) {
4208 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004209 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004210}
4211
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004212void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004213 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
4214 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004215 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07004216 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004217 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004218}
4219
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07004220void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
4221 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004222 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07004223 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07004224 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06004225}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004226
4227bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004228 const VkAllocationCallbacks *pAllocator,
4229 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004230 bool skip = false;
4231
4232 if (pAllocateInfo) {
4233 auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
4234 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004235 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
4236 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004237 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004238
4239 VkMemoryAllocateFlags flags = 0;
4240 auto flags_info = lvl_find_in_chain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
4241 if (flags_info) {
4242 flags = flags_info->flags;
4243 }
4244
4245 auto opaque_alloc_info = lvl_find_in_chain<VkMemoryOpaqueCaptureAddressAllocateInfoKHR>(pAllocateInfo->pNext);
4246 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
4247 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004248 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
4249 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
4250 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004251 }
4252
4253#ifdef VK_USE_PLATFORM_WIN32_KHR
4254 auto import_memory_win32_handle = lvl_find_in_chain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
4255#endif
4256 auto import_memory_fd = lvl_find_in_chain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
4257 auto import_memory_host_pointer = lvl_find_in_chain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
4258#ifdef VK_USE_PLATFORM_ANDROID_KHR
4259 auto import_memory_ahb = lvl_find_in_chain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
4260#endif
4261
4262 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004263 skip |= LogError(
4264 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004265 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
4266 }
4267 if (
4268#ifdef VK_USE_PLATFORM_WIN32_KHR
4269 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
4270#endif
4271 (import_memory_fd && import_memory_fd->handleType) ||
4272#ifdef VK_USE_PLATFORM_ANDROID_KHR
4273 (import_memory_ahb && import_memory_ahb->buffer) ||
4274#endif
4275 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004276 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
4277 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004278 }
4279 }
4280
4281 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004282 VkBool32 capture_replay = false;
4283 VkBool32 buffer_device_address = false;
4284 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
4285 if (vulkan_12_features) {
4286 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
4287 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
4288 } else {
4289 const auto *bda_features =
4290 lvl_find_in_chain<VkPhysicalDeviceBufferDeviceAddressFeaturesKHR>(device_createinfo_pnext);
4291 if (bda_features) {
4292 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
4293 buffer_device_address = bda_features->bufferDeviceAddress;
4294 }
4295 }
4296 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004297 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
4298 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR is set, "
4299 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004300 }
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07004301 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004302 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
4303 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06004304 }
4305 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06004306 }
4307 return skip;
4308}
Ricardo Garciaa4935972019-02-21 17:43:18 +01004309
Jason Macnak192fa0e2019-07-26 15:07:16 -07004310bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004311 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004312 bool skip = false;
4313
4314 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
4315 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
4316 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004317 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004318 } else {
4319 uint32_t vertex_component_size = 0;
4320 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
4321 vertex_component_size = 4;
4322 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
4323 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
4324 vertex_component_size = 2;
4325 }
4326 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004327 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004328 }
4329 }
4330
4331 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
4332 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004333 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004334 } else {
4335 uint32_t index_element_size = 0;
4336 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
4337 index_element_size = 4;
4338 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
4339 index_element_size = 2;
4340 }
4341 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004342 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004343 }
4344 }
4345 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
4346 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004347 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004348 }
4349 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004350 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004351 }
4352 }
4353
4354 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004355 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004356 }
4357
4358 return skip;
4359}
4360
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004361bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
4362 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004363 bool skip = false;
4364
4365 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004366 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004367 }
4368 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004369 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004370 }
4371
4372 return skip;
4373}
4374
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004375bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
4376 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07004377 bool skip = false;
4378 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004379 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004380 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004381 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004382 }
4383 return skip;
4384}
4385
4386bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
sourav parmara24fb7b2020-05-26 10:50:04 -07004387 VkAccelerationStructureNV object_handle, const char *func_name,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004388 bool is_cmd) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004389 bool skip = false;
4390 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004391 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
4392 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
4393 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004394 }
4395 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004396 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
4397 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
4398 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07004399 }
4400 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
4401 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004402 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
4403 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
4404 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07004405 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004406 if (info.geometryCount > phys_dev_ext_props.ray_tracing_propsNV.maxGeometryCount) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004407 skip |= LogError(object_handle,
Mark Lobodzinski17dc4602020-05-29 07:48:40 -06004408 is_cmd ? "VUID-vkCmdBuildAccelerationStructureNV-geometryCount-02241"
4409 : "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004410 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
4411 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004412 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004413 if (info.instanceCount > phys_dev_ext_props.ray_tracing_propsNV.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004414 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
4415 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
4416 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004417 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004418 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07004419 uint64_t total_triangle_count = 0;
4420 for (uint32_t i = 0; i < info.geometryCount; i++) {
4421 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07004422
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004423 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07004424
Jason Macnak5c954952019-07-09 15:46:12 -07004425 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
4426 continue;
4427 }
4428 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
4429 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004430 if (total_triangle_count > phys_dev_ext_props.ray_tracing_propsNV.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004431 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
4432 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
4433 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07004434 }
4435 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07004436 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
4437 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
4438 for (uint32_t i = 1; i < info.geometryCount; i++) {
4439 const VkGeometryNV &geometry = info.pGeometries[i];
4440 if (geometry.geometryType != first_geometry_type) {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004441 skip |= LogError(device, "VUID-VkAccelerationStructureInfoNV-type-02786",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004442 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
4443 "info.pGeometries[0].geometryType.",
4444 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07004445 }
4446 }
4447 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004448 for (uint32_t geometry_index = 0; geometry_index < info.geometryCount; ++geometry_index) {
4449 if (!(info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV ||
4450 info.pGeometries[geometry_index].geometryType == VK_GEOMETRY_TYPE_AABBS_NV)) {
4451 skip |= LogError(device, "VUID-VkGeometryNV-geometryType-03503",
4452 "VkGeometryNV: geometryType must be VK_GEOMETRY_TYPE_TRIANGLES_NV"
4453 "or VK_GEOMETRY_TYPE_AABBS_NV.");
4454 }
4455 }
4456 skip |=
4457 validate_flags(func_name, "info.flags", "VkBuildAccelerationStructureFlagBitsNV", AllVkBuildAccelerationStructureFlagBitsNV,
Shannon McPherson93970b12020-06-12 14:34:35 -06004458 info.flags, kOptionalFlags, "VUID-VkAccelerationStructureInfoNV-flags-parameter");
Jason Macnak5c954952019-07-09 15:46:12 -07004459 return skip;
4460}
4461
Ricardo Garciaa4935972019-02-21 17:43:18 +01004462bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
4463 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004464 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01004465 bool skip = false;
Ricardo Garciaa4935972019-02-21 17:43:18 +01004466 if (pCreateInfo) {
4467 if ((pCreateInfo->compactedSize != 0) &&
4468 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004469 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
4470 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
4471 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
4472 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004473 }
Jason Macnak5c954952019-07-09 15:46:12 -07004474
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004475 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
sourav parmara24fb7b2020-05-26 10:50:04 -07004476 "vkCreateAccelerationStructureNV()", false);
Ricardo Garciaa4935972019-02-21 17:43:18 +01004477 }
Ricardo Garciaa4935972019-02-21 17:43:18 +01004478 return skip;
4479}
Mike Schuchardt21638df2019-03-16 10:52:02 -07004480
Jeff Bolz5c801d12019-10-09 10:38:45 -05004481bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
4482 const VkAccelerationStructureInfoNV *pInfo,
4483 VkBuffer instanceData, VkDeviceSize instanceOffset,
4484 VkBool32 update, VkAccelerationStructureNV dst,
4485 VkAccelerationStructureNV src, VkBuffer scratch,
4486 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004487 bool skip = false;
4488
4489 if (pInfo != nullptr) {
sourav parmara24fb7b2020-05-26 10:50:04 -07004490 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()", true);
Jason Macnak5c954952019-07-09 15:46:12 -07004491 }
4492
4493 return skip;
4494}
4495
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004496bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureKHR(
4497 VkDevice device, const VkAccelerationStructureCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
4498 VkAccelerationStructureKHR *pAccelerationStructure) const {
4499 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07004500 const auto *acceleration_structure_features =
4501 lvl_find_in_chain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
4502 if (!acceleration_structure_features ||
4503 (acceleration_structure_features && acceleration_structure_features->accelerationStructure == VK_FALSE)) {
4504 skip |= LogError(device, "VUID-vkCreateAccelerationStructureKHR-accelerationStructure-03611",
4505 "vkCreateAccelerationStructureKHR(): The accelerationStructure feature must be enabled");
4506 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004507 if (pCreateInfo) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004508 if (pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR &&
4509 (!acceleration_structure_features ||
4510 (acceleration_structure_features && acceleration_structure_features->accelerationStructureCaptureReplay == VK_FALSE))) {
sourav parmara96ab1a2020-04-25 16:28:23 -07004511 skip |=
sourav parmarcd5fb182020-07-17 12:58:44 -07004512 LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-createFlags-03613",
4513 "vkCreateAccelerationStructureKHR(): If createFlags includes "
4514 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR, "
4515 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureCaptureReplay must be VK_TRUE");
sourav parmara96ab1a2020-04-25 16:28:23 -07004516 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004517 if (pCreateInfo->deviceAddress &&
4518 !(pCreateInfo->createFlags & VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
4519 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-deviceAddress-03612",
4520 "vkCreateAccelerationStructureKHR(): If deviceAddress is not zero, createFlags must include "
4521 "VK_ACCELERATION_STRUCTURE_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR");
4522 }
4523 if (SafeModulo(pCreateInfo->offset, 256) != 0) {
4524 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoKHR-offset-03734",
4525 "vkCreateAccelerationStructureKHR(): offset must be a multiple of 256 bytes", pCreateInfo->offset);
4526 }
sourav parmar83c31b12020-05-06 12:30:54 -07004527 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004528 return skip;
4529}
4530
Jason Macnak5c954952019-07-09 15:46:12 -07004531bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
4532 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004533 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07004534 bool skip = false;
4535 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004536 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
4537 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07004538 }
4539 return skip;
4540}
4541
sourav parmarcd5fb182020-07-17 12:58:44 -07004542bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesNV(
4543 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureNV *pAccelerationStructures,
4544 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
4545 bool skip = false;
4546 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
4547 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
4548 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesNV-queryType-03432",
4549 "vkCmdWriteAccelerationStructuresPropertiesNV: queryType must be "
4550 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
4551 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
4552 }
4553 return skip;
4554}
4555
Peter Chen85366392019-05-14 15:20:11 -04004556bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
4557 uint32_t createInfoCount,
4558 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
4559 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004560 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04004561 bool skip = false;
4562
4563 for (uint32_t i = 0; i < createInfoCount; i++) {
4564 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
4565 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
sourav parmar83c31b12020-05-06 12:30:54 -07004566 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02969",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004567 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
4568 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
4569 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
4570 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04004571 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004572
4573 const auto *pipeline_cache_contol_features =
4574 lvl_find_in_chain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
4575 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4576 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4577 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4578 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-pipelineCreationCacheControl-02905",
4579 "vkCreateRayTracingPipelinesNV(): If the pipelineCreationCacheControl feature is not enabled,"
4580 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4581 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4582 }
4583 }
4584
sourav parmarf4a78252020-04-10 13:04:21 -07004585 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
4586 skip |=
4587 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02904",
4588 "vkCreateRayTracingPipelinesNV(): flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
4589 }
4590 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV) &&
4591 (pCreateInfos[i].flags & VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT)) {
4592 skip |=
4593 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-02957",
4594 "vkCreateRayTracingPipelinesNV(): flags must not include both VK_PIPELINE_CREATE_DEFER_COMPILE_BIT_NV and"
4595 "VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT at the same time.");
4596 }
4597 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4598 if (pCreateInfos[i].basePipelineIndex != -1) {
4599 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4600 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03423",
4601 "vkCreateRayTracingPipelinesNV parameter, pCreateInfos->basePipelineHandle, must be "
4602 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4603 "and pCreateInfos->basePipelineIndex is not -1.");
4604 }
sourav parmara24fb7b2020-05-26 10:50:04 -07004605 if (pCreateInfos[i].basePipelineIndex > (int32_t)(i)) {
4606 skip |=
4607 LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03415",
4608 "vkCreateRayTracingPipelinesNV: If the flags member of any element of pCreateInfos contains the"
4609 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element"
4610 "is not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to "
4611 "that element.");
4612 }
sourav parmarf4a78252020-04-10 13:04:21 -07004613 }
4614 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004615 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004616 skip |=
4617 LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03422",
4618 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4619 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex must be a valid index into the calling"
4620 "commands pCreateInfos parameter.");
4621 }
4622 } else {
4623 if (pCreateInfos[i].basePipelineIndex != -1) {
4624 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03424",
4625 "vkCreateRayTracingPipelinesNV if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
4626 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4627 }
4628 }
4629 }
4630 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4631 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03456",
4632 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_LIBRARY_BIT_KHR.");
4633 }
4634 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) {
4635 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03458",
4636 "vkCreateRayTracingPipelinesNV: flags must not include "
4637 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR.");
4638 }
4639 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) {
4640 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03459",
4641 "vkCreateRayTracingPipelinesNV: flags must not include "
4642 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR.");
4643 }
4644 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR) {
4645 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03460",
4646 "vkCreateRayTracingPipelinesNV: flags must not include "
4647 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_MISS_SHADERS_BIT_KHR.");
4648 }
4649 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR) {
4650 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03461",
4651 "vkCreateRayTracingPipelinesNV: flags must not include "
4652 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_INTERSECTION_SHADERS_BIT_KHR.");
4653 }
4654 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4655 skip |= LogError(
4656 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03462",
4657 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4658 }
4659 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4660 skip |= LogError(
4661 device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03463",
4662 "vkCreateRayTracingPipelinesNV: flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR .");
4663 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004664 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR) {
4665 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoNV-flags-03588",
4666 "vkCreateRayTracingPipelinesNV: flags must not include "
4667 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
4668 }
4669 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
4670 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesNV-flags-03816",
4671 "vkCreateRayTracingPipelinesNV: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
4672 }
Peter Chen85366392019-05-14 15:20:11 -04004673 }
4674
4675 return skip;
4676}
4677
sourav parmarcd5fb182020-07-17 12:58:44 -07004678bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesKHR(
4679 VkDevice device, VkDeferredOperationKHR deferredOperation, VkPipelineCache pipelineCache, uint32_t createInfoCount,
4680 const VkRayTracingPipelineCreateInfoKHR *pCreateInfos, const VkAllocationCallbacks *pAllocator, VkPipeline *pPipelines) const {
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004681 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07004682 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
4683 if (!raytracing_features || raytracing_features->rayTracingPipeline == VK_FALSE) {
4684 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-rayTracingPipeline-03586",
4685 "vkCreateRayTracingPipelinesKHR: The rayTracingPipeline feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07004686 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004687 for (uint32_t i = 0; i < createInfoCount; i++) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004688 if (!raytracing_features || (raytracing_features && raytracing_features->rayTraversalPrimitiveCulling == VK_FALSE)) {
4689 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR) {
4690 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03596",
4691 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
4692 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_AABBS_BIT_KHR.");
4693 }
4694 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR) {
4695 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03597",
4696 "vkCreateRayTracingPipelinesKHR: If the rayTraversalPrimitiveCulling feature is not enabled, "
4697 "flags must not include VK_PIPELINE_CREATE_RAY_TRACING_SKIP_TRIANGLES_BIT_KHR.");
4698 }
4699 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004700 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
4701 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
4702 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
sourav parmarcd5fb182020-07-17 12:58:44 -07004703 "vkCreateRayTracingPipelinesKHR: in pCreateInfo[%" PRIu32
4704 "], When chained to VkRayTracingPipelineCreateInfoKHR, "
4705 "VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004706 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoKHR::stageCount(=%" PRIu32 ").",
4707 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
4708 }
sourav parmara96ab1a2020-04-25 16:28:23 -07004709 const auto *pipeline_cache_contol_features =
4710 lvl_find_in_chain<VkPhysicalDevicePipelineCreationCacheControlFeaturesEXT>(device_createinfo_pnext);
4711 if (!pipeline_cache_contol_features || pipeline_cache_contol_features->pipelineCreationCacheControl == VK_FALSE) {
4712 if (pCreateInfos[i].flags & (VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT |
4713 VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT)) {
4714 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pipelineCreationCacheControl-02905",
sourav parmarcd5fb182020-07-17 12:58:44 -07004715 "vkCreateRayTracingPipelinesKHR: If the pipelineCreationCacheControl feature is not enabled,"
sourav parmara96ab1a2020-04-25 16:28:23 -07004716 "flags must not include VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT or"
4717 "VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
4718 }
4719 }
sourav parmarf4a78252020-04-10 13:04:21 -07004720 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV) {
sourav parmarcd5fb182020-07-17 12:58:44 -07004721 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-02904",
4722 "vkCreateRayTracingPipelinesKHR: flags must not include VK_PIPELINE_CREATE_INDIRECT_BINDABLE_BIT_NV.");
sourav parmarf4a78252020-04-10 13:04:21 -07004723 }
4724 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_LIBRARY_BIT_KHR) {
4725 if (pCreateInfos[i].pLibraryInterface == NULL)
4726 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03465",
sourav parmarcd5fb182020-07-17 12:58:44 -07004727 "vkCreateRayTracingPipelinesKHR: If flags includes VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, "
4728 "pLibraryInterface must not be NULL.");
4729 }
4730 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DISPATCH_BASE) {
4731 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03816",
4732 "vkCreateRayTracingPipelinesKHR: flags must not contain the VK_PIPELINE_CREATE_DISPATCH_BASE flag.");
sourav parmarf4a78252020-04-10 13:04:21 -07004733 }
4734 for (uint32_t group_index = 0; group_index < pCreateInfos[i].groupCount; ++group_index) {
4735 if ((pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR) ||
4736 (pCreateInfos[i].pGroups[group_index].type == VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR)) {
4737 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR) &&
4738 (pCreateInfos[i].pGroups[group_index].anyHitShader == VK_SHADER_UNUSED_KHR)) {
4739 skip |= LogError(
4740 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03470",
sourav parmarcd5fb182020-07-17 12:58:44 -07004741 "vkCreateRayTracingPipelinesKHR: If flags includes "
4742 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_ANY_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07004743 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4744 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the anyHitShader of that element "
4745 "must not be VK_SHADER_UNUSED_KHR");
4746 }
4747 if ((pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR) &&
4748 (pCreateInfos[i].pGroups[group_index].closestHitShader == VK_SHADER_UNUSED_KHR)) {
4749 skip |= LogError(
4750 device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03471",
sourav parmarcd5fb182020-07-17 12:58:44 -07004751 "vkCreateRayTracingPipelinesKHR: If flags includes "
4752 "VK_PIPELINE_CREATE_RAY_TRACING_NO_NULL_CLOSEST_HIT_SHADERS_BIT_KHR,"
sourav parmarf4a78252020-04-10 13:04:21 -07004753 "for any element of pGroups with a type of VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR"
4754 "or VK_RAY_TRACING_SHADER_GROUP_TYPE_PROCEDURAL_HIT_GROUP_KHR, the closestHitShader of that "
4755 "element must not be VK_SHADER_UNUSED_KHR");
4756 }
4757 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004758 if (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_TRUE &&
4759 pCreateInfos[i].pGroups[group_index].pShaderGroupCaptureReplayHandle) {
4760 if (!(pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR)) {
4761 skip |= LogError(
4762 device, "VUID-VkRayTracingPipelineCreateInfoKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03599",
4763 "vkCreateRayTracingPipelinesKHR: If "
4764 "VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineShaderGroupHandleCaptureReplay is "
4765 "VK_TRUE and the pShaderGroupCaptureReplayHandle member of any element of pGroups is not NULL, flags must "
4766 "include VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR.");
4767 }
4768 }
sourav parmarf4a78252020-04-10 13:04:21 -07004769 }
4770 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
4771 if (pCreateInfos[i].basePipelineIndex != -1) {
4772 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
4773 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03423",
sourav parmarcd5fb182020-07-17 12:58:44 -07004774 "vkCreateRayTracingPipelinesKHR: parameter, pCreateInfos->basePipelineHandle, must be "
sourav parmarf4a78252020-04-10 13:04:21 -07004775 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
4776 "and pCreateInfos->basePipelineIndex is not -1.");
4777 }
sourav parmara24fb7b2020-05-26 10:50:04 -07004778 if (pCreateInfos[i].basePipelineIndex > (int32_t)i) {
4779 skip |=
4780 LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-flags-03415",
4781 "vkCreateRayTracingPipelinesKHR: If the flags member of any element of pCreateInfos contains the"
4782 "VK_PIPELINE_CREATE_DERIVATIVE_BIT flag, and the basePipelineIndex member of that same element is"
4783 "not -1, basePipelineIndex must be less than the index into pCreateInfos that corresponds to that "
4784 "element.");
4785 }
sourav parmarf4a78252020-04-10 13:04:21 -07004786 }
4787 if (pCreateInfos[i].basePipelineHandle == VK_NULL_HANDLE) {
David Netod9d7b762020-07-27 15:37:58 -04004788 if (static_cast<uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
sourav parmarf4a78252020-04-10 13:04:21 -07004789 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03422",
sourav parmarcd5fb182020-07-17 12:58:44 -07004790 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07004791 "basePipelineHandle is VK_NULL_HANDLE, basePipelineIndex (%d) must be a valid into the calling"
4792 "commands pCreateInfos parameter %d.",
4793 pCreateInfos[i].basePipelineIndex, createInfoCount);
4794 }
4795 } else {
4796 if (pCreateInfos[i].basePipelineIndex != -1) {
4797 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03424",
sourav parmarcd5fb182020-07-17 12:58:44 -07004798 "vkCreateRayTracingPipelinesKHR: if flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT and"
sourav parmarf4a78252020-04-10 13:04:21 -07004799 "basePipelineHandle is not VK_NULL_HANDLE, basePipelineIndex must be -1.");
4800 }
4801 }
4802 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004803 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR &&
4804 (raytracing_features && raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE)) {
4805 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-flags-03598",
4806 "vkCreateRayTracingPipelinesKHR: If flags includes "
4807 "VK_PIPELINE_CREATE_RAY_TRACING_SHADER_GROUP_HANDLE_CAPTURE_REPLAY_BIT_KHR, "
4808 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled.");
sourav parmarf4a78252020-04-10 13:04:21 -07004809 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004810 bool library_enabled = IsExtEnabled(device_extensions.vk_khr_pipeline_library);
4811 if (!library_enabled && (pCreateInfos[i].pLibraryInfo || pCreateInfos[i].pLibraryInterface)) {
4812 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03595",
4813 "vkCreateRayTracingPipelinesKHR: If the VK_KHR_pipeline_library extension is not enabled, "
4814 "pLibraryInfo and pLibraryInterface must be NULL.");
sourav parmarf4a78252020-04-10 13:04:21 -07004815 }
sourav parmarcd5fb182020-07-17 12:58:44 -07004816 if (pCreateInfos[i].pLibraryInfo) {
4817 if (pCreateInfos[i].pLibraryInfo->libraryCount == 0) {
4818 if (pCreateInfos[i].stageCount == 0) {
4819 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03600",
4820 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
4821 "stageCount must not be 0.");
4822 }
4823 if (pCreateInfos[i].groupCount == 0) {
4824 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03601",
4825 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount is 0, "
4826 "groupCount must not be 0.");
4827 }
4828 } else {
4829 if (pCreateInfos[i].pLibraryInterface == NULL) {
4830 skip |= LogError(device, "VUID-VkRayTracingPipelineCreateInfoKHR-pLibraryInfo-03590",
4831 "vkCreateRayTracingPipelinesKHR: If pLibraryInfo is not NULL and its libraryCount member "
4832 "is greater than 0, its "
4833 "pLibraryInterface member must not be NULL.");
4834 }
4835 }
4836 }
4837 if (pCreateInfos[i].pLibraryInterface) {
4838 if (pCreateInfos[i].pLibraryInterface->maxPipelineRayHitAttributeSize >
4839 phys_dev_ext_props.ray_tracing_propsKHR.maxRayHitAttributeSize) {
4840 skip |= LogError(device, "VUID-VkRayTracingPipelineInterfaceCreateInfoKHR-maxPipelineRayHitAttributeSize-03605",
4841 "vkCreateRayTracingPipelinesKHR: maxPipelineRayHitAttributeSize must be less than or equal to "
4842 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayHitAttributeSize.");
4843 }
4844 }
4845 if (deferredOperation != VK_NULL_HANDLE) {
4846 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT) {
4847 skip |= LogError(device, "VUID-vkCreateRayTracingPipelinesKHR-deferredOperation-03587",
4848 "vkCreateRayTracingPipelinesKHR: If deferredOperation is not VK_NULL_HANDLE, the flags member of "
4849 "elements of pCreateInfos must not include VK_PIPELINE_CREATE_EARLY_RETURN_ON_FAILURE_BIT_EXT.");
sourav parmarf4a78252020-04-10 13:04:21 -07004850 }
4851 }
Jeff Bolz443c2ca2020-03-19 12:11:51 -05004852 }
4853
4854 return skip;
4855}
4856
Mike Schuchardt21638df2019-03-16 10:52:02 -07004857#ifdef VK_USE_PLATFORM_WIN32_KHR
4858bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
4859 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004860 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07004861 bool skip = false;
4862 if (!device_extensions.vk_khr_swapchain)
4863 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
4864 if (!device_extensions.vk_khr_get_surface_capabilities_2)
4865 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
4866 if (!device_extensions.vk_khr_surface)
4867 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
4868 if (!device_extensions.vk_khr_get_physical_device_properties_2)
4869 skip |=
4870 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
4871 if (!device_extensions.vk_ext_full_screen_exclusive)
4872 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
4873 skip |= validate_struct_type(
4874 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
4875 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
4876 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
4877 if (pSurfaceInfo != NULL) {
4878 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
4879 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
4880 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
4881
4882 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
4883 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
4884 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
4885 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08004886 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
4887 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07004888
4889 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
4890 }
4891 return skip;
4892}
4893#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01004894
4895bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
4896 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004897 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01004898 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
4899 bool skip = false;
4900 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT_KHR) == 0) {
4901 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
4902 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
4903 }
4904 return skip;
4905}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004906
4907bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004908 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004909 bool skip = false;
4910
4911 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004912 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
4913 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05004914 }
4915
4916 return skip;
4917}
Piers Daniell8fd03f52019-08-21 12:07:53 -06004918
4919bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004920 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06004921 bool skip = false;
4922
4923 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004924 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
4925 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06004926 }
4927
Tony-LunarG6c3c5452019-12-13 10:37:38 -07004928 const auto *index_type_uint8_features = lvl_find_in_chain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Mark Lobodzinski804fde82020-05-08 07:49:25 -06004929 if (indexType == VK_INDEX_TYPE_UINT8_EXT && (!index_type_uint8_features || !index_type_uint8_features->indexTypeUint8)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004930 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
4931 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06004932 }
4933
4934 return skip;
4935}
Mark Lobodzinski84988402019-09-11 15:27:30 -06004936
sfricke-samsung4ada8d42020-02-09 17:43:11 -08004937bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
4938 uint32_t bindingCount, const VkBuffer *pBuffers,
4939 const VkDeviceSize *pOffsets) const {
4940 bool skip = false;
4941 if (firstBinding > device_limits.maxVertexInputBindings) {
4942 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
4943 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
4944 device_limits.maxVertexInputBindings);
4945 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
4946 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
4947 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
4948 "maxVertexInputBindings (%u)",
4949 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
4950 }
4951
Jeff Bolz165818a2020-05-08 11:19:03 -05004952 for (uint32_t i = 0; i < bindingCount; ++i) {
4953 if (pBuffers[i] == VK_NULL_HANDLE) {
4954 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
4955 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
4956 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04001",
4957 "vkCmdBindVertexBuffers() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
4958 } else {
4959 if (pOffsets[i] != 0) {
4960 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-pBuffers-04002",
4961 "vkCmdBindVertexBuffers() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
4962 }
4963 }
4964 }
4965 }
4966
sfricke-samsung4ada8d42020-02-09 17:43:11 -08004967 return skip;
4968}
4969
Mark Lobodzinski84988402019-09-11 15:27:30 -06004970bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004971 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06004972 bool skip = false;
4973 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004974 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
4975 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06004976 }
4977 return skip;
4978}
4979
4980bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05004981 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06004982 bool skip = false;
4983 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004984 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
4985 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06004986 }
4987 return skip;
4988}
Petr Kraus3d720392019-11-13 02:52:39 +01004989
4990bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
4991 VkSemaphore semaphore, VkFence fence,
4992 uint32_t *pImageIndex) const {
4993 bool skip = false;
4994
4995 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07004996 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
4997 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01004998 }
4999
5000 return skip;
5001}
5002
5003bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
5004 uint32_t *pImageIndex) const {
5005 bool skip = false;
5006
5007 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005008 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
5009 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01005010 }
5011
5012 return skip;
5013}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005014
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005015bool StatelessValidation::manual_PreCallValidateCmdBindTransformFeedbackBuffersEXT(VkCommandBuffer commandBuffer,
5016 uint32_t firstBinding, uint32_t bindingCount,
5017 const VkBuffer *pBuffers,
5018 const VkDeviceSize *pOffsets,
5019 const VkDeviceSize *pSizes) const {
5020 bool skip = false;
5021
5022 char const *const cmd_name = "CmdBindTransformFeedbackBuffersEXT";
5023 for (uint32_t i = 0; i < bindingCount; ++i) {
5024 if (pOffsets[i] & 3) {
5025 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pOffsets-02359",
5026 "%s: pOffsets[%" PRIu32 "](0x%" PRIxLEAST64 ") is not a multiple of 4.", cmd_name, i, pOffsets[i]);
5027 }
5028 }
5029
5030 if (firstBinding >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5031 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02356",
5032 "%s: The firstBinding(%" PRIu32
5033 ") index is greater than or equal to "
5034 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5035 cmd_name, firstBinding, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5036 }
5037
5038 if (firstBinding + bindingCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5039 skip |=
5040 LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-firstBinding-02357",
5041 "%s: The sum of firstBinding(%" PRIu32 ") and bindCount(%" PRIu32
5042 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5043 cmd_name, firstBinding, bindingCount, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5044 }
5045
5046 for (uint32_t i = 0; i < bindingCount; ++i) {
5047 // pSizes is optional and may be nullptr.
5048 if (pSizes != nullptr) {
5049 if (pSizes[i] != VK_WHOLE_SIZE &&
5050 pSizes[i] > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferSize) {
5051 skip |= LogError(commandBuffer, "VUID-vkCmdBindTransformFeedbackBuffersEXT-pSize-02361",
5052 "%s: pSizes[%" PRIu32 "] (0x%" PRIxLEAST64
5053 ") is not VK_WHOLE_SIZE and is greater than "
5054 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBufferSize.",
5055 cmd_name, i, pSizes[i]);
5056 }
5057 }
5058 }
5059
5060 return skip;
5061}
5062
5063bool StatelessValidation::manual_PreCallValidateCmdBeginTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5064 uint32_t firstCounterBuffer,
5065 uint32_t counterBufferCount,
5066 const VkBuffer *pCounterBuffers,
5067 const VkDeviceSize *pCounterBufferOffsets) const {
5068 bool skip = false;
5069
5070 char const *const cmd_name = "CmdBeginTransformFeedbackEXT";
5071 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5072 skip |= LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02368",
5073 "%s: The firstCounterBuffer(%" PRIu32
5074 ") index is greater than or equal to "
5075 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5076 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5077 }
5078
5079 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5080 skip |=
5081 LogError(commandBuffer, "VUID-vkCmdBeginTransformFeedbackEXT-firstCounterBuffer-02369",
5082 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5083 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5084 cmd_name, firstCounterBuffer, counterBufferCount,
5085 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5086 }
5087
5088 return skip;
5089}
5090
5091bool StatelessValidation::manual_PreCallValidateCmdEndTransformFeedbackEXT(VkCommandBuffer commandBuffer,
5092 uint32_t firstCounterBuffer, uint32_t counterBufferCount,
5093 const VkBuffer *pCounterBuffers,
5094 const VkDeviceSize *pCounterBufferOffsets) const {
5095 bool skip = false;
5096
5097 char const *const cmd_name = "CmdEndTransformFeedbackEXT";
5098 if (firstCounterBuffer >= phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5099 skip |= LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02376",
5100 "%s: The firstCounterBuffer(%" PRIu32
5101 ") index is greater than or equal to "
5102 "VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5103 cmd_name, firstCounterBuffer, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5104 }
5105
5106 if (firstCounterBuffer + counterBufferCount > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers) {
5107 skip |=
5108 LogError(commandBuffer, "VUID-vkCmdEndTransformFeedbackEXT-firstCounterBuffer-02377",
5109 "%s: The sum of firstCounterBuffer(%" PRIu32 ") and counterBufferCount(%" PRIu32
5110 ") is greater than VkPhysicalDeviceTransformFeedbackPropertiesEXT::maxTransformFeedbackBuffers(%" PRIu32 ").",
5111 cmd_name, firstCounterBuffer, counterBufferCount,
5112 phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBuffers);
5113 }
5114
5115 return skip;
5116}
5117
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005118bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
5119 uint32_t firstInstance, VkBuffer counterBuffer,
5120 VkDeviceSize counterBufferOffset,
5121 uint32_t counterOffset, uint32_t vertexStride) const {
5122 bool skip = false;
5123
5124 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005125 skip |= LogError(
5126 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005127 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
5128 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
5129 }
5130
sfricke-samsungd5e9adb2020-10-26 03:59:29 -07005131 if ((counterOffset % 4) != 0) {
5132 // TODO - Update when header are updated
5133 skip |= LogError(commandBuffer, "UNASSIGNED-vkCmdDrawIndirectByteCountEXT-offset",
5134 "vkCmdDrawIndirectByteCountEXT(): offset (%" PRIu64 ") must be a multiple of 4.", counterOffset);
5135 }
5136
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07005137 return skip;
5138}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005139
5140bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
5141 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5142 const VkAllocationCallbacks *pAllocator,
5143 VkSamplerYcbcrConversion *pYcbcrConversion,
5144 const char *apiName) const {
5145 bool skip = false;
5146
5147 // Check samplerYcbcrConversion feature is set
Tony-LunarG6c3c5452019-12-13 10:37:38 -07005148 const auto *ycbcr_features = lvl_find_in_chain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005149 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005150 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(device_createinfo_pnext);
5151 if ((vulkan_11_features == nullptr) || (vulkan_11_features->samplerYcbcrConversion == VK_FALSE)) {
5152 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
sfricke-samsung83d98122020-07-04 06:21:15 -07005153 "%s: samplerYcbcrConversion must be enabled.", apiName);
Ricardo Garcia3a34ffb2020-06-24 09:36:18 +02005154 }
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005155 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005156
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005157#ifdef VK_USE_PLATFORM_ANDROID_KHR
5158 const VkExternalFormatANDROID *pExternalFormatANDROID = lvl_find_in_chain<VkExternalFormatANDROID>(pCreateInfo);
5159 const bool isExternalFormat = pExternalFormatANDROID != nullptr && pExternalFormatANDROID->externalFormat != 0;
5160#else
5161 const bool isExternalFormat = false;
5162#endif
5163
sfricke-samsung1a72f942020-07-25 12:09:18 -07005164 const VkFormat format = pCreateInfo->format;
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005165
5166 // If there is a VkExternalFormatANDROID with externalFormat != 0, the value of components is ignored.
5167 if (!isExternalFormat) {
5168 const VkComponentMapping components = pCreateInfo->components;
5169 // XChroma Subsampled is same as "the format has a _422 or _420 suffix" from spec
5170 if (FormatIsXChromaSubsampled(format) == true) {
5171 if ((components.g != VK_COMPONENT_SWIZZLE_G) && (components.g != VK_COMPONENT_SWIZZLE_IDENTITY)) {
5172 skip |=
5173 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02581",
sfricke-samsung83d98122020-07-04 06:21:15 -07005174 "%s: When using a XChroma subsampled format (%s) the components.g needs to be VK_COMPONENT_SWIZZLE_G "
5175 "or VK_COMPONENT_SWIZZLE_IDENTITY, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005176 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.g));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005177 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005178
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005179 if ((components.a != VK_COMPONENT_SWIZZLE_A) && (components.a != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5180 (components.a != VK_COMPONENT_SWIZZLE_ONE) && (components.a != VK_COMPONENT_SWIZZLE_ZERO)) {
5181 skip |= LogError(
5182 device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02582",
5183 "%s: When using a XChroma subsampled format (%s) the components.a needs to be VK_COMPONENT_SWIZZLE_A or "
5184 "VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_ONE or VK_COMPONENT_SWIZZLE_ZERO, but is %s.",
5185 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.a));
5186 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005187
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005188 if ((components.r != VK_COMPONENT_SWIZZLE_R) && (components.r != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5189 (components.r != VK_COMPONENT_SWIZZLE_B)) {
5190 skip |=
5191 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02583",
sfricke-samsung83d98122020-07-04 06:21:15 -07005192 "%s: When using a XChroma subsampled format (%s) the components.r needs to be VK_COMPONENT_SWIZZLE_R "
5193 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_B, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005194 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005195 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005196
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005197 if ((components.b != VK_COMPONENT_SWIZZLE_B) && (components.b != VK_COMPONENT_SWIZZLE_IDENTITY) &&
5198 (components.b != VK_COMPONENT_SWIZZLE_R)) {
5199 skip |=
5200 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02584",
sfricke-samsung83d98122020-07-04 06:21:15 -07005201 "%s: When using a XChroma subsampled format (%s) the components.b needs to be VK_COMPONENT_SWIZZLE_B "
5202 "or VK_COMPONENT_SWIZZLE_IDENTITY or VK_COMPONENT_SWIZZLE_R, but is %s.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005203 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005204 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005205
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005206 // If one is identity, both need to be
5207 const bool rIdentity = ((components.r == VK_COMPONENT_SWIZZLE_R) || (components.r == VK_COMPONENT_SWIZZLE_IDENTITY));
5208 const bool bIdentity = ((components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY));
5209 if ((rIdentity != bIdentity) && ((rIdentity == true) || (bIdentity == true))) {
5210 skip |=
5211 LogError(device, "VUID-VkSamplerYcbcrConversionCreateInfo-components-02585",
sfricke-samsung83d98122020-07-04 06:21:15 -07005212 "%s: When using a XChroma subsampled format (%s) if either the components.r (%s) or components.b (%s) "
5213 "are an identity swizzle, then both need to be an identity swizzle.",
sfricke-samsung1a72f942020-07-25 12:09:18 -07005214 apiName, string_VkFormat(format), string_VkComponentSwizzle(components.r),
5215 string_VkComponentSwizzle(components.b));
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005216 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005217 }
5218
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005219 if (pCreateInfo->ycbcrModel != VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY) {
5220 // Checks same VU multiple ways in order to give a more useful error message
5221 const char *vuid = "VUID-VkSamplerYcbcrConversionCreateInfo-ycbcrModel-01655";
5222 if ((components.r == VK_COMPONENT_SWIZZLE_ONE) || (components.r == VK_COMPONENT_SWIZZLE_ZERO) ||
5223 (components.g == VK_COMPONENT_SWIZZLE_ONE) || (components.g == VK_COMPONENT_SWIZZLE_ZERO) ||
5224 (components.b == VK_COMPONENT_SWIZZLE_ONE) || (components.b == VK_COMPONENT_SWIZZLE_ZERO)) {
5225 skip |= LogError(
5226 device, vuid,
5227 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5228 "components.g (%s), nor components.b (%s) can't be VK_COMPONENT_SWIZZLE_ZERO or VK_COMPONENT_SWIZZLE_ONE.",
5229 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5230 string_VkComponentSwizzle(components.b));
5231 }
sfricke-samsung1a72f942020-07-25 12:09:18 -07005232
Benjamin Thautd0bc2a92020-08-25 17:09:09 +02005233 // "must not correspond to a channel which contains zero or one as a consequence of conversion to RGBA"
5234 // 4 channel format = no issue
5235 // 3 = no [a]
5236 // 2 = no [b,a]
5237 // 1 = no [g,b,a]
5238 // depth/stencil = no [g,b,a] (shouldn't ever occur, but no VU preventing it)
5239 const uint32_t channels = (FormatIsDepthOrStencil(format) == true) ? 1 : FormatChannelCount(format);
5240
5241 if ((channels < 4) && ((components.r == VK_COMPONENT_SWIZZLE_A) || (components.g == VK_COMPONENT_SWIZZLE_A) ||
5242 (components.b == VK_COMPONENT_SWIZZLE_A))) {
5243 skip |= LogError(device, vuid,
5244 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5245 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_A.",
5246 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5247 string_VkComponentSwizzle(components.b));
5248 } else if ((channels < 3) &&
5249 ((components.r == VK_COMPONENT_SWIZZLE_B) || (components.g == VK_COMPONENT_SWIZZLE_B) ||
5250 (components.b == VK_COMPONENT_SWIZZLE_B) || (components.b == VK_COMPONENT_SWIZZLE_IDENTITY))) {
5251 skip |= LogError(device, vuid,
5252 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5253 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_B "
5254 "(components.b also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5255 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5256 string_VkComponentSwizzle(components.b));
5257 } else if ((channels < 2) &&
5258 ((components.r == VK_COMPONENT_SWIZZLE_G) || (components.g == VK_COMPONENT_SWIZZLE_G) ||
5259 (components.g == VK_COMPONENT_SWIZZLE_IDENTITY) || (components.b == VK_COMPONENT_SWIZZLE_G))) {
5260 skip |= LogError(device, vuid,
5261 "%s: The ycbcrModel is not VK_SAMPLER_YCBCR_MODEL_CONVERSION_RGB_IDENTITY so components.r (%s), "
5262 "components.g (%s), or components.b (%s) can't be VK_COMPONENT_SWIZZLE_G "
5263 "(components.g also can't be VK_COMPONENT_SWIZZLE_IDENTITY).",
5264 apiName, string_VkComponentSwizzle(components.r), string_VkComponentSwizzle(components.g),
5265 string_VkComponentSwizzle(components.b));
5266 }
sfricke-samsung83d98122020-07-04 06:21:15 -07005267 }
5268 }
5269
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08005270 return skip;
5271}
5272
5273bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
5274 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
5275 const VkAllocationCallbacks *pAllocator,
5276 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5277 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5278 "vkCreateSamplerYcbcrConversion");
5279}
5280
5281bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
5282 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
5283 VkSamplerYcbcrConversion *pYcbcrConversion) const {
5284 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
5285 "vkCreateSamplerYcbcrConversionKHR");
5286}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005287
5288bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
5289 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
5290 bool skip = false;
5291 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
5292 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
5293
5294 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07005295 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
5296 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
5297 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
5298 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
5299 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08005300 }
5301 return skip;
5302}
sourav parmara96ab1a2020-04-25 16:28:23 -07005303
5304bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureToMemoryKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005305 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005306 bool skip = false;
5307 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5308 skip |= LogError(device, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5309 "vkCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5310 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005311 const auto *acc_struct_features = lvl_find_in_chain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
5312 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5313 skip |= LogError(
5314 device, "VUID-vkCopyAccelerationStructureToMemoryKHR-accelerationStructureHostCommands-03584",
5315 "vkCopyAccelerationStructureToMemoryKHR: The "
5316 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5317 }
5318 skip |= validate_required_pointer("vkCopyAccelerationStructureToMemoryKHR", "pInfo->dst.hostAddress", pInfo->dst.hostAddress,
5319 "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03732");
5320 if (SafeModulo((VkDeviceSize)pInfo->dst.hostAddress, 16) != 0) {
5321 skip |= LogError(device, "VUID-vkCopyAccelerationStructureToMemoryKHR-pInfo-03751",
5322 "vkCopyAccelerationStructureToMemoryKHR(): pInfo->dst.hostAddress must be aligned to 16 bytes.");
5323 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005324 return skip;
5325}
5326
5327bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureToMemoryKHR(
5328 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureToMemoryInfoKHR *pInfo) const {
5329 bool skip = false;
5330 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR) {
5331 skip |= // to update VUID to VkCmdCopyAccelerationStructureToMemoryInfoKHR after spec update
5332 LogError(commandBuffer, "VUID-VkCopyAccelerationStructureToMemoryInfoKHR-mode-03412",
5333 "vkCmdCopyAccelerationStructureToMemoryKHR: mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_SERIALIZE_KHR.");
5334 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005335 if (SafeModulo(pInfo->dst.deviceAddress, 256) != 0) {
5336 skip |= LogError(device, "VUID-vkCmdCopyAccelerationStructureToMemoryKHR-pInfo-03740",
5337 "vkCmdCopyAccelerationStructureToMemoryKHR(): pInfo->dst.deviceAddress must be aligned to 256 bytes.",
5338 pInfo->dst.deviceAddress);
sourav parmar83c31b12020-05-06 12:30:54 -07005339 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005340 return skip;
5341}
5342
5343bool StatelessValidation::ValidateCopyAccelerationStructureInfoKHR(const VkCopyAccelerationStructureInfoKHR *pInfo,
5344 const char *api_name) const {
5345 bool skip = false;
5346 if (!(pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR ||
5347 pInfo->mode == VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR)) {
5348 skip |= LogError(device, "VUID-VkCopyAccelerationStructureInfoKHR-mode-03410",
5349 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_COMPACT_KHR"
5350 "or VK_COPY_ACCELERATION_STRUCTURE_MODE_CLONE_KHR.",
5351 api_name);
5352 }
5353 return skip;
5354}
5355
5356bool StatelessValidation::manual_PreCallValidateCopyAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005357 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005358 bool skip = false;
5359 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCopyAccelerationStructureKHR()");
sourav parmarcd5fb182020-07-17 12:58:44 -07005360 const auto *acc_struct_features = lvl_find_in_chain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
5361 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
sourav parmar83c31b12020-05-06 12:30:54 -07005362 skip |= LogError(
sourav parmarcd5fb182020-07-17 12:58:44 -07005363 device, "VUID-vkCopyAccelerationStructureKHR-accelerationStructureHostCommands-03582",
5364 "vkCopyAccelerationStructureKHR: The "
5365 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005366 }
sourav parmara96ab1a2020-04-25 16:28:23 -07005367 return skip;
5368}
5369
5370bool StatelessValidation::manual_PreCallValidateCmdCopyAccelerationStructureKHR(
5371 VkCommandBuffer commandBuffer, const VkCopyAccelerationStructureInfoKHR *pInfo) const {
5372 bool skip = false;
5373 skip |= ValidateCopyAccelerationStructureInfoKHR(pInfo, "vkCmdCopyAccelerationStructureKHR()");
5374 return skip;
5375}
5376
5377bool StatelessValidation::ValidateCopyMemoryToAccelerationStructureInfoKHR(const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo,
Mark Lobodzinskiaad69e42020-05-12 08:44:21 -06005378 const char *api_name, bool is_cmd) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005379 bool skip = false;
5380 if (pInfo->mode != VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR) {
sourav parmar83c31b12020-05-06 12:30:54 -07005381 skip |= LogError(device,
sourav parmarcd5fb182020-07-17 12:58:44 -07005382 "VUID-VkCopyMemoryToAccelerationStructureInfoKHR-mode-03413",
sourav parmara96ab1a2020-04-25 16:28:23 -07005383 "(%s): mode must be VK_COPY_ACCELERATION_STRUCTURE_MODE_DESERIALIZE_KHR.", api_name);
5384 }
5385 return skip;
5386}
5387
5388bool StatelessValidation::manual_PreCallValidateCopyMemoryToAccelerationStructureKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005389 VkDevice device, VkDeferredOperationKHR deferredOperation, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
sourav parmara96ab1a2020-04-25 16:28:23 -07005390 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005391 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCopyMemoryToAccelerationStructureKHR()", true);
sourav parmarcd5fb182020-07-17 12:58:44 -07005392 const auto *acc_struct_features = lvl_find_in_chain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
5393 if (!acc_struct_features || acc_struct_features->accelerationStructureHostCommands == VK_FALSE) {
5394 skip |= LogError(
5395 device, "VUID-vkCopyMemoryToAccelerationStructureKHR-accelerationStructureHostCommands-03583",
5396 "vkCopyMemoryToAccelerationStructureKHR: The "
5397 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005398 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005399 skip |= validate_required_pointer("vkCopyMemoryToAccelerationStructureKHR", "pInfo->src.hostAddress", pInfo->src.hostAddress,
5400 "VUID-vkCopyMemoryToAccelerationStructureKHR-pInfo-03729");
sourav parmara96ab1a2020-04-25 16:28:23 -07005401 return skip;
5402}
Jeremy Hayes9bda85a2020-05-21 16:36:17 -06005403
sourav parmara96ab1a2020-04-25 16:28:23 -07005404bool StatelessValidation::manual_PreCallValidateCmdCopyMemoryToAccelerationStructureKHR(
5405 VkCommandBuffer commandBuffer, const VkCopyMemoryToAccelerationStructureInfoKHR *pInfo) const {
5406 bool skip = false;
sourav parmar83c31b12020-05-06 12:30:54 -07005407 skip |= ValidateCopyMemoryToAccelerationStructureInfoKHR(pInfo, "vkCmdCopyMemoryToAccelerationStructureKHR()", false);
sourav parmarcd5fb182020-07-17 12:58:44 -07005408 if (SafeModulo(pInfo->src.deviceAddress, 256) != 0) {
5409 skip |= LogError(device, "VUID-vkCmdCopyMemoryToAccelerationStructureKHR-pInfo-03743",
5410 "vkCmdCopyMemoryToAccelerationStructureKHR(): pInfo->src.deviceAddress must be aligned to 256 bytes.",
5411 pInfo->src.deviceAddress);
5412 }
sourav parmar83c31b12020-05-06 12:30:54 -07005413 return skip;
5414}
5415bool StatelessValidation::manual_PreCallValidateCmdWriteAccelerationStructuresPropertiesKHR(
5416 VkCommandBuffer commandBuffer, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5417 VkQueryType queryType, VkQueryPool queryPool, uint32_t firstQuery) const {
5418 bool skip = false;
5419 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5420 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5421 skip |= LogError(device, "VUID-vkCmdWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5422 "vkCmdWriteAccelerationStructuresPropertiesKHR: queryType must be "
5423 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5424 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5425 }
5426 return skip;
5427}
5428bool StatelessValidation::manual_PreCallValidateWriteAccelerationStructuresPropertiesKHR(
5429 VkDevice device, uint32_t accelerationStructureCount, const VkAccelerationStructureKHR *pAccelerationStructures,
5430 VkQueryType queryType, size_t dataSize, void *pData, size_t stride) const {
5431 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005432 const auto *acc_structure_features =
5433 lvl_find_in_chain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
5434 if (!acc_structure_features || acc_structure_features->accelerationStructureHostCommands == VK_FALSE) {
5435 skip |= LogError(
5436 device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-accelerationStructureHostCommands-03585",
5437 "vkCmdWriteAccelerationStructuresPropertiesKHR: The "
5438 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled.");
5439 }
sourav parmar83c31b12020-05-06 12:30:54 -07005440 if (dataSize < accelerationStructureCount * stride) {
5441 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-dataSize-03452",
5442 "vkWriteAccelerationStructuresPropertiesKHR: dataSize (%zu) must be greater than or equal to "
5443 "accelerationStructureCount (%d) *stride(%zu).",
5444 dataSize, accelerationStructureCount, stride);
5445 }
5446 if (!(queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR ||
5447 queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR)) {
5448 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03432",
5449 "vkWriteAccelerationStructuresPropertiesKHR: queryType must be "
5450 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR or "
5451 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR.");
5452 }
5453 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR) {
5454 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5455 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03448",
5456 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5457 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_COMPACTED_SIZE_KHR,"
5458 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5459 stride);
5460 }
5461 }
5462 if (queryType == VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR) {
5463 if (SafeModulo(stride, sizeof(VkDeviceSize)) != 0) {
5464 skip |= LogError(device, "VUID-vkWriteAccelerationStructuresPropertiesKHR-queryType-03450",
5465 "vkWriteAccelerationStructuresPropertiesKHR: If queryType is "
5466 "VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE_KHR,"
5467 "then stride (%zu) must be a multiple of the size of VkDeviceSize",
5468 stride);
5469 }
5470 }
sourav parmar83c31b12020-05-06 12:30:54 -07005471 return skip;
5472}
5473bool StatelessValidation::manual_PreCallValidateGetRayTracingCaptureReplayShaderGroupHandlesKHR(
5474 VkDevice device, VkPipeline pipeline, uint32_t firstGroup, uint32_t groupCount, size_t dataSize, void *pData) const {
5475 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005476 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
5477 if (!raytracing_features || raytracing_features->rayTracingPipelineShaderGroupHandleCaptureReplay == VK_FALSE) {
5478 skip |= LogError(
5479 device, "VUID-vkGetRayTracingCaptureReplayShaderGroupHandlesKHR-rayTracingPipelineShaderGroupHandleCaptureReplay-03606",
5480 "vkGetRayTracingCaptureReplayShaderGroupHandlesKHR:VkPhysicalDeviceRayTracingPipelineFeaturesKHR::"
5481 "rayTracingPipelineShaderGroupHandleCaptureReplay must be enabled to call this function.");
sourav parmar83c31b12020-05-06 12:30:54 -07005482 }
5483 return skip;
5484}
5485
5486bool StatelessValidation::manual_PreCallValidateCmdTraceRaysKHR(VkCommandBuffer commandBuffer,
sourav parmarcd5fb182020-07-17 12:58:44 -07005487 const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
5488 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable,
5489 const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
5490 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable,
sourav parmar83c31b12020-05-06 12:30:54 -07005491 uint32_t width, uint32_t height, uint32_t depth) const {
5492 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005493 // RayGen
5494 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
5495 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-size-04023",
5496 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07005497 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005498 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5499 0) {
5500 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03682",
5501 "vkCmdTraceRaysKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
5502 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5503 }
5504 // Callable
5505 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5506 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03694",
5507 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
5508 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005509 }
5510 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5511 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04041",
5512 "vkCmdTraceRaysKHR: The stride member of pCallableShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07005513 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5514 }
5515 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5516 0) {
5517 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03693",
5518 "vkCmdTraceRaysKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
5519 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005520 }
5521 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005522 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5523 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03690",
5524 "vkCmdTraceRaysKHR: The stride member of pHitShaderBindingTable must be a multiple of "
5525 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005526 }
5527 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5528 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07005529 "vkCmdTraceRaysKHR: TThe stride member of pHitShaderBindingTable must be less than or equal to "
5530 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride");
sourav parmar83c31b12020-05-06 12:30:54 -07005531 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005532 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5533 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03689",
5534 "vkCmdTraceRaysKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
5535 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5536 }
sourav parmar83c31b12020-05-06 12:30:54 -07005537 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005538 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5539 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-03686",
5540 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be a multiple of "
5541 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment");
sourav parmar83c31b12020-05-06 12:30:54 -07005542 }
5543 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5544 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-stride-04029",
5545 "vkCmdTraceRaysKHR: The stride member of pMissShaderBindingTable must be"
sourav parmarcd5fb182020-07-17 12:58:44 -07005546 "less than or equal to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5547 }
5548 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5549 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03685",
5550 "vkCmdTraceRaysKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
5551 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5552 }
5553 if (width * depth * height > phys_dev_ext_props.ray_tracing_propsKHR.maxRayDispatchInvocationCount) {
5554 skip |= LogError(device, "VUID-vkCmdTraceRaysKHR-width-03629",
5555 "vkCmdTraceRaysKHR: width {times} height {times} depth must be less than or equal to "
5556 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxRayDispatchInvocationCount");
5557 }
5558 if (width > device_limits.maxComputeWorkGroupCount[0] * device_limits.maxComputeWorkGroupSize[0]) {
5559 skip |=
5560 LogError(device, "VUID-vkCmdTraceRaysKHR-width-03626",
5561 "vkCmdTraceRaysKHR: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[0] "
5562 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[0]");
sourav parmar83c31b12020-05-06 12:30:54 -07005563 }
5564
sourav parmarcd5fb182020-07-17 12:58:44 -07005565 if (height > device_limits.maxComputeWorkGroupCount[1] * device_limits.maxComputeWorkGroupSize[1]) {
5566 skip |=
5567 LogError(device, "VUID-vkCmdTraceRaysKHR-height-03627",
5568 "vkCmdTraceRaysKHR: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1] "
5569 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[1]");
5570 }
5571
5572 if (depth > device_limits.maxComputeWorkGroupCount[2] * device_limits.maxComputeWorkGroupSize[2]) {
5573 skip |=
5574 LogError(device, "VUID-vkCmdTraceRaysKHR-depth-03628",
5575 "vkCmdTraceRaysKHR: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2] "
5576 "{times} VkPhysicalDeviceLimits::maxComputeWorkGroupSize[2]");
sourav parmar83c31b12020-05-06 12:30:54 -07005577 }
5578 return skip;
5579}
5580
sourav parmarcd5fb182020-07-17 12:58:44 -07005581bool StatelessValidation::manual_PreCallValidateCmdTraceRaysIndirectKHR(
5582 VkCommandBuffer commandBuffer, const VkStridedDeviceAddressRegionKHR *pRaygenShaderBindingTable,
5583 const VkStridedDeviceAddressRegionKHR *pMissShaderBindingTable, const VkStridedDeviceAddressRegionKHR *pHitShaderBindingTable,
5584 const VkStridedDeviceAddressRegionKHR *pCallableShaderBindingTable, VkDeviceAddress indirectDeviceAddress) const {
sourav parmar83c31b12020-05-06 12:30:54 -07005585 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005586 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
5587 if (!raytracing_features || raytracing_features->rayTracingPipelineTraceRaysIndirect == VK_FALSE) {
5588 skip |= LogError(
5589 device, "VUID-vkCmdTraceRaysIndirectKHR-rayTracingPipelineTraceRaysIndirect-03637",
5590 "vkCmdTraceRaysIndirectKHR: the VkPhysicalDeviceRayTracingPipelineFeaturesKHR::rayTracingPipelineTraceRaysIndirect "
5591 "feature must be enabled.");
sourav parmar83c31b12020-05-06 12:30:54 -07005592 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005593 // RayGen
5594 if (pRaygenShaderBindingTable->size != pRaygenShaderBindingTable->stride) {
5595 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-size-04023",
5596 "vkCmdTraceRaysKHR: The size member of pRayGenShaderBindingTable must be equal to its stride member");
sourav parmar83c31b12020-05-06 12:30:54 -07005597 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005598 if (SafeModulo(pRaygenShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5599 0) {
5600 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03682",
5601 "vkCmdTraceRaysIndirectKHR: pRaygenShaderBindingTable->deviceAddress must be a multiple of "
5602 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5603 }
5604 // Callabe
5605 if (SafeModulo(pCallableShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5606 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03694",
5607 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be a multiple of "
5608 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005609 }
5610 if (pCallableShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5611 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04041",
sourav parmarcd5fb182020-07-17 12:58:44 -07005612 "vkCmdTraceRaysIndirectKHR: The stride member of pCallableShaderBindingTable must be less than or equal "
5613 "to VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5614 }
5615 if (SafeModulo(pCallableShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) !=
5616 0) {
5617 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03693",
5618 "vkCmdTraceRaysIndirectKHR: pCallableShaderBindingTable->deviceAddress must be a multiple of "
5619 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005620 }
5621 // hitShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005622 if (SafeModulo(pHitShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5623 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03690",
5624 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be a multiple of "
5625 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005626 }
5627 if (pHitShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5628 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04035",
sourav parmarcd5fb182020-07-17 12:58:44 -07005629 "vkCmdTraceRaysIndirectKHR: The stride member of pHitShaderBindingTable must be less than or equal to "
5630 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
sourav parmar83c31b12020-05-06 12:30:54 -07005631 }
sourav parmarcd5fb182020-07-17 12:58:44 -07005632 if (SafeModulo(pHitShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5633 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03689",
5634 "vkCmdTraceRaysIndirectKHR: pHitShaderBindingTable->deviceAddress must be a multiple of "
5635 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
5636 }
sourav parmar83c31b12020-05-06 12:30:54 -07005637 // missShader
sourav parmarcd5fb182020-07-17 12:58:44 -07005638 if (SafeModulo(pMissShaderBindingTable->stride, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupHandleAlignment) != 0) {
5639 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-03686",
5640 "vkCmdTraceRaysIndirectKHR:The stride member of pMissShaderBindingTable must be a multiple of "
5641 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupHandleAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005642 }
5643 if (pMissShaderBindingTable->stride > phys_dev_ext_props.ray_tracing_propsKHR.maxShaderGroupStride) {
5644 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-stride-04029",
sourav parmarcd5fb182020-07-17 12:58:44 -07005645 "vkCmdTraceRaysIndirectKHR: The stride member of pMissShaderBindingTable must be less than or equal to "
5646 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::maxShaderGroupStride.");
5647 }
5648 if (SafeModulo(pMissShaderBindingTable->deviceAddress, phys_dev_ext_props.ray_tracing_propsKHR.shaderGroupBaseAlignment) != 0) {
5649 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03685",
5650 "vkCmdTraceRaysIndirectKHR: pMissShaderBindingTable->deviceAddress must be a multiple of "
5651 "VkPhysicalDeviceRayTracingPipelinePropertiesKHR::shaderGroupBaseAlignment.");
sourav parmar83c31b12020-05-06 12:30:54 -07005652 }
5653
sourav parmarcd5fb182020-07-17 12:58:44 -07005654 if (SafeModulo(indirectDeviceAddress, 4) != 0) {
5655 skip |= LogError(device, "VUID-vkCmdTraceRaysIndirectKHR-indirectDeviceAddress-03634",
5656 "vkCmdTraceRaysIndirectKHR: indirectDeviceAddress must be a multiple of 4.");
sourav parmar83c31b12020-05-06 12:30:54 -07005657 }
5658 return skip;
5659}
5660bool StatelessValidation::manual_PreCallValidateCmdTraceRaysNV(
5661 VkCommandBuffer commandBuffer, VkBuffer raygenShaderBindingTableBuffer, VkDeviceSize raygenShaderBindingOffset,
5662 VkBuffer missShaderBindingTableBuffer, VkDeviceSize missShaderBindingOffset, VkDeviceSize missShaderBindingStride,
5663 VkBuffer hitShaderBindingTableBuffer, VkDeviceSize hitShaderBindingOffset, VkDeviceSize hitShaderBindingStride,
5664 VkBuffer callableShaderBindingTableBuffer, VkDeviceSize callableShaderBindingOffset, VkDeviceSize callableShaderBindingStride,
5665 uint32_t width, uint32_t height, uint32_t depth) const {
5666 bool skip = false;
5667 if (SafeModulo(callableShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5668 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingOffset-02462",
5669 "vkCmdTraceRaysNV: callableShaderBindingOffset must be a multiple of "
5670 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5671 }
5672 if (SafeModulo(callableShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5673 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02465",
5674 "vkCmdTraceRaysNV: callableShaderBindingStride must be a multiple of "
5675 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5676 }
5677 if (callableShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5678 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-callableShaderBindingStride-02468",
5679 "vkCmdTraceRaysNV: callableShaderBindingStride must be less than or equal to "
5680 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride. ");
5681 }
5682
5683 // hitShader
5684 if (SafeModulo(hitShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5685 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingOffset-02460",
5686 "vkCmdTraceRaysNV: hitShaderBindingOffset must be a multiple of "
5687 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5688 }
5689 if (SafeModulo(hitShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5690 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02464",
5691 "vkCmdTraceRaysNV: hitShaderBindingStride must be a multiple of "
5692 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5693 }
5694 if (hitShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5695 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-hitShaderBindingStride-02467",
5696 "vkCmdTraceRaysNV: hitShaderBindingStride must be less than or equal to "
5697 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5698 }
5699
5700 // missShader
5701 if (SafeModulo(missShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5702 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingOffset-02458",
5703 "vkCmdTraceRaysNV: missShaderBindingOffset must be a multiple of "
5704 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5705 }
5706 if (SafeModulo(missShaderBindingStride, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupHandleSize) != 0) {
5707 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02463",
5708 "vkCmdTraceRaysNV: missShaderBindingStride must be a multiple of "
5709 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupHandleSize.");
5710 }
5711 if (missShaderBindingStride > phys_dev_ext_props.ray_tracing_propsNV.maxShaderGroupStride) {
5712 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-missShaderBindingStride-02466",
5713 "vkCmdTraceRaysNV: missShaderBindingStride must be less than or equal to "
5714 "VkPhysicalDeviceRayTracingPropertiesNV::maxShaderGroupStride.");
5715 }
5716
5717 // raygenShader
5718 if (SafeModulo(raygenShaderBindingOffset, phys_dev_ext_props.ray_tracing_propsNV.shaderGroupBaseAlignment) != 0) {
5719 skip |= LogError(device, "VUID-vkCmdTraceRaysNV-raygenShaderBindingOffset-02456",
5720 "vkCmdTraceRaysNV: raygenShaderBindingOffset must be a multiple of "
sourav parmard1521802020-06-07 21:49:02 -07005721 "VkPhysicalDeviceRayTracingPropertiesNV::shaderGroupBaseAlignment.");
5722 }
5723 if (width > device_limits.maxComputeWorkGroupCount[0]) {
5724 skip |=
5725 LogError(device, "VUID-vkCmdTraceRaysNV-width-02469",
5726 "vkCmdTraceRaysNV: width must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[o].");
5727 }
5728 if (height > device_limits.maxComputeWorkGroupCount[1]) {
5729 skip |=
5730 LogError(device, "VUID-vkCmdTraceRaysNV-height-02470",
5731 "vkCmdTraceRaysNV: height must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[1].");
5732 }
5733 if (depth > device_limits.maxComputeWorkGroupCount[2]) {
5734 skip |=
5735 LogError(device, "VUID-vkCmdTraceRaysNV-depth-02471",
5736 "vkCmdTraceRaysNV: depth must be less than or equal to VkPhysicalDeviceLimits::maxComputeWorkGroupCount[2].");
sourav parmar83c31b12020-05-06 12:30:54 -07005737 }
5738 return skip;
5739}
5740
sourav parmar83c31b12020-05-06 12:30:54 -07005741bool StatelessValidation::manual_PreCallValidateGetDeviceAccelerationStructureCompatibilityKHR(
sourav parmarcd5fb182020-07-17 12:58:44 -07005742 VkDevice device, const VkAccelerationStructureVersionInfoKHR *pVersionInfo,
5743 VkAccelerationStructureCompatibilityKHR *pCompatibility) const {
sourav parmar83c31b12020-05-06 12:30:54 -07005744 bool skip = false;
sourav parmarcd5fb182020-07-17 12:58:44 -07005745 const auto *rayQuery_features = lvl_find_in_chain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
5746 const auto *raytracing_features = lvl_find_in_chain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
5747 if ((!raytracing_features && !rayQuery_features) || ((rayQuery_features && !(rayQuery_features->rayQuery)) ||
5748 (raytracing_features && !raytracing_features->rayTracingPipeline))) {
5749 skip |= LogError(device, "VUID-vkGetDeviceAccelerationStructureCompatibilityKHR-rayTracingPipeline-03661",
sourav parmar83c31b12020-05-06 12:30:54 -07005750 "vkGetDeviceAccelerationStructureCompatibilityKHR: The rayTracing or rayQuery feature must be enabled.");
5751 }
5752 return skip;
5753}
5754
Piers Daniell39842ee2020-07-10 16:42:33 -06005755bool StatelessValidation::manual_PreCallValidateCmdSetViewportWithCountEXT(VkCommandBuffer commandBuffer, uint32_t viewportCount,
5756 const VkViewport *pViewports) const {
5757 bool skip = false;
5758
5759 if (!physical_device_features.multiViewport) {
5760 if (viewportCount != 1) {
5761 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03395",
5762 "vkCmdSetViewportWithCountEXT: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
5763 ") is not 1.",
5764 viewportCount);
5765 }
5766 } else { // multiViewport enabled
5767 if (viewportCount < 1 || viewportCount > device_limits.maxViewports) {
5768 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWithCountEXT-viewportCount-03394",
5769 "vkCmdSetViewportWithCountEXT: viewportCount (=%" PRIu32
5770 ") must "
5771 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5772 viewportCount, device_limits.maxViewports);
5773 }
5774 }
5775
5776 if (pViewports) {
5777 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
5778 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
5779 const char *fn_name = "vkCmdSetViewportWithCountEXT";
5780 skip |= manual_PreCallValidateViewport(
5781 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
5782 }
5783 }
5784
5785 return skip;
5786}
5787
5788bool StatelessValidation::manual_PreCallValidateCmdSetScissorWithCountEXT(VkCommandBuffer commandBuffer, uint32_t scissorCount,
5789 const VkRect2D *pScissors) const {
5790 bool skip = false;
5791
5792 if (!physical_device_features.multiViewport) {
5793 if (scissorCount != 1) {
5794 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03398",
5795 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5796 ") must "
5797 "be 1 when the multiViewport feature is disabled.",
5798 scissorCount);
5799 }
5800 } else { // multiViewport enabled
5801 if (scissorCount == 0) {
5802 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5803 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5804 ") must "
5805 "be great than zero.",
5806 scissorCount);
5807 } else if (scissorCount > device_limits.maxViewports) {
5808 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-scissorCount-03397",
5809 "vkCmdSetScissorWithCountEXT: scissorCount (=%" PRIu32
5810 ") must "
5811 "not be greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
5812 scissorCount, device_limits.maxViewports);
5813 }
5814 }
5815
5816 if (pScissors) {
5817 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
5818 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
5819
5820 if (scissor.offset.x < 0) {
5821 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5822 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
5823 scissor.offset.x);
5824 }
5825
5826 if (scissor.offset.y < 0) {
5827 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-x-03399",
5828 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
5829 scissor.offset.y);
5830 }
5831
5832 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
5833 if (x_sum > INT32_MAX) {
5834 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03400",
5835 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5836 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5837 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
5838 }
5839
5840 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
5841 if (y_sum > INT32_MAX) {
5842 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissorWithCountEXT-offset-03401",
5843 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
5844 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
5845 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
5846 }
5847 }
5848 }
5849
5850 return skip;
5851}
5852
5853bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers2EXT(VkCommandBuffer commandBuffer, uint32_t firstBinding,
5854 uint32_t bindingCount, const VkBuffer *pBuffers,
5855 const VkDeviceSize *pOffsets, const VkDeviceSize *pSizes,
5856 const VkDeviceSize *pStrides) const {
5857 bool skip = false;
5858 if (firstBinding >= device_limits.maxVertexInputBindings) {
5859 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03355",
5860 "vkCmdBindVertexBuffers2EXT() firstBinding (%u) must be less than maxVertexInputBindings (%u)",
5861 firstBinding, device_limits.maxVertexInputBindings);
5862 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
5863 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-firstBinding-03356",
5864 "vkCmdBindVertexBuffers2EXT() sum of firstBinding (%u) and bindingCount (%u) must be less than "
5865 "maxVertexInputBindings (%u)",
5866 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
5867 }
5868
5869 for (uint32_t i = 0; i < bindingCount; ++i) {
5870 if (pBuffers[i] == VK_NULL_HANDLE) {
5871 const auto *robustness2_features = lvl_find_in_chain<VkPhysicalDeviceRobustness2FeaturesEXT>(device_createinfo_pnext);
5872 if (!(robustness2_features && robustness2_features->nullDescriptor)) {
5873 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04111",
5874 "vkCmdBindVertexBuffers2EXT() required parameter pBuffers[%d] specified as VK_NULL_HANDLE", i);
5875 } else {
5876 if (pOffsets[i] != 0) {
5877 skip |=
5878 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pBuffers-04112",
5879 "vkCmdBindVertexBuffers2EXT() pBuffers[%d] is VK_NULL_HANDLE, but pOffsets[%d] is not 0", i, i);
5880 }
5881 }
5882 }
5883 if (pStrides) {
5884 if (pStrides[i] > device_limits.maxVertexInputBindingStride) {
5885 skip |=
5886 LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers2EXT-pStrides-03362",
5887 "vkCmdBindVertexBuffers2EXT() pStrides[%d] (%u) must be less than maxVertexInputBindingStride (%u)", i,
5888 pStrides[i], device_limits.maxVertexInputBindingStride);
5889 }
5890 }
5891 }
5892
5893 return skip;
5894}
sourav parmarcd5fb182020-07-17 12:58:44 -07005895
5896bool StatelessValidation::ValidateAccelerationStructureBuildGeometryInfoKHR(
5897 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos, uint32_t infoCount, const char *api_name) const {
5898 bool skip = false;
5899 for (uint32_t i = 0; i < infoCount; ++i) {
5900 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR) {
5901 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03654",
5902 "(%s): type must not be VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.", api_name);
5903 }
5904 if (pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR &&
5905 pInfos[i].flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR) {
5906 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-flags-03796",
5907 "(%s): If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR bit set,"
5908 "then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_KHR bit set.",
5909 api_name);
5910 }
5911 if (pInfos[i].pGeometries && pInfos[i].ppGeometries) {
5912 skip |=
5913 LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-pGeometries-03788",
5914 "(%s): Only one of pGeometries or ppGeometries can be a valid pointer, the other must be NULL", api_name);
5915 }
5916 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR && pInfos[i].geometryCount != 1) {
5917 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03790",
5918 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, geometryCount must be 1", api_name);
5919 }
5920 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR &&
5921 pInfos[i].geometryCount > phys_dev_ext_props.acc_structure_props.maxGeometryCount) {
5922 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03793",
5923 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then geometryCount must be"
5924 " less than or equal to VkPhysicalDeviceAccelerationStructurePropertiesKHR::maxGeometryCount",
5925 api_name);
5926 }
5927 if (pInfos[i].pGeometries) {
5928 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
5929 skip |= validate_ranged_enum(
5930 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometryType", ParameterName::IndexVector{i, j}),
5931 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].pGeometries[j].geometryType,
5932 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
5933 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
5934 if (pInfos[i].pGeometries[j].geometry.triangles.maxVertex <= 0) {
5935 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-maxVertex-03655",
5936 "(%s): maxVertex must be greater than 0", api_name);
5937 }
5938 skip |= validate_struct_type(
5939 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles", ParameterName::IndexVector{i, j}),
5940 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
5941 &(pInfos[i].pGeometries[j].geometry.triangles),
5942 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
5943 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
5944 skip |= validate_struct_pnext(
5945 api_name,
5946 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
5947 NULL, pInfos[i].pGeometries[j].geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
5948 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
5949 skip |=
5950 validate_ranged_enum(api_name,
5951 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.vertexFormat",
5952 ParameterName::IndexVector{i, j}),
5953 "VkFormat", AllVkFormatEnums, pInfos[i].pGeometries[j].geometry.triangles.vertexFormat,
5954 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
5955 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
5956 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
5957 &pInfos[i].pGeometries[j].geometry.triangles,
5958 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
5959 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
5960 skip |= validate_ranged_enum(
5961 api_name,
5962 ParameterName("pInfos[%i].pGeometries[%i].geometry.triangles.indexType", ParameterName::IndexVector{i, j}),
5963 "VkIndexType", AllVkIndexTypeEnums, pInfos[i].pGeometries[j].geometry.triangles.indexType,
5964 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
5965
5966 if (pInfos[i].pGeometries[j].geometry.triangles.vertexStride > UINT32_MAX) {
5967 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
5968 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
5969 }
5970 if (pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
5971 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
5972 pInfos[i].pGeometries[j].geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
5973 skip |=
5974 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
5975 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
5976 api_name);
5977 }
5978 }
5979 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
5980 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
5981 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
5982 &pInfos[i].pGeometries[j].geometry.instances,
5983 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
5984 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
5985 skip |= validate_struct_type(
5986 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.instances", ParameterName::IndexVector{i, j}),
5987 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
5988 &(pInfos[i].pGeometries[j].geometry.instances),
5989 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
5990 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
5991 skip |= validate_struct_pnext(
5992 api_name,
5993 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.pNext", ParameterName::IndexVector{i, j}),
5994 NULL, pInfos[i].pGeometries[j].geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
5995 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
5996
5997 skip |= validate_bool32(api_name,
5998 ParameterName("pInfos[%i].pGeometries[%i].geometry.instances.arrayOfPointers",
5999 ParameterName::IndexVector{i, j}),
6000 pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers);
6001 }
6002 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6003 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6004 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6005 &pInfos[i].pGeometries[j].geometry.aabbs,
6006 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6007 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6008 skip |= validate_struct_type(
6009 api_name, ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs", ParameterName::IndexVector{i, j}),
6010 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6011 &(pInfos[i].pGeometries[j].geometry.aabbs),
6012 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6013 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6014 skip |= validate_struct_pnext(
6015 api_name,
6016 ParameterName("pInfos[%i].pGeometries[%i].geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6017 pInfos[i].pGeometries[j].geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6018 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6019 if (pInfos[i].pGeometries[j].geometry.aabbs.stride > UINT32_MAX) {
6020 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6021 "(%s):stride must be less than or equal to 2^32-1", api_name);
6022 }
6023 }
6024 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6025 pInfos[i].pGeometries[j].geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6026 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6027 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6028 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6029 api_name);
6030 }
6031 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6032 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6033 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6034 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6035 "of elements of"
6036 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6037 api_name);
6038 }
6039 if (pInfos[i].pGeometries[j].geometryType != pInfos[i].pGeometries[0].geometryType) {
6040 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6041 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6042 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6043 api_name);
6044 }
6045 }
6046 }
6047 }
6048 if (pInfos[i].ppGeometries != NULL) {
6049 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6050 skip |= validate_ranged_enum(
6051 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometryType", ParameterName::IndexVector{i, j}),
6052 "VkGeometryTypeKHR", AllVkGeometryTypeKHREnums, pInfos[i].ppGeometries[j]->geometryType,
6053 "VUID-VkAccelerationStructureGeometryKHR-geometryType-parameter");
6054 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6055 if (pInfos[i].ppGeometries[j]->geometry.triangles.maxVertex <= 0) {
6056 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-maxVertex-03655",
6057 "(%s): maxVertex must be greater than 0", api_name);
6058 }
6059 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.triangles",
6060 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6061 &pInfos[i].ppGeometries[j]->geometry.triangles,
6062 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, true,
6063 "VUID-VkAccelerationStructureGeometryKHR-triangles-parameter", kVUIDUndefined);
6064 skip |= validate_struct_type(
6065 api_name,
6066 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles", ParameterName::IndexVector{i, j}),
6067 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR",
6068 &(pInfos[i].ppGeometries[j]->geometry.triangles),
6069 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR, false, kVUIDUndefined,
6070 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-sType-sType");
6071 skip |= validate_struct_pnext(
6072 api_name,
6073 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.pNext", ParameterName::IndexVector{i, j}),
6074 NULL, pInfos[i].ppGeometries[j]->geometry.triangles.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6075 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-pNext-pNext", kVUIDUndefined);
6076 skip |= validate_ranged_enum(api_name,
6077 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.vertexFormat",
6078 ParameterName::IndexVector{i, j}),
6079 "VkFormat", AllVkFormatEnums,
6080 pInfos[i].ppGeometries[j]->geometry.triangles.vertexFormat,
6081 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexFormat-parameter");
6082 skip |= validate_ranged_enum(api_name,
6083 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.triangles.indexType",
6084 ParameterName::IndexVector{i, j}),
6085 "VkIndexType", AllVkIndexTypeEnums,
6086 pInfos[i].ppGeometries[j]->geometry.triangles.indexType,
6087 "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-parameter");
6088 if (pInfos[i].ppGeometries[j]->geometry.triangles.vertexStride > UINT32_MAX) {
6089 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-vertexStride-03819",
6090 "(%s):vertexStride must be less than or equal to 2^32-1", api_name);
6091 }
6092 if (pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT16 &&
6093 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_UINT32 &&
6094 pInfos[i].ppGeometries[j]->geometry.triangles.indexType != VK_INDEX_TYPE_NONE_KHR) {
6095 skip |=
6096 LogError(device, "VUID-VkAccelerationStructureGeometryTrianglesDataKHR-indexType-03798",
6097 "(%s):indexType must be VK_INDEX_TYPE_UINT16, VK_INDEX_TYPE_UINT32, or VK_INDEX_TYPE_NONE_KHR",
6098 api_name);
6099 }
6100 }
6101 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6102 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.instances",
6103 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6104 &pInfos[i].ppGeometries[j]->geometry.instances,
6105 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, true,
6106 "VUID-VkAccelerationStructureGeometryKHR-instances-parameter", kVUIDUndefined);
6107 skip |= validate_struct_type(
6108 api_name,
6109 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances", ParameterName::IndexVector{i, j}),
6110 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR",
6111 &(pInfos[i].ppGeometries[j]->geometry.instances),
6112 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR, false, kVUIDUndefined,
6113 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-sType-sType");
6114 skip |= validate_struct_pnext(
6115 api_name,
6116 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.pNext", ParameterName::IndexVector{i, j}),
6117 NULL, pInfos[i].ppGeometries[j]->geometry.instances.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6118 "VUID-VkAccelerationStructureGeometryInstancesDataKHR-pNext-pNext", kVUIDUndefined);
6119 skip |= validate_bool32(api_name,
6120 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.instances.arrayOfPointers",
6121 ParameterName::IndexVector{i, j}),
6122 pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers);
6123 }
6124 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6125 skip |= validate_struct_type(api_name, "pInfos[i].pGeometries[j].geometry.aabbs",
6126 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6127 &pInfos[i].ppGeometries[j]->geometry.aabbs,
6128 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, true,
6129 "VUID-VkAccelerationStructureGeometryKHR-aabbs-parameter", kVUIDUndefined);
6130 skip |= validate_struct_type(
6131 api_name, ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs", ParameterName::IndexVector{i, j}),
6132 "VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR",
6133 &(pInfos[i].ppGeometries[j]->geometry.aabbs),
6134 VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_AABBS_DATA_KHR, false, kVUIDUndefined,
6135 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-sType-sType");
6136 skip |= validate_struct_pnext(
6137 api_name,
6138 ParameterName("pInfos[%i].ppGeometries[%i]->geometry.aabbs.pNext", ParameterName::IndexVector{i, j}), NULL,
6139 pInfos[i].ppGeometries[j]->geometry.aabbs.pNext, 0, NULL, GeneratedVulkanHeaderVersion,
6140 "VUID-VkAccelerationStructureGeometryAabbsDataKHR-pNext-pNext", kVUIDUndefined);
6141 if (pInfos[i].ppGeometries[j]->geometry.aabbs.stride > UINT32_MAX) {
6142 skip |= LogError(device, "VUID-VkAccelerationStructureGeometryAabbsDataKHR-stride-03820",
6143 "(%s):stride must be less than or equal to 2^32-1", api_name);
6144 }
6145 }
6146 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR &&
6147 pInfos[i].ppGeometries[j]->geometryType != VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6148 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03789",
6149 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR, the geometryType member"
6150 " of elements of either pGeometries or ppGeometries must be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6151 api_name);
6152 }
6153 if (pInfos[i].type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR) {
6154 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6155 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03791",
6156 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR the geometryType member "
6157 "of elements of"
6158 " either pGeometries or ppGeometries must not be VK_GEOMETRY_TYPE_INSTANCES_KHR",
6159 api_name);
6160 }
6161 if (pInfos[i].ppGeometries[j]->geometryType != pInfos[i].ppGeometries[0]->geometryType) {
6162 skip |= LogError(device, "VUID-VkAccelerationStructureBuildGeometryInfoKHR-type-03792",
6163 "(%s): If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR then the geometryType"
6164 " member of each geometry in either pGeometries or ppGeometries must be the same.",
6165 api_name);
6166 }
6167 }
6168 }
6169 }
6170 }
6171 return skip;
6172}
6173bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresKHR(
6174 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6175 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6176 bool skip = false;
6177 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresKHR");
6178 for (uint32_t i = 0; i < infoCount; ++i) {
6179 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6180 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6181 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03710",
6182 "vkCmdBuildAccelerationStructuresKHR:For each element of pInfos, its "
6183 "scratchData.deviceAddress member must be a multiple of "
6184 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6185 }
6186 for (uint32_t k = 0; k < infoCount; ++k) {
6187 if (i == k) continue;
6188 bool found = false;
6189 if (pInfos[i].dstAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6190 skip |= LogError(
6191 device, "VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6192 "vkCmdBuildAccelerationStructuresKHR:The dstAccelerationStructure member of any element (%d) of pInfos must "
6193 "not be "
6194 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6195 i, k);
6196 found = true;
6197 }
6198 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6199 skip |= LogError(
6200 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03403",
6201 "vkCmdBuildAccelerationStructuresKHR:The srcAccelerationStructure member of any element (%d) of pInfos must "
6202 "not be "
6203 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6204 i, k);
6205 found = true;
6206 }
6207 if (found) break;
6208 }
6209 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6210 if (pInfos[i].pGeometries) {
6211 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6212 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6213 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6214 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6215 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6216 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6217 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6218 }
6219 } else {
6220 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6221 skip |=
6222 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6223 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6224 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6225 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6226 }
6227 }
6228 }
6229 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6230 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6231 skip |= LogError(
6232 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6233 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6234 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6235 }
6236 }
6237 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6238 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.indexData.deviceAddress, 16) != 0) {
6239 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6240 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6241 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6242 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6243 }
6244 }
6245 } else if (pInfos[i].ppGeometries) {
6246 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6247 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6248 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6249 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03716",
6250 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6251 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6252 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6253 }
6254 } else {
6255 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6256 skip |=
6257 LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03715",
6258 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6259 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6260 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6261 }
6262 }
6263 }
6264 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6265 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6266 skip |= LogError(
6267 device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03714",
6268 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries with a "
6269 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6270 }
6271 }
6272 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6273 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.indexData.deviceAddress, 16) != 0) {
6274 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03810",
6275 "vkCmdBuildAccelerationStructuresKHR:For any element of pInfos[i].pGeometries "
6276 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6277 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6278 }
6279 }
6280 }
6281 }
6282 }
6283 return skip;
6284}
6285
6286bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructuresIndirectKHR(
6287 VkCommandBuffer commandBuffer, uint32_t infoCount, const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6288 const VkDeviceAddress *pIndirectDeviceAddresses, const uint32_t *pIndirectStrides,
6289 const uint32_t *const *ppMaxPrimitiveCounts) const {
6290 bool skip = false;
6291 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkCmdBuildAccelerationStructuresIndirectKHR");
6292 const auto *ray_tracing_acceleration_structure_features =
6293 lvl_find_in_chain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
6294 if (!ray_tracing_acceleration_structure_features ||
6295 ray_tracing_acceleration_structure_features->accelerationStructureIndirectBuild == VK_FALSE) {
6296 skip |= LogError(
6297 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-accelerationStructureIndirectBuild-03650",
6298 "vkCmdBuildAccelerationStructuresIndirectKHR: The "
6299 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureIndirectBuild feature must be enabled.");
6300 }
6301 for (uint32_t i = 0; i < infoCount; ++i) {
6302 if (pInfos[i].mode == VK_BUILD_ACCELERATION_STRUCTURE_MODE_UPDATE_KHR) {
6303 if (pInfos[i].srcAccelerationStructure == VK_NULL_HANDLE) {
6304 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03666",
6305 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, if its mode member is "
6306 "VK_BUILD_ACCELERATION_STRUCTURE_MODE_UPDATE_KHR, its srcAccelerationStructure member must not be "
6307 "VK_NULL_HANDLE.");
6308 }
6309 }
6310 if (SafeModulo(pInfos[i].scratchData.deviceAddress,
6311 phys_dev_ext_props.acc_structure_props.minAccelerationStructureScratchOffsetAlignment) != 0) {
6312 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03710",
6313 "vkCmdBuildAccelerationStructuresIndirectKHR:For each element of pInfos, its "
6314 "scratchData.deviceAddress member must be a multiple of "
6315 "VkPhysicalDeviceAccelerationStructurePropertiesKHR::minAccelerationStructureScratchOffsetAlignment.");
6316 }
6317 for (uint32_t k = 0; k < infoCount; ++k) {
6318 if (i == k) continue;
6319 if (pInfos[i].srcAccelerationStructure == pInfos[k].dstAccelerationStructure) {
6320 skip |=
6321 LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03403",
6322 "vkCmdBuildAccelerationStructuresIndirectKHR:The srcAccelerationStructure member of any element (%d) "
6323 "of pInfos must not be the same acceleration structure as the dstAccelerationStructure member of "
6324 "any other element [%d) of pInfos.",
6325 i, k);
6326 break;
6327 }
6328 }
6329 for (uint32_t j = 0; j < pInfos[i].geometryCount; ++j) {
6330 if (pInfos[i].pGeometries) {
6331 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6332 if (pInfos[i].pGeometries[j].geometry.instances.arrayOfPointers == VK_TRUE) {
6333 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6334 skip |= LogError(
6335 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6336 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6337 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6338 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6339 }
6340 } else {
6341 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 16) != 0) {
6342 skip |= LogError(
6343 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6344 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6345 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6346 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6347 }
6348 }
6349 }
6350 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6351 if (SafeModulo(pInfos[i].pGeometries[j].geometry.instances.data.deviceAddress, 8) != 0) {
6352 skip |= LogError(
6353 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6354 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6355 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6356 }
6357 }
6358 if (pInfos[i].pGeometries[j].geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6359 if (SafeModulo(pInfos[i].pGeometries[j].geometry.triangles.indexData.deviceAddress, 16) != 0) {
6360 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6361 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6362 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6363 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6364 }
6365 }
6366 } else if (pInfos[i].ppGeometries) {
6367 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_INSTANCES_KHR) {
6368 if (pInfos[i].ppGeometries[j]->geometry.instances.arrayOfPointers == VK_TRUE) {
6369 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6370 skip |= LogError(
6371 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03716",
6372 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6373 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is "
6374 "VK_TRUE, geometry.data->deviceAddress must be aligned to 8 bytes.");
6375 }
6376 } else {
6377 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 16) != 0) {
6378 skip |= LogError(
6379 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03715",
6380 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6381 "geometryType of VK_GEOMETRY_TYPE_INSTANCES_KHR, if geometry.arrayOfPointers is VK_FALSE, "
6382 "geometry.data->deviceAddress must be aligned to 16 bytes.");
6383 }
6384 }
6385 }
6386 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_AABBS_KHR) {
6387 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.instances.data.deviceAddress, 8) != 0) {
6388 skip |= LogError(
6389 device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03714",
6390 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries with a "
6391 "geometryType of VK_GEOMETRY_TYPE_AABBS_KHR, geometry.data->deviceAddress must be aligned to 8 bytes.");
6392 }
6393 }
6394 if (pInfos[i].ppGeometries[j]->geometryType == VK_GEOMETRY_TYPE_TRIANGLES_KHR) {
6395 if (SafeModulo(pInfos[i].ppGeometries[j]->geometry.triangles.indexData.deviceAddress, 16) != 0) {
6396 skip |= LogError(device, "VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-03810",
6397 "vkCmdBuildAccelerationStructuresIndirectKHR:For any element of pInfos[i].pGeometries "
6398 "with a geometryType of VK_GEOMETRY_TYPE_TRIANGLES_KHR, "
6399 "geometry.transformData->deviceAddress must be aligned to 16 bytes.");
6400 }
6401 }
6402 }
6403 }
6404 }
6405 return skip;
6406}
6407
6408bool StatelessValidation::manual_PreCallValidateBuildAccelerationStructuresKHR(
6409 VkDevice device, VkDeferredOperationKHR deferredOperation, uint32_t infoCount,
6410 const VkAccelerationStructureBuildGeometryInfoKHR *pInfos,
6411 const VkAccelerationStructureBuildRangeInfoKHR *const *ppBuildRangeInfos) const {
6412 bool skip = false;
6413 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pInfos, infoCount, "vkBuildAccelerationStructuresKHR");
6414 const auto *ray_tracing_acceleration_structure_features =
6415 lvl_find_in_chain<VkPhysicalDeviceAccelerationStructureFeaturesKHR>(device_createinfo_pnext);
6416 if (!ray_tracing_acceleration_structure_features ||
6417 ray_tracing_acceleration_structure_features->accelerationStructureHostCommands == VK_FALSE) {
6418 skip |=
6419 LogError(device, "VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581",
6420 "vkBuildAccelerationStructuresKHR: The "
6421 "VkPhysicalDeviceAccelerationStructureFeaturesKHR::accelerationStructureHostCommands feature must be enabled");
6422 }
6423 for (uint32_t i = 0; i < infoCount; ++i) {
6424 for (uint32_t j = 0; j < infoCount; ++j) {
6425 if (i == j) continue;
6426 bool found = false;
6427 if (pInfos[i].dstAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6428 skip |= LogError(
6429 device, "VUID-vkBuildAccelerationStructuresKHR-dstAccelerationStructure-03698",
6430 "vkBuildAccelerationStructuresKHR(): The dstAccelerationStructure member of any element (%d) of pInfos must "
6431 "not be "
6432 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6433 i, j);
6434 found = true;
6435 }
6436 if (pInfos[i].srcAccelerationStructure == pInfos[j].dstAccelerationStructure) {
6437 skip |= LogError(
6438 device, "VUID-vkBuildAccelerationStructuresKHR-pInfos-03403",
6439 "vkBuildAccelerationStructuresKHR(): The srcAccelerationStructure member of any element (%d) of pInfos must "
6440 "not be "
6441 "the same acceleration structure as the dstAccelerationStructure member of any other element (%d) of pInfos.",
6442 i, j);
6443 found = true;
6444 }
6445 if (found) break;
6446 }
6447 }
6448 return skip;
6449}
6450
6451bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureBuildSizesKHR(
6452 VkDevice device, VkAccelerationStructureBuildTypeKHR buildType, const VkAccelerationStructureBuildGeometryInfoKHR *pBuildInfo,
6453 const uint32_t *pMaxPrimitiveCounts, VkAccelerationStructureBuildSizesInfoKHR *pSizeInfo) const {
6454 bool skip = false;
6455 skip |= ValidateAccelerationStructureBuildGeometryInfoKHR(pBuildInfo, 1, "vkGetAccelerationStructureBuildSizesKHR");
6456 const auto *ray_tracing_pipeline_features =
6457 lvl_find_in_chain<VkPhysicalDeviceRayTracingPipelineFeaturesKHR>(device_createinfo_pnext);
6458 const auto *ray_query_features = lvl_find_in_chain<VkPhysicalDeviceRayQueryFeaturesKHR>(device_createinfo_pnext);
6459 if (!(ray_tracing_pipeline_features || ray_query_features) ||
6460 ((ray_tracing_pipeline_features && ray_tracing_pipeline_features->rayTracingPipeline == VK_FALSE) ||
6461 (ray_query_features && ray_query_features->rayQuery == VK_FALSE))) {
6462 skip |= LogError(device, "VUID-vkGetAccelerationStructureBuildSizesKHR-rayTracingPipeline-03617",
6463 "vkGetAccelerationStructureBuildSizesKHR:The rayTracingPipeline or rayQuery feature must be enabled");
6464 }
6465 return skip;
6466}