commit 73e58c82957fa9e66b51b0715ed91653c795e97c
author Shannon McPherson <shannon@lunarg.com> Fri Mar 05 17:14:26 2021 -0700
committer Shannon McPherson <shannon@lunarg.com> Thu Apr 01 12:39:43 2021 -0600
tree 8304b09684a3f9a4979bf19c267781c85ea32a05
parent 68eab1e7055abcbb83903213ba892b136021e98c

layers: Remove warning if present mode is FIFO_KHR

A present mode of `VK_PRESENT_MODE_FIFO_KHR` is required to be
supported, so this is now checked and no longer issues a warning
about `vkCreateSwapchainKHR()` being called before first getting surface
present mode(s) from `vkGetPhysicalDeviceSurfacePresentModesKHR()`

Resolves #2602

Change-Id: I094195d835f1374ddfc959c81beba4c3a12377d3

layers/best_practices_utils.cpp

diff --git a/layers/best_practices_utils.cpp b/layers/best_practices_utils.cpp
index 2750181..d71d9fc 100644
--- a/layers/best_practices_utils.cpp
+++ b/layers/best_practices_utils.cpp
@@ -301,7 +301,8 @@
                                "vkGetPhysicalDeviceSurfaceCapabilitiesKHR().");
         }
 
-        if (bp_pd_state->vkGetPhysicalDeviceSurfacePresentModesKHRState != QUERY_DETAILS) {
+        if ((pCreateInfo->presentMode != VK_PRESENT_MODE_FIFO_KHR) &&
+            (bp_pd_state->vkGetPhysicalDeviceSurfacePresentModesKHRState != QUERY_DETAILS)) {
             skip |= LogWarning(device, kVUID_BestPractices_Swapchain_GetSurfaceNotCalled,
                                "vkCreateSwapchainKHR() called before getting surface present mode(s) from "
                                "vkGetPhysicalDeviceSurfacePresentModesKHR().");