blob: f813f998c35430270e8ed7b59ca2d003ac12f2cf [file] [log] [blame]
Greg Fischer04fcc662016-11-10 10:11:50 -07001// Copyright (c) 2017 The Khronos Group Inc.
2// Copyright (c) 2017 Valve Corporation
3// Copyright (c) 2017 LunarG Inc.
4//
5// Licensed under the Apache License, Version 2.0 (the "License");
6// you may not use this file except in compliance with the License.
7// You may obtain a copy of the License at
8//
9// http://www.apache.org/licenses/LICENSE-2.0
10//
11// Unless required by applicable law or agreed to in writing, software
12// distributed under the License is distributed on an "AS IS" BASIS,
13// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14// See the License for the specific language governing permissions and
15// limitations under the License.
16
17#include "inline_pass.h"
GregFe28bd392017-08-01 17:20:13 -060018
Greg Fischerbba812f2017-05-04 20:55:53 -060019#include "cfa.h"
Greg Fischer04fcc662016-11-10 10:11:50 -070020
21// Indices of operands in SPIR-V instructions
22
Greg Fischer04fcc662016-11-10 10:11:50 -070023static const int kSpvFunctionCallFunctionId = 2;
24static const int kSpvFunctionCallArgumentId = 3;
25static const int kSpvReturnValueId = 0;
26static const int kSpvTypePointerStorageClass = 1;
27static const int kSpvTypePointerTypeId = 2;
Greg Fischerbba812f2017-05-04 20:55:53 -060028static const int kSpvLoopMergeMergeBlockId = 0;
David Netoefff5fa2017-08-31 15:47:31 -040029static const int kSpvLoopMergeContinueTargetIdInIdx = 1;
Greg Fischer04fcc662016-11-10 10:11:50 -070030
31namespace spvtools {
32namespace opt {
33
34uint32_t InlinePass::FindPointerToType(uint32_t type_id,
35 SpvStorageClass storage_class) {
Diego Novillo1040a952017-10-25 13:26:25 -040036 ir::Module::inst_iterator type_itr = get_module()->types_values_begin();
37 for (; type_itr != get_module()->types_values_end(); ++type_itr) {
Greg Fischer04fcc662016-11-10 10:11:50 -070038 const ir::Instruction* type_inst = &*type_itr;
39 if (type_inst->opcode() == SpvOpTypePointer &&
40 type_inst->GetSingleWordOperand(kSpvTypePointerTypeId) == type_id &&
41 type_inst->GetSingleWordOperand(kSpvTypePointerStorageClass) ==
42 storage_class)
43 return type_inst->result_id();
44 }
45 return 0;
46}
47
48uint32_t InlinePass::AddPointerToType(uint32_t type_id,
49 SpvStorageClass storage_class) {
50 uint32_t resultId = TakeNextId();
51 std::unique_ptr<ir::Instruction> type_inst(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050052 context(), SpvOpTypePointer, 0, resultId,
Greg Fischer04fcc662016-11-10 10:11:50 -070053 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
54 {uint32_t(storage_class)}},
55 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {type_id}}}));
Steven Perron476cae62017-10-30 11:13:24 -040056 context()->AddType(std::move(type_inst));
Greg Fischer04fcc662016-11-10 10:11:50 -070057 return resultId;
58}
59
60void InlinePass::AddBranch(uint32_t label_id,
Diego Novillod2938e42017-11-08 12:40:02 -050061 std::unique_ptr<ir::BasicBlock>* block_ptr) {
Greg Fischer04fcc662016-11-10 10:11:50 -070062 std::unique_ptr<ir::Instruction> newBranch(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050063 context(), SpvOpBranch, 0, 0,
Diego Novillod2938e42017-11-08 12:40:02 -050064 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {label_id}}}));
Greg Fischer04fcc662016-11-10 10:11:50 -070065 (*block_ptr)->AddInstruction(std::move(newBranch));
66}
67
Greg Fischerbba812f2017-05-04 20:55:53 -060068void InlinePass::AddBranchCond(uint32_t cond_id, uint32_t true_id,
Diego Novillod2938e42017-11-08 12:40:02 -050069 uint32_t false_id,
70 std::unique_ptr<ir::BasicBlock>* block_ptr) {
Greg Fischerbba812f2017-05-04 20:55:53 -060071 std::unique_ptr<ir::Instruction> newBranch(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050072 context(), SpvOpBranchConditional, 0, 0,
Diego Novillod2938e42017-11-08 12:40:02 -050073 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {cond_id}},
74 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {true_id}},
75 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {false_id}}}));
Greg Fischerbba812f2017-05-04 20:55:53 -060076 (*block_ptr)->AddInstruction(std::move(newBranch));
77}
78
79void InlinePass::AddLoopMerge(uint32_t merge_id, uint32_t continue_id,
Diego Novillod2938e42017-11-08 12:40:02 -050080 std::unique_ptr<ir::BasicBlock>* block_ptr) {
Greg Fischerbba812f2017-05-04 20:55:53 -060081 std::unique_ptr<ir::Instruction> newLoopMerge(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050082 context(), SpvOpLoopMerge, 0, 0,
Greg Fischerbba812f2017-05-04 20:55:53 -060083 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {merge_id}},
84 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {continue_id}},
85 {spv_operand_type_t::SPV_OPERAND_TYPE_LOOP_CONTROL, {0}}}));
86 (*block_ptr)->AddInstruction(std::move(newLoopMerge));
87}
88
Greg Fischer04fcc662016-11-10 10:11:50 -070089void InlinePass::AddStore(uint32_t ptr_id, uint32_t val_id,
90 std::unique_ptr<ir::BasicBlock>* block_ptr) {
91 std::unique_ptr<ir::Instruction> newStore(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050092 context(), SpvOpStore, 0, 0,
Diego Novillod2938e42017-11-08 12:40:02 -050093 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}},
94 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {val_id}}}));
Greg Fischer04fcc662016-11-10 10:11:50 -070095 (*block_ptr)->AddInstruction(std::move(newStore));
96}
97
98void InlinePass::AddLoad(uint32_t type_id, uint32_t resultId, uint32_t ptr_id,
99 std::unique_ptr<ir::BasicBlock>* block_ptr) {
100 std::unique_ptr<ir::Instruction> newLoad(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -0500101 context(), SpvOpLoad, type_id, resultId,
Greg Fischer04fcc662016-11-10 10:11:50 -0700102 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}}}));
103 (*block_ptr)->AddInstruction(std::move(newLoad));
104}
105
106std::unique_ptr<ir::Instruction> InlinePass::NewLabel(uint32_t label_id) {
107 std::unique_ptr<ir::Instruction> newLabel(
Alan Bakera7717132017-11-14 14:11:50 -0500108 new ir::Instruction(context(), SpvOpLabel, 0, label_id, {}));
Greg Fischer04fcc662016-11-10 10:11:50 -0700109 return newLabel;
110}
111
Greg Fischerbba812f2017-05-04 20:55:53 -0600112uint32_t InlinePass::GetFalseId() {
Diego Novillod2938e42017-11-08 12:40:02 -0500113 if (false_id_ != 0) return false_id_;
Diego Novillo1040a952017-10-25 13:26:25 -0400114 false_id_ = get_module()->GetGlobalValue(SpvOpConstantFalse);
Diego Novillod2938e42017-11-08 12:40:02 -0500115 if (false_id_ != 0) return false_id_;
Diego Novillo1040a952017-10-25 13:26:25 -0400116 uint32_t boolId = get_module()->GetGlobalValue(SpvOpTypeBool);
Greg Fischerbba812f2017-05-04 20:55:53 -0600117 if (boolId == 0) {
118 boolId = TakeNextId();
Diego Novillo1040a952017-10-25 13:26:25 -0400119 get_module()->AddGlobalValue(SpvOpTypeBool, boolId, 0);
Greg Fischerbba812f2017-05-04 20:55:53 -0600120 }
121 false_id_ = TakeNextId();
Diego Novillo1040a952017-10-25 13:26:25 -0400122 get_module()->AddGlobalValue(SpvOpConstantFalse, false_id_, boolId);
Greg Fischerbba812f2017-05-04 20:55:53 -0600123 return false_id_;
124}
125
Greg Fischer04fcc662016-11-10 10:11:50 -0700126void InlinePass::MapParams(
Diego Novillod2938e42017-11-08 12:40:02 -0500127 ir::Function* calleeFn, ir::BasicBlock::iterator call_inst_itr,
Greg Fischer04fcc662016-11-10 10:11:50 -0700128 std::unordered_map<uint32_t, uint32_t>* callee2caller) {
129 int param_idx = 0;
130 calleeFn->ForEachParam(
131 [&call_inst_itr, &param_idx, &callee2caller](const ir::Instruction* cpi) {
132 const uint32_t pid = cpi->result_id();
133 (*callee2caller)[pid] = call_inst_itr->GetSingleWordOperand(
134 kSpvFunctionCallArgumentId + param_idx);
Greg Fischerbba812f2017-05-04 20:55:53 -0600135 ++param_idx;
Greg Fischer04fcc662016-11-10 10:11:50 -0700136 });
137}
138
139void InlinePass::CloneAndMapLocals(
140 ir::Function* calleeFn,
141 std::vector<std::unique_ptr<ir::Instruction>>* new_vars,
142 std::unordered_map<uint32_t, uint32_t>* callee2caller) {
143 auto callee_block_itr = calleeFn->begin();
144 auto callee_var_itr = callee_block_itr->begin();
145 while (callee_var_itr->opcode() == SpvOp::SpvOpVariable) {
Alan Bakera7717132017-11-14 14:11:50 -0500146 std::unique_ptr<ir::Instruction> var_inst(
147 callee_var_itr->Clone(callee_var_itr->context()));
Greg Fischer04fcc662016-11-10 10:11:50 -0700148 uint32_t newId = TakeNextId();
Steven Perroneb4653a2017-11-13 15:31:43 -0500149 get_decoration_mgr()->CloneDecorations(callee_var_itr->result_id(), newId, update_def_use_mgr_);
Greg Fischer04fcc662016-11-10 10:11:50 -0700150 var_inst->SetResultId(newId);
151 (*callee2caller)[callee_var_itr->result_id()] = newId;
152 new_vars->push_back(std::move(var_inst));
Greg Fischerbba812f2017-05-04 20:55:53 -0600153 ++callee_var_itr;
Greg Fischer04fcc662016-11-10 10:11:50 -0700154 }
155}
156
157uint32_t InlinePass::CreateReturnVar(
158 ir::Function* calleeFn,
159 std::vector<std::unique_ptr<ir::Instruction>>* new_vars) {
160 uint32_t returnVarId = 0;
161 const uint32_t calleeTypeId = calleeFn->type_id();
162 const ir::Instruction* calleeType =
Diego Novillo1040a952017-10-25 13:26:25 -0400163 get_def_use_mgr()->id_to_defs().find(calleeTypeId)->second;
Greg Fischer04fcc662016-11-10 10:11:50 -0700164 if (calleeType->opcode() != SpvOpTypeVoid) {
165 // Find or create ptr to callee return type.
166 uint32_t returnVarTypeId =
167 FindPointerToType(calleeTypeId, SpvStorageClassFunction);
168 if (returnVarTypeId == 0)
169 returnVarTypeId = AddPointerToType(calleeTypeId, SpvStorageClassFunction);
170 // Add return var to new function scope variables.
171 returnVarId = TakeNextId();
172 std::unique_ptr<ir::Instruction> var_inst(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -0500173 context(), SpvOpVariable, returnVarTypeId, returnVarId,
Greg Fischer04fcc662016-11-10 10:11:50 -0700174 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
175 {SpvStorageClassFunction}}}));
176 new_vars->push_back(std::move(var_inst));
177 }
Steven Perroneb4653a2017-11-13 15:31:43 -0500178 get_decoration_mgr()->CloneDecorations(calleeFn->result_id(), returnVarId, update_def_use_mgr_);
Greg Fischer04fcc662016-11-10 10:11:50 -0700179 return returnVarId;
180}
181
182bool InlinePass::IsSameBlockOp(const ir::Instruction* inst) const {
183 return inst->opcode() == SpvOpSampledImage || inst->opcode() == SpvOpImage;
184}
185
186void InlinePass::CloneSameBlockOps(
187 std::unique_ptr<ir::Instruction>* inst,
188 std::unordered_map<uint32_t, uint32_t>* postCallSB,
189 std::unordered_map<uint32_t, ir::Instruction*>* preCallSB,
190 std::unique_ptr<ir::BasicBlock>* block_ptr) {
Diego Novillod2938e42017-11-08 12:40:02 -0500191 (*inst)->ForEachInId(
192 [&postCallSB, &preCallSB, &block_ptr, this](uint32_t* iid) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700193 const auto mapItr = (*postCallSB).find(*iid);
194 if (mapItr == (*postCallSB).end()) {
195 const auto mapItr2 = (*preCallSB).find(*iid);
196 if (mapItr2 != (*preCallSB).end()) {
197 // Clone pre-call same-block ops, map result id.
198 const ir::Instruction* inInst = mapItr2->second;
Alan Bakera7717132017-11-14 14:11:50 -0500199 std::unique_ptr<ir::Instruction> sb_inst(
200 inInst->Clone(inInst->context()));
Greg Fischer04fcc662016-11-10 10:11:50 -0700201 CloneSameBlockOps(&sb_inst, postCallSB, preCallSB, block_ptr);
202 const uint32_t rid = sb_inst->result_id();
203 const uint32_t nid = this->TakeNextId();
Steven Perroneb4653a2017-11-13 15:31:43 -0500204 get_decoration_mgr()->CloneDecorations(rid, nid, update_def_use_mgr_);
Greg Fischer04fcc662016-11-10 10:11:50 -0700205 sb_inst->SetResultId(nid);
206 (*postCallSB)[rid] = nid;
207 *iid = nid;
208 (*block_ptr)->AddInstruction(std::move(sb_inst));
209 }
210 } else {
211 // Reset same-block op operand.
212 *iid = mapItr->second;
213 }
214 });
215}
216
217void InlinePass::GenInlineCode(
218 std::vector<std::unique_ptr<ir::BasicBlock>>* new_blocks,
219 std::vector<std::unique_ptr<ir::Instruction>>* new_vars,
Steven Perronbb7802b2017-10-13 14:25:21 -0400220 ir::BasicBlock::iterator call_inst_itr,
Greg Fischer04fcc662016-11-10 10:11:50 -0700221 ir::UptrVectorIterator<ir::BasicBlock> call_block_itr) {
222 // Map from all ids in the callee to their equivalent id in the caller
223 // as callee instructions are copied into caller.
224 std::unordered_map<uint32_t, uint32_t> callee2caller;
225 // Pre-call same-block insts
226 std::unordered_map<uint32_t, ir::Instruction*> preCallSB;
227 // Post-call same-block op ids
228 std::unordered_map<uint32_t, uint32_t> postCallSB;
229
230 ir::Function* calleeFn = id2function_[call_inst_itr->GetSingleWordOperand(
231 kSpvFunctionCallFunctionId)];
232
David Neto2a1014b2017-08-09 14:59:04 -0400233 // Check for multiple returns in the callee.
234 auto fi = multi_return_funcs_.find(calleeFn->result_id());
235 const bool multiReturn = fi != multi_return_funcs_.end();
Greg Fischerbba812f2017-05-04 20:55:53 -0600236
Greg Fischer04fcc662016-11-10 10:11:50 -0700237 // Map parameters to actual arguments.
238 MapParams(calleeFn, call_inst_itr, &callee2caller);
239
240 // Define caller local variables for all callee variables and create map to
241 // them.
242 CloneAndMapLocals(calleeFn, new_vars, &callee2caller);
243
244 // Create return var if needed.
245 uint32_t returnVarId = CreateReturnVar(calleeFn, new_vars);
246
GregFa699d1a2017-08-29 18:35:05 -0600247 // Create set of callee result ids. Used to detect forward references
248 std::unordered_set<uint32_t> callee_result_ids;
Diego Novillod2938e42017-11-08 12:40:02 -0500249 calleeFn->ForEachInst([&callee_result_ids](const ir::Instruction* cpi) {
GregFa699d1a2017-08-29 18:35:05 -0600250 const uint32_t rid = cpi->result_id();
Diego Novillod2938e42017-11-08 12:40:02 -0500251 if (rid != 0) callee_result_ids.insert(rid);
GregFa699d1a2017-08-29 18:35:05 -0600252 });
253
David Netoefff5fa2017-08-31 15:47:31 -0400254 // If the caller is in a single-block loop, and the callee has multiple
255 // blocks, then the normal inlining logic will place the OpLoopMerge in
256 // the last of several blocks in the loop. Instead, it should be placed
257 // at the end of the first block. First determine if the caller is in a
258 // single block loop. We'll wait to move the OpLoopMerge until the end
259 // of the regular inlining logic, and only if necessary.
260 bool caller_is_single_block_loop = false;
David Neto25ddfec2017-09-02 19:01:03 -0400261 bool caller_is_loop_header = false;
David Netoefff5fa2017-08-31 15:47:31 -0400262 if (auto* loop_merge = call_block_itr->GetLoopMergeInst()) {
David Neto25ddfec2017-09-02 19:01:03 -0400263 caller_is_loop_header = true;
David Netoefff5fa2017-08-31 15:47:31 -0400264 caller_is_single_block_loop =
265 call_block_itr->id() ==
266 loop_merge->GetSingleWordInOperand(kSpvLoopMergeContinueTargetIdInIdx);
267 }
268
269 bool callee_begins_with_structured_header =
270 (*(calleeFn->begin())).GetMergeInst() != nullptr;
271
Greg Fischer04fcc662016-11-10 10:11:50 -0700272 // Clone and map callee code. Copy caller block code to beginning of
273 // first block and end of last block.
274 bool prevInstWasReturn = false;
Greg Fischerbba812f2017-05-04 20:55:53 -0600275 uint32_t singleTripLoopHeaderId = 0;
276 uint32_t singleTripLoopContinueId = 0;
Greg Fischer04fcc662016-11-10 10:11:50 -0700277 uint32_t returnLabelId = 0;
278 bool multiBlocks = false;
279 const uint32_t calleeTypeId = calleeFn->type_id();
David Neto2a1014b2017-08-09 14:59:04 -0400280 // new_blk_ptr is a new basic block in the caller. New instructions are
281 // written to it. It is created when we encounter the OpLabel
David Netoefff5fa2017-08-31 15:47:31 -0400282 // of the first callee block. It is appended to new_blocks only when
283 // it is complete.
Greg Fischer04fcc662016-11-10 10:11:50 -0700284 std::unique_ptr<ir::BasicBlock> new_blk_ptr;
285 calleeFn->ForEachInst([&new_blocks, &callee2caller, &call_block_itr,
286 &call_inst_itr, &new_blk_ptr, &prevInstWasReturn,
David Neto25ddfec2017-09-02 19:01:03 -0400287 &returnLabelId, &returnVarId, caller_is_loop_header,
David Netoefff5fa2017-08-31 15:47:31 -0400288 callee_begins_with_structured_header, &calleeTypeId,
David Neto2a1014b2017-08-09 14:59:04 -0400289 &multiBlocks, &postCallSB, &preCallSB, multiReturn,
Greg Fischerbba812f2017-05-04 20:55:53 -0600290 &singleTripLoopHeaderId, &singleTripLoopContinueId,
David Netoefff5fa2017-08-31 15:47:31 -0400291 &callee_result_ids, this](const ir::Instruction* cpi) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700292 switch (cpi->opcode()) {
293 case SpvOpFunction:
294 case SpvOpFunctionParameter:
295 case SpvOpVariable:
296 // Already processed
297 break;
298 case SpvOpLabel: {
299 // If previous instruction was early return, insert branch
300 // instruction to return block.
301 if (prevInstWasReturn) {
302 if (returnLabelId == 0) returnLabelId = this->TakeNextId();
303 AddBranch(returnLabelId, &new_blk_ptr);
304 prevInstWasReturn = false;
305 }
306 // Finish current block (if it exists) and get label for next block.
307 uint32_t labelId;
308 bool firstBlock = false;
309 if (new_blk_ptr != nullptr) {
310 new_blocks->push_back(std::move(new_blk_ptr));
311 // If result id is already mapped, use it, otherwise get a new
312 // one.
313 const uint32_t rid = cpi->result_id();
314 const auto mapItr = callee2caller.find(rid);
315 labelId = (mapItr != callee2caller.end()) ? mapItr->second
316 : this->TakeNextId();
317 } else {
318 // First block needs to use label of original block
319 // but map callee label in case of phi reference.
Greg Fischerbba812f2017-05-04 20:55:53 -0600320 labelId = call_block_itr->id();
Greg Fischer04fcc662016-11-10 10:11:50 -0700321 callee2caller[cpi->result_id()] = labelId;
322 firstBlock = true;
323 }
324 // Create first/next block.
325 new_blk_ptr.reset(new ir::BasicBlock(NewLabel(labelId)));
326 if (firstBlock) {
327 // Copy contents of original caller block up to call instruction.
328 for (auto cii = call_block_itr->begin(); cii != call_inst_itr;
Greg Fischerbba812f2017-05-04 20:55:53 -0600329 ++cii) {
Alan Bakera7717132017-11-14 14:11:50 -0500330 std::unique_ptr<ir::Instruction> cp_inst(cii->Clone(context()));
Greg Fischer04fcc662016-11-10 10:11:50 -0700331 // Remember same-block ops for possible regeneration.
332 if (IsSameBlockOp(&*cp_inst)) {
333 auto* sb_inst_ptr = cp_inst.get();
334 preCallSB[cp_inst->result_id()] = sb_inst_ptr;
335 }
336 new_blk_ptr->AddInstruction(std::move(cp_inst));
337 }
Diego Novillod2938e42017-11-08 12:40:02 -0500338 if (caller_is_loop_header && callee_begins_with_structured_header) {
David Netoefff5fa2017-08-31 15:47:31 -0400339 // We can't place both the caller's merge instruction and another
340 // merge instruction in the same block. So split the calling block.
341 // Insert an unconditional branch to a new guard block. Later,
342 // once we know the ID of the last block, we will move the caller's
343 // OpLoopMerge from the last generated block into the first block.
344 // We also wait to avoid invalidating various iterators.
345 const auto guard_block_id = this->TakeNextId();
346 AddBranch(guard_block_id, &new_blk_ptr);
347 new_blocks->push_back(std::move(new_blk_ptr));
348 // Start the next block.
349 new_blk_ptr.reset(new ir::BasicBlock(NewLabel(guard_block_id)));
350 // Reset the mapping of the callee's entry block to point to
351 // the guard block. Do this so we can fix up phis later on to
352 // satisfy dominance.
353 callee2caller[cpi->result_id()] = guard_block_id;
354 }
355 // If callee has multiple returns, insert a header block for
David Neto2a1014b2017-08-09 14:59:04 -0400356 // single-trip loop that will encompass callee code. Start postheader
Greg Fischerbba812f2017-05-04 20:55:53 -0600357 // block.
David Netoefff5fa2017-08-31 15:47:31 -0400358 //
359 // Note: Consider the following combination:
360 // - the caller is a single block loop
361 // - the callee does not begin with a structure header
362 // - the callee has multiple returns.
363 // We still need to split the caller block and insert a guard block.
364 // But we only need to do it once. We haven't done it yet, but the
365 // single-trip loop header will serve the same purpose.
David Neto2a1014b2017-08-09 14:59:04 -0400366 if (multiReturn) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600367 singleTripLoopHeaderId = this->TakeNextId();
368 AddBranch(singleTripLoopHeaderId, &new_blk_ptr);
369 new_blocks->push_back(std::move(new_blk_ptr));
Diego Novillod2938e42017-11-08 12:40:02 -0500370 new_blk_ptr.reset(
371 new ir::BasicBlock(NewLabel(singleTripLoopHeaderId)));
Greg Fischerbba812f2017-05-04 20:55:53 -0600372 returnLabelId = this->TakeNextId();
373 singleTripLoopContinueId = this->TakeNextId();
374 AddLoopMerge(returnLabelId, singleTripLoopContinueId, &new_blk_ptr);
375 uint32_t postHeaderId = this->TakeNextId();
376 AddBranch(postHeaderId, &new_blk_ptr);
377 new_blocks->push_back(std::move(new_blk_ptr));
378 new_blk_ptr.reset(new ir::BasicBlock(NewLabel(postHeaderId)));
379 multiBlocks = true;
David Neto860c4192017-08-31 17:33:44 -0400380 // Reset the mapping of the callee's entry block to point to
381 // the post-header block. Do this so we can fix up phis later
382 // on to satisfy dominance.
383 callee2caller[cpi->result_id()] = postHeaderId;
Greg Fischerbba812f2017-05-04 20:55:53 -0600384 }
Greg Fischer04fcc662016-11-10 10:11:50 -0700385 } else {
386 multiBlocks = true;
387 }
388 } break;
389 case SpvOpReturnValue: {
390 // Store return value to return variable.
391 assert(returnVarId != 0);
392 uint32_t valId = cpi->GetInOperand(kSpvReturnValueId).words[0];
393 const auto mapItr = callee2caller.find(valId);
394 if (mapItr != callee2caller.end()) {
395 valId = mapItr->second;
396 }
397 AddStore(returnVarId, valId, &new_blk_ptr);
398
399 // Remember we saw a return; if followed by a label, will need to
400 // insert branch.
401 prevInstWasReturn = true;
402 } break;
403 case SpvOpReturn: {
404 // Remember we saw a return; if followed by a label, will need to
405 // insert branch.
406 prevInstWasReturn = true;
407 } break;
408 case SpvOpFunctionEnd: {
David Neto2a1014b2017-08-09 14:59:04 -0400409 // If there was an early return, we generated a return label id
410 // for it. Now we have to generate the return block with that Id.
Greg Fischer04fcc662016-11-10 10:11:50 -0700411 if (returnLabelId != 0) {
David Neto2a1014b2017-08-09 14:59:04 -0400412 // If previous instruction was return, insert branch instruction
413 // to return block.
Greg Fischer04fcc662016-11-10 10:11:50 -0700414 if (prevInstWasReturn) AddBranch(returnLabelId, &new_blk_ptr);
David Neto2a1014b2017-08-09 14:59:04 -0400415 if (multiReturn) {
416 // If we generated a loop header to for the single-trip loop
417 // to accommodate multiple returns, insert the continue
418 // target block now, with a false branch back to the loop header.
419 new_blocks->push_back(std::move(new_blk_ptr));
420 new_blk_ptr.reset(
421 new ir::BasicBlock(NewLabel(singleTripLoopContinueId)));
422 AddBranchCond(GetFalseId(), singleTripLoopHeaderId, returnLabelId,
423 &new_blk_ptr);
424 }
425 // Generate the return block.
Greg Fischerbba812f2017-05-04 20:55:53 -0600426 new_blocks->push_back(std::move(new_blk_ptr));
Greg Fischer04fcc662016-11-10 10:11:50 -0700427 new_blk_ptr.reset(new ir::BasicBlock(NewLabel(returnLabelId)));
428 multiBlocks = true;
429 }
430 // Load return value into result id of call, if it exists.
431 if (returnVarId != 0) {
432 const uint32_t resId = call_inst_itr->result_id();
433 assert(resId != 0);
434 AddLoad(calleeTypeId, resId, returnVarId, &new_blk_ptr);
435 }
436 // Copy remaining instructions from caller block.
437 auto cii = call_inst_itr;
Greg Fischerbba812f2017-05-04 20:55:53 -0600438 for (++cii; cii != call_block_itr->end(); ++cii) {
Alan Bakera7717132017-11-14 14:11:50 -0500439 std::unique_ptr<ir::Instruction> cp_inst(cii->Clone(context()));
Greg Fischer04fcc662016-11-10 10:11:50 -0700440 // If multiple blocks generated, regenerate any same-block
441 // instruction that has not been seen in this last block.
442 if (multiBlocks) {
443 CloneSameBlockOps(&cp_inst, &postCallSB, &preCallSB, &new_blk_ptr);
444 // Remember same-block ops in this block.
445 if (IsSameBlockOp(&*cp_inst)) {
446 const uint32_t rid = cp_inst->result_id();
447 postCallSB[rid] = rid;
448 }
449 }
450 new_blk_ptr->AddInstruction(std::move(cp_inst));
451 }
452 // Finalize inline code.
453 new_blocks->push_back(std::move(new_blk_ptr));
454 } break;
455 default: {
456 // Copy callee instruction and remap all input Ids.
Alan Bakera7717132017-11-14 14:11:50 -0500457 std::unique_ptr<ir::Instruction> cp_inst(cpi->Clone(context()));
David Netoefff5fa2017-08-31 15:47:31 -0400458 cp_inst->ForEachInId([&callee2caller, &callee_result_ids,
459 this](uint32_t* iid) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700460 const auto mapItr = callee2caller.find(*iid);
461 if (mapItr != callee2caller.end()) {
462 *iid = mapItr->second;
GregFa699d1a2017-08-29 18:35:05 -0600463 } else if (callee_result_ids.find(*iid) != callee_result_ids.end()) {
464 // Forward reference. Allocate a new id, map it,
465 // use it and check for it when remapping result ids
466 const uint32_t nid = this->TakeNextId();
467 callee2caller[*iid] = nid;
468 *iid = nid;
Greg Fischer04fcc662016-11-10 10:11:50 -0700469 }
470 });
GregFa699d1a2017-08-29 18:35:05 -0600471 // If result id is non-zero, remap it. If already mapped, use mapped
472 // value, else use next id.
Greg Fischer04fcc662016-11-10 10:11:50 -0700473 const uint32_t rid = cp_inst->result_id();
474 if (rid != 0) {
GregFa699d1a2017-08-29 18:35:05 -0600475 const auto mapItr = callee2caller.find(rid);
476 uint32_t nid;
477 if (mapItr != callee2caller.end()) {
478 nid = mapItr->second;
Diego Novillod2938e42017-11-08 12:40:02 -0500479 } else {
GregFa699d1a2017-08-29 18:35:05 -0600480 nid = this->TakeNextId();
481 callee2caller[rid] = nid;
482 }
Greg Fischer04fcc662016-11-10 10:11:50 -0700483 cp_inst->SetResultId(nid);
Steven Perroneb4653a2017-11-13 15:31:43 -0500484 get_decoration_mgr()->CloneDecorations(rid, nid, update_def_use_mgr_);
Greg Fischer04fcc662016-11-10 10:11:50 -0700485 }
486 new_blk_ptr->AddInstruction(std::move(cp_inst));
487 } break;
488 }
489 });
David Netoefff5fa2017-08-31 15:47:31 -0400490
David Neto25ddfec2017-09-02 19:01:03 -0400491 if (caller_is_loop_header && (new_blocks->size() > 1)) {
David Netoefff5fa2017-08-31 15:47:31 -0400492 // Move the OpLoopMerge from the last block back to the first, where
David Neto25ddfec2017-09-02 19:01:03 -0400493 // it belongs.
David Netoefff5fa2017-08-31 15:47:31 -0400494 auto& first = new_blocks->front();
495 auto& last = new_blocks->back();
496 assert(first != last);
497
498 // Insert a modified copy of the loop merge into the first block.
499 auto loop_merge_itr = last->tail();
500 --loop_merge_itr;
501 assert(loop_merge_itr->opcode() == SpvOpLoopMerge);
Alan Bakera7717132017-11-14 14:11:50 -0500502 std::unique_ptr<ir::Instruction> cp_inst(loop_merge_itr->Clone(context()));
David Neto25ddfec2017-09-02 19:01:03 -0400503 if (caller_is_single_block_loop) {
504 // Also, update its continue target to point to the last block.
505 cp_inst->SetInOperand(kSpvLoopMergeContinueTargetIdInIdx, {last->id()});
506 }
David Netoefff5fa2017-08-31 15:47:31 -0400507 first->tail().InsertBefore(std::move(cp_inst));
508
509 // Remove the loop merge from the last block.
Steven Perronbb7802b2017-10-13 14:25:21 -0400510 loop_merge_itr->RemoveFromList();
511 delete &*loop_merge_itr;
David Netoefff5fa2017-08-31 15:47:31 -0400512 }
513
Greg Fischer04fcc662016-11-10 10:11:50 -0700514 // Update block map given replacement blocks.
515 for (auto& blk : *new_blocks) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600516 id2block_[blk->id()] = &*blk;
Greg Fischer04fcc662016-11-10 10:11:50 -0700517 }
518}
519
David Netoceb1d4f2017-03-31 10:36:58 -0400520bool InlinePass::IsInlinableFunctionCall(const ir::Instruction* inst) {
521 if (inst->opcode() != SpvOp::SpvOpFunctionCall) return false;
GregFa107d342017-04-25 13:57:20 -0600522 const uint32_t calleeFnId =
523 inst->GetSingleWordOperand(kSpvFunctionCallFunctionId);
524 const auto ci = inlinable_.find(calleeFnId);
525 return ci != inlinable_.cend();
David Netoceb1d4f2017-03-31 10:36:58 -0400526}
527
GregFe28bd392017-08-01 17:20:13 -0600528void InlinePass::UpdateSucceedingPhis(
529 std::vector<std::unique_ptr<ir::BasicBlock>>& new_blocks) {
530 const auto firstBlk = new_blocks.begin();
531 const auto lastBlk = new_blocks.end() - 1;
532 const uint32_t firstId = (*firstBlk)->id();
533 const uint32_t lastId = (*lastBlk)->id();
Diego Novillod2938e42017-11-08 12:40:02 -0500534 (*lastBlk)->ForEachSuccessorLabel([&firstId, &lastId, this](uint32_t succ) {
535 ir::BasicBlock* sbp = this->id2block_[succ];
536 sbp->ForEachPhiInst([&firstId, &lastId](ir::Instruction* phi) {
537 phi->ForEachInId([&firstId, &lastId](uint32_t* id) {
538 if (*id == firstId) *id = lastId;
GregFe28bd392017-08-01 17:20:13 -0600539 });
Diego Novillod2938e42017-11-08 12:40:02 -0500540 });
541 });
Greg Fischer04fcc662016-11-10 10:11:50 -0700542}
543
Greg Fischerbba812f2017-05-04 20:55:53 -0600544bool InlinePass::HasMultipleReturns(ir::Function* func) {
545 bool seenReturn = false;
546 bool multipleReturns = false;
547 for (auto& blk : *func) {
548 auto terminal_ii = blk.cend();
549 --terminal_ii;
Diego Novillod2938e42017-11-08 12:40:02 -0500550 if (terminal_ii->opcode() == SpvOpReturn ||
Greg Fischerbba812f2017-05-04 20:55:53 -0600551 terminal_ii->opcode() == SpvOpReturnValue) {
552 if (seenReturn) {
553 multipleReturns = true;
554 break;
555 }
556 seenReturn = true;
557 }
558 }
559 return multipleReturns;
560}
561
Greg Fischerbba812f2017-05-04 20:55:53 -0600562void InlinePass::ComputeStructuredSuccessors(ir::Function* func) {
563 // If header, make merge block first successor.
564 for (auto& blk : *func) {
Diego Novillofef669f2017-10-30 17:42:26 -0400565 uint32_t mbid = blk.MergeBlockIdIfAny();
566 if (mbid != 0) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600567 block2structured_succs_[&blk].push_back(id2block_[mbid]);
Diego Novillofef669f2017-10-30 17:42:26 -0400568 }
569
570 // Add true successors.
Greg Fischerbba812f2017-05-04 20:55:53 -0600571 blk.ForEachSuccessorLabel([&blk, this](uint32_t sbid) {
572 block2structured_succs_[&blk].push_back(id2block_[sbid]);
573 });
574 }
575}
Diego Novillofef669f2017-10-30 17:42:26 -0400576
Greg Fischerbba812f2017-05-04 20:55:53 -0600577InlinePass::GetBlocksFunction InlinePass::StructuredSuccessorsFunction() {
578 return [this](const ir::BasicBlock* block) {
579 return &(block2structured_succs_[block]);
580 };
581}
582
583bool InlinePass::HasNoReturnInLoop(ir::Function* func) {
584 // If control not structured, do not do loop/return analysis
585 // TODO: Analyze returns in non-structured control flow
Diego Novillod2938e42017-11-08 12:40:02 -0500586 if (!get_module()->HasCapability(SpvCapabilityShader)) return false;
Greg Fischerbba812f2017-05-04 20:55:53 -0600587 // Compute structured block order. This order has the property
588 // that dominators are before all blocks they dominate and merge blocks
589 // are after all blocks that are in the control constructs of their header.
590 ComputeStructuredSuccessors(func);
591 auto ignore_block = [](cbb_ptr) {};
592 auto ignore_edge = [](cbb_ptr, cbb_ptr) {};
593 std::list<const ir::BasicBlock*> structuredOrder;
594 spvtools::CFA<ir::BasicBlock>::DepthFirstTraversal(
Diego Novillod2938e42017-11-08 12:40:02 -0500595 &*func->begin(), StructuredSuccessorsFunction(), ignore_block,
596 [&](cbb_ptr b) { structuredOrder.push_front(b); }, ignore_edge);
Greg Fischerbba812f2017-05-04 20:55:53 -0600597 // Search for returns in loops. Only need to track outermost loop
598 bool return_in_loop = false;
599 uint32_t outerLoopMergeId = 0;
600 for (auto& blk : structuredOrder) {
601 // Exiting current outer loop
Diego Novillod2938e42017-11-08 12:40:02 -0500602 if (blk->id() == outerLoopMergeId) outerLoopMergeId = 0;
Greg Fischerbba812f2017-05-04 20:55:53 -0600603 // Return block
604 auto terminal_ii = blk->cend();
605 --terminal_ii;
Diego Novillod2938e42017-11-08 12:40:02 -0500606 if (terminal_ii->opcode() == SpvOpReturn ||
Greg Fischerbba812f2017-05-04 20:55:53 -0600607 terminal_ii->opcode() == SpvOpReturnValue) {
608 if (outerLoopMergeId != 0) {
609 return_in_loop = true;
610 break;
611 }
Diego Novillod2938e42017-11-08 12:40:02 -0500612 } else if (terminal_ii != blk->cbegin()) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600613 auto merge_ii = terminal_ii;
614 --merge_ii;
615 // Entering outermost loop
616 if (merge_ii->opcode() == SpvOpLoopMerge && outerLoopMergeId == 0)
Diego Novillod2938e42017-11-08 12:40:02 -0500617 outerLoopMergeId =
618 merge_ii->GetSingleWordOperand(kSpvLoopMergeMergeBlockId);
Greg Fischerbba812f2017-05-04 20:55:53 -0600619 }
620 }
621 return !return_in_loop;
622}
623
624void InlinePass::AnalyzeReturns(ir::Function* func) {
625 // Look for multiple returns
626 if (!HasMultipleReturns(func)) {
627 no_return_in_loop_.insert(func->result_id());
628 return;
629 }
David Neto2a1014b2017-08-09 14:59:04 -0400630 multi_return_funcs_.insert(func->result_id());
Greg Fischerbba812f2017-05-04 20:55:53 -0600631 // If multiple returns, see if any are in a loop
Diego Novillod2938e42017-11-08 12:40:02 -0500632 if (HasNoReturnInLoop(func)) no_return_in_loop_.insert(func->result_id());
Greg Fischerbba812f2017-05-04 20:55:53 -0600633}
634
635bool InlinePass::IsInlinableFunction(ir::Function* func) {
GregFa107d342017-04-25 13:57:20 -0600636 // We can only inline a function if it has blocks.
Diego Novillod2938e42017-11-08 12:40:02 -0500637 if (func->cbegin() == func->cend()) return false;
Greg Fischerbba812f2017-05-04 20:55:53 -0600638 // Do not inline functions with returns in loops. Currently early return
639 // functions are inlined by wrapping them in a one trip loop and implementing
640 // the returns as a branch to the loop's merge block. However, this can only
641 // done validly if the return was not in a loop in the original function.
642 // Also remember functions with multiple (early) returns.
643 AnalyzeReturns(func);
David Netoefff5fa2017-08-31 15:47:31 -0400644 return no_return_in_loop_.find(func->result_id()) !=
645 no_return_in_loop_.cend();
GregFa107d342017-04-25 13:57:20 -0600646}
647
Steven Perron476cae62017-10-30 11:13:24 -0400648void InlinePass::InitializeInline(ir::IRContext* c) {
649 InitializeProcessing(c);
Greg Fischer04fcc662016-11-10 10:11:50 -0700650
Alan Baker746bfd22017-11-14 14:11:50 -0500651 // Don't bother updating the DefUseManger
652 update_def_use_mgr_ = [this] (ir::Instruction&, bool) {};
Daniel Schürmanna76d0972017-10-24 18:28:18 +0200653
Greg Fischerbba812f2017-05-04 20:55:53 -0600654 false_id_ = 0;
655
GregFe28bd392017-08-01 17:20:13 -0600656 // clear collections
Greg Fischer04fcc662016-11-10 10:11:50 -0700657 id2function_.clear();
658 id2block_.clear();
Greg Fischerbba812f2017-05-04 20:55:53 -0600659 block2structured_succs_.clear();
GregFa107d342017-04-25 13:57:20 -0600660 inlinable_.clear();
GregFe28bd392017-08-01 17:20:13 -0600661 no_return_in_loop_.clear();
David Neto2a1014b2017-08-09 14:59:04 -0400662 multi_return_funcs_.clear();
GregFe28bd392017-08-01 17:20:13 -0600663
Diego Novillo1040a952017-10-25 13:26:25 -0400664 for (auto& fn : *get_module()) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600665 // Initialize function and block maps.
Greg Fischer04fcc662016-11-10 10:11:50 -0700666 id2function_[fn.result_id()] = &fn;
667 for (auto& blk : fn) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600668 id2block_[blk.id()] = &blk;
Greg Fischer04fcc662016-11-10 10:11:50 -0700669 }
Greg Fischerbba812f2017-05-04 20:55:53 -0600670 // Compute inlinability
Diego Novillod2938e42017-11-08 12:40:02 -0500671 if (IsInlinableFunction(&fn)) inlinable_.insert(fn.result_id());
Greg Fischer04fcc662016-11-10 10:11:50 -0700672 }
673};
674
Diego Novillo1040a952017-10-25 13:26:25 -0400675InlinePass::InlinePass() {}
Greg Fischer04fcc662016-11-10 10:11:50 -0700676
Greg Fischer04fcc662016-11-10 10:11:50 -0700677} // namespace opt
678} // namespace spvtools