commit 0ad83f9139daf70a791560f5c72f94b0be5b8390
author Shahbaz Youssefi <syoussefi@google.com> Fri Feb 11 10:29:42 2022 -0500
committer GitHub <noreply@github.com> Fri Feb 11 15:29:42 2022 +0000
tree e2a3dd52504cf5d906364ab4c0535c9060c6a35a
parent 940127a77d3ad795a4a1422fbeaad50c9f19f2ea

spirv-diff: Match OpSpecConstantComposite correctly (#4704)

OpSpecConstantComposite is not decorated with SpecId, and so is matched
similarly to OpConstantComposite.

source/diff/diff.cpp

diff --git a/source/diff/diff.cpp b/source/diff/diff.cpp
index 3b4c24e..12172bf 100644
--- a/source/diff/diff.cpp
+++ b/source/diff/diff.cpp
@@ -2064,6 +2064,7 @@
         case SpvOpConstant:
           return MatchOpConstant(src_inst, dst_inst, flexibility);
         case SpvOpConstantComposite:
+        case SpvOpSpecConstantComposite:
           // Composite constants must match in type and value.
           //
           // TODO: match OpConstantNull with OpConstantComposite with all zeros
@@ -2092,7 +2093,6 @@
         case SpvOpSpecConstantTrue:
         case SpvOpSpecConstantFalse:
         case SpvOpSpecConstant:
-        case SpvOpSpecConstantComposite:
         case SpvOpSpecConstantOp:
           // Match spec constants by name if available, then by the SpecId
           // decoration.