commit fd2e3212e078a591f21407eb2db5852ef7106d80
author Liviu Rau <liviurau@chromium.org> Wed Dec 18 16:38:20 2019 +0100
committer Commit Bot <commit-bot@chromium.org> Wed Dec 18 15:44:17 2019 +0000
tree d627be7e24e972c184bce29947fbda0515d631d7
parent 24f39c4397841366751a20454c58c84c0b98df54

[presubmit] Allign authors check with the way we do it in V8

Change-Id: Ide50862cda9efc21241a253729c7ed2dfcec93c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971934
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index d92978c..d271703 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -40,10 +40,7 @@
     [ 'OWNERS' ],
 ]
 
-# Bypass the AUTHORS check for these accounts.
-_KNOWN_ROBOTS = set('%s-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com' % s for s in ('devtools-ci')) | set(
-    '%s@appspot.gserviceaccount.com' % s for s in ('findit-for-me',))
-
+AUTOROLL_ACCOUNT = "devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com"
 
 def _CheckChangesAreExclusiveToDirectory(input_api, output_api):
     if input_api.change.DISABLE_THIRD_PARTY_CHECK != None:
@@ -224,9 +221,9 @@
 def _CommonChecks(input_api, output_api):
     """Checks common to both upload and commit."""
     results = []
-    author = input_api.change.author_email
-    if author and author not in _KNOWN_ROBOTS:
-        results.extend(input_api.canned_checks.CheckAuthorizedAuthor(input_api, output_api))
+    results.extend(input_api.canned_checks.CheckAuthorizedAuthor(input_api, output_api,
+        bot_whitelist=[AUTOROLL_ACCOUNT]
+    ))
     results.extend(input_api.canned_checks.CheckOwnersFormat(input_api, output_api))
     results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
     results.extend(input_api.canned_checks.CheckChangeHasNoCrAndHasOnlyOneEol(input_api, output_api))