DevTools: Run presubmit localization checks on commit
Outdated local branch and the use of --bypass-hooks can result in
localizability errors in master. Run the localization checks on commit
so CQ runs can report errors.
Screenshot: https://imgur.com/8kaBsKO
Bug: 941561
Change-Id: I51ca39f76356df48f16a76a2cb46002ff0f2f107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764274
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#689730}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 75c39449c0238d172e37be9620aa120e6a6512d9
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 42bcf8a..1166bdb 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -196,7 +196,10 @@
def CheckChangeOnCommit(input_api, output_api):
- return []
+ results = []
+ results.extend(_CheckDevtoolsLocalizableResources(input_api, output_api))
+ results.extend(_CheckDevtoolsLocalization(input_api, output_api))
+ return results
def _getAffectedFiles(input_api, parent_directories, excluded_actions, accepted_endings): # pylint: disable=invalid-name