commit ebb70e3356da6912965222318821f293288684e9
author Johan Bay <jobay@chromium.org> Mon May 23 17:46:37 2022 +0200
committer Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 24 07:56:40 2022 +0000
tree 4a4531f32968c3310f6bd231b4600b86219b6575
parent 54c53dffd6108624cf0a73ff029e8f8f0210d088

Change JavaScriptMetadata to contain list of receivers

Bug: 1255619, 1327573
Change-Id: I8fbe5a041b1ef5aef519d1b0b76f1bded237bd6f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3580497
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>

scripts/javascript_natives/helpers.js

diff --git a/scripts/javascript_natives/helpers.js b/scripts/javascript_natives/helpers.js
index ac0b71e..19c49ac 100644
--- a/scripts/javascript_natives/helpers.js
+++ b/scripts/javascript_natives/helpers.js
@@ -84,9 +84,7 @@
  * @param {WebIDL2.OperationMemberType} member
  * */
 function handleOperation(member) {
-  storeMethod(
-      member.special === 'static' ? (parent.name + 'Constructor') : member.parent.name, member.name,
-      member.arguments.map(argName));
+  storeMethod(member.parent.name, member.name, member.arguments.map(argName));
 }
 
 /**
@@ -177,13 +175,14 @@
       // All parents had the same signature so we emit an entry without receiver.
       functions.push({name, signatures: method.get('*')});
     } else {
+      const receiversMap = new Map();
       for (const [parent, signatures] of method) {
-        if (parent.endsWith('Constructor')) {
-          functions.push(
-              {name, signatures, static: true, receiver: parent.substring(0, parent.length - 'Constructor'.length)});
-        } else {
-          functions.push({name, signatures, receiver: parent});
-        }
+        const receivers = receiversMap.get(JSON.stringify(signatures)) || [];
+        receivers.push(parent);
+        receiversMap.set(JSON.stringify(signatures), receivers);
+      }
+      for (const [signatures, receivers] of receiversMap) {
+        functions.push({name, signatures: JSON.parse(signatures), receivers});
       }
     }
   }