DevTools: Monitor grdp files for localizability
In rare cases, strings in .grdp files can change without any .js
change. Update the presubmit localizability check to run when .grdp
files change.
Bug: 941561
Change-Id: Ia5e2d084b7c4939b045f6a9ef40e299abec89d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727399
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#689726}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7211b43b8937e9b89b51dfeb22b8696ef59f5ff7
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 6b1f9d3..42bcf8a 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -107,9 +107,9 @@
def _CheckDevtoolsLocalization(input_api, output_api): # pylint: disable=invalid-name
- affected_front_end_files = [
- input_api.os_path.join(input_api.PresubmitLocalPath(), file_path) for file_path in _getAffectedFrontEndFiles(input_api)
- ]
+ devtools_root = input_api.PresubmitLocalPath()
+ devtools_front_end = input_api.os_path.join(devtools_root, "front_end")
+ affected_front_end_files = _getAffectedFiles(input_api, [devtools_front_end], ["D"], [".js", ".grdp"])
if len(affected_front_end_files) == 0:
return []
script_path = input_api.os_path.join(input_api.PresubmitLocalPath(), "scripts", "check_localizability.js")