commit e3bf6c274f1ea846065dfa8bc7eda3de5ceb35d1
author Sigurd Schneider <sigurds@chromium.org> Thu Feb 11 15:35:23 2021 +0100
committer Commit Bot <commit-bot@chromium.org> Fri Feb 12 09:04:25 2021 +0000
tree d0769cfba15fb729cdc73e9e98e9af85cefbb443
parent 2e898b232ac55b7294514bb9fd067e5c0716bfb0

Apply css linting in PRESUBMIT.py to components as well

The command `npm run check-lint` runs stylelint on components, but the
presubmit check wasn't. This lead to files getting committed that did
had lint errors. This CL ensures that stylelint is run on components
during presubmit as well.

Bug: chromium:1166108
Change-Id: Ie3d19a62452a04c710b2468c3a47e0c8a91b0d68
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2690529
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 7fbf50c..97ffbbd 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -288,14 +288,26 @@
                                           [],
                                           ['.json', '.py', '.stylelintignore'])
 
-    should_bail_out, files_to_lint = _getFilesToLint(
+    css_should_bail_out, css_files_to_lint = _getFilesToLint(
         input_api, output_api, lint_config_files, default_linted_directories,
         ['.css'], results)
-    if should_bail_out:
-        return results
 
-    results.extend(
-        _checkWithNodeScript(input_api, output_api, lint_path, files_to_lint))
+    if not css_should_bail_out:
+        script_args = ["--syntax", "html", "--files"] + ts_files_to_lint
+        results.extend(
+            _checkWithNodeScript(input_api, output_api, lint_path,
+                                 css_files_to_lint))
+
+    ts_should_bail_out, ts_files_to_lint = _getFilesToLint(
+        input_api, output_api, lint_config_files, default_linted_directories,
+        ['.ts'], results)
+
+    if not ts_should_bail_out:
+        script_args = ["--syntax", "html", "--files"] + ts_files_to_lint
+        results.extend(
+            _checkWithNodeScript(input_api, output_api, lint_path,
+                                 script_args))
+
     return results