commit d8a8db74c8188b2ce0af00ba6465bcf1e1d4d9aa
author Victor Porof <victorporof@chromium.org> Mon Jun 13 13:24:36 2022 +0000
committer Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 13 16:48:05 2022 +0000
tree 15eb4762dc95fdf697f15ec31a1612600b86a170
parent bd81efed4676f3e5dafdb368b27e59c02cbb0bad

Improve in-place array merges when generating the DOM pinned properties dataset

Array#includes is O(n) whereas set lookups are O(1).
We still O(n) to generate the set, but only happens once.

Signed-off-by: Victor Porof <victorporof@chromium.org>
Bug: 1325812
Change-Id: I29da73edf5e42ad4d088fd9018e505d0e787744a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3702261
Reviewed-by: Mathias Bynens <mathias@chromium.org>

scripts/webidl-properties/util.js

diff --git a/scripts/webidl-properties/util.js b/scripts/webidl-properties/util.js
index f4e94e9..a1f1d61 100644
--- a/scripts/webidl-properties/util.js
+++ b/scripts/webidl-properties/util.js
@@ -28,8 +28,9 @@
   }
 
   function mergeArrays(a, b) {
+    const set = new Set(a);
     for (const value of b) {
-      if (!a.includes(value)) {
+      if (!set.has(value)) {
         a.push(value);
       }
     }