commit c96ccd99f0e299d9cce23a8667eb1d35e057f7e0
author Tim van der Lippe <tvanderlippe@chromium.org> Fri Nov 29 16:23:54 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Fri Nov 29 16:38:40 2019 +0000
tree 8874b97d8efeb01c6660304ab0ced79dc4efa9a1
parent f05ffb295a3a4c36f8a5154285f6641a87f1f8b5

Remove unused globals

By using the script in crrev.com/c/devtools/devtools-frontend/+/1942289
we can prune all globals that are not actually global. Most of these are
internal private variables that are now module-scoped. Some variables
were also completely unused, which ESLint nicely reported.

Change-Id: I43689ac7544ad1239acc7d0eeec4dcd563d7fea9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1942290
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>

front_end/audits/AuditsStatusView.js

diff --git a/front_end/audits/AuditsStatusView.js b/front_end/audits/AuditsStatusView.js
index 49a044e..f3b2454 100644
--- a/front_end/audits/AuditsStatusView.js
+++ b/front_end/audits/AuditsStatusView.js
@@ -297,7 +297,7 @@
 export const minimumTextVisibilityDuration = 3000;
 
 /** @type {!Array.<!RegExp>} */
-export const KnownBugPatterns = [
+const KnownBugPatterns = [
   /PARSING_PROBLEM/,
   /DOCUMENT_REQUEST/,
   /READ_FAILED/,
@@ -328,7 +328,7 @@
 ];
 
 /** @typedef {{message: string, deviceType: string, throttling: string}} */
-export const LoadingMessages = [
+const LoadingMessages = [
   {
     deviceType: 'mobile',
     throttling: 'on',
@@ -351,7 +351,7 @@
   },
 ];
 
-export const FastFacts = [
+const FastFacts = [
   ls
 `1MB takes a minimum of 5 seconds to download on a typical 3G connection [Source: WebPageTest and DevTools 3G definition].`,
     ls`Rebuilding Pinterest pages for performance increased conversion rates by 15% [Source: WPO Stats]`,
@@ -383,17 +383,9 @@
   Audits = Audits || {};
 
   /**
- * @constructor
- */
+* @constructor
+*/
   Audits.StatusView = StatusView;
 
-  Audits.StatusView.FastFacts = FastFacts;
-
-  /** @type {!Array.<!RegExp>} */
-  Audits.StatusView.KnownBugPatterns = KnownBugPatterns;
-
   /** @typedef {{message: string, progressBarClass: string, order: number}} */
   Audits.StatusView.StatusPhases = StatusPhases;
-
-  /** @typedef {{message: string, deviceType: string, throttling: string}} */
-  Audits.StatusView.LoadingMessages = LoadingMessages;