| commit | bf20468f57c10589abcb0df9dd397af1719e289b | [log] [tgz] |
|---|---|---|
| author | Paul Irish <paulirish@chromium.org> | Wed May 13 16:11:37 2020 -0700 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed May 13 23:38:54 2020 +0000 |
| tree | b5bf972c60a97cf31899753fe0562400e718ddbc | |
| parent | 0a227c84a55948a971c0149c493f1195522914b4 [diff] [blame] |
Audits: Roll Lighthouse 6.0.0-rc.1 (0d6f7e799) Adds: desktop scoring for LCP/TBT, Snyk roll, Score calculator link Fixes: Uses pubads-1.1.0-beta release Built from https://github.com/GoogleChrome/lighthouse/tree/dt-600rc1 Diff: https://github.com/GoogleChrome/lighthouse/compare/dt-600rc0..dt-600rc1 Bug: 772558 Change-Id: Ib725c3f3a87abe75243051233a2f621e19ee71d2 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199999 Reviewed-by: Connor Clark <cjamcl@chromium.org> Commit-Queue: Connor Clark <cjamcl@chromium.org> Auto-Submit: Paul Irish <paulirish@chromium.org>
diff --git a/front_end/lighthouse/LighthouseReportRenderer.js b/front_end/lighthouse/LighthouseReportRenderer.js index 2011ad2..5a3b6ca 100644 --- a/front_end/lighthouse/LighthouseReportRenderer.js +++ b/front_end/lighthouse/LighthouseReportRenderer.js
@@ -25,16 +25,16 @@ } const container = el.querySelector('.lh-audit-group'); - const columnsEl = container.querySelector('.lh-columns'); - // There will be no columns if just the PWA category. - if (!columnsEl) { + const disclaimerEl = container.querySelector('.lh-metrics__disclaimer'); + // If it was a PWA-only run, we'd have a trace but no perf category to add the button to + if (!disclaimerEl) { return; } const defaultPassTrace = artifacts.traces.defaultPass; const timelineButton = UI.UIUtils.createTextButton(Common.UIString.UIString('View Trace'), onViewTraceClick, 'view-trace'); - container.insertBefore(timelineButton, columnsEl.nextSibling); + container.insertBefore(timelineButton, disclaimerEl.nextSibling); async function onViewTraceClick() { HostModule.userMetrics.actionTaken(Host.UserMetrics.Action.LighthouseViewTrace);