Migrate run_lint_check_css to JS script
As part of the work to move more scripts to Node, not Python, over time,
picked this one as the starting point. I changed its API slightly to
allow more flags to be taken in, as we'll need that to do a stylelint
pass against TypeScript files, but I will do that in a subsequent CL.
I had to make quite a few changes to devtools_paths.js, but I think it's
now calculating paths correctly. It took a bit of messing to get the
equivalent of Python's path.abspath(__file__), as you'll see from the
large comment that tries to explain what's going on!
Bug: chromium:1166108, chromium:1166572
Change-Id: Ia0b19ff8956b2ede2447530be57876a88046887e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631113
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 81f3146..04236f2 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -236,7 +236,7 @@
results = [output_api.PresubmitNotifyResult('CSS style check:')]
lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
'scripts', 'test',
- 'run_lint_check_css.py')
+ 'run_lint_check_css.js')
front_end_directory = input_api.os_path.join(
input_api.PresubmitLocalPath(), 'front_end')
@@ -270,8 +270,9 @@
if should_bail_out:
return results
- return _ExecuteSubProcess(input_api, output_api, lint_path, files_to_lint,
- results)
+ results.extend(
+ _checkWithNodeScript(input_api, output_api, lint_path, files_to_lint))
+ return results
def _CheckOptimizeSVGHashes(input_api, output_api):