commit ae1192b6309e632d35ff71b4e8ab28daa1b057e0
author Philip Pfaffe <pfaffe@chromium.org> Thu Jun 02 13:08:03 2022 +0000
committer Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jun 02 15:29:00 2022 +0000
tree 971e2497f6901787afc3dfc7579a5fb1022893db
parent 5e91454d1bdee651a57057728c9584a47b0186a0

Show warning infobar for missing debug info

For wasm debugging it's possible that debug info is incomplete on a per-callframe granularity. When debug info is incomplete we currently show a warning banner in the call stack sidebar pane and a little warning icon next to the affected callframes. It's too easy to overlook this. With this CL we're introducing a prominently red error infobar directly in the editor when an incomplete callframe is selected.

Bug: 1331281
Screenshot: See crbug.
Change-Id: Id804e087a0f04d8daa9169a77e0e78eb8556e6c9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3610169
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Peter Müller <petermueller@chromium.org>

extension-api/ExtensionAPI.d.ts

diff --git a/extension-api/ExtensionAPI.d.ts b/extension-api/ExtensionAPI.d.ts
index 1e789b3..6aa568d 100644
--- a/extension-api/ExtensionAPI.d.ts
+++ b/extension-api/ExtensionAPI.d.ts
@@ -181,7 +181,8 @@
        * A new raw module has been loaded. If the raw wasm module references an external debug info module, its URL will be
        * passed as symbolsURL.
        */
-      addRawModule(rawModuleId: string, symbolsURL: string|undefined, rawModule: RawModule): Promise<string[]>;
+      addRawModule(rawModuleId: string, symbolsURL: string|undefined, rawModule: RawModule):
+          Promise<string[]|{missingSymbolFiles: string[]}>;
 
       /**
        * Find locations in raw modules from a location in a source file.
@@ -242,9 +243,8 @@
       /**
        * Find locations in source files from a location in a raw module
        */
-      getFunctionInfo(rawLocation: RawLocation): Promise<{
-        frames: Array<FunctionInfo>,
-      }>;
+      getFunctionInfo(rawLocation: RawLocation):
+          Promise<{frames: Array<FunctionInfo>}|{missingSymbolFiles: Array<string>}>;
 
       /**
        * Find locations in raw modules corresponding to the inline function