commit a7845d583000a2014651fd05f1416ea7d2f0b603
author Yang Guo <yangguo@chromium.org> Thu Oct 31 11:30:23 2019 +0100
committer Commit Bot <commit-bot@chromium.org> Thu Oct 31 10:47:00 2019 +0000
tree 90b2652bb2be1b8255dd85da6413c69a70acf74a
parent 720412311740eec2a14dffb0af1e6be6b158ca55

Check for exclusive changes in presubmit

Changes to third_party or v8, to node_modules, or to OWNERS
should not affect any other file.

R=aerotwist@chromium.org

Change-Id: I7a4603c2c0498ac5d5726e46773bd4e9c13608a8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891420
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index f511244..5b68066 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -34,6 +34,41 @@
 
 import sys
 
+EXCLUSIVE_CHANGE_DIRECTORIES = [
+    [ 'third_party', 'v8' ],
+    [ 'node_modules' ],
+    [ 'OWNERS' ],
+]
+
+def _CheckChangesAreExclusiveToDirectory(input_api, output_api):
+    def IsParentDir(file, dir):
+        while file != '':
+            if file == dir:
+                return True
+            file = input_api.os_path.dirname(file)
+            print(file)
+        return False
+
+    def FileIsInDir(file, dirs):
+        for dir in dirs:
+            if IsParentDir(file, dir):
+                return True
+
+    affected_files = input_api.LocalPaths()
+    print(affected_files)
+    num_affected = len(affected_files)
+    for dirs in EXCLUSIVE_CHANGE_DIRECTORIES:
+        affected_in_dir = filter(lambda f: FileIsInDir(f, dirs), affected_files)
+        num_in_dir = len(affected_in_dir)
+        if num_in_dir == 0:
+            continue
+        if num_in_dir < num_affected:
+            return [
+                output_api.PresubmitError(
+                    'CLs that affect files in "%s" should be limited to these files/directories.' % ', '.join(dirs))
+            ]
+    return []
+
 
 def _CheckBuildGN(input_api, output_api):
     script_path = input_api.os_path.join(input_api.PresubmitLocalPath(), 'scripts', 'check_gn.js')
@@ -190,6 +225,7 @@
     results.extend(_CheckCSSViolations(input_api, output_api))
     results.extend(_CheckDevtoolsLocalizableResources(input_api, output_api))
     results.extend(_CheckDevtoolsLocalization(input_api, output_api))
+    results.extend(_CheckChangesAreExclusiveToDirectory(input_api, output_api))
     return results
 
 
@@ -198,6 +234,7 @@
     results.extend(_CommonChecks(input_api, output_api))
     results.extend(_CheckDevtoolsLocalizableResources(input_api, output_api, True))
     results.extend(_CheckDevtoolsLocalization(input_api, output_api, True))
+    results.extend(_CheckChangesAreExclusiveToDirectory(input_api, output_api))
     results.extend(input_api.canned_checks.CheckChangeHasDescription(input_api, output_api))
     return results