commit a1d0db6496d14fdff62eb9474ba94ee67247f7a2
author Jeff Fisher <jeffish@microsoft.com> Wed Feb 20 18:56:14 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Wed Feb 20 18:56:14 2019 +0000
tree 36cb0a397b8d1d76710ae64b131820c772faa754
parent 2397c0203534363153fe53c7555428173d1d10c8

DevTools: Fix presubmit scripts on Windows

This fixes a couple presubmit issues when running on Windows:

* check_gn didn't properly normalize paths
* eslint didn't execute in node successfully since the bin style for the
npm install was unix specific (it's a CMD file on Windows)


Bug: 929919
Change-Id: Iec7e1057254047bd0a6539e16df964dc8a58d528
Reviewed-on: https://chromium-review.googlesource.com/c/1459576
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#633810}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d2dcac5ced285df053bc094b8e36d80a998f0079

scripts/local_node.py

diff --git a/scripts/local_node.py b/scripts/local_node.py
index 3054114..35ad2c9 100644
--- a/scripts/local_node.py
+++ b/scripts/local_node.py
@@ -11,8 +11,7 @@
 SCRIPTS_PATH = path.dirname(path.abspath(__file__))
 THIRD_PARTY_PATH = path.join(SCRIPTS_PATH, '..', '..', '..', '..')
 NODE_PATH = path.join(THIRD_PARTY_PATH, 'node')
-ESLINT_PATH = path.join(THIRD_PARTY_PATH, 'devtools-node-modules', 'third_party',
-                        'node_modules', '.bin', 'eslint')
+ESLINT_PATH = path.join(THIRD_PARTY_PATH, 'devtools-node-modules', 'third_party', 'node_modules', 'eslint', 'bin', 'eslint.js')
 
 try:
     old_sys_path = sys.path[:]