commit 9ff4da6ff0c95d9cee26c0468ed060278abb80a6
author Simon Zünd <szuend@chromium.org> Tue Nov 22 10:25:59 2022 +0100
committer Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 22 12:10:10 2022 +0000
tree 6f1c2f7dfb3a8c4a119c4a681052939421e5588a
parent 2d908a96e8cc09783bd7bf950fd1fcb18405d884

[l10n] Replace collect-strings.js with check-strings.js for PRESUBMIT

Now that we generate en-US.json/en-XL.json at build time, we can
adjust the presubmit script to use "check-strings.js" instead.

R=alexrudenko@chromium.org

Bug: 1185727
Change-Id: I827112dd7059e817d230e0aa342d32128826adea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4046521
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index fdb43c0..3e7849f 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -461,28 +461,25 @@
     return _ExecuteSubProcess(input_api, output_api, generate_protocol_resources_path, [], results)
 
 
-def _CollectStrings(input_api, output_api):
+def _CheckL10nStrings(input_api, output_api):
     devtools_root = input_api.PresubmitLocalPath()
     devtools_front_end = input_api.os_path.join(devtools_root, 'front_end')
     script_path = input_api.os_path.join(devtools_root, 'third_party', 'i18n',
-                                         'collect-strings.js')
+                                         'check-strings.js')
     affected_front_end_files = _getAffectedFiles(
         input_api, [devtools_front_end, script_path], [], ['.js', '.ts'])
     if len(affected_front_end_files) == 0:
         return [
             output_api.PresubmitNotifyResult(
-                'No affected files to run collect-strings')
+                'No affected files to run check-strings')
         ]
 
     results = [
-        output_api.PresubmitNotifyResult('Collecting strings from front_end:')
+        output_api.PresubmitNotifyResult('Checking UI strings from front_end:')
     ]
     results.extend(
         _checkWithNodeScript(input_api, output_api, script_path,
                              [devtools_front_end]))
-    results.append(
-        output_api.PresubmitNotifyResult(
-            'Please commit en-US.json/en-XL.json if changes are generated.'))
     return results
 
 
@@ -595,7 +592,7 @@
 def CheckChangeOnUpload(input_api, output_api):
     results = []
     results.extend(_CommonChecks(input_api, output_api))
-    results.extend(_CollectStrings(input_api, output_api))
+    results.extend(_CheckL10nStrings(input_api, output_api))
     # Run checks that rely on output from other DevTool checks
     results.extend(_SideEffectChecks(input_api, output_api))
     results.extend(_CheckBugAssociation(input_api, output_api, False))
@@ -605,7 +602,7 @@
 def CheckChangeOnCommit(input_api, output_api):
     results = []
     results.extend(_CommonChecks(input_api, output_api))
-    results.extend(_CollectStrings(input_api, output_api))
+    results.extend(_CheckL10nStrings(input_api, output_api))
     # Run checks that rely on output from other DevTool checks
     results.extend(_SideEffectChecks(input_api, output_api))
     results.extend(input_api.canned_checks.CheckChangeHasDescription(input_api, output_api))