commit 9bb1cf60250b61b9e7e7673146ae215e9cfd1d66
author Tim van der Lippe <tvanderlippe@chromium.org> Fri Mar 06 16:17:02 2020 +0000
committer Commit Bot <commit-bot@chromium.org> Mon Mar 09 10:58:12 2020 +0000
tree f38abc71c0982cb1ed39997c8bd9c075c7dcf569
parent 333ffc227428c6ec2090eaa70871890aa92d9e04

Add extra information for changed files check

This allows us to see which files are changed on bot runs, which eases
debugging.

R=changhaohan@chromium.org

Change-Id: Ic8d759f5c3126c9af05d0e4e98240de539844f76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2091451
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index d8d6982..51ac875 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -221,7 +221,15 @@
                                          stderr=input_api.subprocess.STDOUT)
     out, _ = process.communicate()
     if process.returncode != 0:
-        return [output_api.PresubmitError('You have changed files that need to be committed.')]
+        files_changed_process = input_api.subprocess.Popen(['git', 'diff', '--name-only'],
+                                                           stdout=input_api.subprocess.PIPE,
+                                                           stderr=input_api.subprocess.STDOUT)
+        files_changed, _ = files_changed_process.communicate()
+
+        return [
+            output_api.PresubmitError('You have changed files that need to be committed:'),
+            output_api.PresubmitError(files_changed)
+        ]
     return []
 
 def _CheckForTooLargeFiles(input_api, output_api):