Port linter check to Node
We ignore some files for ESLint, as they are either generated or
third_party. However, when someone tries to change these files,
ESLint would emit a warning stating that the file in question is
ignored.
This issue was reported to ESLint in https://github.com/eslint/eslint/issues/9977
The suggested workaround is to use the CLIEngine to filter out
the problematic paths. However, since our script was written in
Python, that API is not accessible to us.
Therefore rewrite the script to Node and filter out the problematic
files. The calls to CLIEngine were mostly taken from eslint/lib/cli.js,
which was the previous file used by `node_modules/bin/eslint`.
R=jacktfranklin@chromium.org
CC=sigurds@chromium.org
Change-Id: Iee600f0e0d99fcb6eeeb203a952a50fe35f9aaf3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2149316
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3652d86..14baa01 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -147,7 +147,7 @@
def _CheckDevtoolsStyle(input_api, output_api):
results = [output_api.PresubmitNotifyResult('Running Devtools Style Check:')]
- lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(), 'scripts', 'test', 'run_lint_check.py')
+ lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(), 'scripts', 'test', 'run_lint_check.js')
front_end_directory = input_api.os_path.join(input_api.PresubmitLocalPath(), 'front_end')
test_directory = input_api.os_path.join(input_api.PresubmitLocalPath(), 'test')
@@ -160,6 +160,7 @@
input_api.os_path.join(input_api.PresubmitLocalPath(), '.eslintrc.js'),
input_api.os_path.join(input_api.PresubmitLocalPath(), '.eslintignore'),
input_api.os_path.join(scripts_directory, 'test', 'run_lint_check.py'),
+ input_api.os_path.join(scripts_directory, 'test', 'run_lint_check.js'),
input_api.os_path.join(scripts_directory, '.eslintrc.js'),
input_api.os_path.join(scripts_directory, 'eslint_rules'),
]
@@ -180,7 +181,8 @@
results.append(output_api.PresubmitNotifyResult('No affected files for ESLint check'))
return results
- return _ExecuteSubProcess(input_api, output_api, lint_path, affected_files, results)
+ results.extend(_checkWithNodeScript(input_api, output_api, lint_path, affected_files))
+ return results
def _CheckOptimizeSVGHashes(input_api, output_api):